[PATCH] x86/MCE: Statically allocate mce_banks_array

2019-05-23 Thread Ghannam, Yazen
From: Yazen Ghannam The MCE control data is stored in an array of struct mce_banks. This array has historically been shared by all CPUs and it was allocated dynamically during the first CPU's init sequence. However, starting with 5b0883f5c7be ("x86/MCE: Make mce_banks a per-CPU array")

Re: [PATCH v4 0/1] Use HMM for ODP v4

2019-05-23 Thread Jerome Glisse
On Wed, May 22, 2019 at 08:57:37PM -0300, Jason Gunthorpe wrote: > On Wed, May 22, 2019 at 01:48:52PM -0400, Jerome Glisse wrote: > > > > > So attached is a rebase on top of 5.2-rc1, i have tested with pingpong > > > > (prefetch and not and different sizes). Seems to work ok. > > > > > > Urk, it

[PATCH v5 0/4] Allwinner H6 watchdog support

2019-05-23 Thread Clément Péron
Hi, Allwinner H6 SoC has two watchdogs. As we are not sure that both A64 and H6 are stricly identical, I have introduced the H6 bindings. After investigation it seems that on some boards the first watchdog doesn't make it properly reboot. Please see details in the commit log. I think it's prope

Re: [RFC][PATCH] kernel.h: Add generic roundup_64() macro

2019-05-23 Thread Linus Torvalds
On Thu, May 23, 2019 at 7:00 AM Steven Rostedt wrote: > > +# define roundup_64(x, y) (\ > +{ \ > + typeof(y) __y = y; \ > + typeof(x) __x = (x) + (__y - 1);\ >

[PATCH v5 4/4] arm64: defconfig: enable sunxi watchdog

2019-05-23 Thread Clément Péron
The SUNXI_WATCHDOG option is required to make the watchdog available on Allwinner H6. Enable this option as a module. Signed-off-by: Clément Péron --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig ind

[PATCH v5 2/4] arm64: dts: allwinner: h6: add watchdog node

2019-05-23 Thread Clément Péron
Allwinner H6 has a watchog node which seems broken on some boards. Test has been performed on several boards. Chen-Yu Tsai boards: Pine H64 - H6448BA 7782 => OK OrangePi Lite 2 - H8068BA 61C2 => KO Martin Ayotte boards: Pine H64 - H8069BA 6892 => OK OrangePi 3 - HA047BA 69W2 => KO OrangePi One P

[PATCH v5 3/4] arm64: dts: allwinner: h6: add r_watchog node

2019-05-23 Thread Clément Péron
Allwinner H6 has a r_watchdog similar to A64. Declare it in the device-tree. Signed-off-by: Clément Péron --- arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h6.dtsi b/arch/arm64/boot/dts/allwinner/sun

[PATCH v5 1/4] dt-bindings: watchdog: add Allwinner H6 watchdog

2019-05-23 Thread Clément Péron
Allwinner H6 has a similar watchdog as the A64 which is already a compatible of the A31. This commit add the H6 compatible. Signed-off-by: Clément Péron --- Documentation/devicetree/bindings/watchdog/sunxi-wdt.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bind

Re: [PATCH v7 3/4] arm64: dts: qcom: Add AOSS QMP node

2019-05-23 Thread Doug Anderson
Hi, On Tue, Apr 30, 2019 at 9:37 PM Bjorn Andersson wrote: > > The AOSS QMP provides a number of power domains, used for QDSS and > PIL, add the node for this. > > Tested-by: Sibi Sankar > Reviewed-by: Sibi Sankar > Signed-off-by: Bjorn Andersson > --- > > Changes since v6: > - Added #clock-ce

Re: [PATCH] fanotify: remove redundant capable(CAP_SYS_ADMIN)s

2019-05-23 Thread Amir Goldstein
On Thu, May 23, 2019 at 5:40 PM Jan Kara wrote: > > On Thu 23-05-19 15:35:18, Christian Brauner wrote: > > So let's say the user tells me: > > - When the "/A/B/C/target" file appears on the host filesystem, > > please give me access to "target" in the container at a path I tell > > you. > > Wh

[PATCH 0/9] keys: Namespacing [ver #3]

2019-05-23 Thread David Howells
Here are some patches to make keys and keyrings more namespace aware. Note that the branch is dependent on security/next-general. Firstly some miscellaneous patches to make the process easier: (1) Simplify key index_key handling so that the word-sized chunks assoc_array requires don't ha

[PATCH 1/9] keys: Simplify key description management [ver #3]

2019-05-23 Thread David Howells
Simplify key description management by cramming the word containing the length with the first few chars of the description also. This simplifies the code that generates the index-key used by assoc_array. It should speed up key searching a bit too. Signed-off-by: David Howells --- include/linu

[PATCH 2/9] keys: Cache the hash value to avoid lots of recalculation [ver #3]

2019-05-23 Thread David Howells
Cache the hash of the key's type and description in the index key so that we're not recalculating it every time we look at a key during a search. The hash function does a bunch of multiplications, so evading those is probably worthwhile - especially as this is done for every key examined during a s

[PATCH 3/9] keys: Add a 'recurse' flag for keyring searches [ver #3]

2019-05-23 Thread David Howells
Add a 'recurse' flag for keyring searches so that the flag can be omitted and recursion disabled, thereby allowing just the nominated keyring to be searched and none of the children. Signed-off-by: David Howells --- Documentation/security/keys/core.rst | 10 ++ certs/blacklist.c

[PATCH 5/9] keys: Move the user and user-session keyrings to the user_namespace [ver #3]

2019-05-23 Thread David Howells
Move the user and user-session keyrings to the user_namespace struct rather than pinning them from the user_struct struct. This prevents these keyrings from propagating across user-namespaces boundaries with regard to the KEY_SPEC_* flags, thereby making them more useful in a containerised environ

[PATCH 7/9] keys: Garbage collect keys for which the domain has been removed [ver #3]

2019-05-23 Thread David Howells
If a key operation domain (such as a network namespace) has been removed then attempt to garbage collect all the keys that use it. Signed-off-by: David Howells --- include/linux/key.h |2 ++ security/keys/internal.h |3 ++- security/keys/keyring.c | 15 +++ 3 files c

[PATCH 4/9] keys: Namespace keyring names [ver #3]

2019-05-23 Thread David Howells
Keyring names are held in a single global list that any process can pick from by means of keyctl_join_session_keyring (provided the keyring grants Search permission). This isn't very container friendly, however. Make the following changes: (1) Make default session, process and thread keyring na

[PATCH 6/9] keys: Include target namespace in match criteria [ver #3]

2019-05-23 Thread David Howells
Currently a key has a standard matching criteria of { type, description } and this is used to only allow keys with unique criteria in a keyring. This means, however, that you cannot have keys with the same type and description but a different target namespace in the same keyring. This is a potent

[PATCH 8/9] keys: Network namespace domain tag [ver #3]

2019-05-23 Thread David Howells
Create key domain tags for network namespaces and make it possible to automatically tag keys that are used by networked services (e.g. AF_RXRPC, AFS, DNS) with the default network namespace if not set by the caller. This allows keys with the same description but in different namespaces to coexist

[PATCH 9/9] keys: Pass the network namespace into request_key mechanism [ver #3]

2019-05-23 Thread David Howells
Create a request_key_net() function and use it to pass the network namespace domain tag into DNS revolver keys and rxrpc/AFS keys so that keys for different domains can coexist in the same keyring. Signed-off-by: David Howells cc: net...@vger.kernel.org cc: linux-...@vger.kernel.org cc: linux-c..

Re: [PATCH] staging/gasket: Fix string split

2019-05-23 Thread Dan Carpenter
On Thu, May 23, 2019 at 05:11:56PM +0200, 李天正 wrote: > Hello, > we are doing a project in the university and we cooperated to make this > patch. Some warnings are found by Mr.Zhang. Use the Reported-by to show who found the bug or Co-developed-by: if you both wrote code. regards, dan carpenter

Re: [RFC PATCH] rcu: Make 'rcu_assign_pointer(p, v)' of type 'typeof(p)'

2019-05-23 Thread Paul E. McKenney
On Thu, May 23, 2019 at 03:19:19PM +0100, Mark Rutland wrote: > On Thu, May 23, 2019 at 06:50:13AM -0700, Paul E. McKenney wrote: > > On Thu, May 23, 2019 at 03:32:20PM +0200, Andrea Parri wrote: > > > The expression > > > > > > rcu_assign_pointer(p, typeof(p) v) > > > > > > is reported to be o

Re: Getting empty callchain from perf_callchain_kernel()

2019-05-23 Thread Josh Poimboeuf
On Thu, May 23, 2019 at 10:50:24PM +0800, Kairui Song wrote: > > > Hi Josh, this still won't fix the problem. > > > > > > Problem is not (or not only) with ___bpf_prog_run, what actually went > > > wrong is with the JITed bpf code. > > > > There seem to be a bunch of issues. My patch at least fixe

RE: [PATCH][next] scsi: hpsa: fix an uninitialized read and dereference of pointer dev

2019-05-23 Thread Don.Brace
Original Message- From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi-ow...@vger.kernel.org] On Behalf Of Colin King Sent: Wednesday, May 22, 2019 3:39 AM To: Don Brace ; James E . J . Bottomley ; Martin K . Petersen ; esc.storage...@microsemi.com; linux-s...@vger.kernel.org Cc: ke

[PATCH v2 5.2] rsi: Properly initialize data in rsi_sdio_ta_reset

2019-05-23 Thread Nathan Chancellor
When building with -Wuninitialized, Clang warns: drivers/net/wireless/rsi/rsi_91x_sdio.c:940:43: warning: variable 'data' is uninitialized when used here [-Wuninitialized] put_unaligned_le32(TA_HOLD_THREAD_VALUE, data); ^~~~ drivers/net/wire

Re: [PATCH v4 00/30] coresight: Support for ACPI bindings

2019-05-23 Thread Suzuki K Poulose
Hi Leo, On 23/05/2019 15:32, Leo Yan wrote: Hi Suzuki, On Wed, May 22, 2019 at 11:34:33AM +0100, Suzuki K Poulose wrote: [...] Changes since v2: - Drop the patches exposing device links via sysfs, to be posted as separate series. Thanks for sharing the git tree linkage in another ema

Re: [PATCH 1/1] infiniband/mm: convert put_page() to put_user_page*()

2019-05-23 Thread Jerome Glisse
On Thu, May 23, 2019 at 12:25:37AM -0700, john.hubb...@gmail.com wrote: > From: John Hubbard > > For infiniband code that retains pages via get_user_pages*(), > release those pages via the new put_user_page(), or > put_user_pages*(), instead of put_page() > > This is a tiny part of the second st

[GIT PULL] xfs: fixes for 5.2

2019-05-23 Thread Darrick J. Wong
Hi Linus, Here's a bug fix for a minor accounting problem reported by a user. It's survived a few days of fstests and merges cleanly with upstream as of a few minutes ago. Let me know if there are problems. (Urgh, I just noticed that the tag message lists the wrong version. If that's going to b

Re: [RFC 1/2] clocksource: davinci-timer: add support for clockevents

2019-05-23 Thread Bartosz Golaszewski
czw., 23 maj 2019 o 15:25 Daniel Lezcano napisał(a): > > > Hi Bartosz, > > > > On 23/05/2019 14:58, Bartosz Golaszewski wrote: > > [ ... ] > > >>> +++ b/drivers/clocksource/timer-davinci.c > >>> @@ -0,0 +1,272 @@ > >>> +// SPDX-License-Identifier: GPL-2.0-only > >>> +// > >>> +// TI DaVinci clocks

Re: [PATCH][next] scsi: hpsa: fix an uninitialized read and dereference of pointer dev

2019-05-23 Thread Nathan Chancellor
On Wed, May 22, 2019 at 09:39:03AM +0100, Colin King wrote: > From: Colin Ian King > > Currently the check for a lockup_detected failure exits via the > label return_reset_status that reads and dereferences an uninitialized > pointer dev. Fix this by ensuring dev is inintialized to null. > > Ad

Re: [PATCH v9 0/4] vfio: ap: AP Queue Interrupt Control

2019-05-23 Thread Tony Krowiak
On 5/21/19 11:34 AM, Pierre Morel wrote: This patch series implements PQAP/AQIC interception in KVM. 1) Data to handle GISA interrupt for AQIC To implement this we need to add a new structure, vfio_ap_queue, to be able to retrieve the mediated device associated with a queue and specific values

Re: SGX vs LSM (Re: [PATCH v20 00/28] Intel SGX1 support)

2019-05-23 Thread Andy Lutomirski
On Thu, May 23, 2019 at 7:17 AM Sean Christopherson wrote: > > On Thu, May 23, 2019 at 01:26:28PM +0300, Jarkko Sakkinen wrote: > > On Wed, May 22, 2019 at 07:35:17PM -0700, Sean Christopherson wrote: > > > But actually, there's no need to disallow mmap() after ECREATE since the > > > LSM checks a

Re: [PATCH v4 0/1] Use HMM for ODP v4

2019-05-23 Thread Jason Gunthorpe
On Thu, May 23, 2019 at 11:04:32AM -0400, Jerome Glisse wrote: > On Wed, May 22, 2019 at 08:57:37PM -0300, Jason Gunthorpe wrote: > > On Wed, May 22, 2019 at 01:48:52PM -0400, Jerome Glisse wrote: > > > > > > > So attached is a rebase on top of 5.2-rc1, i have tested with pingpong > > > > > (prefe

Re: [PATCH] rtc: ds2404: use hw endiannes variable

2019-05-23 Thread Alexandre Belloni
On 09/05/2019 04:13:55+0200, Nicholas Mc Guire wrote: > Converting from hardware to host endiannes was done using reassignment > to the same variable which makes sparse unhappy as it can not verify > the endiannes handling properly. To allow sparse to verify endiannes > handling an explicit __le32

Re: [PATCH v9 3/4] s390: ap: implement PAPQ AQIC interception in kernel

2019-05-23 Thread Tony Krowiak
On 5/21/19 11:34 AM, Pierre Morel wrote: We register a AP PQAP instruction hook during the open of the mediated device. And unregister it on release. During the probe of the AP device, we allocate a vfio_ap_queue structure to keep track of the information we need for the PQAP/AQIC instruction in

Re: [PATCH v15 00/17] arm64: untag user pointers passed to the kernel

2019-05-23 Thread enh
On Thu, May 23, 2019 at 7:45 AM Catalin Marinas wrote: > > On Wed, May 22, 2019 at 01:47:36PM -0700, Kees Cook wrote: > > On Wed, May 22, 2019 at 05:35:27PM +0100, Catalin Marinas wrote: > > > The two hard requirements I have for supporting any new hardware feature > > > in Linux are (1) a single

Re: [PATCH v2] rtc: test: enable wakeup flags

2019-05-23 Thread Alexandre Belloni
On 15/05/2019 17:20:22+0300, roman.stratiie...@globallogic.com wrote: > From: Roman Stratiienko > > Alarmtimer interface uses only the RTC with wekeup flags enabled. > Allow to use rtc-test driver with alarmtimer interface. > > Signed-off-by: Roman Stratiienko > > --- > Changes in v2: > > Wak

[PATCH] staging/gasket: Fix string split

2019-05-23 Thread Tianzheng Li
This patch removes unnecessary quoted string splits. Reported-by: Jie Zhang Signed-off-by: Tianzheng Li --- drivers/staging/gasket/gasket_core.c | 6 ++ drivers/staging/gasket/gasket_ioctl.c | 3 +-- drivers/staging/gasket/gasket_page_table.c | 14 ++ 3 files change

Re: [PATCH] mmc: meson-gx: fix irq ack

2019-05-23 Thread Kevin Hilman
Jerome Brunet writes: > While cleaning the ISR of the meson-gx and acking only raised irqs, > the ack of the irq was moved at the very last stage of the function. > > This was stable during the initial tests but it triggered issues with > hs200, under specific loads (like booting android). Acking

Re: [PATCH v4 0/1] Use HMM for ODP v4

2019-05-23 Thread Jerome Glisse
On Thu, May 23, 2019 at 12:41:49PM -0300, Jason Gunthorpe wrote: > On Thu, May 23, 2019 at 11:04:32AM -0400, Jerome Glisse wrote: > > On Wed, May 22, 2019 at 08:57:37PM -0300, Jason Gunthorpe wrote: > > > On Wed, May 22, 2019 at 01:48:52PM -0400, Jerome Glisse wrote: > > > > > > > > > So attached

Re: [PATCH 1/2] dt-bindings: arm: Document 96Boards Meerkat96 devicetree binding

2019-05-23 Thread Rob Herring
On Wed, May 22, 2019 at 8:16 AM Manivannan Sadhasivam wrote: > > Document 96Boards Meerkat96 devicetree binding based on i.MX7D SoC. > > Signed-off-by: Manivannan Sadhasivam > --- > Documentation/devicetree/bindings/arm/fsl.yaml | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Rob Herring

[PATCH] ASoC: SOF: Use struct_size() in kmemdup()

2019-05-23 Thread Gustavo A. R. Silva
Make use of the struct_size() helper instead of an open-coded version in order to avoid any potential type mistakes, in particular in the context in which this code is being used. So, replace code of the following form: sizeof(*w) + sizeof(struct sof_ipc_window_elem) * w->num_windows with: stru

[PATCH 0/2] keys: ACLs

2019-05-23 Thread David Howells
Here are some patches to change the permissions model used by keys and keyrings to be based on an ACL: (1) Replace the permissions mask internally with an ACL that contains a list of ACEs, each with a specific subject with a permissions mask. Potted default ACLs are available for new

[PATCH 1/2] KEYS: Replace uid/gid/perm permissions checking with an ACL

2019-05-23 Thread David Howells
Replace the uid/gid/perm permissions checking on a key with an ACL to allow the SETATTR and SEARCH permissions to be split. This will also allow a greater range of subjects to represented. WHY DO THIS? The problem is that SETATTR and SEARCH cover a slew of actions, not

[PATCH 2/2] KEYS: Provide KEYCTL_GRANT_PERMISSION

2019-05-23 Thread David Howells
Provide a keyctl() operation to grant/remove permissions. The grant operation, wrapped by libkeyutils, looks like: int ret = keyctl_grant_permission(key_serial_t key, enum key_ace_subject_type type, unsign

Re: [PATCH v2 4/4] dt-bindings: interconnect: qcs404: Introduce qcom,qos DT property

2019-05-23 Thread Georgi Djakov
Hi Bjorn and Rob, On 4/19/19 01:51, Bjorn Andersson wrote: > On Mon 15 Apr 03:43 PDT 2019, Georgi Djakov wrote: > >> There are separate hardware blocks per each interconnect that allow QoS >> configuration to be applied to each port (node). There are different kinds of >> priorities that could be

[PATCH v4 2/2] tty: add rpmsg driver

2019-05-23 Thread Arnaud Pouliquen
This driver exposes a standard tty interface on top of the rpmsg framework through the "rpmsg-tty-channel" rpmsg service. This driver supports multi-instances, offering a /dev/ttyRPMSGx entry per rpmsg endpoint. Signed-off-by: Arnaud Pouliquen Signed-off-by: Fabien Dessenne --- Documentation/s

[PATCH v4 1/2] rpmsg: core: add possibility to get message payload length

2019-05-23 Thread Arnaud Pouliquen
Return the rpmsg buffer payload size for sending message, so rpmsg users can split a long message in several sub rpmsg buffers. Signed-off-by: Arnaud Pouliquen Signed-off-by: Fabien Dessenne --- drivers/rpmsg/rpmsg_core.c | 20 drivers/rpmsg/rpmsg_internal.h | 2 ++

[PATCH v4 0/2] TTY: add rpmsg tty driver

2019-05-23 Thread Arnaud Pouliquen
This patch set introduces a TTY console on top of the RPMsg framework which enables the following use cases: - Provide a console to communicate easily with the remote processor application. - Provide an interface to get the remote processor log traces without ring buffer limitation. - Ease the

[PATCH] ASoC: qdsp6: q6core: Use struct_size() in kmemdup()

2019-05-23 Thread Gustavo A. R. Silva
Make use of the struct_size() helper instead of an open-coded version in order to avoid any potential type mistakes, in particular in the context in which this code is being used. So, replace code of the following form: sizeof(*fwk) + fwk->num_services * sizeof(fwk->svc_api_info[0]); with: stru

Re: [PATCH net-next 00/18] net: stmmac: Improvements and Selftests

2019-05-23 Thread David Miller
From: Jose Abreu Date: Thu, 23 May 2019 09:36:50 +0200 > [ Thanks to the introducion of selftests this series ended up being a misc > of improvements and the selftests additions per-se. ] > > This introduces selftests support in stmmac driver. We add 9 basic sanity > checks and MAC loopback supp

Re: [PATCH v2 0/7] mm: process_vm_mmap() -- syscall for duplication a process mapping

2019-05-23 Thread Kirill Tkhai
On 22.05.2019 18:22, Kirill A. Shutemov wrote: > On Mon, May 20, 2019 at 05:00:01PM +0300, Kirill Tkhai wrote: >> This patchset adds a new syscall, which makes possible >> to clone a VMA from a process to current process. >> The syscall supplements the functionality provided >> by process_vm_writev

[REVIEW][PATCHv2 03/26] signal/arm64: Use force_sig not force_sig_fault for SIGKILL

2019-05-23 Thread Eric W. Biederman
I don't think this is userspace visible but SIGKILL does not have any si_codes that use the fault member of the siginfo union. Correct this the simple way and call force_sig instead of force_sig_fault when the signal is SIGKILL. The two know places where synchronous SIGKILL are generated are do

Re: [REVIEW][PATCH 03/26] signal/arm64: Use force_sig not force_sig_fault for SIGKILL

2019-05-23 Thread Dave P Martin
On Thu, May 23, 2019 at 03:53:06PM +0100, Eric W. Biederman wrote: > Dave Martin writes: > > > On Thu, May 23, 2019 at 01:38:53AM +0100, Eric W. Biederman wrote: > >> It really only matters to debuggers but the SIGKILL does not have any > >> si_codes that use the fault member of the siginfo union.

[PATCH v3] mm: Rename mm_vmscan_lru_shrink_inactive trace event variables

2019-05-23 Thread Kirill Tkhai
Rename nr_activate{0,1} into nr_activate_{anon,file} since this is exported into userspace, e.g., it's shown here: /sys/kernel/debug/tracing/events/vmscan/mm_vmscan_lru_shrink_inactive/format v3: Fix comment v2: Changed suggested person Suggested-by: Mathieu Desnoyers Signed-off-by: Kirill Tkha

Re: [PATCH 1/3] arm64: dts: meson: g12a: add drive-strength hdmi ddc pins

2019-05-23 Thread Kevin Hilman
Martin Blumenstingl writes: > On Mon, May 20, 2019 at 3:48 PM Neil Armstrong > wrote: >> >> With the default boot settings, the DDC drive strength is too weak, >> set the driver-strengh to 4mA to avoid errors on the DDC line. >> >> Signed-off-by: Neil Armstrong > Amlogic's vendor kernel (from

Re: [PATCH 2/3] arm64: dts: meson: g12a: add drive strength for eth pins

2019-05-23 Thread Kevin Hilman
Martin Blumenstingl writes: > On Mon, May 20, 2019 at 3:48 PM Neil Armstrong > wrote: >> >> With the X96 Max board using an external Gigabit Ethernet PHY, >> add the same driver strength to the Ethernet pins as the vendor >> tree. >> >> Signed-off-by: Neil Armstrong > Amlogic's vendor kernel (

Re: [PATCH 3/3] arm64: dts: meson: g12a: Add hwrng node

2019-05-23 Thread Kevin Hilman
Neil Armstrong writes: > On 20/05/2019 19:45, Martin Blumenstingl wrote: >> Hi Neil, >> >> On Mon, May 20, 2019 at 3:49 PM Neil Armstrong >> wrote: >>> >>> The Amlogic G12A has the hwrng module in an unknown "EFUSE" bus. >>> >>> The hwrng is not enabled on the vendor G12A DTs, but is enabled o

Re: [PATCH net] net: mvpp2: cls: Fix leaked ethtool_rx_flow_rule

2019-05-23 Thread David Miller
From: Maxime Chevallier Date: Thu, 23 May 2019 10:47:24 +0200 > The flow_rule is only used when configuring the classification tables, > and should be free'd once we're done using it. The current code only > frees it in the error path. > > Fixes: 90b509b39ac9 ("net: mvpp2: cls: Add Classificatio

Re: [REVIEW][PATCHv2 03/26] signal/arm64: Use force_sig not force_sig_fault for SIGKILL

2019-05-23 Thread Will Deacon
On Thu, May 23, 2019 at 11:11:19AM -0500, Eric W. Biederman wrote: > diff --git a/arch/arm64/kernel/traps.c b/arch/arm64/kernel/traps.c > index ade32046f3fe..e45d5b440fb1 100644 > --- a/arch/arm64/kernel/traps.c > +++ b/arch/arm64/kernel/traps.c > @@ -256,7 +256,10 @@ void arm64_force_sig_fault(int

[PATCH 00/23] nfs: Mount API conversion

2019-05-23 Thread David Howells
Hi Trond, Anna, Here's a set of patches that converts NFS to use the mount API. Note that there are a lot of preliminary patches, some from me and some from Al. The actual conversion is done by the final patch. I've rebased them on 5.2-rc1. Do you want them basing on something else? The pat

[PATCH 02/23] nfs: stash server into struct nfs_mount_info

2019-05-23 Thread David Howells
From: Al Viro Reviewed-by: David Howells Signed-off-by: Al Viro --- fs/nfs/internal.h |3 ++- fs/nfs/nfs4super.c | 10 -- fs/nfs/super.c | 19 --- 3 files changed, 14 insertions(+), 18 deletions(-) diff --git a/fs/nfs/internal.h b/fs/nfs/internal.h index

[PATCH 01/23] saner calling conventions for nfs_fs_mount_common()

2019-05-23 Thread David Howells
From: Al Viro Allow it to take ERR_PTR() for server and return ERR_CAST() of it in such case. All callers used to open-code that... Reviewed-by: David Howells Signed-off-by: Al Viro --- fs/nfs/nfs4super.c | 16 +--- fs/nfs/super.c | 11 --- 2 files changed, 5 ins

[PATCH 03/23] nfs: lift setting mount_info from nfs4_remote{, _referral}_mount

2019-05-23 Thread David Howells
From: Al Viro Do that (fhandle allocation, setting struct server up) in nfs4_referral_mount() and nfs4_try_mount() resp. and pass the server and pointer to mount_info into nfs_do_root_mount() so that nfs4_remote_referral_mount()/nfs_remote_mount() could be merged. Since we are moving stuff from

[PATCH 04/23] nfs: fold nfs4_remote_fs_type and nfs4_remote_referral_fs_type

2019-05-23 Thread David Howells
From: Al Viro They are identical now. Reviewed-by: David Howells Signed-off-by: Al Viro --- fs/nfs/nfs4super.c | 26 -- 1 file changed, 4 insertions(+), 22 deletions(-) diff --git a/fs/nfs/nfs4super.c b/fs/nfs/nfs4super.c index 71a970ca3fb7..5d02925e3567 100644 ---

[PATCH 05/23] nfs: don't bother setting/restoring export_path around do_nfs_root_mount()

2019-05-23 Thread David Howells
From: Al Viro nothing in it will be looking at that thing anyway Reviewed-by: David Howells Signed-off-by: Al Viro --- fs/nfs/nfs4super.c |4 1 file changed, 4 deletions(-) diff --git a/fs/nfs/nfs4super.c b/fs/nfs/nfs4super.c index 5d02925e3567..d498aa5acab0 100644 --- a/fs/nfs/nfs

[PATCH 08/23] nfs: stash nfs_subversion reference into nfs_mount_info

2019-05-23 Thread David Howells
From: Al Viro That will allow to get rid of passing those references around in quite a few places. Moreover, that will allow to merge xdev and remote file_system_type. Reviewed-by: David Howells Signed-off-by: Al Viro --- fs/nfs/internal.h |1 + fs/nfs/namespace.c |6 +++--- fs/nfs

[PATCH 09/23] nfs: don't bother passing nfs_subversion to ->try_mount() and nfs_fs_mount_common()

2019-05-23 Thread David Howells
From: Al Viro Reviewed-by: David Howells Signed-off-by: Al Viro --- fs/nfs/internal.h |6 ++ fs/nfs/nfs4_fs.h|2 +- fs/nfs/nfs4super.c |5 ++--- fs/nfs/super.c | 19 --- include/linux/nfs_xdr.h |3 +-- 5 files changed, 14 inser

[PATCH 07/23] nfs: lift setting mount_info from nfs_xdev_mount()

2019-05-23 Thread David Howells
From: Al Viro Do it in nfs_do_submount() instead. As a side benefit, nfs_clone_data doesn't need ->fh and ->fattr anymore. Reviewed-by: David Howells Signed-off-by: Al Viro --- fs/nfs/internal.h |3 +-- fs/nfs/namespace.c | 35 +-- fs/nfs/super.c |

[PATCH 06/23] nfs4: fold nfs_do_root_mount/nfs_follow_remote_path

2019-05-23 Thread David Howells
From: Al Viro Reviewed-by: David Howells Signed-off-by: Al Viro --- fs/nfs/nfs4super.c | 88 ++-- 1 file changed, 37 insertions(+), 51 deletions(-) diff --git a/fs/nfs/nfs4super.c b/fs/nfs/nfs4super.c index d498aa5acab0..1710df8240fb 100644 -

[PATCH 11/23] nfs: unexport nfs_fs_mount_common()

2019-05-23 Thread David Howells
From: Al Viro Make it static, even. And remove a stale extern of (long-gone) nfs_xdev_mount_common() from internal.h, while we are at it. Reviewed-by: David Howells Signed-off-by: Al Viro --- fs/nfs/internal.h |3 --- fs/nfs/super.c|5 +++-- 2 files changed, 3 insertions(+), 5 d

[PATCH 10/23] nfs: merge xdev and remote file_system_type

2019-05-23 Thread David Howells
From: Al Viro they are identical now... Reviewed-by: David Howells Signed-off-by: Al Viro --- fs/nfs/internal.h |2 +- fs/nfs/namespace.c |2 +- fs/nfs/nfs4super.c | 22 +- fs/nfs/super.c | 14 -- 4 files changed, 11 insertions(+), 29 deletion

[PATCH 12/23] nfs: don't pass nfs_subversion to ->create_server()

2019-05-23 Thread David Howells
From: Al Viro pick it from mount_info Reviewed-by: David Howells Signed-off-by: Al Viro --- fs/nfs/client.c |4 ++-- fs/nfs/internal.h |7 ++- fs/nfs/nfs3_fs.h|2 +- fs/nfs/nfs3client.c |5 ++--- fs/nfs/nfs4client.c |3 +-- fs/nfs/nfs4sup

[PATCH 14/23] nfs_clone_sb_security(): simplify the check for server bogosity

2019-05-23 Thread David Howells
From: Al Viro We used to check ->i_op for being nfs_dir_inode_operations. With separate inode_operations for v3 and v4 that became bogus, but rather than going for protocol-dependent comparison we could've just checked ->i_fop instead; _that_ is the same for all protocol versions. Reviewed-by:

[PATCH 15/23] nfs: get rid of ->set_security()

2019-05-23 Thread David Howells
From: Al Viro it's always either nfs_set_sb_security() or nfs_clone_sb_security(), the choice being controlled by mount_info->cloned != NULL. No need to add methods, especially when both instances live right next to the caller and are never accessed anywhere else. Reviewed-by: David Howells Si

[PATCH 13/23] nfs: get rid of mount_info ->fill_super()

2019-05-23 Thread David Howells
From: Al Viro The only possible values are nfs_fill_super and nfs_clone_super. The latter is used only when crossing into a submount and it is almost identical to the former; the only differences are * ->s_time_gran unconditionally set to 1 (even for v2 mounts). Regression dating back to

Re: [PATCH net-next 00/18] net: stmmac: Improvements and Selftests

2019-05-23 Thread David Miller
From: David Miller Date: Thu, 23 May 2019 09:09:28 -0700 (PDT) > Series applied. I'm reverting, this doesn't even build. ERROR: "dev_set_rx_mode" [drivers/net/ethernet/stmicro/stmmac/stmmac.ko] undefined! make[1]: *** [scripts/Makefile.modpost:91: __modpost] Error 1 make: *** [Makefile:1290: m

[PATCH 16/23] NFS: Move mount parameterisation bits into their own file

2019-05-23 Thread David Howells
Split various bits relating to mount parameterisation out from fs/nfs/super.c into their own file to form the basis of filesystem context handling for NFS. No other changes are made to the code beyond removing 'static' qualifiers. Signed-off-by: David Howells Signed-off-by: Al Viro --- fs/nfs

[PATCH 17/23] NFS: Constify mount argument match tables

2019-05-23 Thread David Howells
The mount argument match tables should never be altered so constify them. Signed-off-by: David Howells Signed-off-by: Al Viro --- fs/nfs/fs_context.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/fs/nfs/fs_context.c b/fs/nfs/fs_context.c index 9711a2c7b479..265c2

[PATCH 18/23] NFS: Rename struct nfs_parsed_mount_data to struct nfs_fs_context

2019-05-23 Thread David Howells
Rename struct nfs_parsed_mount_data to struct nfs_fs_context and rename pointers to it to "ctx". At some point this will be pointed to by an fs_context struct's fs_private pointer. Signed-off-by: David Howells Signed-off-by: Al Viro --- fs/nfs/client.c | 64 --- fs/nfs/fs_context.c

[PATCH 19/23] NFS: Split nfs_parse_mount_options()

2019-05-23 Thread David Howells
Split nfs_parse_mount_options() to move the prologue, list-splitting and epilogue into one function and the per-option processing into another. Signed-off-by: David Howells Signed-off-by: Al Viro --- fs/nfs/fs_context.c | 126 --- fs/nfs/interna

[PATCH 20/23] NFS: Deindent nfs_fs_context_parse_option()

2019-05-23 Thread David Howells
Deindent nfs_fs_context_parse_option(). Signed-off-by: David Howells Signed-off-by: Al Viro --- fs/nfs/fs_context.c | 729 +-- 1 file changed, 362 insertions(+), 367 deletions(-) diff --git a/fs/nfs/fs_context.c b/fs/nfs/fs_context.c index f4e0

[PATCH 22/23] NFS: Do some tidying of the parsing code

2019-05-23 Thread David Howells
Do some tidying of the parsing code, including: (*) Returning 0/error rather than true/false. (*) Putting the nfs_fs_context pointer first in some arg lists. (*) Unwrap some lines that will now fit on one line. (*) Provide unioned sockaddr/sockaddr_storage fields to avoid casts. (*) nfs_p

RE: [PATCH v2] signal: Adjust error codes according to restore_user_sigmask()

2019-05-23 Thread David Laight
From: Oleg Nesterov > On 05/23, David Laight wrote: > > > > I'm confused... > > Me too. To clarify, the current code is obviously buggy, pselect/whatever > shouldn't return 0 (or anything else) if it was interrupted and we are going > to deliver the signal. If it was interrupted the return value

[PATCH 21/23] NFS: Add a small buffer in nfs_fs_context to avoid string dup

2019-05-23 Thread David Howells
Add a small buffer in nfs_fs_context to avoid string duplication when parsing numbers. Also make the parsing function wrapper place the parsed integer directly in the appropriate nfs_fs_context struct member. Signed-off-by: David Howells Signed-off-by: Al Viro --- fs/nfs/fs_context.c | 82 +

Re: [PATCH v2 0/7] mm: process_vm_mmap() -- syscall for duplication a process mapping

2019-05-23 Thread Andy Lutomirski
On Tue, May 21, 2019 at 10:44 AM Kirill Tkhai wrote: > > On 21.05.2019 19:43, Andy Lutomirski wrote: > > On Tue, May 21, 2019 at 8:52 AM Kirill Tkhai wrote: > >> > >> On 21.05.2019 17:43, Andy Lutomirski wrote: > > Do you mean that the code you sent rejects this case? If so, please > > document

[PATCH 23/23] NFS: Add fs_context support.

2019-05-23 Thread David Howells
Add filesystem context support to NFS, parsing the options in advance and attaching the information to struct nfs_fs_context. The highlights are: (*) Merge nfs_mount_info and nfs_clone_mount into nfs_fs_context. This structure represents NFS's superblock config. (*) Make use of the VFS's

Logo printing on the USB drives

2019-05-23 Thread Stacy
Hi, I am following up on my previous attempt to contact you. We wanted to check to see if you need any LOGO promotional products for your business? Our company manufactures USB Flash Drives that are custom printed with your logo. They make the perfect marketing tool for your business or organiza

Re: [PATCH net-next v2] net: phy: lxt: Add suspend/resume support to LXT971 and LXT973.

2019-05-23 Thread David Miller
From: Christophe Leroy Date: Thu, 23 May 2019 08:55:32 + (UTC) > All LXT PHYs implement the standard "power down" bit 11 of > BMCR, so this patch adds support using the generic > genphy_{suspend,resume} functions added by > commit 0f0ca340e57b ("phy: power management support"). > > LXT970 is

[PATCH] misc: sgi-xp: Properly initialize buf in xpc_get_rsvd_page_pa

2019-05-23 Thread Nathan Chancellor
Clang warns: drivers/misc/sgi-xp/xpc_partition.c:73:14: warning: variable 'buf' is uninitialized when used within its own initialization [-Wuninitialized] void *buf = buf; ~~~ ^~~ 1 warning generated. Initialize it to NULL, which is more deterministic. Fixes: 279290294662

Re: [PATCH bpf v1 1/3] selftests/bpf: Test correctness of narrow 32bit read on 64bit field

2019-05-23 Thread Daniel Borkmann
On 05/15/2019 03:47 PM, Krzesimir Nowak wrote: > Test the correctness of the 32bit narrow reads by reading both halves > of the 64 bit field and doing a binary or on them to see if we get the > original value. > > This isn't really tested - the program is not being run, because > BPF_PROG_TYPE_PER

Re: [PATCH v2 0/4] rtc: s35390a: uie_unsupported and minor fixes

2019-05-23 Thread Alexandre Belloni
On 23/05/2019 13:54:47+0200, Richard Leitner wrote: > As the s35390a does only support per-minute based alarms we have to > set the uie_unsupported flag. Otherwise it delays for 10sec and > fails afterwards with modern hwclock versions. > > Furthermore some other minor changes are made. > > All

Re: [PATCH] aoe: list new maintainer for aoe driver

2019-05-23 Thread Jens Axboe
On 5/23/19 10:24 AM, Ed Cashin wrote: > Yes, please.  Sorry for the omission! Done, thanks. -- Jens Axboe

Re: [PATCH 0/2] net: macb: Add support for SiFive FU540-C000

2019-05-23 Thread David Miller
Please be consistent in your subsystem prefixes used in your Subject lines. You use "net: macb:" then "net/macb:" Really, plain "macb: " is sufficient. Thank you.

Re: [PATCH V4] hsr: fix don't prune the master node from the node_db

2019-05-23 Thread David Miller
From: Andreas Oetken Date: Thu, 23 May 2019 13:57:14 +0200 > Don't prune the master node in the hsr_prune_nodes function. > Neither time_in[HSR_PT_SLAVE_A] nor time_in[HSR_PT_SLAVE_B] > will ever be updated by hsr_register_frame_in for the master port. > Thus, the master node will be repeatedly p

Re: perf: fuzzer causes crash in new XMM code

2019-05-23 Thread Vince Weaver
On Wed, 22 May 2019, Liang, Kan wrote: > XMM registers can only collected by hardware PEBS events. We should disable it > for all software/probe events. > > Could you please try the patch as below? I tested the patch (it was whitespace damaged for some reason, not sure if that was on my end tho

Re: [PATCH v3 1/2] dt-bindings: edac: arm-dmc520.txt

2019-05-23 Thread James Morse
Hi Lei, On 16/05/2019 03:35, Lei Wang wrote: > From: Lei Wang > > This is the device tree bindings for new EDAC driver dmc520_edac.c. > diff --git a/Documentation/devicetree/bindings/edac/arm-dmc520.txt > b/Documentation/devicetree/bindings/edac/arm-dmc520.txt > new file mode 100644 > index 00

Re: [PATCH v3 2/2] EDAC: add EDAC driver for DMC520

2019-05-23 Thread James Morse
Hi Lei, (CC: +Rui Zhao) On 16/05/2019 03:55, Lei Wang wrote: > New driver supports error detection and correction on the devices with ARM > DMC-520 memory controller. > diff --git a/MAINTAINERS b/MAINTAINERS > index 7d1246b..23894ac 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -5573,6 +5

Re: [PATCH 0/4] net: ll_temac: Fix and enable multicast support

2019-05-23 Thread David Miller
From: Esben Haabendal Date: Thu, 23 May 2019 14:02:18 +0200 > This patch series makes the necessary fixes to ll_temac driver to make > multicast work, and enables support for it.so that multicast support can > > The main change is the change from mutex to spinlock of the lock used to > synchroni

Re: [PATCH v4 0/1] Use HMM for ODP v4

2019-05-23 Thread Jason Gunthorpe
On Thu, May 23, 2019 at 11:52:08AM -0400, Jerome Glisse wrote: > On Thu, May 23, 2019 at 12:41:49PM -0300, Jason Gunthorpe wrote: > > On Thu, May 23, 2019 at 11:04:32AM -0400, Jerome Glisse wrote: > > > On Wed, May 22, 2019 at 08:57:37PM -0300, Jason Gunthorpe wrote: > > > > On Wed, May 22, 2019 at

<    1   2   3   4   5   6   7   8   9   10   >