RE: [PATCH v5 4/6] usb: roles: add API to get usb_role_switch by node

2019-05-22 Thread Chunfeng Yun
Hi Biju, On Wed, 2019-05-22 at 08:05 +, Biju Das wrote: > Hi Heikki, > > Thanks for the feedback. > > > Subject: Re: [PATCH v5 4/6] usb: roles: add API to get usb_role_switch by > > node > > > > On Mon, May 20, 2019 at 09:45:46AM +, Biju Das wrote: > > > > > > > > > Hi Heikki, > > > > >

Re: [PATCH 3/3] ARM: dts: imx6: rdu2: Limit USBH1 to Full Speed

2019-05-22 Thread Lucas Stach
Hi Andrey, Am Mittwoch, den 22.05.2019, 00:12 -0700 schrieb Andrey Smirnov: > Cabling used to connect devices to USBH1 on RDU2 does not meet USB > spec cable quality and cable length requirements to operate at High > Speed, so limit the port to Full Speed only. Really? I thought this issue is spe

Re: Running linux on qemu omap

2019-05-22 Thread Corentin Labbe
On Wed, May 22, 2019 at 02:23:23AM +0300, Aaro Koskinen wrote: > Hi, > > On Mon, May 20, 2019 at 09:05:33PM +0200, Corentin Labbe wrote: > > Hello > > > > I am working on adding a maximum set of qemu machine on kernelCI. > > That's cool. > > > For OMAP, five machine exists and I fail to boot an

Re: [PATCH v2] edac: sifive: Add EDAC platform driver for SiFive SoCs

2019-05-22 Thread Boris Petkov
On May 22, 2019 4:13:59 AM CDT, James Morse wrote: >Hi Boris, > >On 21/05/2019 19:21, Borislav Petkov wrote: >> On Tue, May 21, 2019 at 11:00:59AM +0530, Yash Shah wrote: >>> The prerequisite patch (sifive_l2_cache driver) has been merged into >>> mainline v5.2-rc1 >>> It should be OK to merge thi

Re: [PATCH 1/3] ARM: dts: imx6: rdu2: Add node for UCS1002 USB charger chip

2019-05-22 Thread Lucas Stach
Hi Andrey, Am Mittwoch, den 22.05.2019, 00:12 -0700 schrieb Andrey Smirnov: > Add node for UCS1002 USB charger chip connected to front panel USB and > replace "regulator-fixed" previously used to control VBUS. I've had a similar version of this patch, but also added GPIO hogs for the UCS1002 conf

[PATCH] arm: add missing include platform-data/atmel.h

2019-05-22 Thread Philippe Mazenauer
Include corresponding headerfile for function at91_suspend_entering_slow_clock(). ../arch/arm/mach-at91/pm.c:279:5: warning: no previous prototype for ‘at91_suspend_entering_slow_clock’ [-Wmissing-prototypes] int at91_suspend_entering_slow_clock(void) ^~~~ Sign

Re: [PATCH] staging: rtl8723bs: Add missing blank lines

2019-05-22 Thread Dan Carpenter
On Tue, May 21, 2019 at 09:46:55PM -0300, Fabio Lima wrote: > This patch resolves the following warning from checkpatch.pl > WARNING: Missing a blank line after declarations > > Signed-off-by: Fabio Lima > --- > drivers/staging/rtl8723bs/core/rtw_debug.c | 2 ++ > 1 file changed, 2 insertions(+)

[PATCH] arm: arch_timer: add missing include

2019-05-22 Thread Philippe Mazenauer
Include corresponing header file for function arch_timer_arch_init(). ../arch/arm/kernel/arch_timer.c:34:12: warning: no previous prototype for ‘arch_timer_arch_init’ [-Wmissing-prototypes] int __init arch_timer_arch_init(void) ^~~~ Signed-off-by: Philippe Mazenauer

Re: [PATCH][next] leds: TI LMU: remove redundant u8 comparisons with less than zero

2019-05-22 Thread Dan Carpenter
No. This isn't the right fix. We should declare them as int instead. regards, dan carpenter

[PATCH] message/fusion/mptbase.c: Use kmemdup instead of memcpy and kmalloc

2019-05-22 Thread Bharath Vedartham
Replace kmalloc + memcpy with kmemdup. This was reported by coccinelle. Signed-off-by: Bharath Vedartham --- drivers/message/fusion/mptbase.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/message/fusion/mptbase.c b/drivers/message/fusion/mptbase.c index d8882b0..

Re: [PATCHv3 1/3] vfio/mdev: Improve the create/remove sequence

2019-05-22 Thread Cornelia Huck
On Thu, 16 May 2019 18:30:32 -0500 Parav Pandit wrote: > This patch addresses below two issues and prepares the code to address > 3rd issue listed below. > > 1. mdev device is placed on the mdev bus before it is created in the > vendor driver. Once a device is placed on the mdev bus without crea

[PATCH] arm: highbank: add missing include "core.h"

2019-05-22 Thread Philippe Mazenauer
Include corresponding header file "core.h" for function highbank_pm_init(). ../arch/arm/mach-highbank/pm.c:54:13: warning: no previous prototype for ‘highbank_pm_init’ [-Wmissing-prototypes] void __init highbank_pm_init(void) ^~~~ Signed-off-by: Philippe Mazenauer ---

Re: [PATCHv3 2/3] vfio/mdev: Avoid creating sysfs remove file on stale device removal

2019-05-22 Thread Cornelia Huck
On Thu, 16 May 2019 18:30:33 -0500 Parav Pandit wrote: > If device is removal is initiated by two threads as below, mdev core > attempts to create a syfs remove file on stale device. > During this flow, below [1] call trace is observed. > > cpu-0cpu-1 >

[PATCH] arm: kernel: add missing import

2019-05-22 Thread Philippe Mazenauer
Include corresponding header file for function module_frob_arch_sections(). ../arch/arm/kernel/module-plts.c:191:5: warning: no previous prototype for ‘module_frob_arch_sections’ [-Wmissing-prototypes] int module_frob_arch_sections(Elf_Ehdr *ehdr, Elf_Shdr *sechdrs, ^~~

Re: [PATCHv3 1/3] vfio/mdev: Improve the create/remove sequence

2019-05-22 Thread Cornelia Huck
On Mon, 20 May 2019 19:54:59 + Parav Pandit wrote: > Seems 3rd patch will take few more days to settle down with new flag and its > review. > Given that fix of 3rd patch is fixing a different race condition, if patch 1 > and 2 look ok, shall we move forward with those 2 fixes it in 5.2-rc?

[PATCH v2] tracing: silence GCC 9 array bounds warning

2019-05-22 Thread Miguel Ojeda
Starting with GCC 9, -Warray-bounds detects cases when memset is called starting on a member of a struct but the size to be cleared ends up writing over further members. Such a call happens in the trace code to clear, at once, all members after and including `seq` on struct trace_iterator: In

[PATCH v4 00/14] add ecspi ERR009165 for i.mx6/7 soc family

2019-05-22 Thread Robin Gong
There is ecspi ERR009165 on i.mx6/7 soc family, which cause FIFO transfer to be send twice in DMA mode. Please get more information from: https://www.nxp.com/docs/en/errata/IMX6DQCE.pdf. The workaround is adding new sdma ram script which works in XCH mode as PIO inside sdma instead of SMC mode,

[PATCH v4 01/14] Revert "ARM: dts: imx6q: Use correct SDMA script for SPI5 core"

2019-05-22 Thread Robin Gong
There are two ways for SDMA accessing SPBA devices: one is SDMA->AIPS ->SPBA(masterA port), another is SDMA->SPBA(masterC port). Please refer to the 'Figure 58-1. i.MX 6Dual/6Quad SPBA connectivity' of i.mx6DQ Reference Manual. SDMA provide the corresponding app_2_mcu/mcu_2_app and shp_2_mcu/mcu_

[PATCH] arm: kexec: Make function static

2019-05-22 Thread Philippe Mazenauer
Make function machine_crash_nonpanic_core() static, as it is only referenced in this file. ../arch/arm/kernel/machine_kexec.c:82:6: warning: no previous prototype for ‘machine_crash_nonpanic_core’ [-Wmissing-prototypes] void machine_crash_nonpanic_core(void *unused) ^~~

[PATCH v4 02/14] Revert "ARM: dts: imx6: Use correct SDMA script for SPI cores"

2019-05-22 Thread Robin Gong
There are two ways for SDMA accessing SPBA devices: one is SDMA->AIPS ->SPBA(masterA port), another is SDMA->SPBA(masterC port). Please refer to the 'Figure 58-1. i.MX 6Dual/6Quad SPBA connectivity' of i.mx6DQ Reference Manual. SDMA provide the corresponding app_2_mcu/mcu_2_app and shp_2_mcu/mcu_

[PATCH v4 04/14] dmaengine: imx-sdma: remove dupilicated sdma_load_context

2019-05-22 Thread Robin Gong
Since sdma_transfer_init() will do sdma_load_context before any sdma transfer, no need once more in sdma_config_channel(). Signed-off-by: Robin Gong Acked-by: Vinod Koul --- drivers/dma/imx-sdma.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/dma/imx-sdma.c b/d

[PATCH v4 08/14] spi: imx: add new i.mx6ul compatible name in binding doc

2019-05-22 Thread Robin Gong
ERR009165 fixed from i.mx6ul, add its compatible name in binding doc. Signed-off-by: Robin Gong Acked-by: Mark Brown --- Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/spi/fsl-imx-cspi.txt b/Documenta

[PATCH v4 03/14] Revert "dmaengine: imx-sdma: refine to load context only once"

2019-05-22 Thread Robin Gong
This reverts commit ad0d92d7ba6aecbe2705907c38ff8d8be4da1e9c, because in spi-imx case, burst length may be changed dynamically. Signed-off-by: Robin Gong --- drivers/dma/imx-sdma.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index 99d

[PATCH v4 09/14] dmaengine: imx-sdma: remove ERR009165 on i.mx6ul

2019-05-22 Thread Robin Gong
ECSPI issue fixed from i.mx6ul at hardware level, no need ERR009165 anymore on those chips such as i.mx8mq. Add i.mx6sx from where i.mx6ul source. Signed-off-by: Robin Gong Acked-by: Vinod Koul --- drivers/dma/imx-sdma.c | 51 +- 1 file changed, 5

[PATCH v4 10/14] dma: imx-sdma: add i.mx6ul/6sx compatible name

2019-05-22 Thread Robin Gong
Add i.mx6ul and i.mx6sx compatible name in binding doc. Signed-off-by: Robin Gong --- Documentation/devicetree/bindings/dma/fsl-imx-sdma.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/dma/fsl-imx-sdma.txt b/Documentation/devicetree/bindings/dma/fsl-i

[PATCH v4 07/14] spi: imx: remove ERR009165 workaround on i.mx6ul

2019-05-22 Thread Robin Gong
ERR009165 fixed on i.mx6ul/6ull/6sll. All other i.mx6/7 and i.mx8m/8mm still need this errata. Please refer to nxp official errata document from https://www.nxp.com/ . For removing workaround on those chips. Add new i.mx6ul type. Signed-off-by: Robin Gong Acked-by: Mark Brown --- drivers/spi/s

Re: [PATCH][next] leds: TI LMU: remove redundant u8 comparisons with less than zero

2019-05-22 Thread Colin Ian King
On 22/05/2019 10:53, Dan Carpenter wrote: > No. This isn't the right fix. We should declare them as int instead. Doh, brown paper bag time. I'll do a V2. > > regards, > dan carpenter >

[PATCH v4 05/14] dmaengine: imx-sdma: add mcu_2_ecspi script

2019-05-22 Thread Robin Gong
Add mcu_2_ecspi script to fix ecspi errata ERR009165. Signed-off-by: Robin Gong Acked-by: Vinod Koul --- drivers/dma/imx-sdma.c | 3 +++ include/linux/platform_data/dma-imx-sdma.h | 1 + 2 files changed, 4 insertions(+) diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-

[PATCH v4 06/14] spi: imx: fix ERR009165

2019-05-22 Thread Robin Gong
Change to XCH mode even in dma mode, please refer to the below errata: https://www.nxp.com/docs/en/errata/IMX6DQCE.pdf Signed-off-by: Robin Gong Acked-by: Mark Brown --- drivers/spi/spi-imx.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/drivers/spi/spi

[PATCH] net: phy: lxt: Add suspend/resume support to LXT971 and LXT973.

2019-05-22 Thread Christophe Leroy
All LXT PHYs implement the standard "power down" bit 11 of BMCR, so this patch adds support using the generic genphy_{suspend,resume} functions. LXT970 is left aside because all registers get cleared upon "power down" exit. Fixes: 0f0ca340e57b ("phy: power management support") Signed-off-by: Chri

Re: CFQ idling kills I/O performance on ext4 with blkio cgroup controller

2019-05-22 Thread Srivatsa S. Bhat
On 5/22/19 2:09 AM, Paolo Valente wrote: > > First, thank you very much for testing my patches, and, above all, for > sharing those huge traces! > > According to the your traces, the residual 20% lower throughput that you > record is due to the fact that the BFQ injection mechanism takes a few >

[PATCH v4 13/14] ARM: dts: imx6sll: correct sdma compatible

2019-05-22 Thread Robin Gong
Correct sdma compatible since ecspi errata ERR009165 has been fixed on i.mx6sll as i.mx6ul. Signed-off-by: Robin Gong --- arch/arm/boot/dts/imx6sll.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx6sll.dtsi b/arch/arm/boot/dts/imx6sll.dtsi index 1b489

[PATCH v4 14/14] arm64: defconfig: Enable SDMA on i.mx8mq/8mm

2019-05-22 Thread Robin Gong
Enable SDMA support on i.mx8mq/8mm chips, including enabling CONFIG_FW_LOADER_USER_HELPER/CONFIG_FW_LOADER_USER_HELPER_FALLBACK for firmware loaded by udev. Signed-off-by: Robin Gong --- arch/arm64/configs/defconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm64/configs/defcon

[PATCH v4 11/14] dmaengine: imx-sdma: fix ecspi1 rx dma not work on i.mx8mm

2019-05-22 Thread Robin Gong
Because the number of ecspi1 rx event on i.mx8mm is 0, the condition check ignore such special case without dma channel enabled, which caused ecspi1 rx works failed. Actually, no need to check event_id0/event_id1 and replace checking 'event_id1' with 'DMA_DEV_TO_DEV', so that configure event_id1 on

[PATCH v4 12/14] ARM: dts: imx6ul: add dma support on ecspi

2019-05-22 Thread Robin Gong
Add dma support on ecspi. Signed-off-by: Robin Gong --- arch/arm/boot/dts/imx6ul.dtsi | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/imx6ul.dtsi b/arch/arm/boot/dts/imx6ul.dtsi index bbf010c..880b9ee 100644 --- a/arch/arm/boot/dts/imx6ul.dtsi +++ b/arch/arm/boot/dt

[PATCH v3] mm/kasan: Print frame description for stack bugs

2019-05-22 Thread Marco Elver
This adds support for printing stack frame description on invalid stack accesses. The frame description is embedded by the compiler, which is parsed and then pretty-printed. Currently, we can only print the stack frame info for accesses to the task's own stack, but not accesses to other tasks' sta

Re: CFQ idling kills I/O performance on ext4 with blkio cgroup controller

2019-05-22 Thread Srivatsa S. Bhat
On 5/22/19 2:12 AM, Paolo Valente wrote: > >> Il giorno 22 mag 2019, alle ore 11:02, Srivatsa S. Bhat >> ha scritto: >> >> >> Let's continue here on LKML itself. > > Just done :) > >> The only reason I created the >> bugzilla entry is to attach the tarball of the traces, assuming >> that it wo

Re: [PATCH] mm/kasan: Print frame description for stack bugs

2019-05-22 Thread Marco Elver
I've sent v3. If possible, please replace current version with v3, which also includes the fix. Many thanks, -- Marco On Wed, 22 May 2019 at 04:10, Andrew Morton wrote: > > On Sun, 19 May 2019 04:48:21 +0800 kbuild test robot wrote: > > > Hi Marco, > > > > Thank you for the patch! Perhaps some

[PATCH] arm: topology: make function static

2019-05-22 Thread Philippe Mazenauer
Make function cpu_corepower_mask() static, as it is only referenced in this file. ../arch/arm/kernel/topology.c:195:23: warning: no previous prototype for ‘cpu_corepower_mask’ [-Wmissing-prototypes] const struct cpumask *cpu_corepower_mask(int cpu) ^~ Sign

Re: [PATCH v2 0/7] mm: process_vm_mmap() -- syscall for duplication a process mapping

2019-05-22 Thread Kirill Tkhai
On 21.05.2019 20:28, Jann Horn wrote: > On Tue, May 21, 2019 at 7:04 PM Kirill Tkhai wrote: >> On 21.05.2019 19:20, Jann Horn wrote: >>> On Tue, May 21, 2019 at 5:52 PM Kirill Tkhai wrote: On 21.05.2019 17:43, Andy Lutomirski wrote: > On Mon, May 20, 2019 at 7:01 AM Kirill Tkhai wrote:

Re: [PATCH] fbcon: Remove fbcon_has_exited

2019-05-22 Thread Bartlomiej Zolnierkiewicz
Hi Daniel, On 5/21/19 4:23 PM, Daniel Vetter wrote: > This is unused code since > > commit 6104c37094e729f3d4ce65797002112735d49cd1 > Author: Daniel Vetter > Date: Tue Aug 1 17:32:07 2017 +0200 > > fbcon: Make fbcon a built-time depency for fbdev > > when fbcon was made a compile-time

[PATCH] net: stmmac: fix reset gpio free missing

2019-05-22 Thread Jisheng Zhang
Commit 984203ceff27 ("net: stmmac: mdio: remove reset gpio free") removed the reset gpio free, when the driver is unbinded or rmmod, we miss the gpio free. This patch uses managed API to request the reset gpio, so that the gpio could be freed properly. Signed-off-by: Jisheng Zhang Fixes: 984203c

[PATCH] net: stmmac: move reset gpio parse & request to stmmac_mdio_register

2019-05-22 Thread Jisheng Zhang
Move the reset gpio dt parse and request to stmmac_mdio_register(), thus makes the mdio code straightforward. This patch also replace stack var mdio_bus_data with data to simplify the code. Signed-off-by: Jisheng Zhang --- .../net/ethernet/stmicro/stmmac/stmmac_mdio.c | 58 ---

[PATCH] crypto: arm/sha512 - make function static

2019-05-22 Thread Philippe Mazenauer
Function sha512_arm_final() is only used in this file, therefore should be static ../arch/arm/crypto/sha512-glue.c:40:5: warning: no previous prototype for ‘sha512_arm_final’ [-Wmissing-prototypes] int sha512_arm_final(struct shash_desc *desc, u8 *out) ^~~~ Signed-off-by: Phili

Re: [PATCH] x86/fpu: allow kernel_fpu_{begin,end} to be used by non-GPL modules

2019-05-22 Thread Greg KH
On Wed, May 22, 2019 at 02:42:04PM +1000, Aleksa Sarai wrote: > Prior to [1], all non-GPL modules were able to make use of SIMD on x86 > by making use of the __kernel_fpu_* API. Given that __kernel_fpu_* were > both EXPORT_SYMBOL'd and kernel_fpu_* are such trivial wrappers around > the now-static

Re: [PATCH v4 00/14] add ecspi ERR009165 for i.mx6/7 soc family

2019-05-22 Thread Lucas Stach
Hi Robin, Am Mittwoch, den 22.05.2019, 09:59 + schrieb Robin Gong: >   There is ecspi ERR009165 on i.mx6/7 soc family, which cause FIFO > transfer to be send twice in DMA mode. Please get more information from: > https://www.nxp.com/docs/en/errata/IMX6DQCE.pdf. The workaround is adding > new s

Re: [PATCH] input: silead: Add MSSL0017 to acpi_device_id.

2019-05-22 Thread Hans de Goede
Hi, On 22-05-19 06:54, Danct12 wrote: On Chuwi Hi10 Plus, the Silead device id is MSSL0017. Signed-off-by: Danct12 Patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans --- drivers/input/touchscreen/silead.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/inp

Re: [GIT PULL] SPDX update for 5.2-rc1 - round 1

2019-05-22 Thread Thomas Gleixner
On Tue, 21 May 2019, Joe Perches wrote: > On Wed, 2019-05-22 at 13:32 +0900, Masahiro Yamada wrote: > > (Perhaps, checkpatch.pl can suggest newer tags in case > > patch submitters do not even know that deprecation.) > > I'd still prefer the kernel use of a single SPDX style. > > I don't know why

[PATCH] firmware: arm_scmi: clock: set rate_discrete

2019-05-22 Thread Peng Fan
The rate_discrete needs to be assigned to clk->rate_discrete, then scmi_clk_round_rate could get the value. Fixes: 5f6c6430e904 ("firmware: arm_scmi: add initial support for clock protocol") Signed-off-by: Peng Fan --- drivers/firmware/arm_scmi/clock.c | 2 ++ 1 file changed, 2 insertions(+) d

[PATCH 1/2] video: fbdev: pvr2fb: remove function prototypes

2019-05-22 Thread Bartlomiej Zolnierkiewicz
Reorder code a bit and then remove no longer needed function prototypes. Signed-off-by: Bartlomiej Zolnierkiewicz --- drivers/video/fbdev/pvr2fb.c | 141 ++- 1 file changed, 61 insertions(+), 80 deletions(-) Index: b/drivers/video/fbdev/pvr2fb.c

[PATCH v2] mm: Rename mm_vmscan_lru_shrink_inactive trace event variables

2019-05-22 Thread Kirill Tkhai
Rename nr_activate{0,1} into nr_activate{anon,file} since this is exported into userspace, e.g., it's shown here: /sys/kernel/debug/tracing/events/vmscan/mm_vmscan_lru_shrink_inactive/format v2: Changed suggested person (sorry, Mathieu :)) Suggested-by: Mathieu Desnoyers Signed-off-by: Kirill T

[PATCH][V2] leds: TI LMU: fix u8 variable comparisons with less than zero

2019-05-22 Thread Colin King
From: Colin Ian King The u8 variables ramp_ups and ramp_downs are being compared to less than zero, this will always be false. Fix this by making the ramp variables ints. Addresses-Coverity: ("Unsigned compared against 0") Fixes: 9a8e66ebeaa2 ("leds: TI LMU: Add common code for TI LMU devices")

Re: ext4 regression (was Re: [PATCH 4.19 000/105] 4.19.45-stable review)

2019-05-22 Thread Naresh Kamboju
On Wed, 22 May 2019 at 10:36, Theodore Ts'o wrote: > > On Tue, May 21, 2019 at 11:27:21PM +0530, Naresh Kamboju wrote: > > Steps to reproduce is, > > running LTP three test cases in sequence on x86 device. > > # cd ltp/runtest > > # cat syscalls ( only three test case) > > open12 open12 > > madvis

Re: [PATCH 4.19 067/105] ext4: protect journal inodes blocks using block_validity

2019-05-22 Thread Greg Kroah-Hartman
On Wed, May 22, 2019 at 11:18:59AM +0200, Pavel Machek wrote: > On Mon 2019-05-20 14:14:13, Greg Kroah-Hartman wrote: > > From: Theodore Ts'o > > > > commit 345c0dbf3a30872d9b204db96b5857cd00808cae upstream. > > > > Add the blocks which belong to the journal inode to block_validity's > > system

Re: [PATCH 4.19 038/105] ALSA: hdea/realtek - Headset fixup for System76 Gazelle (gaze14)

2019-05-22 Thread Greg Kroah-Hartman
On Wed, May 22, 2019 at 11:15:07AM +0200, Pavel Machek wrote: > On Mon 2019-05-20 14:13:44, Greg Kroah-Hartman wrote: > > From: Jeremy Soller > > > > commit 80a5052db75131423b67f38b21958555d7d970e4 upstream. > > > > On the System76 Gazelle (gaze14), there is a headset microphone input > > attach

Re: [PATCH 2/2] KVM: x86/pmu: do not mask the value that is written to fixed PMUs

2019-05-22 Thread Paolo Bonzini
On 20/05/19 21:01, Sean Christopherson wrote: > Would it make sense to inject a #GP if the guest attempts to set bits that > are reserved to be zero, e.g. based on guest CPUID? Yes, though it was not clear from the SDM quote that hardware enforces that (I guess the hint is that they "must" be writ

Re: [PATCH] tty_io: Fix a missing-check bug in drivers/tty/tty_io.c

2019-05-22 Thread Johan Hovold
On Wed, May 22, 2019 at 10:15:56AM +0200, Jiri Slaby wrote: > On 22. 05. 19, 10:06, Gen Zhang wrote: > > On Wed, May 22, 2019 at 06:25:36AM +0200, Jiri Slaby wrote: > >> On 22. 05. 19, 3:40, Gen Zhang wrote: > >>> In alloc_tty_struct(), tty->dev is assigned by tty_get_device(). And it > >>> calls c

Re: [PATCH] tty_io: Fix a missing-check bug in drivers/tty/tty_io.c

2019-05-22 Thread Jiri Slaby
On 22. 05. 19, 12:29, Johan Hovold wrote: >> Sure, but can class_find_device return NULL in this tty case here? > > Yes, it can and will and that's fine, not all ttys have a struct device > (e.g. ptys). IOW, the code needs a comment, if anything. thanks, -- js suse labs

Re: [PATCH v4 3/5] dt-bindings: watchdog: add Allwinner H6 r_watchdog

2019-05-22 Thread Maxime Ripard
On Tue, May 21, 2019 at 06:03:28PM +0200, Clément Péron wrote: > Allwinner H6 has a second watchdog on the r-blocks which is > compatible with the A31. > > This commit add the H6 compatible for the r_watchdog. > > Signed-off-by: Clément Péron Unless you have some evidence that the two blocks are

[PATCH v4 04/30] coresight: catu: Cleanup device specific data

2019-05-22 Thread Suzuki K Poulose
Switch to using the CoreSight device instead of the real amba device. Reviewed-by: Mathieu Poirier Signed-off-by: Suzuki K Poulose --- drivers/hwtracing/coresight/coresight-catu.c | 13 +++-- drivers/hwtracing/coresight/coresight-catu.h | 1 - 2 files changed, 7 insertions(+), 7 deleti

[PATCH v4 01/30] coresight: funnel: Clean up device book keeping

2019-05-22 Thread Suzuki K Poulose
In preparation to use a consistent device naming scheme, clean up the device link tracking in funnel driver. Use the "coresight" device instead of the "real" parent device for all internal purposes. All other requests (e.g, power management, DMA operations) must use the "real" device which is the p

[PATCH v4 10/30] coresight: Rename of_coresight to coresight-platform

2019-05-22 Thread Suzuki K Poulose
Rename the firmware handling file to a more generic name, in preparation for adding ACPI support. Right now we only support DT and we have all the platform handling code in of_coresight.c. Let us rename the file to coresight-platform.c in order to keep the platform handling in a single place for DT

[PATCH v4 29/30] coresight: acpi: Support for AMBA components

2019-05-22 Thread Suzuki K Poulose
All AMBA devices are handled via ACPI AMBA scan notifier infrastructure. The platform devices get the ACPI id added to their driver. Cc: "Rafael J. Wysocki" Reviewed-by: Mathieu Poirier Signed-off-by: Suzuki K Poulose --- drivers/acpi/acpi_amba.c | 9 + 1 file changed, 9 insertions(+)

[PATCH v4 24/30] coresight: platform: Use fwnode handle for device search

2019-05-22 Thread Suzuki K Poulose
We match of_node while searching for a device. Make this more generic in preparation for the ACPI support by using fwnode_handle. Reviewed-by: Mathieu Poirier Signed-off-by: Suzuki K Poulose --- drivers/hwtracing/coresight/coresight-platform.c | 16 +--- 1 file changed, 9 insertions

[PATCH v4 14/30] coresight: platform: Make memory allocation helper generic

2019-05-22 Thread Suzuki K Poulose
Rename the of_coresight_alloc_memory() => coresight_alloc_conns() as it is independent of the underlying firmware type. This is in preparation for the ACPI support. Reviewed-by: Mathieu Poirier Signed-off-by: Suzuki K Poulose --- drivers/hwtracing/coresight/coresight-platform.c | 34 +++

[PATCH v4 18/30] coresight: Remove cpu field from platform data

2019-05-22 Thread Suzuki K Poulose
CPU field is only used by ETMs and there is a separate API for fetching the same. So, let us use that instead of using the common platform probing helper. Also, remove it from the platform_data. Reviewed-by: Mathieu Poirier Signed-off-by: Suzuki K Poulose --- drivers/hwtracing/coresight/coresig

[PATCH v4 20/30] coresight: Cleanup coresight_remove_conns

2019-05-22 Thread Suzuki K Poulose
When a device is unregistered, we remove all connection references to it, by searching the connection records of all devices in the coresight bus, via coresight_remove_conns. We could avoid searching if this device doesn't have an input port (e.g, a source). Also document the purpose of the functio

[PATCH v4 16/30] coresight: Introduce generic platform data helper

2019-05-22 Thread Suzuki K Poulose
So far we have hard coded the DT platform parsing code in every driver. Introduce generic helper to parse the information provided by the firmware in a platform agnostic manner, in preparation for the ACPI support. Reviewed-by: Mathieu Poirier Signed-off-by: Suzuki K Poulose --- drivers/hwtraci

[PATCH v4 00/30] coresight: Support for ACPI bindings

2019-05-22 Thread Suzuki K Poulose
This series adds the support for CoreSight devices on ACPI based platforms. The device connections are encoded as _DSD graph property[0], with CoreSight specific extensions to indicate the direction of data flow as described in [1]. Components attached to CPUs are listed as child devices of the cor

[PATCH v4 05/30] coresight: tpiu: Clean up device specific data

2019-05-22 Thread Suzuki K Poulose
Switch to using the coresight device instead of the parent amba device. Reviewed-by: Mathieu Poirier Signed-off-by: Suzuki K Poulose --- drivers/hwtracing/coresight/coresight-tpiu.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/hwtracing/coresight/coresight-

[PATCH v4 02/30] coresight: replicator: Cleanup device tracking

2019-05-22 Thread Suzuki K Poulose
In preparation to use a consistent device naming scheme, clean up the device link tracking in replicator driver. Use the "coresight" device instead of the "real" parent device for all internal purposes. All other requests (e.g, power management, DMA operations) must use the "real" device which is t

[PATCH v4 26/30] coresight: Use platform agnostic names

2019-05-22 Thread Suzuki K Poulose
So far we have reused the name of the "platform" device for the CoreSight device. But this is not very intuitive when we move to ACPI. Also, the ACPI device names have ":" in them (e.g, ARMHC97C:01), which the perf tool doesn't like very much. This patch introduces a generic naming scheme, givin mo

[PATCH v4 25/30] coresight: Use fwnode handle instead of device names

2019-05-22 Thread Suzuki K Poulose
We rely on the device names to find a CoreSight device on the coresight bus. The device name however is obtained from the platform, which is bound to the real platform/amba device. As we are about to use different naming scheme for the coresight devices, we can't rely on the platform device name to

[PATCH v4 28/30] coresight: Support for ACPI bindings

2019-05-22 Thread Suzuki K Poulose
Add support for parsing the ACPI platform description for CoreSight. The connections are encoded in a DSD graph property with CoreSight specific variation of the property. The ETMs are listed as the children device of the respective CPU. Cc: "Rafael J. Wysocki" Reviewed-by: Mathieu Poirier Sign

[TEST PATCH 31/30][EDK2] edk2-platform: juno: Update ACPI CoreSight Bindings

2019-05-22 Thread Suzuki K Poulose
ACPI bindings for CoreSight components on the Juno-r0 board. Please note that the bindings apply only for the juno-r0. The layout on r1 and r2 are slightly different and will need dynamic ACPI table support to be able to use a single UEFI image. Signed-off-by: Suzuki K Poulose --- Platform/ARM/J

[PATCH v4 30/30] coresight: acpi: Support for platform devices

2019-05-22 Thread Suzuki K Poulose
Add support for platform devices which do not appear on the AMBA bus. Cc: "Rafael J. Wysocki" Reviewed-by: Mathieu Poirier Signed-off-by: Suzuki K Poulose --- drivers/hwtracing/coresight/coresight-replicator.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/driver

[PATCH v4 22/30] coresight: Rearrange platform data probing

2019-05-22 Thread Suzuki K Poulose
We are about to introduce methods to clean up the platform data as we switch to tracking the device reference from "name" to "fwnode handles" for device connections. This requires us to drop the fwnode handle references when the data is no longer required - i.e, when the device probe fails or the d

[PATCH v4 27/30] coresight: stm: ACPI support for parsing stimulus base

2019-05-22 Thread Suzuki K Poulose
The stimulus base for STM device must be listed as the second memory resource, followed by the programming base address as described in "Section 2.3 Resources" in ACPI for CoreSightTM 1.0 Platform Design documen (DEN0067). Add support for parsing the information for ACPI. Cc: "Rafael J. Wysocki"

[PATCH v4 23/30] coresight: Add support for releasing platform specific data

2019-05-22 Thread Suzuki K Poulose
Add a helper to clean up the platform specific data provided by the firmware. This will be later used for dropping the necessary references when we switch to the fwnode handles for tracking connections. Reviewed-by: Mathieu Poirier Signed-off-by: Suzuki K Poulose --- drivers/hwtracing/coresight

[PATCH v4 13/30] coresight: tmc-etr: Rearrange probing default buffer size

2019-05-22 Thread Suzuki K Poulose
As we are about to refactor the platform specific handling, make the default buffer size probing generic. Reviewed-by: Mathieu Poirier Signed-off-by: Suzuki K Poulose --- drivers/hwtracing/coresight/coresight-tmc.c | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) di

[PATCH v4 21/30] coresight: Reuse platform data structure for connection tracking

2019-05-22 Thread Suzuki K Poulose
The platform specific information describes the connections and the ports of a given coresigh device. This information is also recorded in the coresight device as separate fields. Let us reuse the original platform description to streamline the handling of the data. Reviewed-by: Mathieu Poirier S

[PATCH v4 15/30] coresight: Make sure device uses DT for obsolete compatible check

2019-05-22 Thread Suzuki K Poulose
As we prepare to add support for ACPI bindings, let us make sure we do the compatible check only if we are sure we are dealing with a DT based system. Reviewed-by: Mathieu Poirier Signed-off-by: Suzuki K Poulose --- drivers/hwtracing/coresight/coresight-funnel.c | 3 ++- drivers/hwtracing/c

[PATCH v4 19/30] coresight: Remove name from platform description

2019-05-22 Thread Suzuki K Poulose
We are about to use a name independent of the parent AMBA device name. As such, there is no need to have it in the platform description. Let us move this to coresight description instead. Reviewed-by: Mathieu Poirier Signed-off-by: Suzuki K Poulose --- drivers/hwtracing/coresight/coresight-catu

[PATCH v4 17/30] coresight: Make device to CPU mapping generic

2019-05-22 Thread Suzuki K Poulose
The CoreSight components ETM and CPU-Debug are always associated with CPUs. Replace the of_coresight_get_cpu() with a platform agnostic helper, in preparation to add ACPI support. Reviewed-by: Mathieu Poirier Signed-off-by: Suzuki K Poulose --- drivers/hwtracing/coresight/coresight-cpu-debug.c

[PATCH v4 08/30] coresight: etb10: Clean up device specific data

2019-05-22 Thread Suzuki K Poulose
Track the coresight device instead of the real device. Reviewed-by: Mathieu Poirier Signed-off-by: Suzuki K Poulose --- drivers/hwtracing/coresight/coresight-etb10.c | 32 +-- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/hwtracing/coresight/cor

[PATCH v4 12/30] coresight: stm: Rearrange probing the stimulus area

2019-05-22 Thread Suzuki K Poulose
As we are about to refactor the platform specific handling re-arrange some of the DT specific property handling. Reviewed-by: Mathieu Poirier Signed-off-by: Suzuki K Poulose --- drivers/hwtracing/coresight/coresight-stm.c | 23 +++ 1 file changed, 19 insertions(+), 4 deletio

[PATCH v4 09/30] coresight: Use coresight device names for sinks in PMU attribute

2019-05-22 Thread Suzuki K Poulose
From: Mathieu Poirier Move to using the coresight device name instead of the parent device name for SINK attribute for PMU. Signed-off-by: Mathieu Poirier Signed-off-by: Suzuki K Poulose --- drivers/hwtracing/coresight/coresight-etm-perf.c | 8 1 file changed, 4 insertions(+), 4 dele

[PATCH v4 11/30] coresight: etm3x: Rearrange cp14 access detection

2019-05-22 Thread Suzuki K Poulose
As we are about to refactor the platform specific handling, move the DT property handling to generic helpers. Reviewed-by: Mathieu Poirier Signed-off-by: Suzuki K Poulose --- drivers/hwtracing/coresight/coresight-etm3x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/driver

[PATCH v4 07/30] coresight: etm: Clean up device specific data

2019-05-22 Thread Suzuki K Poulose
Track the coresight device instead of the real device. Reviewed-by: Mathieu Poirier Signed-off-by: Suzuki K Poulose --- drivers/hwtracing/coresight/coresight-etm.h| 6 ++ .../hwtracing/coresight/coresight-etm3x-sysfs.c| 12 ++-- drivers/hwtracing/coresight/coresight-etm

[PATCH v4 06/30] coresight: stm: Cleanup device specific data

2019-05-22 Thread Suzuki K Poulose
Keep track of the STM coresight device which is a child device of the AMBA device. Since we can get to the coresight_device from the "device" instance, remove the explicit field. Reviewed-by: Mathieu Poirier Signed-off-by: Suzuki K Poulose --- drivers/hwtracing/coresight/coresight-stm.c | 21 ++

[PATCH v4 03/30] coresight: tmc: Clean up device specific data

2019-05-22 Thread Suzuki K Poulose
In preparation to use a consistent device naming scheme, clean up the device link tracking in replicator driver. Use the "coresight" device instead of the "real" parent device for all internal purposes. All other requests (e.g, power management, DMA operations) must use the "real" device which is t

Re: [PATCH] HID: multitouch: handle faulty Elo touch device

2019-05-22 Thread Jiri Kosina
On Tue, 21 May 2019, Benjamin Tissoires wrote: > On Tue, May 21, 2019 at 3:38 PM Benjamin Tissoires > wrote: > > > > Since kernel v5.0, one single win8 touchscreen device failed. > > And it turns out this is because it reports 2 InRange usage per touch. > > > > It's a first, and I *really* wonder

[PATCH 3/4 v2] w1: ds2413: when the slave is not responding during read, select it again

2019-05-22 Thread Mariusz Bialonczyk
The protocol is not allowing to obtain a byte of 0xff for PIO_ACCESS_READ call. It is very likely that the slave was not addressed properly and it is just not respoding (leaving the bus in logic high state) during the read of sampled PIO value. We cannot just call w1_reset_resume_command() because

d_lookup: Unable to handle kernel paging request

2019-05-22 Thread Vicente Bergas
Hi, since a recent update the kernel is reporting d_lookup errors. They appear randomly and after each error the affected file or directory is no longer accessible. The kernel is built with GCC 9.1.0 on ARM64. Four traces from different workloads follow. This trace is from v5.1-12511-g72cf0b07418

Re: [PATCH] spi: dt-bindings: Convert Arm pl022 to json-schema

2019-05-22 Thread Maxime Ripard
Hi Rob, On Tue, May 21, 2019 at 04:23:24PM -0500, Rob Herring wrote: > +allOf: > + - $ref: "spi-controller.yaml#" You're using a different construct on the spi-gpio binding you just sent (/schemas/spi/spi-controller.yaml). Is that on purpose? Maxime -- Maxime Ripard, Bootlin Embedded Linux an

Re: [PATCH v5 2/5] USB: use genalloc for USB HCs with local memory

2019-05-22 Thread Laurentiu Tudor
Hello Alan, On 21.05.2019 20:20, Alan Stern wrote: > On Tue, 21 May 2019 laurentiu.tu...@nxp.com wrote: > >> From: Laurentiu Tudor >> >> For HCs that have local memory, replace the current DMA API usage >> with a genalloc generic allocator to manage the mappings for these >> devices. To help use

[PATCH] ignore disabled memory-region nodes

2019-05-22 Thread Puneet Saxena
While parsing "memory-region" node lists if a node is "disabled", parsing halts. Therefore the nodes whose "status" is "okay" or "ok" are not parsed. The change ignores disabled nodes in the memory-region nodes list and returns 0 to continue parsing next nodes. --- v2: * Fixed typo in commit mess

[PATCH V2] of: reserved-memory: ignore disabled memory-region nodes

2019-05-22 Thread Puneet Saxena
From: Krishna Reddy Ignore disabled nodes in the memory-region nodes list and continue to initialize the rest of enabled nodes. Check if the "reserved-memory" node is available and if it's not available, return 0 to ignore the "reserved-memory" node and continue parsing with next node in mem

[PATCH v4 00/16] Software fwnode references

2019-05-22 Thread Heikki Krogerus
Hi, I'm not splitting this series in two after all. After thinking about this for some time, I decided to add support for static software nodes. I did not want to support them because I don't want to make it easy to maintain board files, but in end they make the use of the software nodes so much m

[PATCH v4 01/16] software node: Allow node creation without properties

2019-05-22 Thread Heikki Krogerus
Software nodes are not forced to have device properties. Adding check to property_entries_dup() to make it possible to create software nodes that don't have any properties. Signed-off-by: Heikki Krogerus --- drivers/base/swnode.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/bas

<    1   2   3   4   5   6   7   8   9   10   >