Re: [PATCH v4 5/7] dt-bindings: ti-lmu: Modify dt bindings for the LM3697

2019-05-08 Thread Lee Jones
On Mon, 06 May 2019, Dan Murphy wrote: > The LM3697 is a single function LED driver. The single function LED > driver needs to reside in the LED directory as a dedicated LED driver > and not as a MFD device. The device does have common brightness and ramp > features and those can be accomodated b

Re: [PATCH v4 3/7] dt-bindings: mfd: LMU: Add ti,brightness-resolution

2019-05-08 Thread Lee Jones
On Mon, 06 May 2019, Dan Murphy wrote: > Add ti,brightness-resolution to the TI LMU binding to define > whether the device uses 8-bit brightness or 11-bit brightness. > > Reviewed-by: Rob Herring > Signed-off-by: Dan Murphy For my own reference: Acked-for-MFD-by: Lee Jones -- Lee Jones [李

Re: [PATCH] Remove MODULE_ALIAS() calls that take undefined macro

2019-05-08 Thread Lee Jones
On Tue, 07 May 2019, Masahiro Yamada wrote: > These files do not define (USBHS_)DRIVER_NAME. Yet, they can be > successfully compiled because they are never built as a module by > anyone, i.e, the MODULE_ALIAS() calls are always no-op. > > A problem showed up when a patch "moduleparam: Save infor

RE: [EXT] Re: [PATCH 2/2] arm64: dts: fsl: ls1046a: Add the guts node in dts

2019-05-08 Thread Chuanhua Han
> -Original Message- > From: Sascha Hauer > Sent: 2019年5月6日 15:41 > To: Chuanhua Han > Cc: shawn...@kernel.org; Leo Li ; robh...@kernel.org; > mark.rutl...@arm.com; linux-kernel@vger.kernel.org; > linux-...@vger.kernel.org; linux-arm-ker...@lists.infradead.org; > devicet...@vger.kernel.

[tip:perf/urgent] perf/x86/amd/iommu: Make the 'amd_iommu_attr_groups' symbol static

2019-05-08 Thread tip-bot for Wang Hai
Commit-ID: 4abf1ee16e25ba97bc9e04ddc64e0cd2a1bc41a8 Gitweb: https://git.kernel.org/tip/4abf1ee16e25ba97bc9e04ddc64e0cd2a1bc41a8 Author: Wang Hai AuthorDate: Wed, 8 May 2019 10:04:18 +0800 Committer: Ingo Molnar CommitDate: Wed, 8 May 2019 13:35:32 +0200 perf/x86/amd/iommu: Make the 'am

RE: [EXT] Re: [PATCH 1/2] i2c: imx: I2C Driver doesn't consider I2C_IPGCLK_SEL RCW bit when using ls1046a SoC

2019-05-08 Thread Chuanhua Han
> -Original Message- > From: Sascha Hauer > Sent: 2019年5月6日 15:48 > To: Chuanhua Han > Cc: shawn...@kernel.org; Leo Li ; robh...@kernel.org; > mark.rutl...@arm.com; linux-kernel@vger.kernel.org; > linux-...@vger.kernel.org; linux-arm-ker...@lists.infradead.org; > devicet...@vger.kernel.

Re: [PATCH 5/7] dt-bindings: mfd: Add H6 GPADC binding

2019-05-08 Thread Lee Jones
On Fri, 03 May 2019, Yangtao Li wrote: > This patch adds documentation for the H6 GPADC binding. > > Signed-off-by: Yangtao Li > --- > .../devicetree/bindings/mfd/sun4i-gpadc.txt | 27 +-- > 1 file changed, 25 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devic

RE: [EXT] Re: [PATCH 1/3] dt-bindings: i2c: add optional mul-value property to binding

2019-05-08 Thread Chuanhua Han
> -Original Message- > From: Rob Herring > Sent: 2019年5月3日 4:59 > To: Chuanhua Han > Cc: mark.rutl...@arm.com; shawn...@kernel.org; s.ha...@pengutronix.de; > Leo Li ; linux-kernel@vger.kernel.org; > devicet...@vger.kernel.org; linux-arm-ker...@lists.infradead.org; > linux-...@vger.kerne

Re: [PATCH 6/7] iio: adc: sun4i-gpadc-iio: add support for H6 thermal sensor

2019-05-08 Thread Lee Jones
On Fri, 03 May 2019, Yangtao Li wrote: > This patch adds support for the H6 ths sensor. > > TODO: calibrate thermal sensor by using information from sid. > > Signed-off-by: Yangtao Li > --- > drivers/iio/adc/sun4i-gpadc-iio.c | 65 +++ > include/linux/mfd/sun4i-gpad

Re: [PATCH v3 13/13] platform/x86: intel_cht_int33fe: Replacing the old connections with references

2019-05-08 Thread Heikki Krogerus
On Wed, Apr 17, 2019 at 11:14:19PM +0200, Hans de Goede wrote: > Hi, > > On 17-04-19 11:19, Hans de Goede wrote: > > Note that another problem with this series which I noticed while testing > > is that the usb-role-switch is not being found at all anymore after > > this ("Replacing the old connect

Re: [PATCH v4 1/6] dt-bindings: mfd: max77620: Add compatible for Maxim 77663

2019-05-08 Thread Lee Jones
On Sun, 05 May 2019, Dmitry Osipenko wrote: > Maxim 77663 has a few minor differences in regards to hardware interface > and available capabilities by comparing it with 77620 and 20024 models, > hence re-use 77620 device-tree binding for the 77663. > > Reviewed-by: Rob Herring > Signed-off-by: D

Re: [PATCH v4 2/6] dt-bindings: mfd: max77620: Add system-power-controller property

2019-05-08 Thread Lee Jones
On Sun, 05 May 2019, Dmitry Osipenko wrote: > Document new generic property that designates the PMIC as the system's > power controller. > > Signed-off-by: Dmitry Osipenko For my own reference: Acked-for-MFD-by: Lee Jones -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open

RE: [PATCH V2 2/4] nvmem: imx: add i.MX8 nvmem driver

2019-05-08 Thread Aisheng Dong
> From: Peng Fan > Sent: Wednesday, May 8, 2019 10:56 AM > > This patch adds i.MX8 nvmem ocotp driver to access fuse via RPC to i.MX8 > system controller. > > Cc: Srinivas Kandagatla > Cc: Shawn Guo > Cc: Sascha Hauer > Cc: Pengutronix Kernel Team > Cc: Fabio Estevam > Cc: NXP Linux Team >

Re: [RFC PATCH 1/5] net: dsa: mv88e6xxx: introduce support for two chips using direct smi addressing

2019-05-08 Thread Andrew Lunn
> > Hi Rasmus > > > > This works, but i think i prefer adding mv88e6xxx_smi_dual_chip_write, > > mv88e6xxx_smi_dual_chip_read, and create a > > mv88e6xxx_smi_single_chip_ops. > > Hi Andrew > > Now that Vivien's "net: dsa: mv88e6xxx: refine SMI support" is in > master, do you still prefer introdu

Re: [PATCH v4 3/6] mfd: max77620: Fix swapped FPS_PERIOD_MAX_US values

2019-05-08 Thread Lee Jones
On Sun, 05 May 2019, Dmitry Osipenko wrote: > The FPS_PERIOD_MAX_US definitions are swapped for MAX20024 and MAX77620, > fix it. > > Cc: stable > Signed-off-by: Dmitry Osipenko > --- > include/linux/mfd/max77620.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) For my own referenc

Re: [PATCH v4 4/6] mfd: max77620: Support Maxim 77663

2019-05-08 Thread Lee Jones
On Sun, 05 May 2019, Dmitry Osipenko wrote: > Add support for Maxim 77663 using the Max77620 driver. The hardware > is very similar to Max77663/20024, although there are couple minor > differences. > > Signed-off-by: Dmitry Osipenko > --- > drivers/mfd/max77620.c | 69

Re: [PATCH v4 5/6] mfd: max77620: Provide system power-off functionality

2019-05-08 Thread Lee Jones
On Sun, 05 May 2019, Dmitry Osipenko wrote: > Provide system power-off functionality that allows to turn off machine > gracefully. > > Signed-off-by: Dmitry Osipenko > --- > drivers/mfd/max77620.c | 18 ++ > 1 file changed, 18 insertions(+) For my own reference: Acked-for-MFD

RE: [PATCH V2 4/4] arm64: dts: imx: add i.MX8QXP ocotp support

2019-05-08 Thread Aisheng Dong
> From: Peng Fan > Sent: Wednesday, May 8, 2019 10:56 AM > > Add i.MX8QXP ocotp node > > Cc: Rob Herring > Cc: Mark Rutland > Cc: Shawn Guo > Cc: Sascha Hauer > Cc: Pengutronix Kernel Team > Cc: Fabio Estevam > Cc: NXP Linux Team > Cc: Aisheng Dong > Cc: Anson Huang > Cc: Daniel Baluta

[GIT PULL] Immutable branch between MFD and Regulator due for the v5.2 merge window

2019-05-08 Thread Lee Jones
Enjoy! The following changes since commit e93c9c99a629c61837d5a7fc2120cd2b6c70dbdd: Linux 5.1 (2019-05-05 17:42:58 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git ib-mfd-regulator-v5.2 for you to fetch changes up to 744b13107d0d2ec3

Re: [RESEND PATCH 3/6] perf/x86/intel/uncore: Extract codes of box ref/unref

2019-05-08 Thread Peter Zijlstra
On Tue, Apr 30, 2019 at 05:53:45PM -0700, kan.li...@linux.intel.com wrote: > +static void uncore_box_unref(struct intel_uncore_type **types, int id) > { > + struct intel_uncore_type *type; > struct intel_uncore_pmu *pmu; > struct intel_uncore_box *box; > + int i; > + > + fo

Re: [PATCH v4 2/6] dt-bindings: mfd: Add lm36274 bindings to ti-lmu

2019-05-08 Thread Lee Jones
On Tue, 07 May 2019, Dan Murphy wrote: > Add the LM36274 backlight driver with regulator support. > This is a multi-function device for backlight applications. > > Backlight properties will be documented in it's a supplemental > bindings document. > > Regulator support is documented in the regul

Re: [PATCH v4 3/6] mfd: ti-lmu: Add LM36274 support to the ti-lmu

2019-05-08 Thread Lee Jones
On Tue, 07 May 2019, Dan Murphy wrote: > Add the LM36274 register support to the ti-lmu MFD driver. > > Signed-off-by: Dan Murphy > --- > drivers/mfd/Kconfig | 5 ++--- > drivers/mfd/ti-lmu.c| 14 ++ > include/linux/mfd/ti-lmu-register.h | 23 +++

Re: [PATCH 2/4] x86/kprobes: Fix frame pointer annotations

2019-05-08 Thread Josh Poimboeuf
On Wed, May 08, 2019 at 09:49:03AM +0200, Peter Zijlstra wrote: > The kprobe trampolines have a FRAME_POINTER annotation that makes no > sense. It marks the frame in the middle of pt_regs, at the place of > saving BP. > > Change it to mark the pt_regs frame as per the ENCODE_FRAME_POINTER > from t

Re: [PATCH v3 1/4] mfd: cros_ec: Update the EC feature codes

2019-05-08 Thread Lee Jones
On Mon, 08 Apr 2019, Enric Balletbo i Serra wrote: > Update the feature enum for the Chromebook Embedded Controller to the > latest version. Some of these enums are still not used in the kernel but > we might be also interested on have these enums up to date. Userspace > can use them to query the

Re: [RFC][PATCH 4/4] x86_32: Provide consistent pt_regs

2019-05-08 Thread Josh Poimboeuf
On Wed, May 08, 2019 at 09:49:05AM +0200, Peter Zijlstra wrote: > Currently pt_regs on x86_32 has an oddity in that kernel regs > (!user_mode(regs)) are short two entries (esp/ss). This means that any > code trying to use them (typically: regs->sp) needs to jump through > some unfortunate hoops. >

Re: [PATCH v4 1/3] mfd: cros_ec: Update the EC feature codes

2019-05-08 Thread Lee Jones
On Wed, 08 May 2019, Enric Balletbo i Serra wrote: > Update the feature enum for the Chromebook Embedded Controller to the > latest version. Some of these enums are still not used in the kernel but > we might be also interested on have these enums up to date. Userspace > can use them to query the

Re: [PATCH v4 2/3] mfd: cros_ec: instantiate properly CrOS FP MCU device

2019-05-08 Thread Lee Jones
On Wed, 08 May 2019, Enric Balletbo i Serra wrote: > Support Fingerprint MCU as a special of CrOS EC devices. The current FP > MCU uses the same EC SPI protocol v3 as other CrOS EC devices on a SPI > bus. > > When a MCU has fingerprint support (aka EC_FEATURE_FINGERPRINT), it is > instantiated as

Re: [PATCH v4 3/3] mfd: cros_ec: instantiate properly CrOS Touchpad MCU device

2019-05-08 Thread Lee Jones
On Wed, 08 May 2019, Enric Balletbo i Serra wrote: > Support Touchpad MCU as a special of CrOS EC devices. The current > Touchpad MCU is used on Eve Chromebook and used the same protocol as > other CrOS EC devices. > > When a MCU has touchpad support (aka EC_FEATURE_TOUCHPAD), it is > instantiate

Re: [RESEND PATCH 0/6] Perf uncore support for Snow Ridge server

2019-05-08 Thread Peter Zijlstra
On Tue, Apr 30, 2019 at 05:53:42PM -0700, kan.li...@linux.intel.com wrote: > From: Kan Liang > > The patch series intends to enable perf uncore support for Snow Ridge > server. > > Here is the link for the uncore document. > https://cdrdv2.intel.com/v1/dl/getContent/611319 > > Patch 1: Fixes a

Re: [RFC PATCH 4/6] sched/dl: Improve capacity-aware wakeup

2019-05-08 Thread Juri Lelli
On 08/05/19 11:24, luca abeni wrote: > On Wed, 8 May 2019 11:08:55 +0200 > Juri Lelli wrote: > > > On 06/05/19 06:48, Luca Abeni wrote: > > > From: luca abeni > > > > > > Instead of considering the "static CPU bandwidth" allocated to > > > a SCHED_DEADLINE task (ratio between its maximum runtim

Re: [PATCH 2/4] x86/kprobes: Fix frame pointer annotations

2019-05-08 Thread Peter Zijlstra
On Wed, May 08, 2019 at 06:54:16AM -0500, Josh Poimboeuf wrote: > On Wed, May 08, 2019 at 09:49:03AM +0200, Peter Zijlstra wrote: > > The kprobe trampolines have a FRAME_POINTER annotation that makes no > > sense. It marks the frame in the middle of pt_regs, at the place of > > saving BP. > > > >

[PATCH v2] kvm: nVMX: Set nested_run_pending in vmx_set_nested_state after checks complete

2019-05-08 Thread Paolo Bonzini
From: Aaron Lewis nested_run_pending=1 implies we have successfully entered guest mode. Move setting from external state in vmx_set_nested_state() until after all other checks are complete. Based on a patch by Aaron Lewis. Signed-off-by: Paolo Bonzini --- arch/x86/kvm/vmx/nested.c | 10 ++

Re: [PATCH v3] serial: Add Milbeaut serial control

2019-05-08 Thread Sugaya, Taichi
Hi, Thank you for pointing out. On 2019/04/27 3:15, Alan Cox wrote: O +static void mlb_usio_set_termios(struct uart_port *port, + struct ktermios *termios, struct ktermios *old) +{ + unsigned int escr, smr = MLB_USIO_SMR_SOE; + unsigned long flags, baud, quot;

Re: [PATCH 1/8] arm64: dts: mt8183: add thermal zone node

2019-05-08 Thread Michael Kao
On Mon, 2019-05-06 at 12:43 +0200, Daniel Lezcano wrote: > On 03/05/2019 18:46, Matthias Kaehlcke wrote: > > Hi, > > > > On Fri, May 03, 2019 at 04:03:58PM +0800, Hsin-Yi Wang wrote: > >> On Thu, May 2, 2019 at 10:43 AM michael.kao > >> wrote: > >>> > >>> Add thermal zone node to Mediatek MT8183

Re: [PATCH 2/8] arm64: dts: mt8183: add/update dynamic power coefficients

2019-05-08 Thread Michael Kao
On Fri, 2019-05-03 at 15:16 +0800, Hsin-Yi Wang wrote: > On Thu, May 2, 2019 at 10:43 AM michael.kao wrote: > > > > Add dynamic power coefficients for all cores and update those of > > CPU0 and CPU4. > > > > Signed-off-by: Michael.Kao > > --- > > arch/arm64/boot/dts/mediatek/mt8183.dtsi | 16 +++

[PATCH 2/4] checkpatch: add --fix for warning LINE_CONTINUATIONS

2019-05-08 Thread Antonio Borneo
The warning LINE_CONTINUATIONS does not offer a --fix. Add the trivial --fix. In case of consecutive lines with the same issue, this will fix only the first line. Signed-off-by: Antonio Borneo --- scripts/checkpatch.pl | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/s

[PATCH 4/4] checkpatch: replace magic value for TAB size

2019-05-08 Thread Antonio Borneo
The size of 8 characters used for both TAB and indentation is embedded as magic value allover the checkpatch script, and this makes the script less readable. Replace the magic value 8 with the perl variable "$tabsize". >From the context of the code it's clear if it is used for indentation or tabul

[PATCH 3/4] checkpatch: fix minor typo and mixed space+tab in indentation

2019-05-08 Thread Antonio Borneo
Fix spelling of "concatenation". Don't use tab after space in indentation. Signed-off-by: Antonio Borneo --- scripts/checkpatch.pl | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index 9a247183b65c..373ad345f732 100755 ---

[PATCH 1/4] checkpatch: fix multiple const * types

2019-05-08 Thread Antonio Borneo
Commit 1574a29f8e76 ("checkpatch: allow multiple const * types") claims to support repetition of pattern "const *", but it actually allows only one extra instance. Check the following lines int a(char const * const x[]); int b(char const * const *x); int c(char const * const

Re: [PATCH] x86/fpu: Remove the _GPL from the kernel_fpu_begin/end() export

2019-05-08 Thread Sebastian Gottschall
Am 07.05.2019 um 12:31 schrieb David Laight: ... So I don't really see a problem with Andy's patch. If we want to annoy external non-GPL modules as much as possible, sure, that's for a separate discussion though (and I am sure many people would agree to that). Proposal to get rid of EXPORT_SYM

[RFC PATCH] soc: imx: Try harder to get imq8mq SoC revisions

2019-05-08 Thread Guido Günther
Hi Leonard, Thanks for your comments. Let's try s.th. different then: identify by bootrom, ocotop and anatop and fall back to ATF afterwards (I'll split out the DT part and add binding docs if this makes sense). I'm also happy to drop the whole ATF logic until mailine ATF catched up: The mainline

Re: [PATCH 2/4] x86/kprobes: Fix frame pointer annotations

2019-05-08 Thread Peter Zijlstra
On Wed, May 08, 2019 at 02:04:16PM +0200, Peter Zijlstra wrote: > On Wed, May 08, 2019 at 06:54:16AM -0500, Josh Poimboeuf wrote: > > We should put these macros in a header file somewhere (including > > stringified versions). > > Probably a good idea. I'll frob them into asm/frame.h. --- Subject

Re: [PATCH v1] dmaengine: tegra-apb: Handle DMA_PREP_INTERRUPT flag properly

2019-05-08 Thread Dmitry Osipenko
08.05.2019 12:24, Jon Hunter пишет: > > On 05/05/2019 19:12, Dmitry Osipenko wrote: >> The DMA_PREP_INTERRUPT flag means that descriptor's callback should be >> invoked upon transfer completion and that's it. For some reason driver >> completely disables the hardware interrupt handling, leaving ch

Re: [PATCH v2 00/10] RFC: NVME MDEV

2019-05-08 Thread Paolo Bonzini
On 06/05/19 07:57, Christoph Hellwig wrote: > > Or to put it into another way: unless your paravirt interface requires > zero specific changes to the core nvme code it is not acceptable at all. I'm not sure it's possible to attain that goal, however I agree that putting the control plane in the

Re: [PATCH v2 1/4] bpf: Add support for reading user pointers

2019-05-08 Thread Masami Hiramatsu
On Tue, 7 May 2019 01:10:45 +0200 Daniel Borkmann wrote: > On 05/06/2019 09:57 PM, Joel Fernandes wrote: > > On Mon, May 06, 2019 at 09:11:19PM +0200, Daniel Borkmann wrote: > >> On 05/06/2019 08:31 PM, Joel Fernandes (Google) wrote: > >>> The eBPF based opensnoop tool fails to read the file path

Re: WARNING in untrack_pfn

2019-05-08 Thread Dmitry Vyukov
From: Julia Lawall Date: Fri, Apr 12, 2019 at 3:21 PM > On Fri, 12 Apr 2019, Pavel Machek wrote: > > > On Fri 2019-04-12 04:42:01, syzbot wrote: > > > syzbot has bisected this bug to: > > > > > > commit c68729119f4d2993bec3c9cb999ad76de5aeddba > > > Author: Julia Lawall > > > Date: Sat Jul 15 0

Re: ARM/gic-v4: deadlock occurred

2019-05-08 Thread Marc Zyngier
On Sun, 05 May 2019 12:07:02 +0100, Heyi Guo wrote: > > Hi Marc, > > Appreciate your quick patch :) We'll test it and let you know the > result. For what it is worth, I've just pushed out a branch (irq/vlpi-map-rework) with a more complete fix. It is of course untested (it does compile though).

Re: [PATCH V2 1/3] Calculate Thermal Pressure

2019-05-08 Thread Quentin Perret
Hi Thara, Sorry for the delayed response. On Friday 26 Apr 2019 at 10:17:56 (-0400), Thara Gopinath wrote: > On 04/25/2019 08:45 AM, Vincent Guittot wrote: > > Do you mean calling a variant of sched_update_thermal_pressure() in > > update_cpu_capacity() instead of periodic update ? > > Yes , that

Re: [PATCH 2/4] x86/kprobes: Fix frame pointer annotations

2019-05-08 Thread Josh Poimboeuf
On Wed, May 08, 2019 at 02:04:16PM +0200, Peter Zijlstra wrote: > On Wed, May 08, 2019 at 06:54:16AM -0500, Josh Poimboeuf wrote: > > On Wed, May 08, 2019 at 09:49:03AM +0200, Peter Zijlstra wrote: > > > The kprobe trampolines have a FRAME_POINTER annotation that makes no > > > sense. It marks the

Re: [PATCH 1/2] EDAC/sysfs: Fix memory leak when creating a csrow object

2019-05-08 Thread Greg KH
On Wed, May 08, 2019 at 01:02:50PM +0200, Borislav Petkov wrote: > >From 28e7f23939208bea639d6cd3d492cde3f65a7e4f Mon Sep 17 00:00:00 2001 > From: Pan Bian > Date: Thu, 18 Apr 2019 10:27:18 +0800 > > In edac_create_csrow_object(), the reference to the object is not > released when adding the devi

Re: [PATCH v3 0/2] ftpm: a firmware based TPM driver

2019-05-08 Thread Jarkko Sakkinen
On Tue, May 07, 2019 at 01:40:20PM -0400, Sasha Levin wrote: > On Mon, Apr 15, 2019 at 11:56:34AM -0400, Sasha Levin wrote: > > From: "Sasha Levin (Microsoft)" > > > > Changes since v2: > > > > - Drop the devicetree bindings patch (we don't add any new ones). > > - More code cleanups based on Ja

Re: [RFC][PATCH 4/4] x86_32: Provide consistent pt_regs

2019-05-08 Thread Ingo Molnar
* Josh Poimboeuf wrote: > On Wed, May 08, 2019 at 09:49:05AM +0200, Peter Zijlstra wrote: > > Currently pt_regs on x86_32 has an oddity in that kernel regs > > (!user_mode(regs)) are short two entries (esp/ss). This means that any > > code trying to use them (typically: regs->sp) needs to jump

Re: [RFC PATCH 4/6] sched/dl: Improve capacity-aware wakeup

2019-05-08 Thread luca abeni
Hi Juri, On Wed, 8 May 2019 14:05:26 +0200 Juri Lelli wrote: [...] > > > > + if ((rel_deadline < 0) || (rel_deadline * > > > > dl_se->dl_runtime < dl_se->dl_deadline * rem_runtime)) { > > > > + rel_deadline = dl_se->dl_deadline; > > > > + rem_runtime = dl_se->dl

Re: EDAC: Fix memory leak in creating CSROW object

2019-05-08 Thread Greg KH
On Wed, May 08, 2019 at 12:57:43PM +0200, Borislav Petkov wrote: > On Sat, Apr 27, 2019 at 11:49:25PM +0200, Greg KH wrote: > > How about this patch, I think it fixes up everything you need to do > > here, right? > > Almost, see the two patches as a reply to this message. I've taken > Pan's origin

Re: [PATCH 2/2] EDAC/sysfs: Drop device references properly

2019-05-08 Thread Greg KH
On Wed, May 08, 2019 at 01:06:05PM +0200, Borislav Petkov wrote: > -- > From: Greg KH > > Do put_device() if device_add() fails. > > [ bp: do device_del() for the successfully created devices in >edac_create_csrow_objects(), on the unwind path. ] Yes, good catch, looks good, thanks! greg

Re: [PATCH] x86/fpu: Remove the _GPL from the kernel_fpu_begin/end() export

2019-05-08 Thread Greg KH
On Wed, May 08, 2019 at 02:28:21PM +0200, Sebastian Gottschall wrote: > so the question is if it isnt possible to create a EXPORT_SYMBOL variant > which includes acceptable license models, but still restricts unacceptable > licenses It's not very difficult, "acceptable" license models are all desc

RE: [PATCH V2 2/4] nvmem: imx: add i.MX8 nvmem driver

2019-05-08 Thread Peng Fan
Hi Aisheng, > Subject: RE: [PATCH V2 2/4] nvmem: imx: add i.MX8 nvmem driver > > > From: Peng Fan > > Sent: Wednesday, May 8, 2019 10:56 AM > > > > This patch adds i.MX8 nvmem ocotp driver to access fuse via RPC to > > i.MX8 system controller. > > > > Cc: Srinivas Kandagatla > > Cc: Shawn Guo >

Re: serial: Add Milbeaut serial control

2019-05-08 Thread Sugaya, Taichi
Hi, Thank you for pointing out. On 2019/05/02 20:47, Colin Ian King wrote: Hi, Static analysis with Coverity has picked up an issue in commit: commit ba44dc04300441b47618f9933bf36e75a280e5fe Author: Sugaya Taichi Date: Mon Apr 15 20:31:40 2019 +0900 serial: Add Milbeaut serial contro

Re: [PATCH v2 0/2] Optimize dma_*_from_contiguous calls

2019-05-08 Thread Christoph Hellwig
Hi Nicolin, modulo a trivial comment typo I found this looks fine to me. I plan to apply it with that fixed up around -rc2 time when I open the dma mapping tree opens for the the 5.3 merge window, unless someone finds an issue until then.

[PATCH] drm/amd/display: Make some functions static

2019-05-08 Thread Wang Hai
Fix the following sparse warnings: drivers/gpu/drm/amd/amdgpu/../display/dc/dce120/dce120_resource.c:483:21: warning: symbol 'dce120_clock_source_create' was not declared. Should it be static? drivers/gpu/drm/amd/amdgpu/../display/dc/dce120/dce120_resource.c:506:6: warning: symbol 'dce120_clock

Re: [RFC PATCH v1 1/6] regulator: core: Introduce API for machine-specific regulators coupling

2019-05-08 Thread Dmitry Osipenko
08.05.2019 10:55, Mark Brown пишет: > On Sun, Apr 14, 2019 at 08:59:34PM +0300, Dmitry Osipenko wrote: >> Right now regulator core supports only one type of regulators coupling, >> the "voltage max-spread" which keeps voltages of coupled regulators in a >> given range. A more sophisticated coupling

Re: ptrace warning due to "cgroup: get rid of cgroup_freezer_frozen_exit()"

2019-05-08 Thread Qian Cai
On Tue, 2019-05-07 at 21:37 +, Roman Gushchin wrote: > Can you, please, try if the following patch fixes the problem? It works great. > -- > > diff --git a/kernel/signal.c b/kernel/signal.c > index 16b72f4f14df..bf2f268f1386 100644 > --- a/kernel/signal.c > +++ b/kernel/signal.c > @@ -2484,9

Re: [RFC PATCH 4/6] sched/dl: Improve capacity-aware wakeup

2019-05-08 Thread Juri Lelli
On 08/05/19 14:47, luca abeni wrote: [...] > Notice that all this logic is used only to select one of the idle cores > (instead of picking the first idle core, we select the less powerful > core on which the task "fits"). > > So, running_bw does not provide any useful information, in this case;

Re: [RFC PATCH v1 5/6] soc/tegra: regulators: Add regulators coupler for Tegra20

2019-05-08 Thread Dmitry Osipenko
08.05.2019 10:57, Mark Brown пишет: > On Sun, Apr 14, 2019 at 08:59:38PM +0300, Dmitry Osipenko wrote: >> Add regulators coupler for Tegra20 SoC's that performs voltage balancing >> of a coupled regulators and thus provides voltage scaling functionality. > > Can you say what the rules that this is

Re: [PATCH v7 11/13] ARM: dts: exynos: add syscon to clock compatible

2019-05-08 Thread Lukasz Luba
On 5/8/19 12:17 PM, Krzysztof Kozlowski wrote: > On Wed, 8 May 2019 at 11:50, Lukasz Luba wrote: >> >> >> On 5/8/19 9:22 AM, Krzysztof Kozlowski wrote: >>> On Mon, 6 May 2019 at 17:12, Lukasz Luba wrote: In order get the clock by phandle and use it with regmap it needs to be comp

Re: [PATCH v2] Documentation/trace: Add clarification how histogram onmatch works

2019-05-08 Thread Tom Zanussi
Hi Steve, On Tue, 2019-05-07 at 20:11 -0400, Steven Rostedt wrote: > Tom, > > Can you review this patch. > Sure. > Jon, > > After Tom gives his review, can you take this in your tree? > > Thanks! > > Reviewed-by: Steven Rostedt (VMware) > Reviewed-by: Tom Zanussi Thanks, Tom > -- Ste

[PATCHv3 00/12] perf tools: Display eBPF code in intel_pt trace

2019-05-08 Thread Jiri Olsa
hi, this patchset adds dso support to read and display bpf code in intel_pt trace output. I had to change some of the kernel maps processing code, so hopefully I did not break too many things ;-) It's now possible to see bpf code flow via: # perf-with-kcore record pt -e intel_pt//ku -- sleep 1

[PATCH 01/12] perf tools: Separate generic code in dso__data_file_size

2019-05-08 Thread Jiri Olsa
Moving file specific code in dso__data_file_size function into separate file_size function. I'll add bpf specific code in following patches. Link: http://lkml.kernel.org/n/tip-rkcsft4a0f8sw33p67llx...@git.kernel.org Signed-off-by: Jiri Olsa --- tools/perf/util/dso.c | 19 --- 1 f

[PATCH 02/12] perf tools: Separate generic code in dso_cache__read

2019-05-08 Thread Jiri Olsa
Moving file specific code in dso_cache__read function into separate file_read function. I'll add bpf specific code in following patches. Link: http://lkml.kernel.org/n/tip-7f7d717uzrqt5ka2xp29i...@git.kernel.org Signed-off-by: Jiri Olsa --- tools/perf/util/dso.c | 48

[PATCH 03/12] perf tools: Simplify dso_cache__read function

2019-05-08 Thread Jiri Olsa
There's no need for the while loop now, also we can connect two (ret > 0) condition legs together. Link: http://lkml.kernel.org/n/tip-2vg28bak8euojuvq33cy2...@git.kernel.org Signed-off-by: Jiri Olsa --- tools/perf/util/dso.c | 17 ++--- 1 file changed, 6 insertions(+), 11 deletions(-

[PATCH 05/12] perf tools: Read also the end of the kernel

2019-05-08 Thread Jiri Olsa
We mark the end of kernel based on the first module, but that could cover some bpf program maps. Reading _etext symbol if it's present to get precise kernel map end. Link: http://lkml.kernel.org/n/tip-ynut991ttyyhvo1sbhlm4...@git.kernel.org Signed-off-by: Jiri Olsa --- tools/perf/util/machine.c

[PATCH 07/12] perf script: Pad dso name for --call-trace

2019-05-08 Thread Jiri Olsa
Padding dso name for --call-trace so we don't have the indent screwed by different dso name lengths, as now for kernel there's also bpf code displayed. # perf-with-kcore record pt -e intel_pt//ku -- sleep 1 # perf-core/perf-with-kcore script pt --call-trace Before: sleep 36660 [016

[PATCH 06/12] perf tools: Keep zero in pgoff bpf map

2019-05-08 Thread Jiri Olsa
With pgoff set to zero, the map__map_ip function will return bpf address based from 0, which is what we need when we read the data from bpf dso. Adding bpf symbols with mapped ip addresses as well. Link: http://lkml.kernel.org/n/tip-nqgyzbqgekvxqc5tjmsb3...@git.kernel.org Signed-off-by: Jiri Olsa

[PATCH 09/12] perf tests: Add map_groups__merge_in test

2019-05-08 Thread Jiri Olsa
Adding map_groups__merge_in to test map_groups__merge_in function usage - merging kcore maps into existing eBPF maps. Link: http://lkml.kernel.org/n/tip-dj6v01kbt4upvkw3hccmc...@git.kernel.org Signed-off-by: Jiri Olsa --- tools/perf/tests/Build | 1 + tools/perf/tests/builtin-test.c |

[PATCH 08/12] perf tools: Preserve eBPF maps when loading kcore

2019-05-08 Thread Jiri Olsa
We need to preserve eBPF maps even if they are covered by kcore, because we need to access eBPF dso for source data. Adding map_groups__merge_in function to do that. It merges map into map_groups by splitting the new map within the existing map regions. Suggested-by: Adrian Hunter Link: http://l

[PATCH 11/12] perf script: Remove superfluous bpf event titles

2019-05-08 Thread Jiri Olsa
There's no need to display "ksymbol event with" text for PERF_RECORD_KSYMBOL event and "bpf event with" test for PERF_RECORD_BPF_EVENT event. Removing it so it also goes along with other side-band events display. Before: # perf script --show-bpf-events ... swapper 0 [000] 0.00:

[PATCH 10/12] perf script: Add --show-bpf-events to show eBPF related events

2019-05-08 Thread Jiri Olsa
Adding --show-bpf-events to show eBPF related events: PERF_RECORD_KSYMBOL PERF_RECORD_BPF_EVENT Usage: # perf record -a ... # perf script --show-bpf-events ... swapper 0 [000] 0.00: PERF_RECORD_KSYMBOL ksymbol event with addr c0ef971d len 229 type 1 flags 0x0 nam

[PATCH 12/12] perf script: Add --show-all-events option

2019-05-08 Thread Jiri Olsa
Adding --show-all-events option to show all side-bad events with single option, like: $ perf script --show-all-events swapper 0 [000] 0.00: PERF_RECORD_MMAP -1/0: [0xa600(0xc00e41) @ 0xa600]: x [kernel.kallsyms]_text ... swapper 0 [000] 0.00

[PATCH 04/12] perf tools: Add bpf dso read and size hooks

2019-05-08 Thread Jiri Olsa
Adding bpf related code into dso reading paths to return size (bpf_size) and read the bpf code (bpf_read). Link: http://lkml.kernel.org/n/tip-ql6jpegvv5823yc87u0hl...@git.kernel.org Signed-off-by: Jiri Olsa --- tools/perf/util/dso.c | 49 ++- 1 file change

RE: [PATCH] x86/entry/64: randomize kernel stack offset upon syscall

2019-05-08 Thread Reshetova, Elena
> * Reshetova, Elena wrote: > > > CONFIG_PAGE_TABLE_ISOLATION=n: > > > > base: Simple syscall: 0.0510 microseconds > > get_random_bytes(4096 bytes buffer): Simple syscall: 0.0597 microseconds > > > > So, pure speed wise get_random_bytes() with 1 page per-cpu buf

Re: [PATCH 03/16] lib,treewide: add new match_string() helper/macro

2019-05-08 Thread Ardelean, Alexandru
On Wed, 2019-05-08 at 15:18 +0200, Greg KH wrote: > > > On Wed, May 08, 2019 at 04:11:28PM +0300, Andy Shevchenko wrote: > > On Wed, May 08, 2019 at 02:28:29PM +0300, Alexandru Ardelean wrote: > > > This change re-introduces `match_string()` as a macro that uses > > > ARRAY_SIZE() to compute the

[PATCH] fs: make all new mount api fds cloexec by default

2019-05-08 Thread Christian Brauner
This makes file descriptors returned from the new syscalls of the new mount api cloexec by default. >From a userspace perspective it is rarely the case that fds are supposed to be inherited across exec. In fact, most of the time userspace either needs to remember to pass the _CLOEXEC flag along or

Re: [PATCH v3 01/11] platform/x86: asus-wmi: Fix hwmon device cleanup

2019-05-08 Thread Andy Shevchenko
On Fri, Apr 19, 2019 at 1:00 PM Yurii Pavlovskyi wrote: > > The driver does not clean up the hwmon device on exit or error. To > reproduce the bug, repeat rmmod, insmod to verify that device number > /sys/devices/platform/asus-nb-wmi/hwmon/hwmon?? grows every time. Replace > call for registering d

Re: [PATCH v3 00/11] asus-wmi: Support of ASUS TUF Gaming series laptops

2019-05-08 Thread Andy Shevchenko
On Fri, Apr 19, 2019 at 12:57 PM Yurii Pavlovskyi wrote: > > Hi, > > this is the third version of the patch series. Doesn't apply to the for-next branch. Individual comments on the patches are coming as well. > > Changelog: > v3: > * Use devm_* function in patch 01 > * Detect DSTS/DCTS using

Re: [PATCH v3 03/11] platform/x86: asus-wmi: Increase the input buffer size of WMI methods

2019-05-08 Thread Andy Shevchenko
On Fri, Apr 19, 2019 at 1:07 PM Yurii Pavlovskyi wrote: > > The asus-nb-wmi driver is matched by WMI alias but fails to load on TUF > Gaming series laptops producing multiple ACPI errors in the kernel log. > > The input buffer for WMI method invocation size is 2 dwords, whereas > 3 are expected by

Re: [RFC PATCH v1 6/6] soc/tegra: regulators: Add regulators coupler for Tegra30

2019-05-08 Thread Dmitry Osipenko
08.05.2019 10:58, Mark Brown пишет: > On Sun, Apr 14, 2019 at 08:59:39PM +0300, Dmitry Osipenko wrote: >> Add regulators coupler for Tegra30 SoC's that performs voltage balancing >> of a coupled regulators and thus provides voltage scaling functionality. > > Same here, what are the requirements th

[PATCH v7 5/6] selftests/ftrace: Add user-memory access syntax testcase

2019-05-08 Thread Masami Hiramatsu
Add a user-memory access syntax testcase which checks new user-memory access syntax and ustring type. Signed-off-by: Masami Hiramatsu --- Changes in v6: - Add $argN availability check --- .../ftrace/test.d/kprobe/kprobe_args_user.tc | 32 1 file changed, 32 insert

Re: Linux 5.0.14

2019-05-08 Thread Bhaskar Chowdhury
Thanks, a bunch Greg! On 11:23 Wed 08 May , Greg KH wrote: I'm announcing the release of the 5.0.14 kernel. All users of the 5.0 kernel series must upgrade. The updated 5.0.y git tree can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-5.0.y a

[RESEND PATCH] gnss: get serial speed from subdrivers

2019-05-08 Thread Loys Ollivier
The default serial speed was hardcoded in the code. Rename current-speed to default-speed. Add a function parameter that lets the subdrivers specify their default speed. If not specified fallback to the device-tree default-speed. Signed-off-by: Loys Ollivier --- Hello, This patch moves the curre

[PATCH v7 6/6] perf-probe: Add user memory access attribute support

2019-05-08 Thread Masami Hiramatsu
Add user memory access attribute for kprobe event arguments. If a given 'local variable' is in user-space, User can specify memory access method by '@user' suffix. This is not only for string but also for data structure. If we access a field of data structure in user memory from kernel on some arc

[PATCH v7 0/6] tracing/probes: uaccess: Add support user-space access

2019-05-08 Thread Masami Hiramatsu
Hi, Here is the v7 series of probe-event to support user-space access. Previous version is here. https://lkml.kernel.org/r/155289137555.7218.9282784065958321058.stgit@devnote2 In this version, I fixed some documentation according to Steve's comment. This can be applied against the latest tracing

[PATCH v7 4/6] tracing/probe: Support user-space dereference

2019-05-08 Thread Masami Hiramatsu
Support user-space dereference syntax for probe event arguments to dereference the data-structure or array in user-space. The syntax is just adding 'u' before an offset value. +|-u() e.g. +u8(%ax), +u0(+0(%si)) For example, if you probe do_sched_setscheduler(pid, policy, param) and record para

[PATCH v7 1/6] x86/uaccess: Allow access_ok() in irq context if pagefault_disabled

2019-05-08 Thread Masami Hiramatsu
WARN_ON_IN_IRQ() assumes that the access_ok() and following user memory access can sleep. But this assumption is not always correct; when the pagefault is disabled, following memory access will just returns -EFAULT and never sleep. Add pagefault_disabled() check in WARN_ON_ONCE() so that it can ig

[PATCH v7 3/6] tracing/probe: Add ustring type for user-space string

2019-05-08 Thread Masami Hiramatsu
Add "ustring" type for fetching user-space string from kprobe event. User can specify ustring type at uprobe event, and it is same as "string" for uprobe. Note that probe-event provides this option but it doesn't choose the correct type automatically since we have not way to decide the address is

[PATCH v7 2/6] uaccess: Add non-pagefault user-space read functions

2019-05-08 Thread Masami Hiramatsu
Add probe_user_read(), strncpy_from_unsafe_user() and strnlen_unsafe_user() which allows caller to access user-space in IRQ context. Current probe_kernel_read() and strncpy_from_unsafe() are not available for user-space memory, because it sets KERNEL_DS while accessing data. On some arch, user add

Re: [PATCH 4/7] sched: Add sched_load_rq tracepoint

2019-05-08 Thread Qais Yousef
On 05/06/19 11:18, Peter Zijlstra wrote: > On Mon, May 06, 2019 at 11:08:59AM +0200, Peter Zijlstra wrote: > > Also; I _really_ hate how fat they are. Why can't we do simple straight > > forward things like: > > > > trace_pelt_cfq(cfq); > > trace_pelt_rq(rq); > > trace_pelt_se(se); > >

Re: [PATCH v3 04/11] platform/x86: asus-wmi: Improve DSTS WMI method ID detection

2019-05-08 Thread Andy Shevchenko
On Fri, Apr 19, 2019 at 1:08 PM Yurii Pavlovskyi wrote: > > The DSTS method detection mistakenly selects DCTS instead of DSTS if > nothing is returned when the method ID is not defined in WMNB. As a result, > the control of keyboard backlight is not functional for TUF Gaming series > laptops. Impl

Re: [PATCH v3 0/7] crypto: x86: Fix indirect function call casts

2019-05-08 Thread Herbert Xu
On Tue, May 07, 2019 at 02:50:46PM -0700, Eric Biggers wrote: > > I don't know yet. It's difficult to read the code with 2 layers of macros. > > Hence why I asked why you didn't just change the prototypes to be compatible. I agree. Kees, since you're changing this anyway please make it look bet

Re: [RFC PATCH 1/5] net: dsa: mv88e6xxx: introduce support for two chips using direct smi addressing

2019-05-08 Thread Vivien Didelot
Hi Rasmus, On Wed, 8 May 2019 13:47:15 +0200, Andrew Lunn wrote: > > > > > > This works, but i think i prefer adding mv88e6xxx_smi_dual_chip_write, > > > mv88e6xxx_smi_dual_chip_read, and create a > > > mv88e6xxx_smi_single_chip_ops. > > > > Now that Vivien's "net: dsa: mv88e6xxx: refine SMI su

[PATCHv4 1/2] dt-bindings: cadence-quadspi: add options reset property

2019-05-08 Thread Dinh Nguyen
The QSPI module can have an optional reset signals that will hold the module in a reset state. Signed-off-by: Dinh Nguyen --- v4: no change v3: created base on review comments v2: did not exist v1: did not exist --- Documentation/devicetree/bindings/mtd/cadence-quadspi.txt | 4 1 file chang

<    1   2   3   4   5   6   7   8   >