[PATCH 2/2] livepatch: Remove duplicated code for early initialization

2019-05-03 Thread Petr Mladek
kobject_init() call added one more operation that has to be done when doing the early initialization of both static and dynamic livepatch structures. It would have been easier when the early initialization code was not duplicated. Let's deduplicate it for future generations of livepatching hackers

[PATCH 0/2] livepatch: Remove custom kobject state handling and duplicated code

2019-05-03 Thread Petr Mladek
Tobin's patch[1] uncovered that the livepatching code handles kobjects a too complicated way. The first patch removes the unnecessary custom kobject state handling. The second patch is an optional code deduplication. I did something similar already when introducing the atomic replace. But it was

Re: [PATCH -next] crypto: atmel - remove set but not used variable 'alg_name'

2019-05-03 Thread Herbert Xu
On Wed, Apr 24, 2019 at 03:53:52PM +0800, Yue Haibing wrote: > From: YueHaibing > > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/crypto/atmel-tdes.c: In function 'atmel_tdes_setkey': > drivers/crypto/atmel-tdes.c:803:14: warning: variable 'alg_name' set but not > used [-Wunused-bu

Re: [RFC][PATCH 1/2] x86: Allow breakpoints to emulate call functions

2019-05-03 Thread Steven Rostedt
On Fri, 3 May 2019 11:29:59 +0200 Peter Zijlstra wrote: > OMG, WTF, ARGH... That code is fsck'ing horrible. I'd almost argue to > always do the INT3 thing, just to avoid games like that. Hehe, that's almost the exact same thoughts I had when seeing this code ;-) > > That said; for normal trap

Re: [PATCH next 02/25] crypto: picoxcell: Use dev_get_drvdata()

2019-05-03 Thread Herbert Xu
On Tue, Apr 23, 2019 at 03:49:57PM +0800, Kefeng Wang wrote: > Using dev_get_drvdata directly. > > Cc: Jamie Iles > Cc: Herbert Xu > Cc: "David S. Miller" > Cc: linux-cry...@vger.kernel.org > Cc: linux-arm-ker...@lists.infradead.org > Signed-off-by: Kefeng Wang > --- > drivers/crypto/picoxcel

[PATCH 1/2] livepatch: Remove custom kobject state handling

2019-05-03 Thread Petr Mladek
kobject_init() always succeeds and sets the reference count to 1. It allows to always free the structures via kobject_put() and the related release callback. Note that the custom kobject state handling was used only because we did not know that kobject_put() can and actually should get called even

Re: [PATCH -next] crypto: ccree - Make cc_sec_disable static

2019-05-03 Thread Herbert Xu
On Sat, Apr 27, 2019 at 12:43:13AM +0800, Yue Haibing wrote: > From: YueHaibing > > Fix sparse warning: > > drivers/crypto/ccree/cc_driver.c:37:6: warning: > symbol 'cc_sec_disable' was not declared. Should it be static? > > Signed-off-by: YueHaibing > --- > drivers/crypto/ccree/cc_driver.c

Re: [PATCH v2 0/7] mmc: meson-gx: clean up and tuning update

2019-05-03 Thread Ulf Hansson
On Mon, 29 Apr 2019 at 12:44, Ulf Hansson wrote: > > On Tue, 23 Apr 2019 at 11:02, Jerome Brunet wrote: > > > > The purpose of this series is too improve reliability of the amlogic mmc > > driver on new (g12a) and old ones (axg, gxl, gxbb, etc...) > > > > * The 3 first patches are just harmless c

Re: [PATCH 5/5] asm-generic: remove ptrace.h

2019-05-03 Thread Arnd Bergmann
On Wed, May 1, 2019 at 1:40 PM Christoph Hellwig wrote: > > No one is using this helper anymore. > > Signed-off-by: Christoph Hellwig Acked-by: Arnd Bergmann

Re: [PATCH 14/15] um: switch to generic version of pte allocation

2019-05-03 Thread Anton Ivanov
On 02/05/2019 16:28, Mike Rapoport wrote: um allocates PTE pages with __get_free_page() and uses GFP_KERNEL | __GFP_ZERO for the allocations. Switch it to the generic version that does exactly the same thing for the kernel page tables and adds __GFP_ACCOUNT for the user PTEs. The pte_free()

Re: [PATCH v3] mmc: core: Verify SD bus width

2019-05-03 Thread Ulf Hansson
On Mon, 29 Apr 2019 at 19:32, Raul E Rangel wrote: > > The SD Physical Layer Spec says the following: Since the SD Memory Card > shall support at least the two bus modes 1-bit or 4-bit width, then any SD > Card shall set at least bits 0 and 2 (SD_BUS_WIDTH="0101"). > > This change verifies the car

Re: [PATCH V2 0/5] mmc: mmci: add busy detect for stm32 sdmmc variant

2019-05-03 Thread Ulf Hansson
On Tue, 30 Apr 2019 at 14:06, Ludovic BARRE wrote: > > > > On 4/30/19 1:13 PM, Ulf Hansson wrote: > > On Fri, 26 Apr 2019 at 09:46, Ludovic Barre wrote: > >> > >> From: Ludovic Barre > >> > >> This patch series adds busy detect for stm32 sdmmc variant. > >> Some adaptations are required: > >> -A

Re: [PATCH v2] mmc: usdhi6rol0: mark expected switch fall-throughs

2019-05-03 Thread Ulf Hansson
On Wed, 1 May 2019 at 22:36, Gustavo A. R. Silva wrote: > > In preparation to enabling -Wimplicit-fallthrough, mark switch > cases where we are expecting to fall through. > > This patch fixes the following warnings: > > In file included from drivers/mmc/host/usdhi6rol0.c:9: > drivers/mmc/host/usdh

Re: [PATCH-tip v7 01/20] locking/rwsem: Prevent decrement of reader count before increment

2019-05-03 Thread Waiman Long
On 5/3/19 8:06 AM, Peter Zijlstra wrote: > On Sun, Apr 28, 2019 at 05:25:38PM -0400, Waiman Long wrote: >> During my rwsem testing, it was found that after a down_read(), the >> reader count may occasionally become 0 or even negative. Consequently, >> a writer may steal the lock at that time and ex

Re: linux-next: build warning after merge of the btrfs-kdave tree

2019-05-03 Thread David Sterba
On Fri, May 03, 2019 at 10:21:05AM +1000, Stephen Rothwell wrote: > Hi David, > > After merging the btrfs-kdave tree, today's linux-next build (x86_64 > allmodconfig) produced this warning: > > fs/btrfs/props.c: In function 'inherit_props': > fs/btrfs/props.c:389:4: warning: 'num_bytes' may be us

Re: [PATCH-tip v7 09/20] locking/rwsem: Always release wait_lock before waking up tasks

2019-05-03 Thread Peter Zijlstra
On Sun, Apr 28, 2019 at 05:25:46PM -0400, Waiman Long wrote: > + /* > + * This waiter may have become first in the wait > + * list after re-acquring the wait_lock. The > + * rwsem_first_waiter() test in the main whi

[RESEND PATCH] ARM: dts: Add stmpe-adc DT node to Toradex T30 modules

2019-05-03 Thread Philippe Schenker
From: Philippe Schenker Add the stmpe-adc DT node as found on Toradex T30 modules Signed-off-by: Philippe Schenker --- arch/arm/boot/dts/tegra30-apalis-v1.1.dtsi | 22 ++ arch/arm/boot/dts/tegra30-apalis.dtsi | 22 ++ arch/arm/boot/dts/tegra30-col

Re: [RESEND PATCH v3 09/11] powerpc/mm/radix: mark __radix__flush_tlb_range_psize() as __always_inline

2019-05-03 Thread Masahiro Yamada
Hi Christophe, On Tue, Apr 30, 2019 at 12:36 AM Christophe Leroy wrote: > > > > Le 23/04/2019 à 05:49, Masahiro Yamada a écrit : > > This prepares to move CONFIG_OPTIMIZE_INLINING from x86 to a common > > place. We need to eliminate potential issues beforehand. > > How did you identify the funct

[PATCH] svm/avic: Do not send AVIC doorbell to self

2019-05-03 Thread Suthikulpanit, Suravee
AVIC doorbell is used to notify a running vCPU that interrupts has been injected into the vCPU AVIC backing page. Current logic checks only if a VCPU is running before sending a doorbell. However, the doorbell is not necessary if the destination CPU is itself. Add logic to check currently running

[PATCH] svm/avic: Allow avic_vcpu_load logic to support host APIC ID 255

2019-05-03 Thread Suthikulpanit, Suravee
Current logic does not allow VCPU to be loaded onto CPU with APIC ID 255. This should be allowed since the host physical APIC ID field in the AVIC Physical APIC table entry is an 8-bit value, and APIC ID 255 is valid in system with x2APIC enabled. Instead, do not allow VCPU load if the host APIC I

Re: [PATCH] powerpc/powernv/ioda2: Add __printf format/argument verification

2019-05-03 Thread Michael Ellerman
Joe Perches writes: > On Fri, 2019-05-03 at 16:59 +1000, Michael Ellerman wrote: >> On Thu, 2017-03-30 at 10:19:25 UTC, Joe Perches wrote: >> > Fix fallout too. >> > >> > Signed-off-by: Joe Perches >> >> Applied to powerpc next, thanks. >> >> https://git.kernel.org/powerpc/c/1e496391a845210130

[PATCH V3] watchdog: stm32: add dynamic prescaler support

2019-05-03 Thread Ludovic Barre
From: Ludovic Barre This patch allows to define the max prescaler by compatible. To set a large range of timeout, the prescaler should be set dynamically (from the timeout request) to improve the resolution in order to have a timeout close to the expected value. Signed-off-by: Ludovic Barre ---

Re: [PATCH 2/3] s390: remove ARCH_SELECT_MEMORY_MODEL

2019-05-03 Thread Heiko Carstens
On Wed, May 01, 2019 at 10:56:16PM +0300, Mike Rapoport wrote: > The only reason s390 has ARCH_SELECT_MEMORY_MODEL option in > arch/s390/Kconfig is an ancient compile error with allnoconfig which was > fixed by commit 97195d6b411f ("[S390] fix sparsemem related compile error > with allnoconfig on s

[PATCH v16] platform/mellanox: Add TmFifo driver for Mellanox BlueField Soc

2019-05-03 Thread Liming Sun
This commit adds the TmFifo platform driver for Mellanox BlueField Soc. TmFifo is a shared FIFO which enables external host machine to exchange data with the SoC via USB or PCIe. The driver is based on virtio framework and has console and network access enabled. Reviewed-by: Vadim Pasternak Signe

Re: linux-next: Signed-off-by missing for commit in the btrfs-kdave tree

2019-05-03 Thread David Sterba
On Fri, May 03, 2019 at 07:35:39AM +1000, Stephen Rothwell wrote: > Hi all, > > Commit > > b835a4a3faec ("btrfs: use the existing reserved items for our first prop > for inheritance") > > is missing a Signed-off-by from its author. Will be fixed in next for-next snapshot, thanks.

[PATCH] soc: imx: Get iMX8MQ revision for B0 from ATF

2019-05-03 Thread Guido Günther
This is similar to what the BSP does and needed to e.g. determine necessary quirks for MIPI DSI. Signed-off-by: Guido Günther --- >From the list discussion and changelog it's not clear to me why a different method was chosen for the B1 silicon so I left that in place as is and only trigger on th

Re: [PATCH v2] mmc: usdhi6rol0: mark expected switch fall-throughs

2019-05-03 Thread Gustavo A. R. Silva
On 5/3/19 8:29 AM, Ulf Hansson wrote: > On Wed, 1 May 2019 at 22:36, Gustavo A. R. Silva > wrote: >> >> In preparation to enabling -Wimplicit-fallthrough, mark switch >> cases where we are expecting to fall through. >> [..] >> >> Warning level 3 was used: -Wimplicit-fallthrough=3 >> >> This

Re: [PATCH-tip v7 09/20] locking/rwsem: Always release wait_lock before waking up tasks

2019-05-03 Thread Waiman Long
On 5/3/19 9:37 AM, Peter Zijlstra wrote: > On Sun, Apr 28, 2019 at 05:25:46PM -0400, Waiman Long wrote: > >> +/* >> + * This waiter may have become first in the wait >> + * list after re-acquring the wait_lock. The >> +

[PATCH 3/3] iio: stmpe-adc: Enable all stmpe-adc interrupts just once

2019-05-03 Thread Philippe Schenker
From: Philippe Schenker This commit will enable the interrupts of all channels handled by this driver only once in the probe function. This will improve performance because one byte less has to be written over i2c on each read out of the adc. On the fastest ADC mode this will improve read out sp

[PATCH 1/3] iio: stmpe-adc: Remove unnecessary assignment

2019-05-03 Thread Philippe Schenker
From: Philippe Schenker Remove unnecessary assignment. This could potentially cause an issue, if the wait function runs into a timeout. Furthermore is this assignment also not there in stmpe_read_temp() Signed-off-by: Philippe Schenker --- drivers/iio/adc/stmpe-adc.c | 2 -- 1 file changed, 2

[PATCH 2/3] iio: stmpe-adc: Make wait_completion non interruptible

2019-05-03 Thread Philippe Schenker
From: Philippe Schenker In some cases, the wait_completion got interrupted. This caused the error-handling to mutex_unlock the function. The before turned on interrupt then got called anyway. In the ISR then completion() was called causing problems. Making this wait_completion non interruptible

Re: [PATCH-tip v7 08/20] locking/rwsem: Implement lock handoff to prevent lock starvation

2019-05-03 Thread Waiman Long
On 5/3/19 9:10 AM, Peter Zijlstra wrote: > On Sun, Apr 28, 2019 at 05:25:45PM -0400, Waiman Long wrote: >> +static inline bool rwsem_try_write_lock(long count, struct rw_semaphore >> *sem, >> +enum writer_wait_state wstate) >> { >> long new; >> >> +l

Re: [PATCH] MAINTAINERS: update git tree for sound entries

2019-05-03 Thread Ross Zwisler
On Fri, May 3, 2019 at 2:17 AM Takashi Iwai wrote: > > On Thu, 02 May 2019 19:27:00 +0200, > Ross Zwisler wrote: > > > > Several sound related entries in MAINTAINERS refer to the old git tree > > at "git://git.alsa-project.org/alsa-kernel.git". This is no longer used > > for development, and Taka

Re: [PATCH v3 1/4] ptrace: move clearing of TIF_SYSCALL_EMU flag to core

2019-05-03 Thread Oleg Nesterov
On 05/02, Will Deacon wrote: > > Ok, if you're happy for us to take them via arm64 with your ack, then we can > do that as well. Yes, yes, please! Oleg.

Re: [rcu:dev.2019.04.28a 85/85] htmldocs: kernel/rcu/sync.c:74: warning: Function parameter or member 'rcu' not described in 'rcu_sync_func'

2019-05-03 Thread Paul E. McKenney
On Fri, May 03, 2019 at 02:58:59PM +0800, kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git > dev.2019.04.28a > head: a4e0e069df6e8718bf165fb009cd3a23e7a808a3 > commit: a4e0e069df6e8718bf165fb009cd3a23e7a808a3 [85/85] rcu/sync: Simplify > t

Re: [RT WARNING] DEBUG_LOCKS_WARN_ON(rt_mutex_owner(lock) != current) with fsfreeze (4.19.25-rt16)

2019-05-03 Thread Peter Zijlstra
On Thu, May 02, 2019 at 12:09:32PM +0200, Oleg Nesterov wrote: > On 05/01, Peter Zijlstra wrote: > > > > Anyway; I cobbled together the below. Oleg, could you have a look, I'm > > sure I messed it up. > > Oh, I will need to read this carefully. but at first glance I do not see > any hole... > > >

Re: [PATCH] MAINTAINERS: update git tree for sound entries

2019-05-03 Thread Takashi Iwai
On Fri, 03 May 2019 16:06:40 +0200, Ross Zwisler wrote: > > On Fri, May 3, 2019 at 2:17 AM Takashi Iwai wrote: > > > > On Thu, 02 May 2019 19:27:00 +0200, > > Ross Zwisler wrote: > > > > > > Several sound related entries in MAINTAINERS refer to the old git tree > > > at "git://git.alsa-project.or

Re: [PATCH] kexec_buffer measure

2019-05-03 Thread Mimi Zohar
On Fri, 2019-05-03 at 09:53 +0900, Tetsuo Handa wrote: > On 2019/05/03 1:28, Casey Schaufler wrote: > > On 5/2/2019 8:48 AM, Mimi Zohar wrote: > >> [Cc'ing Paul, John, Casey] > >> > >> On Mon, 2019-04-22 at 20:18 -0400, Mimi Zohar wrote: > >>> [Cc'ing LSM mailing list] > >>> > >>> On Fri, 2019-04-1

Re: [RFC PATCH v1 08/10] KVM: X86: Introduce KVM_HC_PAGE_ENC_STATUS hypercall

2019-05-03 Thread Singh, Brijesh
On 4/26/19 4:39 PM, Lendacky, Thomas wrote: > On 4/24/19 11:10 AM, Singh, Brijesh wrote: >> The hypercall can be used by the SEV guest to notify the page encryption > > This hyercall is used by the SEV guest to notify a change in the page... > >> status to the hypervisor. The hypercall should b

Re: [PATCH v2 1/4] s390: only build for new CPUs with clang

2019-05-03 Thread Heiko Carstens
On Mon, Apr 15, 2019 at 10:35:51AM +0200, Arnd Bergmann wrote: > llvm does does not understand -march=z9-109 and older target > specifiers, so disable the respective Kconfig settings and > the logic to make the boot code work on old systems when > building with clang. > > Part of the early boot co

Re: [PATCH v2 2/4] s390: boot, purgatory: pass $(CLANG_FLAGS) where needed

2019-05-03 Thread Heiko Carstens
On Mon, Apr 15, 2019 at 09:12:06AM -0700, Nathan Chancellor wrote: > On Mon, Apr 15, 2019 at 10:35:52AM +0200, Arnd Bergmann wrote: > > The purgatory and boot Makefiles do not inherit the original cflags, > > so clang falls back to the default target architecture when building it, > > typically thi

Re: [PATCH v2 3/4] s390: drop CONFIG_VIRT_TO_BUS

2019-05-03 Thread Heiko Carstens
On Mon, Apr 15, 2019 at 10:35:53AM +0200, Arnd Bergmann wrote: > VIRT_TO_BUS is only used for legacy device PCI and ISA drivers using > virt_to_bus() instead of the streaming DMA mapping API, and the > remaining drivers generally don't work on 64-bit architectures. > > Two of these drivers also ca

Re: [PATCH v3 0/9] klp-convert livepatch build tooling

2019-05-03 Thread Joe Lawrence
On Tue, Apr 16, 2019 at 01:37:13PM +0200, Miroslav Benes wrote: > > [ ... snip ... ] > > Quick look, but it seems quite similar to the problem we had with > apply_alternatives(). See arch/x86/kernel/livepatch.c and the commit which > introduced it. That was an interesting diversion :) I think I g

Re: [PATCH v2 2/2] regmap: soundwire: fix Kconfig select/depend issue

2019-05-03 Thread Pierre-Louis Bossart
On 5/2/19 11:39 PM, Mark Brown wrote: On Fri, Apr 19, 2019 at 02:46:49PM -0500, Pierre-Louis Bossart wrote: config REGMAP_SOUNDWIRE tristate - depends on SOUNDWIRE_BUS + select SOUNDWIRE_BUS This now makes _SOUNDWIRE different to all the other bus types; if this is a

[PATCH] Documentation/trace: Add clarification how histogram onmatch works

2019-05-03 Thread Tzvetomir Stoyanov
The current trace documentation, the section describing histogram's "onmatch" is not straightforward enough about how this action is applied. It is not clear what criteria are used to "match" both events. A short note is added, describing what exactly is compared in order to match the events. Sign

[PATCH v4 04/10] net: davinci: support of_get_mac_address new ERR_PTR error

2019-05-03 Thread Petr Štetiar
There was NVMEM support added directly to of_get_mac_address, and it uses nvmem_get_mac_address under the hood, so we can remove it. As of_get_mac_address can now return ERR_PTR encoded error values, adjust to that as well. Signed-off-by: Petr Štetiar --- Changes since v2: * ERR_PTR handling

Re: [PATCH v2 11/17] kunit: test: add test managed resource tests

2019-05-03 Thread shuah
On 5/1/19 5:01 PM, Brendan Higgins wrote: From: Avinash Kondareddy Tests how tests interact with test managed resources in their lifetime. Signed-off-by: Avinash Kondareddy Signed-off-by: Brendan Higgins --- I think this change log could use more details. It is vague on what it does. than

Re: [PATCH v3 6/7] irqchip/gic-v3-mbi: Don't map the MSI page in mbi_compose_m{b, s}i_msg()

2019-05-03 Thread Marc Zyngier
On 01/05/2019 14:58, Julien Grall wrote: > The functions mbi_compose_m{b, s}i_msg may be called from non-preemptible > context. However, on RT, iommu_dma_map_msi_msg() requires to be called > from a preemptible context. > > A recent patch split iommu_dma_map_msi_msg in two new functions: > one tha

[PATCH] net: e1000: Fix some bugs in error handling code of e1000_probe()

2019-05-03 Thread Jia-Ju Bai
When "hw->ce4100_gbe_mdio_base_virt = ioremap(...)" fails, the driver does not free the memory allocated in e1000_sw_init(), and also calls "iounmap(hw->ce4100_gbe_mido_base_virt)" that is unnecessary. Besides, when e1000_sw_init() fails, the driver also calls "iounmap(hw->ce4100_gbe_mido_base_vi

[PATCH v4 03/10] net: macb: support of_get_mac_address new ERR_PTR error

2019-05-03 Thread Petr Štetiar
There was NVMEM support added directly to of_get_mac_address, and it uses nvmem_get_mac_address under the hood, so we can remove it. As of_get_mac_address can now return ERR_PTR encoded error values, adjust to that as well. Signed-off-by: Petr Štetiar --- Changes since v2: * ERR_PTR and EPROB

Re: [PATCH v4 01/10] of_net: add NVMEM support to of_get_mac_address

2019-05-03 Thread Maxime Ripard
On Fri, May 03, 2019 at 04:27:06PM +0200, Petr Štetiar wrote: > Many embedded devices have information such as MAC addresses stored > inside NVMEMs like EEPROMs and so on. Currently there are only two > drivers in the tree which benefit from NVMEM bindings. > > Adding support for NVMEM into every o

[PATCH v4 09/10] ARM: Kirkwood: support of_get_mac_address new ERR_PTR error

2019-05-03 Thread Petr Štetiar
There was NVMEM support added to of_get_mac_address, so it could now return ERR_PTR encoded error values, so we need to adjust all current users of of_get_mac_address to this new fact. Signed-off-by: Petr Štetiar --- Changes since v3: * IS_ERR_OR_NULL -> IS_ERR arch/arm/mach-mvebu/kirkwood

[PATCH v4 06/10] net: usb: support of_get_mac_address new ERR_PTR error

2019-05-03 Thread Petr Štetiar
There was NVMEM support added to of_get_mac_address, so it could now return ERR_PTR encoded error values, so we need to adjust all current users of of_get_mac_address to this new fact. Signed-off-by: Petr Štetiar --- Changes since v3: * IS_ERR_OR_NULL -> IS_ERR drivers/net/usb/smsc75xx.c |

RE: [PATCH-tip v7 08/20] locking/rwsem: Implement lock handoff to prevent lock starvation

2019-05-03 Thread David Laight
From: Peter Zijlstra > Sent: 03 May 2019 14:11 > To: Waiman Long ... > I've changed that like so. > > --- a/kernel/locking/rwsem.c > +++ b/kernel/locking/rwsem.c > @@ -406,19 +406,23 @@ static inline bool rwsem_try_write_lock( > long new; > > lockdep_assert_held(&sem->wait_lock); > +

Re: [PATCH v2 15/17] MAINTAINERS: add entry for KUnit the unit testing framework

2019-05-03 Thread shuah
On 5/1/19 5:01 PM, Brendan Higgins wrote: Add myself as maintainer of KUnit, the Linux kernel's unit testing framework. Signed-off-by: Brendan Higgins --- MAINTAINERS | 10 ++ 1 file changed, 10 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 5c38f21aee787..c78ae95c56b80

RE: [PATCH 2/3] iio: stmpe-adc: Make wait_completion non interruptible

2019-05-03 Thread David Laight
From: Philippe Schenker > Sent: 03 May 2019 14:57 > In some cases, the wait_completion got interrupted. This caused the > error-handling to mutex_unlock the function. The before turned on > interrupt then got called anyway. In the ISR then completion() > was called causing problems. > > Making thi

Re: [PATCH] s390: vdso: drop unnecessary cc-ldoption

2019-05-03 Thread Heiko Carstens
On Tue, Apr 30, 2019 at 01:25:09PM -0700, Nick Desaulniers wrote: > On Tue, Apr 23, 2019 at 2:01 PM Nick Desaulniers > wrote: > > > > Towards the goal of removing cc-ldoption, it seems that --hash-style= > > was added to binutils 2.17.50.0.2 in 2006. The minimal required version > > of binutils fo

Re: [PATCH v2 RESEND] i2c-piix4: Add Hygon Dhyana SMBus support

2019-05-03 Thread Wolfram Sang
On Tue, Apr 30, 2019 at 12:08:43AM +0800, Pu Wen wrote: > The Hygon Dhyana CPU has the SMBus device with PCI device ID 0x790b, > which is the same as AMD CZ SMBus device. So add Hygon Dhyana support > to the i2c-piix4 driver by using the code path of AMD. > > Signed-off-by: Pu Wen > Reviewed-by:

Re: [RT WARNING] DEBUG_LOCKS_WARN_ON(rt_mutex_owner(lock) != current) with fsfreeze (4.19.25-rt16)

2019-05-03 Thread Peter Zijlstra
On Thu, May 02, 2019 at 01:42:59PM +0200, Oleg Nesterov wrote: > On 05/02, Oleg Nesterov wrote: > > > > But this all is cosmetic, it seems that we can remove ->rw_sem altogether > > but I am not sure... > > I mean, afaics percpu_down_read() can just do > > wait_event(readers_block == 0); >

Re: [PATCH v5 net-next 00/12] NXP SJA1105 DSA driver

2019-05-03 Thread David Miller
From: Vladimir Oltean Date: Thu, 2 May 2019 23:23:28 +0300 > This patchset adds a DSA driver for the SPI-controlled NXP SJA1105 > switch. Series applied, thank you.

Re: [PATCH] i2c: imx-lpi2c: Use __maybe_unused instead of #if CONFIG_PM_SLEEP

2019-05-03 Thread Wolfram Sang
On Tue, Apr 30, 2019 at 07:00:02AM +, Anson Huang wrote: > Use __maybe_unused for power management related functions > instead of #if CONFIG_PM_SLEEP to simply the code. > > Signed-off-by: Anson Huang Applied to for-next, thanks! signature.asc Description: PGP signature

f68f031d ("Documentation: atomic_t.txt: Explain ordering provided by smp_mb__{before,after}_atomic()")

2019-05-03 Thread Paul E. McKenney
Hello, Alan, Just following up on the -rcu commit below. I believe that it needs some adjustment given Peter Zijlstra's addition of "memory" to the x86 non-value-returning atomics, but thought I should double-check. Thanx, Paul ---

[GIT PULL] irqchip updates for 5.2

2019-05-03 Thread Marc Zyngier
Hi Thomas, Here's the set of irqchip (and related) updates for 5.2. The main offenders are the TI SCI drivers, which we've finally managed to fit in the MSI framework. It comes with its own firmware interface, hence some touching some files outside of the usual areas. Another one is the revamp of

Re: [PATCH 3/3] reset: Add reset controller support for BM1880 SoC

2019-05-03 Thread Philipp Zabel
Hi Manivannan, thank you for the patch. A few issues below: On Thu, 2019-04-25 at 18:25 +0530, Manivannan Sadhasivam wrote: > Add reset controller support for Bitmain BM1880 SoC reusing the > reset-simple driver. While we are at it, this driver has also been > modified to make use of the SPDX lic

Re: [PATCH] Documentation/trace: Add clarification how histogram onmatch works

2019-05-03 Thread Steven Rostedt
On Fri, 3 May 2019 17:35:37 +0300 Tzvetomir Stoyanov wrote: > The current trace documentation, the section describing histogram's "onmatch" > is not straightforward enough about how this action is applied. It is not > clear what criteria are used to "match" both events. A short note is added, >

Re: [rcu:dev.2019.04.28a 85/85] htmldocs: kernel/rcu/sync.c:74: warning: Function parameter or member 'rcu' not described in 'rcu_sync_func'

2019-05-03 Thread Oleg Nesterov
On 05/03, Paul E. McKenney wrote: > > > >> kernel/rcu/sync.c:74: warning: Function parameter or member 'rcu' not > > >> described in 'rcu_sync_func' > >kernel/rcu/sync.c:74: warning: Excess function parameter 'rhp' > > description in 'rcu_sync_func' > > Good catch! I will be folding in the d

Re: [PATCH v5 4/4] coresight: funnel: Support static funnel

2019-05-03 Thread Suzuki K Poulose
Leo, On 12/04/2019 11:27, Leo Yan wrote: Since CoreSight hardware topology can use a 'hidden' funnel in the trace data path, this kind funnel doesn't have register for accessing and is used by default from hardware design perspective. Below is an example for related hardware topology: +---

Re: [RFC PATCH 1/2] mmc: sdhci: Manually check card status after reset

2019-05-03 Thread Raul Rangel
On Wed, May 01, 2019 at 11:54:56AM -0600, Raul E Rangel wrote: > I am running into a kernel panic. A task gets stuck for more than 120 > seconds. I keep seeing blkdev_close in the stack trace, so maybe I'm not > calling something correctly? > > Here is the panic: > https://privatebin.net/?8ec48c1

Re: [PATCH V2 0/5] mmc: mmci: add busy detect for stm32 sdmmc variant

2019-05-03 Thread Ludovic BARRE
hi Ulf On 5/3/19 3:29 PM, Ulf Hansson wrote: On Tue, 30 Apr 2019 at 14:06, Ludovic BARRE wrote: On 4/30/19 1:13 PM, Ulf Hansson wrote: On Fri, 26 Apr 2019 at 09:46, Ludovic Barre wrote: From: Ludovic Barre This patch series adds busy detect for stm32 sdmmc variant. Some adaptations ar

Re: [PATCH v2 4/4] s390: fix clang -Wpointer-sign warnigns in boot code

2019-05-03 Thread Heiko Carstens
On Mon, Apr 15, 2019 at 10:35:54AM +0200, Arnd Bergmann wrote: > The arch/s390/boot directory is built with its own set of compiler > options that does not include -Wno-pointer-sign like the rest of > the kernel does, this causes a lot of harmess but correct warnings > when building with clang. >

Re: f68f031d ("Documentation: atomic_t.txt: Explain ordering provided by smp_mb__{before,after}_atomic()")

2019-05-03 Thread Peter Zijlstra
On Fri, May 03, 2019 at 07:53:26AM -0700, Paul E. McKenney wrote: > Hello, Alan, > > Just following up on the -rcu commit below. I believe that it needs > some adjustment given Peter Zijlstra's addition of "memory" to the x86 > non-value-returning atomics, but thought I should double-check. Righ

Re: [PATCH-tip v7 12/20] locking/rwsem: Clarify usage of owner's nonspinaable bit

2019-05-03 Thread Peter Zijlstra
On Sun, Apr 28, 2019 at 05:25:49PM -0400, Waiman Long wrote: > Bit 1 of sem->owner (RWSEM_ANONYMOUSLY_OWNED) is used to designate an > anonymous owner - readers or an anonymous writer. The setting of this > anonymous bit is used as an indicator that optimistic spinning cannot > be done on this rwse

Re: [RT WARNING] DEBUG_LOCKS_WARN_ON(rt_mutex_owner(lock) != current) with fsfreeze (4.19.25-rt16)

2019-05-03 Thread Peter Zijlstra
On Fri, May 03, 2019 at 04:50:59PM +0200, Peter Zijlstra wrote: > So how about something like so then? > --- a/kernel/locking/percpu-rwsem.c > +++ b/kernel/locking/percpu-rwsem.c > @@ -63,7 +66,7 @@ int __percpu_down_read(struct percpu_rw_ >* If !readers_block the critical section starts

Re: [PATCH-tip v7 12/20] locking/rwsem: Clarify usage of owner's nonspinaable bit

2019-05-03 Thread Waiman Long
On 5/3/19 11:21 AM, Peter Zijlstra wrote: > On Sun, Apr 28, 2019 at 05:25:49PM -0400, Waiman Long wrote: >> Bit 1 of sem->owner (RWSEM_ANONYMOUSLY_OWNED) is used to designate an >> anonymous owner - readers or an anonymous writer. The setting of this >> anonymous bit is used as an indicator that op

Re: [PATCH] overlayfs: ignore empty NFSv4 ACLs in ext4 upperdir

2019-05-03 Thread J. Bruce Fields
On Thu, May 02, 2019 at 05:51:12PM +, Goetz, Patrick G wrote: > > > On 5/2/19 12:44 PM, Andreas Gruenbacher wrote: > > On Thu, 2 May 2019 at 19:27, Goetz, Patrick G > > wrote: > >> On 5/1/19 10:57 PM, NeilBrown wrote: > >>> Support some day support for nfs4 acls were added to ext4 (not a to

Re: [PATCH v3] x86: mm: Do not use set_{pud,pmd}_safe when splitting the large page

2019-05-03 Thread Singh, Brijesh
Hi Boris, On 4/17/19 12:24 PM, Dave Hansen wrote: ... > > The comment here is missing one key point: > kernel_physical_mapping_init() can only be used to populate non-present > entries. It kinda infers that from "Create...", but I really think we > need to be explicit. > > Anyway, it's better

Re: [PATCH] overlayfs: ignore empty NFSv4 ACLs in ext4 upperdir

2019-05-03 Thread J. Bruce Fields
On Thu, May 02, 2019 at 12:02:33PM +1000, NeilBrown wrote: > On Tue, Dec 06 2016, J. Bruce Fields wrote: > > > On Tue, Dec 06, 2016 at 02:18:31PM +0100, Andreas Gruenbacher wrote: > >> On Tue, Dec 6, 2016 at 11:08 AM, Miklos Szeredi wrote: > >> > On Tue, Dec 6, 2016 at 12:24 AM, Andreas Grünbache

Re: [RT WARNING] DEBUG_LOCKS_WARN_ON(rt_mutex_owner(lock) != current) with fsfreeze (4.19.25-rt16)

2019-05-03 Thread Oleg Nesterov
On 05/03, Peter Zijlstra wrote: > > On Thu, May 02, 2019 at 12:09:32PM +0200, Oleg Nesterov wrote: > > > > +static void readers_block(struct percpu_rw_semaphore *sem) > > > +{ > > > + wait_event_cmd(sem->writer, !sem->readers_block, > > > +__up_read(&sem->rw_sem), __down_read(&sem-

Re: [PATCH 0/2] livepatch: Remove custom kobject state handling and duplicated code

2019-05-03 Thread Joe Lawrence
On Fri, May 03, 2019 at 03:26:23PM +0200, Petr Mladek wrote: > Tobin's patch[1] uncovered that the livepatching code handles kobjects > a too complicated way. > > The first patch removes the unnecessary custom kobject state handling. > > The second patch is an optional code deduplication. I did s

Re: [PATCH 2/2] prctl.2: Document the new PR_GET_TASK_SIZE option

2019-05-03 Thread Joel Savitz
On Fri, May 3, 2019 at 7:20 AM David Laight wrote: > Shouldn't this say what the value is? > ISTR a recent patch to change the was the 'used to be constant' TASK_SIZE is > defined. > I think it might be 'The highest userspace virtual address the current > process can use.' But I might be wrong.

[PATCH] rtc: imxdi: remove unused variable

2019-05-03 Thread Anders Roxell
This variable is no longer used and the compiler rightly complains that it should be removed. ../drivers/rtc/rtc-imxdi.c: In function ‘dryice_rtc_set_alarm’: ../drivers/rtc/rtc-imxdi.c:633:16: warning: unused variable ‘now’ [-Wunused-variable] unsigned long now; ^~~ Rework to r

Re: [RT WARNING] DEBUG_LOCKS_WARN_ON(rt_mutex_owner(lock) != current) with fsfreeze (4.19.25-rt16)

2019-05-03 Thread Peter Zijlstra
On Fri, May 03, 2019 at 05:37:48PM +0200, Oleg Nesterov wrote: > (And if we change this code to use wait_event(xchg(readers_block) == 0) we > can remove rw_sem altogether). That patch you just saw and didn't look at did just that. > The main problem is that this is sub-optimal. We can have a lot

Re: [PATCH] rtc: imxdi: remove unused variable

2019-05-03 Thread Alexandre Belloni
On 03/05/2019 17:42:17+0200, Anders Roxell wrote: > This variable is no longer used and the compiler rightly complains that > it should be removed. > > ../drivers/rtc/rtc-imxdi.c: In function ‘dryice_rtc_set_alarm’: > ../drivers/rtc/rtc-imxdi.c:633:16: warning: unused variable ‘now’ > [-Wunused-v

Re: linux-next: build failure after merge of the clk tree

2019-05-03 Thread Stephen Boyd
Quoting Stephen Rothwell (2019-05-02 16:25:11) > Hi all, > > After merging the clk tree, today's linux-next build (arm > multi_v7_defconfig) failed like this: > > arch/arm/mach-omap2/omap_hwmod.c: In function '_get_clkdm': > arch/arm/mach-omap2/omap_hwmod.c:669:35: error: 'CLK_IS_BASIC' undeclare

RE: [PATCH V2] clk: imx: pllv4: add fractional-N pll support

2019-05-03 Thread Stephen Boyd
Quoting Aisheng Dong (2019-05-02 19:38:34) > > From: Stephen Boyd [mailto:sb...@kernel.org] > > Sent: Thursday, May 2, 2019 5:01 AM > > > > The Content-transfer-encoding header is still base64. I guess it can't be > > fixed. > > > > How can we know it's base64? > As I saw from the 'Headers' in

[GIT PULL] GNSS updates for 5.2-rc1

2019-05-03 Thread Johan Hovold
The following changes since commit 79a3aaa7b82e3106be97842dedfd8429248896e6: Linux 5.1-rc3 (2019-03-31 14:39:29 -0700) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/johan/gnss.git tags/gnss-5.2-rc1 for you to fetch changes up to 7cc10c5cb14397d61d2

Re: [PATCH 2/3] iio: stmpe-adc: Make wait_completion non interruptible

2019-05-03 Thread Philippe Schenker
On Fri, 2019-05-03 at 14:39 +, David Laight wrote: > From: Philippe Schenker > > Sent: 03 May 2019 14:57 > > In some cases, the wait_completion got interrupted. This caused the > > error-handling to mutex_unlock the function. The before turned on > > interrupt then got called anyway. In the ISR

RE: [PATCH V2] clk: imx: pllv4: add fractional-N pll support

2019-05-03 Thread Stephen Boyd
Quoting Aisheng Dong (2019-05-02 19:38:34) > > From: Stephen Boyd [mailto:sb...@kernel.org] > > Sent: Thursday, May 2, 2019 5:01 AM > > > > The Content-transfer-encoding header is still base64. I guess it can't be > > fixed. > > > > How can we know it's base64? > As I saw from the 'Headers' in

Re: [PATCH] clk: imx: clk-pllv3: mark expected switch fall-throughs

2019-05-03 Thread Stephen Boyd
Quoting Gustavo A. R. Silva (2019-04-30 07:32:06) > In preparation to enabling -Wimplicit-fallthrough, mark switch > cases where we are expecting to fall through. > > This patch fixes the following warnings: > > drivers/clk/imx/clk-pllv3.c: In function ‘imx_clk_pllv3’: > drivers/clk/imx/clk-pllv3

[PATCH 2/2] coresight: alloc_perf_buf: Do not call smp_processor_id from preemptible

2019-05-03 Thread Suzuki K Poulose
We find the current CPU using smp_processor_id() if the event is not bound to a CPU, to find the node for memory allocation. Use the safe numa_node_id() instead to avoid BUG(). BUG: using smp_processor_id() in preemptible [] code: perf/1743 caller is tmc_alloc_etr_buffer+0x1bc/0x1f0 CPU

[PATCH 1/2] coresight: Do not call smp_processor_id() from preemptible

2019-05-03 Thread Suzuki K Poulose
Instead of using smp_processor_id() to figure out the node, use the numa_node_id() for the current CPU node to avoid splats like : BUG: using smp_processor_id() in preemptible [] code: perf/1743 caller is alloc_etr_buf.isra.6+0x80/0xa0 CPU: 1 PID: 1743 Comm: perf Not tainted 5.1.0-rc6-1

Re: [tip:sched/core 24/27] kernel/power/suspend.c:431:10: error: implicit declaration of function 'suspend_disable_secondary_cpus'

2019-05-03 Thread Peter Zijlstra
On Fri, May 03, 2019 at 08:34:57PM +0800, kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git sched/core > head: 65874bd36e6ae3028539e989bfb5c28ad457368e > commit: c2cb30bfceceba8a2a0d5713230a250dd6140e22 [24/27] power/suspend: Add > function to disable

Re: [GIT PULL] GNSS updates for 5.2-rc1

2019-05-03 Thread Greg Kroah-Hartman
On Fri, May 03, 2019 at 05:58:05PM +0200, Johan Hovold wrote: > The following changes since commit 79a3aaa7b82e3106be97842dedfd8429248896e6: > > Linux 5.1-rc3 (2019-03-31 14:39:29 -0700) > > are available in the Git repository at: > > https://git.kernel.org/pub/scm/linux/kernel/git/johan/gns

Re: [GIT PULL 20/22] intel_th: msu: Add a sysfs attribute showing possible modes

2019-05-03 Thread Greg Kroah-Hartman
On Fri, May 03, 2019 at 11:44:53AM +0300, Alexander Shishkin wrote: > With the addition of dynamically loadable buffer drivers, there needs > to be a way of knowing the currently available ones without having to > scan the list of loaded modules or trial and error. > > Add a sysfs file that lists

Re: [GIT PULL 12/22] intel_th: msu: Support multipage blocks

2019-05-03 Thread Greg Kroah-Hartman
On Fri, May 03, 2019 at 11:44:45AM +0300, Alexander Shishkin wrote: > @@ -1481,7 +1501,7 @@ nr_pages_show(struct device *dev, struct > device_attribute *attr, char *buf) > else if (msc->mode == MSC_MODE_MULTI) { > list_for_each_entry(win, &msc->win_list, entry) { >

RE: [PATCH] x86/entry/64: randomize kernel stack offset upon syscall

2019-05-03 Thread Reshetova, Elena
> * David Laight wrote: > > > It has already been measured - it is far too slow. > > I don't think proper buffering was tested, was it? Only a per syscall > RDRAND overhead which I can imagine being not too good. > Well, I have some numbers, but I am struggling to understand one aspect there.

Re: f68f031d ("Documentation: atomic_t.txt: Explain ordering provided by smp_mb__{before,after}_atomic()")

2019-05-03 Thread Alan Stern
On Fri, 3 May 2019, Peter Zijlstra wrote: > On Fri, May 03, 2019 at 07:53:26AM -0700, Paul E. McKenney wrote: > > Hello, Alan, > > > > Just following up on the -rcu commit below. I believe that it needs > > some adjustment given Peter Zijlstra's addition of "memory" to the x86 > > non-value-retu

Re: [GIT PULL 19/22] intel_th: msu: Introduce buffer driver interface

2019-05-03 Thread Greg Kroah-Hartman
On Fri, May 03, 2019 at 11:44:52AM +0300, Alexander Shishkin wrote: > Introduces a concept of buffer drivers, which is a mechanism for creating > trace sinks that would receive trace data from MSC buffers and transfer it > elsewhere. > > A buffer driver can implement its own window allocation/deal

Re: [GIT PULL] clk fixes for v5.1-rc7

2019-05-03 Thread pr-tracker-bot
The pull request you sent on Thu, 2 May 2019 13:46:40 -0700: > https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git > tags/clk-fixes-for-linus has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/8f76216c80c299ab8074b8658b73faa3815c6f39 Thank you! -- Deet-doot-

Re: [GIT PULL] sound fixes for 5.1

2019-05-03 Thread pr-tracker-bot
The pull request you sent on Thu, 02 May 2019 20:35:52 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git tags/sound-5.1 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/46572f785fb41949665ef4665563db5346f7cb30 Thank you! -- Deet-doot-dot, I am a b

<    1   2   3   4   5   6   >