Re: [PATCH] RAS/CEC: Add debugfs switch to disable at run time

2019-04-18 Thread Cong Wang
On Thu, Apr 18, 2019 at 4:29 PM Borislav Petkov wrote: > > On Thu, Apr 18, 2019 at 03:51:07PM -0700, Cong Wang wrote: > > On Thu, Apr 18, 2019 at 3:02 PM Tony Luck wrote: > > > > > > Useful when running error injection tests that want to > > > see all of the MCi_(STATUS|ADDR|MISC) data via /dev/m

mmotm 2019-04-18-16-58 uploaded

2019-04-18 Thread akpm
The mm-of-the-moment snapshot 2019-04-18-16-58 has been uploaded to http://www.ozlabs.org/~akpm/mmotm/ mmotm-readme.txt says README for mm-of-the-moment: http://www.ozlabs.org/~akpm/mmotm/ This is a snapshot of my -mm patch queue. Uploaded at random hopefully more than once a week. You wi

Re: [PATCH] RAS/CEC: Add debugfs switch to disable at run time

2019-04-18 Thread Luck, Tony
On Fri, Apr 19, 2019 at 01:29:10AM +0200, Borislav Petkov wrote: > Which reminds me, Tony, I think all those debugging files "pfn" > and "array" and the one you add now, should all be under a > CONFIG_RAS_CEC_DEBUG which is default off and used only for development. > Mind adding that too pls? Pat

Re: [PATCH v3] proc/sysctl: add shared variables for range check

2019-04-18 Thread Matteo Croce
On April 19, 2019 7:40:45 AM GMT+09:00, Andrew Morton wrote: > On Wed, 17 Apr 2019 15:15:31 +0200 Matteo Croce > wrote: > > > In the sysctl code the proc_dointvec_minmax() function is often used > to > > validate the user supplied value between an allowed range. This > function > > uses the ext

Re: [PATCH] RAS/CEC: Add debugfs switch to disable at run time

2019-04-18 Thread Borislav Petkov
On Thu, Apr 18, 2019 at 04:58:22PM -0700, Cong Wang wrote: > No, it is all about whether we should break users' expectation. What user expectation? > This doesn't sounds like a valid reason for us to break users' > expectation. I think it is *you* who has some sort of "expectation" but that "exp

[PATCH v2] tools/power: turbostat: make output buffer extensible (Re: [PATCH v1] tools/power: turbostat: fix buffer overrun)

2019-04-18 Thread Naoya Horiguchi
I updated the patch with a trival fix. Could you review it? - Naoya From: Naoya Horiguchi Date: Fri, 19 Apr 2019 09:21:59 +0900 Subject: [PATCH v2] tools/power: turbostat: make output buffer extensible "turbostat --Dump" could be terminated by general protection fault on some latest hardwa

Re: [PATCH] RAS/CEC: Add debugfs switch to disable at run time

2019-04-18 Thread Borislav Petkov
On Thu, Apr 18, 2019 at 05:07:45PM -0700, Luck, Tony wrote: > On Fri, Apr 19, 2019 at 01:29:10AM +0200, Borislav Petkov wrote: > > Which reminds me, Tony, I think all those debugging files "pfn" > > and "array" and the one you add now, should all be under a > > CONFIG_RAS_CEC_DEBUG which is default

Re: EDAC: Fix memory leak in creating CSROW object

2019-04-18 Thread Borislav Petkov
On Fri, Apr 19, 2019 at 08:35:36AM +0800, PanBian wrote: > Yes, I see that. Because the loop start with (--i), there is no put > operation for the device that fails to create. So, I think we cannot > rule out the possibility of memory leak. Ok, so this is not something you trigger - you're basical

Re: Adding plain accesses and detecting data races in the LKMM

2019-04-18 Thread Andrea Parri
> Are you saying that on x86, atomic_inc() acts as a full memory barrier > but not as a compiler barrier, and vice versa for > smp_mb__after_atomic()? Or that neither atomic_inc() nor > smp_mb__after_atomic() implements a full memory barrier? I'd say the former; AFAICT, these boil down to:

Re: [RFC PATCH v3] perf/x86: make perf callchain work without CONFIG_FRAME_POINTER

2019-04-18 Thread Josh Poimboeuf
On Thu, Apr 18, 2019 at 12:07:30PM -0400, Kairui Song wrote: > Currently perf callchain doesn't work well when sampling from trace > point, with ORC unwinder enabled and CONFIG_FRAME_POINTER disabled. > We'll get useless in kernel callchain like this: > > perf 6429 [000]22.498450:

[PATCH 2/2] regulator: fan53555: Switch to SPDX identifier

2019-04-18 Thread Axel Lin
Signed-off-by: Axel Lin --- drivers/regulator/fan53555.c | 24 ++-- 1 file changed, 10 insertions(+), 14 deletions(-) diff --git a/drivers/regulator/fan53555.c b/drivers/regulator/fan53555.c index e2caf4173ab5..dbe477da4e55 100644 --- a/drivers/regulator/fan53555.c +++ b/driv

[PATCH 1/2] regulator: fan53555: Clean up unneeded fields from struct fan53555_device_info

2019-04-18 Thread Axel Lin
The *regmap and *rdev can be replaced by local variables. The slew_rate is no longer used since commit dd7e71fbeefe ("regulator: fan53555: use set_ramp_delay to set the ramp up slew rate"). Signed-off-by: Axel Lin --- drivers/regulator/fan53555.c | 36 +--- 1 file

Re: [PATCH v5 0/2] tty: serial: add DT bindings and serial driver for the SiFive FU540 UART

2019-04-18 Thread Atish Patra
On 4/18/19 4:22 PM, Kevin Hilman wrote: Hi Paul, Paul Walmsley writes: This series adds a serial driver, with console support, for the UART IP block present on the SiFive FU540 SoC. The programming model is straightforward, but unique. Boot-tested on a SiFive FU540 HiFive-U board, using BBL

Re: [PATCH v3] proc/sysctl: add shared variables for range check

2019-04-18 Thread Matthew Wilcox
On Fri, Apr 19, 2019 at 09:17:17AM +0900, Matteo Croce wrote: > > extern const int sysctl_zero; > > /* comment goes here */ > > #define SYSCTL_ZERO ((void *)&sysctl_zero) > > > > and then use SYSCTL_ZERO everywhere. That centralizes the ugliness > > and > > makes it easier to switch over if/when

Re: linux-next: build warning after merge of the block tree

2019-04-18 Thread Chao Yu
On 2019/4/18 22:01, Jaegeuk Kim wrote: > On 04/18, Chao Yu wrote: >> On 2019/4/17 22:03, Jaegeuk Kim wrote: >>> On 04/17, Chao Yu wrote: Hi Jaegeuk, On 2019/4/17 10:31, Stephen Rothwell wrote: > Hi all, > > After merging the block tree, today's linux-next build (x86_64 >>

[PATCH] tools/lib/traceevent: Remove hardcoded install paths from pkg-config file

2019-04-18 Thread Steven Rostedt
From: Tzvetomir Stoyanov Install directories of header and library files are hardcoded in pkg-config templete file. They must be configurable, the Makefile should set them on the compilation / install stage. Link: http://lkml.kernel.org/r/20190329144546.5819-1-tstoya...@vmware.com Signed-off-

Re: [PATCH v7 00/10] vsprintf: Prevent silent crashes and consolidate error handling

2019-04-18 Thread Sergey Senozhatsky
On (04/17/19 13:53), Petr Mladek wrote: > Crash in vsprintf() might be silent when it happens under logbuf_lock > in vprintk_emit(). This patch set prevents most of the crashes by probing > the address. The check is done only by %s and some %p* specifiers that need > to dereference the address. > >

net: ax25: %x specifier misuse in kernel?

2019-04-18 Thread PlusOneSecond
In ax25_info_show of af_ax25.c:1891, linux-5.1. The pointer ax25 is cast to long type to print out. Why it prints the a pointer 'ax25' use %8.8lx rather than %p? If it really want to print the value of ax25, it should use %px. Also, I scan the kernel code and notice that most of the pointers cas

Re: kernel BUG at kernel/cred.c:434!

2019-04-18 Thread Paul Moore
On Wed, Apr 17, 2019 at 10:50 PM Yang Yingliang wrote: > On 2019/4/18 8:24, Casey Schaufler wrote: > > On 4/17/2019 4:39 PM, Paul Moore wrote: > >> > >> Since it looks like all three LSMs which implement the setprocattr > >> hook are vulnerable I'm open to the idea that proc_pid_attr_write() is >

Re: [PATCH v2] panic: add an option to replay all the printk message in buffer

2019-04-18 Thread Feng Tang
On Thu, Apr 18, 2019 at 01:01:52PM +0200, Petr Mladek wrote: > On Thu 2019-04-18 17:00:44, Feng Tang wrote: > > Hi Petr, > > > > On Thu, Apr 18, 2019 at 09:45:52AM +0200, Petr Mladek wrote: > > > On Thu 2019-04-18 09:00:14, Sergey Senozhatsky wrote: > > > > I think that PANIC_PRINT_ALL_PRINTK_MSG

Re: [RFC PATCH v3] perf/x86: make perf callchain work without CONFIG_FRAME_POINTER

2019-04-18 Thread Kairui Song
On Fri, Apr 19, 2019 at 8:58 AM Josh Poimboeuf wrote: > > I still don't like using regs->bp because it results in different code > paths for FP and ORC. In the FP case, the regs are treated like real > regs even though they're fake. > > Something like the below would be much simpler. Would this

[PATCH] kvm: x86: refine kvm_get_arch_capabilities()

2019-04-18 Thread Xiaoyao Li
1. Using X86_FEATURE_ARCH_CAPABILITIES to enumerate the existence of MSR_IA32_ARCH_CAPABILITIES to avoid using rdmsrl_safe(). 2. Since kvm_get_arch_capabilities() is only used in this file, making it static. Signed-off-by: Xiaoyao Li --- arch/x86/include/asm/kvm_host.h | 1 - arch/x86/kvm/x86.c

Re: kernel BUG at kernel/cred.c:434!

2019-04-18 Thread Yang Yingliang
On 2019/4/19 10:04, Paul Moore wrote: On Wed, Apr 17, 2019 at 10:50 PM Yang Yingliang wrote: On 2019/4/18 8:24, Casey Schaufler wrote: On 4/17/2019 4:39 PM, Paul Moore wrote: Since it looks like all three LSMs which implement the setprocattr hook are vulnerable I'm open to the idea that pr

Re: net: ax25: %x specifier misuse in kernel?

2019-04-18 Thread Eric Dumazet
On 04/18/2019 07:01 PM, PlusOneSecond wrote: > In ax25_info_show of af_ax25.c:1891, linux-5.1. > The pointer ax25 is cast to long type to print out. > > Why it prints the a pointer 'ax25' use %8.8lx rather than %p? > If it really want to print the value of ax25, it should use %px. I guess nobo

Re: [PATCH v2] moduleparam: Save information about built-in modules in separate file

2019-04-18 Thread Masahiro Yamada
On Fri, Apr 19, 2019 at 12:36 AM Jessica Yu wrote: > > +++ Masahiro Yamada [19/04/19 00:26 +0900]: > >On Thu, Apr 18, 2019 at 10:52 PM Jessica Yu wrote: > >> > >> +++ Masahiro Yamada [18/04/19 20:10 +0900]: > >> >On Sat, Apr 6, 2019 at 9:15 PM Alexey Gladkov > >> >wrote: > >> >> > >> >> Problem

Re: [PATCH v20 16/28] x86/sgx: Add provisioning

2019-04-18 Thread Huang, Kai
On Wed, 2019-04-17 at 13:39 +0300, Jarkko Sakkinen wrote: > In order to provide a mechanism for devilering provisoning rights: > > 1. Add a new device file /dev/sgx/provision that works as a token for >allowing an enclave to have the provisioning privileges. > 2. Add a new ioctl called SGX_IOC

[PATCH net-next 05/12] net: hns3: refine tx timeout count handle

2019-04-18 Thread Huazhong Tan
From: Jian Shen In current codes, tx_timeout_cnt is used before increased, then we can see the tx_timeout_count is still 0 from the print when tx timeout happens, e.g. "hns3 :7d:00.3 eth3: tx_timeout count: 0, queue id: 0, SW_NTU: 0xa6, SW_NTC: 0xa4, HW_HEAD: 0xa4, HW_TAIL: 0xa6, INT: 0x1"

[PATCH net-next 09/12] net: hns3: add support for dump ncl config by debugfs

2019-04-18 Thread Huazhong Tan
From: Weihang Li This patch allow users to dump content of NCL_CONFIG by using debugfs command. Command format: echo dump ncl_config > cmd It will print as follows: hns3 :7d:00.0: offset |data hns3 :7d:00.0: 0x | 0x0020 hns3 :7d:00.0: 0x00

[PATCH] PCI: keystone: Fix build error while only CONFIG_PCI_KEYSTONE is set

2019-04-18 Thread Yue Haibing
From: YueHaibing During randconfig builds, I occasionally run into an invalid configuration drivers/pci/controller/dwc/pci-keystone.o: In function `ks_pcie_link_up': pci-keystone.c:(.text+0x90): undefined reference to `__dw_pcie_read_dbi' pci-keystone.c:(.text+0x90): relocation truncated to fit:

Re: [PATCH v2 3/4] dt-bindings: power: supply: Add docs for Ingenic JZ47xx SoCs battery.

2019-04-18 Thread Sebastian Reichel
Hi, On Sun, Mar 24, 2019 at 03:30:18PM +, Jonathan Cameron wrote: > On Sat, 23 Mar 2019 18:28:08 +0100 > Artur Rojek wrote: > > > Add documentation for the ingenic-battery driver, used on JZ47xx SoCs. > > > > Signed-off-by: Artur Rojek > Looks fine to me. > > Acked-by: Jonathan Cameron

Re: [PATCH v3] power: supply: add Ingenic JZ47xx battery driver.

2019-04-18 Thread Sebastian Reichel
Hi, On Thu, Apr 18, 2019 at 08:24:04PM +0200, Artur Rojek wrote: > Add a driver for battery present on Ingenic JZ47xx SoCs. > > Signed-off-by: Artur Rojek > Reviewed-by: Jonathan Cameron > --- Thanks, queued. -- Sebastian > > Changes: > > v2: - rework the return logic in ingenic_battery_ge

Re: [PATCH v2 1/4] iio: inkern: API for reading available iio channel attribute values

2019-04-18 Thread Sebastian Reichel
Hi, On Sun, Apr 14, 2019 at 11:34:54AM +0100, Jonathan Cameron wrote: > On Sun, 24 Mar 2019 15:27:25 + > Jonathan Cameron wrote: > > > On Sat, 23 Mar 2019 18:28:06 +0100 > > Artur Rojek wrote: > > > > > Extend the inkern API with a function for reading available > > > attribute values of i

Re: [PATCH v7 00/10] Add support for XO 1.75 to OLPC battery driver

2019-04-18 Thread Sebastian Reichel
Hi, On Thu, Apr 18, 2019 at 04:46:45PM +0200, Lubomir Rintel wrote: > This patch set modifies the OLPC battery driver so that it could eventually > be used on an Arm-based OLPC XO 1.75 machine. > > Compared to the previous version, it addresses review comments for the > x86 platform parts from Th

Re: [PATCH 4/4] mtd: rawnand: meson: only initialize the RB completion once

2019-04-18 Thread Liang Yang
Hi Martin, On 2019/4/19 3:44, Martin Blumenstingl wrote: Hi Liang, On Mon, Apr 15, 2019 at 8:04 AM Liang Yang wrote: On 2019/4/12 6:00, Martin Blumenstingl wrote: Documentation/scheduler/completion.txt states: Calling init_completion() on the same completion object twice is most li

<    5   6   7   8   9   10