[PATCH 04/13] locking/rt-mutex: Flush block plug on __down_read()

2019-04-08 Thread Tom Zanussi
4.14.109-rt58-rc1 stable review patch. If anyone has any objections, please let me know. -- From: Scott Wood [ Upstream commit 0d5d32425a0cab4a282dd79fc953d76a3ab17072 ] __down_read() bypasses the rtmutex frontend to call rt_mutex_slowlock_locked() directly, and thus it needs t

[PATCH 05/13] rtmutex/rwlock: preserve state like a sleeping lock

2019-04-08 Thread Tom Zanussi
4.14.109-rt58-rc1 stable review patch. If anyone has any objections, please let me know. -- From: Sebastian Andrzej Siewior [ Upstream commit 4a1bf9e54a013d55ab156cb462c68054cb52ee2d ] The rwlock is spinning while acquiring a lock. Therefore it must become a sleeping lock on RT

[PATCH 12/13] powerpc/pseries/iommu: Use a locallock instead local_irq_save()

2019-04-08 Thread Tom Zanussi
4.14.109-rt58-rc1 stable review patch. If anyone has any objections, please let me know. -- From: Sebastian Andrzej Siewior [ Upstream commit 5c1b4cd70e2ca0c81038b65babe6dc66086322e0 ] The locallock protects the per-CPU variable tce_page. The function attempts to allocate memor

[PATCH 02/13] sched/fair: Robustify CFS-bandwidth timer locking

2019-04-08 Thread Tom Zanussi
4.14.109-rt58-rc1 stable review patch. If anyone has any objections, please let me know. -- From: Peter Zijlstra [ Upstream commit a44c9da61ad3334a9563102e0194d7197b222ec2 ] Traditionally hrtimer callbacks were run with IRQs disabled, but with the introduction of HRTIMER_MODE_S

Re: [PATCH 1/4] glibc: Perform rseq(2) registration at C startup and thread creation (v7)

2019-04-08 Thread Tulio Magno Quites Machado Filho
Carlos O'Donell writes: > On 4/5/19 5:16 AM, Florian Weimer wrote: >> * Carlos O'Donell: >>> It is valuable that it be a trap, particularly for constant pools because >>> it means that a jump into the constant pool will trap. >> >> Sorry, I don't understand why this matters in this context. Wou

Re: [GIT PULL v2] LM3532 backlight support improvements and relocation

2019-04-08 Thread Tony Lindgren
* Dan Murphy [190408 15:54]: > On 4/7/19 5:17 PM, Pavel Machek wrote: > > Plus, I'd kind of expect ALS enabled/disabled to be runtime controled, > > not from the device tree. > > We can always add runtime override control to the driver. Yeah that sounds good to me :) Sounds like this can be done

Re: [PATCH v3 2/3] platform/x86: intel_pmc_core: Allow to dump debug registers on S0ix failure

2019-04-08 Thread Andy Shevchenko
On Mon, Apr 8, 2019 at 9:58 PM Rajat Jain wrote: > On Mon, Apr 8, 2019 at 11:41 AM Andy Shevchenko > wrote: > > On Mon, Apr 8, 2019 at 9:36 PM Rajat Jain wrote: > > Instead of adding module parameter and doing these prints, perhaps > > introduce another debugfs node. > > Uh, I actually did want

Re: [srcu] a365bb5f6e: leaking_addresses.proc.___srcu_struct_ptrs.

2019-04-08 Thread Joel Fernandes
On Mon, Apr 08, 2019 at 01:25:49PM -0400, Mathieu Desnoyers wrote: > - On Apr 8, 2019, at 1:10 PM, paulmck paul...@linux.ibm.com wrote: > > > On Mon, Apr 08, 2019 at 01:06:56PM -0400, Mathieu Desnoyers wrote: > >> - On Apr 8, 2019, at 11:21 AM, paulmck paul...@linux.ibm.com wrote: > >> >

Re: [PATCH] perf header: Fix lock/unlock imbalances

2019-04-08 Thread Arnaldo Carvalho de Melo
Em Mon, Apr 08, 2019 at 01:26:09PM -0500, Gustavo A. R. Silva escreveu: > > > On 4/8/19 1:22 PM, Song Liu wrote: > > > > > >> On Apr 8, 2019, at 10:33 AM, Gustavo A. R. Silva > >> wrote: > >> > >> Fix lock/unlock imbalances by refactoring the code a bit and adding > >> calls to up_write() bef

[RFC PATCH 3/2] fdomain: Use SCSI host private data instead of global variables

2019-04-08 Thread Ondrej Zary
Move global variables into SCSI host private data in order to support multiple cards. Signed-off-by: Ondrej Zary --- drivers/scsi/fdomain.c | 593 + 1 file changed, 307 insertions(+), 286 deletions(-) diff --git a/drivers/scsi/fdomain.c b/drivers/

Re: [PATCH 1/2] workqueue: Use normal rcu

2019-04-08 Thread Tejun Heo
On Wed, Mar 13, 2019 at 05:55:47PM +0100, Sebastian Andrzej Siewior wrote: > From: Thomas Gleixner > > There is no need for sched_rcu. The undocumented reason why sched_rcu > is used is to avoid a few explicit rcu_read_lock()/unlock() pairs by > the fact that sched_rcu reader side critical sectio

[PATCH 01/22] watchdog: armada_37xx_wdt: Convert to use device managed functions and other improvements

2019-04-08 Thread Guenter Roeck
Use device managed functions to simplify error handling, reduce source code size, improve readability, and reduce the likelyhood of bugs. Other improvements as listed below. The conversion was done automatically with coccinelle using the following semantic patches. The semantic patches and the scr

[PATCH 00/22] watchdog: Convert to use device managed functions and other improvements

2019-04-08 Thread Guenter Roeck
Use device managed functions and other changes to simplify error handling, reduce source code size, improve readability, and reduce the likelyhood of bugs. The changes made in this series can be summarized to - Use devm_add_action_or_reset() for calls to clk_disable_unprepare - Use devm_watchdog_

[PATCH 07/22] watchdog: bcm_kona_wdt: Convert to use device managed functions and other improvements

2019-04-08 Thread Guenter Roeck
Use device managed functions to simplify error handling, reduce source code size, improve readability, and reduce the likelyhood of bugs. Other improvements as listed below. The conversion was done automatically with coccinelle using the following semantic patches. The semantic patches and the scr

[PATCH 03/22] watchdog: aspeed_wdt: Use 'dev' instead of dereferencing it repeatedly

2019-04-08 Thread Guenter Roeck
Introduce local variable 'struct device *dev' and use it instead of dereferencing it repeatedly. The conversion was done automatically with coccinelle using the following semantic patches. The semantic patches and the scripts used to generate this commit log are available at https://github.com/gro

[PATCH 10/22] watchdog: da9055_wdt: Use 'dev' instead of dereferencing it repeatedly

2019-04-08 Thread Guenter Roeck
Introduce local variable 'struct device *dev' and use it instead of dereferencing it repeatedly. The conversion was done automatically with coccinelle using the following semantic patches. The semantic patches and the scripts used to generate this commit log are available at https://github.com/gro

[PATCH 09/22] watchdog: da9052_wdt: Use 'dev' instead of dereferencing it repeatedly

2019-04-08 Thread Guenter Roeck
Introduce local variable 'struct device *dev' and use it instead of dereferencing it repeatedly. The conversion was done automatically with coccinelle using the following semantic patches. The semantic patches and the scripts used to generate this commit log are available at https://github.com/gro

[PATCH 05/22] watchdog: bcm2835_wdt: drop platform_set_drvdata

2019-04-08 Thread Guenter Roeck
There is no call to platform_get_drvdata() in the driver, so platform_set_drvdata() is unnecessary and can be dropped. The conversion was done automatically with coccinelle using the following semantic patches. The semantic patches and the scripts used to generate this commit log are available at

[PATCH 18/22] watchdog: imgpdc_wdt: Convert to use device managed functions and other improvements

2019-04-08 Thread Guenter Roeck
Use device managed functions to simplify error handling, reduce source code size, improve readability, and reduce the likelyhood of bugs. Other improvements as listed below. The conversion was done automatically with coccinelle using the following semantic patches. The semantic patches and the scr

[PATCH 15/22] watchdog: ftwdt010_wdt: Use 'dev' consistently

2019-04-08 Thread Guenter Roeck
Use local variable 'dev' consistently. The conversion was done automatically with coccinelle using the following semantic patches. The semantic patches and the scripts used to generate this commit log are available at https://github.com/groeck/coccinelle-patches Signed-off-by: Guenter Roeck ---

[PATCH 17/22] watchdog: iTCO_wdt: Various improvements

2019-04-08 Thread Guenter Roeck
Various coccinelle driven transformations as detailed below. The conversion was done automatically with coccinelle using the following semantic patches. The semantic patches and the scripts used to generate this commit log are available at https://github.com/groeck/coccinelle-patches - Use watchd

[PATCH 11/22] watchdog: da9062_wdt: Use 'dev' instead of dereferencing it repeatedly

2019-04-08 Thread Guenter Roeck
Introduce local variable 'struct device *dev' and use it instead of dereferencing it repeatedly. Also replace 'ret = func(); return ret;' with 'return func();'. The conversion was done automatically with coccinelle using the following semantic patches. The semantic patches and the scripts used to

[PATCH 21/22] watchdog: lpc18xx_wdt: Convert to use device managed functions and other improvements

2019-04-08 Thread Guenter Roeck
Use device managed functions to simplify error handling, reduce source code size, improve readability, and reduce the likelyhood of bugs. Other improvements as listed below. The conversion was done automatically with coccinelle using the following semantic patches. The semantic patches and the scr

[PATCH 20/22] watchdog: kempld_wdt: Convert to use device managed functions and other improvements

2019-04-08 Thread Guenter Roeck
Use device managed functions to simplify error handling, reduce source code size, improve readability, and reduce the likelyhood of bugs. Other improvements as listed below. The conversion was done automatically with coccinelle using the following semantic patches. The semantic patches and the scr

[PATCH 16/22] watchdog: gpio_wdt: Convert to use device managed functions and other improvements

2019-04-08 Thread Guenter Roeck
Use device managed functions to simplify error handling, reduce source code size, improve readability, and reduce the likelyhood of bugs. Other improvements as listed below. The conversion was done automatically with coccinelle using the following semantic patches. The semantic patches and the scr

[PATCH 14/22] watchdog: ep93xx_wdt: Use 'dev' instead of dereferencing it repeatedly

2019-04-08 Thread Guenter Roeck
Introduce local variable 'struct device *dev' and use it instead of dereferencing it repeatedly. The conversion was done automatically with coccinelle using the following semantic patches. The semantic patches and the scripts used to generate this commit log are available at https://github.com/gro

[PATCH 22/22] watchdog: max63xx_wdt: Convert to use device managed functions and other improvements

2019-04-08 Thread Guenter Roeck
Use device managed functions to simplify error handling, reduce source code size, improve readability, and reduce the likelyhood of bugs. Other improvements as listed below. The conversion was done automatically with coccinelle using the following semantic patches. The semantic patches and the scr

[PATCH 19/22] watchdog: intel-mid_wdt: Use 'dev' instead of dereferencing it repeatedly

2019-04-08 Thread Guenter Roeck
Introduce local variable 'struct device *dev' and use it instead of dereferencing it repeatedly. The conversion was done automatically with coccinelle using the following semantic patches. The semantic patches and the scripts used to generate this commit log are available at https://github.com/gro

[PATCH 13/22] watchdog: davinci_wdt: Convert to use device managed functions and other improvements

2019-04-08 Thread Guenter Roeck
Use device managed functions to simplify error handling, reduce source code size, improve readability, and reduce the likelyhood of bugs. Other improvements as listed below. The conversion was done automatically with coccinelle using the following semantic patches. The semantic patches and the scr

[PATCH 12/22] watchdog: da9063_wdt: Use 'dev' instead of dereferencing it repeatedly

2019-04-08 Thread Guenter Roeck
Introduce local variable 'struct device *dev' and use it instead of dereferencing it repeatedly. The conversion was done automatically with coccinelle using the following semantic patches. The semantic patches and the scripts used to generate this commit log are available at https://github.com/gro

[PATCH 04/22] watchdog: atlas7_wdt: Convert to use device managed functions and other improvements

2019-04-08 Thread Guenter Roeck
Use device managed functions to simplify error handling, reduce source code size, improve readability, and reduce the likelyhood of bugs. Other improvements as listed below. The conversion was done automatically with coccinelle using the following semantic patches. The semantic patches and the scr

[PATCH 06/22] watchdog: bcm7038_wdt: Convert to use device managed functions and other improvements

2019-04-08 Thread Guenter Roeck
Use device managed functions to simplify error handling, reduce source code size, improve readability, and reduce the likelyhood of bugs. Other improvements as listed below. The conversion was done automatically with coccinelle using the following semantic patches. The semantic patches and the scr

[PATCH 08/22] watchdog: cadence_wdt: Convert to use device managed functions and other improvements

2019-04-08 Thread Guenter Roeck
Use device managed functions to simplify error handling, reduce source code size, improve readability, and reduce the likelyhood of bugs. Other improvements as listed below. The conversion was done automatically with coccinelle using the following semantic patches. The semantic patches and the scr

[PATCH 02/22] watchdog: asm9260_wdt: Convert to use device managed functions and other improvements

2019-04-08 Thread Guenter Roeck
Use device managed functions to simplify error handling, reduce source code size, improve readability, and reduce the likelyhood of bugs. Other improvements as listed below. The conversion was done automatically with coccinelle using the following semantic patches. The semantic patches and the scr

Re: [PATCH 2/2] sched: Distangle worker accounting from rq lock

2019-04-08 Thread Tejun Heo
Hello, On Wed, Mar 13, 2019 at 05:55:48PM +0100, Sebastian Andrzej Siewior wrote: > From: Thomas Gleixner > > The worker accounting for CPU bound workers is plugged into the core > scheduler code and the wakeup code. This is not a hard requirement and > can be avoided by keeping track of the sta

Re: [srcu] a365bb5f6e: leaking_addresses.proc.___srcu_struct_ptrs.

2019-04-08 Thread Mathieu Desnoyers
- On Apr 8, 2019, at 3:35 PM, Joel Fernandes, Google j...@joelfernandes.org wrote: > On Mon, Apr 08, 2019 at 01:25:49PM -0400, Mathieu Desnoyers wrote: >> - On Apr 8, 2019, at 1:10 PM, paulmck paul...@linux.ibm.com wrote: >> >> > On Mon, Apr 08, 2019 at 01:06:56PM -0400, Mathieu Desnoyer

Re: [PATCH v2 0/2] A couple hugetlbfs fixes

2019-04-08 Thread Davidlohr Bueso
On Thu, 28 Mar 2019, Mike Kravetz wrote: - A BUG can be triggered (not easily) due to temporarily mapping a page before doing a COW. But you actually _have_ seen it? Do you have the traces? I ask not because of the patches perse, but because it would be nice to have a real snipplet in the Cha

Re: [PATCH] perf header: Fix lock/unlock imbalances

2019-04-08 Thread Gustavo A. R. Silva
On 4/8/19 2:35 PM, Arnaldo Carvalho de Melo wrote: > Em Mon, Apr 08, 2019 at 01:26:09PM -0500, Gustavo A. R. Silva escreveu: >> >> >> On 4/8/19 1:22 PM, Song Liu wrote: >>> >>> On Apr 8, 2019, at 10:33 AM, Gustavo A. R. Silva wrote: Fix lock/unlock imbalances by refactoring

[PATCH 0/4] mm: swapoff: fixes for 5.1-rc

2019-04-08 Thread Hugh Dickins
Here are four fixes to the new "rid quadratic" swapoff in 5.1-rc: 1/4 mm: swapoff: shmem_find_swap_entries() filter out other types 2/4 mm: swapoff: remove too limiting SWAP_UNUSE_MAX_TRIES 3/4 mm: swapoff: take notice of completion sooner 4/4 mm: swapoff: shmem_unuse() stop eviction without igrab

[PATCH 1/4] mm: swapoff: shmem_find_swap_entries() filter out other types

2019-04-08 Thread Hugh Dickins
Swapfile "type" was passed all the way down to shmem_unuse_inode(), but then forgotten from shmem_find_swap_entries(): with the result that removing one swapfile would try to free up all the swap from shmem - no problem when only one swapfile anyway, but counter-productive when more, causing swapof

Re: [srcu] a365bb5f6e: leaking_addresses.proc.___srcu_struct_ptrs.

2019-04-08 Thread Joel Fernandes
On Mon, Apr 08, 2019 at 03:47:04PM -0400, Mathieu Desnoyers wrote: > - On Apr 8, 2019, at 3:35 PM, Joel Fernandes, Google > j...@joelfernandes.org wrote: > > > On Mon, Apr 08, 2019 at 01:25:49PM -0400, Mathieu Desnoyers wrote: > >> - On Apr 8, 2019, at 1:10 PM, paulmck paul...@linux.ibm.c

[PATCH 2/4] mm: swapoff: remove too limiting SWAP_UNUSE_MAX_TRIES

2019-04-08 Thread Hugh Dickins
SWAP_UNUSE_MAX_TRIES 3 appeared to work well in earlier testing, but further testing has proved it to be a source of unnecessary swapoff EBUSY failures (which can then be followed by unmount EBUSY failures). When mmget_not_zero() or shmem's igrab() fails, there is an mm exiting or inode being evic

[PATCH 3/4] mm: swapoff: take notice of completion sooner

2019-04-08 Thread Hugh Dickins
The old try_to_unuse() implementation was driven by find_next_to_unuse(), which terminated as soon as all the swap had been freed. Add inuse_pages checks now (alongside signal_pending()) to stop scanning mms and swap_map once finished. The same ought to be done in shmem_unuse() too, but never was

[PATCH 4/4] mm: swapoff: shmem_unuse() stop eviction without igrab()

2019-04-08 Thread Hugh Dickins
The igrab() in shmem_unuse() looks good, but we forgot that it gives no protection against concurrent unmounting: a point made by Konstantin Khlebnikov eight years ago, and then fixed in 2.6.39 by 778dd893ae78 ("tmpfs: fix race between umount and swapoff"). The current 5.1-rc swapoff is liable to h

Re: [PATCH] perf header: Fix lock/unlock imbalances

2019-04-08 Thread Arnaldo Carvalho de Melo
Em Mon, Apr 08, 2019 at 02:52:52PM -0500, Gustavo A. R. Silva escreveu: > > > On 4/8/19 2:35 PM, Arnaldo Carvalho de Melo wrote: > > Em Mon, Apr 08, 2019 at 01:26:09PM -0500, Gustavo A. R. Silva escreveu: > >> > >> > >> On 4/8/19 1:22 PM, Song Liu wrote: > >>> > >>> > On Apr 8, 2019, at 10:3

Re: [PATCH v5 3/3] platform/chrome: Standardize Chrome OS keyboard backlight name

2019-04-08 Thread Jacek Anaszewski
Hi Dmitry, Thanks for the review. On 4/8/19 12:01 AM, Dmitry Torokhov wrote: Hi Jacek, On Fri, Apr 5, 2019 at 1:00 PM Jacek Anaszewski wrote: Hi all, On 4/5/19 10:42 AM, Enric Balletbo i Serra wrote: Hi, On 5/4/19 0:42, Guenter Roeck wrote: On Thu, Apr 4, 2019 at 3:05 PM Pavel Machek w

Re: [PATCH] selftests/ipc: Fix msgque compiler warnings

2019-04-08 Thread Davidlohr Bueso
On Mon, 08 Apr 2019, Kees Cook wrote: This fixes the various compiler warnings when building the msgque selftest. The primary change is using sys/msg.h instead of linux/msg.h directly to gain the API declarations. Fixes: 3a665531a3b7 ("selftests: IPC message queue copy feature test") Signed-off

Re: [PATCH 24/27] x86/fpu: Add a fastpath to __fpu__restore_sig()

2019-04-08 Thread Sebastian Andrzej Siewior
On 2019-04-08 19:05:56 [+0200], Thomas Gleixner wrote: > > diff --git a/arch/x86/kernel/fpu/signal.c b/arch/x86/kernel/fpu/signal.c > > index a5b086ec426a5..f20e1d1fffa29 100644 > > --- a/arch/x86/kernel/fpu/signal.c > > +++ b/arch/x86/kernel/fpu/signal.c > > @@ -242,10 +242,10 @@ sanitize_restored

Re: [PATCH 19/27] x86/fpu: Update xstate's PKRU value on write_pkru()

2019-04-08 Thread Sebastian Andrzej Siewior
On 2019-04-08 11:14:28 [-0700], Dave Hansen wrote: > On 4/3/19 9:41 AM, Sebastian Andrzej Siewior wrote: > > During the context switch the xstate is loaded which also includes the > > PKRU value. > > If xstate is restored on return to userland it is required that the > > PKRU value in xstate is the

Re: [GIT PULL v2] LM3532 backlight support improvements and relocation

2019-04-08 Thread Dan Murphy
Tony On 4/8/19 2:30 PM, Tony Lindgren wrote: * Dan Murphy [190408 15:54]: On 4/7/19 5:17 PM, Pavel Machek wrote: Plus, I'd kind of expect ALS enabled/disabled to be runtime controled, not from the device tree. We can always add runtime override control to the driver. Yeah that sounds good t

[PATCH v2 2/4] soundwire: bus: remove useless initializations

2019-04-08 Thread Pierre-Louis Bossart
No need for explicit initialization of page and ssp fields, they are already zeroed with a memset. Detected with cppcheck: [drivers/soundwire/bus.c:309]: (style) Variable 'msg->page' is reassigned a value before the old one has been used. Signed-off-by: Pierre-Louis Bossart --- drivers/soundwi

[PATCH v2 0/4] soundwire: code cleanup

2019-04-08 Thread Pierre-Louis Bossart
SoundWire support will be provided in Linux with the Sound Open Firmware (SOF) on Intel platforms. Before we start adding the missing pieces, there are a number of warnings and style issues reported by checkpatch, cppcheck and Coccinelle that need to be cleaned-up. Changes since v1: added missing

[PATCH v2 4/4] soundwire: add missing newlines in dynamic debug logs

2019-04-08 Thread Pierre-Louis Bossart
For some reason the newlines are not used everywhere. Fix as needed. Reported-by: Joe Perches Signed-off-by: Pierre-Louis Bossart --- drivers/soundwire/bus.c| 74 +-- drivers/soundwire/cadence_master.c | 12 ++-- drivers/soundwire/intel.c | 12 ++-- drive

[PATCH v2 3/4] soundwire: stream: remove useless initialization of local variable

2019-04-08 Thread Pierre-Louis Bossart
no need to reset return value. Detected with cppcheck: [drivers/soundwire/stream.c:332]: (style) Variable 'ret' is assigned a value that is never used. Signed-off-by: Pierre-Louis Bossart --- drivers/soundwire/stream.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/

[PATCH v2 1/4] soundwire: fix style issues

2019-04-08 Thread Pierre-Louis Bossart
Visual inspections confirmed by checkpatch.pl --strict expose a number of style issues, specifically parameter alignment is inconsistent as if different contributors used different styles. Before we restart support for SoundWire with Sound Open Firmware on Intel platforms, let's clean all this. Fi

Re: Thoughts on simple scanner approach for free page hinting

2019-04-08 Thread Alexander Duyck
On Mon, Apr 8, 2019 at 11:40 AM David Hildenbrand wrote: > > >>> > >>> In addition we will need some way to identify which pages have been > >>> hinted on and which have not. The way I believe easiest to do this > >>> would be to overload the PageType value so that we could essentially > >>> have

Re: [PATCH v2] soc: fsl: add DPAA2 console support

2019-04-08 Thread Li Yang
On Fri, Apr 5, 2019 at 4:51 AM Ioana Ciornei wrote: > > This patch adds DPAA2 MC and AIOP console log support. > > The platform driver probes on the "fsl,dpaa2-console" device tree node > which describes the base firmware address needed in order to infer the > start address of both firmware logs:

Re: [PATCH 1/3] ARM: use arch_extension directive instead of arch argument

2019-04-08 Thread Stefan Agner
On 31.03.2019 19:34, Arnd Bergmann wrote: > On Sun, Mar 24, 2019 at 3:06 AM Arnd Bergmann wrote: >> >> On Sat, Mar 23, 2019 at 4:52 PM Stefan Agner wrote: >> > >> > The LLVM Target parser currently does not allow to specify the security >> > extension as part of -march (see also LLVM Bug 40186 [0

Re: [PATCH 4.20 105/171] net: stmmac: Send TSO packets always from Queue 0

2019-04-08 Thread Ben Hutchings
On Tue, 2019-03-12 at 10:08 -0700, Greg Kroah-Hartman wrote: > 4.20-stable review patch. If anyone has any objections, please let me know. > > -- > > [ Upstream commit c5acdbee22a1b200dde07effd26fd1f649e9ab8a ] > > The number of TSO enabled channels in HW can be different than t

Re: [PATCH RESEND 4/5] x86/MCE: Make number of MCA banks per_cpu

2019-04-08 Thread Luck, Tony
On Mon, Apr 08, 2019 at 02:12:17PM +, Ghannam, Yazen wrote: > +DEFINE_PER_CPU_READ_MOSTLY(u8, num_banks); > +EXPORT_PER_CPU_SYMBOL_GPL(num_banks); The name "num_banks" is a bit generic for an exported symbol. I think it should have a "mce_" prefix. -Tony

Re: [PATCH v4 3/3] fpga manager: Adding FPGA Manager support for Xilinx zynqmp

2019-04-08 Thread Alan Tull
On Mon, Apr 8, 2019 at 11:51 AM Moritz Fischer wrote: > > Hi Michal, > > On Mon, Apr 08, 2019 at 04:36:15PM +0200, Michal Simek wrote: > > On 08. 04. 19 16:17, Alan Tull wrote: > > > On Mon, Apr 8, 2019 at 7:39 AM Nava kishore Manne > > > wrote: > > >> > > >> Hi Alan, > > >> > > >> Thanks for lo

Re: linux-next: manual merge of the audit tree with Linus' tree

2019-04-08 Thread Paul Moore
On Mon, Apr 8, 2019 at 1:15 PM Dmitry V. Levin wrote: > On Mon, Apr 08, 2019 at 11:31:31AM +1000, Stephen Rothwell wrote: > > Hi all, > > > > Today's linux-next merge of the audit tree got conflicts in: > > > > arch/mips/kernel/ptrace.c > > kernel/seccomp.c > > > > between commit: > > > > b3

Re: [PATCH] perf header: Fix lock/unlock imbalances

2019-04-08 Thread Gustavo A. R. Silva
On 4/8/19 3:00 PM, Arnaldo Carvalho de Melo wrote: > Em Mon, Apr 08, 2019 at 02:52:52PM -0500, Gustavo A. R. Silva escreveu: >> >> >> On 4/8/19 2:35 PM, Arnaldo Carvalho de Melo wrote: >>> Em Mon, Apr 08, 2019 at 01:26:09PM -0500, Gustavo A. R. Silva escreveu: On 4/8/19 1:22 PM, S

Re: [PATCH RESEND 4/5] x86/MCE: Make number of MCA banks per_cpu

2019-04-08 Thread Borislav Petkov
On Mon, Apr 08, 2019 at 01:26:59PM -0700, Luck, Tony wrote: > On Mon, Apr 08, 2019 at 02:12:17PM +, Ghannam, Yazen wrote: > > +DEFINE_PER_CPU_READ_MOSTLY(u8, num_banks); > > +EXPORT_PER_CPU_SYMBOL_GPL(num_banks); > > The name "num_banks" is a bit generic for an exported symbol. > I think it sh

Re: [PATCH] ARM: dts: imx6qdl-nitrogen6_max: Disable LVDS channels

2019-04-08 Thread Fabio Estevam
Hi Robert, [Adding Gary] On Mon, Apr 8, 2019 at 2:54 PM Robert Foss wrote: > > If a LVDS device is not connected, having the LVDS channels > enabled will prevent imx-ldb from probing correctly even > if other CRTCs are connected. > > Signed-off-by: Robert Foss > --- > arch/arm/boot/dts/imx6qdl

RE: [PATCH RESEND 4/5] x86/MCE: Make number of MCA banks per_cpu

2019-04-08 Thread Luck, Tony
> Actually, it should not be exported at all. A function returning the num > banks is better instead. Are all the places it is used in non-pre-emptible sections of code? Looping in the CMCI and #MC handlers should be fine. But do we need get_cpu()/put_cpu() in any places? -Tony

Re: [PATCH 15/24] dt-bindings: pinctrl: pinctrl-mt65xx: add support for MT8516

2019-04-08 Thread Linus Walleij
On Sat, Mar 23, 2019 at 10:17 PM Fabien Parent wrote: > Add binding documentation of pinctrl-mt65xx for MT8516 SoC. > > Signed-off-by: Fabien Parent Patch applied with Rob's ACK. Yours, Linus Walleij

Re: Thoughts on simple scanner approach for free page hinting

2019-04-08 Thread David Hildenbrand
On 08.04.19 22:10, Alexander Duyck wrote: > On Mon, Apr 8, 2019 at 11:40 AM David Hildenbrand wrote: >> > > In addition we will need some way to identify which pages have been > hinted on and which have not. The way I believe easiest to do this > would be to overload the PageType v

Re: [PATCH RESEND 4/5] x86/MCE: Make number of MCA banks per_cpu

2019-04-08 Thread Borislav Petkov
On Mon, Apr 08, 2019 at 08:42:36PM +, Luck, Tony wrote: > > Actually, it should not be exported at all. A function returning the num > > banks is better instead. > > Are all the places it is used in non-pre-emptible sections of code? Looping > in the CMCI and #MC handlers should be fine. But d

Re: Thoughts on simple scanner approach for free page hinting

2019-04-08 Thread David Hildenbrand
On 08.04.19 22:10, Alexander Duyck wrote: > On Mon, Apr 8, 2019 at 11:40 AM David Hildenbrand wrote: >> > > In addition we will need some way to identify which pages have been > hinted on and which have not. The way I believe easiest to do this > would be to overload the PageType v

[PATCH v2 2/3] ARM: mvebu: drop unnecessary label

2019-04-08 Thread Stefan Agner
The label mvebu_boot_wa_start is not necessary and causes a build issue when building with LLVM's integrated assembler: AS arch/arm/mach-mvebu/pmsu_ll.o arch/arm/mach-mvebu/pmsu_ll.S:59:1: error: invalid symbol redefinition mvebu_boot_wa_start: ^ Drop the label. Signed-off-by: Stef

[PATCH v2 3/3] ARM: mvebu: prefix coprocessor operand with p

2019-04-08 Thread Stefan Agner
In every other instance where mrc is used the coprocessor operand is prefix with p (e.g. p15). Use the p prefix in this case too. This fixes a build issue when using LLVM's integrated assembler: arch/arm/mach-mvebu/coherency_ll.S:69:6: error: invalid operand for instruction mrc 15, 0, r3, cr0

[PATCH v2 1/3] ARM: use arch_extension directive instead of arch argument

2019-04-08 Thread Stefan Agner
The LLVM Target parser currently does not allow to specify the security extension as part of -march (see also LLVM Bug 40186 [0]). When trying to use Clang with LLVM's integrated assembler, this leads to build errors such as this: clang-8: error: the clang compiler does not support '-Wa,-march=ar

[PATCH v4] platform/chrome: mfd/cros_ec_debugfs: Add debugfs entry to retrieve EC uptime.

2019-04-08 Thread Tim Wawrzynczak
The new debugfs entry 'uptime' is being made available to userspace so that a userspace daemon can synchronize EC logs with host time. Signed-off-by: Tim Wawrzynczak --- Enric, AFAIK only the cros_ec supports the 'uptime' command for now. And yes, the file does need to be seekable; the userspace

Re: [PATCH 2/2] arm64: dts: h6: Add watchdog node

2019-04-08 Thread Clément Péron
On Mon, 8 Apr 2019 at 10:16, Maxime Ripard wrote: > > On Sun, Apr 07, 2019 at 04:27:36PM +0200, Clément Péron wrote: > > Hi, > > > > On Fri, 5 Apr 2019 at 18:24, Clément Péron wrote: > > > > > > Hi, > > > > > > On Fri, 5 Apr 2019 at 17:08, Maxime Ripard > > > wrote: > > > > > > > > On Fri, Apr

Re: Thoughts on simple scanner approach for free page hinting

2019-04-08 Thread David Hildenbrand
On 08.04.19 22:51, David Hildenbrand wrote: > On 08.04.19 22:10, Alexander Duyck wrote: >> On Mon, Apr 8, 2019 at 11:40 AM David Hildenbrand wrote: >>> >> >> In addition we will need some way to identify which pages have been >> hinted on and which have not. The way I believe easiest t

Re: [PATCH] x86/boot: This program cannot be run in DOS mode.$

2019-04-08 Thread Pavel Machek
On Mon 2019-04-08 20:08:09, Pali Rohár wrote: > On Monday 08 April 2019 20:04:22 Pavel Machek wrote: > > On Mon 2019-04-01 12:24:34, Pali Rohár wrote: > > > Every EFI binary is in PE format. And we know that PE format needs to have > > > MZ MS-DOS header as there is written offset to PE header. > >

[PATCH 01/12] s390: remove -fno-strength-reduce flag

2019-04-08 Thread Arnd Bergmann
This was added as a workaround for really old compilers, and it prevents building with clang now. I can see no reason for keeping it, as it has already been removed for most architectures in the pre-git era, so let's remove it everywhere, rather than only for clang. Signed-off-by: Arnd Bergmann -

[PATCH 03/12] s390: purgatory: pass --target option to clang

2019-04-08 Thread Arnd Bergmann
The purgatory Makefile does not inherit the original cflags, so clang falls back to the default target architecture when building it, typically this would be x86 when cross-compiling. Pass --target=s390x-linux to all compilers that understand this option. Signed-off-by: Arnd Bergmann --- arch/s

[PATCH 02/12] s390: don't build vdso32 with clang

2019-04-08 Thread Arnd Bergmann
clang does not support 31 bit object files on s390, so skip the 32-bit vdso here, and only build it when using gcc to compile the kernel. Signed-off-by: Arnd Bergmann --- arch/s390/Kconfig | 3 +++ arch/s390/kernel/Makefile | 2 +- arch/s390/kernel/vdso.c | 10 +- 3 files cha

linux-next: Fixes tags need some work in the sound-asoc tree

2019-04-08 Thread Stephen Rothwell
Hi all, In commit b4ed6b51f356 ("ASoC: core: conditionally increase module refcount on component open") Fixes tag Fixes: b450b878('ASoC: core: don't increase component module refcount has these problem(s): - missing space between the SHA1 and the subject - SHA1 should be at least 12

Re: Removing pcap? (EZX support in mainline linux)

2019-04-08 Thread Antonio Ospite
On Mon, 08 Apr 2019 21:14:44 +0200 Robert Jarzmik wrote: > Arnd Bergmann writes: > > > On Mon, Apr 8, 2019 at 8:58 AM Antonio Ospite wrote: > >> On Sun, 7 Apr 2019 16:07:41 +0200 > >> Alexandre Belloni wrote: > >> adding Robert to CC as he is listed as the current maintainer of > >> ARM/EZX S

[PATCH 04/12] s390: qeth: address type mismatch warning

2019-04-08 Thread Arnd Bergmann
clang produces a harmless warning for each use for the qeth_adp_supported macro: drivers/s390/net/qeth_l2_main.c:559:31: warning: implicit conversion from enumeration type 'enum qeth_ipa_setadp_cmd' to different enumeration type 'enum qeth_ipa_funcs' [-Wenum-conversion] if (qeth_adp

[PATCH 05/12] s390: zcrypt: initialize variables before_use

2019-04-08 Thread Arnd Bergmann
The 'func_code' variable gets printed in debug statements without a prior initialization in multiple functions, as reported when building with clang: drivers/s390/crypto/zcrypt_api.c:659:6: warning: variable 'func_code' is used uninitialized whenever 'if' condition is true [-Wsometimes-unin

[PATCH 08/12] s390: syscall_wrapper: avoid clang warning

2019-04-08 Thread Arnd Bergmann
Building system calls with clang results in a warning about an alias from a global function to a static one: ../fs/namei.c:3847:1: warning: unused function '__se_sys_mkdirat' [-Wunused-function] SYSCALL_DEFINE3(mkdirat, int, dfd, const char __user *, pathname, umode_t, mode) ^ ../include/linux/sy

[PATCH 07/12] s390: cio: fix cio_irb declaration

2019-04-08 Thread Arnd Bergmann
clang points out that the declaration of cio_irb does not match the definition exactly, it is missing the alignment attribute: ../drivers/s390/cio/cio.c:50:1: warning: section does not match previous declaration [-Wsection] DEFINE_PER_CPU_ALIGNED(struct irb, cio_irb); ^ ../include/linux/percpu-de

[PATCH 06/12] s390: ctcm: fix ctcm_new_device error return code

2019-04-08 Thread Arnd Bergmann
clang points out that the return code from this function is undefined for one of the error paths: ../drivers/s390/net/ctcm_main.c:1595:7: warning: variable 'result' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized] if (priv->channel[direction]

[PATCH 11/12] s390: make chkbss work with clang

2019-04-08 Thread Arnd Bergmann
llvm skips an empty .bss section entirely, which makes the check fail with an unexpected error: /tmp/binutils-multi-test/bin/s390x-linux-gnu-objdump: section '.bss' mentioned in a -j option, but not found in any input file error: arch/s390/boot/compressed/decompressor.o .bss section is not empty

[PATCH 10/12] s390: avoid __builtin_return_address(n) on clang

2019-04-08 Thread Arnd Bergmann
llvm on s390 has problems with __builtin_return_address(n), with n>0, this results in a somewhat cryptic error message: fatal error: error in backend: Unsupported stack frame traversal count To work around it, use the direct return address directly. This is probably not ideal here, but gets thing

[PATCH 12/12] [PROBABLY WRONG] s390: void '0' constraint in inline assembly

2019-04-08 Thread Arnd Bergmann
clang does not understand the contraint "0" in the CALL_ON_STACK() macro: ../arch/s390/mm/maccess.c:117:10: error: invalid input constraint '0' in asm return CALL_ON_STACK(_memcpy_real, S390_lowcore.nodat_stack, ^ ../arch/s390/include/asm/processor.h:292:20:

[PATCH 09/12] s390: make __load_psw_mask work with clang

2019-04-08 Thread Arnd Bergmann
clang fails to use the %O and %R inline assembly modifiers the same way as gcc, leading to build failures with every use of __load_psw_mask(): /tmp/nmi-4a9f80.s: Assembler messages: /tmp/nmi-4a9f80.s:571: Error: junk at end of line: `+8(160(%r11))' /tmp/nmi-4a9f80.s:626: Error: junk at end of line

linux-next: Fixes tags need some work in the cifs tree

2019-04-08 Thread Stephen Rothwell
Hi all, In commit 7d672725ba72 ("cifs: Fix lease buffer length error") Fixes tags Fixes: 9764c02fcbad(SMB3: Add support for multidialect negotiate (SMB2.1 and later)) Fixes: d5c7076b772a(smb3: add smb3.1.1 to default dialect list) has these problem(s): - missing space between the SHA

linux-next: Fixes tag needs some work in the nfsd tree

2019-04-08 Thread Stephen Rothwell
Hi all, In commit 3c86794ac0e6 ("nfsd/nfsd3_proc_readdir: fix buffer count and page pointers") Fixes tag Fixes: f875a79 "nfsd: allow nfsv3 readdir request to be larger" has these problem(s): - SHA1 should be at least 12 digits long Can be fixed by setting core.abbrev to 12 (or more)

[PATCH 09/14] media: ov6650: Fix incorrect use of JPEG colorspace

2019-04-08 Thread Janusz Krzysztofik
Since its initial submission, the driver selects V4L2_COLORSPACE_JPEG for supported formats other than V4L2_MBUS_FMT_SBGGR8_1X8. According to v4l2-compliance test program, V4L2_COLORSPACE_JPEG applies exclusively to V4L2_PIX_FMT_JPEG. Since the sensor does not support JPEG format, fix it to alway

[PATCH 12/14] media: ov6650: Fix default format not applied on device probe

2019-04-08 Thread Janusz Krzysztofik
It is not clear what pixel format is actually configured in hardware on reset. MEDIA_BUS_FMT_YUYV8_2X8, assumed on device probe since the driver was intiially submitted, is for sure not the one. Fix it by explicitly applying a known, driver default frame format just after initial device reset. F

[PATCH] selftests: cgroup: fix cleanup path in test_memcg_subtree_control()

2019-04-08 Thread Roman Gushchin
Dan reported, that cleanup path in test_memcg_subtree_control() triggers a static checker warning: ./tools/testing/selftests/cgroup/test_memcontrol.c:76 \ test_memcg_subtree_control() error: uninitialized symbol 'child2'. Fix this by initializing child2 and parent2 variables and split the cl

Re: [PATCH 1/4] glibc: Perform rseq(2) registration at C startup and thread creation (v7)

2019-04-08 Thread Carlos O'Donell
On 4/8/19 3:20 PM, Tulio Magno Quites Machado Filho wrote: Carlos O'Donell writes: On 4/5/19 5:16 AM, Florian Weimer wrote: * Carlos O'Donell: It is valuable that it be a trap, particularly for constant pools because it means that a jump into the constant pool will trap. Sorry, I don't und

[PATCH 0/7] introduce cpu.headroom knob to cpu controller

2019-04-08 Thread Song Liu
Servers running latency sensitive workload usually aren't fully loaded for various reasons including disaster readiness. The machines running our interactive workloads (referred as main workload) have a lot of spare CPU cycles that we would like to use for optimistic side jobs like video encodi

[PATCH 1/7] sched: refactor tg_set_cfs_bandwidth()

2019-04-08 Thread Song Liu
This patch factors tg_switch_cfs_runtime() out of tg_set_cfs_bandwidth(), so that next patches can extend tg_switch_cfs_runtime() to support the new target_idle_pct value. This patch doesn't have any functionality changes. Signed-off-by: Song Liu --- kernel/sched/core.c | 71 +++

Re: [PATCH 1/4] kernel-doc: Revert "scripts/kernel-doc: Processing -nofunc for functions only"

2019-04-08 Thread Jonathan Corbet
On Fri, 5 Apr 2019 14:44:50 -0700 Sean Christopherson wrote: > Now that Docbook has been deprecated in favor of Sphinx, the -nofunction > option in kernel-doc is defunct, e.g. Sphinx doesn't currently support > it. Furthermore, "functions only" behavior was used by Docproc to avoid > duplicatin

<    1   2   3   4   5   6   7   8   >