Re: [PATCH] KVM: x86: fix warning Using plain integer as NULL pointer

2019-04-08 Thread Sean Christopherson
Nit: For future reference, wrapping the warning text with quotes in the shortlog would be helpful. I initially read it as "fix a warning by using a plain integer as a NULL pointer". E.g.: KVM: x86: fix warning "Using plain integer as NULL pointer" On Sat, Apr 06, 2019 at 03:06:58

Re: [PATCH] apparmor: Restore Y/N in /sys for apparmor's "enabled"

2019-04-08 Thread John Johansen
On 4/8/19 9:07 AM, Kees Cook wrote: > Before commit c5459b829b71 ("LSM: Plumb visibility into optional "enabled" > state"), /sys/module/apparmor/parameters/enabled would show "Y" or "N" > since it was using the "bool" handler. After being changed to "int", > this switched to "1" or "0", breaking th

[PATCH 4/6] ARM: dts: sun8i: a83t: Add device node for CSI (Camera Sensor Interface)

2019-04-08 Thread Chen-Yu Tsai
From: Chen-Yu Tsai The A83T SoC has a camera sensor interface (known as CSI in Allwinner lingo), which is similar to the one found on the A64 and H3. The only difference seems to be that support of MIPI CSI through a connected MIPI CSI-2 bridge. Add a device node for it, and pinctrl nodes for th

[PATCH 2/6] dt-bindings: media: sun6i-csi: Add compatible string for A83T variant

2019-04-08 Thread Chen-Yu Tsai
From: Chen-Yu Tsai The A83T SoC has a camera sensor interface (known as CSI in Allwinner lingo), which is similar to the one found on the A64 and H3. The only difference seems to be that support of MIPI CSI through a connected MIPI CSI-2 bridge. Add a compatible string for this variant. Signed-

[PATCH 0/6] ARM: sun8i: a83t: Support Camera Sensor Interface controller

2019-04-08 Thread Chen-Yu Tsai
From: Chen-Yu Tsai Hi everyone, This series adds support for the camera sensor interface controller found on the Allwinner A83T SoC. The controller is similar to the one found on the H3, with the addition of a MIPI CSI-2 interface. However, this series only supports parallel and BT.656 interfac

Re: [PATCH] x86/mm/mem_encrypt: Disable all instrumentation for SME early boot code

2019-04-08 Thread Borislav Petkov
On Mon, Apr 08, 2019 at 04:46:31PM +, Gary R Hook wrote: > My reasoning (not arguing): the file has been touched exactly one time > in 4 years, by Thomas. Doesn't appear to be a candidate for constant > modification, so this approach doesn't seem risky to me. I could be wrong. The problem, l

[PATCH 03/10] docs: clearing-warn-once.txt: add a title for this document

2019-04-08 Thread Mauro Carvalho Chehab
This document misses a title. Add it, in order to follow the documentation standard. Signed-off-by: Mauro Carvalho Chehab --- Documentation/clearing-warn-once.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/clearing-warn-once.txt b/Documentation/clearing-warn-once.txt in

[RFC PATCH v2] perf/x86: make perf callchain work without CONFIG_FRAME_POINTER

2019-04-08 Thread Kairui Song
Currently perf callchain is not working properly with ORC unwinder, and sampling event from trace point. We'll get useless in kernel callchain like this: perf 6429 [000]22.498450: kmem:mm_page_alloc: page=0x176a17 pfn=1534487 order=0 migratetype=0 gfp_flags=GFP_KERNEL fff

Re: [PATCH v3 1/7] clkdev: Hold clocks_mutex while iterating clocks list

2019-04-08 Thread Stephen Boyd
Quoting Matti Vaittinen (2019-04-08 03:49:41) > On Fri, Apr 05, 2019 at 01:37:24PM -0700, Stephen Boyd wrote: > > Quoting Vaittinen, Matti (2019-04-04 23:51:43) > > > On Thu, 2019-04-04 at 14:53 -0700, Stephen Boyd wrote: > > > > We recently introduced a change to support devm clk lookups. That > >

Re: [PATCH v3 2/3] platform/x86: intel_pmc_core: Allow to dump debug registers on S0ix failure

2019-04-08 Thread Andy Shevchenko
On Fri, Apr 5, 2019 at 11:36 PM Rajat Jain wrote: > > Add a module parameter which when enabled, will check on resume, if the > last S0ix attempt was successful. If not, the driver would warn and provide > helpful debug information (which gets latched during the failed suspend > attempt) to debug

Re: [PATCH] tools/power turbostat: fix file descriptor leaks

2019-04-08 Thread Prarit Bhargava
On 4/8/19 12:12 PM, Gustavo A. R. Silva wrote: > Fix file descriptor leaks by closing fp before return. > > Addresses-Coverity-ID: 1444591 ("Resource leak") > Addresses-Coverity-ID: 1444592 ("Resource leak") > Fixes: 5ea7647b333f ("tools/power turbostat: Warn on bad ACPI LPIT data") > Signed-of

Re: [PATCH 24/27] x86/fpu: Add a fastpath to __fpu__restore_sig()

2019-04-08 Thread Thomas Gleixner
On Wed, 3 Apr 2019, Sebastian Andrzej Siewior wrote: > The previous commits refactor the restoration of the FPU registers so > that they can be loaded from in-kernel memory. This overhead can be > avoided if the load can be performed without a pagefault. > > Attempt to restore FPU registers by in

Re: [srcu] a365bb5f6e: leaking_addresses.proc.___srcu_struct_ptrs.

2019-04-08 Thread Mathieu Desnoyers
- On Apr 8, 2019, at 11:21 AM, paulmck paul...@linux.ibm.com wrote: > On Mon, Apr 08, 2019 at 10:57:50PM +0800, Rong Chen wrote: >> On Mon, Apr 08, 2019 at 07:30:37AM -0700, Paul E. McKenney wrote: >> > On Mon, Apr 08, 2019 at 09:56:10PM +0800, kernel test robot wrote: >> > > FYI, we noticed t

Re: [PATCH v3 3/3] platform/x86: intel_pmc_core: Instantiate pmc_core device on legacy platforms

2019-04-08 Thread Andy Shevchenko
On Fri, Apr 5, 2019 at 11:36 PM Rajat Jain wrote: > > Add code to instantiate the pmc_core platform device and thus attach to > the driver, if the ACPI device for the same ("INT33A1") is not present > in a system where it should be. This was discussed here: > https://www.mail-archive.com/linux-ker

Re: [PATCH v9 00/27] x86: load FPU registers on return to userland

2019-04-08 Thread Thomas Gleixner
On Wed, 3 Apr 2019, Sebastian Andrzej Siewior wrote: > This is a refurbished series originally started by by Rik van Riel. The > goal is load the FPU registers on return to userland and not on every > context switch. By this optimisation we can: > - avoid loading the registers if the task stays in

5.1.0-rc4: Oops in __rpc_execute() when trying to boot from NFS

2019-04-08 Thread Daniel Mack
Hi, I'm seeing the Oops below when trying to boot 5.1.0-rc4 on an ARM PXA3xx platform. v5.0 did not show this effect with the same cmdline. Relevant bits from the config are: CONFIG_NFS_FS=y CONFIG_NFS_V2=y CONFIG_NFS_V3=y # CONFIG_NFS_V3_ACL is not set # CONFIG_NFS_V4 is not set # CONFIG_NFS_SW

Re: [srcu] a365bb5f6e: leaking_addresses.proc.___srcu_struct_ptrs.

2019-04-08 Thread Paul E. McKenney
On Mon, Apr 08, 2019 at 01:06:56PM -0400, Mathieu Desnoyers wrote: > - On Apr 8, 2019, at 11:21 AM, paulmck paul...@linux.ibm.com wrote: > > > On Mon, Apr 08, 2019 at 10:57:50PM +0800, Rong Chen wrote: > >> On Mon, Apr 08, 2019 at 07:30:37AM -0700, Paul E. McKenney wrote: > >> > On Mon, Apr 08

[PATCH] selftests/ipc: Fix msgque compiler warnings

2019-04-08 Thread Kees Cook
This fixes the various compiler warnings when building the msgque selftest. The primary change is using sys/msg.h instead of linux/msg.h directly to gain the API declarations. Fixes: 3a665531a3b7 ("selftests: IPC message queue copy feature test") Signed-off-by: Kees Cook --- tools/testing/selfte

Re: [PATCH v4 1/3] firmware: xilinx: Add fpga API's

2019-04-08 Thread Moritz Fischer
Hi Nava, On Tue, Apr 02, 2019 at 06:01:21PM +0530, Nava kishore Manne wrote: > This Patch Adds fpga API's to support the Bitstream loading > by using firmware interface. > > Signed-off-by: Nava kishore Manne > --- > Changes for v4: > -None. > > Chnages for v3: > -Cre

Re: linux-next: manual merge of the audit tree with Linus' tree

2019-04-08 Thread Dmitry V. Levin
On Mon, Apr 08, 2019 at 11:31:31AM +1000, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the audit tree got conflicts in: > > arch/mips/kernel/ptrace.c > kernel/seccomp.c > > between commit: > > b35f549df1d7 ("syscalls: Remove start and number from > syscall_get_argume

Re: [v2,4/4] devfreq: add mediatek cci devfreq

2019-04-08 Thread Guenter Roeck
On Fri, Mar 29, 2019 at 02:46:12PM +0800, Andrew-sh Cheng wrote: > This adds a devfreq driver for the Cache Coherent Interconnect (CCI) > of the Mediatek MT8183. > > On the MT8183 the CCI is supplied by the same regulator as the LITTLE > cores. The driver is notified when the regulator voltage cha

Re: [PATCH v2] pinctrl:intel: Retain HOSTSW_OWN for requested gpio pin

2019-04-08 Thread Andy Shevchenko
On Mon, Apr 08, 2019 at 05:51:27PM +0800, Chris Chiu wrote: > The touchpad of the ASUS laptops E403NA, X540NA, X541NA are not > responsive after suspend/resume. The following error message > shows after resume. > i2c_hid i2c-ELAN1200:00: failed to reset device. > > On these laptops, the touchpad

Re: [PATCH] apparmor: Restore Y/N in /sys for apparmor's "enabled"

2019-04-08 Thread Kees Cook
On Mon, Apr 8, 2019 at 9:58 AM John Johansen wrote: > > +/* Can only be set before AppArmor is initialized (i.e. on boot cmdline). > > */ > > +static int param_set_aaintbool(const char *val, const struct kernel_param > > *kp) > > +{ > > + struct kernel_param kp_local; > > + bool value; >

Re: [PATCH v4 3/3] fpga: Add fpga manager driver for ARRI Altera FPP

2019-04-08 Thread Anatolij Gustschin
Hi, On Thu, 21 Feb 2019 21:25:06 +0100 Anatolij Gustschin ag...@denx.de wrote: ... > .../ABI/testing/sysfs-driver-ftdi-fifo-fpp| 7 + > drivers/fpga/Kconfig | 7 + > drivers/fpga/Makefile | 1 + > drivers/fpga/ftdi-fifo-fpp.c

Re: [srcu] a365bb5f6e: leaking_addresses.proc.___srcu_struct_ptrs.

2019-04-08 Thread Mathieu Desnoyers
- On Apr 8, 2019, at 1:10 PM, paulmck paul...@linux.ibm.com wrote: > On Mon, Apr 08, 2019 at 01:06:56PM -0400, Mathieu Desnoyers wrote: >> - On Apr 8, 2019, at 11:21 AM, paulmck paul...@linux.ibm.com wrote: >> >> > On Mon, Apr 08, 2019 at 10:57:50PM +0800, Rong Chen wrote: >> >> On Mon, A

Re: shmem_recalc_inode: unable to handle kernel NULL pointer dereference

2019-04-08 Thread Hugh Dickins
On Mon, 8 Apr 2019, Konstantin Khlebnikov wrote: > > I suppose your solution will wait for wakeup from shmem_evict_inode()? No, it's the other way round: shmem_unuse() gets on with its work without delay, shmem_evict_inode() waits until the stop_eviction count has gone down to zero, saying nobody

[PATCH v2 0/3] perf/x86/intel: force reschedule on TFA changes

2019-04-08 Thread Stephane Eranian
This short patch series improves the TFA patch series by adding a guarantee to users each time the allow_force_tsx_abort (TFA) sysctl control knob is modified. The current TFA support in perf_events operates as follow: - TFA=1 The PMU has priority over TSX, if PMC3 is needed, then TSX transac

[PATCH v2 2/2] perf/x86/intel: force resched when TFA sysctl is modified

2019-04-08 Thread Stephane Eranian
This patch provides guarantee to the sysadmin that when TFA is disabled, no PMU event is using PMC3 when the echo command returns. Vice-Versa, when TFA is enabled, PMU can use PMC3 immediately (to eliminate possible multiplexing). $ perf stat -a -I 1000 --no-merge -e branches,branches,branches,bra

[PATCH v2 1/2] perf/core: add perf_ctx_resched() as global function

2019-04-08 Thread Stephane Eranian
This patch add perf_ctx_resched() a global function that can be called to force rescheduling of events based on event types. The function locks both cpuctx and task_ctx internally. This will be used by a subsequent patch. Signed-off-by: Stephane Eranian Change-Id: Icbc05e5f461fd6e091b46778fe62b23

[PATCH] perf header: Fix lock/unlock imbalances

2019-04-08 Thread Gustavo A. R. Silva
Fix lock/unlock imbalances by refactoring the code a bit and adding calls to up_write() before return. Addresses-Coverity-ID: 1444315 ("Missing unlock") Addresses-Coverity-ID: 1444316 ("Missing unlock") Fixes: a70a1123174a ("perf bpf: Save BTF information as headers to perf.data") Fixes: 606f972b1

hello

2019-04-08 Thread jennifermercy
Hello did you received my previous email?

Re: [PATCH] staging: gdm724x: Add parenthesis to Macro arguments

2019-04-08 Thread Andre
Hi Greg, thanks for replying. On 03/04/2019 01:26, Greg KH wrote: > On Tue, Apr 02, 2019 at 10:04:05PM -0300, Andre Dainez wrote: >> Fix checkpatch errors: >> >> CHECK: Macro argument 'len' may be better as '(len)' to avoid precedence >> issues >> CHECK: Macro argument 'nlh' may be better as '(nl

next-20190408: Suspend/resume problems on Thinkpad X60

2019-04-08 Thread Pavel Machek
Hi! It boots ok (unlike mainline -- I'm debugging that), and I can suspend and resume... but then cursor in X is moving and I can talk to applications cached in memory, but any access to disk hangs. Any ideas? Pavel -- (eng

[PATCH linux-next v9 2/7] hexagon: define syscall_get_error() and syscall_get_return_value()

2019-04-08 Thread Dmitry V. Levin
syscall_get_* functions are required to be implemented on all architectures in order to extend the generic ptrace API with PTRACE_GET_SYSCALL_INFO request. This adds remaining 2 syscall_get_* functions as documented in asm-generic/syscall.h: syscall_get_error and syscall_get_return_value. Cc: Ric

[PATCH linux-next v9 1/7] nds32: fix asm/syscall.h

2019-04-08 Thread Dmitry V. Levin
All syscall_get_*() and syscall_set_*() functions must be defined as static inline as on all other architectures, otherwise asm/syscall.h cannot be included in more than one compilation unit. This bug has to be fixed in order to extend the generic ptrace API with PTRACE_GET_SYSCALL_INFO request.

[PATCH linux-next v9 3/7] mips: define syscall_get_error()

2019-04-08 Thread Dmitry V. Levin
syscall_get_error() is required to be implemented on all architectures in addition to already implemented syscall_get_nr(), syscall_get_arguments(), syscall_get_return_value(), and syscall_get_arch() functions in order to extend the generic ptrace API with PTRACE_GET_SYSCALL_INFO request. Acked-by

[PATCH linux-next v9 4/7] parisc: define syscall_get_error()

2019-04-08 Thread Dmitry V. Levin
syscall_get_error() is required to be implemented on all architectures in addition to already implemented syscall_get_nr(), syscall_get_arguments(), syscall_get_return_value(), and syscall_get_arch() functions in order to extend the generic ptrace API with PTRACE_GET_SYSCALL_INFO request. Acked-by

[PATCH linux-next v9 6/7] ptrace: add PTRACE_GET_SYSCALL_INFO request

2019-04-08 Thread Dmitry V. Levin
From: Elvira Khabirova PTRACE_GET_SYSCALL_INFO is a generic ptrace API that lets ptracer obtain details of the syscall the tracee is blocked in. There are two reasons for a special syscall-related ptrace request. Firstly, with the current ptrace API there are cases when ptracer cannot retrieve

[PATCH linux-next v9 7/7] selftests/ptrace: add a test case for PTRACE_GET_SYSCALL_INFO

2019-04-08 Thread Dmitry V. Levin
Check whether PTRACE_GET_SYSCALL_INFO semantics implemented in the kernel matches userspace expectations. Cc: Oleg Nesterov Cc: Andy Lutomirski Cc: Shuah Khan Cc: Elvira Khabirova Cc: Eugene Syromyatnikov Cc: linux-kselft...@vger.kernel.org Signed-off-by: Dmitry V. Levin --- Notes: v9:

Re: [PATCH] apparmor: Restore Y/N in /sys for apparmor's "enabled"

2019-04-08 Thread John Johansen
On 4/8/19 10:25 AM, Kees Cook wrote: > On Mon, Apr 8, 2019 at 9:58 AM John Johansen > wrote: >>> +/* Can only be set before AppArmor is initialized (i.e. on boot cmdline). >>> */ >>> +static int param_set_aaintbool(const char *val, const struct kernel_param >>> *kp) >>> +{ >>> + struct kerne

Re: [PATCH linux-next v9 7/7] selftests/ptrace: add a test case for PTRACE_GET_SYSCALL_INFO

2019-04-08 Thread shuah
On 4/8/19 11:42 AM, Dmitry V. Levin wrote: Check whether PTRACE_GET_SYSCALL_INFO semantics implemented in the kernel matches userspace expectations. Cc: Oleg Nesterov Cc: Andy Lutomirski Cc: Shuah Khan Cc: Elvira Khabirova Cc: Eugene Syromyatnikov Cc: linux-kselft...@vger.kernel.org Signed-

Re: [LINUX PATCH v2 3/3] spi: spi-mem: Add support for Zynq QSPI controller

2019-04-08 Thread Guenter Roeck
On Mon, Apr 01, 2019 at 01:29:13PM +0530, Naga Sureshkumar Relli wrote: > Add support for QSPI controller driver used by Xilinx Zynq SOC. > > Signed-off-by: Naga Sureshkumar Relli > --- > Changes in v2 > - Updated the driver to call spi_mem_default_supports_op() from >ctrl->supports_op() > C

Re: [PATCH RESEND 2/5] x86/MCE: Handle MCA controls in a per_cpu way

2019-04-08 Thread Borislav Petkov
On Mon, Apr 08, 2019 at 02:12:16PM +, Ghannam, Yazen wrote: > From: Yazen Ghannam > > Current AMD systems have unique MCA banks per logical CPU even though > the type of the banks may all align to the same bank number. Each CPU > will have control of a set of MCA banks in the hardware and the

[PATCH] ARM: dts: imx6qdl-nitrogen6_max: Disable LVDS channels

2019-04-08 Thread Robert Foss
If a LVDS device is not connected, having the LVDS channels enabled will prevent imx-ldb from probing correctly even if other CRTCs are connected. Signed-off-by: Robert Foss --- arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/a

Re: [PATCH -next] pinctrl: artpec6: Make two functions static

2019-04-08 Thread Nathan Chancellor
On Thu, Mar 21, 2019 at 11:09:09PM +0800, Yue Haibing wrote: > From: YueHaibing > > Fix sparse warnings: > > drivers/pinctrl/pinctrl-artpec6.c:691:5: warning: > symbol 'artpec6_pmx_enable' was not declared. Should it be static? > drivers/pinctrl/pinctrl-artpec6.c:705:6: warning: > symbol 'artp

[PULL 0/4] xtensa fixes for v5.1-rc5

2019-04-08 Thread Max Filippov
/xtensa-20190408 for you to fetch changes up to ecae26fae15abb7d433557afbd15467ce1c444f5: xtensa: fix format string warning in init_pmd (2019-04-04 18:45:55 -0700) xtensa fixes for v5.1-rc5 - fix syscall number passed to

Re: [PATCH linux-next v9 7/7] selftests/ptrace: add a test case for PTRACE_GET_SYSCALL_INFO

2019-04-08 Thread Dmitry V. Levin
On Mon, Apr 08, 2019 at 11:51:45AM -0600, shuah wrote: > On 4/8/19 11:42 AM, Dmitry V. Levin wrote: > > Check whether PTRACE_GET_SYSCALL_INFO semantics implemented in the kernel > > matches userspace expectations. > > > > Cc: Oleg Nesterov > > Cc: Andy Lutomirski > > Cc: Shuah Khan > > Cc: Elvi

Re: [PATCH] x86/boot: This program cannot be run in DOS mode.$

2019-04-08 Thread Pavel Machek
On Mon 2019-04-01 12:24:34, Pali Rohár wrote: > Every EFI binary is in PE format. And we know that PE format needs to have > MZ MS-DOS header as there is written offset to PE header. > > Therefore generated bzImage binary with CONFIG_EFI_STUB option is MS-DOS > executable binary. > > We already k

Re: [PATCH 2/7] watchdog/sbsa: Use arch_timer_read_counter instead of arch_counter_get_cntvct

2019-04-08 Thread Guenter Roeck
On Mon, Apr 08, 2019 at 04:49:02PM +0100, Marc Zyngier wrote: > Only arch_timer_read_counter will guarantee that workarounds are > applied. So let's use this one instead of arch_counter_get_cntvct. > > Signed-off-by: Marc Zyngier Reviewed-by: Guenter Roeck ... assuming/hoping that those counte

Re: [PATCH] x86/boot: This program cannot be run in DOS mode.$

2019-04-08 Thread Pali Rohár
On Monday 08 April 2019 20:04:22 Pavel Machek wrote: > On Mon 2019-04-01 12:24:34, Pali Rohár wrote: > > Every EFI binary is in PE format. And we know that PE format needs to have > > MZ MS-DOS header as there is written offset to PE header. > > > > Therefore generated bzImage binary with CONFIG_E

Re: [PATCH] module: add stub for within_module

2019-04-08 Thread Nick Desaulniers
On Sat, Apr 6, 2019 at 7:26 PM Tri Vo wrote: > > Provide a stub for within_module() when CONFIG_MODULES is not set. This > is needed to build CONFIG_GCOV_KERNEL. > > Fixes: 8c3d220cb6b5 ("gcov: clang support") The above commit got backed out of the -mm tree, due to the issue this patch addresses,

Re: Thoughts on simple scanner approach for free page hinting

2019-04-08 Thread Nitesh Narayan Lal
On 4/8/19 12:36 PM, David Hildenbrand wrote: > On 06.04.19 02:09, Alexander Duyck wrote: >> So I am starting this thread as a spot to collect my thoughts on the >> current guest free page hinting design as well as point out a few >> possible things we could do to improve upon it. >> >> 1. The curre

Re: [PATCH] module: add stub for within_module

2019-04-08 Thread Nick Desaulniers
On Mon, Apr 8, 2019 at 11:08 AM Nick Desaulniers wrote: > > On Sat, Apr 6, 2019 at 7:26 PM Tri Vo wrote: > > > > Provide a stub for within_module() when CONFIG_MODULES is not set. This > > is needed to build CONFIG_GCOV_KERNEL. > > > > Fixes: 8c3d220cb6b5 ("gcov: clang support") > > The above com

Re: [PATCH 19/27] x86/fpu: Update xstate's PKRU value on write_pkru()

2019-04-08 Thread Dave Hansen
On 4/3/19 9:41 AM, Sebastian Andrzej Siewior wrote: > During the context switch the xstate is loaded which also includes the > PKRU value. > If xstate is restored on return to userland it is required that the > PKRU value in xstate is the same as the one in the CPU. All of the protection keys bits

Re: [PATCH v3 3/3] platform/x86: intel_pmc_core: Instantiate pmc_core device on legacy platforms

2019-04-08 Thread Rajneesh Bhardwaj
On Fri, Apr 05, 2019 at 01:35:58PM -0700, Rajat Jain wrote: > Add code to instantiate the pmc_core platform device and thus attach to > the driver, if the ACPI device for the same ("INT33A1") is not present > in a system where it should be. This was discussed here: > https://www.mail-archive.com/li

Re: Thoughts on simple scanner approach for free page hinting

2019-04-08 Thread Alexander Duyck
On Mon, Apr 8, 2019 at 9:36 AM David Hildenbrand wrote: > > On 06.04.19 02:09, Alexander Duyck wrote: > > So I am starting this thread as a spot to collect my thoughts on the > > current guest free page hinting design as well as point out a few > > possible things we could do to improve upon it. >

Re: [patch V2 28/29] x86/irq/64: Remap the IRQ stack with guard pages

2019-04-08 Thread Thomas Gleixner
On Mon, 8 Apr 2019, Thomas Gleixner wrote: > On Mon, 8 Apr 2019, Andy Lutomirski wrote: > > On Sun, Apr 7, 2019 at 11:46 PM Thomas Gleixner wrote: > > > > > > On Sun, 7 Apr 2019, Andy Lutomirski wrote: > > > > On Sun, Apr 7, 2019 at 3:44 PM Thomas Gleixner > > > > wrote: > > > > > Actually we h

Re: [PATCH v3 3/4] mfd: cros_ec: instantiate properly CrOS FP MCU device

2019-04-08 Thread Benson Leung
Hi Enric, On Mon, Apr 08, 2019 at 11:41:40AM +0200, Enric Balletbo i Serra wrote: > Support Fingerprint MCU as a special of CrOS EC devices. The current FP > MCU uses the same EC SPI protocol v3 as other CrOS EC devices on a SPI > bus. > > When a MCU has fingerprint support (aka EC_FEATURE_FINGER

Re: Thoughts on simple scanner approach for free page hinting

2019-04-08 Thread Michael S. Tsirkin
On Mon, Apr 08, 2019 at 02:09:59PM -0400, Nitesh Narayan Lal wrote: > On 4/8/19 12:36 PM, David Hildenbrand wrote: > > On 06.04.19 02:09, Alexander Duyck wrote: > >> So I am starting this thread as a spot to collect my thoughts on the > >> current guest free page hinting design as well as point out

Re: [PATCH v3 4/4] mfd: cros_ec: instantiate properly CrOS Touchpad MCU device

2019-04-08 Thread Benson Leung
Hi Enric, On Mon, Apr 08, 2019 at 11:41:41AM +0200, Enric Balletbo i Serra wrote: > Support Touchpad MCU as a special of CrOS EC devices. The current > Touchpad MCU is used on Eve Chromebook and used the same protocol as > other CrOS EC devices. > > When a MCU has touchpad support (aka EC_FEATURE

Re: [alsa-devel] [PATCH] soundwire: fix pm_runtime_get_sync return code checks

2019-04-08 Thread Pierre-Louis Bossart
On 4/8/19 2:12 AM, Jan Kotas wrote: On 5 Apr 2019, at 17:04, Pierre-Louis Bossart wrote: On 4/5/19 2:26 AM, Jan Kotas wrote: ret = pm_runtime_get_sync(slave->bus->dev); - if (ret < 0) + if (ret < 0 && ret != -EACCES) There was a patch submitted on 3/28 by Srinivas

Re: [PATCH] perf header: Fix lock/unlock imbalances

2019-04-08 Thread Song Liu
> On Apr 8, 2019, at 10:33 AM, Gustavo A. R. Silva > wrote: > > Fix lock/unlock imbalances by refactoring the code a bit and adding > calls to up_write() before return. > > Addresses-Coverity-ID: 1444315 ("Missing unlock") > Addresses-Coverity-ID: 1444316 ("Missing unlock") > Fixes: a70a1123

Re: [PATCH v3 3/3] platform/x86: intel_pmc_core: Instantiate pmc_core device on legacy platforms

2019-04-08 Thread Rajat Jain
On Mon, Apr 8, 2019 at 11:15 AM Rajneesh Bhardwaj wrote: > > On Fri, Apr 05, 2019 at 01:35:58PM -0700, Rajat Jain wrote: > > Add code to instantiate the pmc_core platform device and thus attach to > > the driver, if the ACPI device for the same ("INT33A1") is not present > > in a system where it s

Re: [PATCH v3 3/3] platform/x86: intel_pmc_core: Instantiate pmc_core device on legacy platforms

2019-04-08 Thread Rajat Jain
On Mon, Apr 8, 2019 at 10:07 AM Andy Shevchenko wrote: > > On Fri, Apr 5, 2019 at 11:36 PM Rajat Jain wrote: > > > > Add code to instantiate the pmc_core platform device and thus attach to > > the driver, if the ACPI device for the same ("INT33A1") is not present > > in a system where it should b

Re: [PATCH] perf header: Fix lock/unlock imbalances

2019-04-08 Thread Gustavo A. R. Silva
On 4/8/19 1:22 PM, Song Liu wrote: > > >> On Apr 8, 2019, at 10:33 AM, Gustavo A. R. Silva >> wrote: >> >> Fix lock/unlock imbalances by refactoring the code a bit and adding >> calls to up_write() before return. >> >> Addresses-Coverity-ID: 1444315 ("Missing unlock") >> Addresses-Coverity-I

Re: Thoughts on simple scanner approach for free page hinting

2019-04-08 Thread David Hildenbrand
On 08.04.19 20:09, Nitesh Narayan Lal wrote: > On 4/8/19 12:36 PM, David Hildenbrand wrote: >> On 06.04.19 02:09, Alexander Duyck wrote: >>> So I am starting this thread as a spot to collect my thoughts on the >>> current guest free page hinting design as well as point out a few >>> possible things

Re: Thoughts on simple scanner approach for free page hinting

2019-04-08 Thread Alexander Duyck
On Mon, Apr 8, 2019 at 11:19 AM Michael S. Tsirkin wrote: > > On Mon, Apr 08, 2019 at 02:09:59PM -0400, Nitesh Narayan Lal wrote: > > On 4/8/19 12:36 PM, David Hildenbrand wrote: > > > On 06.04.19 02:09, Alexander Duyck wrote: > > >> So I am starting this thread as a spot to collect my thoughts on

[PATCH] zram: pass down the bvec we need to read into in the work struct

2019-04-08 Thread jglisse
From: Jérôme Glisse When scheduling work item to read page we need to pass down the proper bvec struct which point to the page to read into. Before this patch it uses randomly initialized bvec (only if PAGE_SIZE != 4096) which is wrong. Signed-off-by: Jérôme Glisse Cc: Minchan Kim Cc: Nitin Gu

Re: [PATCH v3 2/3] platform/x86: intel_pmc_core: Allow to dump debug registers on S0ix failure

2019-04-08 Thread Rajat Jain
On Mon, Apr 8, 2019 at 10:02 AM Andy Shevchenko wrote: > > On Fri, Apr 5, 2019 at 11:36 PM Rajat Jain wrote: > > > > Add a module parameter which when enabled, will check on resume, if the > > last S0ix attempt was successful. If not, the driver would warn and provide > > helpful debug informatio

[PATCH v3] pinctrl: imx8mq: Add suspend/resume ops

2019-04-08 Thread Abel Vesa
To support pinctl hog restore after LPSR resume back, add the generic suspend/resume in pinctrl-imx along with the generic pm ops to be used by platform specific drivers. Then make use of the newly added ops in i.MX8MQ platform specific driver. Signed-off-by: Robin Gong Signed-off-by: Abel Vesa

Re: Thoughts on simple scanner approach for free page hinting

2019-04-08 Thread David Hildenbrand
>>> >>> In addition we will need some way to identify which pages have been >>> hinted on and which have not. The way I believe easiest to do this >>> would be to overload the PageType value so that we could essentially >>> have two values for "Buddy" pages. We would have our standard "Buddy" >>> p

Re: [PATCH] x86/mm/mem_encrypt: Disable all instrumentation for SME early boot code

2019-04-08 Thread Gary R Hook
On 4/8/19 11:58 AM, Borislav Petkov wrote: > On Mon, Apr 08, 2019 at 04:46:31PM +, Gary R Hook wrote: >> My reasoning (not arguing): the file has been touched exactly one time >> in 4 years, by Thomas. Doesn't appear to be a candidate for constant >> modification, so this approach doesn't seem

Re: [PATCH v3 2/3] platform/x86: intel_pmc_core: Allow to dump debug registers on S0ix failure

2019-04-08 Thread Andy Shevchenko
On Mon, Apr 8, 2019 at 9:36 PM Rajat Jain wrote: > On Mon, Apr 8, 2019 at 10:02 AM Andy Shevchenko > wrote: > > On Fri, Apr 5, 2019 at 11:36 PM Rajat Jain wrote: > > Perhaps something like > > > > pmcdev->check_counters = false; > > /* User doesn't want to be warned */ > > if (!warn_on...) > >

Re: [PATCH v3 1/3] platform/x86: intel_pmc_core: Convert to a platform_driver

2019-04-08 Thread Rajat Jain
Hi, Thank you for the review. On Mon, Apr 8, 2019 at 9:51 AM Andy Shevchenko wrote: > > On Fri, Apr 5, 2019 at 11:36 PM Rajat Jain wrote: > > > > Convert the intel_pmc_core driver to a platform driver, and attach using > > the ACPI enumeration method (via the ACPI device "INT33A1"). > > > > Sig

[PATCH] MAINTAINERS: Add arm64/intel entry for SoCFPGA

2019-04-08 Thread Dinh Nguyen
Add arch/arm64/boot/dts/intel/ under Dinh Nguyen. Signed-off-by: Dinh Nguyen --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index e17ebf70b548..8c90df31aaf0 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2189,6 +2189,7 @@ F:arch/arm/mach-soc

Re: [PATCH v3 1/3] platform/x86: intel_pmc_core: Convert to a platform_driver

2019-04-08 Thread Andy Shevchenko
On Mon, Apr 8, 2019 at 9:43 PM Rajat Jain wrote: > On Mon, Apr 8, 2019 at 9:51 AM Andy Shevchenko > wrote: > > On Fri, Apr 5, 2019 at 11:36 PM Rajat Jain wrote: > > > + switch (boot_cpu_data.x86_model) { > > > > I didn't get why this should be boot CPU? > > Otherwise, leave the structure

Re: [PATCH v3 1/3] platform/x86: intel_pmc_core: Convert to a platform_driver

2019-04-08 Thread Rajat Jain
On Mon, Apr 8, 2019 at 11:44 AM Andy Shevchenko wrote: > > On Mon, Apr 8, 2019 at 9:43 PM Rajat Jain wrote: > > On Mon, Apr 8, 2019 at 9:51 AM Andy Shevchenko > > wrote: > > > On Fri, Apr 5, 2019 at 11:36 PM Rajat Jain wrote: > > > > > + switch (boot_cpu_data.x86_model) { > > > > > > I di

Re: 5.1.0-rc4: Oops in __rpc_execute() when trying to boot from NFS

2019-04-08 Thread Trond Myklebust
On Mon, 2019-04-08 at 19:01 +0200, Daniel Mack wrote: > Hi, > > I'm seeing the Oops below when trying to boot 5.1.0-rc4 on an ARM > PXA3xx > platform. v5.0 did not show this effect with the same cmdline. > > Relevant bits from the config are: > > CONFIG_NFS_FS=y > CONFIG_NFS_V2=y > CONFIG_NFS_V3

Re: [GIT PULL] Kselftest update for Linux 5.1-rc4

2019-04-08 Thread shuah
On 4/3/19 7:34 PM, shuah wrote: Hi Linus, Please pull the following Kselftest update for Linux 5.1-rc4 This Kselftest update for Linux 5.1-rc4 consists of fixes to rseq, cgroup, and efivarfs tests. diff is attached. thanks, -- Shuah Hi Linus, I just noticed that one commit in this pull re

[RESEND] arm64: defconfig: Enable RTC_DRV_SNVS

2019-04-08 Thread Abel Vesa
i.MX8MQ needs it for RTC support. Signed-off-by: Abel Vesa --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index 9e313f5..81739d6 100644 --- a/arch/arm64/configs/defconfig +++ b/arch/arm64/configs/de

Re: [PATCH kselftest-next] selftests: cgroup: fix cleanup path in test_memcg_subtree_control()

2019-04-08 Thread shuah
On 3/27/19 8:56 PM, Roman Gushchin wrote: Dan reported, that cleanup path in test_memcg_subtree_control() triggers a static checker warning: ./tools/testing/selftests/cgroup/test_memcontrol.c:76 \ test_memcg_subtree_control() error: uninitialized symbol 'child2'. Fix this by initializin

RE: [PATCH RESEND 2/5] x86/MCE: Handle MCA controls in a per_cpu way

2019-04-08 Thread Ghannam, Yazen
> -Original Message- > From: Borislav Petkov > Sent: Monday, April 8, 2019 12:52 PM > To: Ghannam, Yazen > Cc: linux-e...@vger.kernel.org; linux-kernel@vger.kernel.org; > tony.l...@intel.com; x...@kernel.org > Subject: Re: [PATCH RESEND 2/5] x86/MCE: Handle MCA controls in a per_cpu way

Re: [PATCH v3 2/3] platform/x86: intel_pmc_core: Allow to dump debug registers on S0ix failure

2019-04-08 Thread Rajat Jain
On Mon, Apr 8, 2019 at 11:41 AM Andy Shevchenko wrote: > > On Mon, Apr 8, 2019 at 9:36 PM Rajat Jain wrote: > > On Mon, Apr 8, 2019 at 10:02 AM Andy Shevchenko > > wrote: > > > On Fri, Apr 5, 2019 at 11:36 PM Rajat Jain wrote: > > > > Perhaps something like > > > > > > pmcdev->check_counters =

Re: Thoughts on simple scanner approach for free page hinting

2019-04-08 Thread David Hildenbrand
>>> - Define and use counters corresponding to each zone to monitor the >>> amount of memory freed. >>> - As soon as the 64MB free memory threshold is hit wake up the kernel >>> thread which will scan this xbitmap and try to isolate the pages and >>> clear the corresponding bits. (We still have to

[ANNOUNCE] 4.14.109-rt57

2019-04-08 Thread Tom Zanussi
Hello RT Folks! I'm pleased to announce the 4.14.109-rt57 stable release. This release is just an update to the new stable 4.14.109 version and no RT specific changes have been made. You can get this release via the git tree at: git://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-stable-rt

Re: [PATCH] x86/mm/mem_encrypt: Disable all instrumentation for SME early boot code

2019-04-08 Thread Borislav Petkov
On Mon, Apr 08, 2019 at 06:41:30PM +, Gary R Hook wrote: > Again, not arguing. I completely understand. However, to be fair, this > isn't about SME having trouble with those facilities, this is about > using certain features (e.g. command line option processing) early in > the boot. Any comp

Re: [PATCH 6/6] Input: add IOC3 serio driver

2019-04-08 Thread Alexandre Belloni
On 08/04/2019 12:02:18-0700, Dmitry Torokhov wrote: > > +MODULE_AUTHOR("Stanislaw Skowronek "); > > +MODULE_DESCRIPTION("SGI IOC3 serio driver"); > > +MODULE_LICENSE("GPL"); > > "GPL v2" to match SPDX header? > I've been told this is not true: https://lore.kernel.org/linux-rtc/37140784dbd28

[PATCH] x86: mm: Do not use set_{pud,pmd}_safe when splitting the large page

2019-04-08 Thread Singh, Brijesh
The following commit 0a9fe8ca844d ("x86/mm: Validate kernel_physical_mapping_init() PTE population") triggers the below warning in the SEV guest. WARNING: CPU: 0 PID: 0 at arch/x86/include/asm/pgalloc.h:87 phys_pmd_init+0x30d/0x386 Call Trace: kernel_physical_mapping_init+0xce/0x259 early_set_

[PATCH 00/13] Linux 4.14.109-rt58-rc1

2019-04-08 Thread Tom Zanussi
From: Tom Zanussi Hello RT Folks! This is the RT stable review cycle of patch 4.14.109-rt58-rc1. Please scream at me if I messed something up. Please test the patches too. The -rc release will be uploaded to kernel.org and will be deleted when the final release is out. This is just a review re

[PATCH 01/13] arm64: fpsimd: use preemp_disable in addition to local_bh_disable()

2019-04-08 Thread Tom Zanussi
4.14.109-rt58-rc1 stable review patch. If anyone has any objections, please let me know. -- From: Sebastian Andrzej Siewior [ Upstream commit 3afdfe419c33c1655d0763e070350aad44416594 ] In v4.16-RT I noticed a number of warnings from task_fpsimd_load(). The code disables BH and

[PATCH 07/13] softirq: Avoid "local_softirq_pending" messages if task is in cpu_chill()

2019-04-08 Thread Tom Zanussi
4.14.109-rt58-rc1 stable review patch. If anyone has any objections, please let me know. -- From: Sebastian Andrzej Siewior [ Upstream commit a3429e0147dfd3fc585f989aa49a76579c2b6565 ] If the softirq thread enters cpu_chill() then ->state is UNINTERRUPTIBLE and has no ->pi_bloc

[PATCH 03/13] sched/fair: Make the hrtimers non-hard again

2019-04-08 Thread Tom Zanussi
4.14.109-rt58-rc1 stable review patch. If anyone has any objections, please let me know. -- From: Sebastian Andrzej Siewior [ Upstream commit 73d5c2697339118cd33dc1ff1ffcb21d59cafe1a ] Since commit "sched/fair: Robustify CFS-bandwidth timer locking" both hrtimer can run in soft

[PATCH 09/13] x86: lazy-preempt: properly check against preempt-mask

2019-04-08 Thread Tom Zanussi
4.14.109-rt58-rc1 stable review patch. If anyone has any objections, please let me know. -- From: Sebastian Andrzej Siewior [ Upstream commit 0f8a27bb5f45cc8a66f488549cecc4ce4d4533c2 ] should_resched() should check against preempt_offset after unmasking the need-resched-bit. Ot

[PATCH 13/13] Linux 4.14.109-rt58

2019-04-08 Thread Tom Zanussi
4.14.109-rt58-rc1 stable review patch. If anyone has any objections, please let me know. -- From: Tom Zanussi --- localversion-rt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/localversion-rt b/localversion-rt index c06cc4356292..f9df2cf089cf 100644 --- a/

[PATCH 11/13] tty/sysrq: Convert show_lock to raw_spinlock_t

2019-04-08 Thread Tom Zanussi
4.14.109-rt58-rc1 stable review patch. If anyone has any objections, please let me know. -- From: Julien Grall [ Upstream commit db80c207bffd0f49e984e9889ce62279bc3abd6c ] Systems which don't provide arch_trigger_cpumask_backtrace() will invoke showacpu() from a smp_call_functi

[PATCH 08/13] hrtimer: Don't lose state in cpu_chill()

2019-04-08 Thread Tom Zanussi
4.14.109-rt58-rc1 stable review patch. If anyone has any objections, please let me know. -- From: Sebastian Andrzej Siewior [ Upstream commit 585456236766349f692f9fbcc089d71411831f88 ] In cpu_chill() the state is set to TASK_UNINTERRUPTIBLE and a timer is programmed. On return

[PATCH] Coccinelle: kstrdup: Fix typo in warning messages

2019-04-08 Thread Rikard Falkeborn
Replace 'kstrdep' with 'kstrdup' in warning messages. Signed-off-by: Rikard Falkeborn --- scripts/coccinelle/api/kstrdup.cocci | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/scripts/coccinelle/api/kstrdup.cocci b/scripts/coccinelle/api/kstrdup.cocci index 09cba54ed0

Re: Removing pcap? (EZX support in mainline linux)

2019-04-08 Thread Robert Jarzmik
Arnd Bergmann writes: > On Mon, Apr 8, 2019 at 8:58 AM Antonio Ospite wrote: >> On Sun, 7 Apr 2019 16:07:41 +0200 >> Alexandre Belloni wrote: >> adding Robert to CC as he is listed as the current maintainer of >> ARM/EZX SMARTPHONES in the MAINTAINERS file. >> >> > I've had a look at the PCAP R

[PATCH 10/13] hrtimer: cpu_chill(): save task state in ->saved_state()

2019-04-08 Thread Tom Zanussi
4.14.109-rt58-rc1 stable review patch. If anyone has any objections, please let me know. -- From: Sebastian Andrzej Siewior [ Upstream commit d70f218ee02d6fc3832274653aa6c6e98dd9aa43 ] In the previous change I saved the current task state on stack. This was bad because while th

[PATCH 06/13] softirq: Avoid "local_softirq_pending" messages if ksoftirqd is blocked

2019-04-08 Thread Tom Zanussi
4.14.109-rt58-rc1 stable review patch. If anyone has any objections, please let me know. -- From: Sebastian Andrzej Siewior [ Upstream commit 2cf32c1a3d9352df8017dbf84a1462c4a60a1826 ] If the ksoftirqd thread has a softirq pending and is blocked on the `local_softirq_locks' loc

<    1   2   3   4   5   6   7   8   >