Re: [PATCH 1/2] fsl_hypervisor: dereferencing error pointers in ioctl

2019-04-04 Thread Dan Carpenter
I sent this patch series right before Christmas so everyone was on holiday. It still applies fine. Could you take a look at it? regards, dan carpenter

Re: [PATCH] staging: rtl8192u: remove redundant null check on array 'data'

2019-04-04 Thread Mukesh Ojha
On 4/4/2019 3:02 PM, Colin King wrote: From: Colin Ian King The NULL check on ram->u.wpa_ie.data is redudant as data is s/redudant/redundant zero-length array and is not a pointer, so it can't be null. Remove the check. Addresses-Coverity: ("Array compared against 0") Signed-off-by: Colin

[PATCH v2 0/2] Amazon's Annapurna Labs Thermal Sensor Driver

2019-04-04 Thread Talel Shenhar
This series introduces support for Amazon's Annapurna Labs Thermal Sensor based on a new simple MMIO thermal driver. This driver is intended to be used by other devices as well, which require just a simple MMIO access to read temperature. Changes since v1: == - removed the "therma

[PATCH v2 2/2] thermal: Introduce Amazon's Annapurna Labs Thermal Driver

2019-04-04 Thread Talel Shenhar
This is a generic thermal driver for simple MMIO sensors, of which amazon,al-thermal is one. This device uses a single MMIO transaction to read the temperature and report it to the thermal subsystem. Signed-off-by: Talel Shenhar Reviewed-by: David Woodhouse --- MAINTAINERS|

[PATCH v2 1/2] dt-bindings: thermal: al-thermal: Add binding documentation

2019-04-04 Thread Talel Shenhar
Add thermal binding documentation for Amazon's Annapurna Labs Thermal Sensor. Signed-off-by: Talel Shenhar Reviewed-by: David Woodhouse --- .../bindings/thermal/amazon,al-thermal.txt | 33 ++ 1 file changed, 33 insertions(+) create mode 100644 Documentation/devicet

[PATCH v13 0/8] support ROHM BD70528 PMIC

2019-04-04 Thread Matti Vaittinen
Patch series introducing support for ROHM BD70528 PMIC ROHM BD70528 is a programmable Power Management IC for battery powered 'ultra low power' systems like the pre-announced NXP i.MX7 ULP. This patch series introduces support for the PMIC. Please note that this driver only supports HW setup where

Re: [PATCH 09/10] ALSA: pcm: Add snd_pcm_ops for snd_pcm_link()

2019-04-04 Thread Timo Wischer
On 3/27/19 10:38, Takashi Iwai wrote: On Wed, 27 Mar 2019 10:26:56 +0100, Timo Wischer wrote: On 3/27/19 10:11, Takashi Iwai wrote: On Wed, 27 Mar 2019 09:34:40 +0100, Timo Wischer wrote: On 3/26/19 17:00, Takashi Iwai wrote: On Tue, 26 Mar 2019 16:16:54 +0100, Timo Wischer wrote: On 3/26/19

[PATCH v13 1/8] mfd: regulator: clk: split rohm-bd718x7.h

2019-04-04 Thread Matti Vaittinen
Split the bd718x7.h to ROHM common and bd718x7 specific parts so that we do not need to add same things in every new ROHM PMIC header. Please note that this change requires changes also in bd718x7 sub-device drivers for regulators and clk. Signed-off-by: Matti Vaittinen Acked-by: Mark Brown Acke

[PATCH v13 2/8] mfd: bd70528: Support ROHM bd70528 PMIC - core

2019-04-04 Thread Matti Vaittinen
ROHM BD70528MWV is an ultra-low quiescent current general purpose single-chip power management IC for battery-powered portable devices. Add MFD core which enables chip access for following subdevices: - regulators/LED drivers - battery-charger - gpios - 32.768kHz cl

Re: [PATCH 2/2] tty: fix up a few remaining files without SPDX identifiers

2019-04-04 Thread Greg Kroah-Hartman
On Thu, Apr 04, 2019 at 02:16:06PM +0530, Mukesh Ojha wrote: > > On 4/2/2019 7:37 PM, Greg Kroah-Hartman wrote: > > There were a few straggling files under drivers/tty/ that did not have > > any SPDX identifier either because they entered the tree recently, or > > they somehow missed the mass-tagg

[PATCH v13 3/8] clk: bd718x7: Support ROHM BD70528 clk block

2019-04-04 Thread Matti Vaittinen
ROHM BD70528 is an ultra low power PMIC with similar 32K clk as bd718x7. Only difference (from clk perspective) is register address. Add support for controlling BD70528 clk using bd718x7 driver. Signed-off-by: Matti Vaittinen Acked-by: Stephen Boyd --- Changelog v13: - No changes Changelog v12:

Re: [PATCH 0/4] mm,memory_hotplug: allocate memmap from hotadded memory

2019-04-04 Thread Vlastimil Babka
On 4/3/19 11:40 AM, Oscar Salvador wrote: > On Wed, Apr 03, 2019 at 10:37:57AM +0200, Michal Hocko wrote: >> That being said it should be the caller of the hotplug code to tell >> the vmemmap allocation strategy. For starter, I would only pack vmemmaps >> for "regular" kernel zone memory. Movable z

[PATCH v13 4/8] dt-bindings: mfd: Document first ROHM BD70528 bindings

2019-04-04 Thread Matti Vaittinen
Document bindings for regulators (3 bucks, 3 LDOs and 2 LED drivers) and 4 GPIO pins which can be configured for I/O or as interrupt sources withe configurable trigger levels. Signed-off-by: Matti Vaittinen Reviewed-by: Rob Herring Acked-by: Linus Walleij --- Changelog v13: - No changes Change

[PATCH v13 5/8] gpio: Initial support for ROHM bd70528 GPIO block

2019-04-04 Thread Matti Vaittinen
ROHM BD70528 PMIC has 4 GPIO pins. Allow them to be controlled by GPIO framework. IRQs are handled by regmap-irq and GPIO driver is not aware of the irq usage. Signed-off-by: Matti Vaittinen Reviewed-by: Linus Walleij --- Changelog v13: - No changes Changelog v12: - No functional changes - Sty

[PATCH v13 6/8] rtc: bd70528: Initial support for ROHM bd70528 RTC

2019-04-04 Thread Matti Vaittinen
Support RTC block in ROHM bd70528 power management IC. Support getting and setting the time and date as well as arming an alarm which can also be used to wake the PMIC from standby state. HW supports wake interrupt only for the next 24 hours (sec, minute and hour information only) so we limit also

[PATCH v13 7/8] power: supply: Initial support for ROHM BD70528 PMIC charger block

2019-04-04 Thread Matti Vaittinen
ROHM BD70528 PMIC includes battery charger block. Support charger staus queries and doing few basic settings like input current limit and charging current. Signed-off-by: Matti Vaittinen --- Changelog v13: - no changes Changelog v12: - Styling fixes only drivers/power/supply/Kconfig

Re: [PATCH 2/4] mm, memory_hotplug: provide a more generic restrictions for memory hotplug

2019-04-04 Thread Michal Hocko
On Thu 04-04-19 12:04:05, Oscar Salvador wrote: > On Wed, Apr 03, 2019 at 10:46:03AM +0200, Michal Hocko wrote: > > On Thu 28-03-19 14:43:18, Oscar Salvador wrote: > > > From: Michal Hocko > > > > > > arch_add_memory, __add_pages take a want_memblock which controls whether > > > the newly added m

[PATCH v13 8/8] watchdog: bd70528: Initial support for ROHM BD70528 watchdog block

2019-04-04 Thread Matti Vaittinen
Initial support for watchdog block included in ROHM BD70528 power management IC. Configurations for low power states are still to be checked. Signed-off-by: Matti Vaittinen Acked-by: Guenter Roeck --- Changelog v13 - Moved WDT enable/disable code from MFD to WDT as was (strongly) suggested by

Re: [PATCH v2 0/2] Fix Arm system PMU hotplug issues

2019-04-04 Thread Corentin Labbe
On Wed, Apr 03, 2019 at 06:08:58PM +0100, Robin Murphy wrote: > Hi all, > > After a converstaion with Thomas a while back, it felt like the best way > forward here is just to resolve the pressing preemption violation, and > not make things more complicated by trying to manage theoretical races > w

fs/adfs - keep or kill it?

2019-04-04 Thread Russell King - ARM Linux admin
Hi, Recently, a couple of issues have been identified in fs/adfs: 1. Filename truncation may not work as it should, and Linus has apparently expressed a desire to kill this off. 2. Scanning the ADFS map for disc object fragments may mistakenly find free space fragments in addition to real

Re: [PATCH 5.0 070/246] kbuild: make -r/-R effective in top Makefile for old Make versions

2019-04-04 Thread Greg Kroah-Hartman
On Thu, Apr 04, 2019 at 06:16:37PM +0900, Masahiro Yamada wrote: > Hi. > > > On Thu, Apr 4, 2019 at 6:11 PM Greg Kroah-Hartman > wrote: > > > > 5.0-stable review patch. If anyone has any objections, please let me know. > > > > -- > > > > [ Upstream commit 3812b8c5c5d527239ac015f

[PATCH 4.19 132/187] sched/debug: Initialize sd_sysctl_cpus if !CONFIG_CPUMASK_OFFSTACK

2019-04-04 Thread Greg Kroah-Hartman
4.19-stable review patch. If anyone has any objections, please let me know. -- [ Upstream commit 1ca4fa3ab604734e38e2a3000c9abf788512ffa7 ] register_sched_domain_sysctl() copies the cpu_possible_mask into sd_sysctl_cpus, but only if sd_sysctl_cpus hasn't already been allocated (

[PATCH 4.14 086/121] sched/debug: Initialize sd_sysctl_cpus if !CONFIG_CPUMASK_OFFSTACK

2019-04-04 Thread Greg Kroah-Hartman
4.14-stable review patch. If anyone has any objections, please let me know. -- [ Upstream commit 1ca4fa3ab604734e38e2a3000c9abf788512ffa7 ] register_sched_domain_sysctl() copies the cpu_possible_mask into sd_sysctl_cpus, but only if sd_sysctl_cpus hasn't already been allocated (

[PATCH] gpio: merrifield: Fix build err without CONFIG_ACPI

2019-04-04 Thread Yue Haibing
From: YueHaibing When building CONFIG_ACPI is not set gcc warn this: drivers/gpio/gpio-merrifield.c: In function mrfld_gpio_get_pinctrl_dev_name: drivers/gpio/gpio-merrifield.c:388:19: error: dereferencing pointer to incomplete type struct acpi_device put_device(&adev->dev);

Re: [PATCH v2 1/2] perf/arm-cci: Remove broken race mitigation

2019-04-04 Thread Suzuki K Poulose
On 03/04/2019 18:10, Robin Murphy wrote: Uncore PMU drivers face an awkward cyclic dependency wherein: - They have to pick a valid online CPU to associate with before registering the PMU device, since it will get exposed to userspace immediately. - The PMU registration has to be b

[PATCH 5.0 174/246] sched/debug: Initialize sd_sysctl_cpus if !CONFIG_CPUMASK_OFFSTACK

2019-04-04 Thread Greg Kroah-Hartman
5.0-stable review patch. If anyone has any objections, please let me know. -- [ Upstream commit 1ca4fa3ab604734e38e2a3000c9abf788512ffa7 ] register_sched_domain_sysctl() copies the cpu_possible_mask into sd_sysctl_cpus, but only if sd_sysctl_cpus hasn't already been allocated (i

[PATCH] extcon: axp288: Fix build err without CONFIG_ACPI

2019-04-04 Thread Yue Haibing
From: YueHaibing When building CONFIG_ACPI is not set gcc warn this: drivers/extcon/extcon-axp288.c: In function 'axp288_extcon_probe': drivers/extcon/extcon-axp288.c:363:20: error: dereferencing pointer to incomplete type put_device(&adev->dev); Reported-by: Hulk Robot Fixes: 0cf064db948

Re: [PATCH v2 2/2] perf/arm-ccn: Remove broken race mitigation

2019-04-04 Thread Suzuki K Poulose
Hi Robin, On 03/04/2019 18:10, Robin Murphy wrote: Like arm-cci, arm-ccn has the same issue of disabling preemption around operations which can take mutexes. Again, remove the definite bug by simply not trying to fight the theoretical races. And since we are touching the hotplug handling code, t

[PATCH -next] mtd: rawnand: ingenic: Add missing MODULE_* information

2019-04-04 Thread Yue Haibing
From: YueHaibing gcc warning this: WARNING: modpost: missing MODULE_LICENSE() in drivers/mtd/nand/raw/ingenic/ingenic_ecc.o Add MODULE_LICENSE,MODULE_AUTHOR and MODULE_DESCRIPTION. Reported-by: Hulk Robot Fixes: 9df5741a577e ("mtd: rawnand: ingenic: Separate top-level and SoC specific code"

Re: [PATCH] soc: fsl: add DPAA2 console support

2019-04-04 Thread Ioana Ciornei
On 4/3/19 10:55 PM, Li Yang wrote: > On Tue, Mar 26, 2019 at 2:17 PM Ioana Ciornei wrote: >> >> This patch adds DPAA2 MC and AIOP console log support. >> >> The platform driver probes on the "fsl,dpaa2-console" device tree node >> which describes the base firmware address needed in order to infer

Re: [PATCH] pinctrl: intel: Implements gpio free function

2019-04-04 Thread Enrico Weigelt, metux IT consult
On 03.04.19 06:13, Linus Walleij wrote: > But the chardev on the other hand will protect you from all this.> > If the > program crashes, the lines will be free:ed.> > If two scripts try to access the same GPIO, they will be denied. Right, when you want this concurrency protection and cleanup stif

Re: [PATCH v4 5/5] xfs: disable map_sync for async flush

2019-04-04 Thread Pankaj Gupta
> > On Thu, Apr 04, 2019 at 02:12:30AM -0400, Pankaj Gupta wrote: > > > All this ad hoc IS_DAX conditional logic is getting pretty nasty. > > > > > > xfs_file_mmap( > > > > > > { > > > struct inode*inode = file_inode(filp); > > > > > > if (vma->vm_flags & VM_SYNC) { > > >

Re: [RFC PATCH] arm64/fpsimd: Don't disable softirq when touching FPSIMD/SVE state

2019-04-04 Thread Dave Martin
On Fri, Feb 08, 2019 at 04:55:13PM +, Julien Grall wrote: > When the kernel is compiled with CONFIG_KERNEL_MODE_NEON, some part of > the kernel may be able to use FPSIMD/SVE. This is for instance the case > for crypto code. > > Any use of FPSIMD/SVE in the kernel are clearly marked by using th

[PATCH v2] acct: fix possible deadlock in acct_pin_kill

2019-04-04 Thread Amir Goldstein
This looks like an old bug, pre-dating the "Fixes" commit, but the "Fixes" commit did not handle it properly. The bug recently surfaced as a lockdep possible deadlock warning with commit d1d04ef8572b ("ovl: stack file ops"). When acct_on() replaces one acct file with another, it takes sb_writers

Loan Offer

2019-04-04 Thread Greenlight Financial Services
Do you need a Loan @ 2% P.A? Mail us your: Names,Home Add,Mob No,Email id,Amount Needed,Loan Duration,Occupation :If you are interested kindly contact us via email for more details

Re: [PATCH 1/3] nvmem: imx-ocotp: use devm_platform_ioremap_resource() to simplify code

2019-04-04 Thread Srinivas Kandagatla
On 01/04/2019 05:59, Anson Huang wrote: Use the new helper devm_platform_ioremap_resource() which wraps the platform_get_resource() and devm_ioremap_resource() together, to simplify the code. Signed-off-by: Anson Huang Applied series to nvmem-next Thanks, srini

Re: [PATCH v2 2/8] kbuild: Support for Symbols.list creation

2019-04-04 Thread Miroslav Benes
On Wed, 3 Apr 2019, Miroslav Benes wrote: > > > > Hmm, maybe I spoke too soon. > > > > > > I am having issues if I have a two-object livepatch module in which each > > > object file needs to specify its own KLP_MODULE_RELOC for the same > > > symbol name. > > > > > > For example: I have test_klp_

Re: [PATCH v2 4/5] nvmem: sunxi-sid: add new reg_read func

2019-04-04 Thread Srinivas Kandagatla
On 02/04/2019 16:45, Yangtao Li wrote: Because there was an endianness issue. It seems that reg_read function which the nvmem the driver currently exposes is wrong. So add the new read function, the new function is used when the native_endian flag is set. Signed-off-by: Yangtao Li This pat

Re: [PATCH v2 0/5] nvmem: sunxi-sid: add SID controller support for H6

2019-04-04 Thread Srinivas Kandagatla
On 02/04/2019 16:45, Yangtao Li wrote: Add SID support for H6, and do some cleanup. For endianness issue, add a new ref_read func. Yangtao Li (5): nvmem: sunxi-sid: fix wrong description in kernel doc nvmem: sunxi-sid: add binding for H6's SID controller nvmem: sunxi-sid: convert to

Re: [PATCH] nvmem: core: fix read buffer in place

2019-04-04 Thread Srinivas Kandagatla
On 20/03/2019 19:32, Jorge Ramirez-Ortiz wrote: When the bit_offset in the cell is zero, the pointer to the msb will not be properly initialized (ie, will still be pointing to the first byte in the buffer). This being the case, if there are bits to clear in the msb, those will be left untouch

Re: [PATCH v2 4/5] nvmem: sunxi-sid: add new reg_read func

2019-04-04 Thread Maxime Ripard
On Thu, Apr 04, 2019 at 11:59:44AM +0100, Srinivas Kandagatla wrote: > > > On 02/04/2019 16:45, Yangtao Li wrote: > > Because there was an endianness issue. It seems that reg_read > > function which the nvmem the driver currently exposes is wrong. > > So add the new read function, the new function

[PATCH 1/2] tools: PCI: Add 'h' in optstring of getopt()

2019-04-04 Thread Kishon Vijay Abraham I
'h' is a valid option character for pcitest utility used to print the pcitest usage. Add 'h' in optstring of getopt() in order to get rid of "pcitest: invalid option -- 'h'" warning. While at that remove unncessary case '?'. Signed-off-by: Kishon Vijay Abraham I Signed-off-by: Sekhar Nori --- t

[PATCH 0/2] tools: Fixes for pcitest

2019-04-04 Thread Kishon Vijay Abraham I
Hi Lorenzo, This series includes a couple of patches, one which fixes inadvertent removal of pcitest.sh from kernel repo when doing a "clean" and other lets the user use 'h' option to display the list of options supported by pcitest. Thanks Kishon Kishon Vijay Abraham I (2): tools: PCI: Add 'h

[PATCH 2/2] tools: PCI: Handle pcitest.sh independently from pcitest

2019-04-04 Thread Kishon Vijay Abraham I
Handling pcitest.sh along with pcitest (obtained by compiling pcitest.c) results in pcitest.sh getting removed inadvertently while "make -C tools/pci clean". Fix it here by handling pcitest.sh independently of pcitest. Fixes: 1ce78ce09430a5f ("tools: PCI: Change pcitest compiling process") Cc: Gus

Re: WARN_ON_ONCE() hit at kernel/events/core.c:330

2019-04-04 Thread Peter Zijlstra
On Thu, Apr 04, 2019 at 11:15:39AM +0200, Thomas-Mich Richter wrote: > On 4/3/19 12:41 PM, Peter Zijlstra wrote: > > On Wed, Apr 03, 2019 at 11:47:00AM +0200, Thomas-Mich Richter wrote: > >> I use linux 5.1.0-rc3 on s390 and got this WARN_ON_ONCE message: > >> > >> WARNING: CPU: 15 PID: 0 at kernel

[PATCH] x86/microcode: Refactor Intel microcode loading

2019-04-04 Thread Jann Horn
This changes generic_load_microcode() to use the iov_iter API instead of an open-coded version. This allows us to avoid explicitly casting between user and kernel pointers. Because the iov_iter API makes it hard to read the same location twice, as a side effect, this also fixes a double-read of th

Re: [PATCH v2 1/4] ARM: davinci: fix cpufreq registration on da850-evm

2019-04-04 Thread Adam Ford
On Thu, Apr 4, 2019 at 5:01 AM Bartosz Golaszewski wrote: > > śr., 3 kwi 2019 o 17:49 Adam Ford napisał(a): > > > > On Wed, Apr 3, 2019 at 7:50 AM Bartosz Golaszewski wrote: > > > > > > śr., 27 mar 2019 o 12:14 Sekhar Nori napisał(a): > > > > > > > > Hi Bart, > > > > > > > > On 26/03/19 11:21 P

Re: [PATCH v4 2/2] platform/chrome: Add Wilco EC keyboard backlight LEDs support

2019-04-04 Thread Pavel Machek
On Wed 2019-04-03 15:27:58, Nick Crews wrote: > The EC is in charge of controlling the keyboard backlight on > the Wilco platform. We expose a standard LED class device at > /sys/class/leds/chromeos::kbd_backlight. This driver is modeled Please use platform::kbd_backlight.

[PATCH][V2] Documentation: bus: ti-sysc: fix spelling mistakes "multipe" and "interconnet"

2019-04-04 Thread Colin King
From: Colin Ian King There is are a couple of spelling mistakes in the Documentation. Fix them. Signed-off-by: Colin Ian King --- V2: Add fix to interconnect, thanks to Mukesh Ojha for spotting that --- Documentation/devicetree/bindings/bus/ti-sysc.txt | 4 ++-- 1 file changed, 2 insertions(

[PATCH 0/6] ASoC: meson: add g12a SoC family support

2019-04-04 Thread Jerome Brunet
The Amlogic g12a SoC family audio subsystem derives from the one found in the axg SoC family. To add support for the g12a in the existing elements, this patchset deals with following differences compared to the axg family: * fifos must set an initial start address within the buffer. The fifo p

[PATCH 4/6] ASoC: meson: axg-frddr: add g12a support

2019-04-04 Thread Jerome Brunet
On the axg, frddr could only be connected to 1 downstream element, so the playback was possible on 1 interface only at a time. On the g12a, the frddr may connect and wait for the request of up to 3 downstream elements. With this, it possible for single playback to be played on several interfaces a

[PATCH 2/6] ASoC: meson: axg-fifo: add g12a support

2019-04-04 Thread Jerome Brunet
The g12a fifos gained the ability to set the initial address of the pointer within the buffer, instead of defaulting to the buffer start address. It is not very useful to us (yet) but we need to put a copy the buffer start address in the related register for the fifo to work properly on the g12a S

[PATCH 6/6] ASoC: meson: axg-tdmout: add g12a support

2019-04-04 Thread Jerome Brunet
The axg tdmout driver just need a different skew offset to operate correctly on the g12a SoC family. Signed-off-by: Jerome Brunet --- sound/soc/meson/axg-tdmout.c | 13 + 1 file changed, 13 insertions(+) diff --git a/sound/soc/meson/axg-tdmout.c b/sound/soc/meson/axg-tdmout.c index

[PATCH 5/6] ASoC: meson: axg-tdm-formatter: rework quirks settings

2019-04-04 Thread Jerome Brunet
The g12a tdmout requires a different signal skew offset than the axg. With this change, the skew offset is added as a parameter of the tdm formatters to prepare the addition of the g12a support. Signed-off-by: Jerome Brunet --- sound/soc/meson/axg-tdm-formatter.c | 6 -- sound/soc/meson/axg

[PATCH 1/6] ASoC: meson: add g12a compatibles

2019-04-04 Thread Jerome Brunet
Add new compatible strings for the g12a devices. Audio wise, the g12a is fairly to close to the axg, yet some differences need to be handled. Signed-off-by: Jerome Brunet --- Documentation/devicetree/bindings/sound/amlogic,axg-fifo.txt | 4 +++- Documentation/devicetree/bindings/sound/amlogic,a

[PATCH 3/6] ASoC: meson: axg-toddr: add g12a support

2019-04-04 Thread Jerome Brunet
Since the g12a SoC fifo can set the fifo initial start address, we must make sure to actually reset the write pointer to this address when starting a capture. Signed-off-by: Jerome Brunet --- sound/soc/meson/axg-toddr.c | 53 + 1 file changed, 53 insertions(+)

Re: [PATCH][V2] Documentation: bus: ti-sysc: fix spelling mistakes "multipe" and "interconnet"

2019-04-04 Thread Mukesh Ojha
On 4/4/2019 4:46 PM, Colin King wrote: From: Colin Ian King There is are a couple of spelling mistakes in the Documentation. Fix them. Signed-off-by: Colin Ian King Reviewed-by: Mukesh Ojha Cheers, -Mukesh --- V2: Add fix to interconnect, thanks to Mukesh Ojha for spotting that ---

[PATCH v3 2/2] drm/panel: simple: Add KOE tx14d24vm1bpa display support (320x240)

2019-04-04 Thread Lukasz Majewski
This commit adds support for KOE's 5.7" display. Signed-off-by: Lukasz Majewski Reviewed-by: Rob Herring --- Previous discussion (and Rob's Reviewed-by) about this patch https://patchwork.kernel.org/patch/10339595/ It must have been lost during the development process, so I do resend it now.

Re: [PATCH][next] opa_vnic: fix check on record->event, incorrect operator used

2019-04-04 Thread Dennis Dalessandro
On 4/4/2019 6:04 AM, Colin King wrote: From: Colin Ian King The check on record->event is always true because the wrong operator is being used, used && instead of || Addresses-Coverity: ("Constant expression result") Fixes: fae7a699a925 ("opa_vnic: Convert vport_idr to XArray") Signed-off-by:

Re: [PATCH] platform/chrome: Add Wilco EC keyboard backlight LEDs support

2019-04-04 Thread Pavel Machek
On Mon 2019-03-11 09:29:06, Nick Crews wrote: > Thanks for looking this over. I will fix most of your concerns, but > have one question. > > On Fri, Mar 8, 2019 at 2:08 PM Pavel Machek wrote: > > > > On Fri 2019-03-08 13:38:02, Nick Crews wrote: > > > This patch is meant to be applied on top of t

Re: [RFC PATCH 0/7] rslib: RS decoder is severely broken

2019-04-04 Thread Thomas Gleixner
Ferdinand, On Sat, 30 Mar 2019, Ferdinand Blomqvist wrote: Thanks for providing that! I'm short of cycles to go through that right now, but will do in the foreseeable future. Feel free to remind me if I don't do so within two weeks. Thanks, tglx

Re: [PATCH 23/25] coresight: stm: ACPI support for parsing stimulus base

2019-04-04 Thread Suzuki K Poulose
Hi Mathieu, On 28/03/2019 20:41, Mathieu Poirier wrote: On Wed, Mar 20, 2019 at 06:49:40PM +, Suzuki K Poulose wrote: The stimulus base for STM device must be listed as the second memory resource, followed by the programming base address. Add support for parsing the information for ACPI. C

Re: [PATCH v2 5/8] modpost: Integrate klp-convert

2019-04-04 Thread Miroslav Benes
On Fri, 22 Mar 2019, Joe Lawrence wrote: > On Fri, Mar 01, 2019 at 11:13:10AM -0300, Joao Moreira wrote: > > From: Josh Poimboeuf > > > > Create cmd_klp_convert and hook it into scripts/Makefile.modpost. > > cmd_klp_convert invokes klp-convert with the right arguments for the > > conversion of u

Re: [PATCH][next] opa_vnic: fix check on record->event, incorrect operator used

2019-04-04 Thread Jason Gunthorpe
On Thu, Apr 04, 2019 at 07:23:45AM -0400, Dennis Dalessandro wrote: > On 4/4/2019 6:04 AM, Colin King wrote: > > From: Colin Ian King > > > > The check on record->event is always true because the wrong operator > > is being used, used && instead of || > > > > Addresses-Coverity: ("Constant expre

Re: [PATCH][next] opa_vnic: fix check on record->event, incorrect operator used

2019-04-04 Thread Mukesh Ojha
On 4/4/2019 3:34 PM, Colin King wrote: From: Colin Ian King The check on record->event is always true because the wrong operator is being used, used && instead of || Addresses-Coverity: ("Constant expression result") Fixes: fae7a699a925 ("opa_vnic: Convert vport_idr to XArray") Signed-off-by

Re: [PATCH] gpio: merrifield: Fix build err without CONFIG_ACPI

2019-04-04 Thread Mukesh Ojha
On 4/4/2019 4:09 PM, Yue Haibing wrote: From: YueHaibing When building CONFIG_ACPI is not set gcc warn this: drivers/gpio/gpio-merrifield.c: In function mrfld_gpio_get_pinctrl_dev_name: drivers/gpio/gpio-merrifield.c:388:19: error: dereferencing pointer to incomplete type struct acpi_device

Re: [PATCH] gpio: merrifield: Fix build err without CONFIG_ACPI

2019-04-04 Thread Andy Shevchenko
On Thu, Apr 04, 2019 at 06:39:25PM +0800, Yue Haibing wrote: > From: YueHaibing > > When building CONFIG_ACPI is not set > gcc warn this: > > drivers/gpio/gpio-merrifield.c: In function mrfld_gpio_get_pinctrl_dev_name: > drivers/gpio/gpio-merrifield.c:388:19: error: dereferencing pointer to > i

RE: [PATCH v2] PCI: xilinx-nwl: Fix Multi MSI data programming

2019-04-04 Thread Bharat Kumar Gogada
> On Mon, Apr 01, 2019 at 05:00:40PM +, Bharat Kumar Gogada wrote: > > Hi All, > > > > Please let me know if anyone has any inputs on this. > > > > Regards, > > Bharat > > > > > > The current Multi MSI data programming fails if multiple end points > > > requesting MSI and multi MSI are connecte

Re: [PATCH] extcon: axp288: Fix build err without CONFIG_ACPI

2019-04-04 Thread Mukesh Ojha
On 4/4/2019 4:12 PM, Yue Haibing wrote: From: YueHaibing When building CONFIG_ACPI is not set gcc warn this: drivers/extcon/extcon-axp288.c: In function 'axp288_extcon_probe': drivers/extcon/extcon-axp288.c:363:20: error: dereferencing pointer to incomplete type put_device(&adev->dev);

Re: [PATCH v2 0/8] klp-convert

2019-04-04 Thread Miroslav Benes
> BTW, something I *just* noticed when putting together that toy out-of-tree > module to test out multi-object livepatch modules is that we aren't > considering out-of-tree symbols in Symbols.list. > > Perhaps we can save that for v4 or beyond, but maybe we want to re-arrange the > klp-convert a

[PATCH] ASoC: max98357a: add missing supported rates

2019-04-04 Thread Jerome Brunet
According the publicly available datasheet (and some test) the max98357a also supports 32, 44.1 and 88.2 kHz sample rate. Signed-off-by: Jerome Brunet --- Datasheet is available here: https://datasheets.maximintegrated.com/en/ds/MAX98357A-MAX98357B.pdf sound/soc/codecs/max98357a.c | 3 +++ 1

RE: [PATCH v2] PCI: xilinx-nwl: Fix Multi MSI data programming

2019-04-04 Thread Bharat Kumar Gogada
> Subject: Re: [PATCH v2] PCI: xilinx-nwl: Fix Multi MSI data programming > > On Mon, 11 Mar 2019 at 12:46, Bharat Kumar Gogada > wrote: > > > > The current Multi MSI data programming fails if multiple end points > > requesting MSI and multi MSI are connected with switch, i.e the > > current mult

Re: [PATCH] pinctrl: intel: Implements gpio free function

2019-04-04 Thread Andy Shevchenko
On Thu, Apr 04, 2019 at 12:51:35PM +0200, Enrico Weigelt, metux IT consult wrote: > On 03.04.19 06:13, Linus Walleij wrote: > > > But the chardev on the other hand will protect you from all this.> > If the > > program crashes, the lines will be free:ed.> > If two scripts > try to access the same

Re: [PATCH 2/6] arm64/mm: Enable memory hot remove

2019-04-04 Thread Oscar Salvador
On Thu, Apr 04, 2019 at 11:09:22AM +0530, Anshuman Khandual wrote: > > Do these need to be __meminit? AFAICS it's effectively redundant with the > > containing #ifdef, and removal feels like it's inherently a later-than-init > > thing anyway. > > I was confused here a bit but even X86 does exact

Re: [PATCH] extcon: axp288: Fix build err without CONFIG_ACPI

2019-04-04 Thread Hans de Goede
Hi, On 04-04-19 12:42, Yue Haibing wrote: From: YueHaibing When building CONFIG_ACPI is not set gcc warn this: drivers/extcon/extcon-axp288.c: In function 'axp288_extcon_probe': drivers/extcon/extcon-axp288.c:363:20: error: dereferencing pointer to incomplete type put_device(&adev->dev)

Re: WARN_ON_ONCE() hit at kernel/events/core.c:330

2019-04-04 Thread Peter Zijlstra
On Thu, Apr 04, 2019 at 01:09:09PM +0200, Peter Zijlstra wrote: > That is not entirely the scenario I talked about, but *groan*. > > So what I meant was: > > CPU-0 CPU-n > > __schedule() > local_irq_disable() > > ...

Re: [PATCH 2/4] mm, memory_hotplug: provide a more generic restrictions for memory hotplug

2019-04-04 Thread Oscar Salvador
On Thu, Apr 04, 2019 at 12:31:15PM +0200, Michal Hocko wrote: > On Thu 04-04-19 12:04:05, Oscar Salvador wrote: > > On Wed, Apr 03, 2019 at 10:46:03AM +0200, Michal Hocko wrote: > > > On Thu 28-03-19 14:43:18, Oscar Salvador wrote: > > > > From: Michal Hocko > > > > > > > > arch_add_memory, __add

[PATCH 1/4] sched/core: allow the remote scheduler tick to be started on CPU0

2019-04-04 Thread Nicholas Piggin
This has on effect yet because CPU0 will always be a housekeeping CPU until a later change. Signed-off-by: Nicholas Piggin --- kernel/sched/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/sched/core.c b/kernel/sched/core.c index 4778c48a7fda..10e05ec049b6 100644

[PATCH 0/4] Allow CPU0 to be nohz full

2019-04-04 Thread Nicholas Piggin
I've been looking at ways to fix suspend breakage with CPU0 as a nohz CPU. I started looking at various things like allowing CPU0 to take over do_timer again temporarily or allowing nohz full to be stopped at runtime (that is quite a significant change for little real benefit). The problem then was

Re: [PATCH 1/5] dt-bindings: mfd: Update the ramp up/down property

2019-04-04 Thread Dan Murphy
Lee Thanks for the review On 4/4/19 3:19 AM, Lee Jones wrote: > On Mon, 25 Mar 2019, Dan Murphy wrote: > >> Modify the ramp-up/down property and add the property description >> to the binding. > > This is the 'what', but where is the 'why'? > I will add the why in v2. Dan -- -

[PATCH 3/4] kernel/sched/isolation: require a present CPU in housekeeping mask

2019-04-04 Thread Nicholas Piggin
During housekeeping mask setup, currently a possible CPU is required. That does not guarantee a CPU at boot time, so check to ensure that at least one present CPU is in the mask. Signed-off-by: Nicholas Piggin --- kernel/sched/isolation.c | 18 +- 1 file changed, 13 insertions(+)

[PATCH 2/4] kernel/cpu: Allow non-zero CPU to be primary for suspend / kexec freeze

2019-04-04 Thread Nicholas Piggin
This patch chooses a housekeeping CPU to be the primary when disabling CPUs for suspend / kexec freeze. This should not have any effect until a later change because CPU0 is always a housekeeping CPU. Signed-off-by: Nicholas Piggin --- include/linux/cpu.h | 2 +- kernel/cpu.c| 10 +++

[PATCH 4/4] nohz_full: Allow the boot CPU to be full nohz

2019-04-04 Thread Nicholas Piggin
Allow the boot CPU to be full nohz, and have it take the do_timer duty temporarily during boot. nohz_full has been successful at significantly reducing jitter for a large supercomputer customer, but their job control system requires CPU0 to be for housekeeping. This will cause suspend / kexec fre

Re: [PATCH 4/5] mfd: ti-lmu: Remove support for LM3697

2019-04-04 Thread Dan Murphy
Lee Thanks for the review On 4/4/19 3:17 AM, Lee Jones wrote: > On Mon, 25 Mar 2019, Dan Murphy wrote: > >> Remove support for the LM3697 from the ti-lmu > > Bit of an odd place to insert a line feed. > I will fix in v2. >> driver in favor of a dedicated LED driver. >> >> Signed-off-by: Dan

Re: WARN_ON_ONCE() hit at kernel/events/core.c:330

2019-04-04 Thread Peter Zijlstra
On Thu, Apr 04, 2019 at 02:02:14PM +0200, Peter Zijlstra wrote: > On Thu, Apr 04, 2019 at 01:09:09PM +0200, Peter Zijlstra wrote: > > That is not entirely the scenario I talked about, but *groan*. > > > > So what I meant was: > > > > CPU-0 CPU

[PATCH v1 1/1] ARM: dts: colibri/apalis: convert to SPDX license tags

2019-04-04 Thread Igor Opaniuk
Replace boiler plate licenses texts with the SPDX license identifiers in Colibri/Apalis DTS files. Signed-off-by: Igor Opaniuk --- arch/arm/boot/dts/imx6q-apalis-eval.dts | 40 +- arch/arm/boot/dts/imx6q-apalis-ixora-v1.1.dts | 40 +- arch/arm/boot/dts/imx6q

[PATCH 0/2] PCI: dwc: Export symbols to support module build

2019-04-04 Thread Vidya Sagar
This patch set is based on Jisheng Zhang's patch set to support implementing .remove() hook in host controller drivers of Designware based implementations. Jisheng's patches: https://patchwork.kernel.org/project/linux-pci/list/?series=98559 This patch set moves config space APIs which are inlined

[PATCH 2/2] PCI: dwc: Export APIs to support .remove() implementation

2019-04-04 Thread Vidya Sagar
Export all configuration space access APIs and also other APIs to support host controller drivers of Designware core based implementations while adding support for .remove() hook to build their respective drivers as modules Signed-off-by: Vidya Sagar --- drivers/pci/controller/dwc/pcie-designwar

[PATCH 1/2] PCI: dwc: Add API support to de-initialize host

2019-04-04 Thread Vidya Sagar
Add an API to group all the tasks to be done to de-initialize host which can then be called by any Designware core based driver implementations while adding .remove() support in their respective drivers. Signed-off-by: Vidya Sagar --- drivers/pci/controller/dwc/pcie-designware-host.c | 7 +++

Re: [BUG] perf: intel_pt won't display kernel function

2019-04-04 Thread Jiri Olsa
On Thu, Apr 04, 2019 at 11:14:38AM +0200, Jiri Olsa wrote: SNIP > Program received signal SIGABRT, Aborted. > 0x775e60f5 in raise () from /lib64/libc.so.6 > Missing separate debuginfos, use: dnf debuginfo-install > bzip2-libs-1.0.6-29.fc30.x86_64 elfutils-libelf-0.176-1.fc30.x86_64 > el

[PATCH 1/2] dt-bindings: vendor-prefixes: add AZW

2019-04-04 Thread Clément Péron
Shenzhen AZW Technology Co. Ltd. is a manufacturer specialized in Android smart TV boxes, Intel mini PCs and home cloud TV boxes with NAS. Add the vendor prefix for AZW. Signed-off-by: Clément Péron --- Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 file changed, 1 insertion(+)

Re: [PATCH v1] mfd: Add support for Merrifield Basin Cove PMIC

2019-04-04 Thread Andy Shevchenko
On Thu, Apr 04, 2019 at 10:44:59AM +0100, Lee Jones wrote: > On Thu, 04 Apr 2019, Andy Shevchenko wrote: > > On Thu, Apr 04, 2019 at 10:03:14AM +0100, Lee Jones wrote: > > > On Thu, 04 Apr 2019, Andy Shevchenko wrote: > > > > On Thu, Apr 04, 2019 at 08:03:57AM +0100, Lee Jones wrote: > > > > > On T

[PATCH 2/2] ARM: dts: sun50i: h6: Introduce Beelink GS1 board

2019-04-04 Thread Clément Péron
Beelink GS1 is an Allwinner H6 based TV box, which support: - Allwinner H6 Quad-core 64-bit ARM Cortex-A53 - GPU Mali-T720 - 2GB LPDDR3 RAM - AXP805 PMIC - 1Gbps GMAC via RTL8211E - FN-Link 6222B-SRB Wifi/BT - 1x USB 2.0 Host and 1x USB 3.0 Host - HDMI port - S/PDIF Tx - IR receiver - 5V/2A DC powe

Re: [PATCH][next] HID: intel-ish-hid: fix spelling mistake "multipe" -> "multiple"

2019-04-04 Thread Benjamin Tissoires
On Thu, Apr 4, 2019 at 9:59 AM Colin King wrote: > > From: Colin Ian King > > There is a spelling mistake in a dev_err message, fix it. > > Signed-off-by: Colin Ian King > --- Applied to for-5.2/ish Cheers, Benjamin > drivers/hid/intel-ish-hid/ishtp-fw-loader.c | 2 +- > 1 file changed, 1 in

[PATCH] KVM: arm/arm64: vgic: Restrict setting irq->targets only in GICv2

2019-04-04 Thread Zenghui Yu
Commit ad275b8bb1e6 ("KVM: arm/arm64: vgic-new: vgic_init: implement vgic_init") had set irq->targets in kvm_vgic_vcpu_init(), regardless of the GIC architecture (v2 or v3). When the number of vcpu reaches 32 (in v3), UBSAN will complain about it.

Re: [PATCH v2 2/2] dt-bindings: net: bluetooth: Add device property nvm-postfix for QCA6174

2019-04-04 Thread Marc Gonzalez
+robh On 04/04/2019 11:08, Rocky Liao wrote: > This patchs patch adds an optional device property nvm-postfix to allow the > driver to load customized nvm file based on this property While text /before/ is indeed called a "prefix", text /after/ is not a "postfix", but a "suffix". > Documenta

Re: [PATCH] mm/gup.c: fix the wrong comments

2019-04-04 Thread William Kucharski
> On Apr 4, 2019, at 1:23 AM, Huang Shijie wrote: > > > + * This function is different from the get_user_pages_unlocked(): > + * The @pages may has different page order with the result > + * got by get_user_pages_unlocked(). > + * I suggest a slight rewrite of the comment, somethin

Re: [PATCH v7 4/4] perf/smmuv3: Enable HiSilicon Erratum 162001800 quirk

2019-04-04 Thread Will Deacon
On Tue, Mar 26, 2019 at 03:17:53PM +, Shameer Kolothum wrote: > HiSilicon erratum 162001800 describes the limitation of > SMMUv3 PMCG implementation on HiSilicon Hip08 platforms. > > On these platforms, the PMCG event counter registers > (SMMU_PMCG_EVCNTRn) are read only and as a result it > i

[PATCH] virt: vbox: Sanity-check parameter types for hgcm-calls coming from userspace

2019-04-04 Thread Hans de Goede
Userspace can make host function calls, called hgcm-calls through the /dev/vboxguest device. In this case we should not accept all hgcm-function-parameter-types, some are only valid for in kernel calls. This commit adds proper hgcm-function-parameter-type validation to the ioctl for doing a hgcm-

[PATCH] staging: mt7621-pci-phy: prevent use of uninitialized variable

2019-04-04 Thread Antti Keränen
Do not use uninitialized variable 'port' when printing an error message Signed-off-by: Antti Keränen --- drivers/staging/mt7621-pci-phy/pci-mt7621-phy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/mt7621-pci-phy/pci-mt7621-phy.c b/drivers/staging/mt7621-p

<    4   5   6   7   8   9   10   11   12   13   >