[PATCH] platform/x86: intel_pmc_core: Report slp_s0 residency range

The PMC driver performs a 32-bit read on the sleep s0 residency counter, followed by a hard-coded multiplication to convert into microseconds. The maximum value this counter could have would be 0x*0x64 microseconds, which by my calculations is about 4.9 days. This is well within a reasonabl

Re: [PATCH 1/3] clk: meson: mpll: properly handle spread spectrum

Hi Jerome, On Mon, Apr 1, 2019 at 10:40 AM Jerome Brunet wrote: > > On Sat, 2019-03-30 at 16:56 +0100, Martin Blumenstingl wrote: > > Hi Jerome, > > > > On Sat, Mar 30, 2019 at 12:07 AM Jerome Brunet wrote: > > > On Fri, 2019-03-29 at 20:39 +0100, Martin Blumenstingl wrote: > > > > Hi Jerome, >

[PATCH 4.19 006/134] gtp: change NET_UDP_TUNNEL dependency to select

4.19-stable review patch. If anyone has any objections, please let me know. -- From: Matteo Croce [ Upstream commit c22da36688d6298f2e546dcc43fdc1ad35036467 ] Similarly to commit a7603ac1fc8c ("geneve: change NET_UDP_TUNNEL dependency to select"), GTP has a dependency on NET_U

Re: [PATCH hyperv-fixes,v3] hv_netvsc: Fix unwanted wakeup after tx_disable

From: Haiyang Zhang Date: Thu, 28 Mar 2019 19:40:36 + > From: Haiyang Zhang > > After queue stopped, the wakeup mechanism may wake it up again > when ring buffer usage is lower than a threshold. This may cause > send path panic on NULL pointer when we stopped all tx queues in > netvsc_detac

[PATCH 4.19 003/134] ipmi_si: Fix crash when using hard-coded device

4.19-stable review patch. If anyone has any objections, please let me know. -- Backport from 41b766d661bf94a364960862cfc248a78313dbd3 When excuting a command like: modprobe ipmi_si ports=0xffc0e3 type=bt The system would get an oops. The trouble here is that ipmi_si_hardcode_

[PATCH 4.19 014/134] net: rose: fix a possible stack overflow

4.19-stable review patch. If anyone has any objections, please let me know. -- From: Eric Dumazet [ Upstream commit e5dcc0c3223c45c94100f05f28d8ef814db3d82c ] rose_write_internal() uses a temp buffer of 100 bytes, but a manual inspection showed that given arbitrary input, rose

[PATCH 4.19 012/134] net/packet: Set __GFP_NOWARN upon allocation in alloc_pg_vec

4.19-stable review patch. If anyone has any objections, please let me know. -- From: Christoph Paasch [ Upstream commit 398f0132c14754fcd03c1c4f8e7176d001ce8ea1 ] Since commit fc62814d690c ("net/packet: fix 4gb buffer limit due to overflow check") one can now allocate packet

[PATCH 4.19 013/134] net: phy: meson-gxl: fix interrupt support

4.19-stable review patch. If anyone has any objections, please let me know. -- From: Jerome Brunet [ Upstream commit daa5c4d0167a308306525fd5ab9a5e18e21f4f74 ] If an interrupt is already pending when the interrupt is enabled on the GXL phy, no IRQ will ever be triggered. The

[PATCH 4.19 018/134] rhashtable: Still do rehash when we get EEXIST

4.19-stable review patch. If anyone has any objections, please let me know. -- From: Herbert Xu [ Upstream commit 408f13ef358aa5ad56dc6230c2c7deb92cf462b1 ] As it stands if a shrink is delayed because of an outstanding rehash, we will go into a rescheduling loop without ever d

[PATCH 4.19 001/134] Bluetooth: Check L2CAP option sizes returned from l2cap_get_conf_opt

4.19-stable review patch. If anyone has any objections, please let me know. -- From: Marcel Holtmann commit af3d5d1c87664a4f150fcf3534c6567cb19909b0 upstream. When doing option parsing for standard type values of 1, 2 or 4 octets, the value is converted directly into a variabl

[PATCH 4.19 002/134] Bluetooth: Verify that l2cap_get_conf_opt provides large enough buffer

4.19-stable review patch. If anyone has any objections, please let me know. -- From: Marcel Holtmann commit 7c9cbd0b5e38a1672fcd137894ace3b042dfbf69 upstream. The function l2cap_get_conf_opt will return L2CAP_CONF_OPT_SIZE + opt->len as length value. The opt->len however is in

[PATCH 5.0 127/146] iommu/io-pgtable-arm-v7s: request DMA32 memory, and improve debugging

5.0-stable review patch. If anyone has any objections, please let me know. -- From: Nicolas Boichat commit 0a352554da69b02f75ca3389c885c741f1f63235 upstream. IOMMUs using ARMv7 short-descriptor format require page tables (level 1 and 2) to be allocated within the first 4GB of

Re: [PATCH 2/2] Bluetooth: hci_qca: wcn3990: Drop baudrate change vendor event

On Mon, Apr 01, 2019 at 01:48:23PM +0530, Balakrishna Godavarthi wrote: > Hi Matthias, > > On 2019-04-01 13:29, Balakrishna Godavarthi wrote: > > Hi Matthias, > > > > Sorry for the late reply i was on vacation. > > > > On 2019-03-08 05:00, Matthias Kaehlcke wrote: > > > On Thu, Mar 07, 2019 at 1

[PATCH 5.0 130/146] mm/memory_hotplug.c: fix notification in offline error path

5.0-stable review patch. If anyone has any objections, please let me know. -- From: Qian Cai commit c4efe484b5f0d768e23c9731082fec827723e738 upstream. When start_isolate_page_range() returned -EBUSY in __offline_pages(), it calls memory_notify(MEM_CANCEL_OFFLINE, &arg) with an

[PATCH 5.0 145/146] bpf: do not restore dst_reg when cur_state is freed

5.0-stable review patch. If anyone has any objections, please let me know. -- From: Xu Yu commit 0803278b0b4d8eeb2b461fb698785df65a725d9e upstream. Syzkaller hit 'KASAN: use-after-free Write in sanitize_ptr_alu' bug. Call trace: dump_stack+0xbf/0x12e print_address_descri

[PATCH 5.0 142/146] KVM: Reject device ioctls from processes other than the VMs creator

5.0-stable review patch. If anyone has any objections, please let me know. -- From: Sean Christopherson commit ddba91801aeb5c160b660caed1800eb3aef403f8 upstream. KVM's API requires thats ioctls must be issued from the same process that created the VM. In other words, userspac

[PATCH 5.0 138/146] powerpc/pseries/mce: Fix misleading print for TLB mutlihit

5.0-stable review patch. If anyone has any objections, please let me know. -- From: Mahesh Salgaonkar commit 6f845ebec2706841d15831fab3cfd9e676fa upstream. On pseries, TLB multihit are reported as D-Cache Multihit. This is because the wrongly populated mc_err_types[] array

Re: [PATCH] Bluetooth: btusb: request wake pin with NOAUTOEN

+ akpm, in case he can help out Another week, another buggy 5.1 RC. On Tue, Mar 26, 2019 at 11:48 AM Brian Norris wrote: > > On Thu, Feb 21, 2019 at 4:30 PM Brian Norris wrote: > > > > Badly-designed systems might have (for example) active-high wake pins > > that default to high (e.g., because

[PATCH 5.0 134/146] perf intel-pt: Fix TSC slip

5.0-stable review patch. If anyone has any objections, please let me know. -- From: Adrian Hunter commit f3b4e06b3bda759afd042d3d5fa86bea8f1fe278 upstream. A TSC packet can slip past MTC packets so that the timestamp appears to go backwards. One estimate is that can be up to a

RE: [PATCH V1 24/26] spi: tegra114: de-assert CS before SPI mode is reset to its default

> On Tue, Mar 26, 2019 at 10:56:45PM -0700, Sowjanya Komatineni wrote: > > With SW CS, during transfer completion CS is de-asserted by writing > > the default command1 register value to SPI_COMMAND1 register. With > > this both mode and CS state are set at the same time and if current > > tran

[PATCH 5.0 088/146] staging: erofs: fix error handling when failed to read compresssed data

5.0-stable review patch. If anyone has any objections, please let me know. -- From: Gao Xiang commit b6391ac73400eff38377a4a7364bd3df5efb5178 upstream. Complete read error handling paths for all three kinds of compressed pages: 1) For cache-managed pages, PG_uptodate will be

linux-next: Signed-off-by missing for commits in the block tree

Hi Jens, Commits 837d7c7005c3 ("block: enable multi-page bvec for passthrough IO") df88a384baa3 ("block: pass page to xen_biovec_phys_mergeable") are missing a Signed-off-by from their committer. -- Cheers, Stephen Rothwell pgpu7N86tdzLw.pgp Description: OpenPGP digital signature

[PATCH 5.0 118/146] usb: host: xhci-rcar: Add XHCI_TRUST_TX_LENGTH quirk

5.0-stable review patch. If anyone has any objections, please let me know. -- From: Yasushi Asano commit 40fc165304f0faaae78b761f8ee30b5d216b1850 upstream. When plugging BUFFALO LUA4-U3-AGT USB3.0 to Gigabit Ethernet LAN Adapter, warning messages filled up dmesg. [ 101.09828

[PATCH 5.0 101/146] fs/proc/proc_sysctl.c: fix NULL pointer dereference in put_links

5.0-stable review patch. If anyone has any objections, please let me know. -- From: YueHaibing commit 23da9588037ecdd4901db76a5b79a42b529c4ec3 upstream. Syzkaller reports: kasan: GPF could be caused by NULL-ptr deref or user memory access general protection fault: [#1] S

[PATCH 5.0 094/146] USB: serial: ftdi_sio: add additional NovaTech products

5.0-stable review patch. If anyone has any objections, please let me know. -- From: George McCollister commit 422c2537ba9d42320f8ab6573940269f87095320 upstream. Add PIDs for the NovaTech OrionLX+ and Orion I/O so they can be automatically detected. Signed-off-by: George McCol

[PATCH 5.0 093/146] USB: serial: cp210x: add new device id

5.0-stable review patch. If anyone has any objections, please let me know. -- From: Greg Kroah-Hartman commit a595ecdd5f60b2d93863cebb07eec7f935839b54 upstream. Lorenz Messtechnik has a device that is controlled by the cp210x driver, so add the device id to the driver. The de

[PATCH 5.0 102/146] drivers/block/zram/zram_drv.c: fix idle/writeback string compare

5.0-stable review patch. If anyone has any objections, please let me know. -- From: Minchan Kim commit 0bc9f5d14a93971c6cd9c0d81b0fc154fc54c65d upstream. Makoto report a below KASAN error: zram does out-of-bounds read. Because strscpy copies from source up to count bytes unco

[PATCH 5.0 096/146] USB: serial: option: set driver_info for SIM5218 and compatibles

5.0-stable review patch. If anyone has any objections, please let me know. -- From: Mans Rullgard commit f8df5c2c3e2df5ffaf9fb5503da93d477a8c7db4 upstream. The SIMCom SIM5218 and compatible devices have 5 USB interfaces, only 4 of which are serial ports. The fifth is a networ

[PATCH 5.0 095/146] USB: serial: mos7720: fix mos_parport refcount imbalance on error path

5.0-stable review patch. If anyone has any objections, please let me know. -- From: Lin Yi commit 2908b076f5198d231de62713cb2b633a3a4b95ac upstream. The write_parport_reg_nonblock() helper takes a reference to the struct mos_parport, but failed to release it in a couple of err

[PATCH 5.0 051/146] NFS: fix mount/umount race in nlmclnt.

5.0-stable review patch. If anyone has any objections, please let me know. -- From: NeilBrown commit 4a9be28c45bf02fa0436808bb6c0baeba30e120e upstream. If the last NFSv3 unmount from a given host races with a mount from the same host, we can destroy an nlm_host that is still i

[PATCH 5.0 046/146] tracing: initialize variable in create_dyn_event()

5.0-stable review patch. If anyone has any objections, please let me know. -- From: Frank Rowand commit 3dee10da2e9ff220e054a8f158cc296c797fbe81 upstream. Fix compile warning in create_dyn_event(): 'ret' may be used uninitialized in this function [-Wuninitialized]. Link: htt

[PATCH 5.0 081/146] tty: serial: qcom_geni_serial: Initialize baud in qcom_geni_console_setup

5.0-stable review patch. If anyone has any objections, please let me know. -- From: Nathan Chancellor commit c5cbc78acf693f5605d4a85b1327fa7933daf092 upstream. When building with -Wsometimes-uninitialized, Clang warns: drivers/tty/serial/qcom_geni_serial.c:1079:6: warning: va

[PATCH 5.0 048/146] powerpc: bpf: Fix generation of load/store DW instructions

5.0-stable review patch. If anyone has any objections, please let me know. -- From: Naveen N. Rao commit 86be36f6502c52ddb4b85938145324fd07332da1 upstream. Yauheni Kaliuta pointed out that PTR_TO_STACK store/load verifier test was failing on powerpc64 BE, and rightfully indica

[PATCH 5.0 076/146] drm/rockchip: vop: reset scale mode when win is disabled

5.0-stable review patch. If anyone has any objections, please let me know. -- From: Jonas Karlman commit e9abc611a941d4051cde1d94b2ab7473fdb50102 upstream. NV12 framebuffers produced by the VPU shows distorted on RK3288 after win has been disabled when scaling is active. This

Re: linux-next: Signed-off-by missing for commits in the block tree

On 4/1/19 12:08 PM, Stephen Rothwell wrote: > Hi Jens, > > Commits > > 837d7c7005c3 ("block: enable multi-page bvec for passthrough IO") > df88a384baa3 ("block: pass page to xen_biovec_phys_mergeable") > > are missing a Signed-off-by from their committer. That's my silly error, I'll fix tha

[PATCH 5.0 045/146] locks: wake any locks blocked on request before deadlock check

5.0-stable review patch. If anyone has any objections, please let me know. -- From: Jeff Layton commit 945ab8f6de94430c23a82f3cf2e3f6d6f2945ff7 upstream. Andreas reported that he was seeing the tdbtorture test fail in some cases with -EDEADLCK when it wasn't before. Some debug

[PATCH 5.0 064/146] ALSA: hda/realtek - Add support for Acer Aspire E5-523G/ES1-432 headset mic

5.0-stable review patch. If anyone has any objections, please let me know. -- From: Chris Chiu commit c7531e31c8a440b5fe6bd62664def5bcb6262f96 upstream. The Acer laptop Aspire E5-523G and ES1-432 with ALC255 can't detect the headset microphone until ALC255_FIXUP_ACER_MIC_NO_PR

[PATCH 5.0 057/146] ALSA: pcm: Dont suspend stream in unrecoverable PCM state

5.0-stable review patch. If anyone has any objections, please let me know. -- From: Takashi Iwai commit 113ce08109f8e3b091399e7cc32486df1cff48e7 upstream. Currently PCM core sets each opened stream forcibly to SUSPENDED state via snd_pcm_suspend_all() call, and the user-space

[PATCH 5.0 056/146] ALSA: pcm: Fix possible OOB access in PCM oss plugins

5.0-stable review patch. If anyone has any objections, please let me know. -- From: Takashi Iwai commit ca0214ee2802dd47239a4e39fb21c5b00ef61b22 upstream. The PCM OSS emulation converts and transfers the data on the fly via "plugins". The data is converted over the dynamicall

[PATCH 5.0 059/146] ALSA: hda/realtek: merge alc_fixup_headset_jack to alc295_fixup_chromebook

5.0-stable review patch. If anyone has any objections, please let me know. -- From: Jaroslav Kysela commit c8a9afa632f0fd45731d3353525faf1fdb362c89 upstream. The ALC225_FIXUP_HEADSET_JACK fixup can be merged to alc295_fixup_chromebook. There are no other users for ALC225_FIXUP

[PATCH 5.0 053/146] net: dsa: qca8k: remove leftover phy accessors

5.0-stable review patch. If anyone has any objections, please let me know. -- From: Christian Lamparter commit 1eec7151ae0e134bd42e3f128066b2ff8da21393 upstream. This belated patch implements Andrew Lunn's request of "remove the phy_read() and phy_write() functions."

[PATCH 5.0 004/146] dccp: do not use ipv6 header for ipv4 flow

5.0-stable review patch. If anyone has any objections, please let me know. -- From: Eric Dumazet [ Upstream commit e0aa67709f89d08c8d8e5bdd9e0b649df61d0090 ] When a dual stack dccp listener accepts an ipv4 flow, it should not attempt to use an ipv6 header or inet6_iif() helper

[PATCH 5.0 039/146] btrfs: remove WARN_ON in log_dir_items

5.0-stable review patch. If anyone has any objections, please let me know. -- From: Josef Bacik commit 2cc8334270e281815c3850c3adea363c51f21e0d upstream. When Filipe added the recursive directory logging stuff in 2f2ff0ee5e430 ("Btrfs: fix metadata inconsistencies after direct

[PATCH 5.0 012/146] net/packet: Set __GFP_NOWARN upon allocation in alloc_pg_vec

5.0-stable review patch. If anyone has any objections, please let me know. -- From: Christoph Paasch [ Upstream commit 398f0132c14754fcd03c1c4f8e7176d001ce8ea1 ] Since commit fc62814d690c ("net/packet: fix 4gb buffer limit due to overflow check") one can now allocate packet r

[PATCH 5.0 027/146] vrf: prevent adding upper devices

5.0-stable review patch. If anyone has any objections, please let me know. -- From: Sabrina Dubroca [ Upstream commit 1017e0987117c32783ba7c10fe2e7ff1456ba1dc ] VRF devices don't work with upper devices. Currently, it's possible to add a VRF device to a bridge or team, and to

[PATCH 5.0 028/146] vxlan: Dont call gro_cells_destroy() before device is unregistered

5.0-stable review patch. If anyone has any objections, please let me know. -- From: Zhiqiang Liu [ Upstream commit cc4807bb609230d8959fd732b0bf3bd4c2de8eac ] Commit ad6c9986bcb62 ("vxlan: Fix GRO cells race condition between receive and link delete") fixed a race condition for

linux-next: Fixes tag needs some work in the spi tree

Hi Mark, In commit fc9ba6e3e28a ("spi: tegra114: use packed mode for 32 bits per word") Fixes tag Fixes: Use packed mode for 32 bits per word transfers to increase has these problem(s): - No SHA1 recognised -- Cheers, Stephen Rothwell pgpHxA2nbfwQH.pgp Description: OpenPGP digital s

[PATCH] drivers: firmware: psci: add support for warm reset

From: Aaro Koskinen Add support for warm reset using SYSTEM_RESET2 introduced in PSCI 1.1 specification. Signed-off-by: Aaro Koskinen --- drivers/firmware/psci.c | 25 + include/uapi/linux/psci.h | 3 +++ 2 files changed, 28 insertions(+) diff --git a/drivers/firmwa

Re: linux-next: manual merge of the net-next tree with the net tree

On Mon, 2019-04-01 at 09:11 +1100, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the net-next tree got a conflict in: > > drivers/net/ethernet/mellanox/mlx5/core/en/port_buffer.c > > between commit: > > e28408e98bce ("net/mlx5e: Update xon formula") > > from the net tre

Re: [PATCH 00/15] tools/lib/traceevent: Continuing on the path to a stand alone library

Em Mon, Apr 01, 2019 at 12:43:05PM -0400, Steven Rostedt escreveu: > > Arnaldo, > > These contain more patches to make libtraceevent a stand alone library. > It also brings in some changes that are in the trace-cmd library. > > There's a few name changes to the API function names to be more > de

[PATCH 2/2] pwm: meson: don't disable pwm when setting duty repeatedly

From: Bichao Zheng There is an abnormally low about 20ms,when setting duty repeatedly. Because setting the duty will disable pwm and then enable. Delete this operation now. Fixes: 211ed630753d2f ("pwm: Add support for Meson PWM Controller") Signed-off-by: Bichao Zheng [ Dropped code instead of

[PATCH 1/2] pwm: meson: consider 128 a valid pre-divider

The pre-divider allows configuring longer PWM periods compared to using the input clock directly. The pre-divider is 7 bit wide, meaning it's maximum value is 128 (the register value is off-by-one: 0x7f or 127). Change the loop to also allow for the maximum possible value to be considered valid.

[PATCH 0/2] pwm: meson: two small bug-fixes

This series applies on top of my other fix "pwm: meson: fix scheduling while atomic issue" from [0] The first patch fixes an issue where the maximum possible pre-divider (128) could not be used because there was an off-by-one error in the code. I discovered this while testing with the longest supp

[PATCH V2 1/2] trace,x86: Add external_interrupts to the irq_vectors class

Currently, the irq_vectors is showing the entry and exit events for the interrupts of the architecture, but not for external interrupts. Adds the tracepoints for external interrupts. Example of output: -0 [000] d.h. 102.890935: external_interrupt_entry: vector=35 -0 [000] d.h. 102.8

[PATCH V2 2/2] trace,x86: Add nmi to the irq_vectors class

Currently, the irq_vector class of tracepoints does not include the NMI entry. The NMI was in the first set of tracepoints for IRQs, but it was dropped off because of the logic of switching IDT when enabling trace[1]. However, as the switching IDT logic was removed [2], it is possible to add the NM

[PATCH 2/2] arm64: dts: rockchip: disable TX offload for mtu bigger than 1498 for some SoCs

From: =?UTF-8?q?Kamil=20Trzci=C5=84ski?= Some rockchip boards (like the rock64, and the renegade) exhibit an issue where tx checksuming does not work with packets larger than 1498. This is bad for network stability. The previous approach was using force_thresh_dma_mode, which does more than dis

Re: [PATCH v2] writeback: use exact memcg dirty counts

On Fri, Mar 29, 2019 at 10:46:09AM -0700, Greg Thelen wrote: > @@ -3907,10 +3923,10 @@ void mem_cgroup_wb_stats(struct bdi_writeback *wb, > unsigned long *pfilepages, > struct mem_cgroup *memcg = mem_cgroup_from_css(wb->memcg_css); > struct mem_cgroup *parent; > > - *pdirty = mem

Re: WARNING in cma_exit_net

On Mon, Apr 01, 2019 at 02:45:54PM -0300, Jason Gunthorpe wrote: > On Mon, Apr 01, 2019 at 10:36:05AM -0700, syzbot wrote: > > Hello, > > > > syzbot found the following crash on: > > > > HEAD commit:e3ecb83e Add linux-next specific files for 20190401 > >

Re: KASAN: use-after-free Read in cma_check_port

#syz dup: WARNING in cma_exit_net On Mon, Apr 01, 2019 at 10:35:06AM -0700, syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:e3ecb83e Add linux-next specific files for 20190401 > git tree: linux-next > console output: https://sy

[PATCH] tpm: Actually fail on TPM errors during "get random"

A "get random" may fail with a TPM error, but those codes were returned as-is to the caller, which assumed the result was the number of bytes that had been written to the target buffer, which could lead to an kernel heap memory exposure and over-read. This fixes tpm1_get_random() to mask positive

RE: [PATCH V1 04/26] spi: tegra114: use packed mode for 32 bits per word

> On Tue, Mar 26, 2019 at 10:56:25PM -0700, Sowjanya Komatineni wrote: > > Fixes: Use packed mode for 32 bits per word transfers to increase > > performance as each packet is a full 32-bit word. > > This is an optimization rather than a bug fix, ideally it should be later in > the series to mak

Re: [PATCH 1/2] pwm: meson: consider 128 a valid pre-divider

Hello Martin, On Mon, Apr 01, 2019 at 08:18:16PM +0200, Martin Blumenstingl wrote: > diff --git a/drivers/pwm/pwm-meson.c b/drivers/pwm/pwm-meson.c > index f6e738ad7bd9..4b708c1fcb1d 100644 > --- a/drivers/pwm/pwm-meson.c > +++ b/drivers/pwm/pwm-meson.c > @@ -188,7 +188,7 @@ static int meson_pwm_c

Re: [PATCH] tpm: Actually fail on TPM errors during "get random"

On Mon, Apr 01, 2019 at 11:32:11AM -0700, Kees Cook wrote: > A "get random" may fail with a TPM error, but those codes were returned > as-is to the caller, which assumed the result was the number of bytes > that had been written to the target buffer, which could lead to an kernel > heap memory expo

RE: [PATCH V1 18/26] spi: tegra114: add support for hw based cs

> On Tue, Mar 26, 2019 at 10:56:39PM -0700, Sowjanya Komatineni wrote: > > > Tegra SPI driver default uses SW CS control for transfers and HW CS > > control can be enabled through SPI client device node DT property > > nvidia,enable-hw-based-cs and is used only for single transfers. > > Why have

Re: [PATCH] tpm: Actually fail on TPM errors during "get random"

On Mon, Apr 1, 2019 at 11:39 AM Jason Gunthorpe wrote: > > On Mon, Apr 01, 2019 at 11:32:11AM -0700, Kees Cook wrote: > > A "get random" may fail with a TPM error, but those codes were returned > > as-is to the caller, which assumed the result was the number of bytes > > that had been written to t

Re: [PATCH] tpm: Actually fail on TPM errors during "get random"

On Mon, 2019-04-01 at 11:32 -0700, Kees Cook wrote: [...] > --- a/drivers/char/tpm/tpm1-cmd.c > +++ b/drivers/char/tpm/tpm1-cmd.c > @@ -510,7 +510,7 @@ struct tpm1_get_random_out { > * > * Return: > * * number of bytes read > - * * -errno or a TPM return code otherwise > + * * -errno (positi

[PATCH v2] tpm: Actually fail on TPM errors during "get random"

A "get random" may fail with a TPM error, but those codes were returned as-is to the caller, which assumed the result was the number of bytes that had been written to the target buffer, which could lead to a kernel heap memory exposure and over-read. This fixes tpm1_get_random() and tpm2_get_rando

Re: [PATCH] tpm: Actually fail on TPM errors during "get random"

On Mon, Apr 1, 2019 at 11:52 AM James Bottomley wrote: > > On Mon, 2019-04-01 at 11:32 -0700, Kees Cook wrote: > [...] > > --- a/drivers/char/tpm/tpm1-cmd.c > > +++ b/drivers/char/tpm/tpm1-cmd.c > > @@ -510,7 +510,7 @@ struct tpm1_get_random_out { > > * > > * Return: > > * * number of bytes

Re: [PATCH v2] tpm: Actually fail on TPM errors during "get random"

On Mon, 2019-04-01 at 11:52 -0700, Kees Cook wrote: > @@ -559,6 +559,9 @@ int tpm1_get_random(struct tpm_chip *chip, u8 > *dest, size_t max) > rc = total ? (int)total : -EIO; > out: > tpm_buf_destroy(&buf); > +fail: > + if (rc > 0) > + rc = -EIO; > return rc; > }

Re: [PATCH 1/2] stmmac: introduce flag to dynamically disable TX offload for rockchip devices

On 01/04/2019 19:18, Leonidas P. Papadakos wrote: From: =?UTF-8?q?Kamil=20Trzci=C5=84ski?= Some rockchip boards exhibit an issue where tx checksumming does not work with packets larger than 1498. Is it really a board-level problem? I'm no networking expert, but the nature of the workaround s

Re: [PATCH tip/core/rcu 2/2] rcu: Check for wakeup-safe conditions in rcu_read_unlock_special()

On Mon, Apr 01, 2019 at 10:22:57AM -0700, Paul E. McKenney wrote: > On Mon, Apr 01, 2019 at 10:32:11AM +0200, Peter Zijlstra wrote: > > On Fri, Mar 29, 2019 at 11:26:34AM -0700, Paul E. McKenney wrote: > > > When RCU core processing is offloaded from RCU_SOFTIRQ to the rcuc > > > kthreads, a full a

[PATCH v3] tpm: Actually fail on TPM errors during "get random"

A "get random" may fail with a TPM error, but those codes were returned as-is to the caller, which assumed the result was the number of bytes that had been written to the target buffer, which could lead to a kernel heap memory exposure and over-read. This fixes tpm1_get_random() to mask positive T

of_reserved_mem()/kexec interaction

Hi Rob, Not sure if you're the right person to address this to but if not hopefully someone on the list can assist me. I'm trying to understand if memory reserved in the device tree via the "reserved-memory" facility is preserved during a kexec system call, i.e., is the memory at the same locatio

Re: [PATCH v3] tpm: Actually fail on TPM errors during "get random"

On Mon, Apr 01, 2019 at 12:06:07PM -0700, Kees Cook wrote: > A "get random" may fail with a TPM error, but those codes were returned > as-is to the caller, which assumed the result was the number of bytes > that had been written to the target buffer, which could lead to a kernel > heap memory expos

Re: [PATCH] x86/asm: use memory clobber in bitops that touch arbitrary memory

On Mon, Apr 01, 2019 at 06:24:08PM +0200, Alexander Potapenko wrote: > Certain bit operations that read/write bits take a base pointer and an > arbitrarily large offset to address the bit relative to that base. > Inline assembly constraints aren't expressive enough to tell the > compiler that the a

Re: [PATCH v3] tpm: Actually fail on TPM errors during "get random"

On Mon, Apr 1, 2019 at 12:09 PM Jason Gunthorpe wrote: > > + * -errno otherwise ((positive TPM return codes are masked to -EIO) > > Extra bracket, but otherwise looks fine to me Thanks! (And I guess it's time for lunch so I can take a break and learn how to type again...) -- Kees Cook

Re: WARNING in free_loaded_vmcs (2)

On Sat, Mar 30, 2019 at 09:53:01PM -0700, syzbot wrote: > syzbot has bisected this bug to: > > commit 8fcc4b5923af5de58b80b53a069453b135693304 > Author: Jim Mattson > Date: Tue Jul 10 09:27:20 2018 + > > kvm: nVMX: Introduce KVM_CAP_NESTED_STATE > > bisection log: https://syzkaller.a

Re: [PATCH V4 01/23] perf/x86: Support outputting XMM registers

On Tue, Mar 26, 2019 at 9:11 AM wrote: > > From: Kan Liang > > Starting from Icelake, XMM registers can be collected in PEBS record. > But current code only output the pt_regs. > > Add a new struct x86_perf_regs for both pt_regs and xmm_regs. > XMM registers are 128 bit. To simplify the code, the

Re: WARNING in enter_vmx_operation

On Sat, Mar 30, 2019 at 03:33:00AM -0700, syzbot wrote: > syzbot has bisected this bug to: > > commit 8fcc4b5923af5de58b80b53a069453b135693304 > Author: Jim Mattson > Date: Tue Jul 10 09:27:20 2018 + > > kvm: nVMX: Introduce KVM_CAP_NESTED_STATE > > bisection log: https://syzkaller.a

Re: [PATCH 1/2] PCI: Prevent 64-bit resources from being counted in 32-bit bridge region

Hey Bjorn, On 2019-03-04 1:11 p.m., Bjorn Helgaas wrote: > On Mon, Mar 4, 2019 at 1:21 PM Logan Gunthorpe wrote: >> On 2019-03-03 5:23 p.m., Bjorn Helgaas wrote: >>> Sorry for the delay. This code gives a headache. I still remember >>> my headache from the last time we touched it. Help me unde

Re: How to add Unicode character tables to the kernel?

Linus Torvalds writes: > On Sun, Mar 31, 2019 at 4:09 PM Theodore Ts'o wrote: >> >> The question is how to do this, with different tradeoffs. One is to >> simply include a utf8data.h file, which will be 320k. That might >> sound large, but in fs/nls there are 3544k worth of similar files. >> S

Re: [PATCH] secdesc-ui.py: a UI to view the security descriptors on SMB2+ shares

This is really cool! Thanks Ronnie. I will be targeting this for the next release of cifs-utils (not the one that I am about to cut off), so we will have time to stabilize it. Best regards, Pavel Shilovsky вс, 31 мар. 2019 г. в 21:51, Steve French via samba-technical : > > The tool that Ronnie p

Re: WARNING in port_delete

On Mon, Apr 01, 2019 at 12:58:01AM -0700, syzbot wrote: > syzbot has bisected this bug to: > > commit 63d86a7e85f84b8ac3b2f394570965aedbb03787 > Author: Paul E. McKenney > Date: Tue May 1 20:08:46 2018 + > > rcu: Convert rcu_grace_period_init tracepoint to gp_seq > > bisection log: h

[PATCH] PCI: Fix issue with "pci=disable_acs_redir" parameter being ignored

In most cases, kmalloc will not be available early in boot when pci_setup() is called. Thus, the kstrdup call that was added to fix the __initdata bug with the disable_acs_redir parameter usually returns NULL. Thus the parameter is discarded and it does not take into effect. To fix this we have to

about selftests/netfilter test related issue

hello i think the script nft_nat.sh is assuming devices eth0 and eth1 which may not be the case always. my suggestion is why not give the needed network devices as arguments to the script. iam showing related command line sessions below and error related file is attached. -

Re: [PATCH v2 2/8] kbuild: Support for Symbols.list creation

On Thu, Mar 28, 2019 at 04:17:03PM -0400, Joe Lawrence wrote: > On Tue, Mar 26, 2019 at 04:53:12PM -0400, Joe Lawrence wrote: > > On 3/26/19 2:13 PM, Joao Moreira wrote: > > > > > > > > > On 3/26/19 1:15 PM, Joe Lawrence wrote: > > >> > > > > Hi Joao, > > > > > > > > This change seems to work okay

Re: [PATCH] i2c: isch: Remove unnecessary acpi.h include

On Mon, Apr 1, 2019 at 9:08 AM Wolfram Sang wrote: > > > > > From: Bjorn Helgaas > > > > > > 54fb4a05af0a ("i2c: Check for ACPI resource conflicts") included > > > so we could use acpi_check_region(). fd46a0064af1 ("i2c: > > > convert i2c-isch to platform_device") removed the use of > > > acpi_

RE: [PATCH v3] tpm: Actually fail on TPM errors during "get random"

> > A "get random" may fail with a TPM error, but those codes were returned as-is > to the caller, which assumed the result was the number of bytes that had been > written to the target buffer, which could lead to a kernel heap memory > exposure and over-read. > > This fixes tpm1_get_random() to

Re: [PATCH v2 0/5] pid: add pidfd_open()

On Mon, Apr 01, 2019 at 09:01:29AM -0700, Linus Torvalds wrote: > On Mon, Apr 1, 2019 at 8:55 AM Daniel Colascione wrote: > > > > > > > I wonder if we really want a fill procfs2, or maybe we could just make > > > the pidfd readable (yes, it's a directory file descriptor, but we > > > could allow r

Re: Regression causes a hang on boot with a Comtrol PCI card

On Fri, Mar 22, 2019 at 3:02 PM Jesse Hathaway wrote: > > Can you boot v5.0 vanilla with "initcall_debug"? Maybe we can narrow > > it down to a specific quirk. > > yup, added the "initcall_debug" output to the ticket: > https://bugzilla.kernel.org/show_bug.cgi?id=202927, here is the tail end > >

Re: about selftests/netfilter test related issue

Jeffrin Thalakkottoor wrote: > i think the script nft_nat.sh is assuming devices eth0 and eth1 No it does not. These are arbitrary names given to veth devices. > Error: Unknown device type. No Veth device support in kernel?

Re: [PATCH] i2c: isch: Remove unnecessary acpi.h include

> > > Jean, would you like me to repost this with the updates? I assume you > > > will merge this (just based on get_maintainer.pl)? > > > > I will apply it, now that it has Jean's Rev-by. I assume this is > > for-next material despite the Fixes tag? > > Definitely for-next material, not for the

Re: [PATCH] signal: annotate implicit fall through

[+cc Andrew] On 3/13/19 3:27 PM, Mathieu Malaterre wrote: > ping ? > Acked-by: Gustavo A. R. Silva Maybe Andrew can take this? Thanks -- Gustavo > On Mon, Jan 14, 2019 at 9:35 PM Mathieu Malaterre wrote: >> >> There is a plan to build the kernel with -Wimplicit-fallthrough and >> this place

Re: [PATCH V4 01/23] perf/x86: Support outputting XMM registers

On 4/1/2019 3:18 PM, Stephane Eranian wrote: On Tue, Mar 26, 2019 at 9:11 AM wrote: From: Kan Liang Starting from Icelake, XMM registers can be collected in PEBS record. But current code only output the pt_regs. Add a new struct x86_perf_regs for both pt_regs and xmm_regs. XMM registers

Re: [PATCH 01/17] fpga: dfl-fme-mgr: fix FME_PR_INTFC_ID register address.

Hi Wu, On Mon, Mar 25, 2019 at 11:07:28AM +0800, Wu Hao wrote: > FME_PR_INTFC_ID is used as compat_id for fpga manager and region, > but high 64 bits and low 64 bits of the compat_id are swapped by > mistake. This patch fixes this problem by fixing register address. > > Signed-off-by: Wu Hao > -

Re: [PATCH 2/4] staging: iio: ad9832: add SPDX identifier

On 4/1/2019 10:43 PM, Greg KH wrote: On Mon, Apr 01, 2019 at 08:36:50PM +0530, Mukesh Ojha wrote: On 4/1/2019 8:07 PM, Marcelo Schmitt wrote: Add SPDX identifier of GPL-2.0 for the ad9832 driver. Signed-off-by: Marcelo Schmitt --- drivers/staging/iio/frequency/ad9832.c | 3 +-- 1 file

Re: general protection fault in kvm_lapic_hv_timer_in_use

On Sun, Mar 31, 2019 at 02:08:00AM -0700, syzbot wrote: > syzbot has bisected this bug to: > > commit 8fcc4b5923af5de58b80b53a069453b135693304 > Author: Jim Mattson > Date: Tue Jul 10 09:27:20 2018 + > > kvm: nVMX: Introduce KVM_CAP_NESTED_STATE > > bisection log: https://syzkaller.a

Re: about selftests/netfilter test related issue

anyway thanks for the reply. let me look on what you said and learn On Tue, Apr 2, 2019 at 1:15 AM Florian Westphal wrote: > > Jeffrin Thalakkottoor wrote: > > i think the script nft_nat.sh is assuming devices eth0 and eth1 > > No it does not. > These are arbitrary names given to veth devices.

Re: PATCH 2/2] lib/bitmap.c: guard exotic bitmap functions by CONFIG_NUMA

On 30/03/2019 19.54, Yury Norov wrote: > Hi Rasmus! > >> From: Rasmus Villemoes >> Sent: Saturday, March 30, 2019 12:53:51 AM >> To: Rasmus Villemoes; Andrew Morton; Andy Shevchenko >> Cc: Yury Norov; linux-kernel@vger.kernel.org >> Subject: [PATCH 2/2] lib/bitmap.c: guard exotic bitmap functions

Re: [PATCH v4] kmemleak: survive in a low-memory situation

On Fri 29-03-19 16:16:38, Catalin Marinas wrote: > On Fri, Mar 29, 2019 at 01:02:37PM +0100, Michal Hocko wrote: > > On Thu 28-03-19 14:59:17, Catalin Marinas wrote: > > [...] > > > >From 09eba8f0235eb16409931e6aad77a45a12bedc82 Mon Sep 17 00:00:00 2001 > > > From: Catalin Marinas > > > Date: Thu,

<    1   2   3   4   5   6   7   8   9   10   >