Re: [PATCH] trace/page_ref: print out the page migratetype name

2019-03-27 Thread Steven Rostedt
On Wed, 27 Mar 2019 13:09:37 +0800 Huang Shijie wrote: > Print out the page migratetype name which is more readable. Except that it breaks perf and trace-cmd, as they wont know what a migratetype_names array contains. See how writeback does it. Which would be something like this for you. /* en

Re: [PATCH v2 4/9] dt-bindings: power: Add rpm power domain bindings for qcs404

2019-03-27 Thread Sibi Sankar
On 2019-03-25 09:51, Rajendra Nayak wrote: On 3/24/2019 11:20 PM, Sibi Sankar wrote: From: Bjorn Andersson Add RPM Power domain bindings for the qcs404 family of SoC [sibis: Add supported rpmpd states for qcs404] Signed-off-by: Sibi Sankar SoB ordering seems wrong. will re-order them in

Re: [PATCH v6 1/4] arm64: dts: imx8mq: Add SDMA nodes

2019-03-27 Thread Angus Ainslie
On 2019-03-27 02:51, Daniel Baluta wrote: On Tue, Mar 26, 2019 at 11:44 PM Angus Ainslie wrote: On 2019-03-19 07:31, Shawn Guo wrote: > On Fri, Mar 08, 2019 at 12:02:22PM +, Daniel Baluta wrote: >> SDMA1 is part of AIPS-3 region and SDMA2 is part >> of AIPS-1 region. >> >> Reviewed-by: Fab

Re: [PATCH v2 1/9] soc: qcom: rpmpd: fixup rpmpd set performance state

2019-03-27 Thread Sibi Sankar
On 2019-03-25 09:33, Rajendra Nayak wrote: On 3/24/2019 11:19 PM, Sibi Sankar wrote: Fixup rpmpd state to max if the required state is greater than all the supported states. This should also say why, 'so the clients which just want to vote on whatever is the max state supported can do so by

Re: [PATCH v2 2/9] soc: qcom: rpmpd: Add support to set rpmpd state to max

2019-03-27 Thread Sibi Sankar
On 2019-03-25 09:36, Rajendra Nayak wrote: On 3/24/2019 11:20 PM, Sibi Sankar wrote: Add support to set rpmpd state to max across SoCs. Changelog could be better, 'rpmpd max state varies across SoCs and SoC families, add support in the driver to make it SoC/SoC family specific' will use this

Re: WARNING in arch_install_hw_breakpoint

2019-03-27 Thread Borislav Petkov
On Sat, Mar 23, 2019 at 11:22:06PM -0700, syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:fd1f297b Merge tag 'drm-fixes-2019-03-22' of git://anongit.. > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=1574f56d20 > kernel

Re: [PATCH v2 3/9] soc: qcom: rpmpd: Modify corner defining macros

2019-03-27 Thread Sibi Sankar
On 2019-03-25 09:37, Rajendra Nayak wrote: On 3/24/2019 11:20 PM, Sibi Sankar wrote: From: Bjorn Andersson QCS404 uses individual resource type magic for each power-domain, so adjust the macros slightly to make them reusable for this. [sibi: Extend rpmpd corner pair to a generic rpmpd pair]

[tip:x86/urgent] x86/realmode: Don't leak the trampoline kernel address

2019-03-27 Thread tip-bot for Matteo Croce
Commit-ID: b929a500d68479163c48739d809cbf4c1335db6f Gitweb: https://git.kernel.org/tip/b929a500d68479163c48739d809cbf4c1335db6f Author: Matteo Croce AuthorDate: Tue, 26 Mar 2019 21:30:46 +0100 Committer: Borislav Petkov CommitDate: Wed, 27 Mar 2019 14:22:08 +0100 x86/realmode: Don't le

[PATCH] interconnect: convert to DEFINE_SHOW_ATTRIBUTE

2019-03-27 Thread Yangtao Li
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. Signed-off-by: Yangtao Li --- drivers/interconnect/core.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/interconnect/core.c b/drivers/interconnect/core.c index 6005a1c189f6..871eb4bc4efc 100644 ---

Re: [PATCH v3] PCI: xilinx: Check for __get_free_pages() failure

2019-03-27 Thread Mukesh Ojha
On 3/26/2019 3:49 AM, Kangjie Lu wrote: If __get_free_pages() fails, the patch returns -ENOMEM to avoid NULL pointer dereference. Signed-off-by: Kangjie Lu Reviewed-by: Mukesh Ojha -Mukesh --- v3: remove "unlikely", as suggested by Bjorn Helgaas. v2: caller is redefined to accept the e

Re: [PATCH] RISC-V: Implement ASID allocator

2019-03-27 Thread Gary Guo
On 27/03/2019 11:42, Anup Patel wrote: > On Wed, Mar 27, 2019 at 4:57 PM Gary Guo wrote: >> >> Hi Anup, >> >> This won't work in an actual hardware with ASID support. There're more > > Can you elaborate why > > > This implementation is based on Linux ARM64 ASID allocator which is > tested for la

Re: [PATCH] infiniband: cxgb4: fix a potential NULL pointer dereference

2019-03-27 Thread Potnuri Bharat Teja
On Saturday, March 03/23/19, 2019 at 08:07:46 +0530, Kangjie Lu wrote: > > > > On Mar 8, 2019, at 11:19 PM, Kangjie Lu wrote: > > > > get_skb may fail and return NULL. The fix returns "ENOMEM" > > when it fails to avoid NULL dereference. > > > > Signed-off-by: Kangjie Lu > > --- > > drivers/i

[PATCH] arm:mach-sa1100/hackkit.c : Remove duplicate header

2019-03-27 Thread jagdsh . linux
From: Jagadeesh Pagadala Remove duplicate header which is included twice. Signed-off-by: Jagadeesh Pagadala --- arch/arm/mach-sa1100/hackkit.c | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/mach-sa1100/hackkit.c b/arch/arm/mach-sa1100/hackkit.c index 643d5f2..0016d25 100644 --- a/

Re: [PATCH v3 1/3] dt-bindings: arm: fsl: Add supported ZII VF610 boards to DT schema

2019-03-27 Thread Rob Herring
On Mon, Mar 25, 2019 at 1:23 PM Andrey Smirnov wrote: > > Add already supported ZII VF610 boards to DT schema. > > Signed-off-by: Andrey Smirnov > Cc: Shawn Guo > Cc: Chris Healy > Cc: Andrew Lunn > Cc: Fabio Estevam > Cc: Rob Herring > Cc: linux-arm-ker...@lists.infradead.org > Cc: linux-ke

Re: [PATCH] RISC-V: Implement ASID allocator

2019-03-27 Thread Gary Guo
I would also like to mention that your code assumes 64-bit atomics support which we don't have on 32-bit systems. Using 32-bit to track ASID generations isn't sufficient and will cause overflows. That's why I have asid_generation_overflow to handle the case (this is super error-prone as well).

Re: [RESEND] i2c: imx: defer probing on dma channel request

2019-03-27 Thread Laurentiu Tudor
07894] Internal error: Oops: 9604 [#1] PREEMPT SMP [5.213455] Modules linked in: [5.216502] CPU: 0 PID: 18 Comm: kworker/0:1 Not tainted 5.1.0-rc2-next-20190327-00021-g7b1a4c075381-dirty #15 [5.226489] Hardware name: LS1043A RDB Board (DT) [5.231189] Workqueue: e

Re: [PATCH v3 2/3] dt-bindings: arm: fsl: Add support for ZII VF610 SPB4

2019-03-27 Thread Rob Herring
On Mon, Mar 25, 2019 at 1:23 PM Andrey Smirnov wrote: > > Add support for ZII VF610 SPB4. > > Signed-off-by: Andrey Smirnov > Cc: Shawn Guo > Cc: Chris Healy > Cc: Andrew Lunn > Cc: Fabio Estevam > Cc: Rob Herring > Cc: linux-arm-ker...@lists.infradead.org > Cc: linux-kernel@vger.kernel.org

Re: WARNING in arch_install_hw_breakpoint

2019-03-27 Thread Dmitry Vyukov
On Wed, Mar 27, 2019 at 2:28 PM Borislav Petkov wrote: > > On Sat, Mar 23, 2019 at 11:22:06PM -0700, syzbot wrote: > > Hello, > > > > syzbot found the following crash on: > > > > HEAD commit:fd1f297b Merge tag 'drm-fixes-2019-03-22' of git://anongit.. > > git tree: upstream > > console o

Re: [PATCH v1 1/1] MAINTAINERS: fix typo in file name

2019-03-27 Thread Mukesh Ojha
On 3/26/2019 10:48 AM, Amit Kucheria wrote: Replace underscore with dash. Fixes: e31f941cf977 ("MAINTAINERS: update list of qcom drivers") Reported-by: Joe Perches Signed-off-by: Amit Kucheria Please write appropriate commit text as why are you doing this . Otherwise looks  good. Reviewe

Re: [PATCH 0/2] perf scripts python: exported-sql-viewer.py: Fix python3 support

2019-03-27 Thread Arnaldo Carvalho de Melo
Em Wed, Mar 27, 2019 at 09:28:24AM +0200, Adrian Hunter escreveu: > Hi > > Here are a couple for fixes. Thanks, applied to perf/urgent. - Arnaldo > > Adrian Hunter (2): > perf scripts python: exported-sql-viewer.py: Fix never-ending loop > perf scripts python: exported-sql-viewer.

Re: [PATCH] MAINTAINERS: fix the file path of uniphier-mdmac.c

2019-03-27 Thread Mukesh Ojha
On 3/26/2019 7:43 AM, Masahiro Yamada wrote: The pattern drivers/dmaengine/uniphier-mdmac.c has no match in the source tree. The correct path is drivers/dma/uniphier-mdmac.c Reported-by: Joe Perches Signed-off-by: Masahiro Yamada Reviewed-by: Mukesh Ojha -Mukesh --- MAINTAINERS |

Re: [PATCH 4/5] lib/vsprintf: Make use of fwnode API to obtain node names and separators

2019-03-27 Thread Sakari Ailus
Hi Petr, Thank you for reviewing these patches. On Wed, Mar 27, 2019 at 01:53:56PM +0100, Petr Mladek wrote: > On Fri 2019-03-22 17:29:29, Sakari Ailus wrote: > > Instead of implementing our own means of discovering parent nodes, node > > names or counting how many parents a node has, use the new

Re: [RFC PATCH 1/4] vfs: Create fs_context-aware mount_bdev() replacement

2019-03-27 Thread Andrew Price
On 27/03/2019 11:23, David Howells wrote: Andrew Price wrote: + up_write(&s->s_umount); + blkdev_put(bdev, fc->bdev_mode); + down_write(&s->s_umount); fc->bdev should be NULLed here (or, on the way out of sget_fc() might be more appropriate) otherwis

Re: [PATCH] MAINTAINERS: Fix Hyperv vIOMMU driver file name

2019-03-27 Thread Mukesh Ojha
On 3/26/2019 11:58 AM, lantianyu1...@gmail.com wrote: From: Lan Tianyu The Hyperv vIOMMU file name should be "hyperv-iommu.c" rather s/vIOMMU/IOMMU than "hyperv_iommu.c". This patch is to fix it. Signed-off-by: Lan Tianyu Make the above change otherwise looks good. Reviewed-by: Mukes

Re: [PATCH 2/4] perf, tools: Implement duration_time as a proper event

2019-03-27 Thread Andi Kleen
> > so now that we have time in a separate event, we could > get rid of the isolated update_stats(&walltime_nsecs_stats) calls > and move them to perf_stat__update_shadow_stats? In theory yes, but it would require perf stat always setting up the duration_time event implicitely and then special ha

Re: [PATCH 0/4] PCI, CPER: Trivial cleanups

2019-03-27 Thread Bjorn Helgaas
On Mon, Mar 25, 2019 at 01:14:21PM -0500, helg...@kernel.org wrote: > From: Bjorn Helgaas > > Clean up whitespace, fix some typos, add some spec references, and convert > unnecessary __u32 usage to u32. > > Bjorn Helgaas (4): > PCI: Cleanup register definition width and whitespace > PCI: Fix

Re: [PATCH] mm/page-flags: Check enforce parameter in PF_ONLY_HEAD()

2019-03-27 Thread Anshuman Khandual
On 03/27/2019 06:45 PM, Michal Hocko wrote: > [Cc Nick] > > On Wed 27-03-19 17:57:52, Anshuman Khandual wrote: >> Just check for enforce parameter in PF_ONLY_HEAD() wrapper before calling >> VM_BUG_ON_PGFLAGS() for tail pages. > Why is this an actual fix? Only TESTPAGEFLAG doesn't enforce the c

Re: [PATCH] regulator: max77650: Convert MAX77651 SBB1 to pickable linear range

2019-03-27 Thread Bartosz Golaszewski
śr., 27 mar 2019 o 14:56 Axel Lin napisał(a): > > Bartosz Golaszewski 於 2019年3月27日 週三 下午9:08寫道: > > > > śr., 27 mar 2019 o 11:17 Axel Lin napisał(a): > > > > > > > Hi, > > > > > > > > what tree is this patch based on, because it doesn't apply on top of > > > > v5.1-rc2. > > > Hi Bart, > > > You

Re: [PATCH] RISC-V: Implement ASID allocator

2019-03-27 Thread Anup Patel
On Wed, Mar 27, 2019 at 7:12 PM Gary Guo wrote: > > I would also like to mention that your code assumes 64-bit atomics > support which we don't have on 32-bit systems. Using 32-bit to track > ASID generations isn't sufficient and will cause overflows. That's why I > have asid_generation_overflow t

Re: [PATCH] regulator: max77650: Convert MAX77651 SBB1 to pickable linear range

2019-03-27 Thread Axel Lin
Bartosz Golaszewski 於 2019年3月27日 週三 下午9:08寫道: > > śr., 27 mar 2019 o 11:17 Axel Lin napisał(a): > > > > > Hi, > > > > > > what tree is this patch based on, because it doesn't apply on top of > > > v5.1-rc2. > > Hi Bart, > > You can use linux-next or regulator tree. > > However, due to build dep

Re: [PATCH 0/2] PCI/MSI: Remove unused interfaces

2019-03-27 Thread Bjorn Helgaas
[+cc Lorenzo, Michal, linux-arm-kernel] On Mon, Mar 25, 2019 at 05:12:27PM -0500, Bjorn Helgaas wrote: > From: Bjorn Helgaas > > pcie-xilinx-nwl.c is the only driver to use mask_msi_irq() and > unmask_msi_irq(), which are trivial wrappers around PCI-specific functions. > We obviously know we nee

Re: [PATCH] usb: u132-hcd: fix potential NULL pointer dereference

2019-03-27 Thread Mukesh Ojha
Please change the patch version in subject while sending patch. On 3/26/2019 10:11 AM, Greg Kroah-Hartman wrote: On Tue, Mar 19, 2019 at 12:34:06PM -0500, Kangjie Lu wrote: In case create_singlethread_workqueue fails, the fix notifies callers the error to avoid potential NULL pointer dereferenc

Re: [PATCH] RISC-V: Implement ASID allocator

2019-03-27 Thread Gary Guo
I think my code already get all the caveats cases covered. The only thing my code is missing is handling the case when ASID is not supported. Maybe it is better to work based on that instead? On 27/03/2019 14:02, Anup Patel wrote: > On Wed, Mar 27, 2019 at 7:12 PM Gary Guo wrote: >> >> I would

Re: [PATCH] MAINTAINERS: Fix Hyperv vIOMMU driver file name

2019-03-27 Thread Mukesh Ojha
On 3/26/2019 11:58 AM, lantianyu1...@gmail.com wrote: From: Lan Tianyu The Hyperv vIOMMU file name should be "hyperv-iommu.c" rather s/vIOMMU /IOMMU than "hyperv_iommu.c". This patch is to fix it. Signed-off-by: Lan Tianyu Othewise looks fine. Reviewed-by: Mukesh Ojha -Mukesh ---

Teo En Ming's pfSense 2.4.4-p1 Firewall, IPsec VPN and Snort IPS Deployment Manual version 1.0

2019-03-27 Thread Turritopsis Dohrnii Teo En Ming
Primary Subject/Topic: Teo En Ming's pfSense 2.4.4-p1 Firewall, IPsec VPN and Snort IPS Deployment Manual version 1.0 Secondary Subject/Topic: Installing and Configuring pfSense 2.4.4-p1 Firewall on Oracle VM VirtualBox 6.0.4 with IPsec Remote Access Mobile VPN and Snort Intrusion Prevention Sy

Re: [PATCH] RISC-V: Implement ASID allocator

2019-03-27 Thread Anup Patel
On Wed, Mar 27, 2019 at 7:08 PM Gary Guo wrote: > > On 27/03/2019 11:42, Anup Patel wrote: > > On Wed, Mar 27, 2019 at 4:57 PM Gary Guo wrote: > >> > >> Hi Anup, > >> > >> This won't work in an actual hardware with ASID support. There're more > > > > Can you elaborate why > > > > > This implement

Re: [PATCH 5/5] lib/vsprintf: Add %pfw conversion specifier for printing fwnode names

2019-03-27 Thread Sakari Ailus
Hi Petr, On Tue, Mar 26, 2019 at 04:13:07PM +0100, Petr Mladek wrote: > On Fri 2019-03-22 17:29:30, Sakari Ailus wrote: > > Add support for %pfw conversion specifier (with "f" and "P" modifiers) to > > support printing full path of the node, including its name ("f") and only > > the node's name ("

Re: [PATCH] RISC-V: Implement ASID allocator

2019-03-27 Thread Anup Patel
On Wed, Mar 27, 2019 at 7:39 PM Gary Guo wrote: > > I think my code already get all the caveats cases covered. The only > thing my code is missing is handling the case when ASID is not > supported. Maybe it is better to work based on that instead? Well, I have also spend enough time hardening thi

[PATCH] KVM: x86: avoid misreporting level-triggered irqs as edge-triggered in tracing

2019-03-27 Thread Vitaly Kuznetsov
In __apic_accept_irq() interface trig_mode is int and actually on some code paths it is set above u8: kvm_apic_set_irq() extracts it from 'struct kvm_lapic_irq' where trig_mode is u16. This is done on purpose as e.g. kvm_set_msi_irq() sets it to (1 << 15) & e->msi.data kvm_apic_local_deliver sets

[PATCH v1] gpio: gpio-mlxbf: Add dependency on 64BIT to Kconfig entry

2019-03-27 Thread Shravan Kumar Ramani
Fixes a compile test failure Signed-off-by: Shravan Kumar Ramani --- drivers/gpio/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig index 0d9ddff..530ee34 100644 --- a/drivers/gpio/Kconfig +++ b/drivers/gpio/Kconfig @@ -1318,7

[PATCH] phy: sr-usb: fix build warning

2019-03-27 Thread Srinath Mannam
Add invalid version check to fix below warning reported for stingray usb phy driver. The kbuild robot reports: drivers/phy/broadcom/phy-bcm-sr-usb.c: In function 'bcm_usb_phy_probe': warning: 'phy_cfg' may be used uninitialized in this function Fixes: a3b96057577 (phy: sr-usb: Add Stingray USB P

[PATCH v2 3/5] tools/perf,tools/lib/traceevent: Rename "pevent" member of struct tep_event to "tep"

2019-03-27 Thread Tzvetomir Stoyanov
This patch renames "pevent" member of the struct tep_event to "tep". This makes the struct consistent with the chosen naming convention: tep (trace event parser), instead of the old pevent. Signed-off-by: Tzvetomir Stoyanov --- tools/lib/traceevent/event-parse.c| 32 +

[PATCH v2 4/5] tools/perf,tools/lib/traceevent: Rename "pevent" member of struct tep_event_filter to "tep"

2019-03-27 Thread Tzvetomir Stoyanov
This patch renames "pevent" member of the struct tep_event_filter to "tep". This makes the struct consistent with the chosen naming convention: tep (trace event parser), instead of the old pevent. Signed-off-by: Tzvetomir Stoyanov --- tools/lib/traceevent/event-parse.h | 2 +- tools/lib/tracee

[PATCH v2 2/5] tools/lib/traceevent: Rename input arguments of libtraceevent APIs from pevent to tep

2019-03-27 Thread Tzvetomir Stoyanov
This patch renames "struct tep_handle *pevent" input arguments of libtraceevent APIs to "struct tep_handle *tep". This makes the API consistent with the chosen naming convention: tep (trace event parser), instead of the old pevent. Signed-off-by: Tzvetomir Stoyanov --- tools/lib/traceevent/event

[PATCH v2 5/5] tools/lib/traceevent: Rename input arguments and local variables of libtraceevent from pevent to tep

2019-03-27 Thread Tzvetomir Stoyanov
This patch renames from "pevent" to "tep": - all "pevent" input arguments of libtraceevent internal functions. - all local "pevent" variables of libtraceevent. This makes the implementation consistent with the chosen naming convention, tep (trace event parser), and will avoid any confusion with t

[PATCH v2 0/5] Cleanup traceevent API and make it more consistent

2019-03-27 Thread Tzvetomir Stoyanov
[ v2 changes: - Excluded patches: "tools/lib/traceevent: Remove tep filter trivial APIs" "tools/lib/traceevent: remove call to exit() from tep_filter_add_filter_str()" from the series, as they are already merged. - Dropped patch "tools/lib/traceevent: Add counter to track parsin

Re: [PATCH 02/17] x86, lto: Mark all top level asm statements as .text

2019-03-27 Thread Thomas Gleixner
Andi, On Tue, 26 Mar 2019, Andi Kleen wrote: > > Well, we better should know the real reason for this wreckage. I mean, the > > default section for text is suprisingly .text. I don't see a reason why > > this would be any different for an assembly function implemented in a C > > file. > > What ha

[PATCH v2 1/5] tools/perf,tools/lib/traceevent: Make traceevent APIs more consistent

2019-03-27 Thread Tzvetomir Stoyanov
Rename some traceevent APIs for consistency: tep_pid_is_registered() to tep_is_pid_registered() tep_file_bigendian() to tep_is_file_bigendian() to make the names and return values consistent with other tep_is_... APIs tep_data_lat_fmt() to tep_data_latency_format() to make the name more descr

Re: [PATCH v2 1/6] device property: Add functions for accessing node's parents

2019-03-27 Thread Sakari Ailus
Hi Petr, On Wed, Mar 27, 2019 at 01:26:25PM +0100, Petr Mladek wrote: > On Tue 2019-03-26 14:41:01, Sakari Ailus wrote: > > Add two convenience functions for accessing node's parents: > > > > fwnode_count_parents() returns the number of parent nodes a given node > > has. fwnode_get_nth_parent() r

[ANNOUNCE] 4.19.31-rt18

2019-03-27 Thread Steven Rostedt
Dear RT Folks, I'm pleased to announce the 4.19.31-rt18 stable release. This release is just an update to the new stable 4.19.31 version and no RT specific changes have been made. You can get this release via the git tree at: git://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-stable-r

Re: [PATCH V4 04/23] perf/x86/intel: Support adaptive PEBSv4

2019-03-27 Thread Liang, Kan
On 3/26/2019 6:24 PM, Andi Kleen wrote: + for (at = base; at < top; at += cpuc->pebs_record_size) { + u64 pebs_status; + + pebs_status = get_pebs_status(at) & cpuc->pebs_enabled; + pebs_status &= mask; + + for_each_set_bit(bit, (uns

[PATCH] platform/x86: dell-laptop: fix rfkill functionality

2019-03-27 Thread Mario Limonciello
When converting the driver two arguments were transposed leading to rfkill not working. BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=201427 Reported-by: Pepijn de Vos Fixes: 549b49 ("platform/x86: dell-smbios: Introduce dispatcher for SMM calls") Signed-off-by: Mario Limonciello Acked-by

Re: [PATCH v2] x86/syscalls: Mark expected switch fall-throughs

2019-03-27 Thread Thomas Gleixner
On Wed, 27 Mar 2019, Dmitry V. Levin wrote: > On Tue, Mar 26, 2019 at 04:12:45PM +0100, Oleg Nesterov wrote: > > On 03/23, Thomas Gleixner wrote: > [...] > > > 2) syscall_set_arguments() has been introduced in 2008 and we still have > > > no caller. Instead of polishing it, can it be removed

[RFC PATCH 3/4] spi: spi-fsl-spi: allow changing bits_per_word while CS is still active

2019-03-27 Thread Rasmus Villemoes
Commit c9bfcb315104 (spi_mpc83xx: much improved driver) introduced logic to ensure bits_per_word and speed_hz stay the same for a series of spi_transfers with CS active, arguing that The current driver may cause glitches on SPI CLK line since one must disable the SPI controller before chan

[RFC PATCH 1/4] spi: spi-fsl-spi: remove always-true conditional in fsl_spi_do_one_msg

2019-03-27 Thread Rasmus Villemoes
__spi_validate() in the generic SPI code sets ->speed_hz and ->bits_per_word to non-zero values, so this condition is always true. Signed-off-by: Rasmus Villemoes --- This of course relies on no spi_message reaching ->transfer_one_message without having been through __spi_validate. I believe that

[RFC PATCH 2/4] spi: spi-fsl-spi: relax message sanity checking a little

2019-03-27 Thread Rasmus Villemoes
The comment says that we should not allow changes (to bits_per_word/speed_hz) while CS is active, and indeed the code below does fsl_spi_setup_transfer() when the ->cs_change of the previous spi_transfer was set (and for the very first transfer). So the sanity checking is a bit too strict - we can

[RFC PATCH 0/4] spi: spi-fsl-spi: try to make cpu-mode transfers faster

2019-03-27 Thread Rasmus Villemoes
I doubt patches 3 and 4 are acceptable, but I'd still like to get comments and/or alternative suggestions for making large transfers faster. The patches have been tested on an MPC8309 with a Cypress S25FL032P spi-nor slave, and make various operations between 50% and 73% faster. We have not obser

[RFC PATCH 4/4] spi: spi-fsl-spi: automatically adapt bits-per-word in cpu mode

2019-03-27 Thread Rasmus Villemoes
Taking one interrupt for every byte is rather slow. Since the controller is perfectly capable of transmitting 32 bits at a time, change t->bits_per-word to 32 when the length is divisible by 4 and large enough that the reduced number of interrupts easily compensates for the one or two extra fsl_spi

Re: [PATCH v3] ASoC: sirf-audio: Remove redundant of_match_node call

2019-03-27 Thread Mukesh Ojha
On 3/23/2019 3:30 AM, Aditya Pakki wrote: Unlike other drivers probe method, of_match_node return value is not used or checked. This patch removes the redundant code. Instead could be written like "Use of `of_match_node` is redundant in sirf-audio-codec driver probe. Remove it." Signed-o

[PATCH v13 0/4] PM / Domains: Support hierarchical CPU arrangement (PSCI/ARM)

2019-03-27 Thread Ulf Hansson
Changes in v13: - Use WRITE|READ_ONCE when reading/writing the "next_hrtimer" variable in the struct cpuidle_device. Also reset the same variable after resumed from idle to avoid it from containing a stale value. - Added acks from Daniel Lezcano. - The entire v13 series, including the PSCI/ARM c

Re: [PATCH v3 2/5] drm/virtio: use struct to pass params to virtio_gpu_object_create()

2019-03-27 Thread Noralf Trønnes
Den 18.03.2019 12.33, skrev Gerd Hoffmann: > Create virtio_gpu_object_params, use that to pass object parameters to > virtio_gpu_object_create. This is just the first step, followup patches > will add more parameters to the struct. The plan is to use the struct > for all object parameters. >

[PATCH 2/4] PM / Domains: Add support for CPU devices to genpd

2019-03-27 Thread Ulf Hansson
To enable a device belonging to a CPU to be attached to a PM domain managed by genpd, let's do a few changes to it, as to make it convenient to manage the specifics around CPUs. To be able to quickly find out what CPUs that are attached to a genpd, which typically becomes useful from a genpd gover

[PATCH v13 3/4] cpuidle: Export the next timer/tick expiration for a CPU

2019-03-27 Thread Ulf Hansson
To be able to predict the sleep duration for a CPU that is entering idle, knowing when the next timer/tick is going to expire, is extremely useful. Both the teo and the menu cpuidle governors already makes use of this information, while selecting an idle state. Moving forward, the similar predicti

[PATCH v13 4/4] PM / Domains: Add genpd governor for CPUs

2019-03-27 Thread Ulf Hansson
As it's now perfectly possible that a PM domain managed by genpd contains devices belonging to CPUs, we should start to take into account the residency values for the idle states during the state selection process. The residency value specifies the minimum duration of time, the CPU or a group of CP

Re: [PATCH v3] thunderbolt: Fix to check the return value of kmemdup

2019-03-27 Thread Mukesh Ojha
On 3/26/2019 2:55 AM, Aditya Pakki wrote: uuid in add_switch is allocted via kmemdup which can fail. The patch logs the error and cleans up the allocated memory for switch. Signed-off-by: Aditya Pakki Reviewed-by: Mukesh Ojha -Mukesh --- v2: replace WARN_ONCE with tb_sw_warn, as sugges

[PATCH v13 1/4] PM / Domains: Add a generic data pointer to the genpd_power_state struct

2019-03-27 Thread Ulf Hansson
Let's add a data pointer to the genpd_power_state struct, to allow a genpd backend driver to store per state specific data. To introduce the pointer, we need to change the way genpd deals with freeing of the corresponding allocated data. More precisely, let's clarify the responsibility of whom tha

Re: [PATCH 08/25] coresight: tmc: Clean up device specific data

2019-03-27 Thread Suzuki K Poulose
On 03/26/2019 09:53 PM, Mathieu Poirier wrote: Hi Suzuki, On Wed, Mar 20, 2019 at 06:49:25PM +, Suzuki K Poulose wrote: In preparation to use a consistent device naming scheme, clean up the device link tracking in replicator driver. Use the "coresight" device instead of the "real" parent de

Re: [PATCH 02/17] x86, lto: Mark all top level asm statements as .text

2019-03-27 Thread Ingo Molnar
* Thomas Gleixner wrote: > Proper fix below. > > Thanks, > > tglx > > 8<--- > > --- a/arch/x86/include/asm/paravirt_types.h > +++ b/arch/x86/include/asm/paravirt_types.h > @@ -367,11 +367,15 @@ extern struct paravirt_patch_template pv > _paravirt_alt(insn_string,

[PATCH v13 2/4] PM / Domains: Add support for CPU devices to genpd

2019-03-27 Thread Ulf Hansson
To enable a device belonging to a CPU to be attached to a PM domain managed by genpd, let's do a few changes to it, as to make it convenient to manage the specifics around CPUs. To be able to quickly find out what CPUs that are attached to a genpd, which typically becomes useful from a genpd gover

Re: [PATCH v2 1/5] tools/perf,tools/lib/traceevent: Make traceevent APIs more consistent

2019-03-27 Thread Steven Rostedt
On Wed, 27 Mar 2019 16:19:42 +0200 Tzvetomir Stoyanov wrote: > /** > - * tep_file_bigendian - get if the file is in big endian order > + * tep_is_file_bigendian - return the endian of the file > * @pevent: a handle to the tep_handle > * > - * This returns if the file is in big endian order >

Re: [PATCH v3 5/5] drm/virtio: rework resource creation workflow.

2019-03-27 Thread Noralf Trønnes
Den 18.03.2019 12.33, skrev Gerd Hoffmann: > This patch moves the virtio_gpu_cmd_create_resource() call (which > notifies the host about the new resource created) into the > virtio_gpu_object_create() function. That way we can call > virtio_gpu_cmd_create_resource() before ttm_bo_init(), so the

Re: [PATCH V4 04/23] perf/x86/intel: Support adaptive PEBSv4

2019-03-27 Thread Andi Kleen
> We need to call perf_event_overflow() for the last record of each event. > It's hard to detect which record is the last record of the event with one > pass walking. > > Also, I'm not sure how much we can save with one pass walking. The > optimization should only benefit large PEBS. The total num

Re: [PATCH V4 4/5] mmc: mmci: stm32: define get_dctrl_cfg

2019-03-27 Thread Ludovic BARRE
On 3/27/19 11:54 AM, Ulf Hansson wrote: On Wed, 27 Mar 2019 at 10:05, Ludovic Barre wrote: From: Ludovic Barre This patch defines get_dctrl_cfg callback for sdmmc variant. sdmmc variant has specific stm32 transfer modes. sdmmc data transfer mode selection could be: -Block data transfer en

Re: [PATCH] thunderbolt: property: fix a buffer overflow and a missing check

2019-03-27 Thread Mukesh Ojha
On 3/25/2019 4:19 AM, Kangjie Lu wrote: First, no memory is allocated for "property->value.text"; the following strcpy will lead to a buffer overflow. Fix the commit text as there is no  overflow. only the check and resource cleanp is the fix. Second, no check is enforced for the return v

[PATCH 1/2] dt-bindings: scsi: ufs-cdns: Update Cadence UFS compatibility list

2019-03-27 Thread Jan Kotas
This patch adds a new compatible string description for CDNS UFS HCD + M31 16nm PHY. Signed-off-by: Jan Kotas --- Documentation/devicetree/bindings/ufs/cdns,ufshc.txt | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/ufs/cdns,ufshc.txt b/

[PATCH 2/2] scsi: ufs-cdns: Add support for UFSHCI with M31 PHY

2019-03-27 Thread Jan Kotas
This patch adds an additional PHY initialization, required for M31 PHY when used with Cadence UFS HC. A new compatible string has been added for this purpose. Signed-off-by: Jan Kotas --- drivers/scsi/ufs/cdns-pltfrm.c | 77 -- 1 file changed, 67 insertion

Re: [PATCH V4 4/5] mmc: mmci: stm32: define get_dctrl_cfg

2019-03-27 Thread Ulf Hansson
On Wed, 27 Mar 2019 at 15:44, Ludovic BARRE wrote: > > > > On 3/27/19 11:54 AM, Ulf Hansson wrote: > > On Wed, 27 Mar 2019 at 10:05, Ludovic Barre wrote: > >> > >> From: Ludovic Barre > >> > >> This patch defines get_dctrl_cfg callback for sdmmc variant. > >> sdmmc variant has specific stm32 tra

Re: [PATCH v2 -next] drm/virtio: remove set but not used variable 'vgdev'

2019-03-27 Thread Mukesh Ojha
On 3/25/2019 2:56 PM, YueHaibing wrote: Fixes gcc '-Wunused-but-set-variable' warning: drivers/gpu/drm/virtio/virtgpu_ttm.c: In function 'virtio_gpu_init_mem_type': drivers/gpu/drm/virtio/virtgpu_ttm.c:117:28: warning: variable 'vgdev' set but not used [-Wunused-but-set-variable] drivers/gp

Re: [PATCH] vc04_services: vchiq_arm: fix a NULL pointer dereference

2019-03-27 Thread Mukesh Ojha
On 3/25/2019 4:13 AM, Kangjie Lu wrote: When kzalloc fails, "platform_state->inited = 1" is a NULL pointer dereference. The fix returns VCHIQ_ERROR in case it failed to avoid NULL pointer dereference. Signed-off-by: Kangjie Lu Reviewed-by: Mukesh Ojha -Mukesh --- .../staging/vc04_ser

[PATCH v5] kmemleak: survive in a low-memory situation

2019-03-27 Thread Qian Cai
Kmemleak could quickly fail to allocate an object structure and then disable itself below in a low-memory situation. For example, running a mmap() workload triggering swapping and OOM. This is especially problematic for running things like LTP testsuite where one OOM test case would disable the who

Re: [PATCH v2 -next] ASoC: simple-card-utils: remove set but not used variable 'dai_name'

2019-03-27 Thread Mukesh Ojha
On 3/25/2019 8:47 AM, YueHaibing wrote: Fixes gcc '-Wunused-but-set-variable' warning: sound/soc/generic/simple-card-utils.c: In function 'asoc_simple_parse_clk': sound/soc/generic/simple-card-utils.c:164:18: warning: parameter 'dai_name' set but not used [-Wunused-but-set-parameter] It's n

[PATCH] Convert struct pid count to refcount_t

2019-03-27 Thread Joel Fernandes (Google)
struct pid's count is an atomic_t field used as a refcount. Use refcount_t for it which is basically atomic_t but does additional checking to prevent use-after-free bugs. No change in behavior if CONFIG_REFCOUNT_FULL=n. Cc: keesc...@chromium.org Cc: kernel-t...@android.com Cc: kernel-harden...@lis

Re: [PATCH v2 2/4] rcutree: Add checks for dynticks counters in rcu_is_cpu_rrupt_from_idle

2019-03-27 Thread Paul E. McKenney
On Tue, Mar 26, 2019 at 03:24:09PM -0400, Joel Fernandes (Google) wrote: > In the future we would like to combine the dynticks and dynticks_nesting > counters thus leading to simplifying the code. At the moment we cannot > do that due to concerns about usermode upcalls appearing to RCU as half > of

Re: [PATCH 02/17] x86, lto: Mark all top level asm statements as .text

2019-03-27 Thread Andi Kleen
On Wed, Mar 27, 2019 at 03:20:08PM +0100, Thomas Gleixner wrote: > +void __init foo(void) > +{ > + pr_info("foo\n"); > +} > > right before the kretprobe_trampoline and compiling it with GCC 6. > > So one would assume that kretprobe_trampoline now ends up in > .init.text. But it ends up in t

Re: [PATCH v2 2/5] tools/lib/traceevent: Rename input arguments of libtraceevent APIs from pevent to tep

2019-03-27 Thread Steven Rostedt
On Wed, 27 Mar 2019 16:19:43 +0200 Tzvetomir Stoyanov wrote: > This patch renames "struct tep_handle *pevent" input arguments of > libtraceevent > APIs to "struct tep_handle *tep". This makes the API consistent with the > chosen > naming convention: tep (trace event parser), instead of the old

[PATCH] MIPS: KGDB: fix kgdb support for SMP platforms.

2019-03-27 Thread qiaochong
KGDB_call_nmi_hook is called by other cpu through smp call. MIPS smp call is processed in ipi irq handler and regs is saved in handle_int. So kgdb_call_nmi_hook get regs by get_irq_regs and regs will be passed to kgdb_cpu_enter. Signed-off-by: qiaochong --- arch/mips/kernel/kgdb.c | 3 ++- 1 f

[PATCH v4] mtd: cfi: fix deadloop in cfi_cmdset_0002.c do_write_buffer

2019-03-27 Thread Liu Jian
In function do_write_buffer(), in the for loop, there is a case chip_ready() returns 1 while chip_good() returns 0, so it never break the loop. To fix this, chip_good() is enough and it should timeout if it stay not good status for a while. Fixes: dfeae1073583("mtd: cfi_cmdset_0002: Change write b

Re: [PATCH 02/17] x86, lto: Mark all top level asm statements as .text

2019-03-27 Thread Thomas Gleixner
On Wed, 27 Mar 2019, Andi Kleen wrote: > On Wed, Mar 27, 2019 at 03:20:08PM +0100, Thomas Gleixner wrote: > > /* Simple instruction patching code. */ > > -#define NATIVE_LABEL(a,x,b) "\n\t.globl " a #x "_" #b "\n" a #x "_" #b > > ":\n\t" > > +#define NATIVE_LABEL(a,x,b) "\n" a #x "_" #b ":\n\t" >

Re: [PATCH 3.18 132/134] rcu: Do RCU GP kthread self-wakeup from softirq and interrupt

2019-03-27 Thread Paul E. McKenney
Hello, Jun, Do you see the same hang without the patch? Thanx, Paul On Wed, Mar 27, 2019 at 01:50:57AM +, Zhang, Jun wrote: > Hello,Paul > > I use a new NUC (made in 2017) to test, meet the same hang. System run very > slowly. > > Bu

[PATCH] clk: meson: vid-pll-div: remove warning and return 0 on invalid config

2019-03-27 Thread Neil Armstrong
The vid_pll_div is a programmable fractional divider, but vendor gives a limited of known configuration value and it's corresponding fraction. Thus when at reset value (0) or unknown value, we cannot determine the result rate. The initial behaviour was to print a warning, but the warning triggers

[PATCH v2 RESEND] x86: modernize sync_bitops.h

2019-03-27 Thread Jan Beulich
Add missing insn suffixes and use rmwcc.h just like was (more or less) recently done for bitops.h as well. Signed-off-by: Jan Beulich --- v2: Re-base over rmwcc.h changes. --- arch/x86/include/asm/sync_bitops.h | 31 +-- 1 file changed, 9 insertions(+), 22 deletions

Re: [PATCH v4 0/2] Add IPROC PCIe new features

2019-03-27 Thread Srinath Mannam
Hi Lorenzo, Thanks for feedback, I will talk to our HW engineer. Regards, Srinath. On Wed, Mar 27, 2019 at 6:01 PM Lorenzo Pieralisi wrote: > > On Wed, Mar 27, 2019 at 02:08:46PM +0530, Srinath Mannam wrote: > > Hi Lorenzo/Bjorn, > > > > Could you please help to review this patch series when yo

Re: [PATCH] watchdog: Respect watchdog cpumask on CPU hotplug

2019-03-27 Thread Oleg Nesterov
On 03/26, Thomas Gleixner wrote: > > The rework of the watchdog core to use cpu_stop_work broke the watchdog > cpumask on CPU hotplug. > > The watchdog_enable/disable() functions are now called unconditionally from > the hotplug callback, i.e. even on CPUs which are not in the watchdog > cpumask. >

Re: WARNING in arch_install_hw_breakpoint

2019-03-27 Thread Borislav Petkov
On Wed, Mar 27, 2019 at 02:45:24PM +0100, Dmitry Vyukov wrote: > And run this program: > https://syzkaller.appspot.com/text?tag=ReproC&x=15439f2720 Yap, that worked in my guest, after segfaulting a lot first: [ 101.600512][ T7333] Code: Bad RIP value. [ 101.606103][ T7337] repro[7337]: segf

Re: possible deadlock in acct_pin_kill

2019-03-27 Thread syzbot
Hello, syzbot has tested the proposed patch and the reproducer did not trigger crash: Reported-and-tested-by: syzbot+2a73a6ea9507b7112...@syzkaller.appspotmail.com Tested on: commit: 6c66f635 kernel/acct.c: fix locking order when switching a.. git tree: https://github.com/a

Re: [PATCH -next] selinux: Make selinux_kernfs_init_security static

2019-03-27 Thread Mukesh Ojha
On 3/22/2019 7:34 PM, Yue Haibing wrote: From: YueHaibing Fix sparse warning: security/selinux/hooks.c:3389:5: warning: symbol 'selinux_kernfs_init_security' was not declared. Should it be static? Signed-off-by: YueHaibing Reviewed-by: Mukesh Ojha -Mukesh --- security/selinux/hooks

Re: [PATCH] arm:mach-sa1100/hackkit.c : Remove duplicate header

2019-03-27 Thread Mukesh Ojha
On 3/28/2019 12:41 AM, jagdsh.li...@gmail.com wrote: From: Jagadeesh Pagadala Remove duplicate header which is included twice. Signed-off-by: Jagadeesh Pagadala Reviewed-by: Mukesh Ojha -Mukesh --- arch/arm/mach-sa1100/hackkit.c | 1 - 1 file changed, 1 deletion(-) diff --git a/a

Re: [PATCH v2 1/6] leds: netdev trigger: use memcpy in device_name_store

2019-03-27 Thread Rasmus Villemoes
On 26/03/2019 20.53, Jacek Anaszewski wrote: > Hi Rasmus, > > Thank you for the patch. > > On 3/14/19 3:06 PM, Rasmus Villemoes wrote: >> If userspace doesn't end the input with a newline (which can easily >> happen if the write happens from a C program that does write(fd, >> iface, strlen(iface)

Re: [PATCH 05/25] coresight: Merge the static and dynamic replicator drivers

2019-03-27 Thread Mathieu Poirier
On Wed, Mar 20, 2019 at 06:49:22PM +, Suzuki K Poulose wrote: > Merge the drivers for the two varieties of replicators into > a singel one. The dynamic replicator has programming base > which can be programmed to filter the trace data. The driver > detects the type based on the "base" address v

Re: Linux 5.0-ad1: -march=native support

2019-03-27 Thread Pavel Machek
On Mon 2019-03-04 20:19:16, Alexey Dobriyan wrote: > -ad1 patchset adds support for compiling kernel with "-march=native" > compiler option optimizing kernel for the specific CPU. "-march=native" > has been available in userspace for a long time and is trivial to enable > in Gentoo specifically. >

<    1   2   3   4   5   6   7   8   9   10   >