Threaded onto this email are a few dozen defective F: patterns
and the commits that introduced the patterns and if found,
commits that either renamed or deleted the files that match the
pattern.
There's no good way to script a fix for these defective patterns
so I trust the appropriate maintainers
On Wed, 13 Feb 2019 01:12:44 +0900
Masami Hiramatsu wrote:
> Prohibit probing on IRQ handlers in irqentry_text because
> if it interrupts user mode, at that point we haven't changed
> to kernel space yet and which eventually leads a double fault.
> E.g.
>
> # echo p apic_timer_interrupt > kprob
On 24/03/2019 23.32, Sultan Alsawaf wrote:
> On Sun, Mar 24, 2019 at 10:17:49PM +0100, Rasmus Villemoes wrote:
>> gcc already knows the semantics of these functions and can optimize
>> accordingly. E.g. for strcpy() of a literal to a buffer, gcc readily
>> compiles
>
> The example you gave appears
A file pattern line in this section of the MAINTAINERS file in linux-next
does not have a match in the linux source files.
This could occur because a matching filename was never added, was deleted
or renamed in some other commit.
The commits that added and if found renamed or removed the file pat
A file pattern line in this section of the MAINTAINERS file in linux-next
does not have a match in the linux source files.
This could occur because a matching filename was never added, was deleted
or renamed in some other commit.
The commits that added and if found renamed or removed the file pat
A file pattern line in this section of the MAINTAINERS file in linux-next
does not have a match in the linux source files.
This could occur because a matching filename was never added, was deleted
or renamed in some other commit.
The commits that added and if found renamed or removed the file pat
A file pattern line in this section of the MAINTAINERS file in linux-next
does not have a match in the linux source files.
This could occur because a matching filename was never added, was deleted
or renamed in some other commit.
The commits that added and if found renamed or removed the file pat
A file pattern line in this section of the MAINTAINERS file in linux-next
does not have a match in the linux source files.
This could occur because a matching filename was never added, was deleted
or renamed in some other commit.
The commits that added and if found renamed or removed the file pat
A file pattern line in this section of the MAINTAINERS file in linux-next
does not have a match in the linux source files.
This could occur because a matching filename was never added, was deleted
or renamed in some other commit.
The commits that added and if found renamed or removed the file pat
A file pattern line in this section of the MAINTAINERS file in linux-next
does not have a match in the linux source files.
This could occur because a matching filename was never added, was deleted
or renamed in some other commit.
The commits that added and if found renamed or removed the file pat
A file pattern line in this section of the MAINTAINERS file in linux-next
does not have a match in the linux source files.
This could occur because a matching filename was never added, was deleted
or renamed in some other commit.
The commits that added and if found renamed or removed the file pat
A file pattern line in this section of the MAINTAINERS file in linux-next
does not have a match in the linux source files.
This could occur because a matching filename was never added, was deleted
or renamed in some other commit.
The commits that added and if found renamed or removed the file pat
A file pattern line in this section of the MAINTAINERS file in linux-next
does not have a match in the linux source files.
This could occur because a matching filename was never added, was deleted
or renamed in some other commit.
The commits that added and if found renamed or removed the file pat
uuid in add_switch is allocted via kmemdup which can fail. The patch
logs the error and cleans up the allocated memory for switch.
Signed-off-by: Aditya Pakki
---
v2: replace WARN_ONCE with tb_sw_warn, as suggested by Mika
v1: Change warn_once to return after clean up.
---
drivers/thunderbolt/i
A file pattern line in this section of the MAINTAINERS file in linux-next
does not have a match in the linux source files.
This could occur because a matching filename was never added, was deleted
or renamed in some other commit.
The commits that added and if found renamed or removed the file pat
A file pattern line in this section of the MAINTAINERS file in linux-next
does not have a match in the linux source files.
This could occur because a matching filename was never added, was deleted
or renamed in some other commit.
The commits that added and if found renamed or removed the file pat
A file pattern line in this section of the MAINTAINERS file in linux-next
does not have a match in the linux source files.
This could occur because a matching filename was never added, was deleted
or renamed in some other commit.
The commits that added and if found renamed or removed the file pat
A file pattern line in this section of the MAINTAINERS file in linux-next
does not have a match in the linux source files.
This could occur because a matching filename was never added, was deleted
or renamed in some other commit.
The commits that added and if found renamed or removed the file pat
On Mon, 25 Mar 2019, Borislav Petkov wrote:
> On Sun, Mar 24, 2019 at 05:23:27PM -0700, Paul Walmsley wrote:
> > > + if (!IS_ENABLED(CONFIG_EDAC_DEBUG))
> > > + return;
> >
> > Can all of these debugfs functions be wrapped with an #if ... #endif such
> > that, if CONFIG_EDAC_DEBUG is not
> -Original Message-
> From: Alex Williamson
> Sent: Monday, March 25, 2019 2:50 PM
> To: Kirti Wankhede
> Cc: Parav Pandit ; k...@vger.kernel.org; linux-
> ker...@vger.kernel.org
> Subject: Re: [PATCH 4/8] vfio/mdev: Drop redundant extern for exported
> symbols
>
> On Tue, 26 Mar 201
A file pattern line in this section of the MAINTAINERS file in linux-next
does not have a match in the linux source files.
This could occur because a matching filename was never added, was deleted
or renamed in some other commit.
The commits that added and if found renamed or removed the file pat
A file pattern line in this section of the MAINTAINERS file in linux-next
does not have a match in the linux source files.
This could occur because a matching filename was never added, was deleted
or renamed in some other commit.
The commits that added and if found renamed or removed the file pat
A file pattern line in this section of the MAINTAINERS file in linux-next
does not have a match in the linux source files.
This could occur because a matching filename was never added, was deleted
or renamed in some other commit.
The commits that added and if found renamed or removed the file pat
A file pattern line in this section of the MAINTAINERS file in linux-next
does not have a match in the linux source files.
This could occur because a matching filename was never added, was deleted
or renamed in some other commit.
The commits that added and if found renamed or removed the file pat
A file pattern line in this section of the MAINTAINERS file in linux-next
does not have a match in the linux source files.
This could occur because a matching filename was never added, was deleted
or renamed in some other commit.
The commits that added and if found renamed or removed the file pat
A file pattern line in this section of the MAINTAINERS file in linux-next
does not have a match in the linux source files.
This could occur because a matching filename was never added, was deleted
or renamed in some other commit.
The commits that added and if found renamed or removed the file pat
A file pattern line in this section of the MAINTAINERS file in linux-next
does not have a match in the linux source files.
This could occur because a matching filename was never added, was deleted
or renamed in some other commit.
The commits that added and if found renamed or removed the file pat
A file pattern line in this section of the MAINTAINERS file in linux-next
does not have a match in the linux source files.
This could occur because a matching filename was never added, was deleted
or renamed in some other commit.
The commits that added and if found renamed or removed the file pat
A file pattern line in this section of the MAINTAINERS file in linux-next
does not have a match in the linux source files.
This could occur because a matching filename was never added, was deleted
or renamed in some other commit.
The commits that added and if found renamed or removed the file pat
A file pattern line in this section of the MAINTAINERS file in linux-next
does not have a match in the linux source files.
This could occur because a matching filename was never added, was deleted
or renamed in some other commit.
The commits that added and if found renamed or removed the file pat
A file pattern line in this section of the MAINTAINERS file in linux-next
does not have a match in the linux source files.
This could occur because a matching filename was never added, was deleted
or renamed in some other commit.
The commits that added and if found renamed or removed the file pat
A file pattern line in this section of the MAINTAINERS file in linux-next
does not have a match in the linux source files.
This could occur because a matching filename was never added, was deleted
or renamed in some other commit.
The commits that added and if found renamed or removed the file pat
A file pattern line in this section of the MAINTAINERS file in linux-next
does not have a match in the linux source files.
This could occur because a matching filename was never added, was deleted
or renamed in some other commit.
The commits that added and if found renamed or removed the file pat
A file pattern line in this section of the MAINTAINERS file in linux-next
does not have a match in the linux source files.
This could occur because a matching filename was never added, was deleted
or renamed in some other commit.
The commits that added and if found renamed or removed the file pat
A file pattern line in this section of the MAINTAINERS file in linux-next
does not have a match in the linux source files.
This could occur because a matching filename was never added, was deleted
or renamed in some other commit.
The commits that added and if found renamed or removed the file pat
A file pattern line in this section of the MAINTAINERS file in linux-next
does not have a match in the linux source files.
This could occur because a matching filename was never added, was deleted
or renamed in some other commit.
The commits that added and if found renamed or removed the file pat
> -Original Message-
> From: Kirti Wankhede
> Sent: Monday, March 25, 2019 2:18 PM
> To: Parav Pandit ; k...@vger.kernel.org; linux-
> ker...@vger.kernel.org; alex.william...@redhat.com
> Subject: Re: [PATCH 5/8] vfio/mdev: Avoid masking error code to EBUSY
>
>
>
> On 3/23/2019 4:50 A
> -Original Message-
> From: Alex Williamson
> Sent: Monday, March 25, 2019 3:21 PM
> To: Parav Pandit
> Cc: k...@vger.kernel.org; linux-kernel@vger.kernel.org;
> kwankh...@nvidia.com
> Subject: Re: [PATCH 6/8] vfio/mdev: Follow correct remove sequence
>
> On Fri, 22 Mar 2019 18:20:33
In case __get_free_pages fail, the fix returns -ENOMEMto avoid
NULL pointer dereference.
Signed-off-by: Kangjie Lu
Reviewed-by: Steven Price
---
v2: caller is redefined to accept the error code, as suggested by
Steven Price
---
drivers/pci/controller/pcie-xilinx.c | 12 ++--
1 file cha
On Mon, Mar 25, 2019 at 7:48 AM Jarkko Sakkinen
wrote:
>
> Allow trusted.ko to initialize w/o a TPM. This commit adds checks to the
> key type callbacks and exported functions to fail when a TPM is not
> available.
>
> Cc: Dan Williams
Reported-and-tested-by: Dan Williams
Thanks Jarkko!
> -Original Message-
> From: Alex Williamson
> Sent: Monday, March 25, 2019 3:50 PM
> To: Kirti Wankhede
> Cc: Parav Pandit ; k...@vger.kernel.org; linux-
> ker...@vger.kernel.org
> Subject: Re: [PATCH 7/8] vfio/mdev: Fix aborting mdev child device removal if
> one fails
>
> On Tue, 2
> -Original Message-
> From: Maxim Levitsky
> Sent: Monday, March 25, 2019 8:24 AM
> To: Parav Pandit ; k...@vger.kernel.org; linux-
> ker...@vger.kernel.org; kwankh...@nvidia.com;
> alex.william...@redhat.com
> Subject: Re: [PATCH 8/8] vfio/mdev: Improve the create/remove sequence
>
>
On Mon, Mar 25, 2019 at 10:19:26PM +0100, Jann Horn wrote:
> On Mon, Mar 25, 2019 at 10:11 PM Joel Fernandes
> wrote:
> > On Mon, Mar 25, 2019 at 09:15:45PM +0100, Christian Brauner wrote:
> > > On Mon, Mar 25, 2019 at 01:36:14PM -0400, Joel Fernandes wrote:
> > > > On Mon, Mar 25, 2019 at 09:48:
On Mon, Mar 25, 2019 at 2:36 PM Aditya Pakki wrote:
>
> In case kmemdup fails, the fix releases resources and returns to
> avoid the NULL pointer dereference.
>
> Signed-off-by: Aditya Pakki
>
> ---
> v2: Replace incorrect kfree with ida_simple_remove, suggested by
> Johannes Thumshirn
> v1: Free
On Mon, Mar 25, 2019 at 2:14 PM Al Viro wrote:
>
> Maybe, but we really need to come up with sane documentation on the
> entire drop_inode/evict_inode/destroy_inode/rcu_destroy_inode
> group ;-/
Yeah.
I actually think the "destroy_inode/rcu_destroy_inode" part is the
simplest one to understand:
> -Original Message-
> From: Frederic Barrat
> Sent: Tuesday, 26 March 2019 4:34 AM
> To: Greg Kurz ; Alastair D'Silva
> Cc: alast...@d-silva.org; Arnd Bergmann ; Greg Kroah-
> Hartman ; linux-kernel@vger.kernel.org;
> Andrew Donnellan ; linuxppc-
> d...@lists.ozlabs.org
> Subject: Re: [P
On Mon, Mar 25, 2019 at 02:18:39PM -0700, Paul Walmsley wrote:
> All of these drivers are for single IP blocks. Mostly DRAM controllers.
> There's no "platform EDAC manager" IP block in these cases.
Maybe because they have RAS functionality in one single IP block. Others
like altera_edac, for exa
On Mon, Mar 25, 2019 at 2:13 PM Sudip Mukherjee
wrote:
>
> We do not need to search for ports and bind the initial list of ports
> to daisy driver as daisy driver is always the first driver to use the
> new found parport and we know when the parport bus is registering the
> list of parport will al
On Tue, 19 Feb 2019 18:01:54 +0100, Alexandre Belloni wrote:
> Remove the need for child nodes in the sckc binding to be able to remove
> dtc warnings and have a more modern binding.
>
> Also document optional properties.
>
> Cc: Rob Herring
> Signed-off-by: Alexandre Belloni
> ---
> .../devic
On Mon, Mar 25, 2019 at 02:26:52PM -0700, Paul Walmsley wrote:
> We'll definitely take the RAM savings that a few #ifdefs will deliver to
> us. They add up. We're selling chips for embedded use cases, not just
> big-iron x86 systems.
Fair enough.
Btw, while we're at it, this driver would need
On 3/22/19 11:03 PM, Zi Yan wrote:
On 22 Mar 2019, at 21:44, Yang Shi wrote:
Since PMEM provides larger capacity than DRAM and has much lower
access latency than disk, so it is a good choice to use as a middle
tier between DRAM and disk in page reclaim path.
With PMEM nodes, the demotion pa
Hi Kangjie,
Thanks for the patch!
Please update the subject line like this:
PCI: xilinx: Check for __get_free_pages() failure
You can always get a good idea of the style for subject lines by doing
something like this:
git log --oneline --follow drivers/pci/controller/pcie-xilinx.c
On Mon,
On Mon, 25 Mar 2019 21:36:42 +
Parav Pandit wrote:
> > -Original Message-
> > From: Alex Williamson
> > Sent: Monday, March 25, 2019 3:50 PM
> > To: Kirti Wankhede
> > Cc: Parav Pandit ; k...@vger.kernel.org; linux-
> > ker...@vger.kernel.org
> > Subject: Re: [PATCH 7/8] vfio/mdev:
On Mon, 25 Mar 2019 21:13:25 +
Sudip Mukherjee wrote:
> Some distros like Suse has an alias for "parport_lowlevel" and that
> alias points to "parport_pc". Now when the parport bus registers, it
> also initialises the daisy driver as the daisy driver is needed to
> check the port when the por
On Tue, 26 Mar 2019 00:07:44 +0300 Yury Norov wrote:
> --- a/lib/bitmap.c
> +++ b/lib/bitmap.c
> @@ -477,6 +477,42 @@ int bitmap_print_to_pagebuf(bool list, char *buf, const
> unsigned long *maskp,
> }
> EXPORT_SYMBOL(bitmap_print_to_pagebuf);
>
> +/*
> + * Region 9-38:4/10 describes the fol
On Mon, Mar 25, 2019 at 9:43 PM Joel Fernandes wrote:
>
> On Mon, Mar 25, 2019 at 10:19:26PM +0100, Jann Horn wrote:
> > On Mon, Mar 25, 2019 at 10:11 PM Joel Fernandes
> > wrote:
> >
> > But often you don't just want to wait for a single thing to happen;
> > you want to wait for many things at
In case kmemdup fails, the fix releases resources and returns to
avoid the NULL pointer dereference.
Signed-off-by: Aditya Pakki
---
v3: Move kfree(nd_btt) to goto block.
v2: Replace incorrect kfree with ida_simple_remove, suggested by
Johannes Thumshirn
v1: Free nd_btt->id in case of failure an
The include/linux/selinux.h file has been removed.
Remove the entry from the MAINTAINERS file.
Signed-off-by: Casey Schaufler
---
MAINTAINERS | 1 -
1 file changed, 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 3e5a5d263f29..1039c34dff3c 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
Hi all,
Here are some ti-sysc interconnect target module changes that allow
dropping legacy platform data for many devices in favor of devicetree
provided data.
This series depends on patch series "[PATCH 0/7] omap changes to
allocate struct omap_hwmod dynamically".
I'll be posting patches separ
If we return early before ddata->clocks have been allocated we will get a
NULL pointer dereference in sysc_unprepare(). Let's fix this by returning
early when no clocks are allocated.
Fixes: 0eecc636e5a2 ("bus: ti-sysc: Add minimal TI sysc interconnect target
driver")
Signed-off-by: Tony Lindgren
Let's move the legacy idle and enable into separate functions to simplify
PM runtime functions a bit.
Signed-off-by: Tony Lindgren
---
drivers/bus/ti-sysc.c | 78 +++
1 file changed, 50 insertions(+), 28 deletions(-)
diff --git a/drivers/bus/ti-sysc.c b/d
We should not do the reset until the clocks are enabled. Let's only init
restctrl in sysc_init_resets() and do the reset later on in sysc_reset().
Signed-off-by: Tony Lindgren
---
drivers/bus/ti-sysc.c | 61 ++-
1 file changed, 37 insertions(+), 24 deletio
We already have the clockactivity quirk set for some modules like i2c,
timers and smartreflex. But we're not passing it to the platform functions
yet. Let's start doing that in preparation of dropping interconnect target
module platform data in favor of device tree based data.
Signed-off-by: Tony
At least McPDM module depends on an external optional clock to be
usable. To make handling of the McPDM clock easier in the following
patches, let's add separate functions for handling the main clocks
and the optional clocks.
Let's also add error handling to shut down already enabled clocks
while
We are currently not managing interconnect target module clocks in the
for legacy platform data based case. This causes a problem for using the
platform data based functions when dropping the platform data for the
interconnect target module configuration.
To avoid a situation where we need to popu
In preparation of dropping interconnect target module platform data in
favor of devicetree based data, we must pass swsup idle quirks to the
platform data functions.
For now, let's only tag the UART modules with the SWSUP_SIDLE_ACT quirk.
The other modules will get tagged with swsup quirks as we d
Detect DMIC to see what we have connected if config DEBUG is enabled.
Signed-off-by: Tony Lindgren
---
drivers/bus/ti-sysc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c
--- a/drivers/bus/ti-sysc.c
+++ b/drivers/bus/ti-sysc.c
@@ -999,6 +999,7
We cannot access mcpdm registers at all unless there is an optional pdmclk
configured. As this is currently only needed for mcpdm, let's check for
mcpdm in sysc_get_clocks(). If it turns out to be needed for other modules
too, we can add more flags to the quirks table for this.
Signed-off-by: Tony
At least mcpdm needs an optional external clock enabled to function and
this clock typically comes from the PMIC. We can detect mcpdm based on
the interconnect target module address and set a quirk flag early.
To do this, let's initialize the clocks a bit later and add a new
function for sysc_init
We can make sysc_write() and sysc_child_pm_domain static as noted by
sparse.
Signed-off-by: Tony Lindgren
---
drivers/bus/ti-sysc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c
--- a/drivers/bus/ti-sysc.c
+++ b/drivers/bus/
Hi Bjorn,
On 3/25/19 8:42 PM, Bjorn Helgaas wrote:
> From: Bjorn Helgaas
>
> Use dev_printk() when possible to make messages consistent with other
> device-related messages>
> Signed-off-by: Bjorn Helgaas
> ---
> drivers/vfio/pci/vfio_pci.c | 8 ++---
> drivers/vfio/pci/vfio_
The platform data based init functions typically reset the interconnect
target module configure the registers. As we may need the interconnect
target module specific quirks configured based on the revision register,
we want to move the platform data based init to happen later.
Let's allocate mdata
The first thing we want to do is just read the module revision register to
be able to configure the module specific quirks and configure the module
registers.
As the interconnect target module may not yet be properly configured and
may need a reset first, we don't want to use pm_runtime_get() at t
We have ti,no-idle in use in addition to ti,no-idle-on-init but we're
missing handling for it in the ti-sysc interconnect target module driver.
Let's also group the idle defines together and update the binding
documentation for it.
Cc: Rob Herring
Cc: devicet...@vger.kernel.org
Signed-off-by: To
On Mon, Mar 25, 2019 at 10:33:33AM -0600, Jonathan Corbet wrote:
> On Fri, 8 Mar 2019 08:11:44 +1100
> "Tobin C. Harding" wrote:
>
> > I had a few hours to spare so I thought I'd clear some Sphinx build
> > warnings/errors.
>
> So there were comments on various parts of this series; were you pl
On Mon, Mar 25, 2019 at 06:27:52PM +, James Morse wrote:
> or even:
> | compatible = "microsoft,product-name-dmc520", "arm,dmc-520";
> if there is some firmware/board configuration that means vendor/soc isn't
> precise enough.
Yap, makes sense to me. If dmc-520 is a memory controller IP, then
On Mon, 2019-03-25 at 14:58 -0700, Casey Schaufler wrote:
> The include/linux/selinux.h file has been removed.
> Remove the entry from the MAINTAINERS file.
This looks like it doesn't apply correctly as there
are one too many spaces before each context lines.
> Signed-off-by: Casey Schaufler
> -
On Mon, Mar 25, 2019 at 09:42:53AM -0700, Paul E. McKenney wrote:
> On Mon, Mar 25, 2019 at 12:33:37PM -0400, Joel Fernandes wrote:
> > On Mon, Mar 25, 2019 at 11:02 AM Paul E. McKenney
> > wrote:
> > >
> > > On Fri, Mar 22, 2019 at 11:46:19PM -0400, Joel Fernandes (Google) wrote:
> > > > The rcu
On Wed, 20 Feb 2019 12:26:04 +0100, Alexandre Belloni wrote:
> Add SAM9X60 PMC compatible string.
>
> Cc: Rob Herring
> Signed-off-by: Alexandre Belloni
> ---
> Documentation/devicetree/bindings/clock/at91-clock.txt | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
Reviewed-by: Rob
On 3/23/19 12:02 PM, Thomas Gleixner wrote:
Ralph,
On Mon, 18 Mar 2019, rcampb...@nvidia.com wrote:
From: Ralph Campbell
If CONFIG_DEBUG_VIRTUAL is enabled, a read or write to /dev/mem can
trigger a VIRTUAL_BUG_ON() depending on the value of high_memory.
For example:
read_mem()
valid_ph
On 03/25/2019 10:45 PM, Linus Torvalds wrote:
> On Mon, Mar 25, 2019 at 2:14 PM Al Viro wrote:
>>
>> Maybe, but we really need to come up with sane documentation on the
>> entire drop_inode/evict_inode/destroy_inode/rcu_destroy_inode
>> group ;-/
>
> Yeah.
>
> I actually think the "destroy_inode
On Mon, Mar 25, 2019 at 2:55 PM Jonathan Kowalski wrote:
>
> On Mon, Mar 25, 2019 at 9:43 PM Joel Fernandes wrote:
> >
> > On Mon, Mar 25, 2019 at 10:19:26PM +0100, Jann Horn wrote:
> > > On Mon, Mar 25, 2019 at 10:11 PM Joel Fernandes
> > > wrote:
> > >
> > > But often you don't just want to w
On Sun, Mar 24, 2019 at 11:30 AM Alex Xu (Hello71) wrote:
>
> I get this BUG in 5.1-rc1 sometimes when powering off the machine. I
> suspect my setup erroneously executes two swapoff+cryptsetup close
> operations simultaneously, so a race condition is triggered.
>
> I am using a single swap on a p
Hi Alex,
> -Original Message-
> From: Alex Williamson
> Sent: Monday, March 25, 2019 4:52 PM
> To: Parav Pandit
> Cc: Kirti Wankhede ; k...@vger.kernel.org; linux-
> ker...@vger.kernel.org
> Subject: Re: [PATCH 7/8] vfio/mdev: Fix aborting mdev child device removal if
> one fails
>
> On
From: David Howells
If the kernel is locked down, require that all modules have valid
signatures that we can verify.
I have adjusted the errors generated:
(1) If there's no signature (ENODATA) or we can't check it (ENOPKG,
ENOKEY), then:
(a) If signatures are enforced then EKEYREJEC
From: Matthew Garrett
Allowing users to read and write to core kernel memory makes it possible
for the kernel to be subverted, avoiding module loading restrictions, and
also to steal cryptographic information.
Disallow /dev/mem and /dev/kmem from being opened this when the kernel has
been locked
The following changes since commit 468e91cecb3218afd684b8c422490dfebe0691bb:
keys: fix missing __user in KEYCTL_PKEY_QUERY (2019-03-04 15:48:37 -0800)
are available in the Git repository at:
https://github.com/mjg59/linux lock_down
for you to fetch changes up to 1c57935ab108280aa79fe4420d4b
Systems in lockdown mode should block the kexec of untrusted kernels.
For x86 and ARM we can ensure that a kernel is trustworthy by validating
a PE signature, but this isn't possible on other architectures. On those
platforms we can use IMA digital signatures instead. Add a function to
determine wh
From: David Howells
Prohibit replacement of the PCMCIA Card Information Structure when the
kernel is locked down.
Suggested-by: Dominik Brodowski
Signed-off-by: David Howells
cc: linux-pcm...@lists.infradead.org
Signed-off-by: Matthew Garrett
---
drivers/pcmcia/cistpl.c | 3 +++
1 file chang
From: David Howells
Disallow access to /proc/kcore when the kernel is locked down to prevent
access to cryptographic data.
Signed-off-by: David Howells
Reviewed-by: James Morris
Signed-off-by: Matthew Garrett
---
fs/proc/kcore.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/proc/k
From: Matthew Garrett
Writing to MSRs should not be allowed if the kernel is locked down, since
it could lead to execution of arbitrary code in kernel mode. Based on a
patch by Kees Cook.
MSR accesses are logged for the purposes of building up a whitelist as per
Alan Cox's suggestion.
Signed-o
From: Linn Crosetto
>From the kernel documentation (initrd_table_override.txt):
If the ACPI_INITRD_TABLE_OVERRIDE compile option is true, it is possible
to override nearly any ACPI table provided by the BIOS with an
instrumented, modified one.
When securelevel is set, the kernel should di
From: Josh Boyer
There is currently no way to verify the resume image when returning
from hibernate. This might compromise the signed modules trust model,
so until we can work with signed hibernate images we disable it when the
kernel is locked down.
Signed-off-by: Josh Boyer
Signed-off-by: Da
From: David Howells
There are some bpf functions can be used to read kernel memory:
bpf_probe_read, bpf_probe_write_user and bpf_trace_printk. These allow
private keys in kernel memory (e.g. the hibernation image signing key) to
be read by an eBPF program and kernel memory to be altered without
From: David Howells
Print the content of current->comm in messages generated by lockdown to
indicate a restriction that was hit. This makes it a bit easier to find
out what caused the message.
The message now patterned something like:
Lockdown: : is restricted; see man kernel_lockdown
From: David Howells
Disallow the use of certain perf facilities that might allow userspace to
access kernel data.
Signed-off-by: David Howells
Signed-off-by: Matthew Garrett
Cc: Peter Zijlstra
Cc: Ingo Molnar
Cc: Arnaldo Carvalho de Melo
---
kernel/events/core.c | 5 +
1 file changed,
On Thu, Mar 21, 2019 at 6:23 PM Frank Rowand wrote:
>
> On 3/4/19 3:01 PM, Brendan Higgins wrote:
> > On Thu, Feb 14, 2019 at 1:38 PM Brendan Higgins
< snip >
> > Someone suggested I should send the next revision out as "PATCH"
> > instead of "RFC" since there seems to be general consensus about
>
From: Linn Crosetto
ACPI provides an error injection mechanism, EINJ, for debugging and testing
the ACPI Platform Error Interface (APEI) and other RAS features. If
supported by the firmware, ACPI specification 5.0 and later provide for a
way to specify a physical memory address to which to injec
From: David Howells
The testmmiotrace module shouldn't be permitted when the kernel is locked
down as it can be used to arbitrarily read and write MMIO space.
Suggested-by: Thomas Gleixner
Signed-off-by: David Howells
cc: Steven Rostedt
cc: Ingo Molnar
cc: "H. Peter Anvin"
cc: x...@kernel.o
From: David Howells
Disallow opening of debugfs files that might be used to muck around when
the kernel is locked down as various drivers give raw access to hardware
through debugfs. Given the effort of auditing all 2000 or so files and
manually fixing each one as necessary, I've chosen to apply
801 - 900 of 1175 matches
Mail list logo