Re: [PATCH v9 0/9] freezer for cgroup v2

2019-03-25 Thread Roman Gushchin
Hello, Oleg! Can you, please, take a look at the latest version of the patchset? I'd really appreciate it! Thank you! Roman On Sat, Mar 16, 2019 at 10:58:03AM -0700, Roman Gushchin wrote: > This patchset implements freezer for cgroup v2. > > It provides similar functionality as v1 freezer, but

[PATCH V2 0/2] spi: stm32-qspi: add dma support

2019-03-25 Thread Ludovic Barre
From: Ludovic Barre This patch series adds dma support for the stm32-qspi. In read mode, the memory map is preferred vs dma (due to better throughput). If the dma transfer fails the buffer is sent by polling. V2: -fixe build error in patch 1/2 (move qspi->phys_base in patch 2) Ludovic Barre (2)

[PATCH V2 1/2] spi: stm32-qspi: add spi_master_put in release function

2019-03-25 Thread Ludovic Barre
From: Ludovic Barre This patch adds spi_master_put in release function to drop the controller's refcount. Signed-off-by: Ludovic Barre --- drivers/spi/spi-stm32-qspi.c | 46 +++- 1 file changed, 28 insertions(+), 18 deletions(-) diff --git a/drivers/spi

[PATCH v2] platform/chrome: mfd/cros_ec_sysfs: Add sysfs entry to retrieve EC uptime.

2019-03-25 Thread twawrzynczak
From: Tim Wawrzynczak The new sysfs entry 'uptime' is being made available to userspace so that a userspace daemon can synchronize EC logs with host time. Signed-off-by: Tim Wawrzynczak --- Enric, the use case for this is ChromeOS's userspace daemon, timberslide, which collects the EC logs for

[PATCH V2 2/2] spi: stm32-qspi: add dma support

2019-03-25 Thread Ludovic Barre
From: Ludovic Barre This patch adds the dma support for the stm32-qspi hardware. The memory buffer constraints (lowmem, vmalloc, kmap) are taken into account by framework. In read mode, the memory map is preferred vs dma (due to better throughput). If the dma transfer fails the buffer is sent by

Re: [RFC PATCH v2 1/5] mtd: cfi_cmdset_0002: Add support for polling status register

2019-03-25 Thread Vignesh Raghavendra
On 25/03/19 7:21 PM, Joakim Tjernlund wrote: > On Mon, 2019-03-25 at 18:27 +0530, Vignesh Raghavendra wrote: >> CAUTION: This email originated from outside of the organization. Do not >> click links or open attachments unless you recognize the sender and know the >> content is safe. >> >> >> H

Re: [kernfs] e19dfdc83b: BUG:KASAN:global-out-of-bounds_in_s

2019-03-25 Thread Ondrej Mosnacek
On Mon, Mar 25, 2019 at 4:17 PM Paul Moore wrote: > Ondrej, please look into this. > > You've looked at this code more recently than I have, but it looks > like there might be an issue with __kernfs_iattrs() returning a > pointer to a kernfs_iattrs object without taking a kernfs reference > (kernf

Re: "cat /proc/lockdep" after "rmmod " when !debug_locks will crash the system

2019-03-25 Thread Bart Van Assche
On Mon, 2019-03-25 at 17:45 +0800, shenghui wrote: > I installed virtualbox-5.2.24 on my system (x86 32) and on bootup I got some > warning: > - > 1251 [ 42.640869] DEBUG_LOCKS_WARN_ON(!current->hardirqs_enabled) > 1252 [ 42.640880] WARNING: CPU: 0 PID: 841 at kernel/lockin

Re: [PATCH 0/4] pid: add pidctl()

2019-03-25 Thread Daniel Colascione
On Mon, Mar 25, 2019 at 10:05 AM Konstantin Khlebnikov wrote: > On 25.03.2019 19:48, Daniel Colascione wrote: > > On Mon, Mar 25, 2019 at 9:21 AM Christian Brauner > > wrote: > >> The pidctl() syscalls builds on, extends, and improves translate_pid() [4]. > >> I quote Konstantins original patchs

Re: [PATCH v11 6/8] rtc: bd70528: Initial support for ROHM bd70528 RTC

2019-03-25 Thread Alexandre Belloni
On 25/03/2019 14:06:42+0200, Matti Vaittinen wrote: > Support RTC block in ROHM bd70528 power management IC. Support > getting and setting the time and date as well as arming an alarm > which can also be used to wake the PMIC from standby state. > > HW supports wake interrupt only for the next 24

Re: [PATCH 0/4] pid: add pidctl()

2019-03-25 Thread Konstantin Khlebnikov
On 25.03.2019 19:48, Daniel Colascione wrote: On Mon, Mar 25, 2019 at 9:21 AM Christian Brauner wrote: The pidctl() syscalls builds on, extends, and improves translate_pid() [4]. I quote Konstantins original patchset first that has already been acked and picked up by Eric before and whose fu

[PATCH net-next v5 08/22] ethtool: support for netlink notifications

2019-03-25 Thread Michal Kubecek
Add infrastructure for ethtool netlink notifications. There is only one multicast group "monitor" which is used to notify userspace about changes. Notifications are supposed to be broadcasted on every configuration change, whether it is done using the netlink interface or legacy ioctl one. To trig

[PATCH net-next v5 06/22] ethtool: helper functions for netlink interface

2019-03-25 Thread Michal Kubecek
Various helpers used by ethtool netlink code. Signed-off-by: Michal Kubecek --- include/uapi/linux/ethtool_netlink.h | 11 ++ net/ethtool/netlink.c| 144 +++ net/ethtool/netlink.h| 144 +++ 3 files changed, 299 inse

[PATCH net-next v5 15/22] ethtool: provide link mode names as a string set

2019-03-25 Thread Michal Kubecek
Add table of ethernet link mode names and make it available as a string set to userspace GET_STRSET requests. Signed-off-by: Michal Kubecek --- include/linux/ethtool.h | 4 ++ include/uapi/linux/ethtool.h | 2 + net/ethtool/netlink.c| 81 net/e

Re: [PATCH 1/4] clk: meson: mpll: add init callback and regs

2019-03-25 Thread Stephen Boyd
Quoting Jerome Brunet (2019-03-25 04:11:57) > @@ -138,6 +129,27 @@ static int mpll_set_rate(struct clk_hw *hw, > return 0; > } > > +static void mpll_init(struct clk_hw *hw) > +{ > + struct clk_regmap *clk = to_clk_regmap(hw); > + struct meson_clk_mpll_data *mpll = meson_clk_m

Re: [PATCH] soc: amlogic: meson-gx-pwrc-vpu: Add support for G12A

2019-03-25 Thread Neil Armstrong
On 25/03/2019 18:07, Kevin Hilman wrote: > Neil Armstrong writes: > >> The Amlogic G12A SoC has a very similar VPU Power Controller setup >> than the older GXBB, GXL & GXm SoCs. >> >> This patch adds the variant support for G12A. >> >> Signed-off-by: Neil Armstrong > > This patch not only adds

Re: [PATCH] soc: amlogic: meson-gx-pwrc-vpu: Add support for G12A

2019-03-25 Thread Kevin Hilman
Neil Armstrong writes: > The Amlogic G12A SoC has a very similar VPU Power Controller setup > than the older GXBB, GXL & GXm SoCs. > > This patch adds the variant support for G12A. > > Signed-off-by: Neil Armstrong This patch not only adds support for G12A, but changes the functionality for GX

[PATCH net-next v5 02/22] netlink: introduce nla_put_bitfield32()

2019-03-25 Thread Michal Kubecek
Similar to other data types, this helper puts NLA_BITFIELD32 attribute into a netlink message. It takes separate value and selector arguments, if there is a struct nla_bitfield32 already, one can use nla_put(). Signed-off-by: Michal Kubecek --- include/net/netlink.h | 15 +++ 1 file

[PATCH net-next v5 03/22] netlink: add strict version of nla_parse_nested()

2019-03-25 Thread Michal Kubecek
Similar to nla_parse_strict() and nlmsg_parse_strict(), add also nla_parse_nested_strict() as a version of nla_parse_nested() with strict policy checking. Signed-off-by: Michal Kubecek --- include/net/netlink.h | 9 + 1 file changed, 9 insertions(+) diff --git a/include/net/netlink.h b/

Re: [PATCH v3] Documentation: acpi: Add an example for PRP0001

2019-03-25 Thread Andy Shevchenko
On Mon, Mar 25, 2019 at 04:53:38PM +, Thomas Preston wrote: > Add an example for the magic PRP0001 device ID which allows matching > ACPI devices against drivers using OF Device Tree compatible property. Thank you! Reviewed-by: Andy Shevchenko > > Signed-off-by: Thomas Preston > --- > Doc

Re: [RESEND] i2c: imx: defer probing on dma channel request

2019-03-25 Thread Steven Price
On 25/03/2019 15:30, laurentiu.tu...@nxp.com wrote: > From: Laurentiu Tudor > > If the dma controller is not yet probed, defer i2c probe. > The error path in probe was slightly modified (no functional change) There is a functional change for cases like: > ret = pm_runtime_get_sync(&pdev->

[PATCH 2/2] x86/kvm: Implement MSR_HWCR support

2019-03-25 Thread Borislav Petkov
From: Borislav Petkov The hardware configuration register has some useful bits which can be used by guests. Implement McStatusWrEn which can be used by guests when injecting MCEs with the in-kernel mce-inject module. For that, we need to set bit 18 - McStatusWrEn - first, before writing the MCi_

[PATCH v2] rtc: brcmstb-waketimer: switch to rtc_time64_to_tm

2019-03-25 Thread Alexandre Belloni
Call the 64bit version of rtc_time_to_tm as the range is enforced by the core. Signed-off-by: Alexandre Belloni --- drivers/rtc/rtc-brcmstb-waketimer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/rtc/rtc-brcmstb-waketimer.c b/drivers/rtc/rtc-brcmstb-waketimer.c i

Re: [PATCH 1/3] platform/chrome: wilco_ec: Split core and mailbox into separate modules

2019-03-25 Thread Enric Balletbo i Serra
Hi Nick, Thanks for the patch, some comments below. On 21/3/19 23:13, Nick Crews wrote: > It was bad design to lump the mailbox interface to the Wilco EC into the > same module as the code module, which loads all the subdrivers: Typo: s/code/core/? > - This required the sub-drivers to depend on

[PATCH v4 0/2] x86/kvm: Enable MCE injection in the guest

2019-03-25 Thread Borislav Petkov
From: Borislav Petkov Hi, so AFAIR this got applied before the merge window but it is not upstream. Very strange. So let me send it again, might get more lucky this time. Rebased ontop of 5.1-rc1. Please apply, thanks. Changelog: == v3: here's a rediff ontop of -rc2. No changes, onl

[PATCH 1/2] kvm/x86: Move MSR_K7_HWCR to svm.c

2019-03-25 Thread Borislav Petkov
From: Borislav Petkov This is an AMD-specific MSR. Put it where it belongs. Signed-off-by: Borislav Petkov Tested-by: Yazen Ghannam --- arch/x86/kvm/svm.c | 14 ++ arch/x86/kvm/x86.c | 12 2 files changed, 14 insertions(+), 12 deletions(-) diff --git a/arch/x86/kvm/s

Re: [RFC PATCH v2 1/1] mm/vmap: keep track of free blocks for vmap allocation

2019-03-25 Thread Uladzislau Rezki
Hello, Roman! > Hi, Uladzislau! > > Definitely a clever idea and very promising numbers! > > The overall approach makes total sense to me. > > I tried to go through the code, but it was a bit challenging. > I wonder, if you can split it into smaller parts to simplify the review? > I appreciate

[PATCH] x86/mce: Remove mce_report_event()

2019-03-25 Thread Borislav Petkov
From: Borislav Petkov Calling this function has been wrong for a while now: * Can't call schedule_work() in #MC context. * mce_notify_irq() either. * None of that noodling is needed anymore - all it needs to do is kick the IRQ work which would self-IPI so that once the #MC handler is done, the

Re: [PATCH v2] rtc: brcmstb-waketimer: switch to rtc_time64_to_tm

2019-03-25 Thread Florian Fainelli
On 3/25/19 10:17 AM, Alexandre Belloni wrote: > Call the 64bit version of rtc_time_to_tm as the range is enforced by the > core. > > Signed-off-by: Alexandre Belloni Reviewed-by: Florian Fainelli -- Florian

Re: [PATCH v3 1/6] arm64: dts: meson-g12a-x96-max: add regulators

2019-03-25 Thread Martin Blumenstingl
On Mon, Mar 25, 2019 at 11:15 AM Neil Armstrong wrote: > > From: Guillaume La Roque > > Add system regulators for the X96 Max Set-Top-Box. > > Still missing > * VDD_EE (0.8V - PWM controlled) > * VDD_CPU (PWM controlled) > > Signed-off-by: Guillaume La Roque > Signed-off-by: Neil Armstrong Revi

Re: [PATCH 2/4] pid: add pidctl()

2019-03-25 Thread Mika Penttilä
Hi! > +SYSCALL_DEFINE5(pidctl, unsigned int, cmd, pid_t, pid, int, source, int, > target, > + unsigned int, flags) > +{ > + struct pid_namespace *source_ns = NULL, *target_ns = NULL; > + struct pid *struct_pid; > + pid_t result; > + > + switch (cmd) { > + case PID

[PATCH] PM / wakeup: Use pm_pr_dbg() instead of pr_debug()

2019-03-25 Thread Stephen Boyd
These prints are useful if we're doing PM suspend debugging. Having them at pr_debug() level means that we need to either enable DEBUG in this file, or compile the kernel with dynamic debug capabilities. Both of these options have drawbacks like custom compilation or opting into all debug statement

Re: [RFC PATCH v2 1/5] mtd: cfi_cmdset_0002: Add support for polling status register

2019-03-25 Thread Joakim Tjernlund
On Mon, 2019-03-25 at 22:36 +0530, Vignesh Raghavendra wrote: > > On 25/03/19 7:21 PM, Joakim Tjernlund wrote: > > On Mon, 2019-03-25 at 18:27 +0530, Vignesh Raghavendra wrote: > > > CAUTION: This email originated from outside of the organization. Do not > > > click links or open attachments unle

Re: [PATCH] ext4: use BUG() instead of BUG_ON(1)

2019-03-25 Thread Nick Desaulniers
On Mon, Mar 25, 2019 at 6:00 AM Arnd Bergmann wrote: > > BUG_ON(1) leads to bogus warnings from clang when > CONFIG_PROFILE_ANNOTATED_BRANCHES is set: > > fs/ext4/inode.c:544:4: error: variable 'retval' is used uninitialized > whenever 'if' condition is false > [-Werror,-Wsometimes-uniniti

Re: [PATCH 01/17] fpga: dfl-fme-mgr: fix FME_PR_INTFC_ID register address.

2019-03-25 Thread Alan Tull
On Sun, Mar 24, 2019 at 10:23 PM Wu Hao wrote: Hi Hao, > > FME_PR_INTFC_ID is used as compat_id for fpga manager and region, > but high 64 bits and low 64 bits of the compat_id are swapped by > mistake. This patch fixes this problem by fixing register address. > > Signed-off-by: Wu Hao Acked-b

Re: [PATCH] ext4: use BUG() instead of BUG_ON(1)

2019-03-25 Thread Jan Kara
On Mon 25-03-19 14:00:25, Arnd Bergmann wrote: > BUG_ON(1) leads to bogus warnings from clang when > CONFIG_PROFILE_ANNOTATED_BRANCHES is set: > > fs/ext4/inode.c:544:4: error: variable 'retval' is used uninitialized > whenever 'if' condition is false > [-Werror,-Wsometimes-uninitialized]

Re: [PATCH v4 0/4] ocxl: OpenCAPI Cleanup

2019-03-25 Thread Frederic Barrat
Le 25/03/2019 à 17:49, Greg Kurz a écrit : Hi Alastair, I forgot to mention it during v3 but please don't link new version of a patchset to the previous one with --in-reply-to. This is to ensure I can see them in my email client without having to scroll back many days in the past (which likel

[PATCH] tools/power turbostat: Make interval calculation per thread to reduce jitter

2019-03-25 Thread Ghannam, Yazen
From: Yazen Ghannam Turbostat currently normalizes TSC and other values by dividing by an interval. This interval is the delta between the start of one global (all counters on all CPUs) sampling and the start of another. However, this introduces a lot of jitter into the data. In order to reduce

Repost: Missing security_mmap_file() in remap_file_pages syscall

2019-03-25 Thread TongZhang
Dear Kernel Developers, We’d like to bring this up for a discussion again. Several months ago we posted an email discussing a case where remap_file_pages() has no security_mmap_file() check. At that time we were told that do_mmap_pgoff() will base the new VMA permission on the old one. But some

[PATCH] firmware: arm_scmi: Fix leak in scmi_mailbox_check

2019-03-25 Thread Steven Price
of_parse_phandle_with_args() requires the caller to call of_node_put() on the returned args->np pointer. Otherwise the reference count will remain incremented. However, in this case, since we don't actually use the returned pointer, we can simply pass in NULL. Fixes: aa4f886f3893f ("firmware: arm

Re: [PATCH 0/4] pid: add pidctl()

2019-03-25 Thread Joel Fernandes
On Mon, Mar 25, 2019 at 09:48:43AM -0700, Daniel Colascione wrote: > On Mon, Mar 25, 2019 at 9:21 AM Christian Brauner > wrote: > > The pidctl() syscalls builds on, extends, and improves translate_pid() [4]. > > I quote Konstantins original patchset first that has already been acked and > > picke

Re: [PATCH] PCI: al: add pcie-al.c

2019-03-25 Thread Bjorn Helgaas
On Mon, Mar 25, 2019 at 05:56:35PM +0200, Jonathan Chocron wrote: > On 3/25/19 14:58, Bjorn Helgaas wrote: > > I think you're actually looking for a AMZN0001 device, not a PNP0C02 > > device. Your firmware might have a PNP0C02 _HID and AMZN0001 _CID, but > > that's not relevant here since you're

[PATCH v1] arm64: dts: qcom: msm8998: Add PCIe PHY node

2019-03-25 Thread Marc Gonzalez
Add MSM8998 PCIe QMP PHY DT node. Signed-off-by: Marc Gonzalez --- arch/arm64/boot/dts/qcom/msm8998.dtsi | 39 +++ 1 file changed, 39 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/qcom/msm8998.dtsi index f9a922fdae75..8344ed1bf08

Re: [PATCH 0/1] pwm: meson: fix scheduling while atomic issue

2019-03-25 Thread Martin Blumenstingl
Hello Uwe, On Mon, Mar 25, 2019 at 9:41 AM Uwe Kleine-König wrote: > > Hello Martin, > > On Sun, Mar 24, 2019 at 11:02:16PM +0100, Martin Blumenstingl wrote: > > Back in January a "BUG: scheduling while atomic" error showed up during > > boot on my Meson8b Odroid-C1 (which uses a PWM regulator as

Re: [RFC PATCH 0/10] Another Approach to Use PMEM as NUMA Node

2019-03-25 Thread Brice Goglin
Le 25/03/2019 à 17:56, Dan Williams a écrit : > > I'm generally against the concept that a "pmem" or "type" flag should > indicate anything about the expected performance of the address range. > The kernel should explicitly look to the HMAT for performance data and > not otherwise make type-based p

Re: pidfd design

2019-03-25 Thread Linus Torvalds
On Fri, Mar 22, 2019 at 11:34 AM Michael Tirado wrote: > > On Wed, Mar 20, 2019 at 8:08 PM Alexey Dobriyan wrote: > > > > pidfd code should be backed out immediately. Forget about /proc. > > Seems like Torvalds just merges this sort of "stuff" without reading > it now, or there's something that a

Re: [PATCH] bitrev: fix constant bitrev

2019-03-25 Thread Nick Desaulniers
On Fri, Mar 22, 2019 at 7:05 AM Arnd Bergmann wrote: > > clang points out with hundreds of warnings that the bitrev macros > have a problem with constant input: > > drivers/hwmon/sht15.c:187:11: error: variable '__x' is uninitialized when > used within its own initialization > [-Werror,-Wun

Re: Repost: Missing security_mmap_file() in remap_file_pages syscall

2019-03-25 Thread Kirill A. Shutemov
On Mon, Mar 25, 2019 at 01:33:51PM -0400, TongZhang wrote: > Dear Kernel Developers, > > We’d like to bring this up for a discussion again. > > Several months ago we posted an email discussing a case where > remap_file_pages() has no security_mmap_file() check. > At that time we were told that d

Re: [PATCH 02/17] fpga: dfl: fme: align PR buffer size per PR datawidth

2019-03-25 Thread Alan Tull
On Sun, Mar 24, 2019 at 10:23 PM Wu Hao wrote: Hi Hao, Looks good, one question below. > > Current driver checks if input bitstream file size is aligned or > not per PR data width (default 32bits). It requires one additional > step for end user when they generate the bitstream file, padding > e

RE: Portable Executable (PE) Signature Validation and Measurement for KEXEC system call using IMA

2019-03-25 Thread Lakshmi Ramasubramanian
Hello Mimi, Could you please let me know if you have any concerns with this approach? Thanks, -lakshmi -Original Message- From: linux-integrity-ow...@vger.kernel.org On Behalf Of Lakshmi Ramasubramanian Sent: Friday, March 22, 2019 10:39 AM To: linux-integr...@vger.kernel.org; linux-k

Re: [PATCH 0/4] pid: add pidctl()

2019-03-25 Thread Daniel Colascione
On Mon, Mar 25, 2019 at 10:36 AM Joel Fernandes wrote: > > On Mon, Mar 25, 2019 at 09:48:43AM -0700, Daniel Colascione wrote: > > On Mon, Mar 25, 2019 at 9:21 AM Christian Brauner > > wrote: > > > The pidctl() syscalls builds on, extends, and improves translate_pid() > > > [4]. > > > I quote Ko

Re: [PATCH] ubifs: work around high stack usage with clang

2019-03-25 Thread Nick Desaulniers
On Sun, Mar 24, 2019 at 12:45 PM Arnd Bergmann wrote: > > Building this file with clang can result in large stack usage as seen from > this warning: > > fs/ubifs/auth.c:78:5: error: stack frame size of 1152 bytes in function > 'ubifs_prepare_auth_node' > > The problem is that inlining ubifs_hash_

Re: Kernel LZO compressor

2019-03-25 Thread Nick Terrell
> On Mar 25, 2019, at 6:13 AM, Dave Rodgman wrote: > > On 19/03/2019 8:15 pm, Nick Terrell wrote: >> Hi Dave, >> >> I just saw you patches adding LZO-RLE, so I decided to fuzz the LZO >> compressor and decompressor. I didn't find any crashes, but I found some edge >> cases in the decompressor

Re: [PATCH 0/1] pwm: meson: fix scheduling while atomic issue

2019-03-25 Thread Martin Blumenstingl
Hi Jerome, On Mon, Mar 25, 2019 at 10:35 AM Jerome Brunet wrote: > > On Sun, 2019-03-24 at 23:02 +0100, Martin Blumenstingl wrote: > > Back in January a "BUG: scheduling while atomic" error showed up during > > boot on my Meson8b Odroid-C1 (which uses a PWM regulator as CPU supply). > > The call

Re: [PATCH 1/2] kvm/x86: Move MSR_K7_HWCR to svm.c

2019-03-25 Thread Jim Mattson
On Mon, Mar 25, 2019 at 10:17 AM Borislav Petkov wrote: > > From: Borislav Petkov > > This is an AMD-specific MSR. Put it where it belongs. > > Signed-off-by: Borislav Petkov > Tested-by: Yazen Ghannam > --- > arch/x86/kvm/svm.c | 14 ++ > arch/x86/kvm/x86.c | 12 > 2

Re: [PATCH v19,RESEND 24/27] x86/vdso: Add __vdso_sgx_enter_enclave() to wrap SGX enclave transitions

2019-03-25 Thread Sean Christopherson
On Sun, Mar 24, 2019 at 01:59:48AM -0700, Xing, Cedric wrote: > As said in my previous email, this vDSO API isn't even compliant to > x86_64 ABI and is absolutely NOT for average developers. Instead, > host/enclave communications are expected to be handled by SDKs and > those developers will be ver

Re: [REGRESSION] failed to boot: commit 1aec4211204d parport: daisy: use new parport device model

2019-03-25 Thread Linus Torvalds
On Mon, Mar 25, 2019 at 8:36 AM Steven Rostedt wrote: > > I bisected it down to this commit: > > aec4211204d ("parport: daisy: use new parport device model") I was confused, because no such commit exists. But it turns out you have the right commit ID in your subject line, and you just dropped

[PATCH v2] genirq: Respect IRQCHIP_SKIP_SET_WAKE in irq_chip_set_wake_parent()

2019-03-25 Thread Stephen Boyd
This function returns an error if a child irqchip calls irq_chip_set_wake_parent() but its parent irqchip has the IRQCHIP_SKIP_SET_WAKE flag set. Let's return 0 for success here instead because there isn't anything to do. This keeps the behavior consistent with how set_irq_wake_real() is implement

Re: [PATCH 1/2] kvm/x86: Move MSR_K7_HWCR to svm.c

2019-03-25 Thread Borislav Petkov
On Mon, Mar 25, 2019 at 11:05:48AM -0700, Jim Mattson wrote: > If the guest has written a non-zero value to this MSR, shouldn't it be > able to read that value back? See the second patch. -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply.

Re: [PATCH] ext4: use BUG() instead of BUG_ON(1)

2019-03-25 Thread Darrick J. Wong
On Mon, Mar 25, 2019 at 02:00:25PM +0100, Arnd Bergmann wrote: > BUG_ON(1) leads to bogus warnings from clang when > CONFIG_PROFILE_ANNOTATED_BRANCHES is set: > > fs/ext4/inode.c:544:4: error: variable 'retval' is used uninitialized > whenever 'if' condition is false > [-Werror,-Wsometimes

[PATCH 3/4] CPER: Add UEFI spec references

2019-03-25 Thread helgaas
From: Bjorn Helgaas Add UEFI spec references for CPER UUIDs and structures, fix a few typos, and remove some useless comments. No functional change intended. Link: http://www.uefi.org/specifications Signed-off-by: Bjorn Helgaas --- include/linux/cper.h | 54 +--

[PATCH 4/4] CPER: Remove unnecessary use of user-space types

2019-03-25 Thread helgaas
From: Bjorn Helgaas "__u32" and similar types are intended for things exported to user-space, including structs used in ioctls; see include/uapi/asm-generic/int-l64.h. They are not needed for the CPER struct definitions, which not exported to user-space and not used in ioctls. Replace them with

Re: [RFC v2 1/2] vfio/pci: export common symbols in vfio-pci

2019-03-25 Thread Alex Williamson
On Sat, 23 Mar 2019 11:06:44 + "Liu, Yi L" wrote: > > From: Alex Williamson [mailto:alex.william...@redhat.com] > > Sent: Thursday, March 21, 2019 3:22 AM > > To: Liu, Yi L > > Subject: Re: [RFC v2 1/2] vfio/pci: export common symbols in vfio-pci > > > > On Wed, 20 Mar 2019 11:49:37 + >

Re: [PATCH 1/8] vfio/mdev: Fix to not do put_device on device_register failure

2019-03-25 Thread Kirti Wankhede
On 3/23/2019 4:50 AM, Parav Pandit wrote: > device_register() performs put_device() if device_add() fails. > This balances with device_initialize(). > > mdev core performing put_device() when device_register() fails, > is an error that puts already released device again. > Therefore, don't put

[PATCH 0/4] PCI, CPER: Trivial cleanups

2019-03-25 Thread helgaas
From: Bjorn Helgaas Clean up whitespace, fix some typos, add some spec references, and convert unnecessary __u32 usage to u32. Bjorn Helgaas (4): PCI: Cleanup register definition width and whitespace PCI: Fix comment typos CPER: Add UEFI spec references CPER: Remove unnecessary use of us

[PATCH 2/4] PCI: Fix comment typos

2019-03-25 Thread helgaas
From: Bjorn Helgaas Fix spelling errors and format function comments consistently. Changes whitespace and comments only; no functional change intended. Signed-off-by: Bjorn Helgaas --- drivers/pci/controller/dwc/pci-keystone.c | 2 +- drivers/pci/controller/pci-host-generic.c | 2 +- driv

[PATCH 1/4] PCI: Cleanup register definition width and whitespace

2019-03-25 Thread helgaas
From: Bjorn Helgaas Follow the file conventions of: - register offsets not indented - fields within a register indented one space - field masks use same width as register - register field values indented an additional space No functional change intended. Signed-off-by: Bjorn Helgaas -

Re: [PATCH 0/4] pid: add pidctl()

2019-03-25 Thread Jonathan Kowalski
On Mon, Mar 25, 2019 at 5:53 PM Daniel Colascione wrote: > > [..snip..] > > I don't like the idea of having one kind of pollfd be pollable and > another not. Such an interface would be confusing for users. If, as > you suggest below, we instead make the procfs-less FD the only thing > we call a "p

Re: [PATCH RESEND v3 3/4] arm64: dts: mt8183: add pintcrl device node

2019-03-25 Thread Nicolas Boichat
On Mon, Mar 25, 2019 at 5:41 AM Zhiyong Tao wrote: > > The commit adds pintcrl device node for mt8183 Minor nit: This should say pinctrl (in the commit title as well). > > Signed-off-by: Zhiyong Tao > --- > arch/arm64/boot/dts/mediatek/mt8183.dtsi | 26 +- > 1 file chan

Re: [PATCH 2/4] pid: add pidctl()

2019-03-25 Thread Jann Horn
On Mon, Mar 25, 2019 at 5:21 PM Christian Brauner wrote: > The pidctl() syscalls builds on, extends, and improves translate_pid() [4]. > I quote Konstantins original patchset first that has already been acked and > picked up by Eric before and whose functionality is preserved in this > syscall: [.

Re: [PATCH 1/3] platform/chrome: wilco_ec: Split core and mailbox into separate modules

2019-03-25 Thread Nick Crews
On Mon, Mar 25, 2019 at 11:18 AM Enric Balletbo i Serra wrote: > > Hi Nick, > > Thanks for the patch, some comments below. > > On 21/3/19 23:13, Nick Crews wrote: > > It was bad design to lump the mailbox interface to the Wilco EC into the > > same module as the code module, which loads all the su

[PATCH v3 2/3] dt-bindings: arm: fsl: Add support for ZII VF610 SPB4

2019-03-25 Thread Andrey Smirnov
Add support for ZII VF610 SPB4. Signed-off-by: Andrey Smirnov Cc: Shawn Guo Cc: Chris Healy Cc: Andrew Lunn Cc: Fabio Estevam Cc: Rob Herring Cc: linux-arm-ker...@lists.infradead.org Cc: linux-kernel@vger.kernel.org Cc: devicet...@vger.kernel.org --- Documentation/devicetree/bindings/arm/fs

[PATCH v3 3/3] ARM: dts: vf610: Add ZII SPB4 board

2019-03-25 Thread Andrey Smirnov
Add Device Tree for VF610 based Zodiac Seat Power Box. Signed-off-by: Andrey Smirnov Reviewed-by: Fabio Estevam Cc: Shawn Guo Cc: Chris Healy Cc: Andrew Lunn Cc: Heiner Kallweit Cc: Fabio Estevam Cc: Rob Herring Cc: devicet...@vger.kernel.org Cc: linux-arm-ker...@lists.infradead.org Cc: li

[PATCH v3 1/3] dt-bindings: arm: fsl: Add supported ZII VF610 boards to DT schema

2019-03-25 Thread Andrey Smirnov
Add already supported ZII VF610 boards to DT schema. Signed-off-by: Andrey Smirnov Cc: Shawn Guo Cc: Chris Healy Cc: Andrew Lunn Cc: Fabio Estevam Cc: Rob Herring Cc: linux-arm-ker...@lists.infradead.org Cc: linux-kernel@vger.kernel.org Cc: devicet...@vger.kernel.org --- Documentation/devic

[PATCH] PCI/LINK: Request a one-shot IRQ with NULL handler

2019-03-25 Thread Borislav Petkov
From: Borislav Petkov Booting v5.1-rc1 causes these new messages in dmesg here: genirq: Threaded irq requested with handler=NULL and !ONESHOT for irq 24 pcie_bw_notification: probe of :00:02.0:pcie010 failed with error -22 because requesting a threaded IRQ with NULL handler needs to be

Re: Possible UDF locking error?

2019-03-25 Thread Steve Magnani
On 3/25/19 11:42 AM, Jan Kara wrote: Hi! On Sat 23-03-19 15:14:05, Steve Magnani wrote: ... In contrast, udf_setup_indirect_aext(), which constructs an AED, has this sequence: bh = udf_tgetblk(...); // calls sb_getblk() lock_buffer(bh); memset(bh->b_data, 0, inode->i_sb->s_blocksiz

Re: [PATCH 1/2] kvm/x86: Move MSR_K7_HWCR to svm.c

2019-03-25 Thread Sean Christopherson
On Mon, Mar 25, 2019 at 06:16:48PM +0100, Borislav Petkov wrote: > From: Borislav Petkov > > This is an AMD-specific MSR. Put it where it belongs. > > Signed-off-by: Borislav Petkov > Tested-by: Yazen Ghannam > --- > arch/x86/kvm/svm.c | 14 ++ > arch/x86/kvm/x86.c | 12 --

Re: [PATCH 4/4] CPER: Remove unnecessary use of user-space types

2019-03-25 Thread Bjorn Helgaas
On Mon, Mar 25, 2019 at 01:14:25PM -0500, helg...@kernel.org wrote: > From: Bjorn Helgaas > > "__u32" and similar types are intended for things exported to user-space, > including structs used in ioctls; see include/uapi/asm-generic/int-l64.h. > > They are not needed for the CPER struct definiti

Re: [PATCH] PCI/LINK: Request a one-shot IRQ with NULL handler

2019-03-25 Thread Alex G.
Hi Borislav, Thanks for the update. We've settled on a different fix [1], since Lukas was not happy with IRQF_ONESHOT [2]. Alex [1] https://lore.kernel.org/linux-pci/20190323003700.7294-1-mr.nuke...@gmail.com/ [2] https://lore.kernel.org/linux-pci/20190318043314.noyj6t4sh26sp...@wunner.de/

Re: [PATCH 4/4] pinctrl: add drive for I2C related pins on MT8183

2019-03-25 Thread Nicolas Boichat
On Mon, Mar 25, 2019 at 5:23 AM Zhiyong Tao wrote: > > This patch provides the advanced drive for I2C used pins on MT8183. > The detail strength specification description of the I2C pin: > When E1=0/E0=0, the strength is 0.125mA. > When E1=0/E0=1, the strength is 0.25mA. > When E1=1/E0=0, the stre

Re: [PATCH 2/8] vfio/mdev: Avoid release parent reference during error path

2019-03-25 Thread Kirti Wankhede
On 3/23/2019 4:50 AM, Parav Pandit wrote: > During mdev parent registration in mdev_register_device(), > if parent device is duplicate, it releases the reference of existing > parent device. > This is incorrect. Existing parent device should not be touched. > > Fixes: 7b96953bc640 ("vfio: Media

Re: [PATCH v2 2/2] dt-bindings: edac: arm-dmc520.txt

2019-03-25 Thread James Morse
Hi Rui, On 07/03/2019 01:24, Rui Zhao wrote: > From: Rui Zhao > dt-bindings for new EDAC driver dmc520_edac.c. (minor nit, the DT folk prefer the binding to come first in the series, this makes it easier to review) > diff --git a/Documentation/devicetree/bindings/edac/arm-dmc520.txt > b/Docu

response

2019-03-25 Thread Allen
My name is Mr. Allen, I have a Business Proposal of Four million five hundred thousand united states dollars for you to handle with me from my bank. I will need you to assist me in executing this Business aj4...@gmail.com

[PATCH] ARM: dts: vf610-zii-cfu1: Disable NOR flash/SPI controller

2019-03-25 Thread Andrey Smirnov
Only a certain number of CFU1's come with NOR flash populated. Disable it by default to avoid trying to probe NOR flash on devices that don't have it. Devices that do have it can rely on the bootloader to enable this node. Signed-off-by: Andrey Smirnov Cc: Shawn Guo Cc: Chris Healy Cc: Andrew L

[PATCH v5 1/1] gpio: add driver for Mellanox BlueField GPIO controller

2019-03-25 Thread Shravan Kumar Ramani
This patch adds support for the GPIO controller used by Mellanox BlueField SOCs. Reviewed-by: David Woods Signed-off-by: Shravan Kumar Ramani --- drivers/gpio/Kconfig | 7 +++ drivers/gpio/Makefile | 1 + drivers/gpio/gpio-mlxbf.c | 154 +

Re: [PATCH v2 1/2] EDAC: add EDAC driver for DMC520

2019-03-25 Thread James Morse
Hi guys, On 23/03/2019 09:23, Borislav Petkov wrote: > On Thu, Mar 07, 2019 at 01:24:01AM +, Rui Zhao wrote: >> From: Rui Zhao >> >> New driver supports error detection and correction on >> the devices with ARM DMC-520 memory controller. A question/suggestion on the direction... Could we av

Re: [PATCH 3/4] signal: support pidctl() with pidfd_send_signal()

2019-03-25 Thread Jonathan Kowalski
On Mon, Mar 25, 2019 at 4:21 PM Christian Brauner wrote: > > Let pidfd_send_signal() use pidfds retrieved via pidctl(). With this patch > pidfd_send_signal() becomes independent of procfs. This fullfils the > request made when we merged the pidfd_send_signal() patchset. The > pidfd_send_signal() s

Re: [PATCH] ELAN touchpad i2c_hid bugs fix

2019-03-25 Thread Dmitry Torokhov
On Mon, Mar 25, 2019 at 11:23 AM wrote: > > Hi. > > Mar 25, 2019, 6:56 PM by d...@chromium.org: > > If you want to keep on using edge you need to make sure that i2c-hid > never loses edge, as replaying of previously disabled interrupts in > not at all reliable. So you need to "kick" the device aft

[PATCH v5 0/1] gpio: add driver for Mellanox BlueField GPIO

2019-03-25 Thread Shravan Kumar Ramani
Changes since v4: Use bgpio_init to make use of the generic MMIO library. Remove routines made unnecessary by the above change. Shravan Kumar Ramani (1): gpio: add driver for Mellanox BlueField GPIO controller drivers/gpio/Kconfig | 7 +++ drivers/gpio/Makefile | 1 + drivers/gpio

[PATCH 3/4] ACPI / scan: Simplify acpi_bus_extract_wakeup_device_power_package()

2019-03-25 Thread helgaas
From: Bjorn Helgaas acpi_bus_extract_wakeup_device_power_package() is a static function with a single caller that supplies (device->handle, &device->wakeup). Simplify the interface so the caller need only supply "device". This makes it obvious that "wakeup", i.e., &device->wakeup, can never be

[PATCH 2/4] ACPI / tables: Cleanup whitespace

2019-03-25 Thread helgaas
From: Bjorn Helgaas Cleanup some whitespace to match the rest of the file. No functional change intended. Signed-off-by: Bjorn Helgaas --- drivers/acpi/tables.c | 18 +- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.

[PATCH 0/4] ACPI: Trivial cleanups

2019-03-25 Thread helgaas
From: Bjorn Helgaas Clean up whitespace, fix some typos, add a couple comments, simplify the acpi_bus_extract_wakeup_device_power_package() internal interface slightly. Bjorn Helgaas (4): ACPI: Fix comment typos ACPI / tables: Cleanup whitespace ACPI / scan: Simplify acpi_bus_extract_wakeu

[PATCH 1/4] ACPI: Fix comment typos

2019-03-25 Thread helgaas
From: Bjorn Helgaas Fix some misspellings in comments. No functional change intended. Signed-off-by: Bjorn Helgaas --- drivers/acpi/acpi_dbg.c | 2 +- drivers/acpi/acpi_lpat.c| 2 +- drivers/acpi/cppc_acpi.c| 34 +- drivers/acpi/power.c| 4 ++--

Re: 32-bit Amlogic (ARM) SoC: kernel BUG in kfree()

2019-03-25 Thread Martin Blumenstingl
Hi Liang, On Mon, Mar 25, 2019 at 11:03 AM Liang Yang wrote: > > Hi Martin, > > On 2019/3/23 5:07, Martin Blumenstingl wrote: > > Hi Matthew, > > > > On Thu, Mar 21, 2019 at 10:44 PM Matthew Wilcox wrote: > >> > >> On Thu, Mar 21, 2019 at 09:17:34PM +0100, Martin Blumenstingl wrote: > >>> Hello,

Re: [PATCH v2 1/2] EDAC: add EDAC driver for DMC520

2019-03-25 Thread James Morse
Hi Rui, On 07/03/2019 01:24, Rui Zhao wrote: > From: Rui Zhao > New driver supports error detection and correction on > the devices with ARM DMC-520 memory controller. > diff --git a/drivers/edac/dmc520_edac.c b/drivers/edac/dmc520_edac.c > new file mode 100644 > index 000..c70ce4e > --- /d

Re: KASAN: use-after-free Read in path_lookupat

2019-03-25 Thread Linus Torvalds
On Sun, Mar 24, 2019 at 9:57 PM Al Viro wrote: > > So we have 5 broken cases, all with the same kind of fix: move freeing > into the RCU-delayed part of ->destroy_inode(); for debugfs and bpf > that requires adding ->alloc_inode()/->destroy_inode(), rather than > relying upon the defaults from fs/

[PATCH] i2c: isch: Remove unnecessary acpi.h include

2019-03-25 Thread helgaas
From: Bjorn Helgaas 54fb4a05af0a ("i2c: Check for ACPI resource conflicts") included so we could use acpi_check_region(). fd46a0064af1 ("i2c: convert i2c-isch to platform_device") removed the use of acpi_check_region() but not the include. Remove the now-unnecessary include of . No functional

[PATCH 4/4] ACPI / scan: Add labels for PNP button devices

2019-03-25 Thread helgaas
From: Bjorn Helgaas Subsequent code treats button_device_ids[] entries differently, and it's hard to follow without a hint as to which is which. Add comments to identify the power button, lid, and sleep button devices. The "PNP" prefix is owned by Microsoft, so they distribute the canonical lis

Re: [PATCH 3/4] signal: support pidctl() with pidfd_send_signal()

2019-03-25 Thread Jann Horn
On Mon, Mar 25, 2019 at 5:21 PM Christian Brauner wrote: > Let pidfd_send_signal() use pidfds retrieved via pidctl(). With this patch > pidfd_send_signal() becomes independent of procfs. This fullfils the > request made when we merged the pidfd_send_signal() patchset. The > pidfd_send_signal() sys

Re: [PATCH 1/2] kvm/x86: Move MSR_K7_HWCR to svm.c

2019-03-25 Thread Borislav Petkov
On Mon, Mar 25, 2019 at 11:21:33AM -0700, Sean Christopherson wrote: > Won't this prevent emulating an AMD guest on Intel hardware, e.g. due to > injecting #GPs during boot? I guess, but... > Keeping support in kvm_{get,set}_msr_common > doesn't preclude svm_{get,set}_msr() from having SVM-specif

<    2   3   4   5   6   7   8   9   10   11   >