Re: pidfd design

2019-03-20 Thread Daniel Colascione
On Tue, Mar 19, 2019 at 8:59 PM Christian Brauner wrote: > > On Tue, Mar 19, 2019 at 07:42:52PM -0700, Daniel Colascione wrote: > > On Tue, Mar 19, 2019 at 6:52 PM Joel Fernandes > > wrote: > > > > > > On Wed, Mar 20, 2019 at 12:10:23AM +0100, Christian Brauner wrote: > > > > On Tue, Mar 19, 201

Re: [PATCH v2 03/11] staging: mt7621-mmc: Fix warning when reloading module with debug msgs enabled

2019-03-20 Thread Greg Kroah-Hartman
On Mon, Mar 18, 2019 at 08:20:04PM -0600, George Hilliard wrote: > The kernel complained: > > [ 510.277151] WARNING: CPU: 0 PID: 395 at fs/proc/generic.c:360 > proc_register+0xf0/0x108 > [ 510.292891] proc_dir_entry '/proc/msdc_debug' already registered > > when doing a modprobe/rmmod/

Re: [PATCH v2 06/11] staging: mt7621-mmc: Initialize completions a single time during probe

2019-03-20 Thread Greg Kroah-Hartman
On Mon, Mar 18, 2019 at 08:20:07PM -0600, George Hilliard wrote: > The module was initializing completions whenever it was going to wait on > them, and not when the completion was allocated. This is incorrect > according to the completion docs: > > Calling init_completion() on the same comple

Re: [PATCH v2 07/11] staging: mt7621-mmc: Check for nonzero number of scatterlist entries

2019-03-20 Thread Greg Kroah-Hartman
On Mon, Mar 18, 2019 at 08:20:08PM -0600, George Hilliard wrote: > The buffer descriptor setup loop is correct only if it is setting up at > least one bd struct. Besides, there is an error somewhere if > dma_map_sg() returns 0. So add a paranoid check for this condition. > > Signed-off-by: Georg

Re: [PATCH v2] staging: rtlwifi: Fix potential NULL pointer dereference of kzalloc

2019-03-20 Thread Greg Kroah-Hartman
On Tue, Mar 19, 2019 at 03:15:08PM -0500, Aditya Pakki wrote: > phydm.internal is allocated using kzalloc which is used multiple > times without a check for NULL pointer. This patch avoids such a > scenario. > > -- > v1: Patch collision with different things, fix as per Greg > Signed-off-by: Adity

Re: [PATCH v2] staging: rtlwifi: rtl8822b: fix to avoid NULL pointer dereference

2019-03-20 Thread Greg Kroah-Hartman
On Tue, Mar 19, 2019 at 03:21:25PM -0500, Aditya Pakki wrote: > skb allocated via dev_alloc_skb can fail and return a NULL pointer. > This patch avoids such a scenario and returns, consistent with other > invocations. > > --- > v1: Patch collision with rtl_phydm.c, fix as per Greg > Signed-off-by:

Re: [PATCH v2] staging: rtlwifi: rtl8822b: fix to avoid NULL pointer dereference

2019-03-20 Thread Greg Kroah-Hartman
On Tue, Mar 19, 2019 at 03:21:25PM -0500, Aditya Pakki wrote: > skb allocated via dev_alloc_skb can fail and return a NULL pointer. > This patch avoids such a scenario and returns, consistent with other > invocations. > > --- > v1: Patch collision with rtl_phydm.c, fix as per Greg > Signed-off-by:

Re: [PATCH v2] staging: rtl8188eu: Fix potential NULL pointer dereference

2019-03-20 Thread Greg Kroah-Hartman
On Tue, Mar 19, 2019 at 04:07:54PM -0500, Aditya Pakki wrote: > hwxmits is allocated via kcalloc and not checked for failure before its > dereference. The patch fixes this problem by returning an error in > rtl8723bs. > > --- > v1: Return error and remove print in case of failure, per Greg > Signe

Re: your mail

2019-03-20 Thread Greg Kroah-Hartman
On Mon, Mar 18, 2019 at 08:20:01PM -0600, George Hilliard wrote: > Because of this change, the driver now expects a pinctrl device > reference in the mmc controller's device tree node; without it, it will > bail out. This could break existing setups that don't specify it > because it "just worked"

Re: [PATCH] s390:tty3270:move spin_lock_bh to spin_lock in tasklet

2019-03-20 Thread Heiko Carstens
On Wed, Mar 20, 2019 at 12:12:36AM +0800, Jeff Xie wrote: > It is unnecessary to call spin_lock_bh in a tasklet. > > Signed-off-by: Jeff Xie > --- > drivers/s390/char/tty3270.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/s390/char/tty3270.c b/drivers/s39

[PATCH 1/3] mm/sparse: Clean up the obsolete code comment

2019-03-20 Thread Baoquan He
The code comment above sparse_add_one_section() is obsolete and incorrect, clean it up and write new one. Signed-off-by: Baoquan He --- mm/sparse.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/mm/sparse.c b/mm/sparse.c index 77a0554fa5bd..0a0f82c5d969 100644 --- a

[PATCH] extcon: fix a missing check of regmap_read

2019-03-20 Thread Kangjie Lu
When regmap_read fails, it doesn't make sense to use the read value "val" because it can be uninitialized. The fix returns if regmap_read fails. Signed-off-by: Kangjie Lu --- drivers/extcon/extcon-axp288.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/extcon/extcon-axp288.c b/

[PATCH 3/3] mm/sparse: Rename function related to section memmap allocation/free

2019-03-20 Thread Baoquan He
These functions are used allocate/free section memmap, have nothing to do with kmalloc/free during the handling. Rename them to remove the confusion. Signed-off-by: Baoquan He --- mm/sparse.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/mm/sparse.c b/mm/

[PATCH 2/3] mm/sparse: Optimize sparse_add_one_section()

2019-03-20 Thread Baoquan He
Reorder the allocation of usemap and memmap since usemap allocation is much smaller and simpler. Otherwise hard work is done to make memmap ready, then have to rollback just because of usemap allocation failure. Signed-off-by: Baoquan He --- mm/sparse.c | 13 +++-- 1 file changed, 7 inse

Re: [PATCH 1/3] mm/sparse: Clean up the obsolete code comment

2019-03-20 Thread Mike Rapoport
Hi, On Wed, Mar 20, 2019 at 03:35:38PM +0800, Baoquan He wrote: > The code comment above sparse_add_one_section() is obsolete and > incorrect, clean it up and write new one. > > Signed-off-by: Baoquan He > --- > mm/sparse.c | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > d

[PATCH] mm/sparse: Rename function related to section memmap allocation/free

2019-03-20 Thread Baoquan He
These functions are used allocate/free section memmap, have nothing to do with kmalloc/free during the handling. Rename them to remove the confusion. Signed-off-by: Baoquan He --- mm/sparse.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/mm/sparse.c b/mm/

Re: [PATCH] mm/sparse: Rename function related to section memmap allocation/free

2019-03-20 Thread Baoquan He
On 03/20/19 at 03:53pm, Baoquan He wrote: > These functions are used allocate/free section memmap, have nothing ^ 'to' missed here, will update later. > to do with kmalloc/free during the handling. Rename them to remove > the confusion. > > Signed-off-by: Baoquan He > --

Re: [PATCH v7 0/4] Enable wm8524 on i.MX8MQ-EVK

2019-03-20 Thread Shawn Guo
On Tue, Mar 19, 2019 at 05:48:35PM +, Daniel Baluta wrote: > On i.MX8MQ EVK we can start the party using the wm8524 codec > which gets it's data through the SAI2 interface. > > In order to make it work this patch series enables the SDMA nodes, > sets the correct pinctrl configuration and uses

Re: [PATCH 2/3] mm/sparse: Optimize sparse_add_one_section()

2019-03-20 Thread Mike Rapoport
On Wed, Mar 20, 2019 at 03:35:39PM +0800, Baoquan He wrote: > Reorder the allocation of usemap and memmap since usemap allocation > is much smaller and simpler. Otherwise hard work is done to make > memmap ready, then have to rollback just because of usemap allocation > failure. > > Signed-off-by:

[PATCH] blk-mq: fix a hung issue when set device state to blocked and restore running

2019-03-20 Thread zhengbin
When I use dd test a SCSI device which use blk-mq in the following steps: 1.echo "blocked" >/sys/block/sda/device/state 2.dd if=/dev/sda of=/mnt/t.log bs=1M count=10 3.echo "running" >/sys/block/sda/device/state dd should finish this work after step 3, unfortunately, still hung. After step2, the k

Re: [PATCH] mm/sparse: Rename function related to section memmap allocation/free

2019-03-20 Thread Baoquan He
On 03/20/19 at 03:53pm, Baoquan He wrote: > These functions are used allocate/free section memmap, have nothing > to do with kmalloc/free during the handling. Rename them to remove > the confusion. Sorry, wrong git operation caused this one sent. I intended to send out other single patch. Please

Re: [PATCH 1/3] mm/sparse: Clean up the obsolete code comment

2019-03-20 Thread Baoquan He
On 03/20/19 at 09:50am, Mike Rapoport wrote: > Hi, > > On Wed, Mar 20, 2019 at 03:35:38PM +0800, Baoquan He wrote: > > The code comment above sparse_add_one_section() is obsolete and > > incorrect, clean it up and write new one. > > > > Signed-off-by: Baoquan He > > --- > > mm/sparse.c | 9

Re: [PATCH] extcon: fix a missing check of regmap_read

2019-03-20 Thread Chanwoo Choi
Hi, You better to edit the patch title as following in order to sustain the title format for extcon: extcon: fix a missing check of regmap_read -> extcon: axp288: Fix a missing check of regmap_read On 19. 3. 20. 오후 4:35, Kangjie Lu wrote: > When regmap_read fails, it doesn't make sense to use t

Re: [PATCH] mm/sparse: Rename function related to section memmap allocation/free

2019-03-20 Thread Mike Rapoport
On Wed, Mar 20, 2019 at 03:53:01PM +0800, Baoquan He wrote: > These functions are used allocate/free section memmap, have nothing > to do with kmalloc/free during the handling. Rename them to remove > the confusion. > > Signed-off-by: Baoquan He Acked-by: Mike Rapoport > --- > mm/sparse.c | 1

Re: [PATCH 1/2] clk: imx7ulp: remove snvs clock

2019-03-20 Thread Shawn Guo
On Thu, Feb 28, 2019 at 08:56:00AM +, Anson Huang wrote: > Since i.MX7ULP B0 chip, the SNVS module is moved into M4 > domain and its clock is also moved into PCC0 which is > contorlled by M4, Linux kernel should NOT add it into > clock tree. > > Signed-off-by: Anson Huang Applied both, thank

Re: [PATCH] mm/sparse: Rename function related to section memmap allocation/free

2019-03-20 Thread Baoquan He
On 03/20/19 at 09:59am, Mike Rapoport wrote: > On Wed, Mar 20, 2019 at 03:53:01PM +0800, Baoquan He wrote: > > These functions are used allocate/free section memmap, have nothing > > to do with kmalloc/free during the handling. Rename them to remove > > the confusion. > > > > Signed-off-by: Baoqua

Re: [PATCH 2/3] mm/sparse: Optimize sparse_add_one_section()

2019-03-20 Thread Baoquan He
On 03/20/19 at 09:56am, Mike Rapoport wrote: > > diff --git a/mm/sparse.c b/mm/sparse.c > > index 0a0f82c5d969..054b99f74181 100644 > > --- a/mm/sparse.c > > +++ b/mm/sparse.c > > @@ -697,16 +697,17 @@ int __meminit sparse_add_one_section(int nid, > > unsigned long start_pfn, > > ret = sparse_

[PATCH] mm, memory_hotplug: Fix the wrong usage of N_HIGH_MEMORY

2019-03-20 Thread Baoquan He
In function node_states_check_changes_online(), N_HIGH_MEMORY is used to substitute ZONE_HIGHMEM directly. This is not right. N_HIGH_MEMORY always has value '3' if CONFIG_HIGHMEM=y, while ZONE_HIGHMEM's value is not. It depends on whether CONFIG_ZONE_DMA/CONFIG_ZONE_DMA32 are enabled. Obviously it'

Re: [PATCH] ARM: dts: imx7s-warp: PMIC swbst boot-on/always-on

2019-03-20 Thread Shawn Guo
On Sat, Mar 02, 2019 at 11:32:29PM +0100, Pierre-Jean Texier wrote: > PMIC swbst regulator is used for the MikroBUS socket (pin +5V). > > We have to set the regulator to "boot-on" and "always-on" > to output a voltage of 5V on this socket. > > Signed-off-by: Pierre-Jean Texier Applied, thanks.

[PATCH] arm64: dts: sdm845: Include rpmpd DT header

2019-03-20 Thread Rajendra Nayak
In order to fix dependencies with rpmpd DT entries, the header was dropped and hardcoded values were added for opp-level, during the previous merge window. Add the header back in now and remove the hardcodings, effectively reverting commit '08585d21de9875a6064b350957faa0460a4c69a6: arm64: dts: sdm8

[PATCH] Revert "svm: Fix AVIC incomplete IPI emulation"

2019-03-20 Thread Suthikulpanit, Suravee
This reverts commit bb218fbcfaaa3b115d4cd7a43c0ca164f3a96e57. As Oren Twaig pointed out the old discussion: https://patchwork.kernel.org/patch/8292231/ that the change coud potentially cause an extra IPI to be sent to the destination vcpu because the AVIC hardware already set the IRR bit befor

Re: [PATCH] drivers: power: supply: goldfish_battery: Fix bogus SPDX identifier

2019-03-20 Thread Thomas Gleixner
A: Because it messes up the order in which people normally read text. Q: Why is top-posting such a bad thing? A: Top-posting. Q: What is the most annoying thing in e-mail? A: No. Q: Should I include quotations after my reply? On Tue, 19 Mar 2019, Roman Kiryanov wrote: > Hi, I am sorry for this war

Re: [PATCH 2/4] clk: meson: meson8b: use a sparate clock table for Meson8m2

2019-03-20 Thread Neil Armstrong
Hi, There is a typo in the subject "s/sparate/separate/" ! On 19/03/2019 22:51, Martin Blumenstingl wrote: > Meson8, Meson8b and Meson8m2 implement a similar clock controller. > However, there are a few differences between the three actual IP blocks. > > One example where Meson8m2 differs from M

Re: [PATCH] kvm: arm: Fix handling of stage2 huge mappings

2019-03-20 Thread Marc Zyngier
Hi Suzuki, On Tue, 19 Mar 2019 14:11:08 +, Suzuki K Poulose wrote: > > We rely on the mmu_notifier call backs to handle the split/merge > of huge pages and thus we are guaranteed that, while creating a > block mapping, either the entire block is unmapped at stage2 or it > is missing permissi

Re: [PATCH 3/4] clk: meson: meson8b: add support for the GP_PLL clock on Meson8m2

2019-03-20 Thread Neil Armstrong
On 19/03/2019 22:51, Martin Blumenstingl wrote: > Meson8m2 has a GP_PLL clock (similar to GP0_PLL on GXBB/GXL/GXM) which > is used as input for the VPU clocks. > The only supported frequency (based on Amlogic's vendor kernel sources) > is 364MHz which is achieved using the following parameters: > -

Re: [PATCH] mm: mempolicy: make mbind() return -EIO when MPOL_MF_STRICT is specified

2019-03-20 Thread Oscar Salvador
On Wed, Mar 20, 2019 at 02:35:56AM +0800, Yang Shi wrote: > Fixes: 6f4576e3687b ("mempolicy: apply page table walker on > queue_pages_range()") > Reported-by: Cyril Hrubis > Cc: Vlastimil Babka > Cc: sta...@vger.kernel.org > Suggested-by: Kirill A. Shutemov > Signed-off-by: Yang Shi > Signed-o

[PATCH v3] tracing: eliminate const char[] auto variables

2019-03-20 Thread Rasmus Villemoes
Automatic const char[] variables cause unnecessary code generation. For example, the this_mod variable leads to 3f04: 48 b8 5f 5f 74 68 69 73 5f 6d movabs $0x6d5f736968745f5f,%rax # __this_m 3f0e: 4c 8d 44 24 02 lea0x2(%rsp),%r8 3f13: 48 8d 7c

Re: [PATCH 4/4] clk: meson: meson8b: add the VPU clock trees

2019-03-20 Thread Neil Armstrong
On 19/03/2019 22:51, Martin Blumenstingl wrote: > The VPU clock tree is slightly different on all three supported SoCs: > > Meson8 only has an input mux (which chooses between "fclk_div4", > "fclk_div3", "fclk_div5" and "fclk_div7"), a divider and a gate. > > Meson8b has two VPU clock trees, each

Re: [PATCH V7 2/5] pwm: Add i.MX TPM PWM driver support

2019-03-20 Thread Uwe Kleine-König
Hello, On Wed, Mar 20, 2019 at 05:06:21AM +, Anson Huang wrote: > i.MX7ULP has TPM(Low Power Timer/Pulse Width Modulation Module) > inside, it can support multiple PWM channels, all the channels > share same counter and period setting, but each channel can > configure its duty and polarity ind

Re: [PATCH v2] arm64: dts: ls1088a: add one more thermal zone node

2019-03-20 Thread Shawn Guo
On Fri, Mar 08, 2019 at 09:57:09AM +, Andy Tang wrote: > > > > -Original Message- > > From: Daniel Lezcano > > Sent: 2019年3月8日 17:28 > > To: Andy Tang ; Shawn Guo > > Cc: Leo Li ; robh...@kernel.org; mark.rutl...@arm.com; > > linux-arm-ker...@lists.infradead.org; devicet...@vger.ker

Re: [PATCH 2/2] clk: meson: meson8b: add the video decoder clock trees

2019-03-20 Thread Neil Armstrong
On 19/03/2019 23:00, Martin Blumenstingl wrote: > This adds the four video decoder clock trees. > > VDEC_1 is split into two paths on Meson8b and Meson8m2: > - input mux called "vdec_1_sel" > - two dividers ("vdec_1_1_div" and "vdec_1_2_div") and gates ("vdec_1_1" > and "vdec_1_2") > - and an ou

Re: [PATCH] x86/Hyper-V: Fix definition HV_MAX_FLUSH_REP_COUNT

2019-03-20 Thread Thomas Gleixner
On Fri, 15 Mar 2019, Paolo Bonzini wrote: > On 22/02/19 11:48, lantianyu1...@gmail.com wrote: > > From: Lan Tianyu > > > > The max flush rep count of HvFlushGuestPhysicalAddressList hypercall > > is equal with how many entries of union hv_gpa_page_range can be populated > > into the input parame

[PATCH] arm64: dts: juno: Enable smmu_pcie for Juno r1/r2

2019-03-20 Thread Leo Yan
Though PCIe controller has been enabled on Juno r1/r2, but it misses to enable its connected SMMU. From the testing, even without set this SMMU status property to 'okay', the PCIe NIC device still works well. Since the SMMU is not enabled in DT binding and its iommu_groups is not created properly

Re: [PATCH -next] phy: tegra: xusb: Make two functions static

2019-03-20 Thread Thierry Reding
On Tue, Mar 19, 2019 at 11:32:19PM +0800, Yue Haibing wrote: > From: YueHaibing > > Fix sparse warning: > > drivers/phy/tegra/xusb-tegra186.c:250:6: warning: symbol > 'tegra_phy_xusb_utmi_pad_power_on' was not declared. Should it be static? > drivers/phy/tegra/xusb-tegra186.c:281:6: warning: sy

Re: [PATCH -next] clk: tegra: Make tegra_clk_super_mux_ops static

2019-03-20 Thread Thierry Reding
On Tue, Mar 19, 2019 at 11:35:04PM +0800, Yue Haibing wrote: > From: YueHaibing > > Fix sparse warning: > > drivers/clk/tegra/clk-super.c:124:22: > warning: symbol 'tegra_clk_super_mux_ops' was not declared. Should it be > static? > > Signed-off-by: YueHaibing > --- > drivers/clk/tegra/clk-

RE: [PATCH v2] arm64: dts: ls1088a: add one more thermal zone node

2019-03-20 Thread Andy Tang
Hi Shawn, > -Original Message- > From: Shawn Guo > Sent: 2019年3月20日 16:19 > To: Andy Tang > Cc: Daniel Lezcano ; mark.rutl...@arm.com; > devicet...@vger.kernel.org; linux...@vger.kernel.org; > linux-kernel@vger.kernel.org; Leo Li ; > edubez...@gmail.com; robh...@kernel.org; rui.zh...@int

Re: [PATCH] mm, memory_hotplug: Fix the wrong usage of N_HIGH_MEMORY

2019-03-20 Thread Michal Hocko
On Wed 20-03-19 16:07:32, Baoquan He wrote: > In function node_states_check_changes_online(), N_HIGH_MEMORY is used > to substitute ZONE_HIGHMEM directly. This is not right. N_HIGH_MEMORY > always has value '3' if CONFIG_HIGHMEM=y, while ZONE_HIGHMEM's value > is not. It depends on whether CONFIG_Z

Re: [PATCH] dt-bindings: clock: axg-audio: unexpose controller inputs

2019-03-20 Thread Neil Armstrong
On 13/02/2019 10:58, Jerome Brunet wrote: > Remove the bindings ID of the clock input of the controller. These > clocks are purely internal to the controller, exposing them was a > mistake. Actually, these should not even be in the provider and have > IDs to begin with. > > Unexpose these IDs befo

Re: [RFC 0/2] guarantee natural alignment for kmalloc()

2019-03-20 Thread Vlastimil Babka
On 3/20/19 1:43 AM, Christopher Lameter wrote: > On Tue, 19 Mar 2019, Vlastimil Babka wrote: > >> The recent thread [1] inspired me to look into guaranteeing alignment for >> kmalloc() for power-of-two sizes. Turns out it's not difficult and in most >> configuration nothing really changes as it ha

[PATCH] staging: rtl8188eu: remove unused WFD defines

2019-03-20 Thread Michael Straube
All defined WFD* in wifi.h are unused in the driver code, so remove them. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/include/wifi.h | 20 1 file changed, 20 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/wifi.h b/drivers/staging/rtl8188eu/inc

Re: [RFC RESEND PATCH 1/7] dt-bindings: soc: Add DVFSRC driver bindings

2019-03-20 Thread Nicolas Boichat
On Mon, Feb 18, 2019 at 12:55 PM Henry Chen wrote: > > Hi Rob, > > Sorry for late reply. I missed this mail before. > > On Fri, 2019-01-11 at 10:09 -0600, Rob Herring wrote: > > On Wed, Jan 02, 2019 at 10:09:52PM +0800, Henry Chen wrote: > > > Document the binding for enabling DVFSRC on MediaTek S

Re: [RESEND PATCH v1] moduleparam: Save information about built-in modules in separate file

2019-03-20 Thread Masahiro Yamada
On Fri, Mar 15, 2019 at 7:10 PM Alexey Gladkov wrote: > > Problem: > > When a kernel module is compiled as a separate module, some important > information about the kernel module is available via .modinfo section of > the module. In contrast, when the kernel module is compiled into the > kernel,

Re: static analysis bug report: staging r8712u memcpy of uninitialized variable

2019-03-20 Thread Dan Carpenter
On Mon, Mar 18, 2019 at 11:20:51AM +, Colin Ian King wrote: > Hi, > > Static analysis with cppcheck found a couple of interesting issues with > memcpy'ing of an uninitialized variable. Two occurrences of the same > issue are found in drivers/staging/rtl8712/rtl8712_cmd.c in functions > read_bb

Re: [PATCH 2/2] pwm: Kconfig: Enable ehrpwm driver to be compiled for ARCH_K3

2019-03-20 Thread Vignesh Raghavendra
Hi, On 12/03/19 3:00 PM, Uwe Kleine-König wrote: > On Tue, Mar 12, 2019 at 02:46:29PM +0530, Vignesh Raghavendra wrote: >> K3 devices have the same EHRPWM IP as OMAP SoCs. Enable driver to be built >> for K3 devices. Also, drop reference to AM33xx in help text, as IP is >> found on multiple TI SoC

Re: [PATCH] mm, memory_hotplug: Fix the wrong usage of N_HIGH_MEMORY

2019-03-20 Thread Baoquan He
On 03/20/19 at 09:46am, Michal Hocko wrote: > On Wed 20-03-19 16:07:32, Baoquan He wrote: > > In function node_states_check_changes_online(), N_HIGH_MEMORY is used > > to substitute ZONE_HIGHMEM directly. This is not right. N_HIGH_MEMORY > > always has value '3' if CONFIG_HIGHMEM=y, while ZONE_HIGH

Re: [PATCH] mm, memory_hotplug: Fix the wrong usage of N_HIGH_MEMORY

2019-03-20 Thread David Hildenbrand
On 20.03.19 10:06, Baoquan He wrote: > On 03/20/19 at 09:46am, Michal Hocko wrote: >> On Wed 20-03-19 16:07:32, Baoquan He wrote: >>> In function node_states_check_changes_online(), N_HIGH_MEMORY is used >>> to substitute ZONE_HIGHMEM directly. This is not right. N_HIGH_MEMORY >>> always has value

Re: [PATCH v4 1/1] mm: introduce put_user_page*(), placeholder versions

2019-03-20 Thread Kirill A. Shutemov
On Tue, Mar 19, 2019 at 01:01:01PM -0700, John Hubbard wrote: > On 3/19/19 7:06 AM, Kirill A. Shutemov wrote: > > On Tue, Mar 19, 2019 at 09:47:24AM -0400, Jerome Glisse wrote: > >> On Tue, Mar 19, 2019 at 03:04:17PM +0300, Kirill A. Shutemov wrote: > >>> On Fri, Mar 08, 2019 at 01:36:33PM -0800, j

Re: [PATCH] mm, memory_hotplug: Fix the wrong usage of N_HIGH_MEMORY

2019-03-20 Thread Baoquan He
On 03/20/19 at 10:11am, David Hildenbrand wrote: > On 20.03.19 10:06, Baoquan He wrote: > > On 03/20/19 at 09:46am, Michal Hocko wrote: > >> On Wed 20-03-19 16:07:32, Baoquan He wrote: > >>> In function node_states_check_changes_online(), N_HIGH_MEMORY is used > >>> to substitute ZONE_HIGHMEM direc

[PATCH RESEND] eventfd: prepare id to userspace via fdinfo

2019-03-20 Thread Masatake YAMATO
Finding endpoints of an IPC channel is one of essential task to understand how a user program works. Procfs and netlink socket provide enough hints to find endpoints for IPC channels like pipes, unix sockets, and pseudo terminals. However, there is no simple way to find endpoints for an eventfd fil

Re: regression (bisected): "modprobe parport_pc" hangs in current mainline

2019-03-20 Thread Sudip Mukherjee
Hi Michal, On Sun, Mar 17, 2019 at 6:05 PM Michal Kubecek wrote: > > On Sun, Mar 17, 2019 at 05:01:37PM +, Sudip Mukherjee wrote: > > On Wed, Mar 13, 2019 at 6:45 AM Michal Kubecek wrote: > > > I encountered a regression in current (post-5.0) mainline kernel which I > > > bisected to commit

Re: [PATCH v3] optee: allow to work without static shared memory

2019-03-20 Thread Jens Wiklander
Hi Volodymyr, On Mon, Mar 11, 2019 at 2:04 PM Volodymyr Babchuk wrote: > > From: Volodymyr Babchuk > > On virtualized systems it is possible that OP-TEE will provide > only dynamic shared memory support. So it is fine to boot > without static SHM enabled if dymanic one is supported. > > Signed-o

[PATCH] virt: vbox: Implement passing requestor info to the host for VirtualBox 6.0.x

2019-03-20 Thread Hans de Goede
VirtualBox 6.0.x has a new feature where the guest kernel driver passes info about the origin of the request (e.g. userspace or kernelspace) to the hypervisor. If we do not pass this information then when running the 6.0.x userspace guest-additions tools on a 6.0.x host, some requests will get den

Re: [PATCH] mm, memory_hotplug: Fix the wrong usage of N_HIGH_MEMORY

2019-03-20 Thread Michal Hocko
On Wed 20-03-19 17:06:24, Baoquan He wrote: > On 03/20/19 at 09:46am, Michal Hocko wrote: > > On Wed 20-03-19 16:07:32, Baoquan He wrote: > > > In function node_states_check_changes_online(), N_HIGH_MEMORY is used > > > to substitute ZONE_HIGHMEM directly. This is not right. N_HIGH_MEMORY > > > alw

Re: [PATCH v4 1/1] mm: introduce put_user_page*(), placeholder versions

2019-03-20 Thread Kirill A. Shutemov
On Tue, Mar 19, 2019 at 12:24:00PM -0700, John Hubbard wrote: > So, I could be persuaded either way. But given the lack of an visible perf > effects, and given that this could will get removed anyway because we'll > likely end up with set_page_dirty() called at GUP time instead...it seems > like it

Re: [PATCH] virt: vbox: Implement passing requestor info to the host for VirtualBox 6.0.x

2019-03-20 Thread Greg Kroah-Hartman
On Wed, Mar 20, 2019 at 10:35:19AM +0100, Hans de Goede wrote: > VirtualBox 6.0.x has a new feature where the guest kernel driver passes > info about the origin of the request (e.g. userspace or kernelspace) to > the hypervisor. > > If we do not pass this information then when running the 6.0.x us

Re: [PATCH] virt: vbox: Implement passing requestor info to the host for VirtualBox 6.0.x

2019-03-20 Thread Hans de Goede
Hi, On 20-03-19 10:46, Greg Kroah-Hartman wrote: On Wed, Mar 20, 2019 at 10:35:19AM +0100, Hans de Goede wrote: VirtualBox 6.0.x has a new feature where the guest kernel driver passes info about the origin of the request (e.g. userspace or kernelspace) to the hypervisor. If we do not pass this

Re: [PATCH v2 2/2] mfd: Add leds MFD cell for intel_soc_pmic_chtwc

2019-03-20 Thread Lee Jones
On Wed, 20 Mar 2019, Lee Jones wrote: > On Tue, 12 Feb 2019, Yauhen Kharuzhy wrote: > > > Add MFD cell for LEDs driver to the Intel Cherry Trail Whiskey Cove PMIC > > mfd device driver. > > > > Signed-off-by: Yauhen Kharuzhy > > --- > > drivers/mfd/intel_soc_pmic_chtwc.c | 1 + > > 1 file chan

Re: [PATCH v2 2/2] mfd: Add leds MFD cell for intel_soc_pmic_chtwc

2019-03-20 Thread Lee Jones
On Tue, 12 Feb 2019, Yauhen Kharuzhy wrote: > Add MFD cell for LEDs driver to the Intel Cherry Trail Whiskey Cove PMIC > mfd device driver. > > Signed-off-by: Yauhen Kharuzhy > --- > drivers/mfd/intel_soc_pmic_chtwc.c | 1 + > 1 file changed, 1 insertion(+) I'll fix up the subject line for you

Re: [PATCH v3 1/2] mfd: sec: Put one element structure initialisation on one line

2019-03-20 Thread Lee Jones
On Wed, 13 Feb 2019, Stuart Menefy wrote: > Change the layout of the initialisation of structures with one > element to a single line of code. This keeps the coding style > consistent. > > Signed-off-by: Stuart Menefy > --- > drivers/mfd/sec-core.c | 58 > +-

[PATCH RESEND] ARM: dts: exynos: Fix audio (microphone) routing on Odroid XU3

2019-03-20 Thread Sylwester Nawrocki
The name of CODEC input widget to which microphone is connected through the "Headphone" jack is "IN12" not "IN1". This fixes microphone support on Odroid XU3. Cc: # v4.14+ Signed-off-by: Sylwester Nawrocki --- arch/arm/boot/dts/exynos5422-odroidxu3-audio.dtsi | 2 +- 1 file changed, 1 insertion

Re: [PATCH v3 2/2] mfd: sec: Add support for the RTC on S2MPA01

2019-03-20 Thread Lee Jones
On Wed, 13 Feb 2019, Stuart Menefy wrote: > The RTC portion of the S2MPA01 appears to have the same > register layout as the S2MPS14. > > Reviewed-by: Krzysztof Kozlowski > Signed-off-by: Stuart Menefy Tags should be in chronological order. That way they can give us more information about the

[PATCH v2] clk: hi3660: Mark clk_gate_ufs_subsys as critical

2019-03-20 Thread Leo Yan
clk_gate_ufs_subsys is a system bus clock, turning off it will introduce lockup issue during system suspend flow. Let's mark clk_gate_ufs_subsys as critical clock, thus keeps it on during system suspend and resume. Fixes: d374e6fd5088 ("clk: hisilicon: Add clock driver for hi3660 SoC") Cc: sta...

Re: [PATCH 2/3] mm/sparse: Optimize sparse_add_one_section()

2019-03-20 Thread Baoquan He
Hi Mike, On 03/20/19 at 09:56am, Mike Rapoport wrote: > @@ -697,16 +697,17 @@ int __meminit sparse_add_one_section(int nid, unsigned > long start_pfn, > > ret = sparse_index_init(section_nr, nid); > > if (ret < 0 && ret != -EEXIST) > > return ret; > > - ret = 0; > > - me

RE: [PATCH V7 2/5] pwm: Add i.MX TPM PWM driver support

2019-03-20 Thread Anson Huang
Hi, Uwe Best Regards! Anson Huang > -Original Message- > From: Uwe Kleine-König [mailto:u.kleine-koe...@pengutronix.de] > Sent: 2019年3月20日 16:19 > To: Anson Huang > Cc: thierry.red...@gmail.com; robh...@kernel.org; mark.rutl...@arm.com; > shawn...@kernel.org; s.ha...@pengutronix.de; ker.

RE: [PATCH] hyperv: a potential NULL pointer dereference

2019-03-20 Thread Thomas Gleixner
On Thu, 14 Mar 2019, KY Srinivasan wrote: > > -Original Message- > > From: Kangjie Lu > > Sent: Wednesday, March 13, 2019 10:47 PM > > To: k...@umn.edu > > Cc: pakki...@umn.edu; KY Srinivasan ; Haiyang Zhang > > ; Stephen Hemminger > > ; Sasha Levin ; Thomas > > Gleixner ; Ingo Molnar ; Bo

Re: [PATCH 2/2] Revert "x86/hpet: Reduce HPET counter read contention"

2019-03-20 Thread Thomas Gleixner
On Mon, 18 Mar 2019, Waiman Long wrote: > On 03/18/2019 04:44 AM, Zhenzhong Duan wrote: > > https://lkml.org/lkml/2019/3/15/101 > > > I think what Thomas was asking is to provide a REALISTIC use case where > TSC is wrecked and HPET is somehow not used and we have to fall back to > use PM timer. If

Re: scif_insert_vma()

2019-03-20 Thread Jarkko Sakkinen
On Sun, Mar 17, 2019 at 10:47:40PM -0700, Sudeep Dutt wrote: > On Mon, 2019-03-11 at 08:45 +0200, Jarkko Sakkinen wrote: > > Hi > > > > Just wondering what will happen if kzalloc() fails in scif_mmap.c. How > > it is recovered? I don't see anything in the VMA callbacks taking care > > of this. >

Re: [PATCH] dt-bindings: reset: meson-g12a: Add missing USB2 PHY resets

2019-03-20 Thread Philipp Zabel
On Mon, 2019-03-04 at 11:49 +0100, Neil Armstrong wrote: > The G12A Documentation lacked these 2 reset lines, but they are present and > used for each USB 2 PHYs. > > Add them to the dt-bindings for the upcoming USB support. > > Fixes: dbfc54534dfc ("dt-bindings: reset: meson: add g12a bindings")

Re: [PATCH 2/2] platform/x86: intel_pmc_core: Allow to dump debug registers on S0ix failure

2019-03-20 Thread Rafael J. Wysocki
On Monday, March 18, 2019 5:01:06 PM CET Rajneesh Bhardwaj wrote: > On Mon, Mar 18, 2019 at 08:18:56AM -0700, Rajat Jain wrote: > > On Mon, Mar 18, 2019 at 2:31 AM Somayaji, Vishwanath > > wrote: > > > > > > > > > > > > >-Original Message- > > > >From: Rajat Jain > > > >Sent: Thursday, Ma

Re: [PATCH] staging: rtlwifi: Fix potential NULL pointer dereference

2019-03-20 Thread Dan Carpenter
On Wed, Mar 13, 2019 at 11:13:34AM -0500, Aditya Pakki wrote: > phydm.internal is allocated using kzalloc which is used multiple > times without a check for NULL pointer. This patch avoids such a > scenario. > > Signed-off-by: Aditya Pakki > --- > drivers/staging/rtlwifi/phydm/rtl_phydm.c | 3 ++

Re: [PATCH] rtc: cros-ec: Fail suspend/resume if wake IRQ can't be configured

2019-03-20 Thread Alexandre Belloni
On 15/03/2019 11:51:12-0700, Stephen Boyd wrote: > If we encounter a failure during suspend where this RTC was programmed > to wakeup the system from suspend, but that wakeup couldn't be > configured because the system didn't support wakeup interrupts, we'll > run into the following warning: > >

Re: [PATCH 18/52] virtio-fs: Map cache using the values from the capabilities

2019-03-20 Thread Dr. David Alan Gilbert
* Liu Bo (obuil.li...@gmail.com) wrote: > On Mon, Dec 10, 2018 at 9:57 AM Vivek Goyal wrote: > > > > Instead of assuming we had the fixed bar for the cache, use the > > value from the capabilities. > > > > Signed-off-by: Dr. David Alan Gilbert > > --- > > fs/fuse/virtio_fs.c | 32 +++

Re: [PATCH] thunderbolt: Fix to check for kmemdup failure

2019-03-20 Thread Mika Westerberg
On Mon, Mar 18, 2019 at 05:44:17PM -0500, Aditya Pakki wrote: > Memory allocated via kmemdup might fail and return a NULL pointer. > This patch adds a check on the return value of kmemdup and passes the > error upstream. > > Signed-off-by: Aditya Pakki Applied, thanks!

[PATCH] of: Drop redundant check in linker section OF match table

2019-03-20 Thread Mukesh Ojha
Existing check of `fn` against NULL inside OF match table is redundant. Remove the check. Signed-off-by: Mukesh Ojha Cc: Rob Herring Cc: Frank Rowand Cc: Pantelis Antoniou Cc: devicet...@vger.kernel.org --- include/linux/of.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --g

Re: [PATCH] thunderbolt: Fix to check return value of ida_simple_get

2019-03-20 Thread Mika Westerberg
On Tue, Mar 19, 2019 at 12:22:59PM -0500, Aditya Pakki wrote: > ida_simple_get on failure can return an error. The patch ensures that > the dev_set_name is set on non failure cases. > > Signed-off-by: Aditya Pakki > --- > drivers/thunderbolt/xdomain.c | 4 +++- > 1 file changed, 3 insertions(+),

Re: [PATCH V7 2/5] pwm: Add i.MX TPM PWM driver support

2019-03-20 Thread Uwe Kleine-König
Hello Anson, On Wed, Mar 20, 2019 at 10:17:50AM +, Anson Huang wrote: > > On Wed, Mar 20, 2019 at 05:06:21AM +, Anson Huang wrote: > > > + /* make sure counter is disabled for programming prescale */ > > > + val = readl(tpm->base + PWM_IMX_TPM_SC); > > > + saved_cmod = FIELD_GET(PWM_IMX_TP

Re:

2019-03-20 Thread Felipe Franciosi
> On Mar 19, 2019, at 2:41 PM, Maxim Levitsky wrote: > > Date: Tue, 19 Mar 2019 14:45:45 +0200 > Subject: [PATCH 0/9] RFC: NVME VFIO mediated device > > Hi everyone! > > In this patch series, I would like to introduce my take on the problem of > doing > as fast as possible virtualization of

RE: [RFC PATCH] x86/entry/64: randomize kernel stack offset upon syscall

2019-03-20 Thread David Laight
From: Andy Lutomirski > Sent: 18 March 2019 20:16 ... > > As a result this patch introduces 8 bits of randomness > > (bits 4 - 11 are randomized, bits 0-3 must be zero due to stack alignment) > > after pt_regs location on the thread stack. > > The amount of randomness can be adjusted based on how m

Re: [PATCH 2/2] clk: meson: meson8b: add the video decoder clock trees

2019-03-20 Thread Maxime Jourdan
Hi Martin, thanks for looking into the video decoder for meson8! On Tue, Mar 19, 2019 at 11:00 PM Martin Blumenstingl wrote: > > This adds the four video decoder clock trees. > > VDEC_1 is split into two paths on Meson8b and Meson8m2: > - input mux called "vdec_1_sel" > - two dividers ("vdec_1_1_d

RE: [PATCH 02/25] tracing: Improve "if" macro code generation

2019-03-20 Thread David Laight
From: > Peter Zijlstra > Sent: 18 March 2019 15:39 > > With CONFIG_PROFILE_ALL_BRANCHES, the "if" macro converts the > conditional to an array index. This can cause GCC to create horrible > code. When there are nested ifs, the generated code uses register > values to encode branching decisions.

Re: [PATCH v2] kernel/trace: fix watchdog soft lockup

2019-03-20 Thread Anders Roxell
On Fri, 30 Nov 2018 at 16:18, Steven Rostedt wrote: > > On Fri, 30 Nov 2018 15:56:22 +0100 > Anders Roxell wrote: > > > When building a allmodconfig kernel for arm64 and boot that in qemu, > > CONFIG_FTRACE_STARTUP_TEST gets enabled and that takes time so the > > watchdog expires and prints out a

Re: [PATCH 1/3] mm/sparse: Clean up the obsolete code comment

2019-03-20 Thread Matthew Wilcox
On Wed, Mar 20, 2019 at 03:35:38PM +0800, Baoquan He wrote: > /* > - * returns the number of sections whose mem_maps were properly > - * set. If this is <=0, then that means that the passed-in > - * map was not consumed and must be freed. > + * sparse_add_one_section - add a memory section > + *

RE: [PATCH V7 2/5] pwm: Add i.MX TPM PWM driver support

2019-03-20 Thread Anson Huang
Hi, Uwe Best Regards! Anson Huang > -Original Message- > From: Uwe Kleine-König [mailto:u.kleine-koe...@pengutronix.de] > Sent: 2019年3月20日 18:58 > To: Anson Huang > Cc: thierry.red...@gmail.com; robh...@kernel.org; mark.rutl...@arm.com; > shawn...@kernel.org; s.ha...@pengutronix.de; ker.

Re: [PATCH 2/3] mm/sparse: Optimize sparse_add_one_section()

2019-03-20 Thread Matthew Wilcox
On Wed, Mar 20, 2019 at 06:13:18PM +0800, Baoquan He wrote: > + if (!memmap) { > + ret = -ENOMEM; > + goto out2; Documentation/process/coding-style: Choose label names which say what the goto does or why the goto exists. An example of a good name could be ``out_free_b

Re: [PATCH] arm64: dts: juno: Enable smmu_pcie for Juno r1/r2

2019-03-20 Thread Robin Murphy
Hi Leo, On 20/03/2019 08:31, Leo Yan wrote: Though PCIe controller has been enabled on Juno r1/r2, but it misses to enable its connected SMMU. From the testing, even without set this SMMU status property to 'okay', the PCIe NIC device still works well. Since the SMMU is not enabled in DT bindi

Re: [PATCH 2/3] mm/sparse: Optimize sparse_add_one_section()

2019-03-20 Thread Mike Rapoport
On Wed, Mar 20, 2019 at 06:13:18PM +0800, Baoquan He wrote: > Hi Mike, > > On 03/20/19 at 09:56am, Mike Rapoport wrote: > > @@ -697,16 +697,17 @@ int __meminit sparse_add_one_section(int nid, > unsigned long start_pfn, > > > ret = sparse_index_init(section_nr, nid); > > > if (ret < 0 && ret

Re: [PATCH] rcu: Allow to eliminate softirq processing from rcutree

2019-03-20 Thread Sebastian Andrzej Siewior
On 2019-03-19 20:26:13 [-0400], Joel Fernandes wrote: > > @@ -2769,19 +2782,121 @@ static void invoke_rcu_callbacks(struct rcu_data > > *rdp) > > { > > if (unlikely(!READ_ONCE(rcu_scheduler_fully_active))) > > return; > > - if (likely(!rcu_state.boost)) { > > - rcu_do_

Re: [PATCH] pwm: img: Turn final 'else if' into 'else' in img_pwm_config

2019-03-20 Thread Thierry Reding
On Thu, Mar 07, 2019 at 03:36:28PM -0700, Nathan Chancellor wrote: > When building with -Wsometimes-uninitialized, Clang warns: > > drivers/pwm/pwm-img.c:126:13: error: variable 'timebase' is used > uninitialized whenever 'if' condition is false > [-Werror,-Wsometimes-uninitialized] > > The final

Re: [PATCH] pwm: tiehrpwm: Update shadow register for disabling PWMs

2019-03-20 Thread Thierry Reding
On Tue, Mar 12, 2019 at 02:38:46PM +0530, Vignesh Raghavendra wrote: > From: Christoph Vogtländer > > It must be made sure that immediate mode is not already set, when > modifying shadow register value in ehrpwm_pwm_disable(). Otherwise > modifications to the action-qualifier continuous S/W force

Re: [PATCH v2] rcu: Allow to eliminate softirq processing from rcutree

2019-03-20 Thread Sebastian Andrzej Siewior
On 2019-03-19 12:44:19 [+0100], To Paul E. McKenney wrote: > diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c > index 0f31b79eb6761..0a719f726e149 100644 > --- a/kernel/rcu/tree.c > +++ b/kernel/rcu/tree.c … > +/* > + * Spawn per-CPU RCU core processing kthreads. > + */ > +static int __init rcu_s

  1   2   3   4   5   6   7   8   >