[PATCH v6 4/4] can: tcan4x5x: Add tcan4x5x driver to the kernel

2019-03-01 Thread Dan Murphy
Add the TCAN4x5x SPI CAN driver. This device uses the Bosch MCAN IP core along with a SPI interface map. Register to the MCAN common core code to manage the MCAN IP. This device has a special method to indicate a write/read operation on the data payload. Signed-off-by: Dan Murphy --- v6 - Upda

[PATCH] ACPI/PPTT: Simplify leaf node detection.

2019-03-01 Thread Jeremy Linton
ACPI 6.3 bumps the PPTT table revision and adds a LEAF_NODE flag. This allows us to avoid a second pass through the table to assure that the node in question is a leaf. Signed-off-by: Jeremy Linton --- drivers/acpi/pptt.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/acpi/pptt.c

[PATCH v2] ARM: sun8i: h3: bluetooth for Banana Pi M2 Zero board

2019-03-01 Thread Andreas Kemnade
The Banana Pi M2 Zero board has an AP6212 BT+Wifi combo chip with broadcom internals attached to UART1 and some gpios. This addition is in line with similar boards Signed-off-by: Andreas Kemnade --- changes in v2: remove pinctrl things arch/arm/boot/dts/sun8i-h2-plus-bananapi-m2-zero.dts | 15 ++

Re: [PATCH] soc: qcom: cmd-db: Fix an error code in cmd_db_dev_probe()

2019-03-01 Thread Bjorn Andersson
On Wed 27 Feb 21:48 PST 2019, Dan Carpenter wrote: > The memremap() function doesn't return error pointers, it returns NULL. > This code is returning "ret = PTR_ERR(NULL);" which is success, but it > should return -ENOMEM. > > Fixes: 312416d9171a ("drivers: qcom: add command DB driver") > Signed-

Re: [PATCH v4 2/5] base: soc: Export soc_device_register/unregister APIs

2019-03-01 Thread Bjorn Andersson
On Sun 24 Feb 22:50 PST 2019, Vaishali Thakkar wrote: > From: Vinod Koul > > Qcom Socinfo driver can be built as a module, so > export these two APIs. > > Signed-off-by: Vinod Koul > Signed-off-by: Vaishali Thakkar > Reviewed-by: Greg Kroah-Hartman Reviewed-by: Bjorn Andersson Regards, Bj

Re: [PATCH net-next] drivers: net: Remove unnecessary semicolon

2019-03-01 Thread Sean Wang
On Fri, 2019-03-01 at 16:09 +0800, Yue Haibing wrote: > From: YueHaibing > > drivers/net/dsa/mt7530.c:649:3-4: Unneeded semicolon > drivers/net/ethernet/cisco/enic/enic_clsf.c:35:2-3: Unneeded semicolon > drivers/net/ethernet/faraday/ftgmac100.c:1640:2-3: Unneeded semicolon > drivers/net/ethernet

Re: [PATCH v3] page cache: Store only head pages in i_pages

2019-03-01 Thread Song Liu
On Fri, Feb 15, 2019 at 2:25 PM Matthew Wilcox wrote: > > Transparent Huge Pages are currently stored in i_pages as pointers to > consecutive subpages. This patch changes that to storing consecutive > pointers to the head page in preparation for storing huge pages more > efficiently in i_pages. >

[PATCH v4] Drivers: hv: vmbus: Expose monitor data only when monitor pages are used

2019-03-01 Thread Kimberly Brown
There are two methods for signaling the host: the monitor page mechanism and hypercalls. The monitor page mechanism is used by performance critical channels (storage, networking, etc.) because it provides improved throughput. However, latency is increased. Monitor pages are allocated to these chann

Re: [PATCH] iommu/arm-smmu: Allow disabling bypass via kernel config

2019-03-01 Thread Doug Anderson
Hi, On Fri, Feb 15, 2019 at 2:37 PM Rob Clark wrote: > > On Thu, Feb 14, 2019 at 7:40 PM Doug Anderson wrote: > > > > Hi, > > > > On Thu, Feb 14, 2019 at 1:32 PM Robin Murphy wrote: > > > > > > Hi Doug, > > > > > > On 2019-02-14 8:44 pm, Douglas Anderson wrote: > > > > Right now the only way to

[PATCH v2] iommu/arm-smmu: Break insecure users by disabling bypass by default

2019-03-01 Thread Douglas Anderson
If you're bisecting why your peripherals stopped working, it's probably this CL. Specifically if you see this in your dmesg: Unexpected global fault, this could be serious ...then it's almost certainly this CL. Running your IOMMU-enabled peripherals with the IOMMU in bypass mode is insecure and

Re: [PATCH net-next v4 0/4] enetc: Add mdio support and device tree nodes

2019-03-01 Thread David Miller
From: Claudiu Manoil Date: Tue, 26 Feb 2019 15:42:19 +0200 > This is the missing part to enable PCI probing of the ENETC ethernet > ports on the LS1028A SoC and external traffic on the LS1028A RDB board. > It's one of the first items on the TODO list for the recently merged > ENETC ethernet drive

[PATCH] cros_ec: Expose sysfile to force battery cut-off on shutdown.

2019-03-01 Thread RaviChandra Sadineni
On chromebooks, power_manager daemon normally shutsdown(S5) the device when the battery charge falls below 4% threshold. ChromeOS EC then normally spends an hour in S5 before hibernating. If the battery charge falls below critical threshold in the mean time, EC does a battery cutoff instead of hibe

Re: [PATCH v4 3/5] soc: qcom: Add socinfo driver

2019-03-01 Thread Bjorn Andersson
On Sun 24 Feb 22:50 PST 2019, Vaishali Thakkar wrote: [..] > diff --git a/drivers/soc/qcom/Makefile b/drivers/soc/qcom/Makefile > index f25b54cd6cf8..c817da4f4140 100644 > --- a/drivers/soc/qcom/Makefile > +++ b/drivers/soc/qcom/Makefile > @@ -14,6 +14,7 @@ qcom_rpmh-y += rpmh-rsc.

Re: [PATCH v5] panic: Avoid the extra noise dmesg

2019-03-01 Thread Steven Rostedt
On Fri, 1 Mar 2019 09:54:01 +0100 Petr Mladek wrote: I'll put my $0.02 in, and say I like the idea of the patch too. > > > Thoughts: > > > > > > - why do the suppression in vprintk_emit()? Doing it right at entry > > > to printk() seems cleaner, more explicit? > > > > Yes, I put it in pr

Re: [PATCH] scripts: checkpatch: Check multiple blank lines when deleting code

2019-03-01 Thread Joe Perches
On Thu, 2019-02-28 at 13:15 -0500, Alexandre Ghiti wrote: > By matching only current line starting with '+', we miss the case > when deleting code makes consecutive blank lines appear: this patch > then makes it possible to detect this case by also matching current > line starting with ' ', which i

Re: [PATCH v5 00/10] arm64: add system vulnerability sysfs entries

2019-03-01 Thread Stefan Wahren
Hi Jeremy, > Jeremy Linton hat am 27. Februar 2019 um 02:05 > geschrieben: > > > Arm64 machines should be displaying a human readable > vulnerability status to speculative execution attacks in > /sys/devices/system/cpu/vulnerabilities > > This series enables that behavior by providing the ex

Re: [PATCH] PCI: imx6: Don't request "pci_aux" clock on i.MX7

2019-03-01 Thread Trent Piepho
On Fri, 2019-03-01 at 00:55 -0800, Andrey Smirnov wrote: > The clock in question is not present on i.MX7, so move the code > requesting it into i.MX8MQ-only path. > > Fixes: eeb61c4e8530 ("PCI: imx6: Add code to request/control > "pcie_aux" clock for i.MX8MQ") > Reported-by: Trent Piepho > Signed

[RFC PATCH v1 03/15] iommu/io-pgtable: Allow TLB operations to be optional

2019-03-01 Thread Jordan Crouse
An upcoming change to arm-smmu will add auxiliary domains that will allow a leaf driver to create and map additional pagetables for device specific uses. By definition aux arm-smmu domains will not be allowed to touch the hardware directly so allow for the TLB operations for a given pagetable confi

[RFC PATCH v1 02/15] iommu/arm-smmu: Add split pagetable support for arm-smmu-v2

2019-03-01 Thread Jordan Crouse
Add support for a split pagetable (TTBR0/TTBR1) scheme for arm-smmu-v2. If split pagetables are enabled, create a pagetable for TTBR1 and set up the sign extension bit so that all IOVAs with that bit set are mapped and translated from the TTBR1 pagetable. Signed-off-by: Jordan Crouse --- driver

[RFC PATCH v1 01/15] iommu: Add DOMAIN_ATTR_SPLIT_TABLES

2019-03-01 Thread Jordan Crouse
Add a new domain attribute to enable split pagetable support for devices devices that support it. Signed-off-by: Jordan Crouse --- include/linux/iommu.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/iommu.h b/include/linux/iommu.h index e90da6b..3f2250b 100644 --- a/include/

[RFC PATCH v1 08/15] drm/msm: Pass the MMU domain index in struct msm_file_private

2019-03-01 Thread Jordan Crouse
Pass the index of the MMU domain in struct msm_file_private instead of assuming gpu->id throughout the submit path. This clears the way to change ctx->aspace to a per-instance pagetable. Signed-off-by: Jordan Crouse --- drivers/gpu/drm/msm/msm_drv.c| 2 ++ drivers/gpu/drm/msm/msm_drv.h

[RFC PATCH v1 07/15] drm/msm: Print all 64 bits of the faulting IOMMU address

2019-03-01 Thread Jordan Crouse
When we move to 64 bit addressing for a5xx and a6xx targets we will start seeing pagefaults at larger addresses so format them appropriately in the log message for easier debugging. Signed-off-by: Jordan Crouse --- drivers/gpu/drm/msm/msm_iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deleti

[RFC PATCH v1 05/15] iommu/arm-smmu: Add auxiliary domain support for arm-smmuv2

2019-03-01 Thread Jordan Crouse
Support the new auxiliary domain API for arm-smmuv2 to initialize and support multiple pagetables for a SMMU device. Since the smmu-v2 hardware doesn't have any built in support for switching the pagetable base it is left as an exercise to the caller to actually use the pagetable; aux domains in th

[RFC PATCH v1 10/15] drm/msm: Add support for IOMMU auxiliary domains

2019-03-01 Thread Jordan Crouse
Add support for creating a auxiliary domain from the IOMMU device to implement per-instance pagetables. Also add a helper function to return the pagetable base address (ttbr) and asid to the caller so that the GPU target code can set up the pagetable switch. Signed-off-by: Jordan Crouse --- dri

[RFC PATCH v1 11/15] drm/msm: Add a helper function for a per-instance address space

2019-03-01 Thread Jordan Crouse
Add a helper function to create a GEM address space attached to an iommu auxiliary domain for a per-instance pagetable. Signed-off-by: Jordan Crouse --- drivers/gpu/drm/msm/msm_drv.h | 4 +++ drivers/gpu/drm/msm/msm_gem_vma.c | 53 +++ 2 files changed, 3

[RFC PATCH v1 00/15] drm/msm: Per-instance pagetable support

2019-03-01 Thread Jordan Crouse
This is the latest incarnation of per-instance pagetable support for the MSM GPU driver. Some of these have been seen before, most recently [1]. Per-instance pagetables allow the target GPU driver to create and manage an individual pagetable for each file descriptor instance and switch between the

[RFC PATCH v1 04/15] iommu: Add DOMAIN_ATTR_PTBASE

2019-03-01 Thread Jordan Crouse
Add an attribute to return the base address of the pagetable. This is used by auxiliary domains from arm-smmu to return the address of the pagetable to the leaf driver so that it can set the appropriate pagetable through it's own means. Signed-off-by: Jordan Crouse --- include/linux/iommu.h | 1

[RFC PATCH v1 06/15] drm/msm/adreno: Enable 64 bit mode by default on a5xx and a6xx targets

2019-03-01 Thread Jordan Crouse
A5XX and newer GPUs can be run in either 32 or 64 bit mode. The GPU registers and the microcode use 64 bit virtual addressing in either case but the upper 32 bits are ignored if the GPU is in 32 bit mode. There is no performance disadvantage to remaining in 64 bit mode even if we are only generatin

[RFC PATCH v1 14/15] drm/msm/a6xx: Support per-instance pagetables

2019-03-01 Thread Jordan Crouse
Add support for per-instance pagetables for a6xx targets. Add support to handle split pagetables and create a new instance if the needed IOMMU support exists and insert the necessary PM4 commands to trigger a pagetable switch at the beginning of a user command. Signed-off-by: Jordan Crouse ---

[RFC PATCH v1 09/15] drm/msm/gpu: Move address space setup to the GPU targets

2019-03-01 Thread Jordan Crouse
Move the address space steup code out of the generic msm GPU code to to the individual GPU targets. This allows us to do target specific setup such as gpummu for a2xx or split pagetables and per-instance pagetables for newer a5xx and a6xx targets. All this is at the expense of duplicated code in so

[RFC PATCH v1 13/15] drm/msm/gpu: Add ttbr0 to the memptrs

2019-03-01 Thread Jordan Crouse
Targets that support per-instance pagetable switching will have to keep track of which pagetable belongs to each instance to be able to recover for preemption. Signed-off-by: Jordan Crouse --- drivers/gpu/drm/msm/msm_ringbuffer.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/d

[RFC PATCH v1 15/15] drm/msm/a5xx: Support per-instance pagetables

2019-03-01 Thread Jordan Crouse
Add support for per-instance pagetables for 5XX targets. Create a support buffer for preemption to hold the SMMU pagetable information for a preempted ring, enable TTBR1 to support split pagetables and add the necessary PM4 commands to trigger a pagetable switch at the beginning of a user command.

[RFC PATCH v1 12/15] drm/msm: Add support to create target specific address spaces

2019-03-01 Thread Jordan Crouse
Add support to create a GPU target specific address space for a context. For those targets that support per-instance pagetables they will return a new address space set up for the instance if possible otherwise just use the global device pagetable. Signed-off-by: Jordan Crouse --- drivers/gpu/d

Re: [PATCH v4 4/5] soc: qcom: socinfo: Expose custom attributes

2019-03-01 Thread Bjorn Andersson
On Sun 24 Feb 22:50 PST 2019, Vaishali Thakkar wrote: > +#ifdef CONFIG_DEBUG_FS > +/* pmic model info */ Please drop this comment and make "pmic_model" plural. > +static const char *const pmic_model[] = { > + [0] = "Unknown PMIC model", > + [9] = "PM8994", > + [11] = "PM8916", > +

Re: [PATCH RFC] mm/vmscan: try to protect active working set of cgroup from reclaim.

2019-03-01 Thread Andrey Ryabinin
On 3/1/19 8:49 PM, Johannes Weiner wrote: > Hello Andrey, > > On Fri, Mar 01, 2019 at 01:38:26PM +0300, Andrey Ryabinin wrote: >> On 2/26/19 3:50 PM, Andrey Ryabinin wrote: >>> On 2/22/19 10:15 PM, Johannes Weiner wrote: On Fri, Feb 22, 2019 at 08:58:25PM +0300, Andrey Ryabinin wrote:

Re: [PATCH v4 5/5] soc: qcom: socinfo: Expose image information

2019-03-01 Thread Bjorn Andersson
On Sun 24 Feb 22:50 PST 2019, Vaishali Thakkar wrote: > +#define IMAGE_SHOW_OEM(attr) \ > +static int show_ ##attr## _oem(struct seq_file *seq, void *p) > \ > +{ \ > + s

Re: [PATCH] wusb: Remove unnecessary static function ckhdid_printf

2019-03-01 Thread Greg KH
On Fri, Mar 01, 2019 at 10:18:32AM -0800, Nick Desaulniers wrote: > On Thu, Feb 28, 2019 at 8:38 PM Joe Perches wrote: > > > > This static inline is unnecessary and can be removed > > by using the vsprintf %ph extension. > > > > This reduces overall object size by more than 2K. > > > > Signed-off-

[PATCH 1/3] add generic builtin command line

2019-03-01 Thread Daniel Walker
This code allows architectures to use a generic builtin command line. The state of the builtin command line options across architecture is diverse. On x86 and mips they have pretty much the same code and the code prepends the builtin command line onto the boot loader provided one. On powerpc there

[PATCH 2/3] powerpc: convert to generic builtin command line

2019-03-01 Thread Daniel Walker
This updates the powerpc code to use the CONFIG_GENERIC_CMDLINE option. [maksym.kok...@globallogic.com: add strlcat to prom_init_check.sh whitelist] Cc: Daniel Walker Cc: Daniel Walker Cc: xe-linux-exter...@cisco.com Signed-off-by: Daniel Walker Signed-off-by: Maksym Kokhan --- arch/powerpc/K

[PATCH 3/3] powerpc: convert config files to generic cmdline

2019-03-01 Thread Daniel Walker
This is a scripted mass convert of the config files to use the new generic cmdline. There is a bit of a trim effect here. It would seems that some of the config haven't been trimmed in a while. The script used to convert is as follows, if [[ -z "$1" || -z "$2" ]]; then echo "Two arguments

Re: [PATCH v3] cfi: fix deadloop in cfi_cmdset_0002.c do_write_buffer

2019-03-01 Thread Boris Brezillon
The "mtd: " prefix is still missing. Should be "mtd: cfi: ". If you send a new version, please fix that. Thanks, Boris On Tue, 26 Feb 2019 22:00:48 +0800 Liu Jian wrote: > In function do_write_buffer(), in the for loop, there is a case > chip_ready() returns 1 while chip_good() returns 0, so i

Re: [PATCH v2 2/4] mm: remove zone_lru_lock() function access ->lru_lock directly

2019-03-01 Thread John Hubbard
On 3/1/19 2:51 AM, Andrey Ryabinin wrote: > > > On 3/1/19 12:44 AM, John Hubbard wrote: >> On 2/28/19 12:33 AM, Andrey Ryabinin wrote: >>> We have common pattern to access lru_lock from a page pointer: >>> zone_lru_lock(page_zone(page)) >>> >>> Which is silly, because it unfolds to this: >>>

Re: [PATCH] selftests: x86: add version check in test_syscall_vdso

2019-03-01 Thread Andy Lutomirski
> On Feb 28, 2019, at 4:18 PM, Steve Muckle wrote: > > Since 4.17 registers r8-r11 are not clobbered/zeroed by a 64-bit kernel > handling a 32-bit syscall and this behavior is enforced by the > test_syscall_vdso testcase. See commit 8bb2610bc496 > ("x86/entry/64/compat: Preserve r8-r11 in int $0x8

[PATCH] arm64/stacktrace: Export save_stack_trace_regs()

2019-03-01 Thread William Cohen
The ARM64 implements the save_stack_trace_regs function, but it is unusable for any diagnostic tooling compiled as a kernel module due the missing EXPORT_SYMBOL_GPL for the function. Export save_stack_trace_regs() to align with other architectures such as s390, openrisc, and powerpc. This is simil

Re: [RFC net-next 0/8] Introducing subdev bus and devlink extension

2019-03-01 Thread Jakub Kicinski
On Thu, 28 Feb 2019 23:37:44 -0600, Parav Pandit wrote: > Use case: > - > A user wants to create/delete hardware linked sub devices without > using SR-IOV. > These devices for a pci device can be netdev (optional rdma device) > or other devices. Such sub devices share some of the PCI device

[PATCH] fs: use KERNEL_DS instead of get_ds()

2019-03-01 Thread Jann Horn
get_ds() is a legacy name for KERNEL_DS; all architectures #define it to KERNEL_DS, and almost every user of set_fs() uses the name KERNEL_DS. Let the VFS also use KERNEL_DS so that we can get rid of get_ds() at some point. Signed-off-by: Jann Horn --- fs/read_write.c | 6 +++--- fs/splice.c

[PATCH] integrity: use KERNEL_DS instead of get_ds()

2019-03-01 Thread Jann Horn
get_ds() is a legacy name for KERNEL_DS; all architectures #define it to KERNEL_DS, and almost every user of set_fs() uses the name KERNEL_DS. Let the integrity subsystem also use KERNEL_DS so that we can get rid of get_ds() at some point. Signed-off-by: Jann Horn --- security/integrity/iint.c

[PATCH] staging: rtl8723bs: use kernel_read() instead of open-coded version

2019-03-01 Thread Jann Horn
Replace the manual call to f_op->read() under KERNEL_DS with kernel_read(). This also reduces the number of users of the legacy alias get_ds() for KERNEL_DS. Signed-off-by: Jann Horn --- .../staging/rtl8723bs/os_dep/osdep_service.c | 23 ++- 1 file changed, 7 insertions(+), 16 d

Re: [PATCH 1/3] dt-bindings: Add doc for the ingenic-drm driver

2019-03-01 Thread Sam Ravnborg
Hi Paul. Good to see work migrating fbdev => drm. Following comments is based on experience while working on migrating another driver from fbdev => drm. On Thu, Feb 28, 2019 at 07:07:54PM -0300, Paul Cercueil wrote: > Add documentation for the devicetree bindings of the DRM driver for the > JZ47

[PATCH v2] mm/hotplug: fix an imbalance with DEBUG_PAGEALLOC

2019-03-01 Thread Qian Cai
When onlining a memory block with DEBUG_PAGEALLOC, it unmaps the pages in the block from kernel, However, it does not map those pages while offlining at the beginning. As the result, it triggers a panic below while onlining on ppc64le as it checks if the pages are mapped before unmapping. However,

Re: [RFC PATCH v1 15/15] drm/msm/a5xx: Support per-instance pagetables

2019-03-01 Thread Rob Clark
On Fri, Mar 1, 2019 at 2:39 PM Jordan Crouse wrote: > > Add support for per-instance pagetables for 5XX targets. Create a support > buffer for preemption to hold the SMMU pagetable information for a > preempted ring, enable TTBR1 to support split pagetables and add the > necessary PM4 commands to

Re: [Freedreno] [RFC PATCH v1 02/15] iommu/arm-smmu: Add split pagetable support for arm-smmu-v2

2019-03-01 Thread Rob Clark
On Fri, Mar 1, 2019 at 2:38 PM Jordan Crouse wrote: > > Add support for a split pagetable (TTBR0/TTBR1) scheme for > arm-smmu-v2. If split pagetables are enabled, create a > pagetable for TTBR1 and set up the sign extension bit so > that all IOVAs with that bit set are mapped and translated > from

Re: [PATCH] log2: make is_power_of_2() integer constant expression when possible

2019-03-01 Thread Andrew Morton
On Fri, 1 Mar 2019 14:52:07 +0200 Jani Nikula wrote: > While is_power_of_2() is an inline function and likely gets optimized > for compile time constant arguments, it still doesn't produce an integer > constant expression that could be used in, say, static data > initialization or case labels.

Re: [PATCH] percpu/module resevation: change resevation size iff X86_VSMP is set

2019-03-01 Thread Dennis Zhou
Hi Barret, On Fri, Mar 01, 2019 at 01:30:15PM -0500, Barret Rhoden wrote: > Hi - > > On 01/21/2019 06:47 AM, Eial Czerwacki wrote: > > > > Your main issue was that you only sent this patch to LKML, but not the > maintainers of the file. If you don't, your patch might get lost. To get > the app

Re: next/master boot bisection: next-20190215 on beaglebone-black

2019-03-01 Thread Andrew Morton
On Fri, 1 Mar 2019 09:25:24 +0100 Guillaume Tucker wrote: > >>> Michal had asked if the free space accounting fix up addressed this > >>> boot regression? I was awaiting word on that. > >> > >> hm, does b...@kernelci.org actually read emails? Let's try info@ as well.. > > b...@kernelci.org is

Re: [PATCH net-next] net: dsa: Do not configure VLAN ID 0

2019-03-01 Thread David Miller
From: Florian Fainelli Date: Fri, 1 Mar 2019 09:54:07 -0800 > David, please discard this version, I will submit a version that > properly emulates the prepare/commit phase such that no assumptions are > broken, this will take care of both issues at once. Thanks! Ok.

Re: Clang warning in drivers/net/ethernet/intel/igc/igc_ethtool.c

2019-03-01 Thread Michal Kubecek
On Fri, Mar 01, 2019 at 10:28:35AM -0800, Nick Desaulniers wrote: > On Fri, Feb 8, 2019 at 6:34 AM Michal Kubecek wrote: > > > > On Thu, Feb 07, 2019 at 10:09:21PM -0700, Nathan Chancellor wrote: > > > Hi all, > > > > > > After commit 8c5ad0dae93c ("igc: Add ethtool support"), Clang warns: > > > >

[PATCH] ASoC: ab8500: Mark expected switch fall-through

2019-03-01 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. This patch fixes the following warning: In file included from sound/soc/codecs/ab8500-codec.c:24: sound/soc/codecs/ab8500-codec.c: In function ‘ab8500_codec_set_dai_fmt’: ./include/linux/d

Re: [PATCH v2] mm/hotplug: fix an imbalance with DEBUG_PAGEALLOC

2019-03-01 Thread Andrew Morton
On Fri, 1 Mar 2019 15:19:50 -0500 Qian Cai wrote: > When onlining a memory block with DEBUG_PAGEALLOC, it unmaps the pages > in the block from kernel, However, it does not map those pages while > offlining at the beginning. As the result, it triggers a panic below > while onlining on ppc64le as

[PATCH] drm/amdgpu/gfx_v8_0: Mark expected switch fall-through

2019-03-01 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. This patch fixes the following warning: drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c: In function ‘gfx_v8_0_tiling_mode_table_init’: ./include/linux/device.h:1487:2: warning: this statement may

Re: [PATCH 3/3] DRM: Add KMS driver for the Ingenic JZ47xx SoCs

2019-03-01 Thread Sam Ravnborg
Hi Paul. Driver looks good and is a very nice piece of work. In the following a number of minor issues. One area that jumped at me was framedesc and the use of dma_alloc_coherent() I hope someone that knows the memory handling better can give some advice here. To me it looks like something drm sh

Re: next/master boot bisection: next-20190215 on beaglebone-black

2019-03-01 Thread Guillaume Tucker
t;> master branch is concerned, KernelCI boot tests are passing fine >> on that platform. > > They would, because I dropped > mm-shuffle-default-enable-all-shuffling.patch, so your tests presumably > now have shuffling disabled. > > Is it possible to add the below to linux-ne

Dear Friend,

2019-03-01 Thread Mrs Alice Johnson
Dear Friend, I am Mrs Alice Johnson.am sending you this brief letter to solicit your partnership to transfer $23.5 million US Dollars.I shall send you more information and procedures when I receive positive response from you. please send me a message in my Email box (mrsalicejohns...@gmail.com) as

Re: [PATCH] mm/hugepages: fix "orig_pud" set but not used

2019-03-01 Thread Andrew Morton
On Thu, 28 Feb 2019 19:49:03 -0500 Qian Cai wrote: > The commit a00cc7d9dd93 ("mm, x86: add support for PUD-sized transparent > hugepages") introduced pudp_huge_get_and_clear_full() but no one uses > its return code, so just make it void. > > mm/huge_memory.c: In function 'zap_huge_pud': > mm/hu

Re: [PATCH 13/20] riscv/mmiowb: Hook up mmwiob() implementation to asm-generic code

2019-03-01 Thread Palmer Dabbelt
On Fri, 01 Mar 2019 06:03:41 PST (-0800), Will Deacon wrote: In a bid to kill off explicit mmiowb() usage in driver code, hook up the asm-generic mmiowb() tracking code for riscv, so that an mmiowb() is automatically issued from spin_unlock() if an I/O write was performed in the critical section.

Re: [PATCH] cxgb4: fix undefined behavior in mem.c

2019-03-01 Thread Shaobo He
Yes, why wouldn't they be real bugs? I was simply pointing out the irrational conclusion if the C standard is strictly applied to kernel code. I think the spirit of the C standard is that one shouldn't rely on the assumption that the value of a freed pointer does not change, even though in pra

Re: [PATCH] percpu/module resevation: change resevation size iff X86_VSMP is set

2019-03-01 Thread Barret Rhoden
Hi - On 03/01/2019 03:34 PM, Dennis Zhou wrote: Hi Barret, On Fri, Mar 01, 2019 at 01:30:15PM -0500, Barret Rhoden wrote: Hi - On 01/21/2019 06:47 AM, Eial Czerwacki wrote: Your main issue was that you only sent this patch to LKML, but not the maintainers of the file. If you don't, your

[PATCH] drm/amdgpu/powerplay: Fix missing break in switch statement

2019-03-01 Thread Gustavo A. R. Silva
Add missing break statement in order to prevent the code from falling through to case SMU_Discrete_DpmTable. This bug was found thanks to the ongoing efforts to enable -Wimplicit-fallthrough. Fixes: 34a564eaf528 ("drm/amd/powerplay: implement fw image related smum interface for Polaris.") Cc: st

Re: [PATCH v3] mtd: rawnand: Mark expected switch fall-throughs

2019-03-01 Thread Gustavo A. R. Silva
Hi all, Friendly ping: Who can take this, please? Thanks -- Gustavo On 2/8/19 11:49 AM, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch > cases where we are expecting to fall through. > > This patch fixes the following warning: > > drivers/mtd/nand/

Re: [PATCH] mm/hugepages: fix "orig_pud" set but not used

2019-03-01 Thread Matthew Wilcox
On Fri, Mar 01, 2019 at 01:09:51PM -0800, Andrew Morton wrote: > On Thu, 28 Feb 2019 19:49:03 -0500 Qian Cai wrote: > > > The commit a00cc7d9dd93 ("mm, x86: add support for PUD-sized transparent > > hugepages") introduced pudp_huge_get_and_clear_full() but no one uses > > its return code, so just

Re: [PATCH v3 03/34] arm: mm: Add p?d_large() definitions

2019-03-01 Thread Kirill A. Shutemov
On Wed, Feb 27, 2019 at 05:05:37PM +, Steven Price wrote: > walk_page_range() is going to be allowed to walk page tables other than > those of user space. For this it needs to know when it has reached a > 'leaf' entry in the page tables. This information will be provided by the > p?d_large() fu

Re: [PATCH v3 05/34] c6x: mm: Add p?d_large() definitions

2019-03-01 Thread Kirill A. Shutemov
On Wed, Feb 27, 2019 at 05:05:39PM +, Steven Price wrote: > walk_page_range() is going to be allowed to walk page tables other than > those of user space. For this it needs to know when it has reached a > 'leaf' entry in the page tables. This information is provided by the > p?d_large() functio

Re: [PATCH v3 06/34] csky: mm: Add p?d_large() definitions

2019-03-01 Thread Kirill A. Shutemov
On Wed, Feb 27, 2019 at 05:05:40PM +, Steven Price wrote: > walk_page_range() is going to be allowed to walk page tables other than > those of user space. For this it needs to know when it has reached a > 'leaf' entry in the page tables. This information is provided by the > p?d_large() functio

Re: [PATCH] percpu/module resevation: change resevation size iff X86_VSMP is set

2019-03-01 Thread Christopher Lameter
On Fri, 1 Mar 2019, Barret Rhoden wrote: > I'm not familiar with VSMP - how bad is it to use L1 cache alignment instead > of 4K page alignment? Maybe some structures can use the smaller alignment? > Or maybe have VSMP require SRCU-using modules to be built-in? It is very expensive. VMSP exchange

[PATCH] workqueue: Fix spelling in source code comments

2019-03-01 Thread Bart Van Assche
Change "execuing" into "executing" and "guarnateed" into "guaranteed". Cc: Lai Jiangshan Signed-off-by: Bart Van Assche --- kernel/workqueue.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/workqueue.c b/kernel/workqueue.c index fc5d23d752a5..57ad76486a9a 100644

Re: [PATCH v3 08/34] ia64: mm: Add p?d_large() definitions

2019-03-01 Thread Kirill A. Shutemov
On Wed, Feb 27, 2019 at 05:05:42PM +, Steven Price wrote: > walk_page_range() is going to be allowed to walk page tables other than > those of user space. For this it needs to know when it has reached a > 'leaf' entry in the page tables. This information is provided by the > p?d_large() functio

Re: [PATCH v6] panic: Avoid the extra noise dmesg

2019-03-01 Thread Steven Rostedt
On Fri, 1 Mar 2019 16:49:46 +0800 Feng Tang wrote: > When kernel panic happens, it will first print the panic call stack, > then the ending msg like: > > [ 35.743249] ---[ end Kernel panic - not syncing: Fatal exception > [ 35.749975] [ cut here ] > > The above mess

Re: [PATCH v6] panic: Avoid the extra noise dmesg

2019-03-01 Thread Andrew Morton
On Fri, 1 Mar 2019 16:57:52 -0500 Steven Rostedt wrote: > Looks good to me. > > Acked-by: Steven Rostedt (VMware) > > Andrew, you want to take this patch? Yup.

Re: [PATCH] bpf: enable program stats

2019-03-01 Thread Guenter Roeck
l_init+0x1c/0x150 [<1019601c>] ret_from_kernel_thread+0x1c/0x24 Kernel Fault: Code=18 (Data memory protection/unaligned access trap) at addr 10193fd0 CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5.0.0-rc8-next-20190301 #1 Hardware name: 9000/778/B160L YZrvWESTHLNXBCVMcbcbcbcbOGFRQPDI PSW:

[PATCH -next] mm/hotplug: fix an imbalance with DEBUG_PAGEALLOC

2019-03-01 Thread Qian Cai
When onlining a memory block with DEBUG_PAGEALLOC, it unmaps the pages in the block from kernel, However, it does not map those pages while offlining at the beginning. As the result, it triggers a panic below while onlining on ppc64le as it checks if the pages are mapped before unmapping. However,

Re: [PATCH v3 15/34] parisc: mm: Add p?d_large() definitions

2019-03-01 Thread Kirill A. Shutemov
On Wed, Feb 27, 2019 at 07:54:22PM +0100, Helge Deller wrote: > On 27.02.19 18:05, Steven Price wrote: > > walk_page_range() is going to be allowed to walk page tables other than > > those of user space. For this it needs to know when it has reached a > > 'leaf' entry in the page tables. This infor

Re: [RFC net-next 8/8] net/mlx5: Add subdev driver to bind to subdev devices

2019-03-01 Thread Saeed Mahameed
On Thu, 2019-02-28 at 23:37 -0600, Parav Pandit wrote: > Add a subdev driver to probe the subdev devices and create fake > netdevice for it. > > Signed-off-by: Parav Pandit > --- > drivers/net/ethernet/mellanox/mlx5/core/Makefile | 2 +- > drivers/net/ethernet/mellanox/mlx5/core/main.c |

Re: [PATCH 10/20] mips/mmiowb: Add unconditional mmiowb() to arch_spin_unlock()

2019-03-01 Thread Paul Burton
Hi Will, On Fri, Mar 01, 2019 at 02:03:38PM +, Will Deacon wrote: > The mmiowb() macro is horribly difficult to use and drivers will continue > to work most of the time if they omit a call when it is required. > > Rather than rely on driver authors getting this right, push mmiowb() into > arc

Re: [PATCH] bpf: enable program stats

2019-03-01 Thread Eric Dumazet
On 03/01/2019 02:03 PM, Guenter Roeck wrote: > Hi, > > On Mon, Feb 25, 2019 at 02:28:39PM -0800, Alexei Starovoitov wrote: >> JITed BPF programs are indistinguishable from kernel functions, but unlike >> kernel code BPF code can be changed often. >> Typical approach of "perf record" + "perf rep

Re: [PATCH] bpf: enable program stats

2019-03-01 Thread Eric Dumazet
On 03/01/2019 02:03 PM, Guenter Roeck wrote: > Hi, > > On Mon, Feb 25, 2019 at 02:28:39PM -0800, Alexei Starovoitov wrote: >> JITed BPF programs are indistinguishable from kernel functions, but unlike >> kernel code BPF code can be changed often. >> Typical approach of "perf record" + "perf rep

[PATCH v2] mm/hugepages: fix "orig_pud" set but not used

2019-03-01 Thread Qian Cai
The commit a00cc7d9dd93 ("mm, x86: add support for PUD-sized transparent hugepages") introduced pudp_huge_get_and_clear_full() but no one uses its return code. In order to not diverge from pmdp_huge_get_and_clear_full(), just change zap_huge_pud() to not assign the return value from pudp_huge_get_a

Re: [PATCH RFC] mm/vmscan: try to protect active working set of cgroup from reclaim.

2019-03-01 Thread Johannes Weiner
On Fri, Mar 01, 2019 at 10:46:34PM +0300, Andrey Ryabinin wrote: > On 3/1/19 8:49 PM, Johannes Weiner wrote: > > On Fri, Mar 01, 2019 at 01:38:26PM +0300, Andrey Ryabinin wrote: > >> On 2/26/19 3:50 PM, Andrey Ryabinin wrote: > >>> On 2/22/19 10:15 PM, Johannes Weiner wrote: > On Fri, Feb 22,

Re: [PATCH v3] page cache: Store only head pages in i_pages

2019-03-01 Thread Song Liu
On Fri, Mar 1, 2019 at 11:12 AM Song Liu wrote: > > On Fri, Feb 15, 2019 at 2:25 PM Matthew Wilcox wrote: > > > > Transparent Huge Pages are currently stored in i_pages as pointers to > > consecutive subpages. This patch changes that to storing consecutive > > pointers to the head page in prepar

Re: [PATCH] sctp: chunk.c: correct format string for size_t in printk

2019-03-01 Thread Joe Perches
On Thu, 2019-02-28 at 11:36 +, Matthias Maennich wrote: > According to Documentation/core-api/printk-formats.rst, size_t should be > printed with %zu, rather than %Zu. > > In addition, using %Zu triggers a warning on clang (-Wformat-extra-args): [] > diff --git a/net/sctp/chunk.c b/net/sctp/ch

Re: [PATCH 1/2] drm/panel: simple: Add Sharp LS020B1DD01D panel support

2019-03-01 Thread Sam Ravnborg
Hi Paul. On Thu, Feb 28, 2019 at 03:58:52PM -0300, Paul Cercueil wrote: > The Sharp LS020B1DD01D is a simple 2.0" 240x160 16-bit TFT panel. > > Signed-off-by: Paul Cercueil > Tested-by: Artur Rojek > --- > drivers/gpu/drm/panel/panel-simple.c | 28 > 1 file changed

Re: Realtek r8822be kernel module does not negotiate 802.11ac connection

2019-03-01 Thread David R. Bergstein
Larry, Thanks for the response and detailed instructions, which allowed me to build and install the rtw88 kernel module.  I cannot however seem to get my system to actually use the module.  Just to recap this is an HP Omen laptop with secure boot disabled.  Upon boot-up both the new rtw88 and old

Re: Bug in spi: imx: Add support for SPI Slave mode

2019-03-01 Thread Trent Piepho
On Wed, 2019-02-27 at 10:55 +0900, Jiada Wang wrote: > Hi Trent > > Thanks for reporting Thanks for the information, it was very helpful! > > in the commit message of commit ("spi: imx: Add support for SPI Slave > mode"), it mentions > > "The stale data in RXFIFO will be dropped when the Slav

Re: [PATCH] bpf: enable program stats

2019-03-01 Thread Guenter Roeck
On Fri, Mar 01, 2019 at 02:17:40PM -0800, Eric Dumazet wrote: > > > On 03/01/2019 02:03 PM, Guenter Roeck wrote: > > Hi, > > > > On Mon, Feb 25, 2019 at 02:28:39PM -0800, Alexei Starovoitov wrote: > >> JITed BPF programs are indistinguishable from kernel functions, but unlike > >> kernel code BP

Re: [PATCH v3] mtd: rawnand: Mark expected switch fall-throughs

2019-03-01 Thread Richard Weinberger
Am Freitag, 1. März 2019, 22:38:18 CET schrieb Gustavo A. R. Silva: > Hi all, > > Friendly ping: > > Who can take this, please? /me points to Miquel. :) Thanks, //richard

Re: [PATCH v2 3/3] drm/panel: Add Rocktech jh057n00900 panel driver

2019-03-01 Thread Sam Ravnborg
Hi Guido. Thanks for addressing review comments in first round. Just a few nits in this follow-up. With these nits addressed: Reviewed-by: Sam Ravnborg On Fri, Mar 01, 2019 at 02:02:04PM +0100, Guido Günther wrote: > +#include This include file is, as far as I could tell, no longer used and ca

Re: [PATCH 1/3] dt-bindings: Add doc for the ingenic-drm driver

2019-03-01 Thread Paul Cercueil
Hi Sam, thanks for the feedback. Le ven. 1 mars 2019 à 17:16, Sam Ravnborg a écrit : Hi Paul. Good to see work migrating fbdev => drm. Following comments is based on experience while working on migrating another driver from fbdev => drm. On Thu, Feb 28, 2019 at 07:07:54PM -0300, Paul Cercuei

Re: [PATCH 1/2] drm/panel: simple: Add Sharp LS020B1DD01D panel support

2019-03-01 Thread Paul Cercueil
Hi, Le ven. 1 mars 2019 à 19:24, Sam Ravnborg a écrit : Hi Paul. On Thu, Feb 28, 2019 at 03:58:52PM -0300, Paul Cercueil wrote: The Sharp LS020B1DD01D is a simple 2.0" 240x160 16-bit TFT panel. Signed-off-by: Paul Cercueil Tested-by: Artur Rojek --- drivers/gpu/drm/panel/panel-simple

[PATCH] MIPS: eBPF: Fix icache flush end address

2019-03-01 Thread Paul Burton
The MIPS eBPF JIT calls flush_icache_range() in order to ensure the icache observes the code that we just wrote. Unfortunately it gets the end address calculation wrong due to some bad pointer arithmetic. The struct jit_ctx target field is of type pointer to u32, and as such adding one to it will

Re: [RFC] kprobes: Fix locking in recycle_rp_inst

2019-03-01 Thread David Valin
Finally got around to testing it.  Verified the issue was still present.  Then install Jiri's fix.  Cleared the issue out.  So at least from the standpoint of fixing the hang, the change is good. Dave On 2/28/19 1:50 AM, Masami Hiramatsu wrote: On Wed, 27 Feb 2019 14:33:09 +0100 Jiri Olsa wr

Re: [RFC PATCH v1 09/15] drm/msm/gpu: Move address space setup to the GPU targets

2019-03-01 Thread Jonathan Marek
There is an error in the a2xx part of this patch: 0xfff in adreno_gpu.c became 0xff in a2xx_gpu.c On 3/1/19 2:38 PM, Jordan Crouse wrote: Move the address space steup code out of the generic msm GPU code to to the individual GPU targets. This allows us to do target specific setup such as gpummu

<    1   2   3   4   5   6   7   8   >