Re: [PATCH v3 5/6] x86/mm/KASLR: Calculate the actual size of vmemmap region

2019-02-18 Thread Baoquan He
On 02/17/19 at 09:25am, Kees Cook wrote: > On Sat, Feb 16, 2019 at 6:04 AM Baoquan He wrote: > > > > Vmemmap region has different maximum size depending on paging mode. > > Now its size is hardcoded as 1TB in memory KASLR, this is not > > right for 5-level paging mode. It will cause overflow if vm

[PATCH] i2c: cadence: try reset when master receive arbitration lost

2019-02-18 Thread Shikai Wang
When the adapter receive arbitration lost error interrupts, cdns_i2c_master_xfer return to the caller directly instead of resetting the adapter which resulted in the adapter being out of control. So when driver detect err_status such as arbitration lost, then try to repair and fix it. Signed-off-

[PATCH v2 6/8] net: thunderx: add mutex to protect mailbox from concurrent calls for same VF

2019-02-18 Thread Vadim Lomovtsev
In some cases it could happen that nicvf_send_msg_to_pf() could be called concurrently for the same NIC VF, and thus re-writing mailbox contents and breaking messaging sequence with PF by re-writing NICVF data. This commit is to implement mutex for NICVF to protect mailbox registers and NICVF mess

[PATCH v2 7/8] net: thunderx: add LINK_CHANGE message handler at nicpf

2019-02-18 Thread Vadim Lomovtsev
Move the link change polling task to VF side in order to prevent races between VF and PF while sending link change message(s). This commit is to implement link change request to be initiated by VF. Signed-off-by: Vadim Lomovtsev --- drivers/net/ethernet/cavium/thunder/nic.h | 2 +- .../net/

[PATCH v2 3/8] net: thunderx: make CFG_DONE message to run through generic send-ack sequence

2019-02-18 Thread Vadim Lomovtsev
At the end of NIC VF initialization VF sends CFG_DONE message to PF without using nicvf_msg_send_to_pf routine. This potentially could re-write data in mailbox. This commit is to implement common way of sending CFG_DONE message by the same way with other configuration messages by using nicvf_send_m

[PATCH 5/6] arm64: dts: freescale: lx2160a: add pcie EP mode DT nodes

2019-02-18 Thread Xiaowei Bao
The LX2160A PCIe EP mode node. Signed-off-by: Xiaowei Bao --- depends on: http://patchwork.ozlabs.org/project/linux-pci/list/?series=88754 arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 56 1 files changed, 56 insertions(+), 0 deletions(-) diff --git a/arch/arm64/b

[PATCH 4/6] PCI: mobiveil: Add workaround for unsupported request error

2019-02-18 Thread Xiaowei Bao
Errata: unsupported request error on inbound posted write transaction, PCIe controller reports advisory error instead of uncorrectable error message to RC. Signed-off-by: Xiaowei Bao --- depends on: http://patchwork.ozlabs.org/project/linux-pci/list/?series=88754 .../controller/mobiveil/pci-lay

[PATCH v2 5/8] net: thunderx: rework xcast message structure to make it fit into 64 bit

2019-02-18 Thread Vadim Lomovtsev
To communicate to PF each of ThunderX NIC VF uses mailbox which is pair of 64 bit registers available to both VFn and PF. This commit is to change the xcast message structure in order to fit it into 64 bit. Signed-off-by: Vadim Lomovtsev --- drivers/net/ethernet/cavium/thunder/nic.h| 6

[PATCH 3/6] PCI: mobiveil: Add PCIe Gen4 EP driver for NXP Layerscape SoCs

2019-02-18 Thread Xiaowei Bao
This PCIe controller is based on the Mobiveil GPEX IP, it work in EP mode if select this config opteration. Signed-off-by: Xiaowei Bao --- depends on: http://patchwork.ozlabs.org/project/linux-pci/list/?series=88754 drivers/pci/controller/mobiveil/Kconfig| 17 ++- drivers/pci/cont

[PATCH 6/6] misc: pci_endpoint_test: Add the layerscape PCIe GEN4 EP device support

2019-02-18 Thread Xiaowei Bao
Add the layerscape PCIE GEN4 EP device support in pci_endpoint_test driver. Signed-off-by: Xiaowei Bao --- drivers/misc/pci_endpoint_test.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/misc/pci_endpoint_test.c b/drivers/misc/pci_endpoint_test.c index 896e2df..

[PATCH 2/6] dt-bindings: add DT binding for the layerscape PCIe GEN4 controller with EP mode

2019-02-18 Thread Xiaowei Bao
Add the documentation for the Device Tree binding for the layerscape PCIe GEN4 controller with EP mode. Signed-off-by: Xiaowei Bao --- depends on: http://patchwork.ozlabs.org/project/linux-pci/list/?series=88754 .../bindings/pci/layerscape-pci-gen4.txt |5 - 1 files changed, 4

[PATCH v2 8/8] net: thunderx: remove link change polling code and info from nicpf

2019-02-18 Thread Vadim Lomovtsev
Since link change polling routine was moved to nicvf side, we don't need anymore polling function at nicpf side along with link status info for all enabled Vfs as at VF side this info is already tracked. This commit is to remove unnecessary code & fields from nicpf structure. Signed-off-by: Vadim

[PATCH 1/6] PCI: mobiveil: Add the EP mode support

2019-02-18 Thread Xiaowei Bao
Add the EP mode support for Mobiveil base on endpoint framework. Signed-off-by: Xiaowei Bao --- depends on: http://patchwork.ozlabs.org/project/linux-pci/list/?series=88754 drivers/pci/controller/mobiveil/Kconfig|5 + drivers/pci/controller/mobiveil/Makefile |1 +

[PATCH v2 2/8] net: thunderx: replace global nicvf_rx_mode_wq work queue for all VFs to private for each of them.

2019-02-18 Thread Vadim Lomovtsev
Having one work queue for receive mode configuration ndo_set_rx_mode() call for all VFs results in making each of them wait till the set_rx_mode() call completes for another VF if any of close, set receive mode and change flags calls being already invoked. Potentially this could cause device state

[PATCH v2 4/8] net: thunderx: add nicvf_send_msg_to_pf result check for set_rx_mode_task

2019-02-18 Thread Vadim Lomovtsev
The rx_set_mode invokes number of messages to be send to PF for receive mode configuration. In case if there any issues we need to stop sending messages and release allocated memory. This commit is to implement check of nicvf_msg_send_to_pf() result. Signed-off-by: Vadim Lomovtsev --- drivers/n

[PATCH v2 1/8] net: thunderx: correct typo in macro name

2019-02-18 Thread Vadim Lomovtsev
Correct STREERING to STEERING at macro name for BGX steering register. Signed-off-by: Vadim Lomovtsev --- drivers/net/ethernet/cavium/thunder/thunder_bgx.c | 2 +- drivers/net/ethernet/cavium/thunder/thunder_bgx.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net

[PATCH v2 0/8] nic: thunderx: fix communication races between VF & PF

2019-02-18 Thread Vadim Lomovtsev
From: Vadim Lomovtsev The ThunderX CN88XX NIC Virtual Function driver uses mailbox interface to communicate to physical function driver. Each of VF has it's own pair of mailbox registers to read from and write to. The mailbox registers has no protection from possible races, so it has to be imple

Re: [PATCH 3/3] PM / devfreq: tegra: remove unneeded variable

2019-02-18 Thread Jon Hunter
On 18/02/2019 00:38, Chanwoo Choi wrote: > On 19. 2. 17. 오전 12:18, Yangtao Li wrote: >> This variable is not used after initialization, so >> remove it. And in order to unify the code style, >> move the location where the dev_get_drvdata is called >> by the way. >> >> Signed-off-by: Yangtao Li >

Re: mremap vs sysctl_max_map_count

2019-02-18 Thread Vlastimil Babka
On 2/18/19 9:33 AM, Oscar Salvador wrote: > > Hi all, > > I would like to bring up a topic that comes from an issue a customer of ours > is facing with the mremap syscall + hitting the max_map_count threshold: > > When passing the MREMAP_FIXED flag, mremap() calls mremap_to() which does the > fo

RE: [PATCH v6 1/4] acpi: arm64: add iort support for PMCG

2019-02-18 Thread Shameerali Kolothum Thodi
> -Original Message- > From: Lorenzo Pieralisi [mailto:lorenzo.pieral...@arm.com] > Sent: 15 February 2019 11:40 > To: Shameerali Kolothum Thodi > Cc: robin.mur...@arm.com; andrew.mur...@arm.com; > jean-philippe.bruc...@arm.com; will.dea...@arm.com; > mark.rutl...@arm.com; Guohanjun (Ha

Re: [PATCH] i2c: Allow recovery of the initial IRQ by a i2c client device.

2019-02-18 Thread Charles Keepax
On Fri, Feb 15, 2019 at 04:15:33PM -0800, Jim Broadus wrote: > A previous change allowed i2c client devices to discover new IRQs upon > reprobe. By clearing the IRQ in i2c_device_remove. However, if an IRQ was > assigned in i2c_new_device, that information is lost. > > For example, the touchscreen

Re: [PATCH v3 5/6] x86/mm/KASLR: Calculate the actual size of vmemmap region

2019-02-18 Thread Baoquan He
On 02/18/19 at 05:50pm, Baoquan He wrote: > On 02/17/19 at 09:25am, Kees Cook wrote: > > On Sat, Feb 16, 2019 at 6:04 AM Baoquan He wrote: > > > > > > Vmemmap region has different maximum size depending on paging mode. > > > Now its size is hardcoded as 1TB in memory KASLR, this is not > > > right

[PATCH] clocksource: exynos_mct: Remove unused header includes

2019-02-18 Thread Krzysztof Kozlowski
The driver does not use sched.h and platform_device.h. Signed-off-by: Krzysztof Kozlowski --- drivers/clocksource/exynos_mct.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/clocksource/exynos_mct.c b/drivers/clocksource/exynos_mct.c index 7a244b681876..33fc4038da06 100644 --- a/dr

[PATCH] input : avoid too late kobject_uevent(KOBJ_REMOVE) call

2019-02-18 Thread Tetsuo Handa
syzbot is hitting use-after-free bug in uinput module [1]. This is because kobject_uevent(KOBJ_REMOVE) is called again due to commit 0f4dafc0563c6c49 ("Kobject: auto-cleanup on final unref") after memory allocation fault injection made kobject_uevent(KOBJ_REMOVE) from device_del() from input_unregi

Re: [PATCH (resend)] Input: uinput - Set name/phys to NULL before kfree().

2019-02-18 Thread Tetsuo Handa
Thank you for responding. On 2019/02/18 6:07, Dmitry Torokhov wrote: > The commit tries to send final uevent for objects for which "add" uevent > has been sent, but not "remove" event. However in uinput (and general > input case) we always take care of sending uevent at unregister, and do > not ex

Re: [PATCH v3 5/6] x86/mm/KASLR: Calculate the actual size of vmemmap region

2019-02-18 Thread Baoquan He
On 02/18/19 at 05:50pm, Baoquan He wrote: > On 02/17/19 at 09:25am, Kees Cook wrote: > > On Sat, Feb 16, 2019 at 6:04 AM Baoquan He wrote: > > > > > > Vmemmap region has different maximum size depending on paging mode. > > > Now its size is hardcoded as 1TB in memory KASLR, this is not > > > right

Re: [PATCH] i2c: cadence: try reset when master receive arbitration lost

2019-02-18 Thread Michal Simek
On 18. 02. 19 10:41, Shikai Wang wrote: > When the adapter receive arbitration lost error interrupts, > cdns_i2c_master_xfer return to the caller directly instead of resetting > the adapter which resulted in the adapter being out of control. > > So when driver detect err_status such as arbitration

Re: [PATCH v8 0/4] platform/chrome: Add basic support for Wilco EC

2019-02-18 Thread Enric Balletbo Serra
Missatge de Nick Crews del dia ds., 9 de febr. 2019 a les 1:37: > > > There is a new chromebook that contains a different Embedded Controller > (codename Wilco) than the rest of the chromebook series. Thus the kernel > requires a different driver than the already existing and generalized > cros_ec

Re: [PATCH -next] platform/chrome: Make function wilco_ec_transfer() static

2019-02-18 Thread Enric Balletbo i Serra
On 16/2/19 7:09, Wei Yongjun wrote: > Fixes the following sparse warning: > > drivers/platform/chrome/wilco_ec/mailbox.c:126:5: warning: > symbol 'wilco_ec_transfer' was not declared. Should it be static? > > Fixes: 436dad4fda10 ("platform/chrome: Add new driver for Wilco EC") > Signed-off-by

[RFC 0/4] clk/driver: platform: Fix kfree() of const memory on setting driver_override

2019-02-18 Thread Krzysztof Kozlowski
Hi, The problem === Several device types (platform, amba, spi etc.) provide a driver_override field. On sysfs store or during device removal, they kfree() the existing value. However the users are unaware of this and set the driver_override like: pdev->driver_override = "exynos5

[RFC 1/4] clk: samsung: exynos5: Fix possible NULL pointer exception on platform_device_alloc() failure

2019-02-18 Thread Krzysztof Kozlowski
During initialization of subdevices if platform_device_alloc() failed, returned NULL pointer will be later dereferenced. Add proper error paths to exynos5_clk_register_subcmu(). The return value of this function is still ignored because at this stage of init there is nothing we can do. Signed-of

[RFC 3/4] clk: samsung: exynos5: Fix kfree() of const memory on setting driver_override

2019-02-18 Thread Krzysztof Kozlowski
Platform driver driver_override field should not be initialized from const memory because the core later kfree() it. If driver_override is manually set later through sysfs, kfree() of old value leads to: $ echo "new_value" > /sys/bus/platform/drivers/.../driver_override kernel BUG at ../

[RFC 4/4] slimbus: ngd: Fix kfree() of const memory on setting driver_override

2019-02-18 Thread Krzysztof Kozlowski
Platform driver driver_override field should not be initialized from const memory because the core later kfree() it. If driver_override is manually set later through sysfs, kfree() of old value leads to: $ echo "new_value" > /sys/bus/platform/drivers/.../driver_override kernel BUG at ../

[RFC 2/4] driver: platform: Provide helper for safer setting of driver_override

2019-02-18 Thread Krzysztof Kozlowski
The core platform driver expects that driver_override is an dynamically allocated memory so later it can kfree() it. However such assumption is not documented and there are already users setting it to a const memory. This leads to kfree() of const memory during device release (e.g. in error paths

Re: [PATCH 4.19 01/24] bridge: do not add port to router list when receives query with source 0.0.0.0

2019-02-18 Thread Sebastian Gottschall
Am 17.02.2019 um 17:48 schrieb Greg Kroah-Hartman: On Sun, Feb 17, 2019 at 03:29:22PM +0100, Sebastian Gottschall wrote: according to user reports this patch will cause a serious regression. igmp snooping is not working anymore with this patch Am 02.11.2018 um 19:34 schrieb Greg Kroah-Hartma

RE: [PATCH] drivers: mux: Generic register bitfield-based multiplexer driver

2019-02-18 Thread Pankaj Bansal
Hi Peter, > -Original Message- > From: Peter Rosin [mailto:p...@axentia.se] > Sent: Monday, 18 February, 2019 03:17 PM > To: Pankaj Bansal ; Leo Li ; > linux-kernel@vger.kernel.org; Philipp Zabel > Subject: Re: [PATCH] drivers: mux: Generic register bitfield-based multiplexer > driver >

Re: [PATCH v7 2/3] thermal: tegra: fix memory allocation

2019-02-18 Thread Daniel Lezcano
On 03/01/2019 11:12, Wei Ni wrote: > Fix memory allocation to store the pointers to > thermal_zone_device. > > Signed-off-by: Wei Ni > Acked-by: Thierry Reding > --- Good catch Reviewed-by: Daniel Lezcano > drivers/thermal/tegra/soctherm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deleti

Re: [PATCH] lib/test_rhashtable: fix spelling mistake "existant" -> "existent"

2019-02-18 Thread Herbert Xu
On Sun, Feb 17, 2019 at 10:52:09PM +, Colin King wrote: > From: Colin Ian King > > There are spelling mistakes in warning macro messages. Fix them. > > Signed-off-by: Colin Ian King Acked-by: Herbert Xu -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http:/

Re: [PATCH net-next 10/13] net: mvpp2: reset the XPCS while reconfiguring the serdes lanes

2019-02-18 Thread Antoine Tenart
Hi Russell, On Fri, Feb 15, 2019 at 05:12:24PM +, Russell King - ARM Linux admin wrote: > On Fri, Feb 15, 2019 at 04:32:38PM +0100, Antoine Tenart wrote: > > The documentation advises to set the XPCS in reset while reconfiguring > > the serdes lanes. This seems to be a good thing to do, but th

[tip:irq/core] genirq/affinity: Code consolidation

2019-02-18 Thread tip-bot for Thomas Gleixner
Commit-ID: 0145c30e896d26e638d27c957d9eed72893c1c92 Gitweb: https://git.kernel.org/tip/0145c30e896d26e638d27c957d9eed72893c1c92 Author: Thomas Gleixner AuthorDate: Sat, 16 Feb 2019 18:13:07 +0100 Committer: Thomas Gleixner CommitDate: Mon, 18 Feb 2019 11:21:27 +0100 genirq/affinity: Co

Re: [PATCH] net/mlx4_en: fix spelling mistake: "quiting" -> "quitting"

2019-02-18 Thread Dan Carpenter
On Mon, Feb 18, 2019 at 09:37:22AM +, Tariq Toukan wrote: > > > On 2/18/2019 1:03 AM, Colin King wrote: > > From: Colin Ian King > > > > There is a spelling mistake in a en_err error message. Fix it. > > > > Signed-off-by: Colin Ian King > > --- > > drivers/net/ethernet/mellanox/mlx4/en

[tip:irq/core] genirq/affinity: Store interrupt sets size in struct irq_affinity

2019-02-18 Thread tip-bot for Ming Lei
Commit-ID: 9cfef55bb57e7620c63087be18a76351628f8d0f Gitweb: https://git.kernel.org/tip/9cfef55bb57e7620c63087be18a76351628f8d0f Author: Ming Lei AuthorDate: Sat, 16 Feb 2019 18:13:08 +0100 Committer: Thomas Gleixner CommitDate: Mon, 18 Feb 2019 11:21:27 +0100 genirq/affinity: Store int

[tip:irq/core] genirq/affinity: Add new callback for (re)calculating interrupt sets

2019-02-18 Thread tip-bot for Ming Lei
Commit-ID: c66d4bd110a1f8a68c1a88bfbf866eb50c6464b7 Gitweb: https://git.kernel.org/tip/c66d4bd110a1f8a68c1a88bfbf866eb50c6464b7 Author: Ming Lei AuthorDate: Sat, 16 Feb 2019 18:13:09 +0100 Committer: Thomas Gleixner CommitDate: Mon, 18 Feb 2019 11:21:28 +0100 genirq/affinity: Add new c

Re: [PATCH v7 3/3] thermal: tegra: add get_trend ops

2019-02-18 Thread Daniel Lezcano
On 03/01/2019 11:12, Wei Ni wrote: > Add support for get_trend ops that allows soctherm > sensors to be used with the step-wise governor. > > Signed-off-by: Wei Ni > --- > drivers/thermal/tegra/soctherm.c | 34 ++ > 1 file changed, 34 insertions(+) > > diff --git

[tip:irq/core] nvme-pci: Simplify interrupt allocation

2019-02-18 Thread tip-bot for Ming Lei
Commit-ID: 612b72862b4dd7f3f5e42651522daac6733b8ea6 Gitweb: https://git.kernel.org/tip/612b72862b4dd7f3f5e42651522daac6733b8ea6 Author: Ming Lei AuthorDate: Sat, 16 Feb 2019 18:13:10 +0100 Committer: Thomas Gleixner CommitDate: Mon, 18 Feb 2019 11:21:28 +0100 nvme-pci: Simplify interru

Re: mremap vs sysctl_max_map_count

2019-02-18 Thread Mike Rapoport
On Mon, Feb 18, 2019 at 10:57:18AM +0100, Vlastimil Babka wrote: > On 2/18/19 9:33 AM, Oscar Salvador wrote: > > > > Hi all, > > > > I would like to bring up a topic that comes from an issue a customer of ours > > is facing with the mremap syscall + hitting the max_map_count threshold: > > > > W

Re: [LKP] efad4e475c [ 40.308255] Oops: 0000 [#1] PREEMPT SMP PTI

2019-02-18 Thread Michal Hocko
On Mon 18-02-19 18:01:39, Rong Chen wrote: > > On 2/18/19 4:55 PM, Michal Hocko wrote: > > [Sorry for an excessive quoting in the previous email] > > [Cc Pavel - the full report is > > http://lkml.kernel.org/r/20190218052823.GH29177@shao2-debian[] > > > > On Mon 18-02-19 08:08:44, Michal Hocko w

[tip:irq/core] genirq/affinity: Remove the leftovers of the original set support

2019-02-18 Thread tip-bot for Thomas Gleixner
Commit-ID: a6a309edba13866b31dc4d8aebad3864a6d56ade Gitweb: https://git.kernel.org/tip/a6a309edba13866b31dc4d8aebad3864a6d56ade Author: Thomas Gleixner AuthorDate: Sat, 16 Feb 2019 18:13:11 +0100 Committer: Thomas Gleixner CommitDate: Mon, 18 Feb 2019 11:21:29 +0100 genirq/affinity: Re

[tip:irq/core] PCI/MSI: Remove obsolete sanity checks for multiple interrupt sets

2019-02-18 Thread tip-bot for Thomas Gleixner
Commit-ID: 4e6b26d23dc1faee318796d5c7f91b5692b1e6be Gitweb: https://git.kernel.org/tip/4e6b26d23dc1faee318796d5c7f91b5692b1e6be Author: Thomas Gleixner AuthorDate: Sat, 16 Feb 2019 18:13:12 +0100 Committer: Thomas Gleixner CommitDate: Mon, 18 Feb 2019 11:21:29 +0100 PCI/MSI: Remove obs

Re: [PATCH 1/3] dt-bindings: dmaengine: Add one new cell to present hardware slave id

2019-02-18 Thread Arnd Bergmann
On Tue, Feb 12, 2019 at 9:25 AM Baolin Wang wrote: > On Fri, 1 Feb 2019 at 19:53, Baolin Wang wrote: > > On Thu, 31 Jan 2019 at 00:52, Arnd Bergmann wrote: > > > On Tue, Jan 22, 2019 at 2:21 PM Baolin Wang > > > wrote: > > > > > > > > Client: > > > > DMA clients connected to the Spreadtrum D

Re: 4.20.7: pl2303 not working (post-4.19 regression) (limited info so far, not yet bisected)

2019-02-18 Thread Nix
On 18 Feb 2019, Johan Hovold stated: > On Sun, Feb 17, 2019 at 07:13:52PM +, Nix wrote: >> I'm still fairly sure this is a regression -- my machines are often up >> for a lot longer than that and I've never seen this before I upgraded to >> 4.20.x -- but I don't think I'm going to identify it

Re: [PATCH 2/8] dt-bindings: phy: Add Amlogic G12A USB3+PCIE Combo PHY Bindings

2019-02-18 Thread Neil Armstrong
On 17/02/2019 23:03, Martin Blumenstingl wrote: > On Tue, Feb 12, 2019 at 4:15 PM Neil Armstrong > wrote: >> >> Add the Amlogic G12A Family USB3 + PCIE Combo PHY Bindings. >> >> This PHY can provide exclusively USB3 or PCIE support on shared I/Os. >> >> Signed-off-by: Neil Armstrong > one nit-pi

[PATCH] usb: host: xhci-rcar: Add XHCI_TRUST_TX_LENGTH quirk

2019-02-18 Thread Spyridon Papageorgiou
From: Yasushi Asano When plugging BUFFALO LUA4-U3-AGT USB3.0 to Gigabit Ethernet LAN Adapter, warning messages filled up dmesg. [ 101.098287] xhci-hcd ee00.usb: WARN Successful completion on short TX for slot 1 ep 4: needs XHCI_TRUST_TX_LENGTH quirk? [ 101.117463] xhci-hcd ee00.usb: W

Re: [PATCH v2 5/5] arm64: dts: sprd: Remove wildcard compatible string

2019-02-18 Thread Arnd Bergmann
On Thu, Feb 14, 2019 at 2:56 AM Baolin Wang wrote: > > On Wed, 13 Feb 2019 at 22:32, Arnd Bergmann wrote: > > > > On Wed, Feb 13, 2019 at 1:34 PM Baolin Wang wrote: > > > > > > Remove wildcard compatible string. > > > > > > Signed-off-by: Baolin Wang > > > > > > Looks good to me. It does break

Re: [PATCH 5/8] phy: amlogic: add Amlogic G12A USB2 PHY Driver

2019-02-18 Thread Neil Armstrong
Hi Martin, On 17/02/2019 23:24, Martin Blumenstingl wrote: > Hi Neil, > > On Tue, Feb 12, 2019 at 4:15 PM Neil Armstrong > wrote: >> >> This adds support for the USB2 PHY found in the Amlogic G12A SoC Family. >> >> It supports Host and/or Peripheral mode, depending on it's position. >> The firs

[PATCH v2] regulator: axp20x: fix BLDO2 definition for AXP806

2019-02-18 Thread megous
From: Ondrej Jirman This fixes an error from the refactoring of literals to mask preproccesor definitions that was done during the 5.0 release cycle. Found by debugging a broken voltage setup on Orange Pi One Plus. Fixes: db4a555f7c4cf ("regulator: axp20x: use defines for masks") Signed-off-by:

Re: [PATCH net-next 01/13] net: mvpp2: do not call phylink_mac_change if there is no event

2019-02-18 Thread Antoine Tenart
Hi Russell, On Fri, Feb 15, 2019 at 05:05:53PM +, Russell King - ARM Linux admin wrote: > On Fri, Feb 15, 2019 at 04:32:29PM +0100, Antoine Tenart wrote: > > This patch makes the link interrupt handler to avoid calling > > phylink_mac_change when there are no event. > > The reasoning being?

Re: [RFC 0/4] clk/driver: platform: Fix kfree() of const memory on setting driver_override

2019-02-18 Thread Geert Uytterhoeven
Hi Krzysztof, On Mon, Feb 18, 2019 at 11:27 AM Krzysztof Kozlowski wrote: > The problem > === > Several device types (platform, amba, spi etc.) provide a driver_override > field. On sysfs store or during device removal, they kfree() the > existing value. > > However the users are unaware

Re: [PATCH] arm64/mm: skip hwasan callbacks for pgtable walker

2019-02-18 Thread Will Deacon
On Fri, Feb 15, 2019 at 11:47:35PM -0500, Qian Cai wrote: > Page table walkers trigger soft lockups below with KASAN_SW_TAGS outline > mode on a large ThunderX2 system, because there is too much overhead to > call check_memory_region() for every memory access where it needs to > dereference every b

[PATCH v4 0/7] mtd: rawnand: Support bad block markers in first, second or last page

2019-02-18 Thread Schrempf Frieder
From: Frieder Schrempf Currently supported bad block marker positions within the block are: * in first page only * in last page only * in first or second page After some cleanup and preparation in patch 1 and 2, we make it possible to set NAND_BBM_FIRSTPAGE, NAND_BBM_SECONDPAGE and NAND_BBM_LAST

[PATCH v4 4/7] mtd: nand: Make flags for bad block marker position more granular

2019-02-18 Thread Schrempf Frieder
From: Frieder Schrempf To be able to check and set bad block markers in the first and second page of a block independently of each other, we create separate flags for both cases. Previously NAND_BBM_SECONDPAGE meant, that both, the first and the second page were used. With this patch NAND_BBM_FI

[PATCH v4 3/7] mtd: nand: Cleanup flags and fields for bad block marker position

2019-02-18 Thread Schrempf Frieder
From: Frieder Schrempf Now that we have moved the information to the chip level, let's remove all the unused flags and fields. Signed-off-by: Frieder Schrempf --- include/linux/mtd/bbm.h | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/include/linux/mtd/bbm.h

[PATCH v4 6/7] mtd: rawnand: ESMT: Also use the last page for bad block markers

2019-02-18 Thread Schrempf Frieder
From: Frieder Schrempf It is known that some ESMT SLC NANDs have been shipped with the factory bad block markers in the first or last page of the block, instead of the first or second page. To be on the safe side, let's check all three locations. Signed-off-by: Frieder Schrempf Reviewed-by: Bor

[PATCH v4 1/7] mtd: rawnand: Always store info about bad block markers in chip struct

2019-02-18 Thread Schrempf Frieder
From: Frieder Schrempf The information about where the manufacturer puts the bad block markers inside the bad block and in the OOB data is stored in different places. Let's move this information to nand_chip.options and nand_chip.badblockpos. As this chip-specific information is not directly rel

[PATCH v4 2/7] mtd: onenand: Store bad block marker position in chip struct

2019-02-18 Thread Schrempf Frieder
From: Frieder Schrempf The information about where the manufacturer puts the bad block markers inside the bad block and in the OOB data is stored in different places. Let's move this information to the chip struct, as we did it for rawnand. Signed-off-by: Frieder Schrempf --- drivers/mtd/nand/

[PATCH v4 5/7] mtd: rawnand: Support bad block markers in first, second or last page

2019-02-18 Thread Schrempf Frieder
From: Frieder Schrempf Currently supported bad block marker positions within the block are: * in first page only * in last page only * in first or second page Some ESMT NANDs are known to have been shipped by the manufacturer with bad block markers in the first or last page, instead of the first

[PATCH v4 7/7] mtd: rawnand: AMD: Also use the last page for bad block markers

2019-02-18 Thread Schrempf Frieder
From: Frieder Schrempf According to the datasheet of some Cypress SLC NANDs, the bad block markers can be in the first, second or last page of a block. So let's check all three locations. Signed-off-by: Frieder Schrempf Reviewed-by: Boris Brezillon --- drivers/mtd/nand/raw/nand_amd.c | 8

Re: [PATCH net-next 10/13] net: mvpp2: reset the XPCS while reconfiguring the serdes lanes

2019-02-18 Thread Russell King - ARM Linux admin
On Mon, Feb 18, 2019 at 11:26:30AM +0100, Antoine Tenart wrote: > Hi Russell, > > On Fri, Feb 15, 2019 at 05:12:24PM +, Russell King - ARM Linux admin > wrote: > > On Fri, Feb 15, 2019 at 04:32:38PM +0100, Antoine Tenart wrote: > > > The documentation advises to set the XPCS in reset while re

Re: [PATCH] trace: skip hwasan

2019-02-18 Thread Will Deacon
On Sat, Feb 16, 2019 at 11:34:34PM -0500, Qian Cai wrote: > Enabling function tracer with CONFIG_KASAN_SW_TAGS=y (hwasan) tracer > causes the whole system frozen on ThunderX2 systems with 256 CPUs, > because there is a burst of too much pointer access, and then KASAN will > dereference each byte of

Re: [RFC] net: dsa: qca8k: implement rgmii-id mode

2019-02-18 Thread Vinod Koul
On 15-02-19, 16:23, Andrew Lunn wrote: > On Fri, Feb 15, 2019 at 04:01:08PM +0100, Michal Vokáč wrote: > > Hi, > > > > networking on my boards [1], which are currently in linux-next, suddently > > stopped working. I tracked it down to this commit 5ecdd77c61c8 ("net: dsa: > > qca8k: disable delay f

Re: [PATCH] binder: reduce mmap_sem write-side lock

2019-02-18 Thread Minchan Kim
On Mon, Feb 18, 2019 at 09:32:08AM +0100, Greg KH wrote: > On Mon, Feb 18, 2019 at 05:11:45PM +0900, Minchan Kim wrote: > > binder has used write-side mmap_sem semaphore to release memory > > mapped at address space of the process. However, right lock to > > release pages is down_read, not down_wri

Re: [PATCH net-next 10/13] net: mvpp2: reset the XPCS while reconfiguring the serdes lanes

2019-02-18 Thread Russell King - ARM Linux admin
On Mon, Feb 18, 2019 at 10:43:02AM +, Russell King - ARM Linux admin wrote: > On Mon, Feb 18, 2019 at 11:26:30AM +0100, Antoine Tenart wrote: > > Hi Russell, > > > > On Fri, Feb 15, 2019 at 05:12:24PM +, Russell King - ARM Linux admin > > wrote: > > > On Fri, Feb 15, 2019 at 04:32:38PM +0

Re: [PATCH] Bluetooth: remove redundant zero check on count

2019-02-18 Thread Marcel Holtmann
Hi Colin, > Variable count is never zero inside the loop so the check if count is > zero is redundant and can be removed. Fix this. > > Detected by CoverityScan, CID#1466880 ("Logically dead code") > > Signed-off-by: Colin Ian King > --- > drivers/bluetooth/h4_recv.h | 3 --- > 1 file changed, 3

Re: [PATCH RESEND 0/3] Add quirk for reading BD_ADDR from fwnode property

2019-02-18 Thread Marcel Holtmann
Hi Matthias, > [initial post: https://lore.kernel.org/patchwork/cover/1028184/] > > On some systems the Bluetooth Device Address (BD_ADDR) isn't stored > on the Bluetooth chip itself. One way to configure the address is > through the device tree (patched in by the bootloader). The btqcomsmd > dri

Re: [PATCH] kvm: vmx: Fix entry nubmer check for add_atomic_switch_msr()

2019-02-18 Thread Xiaoyao Li
On Mon, 2019-02-18 at 16:26 +0800, linux.intel.com wrote: > On Fri, 2019-02-15 at 11:46 -0500, Konrad Rzeszutek Wilk wrote: > > On Thu, Feb 14, 2019 at 12:08:58PM +0800, Xiaoyao Li wrote: > > > Commit ca83b4a7f2d068da79a0 ("x86/KVM/VMX: Add find_msr() helper > > > function") > > > introduces the he

Re: linux-next: manual merge of the net-next tree with the rdma tree

2019-02-18 Thread Leon Romanovsky
On Mon, Feb 18, 2019 at 11:05:49AM +1100, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the net-next tree got a conflict in: > > drivers/infiniband/hw/mlx5/ib_rep.c > > between commits: > > 459cc69fa4c1 ("RDMA: Provide safe ib_alloc_device() function") > fc9e4477f924 ("RDM

Re: [PATCH net-next 10/13] net: mvpp2: reset the XPCS while reconfiguring the serdes lanes

2019-02-18 Thread Antoine Tenart
Russell, On Mon, Feb 18, 2019 at 10:43:02AM +, Russell King - ARM Linux admin wrote: > On Mon, Feb 18, 2019 at 11:26:30AM +0100, Antoine Tenart wrote: > > On Fri, Feb 15, 2019 at 05:12:24PM +, Russell King - ARM Linux admin > > wrote: > > > On Fri, Feb 15, 2019 at 04:32:38PM +0100, Antoin

Re: [PATCH] clocksource: exynos_mct: Remove unused header includes

2019-02-18 Thread Daniel Lezcano
On 18/02/2019 11:09, Krzysztof Kozlowski wrote: > The driver does not use sched.h and platform_device.h. > > Signed-off-by: Krzysztof Kozlowski > --- Applied for 5.1 Thanks -- Linaro.org │ Open source software for ARM SoCs Follow Linaro:

Re: [PATCH v11 0/3] Bug fixes for Qualcomm BT chip wcn3990

2019-02-18 Thread Marcel Holtmann
Hi Balakrishna, > The below issues are found in our recent testing. > > 1. Observed device is not going into off state or not responding. >As wcn3990 require a power pulses to turn on the irrespctive of >igniting regulators, it was observed that power on or power off >pulses are not i

Re: [PATCH net-next 10/13] net: mvpp2: reset the XPCS while reconfiguring the serdes lanes

2019-02-18 Thread Antoine Tenart
Russell, On Mon, Feb 18, 2019 at 10:47:57AM +, Russell King - ARM Linux admin wrote: > > Another case that needs to be considered: if the XPCS should be placed > into reset while reconfiguring the serdes lanes, is the same treatment > needed for the GMAC? That's something I wanted to check a

Re: [PATCH 1/3] dt-bindings: dmaengine: Add one new cell to present hardware slave id

2019-02-18 Thread Baolin Wang
Hi Arnd, On Mon, 18 Feb 2019 at 18:31, Arnd Bergmann wrote: > > On Tue, Feb 12, 2019 at 9:25 AM Baolin Wang wrote: > > On Fri, 1 Feb 2019 at 19:53, Baolin Wang wrote: > > > On Thu, 31 Jan 2019 at 00:52, Arnd Bergmann wrote: > > > > On Tue, Jan 22, 2019 at 2:21 PM Baolin Wang > > > > wrote: >

[PATCH 0/4] iomap: fix multiple consistency issues, interface cleanup

2019-02-18 Thread Hugo Lefeuvre
Hi, This patch cleans up the iomap interface. The first patch makes the include/asm-generic/iomap.h header compliant with the kernel style guidelines by adding missing function args identifier names. The second and fourth patches address multiple compilation warnings due to missing const qualifi

[PATCH 2/4] iomap: add missing const to ioread*/iowrite addr arg

2019-02-18 Thread Hugo Lefeuvre
ioread* and iowrite* definitions from asm-generic/iomap.h and lib/iomap.c are missing const qualifiers. This is inconsistent with the definitions from asm-generic/io.h and results in compilation warnings when compiling drivers. Add missing const qualifiers. Signed-off-by: Hugo Lefeuvre --- incl

[PATCH 3/4] io: change io*_rep definitions to take ulong count

2019-02-18 Thread Hugo Lefeuvre
ioread*_rep and iowrite*_rep from asm-generic/io.h expect unsigned int count parameter. This is inconsistent with all other definitions in the kernel which take unsigned long count. Change io*_rep definitions to take unsigned long count instead of unsigned int. Signed-off-by: Hugo Lefeuvre ---

[PATCH 4/4] lib/iomap: add missing const to mmio_ins* addr arg

2019-02-18 Thread Hugo Lefeuvre
mmio_ins* definitions from lib/iomap.c are missing const qualifiers for the addr argument. This results in compilation warnings when compiling drivers. Add missing const qualifiers. Signed-off-by: Hugo Lefeuvre --- lib/iomap.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --

Re: [PATCH 6/7] MIPS: SGI-IP27: use generic PCI driver

2019-02-18 Thread Thomas Bogendoerfer
On Mon, 28 Jan 2019 05:32:15 -0800 Christoph Hellwig wrote: > Note that we could probably fix these by just switching IP27 and > other users of the bridge chip to use the dma_pfn_offset field > in struct device and stop overriding these functions. during my final round of tests for v2 of the pat

Re: [PATCH 2/3] power: reset: at91-poweroff: add support for SAM9X60

2019-02-18 Thread Nicolas.Ferre
On 14/02/2019 at 12:24, Claudiu Beznea - M18063 wrote: > From: Claudiu Beznea > > Add support for SAM9X60 shutdown controller. > > Signed-off-by: Claudiu Beznea Acked-by: Nicolas Ferre > --- > drivers/power/reset/at91-sama5d2_shdwc.c | 11 +++ > 1 file changed, 11 insertions(+) >

Re: [PATCH 1/3] power: reset: at91-poweroff: add RTT wakeup capability

2019-02-18 Thread Nicolas.Ferre
On 14/02/2019 at 12:24, Claudiu Beznea - M18063 wrote: > From: Claudiu Beznea > > Add RTT wakeup capability. > > Signed-off-by: Claudiu Beznea Acked-by: Nicolas Ferre > --- > drivers/power/reset/at91-sama5d2_shdwc.c | 14 ++ > 1 file changed, 14 insertions(+) > > diff --git a

Re: [PATCH 2/2] ASoC: samsung: i2s: Fix multiple "IIS multi" devices initialization

2019-02-18 Thread Krzysztof Kozlowski
On Fri, 15 Feb 2019 at 15:48, Sylwester Nawrocki wrote: > > On some SoCs (e.g. Exynos5433) there are multiple "IIS multi audio > interfaces" and the driver will try to register there multiple times > same platform device for the secondary FIFO, which of course fails > miserably. To fix this we de

[PATCH] drm/tegra: vic: fix implicit function declaration warning

2019-02-18 Thread Anders Roxell
When CONFIG_IOMMU_API isn't set the following warnings pops up: drivers/gpu/drm/tegra/vic.c: In function ‘vic_boot’: drivers/gpu/drm/tegra/vic.c:110:31: error: implicit declaration of function ‘dev_iommu_fwspec_get’; did you mean ‘iommu_fwspec_free’? [-Werror=implicit-function-declaration] st

Re: [PATCH 3/3] dt-bindings: arm: atmel: add binding for SAM9X60 shutdown controller

2019-02-18 Thread Nicolas.Ferre
On 14/02/2019 at 12:24, Claudiu Beznea - M18063 wrote: > From: Claudiu Beznea > > Add documentation for SAM9X60 shutdown controller. > > Signed-off-by: Claudiu Beznea > --- > Documentation/devicetree/bindings/arm/atmel-sysregs.txt | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-)

Re: [PATCH] platform: set of_node in platform_device_register_full()

2019-02-18 Thread Måns Rullgård
"Rafael J. Wysocki" writes: > On Sat, Feb 16, 2019 at 5:50 PM Mans Rullgard wrote: >> >> If the provided fwnode is an OF node, set dev.of_node as well. >> >> Signed-off-by: Mans Rullgard >> --- >> drivers/base/platform.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/base/

Re: [PATCH] cpufreq: scmi: fix use-after-free in scmi_cpufreq_exit()

2019-02-18 Thread Sudeep Holla
On Sat, Feb 16, 2019 at 11:31:48AM -0500, Yangtao Li wrote: > This issue was detected with the help of Coccinelle. So > change the order of function calls to fix it. > > Fixes: 1690d8bb91e37 (cpufreq: scpi/scmi: Fix freeing of dynamic OPPs) > Acked-by: Sudeep Holla -- Regards, Sudeep

[PATCH 1/4] iomap: add missing function args identifier names

2019-02-18 Thread Hugo Lefeuvre
Add missing function arguments identifier names to asm-generic/iomap.h definitions. This addresses multiple checkpatch.pl code style warnings. Signed-off-by: Hugo Lefeuvre --- include/asm-generic/iomap.h | 32 1 file changed, 16 insertions(+), 16 deletions(-) di

Re: [PATCH -next] ASoC: samsung: i2s: Fix return value check in i2s_create_secondary_device()

2019-02-18 Thread Sylwester Nawrocki
On 2/16/19 02:20, Wei Yongjun wrote: > In case of error, the function platform_device_register_simple() returns > ERR_PTR() and never returns NULL. The NULL test in the return value > check should be replaced with IS_ERR(). Thanks for the patch, it looks good but I have already prepared other fix

RE: [EXT] Re: [PATCH net-next 10/13] net: mvpp2: reset the XPCS while reconfiguring the serdes lanes

2019-02-18 Thread Stefan Chulski
> -Original Message- > From: Antoine Tenart > Sent: Monday, February 18, 2019 12:52 PM > To: Russell King - ARM Linux admin > Cc: Antoine Tenart ; da...@davemloft.net; > net...@vger.kernel.org; linux-kernel@vger.kernel.org; > thomas.petazz...@bootlin.com; maxime.chevall...@bootlin.com;

Re: [PATCH v2 1/2] leds: Add Intel Cherry Trail Whiskey Cove PMIC LEDs

2019-02-18 Thread Hans de Goede
Hi, On 17-02-19 18:45, Pavel Machek wrote: Hi! I see... and yes, that would be the easiest solution. But somehow I see "this LED is controlled by charging state" as primary and "it shows pulses instead of staying on" as secondary eye-candy. This week there was another driver for charger LED.

Re: [PATCH 03/13] mm: Add generic p?d_large() macros

2019-02-18 Thread Mark Rutland
On Fri, Feb 15, 2019 at 05:02:24PM +, Steven Price wrote: > From: James Morse > > Exposing the pud/pgd levels of the page tables to walk_page_range() means > we may come across the exotic large mappings that come with large areas > of contiguous memory (such as the kernel's linear map). > > Fo

Re: [RFC 0/4] clk/driver: platform: Fix kfree() of const memory on setting driver_override

2019-02-18 Thread Krzysztof Kozlowski
On Mon, 18 Feb 2019 at 11:40, Geert Uytterhoeven wrote: > > Hi Krzysztof, > > On Mon, Feb 18, 2019 at 11:27 AM Krzysztof Kozlowski wrote: > > The problem > > === > > Several device types (platform, amba, spi etc.) provide a driver_override > > field. On sysfs store or during device remov

Re: mremap vs sysctl_max_map_count

2019-02-18 Thread Kirill A. Shutemov
On Mon, Feb 18, 2019 at 10:57:18AM +0100, Vlastimil Babka wrote: > On 2/18/19 9:33 AM, Oscar Salvador wrote: > > > > Hi all, > > > > I would like to bring up a topic that comes from an issue a customer of ours > > is facing with the mremap syscall + hitting the max_map_count threshold: > > > > W

<    1   2   3   4   5   6   7   8   9   10   >