RE: [PATCH V15 4/6] i2c: tegra: Add DMA support

2019-02-08 Thread Sowjanya Komatineni
> > Please use "release_dma:" variant that I suggested in the comment to v14 > > because: > > > > > 1) It's just a good (and common-style in kernel) tone to unwind errors > > handling in the opposite order, it makes code more straight forward and > > helps to avoid silly mistakes. > > > > 2) I

Re: [PATCH v10 12/25] arm64: irqflags: Use ICC_PMR_EL1 for interrupt masking

2019-02-08 Thread Nathan Chancellor
On Fri, Feb 08, 2019 at 09:36:48AM +, Julien Thierry wrote: > Hi Nathan, > > On 08/02/2019 04:35, Nathan Chancellor wrote: > > On Thu, Jan 31, 2019 at 02:58:50PM +, Julien Thierry wrote: > > [...] > > > > > Hi Julien, > > > > This patch introduced a slew of Clang warnings: > > > > In

Re: [PATCH v5] scsi/ata: Use unsigned int for cmd's type in ioctls in scsi_host_template

2019-02-08 Thread Nathan Chancellor
On Fri, Feb 08, 2019 at 12:05:01AM -0800, Christoph Hellwig wrote: > On Thu, Feb 07, 2019 at 09:07:20AM -0700, Nathan Chancellor wrote: > > Clang warns several times in the scsi subsystem (trimmed for brevity): > > > > drivers/scsi/hpsa.c:6209:7: warning: overflow converting case value to > > swit

Re: [PATCH] Input: ps2-gpio - flush TX work when closing port

2019-02-08 Thread Danilo Krummrich
On 2019-02-08 08:31, Dmitry Torokhov wrote: On Thu, Feb 07, 2019 at 06:03:03PM -0500, Sven Van Asbroeck wrote: On Thu, Feb 7, 2019 at 5:27 PM Dmitry Torokhov wrote: > > + flush_work(&drvdata->tx_work.work); Would cancel_work_sync() be better than flush_work() ? No, because we want to h

[PATCH v2] module: Cure the MODULE_LICENSE "GPL" vs. "GPL v2" bogosity

2019-02-08 Thread Thomas Gleixner
The original MODULE_LICENSE string for kernel modules licensed under the GPL v2 (only / or later) was simply "GPL", which was - and still is - completely sufficient for the purpose of module loading and checking whether the module is free software or proprietary. In January 2003 this was changed w

[PATCH v2 0/2] tpm: Unify send() callbacks

2019-02-08 Thread Jarkko Sakkinen
A portion of send() callbacks have returned length, in many cases just returning back what was given as an argument, and tpm_crb has returned 0 on success. This patch set fixes and unifies the behaviour. v2: The drivers tpm_nsc and tpm_infineon were forgotten. For this version I checked both with

[PATCH v2 1/2] tpm: Unify the send callback behaviour

2019-02-08 Thread Jarkko Sakkinen
The send() callback should never return length as it does not in every driver except tpm_crb in the success case. The reason is that the main transmit functionality only cares about whether the transmit was successful or not and ignores the count completely. Cc: sta...@vger.kernel.org Signed-off-b

[PATCH v2 2/2] tpm/tpm_i2c_atmel: Return -E2BIG when the transfer is incomplete

2019-02-08 Thread Jarkko Sakkinen
Return -E2BIG when the transfer is incomplete. The upper layer does not retry, so not doing that is incorrect behaviour. Cc: sta...@vger.kernel.org Fixes: a2871c62e186 ("tpm: Add support for Atmel I2C TPMs") Signed-off-by: Jarkko Sakkinen --- drivers/char/tpm/tpm_i2c_atmel.c | 4 1 file cha

Re: [PATCH 18/35] irqchip: davinci-aintc: move the driver to drivers/irqchip

2019-02-08 Thread Bartosz Golaszewski
wt., 5 lut 2019 o 00:43 David Lechner napisał(a): > > On 1/31/19 7:39 AM, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > > > The aintc driver has now been cleaned up. Move it to drivers/irqchip > > where it belongs. There's no device-tree support for any dm* board so > > there's no

[PATCH] gma500: fix some indentation issues

2019-02-08 Thread Colin King
From: Colin Ian King There are several statements that are indented incorrectly. Fix these. Signed-off-by: Colin Ian King --- drivers/gpu/drm/gma500/cdv_intel_dp.c | 5 ++--- drivers/gpu/drm/gma500/mid_bios.c | 2 +- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/gp

Re: [PATCH 1/2] tpm: Unify the send callback behaviour

2019-02-08 Thread Jarkko Sakkinen
On Fri, Feb 08, 2019 at 10:45:53AM -0500, Stefan Berger wrote: > On 2/8/19 10:42 AM, Jarkko Sakkinen wrote: > > On Fri, Feb 08, 2019 at 09:42:16AM -0500, Stefan Berger wrote: > On 2/8/19 > > 9:05 AM, Jarkko Sakkinen wrote: > > > At least tpm_nsc_send (tpm_nsc.c) and tpm_inf_send (tpm_infineon.c) a

Re: [PATCH v6 4/4] platform/chrome: rtc: Add RTC driver

2019-02-08 Thread Nick Crews
Hi Enric and Alexandre, On Fri, Feb 8, 2019 at 5:18 AM Enric Balletbo i Serra wrote: > > Hi, > > On 8/2/19 2:23, Nick Crews wrote: > > This Embedded Controller has an internal RTC that is exposed > > as a standard RTC class driver with read/write functionality. > > > > The driver is added to the

[PATCH v3 2/5] i2c:ocores: do not handle IRQ if IF is not set

2019-02-08 Thread Federico Vaga
If the Interrupt Flag (IF) is not set, we should not handle the IRQ: - the line can be shared with other devices - it can be a spurious interrupt To avoid reading twice the status register, the ocores_process() function expects it to be read by the caller. Signed-off-by: Federico Vaga Acked-by:

[PATCH v3 0/5]

2019-02-08 Thread Federico Vaga
This patch set provides improvements to the i2c-ocore driver. [V2 -> V3] - fix error condition on platform_get_irq(). Copied from https://patchwork.ozlabs.org/patch/1038409/ [V1 -> V2] - replaced usleep_range() with udelay() so that the polling version can be used in atomic context. - added d

[PATCH v3 1/5] i2c:ocores: stop transfer on timeout

2019-02-08 Thread Federico Vaga
Detecting a timeout is ok, but we also need to assert a STOP command on the bus in order to prevent it from generating interrupts when there are no on going transfers. Example: very long transmission. 1. ocores_xfer: START a transfer 2. ocores_isr : handle byte by byte the transfer 3. ocores_xfer

[PATCH v3 5/5] i2c:ocores: checkpatch fixes

2019-02-08 Thread Federico Vaga
Miscellaneous style fixes from checkpatch Signed-off-by: Federico Vaga --- drivers/i2c/busses/i2c-ocores.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/drivers/i2c/busses/i2c-ocores.c b/drivers/i2c/busses/i2c-ocores.c index 5b80190..ba35d2a 100644 ---

[PATCH v3 4/5] i2c:ocores: add SPDX tag

2019-02-08 Thread Federico Vaga
It adds the SPDX tag and it removes the old text about the GPLv2. Signed-off-by: Federico Vaga --- drivers/i2c/busses/i2c-ocores.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/i2c/busses/i2c-ocores.c b/drivers/i2c/busses/i2c-ocores.c index bbe3e96..5b80190 10

[PATCH v3 3/5] i2c:ocores: add polling interface

2019-02-08 Thread Federico Vaga
This driver assumes that an interrupt line is always available for the I2C master. This is not always the case and this patch adds support for a polling version. Signed-off-by: Federico Vaga --- drivers/i2c/busses/i2c-ocores.c | 176 +++- 1 file changed, 156 i

Re: [PATCH v2 0/2] tpm: Unify send() callbacks

2019-02-08 Thread Stefan Berger
On 2/8/19 11:03 AM, Jarkko Sakkinen wrote: A portion of send() callbacks have returned length, in many cases just returning back what was given as an argument, and tpm_crb has returned 0 on success. This patch set fixes and unifies the behaviour. v2: The drivers tpm_nsc and tpm_infineon were for

Re: [PATCH V15 4/6] i2c: tegra: Add DMA support

2019-02-08 Thread Dmitry Osipenko
08.02.2019 18:58, Sowjanya Komatineni пишет: > > >>> Please use "release_dma:" variant that I suggested in the comment to v14 >>> because: >>> 1) It's just a good (and common-style in kernel) tone to unwind errors >>> handling in the opposite order, it makes code more straight forward and

[PATCH v2] Input: st1232 - switch to gpiod API

2019-02-08 Thread Martin Kepplinger
Use devm_gpiod_get_optional() and gpiod_set_value_cansleep() instead of the old API. The st1232_ts_power() now passes on the inverted "poweron" value to reflect the correct logical value. Signed-off-by: Martin Kepplinger --- ok. tested. If i get that right, assigning different gpio functions wou

Re: [PATCH v6 4/4] platform/chrome: rtc: Add RTC driver

2019-02-08 Thread Alexandre Belloni
On 08/02/2019 13:18:38+0100, Enric Balletbo i Serra wrote: > > Changes in v6: > > - In the core, actually unregister the RTC child platform_device. > > > > Changes in v5: None > > Changes in v4: > > - Change me email to @chromium.org from @google.com > > - Move "Add RTC driver" before "Add sysfs a

Re: [PATCH v10, RESEND 4/6] tpm: move tpm_chip definition to include/linux/tpm.h

2019-02-08 Thread Nathan Chancellor
On Fri, Feb 08, 2019 at 09:41:14AM +0100, Roberto Sassu wrote: > On 2/8/2019 5:24 AM, Nathan Chancellor wrote: > > > diff --git a/include/linux/tpm.h b/include/linux/tpm.h > > > index afd022fc9d3d..816e686a73ac 100644 > > > --- a/include/linux/tpm.h > > > +++ b/include/linux/tpm.h > > > @@ -22,6 +2

Re: [PATCH v10 12/25] arm64: irqflags: Use ICC_PMR_EL1 for interrupt masking

2019-02-08 Thread Catalin Marinas
On Fri, Feb 08, 2019 at 09:36:48AM +, Julien Thierry wrote: > From e839dec632bbf440efe8314751138ba46324078c Mon Sep 17 00:00:00 2001 > From: Julien Thierry > Date: Fri, 8 Feb 2019 09:21:58 + > Subject: [PATCH] arm64: irqflags: Fix clang build warnings > > Clang complains when passing asm

Re: [PATCH v6 4/4] platform/chrome: rtc: Add RTC driver

2019-02-08 Thread Alexandre Belloni
On 08/02/2019 09:10:02-0700, Nick Crews wrote: > Hi Enric and Alexandre, > > On Fri, Feb 8, 2019 at 5:18 AM Enric Balletbo i Serra > wrote: > > > > Hi, > > > > On 8/2/19 2:23, Nick Crews wrote: > > > This Embedded Controller has an internal RTC that is exposed > > > as a standard RTC class driver

Re: [PATCH v4 3/3] powerpc/32: Add KASAN support

2019-02-08 Thread Daniel Axtens
Hi Christophe, I've been attempting to port this to 64-bit Book3e nohash (e6500), although I think I've ended up with an approach more similar to Aneesh's much earlier (2015) series for book3s. Part of this is just due to the changes between 32 and 64 bits - we need to hack around the discontiguo

Re: [PATCH v2 net-next] net: fixed-phy: Add fixed_phy_register_with_gpiod() API

2019-02-08 Thread Moritz Fischer
Hi David, On Thu, Feb 7, 2019 at 6:15 PM David Miller wrote: > > From: Moritz Fischer > Date: Thu, 7 Feb 2019 12:14:55 -0800 > > > Add fixed_phy_register_with_gpiod() API. It lets users create a > > fixed_phy instance that uses a GPIO descriptor which was obtained > > externally e.g. through pl

Re: [PATCH 1/2] tpm: Unify the send callback behaviour

2019-02-08 Thread Stefan Berger
On 2/8/19 11:07 AM, Jarkko Sakkinen wrote: On Fri, Feb 08, 2019 at 10:45:53AM -0500, Stefan Berger wrote: On 2/8/19 10:42 AM, Jarkko Sakkinen wrote: On Fri, Feb 08, 2019 at 09:42:16AM -0500, Stefan Berger wrote: > On 2/8/19 9:05 AM, Jarkko Sakkinen wrote: At least tpm_nsc_send (tpm_nsc.c) and

Re: [PATCH] Input: ps2-gpio - flush TX work when closing port

2019-02-08 Thread Sven Van Asbroeck
On Fri, Feb 8, 2019 at 10:51 AM Danilo Krummrich wrote: > > I agree with Dmitry > So do I, you guys are absolutely right. As far as I can see, this patch fixes the user-after-free. So, after Dmitry changes flush_work() to flush_delayed_work() : Reviewed-by: Sven Van Asbroeck

Re: [PATCH] remove unused end_pfn

2019-02-08 Thread Joerg Roedel
On Fri, Feb 08, 2019 at 02:04:38PM +, Tom Murphy wrote: > This variable is useless. > > --- > drivers/iommu/dma-iommu.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) A similar change is already in the iommu tree[1]. Joerg [1] https://git.kernel.org/pub/scm/linux/kernel

Re: [PATCH] LSM: Allow syzbot to ignore security= parameter.

2019-02-08 Thread Casey Schaufler
On 2/8/2019 2:52 AM, Tetsuo Handa wrote: > On 2019/02/08 1:24, Casey Schaufler wrote: > Then, I think that it is straightforward (and easier to manage) to ignore > security= parameter > when lsm= parameter is specified. That reduces flexibility somewhat. If I am debugging security

Re: [PATCH v2 0/2] tpm: Unify send() callbacks

2019-02-08 Thread Jarkko Sakkinen
On Fri, Feb 08, 2019 at 11:14:42AM -0500, Stefan Berger wrote: > On 2/8/19 11:03 AM, Jarkko Sakkinen wrote: > > A portion of send() callbacks have returned length, in many cases just > > returning back what was given as an argument, and tpm_crb has returned 0 on > > success. This patch set fixes an

[PATCH v1 2/3] PCI / ACPI: Remove the need for 'struct hotplug_params'

2019-02-08 Thread Alexandru Gagniuc
We used to first parse all the _HPP and _HPX tables before using the information to program registers of PCIe devices. Up until HPX type 2, there was only one structure of each type, so we could cheat and store it on the stack. With HPX type 3 we get an arbitrary number of entries, so the above mo

[PATCH v1 3/3] PCI / ACPI: Implement Type 3 _HPX record

2019-02-08 Thread Alexandru Gagniuc
_HPX Type 3 is intended to be more generic and allow configuration of settings not possible with Type 2 tables. For example, FW could ensure that the completion timeout value is set accordingly throughout the PCI tree. Implement support for _HPX3 tables. Signed-off-by: Alexandru Gagniuc --- dri

[PATCH v1 1/3] PCI / ACPI: Do not export pci_get_hp_params()

2019-02-08 Thread Alexandru Gagniuc
This is only used within drivers/pci, and there is no reason to make it available outside of the PCI core. Signed-off-by: Alexandru Gagniuc --- drivers/pci/pci-acpi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/pci/pci-acpi.c b/drivers/pci/pci-acpi.c index e1949f7efd9c..b25e5fa9d1

Re: [PATCH 3/4] Makefile: lld: tell clang to use lld

2019-02-08 Thread Nathan Chancellor
On Fri, Feb 08, 2019 at 03:21:15PM +0100, Sedat Dilek wrote: > Hi Nick, > > why don't you simply check for CONFIG_LD_IS_LLD existing (when [1] applied)? > Hi Sedat, This section runs before Kconfig so we can't rely on the symbols it generates. See commit 995167420797 ("kbuild: remove cc-name va

Re: [PATCH 2/3] gpu: ipu-v3: ipu-ic: Add support for BT.709 encoding

2019-02-08 Thread Tim Harvey
On Sun, Feb 3, 2019 at 11:48 AM Steve Longerbeam wrote: > > Pass v4l2 encoding enum to the ipu_ic task init functions, and add > support for the BT.709 encoding and inverse encoding matrices. > > Reported-by: Tim Harvey > Signed-off-by: Steve Longerbeam > --- > drivers/gpu/ipu-v3/ipu-ic.c

Re: [PATCH 1/2] tpm: Unify the send callback behaviour

2019-02-08 Thread Jarkko Sakkinen
On Fri, Feb 08, 2019 at 11:19:04AM -0500, Stefan Berger wrote: > On 2/8/19 11:07 AM, Jarkko Sakkinen wrote: > > On Fri, Feb 08, 2019 at 10:45:53AM -0500, Stefan Berger wrote: > > > On 2/8/19 10:42 AM, Jarkko Sakkinen wrote: > > > > On Fri, Feb 08, 2019 at 09:42:16AM -0500, Stefan Berger wrote: > On

Re: [PATCH 25/35] ARM: davinci: cp-intc: use the new-style config structure

2019-02-08 Thread Bartosz Golaszewski
wt., 5 lut 2019 o 01:29 David Lechner napisał(a): > > On 1/31/19 7:39 AM, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > > > Modify the cp-intc driver to take all its configuration from the new > > config structure. Stop referencing davinci_soc_info in any way. > > Move the declarat

Re: [PATCH 1/2] tpm: Unify the send callback behaviour

2019-02-08 Thread Jarkko Sakkinen
On Fri, Feb 08, 2019 at 06:26:15PM +0200, Jarkko Sakkinen wrote: > On Fri, Feb 08, 2019 at 11:19:04AM -0500, Stefan Berger wrote: > > On 2/8/19 11:07 AM, Jarkko Sakkinen wrote: > > > On Fri, Feb 08, 2019 at 10:45:53AM -0500, Stefan Berger wrote: > > > > On 2/8/19 10:42 AM, Jarkko Sakkinen wrote: >

Re: [PATCH v3 1/2] PCI: altera: Add Stratix 10 PCIe support

2019-02-08 Thread Lorenzo Pieralisi
Apologies, I have dropped the ball on this one. On Wed, Jan 02, 2019 at 02:16:48PM +0800, Ley Foon Tan wrote: > Add PCIe Root Port support for Stratix 10 device. > > Main differences: > - HIP interface to access Root Port configuration register. > - TLP programming flow: > - One REG0 register >

[PATCH v3 1/2] tpm: Unify the send callback behaviour

2019-02-08 Thread Jarkko Sakkinen
The send() callback should never return length as it does not in every driver except tpm_crb in the success case. The reason is that the main transmit functionality only cares about whether the transmit was successful or not and ignores the count completely. Cc: sta...@vger.kernel.org Signed-off-b

Re: [PATCH 1/2] sched/fair: optimization of update_blocked_averages()

2019-02-08 Thread Peter Zijlstra
On Wed, Feb 06, 2019 at 05:14:21PM +0100, Vincent Guittot wrote: > --- a/kernel/sched/fair.c > +++ b/kernel/sched/fair.c > @@ -346,6 +346,18 @@ static inline bool list_add_leaf_cfs_rq(struct cfs_rq > *cfs_rq) > static inline void list_del_leaf_cfs_rq(struct cfs_rq *cfs_rq) > { > if (cfs_rq

Re: [PATCH 1/2] sched/fair: optimization of update_blocked_averages()

2019-02-08 Thread Peter Zijlstra
On Fri, Feb 08, 2019 at 04:44:53PM +0100, Vincent Guittot wrote: > On Fri, 8 Feb 2019 at 16:40, Peter Zijlstra wrote: > > > > > > Argh head hurts!! > > > > On Wed, Feb 06, 2019 at 05:14:21PM +0100, Vincent Guittot wrote: > > > @@ -4438,6 +4450,10 @@ static int tg_unthrottle_up(struct task_group *t

Re: [PATCH v8 1/6] fieldbus_dev: add Fieldbus Device subsystem.

2019-02-08 Thread Sven Van Asbroeck
On Fri, Feb 8, 2019 at 7:18 AM Greg KH wrote: > > > +static DEFINE_IDA(fieldbus_ida); > > You forget to destroy this ida structure when the module is removed. > It's a common thing to get wrong :( > But fieldbus_ida is allocated on the heap. So as long as calls to ida_simple_get() and ida_simple_

[PATCH v3 0/2] tpm: Unify send() callbacks

2019-02-08 Thread Jarkko Sakkinen
A portion of send() callbacks have returned length, in many cases just returning back what was given as an argument, and tpm_crb has returned 0 on success. This patch set fixes and unifies the behaviour. v3: tpm_tis_core fix was left out of the staging area :-( v2: The drivers tpm_nsc and tpm_in

Re: [PATCH -next] hugetlbfs: a terminator for hugetlb_param_specs[]

2019-02-08 Thread David Howells
Mike Kravetz wrote: > Thanks for fixing this. Looks like a simple oversight when 2284cf59cbce > was added. I've already pushed a fix for this which Al should have folded in already. > FYI David, the fs_parameter_spec example in the documentation (mount_api.txt) > is also missing a terminator.

[PATCH v3 2/2] tpm/tpm_i2c_atmel: Return -E2BIG when the transfer is incomplete

2019-02-08 Thread Jarkko Sakkinen
Return -E2BIG when the transfer is incomplete. The upper layer does not retry, so not doing that is incorrect behaviour. Cc: sta...@vger.kernel.org Fixes: a2871c62e186 ("tpm: Add support for Atmel I2C TPMs") Signed-off-by: Jarkko Sakkinen --- drivers/char/tpm/tpm_i2c_atmel.c | 4 1 file cha

Re: [PATCH v6 00/16] locking/lockdep: Add support for dynamic keys

2019-02-08 Thread Bart Van Assche
On Fri, 2019-02-08 at 11:43 +, Will Deacon wrote: > I've also been trying to understand why it's necessary to check both of the > pending_free entries, and I'm still struggling somewhat. It's true that the > wakeup in get_pending_free_lock() could lead to both entries being used > without the R

Re: [PATCH v3] dt-bindings: reset: meson: add g12a bindings

2019-02-08 Thread Philipp Zabel
On Thu, 2019-02-07 at 14:10 +0100, Neil Armstrong wrote: [...] > The controller is the exact same as Meson8, GXBB, and AXG. > > We had doubts since the previous datasheets were not clear, but for G12A we > are sure it's 100% same to at least GXBB and AXG, thus using the same > compatible as AXG si

Re: linux-next: Tree for Feb 8 (drivers/char/tpm/)

2019-02-08 Thread Randy Dunlap
On 2/8/19 2:26 AM, Stephen Rothwell wrote: > Hi all, > > Changes since 20190207: > on i386 or x86_64: ERROR: "tpm_chip_stop" [drivers/char/tpm/tpm_tis_core.ko] undefined! ERROR: "tpm_chip_start" [drivers/char/tpm/tpm_tis_core.ko] undefined! Full randconfig file is attached. -- ~Randy # # Au

Re: [PATCH v3 1/2] tpm: Unify the send callback behaviour

2019-02-08 Thread Stefan Berger
On 2/8/19 11:30 AM, Jarkko Sakkinen wrote: static void tpm_nsc_cancel(struct tpm_chip *chip) diff --git a/drivers/char/tpm/tpm_tis_core.c b/drivers/char/tpm/tpm_tis_core.c index 60e2038652b8..1d781c19f112 100644 --- a/drivers/char/tpm/tpm_tis_core.c +++ b/drivers/char/tpm/tpm_tis_core.c @@ -507

Re: [PATCH net-next] ethtool: Remove unnecessary null check in ethtool_rx_flow_rule_create

2019-02-08 Thread Pablo Neira Ayuso
On Thu, Feb 07, 2019 at 09:46:53PM -0700, Nathan Chancellor wrote: > net/core/ethtool.c:3023:19: warning: address of array > 'ext_m_spec->h_dest' will always evaluate to 'true' > [-Wpointer-bool-conversion] > if (ext_m_spec->h_dest) { > ~~ ^~ > > h_

Re: [PATCH v2] lib/scatterlist: Provide a DMA page iterator

2019-02-08 Thread Jason Gunthorpe
On Thu, Feb 07, 2019 at 03:26:47PM -0700, Jason Gunthorpe wrote: > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c > b/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c > index 31786b200afc47..e84f6aaee778f0 100644 > +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_ttm_buffer.c > @@ -311,7 +311,13 @@ static d

Re: [PATCH v10, RESEND 4/6] tpm: move tpm_chip definition to include/linux/tpm.h

2019-02-08 Thread Roberto Sassu
On 2/8/2019 5:16 PM, Nathan Chancellor wrote: On Fri, Feb 08, 2019 at 09:41:14AM +0100, Roberto Sassu wrote: On 2/8/2019 5:24 AM, Nathan Chancellor wrote: diff --git a/include/linux/tpm.h b/include/linux/tpm.h index afd022fc9d3d..816e686a73ac 100644 --- a/include/linux/tpm.h +++ b/include/linux

Re: [PATCH v8 0/8] Introduce the for_each_set_clump8 macro

2019-02-08 Thread Andy Shevchenko
On Tue, Jan 29, 2019 at 05:07:34PM -0800, Andrew Morton wrote: > On Mon, 14 Jan 2019 15:19:17 +0900 William Breathitt Gray > wrote: > It's a shame that it doesn't actually dercease the kernel line count, > but there are other benefits. > > The patches are missing the hoped-for acks, but I think

Re: [PATCH 6/7] PCI: qcom: Add QCS404 PCIe controller support

2019-02-08 Thread Niklas Cassel
On Fri, Jan 25, 2019 at 03:45:08PM -0800, Bjorn Andersson wrote: > The QCS404 platform contains a PCIe controller of version 2.4.0 and a > Qualcomm PCIe2 PHY. The driver already supports version 2.4.0, for the > IPQ4019, but this support touches clocks and resets related to the PHY > as well, and t

Re: [PATCH/RFC] driver core: Postpone DMA tear-down until after devres release

2019-02-08 Thread Joerg Roedel
Hi Geert, On Thu, Feb 07, 2019 at 08:36:53PM +0100, Geert Uytterhoeven wrote: > diff --git a/drivers/base/dd.c b/drivers/base/dd.c > index 8ac10af17c0043a3..d62487d024559620 100644 > --- a/drivers/base/dd.c > +++ b/drivers/base/dd.c > @@ -968,9 +968,9 @@ static void __device_release_driver(struct

KASAN: wild-memory-access Write in fib6_purge_rt

2019-02-08 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:cc7335786f72 socket: fix for Add SO_TIMESTAMP[NS]_NEW git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=16539260c0 kernel config: https://syzkaller.appspot.com/x/.config?x=33ad02b9305759c3 dashboard

Re: [PATCH 32/35] ARM: davinci: remove intc related fields from davinci_soc_info

2019-02-08 Thread Bartosz Golaszewski
czw., 7 lut 2019 o 15:04 Sekhar Nori napisał(a): > > On 31/01/19 7:09 PM, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > > > These are no longer used. Remove them. > > > > Signed-off-by: Bartosz Golaszewski > > I assume you are going to drop this patch and keep the priority setting

Re: [PATCH 1/3] ASoC: msm8916-wcd-analog: add missing license information

2019-02-08 Thread Mark Brown
On Fri, Feb 08, 2019 at 04:15:02PM +0100, Johan Hovold wrote: > Ah, yes, that makes sense for consistency since you've already enforced > that style. And while I don't think the all-c++-comment headers look > better in general, for the single copyright statement case it's not too > bad. Yeah, I'm

Re: [PATCH v2 0/7] binder: eliminate use of vmalloc space for binder buffers

2019-02-08 Thread Todd Kjos
On Fri, Feb 8, 2019 at 3:26 AM Greg KH wrote: > > On Wed, Jan 30, 2019 at 02:46:48PM -0800, Todd Kjos wrote: > > Binder buffers have always been mapped into kernel space > > via map_kernel_range_noflush() to allow the binder driver > > to modify the buffer before posting to userspace for > > proce

[PATCH V16 4/6] i2c: tegra: Add DMA support

2019-02-08 Thread Sowjanya Komatineni
This patch adds DMA support for Tegra I2C. Tegra I2C TX and RX FIFO depth is 8 words. PIO mode is used for transfer size of the max FIFO depth and DMA mode is used for transfer size higher than max FIFO depth to save CPU overhead. PIO mode needs full intervention of CPU to fill or empty FIFO's an

Re: [PATCH] arm64: dts: rockchip: Add on-board WiFi/BT support for Rock960 boards

2019-02-08 Thread Peter Robinson
Hi Mani, On Thu, Feb 7, 2019 at 5:54 AM Manivannan Sadhasivam wrote: > > Add on-board WiFi/BT support for Rock960 boards such as Rock960 based > on AP6356S and Ficus based on AP6354 wireless modules. > > Firmwares for the respective boards are available here: > > http://people.linaro.org/~manivan

[PATCH V16 2/6] i2c: tegra: add bus clear Master Support

2019-02-08 Thread Sowjanya Komatineni
Bus clear feature of Tegra I2C controller helps to recover from bus hang when I2C master loses the bus arbitration due to the slave device holding SDA LOW continuously for some unknown reasons. Per I2C specification, the device that held the bus LOW should release it within 9 clock pulses. During

[PATCH V16 6/6] i2c: tegra: add i2c interface timing support

2019-02-08 Thread Sowjanya Komatineni
This patch adds I2C interface timing registers support for proper bus rate configuration along with meeting the I2C spec setup and hold times based on the tuning performed on Tegra210, Tegra186 and Tegra194 platforms. I2C_INTERFACE_TIMING_0 register contains TLOW and THIGH field and Tegra I2C cont

[PATCH V16 1/6] i2c: tegra: sort all the include headers alphabetically

2019-02-08 Thread Sowjanya Komatineni
This patch sorts all the include headers alphabetically for the I2C Tegra driver. Acked-by: Thierry Reding Reviewed-by: Dmitry Osipenko Signed-off-by: Sowjanya Komatineni --- [V9/V10/V11/V12/V13/V14/V15/V16] : Rebased to 5.0-rc4 [V3/V4/V5/V7/V8] : Removed unsued headers in tegra I2C [V2]

[PATCH V16 3/6] i2c: tegra: fix maximum transfer size

2019-02-08 Thread Sowjanya Komatineni
Tegra194 supports maximum 64K bytes transfer per packet. Tegra186 and prior supports maximum 4K bytes transfer per packet. This includes 12 bytes of packet header. This patch fixes max write length to account for packet header size for transfers. Signed-off-by: Sowjanya Komatineni --- [V16] :

[PATCH V16 5/6] i2c: tegra: update transfer timeout

2019-02-08 Thread Sowjanya Komatineni
Tegra194 allows max of 64K bytes and Tegra186 and prior allows max of 4K bytes of transfer per packet. one sec timeout is not enough for transfers more than 10K bytes at STD bus rate. This patch updates I2C transfer timeout based on the transfer size and I2C bus rate to allow enough time during m

Re: [PATCH 1/2] sched/fair: optimization of update_blocked_averages()

2019-02-08 Thread Vincent Guittot
On Fri, 8 Feb 2019 at 17:31, Peter Zijlstra wrote: > > On Wed, Feb 06, 2019 at 05:14:21PM +0100, Vincent Guittot wrote: > > --- a/kernel/sched/fair.c > > +++ b/kernel/sched/fair.c > > @@ -346,6 +346,18 @@ static inline bool list_add_leaf_cfs_rq(struct cfs_rq > > *cfs_rq) > > static inline void l

Re: [PATCH 1/2] sched/fair: optimization of update_blocked_averages()

2019-02-08 Thread Vincent Guittot
On Fri, 8 Feb 2019 at 17:30, Peter Zijlstra wrote: > > On Fri, Feb 08, 2019 at 04:44:53PM +0100, Vincent Guittot wrote: > > On Fri, 8 Feb 2019 at 16:40, Peter Zijlstra wrote: > > > > > > > > > Argh head hurts!! > > > > > > On Wed, Feb 06, 2019 at 05:14:21PM +0100, Vincent Guittot wrote: > > > > @

Re: [PATCH v3 2/2] tpm/tpm_i2c_atmel: Return -E2BIG when the transfer is incomplete

2019-02-08 Thread Stefan Berger
On 2/8/19 11:30 AM, Jarkko Sakkinen wrote: Return -E2BIG when the transfer is incomplete. The upper layer does not retry, so not doing that is incorrect behaviour. Cc: sta...@vger.kernel.org Fixes: a2871c62e186 ("tpm: Add support for Atmel I2C TPMs") Signed-off-by: Jarkko Sakkinen --- drivers

[git pull] IOMMU Fixes for Linux v5.0-rc5

2019-02-08 Thread Joerg Roedel
Hi Linus, The following changes since commit 9825bd94e3a2baae1f4874767ae3a7d4c049720e: iommu/amd: Fix IOMMU page flush when detach device from a domain (2019-01-24 15:24:49 +0100) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git tags/iom

Re: [PATCH 1/2] sched/fair: optimization of update_blocked_averages()

2019-02-08 Thread Vincent Guittot
On Fri, 8 Feb 2019 at 17:51, Peter Zijlstra wrote: > > On Fri, Feb 08, 2019 at 05:47:53PM +0100, Vincent Guittot wrote: > > On Fri, 8 Feb 2019 at 17:30, Peter Zijlstra wrote: > > > On Fri, Feb 08, 2019 at 04:44:53PM +0100, Vincent Guittot wrote: > > > > On Fri, 8 Feb 2019 at 16:40, Peter Zijlstra

Re: [PATCH 1/2] sched/fair: optimization of update_blocked_averages()

2019-02-08 Thread Peter Zijlstra
On Fri, Feb 08, 2019 at 05:47:53PM +0100, Vincent Guittot wrote: > On Fri, 8 Feb 2019 at 17:30, Peter Zijlstra wrote: > > On Fri, Feb 08, 2019 at 04:44:53PM +0100, Vincent Guittot wrote: > > > On Fri, 8 Feb 2019 at 16:40, Peter Zijlstra wrote: > > > Good point but this should go after the for_ea

Re: [PATCH v3 1/2] tpm: Unify the send callback behaviour

2019-02-08 Thread Stefan Berger
On 2/8/19 11:30 AM, Jarkko Sakkinen wrote: drivers/char/tpm/st33zp24/st33zp24.c | 2 +- tpm_ibmvtpm.c needs an update of the description of the send function.

[RFC PATCH] arm64/fpsimd: Don't disable softirq when touching FPSIMD/SVE state

2019-02-08 Thread Julien Grall
When the kernel is compiled with CONFIG_KERNEL_MODE_NEON, some part of the kernel may be able to use FPSIMD/SVE. This is for instance the case for crypto code. Any use of FPSIMD/SVE in the kernel are clearly marked by using the function kernel_neon_{begin, end}. Furthermore, this can only be used

Re: [PATCH V16 6/6] i2c: tegra: add i2c interface timing support

2019-02-08 Thread Dmitry Osipenko
08.02.2019 19:45, Sowjanya Komatineni пишет: > This patch adds I2C interface timing registers support for > proper bus rate configuration along with meeting the I2C spec > setup and hold times based on the tuning performed on Tegra210, > Tegra186 and Tegra194 platforms. > > I2C_INTERFACE_TIMING_0

Re: [RFC PATCH] leds: multicolor: Add sysfs interface definition

2019-02-08 Thread Dan Murphy
Veas On 2/7/19 11:09 PM, Vesa Jääskeläinen wrote: > Hi All, > > On 08/02/2019 6.55, Vesa Jääskeläinen wrote: >> Hi All, >> >> On 31/01/2019 0.35, Pavel Machek wrote: >>> On Wed 2019-01-30 12:30:05, Dan Murphy wrote: Add a documentation of LED Multicolor LED class specific sysfs attribut

Re: [PATCH V16 4/6] i2c: tegra: Add DMA support

2019-02-08 Thread Dmitry Osipenko
08.02.2019 19:45, Sowjanya Komatineni пишет: > This patch adds DMA support for Tegra I2C. > > Tegra I2C TX and RX FIFO depth is 8 words. PIO mode is used for > transfer size of the max FIFO depth and DMA mode is used for > transfer size higher than max FIFO depth to save CPU overhead. > > PIO mod

Re: [PATCH] fbdev/via: fix spelling mistake "Expandsion" -> "Expansion"

2019-02-08 Thread Bartlomiej Zolnierkiewicz
On 10/13/2018 12:47 AM, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in MODULE_PARM_DESC text > > Signed-off-by: Colin Ian King Patch queued for v5.1, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics

Re: [Breakage] Git v2.21.0-rc0 - t5318 (NonStop)

2019-02-08 Thread Jeff King
On Fri, Feb 08, 2019 at 06:08:33AM -0500, Randall S. Becker wrote: > t5318 is rather problematic and I have no good way to fix this. There > is no /dev/zero on the platform, and the corrupt_graph_and_verify > hard-codes if=/dev/zero, which is a linux-specific pseudo device. > Please provide a more

Re: [PATCH v3 1/5] i2c:ocores: stop transfer on timeout

2019-02-08 Thread Andrew Lunn
On Fri, Feb 08, 2019 at 05:11:57PM +0100, Federico Vaga wrote: > Detecting a timeout is ok, but we also need to assert a STOP command on > the bus in order to prevent it from generating interrupts when there are > no on going transfers. > > Example: very long transmission. > > 1. ocores_xfer: STA

Re: [PATCH] MAINTAINERS: drop Hoan Tran, e-mail is bouncing

2019-02-08 Thread z-Hoan Tran - OS
On 2/8/19 6:34 AM, Linus Walleij wrote: > On Fri, Feb 8, 2019 at 12:54 PM Thomas Petazzoni > wrote: > >> Hoan Tran's e-mail is bouncing: >> >> : host ASPMX.L.GOOGLE.COM[64.233.167.26] said: 550-5.2.1 The >> email account that you tried to reach is disabled. Learn more at 550 >> 5.2.1 >>

[PATCH 1/2] genirq/msi: Clean up usage of __u8/__u16 types

2019-02-08 Thread Logan Gunthorpe
The double underscore types are meant for compatibility in userspace headers which does not apply here. Therefore, change to use the standard no-underscore types. The origin of the double underscore types dates back to before the git era so I was not able to find a commit to see the original justi

Re: [PATCH v3 2/5] i2c:ocores: do not handle IRQ if IF is not set

2019-02-08 Thread Andrew Lunn
On Fri, Feb 08, 2019 at 05:11:58PM +0100, Federico Vaga wrote: > If the Interrupt Flag (IF) is not set, we should not handle the IRQ: > - the line can be shared with other devices > - it can be a spurious interrupt > > To avoid reading twice the status register, the ocores_process() function > exp

[PATCH 2/2] PCI: Clean up usage of __u32 type

2019-02-08 Thread Logan Gunthorpe
The double underscore types are meant for compatibility in userspace headers which does not apply here. Therefore, change to use the standard no-underscore types. The origin of the double underscore types dates back to before the git era so I was not able to find a commit to see the original justi

Re: [PATCH v3 4/5] i2c:ocores: add SPDX tag

2019-02-08 Thread Andrew Lunn
On Fri, Feb 08, 2019 at 05:12:00PM +0100, Federico Vaga wrote: > It adds the SPDX tag and it removes the old text about the GPLv2. > > Signed-off-by: Federico Vaga Reviewed-by: Andrew Lunn Andrew

Re: [patch V2 2/2] proc/stat: Make the interrupt statistics more efficient

2019-02-08 Thread Alexey Dobriyan
On Fri, Feb 08, 2019 at 02:48:04PM +0100, Thomas Gleixner wrote: > - for_each_irq_nr(j) > - seq_put_decimal_ull(p, " ", kstat_irqs_usr(j)); > + show_all_irqs(p); Reviewed-by: Alexey Dobriyan

Re: [PATCH] fbcon: use kvmalloc() for scrollback buffer

2019-02-08 Thread Bartlomiej Zolnierkiewicz
On 12/21/2018 11:58 AM, Konstantin Khorenko wrote: > Hi Bartlomiej, > > On 12/20/2018 07:21 PM, Bartlomiej Zolnierkiewicz wrote: >> On 11/26/2018 11:02 AM, Konstantin Khorenko wrote: >>> Scrollback frame buffer is rather big - 32K, >>> so it requires 3rd order page, so let's use kvmalloc() inste

RE: [PATCH V16 4/6] i2c: tegra: Add DMA support

2019-02-08 Thread Sowjanya Komatineni
> I'm still also suggesting to squash "fix maximum transfer size" into this > patch because it is really part of DMA-support enabling. Max transfer length limits apply to PIO also but for DMA its more needed to prevent crash. So had this as patch before DMA as its applicable for both DMA & PIO.

Re: [patch V2 0/2] genirq, proc: Speedup /proc/stat interrupt statistics

2019-02-08 Thread Davidlohr Bueso
On Fri, 08 Feb 2019, Thomas Gleixner wrote: Waiman reported that on large systems with a large amount of interrupts the readout of /proc/stat takes a long time to sum up the interrupt statistics. In principle this is not a problem. but for unknown reasons some enterprise quality software reads /

Re: [PATCH] Documentation: cgroup-v2: eliminate markup warnings

2019-02-08 Thread Tejun Heo
On Wed, Feb 06, 2019 at 04:59:00PM -0800, Randy Dunlap wrote: > From: Randy Dunlap > > Fix markup warnings in cgroup-v2.rst: > > Documentation/admin-guide/cgroup-v2.rst:1509: WARNING: Block quote ends > without a blank line; unexpected unindent. > Documentation/admin-guide/cgroup-v2.rst:1511: W

Re: [PATCH] fbdev: Use of_node_name_eq for node name comparisons

2019-02-08 Thread Bartlomiej Zolnierkiewicz
On 12/05/2018 08:50 PM, Rob Herring wrote: > Convert string compares of DT node names to use of_node_name_eq helper > instead. This removes direct access to the node name pointer. > > For instances using of_node_cmp, this has the side effect of now using > case sensitive comparisons. This should

[PATCH 1/3] nds32: Removed unused thread flag TIF_USEDFPU

2019-02-08 Thread Julien Grall
The bit TIF_USEDFPU is not used in the nds32 code. Signed-off-by: Julien Grall Cc: Greentime Hu Cc: Vincent Chen --- Untested as I don't have a cross-compiler for it. --- arch/nds32/include/asm/thread_info.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/nds32/include/asm/threa

[PATCH RESEND 0/3] Remove reference of TIF_USEDFPU on arch not using it

2019-02-08 Thread Julien Grall
Hi all, This small patch series remove reference of TIF_USEDFPU on nds32, arm and arm64 as the flag is not inuse. Cheers, Cc: Greentime Hu Cc: Vincent Chen Cc: Russell King Cc: Catalin Marinas Cc: Will Deacon Cc: linux-arm-ker...@lists.infradead.org Julien Grall (3): nds32: Removed unuse

Re: [PATCH v2] mm: proc: smaps_rollup: Fix pss_locked calculation

2019-02-08 Thread Vlastimil Babka
On 2/3/19 7:54 AM, Sandeep Patil wrote: > The 'pss_locked' field of smaps_rollup was being calculated incorrectly. > It accumulated the current pss everytime a locked VMA was found. Fix > that by adding to 'pss_locked' the same time as that of 'pss' if the vma > being walked is locked. > > Fixes:

[PATCH 1/3] nds32: Removed unused thread flag TIF_USEDFPU

2019-02-08 Thread Julien Grall
The bit TIF_USEDFPU is not used in the nds32 code. Signed-off-by: Julien Grall Cc: Greentime Hu Cc: Vincent Chen --- Untested as I don't have a cross-compiler for it. --- arch/nds32/include/asm/thread_info.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/arch/nds32/include/asm/threa

[PATCH 2/3] arm: Remove documentation about TIF_USEDFPU

2019-02-08 Thread Julien Grall
TIF_USEDFPU is not defined as thread flags for Arm. So drop it from the documentation. Signed-off-by: Julien Grall Cc: Russell King Cc: linux-arm-ker...@lists.infradead.org --- arch/arm/include/asm/thread_info.h | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/arm/include/asm/thread_info

Re: [PATCH 0/3] Remove reference of TIF_USEDFPU on arch not using it

2019-02-08 Thread Julien Grall
Hi, Sorry I made an error in the patches sent. Please ignore this series and look for the "RESEND" version. Cheers, On 08/02/2019 17:03, Julien Grall wrote: Hi all, This small patch series remove reference of TIF_USEDFPU on nds32, arm and arm64 as the flag is not inuse. Cheers, Cc: Greent

<    1   2   3   4   5   6   7   8   9   10   >