Re: [PATCH] drm/bridge: lvds-encoder: remove surplus NULL checks

2019-01-22 Thread Laurent Pinchart
Hi Peter, Thank you for the patch. On Fri, Jan 18, 2019 at 11:11:38PM +, Peter Rosin wrote: > The gpio API explicitly allows skipping the NULL check, precisely to > allow for neat support for optional gpios. Which is exactly what is at > play here. > > Reported-by: Andrzej Hajda > Signed-of

Re: [PATCH] genirq/affinity: Assign default affinity to pre/post vectors

2019-01-22 Thread Thomas Gleixner
Chen, On Fri, 18 Jan 2019, Huacai Chen wrote: > > > I did not say that you removed all NULL returns. I said that this function > > > can return NULL for other reasons and then the same situation will happen. > > > > > > If the masks pointer returned is NULL then the calling code or any > > > subse

Re: [RFC PATCH] drm: disable WC optimization for cache coherent devices on non-x86

2019-01-22 Thread Ard Biesheuvel
On Tue, 22 Jan 2019 at 21:56, Alex Deucher wrote: > > On Tue, Jan 22, 2019 at 4:19 AM Ard Biesheuvel > wrote: > > > > On Mon, 21 Jan 2019 at 20:04, Michel Dänzer wrote: > > > > > > On 2019-01-21 7:28 p.m., Ard Biesheuvel wrote: > > > > On Mon, 21 Jan 2019 at 19:24, Michel Dänzer wrote: > > > >>

Re: [PATCH v3] platform/chrome: Add cros_ec_readmem() helpers for I2C/SPI based ECs

2019-01-22 Thread Moritz Fischer
Hi Enrico, On Mon, Jan 21, 2019 at 11:19:34PM +0100, Enric Balletbo Serra wrote: > I tried with a Samsung Chromebook Plus (arm64 Chromebook) > > > What was the ioctl you ran? > > > > The code that I ran is this: https://hastebin.com/cupecuvowi.py > No guarantee :) I'll try to look deeper tomorro

Re: [PATCH] drm/bridge: sil_sii8620: depend on INPUT instead of selecting it.

2019-01-22 Thread Laurent Pinchart
Hi Ronald, Thank you for the patch. On Tue, Jan 22, 2019 at 06:13:11AM -0800, Ronald Tschalär wrote: > commit d6abe6df706c66d803e6dd4fe98c1b6b7f125a56 (drm/bridge: Commits are usually quoted using the short 12 digits version of their SHA-1. > sil_sii8620: do not have a dependency of RC_CORE) ad

Re: [PATCH v6 00/15] qcom: spmi: add support for hierarchical IRQ chip

2019-01-22 Thread Andy Gross
On Tue, Jan 22, 2019 at 04:31:20PM +0100, Linus Walleij wrote: > On Sat, Jan 19, 2019 at 9:43 PM Brian Masney wrote: > > > This patch series adds hierarchical IRQ chip support to spmi-gpio so > > that device tree consumers can request an IRQ directly from the GPIO > > block rather than having to

Re: WARN_ON_ONCE(!new_owner) within wake_futex_pi() triggered

2019-01-22 Thread Thomas Gleixner
On Mon, 21 Jan 2019, Thomas Gleixner wrote: > On Mon, 21 Jan 2019, Heiko Carstens wrote: > > > Hi Thomas, > > > > [full quote below] > > > > Did you have any time to look into this yet? :) > > > > The warning is still reproducible. > > Yeah, it's on my list of stuff which I need to take care o

Re: [PATCH v3 2/3] usb: dwc3: qcom: Add support for MSM8998

2019-01-22 Thread Andy Gross
On Mon, Jan 21, 2019 at 02:33:08PM -0700, Jeffrey Hugo wrote: > Add a MSM8998 specific DT compatible so that we can properly bind to the > device and enable the USB controller. > > Signed-off-by: Jeffrey Hugo > Reviewed-by: Bjorn Andersson > --- > drivers/usb/dwc3/dwc3-qcom.c | 1 + > 1 file ch

Re: [PATCH v3 1/1] MAINTAINERS: update list of qcom drivers

2019-01-22 Thread Andy Gross
On Mon, Jan 21, 2019 at 01:58:41PM +0530, Amit Kucheria wrote: > On Tue, Jan 15, 2019 at 1:16 AM Amit Kucheria > wrote: > > > > Several drivers didn't have a specific maintainer (other than the > > subsystem maintainer). Add some generic regex patterns to capture most > > qcom drivers in the list

[PATCH v2 0/2] pinctrl: remove unused 'pinconf-config' debugfs interface

2019-01-22 Thread Vladimir Zapolskiy
The main goal of the change is to remove .pin_config_dbg_parse_modify callback before a driver with its support appears. So far the in-kernel interface did not attract any users since its introduction 5 years ago. Originally .pin_config_dbg_parse_modify callback and the associated 'pinconf-config'

[PATCH v2 1/2] pinctrl: remove pinctrl/machine.h inclusion from pinctrl/pinconf.h

2019-01-22 Thread Vladimir Zapolskiy
The change adds explicit inclusion of linux/pinctrl/machine.h header to the only needed pinctrl-madera-core.c file, and therefore inclusion of pinctrl/machine.h header from pinctrl/pinconf.h can be removed. The change is preparatory to a follow-up reversal of commit f07512e615dd ("pinctrl/pinconfi

[PATCH v2 2/2] pinctrl: remove unused 'pinconf-config' debugfs interface

2019-01-22 Thread Vladimir Zapolskiy
The main goal of the change is to remove .pin_config_dbg_parse_modify callback before a driver with its support appears. So far the in-kernel interface did not attract any users since its introduction 5 years ago. Originally .pin_config_dbg_parse_modify callback and the associated 'pinconf-config'

[PATCH 1/2] dma-direct: set_memory_{en,de}crypted() take number of pages

2019-01-22 Thread Thiago Jung Bauermann
From: Ram Pai set_memory_encrypted() and set_memory_decrypted() expect the number of PAGE_SIZE pages to encrypt or decrypt. dma_direct_alloc() and dma_direct_free() instead pass number of bytes. This encrypts/decrypts a huge number of pages resulting in data corruption. Fixed it. [ bauermann: S

[PATCH 2/2] x86/kvmclock: set_memory_decrypted() takes number of pages

2019-01-22 Thread Thiago Jung Bauermann
From: Ram Pai set_memory_decrypted() expects the number of PAGE_SIZE pages to decrypt. kvmclock_init_mem() instead passes number of bytes. This decrypts a huge number of pages resulting in data corruption. Fixed it. [ bauermann: Slightly reworded commit message and added Fixes: tag. ] Fixes: 6a

Re: [PATCH 2/4] arm: dump: no need to check return value of debugfs_create functions

2019-01-22 Thread Kees Cook
On Wed, Jan 23, 2019 at 3:41 AM Greg Kroah-Hartman wrote: > > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > > Cc: Russell King > Cc: Jinbum Park > Cc: Kee

Re: [PATCH v3 1/3] drm/msm/a6xx: Add support for an interconnect path

2019-01-22 Thread Doug Anderson
Hi, On Mon, Jan 21, 2019 at 9:13 AM Georgi Djakov wrote: > > Hi Rob, > > On 1/18/19 21:16, Rob Clark wrote: > > On Fri, Jan 18, 2019 at 1:06 PM Doug Anderson wrote: > >> > >> Hi, > >> > >> On Thu, Dec 20, 2018 at 9:30 AM Jordan Crouse > >> wrote: > >>> > >>> Try to get the interconnect path fo

[PATCH] usb: gadget: udc: net2272: Fix bitwise and boolean operations

2019-01-22 Thread Gustavo A. R. Silva
(!x & y) strikes again. Fix bitwise and boolean operations by enclosing the expression: intcsr & (1 << NET2272_PCI_IRQ) in parentheses, before applying the boolean operator '!'. Notice that this code has been there since 2011. So, it would be helpful if someone can double-check this. T

[PATCH v2] iommu/vt-d: Implement dma_[un]map_resource()

2019-01-22 Thread Logan Gunthorpe
Currently the Intel IOMMU uses the default dma_[un]map_resource() implementations does nothing and simply returns the physical address unmodified. However, this doesn't create the IOVA entries necessary for addresses mapped this way to work when the IOMMU is enabled. Thus, when the IOMMU is enable

Re: [PATCH v5 2/5] Bluetooth: hci_qca: Deassert RTS while baudrate change command

2019-01-22 Thread Matthias Kaehlcke
On Mon, Jan 21, 2019 at 09:56:13AM +0100, Johan Hovold wrote: > On Fri, Jan 18, 2019 at 04:31:09PM -0800, Matthias Kaehlcke wrote: > > On Fri, Jan 18, 2019 at 10:44:16AM +0100, Johan Hovold wrote: > > > On Thu, Jan 17, 2019 at 09:21:09AM -0800, Matthias Kaehlcke wrote: > > > > > > > I observed tha

Re: [PATCH v2 2/2] leds: lp50xx: Add the LP50XX family of the RGB LED driver

2019-01-22 Thread Jacek Anaszewski
Hi all, On 1/20/19 7:42 AM, Vesa Jääskeläinen wrote: Hi Dan, On 18/01/2019 15.58, Dan Murphy wrote: Jacek On 1/18/19 7:45 AM, Dan Murphy wrote: Jacek On 1/17/19 3:10 PM, Jacek Anaszewski wrote: Hi Dan, On 1/16/19 7:41 PM, Dan Murphy wrote: Hello On 1/16/19 4:55 AM, Pavel Machek wrote:

Re: [PATCH 1/2] dma-direct: set_memory_{en,de}crypted() take number of pages

2019-01-22 Thread Lendacky, Thomas
On 1/22/19 3:17 PM, Thiago Jung Bauermann wrote: > From: Ram Pai > > set_memory_encrypted() and set_memory_decrypted() expect the number of > PAGE_SIZE pages to encrypt or decrypt. dma_direct_alloc() and > dma_direct_free() instead pass number of bytes. This encrypts/decrypts a > huge number of p

Re: [PATCH 2/2] x86/kvmclock: set_memory_decrypted() takes number of pages

2019-01-22 Thread Lendacky, Thomas
On 1/22/19 3:17 PM, Thiago Jung Bauermann wrote: > From: Ram Pai > > set_memory_decrypted() expects the number of PAGE_SIZE pages to decrypt. > kvmclock_init_mem() instead passes number of bytes. This decrypts a huge > number of pages resulting in data corruption. Same comment as patch 1/2 in th

Re: [LSF/MM TOPIC] Page flags, can we free up space ?

2019-01-22 Thread Andi Kleen
Jerome Glisse writes: > > Right now this is more a temptative ie i do not know if i will succeed, > in any case i can report on failure or success and discuss my finding to > get people opinions on the matter. I would just stop putting node/zone number into the flags. These could be all handled w

[tip:x86/urgent] x86/Kconfig: Select PCI_LOCKLESS_CONFIG if PCI is enabled

2019-01-22 Thread tip-bot for Sinan Kaya
Commit-ID: 625210cfa6c0c26ea422f655bf68288176f174e6 Gitweb: https://git.kernel.org/tip/625210cfa6c0c26ea422f655bf68288176f174e6 Author: Sinan Kaya AuthorDate: Mon, 21 Jan 2019 23:19:58 + Committer: Borislav Petkov CommitDate: Tue, 22 Jan 2019 17:06:28 +0100 x86/Kconfig: Select PCI_

Re: [PATCH v7 1/6] fieldbus_dev: add Fieldbus Device subsystem.

2019-01-22 Thread Paul Gortmaker
[Re: [PATCH v7 1/6] fieldbus_dev: add Fieldbus Device subsystem.] On 22/01/2019 (Tue 19:52) Greg KH wrote: > On Tue, Jan 22, 2019 at 06:12:31PM +0100, Andreas Färber wrote: > > Am 22.01.19 um 17:56 schrieb Paul Gortmaker: > > > [[PATCH v7 1/6] fieldbus_dev: add Fieldbus Device subsystem.] On > >

Re: [PATCH resend] drm/panel: panel-innolux: set display off in innolux_panel_unprepare

2019-01-22 Thread Sean Paul
On Fri, Jan 18, 2019 at 12:58:10PM -0500, Sean Paul wrote: > On Wed, Jan 9, 2019 at 1:59 AM Hsin-Yi, Wang wrote: > > > > Move mipi_dsi_dcs_set_display_off() from innolux_panel_disable() > > to innolux_panel_unprepare(), so they are consistent with > > innolux_panel_enable() and innolux_panel_prepa

Re: [PATCH v5 2/5] Bluetooth: hci_qca: Deassert RTS while baudrate change command

2019-01-22 Thread Matthias Kaehlcke
On Mon, Jan 21, 2019 at 08:11:39PM +0530, Balakrishna Godavarthi wrote: > Hi Matthias, > > On 2019-01-19 06:01, Matthias Kaehlcke wrote: > > On Fri, Jan 18, 2019 at 10:44:16AM +0100, Johan Hovold wrote: > > > On Thu, Jan 17, 2019 at 09:21:09AM -0800, Matthias Kaehlcke wrote: > > > > > > > I obser

Re: [PATCH 2/4] preemptirq_delay_test: Add the burst feature and a sysfs trigger

2019-01-22 Thread Joel Fernandes
Hi Viktor, Could you CC me on the other patches as well, next time? I am quite interested and recently have worked on the latency tracer. Some comments below: On Mon, Jan 21, 2019 at 02:35:11PM +0200, Viktor Rosendahl wrote: > This burst feature enables the user to generate a burst of > preempt/

Re: [PATCH 1/6] x86: mce: no need to check return value of debugfs_create functions

2019-01-22 Thread Borislav Petkov
On Tue, Jan 22, 2019 at 03:35:37PM +0100, Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > > Cc: Thomas Gleixner > Cc: Ingo Molnar

Re: [PATCH] regulator: qcom-smd: Batch up requests for disabled regulators

2019-01-22 Thread Jeffrey Hugo
On 1/22/2019 12:01 PM, Bjorn Andersson wrote: In some scenarios the early stages of the boot chain has configured regulators to be in a required state, but the later stages has skipped to inform the RPM about it's requirements. But as the SMD RPM regulators are being initialized voltage change r

Re: [PATCH v9 00/22] Re-use nvram module

2019-01-22 Thread Finn Thain
On Tue, 22 Jan 2019, Greg Kroah-Hartman wrote: > On Tue, Jan 15, 2019 at 03:18:56PM +1100, Finn Thain wrote: > > The "generic" NVRAM module, drivers/char/generic_nvram.c, implements a > > /dev/nvram misc device. This module is used only by 32-bit PowerPC > > platforms. > > > > The RTC "CMOS" NVRA

Re: [PATCH 6/7] crypto: ccp: no need to check return value of debugfs_create functions

2019-01-22 Thread Gary R Hook
On 1/22/19 9:14 AM, Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. Stupid question(s) time. If we don't care about failures (becau

[PATCH ghak104 V1] audit: move loginuid and sessionid from CONFIG_ AUDITSYSCALL to AUDIT

2019-01-22 Thread Richard Guy Briggs
loginuid and sessionid (and audit_log_session_info) should be part of CONFIG_AUDIT scope and not CONFIG_AUDITSYSCALL since it is used in CONFIG_CHANGE, ANOM_LINK, FEATURE_CHANGE (and INTEGRITY_RULE), none of which are otherwise dependent on AUDITSYSCALL. Please see github issue https://github.com/

[PATCH ghak105 V1 1/2] audit: clean up AUDITSYSCALL prototypes and stubs

2019-01-22 Thread Richard Guy Briggs
Pull together all the audit syscall watch, mark and tree prototypes and stubs into the same ifdef. Signed-off-by: Richard Guy Briggs --- kernel/audit.h | 64 ++ 1 file changed, 33 insertions(+), 31 deletions(-) diff --git a/kernel/audit.h

[PATCH ghak105 V1 2/2] audit: remove audit_context when CONFIG_ AUDIT and not AUDITSYSCALL

2019-01-22 Thread Richard Guy Briggs
Remove audit_context from struct task_struct and struct audit_buffer when CONFIG_AUDIT is enabled but CONFIG_AUDITSYSCALL is not. Also, audit_log_name() (and supporting inode and fcaps functions) should have been put back in auditsc.c when soft and hard link logging was normalized since it is only

[PATCH ghak105 V1 0/2] audit: clean up CONFIG_AUDITSYSCALL

2019-01-22 Thread Richard Guy Briggs
Compiles and boots with config AUDITSYSCALL def_bool n in init/Kconfig. Verified syscall code is not present in resulting kernel. Richard Guy Briggs (2): audit: clean up AUDITSYSCALL prototypes and stubs audit: remove audit_context when CONFIG_ AUDIT and not AUDITSYSCALL include/linux/sched.

Re: [PATCH 0/3] gnss: sirf: fixes and cleanup

2019-01-22 Thread Andreas Kemnade
Hi Johan, On Tue, 22 Jan 2019 18:22:52 +0100 Johan Hovold wrote: > These patches fixes an issue where the sirf wakeup interrupt was > prematurely enabled during probe. As Andreas suggested, we should also > make sure that the receiver is indeed suspended at probe (to avoid > wasting power until

RE: [PATCH V3] i2c: tegra: Add Bus Clear Master Support

2019-01-22 Thread Sowjanya Komatineni
>> Bus clear feature of tegra i2c controller helps to recover from bus >> hang when i2c master loses the bus arbitration due to the slave device >> holding SDA LOW continuously for some unknown reasons. >> >> Per I2C specification, the device that held the bus LOW should release >> it within

Re: [PATCH] sched/wait: introduce wait_event_freezable_hrtimeout

2019-01-22 Thread Joel Fernandes
On Sat, Jan 19, 2019 at 11:29:12AM +0100, Hugo Lefeuvre wrote: > > > as far as I understand this code, freezable_schedule() avoids blocking the > > > freezer during the schedule() call, but in the end try_to_freeze() is > > > still > > > called so the result is the same, right? > > > I wonder why

Re: [PATCH 4.20 000/111] 4.20.4-stable review

2019-01-22 Thread shuah
On 1/21/19 6:41 AM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.20.4 release. There are 111 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made

Re: [PATCH 4.19 00/99] 4.19.17-stable review

2019-01-22 Thread shuah
On 1/21/19 6:47 AM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.19.17 release. There are 99 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made

Re: [PATCH v4 1/5] usb: split code locating ACPI companion into port and device

2019-01-22 Thread Rajat Jain
Hi Marcel, On Sat, Jan 19, 2019 at 11:51 AM Marcel Holtmann wrote: > > Hi Rajat, > > > In preparation for handling embedded USB devices let's split > > usb_acpi_find_companion() into usb_acpi_find_companion_for_device() and > > usb_acpi_find_companion_for_port(). > > > > Signed-off-by: Dmitry Tor

Re: [PATCH v4 2/5] usb: assign ACPI companions for embedded USB devices

2019-01-22 Thread Rajat Jain
On Sat, Jan 19, 2019 at 11:51 AM Marcel Holtmann wrote: > > Hi Rajat, > > > USB devices permanently connected to USB ports may be described in ACPI > > tables and share ACPI devices with ports they are connected to. See [1] > > for details. > > > > This will allow us to describe sideband resources

[PATCH v3] tty: moxa: Fix coding style issues

2019-01-22 Thread Antoine Robertson
Fix coding style issues Signed-off-by: Antoine Robertson --- [V3]: Added what changed from v1 and v2 below the --- [V2]: Changed moxa_brdname[] to const and fixed brackets on an else statement drivers/tty/moxa.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) dif

Re: [PATCH 4.14 00/59] 4.14.95-stable review

2019-01-22 Thread shuah
On 1/21/19 6:43 AM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.14.95 release. There are 59 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made

[PATCH v3 00/16] block: sed-opal: support shadow MBR done flag and write

2019-01-22 Thread David Kozub
This patch series extends OPAL support: it adds IOCTL for setting the shadow MBR done flag which can be useful for unlocking an OPAL disk on boot and it adds IOCTL for writing to the shadow MBR. Also included are some minor fixes and improvements. This series is based on the original work done by

[PATCH v3 11/16] block: sed-opal: ioctl for writing to shadow mbr

2019-01-22 Thread David Kozub
From: Jonas Rabenstein Allow modification of the shadow mbr. If the shadow mbr is not marked as done, this data will be presented read only as the device content. Only after marking the shadow mbr as done and unlocking a locking range the actual content is accessible. Co-authored-by: David Kozub

[PATCH v3 13/16] block: sed-opal: check size of shadow mbr

2019-01-22 Thread David Kozub
From: Jonas Rabenstein Check whether the shadow mbr does fit in the provided space on the target. Also a proper firmware should handle this case and return an error we may prevent problems or even damage with crappy firmwares. Signed-off-by: Jonas Rabenstein --- block/opal_proto.h | 16 +++

[PATCH v3 03/16] block: sed-opal: unify space check in add_token_*

2019-01-22 Thread David Kozub
From: Jonas Rabenstein All add_token_* functions have a common set of conditions that have to be checked. Use a common function for those checks in order to avoid different behaviour as well as code duplication. Co-authored-by: David Kozub Signed-off-by: Jonas Rabenstein Signed-off-by: David K

[PATCH v3 01/16] block: sed-opal: fix typos and formatting

2019-01-22 Thread David Kozub
This should make no change in functionality. The formatting changes were triggered by checkpatch.pl. Signed-off-by: David Kozub --- block/sed-opal.c | 19 +++ 1 file changed, 11 insertions(+), 8 deletions(-) diff --git a/block/sed-opal.c b/block/sed-opal.c index e0de4dd448b3..c8

[PATCH v3 09/16] block: sed-opal: split generation of bytestring header and content

2019-01-22 Thread David Kozub
From: Jonas Rabenstein Split the header generation from the (normal) memcpy part if a bytestring is copied into the command buffer. This allows in-place generation of the bytestring content. For example, copy_from_user may be used without an intermediate buffer. Signed-off-by: Jonas Rabenstein

[PATCH v3 06/16] block: sed-opal: unify error handling of responses

2019-01-22 Thread David Kozub
response_get_{string,u64} include error handling for argument resp being NULL but response_get_token does not handle this. Make all three of response_get_{string,u64,token} handle NULL resp in the same way. Co-authored-by: Jonas Rabenstein Signed-off-by: David Kozub Signed-off-by: Jonas Rabenst

[PATCH v3 02/16] block: sed-opal: use correct macro for method length

2019-01-22 Thread David Kozub
From: Jonas Rabenstein Also the values of OPAL_UID_LENGTH and OPAL_METHOD_LENGTH are the same, it is weird to use OPAL_UID_LENGTH for the definition of the methods. Signed-off-by: Jonas Rabenstein --- block/sed-opal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/se

[PATCH v3 14/16] block: sed-opal: pass steps via argument rather than via opal_dev

2019-01-22 Thread David Kozub
The steps argument is only read by the next function, so it can be passed directly as an argument rather than via opal_dev. Normally, the steps is an array on the stack, so the pointer stops being valid then the function that set opal_dev.steps returns. If opal_dev.steps was not set to NULL before

[PATCH v3 08/16] block: sed-opal: print failed function address

2019-01-22 Thread David Kozub
From: Jonas Rabenstein Add function address (and if available its symbol) to the message if a step function fails. Signed-off-by: Jonas Rabenstein --- block/sed-opal.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/sed-opal.c b/block/sed-opal.c index 1332547e5a99

[PATCH v3 10/16] block: sed-opal: add ioctl for done-mark of shadow mbr

2019-01-22 Thread David Kozub
From: Jonas Rabenstein Enable users to mark the shadow mbr as done without completely deactivating the shadow mbr feature. This may be useful on reboots, when the power to the disk is not disconnected in between and the shadow mbr stores the required boot files. Of course, this saves also the (fe

[PATCH v3 04/16] block: sed-opal: close parameter list in cmd_finalize

2019-01-22 Thread David Kozub
Every step ends by calling cmd_finalize (via finalize_and_send) yet every step adds the token OPAL_ENDLIST on its own. Moving this into cmd_finalize decreases code duplication. Co-authored-by: Jonas Rabenstein Signed-off-by: David Kozub Signed-off-by: Jonas Rabenstein --- block/sed-opal.c | 25

[PATCH v3 07/16] block: sed-opal: reuse response_get_token to decrease code duplication

2019-01-22 Thread David Kozub
response_get_token had already been in place, its functionality had been duplicated within response_get_{u64,bytestring} with the same error handling. Unify the handling by reusing response_get_token within the other functions. Co-authored-by: Jonas Rabenstein Signed-off-by: David Kozub Signed-o

[PATCH v3 15/16] block: sed-opal: don't repeat opal_discovery0 in each steps array

2019-01-22 Thread David Kozub
Originally each of the opal functions that call next include opal_discovery0 in the array of steps. This is superfluous and can be done always inside next. Signed-off-by: David Kozub --- block/sed-opal.c | 89 +++- 1 file changed, 43 insertions(+), 46

[PATCH v3 12/16] block: sed-opal: unify retrieval of table columns

2019-01-22 Thread David Kozub
From: Jonas Rabenstein Instead of having multiple places defining the same argument list to get a specific column of a sed-opal table, provide a generic version and call it from those functions. Signed-off-by: Jonas Rabenstein --- block/opal_proto.h | 2 + block/sed-opal.c | 132 ++

[PATCH v3 05/16] block: sed-opal: unify cmd start

2019-01-22 Thread David Kozub
Every step starts with resetting the cmd buffer as well as the comid and constructs the appropriate OPAL_CALL command. Consequently, those actions may be combined into one generic function. On should take care that the opening and closing tokens for the argument list are already emitted by cmd_star

Re: [PATCH v4 4/5] Bluetooth: btusb: Collect the common Intel assignments together

2019-01-22 Thread Rajat Jain
On Sat, Jan 19, 2019 at 11:51 AM Marcel Holtmann wrote: > > Hi Rajat, > > > The BTUSB_INTEL and BTUSB_INTEL_NEW have common functions & quirks are > > assigned to hdev structure. Lets collect them together instead of > > repeating them in different code branches. > > > > Signed-off-by: Rajat Jain

Re: [PATCH v4 3/5] Bluetooth: Reset Bluetooth chip after multiple command timeouts

2019-01-22 Thread Rajat Jain
On Sat, Jan 19, 2019 at 11:51 AM Marcel Holtmann wrote: > > Hi Rajat, > > > Add a quirk and a hook to allow the HCI core to reset the BT chip > > if needed (after a number of timed out commands). Use that new hook to > > initiate BT chip reset if the controller fails to respond to certain > > numb

Re: [PATCH v4 5/5] Bluetooth: btusb: Use the hw_reset method to allow resetting the BT chip

2019-01-22 Thread Rajat Jain
On Sat, Jan 19, 2019 at 11:51 AM Marcel Holtmann wrote: > > Hi Rajat, > > > If the platform provides it, use the reset gpio to reset the BT > > chip (requested by the HCI core if needed). This has been found helpful > > on some of Intel bluetooth controllers where the firmware gets stuck and > > t

[GIT PULL] clk fixes for v5.0-rc3

2019-01-22 Thread Stephen Boyd
The following changes since commit bfeffd155283772bbe78c6a05dec7c0128ee500c: Linux 5.0-rc1 (2019-01-06 17:08:20 -0800) are available in the Git repository at: https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git tags/clk-fixes-for-linus for you to fetch changes up to b488517b28a47

Re: [PATCH 4/4] staging: android: ion: Support for mapping with dma mapping attributes

2019-01-22 Thread Liam Mark
On Mon, 21 Jan 2019, Brian Starkey wrote: > Hi Liam, > > On Fri, Jan 18, 2019 at 10:37:47AM -0800, Liam Mark wrote: > > Add support for configuring dma mapping attributes when mapping > > and unmapping memory through dma_buf_map_attachment and > > dma_buf_unmap_attachment. > > > > For example th

Re: [PATCH 1/2] dma-direct: set_memory_{en,de}crypted() take number of pages

2019-01-22 Thread Thiago Jung Bauermann
Lendacky, Thomas writes: > On 1/22/19 3:17 PM, Thiago Jung Bauermann wrote: >> diff --git a/kernel/dma/direct.c b/kernel/dma/direct.c >> index 355d16acee6d..bc78c37220ba 100644 >> --- a/kernel/dma/direct.c >> +++ b/kernel/dma/direct.c >> @@ -166,7 +166,7 @@ void *dma_direct_alloc_pages(struct d

Re: [PATCH] tty: serial: lpc32xx_hs: fix missing console boot messages

2019-01-22 Thread Vladimir Zapolskiy
Hi Alexandre, On 01/15/2019 07:18 PM, Alexandre Belloni wrote: > When probing the HSUART, it is put in loopback mode in order to prevent a > potential issue that may happen on RX (Errata HSUART.1). > > serial_lpc32xx_startup() moves it out of loopback mode but this is too late > to get the kernel

Re: [PATCH 4.9 00/51] 4.9.152-stable review

2019-01-22 Thread shuah
On 1/21/19 6:43 AM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.9.152 release. There are 51 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made

[PATCH] arm64: dts: rockchip: enable usb-host regulators during boot

2019-01-22 Thread Dmitry Voytik
After commit ef05bcb60, boot from USB drives is broken. Fix this problem by enabling usb-host regulators during boot time. Signed-off-by: Dmitry Voytik --- arch/arm64/boot/dts/rockchip/rk3328-rock64.dts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3328-roc

Re: [PATCH V3] i2c: tegra: Add Bus Clear Master Support

2019-01-22 Thread Dmitry Osipenko
В Tue, 22 Jan 2019 22:13:53 + Sowjanya Komatineni пишет: > >> Bus clear feature of tegra i2c controller helps to recover from > >> bus hang when i2c master loses the bus arbitration due to the > >> slave device holding SDA LOW continuously for some unknown reasons. > >> > >> Per I2C specific

Re: [PATCH v1 5/8] scsi: ufs: qcom: Expose the reset controller for PHY

2019-01-22 Thread Evan Green
On Fri, Jan 18, 2019 at 2:31 PM Stephen Boyd wrote: > > Quoting Evan Green (2019-01-11 15:01:26) > > diff --git a/drivers/scsi/ufs/ufs-qcom.c b/drivers/scsi/ufs/ufs-qcom.c > > index 3aeadb14aae1e..db46f9a64b54c 100644 > > --- a/drivers/scsi/ufs/ufs-qcom.c > > +++ b/drivers/scsi/ufs/ufs-qcom.c > >

Re: [PATCH v4 1/5] usb: split code locating ACPI companion into port and device

2019-01-22 Thread Dmitry Torokhov
On Tue, Jan 22, 2019 at 2:29 PM Rajat Jain wrote: > > Hi Marcel, > > On Sat, Jan 19, 2019 at 11:51 AM Marcel Holtmann wrote: > > > > Hi Rajat, > > > > > In preparation for handling embedded USB devices let's split > > > usb_acpi_find_companion() into usb_acpi_find_companion_for_device() and > > >

Re: [PATCH v1 6/8] phy: qcom-qmp: Utilize UFS reset controller

2019-01-22 Thread Evan Green
On Fri, Jan 18, 2019 at 2:33 PM Stephen Boyd wrote: > > Quoting Evan Green (2019-01-11 15:01:27) > > @@ -1214,6 +1225,32 @@ static int qcom_qmp_phy_init(struct phy *phy) > > > > dev_vdbg(qmp->dev, "Initializing QMP phy\n"); > > > > + if (cfg->has_ufsphy_reset) { > > + /

Re: [PATCH v1 7/8] phy: qcom-qmp: Move UFS phy to phy_poweron/off

2019-01-22 Thread Evan Green
On Fri, Jan 18, 2019 at 2:39 PM Stephen Boyd wrote: > > Quoting Evan Green (2019-01-11 15:01:28) > > For UFS, move the actual firing up of the PHY to phy_poweron and > > phy_poweroff callbacks, rather than init/exit. UFS calls > > phy_poweroff during suspend, so now all clocks and regulators for >

Re: [PATCH v2 2/2] leds: lp50xx: Add the LP50XX family of the RGB LED driver

2019-01-22 Thread Dan Murphy
Jacek On 1/22/19 3:39 PM, Jacek Anaszewski wrote: > Hi all, > > On 1/20/19 7:42 AM, Vesa Jääskeläinen wrote: >> Hi Dan, >> >> On 18/01/2019 15.58, Dan Murphy wrote: >>> Jacek >>> >>> On 1/18/19 7:45 AM, Dan Murphy wrote: Jacek On 1/17/19 3:10 PM, Jacek Anaszewski wrote: > Hi Da

Re: [PATCH v1 8/8] phy: qcom-ufs: Refactor all init steps into phy_poweron

2019-01-22 Thread Evan Green
On Fri, Jan 18, 2019 at 3:50 PM Stephen Boyd wrote: > > Quoting Evan Green (2019-01-11 15:01:29) > > diff --git a/drivers/phy/qualcomm/phy-qcom-ufs.c > > b/drivers/phy/qualcomm/phy-qcom-ufs.c > > index f2979ccad00a3..a4cff17fef925 100644 > > --- a/drivers/phy/qualcomm/phy-qcom-ufs.c > > +++ b/dri

Re: [PATCH 3/4] dma-buf: add support for mapping with dma mapping attributes

2019-01-22 Thread Liam Mark
On Tue, 22 Jan 2019, Andrew F. Davis wrote: > On 1/21/19 4:18 PM, Liam Mark wrote: > > On Mon, 21 Jan 2019, Andrew F. Davis wrote: > > > >> On 1/21/19 2:20 PM, Liam Mark wrote: > >>> On Mon, 21 Jan 2019, Andrew F. Davis wrote: > >>> > On 1/21/19 1:44 PM, Liam Mark wrote: > > On Mon, 21 J

Re: [PATCH 3/4] dma-buf: add support for mapping with dma mapping attributes

2019-01-22 Thread Liam Mark
On Tue, 22 Jan 2019, Andrew F. Davis wrote: > On 1/21/19 4:12 PM, Liam Mark wrote: > > On Mon, 21 Jan 2019, Christoph Hellwig wrote: > > > >> On Mon, Jan 21, 2019 at 11:44:10AM -0800, Liam Mark wrote: > >>> The main use case is for allowing clients to pass in > >>> DMA_ATTR_SKIP_CPU_SYNC in orde

Re: [PATCH v6 0/3] iommu/io-pgtable-arm-v7s: Use DMA32 zone for page tables

2019-01-22 Thread Nicolas Boichat
Hi Andrew, On Fri, Jan 11, 2019 at 6:21 PM Joerg Roedel wrote: > > On Wed, Jan 02, 2019 at 01:51:45PM +0800, Nicolas Boichat wrote: > > Does anyone have any further comment on this series? If not, which > > maintainer is going to pick this up? I assume Andrew Morton? > > Probably, yes. I don't li

Re: [PATCH v2 1/2] i2c: imx: fix dma_request_chan error handling

2019-01-22 Thread Wolfram Sang
On Wed, Jan 16, 2019 at 01:28:54PM +0200, Laurentiu Tudor wrote: > Use the correct error pointer when extracting the error code. > > Fixes: ea1e5f176e97 ("i2c: imx: notify about real errors on dma > i2c_imx_dma_request") This is not the sha1 in my tree. Maybe you rebased? I applied another patch

Re: [PATCH-next] reset: brcmstb: make it explicitly non-modular

2019-01-22 Thread Florian Fainelli
On 1/22/19 11:02 AM, Paul Gortmaker wrote: > The Kconfig currently controlling compilation of this code is: > > drivers/reset/Kconfig: bool "Broadcom STB reset controller" if COMPILE_TEST > drivers/reset/Kconfig: default ARCH_BRCMSTB > > ...meaning that it currently is not being built as a modu

Re: [PATCH net-next] hinic: Add pci device ids

2019-01-22 Thread David Miller
From: Xue Chaojing Date: Sun, 20 Jan 2019 22:15:46 + > This patch adds PCI device IDs to support following cards: > > 1. Add device id 0x0205 for HINIC 100GE dual port mezz card. > 2. Add device id 0x0210 for HINIC 25GE quad port mezz card. > 3. Delete device id 0x0201 for HINIC 100GE dual p

Re: [PATCH 13/14] staging: android: ion: Do not sync CPU cache on map/unmap

2019-01-22 Thread Liam Mark
On Mon, 21 Jan 2019, Brian Starkey wrote: > Hi, > > Sorry for being a bit sporadic on this. I was out travelling last week > with little time for email. > > On Fri, Jan 18, 2019 at 11:16:31AM -0600, Andrew F. Davis wrote: > > On 1/17/19 7:11 PM, Liam Mark wrote: > > > On Thu, 17 Jan 2019, Andrew

Re: [PATCH] ARM: dts: n900: fix mmc1 card detect gpio polarity

2019-01-22 Thread Tony Lindgren
* Arthur D. [190122 04:59]: > Signed-off-by: Arthur Demchenkov Thanks applying into omap-for-v5.0/fixes. Tony

Re: [PATCH v1 2/2] ARM: dts: am335x-shc.dts: fix wrong cd pin level

2019-01-22 Thread Tony Lindgren
* Heiko Schocher [190121 21:27]: > cd pin on mmc1 is GPIO_ACTIVE_LOW not GPIO_ACTIVE_HIGH Thanks applying into omap-for-v5.0/fixes. Tony

[PATCH] [PATCH] btrfs: remove unused wariable 'num_pages'

2019-01-22 Thread Matthew Friday
Signed-off-by: Matthew Friday --- fs/btrfs/ioctl.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/fs/btrfs/ioctl.c b/fs/btrfs/ioctl.c index 9c8e1734429c..6243f734c0cd 100644 --- a/fs/btrfs/ioctl.c +++ b/fs/btrfs/ioctl.c @@ -3278,7 +3278,6 @@ static int btrfs_extent_same(struct inode *src,

Re: [PATCH] usbip: Fix vep_free_request() null pointer checks on input args

2019-01-22 Thread shuah
On 1/19/19 1:17 AM, Greg KH wrote: On Fri, Jan 18, 2019 at 02:29:30PM -0700, Shuah Khan wrote: From: Shuah Khan Fix vep_free_request() to return when usb_ep and usb_request are null instead of calling WARN_ON. Signed-off-by: Shuah Khan --- drivers/usb/usbip/vudc_dev.c | 2 +- 1 file chang

Re: [PATCH 3/4] arm: omap1: no need to check return value of debugfs_create functions

2019-01-22 Thread Tony Lindgren
* Greg Kroah-Hartman [190122 14:41]: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. Acked-by: Tony Lindgren

Re: [PATCH 4/4] arm: omap2: no need to check return value of debugfs_create functions

2019-01-22 Thread Tony Lindgren
* Greg Kroah-Hartman [190122 14:41]: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. Acked-by: Tony Lindgren

Re: [PATCH] fbdev: omap2: no need to check return value of debugfs_create functions

2019-01-22 Thread Tony Lindgren
* Greg Kroah-Hartman [190122 15:28]: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. Acked-by: Tony Lindgren

Re: [PATCH] ti: wlcore: no need to check return value of debugfs_create functions

2019-01-22 Thread Tony Lindgren
* Greg Kroah-Hartman [190122 15:22]: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. Acked-by: Tony Lindgren

Re: [PATCH] x86/platform/UV: Replace kmalloc and memset with kzalloc and kcalloc

2019-01-22 Thread Gustavo A. R. Silva
On 1/16/19 6:06 AM, Borislav Petkov wrote: >> -vp = kmalloc_array(nuvhubs, sizeof(struct uvhub_desc), GFP_KERNEL); >> -uvhub_descs = (struct uvhub_desc *)vp; >> -memset(uvhub_descs, 0, nuvhubs * sizeof(struct uvhub_desc)); >> +uvhub_descs = kcalloc(nuvhubs, sizeof(*uvhub_descs),

Re: [PATCH] ti: wl12xx: no need to check return value of debugfs_create functions

2019-01-22 Thread Tony Lindgren
* Greg Kroah-Hartman [190122 15:23]: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. Acked-by: Tony Lindgren

Re: [PATCH] ti: wl1251: no need to check return value of debugfs_create functions

2019-01-22 Thread Tony Lindgren
* Greg Kroah-Hartman [190122 15:23]: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. Acked-by: Tony Lindgren

Re: [PATCH] ti: wl18xx: no need to check return value of debugfs_create functions

2019-01-22 Thread Tony Lindgren
* Greg Kroah-Hartman [190122 15:23]: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. Acked-by: Tony Lindgren

Re: linux-next: Tree for Jan 22 (drivers/reset/reset-brcmstb.c)

2019-01-22 Thread Florian Fainelli
On 1/22/19 8:21 AM, Randy Dunlap wrote: > On 1/21/19 8:36 PM, Stephen Rothwell wrote: >> Hi all, >> >> Changes since 20190121: >> > > on i386: > > ld: drivers/reset/reset-brcmstb.o: in function `brcmstb_reset_probe': > reset-brcmstb.c:(.text+0xd7): undefined reference to `__umoddi3' > ld: reset-b

Re: [PATCH v3 01/10] arm64: dts: qcom: sdm845: Update PIL region memory map

2019-01-22 Thread Doug Anderson
Hi, On Tue, Jan 22, 2019 at 11:24 AM Bjorn Andersson wrote: > > On Tue 22 Jan 10:58 PST 2019, Stephen Boyd wrote: > > > Quoting Bjorn Andersson (2019-01-21 21:51:03) > > > @@ -103,10 +138,30 @@ > > > no-map; > > > }; > > > > > > + venus_mem: m

Re: [PATCH] kvm: no need to check return value of debugfs_create functions

2019-01-22 Thread Paolo Bonzini
On 22/01/19 21:48, Greg Kroah-Hartman wrote: >> This also brings the question: shall we move these counters out of debugfs >> into something else? > If you have code that relies on debugfs, yes, you need to move that out > of debugfs because more and more systems are trying to disable it due to >

Re: [PATCH v3 01/10] arm64: dts: qcom: sdm845: Update PIL region memory map

2019-01-22 Thread Doug Anderson
Hi, On Mon, Jan 21, 2019 at 9:52 PM Bjorn Andersson wrote: > > Update existing and add all missing PIL regions to the reserved memory > map, as described in version 10. > > Signed-off-by: Bjorn Andersson > --- > > Changes since v2: > - New patch > > arch/arm64/boot/dts/qcom/sdm845.dtsi | 61 +++

<    5   6   7   8   9   10   11   12   13   >