Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-17 Thread Dan Williams
On Mon, Dec 17, 2018 at 12:57 AM Jan Kara wrote: > > On Fri 14-12-18 11:38:59, Dan Williams wrote: > > On Thu, Dec 13, 2018 at 10:11 PM John Hubbard wrote: > > > > > > On 12/13/18 9:21 PM, Dan Williams wrote: > > > > On Thu, Dec 13, 2018 at 7:53 PM John Hubbard > > > > wrote: > > > >> > > > >>

Re: [PATCH v14 1/5] x86/boot: Introduce get_acpi_rsdp() to parse RSDP in cmdline from KEXEC

2018-12-17 Thread Thomas Gleixner
On Mon, 17 Dec 2018, Ingo Molnar wrote: > * Chao Fan wrote: > > + val[len] = '\0'; > > + return (acpi_physical_address)simple_strtoull(val, &e, 16); > > 'return' is not a function - no need for the parenthesis. It's a typecast which better has parenthesis

Re: [PATCH v17 18/23] platform/x86: Intel SGX driver

2018-12-17 Thread Jarkko Sakkinen
On Mon, Dec 17, 2018 at 10:07:08AM -0800, Dave Hansen wrote: > On 12/17/18 10:01 AM, Jarkko Sakkinen wrote: > >>> + encl->mm = current->mm; <-> + > >>> encl->base = secs->base; > >>> + encl->size = secs->size; > >>> + encl->ssaframesize = secs->ssa_frame_size; > >

RE: [PATCH] Drivers: hv: vmbus: Return -EINVAL for the sys files for unopened channels

2018-12-17 Thread Dexuan Cui
> From: Stephen Hemminger > Sent: Monday, December 17, 2018 10:17 AM > To: Dexuan Cui > > On Mon, 17 Dec 2018 18:00:29 + > Dexuan Cui wrote: > > > > From: Stephen Hemminger > > > On Thu, 13 Dec 2018 16:35:43 + > > > Dexuan Cui wrote: > > > > > > > Before 98f4c651762c, we returned zer

Re: [PATCH v2 01/12] fs-verity: add a documentation file

2018-12-17 Thread Eric Biggers
On Mon, Dec 17, 2018 at 08:49:49AM -0800, Christoph Hellwig wrote: > > > > Given that you alread use an ioctl as the interface what is the problem > > > of passing this data through the ioctl? > > > > Do you mean pass the verity metadata in a buffer? That cannot work in > > general, > > because

Re: [PATCH v14 2/5] x86/boot: Introduce efi_get_rsdp_addr() to find RSDP from EFI table

2018-12-17 Thread Thomas Gleixner
On Mon, 17 Dec 2018, Ingo Molnar wrote: > * Chao Fan wrote: > > + else if (!(efi_guidcmp(guid, ACPI_20_TABLE_GUID))) > > + return (acpi_physical_address)table; > > 'return' is not a function. It's still a typecast :)

Re: [PATCH] Linux: Implement membarrier function

2018-12-17 Thread Paul E. McKenney
On Mon, Dec 17, 2018 at 11:02:40AM -0500, Alan Stern wrote: > On Sun, 16 Dec 2018, Paul E. McKenney wrote: > > > OK, so "simultaneous" IPIs could be emulated in a real implementation by > > having sys_membarrier() send each IPI (but not wait for a response), then > > execute a full memory barrier

Re: [PATCH v3 6/6] irqchip: sifive-plic: Implement irq_set_affinity() for SMP host

2018-12-17 Thread Christoph Hellwig
On Fri, Nov 30, 2018 at 01:32:07PM +0530, Anup Patel wrote: > This patch provides irq_set_affinity() implementation for PLIC driver. > It also updates irq_enable() such that PLIC interrupts are only enabled > for one of CPUs specified in IRQ affinity mask. But normally our affinity masks are that

Re: [PATCH v2] debugobjects: Move printk out of db lock critical sections

2018-12-17 Thread Waiman Long
On 12/17/2018 01:17 PM, Ingo Molnar wrote: > * Waiman Long wrote: > >> The db->lock is a raw spinlock and so the lock hold time is supposed to >> be short. This will not be the case when printk() is being involved in >> some of the critical sections. >> >> In order to avoid the long hold time, in

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-17 Thread Matthew Wilcox
On Mon, Dec 17, 2018 at 01:11:50PM -0500, Jerome Glisse wrote: > On Mon, Dec 17, 2018 at 08:58:19AM +1100, Dave Chinner wrote: > > Sure, that's a possibility, but that doesn't close off any race > > conditions because there can be DMA into the page in progress while > > the page is being bounced, r

Re: [RFC PATCH 2/2] PCI/portdrv Hisilicon PCIe transport layer Port PMU driver.

2018-12-17 Thread Logan Gunthorpe
On 2018-12-17 11:19 a.m., Bjorn Helgaas wrote: > I *think* drivers/pci/switch/switchtec.c is for a type 0 endpoint that > happens to be built into the switch, e.g., the type 1 bridge is > function 0 and the type 0 management endpoint is function 1. Logan, > can you confirm/deny? Yes, that's co

Re: [PATCH v17 18/23] platform/x86: Intel SGX driver

2018-12-17 Thread Sean Christopherson
On Mon, Dec 17, 2018 at 08:01:02PM +0200, Jarkko Sakkinen wrote: > On Mon, Dec 17, 2018 at 09:45:40AM -0800, Dave Hansen wrote: > > > +struct sgx_encl *sgx_encl_alloc(struct sgx_secs *secs) > > > +{ > > ... > > > + kref_init(&encl->refcount); > > > + INIT_LIST_HEAD(&encl->add_page_reqs); > > > + IN

Re: [PATCH 0/3] clk: imx: Make all the parent_names arrays be const pointers

2018-12-17 Thread Stephen Boyd
Quoting Abel Vesa (2018-12-17 03:35:40) > On 18-12-14 13:08:37, Stephen Boyd wrote: > > Quoting Abel Vesa (2018-12-14 07:30:08) > > > This is mainly to shut up the checkpatch.pl script warnings about the > > > "static const char *" needing to be "static const char * const". > > > > > > Abel Vesa (

[PATCH V2] mmc: tegra: HW Command Queue Support for Tegra SDMMC

2018-12-17 Thread Sowjanya Komatineni
This patch adds HW Command Queue for supported Tegra SDMMC controllers. Tegra SDHCI with Quirk SDHCI_QUIRK2_BROKEN_64_BIT_DMA disables the use of 64_BIT DMA to disable 64-bit addressing mode access to the system memory and sdhci_cqe_enable using flag SDHCI_USE_64_BIT_DMA for ADMA32/ADMA2 Vs ADMA64

Re: [RFC PATCH net v3] net: phy: Fix the issue that netif always links up after resuming

2018-12-17 Thread Heiner Kallweit
On 17.12.2018 07:41, Kunihiko Hayashi wrote: > Hi, > > Gentle ping... > Are there any comments about changes since v2? > > v2: https://www.spinics.net/lists/netdev/msg536926.html > > Thank you, > > On Mon, 3 Dec 2018 17:22:29 +0900 wrote: > >> Even though the link is down before entering hibe

Re: [PATCH v5 3/3] Documentation/filesystems/proc.txt: add AVX512_elapsed_ms

2018-12-17 Thread Tim Chen
On 12/16/18 10:50 AM, Aubrey Li wrote: > @@ -275,6 +276,7 @@ Table 1-2: Contents of the status files (as of 4.8) Will need to update the "as of 4.8" to the version of kernel this patch is targeted. > Mems_allowed_list Same as previous, but in "list format" > voluntary_ctxt_switche

RE: [tip:efi/core] x86/efi: Unmap EFI boot services code/data regions from efi_pgd

2018-12-17 Thread Prakhya, Sai Praneeth
> > Hi Thomas and Ingo, > > > > I recently noticed that the below commits [1] and [2] are broken when > > kernel command line argument "efi=old_map" is passed. Sorry! I missed > > to test this condition prior to sending these patches to mailing list. > > I am working on a fix and will send it to ma

Re: selftests/net: udpgso: LTS kernels supportability ?

2018-12-17 Thread shuah
Hi Rafael, On 12/17/18 10:53 AM, Rafael David Tinoco wrote: Shuah, I was recently investigating some errors coming out of our functional tests and we, Dan and I, came up with a discussion that might not be new for you, but, interests us, in defining how to better use kselftests as a regression

Re: [PATCH v3] staging: android: ion: Add implementation of dma_buf_vmap and dma_buf_vunmap

2018-12-17 Thread Liam Mark
On Sun, 16 Dec 2018, Alexey Skidanov wrote: > > > On 12/16/18 7:20 AM, Liam Mark wrote: > > On Tue, 6 Feb 2018, Alexey Skidanov wrote: > > > >> > >> > >> On 02/07/2018 01:56 AM, Laura Abbott wrote: > >>> On 01/31/2018 10:10 PM, Alexey Skidanov wrote: > > On 01/31/2018 03:00 PM, Greg K

Re: [PATCH 2/3] hugetlbfs: Use i_mmap_rwsem to fix page fault/truncate race

2018-12-17 Thread Mike Kravetz
On 12/17/18 2:25 AM, Aneesh Kumar K.V wrote: > On 12/4/18 1:38 AM, Mike Kravetz wrote: >> hugetlbfs page faults can race with truncate and hole punch operations. >> Current code in the page fault path attempts to handle this by 'backing >> out' operations if we encounter the race. One obvious omis

Re: [PATCH v17 18/23] platform/x86: Intel SGX driver

2018-12-17 Thread Jarkko Sakkinen
On Mon, Dec 17, 2018 at 10:36:13AM -0800, Sean Christopherson wrote: > I'm pretty sure doing mmget() would result in circular dependencies and > a zombie enclave. In the do_exit() case where a task is abruptly killed: > > - __mmput() is never called because the enclave holds a ref > - sgx_en

Re: [RFC PATCH net v3] net: phy: Fix the issue that netif always links up after resuming

2018-12-17 Thread Heiner Kallweit
On 17.12.2018 19:41, Heiner Kallweit wrote: > On 17.12.2018 07:41, Kunihiko Hayashi wrote: >> Hi, >> >> Gentle ping... >> Are there any comments about changes since v2? >> >> v2: https://www.spinics.net/lists/netdev/msg536926.html >> >> Thank you, >> >> On Mon, 3 Dec 2018 17:22:29 +0900 wrote: >>

Re: [PATCH RESEND] KEYS: fix parsing invalid pkey info string

2018-12-17 Thread Linus Torvalds
On Mon, Dec 17, 2018 at 10:13 AM Eric Biggers wrote: > > Hi Linus, please consider applying this patch. It's been ignored by the > keyrings maintainer for a month and a half with multiple reminders. It > fixes an easily reachable stack corruption in the new keyctl operations > that were added in

RE: [PATCH] Drivers: hv: vmbus: Return -EINVAL for the sys files for unopened channels

2018-12-17 Thread Dexuan Cui
> From: devel On Behalf Of > Dexuan Cui > Sent: Monday, December 17, 2018 10:31 AM > > From: Stephen Hemminger > > > > The old code was risky because it would silently return stack garbage. > > Having an error check in get_debuginfo would eliminate that. > > OK, then let me make another patch ba

Re: WARNING in __rcu_read_unlock

2018-12-17 Thread Dmitry Vyukov
On Mon, Dec 17, 2018 at 12:29 PM Paul E. McKenney wrote: > Any chance of a bisection? Better later then never. Bisection also needs testing :) syz-bisect -config bisect.cfg -crash dda626cdbd87eafe9a755acbbe102e2b6096b256 searching for guilty commit starting from 2aa55dccf83d building syzkaller o

[PATCH V3] mmc: tegra: HW Command Queue Support for Tegra SDMMC

2018-12-17 Thread Sowjanya Komatineni
This patch adds HW Command Queue for supported Tegra SDMMC controllers. Tegra SDHCI with Quirk SDHCI_QUIRK2_BROKEN_64_BIT_DMA disables the use of 64_BIT DMA to disable 64-bit addressing mode access to the system memory and sdhci_cqe_enable using flag SDHCI_USE_64_BIT_DMA for ADMA32/ADMA2 Vs ADMA64

Re: [PATCH v17 18/23] platform/x86: Intel SGX driver

2018-12-17 Thread Sean Christopherson
On Mon, Dec 17, 2018 at 08:23:19PM +0200, Jarkko Sakkinen wrote: > On Mon, Dec 17, 2018 at 10:09:57AM -0800, Sean Christopherson wrote: > > No, EREMOVE should never fail if the enclave is being released, i.e. all > > references to the enclave are gone. And failure during sgx_encl_release() > > mea

Re: [PATCH v17 18/23] platform/x86: Intel SGX driver

2018-12-17 Thread Dave Hansen
On 12/17/18 10:43 AM, Jarkko Sakkinen wrote: > On Mon, Dec 17, 2018 at 10:36:13AM -0800, Sean Christopherson wrote: >> I'm pretty sure doing mmget() would result in circular dependencies and >> a zombie enclave. In the do_exit() case where a task is abruptly killed: >> >> - __mmput() is never

Re: [PATCH v14 1/5] x86/boot: Introduce get_acpi_rsdp() to parse RSDP in cmdline from KEXEC

2018-12-17 Thread Ingo Molnar
* Thomas Gleixner wrote: > On Mon, 17 Dec 2018, Ingo Molnar wrote: > > * Chao Fan wrote: > > > + val[len] = '\0'; > > > + return (acpi_physical_address)simple_strtoull(val, &e, 16); > > > > 'return' is not a function - no need for the parenthesis. > > It's a typecast which be

Re: [PATCH v17 18/23] platform/x86: Intel SGX driver

2018-12-17 Thread Sean Christopherson
On Mon, Dec 17, 2018 at 08:43:33PM +0200, Jarkko Sakkinen wrote: > On Mon, Dec 17, 2018 at 10:36:13AM -0800, Sean Christopherson wrote: > > I'm pretty sure doing mmget() would result in circular dependencies and > > a zombie enclave. In the do_exit() case where a task is abruptly killed: > > > >

Re: [PATCH v14 2/5] x86/boot: Introduce efi_get_rsdp_addr() to find RSDP from EFI table

2018-12-17 Thread Ingo Molnar
* Thomas Gleixner wrote: > On Mon, 17 Dec 2018, Ingo Molnar wrote: > > * Chao Fan wrote: > > > + else if (!(efi_guidcmp(guid, ACPI_20_TABLE_GUID))) > > > + return (acpi_physical_address)table; > > > > 'return' is not a function. > > It's still a typecast :) Yeah, see

Re: [PATCH RESEND] KEYS: fix parsing invalid pkey info string

2018-12-17 Thread Linus Torvalds
On Mon, Dec 17, 2018 at 10:43 AM Linus Torvalds wrote: > > Or maybe just remove it entirely, since it's clearly entirely > incorrect from the very start. .. or another alternative: remove the "Opt_err = -1" entirely. Again, this seems to be a buggy pattern exclusive to the security code. Nobody

Re: [RFC] regmap-irq: add "main register" and level-irq support

2018-12-17 Thread Mark Brown
On Mon, Dec 17, 2018 at 10:19:12AM +0200, Matti Vaittinen wrote: > On Fri, Dec 14, 2018 at 05:26:19PM +, Mark Brown wrote: > > On Fri, Dec 14, 2018 at 03:58:19PM +0200, Matti Vaittinen wrote: > > > On Fri, Dec 07, 2018 at 01:14:18PM +, Mark Brown wrote: > > > I could send an example on how

Re: [PATCH v1 1/1] MAINTAINERS: update list of qcom drivers

2018-12-17 Thread Amit Kucheria
On Mon, Dec 17, 2018 at 10:51 PM Joe Perches wrote: > > On Mon, 2018-12-17 at 21:49 +0530, Amit Kucheria wrote: > > Several drivers didn't have a specific maintainer (other than the > > subsystem maintainer). Switch to using the 'qcom' and 'msm' regex > > patterns to capture all of them and add ex

Re: NFS/TCP crashes on MIPS/RBTX4927 in v4.20-rcX (bisected)

2018-12-17 Thread Geert Uytterhoeven
Hi Trond, (For the newly added CCs, first message was https://lore.kernel.org/lkml/CAMuHMdVJr0PwvJg3FeTCy7vxuyY1=s1tplho7hpsozx4wz+...@mail.gmail.com/) > On Mon, Dec 17, 2018 at 3:51 PM Trond Myklebust > wrote: > > On Mon, 2018-12-17 at 15:03 +0100, Geert Uytterhoeven wrote: > > > On We

Re: [PATCH v3 1/2] spi: Add Renesas R-Car Gen3 RPC SPI controller driver

2018-12-17 Thread Sergei Shtylyov
Hello! On 12/17/2018 10:42 AM, masonccy...@mxic.com.tw wrote: >> > +static int rpc_spi_io_xfer(struct rpc_spi *rpc, >> > +const void *tx_buf, void *rx_buf) >> > +{ >> > + u32 smenr, smcr, data, pos = 0; >> > + int ret = 0; >> > + >> > + regmap_write(rpc->regmap, RPC_CMNCR, RPC_C

Re: [PATCH v3] m68k: Fix memblock-related crashes

2018-12-17 Thread Andreas Schwab
On Dez 13 2018, Andreas Schwab wrote: > I'm now getting this Oops: > > [ 65.39] Unable to handle kernel NULL pointer dereference at virtual > address (ptrval) > [ 65.39] Oops: > [ 65.39] Modules linked in: nls_iso8859_1 nls_cp437 vfat fat virtio_rng > virtio_blk virti

Re: [PATCH 0/3] clk: imx: Make all the parent_names arrays be const pointers

2018-12-17 Thread Abel Vesa
On 18-12-17 10:40:52, Stephen Boyd wrote: > Quoting Abel Vesa (2018-12-17 03:35:40) > > On 18-12-14 13:08:37, Stephen Boyd wrote: > > > Quoting Abel Vesa (2018-12-14 07:30:08) > > > > This is mainly to shut up the checkpatch.pl script warnings about the > > > > "static const char *" needing to be "

Re: NFS/TCP crashes on MIPS/RBTX4927 in v4.20-rcX (bisected)

2018-12-17 Thread Trond Myklebust
On Mon, 2018-12-17 at 19:55 +0100, Geert Uytterhoeven wrote: > Hi Trond, > > (For the newly added CCs, first message was > https://lore.kernel.org/lkml/CAMuHMdVJr0PwvJg3FeTCy7vxuyY1=s1tplho7hpsozx4wz+...@mail.gmail.com/) > > > On Mon, Dec 17, 2018 at 3:51 PM Trond Myklebust < > > tron...@ha

Re: [PATCH RESEND] KEYS: fix parsing invalid pkey info string

2018-12-17 Thread Linus Torvalds
On Mon, Dec 17, 2018 at 10:49 AM Linus Torvalds wrote: > > So the *simplest* fix would seem to be to literally remove all those > "= -1" for the Opt_err initialization. Making the code smaller, > simpler, and fixing the bug in the process. Something like this git grep -l 'Opt_err = -1' | x

Applied "regmap: debugfs: convert to DEFINE_SHOW_ATTRIBUTE" to the regmap tree

2018-12-17 Thread Mark Brown
The patch regmap: debugfs: convert to DEFINE_SHOW_ATTRIBUTE has been applied to the regmap tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and

Applied "regmap: rbtree: convert to DEFINE_SHOW_ATTRIBUTE" to the regmap tree

2018-12-17 Thread Mark Brown
The patch regmap: rbtree: convert to DEFINE_SHOW_ATTRIBUTE has been applied to the regmap tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and s

Re: A weird problem of Realtek r8168 after resume from S3

2018-12-17 Thread Heiner Kallweit
On 17.12.2018 14:25, Chris Chiu wrote: > On Fri, Dec 14, 2018 at 3:37 PM Heiner Kallweit wrote: >> >> On 14.12.2018 04:33, Chris Chiu wrote: >>> On Thu, Dec 13, 2018 at 10:20 AM Chris Chiu wrote: Hi, We got an acer laptop which has a problem with ethernet networking after

Re: [PATCH 4.4 00/88] 4.4.168-stable review

2018-12-17 Thread Greg Kroah-Hartman
On Mon, Dec 17, 2018 at 05:46:01AM -0800, Guenter Roeck wrote: > On 12/17/18 1:05 AM, Greg Kroah-Hartman wrote: > > On Sun, Dec 16, 2018 at 11:58:13PM +, Ben Hutchings wrote: > > > On Sat, 2018-12-15 at 07:45 -0800, Guenter Roeck wrote: > > > > On 12/15/18 12:07 AM, Greg Kroah-Hartman wrote: >

Re: [PATCH v17 18/23] platform/x86: Intel SGX driver

2018-12-17 Thread Dave Hansen
On 12/17/18 10:48 AM, Sean Christopherson wrote: > We can't set mm to NULL as we need it to unregister the notifier, and > I'm fairly certain attempting to unregister in the release callback > will deadlock. Suggestion: It looks like you only expect one VMA per enclave. Things go bonkers if this

Re: [PATCH v17 18/23] platform/x86: Intel SGX driver

2018-12-17 Thread Andy Lutomirski
On Mon, Dec 17, 2018 at 10:47 AM Dave Hansen wrote: > > On 12/17/18 10:43 AM, Jarkko Sakkinen wrote: > > On Mon, Dec 17, 2018 at 10:36:13AM -0800, Sean Christopherson wrote: > >> I'm pretty sure doing mmget() would result in circular dependencies and > >> a zombie enclave. In the do_exit() case w

Re: [PATCH 1/1] net-next/hinic:optmize rx refill buffer mechanism

2018-12-17 Thread David Miller
From: Xue Chaojing Date: Sun, 16 Dec 2018 22:32:34 + > In rx_alloc_pkts(), there is no need to schedule a different tasklet for > refill and it will cause some extra overhead. this patch remove it. > > Suggested-by: Neil Horman > Signed-off-by: Xue Chaojing In future submissions please fo

Re: [PATCH] VSOCK: Send reset control packet when socket is partially bound

2018-12-17 Thread David Miller
From: Jorgen Hansen Date: Wed, 12 Dec 2018 01:38:59 -0800 > static int vmci_transport_send_reset_bh(struct sockaddr_vm *dst, > @@ -312,12 +328,29 @@ static int vmci_transport_send_reset_bh(struct > sockaddr_vm *dst, > static int vmci_transport_send_reset(struct sock *sk, >

Re: [PATCH v2 01/12] fs-verity: add a documentation file

2018-12-17 Thread Eric Biggers
Hi Christoph, On Mon, Dec 17, 2018 at 08:52:31AM -0800, Christoph Hellwig wrote: > [FYI, your mail never made it to my inbox, although I found the copy > in linux-fsdevel now] > > On Fri, Dec 14, 2018 at 12:17:22AM -0500, Theodore Y. Ts'o wrote: > > I don't consider fs-verity to be part of core V

Re: [PATCH v17 18/23] platform/x86: Intel SGX driver

2018-12-17 Thread Dave Hansen
On 12/17/18 11:12 AM, Andy Lutomirski wrote: > So I'm not saying that you shouldn't do it the way you are now, but I > do think that the changelog or at least some emails should explain > *why* the enclave needs to keep a pointer to the creating process's > mm. And, if you do keep the current mode

Re: [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1

2018-12-17 Thread Aaro Koskinen
On Thu, Nov 22, 2018 at 03:12:36PM +, Russell King - ARM Linux wrote: > Also we can't deal with the omap_set_dma_dest_burst_mode() setting - > DMAengine always uses a 64 byte burst, but udc wants a smaller burst > setting. Does this matter? Looking at OMAP1 docs, it seems it supports only 16

Re: [PATCH V2] livepatch: fix non-static warnings

2018-12-17 Thread Nicholas Mc Guire
On Mon, Dec 17, 2018 at 10:44:36AM -0500, Joe Lawrence wrote: > On 12/17/2018 07:03 AM, Miroslav Benes wrote: > > Hi, > > > > I'm sorry for being late to the party. > > > > On Sun, 16 Dec 2018, Nicholas Mc Guire wrote: > > > >> Sparse reported warnings about non-static symbols. For the variables

Re: [PATCH v17 18/23] platform/x86: Intel SGX driver

2018-12-17 Thread Andy Lutomirski
On Mon, Dec 17, 2018 at 11:17 AM Dave Hansen wrote: > > On 12/17/18 11:12 AM, Andy Lutomirski wrote: > > So I'm not saying that you shouldn't do it the way you are now, but I > > do think that the changelog or at least some emails should explain > > *why* the enclave needs to keep a pointer to the

Re: objtool warnings for kernel/trace/trace_selftest_dynamic.o

2018-12-17 Thread Peter Zijlstra
On Mon, Dec 17, 2018 at 12:16:38PM -0600, Josh Poimboeuf wrote: > > Yes LTO causes the to be treated like static functions. > > > > I guess noclone is unlikely to be really needed here because these > > functions are unlikely to be cloned. > > > > So as a workaround it could be removed. > > > >

Re: [PATCH v2] debugobjects: Move printk out of db lock critical sections

2018-12-17 Thread Peter Zijlstra
On Mon, Dec 17, 2018 at 07:17:12PM +0100, Ingo Molnar wrote: > and rename early_printk() to printk(), and be done with this. git://git.kernel.org/pub/scm/linux/kernel/git/peterz/queue.git debug/experimental :-)

Re: [GIT PULL] tpmdd updates for Linux v4.21

2018-12-17 Thread James Morris
On Mon, 17 Dec 2018, Jarkko Sakkinen wrote: > Hi James, > > v4.21 updates: > > * Support for partial reads of /dev/tpm0. > * Clean up for TPM 1.x code: move the commands to tpm1-cmd.c and make > everything to use the same data structure for building TPM commands > i.e. struct tpm_buf. Pulle

Re: [PATCH v17 18/23] platform/x86: Intel SGX driver

2018-12-17 Thread Jarkko Sakkinen
On Mon, Dec 17, 2018 at 10:48:58AM -0800, Sean Christopherson wrote: > On Mon, Dec 17, 2018 at 08:43:33PM +0200, Jarkko Sakkinen wrote: > > On Mon, Dec 17, 2018 at 10:36:13AM -0800, Sean Christopherson wrote: > > > I'm pretty sure doing mmget() would result in circular dependencies and > > > a zomb

Re: [PATCH v13 19/25] kasan: add hooks implementation for tag-based mode

2018-12-17 Thread Andrey Konovalov
On Fri, Dec 14, 2018 at 1:34 PM Vincenzo Frascino wrote: > > On 12/12/18 3:04 PM, Andrey Konovalov wrote: > > On Tue, Dec 11, 2018 at 5:22 PM Vincenzo Frascino > > wrote: > >> > >> Hi Andrey, > >> > >> On 06/12/2018 12:24, Andrey Konovalov wrote: > >>> This commit adds tag-based KASAN specific ho

Re: [PATCH] integrity: Remove references to module keyring

2018-12-17 Thread James Morris
On Wed, 12 Dec 2018, Thiago Jung Bauermann wrote: > >From what I can tell, it has never been used. > > Signed-off-by: Thiago Jung Bauermann Mimi, can I add your acked-by? > --- > security/integrity/digsig.c| 1 - > security/integrity/integrity.h | 5 ++--- > 2 files changed, 2 insertions

Re: [PATCH v3] m68k: Fix memblock-related crashes

2018-12-17 Thread Andreas Schwab
On Dez 17 2018, Andreas Schwab wrote: > On Dez 13 2018, Andreas Schwab wrote: > >> I'm now getting this Oops: >> >> [ 65.39] Unable to handle kernel NULL pointer dereference at virtual >> address (ptrval) >> [ 65.39] Oops: >> [ 65.39] Modules linked in: nls_iso8859_1

Re: [PATCH] ARM: Ensure that NEON code always compiles with Clang

2018-12-17 Thread Nathan Chancellor
On Mon, Dec 17, 2018 at 01:23:52PM -0500, Nicolas Pitre wrote: > On Sat, 15 Dec 2018, Nathan Chancellor wrote: > > > While building arm32 allyesconfig, I ran into the following errors: > > > > arch/arm/lib/xor-neon.c:17:2: error: You should compile this file with > > '-mfloat-abi=softfp -mfpu

Re: [tip:efi/core] x86/efi: Unmap EFI boot services code/data regions from efi_pgd

2018-12-17 Thread Ard Biesheuvel
On Mon, 17 Dec 2018 at 19:42, Prakhya, Sai Praneeth wrote: > > > > Hi Thomas and Ingo, > > > > > > I recently noticed that the below commits [1] and [2] are broken when > > > kernel command line argument "efi=old_map" is passed. Sorry! I missed > > > to test this condition prior to sending these p

Re: [GIT PULL] seccomp updates for next (part2)

2018-12-17 Thread James Morris
On Mon, 17 Dec 2018, Kees Cook wrote: > On Fri, Dec 14, 2018 at 8:26 AM Kees Cook wrote: > > > > > > Hi James, > > > > Please pull these seccomp fixes for -next. > > > > Thanks! > > Friendly ping: James, can you pick this up for -next? > Pulled to next-seccomp and next-testing. > -Kees > >

Re: [PATCH v17 18/23] platform/x86: Intel SGX driver

2018-12-17 Thread Jarkko Sakkinen
On Mon, Dec 17, 2018 at 10:46:25AM -0800, Sean Christopherson wrote: > On Mon, Dec 17, 2018 at 08:23:19PM +0200, Jarkko Sakkinen wrote: > > On Mon, Dec 17, 2018 at 10:09:57AM -0800, Sean Christopherson wrote: > > > No, EREMOVE should never fail if the enclave is being released, i.e. all > > > refer

Re: [PATCH v17 18/23] platform/x86: Intel SGX driver

2018-12-17 Thread Jarkko Sakkinen
On Mon, Dec 17, 2018 at 11:09:33AM -0800, Dave Hansen wrote: > On 12/17/18 10:48 AM, Sean Christopherson wrote: > > We can't set mm to NULL as we need it to unregister the notifier, and > > I'm fairly certain attempting to unregister in the release callback > > will deadlock. > > Suggestion: > >

Re: [PATCH 10/13] arm64: dts: qcom: qcs404: Add HFPLL node

2018-12-17 Thread Stephen Boyd
Quoting Jorge Ramirez-Ortiz (2018-12-17 01:46:27) > The high frequency pll functionality is required to enable CPU > frequency scaling operation. > > Co-developed-by: Niklas Cassel > Signed-off-by: Niklas Cassel > Signed-off-by: Jorge Ramirez-Ortiz > --- > arch/arm64/boot/dts/qcom/qcs404.dtsi

Re: [PATCH v17 18/23] platform/x86: Intel SGX driver

2018-12-17 Thread Dave Hansen
On 12/17/18 11:37 AM, Jarkko Sakkinen wrote: >> Suggestion: >> >> It looks like you only expect one VMA per enclave. Things go bonkers if >> this is not true. So, instead of storing encl->mm, don't. You can get >> the mm from vma->vm_mm and you could just store encl->vma instead. > The code actu

Re: [PATCH RESEND] KEYS: fix parsing invalid pkey info string

2018-12-17 Thread Linus Torvalds
On Mon, Dec 17, 2018 at 11:06 AM Linus Torvalds wrote: > > Honestly, for being about "security", all of this code seems to be > doing some really questionable things with all those Opt_xyz enums. Yeah, at least security/keys/trusted.c ends up mixing that enum and just using "int" completely rando

Re: [Potential Spoof] Re: [PATCH 1/4] ARM: dts: aspeed: Add sensors devices for Facebook

2018-12-17 Thread Vijay Khemka
On 12/14/18, 12:42 PM, "Linux-aspeed on behalf of Vijay Khemka" wrote: On 12/14/18, 11:22 AM, "openbmc on behalf of Jae Hyun Yoo" wrote: Hi Vijay, On 12/14/2018 10:11 AM, Vijay Khemka wrote: > On 12/13/18, 2:56 PM, "Joel Stanley" wrote:

Re: linux-next: manual merge of the gpio tree with the arm-soc tree

2018-12-17 Thread Tony Lindgren
* Stephen Rothwell [181217 00:18]: > Hi all, > > Today's linux-next merge of the gpio tree got a conflict in: > > arch/arm/mach-omap1/board-ams-delta.c > > between commit: > > 19a2668a8ae3 ("ARM: OMAP1: ams-delta: Provide GPIO lookup table for LED > device") > > from the arm-soc tree and

Re: [PATCH v2] loop: drop caches if offset or block_size are changed

2018-12-17 Thread Jaegeuk Kim
If we don't drop caches used in old offset or block_size, we can get old data from new offset/block_size, which gives unexpected data to user. For example, Martijn found a loopback bug in the below scenario. 1) LOOP_SET_FD loads first two pages on loop file 2) LOOP_SET_STATUS64 changes the offset

Re: [PATCH v3] block: fix blk-iolatency accounting underflow

2018-12-17 Thread Liu Bo
On Mon, Dec 17, 2018 at 8:04 AM Dennis Zhou wrote: > > The blk-iolatency controller measures the time from rq_qos_throttle() to > rq_qos_done_bio() and attributes this time to the first bio that needs > to create the request. This means if a bio is plug-mergeable or > bio-mergeable, it gets to byp

Re: [PATCH v2] debugobjects: Move printk out of db lock critical sections

2018-12-17 Thread Linus Torvalds
On Mon, Dec 17, 2018 at 10:17 AM Ingo Molnar wrote: > > We should rename printk() to syslog() or so, and rename early_printk() to > printk(), and be done with this. No. As already pointed out, the syslog part isn't the issue. The printing part is the issue. So thinking that early_printk is any

RE: [tip:efi/core] x86/efi: Unmap EFI boot services code/data regions from efi_pgd

2018-12-17 Thread Prakhya, Sai Praneeth
> > > > Hi Thomas and Ingo, > > > > > > > > I recently noticed that the below commits [1] and [2] are broken > > > > when kernel command line argument "efi=old_map" is passed. Sorry! > > > > I missed to test this condition prior to sending these patches to > > > > mailing list. > > > > I am workin

Re: [PATCH] drivers/base: use a worker for sysfs unbind

2018-12-17 Thread Daniel Vetter
On Thu, Dec 13, 2018 at 07:09:15PM +0100, Rafael J. Wysocki wrote: > On Thu, Dec 13, 2018 at 5:25 PM Daniel Vetter wrote: > > > > On Thu, Dec 13, 2018 at 5:18 PM Rafael J. Wysocki wrote: > > > > > > On Thu, Dec 13, 2018 at 1:36 PM Daniel Vetter > > > wrote: > > [cut] > > > > > I can do the ol

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-17 Thread Jerome Glisse
On Mon, Dec 17, 2018 at 10:34:43AM -0800, Matthew Wilcox wrote: > On Mon, Dec 17, 2018 at 01:11:50PM -0500, Jerome Glisse wrote: > > On Mon, Dec 17, 2018 at 08:58:19AM +1100, Dave Chinner wrote: > > > Sure, that's a possibility, but that doesn't close off any race > > > conditions because there can

Re: [PATCH v17 18/23] platform/x86: Intel SGX driver

2018-12-17 Thread Jarkko Sakkinen
On Mon, Dec 17, 2018 at 11:17:49AM -0800, Dave Hansen wrote: > On 12/17/18 11:12 AM, Andy Lutomirski wrote: > > So I'm not saying that you shouldn't do it the way you are now, but I > > do think that the changelog or at least some emails should explain > > *why* the enclave needs to keep a pointer

Re: [Potential Spoof] Re: [PATCH 1/4] ARM: dts: aspeed: Add sensors devices for Facebook

2018-12-17 Thread James Feist
On 12/17/18 11:39 AM, Vijay Khemka wrote: On 12/14/18, 12:42 PM, "Linux-aspeed on behalf of Vijay Khemka" wrote: On 12/14/18, 11:22 AM, "openbmc on behalf of Jae Hyun Yoo" wrote: Hi Vijay, On 12/14/2018 10:11 AM, Vijay Khemka wrote:

Re: [PATCH RESEND] KEYS: fix parsing invalid pkey info string

2018-12-17 Thread James Bottomley
On Mon, 2018-12-17 at 11:39 -0800, Linus Torvalds wrote: > On Mon, Dec 17, 2018 at 11:06 AM Linus Torvalds > wrote: > > > > Honestly, for being about "security", all of this code seems to be > > doing some really questionable things with all those Opt_xyz enums. > > Yeah, at least security/keys/

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-17 Thread Matthew Wilcox
On Mon, Dec 17, 2018 at 02:48:00PM -0500, Jerome Glisse wrote: > On Mon, Dec 17, 2018 at 10:34:43AM -0800, Matthew Wilcox wrote: > > On Mon, Dec 17, 2018 at 01:11:50PM -0500, Jerome Glisse wrote: > > > On Mon, Dec 17, 2018 at 08:58:19AM +1100, Dave Chinner wrote: > > > > Sure, that's a possibility,

Re: [PATCH v17 18/23] platform/x86: Intel SGX driver

2018-12-17 Thread Dave Hansen
On 12/17/18 11:49 AM, Jarkko Sakkinen wrote: >> Yeah, the code is built to have one VMA and only one VMA per enclave. >> You need to go over the origin of this restriction and what enforces this. > It is before ECREATE but after that you can split it with mprotect(). > > Lets take an example. I'm

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-17 Thread Jerome Glisse
On Mon, Dec 17, 2018 at 11:51:51AM -0800, Matthew Wilcox wrote: > On Mon, Dec 17, 2018 at 02:48:00PM -0500, Jerome Glisse wrote: > > On Mon, Dec 17, 2018 at 10:34:43AM -0800, Matthew Wilcox wrote: > > > On Mon, Dec 17, 2018 at 01:11:50PM -0500, Jerome Glisse wrote: > > > > On Mon, Dec 17, 2018 at 0

Re: [PATCH v17 18/23] platform/x86: Intel SGX driver

2018-12-17 Thread Jarkko Sakkinen
On Mon, Dec 17, 2018 at 11:25:47AM -0800, Andy Lutomirski wrote: > On Mon, Dec 17, 2018 at 11:17 AM Dave Hansen wrote: > > > > On 12/17/18 11:12 AM, Andy Lutomirski wrote: > > > So I'm not saying that you shouldn't do it the way you are now, but I > > > do think that the changelog or at least some

Re: [PATCH v17 18/23] platform/x86: Intel SGX driver

2018-12-17 Thread Andy Lutomirski
On Mon, Dec 17, 2018 at 11:53 AM Dave Hansen wrote: > > On 12/17/18 11:49 AM, Jarkko Sakkinen wrote: > >> Yeah, the code is built to have one VMA and only one VMA per enclave. > >> You need to go over the origin of this restriction and what enforces this. > > It is before ECREATE but after that yo

Re: [PATCH 2/2] Staging: nvec: nvec: fixed check style issues

2018-12-17 Thread Marc Dietrich
Hi, On Mon, 17 Dec 2018, Greg KH wrote: On Sun, Dec 16, 2018 at 08:57:43AM -0800, Amir Mahdi Ghorbanian wrote: @@ -626,7 +628,7 @@ static irqreturn_t nvec_interrupt(int irq, void *dev) break; case 2: /* first byte after command */ if (status ==

Re: WARNING in __rcu_read_unlock

2018-12-17 Thread Paul E. McKenney
On Mon, Dec 17, 2018 at 07:45:58PM +0100, Dmitry Vyukov wrote: > On Mon, Dec 17, 2018 at 12:29 PM Paul E. McKenney > wrote: > > Any chance of a bisection? > > Better later then never. Bisection also needs testing :) Well, it looks like it did pass the test, arriving at the same commit that Eric

Re: [PATCH v5 3/5] mm: Shuffle initial free memory to improve memory-side-cache utilization

2018-12-17 Thread Dan Williams
On Sun, Dec 16, 2018 at 4:43 AM Mike Rapoport wrote: > > On Fri, Dec 14, 2018 at 05:48:46PM -0800, Dan Williams wrote: > > Randomization of the page allocator improves the average utilization of > > a direct-mapped memory-side-cache. Memory side caching is a platform > > capability that Linux has

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-17 Thread Matthew Wilcox
On Mon, Dec 17, 2018 at 02:54:08PM -0500, Jerome Glisse wrote: > On Mon, Dec 17, 2018 at 11:51:51AM -0800, Matthew Wilcox wrote: > > On Mon, Dec 17, 2018 at 02:48:00PM -0500, Jerome Glisse wrote: > > > On Mon, Dec 17, 2018 at 10:34:43AM -0800, Matthew Wilcox wrote: > > > > No. The solution John, D

Re: [PATCH v2 01/12] fs-verity: add a documentation file

2018-12-17 Thread Darrick J. Wong
On Thu, Dec 13, 2018 at 08:48:03PM -0800, Eric Biggers wrote: > Hi Christoph, > > On Thu, Dec 13, 2018 at 12:22:49PM -0800, Christoph Hellwig wrote: > > On Wed, Dec 12, 2018 at 12:26:10PM -0800, Eric Biggers wrote: > > > > As this apparently got merged despite no proper reviews from VFS > > > > le

Re: [PATCH RESEND] KEYS: fix parsing invalid pkey info string

2018-12-17 Thread Linus Torvalds
On Mon, Dec 17, 2018 at 11:51 AM James Bottomley wrote: > > If this is to replace Eric's patch, didn't you want to set token_mask > to (1<

Re: [PATCH v17 18/23] platform/x86: Intel SGX driver

2018-12-17 Thread Dave Hansen
On 12/17/18 11:55 AM, Andy Lutomirski wrote: >> You're effectively rebuilding reverse-mapping infrastructure here. It's >> a frequent thing for the core VM to need to go from 'struct page' back >> to the page tables mapping it. For that we go (logically) >> page->{anon_vma,mapping}->vma->vm_mm->p

[PATCH v2 2/4] ARM: dts: aspeed: Add KCS support for LPC BMC

2018-12-17 Thread Vijay Khemka
Added kcs device support for lpc BMC. Signed-off-by: Vijay Khemka --- arch/arm/boot/dts/aspeed-g5.dtsi | 33 +++- 1 file changed, 32 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi index d107459fc0f8..2743

Re: [PATCH] integrity: Remove references to module keyring

2018-12-17 Thread Mimi Zohar
On Tue, 2018-12-18 at 06:33 +1100, James Morris wrote: > On Wed, 12 Dec 2018, Thiago Jung Bauermann wrote: > > > >From what I can tell, it has never been used. This was introduced prior to Rusty's decision to use appended signatures for kernel modules. > > > > Signed-off-by: Thiago Jung Bauerma

[PATCH v2 3/4] ARM: dts: aspeed: Add KCS for Facebook

2018-12-17 Thread Vijay Khemka
Added kcs device in Facebook Tiogapass device tree. Signed-off-by: Vijay Khemka --- arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts | 12 1 file changed, 12 insertions(+) diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts b/arch/arm/boot/dts/aspeed-bmc-facebook-t

[PATCH v2 4/4] ARM: dts: aspeed: Add lpc ctrl for Facebook

2018-12-17 Thread Vijay Khemka
Added lpc ctrl device to enable LPC clock in Facebook Tiogapass device tree. Signed-off-by: Vijay Khemka --- .../boot/dts/aspeed-bmc-facebook-tiogapass.dts | 17 + 1 file changed, 17 insertions(+) diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts b/arch/arm/boot

[PATCH v2 1/4] ARM: dts: aspeed: Add sensors devices for Facebook

2018-12-17 Thread Vijay Khemka
Added ADC and other sensor devices in Facebook Tiogapass device tree. Signed-off-by: Vijay Khemka --- .../dts/aspeed-bmc-facebook-tiogapass.dts | 23 +-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/aspeed-bmc-facebook-tiogapass.dts b/arch

linux-next: Signed-off-by missing for commit in the printk tree

2018-12-17 Thread Stephen Rothwell
Hi Petr, Commit 503283fa006d ("printk: Add caller information to printk() output.") is missing a Signed-off-by from its committer. Moreover, that patch appears twice in the tree (the other time properly signed-off), -- Cheers, Stephen Rothwell pgpvJciYWjoZG.pgp Description: OpenPGP digita

Re: [WIP PATCH 01/15] drm/dp_mst: Remove bogus conditional in drm_dp_update_payload_part1()

2018-12-17 Thread Wentland, Harry
On 2018-12-14 3:42 a.m., Daniel Vetter wrote: > On Thu, Dec 13, 2018 at 08:25:30PM -0500, Lyude Paul wrote: >> There's no reason we need this, it's just confusing looking. >> >> Signed-off-by: Lyude Paul >> Cc: Juston Li >> --- >> drivers/gpu/drm/drm_dp_mst_topology.c | 4 +--- >> 1 file chang

Re: [PATCH v17 18/23] platform/x86: Intel SGX driver

2018-12-17 Thread Andy Lutomirski
On Mon, Dec 17, 2018 at 12:03 PM Dave Hansen wrote: > > On 12/17/18 11:55 AM, Andy Lutomirski wrote: > >> You're effectively rebuilding reverse-mapping infrastructure here. It's > >> a frequent thing for the core VM to need to go from 'struct page' back > >> to the page tables mapping it. For th

Re: [PATCH 4.4 00/88] 4.4.168-stable review

2018-12-17 Thread Guenter Roeck
On Mon, Dec 17, 2018 at 08:08:34PM +0100, Greg Kroah-Hartman wrote: > > > > v4.4.167-89-g9c558d7fe359 seemed to be happy. v4.4.167-89-g50a0280f2f7e > > replaced it and will take a while. > > If I read your site right, it passed everything except one qemu test? > Is that normal? > Kind of. I was

  1   2   3   4   5   6   7   8   9   10   >