[PATCH 2/5] drivers: staging: erofs: Fix comparison to NULL issues.

Fix of 7 `CHECK: Comparison to NULL could be written ...` issues. Signed-off-by: Aaron Strahlberger Signed-off-by: Julius Wiedmann Signed-off-by: Dominik Huber --- drivers/staging/erofs/data.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/drivers

[PATCH 0/5] drivers: staging: erofs: Fix styling issues

Fixed several styling issues and one error, reported by checkpatch.pl. Signed-off-by: Aaron Strahlberger Signed-off-by: Julius Wiedmann Signed-off-by: Dominik Huber Aaron Strahlberger (5): drivers: staging: erofs: Fix alignment. drivers: staging: erofs: Fix comparison to NULL issues. dri

[PATCH 4/5] drivers: staging: erofs: Fix parentheses error in macro

Fix of ERROR: Macros with complex values should be enclosed in parentheses from checkpatch.pl Signed-off-by: Aaron Strahlberger Signed-off-by: Julius Wiedmann Signed-off-by: Dominik Huber --- drivers/staging/erofs/erofs_fs.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 1/5] drivers: staging: erofs: Fix alignment.

Fix of 17 `CHECK: Alignment should match open parenthesis` checkpatch.pl issues. Signed-off-by: Aaron Strahlberger Signed-off-by: Julius Wiedmann Signed-off-by: Dominik Huber LocalWords: Alighnment --- drivers/staging/erofs/data.c | 42 ++-- drivers/staging/er

[PATCH 5/5] drivers: staging: erofs: Add blank line after function

Fix of checkpatch.pl issue: CHECK: Please use a blank line after ... declarations Signed-off-by: Aaron Strahlberger Signed-off-by: Julius Wiedmann Signed-off-by: Dominik Huber --- drivers/staging/erofs/erofs_fs.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/erofs/erofs_

Re: [PATCH] kasan: mark kasan_check_(read|write) as 'notrace'

On Tue, Dec 11, 2018 at 11:37 AM Anders Roxell wrote: > > When option CONFIG_KASAN is enabled toghether with ftrace, function > ftrace_graph_caller() gets in to a recursion, via functions > kasan_check_read() and kasan_check_write(). > > Breakpoint 2, ftrace_graph_caller () at > ../arch/arm64/ke

[PATCH 3/5] drivers: staging: erofs: Fix spelling issue

Changed "stoped" to "stopped". Signed-off-by: Aaron Strahlberger Signed-off-by: Julius Wiedmann Signed-off-by: Dominik Huber --- drivers/staging/erofs/dir.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/erofs/dir.c b/drivers/staging/erofs/dir.c index 4

Re: [PATCH 2/2] regulator: provide regulator_set_voltage_sel_regmap_step() helper

pon., 10 gru 2018 o 16:41 Mark Brown napisał(a): > > On Mon, Dec 10, 2018 at 04:10:24PM +0100, Bartosz Golaszewski wrote: > > > On some devices we need to manually ramp the regulators to desired > > voltage one step at a time. This patch adds a helper routine for > > regmap users that checks if th

Re: [PATCH v4 3/7] mips: rename macros and files from '64' to 'n64'

Hi Paul, > > My feeling has been n32 was invented at SGI as an afterthought, hence the > > choice of having ABI32 or ABI64 defined for the 32-bit (now o32) and the > > 64-bit (now n64) ABI respectively was reasonable. > > I'd agree if _MIPS_SIM were defined as _ABI32 for o32, but: > > $ mip

[PATCH 19/27] kconfig: use T_WORD instead of T_VARIABLE for variables

There is no grammatical ambiguity by using T_WORD for variables. The parser can distinguish variables from symbols from the context. Signed-off-by: Masahiro Yamada --- scripts/kconfig/zconf.l | 4 ++-- scripts/kconfig/zconf.y | 3 +-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git

[PATCH 27/27] kconfig: remove keyword lookup table entirely

Commit 7a88488bbc23 ("[PATCH] kconfig: use gperf for kconfig keywords") introduced gperf for the keyword lookup. Then, commit bb3290d91695 ("Remove gperf usage from toolchain") killed the gperf use. As a result, the linear keyword search was left. If we do not use gperf, there is no reason to hav

[PATCH 22/27] kconfig: ban the use of '.' and '/' in unquoted words

In my understanding, special characters such as '.' and '/' are supported in unquoted words to use bare file paths in the source statement. With all included file paths quoted in the previous commit, we can drop this. Signed-off-by: Masahiro Yamada --- scripts/kconfig/preprocess.c | 3 +-- scr

[PATCH 23/27] kconfig: refactor end token rules

T_ENDMENU, T_ENDCHOICE, T_ENDIF are the last users of kconf_id associated with yylval. Refactor them to not use it. Signed-off-by: Masahiro Yamada --- scripts/kconfig/zconf.y | 43 +++ 1 file changed, 15 insertions(+), 28 deletions(-) diff --git a/script

[PATCH 20/27] microblaze: surround string default in Kconfig with double quotes

I guess this is a constant value instead of a symbol. Signed-off-by: Masahiro Yamada --- I will apply this to my Kbuild tree because it is necessary for Kconfig clean-ups. arch/microblaze/Kconfig.platform | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/microblaze/Kcon

[PATCH 25/27] kconfig: switch to ASSIGN_VAL state in the second lexer

To simplify the generated lexer, switch to the ASSIGN_VAL state in the hand-made lexer. Signed-off-by: Masahiro Yamada --- scripts/kconfig/zconf.l | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/scripts/kconfig/zconf.l b/scripts/kconfig/zconf.l index c8823a4..d4

[PATCH 26/27] kconfig: update current_pos in the second lexer

To simplify the generated lexer, let the hand-made lexer update the file name and line number for the parser. I tested this with DEBUG_PARSE, and confirmed the same file names and line numbers were dumped. Signed-off-by: Masahiro Yamada --- scripts/kconfig/zconf.l | 20 +++- 1

[PATCH 24/27] kconfig: stop associating kconf_id with yylval

The lexer has conventionally associated kconf_id data with yylval to carry additional information to the parser. No token is relying on this any more. Signed-off-by: Masahiro Yamada --- scripts/kconfig/zconf.l | 2 -- scripts/kconfig/zconf.y | 41 - 2 f

[PATCH 02/27] kconfig: fix memory leak when EOF is encountered in quotation

An unterminated string literal followed by new line is passed to the parser (with "multi-line strings not supported" warning shown), then handled properly there. On the other hand, an unterminated string literal at end of file is never passed to the parser, then results in memory leak. [Test Code

[PATCH 09/27] kconfig: remove grammatically ambiguous "unexpected option" diagnostic

This commit decreases 15 shift/reduce conflicts. The location of this error recovery is ambiguous. For example, there are two ways to interpret the following code: 1 config FOO 2 bool "foo" [A] Both lines are reduced together into a config_stmt. [B] The only line 1 is reduced int

[PATCH 17/27] kconfig: refactor scanning and parsing "option" properties

For the keywords "modules", "defconfig_list", and "allnoconfig_y", the lexer should pass specific tokens instead of generic T_WORD. This simplifies both the lexer and the parser. Signed-off-by: Masahiro Yamada --- scripts/kconfig/kconf_id.c | 3 --- scripts/kconfig/lkc.h | 9 +++--

[PATCH 01/27] kconfig: fix file name and line number of warn_ignored_character()

Currently, warn_ignore_character() displays invalid file name and line number. The lexer should use current_file->name and yylineno, while the parser should use zconf_curname() and zconf_lineno(). This difference comes from that the lexer is always going ahead of the parser. The parser needs to l

[PATCH 10/27] kconfig: remove grammatically ambiguous option_error

This commit decreases 6 shift/reduce conflicts, and finally achieves conflict-free parser. Since Kconfig has no terminator for a config block, detecting the end of config_stmt is not easy. For example, there are two ways for handling the error in the following code: 1 config FOO 2 =

[PATCH 16/27] kconfig: use distinct tokens for type and default properties

This commit removes kconf_id::stype to prepare for the entire removal of kconf_id.c To simplify the lexer, I want keywords straight-mapped to tokens. Signed-off-by: Masahiro Yamada --- scripts/kconfig/kconf_id.c | 16 ++-- scripts/kconfig/lkc.h | 1 - scripts/kconfig/zconf.y|

[PATCH 06/27] kconfig: fix ambiguous grammar in terms of new lines

This commit decreases 8 shift/reduce conflicts. A certain amount of grammatical ambiguity comes from how to reduce excessive T_EOL tokens. Let's take a look at the example code below: 1 config A 2 bool "a" 3 4 depends on B 5 6 config B 7 def_bool y The

[PATCH 18/27] kconfig: use specific tokens instead of T_ASSIGN for assignments

Currently, the lexer returns T_ASSIGN for all of =, :=, and += associating yylval with the flavor. I want to make the generated lexer as simple as possible. So, the lexer should convert keywords to tokens without thinking about the meaning. = -> T_EQUAL := -> T_COLON_EQUAL += -> T_PL

[PATCH 13/27] kconfig: loosen the order of "visible" and "depends on" in menu entry

Currently, "visible" and "depends on", if defined in a menu entry, must appear in that order. The real example is in drivers/media/tuners/Kconfig: menu "Customize TV tuners" visible if depends on ... is fine, but you cannot change the property order like this: menu "Cu

[PATCH 03/27] kconfig: require T_EOL to reduce visible statement

All line-oriented statements should be reduced when seeing a T_EOL token. I guess missing T_EOL for the "visible" statement is just a mistake. This commit decreases one shift/reduce conflict. Signed-off-by: Masahiro Yamada --- scripts/kconfig/zconf.y | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH 21/27] treewide: surround file paths in Kconfig files with double quotes

The Kconfig lexer supports special characters such as '.' and '/' in the parameter context. In my understanding, the reason is just to support bare file paths in the source statement. I do not see a good reason to complicate Kconfig for the room of ambiguity. The majority of code already surround

[PATCH 14/27] kconfig: rename depends_list to comment_option_list

Now the comment_stmt is the only user of depends_list. Rename it to comment_option_list Signed-off-by: Masahiro Yamada --- scripts/kconfig/zconf.y | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/scripts/kconfig/zconf.y b/scripts/kconfig/zconf.y index 7cc8244..7a

[PATCH 05/27] kconfig: refactor pattern matching in STRING state

Here, similar matching patters are duplicated in order to look ahead the '\n' character. If the next character is '\n', the lexer returns T_WORD_QUOTE because it must be prepared to return T_EOL at the next match. Use unput('\n') trick to reduce the code duplication. Signed-off-by: Masahiro Yamad

[PATCH 15/27] kconfig: remove redundant token defines

These are already defined as %left. Signed-off-by: Masahiro Yamada --- scripts/kconfig/zconf.y | 5 - 1 file changed, 5 deletions(-) diff --git a/scripts/kconfig/zconf.y b/scripts/kconfig/zconf.y index 7a4bc58..020454b 100644 --- a/scripts/kconfig/zconf.y +++ b/scripts/kconfig/zconf.y @@ -

[PATCH 00/27] kconfig: remove all reduce/shift conflicts, refactor lexer, fix various issues

When I tryed to change something, I was often hit by annoying shift/reduce conflicts in the parser. The lexer and parser are too cluttered. So, I decided to clean-up now. - Fix all shift/reduce conflicts in the parser - Rewrite the lexer. The linear keyword search was removed. The num

[PATCH 08/27] kconfig: warn no new line at end of file

It would be nice to warn if a new line is missing at end of file. We could do this by checkpatch.pl for arbitrary files, but new line is rather essential as a statement terminator in Kconfig. The warning message looks like this: kernel/Kconfig.preempt:60:warning: no new line at end of file Cu

[PATCH 04/27] kconfig: remove unneeded pattern matching to whitespaces

Whitespaces are consumed in the COMMAND state anyway. Signed-off-by: Masahiro Yamada --- scripts/kconfig/zconf.l | 6 -- 1 file changed, 6 deletions(-) diff --git a/scripts/kconfig/zconf.l b/scripts/kconfig/zconf.l index c2f577d..709b774 100644 --- a/scripts/kconfig/zconf.l +++ b/scripts/k

[PATCH 12/27] kconfig: remove redundant menu_block rule

The code block surrounded by "menu" ... "endmenu" is stmt_list. Remove the redundant menu_block symbol entirely. Signed-off-by: Masahiro Yamada --- scripts/kconfig/zconf.y | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/scripts/kconfig/zconf.y b/scripts/kconfig/zcon

[PATCH 07/27] kconfig: clean up EOF handling in the lexer

A new file should always start in the INITIAL state. When the lexer bumps into EOF, the lexer must get back to the INITIAL state anyway. Remove the redundant <> pattern in the PARAM state. Signed-off-by: Masahiro Yamada --- scripts/kconfig/zconf.l | 5 ++--- 1 file changed, 2 insertions(+), 3

[PATCH 11/27] kconfig: remove redundant if_block rule

The code block surrounded by "if" ... "endif" is stmt_list. Remove the redundant if_block symbol entirely. Remove "stmt_list: stmt_list end" rule as well since it would obviously cause conflicts. Signed-off-by: Masahiro Yamada --- scripts/kconfig/zconf.y | 10 +- 1 file changed, 1 ins

Re: [PATCH 4/5] drivers: staging: erofs: Fix parentheses error in macro

Hi Aaron, On 2018/12/11 18:54, Aaron Strahlberger wrote: > Fix of ERROR: Macros with complex values should be enclosed in parentheses > from checkpatch.pl > > Signed-off-by: Aaron Strahlberger > Signed-off-by: Julius Wiedmann > Signed-off-by: Dominik Huber > --- > drivers/staging/erofs/erofs_

Re: [PATCH 10/10] perf/doc: update design.txt for exclude_{host|guest} flags

[ Reviving old thread. ] Andrew Murray writes: > On Tue, Nov 20, 2018 at 10:31:36PM +1100, Michael Ellerman wrote: >> Andrew Murray writes: >> >> > Update design.txt to reflect the presence of the exclude_host >> > and exclude_guest perf flags. >> > >> > Signed-off-by: Andrew Murray >> > --- >

[PATCH] srcu: Remove srcu_queue_delayed_work_on()

srcu_queue_delayed_work_on() disables preemption (and therefore CPU hotplug in RCU's case) and then checks based on its own accounting if a CPU is online. If the CPU is online it uses queue_delayed_work_on() otherwise it fallbacks to queue_delayed_work(). The problem here is that queue_work() on -R

Re: [tip:x86/pti] x86/speculation/l1tf: Drop the swap storage limit restriction when l1tf=off

On Tue 11-12-18 11:47:52, Thomas Gleixner wrote: > On Tue, 11 Dec 2018, Ingo Molnar wrote: > > >offDisables hypervisor mitigations and doesn't emit any > > > warnings. > > > + It also drops the swap size and available RAM limit restrictions > > > +o

Re: [PATCH v2] ksm: React on changing "sleep_millisecs" parameter faster

On Tue, Dec 11, 2018 at 01:26:59PM +0300, Kirill Tkhai wrote: > ksm thread unconditionally sleeps in ksm_scan_thread() > after each iteration: > > schedule_timeout_interruptible( > msecs_to_jiffies(ksm_thread_sleep_millisecs)) > > The timeout is configured in /sys/kernel/mm/ks

Re: [PATCH v3 7/8] platform/chrome: cros_ec_lightbar: instantiate only if the EC has a lightbar.

On 10/12/18 19:20, Guenter Roeck wrote: > On Tue, Nov 27, 2018 at 4:19 AM Enric Balletbo i Serra > wrote: >> >> Due to the way attribute groups visibility work, the function >> cros_ec_lightbar_attrs_are_visible is called multiple times, once per >> attribute, and each of these calls makes an E

[PATCH v2] Input: touchscreen: Fix ERROR: foo* bar should be "foo *bar"

This patch fixes the coding style problem reported by checkpatch.pl. Signed-off-by: Hardik Singh Rathore --- v2: - fix the pointer location style problem in drivers/input/touchscreen/* files leftover in previous patch. drivers/input/touchscreen/ektf2127.c | 2 +- drivers/input/touchscreen/gunze

Re: [PATCH 21/27] treewide: surround file paths in Kconfig files with double quotes

On Tue, Dec 11, 2018 at 08:01:04PM +0900, Masahiro Yamada wrote: > The Kconfig lexer supports special characters such as '.' and '/' in > the parameter context. In my understanding, the reason is just to > support bare file paths in the source statement. > > I do not see a good reason to complicat

Re: [PATCH 1/5] drivers: staging: erofs: Fix alignment.

Hi Aaron, On 2018/12/11 18:54, Aaron Strahlberger wrote: > Fix of 17 `CHECK: Alignment should match open parenthesis` checkpatch.pl > issues. > > Signed-off-by: Aaron Strahlberger > Signed-off-by: Julius Wiedmann > Signed-off-by: Dominik Huber > > LocalWords: Alighnment What's this? > ---

Re: [PATCH 2/5] drivers: staging: erofs: Fix comparison to NULL issues.

Hi Aaron, On 2018/12/11 18:54, Aaron Strahlberger wrote: > Fix of 7 `CHECK: Comparison to NULL could be written ...` issues. > > Signed-off-by: Aaron Strahlberger > Signed-off-by: Julius Wiedmann > Signed-off-by: Dominik Huber > --- > drivers/staging/erofs/data.c | 23 ---

[RFC PATCH v1 0/3] Enable CONFIG_VMAP_STACK on the 8xx

The purpose of this serie is to enable CONFIG_VMAP_STACK on the 8xx. I'm sending it now to get early feedback if any. For the time being, there is no proper handling of stack overflow. This serie applies on the top of the serie "powerpc: Switch to CONFIG_THREAD_INFO_IN_TASK" Christophe Leroy (3

[RFC PATCH v1 1/3] powerpc/32: prepare for CONFIG_VMAP_STACK

To support CONFIG_VMAP_STACK, the kernel must be able to activate Data MMU Translation for accessing the stack. Before doing that it must save SRR0, SRR1 and DAR in order to not loose them in case there is a Data TLB Miss once the translation is reactivated. This patch defines fields in the thread

[RFC PATCH v1 3/3] powerpc/8xx: Enable CONFIG_VMAP_STACK

This patch enables CONFIG_VMAP_STACK. For that, a few changes are done in head_8xx.S to re-activation DATA MMU Translation before accessing to the stack. Due to the growing of exception prolog, a few rearrangement is also done in a few exception handlers. Signed-off-by: Christophe Leroy --- arc

[PATCH v2 1/2] dt-bindings: input: Add Raspberry Pi Touchscreen

Adds device tree documentation for Raspberry Pi's official 7" touchscreen. This binding is meant to be used as an overlay. Signed-off-by: Nicolas Saenz Julienne --- .../touchscreen/raspberrypi,firmware-ts.txt | 26 +++ 1 file changed, 26 insertions(+) create mode 100644 Docu

[PATCH v2 0/2] input: driver for RPi's official 7" touchscreen

This small series adds support for Raspberry pi's 7" touchscreen. Which alongside with the backlight driver are the last devices needed to have a functional touchscreen upstream. With this setup the board's VC4 firmware takes care of communicating with the touch chip and provides data though a sha

[PATCH v2 2/2] input: add official Raspberry Pi's touchscreen driver

Add's support to Raspberry Pi's 7" Touch device. Instead of using a conventional bus all information is copied into a memory mapped area by RPi's firmware. Based on the driver found in RPi's kernel repository. Signed-off-by: Nicolas Saenz Julienne --- drivers/input/touchscreen/Kconfig

[RFC PATCH v1 2/3] powerpc/8xx: Use alternative scratch registers in DTLB miss handler

In preparation of handling CONFIG_VMAP_STACK, we need DTLB miss handler to use different scratch registers than other exception handlers in order to not jeopardise exception entry on stack DTLB misses. Signed-off-by: Christophe Leroy --- arch/powerpc/kernel/head_8xx.S | 27 ++

Re: [PATCH 21/27] treewide: surround file paths in Kconfig files with double quotes

On Tue, Dec 11, 2018 at 12:03 PM Masahiro Yamada wrote: > The Kconfig lexer supports special characters such as '.' and '/' in > the parameter context. In my understanding, the reason is just to > support bare file paths in the source statement. > > I do not see a good reason to complicate Kconfig

[PATCH 1/2] OPP: Use opp_table->regulators to verify no regulator case

The value of opp_table->regulator_count is not very consistent right now and it may end up being 0 while we do have a "opp-microvolt" property in the OPP table. It was kept that way as we used to check if any regulators are set with the OPP core for a device or not using value of regulator_count.

Re: [RFC PATCH] PM / OPP: Always expose one supply in debugfs

On 11-12-18, 09:49, Quentin Perret wrote: > So, on Juno we do get voltage numbers from firmware, and those get > registered properly in PM_OPP, exactly like for Hikey960. So it's > probably the same problem in both cases. > > FWIW, this is what I get on juno with my 'fix' applied: > > $ cat /sy

[PATCH 2/2] OPP: Fix missing debugfs supply directory for OPPs

There is one case where we may end up with no "supply" directory for the OPPs in debugfs. That happens when the OPP core isn't managing the regulators for the device and the device's OPP do have microvolt property. It happens because the opp_table->regulator_count remains set to 0 and the debugfs r

Re: [RFC PATCH v2 08/15] usb:cdns3: Implements device operations part of the API

On 10/12/18 7:42 AM, Peter Chen wrote: >>> +static struct usb_ep *cdns3_gadget_match_ep(struct usb_gadget *gadget, >>> + struct usb_endpoint_descriptor >>> *desc, >>> + struct usb_ss_ep_comp_descriptor >>> *comp_desc)

Re: [PATCH 3/5] drivers: staging: erofs: Fix spelling issue

On 2018/12/11 18:54, Aaron Strahlberger wrote: > Changed "stoped" to "stopped". > > Signed-off-by: Aaron Strahlberger > Signed-off-by: Julius Wiedmann > Signed-off-by: Dominik Huber A typo fix... I'm not a native English speaker, help me if it has more typo errors... Reviewed-by: Gao Xiang

Re: Can we drop upstream Linux x32 support?

On Tue, Dec 11, 2018 at 10:02:45AM +0100, Arnd Bergmann wrote: > On Tue, Dec 11, 2018 at 6:35 AM Andy Lutomirski wrote: > > I tried to understand what's going on. As far as I can tell, most of > > the magic is the fact that __kernel_long_t and __kernel_ulong_t are > > 64-bit as seen by x32 user c

Re: Can we drop upstream Linux x32 support?

* Catalin Marinas: > On Tue, Dec 11, 2018 at 10:02:45AM +0100, Arnd Bergmann wrote: >> On Tue, Dec 11, 2018 at 6:35 AM Andy Lutomirski wrote: >> > I tried to understand what's going on. As far as I can tell, most of >> > the magic is the fact that __kernel_long_t and __kernel_ulong_t are >> > 64

Re: Configure video PAL decoder into media pipeline

Hi Michael, On Mon, Dec 10, 2018 at 10:45:02PM +0100, Michael Nazzareno Trimarchi wrote: > Hi Jacopo > > Let's see what I have done > > On Sun, Dec 9, 2018 at 8:39 PM jacopo mondi wrote: > > > > Hi Michael, Jagan, Hans, > > > > On Sat, Dec 08, 2018 at 06:07:04PM +0100, Michael Nazzareno Trimarchi

Re: [PATCH v1 2/2] usb:cdns3 Add Cadence USB3 DRD Driver

Hi, Roger Quadros writes: >> This patch introduce new Cadence USBSS DRD driver >> to linux kernel. >> >> The Cadence USBSS DRD Driver is a highly >> configurable IP Core which can be >> instantiated as Dual-Role Device (DRD), >> Peripheral Only and Host Only (XHCI) >> configurations. >> >> The

RE: [PATCH 22/30] hwmon: (da9055-hwmon) Use permission specific SENSOR[_DEVICE]_ATTR variants

Hi Guenter, On 10 December 2018 22:09, Guenter Roeck wrote: > Subject: [PATCH 22/30] hwmon: (da9055-hwmon) Use permission specific > SENSOR[_DEVICE]_ATTR variants > > Use SENSOR[_DEVICE]_ATTR[_2]_{RO,RW,WO} to simplify the source code, > to improve readbility, and to reduce the chance of incons

RE: [PATCH 21/30] hwmon: (da9052-hwmon) Use permission specific SENSOR[_DEVICE]_ATTR variants

Hi Guenter, On 10 December 2018 22:09, Guenter Roeck wrote: > Subject: [PATCH 21/30] hwmon: (da9052-hwmon) Use permission specific > SENSOR[_DEVICE]_ATTR variants > > Use SENSOR[_DEVICE]_ATTR[_2]_{RO,RW,WO} to simplify the source code, > to improve readbility, and to reduce the chance of incons

[RFC/RFT][PATCH v8] cpuidle: New timer events oriented governor for tickless systems

From: Rafael J. Wysocki The venerable menu governor does some thigns that are quite questionable in my view. First, it includes timer wakeups in the pattern detection data and mixes them up with wakeups from other sources which in some cases causes it to expect what essentially would be a timer

Re: [PATCH] Input: touchscreen: ad7879: Fix ERROR: foo* bar should be "foo *bar"

Hi Joe, On Tue, 11 Dec 2018 at 01:07, Joe Perches wrote: > > On Mon, 2018-12-10 at 21:14 +0530, Hardik Singh Rathore wrote: > > Fix the coding style problem reported by checkpatch.pl. > > While whitespace only checkpatch cleanups are generally not > well accepted, why do one pointer location clea

Re: [PATCH] dma-debug: fix soft lockup when a lot of debug are enabled

Hi Anders, On 11/12/2018 10:36, Anders Roxell wrote: When running a kernel in qemu with enough debugging options (slub-debug, ftrace, kcov, kasan, ubsan, ...) enabled together, that results in a slow initcall. So a 'watchdog: BUG: soft lockup' happens: [ 44.105619] Call trace: [ 44.106709]

Re: Can we drop upstream Linux x32 support?

On Tue, Dec 11, 2018 at 12:37:42PM +0100, Florian Weimer wrote: > * Catalin Marinas: > > On Tue, Dec 11, 2018 at 10:02:45AM +0100, Arnd Bergmann wrote: > >> On Tue, Dec 11, 2018 at 6:35 AM Andy Lutomirski wrote: > >> > I tried to understand what's going on. As far as I can tell, most of > >> > th

Re: [PATCH v6 20/20] PM: Switch to use %ptR

On Tuesday, December 4, 2018 10:23:30 PM CET Andy Shevchenko wrote: > Use %ptR instead of open coded variant to print content of > struct rtc_time in human readable format. > > Cc: linux...@vger.kernel.org > Acked-by: Rafael J. Wysocki > Signed-off-by: Andy Shevchenko Do you want me to take thi

[PATCH 0/7] selftest/bpf fix PEP8 warnings

fixing PEP8 warning in the selftest bpf python files. Alice Ferrazzi (7): selftest/bpf: Fix trailing semicolon in the statement selftest/bpf: optimize import selftest/bpf: PEP 8: multiple statements on one line (colon) selftest/bpf: test_offload PEP8 format style fix selftest/bpf: Fix PE

[PATCH 1/7] selftest/bpf: Fix trailing semicolon in the statement

fix python PEP8 style issue Signed-off-by: Alice Ferrazzi --- tools/testing/selftests/bpf/tcp_client.py | 4 ++-- tools/testing/selftests/bpf/tcp_server.py | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tools/testing/selftests/bpf/tcp_client.py b/tools/testing/selftest

[PATCH 2/7] selftest/bpf: optimize import

Fix PEP8 warnings Signed-off-by: Alice Ferrazzi --- tools/testing/selftests/bpf/tcp_client.py | 7 +++ tools/testing/selftests/bpf/tcp_server.py | 7 --- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/tools/testing/selftests/bpf/tcp_client.py b/tools/testing/selftests/bp

[PATCH 7/7] selftest/bpf: fix E501 line too long

fix PEP8 style issues Signed-off-by: Alice Ferrazzi --- tools/testing/selftests/bpf/test_offload.py | 35 + 1 file changed, 22 insertions(+), 13 deletions(-) diff --git a/tools/testing/selftests/bpf/test_offload.py b/tools/testing/selftests/bpf/test_offload.py index b06cc0e

[PATCH 6/7] selftest/bpf: remove redundant parenthesis

Signed-off-by: Alice Ferrazzi --- tools/testing/selftests/bpf/test_offload.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/bpf/test_offload.py b/tools/testing/selftests/bpf/test_offload.py index 0f9130ebfd2c..b06cc0eea0eb 100755 --- a/tools/testing/

[PATCH 5/7] selftest/bpf: Fix PEP8 ambiguous variable name

Signed-off-by: Alice Ferrazzi --- tools/testing/selftests/bpf/test_offload.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/bpf/test_offload.py b/tools/testing/selftests/bpf/test_offload.py index f80c4f13991d..0f9130ebfd2c 100755 --- a/tools/test

[PATCH 3/7] selftest/bpf: PEP 8: multiple statements on one line (colon)

Reformat the file for fixing PEP 8 style Signed-off-by: Alice Ferrazzi --- tools/testing/selftests/bpf/tcp_client.py | 13 + tools/testing/selftests/bpf/tcp_server.py | 16 +++- 2 files changed, 20 insertions(+), 9 deletions(-) diff --git a/tools/testing/selftests/bpf/tc

Re: kvm: RDTSCP on AMD

On Tue, Dec 11, 2018 at 10:38:39AM +, Daniel P. Berrangé wrote: > On Mon, Dec 10, 2018 at 06:08:43PM -0200, Eduardo Habkost wrote: > > On Mon, Dec 10, 2018 at 08:42:58PM +0100, Borislav Petkov wrote: > > > On Mon, Dec 10, 2018 at 05:06:00PM -0200, Eduardo Habkost wrote: > > > > I mean documenti

[PATCH 4/7] selftest/bpf: test_offload PEP8 format style fix

Signed-off-by: Alice Ferrazzi --- tools/testing/selftests/bpf/test_offload.py | 68 - 1 file changed, 54 insertions(+), 14 deletions(-) diff --git a/tools/testing/selftests/bpf/test_offload.py b/tools/testing/selftests/bpf/test_offload.py index d59642e70f56..f80c4f13991d 100

Re: [PATCH] mmc: sdhci-omap: Workaround errata regarding SDR104/HS200 tuning failures (i929)

Hi, On 10/12/18 10:26 PM, Ulf Hansson wrote: > On Mon, 10 Dec 2018 at 17:43, Faiz Abbas wrote: >> >> Hi, >> >> On 10/12/18 8:55 PM, Ulf Hansson wrote: >>> On Mon, 10 Dec 2018 at 15:04, Faiz Abbas wrote: Hi, On 10/12/18 7:15 PM, Ulf Hansson wrote: > On Mon, 10 Dec 2018 at

Re: [PATCH] MAINTAINERS: add entry for i2c-axxia driver

Hi! On 11/12/2018 10:17, Adamski, Krzysztof (Nokia - PL/Wroclaw) wrote: > Create separate entry for i2c-axxia and set myself as maintainer. > > Even though I don't work for Intel/LSI who is the manufacturer of this > IP, I do have access to some documentation and the actual hardware using > this

Re: [PATCH 1/3] i2c-axxia: dedicated function to set client addr

Hi! On 10/12/2018 16:00, Adamski, Krzysztof (Nokia - PL/Wroclaw) wrote: > This patch moves configuration of hardware registers used for setting > i2c client address to separate function. It is preparatory change for > next commit. Reviewed-by: Alexander Sverdlin > Signed-off-by: Krzysztof Adams

Re: [PATCH v10 02/15] sched/cpufreq: Prepare schedutil for Energy Aware Scheduling

On Mon, Dec 3, 2018 at 10:56 AM Quentin Perret wrote: [cut] > #ifdef CONFIG_CPU_FREQ_GOV_SCHEDUTIL > +/** > + * enum schedutil_type - CPU utilization type > + * @FREQUENCY_UTIL:Utilization used to select frequency > + * @ENERGY_UTIL: Utilization used during energy calculation > + * >

[PATCH 3/4] kbuild: refactor part-of-module

Use $(foreach ...) to make it shorter. Signed-off-by: Masahiro Yamada --- scripts/Makefile.build | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/scripts/Makefile.build b/scripts/Makefile.build index f26ae45..321b5b7 100644 --- a/scripts/Makefile.build +++ b/scripts/M

[PATCH 4/4] kbuild: handle part-of-module correctly for *.ll and *.symtypes

The single targets *.ll and *.symtypes never treated as a module. Fix this. Signed-off-by: Masahiro Yamada --- scripts/Makefile.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/Makefile.build b/scripts/Makefile.build index 321b5b7..795fedc 100644 --- a/scripts/M

[PATCH 1/4] kbuild: remove redundant quiet_modtag for $(obj-m)

All objects in $(obj-m) are included in $(real-obj-m) as well. It is true composite objects are only contained in $(obj-m), but [M] is hard-coded in quiet_cmd_link_multi-m. This line is redundant. Signed-off-by: Masahiro Yamada --- scripts/Makefile.build | 2 -- 1 file changed, 2 deletions(-)

[PATCH 2/4] kbuild: refactor quiet_modtag

part-of-module and quiet_modtag are set for the same targets. Define quiet_modtag based on part-of-module. Signed-off-by: Masahiro Yamada --- scripts/Makefile.build | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/scripts/Makefile.build b/scripts/Makefile.build index 5a

Re: [PATCH 2/2] scsi: ufs: add inline crypto support to UFS HCD

On Tue, Dec 11, 2018 at 09:50:27AM +, Parshuram Thombare wrote: > Add real time crypto support to UFS HCD using new device > mapper 'crypto-ufs'. dmsetup tool can be used to enable > real time / inline crypto support using device mapper > 'crypt-ufs'. > > Signed-off-by: Parshuram Thombare As

Re: [PATCH 2/3] i2c-axxia: check for error conditions first

Hi! On 10/12/2018 16:01, Adamski, Krzysztof (Nokia - PL/Wroclaw) wrote: > It was observed that when using seqentional mode contrary to the ^^^ > documentation, the SS bit (which is supposed to only be set if > automatic/sequence command completed normally)

Re: [PATCH 3/3] i2c-axxia: support sequence command mode

Hi! On 10/12/2018 16:05, Adamski, Krzysztof (Nokia - PL/Wroclaw) wrote: > In order to comply with SMBus specification, the Axxia I²C module will > abort the multi message transfer if the delay between finishing sending > one message and starting another is longer than 25ms. Unfortunately it > isn'

Re: [PATCH] Revert "firmware: dmi_scan: Use lowercase letters for UUID"

> "Peter" == Peter Korsgaard writes: Hi Jean, >> Look, you can imagine that I was perfectly aware of what I was doing >> when I made that change, and that I pondered the decision carefully at >> that time. And my decision was that the change should be made. As far >> as I'm concerned, th

[PATCH] sparc: Set "ARCH: sunxx" information on the same line

While checking boot log from SPARC qemu, I saw that the "ARCH: sunxx" information was split on two different line. This patchs merge both line together. In the meantime, thoses information need to be printed via pr_info since printk print them by default via the warning loglevel. Signed-off-by: Co

Re: [PATCH v3] mmc: mediatek: Add MMC_CAP_SDIO_IRQ support

On Tue, 2018-12-11 at 17:29 +0800, Ulf Hansson wrote: > On Mon, 10 Dec 2018 at 12:44, Jjian Zhou wrote: > > > > From: jjian zhou > > > > This patch enables support SDIO IRQs. It enables > > MMC_CAP_SDIO_IRQ & MMC_CAP2_SDIO_IRQ_NOTHREAD > > and implement the ->ack_sdio_irq callback. > > > > Signed

Re: [PATCH v1 2/2] usb:cdns3 Add Cadence USB3 DRD Driver

Hi, Pawel Laszczak writes: > +static int cdns3_probe(struct platform_device *pdev) > +{ > + struct device *dev = &pdev->dev; > + struct resource *res; > + struct cdns3 *cdns; > + void __iomem *regs; > + int ret; > + > + cdns = devm_kzalloc(dev, sizeof(*cdns), GFP_KERNEL);

RE: [PATCH v1 2/2] usb:cdns3 Add Cadence USB3 DRD Driver

Hi, Pawel Laszczak writes: >>I think what Felipe meant was to only combine the gadget driver code into one >>patch. >> >>The series could be split into 6 patches like so. >>-dt binding >>-pci glue >>-core driver >>-host driver >>-gadget driver >>-drd driver > > Felipe wrote: > " > Frankly, I d

Re: [PATCH v10 02/15] sched/cpufreq: Prepare schedutil for Energy Aware Scheduling

Hi Rafael, On Tuesday 11 Dec 2018 at 13:01:24 (+0100), Rafael J. Wysocki wrote: > On Mon, Dec 3, 2018 at 10:56 AM Quentin Perret wrote: > > [cut] > > > #ifdef CONFIG_CPU_FREQ_GOV_SCHEDUTIL > > +/** > > + * enum schedutil_type - CPU utilization type > > + * @FREQUENCY_UTIL:Utilization used

[PATCH 6/9] iommu/mediatek: Use helper functions to access dev->iommu_fwspec

From: Joerg Roedel Use the new helpers dev_iommu_fwspec_get()/set() to access the dev->iommu_fwspec pointer. This makes it easier to move that pointer later into another struct. Cc: Matthias Brugger Signed-off-by: Joerg Roedel --- drivers/iommu/mtk_iommu.c| 21 - drive

[PATCH 3/9] iommu/arm-smmu: Use helper functions to access dev->iommu_fwspec

From: Joerg Roedel Use the new helpers dev_iommu_fwspec_get()/set() to access the dev->iommu_fwspec pointer. This makes it easier to move that pointer later into another struct. Cc: Will Deacon Cc: Robin Murphy Acked-by: Will Deacon Signed-off-by: Joerg Roedel --- drivers/iommu/arm-smmu-v3.

[PATCH 7/9] iommu/of: Use helper functions to access dev->iommu_fwspec

From: Joerg Roedel Use the new helpers dev_iommu_fwspec_get()/set() to access the dev->iommu_fwspec pointer. This makes it easier to move that pointer later into another struct. Signed-off-by: Joerg Roedel --- drivers/iommu/of_iommu.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletio

<    1   2   3   4   5   6   7   8   9   10   >