Re: [PATCH] nvme-rdma: complete requests from ->timeout

2018-12-07 Thread Jaesoo Lee
Now, I see that my patch is not safe and can cause double completions. However, I am having a hard time finding out a good solution to barrier the racing completions. Could you suggest where the fix should go and what should it look like? We can provide more details on reproducing this issue if th

Re: [PATCH v9 2/3] x86: add support for Huawei WMI hotkeys.

2018-12-07 Thread ayman . bagabas
On Fri, 2018-12-07 at 00:52 -0500, ayman.baga...@gmail.com wrote: On Mon, 2018-12-03 at 21:17 +0200, Andy Shevchenko wrote: > On Mon, Dec 3, 2018 at 9:04 PM Takashi Iwai wrote: > > On Mon, 03 Dec 2018 19:53:39 +0100, > > Ayman Bagabas wrote: > > > + if (code == 0x80) { > > > + acpi

Re: [PATCH 6/7] microblaze: fix race condition in building boot images

2018-12-07 Thread Masahiro Yamada
On Thu, Dec 6, 2018 at 1:32 AM Michal Simek wrote: > > On 03. 12. 18 8:50, Masahiro Yamada wrote: > > I fixed a race condition in the parallel building of ARM in commit > > 3939f3345050 ("ARM: 8418/1: add boot image dependencies to not > > generate invalid images"). > > > > I see the same problem

Re: [PATCH 1/5] kconfig: remove unneeded setsym label in conf_read_simple()

2018-12-07 Thread Masahiro Yamada
On Fri, Nov 30, 2018 at 6:17 PM Masahiro Yamada wrote: > > The two 'goto setsym' statements are reachable only when sym == NULL. > > The code below the 'setsym:' label does nothing when sym == NULL > since there is just one if-block guarded by 'if (sym && ...)'. > > Hence, 'goto setsym' can be rep

Re: [PATCH] kprobes: x86_64: blacklist non-attachable interrupt functions

2018-12-07 Thread Andrea Righi
On Sat, Dec 08, 2018 at 12:42:10PM +0900, Masami Hiramatsu wrote: > On Fri, 7 Dec 2018 18:00:26 +0100 > Andrea Righi wrote: > > > On Sat, Dec 08, 2018 at 01:01:20AM +0900, Masami Hiramatsu wrote: > > > Hi Andrea and Ingo, > > > > > > Here is the patch what I meant. I just ran it on qemu-x86, and

Re: [PATCH] kprobes: x86_64: blacklist non-attachable interrupt functions

2018-12-07 Thread Andrea Righi
On Sat, Dec 08, 2018 at 12:48:59PM +0900, Masami Hiramatsu wrote: > On Fri, 7 Dec 2018 18:58:05 +0100 > Andrea Righi wrote: > > > On Sat, Dec 08, 2018 at 01:01:20AM +0900, Masami Hiramatsu wrote: > > > Hi Andrea and Ingo, > > > > > > Here is the patch what I meant. I just ran it on qemu-x86, and

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2018-12-07 Thread Dan Williams
On Fri, Dec 7, 2018 at 4:53 PM John Hubbard wrote: > > On 12/7/18 11:16 AM, Jerome Glisse wrote: > > On Thu, Dec 06, 2018 at 06:45:49PM -0800, John Hubbard wrote: [..] > I see. OK, HMM has done an efficient job of mopping up unused fields, and now > we are > completely out of space. At this point

Re: [PATCH] leds: tlc591xx: fix device_node_continue.cocci warnings (fwd)

2018-12-07 Thread Julia Lawall
On Fri, 7 Dec 2018, Jacek Anaszewski wrote: > Hi Julia, > > Thank you for the patch, but it doesn't apply to LED tree. > > The patch causing the problem is out-of-LED-tree. OK, I guess that the patch is in a TI-specific tree, given the name. Thanks for looking into it. julia > > Best regard

Re: Process for severe early stable bugs?

2018-12-07 Thread Willy Tarreau
Hi Laura, On Fri, Dec 07, 2018 at 04:33:10PM -0800, Laura Abbott wrote: > The latest file system corruption issue (Nominally fixed by > ffe81d45322c ("blk-mq: fix corruption with direct issue") later > fixed by c616cbee97ae ("blk-mq: punt failed direct issue to dispatch > list")) brought a lot of

Re: [PATCH v5 2/3] iommu/io-pgtable-arm-v7s: Request DMA32 memory, and improve debugging

2018-12-07 Thread Matthew Wilcox
On Fri, Dec 07, 2018 at 02:16:19PM +0800, Nicolas Boichat wrote: > +#ifdef CONFIG_ZONE_DMA32 > +#define ARM_V7S_TABLE_GFP_DMA GFP_DMA32 > +#define ARM_V7S_TABLE_SLAB_CACHE SLAB_CACHE_DMA32 This name doesn't make any sense. Why not ARM_V7S_TABLE_SLAB_FLAGS ? > +#else > +#define ARM_V7S_TABLE_GFP_

Re: [Spice-devel] [PATCH 1/3] drm/qxl: allow both PRIV and VRAM placement for QXL_GEM_DOMAIN_SURFACE

2018-12-07 Thread Gerd Hoffmann
On Thu, Dec 06, 2018 at 09:39:54AM -0500, Frediano Ziglio wrote: > > > > On Thu, Dec 06, 2018 at 05:55:58AM -0500, Frediano Ziglio wrote: > > > > > > > qxl surfaces (used for framebuffers and gem objects) can live in both > > > > VRAM and PRIV ttm domains. Update placement setup to include both.

Re: [PATCH 1/8] clk: renesas: Remove usage of CLK_IS_BASIC

2018-12-07 Thread Geert Uytterhoeven
Hi Stephen, On Thu, Dec 6, 2018 at 10:59 PM Stephen Boyd wrote: > This flag doesn't look to be used by any code, just set in various clk > init structures and then never tested again. Remove it from these > drivers as it doesn't provide any benefit. > > Cc: Geert Uytterhoeven > Cc: > Signed-off

[PATCH] soc: fsl: guts: us devm_kstrdup_const() for RO data

2018-12-07 Thread Nicholas Mc Guire
forms") --- Problem located by experimental coccinelle script Patch was compile tested with: multi_v7_defconfig (implies FSL_GUTS=y) Patch is against 4.20-rc5 (localversion-next is next-20181207) drivers/soc/fsl/guts.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drive

Re: [PATCH] media: docs-rst: Document m2m stateless video decoder interface

2018-12-07 Thread Paul Kocialkowski
Hi, Thanks for this new version! I only have one comment left, see below. On Wed, 2018-12-05 at 19:01 +0900, Alexandre Courbot wrote: > Documents the protocol that user-space should follow when > communicating with stateless video decoders. > > The stateless video decoding API makes use of the n

[PATCH] net/mlx4_core: Correctly set PFC param if global pause is turned off.

2018-12-07 Thread Tarick Bedeir
rx_ppp and tx_ppp can be set between 0 and 255, so don't clamp to 1. Fixes: 6e8814ceb7e8 ("net/mlx4_en: Fix mixed PFC and Global pause user control requests") Signed-off-by: Tarick Bedeir --- drivers/net/ethernet/mellanox/mlx4/en_ethtool.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(

Re: [PATCH v4 0/5] powerpc: system call table generation support

2018-12-07 Thread Firoz Khan
Hi Satheesh, On Fri, 7 Dec 2018 at 12:57, Satheesh Rajendran wrote: > > On Fri, Dec 07, 2018 at 11:41:35AM +0530, Firoz Khan wrote: > Hi Firoz, > > This version(v4) booted fine in IBM Power8 box. Sounds good. Thanks for the support. Thanks Arnd for sharing the solution for "split compat syscall

Re: [PATCH v5 2/3] iommu/io-pgtable-arm-v7s: Request DMA32 memory, and improve debugging

2018-12-07 Thread Nicolas Boichat
On Fri, Dec 7, 2018 at 4:05 PM Matthew Wilcox wrote: > > On Fri, Dec 07, 2018 at 02:16:19PM +0800, Nicolas Boichat wrote: > > +#ifdef CONFIG_ZONE_DMA32 > > +#define ARM_V7S_TABLE_GFP_DMA GFP_DMA32 > > +#define ARM_V7S_TABLE_SLAB_CACHE SLAB_CACHE_DMA32 > > This name doesn't make any sense. Why not

[RFC 0/3] virtio_ring: define flags as shifts consistently

2018-12-07 Thread Tiwei Bie
This is a follow up of the discussion in this thread: https://patchwork.ozlabs.org/patch/1001015/#2042353 Tiwei Bie (3): virtio_ring: define flags as shifts consistently virtio_ring: add VIRTIO_RING_NO_LEGACY virtio_ring: use new vring flags drivers/virtio/virtio_ring.c | 100 +

[RFC 3/3] virtio_ring: use new vring flags

2018-12-07 Thread Tiwei Bie
Switch to using the _SPLIT_ and _PACKED_ variants of vring flags in split ring and packed ring respectively. Signed-off-by: Tiwei Bie --- drivers/virtio/virtio_ring.c | 100 +-- 1 file changed, 59 insertions(+), 41 deletions(-) diff --git a/drivers/virtio/virtio_

[RFC 2/3] virtio_ring: add VIRTIO_RING_NO_LEGACY

2018-12-07 Thread Tiwei Bie
Introduce VIRTIO_RING_NO_LEGACY to support disabling legacy macros and layout definitions. Suggested-by: Michael S. Tsirkin Signed-off-by: Tiwei Bie --- VRING_AVAIL_ALIGN_SIZE, VRING_USED_ALIGN_SIZE and VRING_DESC_ALIGN_SIZE are not pre-virtio 1.0, but can also be disabled by VIRTIO_RING_NO_LEGA

Re: [PATCH 1/6] media: v4l2-subdev: stub v4l2_subdev_get_try_format() ??

2018-12-07 Thread Hans Verkuil
On 12/06/2018 09:30 AM, jacopo mondi wrote: > Hi Lubomir, > > On Tue, Dec 04, 2018 at 04:01:43PM +0100, Lubomir Rintel wrote: >> On Mon, 2018-12-03 at 14:48 +0100, jacopo mondi wrote: >>> Hi Lubomir, >>> >>> thanks for the patches >>> >>> On Wed, Nov 28, 2018 at 06:19:13PM +0100, Lubomir Rintel

Re: [PATCH] usb: dwc2: Revert "usb: dwc2: Disable all EP's on disconnect"

2018-12-07 Thread Minas Harutyunyan
Hi Maynard, On 12/7/2018 3:09 AM, Maynard CABIENTE wrote: > Hi Minas, > > I tried your new patch on top of the other 2 patches for a couple of days now > and I do not see the issue that Marek encountered. Of course, I did not see > it also on the original two patches you created. I also do not

Re: [PATCH] usb: dwc2: Revert "usb: dwc2: Disable all EP's on disconnect"

2018-12-07 Thread Minas Harutyunyan
Hi Marek, On 12/6/2018 7:04 PM, Marek Szyprowski wrote: > Dear Minas, > > On 2018-12-04 13:34, Minas Harutyunyan wrote: >> On 11/23/2018 6:43 PM, Dan Carpenter wrote: >>> Ugh... We also had a long thread about the v2 patch but it turns out >>> the list was not CC'd. I should have checked for th

Re: [PATCH v2 0/9] phy: Add configuration interface for MIPI D-PHY devices

2018-12-07 Thread Maxime Ripard
On Fri, Dec 07, 2018 at 10:30:55AM +0530, Kishon Vijay Abraham I wrote: > Maxime, > > On 06/11/18 8:24 PM, Maxime Ripard wrote: > > Hi, > > > > Here is a set of patches to allow the phy framework consumers to test and > > apply runtime configurations. > > > > This is needed to support more phy c

Re: [PATCH v2 03/17] locking/lockdep: Add a new terminal lock type

2018-12-07 Thread Peter Zijlstra
On Mon, Nov 19, 2018 at 01:55:12PM -0500, Waiman Long wrote: > A terminal lock is a lock where further locking or unlocking on another > lock is not allowed. IOW, no forward dependency is permitted. > > With such a restriction in place, we don't really need to do a full > validation of the lock ch

Re: [PATCH v2 07/17] debugobjects: Move printk out of db lock critical sections

2018-12-07 Thread Peter Zijlstra
On Mon, Nov 19, 2018 at 01:55:16PM -0500, Waiman Long wrote: > The db->lock is a raw spinlock and so the lock hold time is supposed > to be short. This will not be the case when printk() is being involved > in some of the critical sections. In order to avoid the long hold time, > in case some messa

Re: [PATCH v2 08/17] locking/lockdep: Add support for nestable terminal locks

2018-12-07 Thread Peter Zijlstra
On Mon, Nov 19, 2018 at 01:55:17PM -0500, Waiman Long wrote: > There are use cases where we want to allow nesting of one terminal lock > underneath another terminal-like lock. That new lock type is called > nestable terminal lock which can optionally allow the acquisition of > no more than one regu

Re: [PATCH 1/1] iommu/arm-smmu: Add support to use Last level cache

2018-12-07 Thread Vivek Gautam
Hi Robin, On Tue, Dec 4, 2018 at 8:51 PM Robin Murphy wrote: > > On 04/12/2018 11:01, Vivek Gautam wrote: > > Qualcomm SoCs have an additional level of cache called as > > System cache, aka. Last level cache (LLC). This cache sits right > > before the DDR, and is tightly coupled with the memory c

Re: [PATCH 2/5] iommu/of: Use device_iommu_mapped()

2018-12-07 Thread Joerg Roedel
On Thu, Dec 06, 2018 at 05:42:16PM +, Robin Murphy wrote: > For sure - although I am now wondering whether "mapped" is perhaps a little > ambiguous in the naming, since the answer to "can I use the API" is yes even > when the device may currently be attached to an identity/passthrough domain >

Re: [PATCH v3] media: venus: add support for key frame

2018-12-07 Thread Stanimir Varbanov
Hi Hans, On 11/29/18 9:40 PM, Tomasz Figa wrote: > On Thu, Nov 29, 2018 at 3:10 AM wrote: >> >> >> Hi Stan, >> >> On 2018-11-29 16:01, Stanimir Varbanov wrote: >>> Hi Tomasz, >>> >>> On 11/3/18 5:01 AM, Tomasz Figa wrote: Hi Malathi, On Fri, Nov 2, 2018 at 9:58 PM Malathi Gottam >

RE: [Xen-devel] [PATCH 1/1] xen/blkback: rework connect_ring() to avoid inconsistent xenstore 'ring-page-order' set by malicious blkfront

2018-12-07 Thread Paul Durrant
> -Original Message- > From: Xen-devel [mailto:xen-devel-boun...@lists.xenproject.org] On Behalf > Of Dongli Zhang > Sent: 07 December 2018 04:18 > To: linux-kernel@vger.kernel.org; xen-de...@lists.xenproject.org; linux- > bl...@vger.kernel.org > Cc: ax...@kernel.dk; Roger Pau Monne ; > kon

Re: [f2fs-dev] [PATCH] f2fs: avoid frequent costly fsck triggers

2018-12-07 Thread Chao Yu
On 2018/12/1 4:28, Jaegeuk Kim wrote: > On 11/30, Chao Yu wrote: >> On 2018/11/30 10:35, Sheng Yong wrote: >>> Hi, Jaegeuk and Chao, >>> >>> On 2018/11/29 1:48, Jaegeuk Kim wrote: On 11/28, Chao Yu wrote: > On 2018/11/28 16:10, Jaegeuk Kim wrote: >> On 11/28, Chao Yu wrote: >>> Hi

Re: [PATCH net-next v2 1/4] indirect call wrappers: helpers to speed-up indirect calls of builtin

2018-12-07 Thread David Woodhouse
On Wed, 2018-12-05 at 19:13 +0100, Paolo Abeni wrote: > +/* > + * We can use INDIRECT_CALL_$NR for ipv6 related functions only if ipv6 is > + * builtin, this macro simplify dealing with indirect calls with only > ipv4/ipv6 > + * alternatives > + */ > +#if IS_BUILTIN(CONFIG_IPV6) > +#define INDIREC

Re: [PATCH v2] f2fs: fix sbi->extent_list corruption issue

2018-12-07 Thread Chao Yu
On 2018/12/1 4:33, Jaegeuk Kim wrote: > On 11/29, Sahitya Tummala wrote: >> >> On Tue, Nov 27, 2018 at 09:42:39AM +0800, Chao Yu wrote: >>> On 2018/11/27 8:30, Jaegeuk Kim wrote: On 11/26, Sahitya Tummala wrote: > When there is a failure in f2fs_fill_super() after/during > the recovery

Re: [PATCH v2 09/17] debugobjects: Make object hash locks nestable terminal locks

2018-12-07 Thread Peter Zijlstra
On Mon, Nov 19, 2018 at 01:55:18PM -0500, Waiman Long wrote: > By making the object hash locks nestable terminal locks, we can avoid > a bunch of unnecessary lockdep validations as well as saving space > in the lockdep tables. So the 'problem'; which you've again not explained; is that debugobject

Re: [PATCH] usb: dwc2: Revert "usb: dwc2: Disable all EP's on disconnect"

2018-12-07 Thread Felipe Balbi
Hi, Minas Harutyunyan writes: > Hi Marek, > > On 12/6/2018 7:04 PM, Marek Szyprowski wrote: >> Dear Minas, >> >> On 2018-12-04 13:34, Minas Harutyunyan wrote: >>> On 11/23/2018 6:43 PM, Dan Carpenter wrote: Ugh... We also had a long thread about the v2 patch but it turns out the l

Re: [PATCH v2 08/17] locking/lockdep: Add support for nestable terminal locks

2018-12-07 Thread Peter Zijlstra
On Fri, Dec 07, 2018 at 10:22:52AM +0100, Peter Zijlstra wrote: > On Mon, Nov 19, 2018 at 01:55:17PM -0500, Waiman Long wrote: > > There are use cases where we want to allow nesting of one terminal lock > > underneath another terminal-like lock. That new lock type is called > > nestable terminal lo

Re: [f2fs-dev] [PATCH] f2fs: add an ioctl() to explicitly trigger fsck later

2018-12-07 Thread Chao Yu
On 2018/12/1 4:36, Jaegeuk Kim wrote: > On 11/30, Chao Yu wrote: >> On 2018/11/29 9:52, Jaegeuk Kim wrote: >>> This adds an option in ioctl(F2FS_IOC_SHUTDOWN) in order to trigger fsck by >>> setting a NEED_FSCK flag. >>> >>> Signed-off-by: Jaegeuk Kim >>> --- >>> fs/f2fs/f2fs.h | 1 + >>> fs/f2fs

[PATCH 1/2] dt-bindings: Add Qualcomm USB Super-Speed PHY bindings

2018-12-07 Thread Jorge Ramirez-Ortiz
Binding description for Qualcomm's Synopsys 1.0.0 super-speed PHY controller embedded in QCS404. Based on Sriharsha Allenki's original definitions. Signed-off-by: Jorge Ramirez-Ortiz Reviewed-by: Vinod Koul --- .../devicetree/bindings/usb/qcom,usb-ssphy.txt | 78 ++ 1

[PATCH 2/2] phy: qualcomm: usb: Add Super-Speed PHY driver

2018-12-07 Thread Jorge Ramirez-Ortiz
From: Shawn Guo Driver to control the Synopsys SS PHY 1.0.0 implemeneted in QCS404 Based on Sriharsha Allenki's original code. Signed-off-by: Jorge Ramirez-Ortiz Signed-off-by: Shawn Guo Reviewed-by: Vinod Koul --- drivers/phy/qualcomm/Kconfig | 11 ++ drivers/phy/qualcomm/Makef

[PATCH 0/2] USB SS PHY for Qualcomm's QCS404

2018-12-07 Thread Jorge Ramirez-Ortiz
This set adds USB SS PHY support to Qualcomm's QCS404 SoC The PHY is implemented using Synopsys SS PHY 1.0.0 IP The code is based on Sriharsha Allenki's original implementation. Jorge Ramirez-Ortiz (1): dt-bindings: Add Qualcomm USB Super-Speed PHY bindings Shawn Guo (1): phy: qualcomm: usb

Re: [PATCH] usb: dwc2: Revert "usb: dwc2: Disable all EP's on disconnect"

2018-12-07 Thread Minas Harutyunyan
Hi Filipe, My patch dccf1bad4be7eaa096c1f3697bd37883f9a08ecb "usb: dwc2: Disable all EP's on disconnect" applied to 4.20-rc1. I need to update this patch. What I should do. There are 2 options: 1. Ack Marek Szyprowski [PATCH] usb: dwc2: Revert "usb: dwc2: Disable all EP's on disconnect" then

Re: [PATCH BUGFIX 0/2] bfq: fix unbalanced decrements causing loss of throughput

2018-12-07 Thread Paolo Valente
> Il giorno 7 dic 2018, alle ore 03:23, Jens Axboe ha scritto: > > On 12/6/18 11:18 AM, Paolo Valente wrote: >> Hi Jens, >> the first patch in this series fixes an error in the decrementing of >> the counter of the number of groups with pending I/O. This wrong >> decrement caused loss of throu

Re: [PATCH v2] media: Use of_node_name_eq for node name comparisons

2018-12-07 Thread Sylwester Nawrocki
On 12/6/18 20:35, Rob Herring wrote: > Convert string compares of DT node names to use of_node_name_eq helper > instead. This removes direct access to the node name pointer. > Reviewed-by: Laurent Pinchart > Reviewed-by: Benoit Parrot > Signed-off-by: Rob Herring > --- > v2: > - Also convert ta

Re: [PATCH v4 2/5] scsi: hisi_sas: Relocate some code to reduce complexity

2018-12-07 Thread John Garry
On 06/12/2018 16:20, Johannes Thumshirn wrote: On 06/12/2018 16:37, John Garry wrote: which is important. Let me know if you disagree and I can change it. Sure, it's your driver. It was just because the patch is even titled "Relocate some code to reduce complexity", so I thought of reducing th

Re: [PATCH 1/1] media: venus: core: Set dma maximum segment size

2018-12-07 Thread Stanimir Varbanov
Hi Vivek, Thanks for the patch! On 12/5/18 10:31 AM, Vivek Gautam wrote: > Turning on CONFIG_DMA_API_DEBUG_SG results in the following error: > > [ 460.308650] [ cut here ] > [ 460.313490] qcom-venus aa0.video-codec: DMA-API: mapping sg segment > longer than device

Re: [PATCH] usb: dwc2: Revert "usb: dwc2: Disable all EP's on disconnect"

2018-12-07 Thread Felipe Balbi
Hi, Minas Harutyunyan writes: > Hi Filipe, > > My patch dccf1bad4be7eaa096c1f3697bd37883f9a08ecb "usb: dwc2: Disable > all EP's on disconnect" applied to 4.20-rc1. > > I need to update this patch. What I should do. There are 2 options: > > 1. Ack Marek Szyprowski [PATCH] usb: dwc2: > Revert

Re: [PATCH v16 06/16] lib: fdt: add a helper function for handling memory range property

2018-12-07 Thread James Morse
Hi Akashi, Will, On 06/12/2018 15:54, Will Deacon wrote: > On Thu, Dec 06, 2018 at 08:47:04AM -0600, Rob Herring wrote: >> On Wed, Nov 14, 2018 at 11:52 PM AKASHI Takahiro >> wrote: >>> >>> Added function, fdt_setprop_reg(), will be used later to handle >>> kexec-specific property in arm64's kexe

[PATCH arm64/kexec] arm64: kexec_file: forbid kdump via kexec_file_load()

2018-12-07 Thread James Morse
Now that kexec_walk_memblock() can do the crash-kernel placement itself architectures that don't support kdump via kexe_file_load() need to explicitly forbid it. We don't support this on arm64 until the kernel can add the elfcorehdr and usable-memory-range fields to the DT. Without these the crash

Re: [PATCH] usb: dwc2: Revert "usb: dwc2: Disable all EP's on disconnect"

2018-12-07 Thread Dan Carpenter
On Wed, Dec 05, 2018 at 12:52:22PM +, Minas Harutyunyan wrote: > Hi, > > On 12/4/2018 5:29 PM, Dan Carpenter wrote: > > On Tue, Dec 04, 2018 at 12:34:08PM +, Minas Harutyunyan wrote: > >> @@ -3185,12 +3183,13 @@ void dwc2_hsotg_disconnect(struct dwc2_hsotg > >> *hsotg) > >> hsot

Re: [PATCH] Fix sync. in inode_has_no_xattr()

2018-12-07 Thread Alexander Lochmann
Am 05.12.18 um 16:32 schrieb Jan Kara: > > Thinking more about this I'm not sure if this is actually the right > solution. Because for example the write(2) can set S_NOSEC flag wrongly > when it would race with chmod adding SUID bit. So probably we rather need > to acquire i_rwsem in blkdev_write_

Re: [PATCH v8 0/7] KVM: x86: Allow Qemu/KVM to use PVH entry point

2018-12-07 Thread Borislav Petkov
On Thu, Dec 06, 2018 at 11:14:34PM +0100, Paolo Bonzini wrote: > > There are some minor changes in non-xen x86 code so it would be good to > > get x86 maintainers' ack. > > It's not really code, only Kconfig (and I remarked on it just now), but > it doesn't hurt of course. Yeah, I don't see anyth

Re: [PATCH] pseries/hotplug: Add more delay in pseries_cpu_die while waiting for rtas-stop

2018-12-07 Thread Gautham R Shenoy
Hi Thiago, On Thu, Dec 06, 2018 at 03:28:17PM -0200, Thiago Jung Bauermann wrote: [..snip..] > > > I posted a similar patch last year, but I wasn't able to arrive at a > root cause analysis like you did: > > https://lists.ozlabs.org/pipermail/linuxppc-dev/2017-February/153734.html Ah! Nice.

Re: [PATCH v4] media: vivid: Improve timestamping

2018-12-07 Thread Hans Verkuil
Hi Gabriel, On 12/02/2018 02:45 PM, Gabriel Francisco Mandaji wrote: > Simulate a more precise timestamp by calculating it based on the > current framerate. > > Signed-off-by: Gabriel Francisco Mandaji > --- > Changes in v2: > - fix spelling > - end of exposure is offset by 90% of the fr

Re: [RFC PATCH v2 2/2] mwifiex: add NL80211_STA_INFO_RX_BITRATE support

2018-12-07 Thread Kalle Valo
Brian Norris writes: > Comparing the existing TX_BITRATE parsing code (in > mwifiex_parse_htinfo()) with the RX bitrate histograms in debugfs.c, it > appears that the rxpd_rate and rxpd_htinfo fields have the same format. > At least, they give reasonable results when I parse them this way. > > So

Re: [PATCH v4 2/5] scsi: hisi_sas: Relocate some code to reduce complexity

2018-12-07 Thread Johannes Thumshirn
On 07/12/2018 11:07, John Garry wrote: > On 06/12/2018 16:20, Johannes Thumshirn wrote: >> On 06/12/2018 16:37, John Garry wrote: >>> which is important. Let me know if you disagree and I can change it. >> >> Sure, it's your driver. It was just because the patch is even titled >> "Relocate some cod

[PATCH v7 0/3] clk: clkdev add managed lookup registrations

2018-12-07 Thread Matti Vaittinen
Series adds managed clkdev lookup interfaces and cleans few drivers Few clk drivers appear to be leaking clkdev lookup registrations at driver remove. The patch series adds devm versions of lookup registrations and cleans up few drivers. Driver clean-up patches have not been tested as I lack the H

[PATCH v7 1/3] clkdev: add managed clkdev lookup registration

2018-12-07 Thread Matti Vaittinen
Clkdev registration lacks of managed registration functions and it seems few drivers do not drop clkdev lookups at exit. Add devm_clk_hw_register_clkdev and devm_clk_release_clkdev to ease lookup releasing at exit. Signed-off-by: Matti Vaittinen --- Documentation/driver-model/devres.txt | 1 +

[PATCH v7 2/3] clk: clk-max77686: Clean clkdev lookup leak and use devm

2018-12-07 Thread Matti Vaittinen
clk-max77686 never clean clkdev lookup at remove. This can cause oops if clk-max77686 is removed and inserted again. Fix leak by using new devm clkdev lookup registration. Simplify also error path by using new devm_of_clk_add_hw_provider. Signed-off-by: Matti Vaittinen Reviewed-by: Krzysztof Kozl

[PATCH v7 3/3] clk: clk-st: avoid clkdev lookup leak at remove

2018-12-07 Thread Matti Vaittinen
Use devm based clkdev lookup registration to avoid leaking lookup structures. Signed-off-by: Matti Vaittinen --- drivers/clk/x86/clk-st.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/clk/x86/clk-st.c b/drivers/clk/x86/clk-st.c index 3a0996f2d556..25d4b97aff9b 100

Re: [PATCH v4] powerpc/ptrace: replace ptrace_report_syscall() with a tracehook call

2018-12-07 Thread Michael Ellerman
"Dmitry V. Levin" writes: > On Mon, Dec 03, 2018 at 06:18:23AM +0300, Dmitry V. Levin wrote: >> From: Elvira Khabirova >> >> Arch code should use tracehook_*() helpers, as documented >> in include/linux/tracehook.h, >> ptrace_report_syscall() is not expected to be used outside that file. >> >>

[PATCH v3 2/2] dt-binding: spi: Document Renesas R-Car Gen3 RPC controller bindings

2018-12-07 Thread Mason Yang
Document the bindings used by the Renesas R-Car Gen3 RPC controller. Signed-off-by: Mason Yang --- .../devicetree/bindings/spi/spi-renesas-rpc.txt| 38 ++ 1 file changed, 38 insertions(+) create mode 100644 Documentation/devicetree/bindings/spi/spi-renesas-rpc.txt diff

[PATCH v3 0/2] spi: Add Renesas R-Car Gen3 RPC SPI driver

2018-12-07 Thread Mason Yang
Hi Mark, This Renesas R-Car Gen3 RPC SPI driver is based on Boris's new spi-mem direct mapping read/write mode [1][2]. v3 patch is according to Marek and Geert's comments including: 1) soc_device_mach() to set up RPC_PHYCNT_STRTIM. 2) get_unaligned() 3) rpc-mode for rpi-spi-flash or rpc-hyperflas

[PATCH v3 1/2] spi: Add Renesas R-Car Gen3 RPC SPI controller driver

2018-12-07 Thread Mason Yang
Add a driver for Renesas R-Car Gen3 RPC SPI controller. Signed-off-by: Mason Yang --- drivers/spi/Kconfig | 6 + drivers/spi/Makefile | 1 + drivers/spi/spi-renesas-rpc.c | 776 ++ 3 files changed, 783 insertions(+) create mode 1006

Re: [PATCH] Fix sync. in inode_has_no_xattr()

2018-12-07 Thread Jan Kara
On Fri 07-12-18 11:24:47, Alexander Lochmann wrote: > Am 05.12.18 um 16:32 schrieb Jan Kara: > > > > Thinking more about this I'm not sure if this is actually the right > > solution. Because for example the write(2) can set S_NOSEC flag wrongly > > when it would race with chmod adding SUID bit. So

Re: [PATCH v2 2/2] kgdb/treewide: constify struct kgdb_arch arch_kgdb_ops

2018-12-07 Thread Michael Ellerman
Christophe Leroy writes: > checkpatch.pl reports the following: > > WARNING: struct kgdb_arch should normally be const > #28: FILE: arch/mips/kernel/kgdb.c:397: > +struct kgdb_arch arch_kgdb_ops = { > > This report makes sense, as all other ops struct, this > one should also be const. This

Re: [PATCH] usb: dwc2: Revert "usb: dwc2: Disable all EP's on disconnect"

2018-12-07 Thread Minas Harutyunyan
Hi Dan, On 12/7/2018 2:16 PM, Dan Carpenter wrote: > On Wed, Dec 05, 2018 at 12:52:22PM +, Minas Harutyunyan wrote: >> Hi, >> >> On 12/4/2018 5:29 PM, Dan Carpenter wrote: >>> On Tue, Dec 04, 2018 at 12:34:08PM +, Minas Harutyunyan wrote: @@ -3185,12 +3183,13 @@ void dwc2_hsotg_discon

Re: [RESEND PATCH] efi: let kmemleak ignore false positives

2018-12-07 Thread Ard Biesheuvel
On Thu, 6 Dec 2018 at 19:05, Qian Cai wrote: > > On Thu, 2018-12-06 at 19:01 +0100, Ard Biesheuvel wrote: > > On Thu, 6 Dec 2018 at 19:00, Catalin Marinas > > wrote: > > > > > > On Thu, Dec 06, 2018 at 11:16:33AM -0500, Qian Cai wrote: > > > > unreferenced object 0x8096c1acf580 (size 128): >

Re: [RFC v3 11/19] kunit: add Python libraries for handing KUnit config and kernel

2018-12-07 Thread Kieran Bingham
Hi Matthew, On 06/12/2018 15:37, Matthew Wilcox wrote: > On Thu, Dec 06, 2018 at 12:32:47PM +, Kieran Bingham wrote: >> On 04/12/2018 20:47, Luis Chamberlain wrote: >>> On Mon, Dec 03, 2018 at 03:48:15PM -0800, Brendan Higgins wrote: On Thu, Nov 29, 2018 at 5:54 AM Kieran Bingham wr

Re: [PATCH 2/5] media: dt-bindings: Add binding for si470x radio

2018-12-07 Thread Paweł Chmiel
Dnia piątek, 7 grudnia 2018 12:33:10 CET Hans Verkuil pisze: > Please combine 2/5 with 5/5. No need to have two patches for these bindings. I though that it will be better to separate patches which just adds devicetree support and those adding new functionality (reset), so for example if there is

Re: [PATCH v2 30/34] dt-bindings: arm: Convert Tegra board/soc bindings to json-schema

2018-12-07 Thread Thierry Reding
On Thu, Dec 06, 2018 at 04:38:44PM -0600, Rob Herring wrote: > On Tue, Dec 4, 2018 at 2:50 AM Thierry Reding > wrote: > > > > On Mon, Dec 03, 2018 at 03:32:19PM -0600, Rob Herring wrote: > > > Convert Tegra SoC bindings to DT schema format using json-schema. > > > > > > Cc: Mark Rutland > > > Cc

Configure video PAL decoder into media pipeline

2018-12-07 Thread Jagan Teki
Hi, We have some unconventional setup for parallel CSI design where analog input data is converted into to digital composite using PAL decoder and it feed to adv7180, camera sensor. Analog input => Video PAL Decoder => ADV7180 => IPU-CSI0 The PAL decoder is I2C based, tda9885 chip. We setup it

Re: [EXT] Re: [RFC PATCH v2 2/2] mwifiex: add NL80211_STA_INFO_RX_BITRATE support

2018-12-07 Thread Ganapathi Bhat
Hi Kalle/Brian, >> RFC: I'd appreciate it if someone from Marvell could double check my work >> here. >BTW, if we don't hear anything from Marvell I'm going to apply these >anyway. This patch series looks good to us. Thanks, Ganapathi

[PATCH] cpuidle: Add 'above' and 'below' idle state metrics

2018-12-07 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Subject: [PATCH] cpuidle: Add 'above' and 'below' idle state metrics Add two new metrics for CPU idle states, "above" and "below", to count the number of times the given state had been asked for (or entered from the kernel's perspective), but the observed idle duration tur

Re: [PATCH] cpuidle: Add 'above' and 'below' idle state metrics

2018-12-07 Thread Quentin Perret
Hi Rafael, On Friday 07 Dec 2018 at 12:57:00 (+0100), Rafael J. Wysocki wrote: > --- linux-pm.orig/Documentation/ABI/testing/sysfs-devices-system-cpu > +++ linux-pm/Documentation/ABI/testing/sysfs-devices-system-cpu > @@ -145,6 +145,8 @@ What: /sys/devices/system/cpu/cpuX/cpui >

Re: [PATCH] pseries/hotplug: Add more delay in pseries_cpu_die while waiting for rtas-stop

2018-12-07 Thread Gautham R Shenoy
On Fri, Dec 07, 2018 at 04:13:11PM +0530, Gautham R Shenoy wrote: > Hi Thiago, > > > Sure. I will test the patch and report back. I added the following debug patch on top of your patch, and after an hour's run, the system crashed. Appending the log at the end. I suppose we still need to increas

Re: [PATCH v2 1/2] spi: Add Renesas R-Car Gen3 RPC SPI controller driver

2018-12-07 Thread Marek Vasut
On 12/07/2018 08:24 AM, masonccy...@mxic.com.tw wrote: > > Hi Marek, Hi, >> >> >> > + >> >> >> > +         regmap_write(rpc->regmap, RPC_SMWDR0, >> >> >> > +                 *(u32 *)(tx_buf + pos)); >> >> >> >> >> >> *(u32 *) cast is probably not needed , fix casts globally. >> >> > >> >> > It m

Re: Configure video PAL decoder into media pipeline

2018-12-07 Thread Hans Verkuil
On 12/07/2018 12:51 PM, Jagan Teki wrote: > Hi, > > We have some unconventional setup for parallel CSI design where analog > input data is converted into to digital composite using PAL decoder > and it feed to adv7180, camera sensor. > > Analog input => Video PAL Decoder => ADV7180 => IPU-CSI0

Re: [PATCH 01/34] powerpc: use mm zones more sensibly

2018-12-07 Thread Michael Ellerman
Christoph Hellwig writes: > Ben / Michael, > > can we get this one queued up for 4.21 to prepare for the DMA work later > on? I was hoping the PASEMI / NXP regressions could be solved before merging. My p5020ds is booting fine with this series, so I'm not sure why it's causing problems on Chris

Re: [PATCH 0/2] pinctrl: sunxi: a64: Drop numeral from csi0/ts0

2018-12-07 Thread Linus Walleij
On Mon, Dec 3, 2018 at 4:41 PM Chen-Yu Tsai wrote: > This small series renames the csi0 and ts0 pin function names to csi and > ts. This makes the names match the datasheet. As there are only one of > each type of controller, having a numeral suffix doesn't make sense. > > I'd like to do the rena

Re: [RESEND PATCH] efi: let kmemleak ignore false positives

2018-12-07 Thread Qian Cai
On 12/7/18 at 6:28 AM, Ard Biesheuvel wrote: > On Thu, 6 Dec 2018 at 19:05, Qian Cai wrote: > > > > On Thu, 2018-12-06 at 19:01 +0100, Ard Biesheuvel wrote: > > > On Thu, 6 Dec 2018 at 19:00, Catalin Marinas > > > wrote: > > > > > > > > On Thu, Dec 06, 2018 at 11:16:33AM -0500, Qian Cai wrote

Re: [PATCH] pinctrl: sunxi: a83t: Fix IRQ offset typo for PH11

2018-12-07 Thread Linus Walleij
On Tue, Dec 4, 2018 at 10:05 AM Chen-Yu Tsai wrote: > Pin PH11 is used on various A83T board to detect a change in the OTG > port's ID pin, as in when an OTG host cable is plugged in. > > The incorrect offset meant the gpiochip/irqchip was activating the wrong > pin for interrupts. > > Fixes: 473

Re: linux-next: build failure after merge of the drm-misc tree

2018-12-07 Thread Koenig, Christian
Hi Stephen, yeah, that is a known problem. I missed the change during rebase of the revert. Please see patch "2312f9842854 drm/v3d: fix broken build" which is already in drm-misc-next and fixes the issue. Christian. Am 06.12.18 um 03:32 schrieb Stephen Rothwell: > Hi all, > > After merging th

Re: [RESEND PATCH] efi: let kmemleak ignore false positives

2018-12-07 Thread Ard Biesheuvel
On Fri, 7 Dec 2018 at 13:32, Qian Cai wrote: > > > On 12/7/18 at 6:28 AM, Ard Biesheuvel wrote: > > > On Thu, 6 Dec 2018 at 19:05, Qian Cai wrote: > > > > > > On Thu, 2018-12-06 at 19:01 +0100, Ard Biesheuvel wrote: > > > > On Thu, 6 Dec 2018 at 19:00, Catalin Marinas > > > > wrote: > > > > > >

[PATCH 02/10] KVM: X86: Add arbitrary data pointer in kvm memslot iterator functions

2018-12-07 Thread Ahmed Abd El Mawgood
This will help sharing data into the slot_level_handler callback. In my case I need to a share a counter for the pages traversed to use it in some bitmap. Being able to send arbitrary memory pointer into the slot_level_handler callback made it easy. Signed-off-by: Ahmed Abd El Mawgood --- arch/x

[PATCH 01/10] KVM: State whether memory should be freed in kvm_free_memslot

2018-12-07 Thread Ahmed Abd El Mawgood
The conditions upon which kvm_free_memslot are kind of ad-hock, it will be hard to extend memslot with allocatable data that needs to be freed, so I replaced the current mechanism by clear flag that states if the memory slot should be freed. Signed-off-by: Ahmed Abd El Mawgood --- virt/kvm/kvm_m

[PATCH 05/10] KVM: Create architecture independent ROE skeleton

2018-12-07 Thread Ahmed Abd El Mawgood
This patch introduces a hypercall that can assist against subset of kernel rootkits, it works by place readonly protection in shadow PTE. The end result protection is also kept in a bitmap for each kvm_memory_slot and is used as reference when updating SPTEs. The whole goal is to protect the guest

[PATCH 04/10] KVM: Document Memory ROE

2018-12-07 Thread Ahmed Abd El Mawgood
ROE version documented here is implemented in the next 2 patches Signed-off-by: Ahmed Abd El Mawgood --- Documentation/virtual/kvm/hypercalls.txt | 40 1 file changed, 40 insertions(+) diff --git a/Documentation/virtual/kvm/hypercalls.txt b/Documentation/virtual/kvm/hyp

[PATCH V7 0/10] KVM: X86: Introducing ROE Protection Kernel Hardening

2018-12-07 Thread Ahmed Abd El Mawgood
-- Summary -- ROE is a hypercall that enables host operating system to restrict guest's access to its own memory. This will provide a hardening mechanism that can be used to stop rootkits from manipulating kernel static data structures and code. Once a memory region is protected the guest kernel c

[PATCH 06/10] KVM: X86: Enable ROE for x86

2018-12-07 Thread Ahmed Abd El Mawgood
This patch implements kvm_roe_arch_commit_protection and kvm_roe_arch_is_userspace for x86, and invoke kvm_roe via the appropriate vmcall. Signed-off-by: Ahmed Abd El Mawgood --- arch/x86/include/asm/kvm_host.h | 2 +- arch/x86/kvm/Makefile | 4 +- arch/x86/kvm/mmu.c |

[PATCH 03/10] KVM: X86: Add helper function to convert SPTE to GFN

2018-12-07 Thread Ahmed Abd El Mawgood
Signed-off-by: Ahmed Abd El Mawgood --- arch/x86/kvm/mmu.c | 7 +++ arch/x86/kvm/mmu.h | 1 + 2 files changed, 8 insertions(+) diff --git a/arch/x86/kvm/mmu.c b/arch/x86/kvm/mmu.c index b67d743c33..a300e4acb8 100644 --- a/arch/x86/kvm/mmu.c +++ b/arch/x86/kvm/mmu.c @@ -1024,6 +1024,13 @@ sta

[PATCH 08/10] KVM: X86: Port ROE_MPROTECT_CHUNK to x86

2018-12-07 Thread Ahmed Abd El Mawgood
Apply d->memslot->partial_roe_bitmap to shadow page table entries too. Signed-off-by: Ahmed Abd El Mawgood --- arch/x86/kvm/roe.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/arch/x86/kvm/roe.c b/arch/x86/kvm/roe.c index f787106be8..700f69823b 100644 --- a/arch/x86/kvm

[PATCH 07/10] KVM: Add support for byte granular memory ROE

2018-12-07 Thread Ahmed Abd El Mawgood
This patch documents and implements ROE_MPROTECT_CHUNK, a part of ROE hypercall designed to protect regions of a memory page with byte granularity. This feature provides a key primitive to protect against attacks involving pages remapping. Signed-off-by: Ahmed Abd El Mawgood --- include/linux/kv

[PATCH 10/10] KVM: Log ROE violations in system log

2018-12-07 Thread Ahmed Abd El Mawgood
Signed-off-by: Ahmed Abd El Mawgood --- virt/kvm/kvm_main.c| 5 + virt/kvm/roe.c | 14 ++ virt/kvm/roe_generic.h | 2 +- 3 files changed, 20 insertions(+), 1 deletion(-) diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index c3a21d3bc8..661933053f 100644 --- a

[PATCH 09/10] KVM: Add new exit reason For ROE violations

2018-12-07 Thread Ahmed Abd El Mawgood
The problem is that qemu will not be able to detect ROE violations, so one option would be create host API to tell if a given page is ROE protected, or create ROE violation exit reason. Signed-off-by: Ahmed Abd El Mawgood --- arch/x86/kvm/x86.c | 10 +- include/kvm/roe.h| 1

Re: [PATCH] cpuidle: Add 'above' and 'below' idle state metrics

2018-12-07 Thread Lorenzo Pieralisi
On Fri, Dec 07, 2018 at 12:57:00PM +0100, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > Subject: [PATCH] cpuidle: Add 'above' and 'below' idle state metrics > > Add two new metrics for CPU idle states, "above" and "below", to count > the number of times the given state had been asked for (

[PATCH] video: offb: Pass actual name in offb_init_palette_hacks

2018-12-07 Thread Mathieu Malaterre
This is a partial revert of commit 5c63e407aaab ("fbdev: Convert to using %pOFn instead of device_node.name"). This is the minimal work to get a Mac Mini G4 back to a bootable state. The function offb_init_palette_hacks would need to handle the case where `name` has been set to NULL. Cc: Rob Herri

Re: powerpc/mm: dump segment registers on book3s/32

2018-12-07 Thread Michael Ellerman
On Fri, 2018-11-16 at 17:06:43 UTC, Christophe Leroy wrote: > This patch creates a debugfs file to see content of > segment registers > > ~# cat /sys/kernel/debug/segment_registers > ---[ User Segments ]--- > 0x-0x0fff Kern key 1 User key 1 VSID 0xade2b0 > 0x1000-0x1fff Kern ke

Re: macintosh: Use device_type helpers to access the node type

2018-12-07 Thread Michael Ellerman
On Fri, 2018-11-16 at 22:11:01 UTC, Rob Herring wrote: > Remove directly accessing device_node.type pointer and use the accessors > instead. This will eventually allow removing the type pointer. > > Cc: Benjamin Herrenschmidt > Cc: linuxppc-...@lists.ozlabs.org > Signed-off-by: Rob Herring Appl

Re: [v9,01/20] powerpc/book3s32: Remove CONFIG_BOOKE dependent code

2018-12-07 Thread Michael Ellerman
On Thu, 2018-11-29 at 14:06:47 UTC, Christophe Leroy wrote: > BOOK3S/32 cannot be BOOKE, so remove useless code > > Signed-off-by: Christophe Leroy Series applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/a43ccc4bc499cb592e2cb3b4ada8d3 cheers

<    1   2   3   4   5   6   7   8   9   >