Re: [patch V2 18/28] x86/speculation: Prepare for per task indirect branch speculation control

2018-11-27 Thread Tim Chen
On 11/27/2018 09:25 AM, Lendacky, Thomas wrote: >> --- a/arch/x86/kernel/cpu/bugs.c >> +++ b/arch/x86/kernel/cpu/bugs.c >> @@ -148,6 +148,10 @@ x86_virt_spec_ctrl(u64 guest_spec_ctrl, >> static_cpu_has(X86_FEATURE_AMD_SSBD)) >> hostval |= ssbd_tif_to_spec_ctrl(

Re: [PATCH v2] x86: modernize sync_bitops.h

2018-11-27 Thread Sean Christopherson
On Wed, Nov 21, 2018 at 03:53:05PM +, David Laight wrote: > > > > -Original Message- > > From: Jan Beulich [mailto:jbeul...@suse.com] > > Sent: 21 November 2018 14:42 > > To: David Laight > > Cc: mi...@elte.hu; t...@linutronix.de; Boris Ostrovsky; Juergen Gross; > > linux-kernel@vger

overlayfs access checks on underlying layers

2018-11-27 Thread Miklos Szeredi
Moving discussion from github[1] to here. To summarize: commit 007ea44892e6 ("ovl: relax permission checking on underlying layers") was added in 4.20-rc1 to make overlayfs access checks on underlying "real" filesystems more consistent. The discussion leading up to this commit can be found at [2].

Re: [PATCH RESEND] tty/sysrq: Do not call sync directly from sysrq_do_reset()

2018-11-27 Thread Mark Tomlinson
On 27/11/18 11:11 PM, Greg KH wrote: > On Tue, Nov 27, 2018 at 09:57:23AM +1300, Mark Tomlinson wrote: >> sysrq_do_reset() is called in softirq context, so it cannot call >> sync() directly. Instead, call orderly_reboot(), which creates a work >> item to run /sbin/reboot, or do emergency_sync and

Re: overlayfs access checks on underlying layers

2018-11-27 Thread Miklos Szeredi
[resending with fixed email address for Paul Moore] Moving discussion from github[1] to here. To summarize: commit 007ea44892e6 ("ovl: relax permission checking on underlying layers") was added in 4.20-rc1 to make overlayfs access checks on underlying "real" filesystems more consistent. The disc

Re: [PATCH] tracing: Fix an off by one in __next()

2018-11-27 Thread Dan Carpenter
On Tue, Nov 27, 2018 at 01:44:12PM -0500, Steven Rostedt wrote: > > Doing the sweep of my INBOX, I came across this patch (it was sent > while I was in the Alps :-) > > > On Wed, 20 Jun 2018 14:08:00 +0300 > Dan Carpenter wrote: > > > The > should be >= to prevent an off by one bug. > > Well,

Re: [RFC PATCH] smack: fix access permissions for keyring

2018-11-27 Thread Casey Schaufler
On 10/17/2018 4:25 PM, Zoran Markovic wrote: > Function smack_key_permission() only issues smack requests for the > following operations: > - KEY_NEED_READ (issues MAY_READ) > - KEY_NEED_WRITE (issues MAY_WRITE) > - KEY_NEED_LINK (issues MAY_WRITE) > - KEY_NEED_SETATTR (issues MAY_WRITE) > A bl

Re: [patch V2 24/28] x86/speculation: Prepare arch_smt_update() for PRCTL mode

2018-11-27 Thread Lendacky, Thomas
On 11/25/2018 12:33 PM, Thomas Gleixner wrote: > The upcoming fine grained per task STIBP control needs to be updated on CPU > hotplug as well. > > Split out the code which controls the strict mode so the prctl control code > can be added later. Mark the SMP function call argument __unused while a

Re: [RFC PATCH v4 11/13] mm: parallelize deferred struct page initialization within each node

2018-11-27 Thread Daniel Jordan
On Tue, Nov 27, 2018 at 12:12:28AM +, Elliott, Robert (Persistent Memory) wrote: > I ran a short test with: > * HPE ProLiant DL360 Gen9 system > * Intel Xeon E5-2699 CPU with 18 physical cores (0-17) and > 18 hyperthreaded cores (36-53) > * DDR4 NVDIMM-Ns (which run at regular DRAM DIMM spe

Re: [Bug] SD card reader in Acer Aspire S5 broken in 4.20-rc

2018-11-27 Thread Bjorn Helgaas
On Mon, Nov 26, 2018 at 11:37:20PM +0100, Rafael J. Wysocki wrote: > On Monday, November 26, 2018 7:03:58 PM CET Rafael J. Wysocki wrote: > > Hi Bjorn, > > > > The SD card reader in my Acer Aspire S5 doesn't work with 4.20-rc. > > > > Here's what lspci -v says about it (in a bad kernel): > > > >

Re: [RFC PATCH 0/1] support ftrace and -ffunction-sections

2018-11-27 Thread Joe Lawrence
On 11/20/2018 03:19 PM, Joe Lawrence wrote: > Hi Steve, > > I noticed that ftrace does not currently support functions built with > the -ffunction-sections option as they end up in .text. > ELF sections, never making into the __mcount_loc section. > > I modified the recordmcount scripts to handle

Re: [patch V2 24/28] x86/speculation: Prepare arch_smt_update() for PRCTL mode

2018-11-27 Thread Thomas Gleixner
On Tue, 27 Nov 2018, Lendacky, Thomas wrote: > On 11/25/2018 12:33 PM, Thomas Gleixner wrote: > > +/* Update x86_spec_ctrl_base in case SMT state changed. */ > > +static void update_stibp_strict(void) > > { > > - wrmsrl(MSR_IA32_SPEC_CTRL, x86_spec_ctrl_base); > > + u64 mask = x86_spec_ctrl_ba

Re: [PATCH v2] mm/zsmalloc.c: Fix zsmalloc 32-bit PAE support

2018-11-27 Thread Rafael David Tinoco
On 11/20/18 10:18 PM, Rafael David Tinoco wrote: > > Russell, > > I have tried to place MAX_POSSIBLE_PHYSMEM_BITS in the best available > header for each architecture, considering different paging levels, PAE > existence, and existing similar definitions. Also, I have only > considered those arch

linux-next: Signed-off-by missing for commit in the kselftest tree

2018-11-27 Thread Stephen Rothwell
Hi Shuah, Commit 623ea0df7083 ("selftests: firmware: remove use of non-standard diff -Z option") is missing a Signed-off-by from its author. -- Cheers, Stephen Rothwell pgp7ZaLoM8wMr.pgp Description: OpenPGP digital signature

Re: [PATCH v2 03/11] clk: mediatek: Disable tuner_en before change PLL rate

2018-11-27 Thread Sean Wang
Weiyi Lu 於 2018年11月26日 週一 下午7:45寫道: > > From: Owen Chen > > PLLs with tuner_en bit, such as APLL1, need to disable > tuner_en before apply new frequency settings, or the new frequency > settings (pcw) will not be applied. > The tuner_en bit will be disabled during changing PLL rate > and be resto

Re: [Xen-devel] [PATCH] pvcalls-front: fixes incorrect error handling

2018-11-27 Thread Stefano Stabellini
On Tue, 27 Nov 2018, PanBian wrote: > On Mon, Nov 26, 2018 at 03:31:39PM -0500, Boris Ostrovsky wrote: > > On 11/21/18 9:07 PM, Pan Bian wrote: > > > kfree() is incorrectly used to release the pages allocated by > > > __get_free_page() and __get_free_pages(). Use the matching deallocators > > > i.e

Re: [PATCH 04/24] dt-bindings: leds: Add function and color properties

2018-11-27 Thread Jacek Anaszewski
On 11/13/2018 09:57 PM, Jacek Anaszewski wrote: > On 11/12/2018 07:27 PM, Rob Herring wrote: >> On Tue, Nov 06, 2018 at 11:07:12PM +0100, Jacek Anaszewski wrote: >>> Introduce dedicated properties for conveying information about >>> LED function and color. Mark old "label" property as deprecated. >

Re: [PATCH V2] gpio: mt7621: pass mediatek_gpio_bank_probe() failure up the stack

2018-11-27 Thread Sean Wang
Nicholas Mc Guire 於 2018年11月27日 週二 上午9:07寫道: > > The error cases of mediatek_gpio_bank_probe() would go unnoticed (except > for the dev_err() messages). The probe function should return an error > if one of the banks failed to initialize properly indicated by > not returning non-0. > > Signed-off-

[PATCH 2/2] drm/vkms: Add PRIME support by converting to Noralf's shmem helpers.

2018-11-27 Thread Eric Anholt
This cuts out a tremendous amount of boilerplate. I've used the PRIME support now to test V3D rendering on a STB development board with no KMS driver. v2: Use the DEFINE_DRM_GEM_SHMEM_FOPS for proper mmap setup. Signed-off-by: Eric Anholt Acked-by: Daniel Vetter (v1) --- drivers/gpu/drm/Kconf

Re: [PATCH v2 2/2] swiotlb: Skip cache maintenance on map error

2018-11-27 Thread Stefano Stabellini
On Wed, 21 Nov 2018, Robin Murphy wrote: > If swiotlb_bounce_page() failed, calling arch_sync_dma_for_device() may > lead to such delights as performing cache maintenance on whatever > address phys_to_virt(SWIOTLB_MAP_ERROR) looks like, which is typically > outside the kernel memory map and goes ab

Re: [patch V2 18/28] x86/speculation: Prepare for per task indirect branch speculation control

2018-11-27 Thread Thomas Gleixner
On Tue, 27 Nov 2018, Lendacky, Thomas wrote: > On 11/25/2018 12:33 PM, Thomas Gleixner wrote: > > --- a/arch/x86/kernel/process.c > > +++ b/arch/x86/kernel/process.c > > @@ -406,6 +406,11 @@ static __always_inline void spec_ctrl_up > > if (static_cpu_has(X86_FEATURE_SSBD)) > > msr |

Re: [patch V2 18/28] x86/speculation: Prepare for per task indirect branch speculation control

2018-11-27 Thread Thomas Gleixner
On Tue, 27 Nov 2018, Thomas Gleixner wrote: > On Tue, 27 Nov 2018, Lendacky, Thomas wrote: > > On 11/25/2018 12:33 PM, Thomas Gleixner wrote: > > > --- a/arch/x86/kernel/process.c > > > +++ b/arch/x86/kernel/process.c > > > @@ -406,6 +406,11 @@ static __always_inline void spec_ctrl_up > > > if (s

Re: [PATCH] arm: always update thread_info->syscall

2018-11-27 Thread Rafael David Tinoco
On 11/27/18 1:35 PM, Russell King - ARM Linux wrote: > On x86 (32-bit app on 64-bit kernel), it has this behaviour: > > $ ./syscall-test > 162 0xffcc5a6c 0xffcc5a6c 0x48d09000 0x0 0xffcc5af4 0xffcc5a74 0xffcc5a2c > 0xf77dfa59 > 162 0xffcc5a6c 0xffcc5a6c 0x48d09000 0x0 0xffcc5af4 0xffcc5a74 0xffcc

Re: [LKP] [mm] ac5b2c1891: vm-scalability.throughput -61.3% regression

2018-11-27 Thread Andrea Arcangeli
Hi Linus, On Tue, Nov 27, 2018 at 09:08:50AM -0800, Linus Torvalds wrote: > On Mon, Nov 26, 2018 at 10:24 PM kernel test robot > wrote: > > > > FYI, we noticed a -61.3% regression of vm-scalability.throughput due > > to commit ac5b2c18911f ("mm: thp: relax __GFP_THISNODE for > > MADV_HUGEPAGE map

[PATCH 1/2] staging: emxx_udc: Align parameter with parenthesis

2018-11-27 Thread Cristian Sicilia
Align parameters with parenthesis and removed open parenthesis at the end of line. Signed-off-by: Cristian Sicilia --- drivers/staging/emxx_udc/emxx_udc.c | 270 ++-- 1 file changed, 107 insertions(+), 163 deletions(-) diff --git a/drivers/staging/emxx_udc/emxx_

[PATCH 2/2] staging: emxx_udc: Remove cast and move all in one line.

2018-11-27 Thread Cristian Sicilia
Remove the cast from IO_ADDRESS and use a single line. Signed-off-by: Cristian Sicilia --- As suggested by Dan we can just remove the cast and use an unique line. drivers/staging/emxx_udc/emxx_udc.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/staging

[PATCH 0/2] Parenthesis fix

2018-11-27 Thread Cristian Sicilia
In the first patch there is a fix of some parenthesis that terminate on end of line and some parameters that are not aligned with previous parenthesis. The second patch is a proposal that avoid the long line refactoring code removing cast pointer. Cristian Sicilia (2): staging: emxx_udc: Align

Re: NFSd: NULL-dereference when writing to v4_end_grace when server is not yet started

2018-11-27 Thread J. Bruce Fields
On Sun, Nov 25, 2018 at 09:17:10AM +0300, Anatoly Trosinenko wrote: > When manually exploring the kernel NFSd feature, I have stumbled upon > a NULL-dereference when writing to v4_end_grace when server is not yet > started. Thanks for the report! I think this is what we want--it's what a lot of t

[PATCH] Revert "xen/balloon: Mark unallocated host memory as UNUSABLE"

2018-11-27 Thread Igor Druzhinin
This reverts commit b3cf8528bb21febb650a7ecbf080d0647be40b9f. That commit unintentionally broke Xen balloon memory hotplug with "hotplug_unpopulated" set to 1. As long as "System RAM" resource got assigned under a new "Unusable memory" resource in IO/Mem tree any attempt to online this memory woul

Re: [Xen-devel] [PATCH] pvcalls-front: fixes incorrect error handling

2018-11-27 Thread Boris Ostrovsky
On 11/27/18 3:37 PM, Stefano Stabellini wrote: > On Tue, 27 Nov 2018, PanBian wrote: >> On Mon, Nov 26, 2018 at 03:31:39PM -0500, Boris Ostrovsky wrote: >>> On 11/21/18 9:07 PM, Pan Bian wrote: kfree() is incorrectly used to release the pages allocated by __get_free_page() and __get_free_

[PATCH] x86/umip: Print UMIP line only once

2018-11-27 Thread Borislav Petkov
From: Borislav Petkov ... instead of issuing it per CPU and flooding dmesg unnecessarily. Signed-off-by: Borislav Petkov Cc: "H. Peter Anvin" Cc: Ingo Molnar Cc: Ricardo Neri Cc: Thomas Gleixner --- arch/x86/kernel/cpu/common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --

Re: [PATCH 3/3] PCI: imx: Add support for i.MX8MQ

2018-11-27 Thread Andrey Smirnov
On Tue, Nov 27, 2018 at 2:16 AM Leonard Crestez wrote: > > On 11/26/18 8:24 PM, Andrey Smirnov wrote: > > On Tue, Nov 20, 2018 at 2:49 AM Leonard Crestez > > wrote: > >> On Sat, 2018-11-17 at 10:12 -0800, Andrey Smirnov wrote: > > >>> + if (of_property_read_u32_array( > >>> +

Re: overlayfs access checks on underlying layers

2018-11-27 Thread Vivek Goyal
On Tue, Nov 27, 2018 at 08:58:06PM +0100, Miklos Szeredi wrote: > [resending with fixed email address for Paul Moore] > > Moving discussion from github[1] to here. > > To summarize: commit 007ea44892e6 ("ovl: relax permission checking on > underlying layers") was added in 4.20-rc1 to make overlay

Re: [PATCHi v2] mm: put_and_wait_on_page_locked() while page is migrated

2018-11-27 Thread Hugh Dickins
On Tue, 27 Nov 2018, Mike Rapoport wrote: > On Mon, Nov 26, 2018 at 11:27:07AM -0800, Hugh Dickins wrote: > > > > +/* > > + * A choice of three behaviors for wait_on_page_bit_common(): > > + */ > > +enum behavior { > > + EXCLUSIVE, /* Hold ref to page and take the bit when woken, like > > +

Re: [Xen-devel] [PATCH] pvcalls-front: fixes incorrect error handling

2018-11-27 Thread Stefano Stabellini
On Tue, 27 Nov 2018, Boris Ostrovsky wrote: > On 11/27/18 3:37 PM, Stefano Stabellini wrote: > > On Tue, 27 Nov 2018, PanBian wrote: > >> On Mon, Nov 26, 2018 at 03:31:39PM -0500, Boris Ostrovsky wrote: > >>> On 11/21/18 9:07 PM, Pan Bian wrote: > kfree() is incorrectly used to release the pag

[GIT PULL 3/4] bcm2835-drivers-next-2018-11-27

2018-11-27 Thread Eric Anholt
Hi Florian, The following changes since commit 651022382c7f8da46cb4872a545ee1da6d097d2a: Linux 4.20-rc1 (2018-11-04 15:37:52 -0800) are available in the Git repository at: git://github.com/anholt/linux tags/bcm2835-drivers-next-2018-11-27 for you to fetch changes up to 502b431cda801645fd73

[GIT PULL 2/4] bcm2835-soc-next-2018-11-27

2018-11-27 Thread Eric Anholt
Hi Florian, The following changes since commit 651022382c7f8da46cb4872a545ee1da6d097d2a: Linux 4.20-rc1 (2018-11-04 15:37:52 -0800) are available in the Git repository at: git://github.com/anholt/linux tags/bcm2835-soc-next-2018-11-27 for you to fetch changes up to 7b369a42e6d06c59fc56a176

[GIT PULL 4/4] bcm2835-dt-next-2018-11-27

2018-11-27 Thread Eric Anholt
Hi Florian, The following changes since commit 651022382c7f8da46cb4872a545ee1da6d097d2a: Linux 4.20-rc1 (2018-11-04 15:37:52 -0800) are available in the Git repository at: git://github.com/anholt/linux tags/bcm2835-dt-next-2018-11-27 for you to fetch changes up to 703c605fac82d580822dc39f5

[GIT PULL 1/4] bcm2835-defconfig-next-2018-11-27

2018-11-27 Thread Eric Anholt
Hi Florian, Hopefully I'm not too late this time around. Stefan's been doing a great job maintaining the bcm2835 branches, and was waiting for me to send the PRs. The following changes since commit 651022382c7f8da46cb4872a545ee1da6d097d2a: Linux 4.20-rc1 (2018-11-04 15:37:52 -0800) are avail

Re: [PATCH 3/3] PCI: imx: Add support for i.MX8MQ

2018-11-27 Thread Andrey Smirnov
On Tue, Nov 27, 2018 at 2:46 AM Leonard Crestez wrote: > > On 11/27/18 12:06 PM, Lucas Stach wrote: > > Hi Andrey, > > > > Am Montag, den 26.11.2018, 10:24 -0800 schrieb Andrey Smirnov: > >> On Tue, Nov 20, 2018 at 2:49 AM Leonard Crestez > >> wrote: > >>> > >>> On Sat, 2018-11-17 at 10:12 -0800

[PATCH] Small typo fix

2018-11-27 Thread Emre Ates
--- mm/vmstat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/vmstat.c b/mm/vmstat.c index 9c624595e904..cc7d04928c2e 100644 --- a/mm/vmstat.c +++ b/mm/vmstat.c @@ -1106,7 +1106,7 @@ int fragmentation_index(struct zone *zone, unsigned int order)

Re: linux-next: Signed-off-by missing for commit in the kselftest tree

2018-11-27 Thread shuah
On 11/27/18 1:36 PM, Stephen Rothwell wrote: Hi Shuah, Commit 623ea0df7083 ("selftests: firmware: remove use of non-standard diff -Z option") is missing a Signed-off-by from its author. Thanks for catching this. I will fix it. This is the result of change log content messing up the com

Re: [patch V2 24/28] x86/speculation: Prepare arch_smt_update() for PRCTL mode

2018-11-27 Thread Lendacky, Thomas
On 11/27/2018 02:30 PM, Thomas Gleixner wrote: > On Tue, 27 Nov 2018, Lendacky, Thomas wrote: >> On 11/25/2018 12:33 PM, Thomas Gleixner wrote: >>> +/* Update x86_spec_ctrl_base in case SMT state changed. */ >>> +static void update_stibp_strict(void) >>> { >>> - wrmsrl(MSR_IA32_SPEC_CTRL, x86_sp

Re: ext4 file system corruption with v4.19.3 / v4.19.4

2018-11-27 Thread Guenter Roeck
On Tue, Nov 27, 2018 at 07:55:01PM +0100, Rainer Fiebig wrote: > Am Dienstag, 27. November 2018, 15:48:19 schrieb Marek Habersack: > > On 27/11/2018 15:32, Guenter Roeck wrote: > > Hi, > > > > You might try to see if you have CONFIG_SCSI_MQ_DEFAULT=yes in your kernel > > config. Starting with 4.19

Re: [PATCH 2/4] dt-bindings: rtc: add binding doc for i.MX system controller RTC driver

2018-11-27 Thread Alexandre Belloni
Hello, On 27/11/2018 09:41:29+, Anson Huang wrote: > NXP i.MX8QXP is an ARMv8 SoC with a Cortex-M4 core inside as > system controller, the system controller is in charge of system > power, clock and secure RTC etc. management, Linux kernel > has to communicate with system controller via MU (me

Re: [PATCH 1/4] rtc: add i.MX system controller RTC support

2018-11-27 Thread Alexandre Belloni
Hello, Thank you for your submission. On 27/11/2018 09:41:20+, Anson Huang wrote: > diff --git a/drivers/rtc/Makefile b/drivers/rtc/Makefile > index 290c173..965725f 100644 > --- a/drivers/rtc/Makefile > +++ b/drivers/rtc/Makefile > @@ -151,6 +151,7 @@ obj-$(CONFIG_RTC_DRV_SC27XX) += rtc

Re: [PATCH 3/4] defconfig: arm64: add i.MX system controller RTC support

2018-11-27 Thread Alexandre Belloni
On 27/11/2018 09:41:37+, Anson Huang wrote: > This patch enables CONFIG_RTC_DRV_IMX_SC by default. > > Signed-off-by: Anson Huang > --- > arch/arm64/configs/defconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig > index

Re: [RFC v3 2/3] dt-bindings: sdm845-pinctrl: add wakeup interrupt parent for GPIO

2018-11-27 Thread Stephen Boyd
Quoting Lina Iyer (2018-11-27 10:21:23) > On Tue, Nov 27 2018 at 02:12 -0700, Stephen Boyd wrote: > > > >Two reasons. First, simplicity. The TLMM driver just needs to pass the > >gpio number up to the PDC gpio domain and then that domain can figure > >out what hwirq it maps to within the PDC hw irq

Re: [PATCHi v2] mm: put_and_wait_on_page_locked() while page is migrated

2018-11-27 Thread Mike Rapoport
On November 27, 2018 11:08:50 PM GMT+02:00, Hugh Dickins wrote: >On Tue, 27 Nov 2018, Mike Rapoport wrote: >> On Mon, Nov 26, 2018 at 11:27:07AM -0800, Hugh Dickins wrote: >> > >> > +/* >> > + * A choice of three behaviors for wait_on_page_bit_common(): >> > + */ >> > +enum behavior { >> > +

Re: [patch V2 18/28] x86/speculation: Prepare for per task indirect branch speculation control

2018-11-27 Thread Lendacky, Thomas
On 11/27/2018 02:42 PM, Thomas Gleixner wrote: > On Tue, 27 Nov 2018, Thomas Gleixner wrote: >> On Tue, 27 Nov 2018, Lendacky, Thomas wrote: >>> On 11/25/2018 12:33 PM, Thomas Gleixner wrote: --- a/arch/x86/kernel/process.c +++ b/arch/x86/kernel/process.c @@ -406,6 +406,11 @@ static

Re: [patch 20/24] x86/speculation: Split out TIF update

2018-11-27 Thread Thomas Gleixner
On Tue, 27 Nov 2018, Jiri Kosina wrote: > struct thread_info { > unsigned long flags; /* low level flags */ > + unsigned long spec_flags; /* spec flags to sync on ctxsw > */ The information is already available in task->atomic_flags, no need for new sto

Re: [PATCH 2/2] kbuild: descend into scripts/gcc-plugins/ via scripts/Makefile

2018-11-27 Thread Kees Cook
On Thu, Nov 22, 2018 at 8:51 PM, Masahiro Yamada wrote: > Now that 'prepare0' depends on 'scripts', building GCC plugins can > go into scripts/Makefile, which is a more standard way. > > Signed-off-by: Masahiro Yamada Reviewed-by: Kees Cook -Kees > --- > > Makefile | 2 +-

Re: [patch 20/24] x86/speculation: Split out TIF update

2018-11-27 Thread Jiri Kosina
On Tue, 27 Nov 2018, Thomas Gleixner wrote: > > static int ssb_prctl_set(struct task_struct *task, unsigned long ctrl) > > diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c > > index 3f5e351bdd37..6c4fcef52b19 100644 > > --- a/arch/x86/kernel/process.c > > +++ b/arch/x86/kernel/p

Re: [REGRESSION] x86, perf: counter freezing breaks rr

2018-11-27 Thread Kyle Huey
On Wed, Nov 21, 2018 at 12:14 AM Peter Zijlstra wrote: > > On Tue, Nov 20, 2018 at 02:38:54PM -0800, Andi Kleen wrote: > > > In fact, I'll argue FREEZE_ON_OVERFLOW is unfixably broken for > > > independent counters, because while one counter overflows, we'll stall > > > counting on all others unti

[PATCH] selftests: add TPM 2.0 tests

2018-11-27 Thread Jarkko Sakkinen
Added the tests that I've been using for testing TPM 2.0 functionality for long time but have out-of-tree so far residing in https://github.com/jsakkine-intel/tpm2-scripts Cc: Tadeusz Struk Signed-off-by: Jarkko Sakkinen --- Tadeusz: does not include your test. Better that you send them after t

Re: [PATCH] selftests: add TPM 2.0 tests

2018-11-27 Thread Jarkko Sakkinen
On Tue, Nov 27, 2018 at 02:10:48PM -0800, Jarkko Sakkinen wrote: > Added the tests that I've been using for testing TPM 2.0 functionality > for long time but have out-of-tree so far residing in > > https://github.com/jsakkine-intel/tpm2-scripts > > Cc: Tadeusz Struk > Signed-off-by: Jarkko Sakki

Re: [patch 20/24] x86/speculation: Split out TIF update

2018-11-27 Thread Jiri Kosina
On Tue, 27 Nov 2018, Jiri Kosina wrote: > > > static int ssb_prctl_set(struct task_struct *task, unsigned long ctrl) > > > diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c > > > index 3f5e351bdd37..6c4fcef52b19 100644 > > > --- a/arch/x86/kernel/process.c > > > +++ b/arch/x86/ke

Re: linux-next: Signed-off-by missing for commit in the kselftest tree

2018-11-27 Thread Stephen Rothwell
Hi Shuah, On Tue, 27 Nov 2018 14:17:57 -0700 shuah wrote: > > Thanks for catching this. I will fix it. This is the result of change > log content messing up the commit: The diff -Z in the change log > resulted in throwing out the Signed-off and Acked-by. Tricky :-( > -

Re: [RFC PATCH v2] ptrace: add PTRACE_GET_SYSCALL_INFO request

2018-11-27 Thread Kees Cook
On Sat, Nov 24, 2018 at 8:10 PM, Dmitry V. Levin wrote: > On Fri, Nov 23, 2018 at 07:01:39AM +0300, Dmitry V. Levin wrote: >> On Thu, Nov 22, 2018 at 04:19:10PM -0800, Andy Lutomirski wrote: >> > On Thu, Nov 22, 2018 at 11:15 AM Dmitry V. Levin wrote: >> > > On Thu, Nov 22, 2018 at 06:55:29AM -080

Re: [Bug] SD card reader in Acer Aspire S5 broken in 4.20-rc

2018-11-27 Thread Rafael J. Wysocki
On Tuesday, November 27, 2018 9:25:14 PM CET Bjorn Helgaas wrote: > On Mon, Nov 26, 2018 at 11:37:20PM +0100, Rafael J. Wysocki wrote: > > On Monday, November 26, 2018 7:03:58 PM CET Rafael J. Wysocki wrote: > > > Hi Bjorn, > > > > > > The SD card reader in my Acer Aspire S5 doesn't work with 4.20

Re: [PATCH 0/3] tools/memory-model: Add SRCU support

2018-11-27 Thread Akira Yokosawa
On 2018/11/27 09:17:46 -0800, Paul E. McKenney wrote: > On Tue, Nov 27, 2018 at 01:26:42AM +0100, Andrea Parri wrote: >>> commit 72f61917f12236514a70017d1ebafb9b8d34a9b6 >>> Author: Paul E. McKenney >>> Date: Mon Nov 26 14:26:43 2018 -0800 >>> >>> tools/memory-model: Update README for additi

Re: [PATCH] nfsd: clean up indentation, increase indentation in switch statement

2018-11-27 Thread J . Bruce Fields
Thanks, applying for 4.21.--b. On Sat, Nov 03, 2018 at 04:12:53PM +, Colin King wrote: > From: Colin Ian King > > Trivial fix to clean up indentation, add in missing tabs. > > Signed-off-by: Colin Ian King > --- > fs/nfsd/nfs4state.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deleti

Re: [PATCH] selftests: add TPM 2.0 tests

2018-11-27 Thread Tadeusz Struk
On 11/27/18 2:10 PM, Jarkko Sakkinen wrote: > Added the tests that I've been using for testing TPM 2.0 functionality > for long time but have out-of-tree so far residing in > > https://github.com/jsakkine-intel/tpm2-scripts > > Cc: Tadeusz Struk > Signed-off-by: Jarkko Sakkinen > --- > Tadeusz:

Re: [patch 20/24] x86/speculation: Split out TIF update

2018-11-27 Thread Thomas Gleixner
On Tue, 27 Nov 2018, Jiri Kosina wrote: > On Tue, 27 Nov 2018, Thomas Gleixner wrote: > > > > static int ssb_prctl_set(struct task_struct *task, unsigned long ctrl) > > > diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c > > > index 3f5e351bdd37..6c4fcef52b19 100644 > > > --- a/

Re: [PATCH 1/1] sched/headers: fix thread_info. is overwritten by STACK_END_MAGIC

2018-11-27 Thread Kees Cook
On Thu, Nov 22, 2018 at 11:54 PM, Wang Dongsheng wrote: > When select ARCH_TASK_STRUCT_ON_STACK the first of thread_info variable > is overwritten by STACK_END_MAGIC. In fact, the ARCH_TASK_STRUCT_ON_STACK > is not a real task on stack, it's only init_task on init_stack. > > Commit 0500871f21b2 ("

Re: [PATCHi v2] mm: put_and_wait_on_page_locked() while page is migrated

2018-11-27 Thread Joey Pabalinas
On Tue, Nov 27, 2018 at 01:08:50PM -0800, Hugh Dickins wrote: > On Tue, 27 Nov 2018, Mike Rapoport wrote: > > On Mon, Nov 26, 2018 at 11:27:07AM -0800, Hugh Dickins wrote: > > > > > > +/* > > > + * A choice of three behaviors for wait_on_page_bit_common(): > > > + */ > > > +enum behavior { > > > +

[PATCH V2] thermal: Fix locking in cooling device sysfs update cur_state

2018-11-27 Thread Thara Gopinath
Sysfs interface to update cooling device cur_state does not currently holding cooling device lock sometimes leading to stale values in cur_state if getting updated simultanelously from user space and thermal framework. Adding the proper locking code fixes this issue. Signed-off-by: Thara Gopinath

Re: [PATCH] Revert "xen/balloon: Mark unallocated host memory as UNUSABLE"

2018-11-27 Thread Boris Ostrovsky
On 11/27/18 3:58 PM, Igor Druzhinin wrote: > This reverts commit b3cf8528bb21febb650a7ecbf080d0647be40b9f. > > That commit unintentionally broke Xen balloon memory hotplug with > "hotplug_unpopulated" set to 1. As long as "System RAM" resource > got assigned under a new "Unusable memory" resource i

Re: [PATCH] selftests: add TPM 2.0 tests

2018-11-27 Thread Joey Pabalinas
On Tue, Nov 27, 2018 at 02:10:48PM -0800, Jarkko Sakkinen wrote: > Added the tests that I've been using for testing TPM 2.0 functionality > for long time but have out-of-tree so far residing in > > https://github.com/jsakkine-intel/tpm2-scripts > > Cc: Tadeusz Struk > Signed-off-by: Jarkko Sakki

Re: [PATCH v7 05/16] tracing: Generalize hist trigger onmax and save action

2018-11-27 Thread Tom Zanussi
Hi Namhyung, On Fri, 2018-11-23 at 16:01 +0900, Namhyung Kim wrote: > On Wed, Nov 14, 2018 at 02:18:02PM -0600, Tom Zanussi wrote: > > From: Tom Zanussi > > > > [snip] > > - > > - update_max_vars(hist_data, elt, rbe, rec); > > + if (update_track_val(hist_data, elt, data, var_ref_vals)) >

Re: [PATCH 2/7] lib/lzo: clean-up by introducing COPY16

2018-11-27 Thread Andrew Morton
On Tue, 27 Nov 2018 16:19:31 + Dave Rodgman wrote: > From: Matt Sealey > > ... > > Signed-off-by: Matt Sealey Several of the From:Matt patches were missing your Signed-off-by:. I added it. [patch 5/7] had the signoffs in an inappropriate order - I switched them.

Re: [PATCH] x86/mm/dump_pagetables: Change to use DEFINE_SHOW_ATTRIBUTE macro

2018-11-27 Thread Kees Cook
On Mon, Nov 19, 2018 at 9:06 AM, Dave Hansen wrote: > On 11/19/18 7:43 AM, Yangtao Li wrote: >> -static const struct file_operations ptdump_curusr_fops = { >> - .owner = THIS_MODULE, >> - .open = ptdump_open_curusr, >> - .read = seq_read, >> - .llseek

Re: [LKP] [mm] ac5b2c1891: vm-scalability.throughput -61.3% regression

2018-11-27 Thread Linus Torvalds
On Tue, Nov 27, 2018 at 12:57 PM Andrea Arcangeli wrote: > > This difference can only happen with defrag=always, and that's not the > current upstream default. Ok, thanks. That makes it a bit less critical. > That MADV_HUGEPAGE causes flights with NUMA balancing is not great > indeed, qemu needs

Re: [PATCH] selftests: add TPM 2.0 tests

2018-11-27 Thread Joey Pabalinas
On Tue, Nov 27, 2018 at 12:49:00PM -1000, Joey Pabalinas wrote: > > +def start_auth_session(self, session_type, name_alg = TPM2_ALG_SHA1): > > +fmt = '>HII IIH16sHBHH' > > +cmd = struct.pack(fmt, > > + TPM2_ST_NO_SESSIONS, > > +

Re: [PATCH v7 09/16] tracing: Add hist trigger snapshot() action test case

2018-11-27 Thread Tom Zanussi
Hi Masami, On Mon, 2018-11-26 at 22:03 +0900, Masami Hiramatsu wrote: > On Wed, 14 Nov 2018 14:18:06 -0600 > Tom Zanussi wrote: > > > From: Tom Zanussi > > > > Add a test case verifying the basic functionality of the > > hist:snapshot() action. > > > > Signed-off-by: Tom Zanussi > > --- > >

[PATCH v5 1/2] kernel/signal: Signal-based pre-coredump notification

2018-11-27 Thread Enke Chen
[Repost as a series, as suggested by Andrew Morton] For simplicity and consistency, this patch provides an implementation for signal-based fault notification prior to the coredump of a child process. A new prctl command, PR_SET_PREDUMP_SIG, is defined that can be used by an application to express

[PATCH v5 2/2] selftests/prctl: selftest for pre-coredump signal notification

2018-11-27 Thread Enke Chen
[Repost as a series, as suggested by Andrew Morton] Selftest for the pre-coredump signal notification Signed-off-by: Enke Chen --- tools/testing/selftests/prctl/Makefile | 2 +- tools/testing/selftests/prctl/predump-sig-test.c | 160 +++ 2 files changed, 161 inse

[PATCH] prctl: add PR_{GET,SET}_KILL_DESCENDANTS_ON_EXIT

2018-11-27 Thread Jürg Billeter
This introduces a new thread group flag that can be set by calling prctl(PR_SET_KILL_DESCENDANTS_ON_EXIT, 1, 0, 0, 0) When a thread group exits with this flag set, it will send SIGKILL to all descendant processes. This can be used to prevent stray child processes. This flag is cleared on pr

[PATCH 0/1] Add prctl to kill descendants on exit

2018-11-27 Thread Jürg Billeter
This patch adds a new prctl to kill all descendant processes on exit. See commit message for details of the prctl. This is a replacement of PR_SET_PDEATHSIG_PROC I proposed last year [1]. In the following discussion, Oleg suggested this approach. The motivation for this is to provide a lightweigh

linux-next: manual merge of the vfs tree with the ext3 tree

2018-11-27 Thread Stephen Rothwell
Hi Al, Today's linux-next merge of the vfs tree got a conflict in: fs/Makefile between commit: d44170a7ba48 ("fs: common implementation of file type") from the ext3 tree and commits: 229e55402816 ("vfs: Add configuration parser helpers") 37744f3d21f8 ("vfs: Implement a filesystem supe

Re: [PATCH] selftests: add TPM 2.0 tests

2018-11-27 Thread Jarkko Sakkinen
On Tue, Nov 27, 2018 at 12:53:07PM -1000, Joey Pabalinas wrote: > On Tue, Nov 27, 2018 at 12:49:00PM -1000, Joey Pabalinas wrote: > > > +def start_auth_session(self, session_type, name_alg = TPM2_ALG_SHA1): > > > +fmt = '>HII IIH16sHBHH' > > > +cmd = struct.pack(fmt, > > > +

Re: [PATCH] selftests: add TPM 2.0 tests

2018-11-27 Thread Jarkko Sakkinen
On Tue, Nov 27, 2018 at 02:34:39PM -0800, Tadeusz Struk wrote: > On 11/27/18 2:10 PM, Jarkko Sakkinen wrote: > > Added the tests that I've been using for testing TPM 2.0 functionality > > for long time but have out-of-tree so far residing in > > > > https://github.com/jsakkine-intel/tpm2-scripts >

Re: [LKP] [fs/locks] 83b381078b: will-it-scale.per_thread_ops -62.5% regression

2018-11-27 Thread NeilBrown
On Tue, Nov 27 2018, J. Bruce Fields wrote: > Thanks for the report! Yes, thanks. I thought I had replied to the previous report of a similar problem, but I didn't actually send that email - oops. Though the test is the same and the regression similar, this is a different patch. The previous re

[PATCH] RDMA/uverbs: fix ptr_ret.cocci warnings

2018-11-27 Thread kbuild test robot
From: kbuild test robot drivers/infiniband/core/uverbs_cmd.c:1095:1-3: WARNING: PTR_ERR_OR_ZERO can be used Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Generated by: scripts/coccinelle/api/ptr_ret.cocci Fixes: 7106a9769715 ("RDMA/uverbs: Make write() handlers return 0 on succe

Re: siginfo pid not populated from ptrace?

2018-11-27 Thread Tycho Andersen
On Mon, Nov 12, 2018 at 12:24:43PM -0700, Tycho Andersen wrote: > On Mon, Nov 12, 2018 at 11:55:38AM -0700, Tycho Andersen wrote: > > I haven't manage to reproduce it on stock v4.20-rc2, unfortunately. > > Ok, now I have, > > seccomp_bpf.c:2736:global.syscall_restart:Expected getpid() (1493) ==

[PATCH] arm64: dts: rockchip: Add 32k clk on rk3399-gru

2018-11-27 Thread Derek Basehore
This adds the 32k clock to the RK3399 Gru board file. Even though it's not directly used, muxes will end up traversing the entire clk tree on calls to determine_rate if it doesn't exist. This is because the 32k clk is listed as a possible parent on some clks. Since the clk doesn't know about the 32

Re: [PATCH v2 3/3] clk: sifive: add a driver for the SiFive FU540 PRCI IP block

2018-11-27 Thread Paul Walmsley
On Wed, 21 Nov 2018, Stephen Boyd wrote: > Quoting Paul Walmsley (2018-10-20 06:50:24) > > diff --git a/drivers/clk/sifive/fu540-prci.c > > b/drivers/clk/sifive/fu540-prci.c > > new file mode 100644 > > index ..870cb8333648 > > --- /dev/null > > +++ b/drivers/clk/sifive/fu540-prci.c >

Re: [RFC PATCH RESEND v3 3/3] ptrace: add PTRACE_EVENT_SECCOMP support to PTRACE_GET_SYSCALL_INFO

2018-11-27 Thread Dmitry V. Levin
On Tue, Nov 27, 2018 at 01:31:17PM +0100, Oleg Nesterov wrote: > On 11/27, Elvira Khabirova wrote: > > On Mon, 26 Nov 2018 15:35:24 +0100, Oleg Nesterov wrote: > > > On 11/25, Elvira Khabirova wrote: > > > > > > > > Extend PTRACE_GET_SYSCALL_INFO to support PTRACE_EVENT_SECCOMP stops. > > > > The i

Re: [PATCH] defconfig: arm64: add i.MX system controller thermal support

2018-11-27 Thread Olof Johansson
Hi, On Mon, Nov 26, 2018 at 10:14 PM Anson Huang wrote: > > This patch enables CONFIG_IMX_SC_THERMAL by default. > > Signed-off-by: Anson Huang I don't think this driver is needed to boot the system to root filesystem, is it? If so, it would be preferred to enable this as a module to keep kerne

Re: [REGRESSION] x86, perf: counter freezing breaks rr

2018-11-27 Thread Andi Kleen
> It does seem that FREEZE_PERFMON_ON_PMI (misnamed as it is) is of > rather limited use (or even negative, in our case) to a counter that's > already restricted to ring 3. It's much faster. The PMI cost goes down dramatically. I still the the right fix is to add an perf event opt-out and let it

Re: [PATCH v6] tpm: add support for partial reads

2018-11-27 Thread Jarkko Sakkinen
On Wed, Nov 21, 2018 at 05:18:38PM +0200, Jarkko Sakkinen wrote: > On Wed, Nov 21, 2018 at 06:50:37AM -0800, Tadeusz Struk wrote: > > Currently to read a response from the TPM device an application needs > > provide big enough buffer for the whole response and read it in one go. > > The application

Re: [PATCH v9 00/17] Removed nested TPM operations

2018-11-27 Thread Jarkko Sakkinen
On Sun, Nov 18, 2018 at 02:47:33PM +0200, Jarkko Sakkinen wrote: > [was Detach TPM space code out of the tpm_transmit() flow but the scope > expanded a bit.] > > Make the changes necessary to detach TPM space code and TPM activation > code out of the tpm_transmit() flow because of both of these c

RE: [PATCH] ALSA: pcm: Fix starvation on down_write_nonblock()

2018-11-27 Thread Chanho Min
> On Mon, 26 Nov 2018 06:36:37 +0100, > Chanho Min wrote: > > > > Commit 67ec1072b053 ("ALSA: pcm: Fix rwsem deadlock for non-atomic PCM > > stream") fixes deadlock for non-atomic PCM stream. But, This patch > causes antother stuck. > > If writer is RT thread and reader is a normal thread, the read

Re: [PATCH 4/8] HID: input: use the Resolution Multiplier for high-resolution scrolling

2018-11-27 Thread Peter Hutterer
On Mon, Nov 26, 2018 at 06:30:04PM -0800, Linus Torvalds wrote: > On Thu, Nov 22, 2018 at 3:28 PM Peter Hutterer > wrote: > > > > The device sends hi-res values of 4, so it should end up as REL_WHEEL_HI_RES > > 30. We are getting 28 instead which doesn't add up to a nice 120. > > I think you're

Re: [PATCH v2 03/11] clk: mediatek: Disable tuner_en before change PLL rate

2018-11-27 Thread Nicolas Boichat
On Wed, Nov 28, 2018 at 4:37 AM Sean Wang wrote: > > Weiyi Lu 於 2018年11月26日 週一 下午7:45寫道: > > > > From: Owen Chen > > > > PLLs with tuner_en bit, such as APLL1, need to disable > > tuner_en before apply new frequency settings, or the new frequency > > settings (pcw) will not be applied. > > The t

Re: [PATCH] arm64: ftrace: Fix to enable syscall events on arm64

2018-11-27 Thread Masami Hiramatsu
Hi Will, On Tue, 27 Nov 2018 13:18:59 -0500 Steven Rostedt wrote: > On Tue, 27 Nov 2018 16:58:49 + > Will Deacon wrote: > > > This looks fine to me, but I'm curious about whether this is supposed to > > work with compat syscalls as well, where the prefix is "__arm64_compat_". > > > > If w

Re: [PATCH 0/3] tools/memory-model: Add SRCU support

2018-11-27 Thread Paul E. McKenney
On Wed, Nov 28, 2018 at 07:34:14AM +0900, Akira Yokosawa wrote: > On 2018/11/27 09:17:46 -0800, Paul E. McKenney wrote: > > On Tue, Nov 27, 2018 at 01:26:42AM +0100, Andrea Parri wrote: > >>> commit 72f61917f12236514a70017d1ebafb9b8d34a9b6 > >>> Author: Paul E. McKenney > >>> Date: Mon Nov 26 14

Re: [PATCH] tty: serial: qcom_geni_serial: Fix softlock

2018-11-27 Thread Stephen Boyd
Quoting Ryan Case (2018-11-26 18:25:36) > Transfers were being divided into device FIFO sized (64 byte max) > operations which would poll for completion within a spin_lock_irqsave / > spin_unlock_irqrestore block. This both made things slow by waiting for > the FIFO to completely drain before addin

Re: Adding a Basic DT for the Linksys ea6500 v2 wireless home router

2018-11-27 Thread Florian Fainelli
On 11/26/18 4:49 PM, René Kjellerup wrote: > To the broadcom kernel maintainers, (for BCM4708 CPUs) > > I just want to add a little attention to this patch again... > let me know if there's any concerns and I will try to address highlighted > issues > as soon as possible. > > I've been runnin

Re: [PATCH v2] soc: bcm: brcmstb: Don't leak device tree node reference

2018-11-27 Thread Florian Fainelli
On 11/26/18 6:42 AM, Frank Lee wrote: > On Sat, Nov 24, 2018 at 10:52 PM Yangtao Li wrote: >> >> of_find_node_by_path() acquires a reference to the node returned by it >> and that reference needs to be dropped by its caller. soc_is_brcmstb() >> doesn't do that, so fix it. >> >> [treding: slight

<    1   2   3   4   5   6   7   8   >