Re: [PATCH 2/2] gpio: mt7621: pass mediatek_gpio_bank_probe() failure up the stack

2018-11-27 Thread Nicholas Mc Guire
On Mon, Nov 26, 2018 at 11:49:26PM -0800, Sean Wang wrote: > Nicholas Mc Guire ??? 2018???11???21??? ?? > ??10:13? > > > > The error cases of mediatek_gpio_bank_probe() would go unnoticed (except > > for the dev_err() messages). The probe function should return an error > > if one

Re: [PATCH 3/3] s390/mm: fix mis-accounting of pgtable_bytes

2018-11-27 Thread Kirill A. Shutemov
On Tue, Nov 27, 2018 at 08:34:12AM +0100, Heiko Carstens wrote: > On Wed, Oct 31, 2018 at 01:36:23PM +0300, Kirill A. Shutemov wrote: > > On Wed, Oct 31, 2018 at 11:09:44AM +0100, Heiko Carstens wrote: > > > On Wed, Oct 31, 2018 at 07:31:49AM +0100, Martin Schwidefsky wrote: > > > > Thanks for test

WARN_ON_ONCE(!new_owner) within wake_futex_pi() triggered

2018-11-27 Thread Heiko Carstens
Hello, with the glibc self-tests I was able to trigger the "this should not happen" warning ;) below on s390 (with panic_on_warn=1 set). It looks like it is hardly reproducible. This one happened with commit d146194f31c9 for compiling the kernel. Config can be re-created with "make ARCH=s390 perf

Re: [PATCH 3/3] s390/mm: fix mis-accounting of pgtable_bytes

2018-11-27 Thread Heiko Carstens
On Tue, Nov 27, 2018 at 11:05:15AM +0300, Kirill A. Shutemov wrote: > > E.g. something like the below. If there aren't any objections, I will > > provide a proper patch with changelog, etc. > > > > diff --git a/kernel/fork.c b/kernel/fork.c > > index 07cddff89c7b..d7aeec03c57f 100644 > > --- a/ker

Re: [PATCH] staging: rtl8188eu: Fix off-by-one in core/rtw_mlme_ext.c

2018-11-27 Thread Dan Carpenter
The original code is OK. On Tue, Nov 27, 2018 at 07:29:07AM +, Yang Xiao wrote: > From: Young_X > > The error at line 3267 was the result of an off-by-one error in > a for loop in line 3253. > If condition in line 3254 never satisfies, then the value of > pstat->aid is NUM_ST

Re: [PATCH] perf stat: Fix shadow stats for clock events

2018-11-27 Thread Ravi Bangoria
On 11/16/18 7:05 PM, Jiri Olsa wrote: > On Fri, Nov 16, 2018 at 09:58:43AM +0530, Ravi Bangoria wrote: >> Commit 0aa802a79469 ("perf stat: Get rid of extra clock display >> function") introduced scale and unit for clock events. Thus, >> perf_stat__update_shadow_stats() now saves scaled values of

Re: [PATCHi v2] mm: put_and_wait_on_page_locked() while page is migrated

2018-11-27 Thread Vlastimil Babka
On 11/26/18 8:27 PM, Hugh Dickins wrote: > Waiting on a page migration entry has used wait_on_page_locked() all > along since 2006: but you cannot safely wait_on_page_locked() without > holding a reference to the page, and that extra reference is enough to > make migrate_page_move_mapping() fail wi

Re: [PATCH v2 3/4] x86/kvm/hyper-v: direct mode for synthetic timers

2018-11-27 Thread Roman Kagan
On Mon, Nov 26, 2018 at 04:47:31PM +0100, Vitaly Kuznetsov wrote: > Turns out Hyper-V on KVM (as of 2016) will only use synthetic timers > if direct mode is available. With direct mode we notify the guest by > asserting APIC irq instead of sending a SynIC message. > > The implementation uses exist

Re: [PATCH] mtd: nand: Fix memory allocation in nanddev_bbt_init()

2018-11-27 Thread Boris Brezillon
On Tue, 27 Nov 2018 07:44:52 + Schrempf Frieder wrote: > Fix the size of the buffer allocated to store the in-memory BBT. > This bug was previously hidden by a different bug, that was fixed in > d098093ba06e. Oops :-/. > > Fixes: 9c3736a3de21 ("mtd: nand: Add core infrastructure to deal wi

Re: [PATCH] mtd: nand: Fix memory allocation in nanddev_bbt_init()

2018-11-27 Thread Schrempf Frieder
On 27.11.18 09:22, Boris Brezillon wrote: > On Tue, 27 Nov 2018 07:44:52 + > Schrempf Frieder wrote: > >> Fix the size of the buffer allocated to store the in-memory BBT. >> This bug was previously hidden by a different bug, that was fixed in >> d098093ba06e. > > Oops :-/. > >> >> Fixes: 9c

Re: [PATCH V4 2/2] base/drivers/arch_topology: Default dmips-mhz if they are not set in DT

2018-11-27 Thread Daniel Lezcano
On 27/11/2018 04:57, Viresh Kumar wrote: > On 26-11-18, 13:20, Daniel Lezcano wrote: >> diff --git a/Documentation/devicetree/bindings/arm/cpu-capacity.txt >> b/Documentation/devicetree/bindings/arm/cpu-capacity.txt >> index 84262cd..f53a3c9 100644 >> --- a/Documentation/devicetree/bindings/arm/cp

Re: [PATCH v2 03/43] drm/sun4i: Add TODO comment about supporting scaling with the backend

2018-11-27 Thread Maxime Ripard
On Fri, Nov 23, 2018 at 10:24:35AM +0100, Paul Kocialkowski wrote: > The backend allows integer-only scaling but can handle alpha components, > unlike the frontend. It could be useful to add support for this > eventually, so add a short TODO comment describing the situation. > > Signed-off-by: Pau

Re: [PATCH 2/2] gpio: mt7621: pass mediatek_gpio_bank_probe() failure up the stack

2018-11-27 Thread Sean Wang
> > On Mon, Nov 26, 2018 at 11:49:26PM -0800, Sean Wang wrote: > > Nicholas Mc Guire ??? 2018???11???21??? ?? > > ??10:13? > > > > > > The error cases of mediatek_gpio_bank_probe() would go unnoticed (except > > > for the dev_err() messages). The probe function should return an er

Re: [PATCH] staging: rtl8188eu: Fix off-by-one in core/rtw_mlme_ext.c

2018-11-27 Thread Dan Carpenter
On Tue, Nov 27, 2018 at 08:29:05AM +, Yang Xiao wrote: > Hi, > > See commit ef9209b642f ("staging: rtl8723bs: Fix indenting errors and an > off-by-one mistake in core/rtw_mlme_ext.c") for detail. > > I don't know how can you make sure that line 3254 can be true in the for > loop.  If the co

[PATCH 1/3] media: imx274: don't declare events, they are not implemented

2018-11-27 Thread Luca Ceresoli
The V4L2_SUBDEV_FL_HAS_EVENTS flag should not be set, event are just not implemented. Signed-off-by: Luca Ceresoli --- drivers/media/i2c/imx274.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/imx274.c b/drivers/media/i2c/imx274.c index 95a0e7d9851a..78746c

[PATCH] mm: warn only once if page table misaccounting is detected

2018-11-27 Thread Heiko Carstens
Use pr_alert_once() instead of pr_alert() if page table misaccounting has been detected. If this happens once it is very likely that there will be numerous other occurrence as well, which would flood dmesg and the console with hardly any added information. Therefore print the warning only once. C

Re: [PATCH v2 3/4] x86/kvm/hyper-v: direct mode for synthetic timers

2018-11-27 Thread Roman Kagan
On Mon, Nov 26, 2018 at 05:44:24PM +0100, Paolo Bonzini wrote: > On 26/11/18 16:47, Vitaly Kuznetsov wrote: > > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > > index 5cd5647120f2..b21b5ceb8d26 100644 > > --- a/arch/x86/kvm/x86.c > > +++ b/arch/x86/kvm/x86.c > > @@ -2997,6 +2997,7 @@ int kv

Re: [PATCH 2/2] gpio: mt7621: pass mediatek_gpio_bank_probe() failure up the stack

2018-11-27 Thread Nicholas Mc Guire
On Tue, Nov 27, 2018 at 12:32:59AM -0800, Sean Wang wrote: > > > > On Mon, Nov 26, 2018 at 11:49:26PM -0800, Sean Wang wrote: > > > Nicholas Mc Guire ??? 2018???11???21??? ?? > > > ??10:13? > > > > > > > > The error cases of mediatek_gpio_bank_probe() would go unnoticed (except >

Re: [PATCH v2 4/4] x86/static_call: Add inline static call implementation for x86-64

2018-11-27 Thread Peter Zijlstra
On Mon, Nov 26, 2018 at 03:26:28PM -0600, Josh Poimboeuf wrote: > Yeah, that's probably better. I assume you also mean that we would have > all text_poke_bp() users create a handler callback? That way the > interface is clear and consistent for everybody. Like: Can do, it does indeed make the

Re: [PATCH -next] pps: using ERR_PTR instead of NULL while pps_register_source fails

2018-11-27 Thread Rodolfo Giometti
On 27/11/2018 08:34, Greg KH wrote: On Mon, Nov 26, 2018 at 11:43:06AM +0100, Rodolfo Giometti wrote: On 26/11/2018 11:24, YueHaibing wrote: pps_register_source() has keeps error codes in a local variable, but it does not make use of the code. This patch let it return the errcode in case of fai

[PATCH] perf intel-pt: Fix error with config term pt=0

2018-11-27 Thread Adrian Hunter
Users should never use 'pt=0', but if they do it may give a meaningless error: $ perf record -e intel_pt/pt=0/u uname Error: The sys_perf_event_open() syscall returned with 22 (Invalid argument) for event (intel_pt/pt=0/u). Fix that by forcing 'pt=1'. Signed-off-

[PATCH] PCI: Mark NXP LS1088 to avoid bus reset bus

2018-11-27 Thread Bharat Bhushan
NXP (Freescale Vendor ID) LS1088 chips do not behave correctly after bus reset with e1000e. Link state of device does not comes UP and so config space never accessible again. Signed-off-by: Bharat Bhushan --- drivers/pci/quirks.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers

Re: [PATCH v2 4/4] x86/static_call: Add inline static call implementation for x86-64

2018-11-27 Thread Peter Zijlstra
On Mon, Nov 26, 2018 at 02:14:49PM -0600, Josh Poimboeuf wrote: > On Mon, Nov 26, 2018 at 10:28:08AM -0800, Andy Lutomirski wrote: > > Can you add a comment that it will need updating when kernel CET is added? > > Will do, though I get the feeling there's a lot of other (existing) code > that wil

Re: [PATCH] mm: warn only once if page table misaccounting is detected

2018-11-27 Thread Kirill A. Shutemov
On Tue, Nov 27, 2018 at 09:36:03AM +0100, Heiko Carstens wrote: > Use pr_alert_once() instead of pr_alert() if page table misaccounting > has been detected. > > If this happens once it is very likely that there will be numerous > other occurrence as well, which would flood dmesg and the console wi

[PATCH] perf auxtrace: Alter addr_filter__entire_dso() to work if there are no symbols

2018-11-27 Thread Adrian Hunter
addr_filter__entire_dso() uses the first and last symbols from a dso, and so does not work when there are no symbols. Alter it to filter the whole file instead. Signed-off-by: Adrian Hunter --- tools/perf/util/auxtrace.c | 11 --- tools/perf/util/dso.c | 6 +++--- tools/perf/util/

Re: [PATCH] tty: serial: qcom_geni_serial: Fix softlock

2018-11-27 Thread Julia Lawall
ING on v4.20-rc4 next-20181126] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Ryan-Case/tty-serial-qcom_geni_serial-Fix-softlock/20181127-102810 base: https://git.kernel.org/pub/scm/linux/kerne

Re: [PATCH v2 1/4] compiler.h: Make __ADDRESSABLE() symbol truly unique

2018-11-27 Thread Ard Biesheuvel
On Mon, 26 Nov 2018 at 14:55, Josh Poimboeuf wrote: > > The __ADDRESSABLE() macro uses the __LINE__ macro to create a temporary > symbol which has a unique name. However, if the macro is used multiple > times from within another macro, the line number will always be the > same, resulting in dupli

Re: [PATCH v2 4/4] x86/kvm/hyper-v: avoid open-coding stimer_mark_pending() in kvm_hv_notify_acked_sint()

2018-11-27 Thread Roman Kagan
On Mon, Nov 26, 2018 at 04:47:32PM +0100, Vitaly Kuznetsov wrote: > stimers_pending optimization only helps us to avoid multiple > kvm_make_request() calls. This doesn't happen very often and these > calls are very cheap in the first place, remove open-coded version of > stimer_mark_pending() from

Re: [PATCH v2 10/43] drm/fourcc: Add format helpers for checking YUV planes disposition

2018-11-27 Thread Maxime Ripard
On Fri, Nov 23, 2018 at 10:24:42AM +0100, Paul Kocialkowski wrote: > This introduces new format helpers that use the previously-introduced > format info helpers for checking YUV planes disposition. > > Only the format fourcc is required by these helpers and the formats are > iterated from the list

Re: [PATCH] staging: rtl8188eu: Fix off-by-one in core/rtw_mlme_ext.c

2018-11-27 Thread Dan Carpenter
On Tue, Nov 27, 2018 at 08:41:53AM +, Yang Xiao wrote: > Okay. I can send a patch to revert ef9209b642f. > > But, can you make sure that the condition "(pstapriv->sta_aid[pstat->aid > - 1] == NULL)" can satisfies in the for loop? ->max_num_sta is either set in _rtw_init_sta_priv() or rtw_set

Re: [PATCH v2 4/4] x86/static_call: Add inline static call implementation for x86-64

2018-11-27 Thread Peter Zijlstra
On Tue, Nov 27, 2018 at 09:43:30AM +0100, Peter Zijlstra wrote: > Now; if I'm not mistaken, the below @site is in fact @regs->ip - 1, no? > > We already patched site with INT3, which is what we just trapped on. So > we could in fact write something like: > > static void static_call_bp_handler(str

Re: linux-next: manual merge of the selinux tree with the vfs tree

2018-11-27 Thread Ondrej Mosnacek
On Tue, Nov 27, 2018 at 1:52 AM Stephen Rothwell wrote: > Hi Paul, > > Today's linux-next merge of the selinux tree got a conflict in: > > security/selinux/hooks.c > > between commit: > > 0472421f47a9 ("vfs: Remove unused code after filesystem context changes") > > from the vfs tree and commit

Re: [PATCH v17 18/23] platform/x86: Intel SGX driver

2018-11-27 Thread Dr. Greg
On Mon, Nov 26, 2018 at 03:04:36PM -0800, Jarkko Sakkinen wrote: Good morning to everyone. > On Mon, Nov 26, 2018 at 01:51:45PM -0800, Jarkko Sakkinen wrote: > > > ioctl(sgx, SGX_IOC_ADD_RIGHT, sgx_provisioning); > > > > > > This requires extra syscalls, but it doesn???t have the combinatorial >

Re: [PATCH v5 2/8] mfd: stpmic1: add stpmic1 driver

2018-11-27 Thread Lee Jones
On Mon, 26 Nov 2018, Pascal PAILLET-LME wrote: > Hi Lee, > I have just one question regarding i2c_device_id. Don't forget to trim your responses. Lots of unrequired quotes here. [...] > >> +static const struct i2c_device_id stpmic1_id[] = { > >> + { "stpmic1"}, > >> + {} > >> +}; > > I don't

[PATCH] arm64: dts: qcom: sdm845: Add Q6V5 MSS node

2018-11-27 Thread Sibi Sankar
This patch adds Q6V5 MSS remoteproc node for SDM845 SoCs. Signed-off-by: Sibi Sankar --- The remoteproc mss node depends on the following bindings: https://patchwork.kernel.org/patch/10490559/ - rpmhp dt bindings https://patchwork.kernel.org/patch/10678301/ - AOP QMP dt bindings https://patchwor

Re: [Question] atomic_fetch_andnot() in nohz_idle_balance()

2018-11-27 Thread Vincent Guittot
On Mon, 26 Nov 2018 at 21:44, Andrea Parri wrote: > > On Mon, Nov 26, 2018 at 12:37:00PM +0100, Vincent Guittot wrote: > > On Mon, 26 Nov 2018 at 10:30, Peter Zijlstra wrote: > > > > > > On Wed, Nov 21, 2018 at 11:34:53PM +0100, Andrea Parri wrote: > > > > Hi, > > > > > > > > The comment for the

Re: [PATCH v2 05/13] i2c: acpi: Return error pointers from i2c_acpi_new_device()

2018-11-27 Thread Mika Westerberg
On Mon, Nov 26, 2018 at 05:08:50PM +0200, Andy Shevchenko wrote: > The caller would like to know the reason why the i2c_acpi_new_device() fails. > For example, if adapter is not available, it might be in the future and we > would like to re-probe the clients again. But at the same time we would lik

Re: [PATCH v2 06/13] i2c: acpi: Use ACPI_FAILURE instead of !ACPI_SUCCESS

2018-11-27 Thread Mika Westerberg
On Mon, Nov 26, 2018 at 05:08:51PM +0200, Andy Shevchenko wrote: > Convert to use ACPI_FAILURE instead of !ACPI_SUCCESS. > > Signed-off-by: Andy Shevchenko > Reviewed-by: Hans de Goede Acked-by: Mika Westerberg

[PATCH] perf bpf: Use ERR_CAST instead of ERR_PTR(PTR_ERR())

2018-11-27 Thread Wen Yang
Use ERR_CAST inlined function instead of ERR_PTR(PTR_ERR(...)). This makes it more readable and also fix this warning detected by err_cast.cocci: tools/perf/util/bpf-loader.c:1606:11-18: WARNING: ERR_CAST can be used with op Signed-off-by: Wen Yang CC: Peter Zijlstra CC: Arnaldo Carvalho de Melo

Re: [PATCH v2 07/13] i2c: acpi: Introduce i2c_acpi_get_i2c_resource() helper

2018-11-27 Thread Mika Westerberg
On Mon, Nov 26, 2018 at 05:08:52PM +0200, Andy Shevchenko wrote: > Besides current two users one more is coming. Definitely makes sense to > introduce a helper. > > No functional change intended. > > Signed-off-by: Andy Shevchenko > Reviewed-by: Hans de Goede > --- > drivers/i2c/i2c-core-acpi.

Dolgozói juttatások

2018-11-27 Thread László Péter
Kedves Hölgyem/Uram! 2019 januárjától szinte minden béren kívüli juttatás jövedelemként fog adózni (kivételt képez ez alól a SZÉP kártya). A változások ellenére a vállalatok több mint 55%-a meg kívánja tartani a dolgozói juttatások nettó összegét, magára vállalva ezzel a megemelkedett adóterhek

Re: [PATCH V4 2/2] base/drivers/arch_topology: Default dmips-mhz if they are not set in DT

2018-11-27 Thread Quentin Perret
On Tuesday 27 Nov 2018 at 09:27:35 (+0530), Viresh Kumar wrote: > On 26-11-18, 13:20, Daniel Lezcano wrote: > > diff --git a/Documentation/devicetree/bindings/arm/cpu-capacity.txt > > b/Documentation/devicetree/bindings/arm/cpu-capacity.txt > > index 84262cd..f53a3c9 100644 > > --- a/Documentation

Re: [PATCH] libceph: fix use after free

2018-11-27 Thread PanBian
On Tue, Nov 27, 2018 at 11:47:56AM +0300, Sergei Shtylyov wrote: > Hello! > > On 27.11.2018 10:02, Pan Bian wrote: > > >The function ceph_monc_handle_map calls kfree(old) to free the old > >monitor map, old points to monc->monmap. However, after that, it reads > >monc->monmap->epoch and passes it

Re: [RFC v3 2/3] dt-bindings: sdm845-pinctrl: add wakeup interrupt parent for GPIO

2018-11-27 Thread Stephen Boyd
Quoting Lina Iyer (2018-11-26 08:14:55) > On Wed, Nov 21 2018 at 14:36 -0700, Stephen Boyd wrote: > >Quoting Lina Iyer (2018-11-20 16:06:47) > >> SDM845 SoC has an always-on interrupt controller (PDC) with select GPIO > >> routed to the PDC as interrupts that can be used to wake the system up > >>

Re: [PATCH 4.9 00/46] 4.9.141-stable review

2018-11-27 Thread Jon Hunter
On 26/11/2018 10:50, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.9.141 release. > There are 46 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Responses sh

[PATCH v4] arm64: dts: rockchip: Add DT for nanopc-t4

2018-11-27 Thread Tomeu Vizoso
This adds a device tree for the NanoPC-T4 SBC, which is based on the Rockchip RK3399 SoC and marketed by FriendlyELEC. Known working: - Serial - Ethernet - HDMI - USB 2.0 All of the interesting stuff is in a .dtsi because there are at least two other boards that share most of it: NanoPi M4 and N

Re: [PATCH 00/16] staging: vchiq: dead code removal & misc fixes

2018-11-27 Thread Greg KH
On Mon, Nov 26, 2018 at 08:36:33PM +0100, Stefan Wahren wrote: > > Nicolas Saenz Julienne hat am 20. November 2018 um > > 15:53 geschrieben: > > > > > > Hi All, > > > > This series was written in parallel with reading and understanding the > > vchiq code. So excuse me for the lack of logic in

Re: [PATCH v2 32/43] drm/sun4i: Pass modifier to backend and frontend format support helpers

2018-11-27 Thread Maxime Ripard
On Fri, Nov 23, 2018 at 10:25:04AM +0100, Paul Kocialkowski wrote: > To prepare the introduction of tiled mode support, pass the framebuffer > format modifier to the helpers dealing with format support. > > Since only linear mode is supported for now, add corresponding checks in > each helper. >

[PATCH] perf/core: declare the percpu variable properly

2018-11-27 Thread Mukesh Ojha
Sparse reports the current declaration of percpu variable with below warning warning: incorrect type in initializer (different address spaces) expected void const [noderef] *__vpp_verify got struct perf_cpu_context * Fix it by declaring it properly. Signed-off-by: Mukesh Ojha

Re: linux-next: manual merge of the selinux tree with the vfs tree

2018-11-27 Thread Ondrej Mosnacek
On Tue, Nov 27, 2018 at 9:53 AM Ondrej Mosnacek wrote: > On Tue, Nov 27, 2018 at 1:52 AM Stephen Rothwell > wrote: > > Hi Paul, > > > > Today's linux-next merge of the selinux tree got a conflict in: > > > > security/selinux/hooks.c > > > > between commit: > > > > 0472421f47a9 ("vfs: Remove

Re: [PATCH 4.14 00/62] 4.14.84-stable review

2018-11-27 Thread Jon Hunter
On 26/11/2018 10:50, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.14.84 release. > There are 62 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Responses sh

Re: [PATCH v10 3/3] clk: qcom: Add lpass clock controller driver for SDM845

2018-11-27 Thread Stephen Boyd
Quoting Taniya Das (2018-11-21 23:53:41) > + > +static struct clk_branch lpass_qdsp6ss_core_clk = { > + .halt_reg = 0x20, > + /* CLK_OFF would not toggle until LPASS is not out of reset */ Is this really "CLK_OFF won't toggle until LPASS it out of reset"?

Re: [PATCH] ext4: fix possible use after free in ext4_quota_enable

2018-11-27 Thread Jan Kara
On Mon 26-11-18 11:21:06, Pan Bian wrote: > The function frees qf_inode via iput but then pass qf_inode to > lockdep_set_quota_inode on the failure path. This may result in a > use-after-free bug. The patch frees df_inode only when it is never used. > > Signed-off-by: Pan Bian > Fixes: daf647d2dd

Re: [PATCH v2 05/13] i2c: acpi: Return error pointers from i2c_acpi_new_device()

2018-11-27 Thread Hans de Goede
Hi, On 27-11-18 10:04, Mika Westerberg wrote: On Mon, Nov 26, 2018 at 05:08:50PM +0200, Andy Shevchenko wrote: The caller would like to know the reason why the i2c_acpi_new_device() fails. For example, if adapter is not available, it might be in the future and we would like to re-probe the clie

Re: [PATCH V2] xfs: libxfs: move xfs_perag_put late

2018-11-27 Thread Carlos Maiolino
On Tue, Nov 27, 2018 at 08:33:38AM +0800, Pan Bian wrote: > The function xfs_alloc_get_freelist calls xfs_perag_put to drop the > reference. However, pag->pagf_btreeblks is read and write after the > put operation. This patch moves the put operation late. I'm not a native English speaker too, but

Re: [alsa-devel] [PATCH 1/4] ASoC: qcom: sdm845: Add board specific dapm widgets

2018-11-27 Thread Srinivas Kandagatla
On 24/11/18 11:09, Cheng-Yi Chiang wrote: Add board specific dapm widgets so these widgets can be used in the route. Signed-off-by: Rohit kumar Signed-off-by: Cheng-Yi Chiang Acked-by: Srinivas Kandagatla --- sound/soc/qcom/sdm845.c | 10 ++ 1 file changed, 10 insertions(+)

Re: [alsa-devel] [PATCH 4/4] ASoC: qcom: Kconfig: select config for codec

2018-11-27 Thread Srinivas Kandagatla
On 24/11/18 11:09, Cheng-Yi Chiang wrote: Select SND_SOC_RT5663 and SND_SOC_MAX98927 for SND_SOC_SDM845. Signed-off-by: Rohit kumar Signed-off-by: Cheng-Yi Chiang Acked-by: Srinivas Kandagatla --- sound/soc/qcom/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc

Re: [alsa-devel] [PATCH 2/4] ASoC: qcom: sdm845: Create and setup jack in init callback

2018-11-27 Thread Srinivas Kandagatla
On 24/11/18 11:09, Cheng-Yi Chiang wrote: Add a callback for init ops on dai_link to create and setup jack. Signed-off-by: Rohit kumar Signed-off-by: Cheng-Yi Chiang Acked-by: Srinivas Kandagatla --- sound/soc/qcom/sdm845.c | 57 +++-- 1 file chan

Re: [PATCH 3/3] gpio: Add reference counting for non-exclusive GPIOs

2018-11-27 Thread Charles Keepax
On Mon, Nov 26, 2018 at 10:53:40PM +0100, Linus Walleij wrote: > On Fri, Nov 23, 2018 at 2:25 PM Mark Brown wrote: > I suspect maybe the lesser evil is to bite the bullet, invent > gpiod_get_from_of_node() which is the missing API (we currently > only have devm_gpiod_get_from_of_node()) and simply

Re: [PATCH] ext2: fix potential use after free

2018-11-27 Thread Jan Kara
On Sun 25-11-18 08:58:02, Pan Bian wrote: > The function ext2_xattr_set calls brelse(bh) to drop the reference count > of bh. After that, bh may be freed. However, following brelse(bh), > it reads bh->b_data via macro HDR(bh). This may result in a > use-after-free bug. This patch moves brelse(bh) a

Re: [PATCH 4/5] mm: Reclaim small amounts of memory when an external fragmentation event occurs

2018-11-27 Thread Vlastimil Babka
On 11/23/18 12:45 PM, Mel Gorman wrote: > An external fragmentation event was previously described as > > When the page allocator fragments memory, it records the event using > the mm_page_alloc_extfrag event. If the fallback_order is smaller > than a pageblock order (order-9 on 64-bit

Re: [PATCH V2] namei: free new_dentry late

2018-11-27 Thread Jan Kara
On Sun 25-11-18 08:15:23, Pan Bian wrote: > After calling dput(new_dentry), new_dentry is passed to fsnotify_move. > This may result in a use-after-free bug. This patch moves the put > operation late. > > Fixes: da1ce0670c14("vfs: add cross-rename") > Signed-off-by: Pan Bian The code is actually

Re: [PATCH v2] mmc: mediatek: add MT8183 SDIO driver support

2018-11-27 Thread Jjian Zhou
On Mon, 2018-11-26 at 19:47 +0800, Nicolas Boichat wrote: > On Thu, Nov 22, 2018 at 4:03 PM Jjian Zhou wrote: > > > > MT8183 need SDIO driver. So it need add new code > > to support it. > > The description does not seem to match what is going on below: I don't > see anything that is obviously MT8

Re: [PATCH] mtd: nand: Fix memory allocation in nanddev_bbt_init()

2018-11-27 Thread Miquel Raynal
Hello, Schrempf Frieder wrote on Tue, 27 Nov 2018 08:30:24 +: > On 27.11.18 09:22, Boris Brezillon wrote: > > On Tue, 27 Nov 2018 07:44:52 + > > Schrempf Frieder wrote: > > > >> Fix the size of the buffer allocated to store the in-memory BBT. > >> This bug was previously hidden by a

Re: [PATCH] ext4: clean up indentation issues, remove extraneous tabs

2018-11-27 Thread Jan Kara
On Fri 23-11-18 16:30:43, Colin King wrote: > From: Colin Ian King > > There are several lines that are indented too far, clean these > up by removing the tabs. > > Signed-off-by: Colin Ian King The patch looks good. You can add: Reviewed-by: Jan Kara

Re: [PATCH] cgroup: remove unused member "cgrp_ancestor_id_storage" in struct cgroup_root

2018-11-27 Thread Tejun Heo
On Tue, Nov 27, 2018 at 02:53:57PM +0800, Peng Wang wrote: > "cgrp_ancestor_id_storage" is not used, so let's clean it up. It is being used. Thanks. -- tejun

Re: [PATCH v2 1/2] perf tools: Make find_vdso_map() more modular

2018-11-27 Thread Jiri Olsa
On Thu, Oct 25, 2018 at 10:55:07AM -0700, Florian Fainelli wrote: > In preparation for checking that the vectors page on the ARM > architecture, refactor the find_vdso_map() function to accept finding an > arbitrary string and create a dedicated helper function for that under > util/find-map.c and

Re: [PATCH 0/7] ACPI HMAT memory sysfs representation

2018-11-27 Thread Anshuman Khandual
On 11/26/2018 10:50 PM, Dave Hansen wrote: > On 11/26/18 7:38 AM, Anshuman Khandual wrote: >> On 11/24/2018 12:51 AM, Dave Hansen wrote: >>> On 11/22/18 10:42 PM, Anshuman Khandual wrote: Are we willing to go in the direction for inclusion of a new system call, subset of it appears on

Re: [alsa-devel] [PATCH 3/4] ASoC: qcom: sdm845: Add codec related configuration for sdm845

2018-11-27 Thread Srinivas Kandagatla
Thanks for the patch Jimmy, On 24/11/18 11:09, Cheng-Yi Chiang wrote: Set TDM time slots and DAI format for speaker codec. Set DAI format and clock for headset. > Signed-off-by: Rohit kumar Signed-off-by: Cheng-Yi Chiang Overall the patch looks good for me, but this needs to be split into tw

Re: [PATCH v2 0/2] perf tests: Check for ARM [vectors] page

2018-11-27 Thread Jiri Olsa
On Thu, Oct 25, 2018 at 10:55:06AM -0700, Florian Fainelli wrote: > Hi all, > > I just painfully learned that perf would segfault when > CONFIG_KUSER_HELPERS is disabled because it unconditionally makes use of > it. This patch series adds an ARM test for that by leveraging the > existing find_vdso

Re: [PATCH v2 1/2] perf tools: Make find_vdso_map() more modular

2018-11-27 Thread Jiri Olsa
On Thu, Oct 25, 2018 at 10:55:07AM -0700, Florian Fainelli wrote: > In preparation for checking that the vectors page on the ARM > architecture, refactor the find_vdso_map() function to accept finding an > arbitrary string and create a dedicated helper function for that under > util/find-map.c and

Re: [PATCH] sched, trace: Fix prev_state output in sched_switch tracepoint

2018-11-27 Thread Pavan Kondeti
Hi Peter/Thomas, On Tue, Oct 30, 2018 at 12:25 PM Pavankumar Kondeti wrote: > > commit 3f5fe9fef5b2 ("sched/debug: Fix task state recording/printout") > tried to fix the problem introduced by a previous commit efb40f588b43 > ("sched/tracing: Fix trace_sched_switch task-state printing"). However >

Re: [PATCH v5 3/8] clk: lochnagar: Add initial binding documentation

2018-11-27 Thread Charles Keepax
On Mon, Nov 26, 2018 at 02:16:45PM -0600, Rob Herring wrote: > On Tue, Nov 20, 2018 at 02:16:26PM +, Charles Keepax wrote: > > Lochnagar is an evaluation and development board for Cirrus > > Logic Smart CODEC and Amp devices. It allows the connection of > > most Cirrus Logic devices on mini-car

Re: [PATCH 2/2] perf report: Display average IPC and IPC coverage per symbol

2018-11-27 Thread Jiri Olsa
On Tue, Nov 27, 2018 at 11:42:12AM +0800, Jin, Yao wrote: > > > On 11/26/2018 5:55 PM, Jiri Olsa wrote: > > On Mon, Nov 26, 2018 at 05:40:54PM +0800, Jin Yao wrote: > > > > SNIP > > > > > diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c > > > index f96c005..94f62c8 100644 > > > ---

Re: [PATCH 06/14] regulator: axp20x: add software based soft_start for AXP209 LDO3

2018-11-27 Thread Maxime Ripard
On Mon, Nov 26, 2018 at 05:27:47PM +0200, Priit Laes wrote: > From: Olliver Schinagl > > In the past, there have been words on various lists that if LDO3 is > disabled in u-boot, but enabled in the DTS, the axp209 driver would > fail to continue/hang. Several enable/disable patches have been > is

Re: [PATCH 10/14] regulator: dts: set proper lradc vref on OLinuXino Lime2

2018-11-27 Thread Maxime Ripard
On Mon, Nov 26, 2018 at 05:27:51PM +0200, Priit Laes wrote: > From: Olliver Schinagl > > The lradc's analog reference voltage is set to 3.0 volt in the > hardware. This is more or less set in copper for at least lradc0. Set the > property in the dts to ensure the lradc is referenced properly. >

Re: [PATCH 09/14] regulator: dts: add full voltage range to LDO4 on the Lime2

2018-11-27 Thread Maxime Ripard
On Mon, Nov 26, 2018 at 05:27:50PM +0200, Priit Laes wrote: > From: Olliver Schinagl > > With commit b43776d65a33b46092 ("ARM: dts: sunxi: Use axp209.dtsi for > Olinuxino Lime2") we force them an arbitrary 2.8 volts. Granted, for > LDO3 this may be less arbitrary, but for LDO4 this is just wrong.

[PATCH 3/4] defconfig: arm64: add i.MX system controller RTC support

2018-11-27 Thread Anson Huang
This patch enables CONFIG_RTC_DRV_IMX_SC by default. Signed-off-by: Anson Huang --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index 6d224f7..6fdf2d0 100644 --- a/arch/arm64/configs/defconfig +++ b/

Re: [PATCH 10/14] regulator: dts: set proper lradc vref on OLinuXino Lime2

2018-11-27 Thread Chen-Yu Tsai
On Tue, Nov 27, 2018 at 5:37 PM Maxime Ripard wrote: > > On Mon, Nov 26, 2018 at 05:27:51PM +0200, Priit Laes wrote: > > From: Olliver Schinagl > > > > The lradc's analog reference voltage is set to 3.0 volt in the > > hardware. This is more or less set in copper for at least lradc0. Set the > >

[PATCH 0/4] Add i.MX system controller RTC driver

2018-11-27 Thread Anson Huang
NXP i.MX8QXP is an ARMv8 SoC with a Cortex-M4 core inside as system controller, the system controller is in charge of system power, clock and secure RTC etc. management, Linux kernel has to communicate with system controller via MU (message unit) IPC to do RTC operation. Since the RTC set time MUS

[PATCH 4/4] ARM64: dts: imx: add i.MX8QXP system controller RTC support

2018-11-27 Thread Anson Huang
Add i.MX8QXP system controller RTC support. Signed-off-by: Anson Huang --- arch/arm64/boot/dts/freescale/imx8qxp.dtsi | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi index 9155d45..ef57db6 100644 ---

[PATCH 1/4] rtc: add i.MX system controller RTC support

2018-11-27 Thread Anson Huang
i.MX8QXP is an ARMv8 SoC which has a Cortex-M4 system controller inside, the system controller is in charge of controlling power, clock and secure rtc etc.. This patch adds i.MX system controller RTC driver support, Linux kernel has to communicate with system controller via MU (message unit) IPC t

[PATCH 2/4] dt-bindings: rtc: add binding doc for i.MX system controller RTC driver

2018-11-27 Thread Anson Huang
NXP i.MX8QXP is an ARMv8 SoC with a Cortex-M4 core inside as system controller, the system controller is in charge of system power, clock and secure RTC etc. management, Linux kernel has to communicate with system controller via MU (message unit) IPC to do RTC operation, this patch adds binding doc

Re: [PATCH v7 2/3] x86: add support for Huawei WMI hotkeys.

2018-11-27 Thread Takashi Iwai
On Tue, 27 Nov 2018 03:57:48 +0100, Ayman Bagabas wrote: > > +static const struct key_entry huawei_wmi_keymap[] __initconst = { > + { KE_KEY,0x281, { KEY_BRIGHTNESSDOWN } }, > + { KE_KEY,0x282, { KEY_BRIGHTNESSUP } }, > + { KE_KEY,0x284, { KEY_MUTE }

Re: [PATCH 10/14] regulator: dts: set proper lradc vref on OLinuXino Lime2

2018-11-27 Thread Maxime Ripard
On Tue, Nov 27, 2018 at 05:41:10PM +0800, Chen-Yu Tsai wrote: > On Tue, Nov 27, 2018 at 5:37 PM Maxime Ripard > wrote: > > > > On Mon, Nov 26, 2018 at 05:27:51PM +0200, Priit Laes wrote: > > > From: Olliver Schinagl > > > > > > The lradc's analog reference voltage is set to 3.0 volt in the > > >

DMA: atmel_serial: Opening and closing the serial device repeatedly causes kmalloc-32 slab leak

2018-11-27 Thread richard . genoud
[re-sending the bug report to the lists] Le 16/11/2018 à 17:04, Mario Forner a écrit : > Problem: > When I open and close the serial device /dev/ttyS4 in a loop > the amount of kmalloc-32 slabs increases slowly but steadily without limit. > > The serial device is configured in acme-aria.dts to use

DMA: atmel_serial: Opening and closing the serial device repeatedly causes kmalloc-32 slab leak

2018-11-27 Thread richard . genoud
[re-sending with Vinod's correct email address. Sorry for the noise. ] [re-sending the bug report to the lists] Le 16/11/2018 à 17:04, Mario Forner a écrit : > Problem: > When I open and close the serial device /dev/ttyS4 in a loop > the amount of kmalloc-32 slabs increases slowly but steadily wit

Re: [PATCH 4.4 00/70] 4.4.165-stable review

2018-11-27 Thread Harsh Shandilya
On 26 November 2018 4:20:15 PM IST, Greg Kroah-Hartman wrote: >This is the start of the stable review cycle for the 4.4.165 release. >There are 70 patches in this series, all will be posted as a response >to this one. If anyone has any issues with these being applied, please >let me know. > >Res

Re: [PATCH V2] namei: free new_dentry late

2018-11-27 Thread PanBian
On Tue, Nov 27, 2018 at 10:25:51AM +0100, Jan Kara wrote: > On Sun 25-11-18 08:15:23, Pan Bian wrote: > > After calling dput(new_dentry), new_dentry is passed to fsnotify_move. > > This may result in a use-after-free bug. This patch moves the put > > operation late. > > > > Fixes: da1ce0670c14("vf

Re: DMA: atmel_serial: Opening and closing the serial device repeatedly causes kmalloc-32 slab leak

2018-11-27 Thread Alexandre Belloni
Hello Richard, On 27/11/2018 10:51:13+0100, richard.gen...@gmail.com wrote: > Hi all, > > I reproduced the memory leak on my board (at91sam9g35-cm) with a 4.20-rc3. > > It triggered an OOM after a couple of hours running a code like this: > #include > #include > #include > #include > > > i

Re: [PATCH 4.19 000/118] 4.19.5-stable review

2018-11-27 Thread Greg Kroah-Hartman
On Mon, Nov 26, 2018 at 05:09:05PM -0700, shuah wrote: > On 11/26/18 3:49 AM, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.19.5 release. > > There are 118 patches in this series, all will be posted as a response > > to this one. If anyone has any issues with

Re: [PATCH 4.19 000/118] 4.19.5-stable review

2018-11-27 Thread Greg Kroah-Hartman
On Mon, Nov 26, 2018 at 11:05:34AM -0800, Guenter Roeck wrote: > On Mon, Nov 26, 2018 at 11:49:54AM +0100, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.19.5 release. > > There are 118 patches in this series, all will be posted as a response > > to this one.

Re: [PATCH 4.19 005/118] nvme-pci: fix conflicting p2p resource adds

2018-11-27 Thread Greg Kroah-Hartman
On Mon, Nov 26, 2018 at 12:23:40PM -0700, Logan Gunthorpe wrote: > > > On 2018-11-26 3:49 a.m., Greg Kroah-Hartman wrote: > > 4.19-stable review patch. If anyone has any objections, please let me know. > > This commit is fixing a bug in the p2pdma code which was merged for > 4.20. I'm not sure

Re: [PATCH 4/5] userfaultfd: shmem: add i_size checks

2018-11-27 Thread Mike Rapoport
Hi, On Tue, Nov 27, 2018 at 06:57:32AM +, Sasha Levin wrote: > Hi, > > [This is an automated email] > > This commit has been processed because it contains a "Fixes:" tag, > fixing commit: 4c27fe4c4c84 userfaultfd: shmem: add shmem_mcopy_atomic_pte > for userfaultfd support. > > The bot has

Re: [PATCH 3.18 00/24] 3.18.127-stable review

2018-11-27 Thread Greg Kroah-Hartman
On Mon, Nov 26, 2018 at 11:23:31PM +0530, Harsh Shandilya wrote: > On 26 November 2018 4:20:54 PM IST, Greg Kroah-Hartman > wrote: > >This is the start of the stable review cycle for the 3.18.127 release. > >There are 24 patches in this series, all will be posted as a response > >to this one. If

[PATCH v2 1/4] irqchip: sifive-plic: Pre-compute context hart base and enable base

2018-11-27 Thread Anup Patel
This patch does following optimizations: 1. Pre-compute hart base for each context handler 2. Pre-compute enable base for each context handler 3. Have enable lock for each context handler instead of global plic_toggle_lock Signed-off-by: Anup Patel --- drivers/irqchip/irq-sifive-plic.c | 41

[PATCH v2 0/4] IRQ affinity support in PLIC driver

2018-11-27 Thread Anup Patel
This patchset primarily adds IRQ affinity support in PLIC driver and other improvements. The patchset gives mechanism for explicitly routing external interrupts to particular CPUs using smp_affinity attribute of each Linux IRQs. Also, we can now use IRQ balancer from kernel-space or user-space. T

[PATCH v2 2/4] irqchip: sifive-plic: More flexible plic_irq_toggle()

2018-11-27 Thread Anup Patel
We make plic_irq_toggle() more generic so that we can enable/disable hwirq for given cpumask. This generic plic_irq_toggle() will be eventually used to implement set_affinity for PLIC driver. Signed-off-by: Anup Patel --- drivers/irqchip/irq-sifive-plic.c | 79 +++ 1

[PATCH v2 4/4] irqchip: sifive-plic: Implement irq_set_affinity() for SMP host

2018-11-27 Thread Anup Patel
Currently on SMP host, all CPUs take external interrupts routed via PLIC. All CPUs will try to claim a given external interrupt but only one of them will succeed while other CPUs would simply resume whatever they were doing before. This means if we have N CPUs then for every external interrupt N-1

[PATCH v2 3/4] irqchip: sifive-plic: Differentiate between PLIC handler and context

2018-11-27 Thread Anup Patel
We explicitly differentiate between PLIC handler and context because PLIC context is for given mode of HART whereas PLIC handler is per-CPU software construct meant for handling interrupts from a particular PLIC context. Signed-off-by: Anup Patel --- drivers/irqchip/irq-sifive-plic.c | 21 ++

  1   2   3   4   5   6   7   8   >