Re: [PATCH v3 3/3] ALSA: hda: add support for Huawei WMI micmute LED

2018-11-24 Thread Takashi Iwai
On Sat, 24 Nov 2018 00:33:09 +0100, Pavel Machek wrote: > > Hi! > > > > > > > > > You have general-purpose LED, yet you are treating it as > > > > > > > > "something > > > > > > > > special". That means ugly code (quoted above) and lack of > > > > > > > > flexibility. > > > > > > > > > > > > I

Re: [PATCH 1/2] build_bug.h: remove negative-array fallback for BUILD_BUG_ON()

2018-11-24 Thread Miguel Ojeda
On Fri, Nov 16, 2018 at 8:01 PM Kees Cook wrote: > > On Fri, Nov 16, 2018 at 12:19 AM, Masahiro Yamada > wrote: > > The kernel can only be compiled with an optimization option (-O2, -Os, > > or the currently proposed -Og). Hence, __OPTIMIZE__ is always defined > > in the kernel source. > > > > A

Re: [PATCH v4 2/3] build_bug.h: remove negative-array fallback for BUILD_BUG_ON()

2018-11-24 Thread Miguel Ojeda
On Thu, Nov 22, 2018 at 5:15 PM Masahiro Yamada wrote: > > The kernel can only be compiled with an optimization option (-O2, -Os, > or the currently proposed -Og). Hence, __OPTIMIZE__ is always defined > in the kernel source. > > The fallback for the -O0 case is just hypothetical and pointless. >

Re: [PATCH] staging: iio: ad5933: finalized device-tree support

2018-11-24 Thread Slawomir Stepien
On lis 23, 2018 21:51, Marcelo Schmitt wrote: > Added a of_device_id struct variable and subsequent call to > MODULE_DEVICE_TABLE macro to complete device-tree support for this > driver. > > Signed-off-by: Marcelo Schmitt > --- > drivers/staging/iio/impedance-analyzer/ad5933.c | 9 + > 1

Re: [PATCH] drivers/fsi/fsi-scom.c: Remove duplicate header

2018-11-24 Thread Brajeswar Ghosh
On Fri, Nov 16, 2018 at 4:17 PM Brajeswar Ghosh wrote: > > Remove linux/cdev.h which is included more than once > > Signed-off-by: Brajeswar Ghosh Any comment on this patch? > --- > drivers/fsi/fsi-scom.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/fsi/fsi-scom.c b/drivers/

Re: [PATCH] drivers/bus/qcom-ebi2.c: Remove duplicate header

2018-11-24 Thread Brajeswar Ghosh
On Fri, Nov 16, 2018 at 3:43 PM Brajeswar Ghosh wrote: > > Remove linux/io.h which is included more than once > > Signed-off-by: Brajeswar Ghosh Any comment on this patch? > --- > drivers/bus/qcom-ebi2.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/bus/qcom-ebi2.c b/drivers/

Re: [PATCH] drivers/bus/fsl-mc/dpcon.c: Remove duplicate header

2018-11-24 Thread Brajeswar Ghosh
On Fri, Nov 16, 2018 at 3:36 PM Brajeswar Ghosh wrote: > > Remove linux/fsl/mc.h which is included more than once > > Signed-off-by: Brajeswar Ghosh Any comment on this patch? > --- > drivers/bus/fsl-mc/dpcon.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/bus/fsl-mc/dpcon.c

Re: [PATCH v4 1/3] kernel.h: disable type-checks in container_of() for Sparse

2018-11-24 Thread Miguel Ojeda
On Fri, Nov 23, 2018 at 10:14 PM Luc Van Oostenryck wrote: > > On Thu, Nov 22, 2018 at 12:14:20PM +0900, Masahiro Yamada wrote: > > When I tried to enable BUILD_BUG_ON for Sparse, the kbuild test robot > > reported lots of "unknown expression" warnings from container_of(), > > which seemed false p

Re: [PATCH v4 3/3] build_bug.h: remove most of dummy BUILD_BUG_ON stubs for Sparse

2018-11-24 Thread Miguel Ojeda
On Thu, Nov 22, 2018 at 5:08 PM Masahiro Yamada wrote: > > The introduction of these dummy BUILD_BUG_ON stubs dates back to > commit 903c0c7cdc21 ("sparse: define dummy BUILD_BUG_ON definition > for sparse"). > > At that time, BUILD_BUG_ON() was implemented with the negative array > trick *and* th

Re: [PATCH v2 15/15] MAINTAINERS: Add entry for RDA Micro SoC architecture

2018-11-24 Thread kbuild test robot
Hi Manivannan, I love your patch! Perhaps something to improve: [auto build test WARNING on robh/for-next] [also build test WARNING on v4.20-rc3 next-20181123] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/

[PATCH] mm: make free_reserved_area() return "const char *"

2018-11-24 Thread Alexey Dobriyan
and propagate through down the call stack. Signed-off-by: Alexey Dobriyan --- arch/x86/include/asm/processor.h |2 +- arch/x86/mm/init.c |2 +- include/linux/mm.h |2 +- mm/page_alloc.c |2 +- 4 files changed, 4 insertions(+), 4 delet

[PATCH] make "initcall_level_names[]" const char *

2018-11-24 Thread Alexey Dobriyan
Initcall names should not be changed. Signed-off-by: Alexey Dobriyan --- init/main.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/init/main.c +++ b/init/main.c @@ -934,7 +934,7 @@ static initcall_entry_t *initcall_levels[] __initdata = { }; /* Keep these in sync with init

[PATCH] namei: free new_dentry late

2018-11-24 Thread Pan Bian
After calling dput(new_dentry), new_dentry is passed to fsnotify_move. This may result in a use-after-free bug. This patch moves the put operation late. Fixes: 49d31c2f389a("dentry name snapshots") Signed-off-by: Pan Bian --- fs/namei.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH] drop silly "static inline asmlinkage" from dump_stack()

2018-11-24 Thread Alexey Dobriyan
Signed-off-by: Alexey Dobriyan --- include/linux/printk.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/include/linux/printk.h +++ b/include/linux/printk.h @@ -269,7 +269,7 @@ static inline void show_regs_print_info(const char *log_lvl) { } -static inline asmlinkage void du

Re: [PATCH v8 2/4] pps: descriptor-based gpio, capture-clear addition

2018-11-24 Thread tom burkart
Hi Philipp, Quoting Philipp Zabel : On Sat, Nov 17, 2018 at 2:07 PM Tom Burkart wrote: This patch changes the GPIO access for the pps-gpio driver from the integer based ABI to the descriptor based ABI. It also adds the extraction of the device tree capture-clear option. Is the capture-cle

[PATCH] xfs: libxfs: move xfs_perag_put late

2018-11-24 Thread Pan Bian
The function xfs_alloc_get_freelist calls xfs_perag_put to drop the reference. In this case, pag may be released. However, pag->pagf_btreeblks is read and write after the put operation. This may result in a use-after-free bug. This patch moves the put operation late. Signed-off-by: Pan Bian ---

Re: Re: [PATCH] arm64: crc: accelerated-crc32-by-64bytes

2018-11-24 Thread Ard Biesheuvel
On Sat, 24 Nov 2018 at 07:42, sunrui wrote: > > > On Thu, 22 Nov 2018 at 02:50, sunrui wrote: > > > > > > > > On Sun, 18 Nov 2018 at 23:30, Rui Sun wrote: > > > > > > > > > > add 64 bytes loop to acceleration calculation > > > > > > > > > > > > > Can you share some performance numbers please? >

[PATCH 1/1] hfsplus: do not free node before using

2018-11-24 Thread Pan Bian
The function hfs_bmap_free frees node via hfs_bnode_put(node). However, it then reads node->this when dumping error message on an error path, which may result in a use-after-free bug. This patch frees node only when it is never used. Signed-off-by: Pan Bian --- fs/hfsplus/btree.c | 3 ++- 1 file

Re: [PATCH v3 3/3] ALSA: hda: add support for Huawei WMI micmute LED

2018-11-24 Thread Pavel Machek
Hi! > > > > > > > > > You have general-purpose LED, yet you are treating it as > > > > > > > > > "something > > > > > > > > > special". That means ugly code (quoted above) and lack of > > > > > > > > > flexibility. > > > > > > > > > > > > > > > I'd prefer this to be normal LED and "mic muted" t

[PATCH] printk: don't unconditionally shortcut print_time()

2018-11-24 Thread Tetsuo Handa
Since /sys/module/printk/parameters/time can change from N to Y between "msg_print_text() called print_prefix() with buf == NULL" and "msg_print_text() again calls print_prefix() with buf != NULL", it is not safe for print_time() to unconditionally return 0 if printk_time == false. Signed-off-by:

Re: [PATCH] ALSA: pcm: Fix starvation on down_write_nonblock()

2018-11-24 Thread kbuild test robot
/commits/Chanho-Min/ALSA-pcm-Fix-starvation-on-down_write_nonblock/20181124-182630 base: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next config: x86_64-randconfig-x001-201846 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached

[PATCH 2/4] ASoC: qcom: sdm845: Create and setup jack in init callback

2018-11-24 Thread Cheng-Yi Chiang
Add a callback for init ops on dai_link to create and setup jack. Signed-off-by: Rohit kumar Signed-off-by: Cheng-Yi Chiang --- sound/soc/qcom/sdm845.c | 57 +++-- 1 file changed, 55 insertions(+), 2 deletions(-) diff --git a/sound/soc/qcom/sdm845.c b/sound/

[PATCH 1/4] ASoC: qcom: sdm845: Add board specific dapm widgets

2018-11-24 Thread Cheng-Yi Chiang
Add board specific dapm widgets so these widgets can be used in the route. Signed-off-by: Rohit kumar Signed-off-by: Cheng-Yi Chiang --- sound/soc/qcom/sdm845.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/sound/soc/qcom/sdm845.c b/sound/soc/qcom/sdm845.c index 58593db2ab151.

[PATCH 4/4] ASoC: qcom: Kconfig: select config for codec

2018-11-24 Thread Cheng-Yi Chiang
Select SND_SOC_RT5663 and SND_SOC_MAX98927 for SND_SOC_SDM845. Signed-off-by: Rohit kumar Signed-off-by: Cheng-Yi Chiang --- sound/soc/qcom/Kconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/qcom/Kconfig b/sound/soc/qcom/Kconfig index 2a4c912d1e484..3528c4279cbae 100644 ---

[PATCH 3/4] ASoC: qcom: sdm845: Add codec related configuration for sdm845

2018-11-24 Thread Cheng-Yi Chiang
Set TDM time slots and DAI format for speaker codec. Set DAI format and clock for headset. Signed-off-by: Rohit kumar Signed-off-by: Cheng-Yi Chiang --- sound/soc/qcom/sdm845.c | 82 - 1 file changed, 81 insertions(+), 1 deletion(-) diff --git a/sound/so

Re: [PATCH v3 4/4] ARM: dts: Add stmpe-adc driver to relevant devicetrees

2018-11-24 Thread Dmitry Osipenko
On 23.11.2018 17:24, Philippe Schenker wrote: > From: Philippe Schenker > > Activate the stmpe-adc driver as found on Apalis/Colibri iMX6/T30 modules > > Signed-off-by: Philippe Schenker Hello Philippe, Just a very minor comment.. device trees are not for drivers, but for HW description. It

[PATCH v10 2/4] pps: descriptor-based gpio, capture-clear addition

2018-11-24 Thread Tom Burkart
This patch changes the GPIO access for the pps-gpio driver from the integer based ABI to the descriptor based ABI. It also adds the extraction of the device tree capture-clear option. Reviewed-by: Philipp Zabel Signed-off-by: Tom Burkart --- drivers/pps/clients/pps-gpio.c | 70

[PATCH v10 0/4] PPS: pps-gpio PPS ECHO implementation

2018-11-24 Thread Tom Burkart
Hi all, please find attached the PPS-GPIO PPS ECHO implementation patch. The driver claims to have echo functionality in the sysfs interface but this functionality is not present. This patch provides this functionality. Parts 1 and 2 of the patch change the original driver from the number based G

[PATCH v10 1/4] dt-bindings: pps: capture-clear addition

2018-11-24 Thread Tom Burkart
It adds documentation for the device tree capture-clear option. Signed-off-by: Tom Burkart --- Documentation/devicetree/bindings/pps/pps-gpio.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/pps/pps-gpio.txt b/Documentation/devicetree/bindings/pps/pps-

[PATCH v10 3/4] dt-bindings: pps: pps-gpio PPS ECHO implementation

2018-11-24 Thread Tom Burkart
This patch implements the device tree changes required for the pps echo functionality for pps-gpio, that sysfs claims is available already. This patch was originally written by Lukas Senger as part of a masters thesis project and modified for inclusion into the linux kernel by Tom Burkart. Signed

[PATCH v10 4/4] pps: pps-gpio pps-echo implementation

2018-11-24 Thread Tom Burkart
This patch implements the pps echo functionality for pps-gpio, that sysfs claims is available already. Configuration is done via device tree bindings. This patch was originally written by Lukas Senger as part of a masters thesis project and modified for inclusion into the linux kernel by Tom Burk

Re: Re: [PATCH] arm64: crc: accelerated-crc32-by-64bytes

2018-11-24 Thread Ard Biesheuvel
On Sat, 24 Nov 2018 at 10:56, Ard Biesheuvel wrote: > > On Sat, 24 Nov 2018 at 07:42, sunrui wrote: > > > > > > On Thu, 22 Nov 2018 at 02:50, sunrui wrote: > > > > > > > > > > > > On Sun, 18 Nov 2018 at 23:30, Rui Sun wrote: > > > > > > > > > > > > > > add 64 bytes loop to acceleration calculat

Re:HELLO

2018-11-24 Thread Salah Ibrahim
With due respect to your person and much sincerity of purpose’ I have a business proposal which I will like to handle with you. $35 Million USD is involve. But be rest assured that everything is legal and risk free as I have concluded all the arrangements and the legal papers that will back the

[PATCH] altera-stapl: check for a null key before strcasecmp'ing it

2018-11-24 Thread Colin King
From: Colin Ian King Currently the null check on key is occurring after the strcasecmp on the key, hence there is a potential null pointer dereference on key. Fix this by checking if key is null first. Also replace the == 0 check on strcasecmp with just the ! operator. Detected by CoverityScan,

[PATCH] Little memset_explicit optimisation

2018-11-24 Thread David CARLIER
0001-memzero_explicit-optimisation-for-size.patch Description: Binary data

[GIT PULL] arm64 fixes for 4.20-rc4

2018-11-24 Thread Catalin Marinas
Hi Linus, Please pull the arm64 fixes below. Thanks. The following changes since commit 9ff01193a20d391e8dbce4403dd5ef87c7eaaca6: Linux 4.20-rc3 (2018-11-18 13:33:44 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux tags/arm64-fixes f

Re: [PATCH rdma-next 3/3] RDMA/hns: Modify hns RoCE device's name

2018-11-24 Thread Wei Hu (Xavier)
On 2018/11/24 4:39, Jason Gunthorpe wrote: > On Fri, Nov 23, 2018 at 11:14:25PM +0800, Wei Hu (Xavier) wrote: >> This patch modifies the name of hns RoCE device's name in order >> to ensure that the name is consistent before and after reset. >> >> Signed-off-by: Wei Hu (Xavier) >> drivers/infi

Re: [PATCH rdma-next 0/3] RDMA/hns: Updates for reset process of roce device in hip08

2018-11-24 Thread Wei Hu (Xavier)
On 2018/11/24 4:42, Jason Gunthorpe wrote: > On Fri, Nov 23, 2018 at 11:14:22PM +0800, Wei Hu (Xavier) wrote: >> Hi, Doug and Janson >> >> This series mainly include updates for reset process of roce device >> in hip08. >> One patch adds support for reset and loading or unloading driver occur >>

[PATCH v2] staging: iio: ad5933: add device tree support

2018-11-24 Thread Marcelo Schmitt
Add a of_device_id struct variable and subsequent call to MODULE_DEVICE_TABLE macro to complete device tree support. Signed-off-by: Marcelo Schmitt --- drivers/staging/iio/impedance-analyzer/ad5933.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/staging/iio/impedance-analy

HELLO DEAR

2018-11-24 Thread michel
With Due Respect, I know that this mail will come to you as a surprise as we have never met before, but need not to worry as I am contacting you independently of my investigation and no one is informed of this communication. I need your urgent assistance in transferring the sum of $11.3million imm

Re: [PATCH] dmaengine: xilinx_dma: Remove __aligned attribute on zynqmp_dma_desc_ll

2018-11-24 Thread Vinod Koul
On 25-10-18, 11:05, Nathan Chancellor wrote: > Clang warns: > > drivers/dma/xilinx/zynqmp_dma.c:166:4: warning: attribute 'aligned' is > ignored, place it after "struct" to apply attribute to type declaration > [-Wignored-attributes] > }; __aligned(64) >^ > ./include/linux/compiler_types.h:200

Re: [PATCH v17 06/23] x86/cpu/intel: Detect SGX support and update caps appropriately

2018-11-24 Thread Jarkko Sakkinen
On Wed, Nov 21, 2018 at 07:17:28PM +0100, Borislav Petkov wrote: > I see the build failure here has been pointed out already but lemme > repeat it out for another reason: > > It is very important that no patch we merge breaks bisectability - > please build every patch before sending: Yep, the pat

RE,

2018-11-24 Thread Miss Sharifah Ahmad Mustahfa
Hello, First of all i will like to apologies for my manner of communication because you do not know me personally, its due to the fact that i have a very important proposal for you.

[PATCH] memory: tegra: Convert to using %pOFn instead of device_node.name

2018-11-24 Thread Yangtao Li
In preparation to remove the node name pointer from struct device_node, convert printf users to use the %pOFn format specifier. Signed-off-by: Yangtao Li --- drivers/memory/tegra/mc.c | 6 +++--- drivers/memory/tegra/tegra124-emc.c | 12 ++-- 2 files changed, 9 insertions(+),

RE,

2018-11-24 Thread Miss Sharifah Ahmad Mustahfa
Hello, First of all i will like to apologies for my manner of communication because you do not know me personally, its due to the fact that i have a very important proposal for you.

RE,

2018-11-24 Thread Miss Sharifah Ahmad Mustahfa
Hello, I need your help to invest in your region.

Re: [PATCH v4 0/2] dmaengine: add UniPhier MIO DMAC driver

2018-11-24 Thread Vinod Koul
On 12-10-18, 01:41, Masahiro Yamada wrote: > 1/2: DT-binding > 2/2: driver Applied this series, thanks While building I noticed that we get few warns when compiling with C=1, I would prefer you fix them. Please send fixes on top of the applied patches. Thanks -- ~Vinod

RE,

2018-11-24 Thread Miss Sharifah Ahmad Mustahfa
Hello, First of all i will like to apologies for my manner of communication because you do not know me personally, its due to the fact that i have a very important proposal for you.

RE,

2018-11-24 Thread Miss Sharifah Ahmad Mustahfa
Hello, First of all i will like to apologies for my manner of communication because you do not know me personally, its due to the fact that i have a very important proposal for you.

[PATCH] devres: no print device_node.name in devres_log()

2018-11-24 Thread Yangtao Li
In preparation to remove the node name pointer from struct device_node, avoid to printf node name. Signed-off-by: Yangtao Li --- drivers/base/devres.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/base/devres.c b/drivers/base/devres.c index 4aaf00d2098b..34c07e9

Re: [PATCH v2] kmemleak: Turn kmemleak_lock to raw spinlock on RT

2018-11-24 Thread He Zhe
On 2018/11/23 17:53, Sebastian Andrzej Siewior wrote: > On 2018-11-22 17:04:19 [+0800], zhe...@windriver.com wrote: >> From: He Zhe >> >> kmemleak_lock, as a rwlock on RT, can possibly be held in atomic context and >> causes the follow BUG. >> >> BUG: scheduling while atomic: migration/15/132/0

[PATCH] printk: deduplicate print_prefix() calls

2018-11-24 Thread Tetsuo Handa
Since /sys/module/printk/parameters/time can change from N to Y between "msg_print_text() called print_prefix() with buf == NULL" and "msg_print_text() again calls print_prefix() with buf != NULL", it is not safe for print_time() to unconditionally return 0 if printk_time == false. But print_prefi

Re: [PATCH] dma: coh901318: Fix a double-lock bug

2018-11-24 Thread Vinod Koul
On 06-11-18, 11:33, Jia-Ju Bai wrote: > The function coh901318_alloc_chan_resources() calls spin_lock_irqsave() > before calling coh901318_config(). > But coh901318_config() calls spin_lock_irqsave() again in its > definition, which may cause a double-lock bug. > > Because coh901318_config() is o

[PATCH] power/reset: axxia: Convert to using %pOFn instead of device_node.name

2018-11-24 Thread Yangtao Li
In preparation to remove the node name pointer from struct device_node, convert printf users to use the %pOFn format specifier. Signed-off-by: Yangtao Li --- drivers/power/reset/axxia-reset.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/power/reset/axxia-reset.c b

Greetings,

2018-11-24 Thread Mr David Sankara
Greetings, I want to make an investment in your field of work. I've seen alot of profit and success story that came out from your kind of business thus my desire to make a huge investment on it. Please send to me a sample of your work/business and once I confide in you, I will make available the in

Re: [PATCH] dmaengine: ep93xx_dma: fix misspell

2018-11-24 Thread Vinod Koul
On 19-11-18, 10:15, Yangtao Li wrote: > couln't -> couldn't Applied, thanks -- ~Vinod

[PATCH v2] soc: bcm: brcmstb: Don't leak device tree node reference

2018-11-24 Thread Yangtao Li
of_find_node_by_path() acquires a reference to the node returned by it and that reference needs to be dropped by its caller. soc_is_brcmstb() doesn't do that, so fix it. [treding: slightly rewrite to avoid inline comparison] Signed-off-by: Yangtao Li --- Changes in v2: -update changelog -slightl

Re: [PATCH] devres: no print device_node.name in devres_log()

2018-11-24 Thread Frank Lee
On Sat, Nov 24, 2018 at 10:25 PM Yangtao Li wrote: > > In preparation to remove the node name pointer from struct device_node, > avoid to printf node name. > > Signed-off-by: Yangtao Li > --- > drivers/base/devres.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/dri

Re: [PATCH] clocksource/drivers/integrator-ap: add missing of_node_put()

2018-11-24 Thread Frank Lee
On Thu, Nov 22, 2018 at 11:23 PM Yangtao Li wrote: > > of_find_node_by_path() acquires a reference to the node > returned by it and that reference needs to be dropped by its caller. > integrator_ap_timer_init_of() doesn't do that, so fix it. > > Signed-off-by: Yangtao Li > --- > drivers/clocksou

[PATCH] Little memset_explicit optimisation

2018-11-24 Thread David CARLIER
Subject: [PATCH] memzero_explicit, optimisation for size. Using the return value of memset for save/load sake. Signed-off-by: David Carlier --- lib/string.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/string.c b/lib/string.c index 38e4ca08e757..92da04a0213b 10

[PING 2] [PATCH] jffs2: Fix use of uninitialized delayed_work, lockdep breakage

2018-11-24 Thread Daniel Santos
Ping 2! On 11/05/2018 03:38 PM, Daniel Santos wrote: > Ping. > > Daniel > > On 10/21/2018 07:32 PM, Hou Tao wrote: >> On 2018/10/19 16:30, Daniel Santos wrote: >>> jffs2_sync_fs makes the assumption that if CONFIG_JFFS2_FS_WRITEBUFFER >>> is defined then a write buffer is available and has been in

Re: [PATCH v5 8/8] pinctrl: lochnagar: Add support for the Cirrus Logic Lochnagar

2018-11-24 Thread kbuild test robot
Hi Charles, I love your patch! Yet something to improve: [auto build test ERROR on ljones-mfd/for-mfd-next] [also build test ERROR on v4.20-rc3] [cannot apply to next-20181123] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://gi

Re: [PATCH v17 18/23] platform/x86: Intel SGX driver

2018-11-24 Thread Jarkko Sakkinen
On Tue, Nov 20, 2018 at 05:15:08AM -0600, Dr. Greg wrote: > Malware would not necessarily need the Intel attestation service. > Once access to the PROVISION bit is available, malware teams could > simply build their own attestation service. AFAIK not possible as they wouldn't have access to the ro

[PATCH] pinctrl: rza1: report if devm_kasptrinf() fails

2018-11-24 Thread Nicholas Mc Guire
devm_kasprintf() may return NULL on failure of internal allocation thus the assignments are not safe if not checked. On error rza1_pinctrl_register() respectively rza1_parse_gpiochip() return negative values so -ENOMEM in the (unlikely) failure case of devm_kasprintf() should be fine here. Sign

Re: [PATCH v17 18/23] platform/x86: Intel SGX driver

2018-11-24 Thread Jarkko Sakkinen
On Fri, Nov 23, 2018 at 04:39:23AM -0600, Dr. Greg wrote: > Jarkko, when this driver lands it will set the SGX ABI in stone for > Linux. It would be very, very helpful to the development community if > there was some official guidance from Intel on whether or not FLC will > be a universal feature

[GIT PULL] xfs: fixes for v4.20-rc4

2018-11-24 Thread Darrick J. Wong
Hi Linus, Dave and I have continued our work fixing corruption problems that can be found when running long-term burn-in exercisers on xfs. Here are some patches fixing most of the problems, but there will likely be more. :/ Anyhow, this series merges cleanly with master as of last night, so ple

Re: RFC: userspace exception fixups

2018-11-24 Thread Jarkko Sakkinen
On Wed, Nov 21, 2018 at 05:17:34PM +0200, Jarkko Sakkinen wrote: > On Wed, Nov 21, 2018 at 05:17:32AM +, Jethro Beekman wrote: > > Jarkko, can you please explain you solution in detail? The CPU receives an > > exception. This will be handled by the kernel exception handler. What > > information

Re: [PATCH v17 18/23] platform/x86: Intel SGX driver

2018-11-24 Thread Jarkko Sakkinen
On Thu, Nov 22, 2018 at 07:21:08AM -0800, Andy Lutomirski wrote: > > At a high level, addressing these issues is straight forward. First, > > the driver needs to support authorization equivalent to that which is > > implemented in the current Intel Launch Enclave, ie. control over the > > SGX_FLAG

[GIT PULL] XArray updates

2018-11-24 Thread Matthew Wilcox
Hi Linus, We found some bugs in the DAX conversion to XArray (and one bug which predated the XArray conversion). There were a couple of bugs in some of the higher-level functions, which aren't actually being called in today's kernel, but surfaced as a result of converting existing radix tree &

WARNING: syz-executor still has locks held!

2018-11-24 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:7c98a4261827 Merge tag 'ceph-for-4.20-rc4' of https://gith.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=12d8101540 kernel config: https://syzkaller.appspot.com/x/.config?x=73e2bc0cb6463446 da

Re: [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1

2018-11-24 Thread Russell King - ARM Linux
On Sat, Nov 24, 2018 at 02:17:40AM +0200, Aaro Koskinen wrote: > Hi, > > On Fri, Nov 23, 2018 at 01:45:46PM +0200, Peter Ujfalusi wrote: > > On 23/11/2018 0.01, Aaro Koskinen wrote: > > > With that reverted, the DMA works OK (and I can also now confirm that > > > OMAP_DMA_LCH_2D works). I haven't

Re: [GIT PULL] xfs: fixes for v4.20-rc4

2018-11-24 Thread pr-tracker-bot
The pull request you sent on Sat, 24 Nov 2018 09:05:40 -0800: > git://git.kernel.org/pub/scm/fs/xfs/xfs-linux.git tags/xfs-4.20-fixes-2 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/abe72ff4134028ff2189d29629c40a40bee0a989 Thank you! -- Deet-doot-dot, I am a bot. h

Re: [GIT] Networking

2018-11-24 Thread pr-tracker-bot
The pull request you sent on Fri, 23 Nov 2018 22:58:55 -0800 (PST): > git://git.kernel.org/pub/scm/linux/kernel/git/davem/net.git master has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/857fa628bbe93017c72ddd0d5304962a2608db07 Thank you! -- Deet-doot-dot, I am a bot.

Re: [GIT PULL] arm64 fixes for 4.20-rc4

2018-11-24 Thread pr-tracker-bot
The pull request you sent on Sat, 24 Nov 2018 12:36:40 +: > git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux tags/arm64-fixes has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/d146194f31c96f9b260c5a1cf1592d2e7f82a2e2 Thank you! -- Deet-doot-dot, I am a bot

Re: [GIT PULL] XArray updates

2018-11-24 Thread Linus Torvalds
On Sat, Nov 24, 2018 at 9:32 AM Matthew Wilcox wrote: > > git://git.infradead.org/users/willy/linux-dax.git xarray Can you *please* make that a signed tag. I don't trust infradead.org implicitly, so I really want signed tag pull requests. I may not always notice, but when I do, I abort the pu

KASAN: slab-out-of-bounds Read in default_write_copy_kernel

2018-11-24 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:7c98a4261827 Merge tag 'ceph-for-4.20-rc4' of https://gith.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=142c889340 kernel config: https://syzkaller.appspot.com/x/.config?x=73e2bc0cb6463446 da

Re: [RFC][PATCH 02/14] fgraph: Have set_graph_notrace only affect function_graph tracer

2018-11-24 Thread Steven Rostedt
On Sat, 24 Nov 2018 14:49:34 +0900 Namhyung Kim wrote: > On Sat, Nov 24, 2018 at 2:37 AM Steven Rostedt wrote: > > > > On Fri, 23 Nov 2018 09:01:18 +0900 > > Namhyung Kim wrote: > > > > > Acked-by: Namhyung Kim > > > > Thanks Namhyung! > > It'd be nice if you cc me for the whole patchse

Re: [for-next][PATCH 08/18] parisc: function_graph: Simplify with function_graph_entry()

2018-11-24 Thread Steven Rostedt
On Fri, 23 Nov 2018 15:00:11 -0500 Sasha Levin wrote: > On Fri, Nov 23, 2018 at 02:26:17PM -0500, Steven Rostedt wrote: > >On Fri, 23 Nov 2018 13:34:15 -0500 > >Sasha Levin wrote: > > > >> Does this mean that someone (Steve) will send a backport of this to all > >> relevant stable trees? Right

Re: [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1

2018-11-24 Thread Aaro Koskinen
Hello, On Sat, Nov 24, 2018 at 05:48:23PM +, Russell King - ARM Linux wrote: > Hmm, there's more questionable stuff in this driver, and the gadget > layer. [...] > So, whatever way I look at this, the code in the removal path both > in omap_udc and the gadget removal code higher up looks ver

Re: [PATCH v17 18/23] platform/x86: Intel SGX driver

2018-11-24 Thread Dr. Greg
On Sat, Nov 24, 2018 at 08:15:21AM -0800, Jarkko Sakkinen wrote: > On Tue, Nov 20, 2018 at 05:15:08AM -0600, Dr. Greg wrote: > > Malware would not necessarily need the Intel attestation service. > > Once access to the PROVISION bit is available, malware teams could > > simply build their own attes

Re: [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1

2018-11-24 Thread Russell King - ARM Linux
On Sat, Nov 24, 2018 at 09:06:48PM +0200, Aaro Koskinen wrote: > Hello, > > On Sat, Nov 24, 2018 at 05:48:23PM +, Russell King - ARM Linux wrote: > > Hmm, there's more questionable stuff in this driver, and the gadget > > layer. > > [...] > > > So, whatever way I look at this, the code in th

Re: [PATCH] clocksource/drivers/integrator-ap: add missing of_node_put()

2018-11-24 Thread Daniel Lezcano
On 24/11/2018 15:58, Frank Lee wrote: > On Thu, Nov 22, 2018 at 11:23 PM Yangtao Li wrote: >> >> of_find_node_by_path() acquires a reference to the node >> returned by it and that reference needs to be dropped by its caller. >> integrator_ap_timer_init_of() doesn't do that, so fix it. >> >> Signed

Re: [PATCH] namei: free new_dentry late

2018-11-24 Thread Al Viro
On Sat, Nov 24, 2018 at 05:23:24PM +0800, Pan Bian wrote: > After calling dput(new_dentry), new_dentry is passed to fsnotify_move. > This may result in a use-after-free bug. This patch moves the put > operation late. > > Fixes: 49d31c2f389a("dentry name snapshots") What does that commit have to do

Re: [PATCH V2] hfs: do not free node before using

2018-11-24 Thread Viacheslav Dubeyko
On Sat, 2018-11-24 at 10:10 +0800, Pan Bian wrote: > The function hfs_bmap_free frees node via hfs_bnode_put(node). > However, > it then reads node->this when dumping error message on an error path, > which may result in a use-after-free bug. This patch frees node only > when it is never used. > >

Re: [PATCH] dmaengine: ti: omap-dma: Configure LCH_TYPE for OMAP1

2018-11-24 Thread Russell King - ARM Linux
On Fri, Nov 23, 2018 at 08:52:15PM +0200, Aaro Koskinen wrote: > Hi, > > On Fri, Nov 23, 2018 at 02:35:04PM +0200, Peter Ujfalusi wrote: > > On 22/11/2018 17.12, Russell King - ARM Linux wrote: > > > I'm also not sure about this: > > > > > > if (cpu_is_omap15xx()) > > > en

Re: [PATCH v17 18/23] platform/x86: Intel SGX driver

2018-11-24 Thread Dr. Greg
On Sat, Nov 24, 2018 at 09:21:14AM -0800, Jarkko Sakkinen wrote: > On Thu, Nov 22, 2018 at 07:21:08AM -0800, Andy Lutomirski wrote: > > > At a high level, addressing these issues is straight forward. First, > > > the driver needs to support authorization equivalent to that which is > > > implement

[GIT PULL] HID fixes

2018-11-24 Thread Jiri Kosina
Linus, please pull from git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-linus to receive HID subsystem fixes = - revert of the high-resolution scrolling feature, as it breaks certain hardware due to incompatibilities between Logitech and Microsoft worlds. Peter Hutterer

Re: [PING 2] [PATCH] jffs2: Fix use of uninitialized delayed_work, lockdep breakage

2018-11-24 Thread Richard Weinberger
On Sat, Nov 24, 2018 at 4:32 PM Daniel Santos wrote: > > Ping 2! > > On 11/05/2018 03:38 PM, Daniel Santos wrote: > > Ping. > > > > Daniel > > > > On 10/21/2018 07:32 PM, Hou Tao wrote: > >> On 2018/10/19 16:30, Daniel Santos wrote: > >>> jffs2_sync_fs makes the assumption that if CONFIG_JFFS2_FS_

Re: [RFC PATCH] of: make MAX_RESERVED_REGIONS configurable

2018-11-24 Thread Rob Herring
On Wed, Nov 21, 2018 at 8:51 PM Miles Chen wrote: > > On Wed, 2018-11-21 at 10:39 -0600, Rob Herring wrote: > > On Wed, Nov 21, 2018 at 2:11 AM wrote: > > > > > > From: Miles Chen > > > > > > When we use more than 32 entries in /resered-memory, > > > there will be an error message: "not enough s

[PATCH] fat: Replaced 11 magic to MSDOS_NAME for volume label

2018-11-24 Thread Carmeli Tamir
The FAT file system volume label file stored in the root directory should match the volume label field in the FAT boot sector. As consequence, the max length of these fields ought to be the same. This patch replaces the magic '11' usef in the struct fat_boot_sector with MSDOS_NAME, which is used in

[PATCH 0/3] add support for Sensirion SPS30 PM sensor

2018-11-24 Thread Tomasz Duszynski
This patch series adds support for Sensirion SPS30 particulate matter sensor. Along with a driver itself, new channel type and two modifiers for distinguishing between coarse and fine particles measurements are introduced. Sensor datasheet can be downloaded from https://www.sensirion.com/fileadmi

[PATCH 3/3] iio: chemical: sps30: add device tree support

2018-11-24 Thread Tomasz Duszynski
Add device tree support for Sensirion SPS30 particulate matter sensor. Signed-off-by: Tomasz Duszynski --- .../bindings/iio/chemical/sensirion,sps30.txt| 12 1 file changed, 12 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/chemical/sensirion,sps30.

[PATCH 1/3] iio: add IIO_MASSCONCENTRATION channel type

2018-11-24 Thread Tomasz Duszynski
Measuring particulate matter in ug / m3 (micro-grams per cubic meter) is de facto standard. Existing air quality sensors usually follow this convention and are capable of returning measurements using this unit. IIO currently does not offer suitable channel type for this type of measurements hence

[PATCH 2/3] iio: chemical: add support for Sensirion SPS30 sensor

2018-11-24 Thread Tomasz Duszynski
Add support for Sensirion SPS30 particulate matter sensor. Signed-off-by: Tomasz Duszynski --- drivers/iio/chemical/Kconfig | 11 ++ drivers/iio/chemical/Makefile | 1 + drivers/iio/chemical/sps30.c | 359 ++ 3 files changed, 371 insertions(+) create mode 10

Re: [GIT PULL] HID fixes

2018-11-24 Thread pr-tracker-bot
The pull request you sent on Sat, 24 Nov 2018 21:19:35 +0100 (CET): > git://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-linus has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/e195ca6cb6f21633e56322d5aa11ed59cdb22fb2 Thank you! -- Deet-doot-dot, I am a bot.

[PATCH V2] namei: free new_dentry late

2018-11-24 Thread Pan Bian
After calling dput(new_dentry), new_dentry is passed to fsnotify_move. This may result in a use-after-free bug. This patch moves the put operation late. Fixes: da1ce0670c14("vfs: add cross-rename") Signed-off-by: Pan Bian --- V2: correct the fixes commit information --- fs/namei.c | 2 +- 1 file

Re: [PATCH -next 1/2] mm/memfd: make F_SEAL_FUTURE_WRITE seal more robust

2018-11-24 Thread Andrew Morton
On Thu, 22 Nov 2018 15:09:06 -0800 Joel Fernandes wrote: > Android uses ashmem for sharing memory regions. We are looking forward to > migrating all usecases of ashmem to memfd so that we can possibly remove > the ashmem driver in the future from staging while also benefiting from > using memfd

Re: [PATCH -next 1/2] mm/memfd: make F_SEAL_FUTURE_WRITE seal more robust

2018-11-24 Thread Matthew Wilcox
On Sat, Nov 24, 2018 at 04:42:29PM -0800, Andrew Morton wrote: > This changelog doesn't have the nifty test case code which was in > earlier versions? Why do we put regression tests in the changelogs anyway? We have tools/testing/selftests/vm/ already, perhaps they should go there?

[PATCH] ext2: fix potential use after free

2018-11-24 Thread Pan Bian
The function ext2_xattr_set calls brelse(bh) to drop the reference count of bh. After that, bh may be freed. However, following brelse(bh), it reads bh->b_data via macro HDR(bh). This may result in a use-after-free bug. This patch moves brelse(bh) after reading field. Signed-off-by: Pan Bian ---

[PATCH v3 0/3] ptrace: add PTRACE_GET_SYSCALL_INFO request

2018-11-24 Thread Elvira Khabirova
PTRACE_GET_SYSCALL_INFO lets ptracer obtain details of the syscall the tracee is blocked in. The request succeeds when the tracee is in a syscall-enter-stop, syscall-exit-stop or PTRACE_EVENT_SECCOMP stop, and fails with -EINVAL otherwise. There are two reasons for a special syscall-related ptrac

  1   2   >