Re: [PATCH] mm: simplify get_next_ra_size

2018-10-28 Thread Gao Xiang
Hi Fengguang, On 2018/10/28 14:27, Fengguang Wu wrote: > Looks good to me, thanks! > > Reviewed-by: Fengguang Wu  Thanks for taking time and the quickly review. :) Best regards, Gao Xiang > > On Sun, Oct 28, 2018 at 02:13:26PM +0800, Gao Xiang wrote: >> It's a trivial simplification for get_n

Re: [PATCH] staging: olpc_dcon: olpc_dcon_xo_1.c: Switch to the gpio descriptor interface

2018-10-28 Thread kbuild test robot
/linux/commits/Nishad-Kamdar/staging-olpc_dcon-olpc_dcon_xo_1-c-Switch-to-the-gpio-descriptor-interface/20181028-124517 config: i386-allmodconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config to linux build tree make ARCH=i386

[for-next][PATCH 18/18] tracing: Have stack tracer trace full stack

2018-10-28 Thread Steven Rostedt
From: "Steven Rostedt (VMware)" The stack tracer traces every function call checking the current stack (in non interrupt context), looking for the deepest stack, and saving it when it finds a new max depth. The problem is that it calls save_stack_trace(), and with the new ORC unwinder, it can ski

[for-next][PATCH 17/18] tracing: Export trace_dump_stack to modules

2018-10-28 Thread Steven Rostedt
From: Nikolay Borisov There is no reason for this function to be unexprted and it's a useful debugging aid. Link: http://lkml.kernel.org/r/1539759103-5923-1-git-send-email-nbori...@suse.com Signed-off-by: Nikolay Borisov Signed-off-by: Steven Rostedt (VMware) --- kernel/trace/trace.c | 1 +

[for-next][PATCH 16/18] tracing: probeevent: Fix uninitialized used of offset in parse args

2018-10-28 Thread Steven Rostedt
From: "Steven Rostedt (VMware)" Dan's smatch utility found an uninitialized use of offset in a path in parse_probe_args(). Unless an offset is specifically specified for commands that allow them, it should default to zero. Link: http://lkml.kernel.org/r/20181012134246.5doqaobxunlqqs53@mwanda Fix

[for-next][PATCH 11/18] x86: ptrace: Add function argument access API

2018-10-28 Thread Steven Rostedt
From: Masami Hiramatsu Add regs_get_argument() which returns N th argument of the function call. Note that this chooses most probably assignment, in some case it can be incorrect (e.g. passing data structure or floating point etc.) This is expected to be called from kprobes or ftrace with regs w

[for-next][PATCH 15/18] tracing/kprobes: Allow kprobe-events to record module symbol

2018-10-28 Thread Steven Rostedt
From: Masami Hiramatsu Allow kprobe-events to record module symbols. Since data symbols in a non-loaded module doesn't exist, it fails to define such symbol as an argument of kprobe-event. But if the kprobe event is defined on that module, we can defer to resolve the symbol address. Note that i

[for-next][PATCH 10/18] tracing: probeevent: Add array type support

2018-10-28 Thread Steven Rostedt
From: Masami Hiramatsu Add array type support for probe events. This allows user to get arraied types from memory address. The array type syntax is TYPE[N] Where TYPE is one of types (u8/16/32/64,s8/16/32/64, x8/16/32/64, symbol, string) and N is a fixed value less than 64. The string

[for-next][PATCH 01/18] tracing: probeevent: Cleanup print argument functions

2018-10-28 Thread Steven Rostedt
From: Masami Hiramatsu Cleanup the print-argument function to decouple it into print-name and print-value, so that it can support more flexible expression, like array type. Link: http://lkml.kernel.org/r/152465859635.26224.13452846788717102315.stgit@devbox Signed-off-by: Masami Hiramatsu Sign

[for-next][PATCH 03/18] tracing: probeevent: Remove NOKPROBE_SYMBOL from print functions

2018-10-28 Thread Steven Rostedt
From: Masami Hiramatsu Remove unneeded NOKPROBE_SYMBOL from print functions since the print functions are only used when printing out the trace data, and not from kprobe handler. Link: http://lkml.kernel.org/r/152465865422.26224.10111548170594014954.stgit@devbox Signed-off-by: Masami Hiramatsu

[for-next][PATCH 04/18] tracing: probeevent: Introduce new argument fetching code

2018-10-28 Thread Steven Rostedt
From: Masami Hiramatsu Replace {k,u}probe event argument fetching framework with switch-case based. Currently that is implemented with structures, macros and chain of function-pointers, which is more complicated than necessary and may get a performance penalty by retpoline. This simplify that wi

[for-next][PATCH 12/18] tracing: probeevent: Add $argN for accessing function args

2018-10-28 Thread Steven Rostedt
From: Masami Hiramatsu Add $argN special fetch variable for accessing function arguments. This allows user to trace the Nth argument easily at the function entry. Note that this returns most probably assignment of registers and stacks. In some case, it may not work well. If you need to access co

[for-next][PATCH 14/18] tracing/kprobes: Check the probe on unloaded module correctly

2018-10-28 Thread Steven Rostedt
From: Masami Hiramatsu Current kprobe event doesn't checks correctly whether the given event is on unloaded module or not. It just checks the event has ":" in the name. That is not enough because if we define a probe on non-exist symbol on loaded module, it allows to define that (with warning me

[for-next][PATCH 09/18] tracing: probeevent: Add symbol type

2018-10-28 Thread Steven Rostedt
From: Masami Hiramatsu Add "symbol" type to probeevent, which is an alias of u32 or u64 (depends on BITS_PER_LONG). This shows the result value in symbol+offset style. This type is only available with kprobe events. Link: http://lkml.kernel.org/r/152465882860.26224.14779072294412467338.stgit@de

[for-next][PATCH 13/18] tracing/uprobes: Fix to return -EFAULT if copy_from_user failed

2018-10-28 Thread Steven Rostedt
From: Masami Hiramatsu Fix probe_mem_read() to return -EFAULT if copy_from_user() failed. The copy_from_user() returns remaining bytes when it failed, but probe_mem_read() caller expects it returns error code like as probe_kernel_read(). Link: http://lkml.kernel.org/r/153547306719.26502.8353484

[for-next][PATCH 07/18] tracing: probeevent: Append traceprobe_ for exported function

2018-10-28 Thread Steven Rostedt
From: Masami Hiramatsu Append traceprobe_ for exported function set_print_fmt() as same as other functions. Link: http://lkml.kernel.org/r/152465877071.26224.11143125027282999726.stgit@devbox Signed-off-by: Masami Hiramatsu Signed-off-by: Steven Rostedt (VMware) --- kernel/trace/trace_kprob

[for-next][PATCH 08/18] tracing: probeevent: Unify fetch_insn processing common part

2018-10-28 Thread Steven Rostedt
From: Masami Hiramatsu Unify the fetch_insn bottom process (from stage 2: dereference indirect data) from kprobe and uprobe events, since those are mostly same. Link: http://lkml.kernel.org/r/152465879965.26224.8547240824606804815.stgit@devbox Signed-off-by: Masami Hiramatsu Signed-off-by: St

[for-next][PATCH 02/18] tracing: probeevent: Cleanup argument field definition

2018-10-28 Thread Steven Rostedt
From: Masami Hiramatsu Cleanup event argument definition code in one place for maintenancability. Link: http://lkml.kernel.org/r/152465862529.26224.9068605421476018902.stgit@devbox Signed-off-by: Masami Hiramatsu Signed-off-by: Steven Rostedt (VMware) --- kernel/trace/trace_kprobe.c | 32 ++

[for-next][PATCH 05/18] tracing: probeevent: Unify fetch type tables

2018-10-28 Thread Steven Rostedt
From: Masami Hiramatsu Unify {k,u}probe_fetch_type_table to probe_fetch_type_table because the main difference of those type tables (fetcharg methods) are gone. Now we can consolidate it. Link: http://lkml.kernel.org/r/152465871274.26224.13999436317830479698.stgit@devbox Signed-off-by: Masami

[for-next][PATCH 00/18] tracing: For this merge window

2018-10-28 Thread Steven Rostedt
I've been hammering this for some time, and Like this in this merge window. git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git for-next Head SHA1: a2acce536921bd793bae13fa344fcea157638e72 Masami Hiramatsu (15): tracing: probeevent: Cleanup print argument functions

[for-next][PATCH 06/18] tracing: probeevent: Return consumed bytes of dynamic area

2018-10-28 Thread Steven Rostedt
From: Masami Hiramatsu Cleanup string fetching routine so that returns the consumed bytes of dynamic area and store the string information as data_loc format instead of data_rloc. This simplifies the fetcharg loop. Link: http://lkml.kernel.org/r/152465874163.26224.12125143907501289031.stgit@dev

[PATCH v8] Add support for LPASS clock controller for SDM845

2018-10-28 Thread Taniya Das
[v8] * Add CLK_IS_CRITICAL for GCC lpass clocks for lpass clocks access to go through always. [v7] * Cleanup header file inclusions. * Move the comments along with the flags. * Update the commit with details for CLK_IGNORE_UNUSED. [v6] * Update the logic to register the lpass clock

[PATCH v8] clk: qcom: Add lpass clock controller driver for SDM845

2018-10-28 Thread Taniya Das
Add support for the lpass clock controller found on SDM845 based devices. This would allow lpass peripheral loader drivers to control the clocks to bring the subsystem out of reset. LPASS clocks present on the global clock controller would be registered with the clock framework based on the device

[PATCH v6 0/3] staging: iio: ad2s1210: Switch to the gpio descriptor interface.

2018-10-28 Thread Nishad Kamdar
Use the gpiod interface instead of the deprecated old non-descriptor Changes in v6: - Split device tree table addition and device tree support addition in two patches. - Replace platform data with device tree support. - Rename boolean property. Changes in v5: - Add device tree support. -

[PATCH v6 1/3] staging: iio: ad2s1210: Switch to the gpio descriptor interface

2018-10-28 Thread Nishad Kamdar
Use the gpiod interface instead of the deprecated old non-descriptor interface. Signed-off-by: Nishad Kamdar --- drivers/staging/iio/resolver/ad2s1210.c | 92 ++--- drivers/staging/iio/resolver/ad2s1210.h | 3 - 2 files changed, 50 insertions(+), 45 deletions(-) diff --git

Re: [Outreachy kernel] [RESEND PATCH 2/2] staging: vboxvideo: Use unsigned int instead bool

2018-10-28 Thread Himanshu Jha
Hi Sasha, On Fri, Oct 26, 2018 at 04:42:25PM -0400, Sasha Levin wrote: > On Fri, Oct 26, 2018 at 04:04:45PM -0300, Shayenne da Luz Moura wrote: > > This change was suggested by checkpath.pl. Use unsigned int with bitfield > > allocate only one bit to the boolean variable. > > > > CHECK: Avoid usi

[PATCH v6 2/3] staging: iio: ad2s1210: Add device tree table.

2018-10-28 Thread Nishad Kamdar
Add device tree table for matching vendor ID. Signed-off-by: Nishad Kamdar --- drivers/staging/iio/resolver/ad2s1210.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/staging/iio/resolver/ad2s1210.c b/drivers/staging/iio/resolver/ad2s1210.c index 93c3c70ce62e..0234869e9d74 10

[PATCH v6 3/3] staging: iio: ad2s1210: Add device tree support.

2018-10-28 Thread Nishad Kamdar
Replace platform data with device tree support. Signed-off-by: Nishad Kamdar --- drivers/staging/iio/resolver/Kconfig| 1 + drivers/staging/iio/resolver/ad2s1210.c | 17 - drivers/staging/iio/resolver/ad2s1210.h | 17 - 3 files changed, 9 insertions(+), 26 de

Re: [PATCH 0/2] tracing: Fix synthetic event parser

2018-10-28 Thread Steven Rostedt
On Mon, 22 Oct 2018 00:07:50 +0900 Masami Hiramatsu wrote: > Hi, > > I found another bug in synthetic event. This is a small fix, but > confusingly, there is also a bug in a test case. > > Steve, since the testcase bugfix ([2/2]) breaks the test result > unless corresponding fix ([1/2]), I woul

Re: [PATCH 0/2] tracing: Fix synthetic event parser

2018-10-28 Thread Steven Rostedt
On Sun, 28 Oct 2018 04:01:35 -0400 Steven Rostedt wrote: > I'll add them on top of my linux-next code, and include them in the > pull request I'm hoping to do on Tuesday. Bah, I think this is on a different branch, and that will make it go as a separate pull. Anyway, it probably will still be on

Re: [PATCH 0/7] staging: vc04_services: Some dead code removal

2018-10-28 Thread Stefan Wahren
Hi Dave, > Dave Stevenson hat am 26. Oktober 2018 um > 19:15 geschrieben: > > > Thanks Stefan. > I've picked up your latest patches which mean I can get the driver > loaded via the (almost) approved method. > I do seem to still have issues with not getting the expected address > ranges, so the

Re: INFO: rcu detected stall in do_idle

2018-10-28 Thread Juri Lelli
On 27/10/18 12:16, Dmitry Vyukov wrote: > On Wed, Oct 24, 2018 at 1:03 PM, Juri Lelli wrote: > > > > On 19/10/18 22:50, luca abeni wrote: > > > On Fri, 19 Oct 2018 13:39:42 +0200 > > > Peter Zijlstra wrote: > > > > > > > On Thu, Oct 18, 2018 at 01:08:11PM +0200, luca abeni wrote: > > > > > Ok, I

Re: [Outreachy kernel] [RESEND PATCH 2/2] staging: vboxvideo: Use unsigned int instead bool

2018-10-28 Thread Julia Lawall
> The "possible alignement issues" in CHECK report is difficult to figure > out by just doing a glance analysis. :) > > Linus also suggested to use bool as the base type i.e., `bool x:1` but > again sizeof(_Bool) is implementation defined ranging from 1-4 bytes. If bool x:1 has the size of bool, t

Re: [PATCH 4/5] staging: rtl8188eu: change return type of rtw_hal_xmit()

2018-10-28 Thread Michael Straube
On 10/28/18 1:08 AM, Joe Perches wrote: On Sat, 2018-10-27 at 15:57 -0700, Joe Perches wrote: On Sat, 2018-10-27 at 22:28 +0200, Michael Straube wrote: The function rtw_hal_xmit() returns true or false. Change the return type from s32 to bool. [] diff --git a/drivers/staging/rtl8188eu/hal/rtl

Re: [Patch v3 03/13] x86/speculation: Add static key for Enhanced IBRS

2018-10-28 Thread Thomas Gleixner
On Fri, 26 Oct 2018, Tim Chen wrote: > On 10/26/2018 09:58 AM, Waiman Long wrote: > >> @@ -386,6 +389,7 @@ static void __init spectre_v2_select_mitigation(void) > >>/* Force it so VMEXIT will restore correctly */ > >>x86_spec_ctrl_base |= SPEC_CTRL_IBRS; > >>

Realtek wifi adapter

2018-10-28 Thread Chris Ward
Does anyone want to add https://www.amazon.co.uk/gp/product/B07C4JQZSP/ref=oh_aui_detailpage_o00_s01?ie=UTF8&psc=1 to the set of modules built with the Linux kernel ? I recently bought one of these. It came with source code for a Linux kernel driver, but it didn't work with the latest OpenSuSE

Re: [PATCH 14/17] prmem: llist, hlist, both plain and rcu

2018-10-28 Thread Steven Rostedt
On Wed, 24 Oct 2018 17:03:01 +0300 Igor Stoppa wrote: > I was hoping that by CC-ing kernel.org, the explicit recipients would > get both the mail directly intended for them (as subsystem > maintainers/supporters) and the rest. > > The next time I'll err in the opposite direction. Please don't

Which SPDX Identifier for files without explicit GPL version

2018-10-28 Thread Michael Straube
Hi, which GPL version should be used in SPDX Identifiers for files that are GPL licensed but do not mention any version? It is not clear to me after reading license-rules.rst. For example: /** * Copyright(c) 2008 - 201

Re: [PATCH] mm: simplify get_next_ra_size

2018-10-28 Thread Matthew Wilcox
On Sun, Oct 28, 2018 at 02:13:26PM +0800, Gao Xiang wrote: > It's a trivial simplification for get_next_ra_size and > clear enough for humans to understand. > > It also fixes potential overflow if ra->size(< ra_pages) is too large. > > Cc: Fengguang Wu > Signed-off-by: Gao Xiang Reviewed-by: M

Re: [PATCH v1 2/2] clk: qcom : dispcc: Add support for display port clocks

2018-10-28 Thread Taniya Das
Hello Stephen, On 2018-10-19 16:04, Taniya Das wrote: Hello Stephen, On 10/10/2018 2:04 AM, Stephen Boyd wrote: Quoting Taniya Das (2018-10-09 06:57:47) diff --git a/drivers/clk/qcom/dispcc-sdm845.c b/drivers/clk/qcom/dispcc-sdm845.c index 0cc4909..6d3136a 100644 --- a/drivers/clk/qcom/dispc

Re: Oops in current tree in i2c

2018-10-28 Thread Hans de Goede
Hi Linus, On 27-10-18 18:08, Linus Torvalds wrote: Julian, Jiri, On my laptop I'm getting a kernel page fault with the current git tree, and I'm tentatively blaming commit 9ee3e06610fd ("HID: i2c-hid: override HID descriptors for certain devices") but that's simply because it's the only t

Re: [PATCH] arch/x86/boot/memory.c: Touched up coding-style issues

2018-10-28 Thread Ingo Molnar
* Jordan Borgner wrote: > Added missing parentheses to sizeof() function in detect_memory_e820(). > > Removed unnecessary braces in detect_memory_e801(). > > Replaced three if-statements with a ternary if-statement and > removed an unnecessary integer variable in detect_memory(). > > This i

Re: [PATCH v3] libata: Apply NOLPM quirk for SAMSUNG MZ7TD256HAFV-000L9

2018-10-28 Thread Hans de Goede
Hi, On 28-10-18 05:13, Diego Viola wrote: On Fri, Oct 26, 2018 at 5:36 PM Diego Viola wrote: On Fri, Oct 26, 2018 at 11:21 AM Jens Axboe wrote: On 10/26/18 7:45 AM, Diego Viola wrote: med_power_with_dipm causes my T450 to freeze with a SAMSUNG MZ7TD256HAFV-000L9 SSD (firmware DXT02L5Q).

Re: [RESEND PATCH 1/2] staging: vboxvideo: Change uint32_t to u32

2018-10-28 Thread Hans de Goede
Hi, On 26-10-18 21:04, Shayenne da Luz Moura wrote: This change was suggested by checkpath.pl. CHECK: Prefer kernel type 'u32' over 'uint32_t' Signed-off-by: Shayenne da Luz Moura So as already mentioned in response to the coverletter of the first posting of this series. The drm headers us

Re: [PATCH] mm: simplify get_next_ra_size

2018-10-28 Thread Gao Xiang
Hi Matthew, On 2018/10/28 18:23, Matthew Wilcox wrote: > On Sun, Oct 28, 2018 at 02:13:26PM +0800, Gao Xiang wrote: >> It's a trivial simplification for get_next_ra_size and >> clear enough for humans to understand. >> >> It also fixes potential overflow if ra->size(< ra_pages) is too large. >> >>

drivers by default (was Re: Another HID problem this merge window..)

2018-10-28 Thread Adam Borowski
On Sat, Oct 27, 2018 at 11:13:17AM -0700, Linus Torvalds wrote: > Ok, so this is a much smaller issue than the i2c one that cause boot > problems, but it's annoying. > > We do *not* enable new random drivers by default. And we most > *definitely* don't do it when they are odd-ball ones that most p

Re: [Outreachy kernel] [RESEND PATCH 2/2] staging: vboxvideo: Use unsigned int instead bool

2018-10-28 Thread Himanshu Jha
On Sun, Oct 28, 2018 at 09:47:15AM +0100, Julia Lawall wrote: > > The "possible alignement issues" in CHECK report is difficult to figure > > out by just doing a glance analysis. :) > > > > Linus also suggested to use bool as the base type i.e., `bool x:1` but > > again sizeof(_Bool) is implementat

Re: Which SPDX Identifier for files without explicit GPL version

2018-10-28 Thread Greg Kroah-Hartman
On Sun, Oct 28, 2018 at 11:04:06AM +0100, Michael Straube wrote: > Hi, > > which GPL version should be used in SPDX Identifiers for files that > are GPL licensed but do not mention any version? It is not clear to > me after reading license-rules.rst. > > For example: > > /***

Re: [Outreachy kernel] [RESEND PATCH 2/2] staging: vboxvideo: Use unsigned int instead bool

2018-10-28 Thread Julia Lawall
On Sun, 28 Oct 2018, Himanshu Jha wrote: > On Sun, Oct 28, 2018 at 09:47:15AM +0100, Julia Lawall wrote: > > > The "possible alignement issues" in CHECK report is difficult to figure > > > out by just doing a glance analysis. :) > > > > > > Linus also suggested to use bool as the base type i.e.

Re: [PATCH v3 2/3] iio: adc128s052: add ACPI _HID AANT1280

2018-10-28 Thread Jonathan Cameron
On Sat, 27 Oct 2018 22:44:28 +0530 Himanshu Jha wrote: > Hi Dan, > > On Thu, Oct 25, 2018 at 04:35:41PM +0100, Dan O'Donovan wrote: > > From: Nicola Lunghi > > > > ACPI _HID AANT1280 matches an ADC124S101 present on E3940 SKUs of the UP > > Squared board. > > > > Add it to the driver. > > >

Re: [PATCH v3 2/3] iio: adc128s052: add ACPI _HID AANT1280

2018-10-28 Thread Jonathan Cameron
On Thu, 25 Oct 2018 16:35:41 +0100 Dan O'Donovan wrote: > From: Nicola Lunghi > > ACPI _HID AANT1280 matches an ADC124S101 present on E3940 SKUs of the UP > Squared board. > > Add it to the driver. > > Signed-off-by: Nicola Lunghi > [jav...@emutex.com: fix up commit message and one checkpatc

Re: [PATCH v3 3/3] iio: adc128s052: use SPDX-License-Identifier

2018-10-28 Thread Jonathan Cameron
On Thu, 25 Oct 2018 16:35:42 +0100 Dan O'Donovan wrote: > This updates the ti-adc128s052.c file to use SPDX-License-Identifier > instead of more verbose license text. > > Signed-off-by: Dan O'Donovan Applied, Thanks, Jonathan > --- > drivers/iio/adc/ti-adc128s052.c | 5 + > 1 file chan

Re: [PATCH 2/2] dt-bindings: iio: adc: Add docs for AD7606 ADC

2018-10-28 Thread Jonathan Cameron
On Thu, 25 Oct 2018 13:43:26 -0500 Rob Herring wrote: > On Thu, Oct 18, 2018 at 12:12:36PM +0300, Stefan Popa wrote: > > Document support for AD7606 Analog to Digital Converter. > > > > Signed-off-by: Stefan Popa > > --- > > .../devicetree/bindings/iio/adc/adi,ad7606.txt | 51 > >

[PATCH v1 1/4] perf cs-etm: Generate branch sample for exception packet

2018-10-28 Thread Leo Yan
The exception packet appears as one element with 'elem_type' == OCSD_GEN_TRC_ELEM_EXCEPTION or OCSD_GEN_TRC_ELEM_EXCEPTION_RET, which present for exception entry and exit respectively. The decoder set packet fields 'packet->exc' and 'packet->exc_ret' to indicate the exception packets; but exceptio

[PATCH v1 0/4] perf cs-etm: Add support for sample flags

2018-10-28 Thread Leo Yan
This patch seris adds support for sample flags so can facilitate perf to print sample flags for branch instruction. The branch instructions also include exception taken and return related instructions, so the first patch is used to generate branch sample for exception packets; and the second patch

[PATCH v1 4/4] perf cs-etm: Add support sample flags

2018-10-28 Thread Leo Yan
We have prepared the flags in the packet structure, so need to copy the related value into sample structure thus perf tool can facilitate sample flags. The PREV_PACKET contains the branch instruction flags and PACKET actually contains the flags for next branch instruction. So this patch is to set

[PATCH v1 3/4] perf cs-etm: Set branch instruction flags in packet

2018-10-28 Thread Leo Yan
The perf sample data contains flags to indicate the hardware trace data is belonging to which type branch instruction, thus this can be used to print out the human readable string. Arm CoreSight ETM sample data is missed to set flags and it is always set to zeros, this results in perf tool skips t

[PATCH v1 2/4] perf cs-etm: Track exception number

2018-10-28 Thread Leo Yan
When an exception packet comes, it contains the info for exception number; the exception number indicates the exception types, so from it we can know if the exception is taken for interrupt, system call or other traps, etc. But because the exception return packet cannot delivery exception number c

Re: [PATCH v3] libata: Apply NOLPM quirk for SAMSUNG MZ7TD256HAFV-000L9

2018-10-28 Thread Diego Viola
Hi Hans, On Sun, Oct 28, 2018 at 7:48 AM Hans de Goede wrote: > > Hi, > > On 28-10-18 05:13, Diego Viola wrote: > > On Fri, Oct 26, 2018 at 5:36 PM Diego Viola wrote: > >> > >> On Fri, Oct 26, 2018 at 11:21 AM Jens Axboe wrote: > >>> > >>> On 10/26/18 7:45 AM, Diego Viola wrote: > med_powe

Re: [PATCH v2 1/4] x86/mm: surround level4_kernel_pgt with #ifdef CONFIG_X86_5LEVEL...#endif

2018-10-28 Thread Changbin Du
On Sun, Oct 28, 2018 at 10:44:46AM +0900, Masahiro Yamada wrote: > On Fri, Oct 19, 2018 at 9:50 PM Du Changbin wrote: > > > > The level4_kernel_pgt is only defined when X86_5LEVEL is enabled. So > > surround level4_kernel_pgt with #ifdef CONFIG_X86_5LEVEL...#endif to > > make code correct. > > Fo

Re: [PATCH v2 4/4] kernel hacking: new config CC_OPTIMIZE_FOR_DEBUGGING to apply GCC -Og optimization

2018-10-28 Thread Changbin Du
On Sun, Oct 28, 2018 at 11:28:24AM +0900, Masahiro Yamada wrote: > On Fri, Oct 19, 2018 at 9:50 PM Du Changbin wrote: > > > > This will apply GCC '-Og' optimization level which is supported > > since GCC 4.8. This optimization level offers a reasonable level > > of optimization while maintaining f

[PATCH 2/2] clocksource: meson6_timer: implement ARM delay timer

2018-10-28 Thread Martin Blumenstingl
Implement an ARM delay timer to be used for udelay(). This allows us to skip the delay loop calibration at boot. With this patch udelay() is now independent of CPU frequency changes. This is a good thing on Meson8, Meson8b and Meson8m2 because changing the CPU frequency requires running the CPU cl

[PATCH 0/2] clocksource/meson6_timer: implement ARM delay timer

2018-10-28 Thread Martin Blumenstingl
While trying to add support for the ARM TWD Timer and the ARM Global Timer on Meson8, Meson8b and Meson8m2 (ARM Cortex-A5 and Cortex-A9 SoCs) I did a review of the existing driver. Unfortunately I found it hard to review because the pre-processor #defines did not match the names from the public S80

[PATCH 1/2] clocksource: meson6_timer: use register names from the datasheet

2018-10-28 Thread Martin Blumenstingl
This makes the driver use the names from S805 datasheet for the preprocessor #defines. This makes it easier to spot that the driver currently only supports Timer A (as clockevent with interrupt support) and Timer E (as clocksource without interrupts). Timer B, C and D (which are similar to Timer A)

Re: [RFC PATCH v2 01/17] OPP: Allow to request stub voltage regulators

2018-10-28 Thread Dmitry Osipenko
On 10/26/18 6:37 PM, Lucas Stach wrote: > Am Freitag, den 26.10.2018, 15:03 +0300 schrieb Dmitry Osipenko: > [...] >>> On the other hand, the tegra20 cpufreq driver is common across a lot of >>> boards. >>> What will happen if the DT for some of the boards isn't correct and missed >>> the >>> nec

[PATCH v3 4/4] kernel hacking: new config CC_OPTIMIZE_FOR_DEBUGGING to apply GCC -Og optimization

2018-10-28 Thread Changbin Du
This will apply GCC '-Og' optimization level which is supported since GCC 4.8. This optimization level offers a reasonable level of optimization while maintaining fast compilation and a good debugging experience. It is similar to '-O1' while perferring to keep debug ability over runtime speed. If

[PATCH v3 0/4] kernel hacking: GCC optimization for better debug experience (-Og)

2018-10-28 Thread Changbin Du
Hi all, I have posted this series several months ago but interrupted by personal affairs. Now I get time to complete this task. Thanks for all of the reviewers. I know some kernel developers was searching for a method to dissable GCC optimizations, probably they want to apply GCC '-O0' option. But

[PATCH v3 1/4] x86/mm: declare check_la57_support() as inline

2018-10-28 Thread Changbin Du
The level4_kernel_pgt is only defined when X86_5LEVEL is enabled. So declare check_la57_support() as inline to make sure the code referring to level4_kernel_pgt is optimized out. This is a preparation for CONFIG_CC_OPTIMIZE_FOR_DEBUGGING. Signed-off-by: Changbin Du Cc: Steven Rostedt (VMware) Cc

Re: [PATCH v2 4/4] kernel hacking: new config CC_OPTIMIZE_FOR_DEBUGGING to apply GCC -Og optimization

2018-10-28 Thread Masahiro Yamada
Hi Changbin, On Sun, Oct 28, 2018 at 9:52 PM Changbin Du wrote: > > > Thanks for pointing this out and kind suggestions. I have tested with your > modification. Will update patch serias soon. I have one more request. The patch subject "kernel hacking: new config CC_OPTIMIZE_FOR_DEBUGGING to a

[PATCH v3 2/4] kernel hacking: new config NO_AUTO_INLINE to disable compiler auto-inline optimizations

2018-10-28 Thread Changbin Du
This patch add a new kernel hacking option NO_AUTO_INLINE. Selecting this option will prevent the compiler from optimizing the kernel by auto-inlining functions not marked with the inline keyword. With this option, only functions explicitly marked with "inline" will be inlined. This will allow the

[PATCH v3 3/4] ARM: mm: fix build error in fix_to_virt with CONFIG_CC_OPTIMIZE_FOR_DEBUGGING

2018-10-28 Thread Changbin Du
With '-Og' optimization level, GCC would not optimize a count for a loop as a constant value. But BUILD_BUG_ON() only accept compile-time constant values. Let's use __fix_to_virt() to avoid the error. arch/arm/mm/mmu.o: In function `fix_to_virt': /home/changbin/work/linux/./include/asm-generic/fix

[PATCH] arch: x86: Touched up patterns of 'sizeof' functions

2018-10-28 Thread Jordan Borgner
Addded missing parentheses to 'sizeof()' functions in arch/x86/. Like this: Before: 'sizeof x' After: 'sizeof(x)' Done by motivation of Ingo Molnar. Signed-off-by: Jordan Borgner --- linux-4.19/arch/x86/boot/cpucheck.c | 2 +- linux-4.19/arch/x86/boot/early_serial_console.c | 4

Re: [PATCH v2 2/4] kernel hacking: new config NO_AUTO_INLINE to disable compiler auto-inline optimizations

2018-10-28 Thread Masahiro Yamada
On Fri, Oct 19, 2018 at 9:50 PM Du Changbin wrote: > > This patch add a new kernel hacking option NO_AUTO_INLINE. Selecting > this option will prevent the compiler from optimizing the kernel by > auto-inlining functions not marked with the inline keyword. > > With this option, only functions expli

Re: [PATCH v2 4/4] kernel hacking: new config CC_OPTIMIZE_FOR_DEBUGGING to apply GCC -Og optimization

2018-10-28 Thread Changbin Du
On Sun, Oct 28, 2018 at 10:09:21PM +0900, Masahiro Yamada wrote: > Hi Changbin, > > On Sun, Oct 28, 2018 at 9:52 PM Changbin Du wrote: > > > > > > Thanks for pointing this out and kind suggestions. I have tested with your > > modification. Will update patch serias soon. > > > I have one more r

Re: Which SPDX Identifier for files without explicit GPL version

2018-10-28 Thread Michael Straube
On 10/28/18 12:27 PM, Greg Kroah-Hartman wrote: On Sun, Oct 28, 2018 at 11:04:06AM +0100, Michael Straube wrote: Hi, which GPL version should be used in SPDX Identifiers for files that are GPL licensed but do not mention any version? It is not clear to me after reading license-rules.rst. For e

Re: [PATCH v2 09/10] irqchip: ti-sci-inta: Add support for Interrupt Aggregator driver

2018-10-28 Thread Marc Zyngier
Hi Lokesh, On Fri, 26 Oct 2018 21:19:41 +0100, Lokesh Vutla wrote: > > Hi Marc, > > [..snip..] > >> [...] > >> > > +/** > > + * ti_sci_inta_register_event() - Register a event to an interrupt > > aggregator > > + * @dev: Device pointer to source generating the event > >>

[git pull] m68k updates for 4.20

2018-10-28 Thread Geert Uytterhoeven
Hi Linus, The following changes since commit 5b394b2ddf0347bef56e50c69a58773c94343ff3: Linux 4.19-rc1 (2018-08-26 14:11:59 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/geert/linux-m68k.git tags/m68k-for-v4.20-tag1 for you to fetch ch

Re: Which SPDX Identifier for files without explicit GPL version

2018-10-28 Thread Greg Kroah-Hartman
On Sun, Oct 28, 2018 at 02:22:40PM +0100, Michael Straube wrote: > On 10/28/18 12:27 PM, Greg Kroah-Hartman wrote: > > On Sun, Oct 28, 2018 at 11:04:06AM +0100, Michael Straube wrote: > > > Hi, > > > > > > which GPL version should be used in SPDX Identifiers for files that > > > are GPL licensed b

Re: [alsa-devel] [PATCH v2] staging: bcm2835-audio: interpolate audio delay

2018-10-28 Thread Mike Brady
Hi Kirill. Thanks for the post. Mike > On 25 Oct 2018, at 18:20, Kirill Marinushkin wrote: > > Hello Takashi, Mike, > > @Takashi > > On 10/25/18 09:37, Takashi Iwai wrote: >> Well, in the API POV, it's nothing wrong to keep hwptr sticking while >> updating only delay value. It implies that th

Re: [alsa-devel] [PATCH v2] staging: bcm2835-audio: interpolate audio delay

2018-10-28 Thread Mike Brady
> On 25 Oct 2018, at 08:37, Takashi Iwai wrote: > > On Thu, 25 Oct 2018 00:02:34 +0200, > Kirill Marinushkin wrote: >> When you play sound - the pointer increments. >>> >>> Unfortunately, when you play sound, the pointer does not actually >>> increment, for up to about 10 milliseconds.

[PATCH] Blacklist SAMSUNG MZ7TD256HAFV-000L9 SSD

2018-10-28 Thread Diego Viola
med_power_with_dipm still causes freezes after updating the firmware to the latest version (DXT04L5Q). Set model_rev to NULL and blacklist the device. Signed-off-by: Diego Viola --- drivers/ata/libata-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ata/libata-

Re: [PATCH v3 3/5] nfc: pn533: add UART phy driver

2018-10-28 Thread Johan Hovold
On Sun, Oct 28, 2018 at 02:46:24PM +0100, Marcel Holtmann wrote: > >> +#define VERSION "0.1" > > > > We don't version kernel drivers individually, so please drop this here > > and below. > > if we don’t then maybe send patches to remove MODULE_VERSION first. > Otherwise this is totally fine to d

Re: [PATCH v6 1/3] staging: iio: ad2s1210: Switch to the gpio descriptor interface

2018-10-28 Thread Jonathan Cameron
On Sun, 28 Oct 2018 13:21:25 +0530 Nishad Kamdar wrote: > Use the gpiod interface instead of the deprecated old non-descriptor > interface. > > Signed-off-by: Nishad Kamdar Hi Nishad, Sorry it took me most of the week to get to this. It's a trade off when you want to make fast progress, but I

Re: [PATCH v6 3/3] staging: iio: ad2s1210: Add device tree support.

2018-10-28 Thread Jonathan Cameron
On Sun, 28 Oct 2018 13:23:23 +0530 Nishad Kamdar wrote: > Replace platform data with device tree support. > > Signed-off-by: Nishad Kamdar The whole gpio in or out thing makes less and less sense to me and seems to contradict the datasheet. If I'm not missing something I would just get rid of

Re: [PATCH v5 2/2] staging: iio: ad2s1210: Add device tree support.

2018-10-28 Thread Jonathan Cameron
On Sat, 27 Oct 2018 17:49:03 +0200 Slawomir Stepien wrote: > Hi > > On paź 26, 2018 18:55, Nishad Kamdar wrote: > > Add device tree table for matching vendor ID > > and support for retrieving platform data > > from device tree. > > So maybe you should make 2 commits? > > > Signed-off-by: Nis

Re: [PATCH 1/2] staging: iio: ad5933: Remove unnecessary space on casting

2018-10-28 Thread Jonathan Cameron
On Mon, 22 Oct 2018 17:40:25 -0300 Victor Colombo wrote: > This patch fixes the checkpatch.pl warning: > > WARNING: No space is necessary after a cast > > Signed-off-by: Victor Colombo Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it and se

Hello

2018-10-28 Thread Mr Fawaz Al Saleh
Please can you contact me for a transaction.

Re: [PATCH 2/2] staging: iio: ad5933: Remove unnecessary blank line

2018-10-28 Thread Jonathan Cameron
On Mon, 22 Oct 2018 17:41:27 -0300 Victor Colombo wrote: > This patch fixes the checkpatch.pl warning: > > WARNING: Blank lines aren't necessary before a close brace '}' > > Signed-off-by: Victor Colombo Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to

Re: [PATCH] Blacklist SAMSUNG MZ7TD256HAFV-000L9 SSD

2018-10-28 Thread Hans de Goede
Hi, On 28-10-18 15:34, Diego Viola wrote: med_power_with_dipm still causes freezes after updating the firmware to the latest version (DXT04L5Q). Set model_rev to NULL and blacklist the device. Signed-off-by: Diego Viola Thank you for the patch. Reviewed-by: Hans de Goede Regards, Hans

Re: [PATCH v5 3/3] clk: meson: add sub MMC clock controller driver

2018-10-28 Thread Jianxin Pan
Hi Jerome, On 2018/10/25 20:54, Jerome Brunet wrote: > On Thu, 2018-10-25 at 19:48 +0800, Jianxin Pan wrote: >> Hi Jerome, >> >> On 2018/10/24 17:01, Jerome Brunet wrote: >>> On Thu, 2018-10-18 at 13:07 +0800, Jianxin Pan wrote: From: Yixun Lan The patch will add a MMC clock contro

Re: [PATCH v3 1/3] iio: adc128s052: Add pin-compatible IDs

2018-10-28 Thread Jonathan Cameron
On Thu, 25 Oct 2018 16:35:40 +0100 Dan O'Donovan wrote: > From: Javier Arteaga > > The datasheets for ADC122S021 and ADC124S021 list two more > pin-compatible alternatives for each device. > > Add their IDs as compatible strings. > > Suggested-by: Jonathan Cameron > Signed-off-by: Javier Art

Re: [PATCH v5 04/11] dt-bindings: iio: adc: add AXP803 ADC bindings

2018-10-28 Thread Jonathan Cameron
On Wed, 24 Oct 2018 08:56:33 -0500 Rob Herring wrote: > On Tue, 23 Oct 2018 21:53:23 +0300, Oskari Lemmela wrote: > > The AXP803 ADC is compatible with AXP813 ADC, but add > > specific compatible for it. > > > > Signed-off-by: Oskari Lemmela > > --- > > Documentation/devicetree/bindings/iio/ad

Re: [PATCH] pstore: Remove duplicate invoking of persistent_ram_zap()

2018-10-28 Thread Kees Cook
On Sat, Oct 27, 2018 at 9:52 AM, Peng15 Wang 王鹏 wrote: > > > >>From: Kees Cook >>Sent: Friday, October 26, 2018 17:44 >>To: Peng15 Wang 王鹏 >>Cc: an...@enomsg.org; ccr...@android.com; tony.l...@intel.com; >>linux-kernel@vger.kernel.org >>Subject: Re: [PATC

Re: [PATCH v2 1/2] staging: iio: ad7780: update voltage on read

2018-10-28 Thread Jonathan Cameron
On Thu, 25 Oct 2018 19:30:04 -0300 Renato Lui Geh wrote: > The ad7780 driver previously did not read the correct device output, as > it read an outdated value set at initialization. It now updates its > voltage on read. > > Signed-off-by: Renato Lui Geh > --- > drivers/staging/iio/adc/ad7780.c

Re: [PATCH v2 2/2] staging: iio: ad7780: fix offset read value

2018-10-28 Thread Jonathan Cameron
On Thu, 25 Oct 2018 19:30:37 -0300 Renato Lui Geh wrote: > Variable val subtracted an uninitialized value on IIO_CHAN_INFO_OFFSET. > This was fixed by assigning the correct value instead. > > Signed-off-by: Renato Lui Geh It obviously doesn't make much difference, but as you are respinning any

Re: [PATCH v2] pstore: Avoid duplicate call of persistent_ram_zap()

2018-10-28 Thread Kees Cook
On Sat, Oct 27, 2018 at 2:08 PM, Peng15 Wang 王鹏 wrote: > When initialing prz with invalid data in buffer(no PERSISTENT_RAM_SIG), > function call path is like this: > > ramoops_init_prz -> > | > |-> persistent_ram_new -> persistent_ram_post_init -> persistent_ram_zap > | > |-> persistent_ram_zap >

[PATCH] regulator: bd718x7: Remove double indirection for bd718xx_pmic_inits.rdatas

2018-10-28 Thread Geert Uytterhoeven
With gcc 4.1: drivers/regulator/bd718x7-regulator.c: In function ‘bd718xx_probe’: drivers/regulator/bd718x7-regulator.c:1020: warning: initialization from incompatible pointer type drivers/regulator/bd718x7-regulator.c:1024: warning: initialization from incompatible pointer type App

Re: linux-next: Signed-off-by missing for commit in the c6x tree

2018-10-28 Thread Mark Salter
On Sun, 2018-10-28 at 15:53 +1100, Stephen Rothwell wrote: > Hi Mark, > > Commit > > fe381767b94f ("c6x: switch to NO_BOOTMEM") > > is missing a Signed-off-by from its committer. > Oops, fixed.

Re: [PATCH v3 1/5] x86/vdso: Renames variable to fix shadow warning.

2018-10-28 Thread Masahiro Yamada
Hi Ingo, On Wed, Oct 24, 2018 at 1:04 PM Leonardo Bras wrote: > > The go32() and go64() functions have an argument and a local variable > called ‘name’. Rename both to clarify the code and to fix a warning > with -Wshadow. > > Signed-off-by: Leonardo Bras Please take care of this in x86 tree

Re: [PATCH v3 2/5] kbuild: Removes unnecessary shadowed local variable.

2018-10-28 Thread Masahiro Yamada
On Wed, Oct 24, 2018 at 1:04 PM Leonardo Bras wrote: > > Removes an unnecessary shadowed local variable (start). > It was used only once, with the same value it was started before > the if block. > > Signed-off-by: Leonardo Bras Applied to linux-kbuild with some fixups in the subject. Please

  1   2   3   >