Re: [PATCH V3 01/10] PM / Domains: Rename genpd virtual devices as virt_dev

2018-10-25 Thread Ulf Hansson
On 25 October 2018 at 07:52, Viresh Kumar wrote: > There are several struct device instances that genpd core handles. The > most common one is the consumer device structure, which is named > (correctly) as "dev" within genpd core. The second one is the genpd's > device structure, referenced as gen

Re: [PATCH V3 07/10] OPP: Add dev_pm_opp_{set|put}_genpd_virt_dev() helper

2018-10-25 Thread Ulf Hansson
On 25 October 2018 at 07:52, Viresh Kumar wrote: > Multiple generic power domains for a consumer device are supported with > the help of virtual devices, which are created for each consumer device > - genpd pair. These are the device structures which are attached to the > power domain and are requ

Re: [PATCH V3 09/10] OPP: Rename and relocate of_genpd_opp_to_performance_state()

2018-10-25 Thread Ulf Hansson
On 25 October 2018 at 07:52, Viresh Kumar wrote: > The OPP core already has the performance state values for each of the > genpd's OPPs and there is no need to call the genpd callback again to > get the performance state for the case where the end device doesn't have > an OPP table and has the "re

Re: [PATCH V3 10/10] OPP: Remove of_dev_pm_opp_find_required_opp()

2018-10-25 Thread Ulf Hansson
On 25 October 2018 at 07:52, Viresh Kumar wrote: > This isn't used anymore, remove it. > > Signed-off-by: Viresh Kumar Reviewed-by: Ulf Hansson Kind regards Uffe > --- > drivers/opp/of.c | 54 -- > include/linux/pm_opp.h | 5 > 2 files chan

Re: [PATCH V3 08/10] OPP: Configure all required OPPs

2018-10-25 Thread Ulf Hansson
On 25 October 2018 at 07:52, Viresh Kumar wrote: > Now that all the infrastructure is in place to support multiple required > OPPs, lets switch over to using it. > > A new internal routine _set_required_opps() takes care of updating > performance state for all the required OPPs. With this the perf

Re: [PATCH v2 2/5] mfd: lochnagar: Add support for the Cirrus Logic Lochnagar

2018-10-25 Thread Charles Keepax
On Thu, Oct 25, 2018 at 11:12:48AM +0100, Mark Brown wrote: > On Thu, Oct 25, 2018 at 10:28:16AM +0100, Richard Fitzgerald wrote: > > On 25/10/18 09:26, Charles Keepax wrote: > > > On Thu, Oct 25, 2018 at 08:44:59AM +0100, Lee Jones wrote: > > > I really feel this isn't the driver you are objecting

Re: Crash report: Broken NUMA distance map causes crash on arm64 system

2018-10-25 Thread John Garry
On 23/10/2018 11:30, John Garry wrote: Hi all, I have stumbled upon this crash on my arm64 system: JFYI, I bisected this issue to the following patch: commit 58d5af59d55b4e9f3015207afa6a6648e9b005b1 Author: Suravee Suthikulpanit Date: Thu Sep 7 02:20:05 2017 -0500 sched/topology: Int

Re: [PATCH 1/2] mm/zsmalloc.c: check encoded object value overflow for PAE

2018-10-25 Thread Rafael David Tinoco
On Thu, Oct 25, 2018 at 2:29 AM, Sergey Senozhatsky wrote: > On (10/24/18 22:27), Rafael David Tinoco wrote: >> static unsigned long location_to_obj(struct page *page, unsigned int >> obj_idx) >> { >> - unsigned long obj; >> + unsigned long obj, pfn; >> + >> + pfn = page_to_pfn(page

Re: [PATCH v2 1/3] mfd: upboard: Add UP2 platform controller driver

2018-10-25 Thread Lee Jones
On Sat, 20 Oct 2018, Andy Shevchenko wrote: > On Fri, Oct 19, 2018 at 8:26 PM Dan O'Donovan wrote: > > > > From: Javier Arteaga > > > > UP Squared (UP2) is a x86 SBC from AAEON based on Intel Apollo Lake. It > > features a MAX 10 FPGA that routes lines from both SoC and on-board > > devices to t

Re: [RFC][PATCH 00/11] common implementation of dirent file types

2018-10-25 Thread Jan Kara
On Wed 24-10-18 09:43:21, Amir Goldstein wrote: > Once all comments are addressed and assuming no objections, you have > two possible ways forward: > > 1. Wait for VFS maintainer to take the common code and patches ACKed > by individual maintainers (Al practically maintains some of the small f

Re: BUG: KMSAN: uninit-value in selinux_socket_bind, selinux_socket_connect_helper

2018-10-25 Thread Alexander Potapenko
On Thu, Oct 25, 2018 at 12:35 PM Kyungtae Kim wrote: > > We report two crashes related (in v4.19-rc8) : > "BUG: KMSAN: uninit-value in selinux_socket_bind" > "BUG: KMSAN: uninit-value in selinux_socket_connect_helper” > > kernel config: https://kt0755.github.io/etc/config-4.19-rc2.kmsan > repro: h

Re: [PATCH anybus v1 3/4] bus: support HMS Anybus-S bus.

2018-10-25 Thread Linus Walleij
Hi Sven, thanks for your patch! On Wed, Oct 24, 2018 at 4:25 PM Sven Van Asbroeck wrote: > This driver implementation is designed to be almost completely independent > from the way the Anybus-S hardware is accessed by the SoC. All it needs is: > > - a regmap which accesses the underlying Anybus

Re: [PATCH v4 2/2] sched/fair: update scale invariance of PELT

2018-10-25 Thread Dietmar Eggemann
On 10/25/18 12:43 PM, Vincent Guittot wrote: On Thu, 25 Oct 2018 at 12:36, Dietmar Eggemann wrote: [...] I have a couple of questions related to the tests you ran. On a hikey (octo ARM platform). Performance cpufreq governor and only shallowest c-state to remove variance generated by those

[PATCH 09/37] perf evsel: Mark a evsel as disabled when asking the kernel do disable it

2018-10-25 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo Because there may be more such events in the ring buffer that should be discarded when an app decides to stop considering them. At some point we'll do this with eBPF, this way we stop them at origin, before they are placed in the ring buffer. Cc: Adrian Hunter Cc

[PATCH 05/37] perf arm64: Fix generate system call table failed with /tmp mounted with noexec

2018-10-25 Thread Arnaldo Carvalho de Melo
From: Hongxu Jia When /tmp is mounted with noexec, mksyscalltbl fails. [snip] |perf-1.0/tools/perf/arch/arm64/entry/syscalls//mksyscalltbl: /tmp/create-table-6VGPSt: Permission denied [snip] Add variable TMPDIR as prefix dir of the temporary file, if it is set, replace default /tmp. Si

[PATCH 03/37] perf jitdump: Add Sparc support.

2018-10-25 Thread Arnaldo Carvalho de Melo
From: David Miller Signed-off-by: David S. Miller Link: http://lkml.kernel.org/r/20181016.211545.1487970139012324624.da...@davemloft.net Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/arch/sparc/Makefile | 2 ++ tools/perf/util/genelf.h | 6 ++ 2 files changed, 8 insertions(

[PATCH 07/37] perf trace: Introduce --max-events

2018-10-25 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo Allow stopping tracing after a number of events take place, considering strace-like syscalls formatting as one event per enter/exit pair or when in a multi-process tracing session a syscall is interrupted and printed ending with '...'. Examples included in the docu

[PATCH 04/37] perf symbols: Set PLT entry/header sizes properly on Sparc

2018-10-25 Thread Arnaldo Carvalho de Melo
From: David Miller Using the sh_entsize for both values isn't correct. It happens to be correct on x86... For both 32-bit and 64-bit sparc, there are four PLT entries in the PLT section. Signed-off-by: David S. Miller Cc: Alexander Shishkin Cc: Alexis Berlemont Cc: David Tolnay Cc: Hanjun

[PATCH 10/37] perf trace: Drop addr_location refcounts

2018-10-25 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo When we use machine__resolve() we grab a reference to addr_location.thread (and in the future to other elements there) via machine__findnew_thread(), so we must pair that with addr_location__put(), else we'll never drop that thread when it exits and no other remaini

[PATCH 13/37] perf script: Allow extended console debug output

2018-10-25 Thread Arnaldo Carvalho de Melo
From: Milian Wolff The script tool isn't using a browser, yet use_browser wasn't set explicitly to zero. This in turn lead to confusing output such as: ``` $ perf script -vvv ... ... overlapping maps in /home/milian/foobar (disable tui for more info) ... ``` Explicitly set use_brows

[PATCH 00/37] perf/core improvements and fixes

2018-10-25 Thread Arnaldo Carvalho de Melo
ailable in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-4.20-20181025 for you to fetch changes up to fe57120e18a1f9124ca758c89cc54f91333d1847: perf script: Support total cycles count (2018-10-24 15:2

[PATCH 12/37] perf stat: Poll for monitored tasks being alive

2018-10-25 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa Adding the check for tasks we monitor via -p/-t options, and finish stat if there's no longer task to monitor. Requested-by: Stephane Eranian Signed-off-by: Jiri Olsa Cc: Alexander Shishkin Cc: Jin Yao Cc: Namhyung Kim Cc: Peter Zijlstra Tested-by: Arnaldo Carvalho de Melo

[PATCH 01/37] perf record: Encode -k clockid frequency into Perf trace

2018-10-25 Thread Arnaldo Carvalho de Melo
From: Alexey Budankov Store -k clockid frequency into Perf trace to enable timestamps derived metrics conversion into wall clock time on reporting stage. Below is the example of perf report output: tools/perf/perf record -k raw -- ../../matrix/linux/matrix.gcc ... [ perf record: Captured

[PATCH 11/37] perf trace: Drop thread refcount in trace__event_handler()

2018-10-25 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo We must pair: thread = machine__findnew_thread(); with thread__put(thread). Fix it. Cc: Adrian Hunter Cc: David Ahern Cc: Jiri Olsa Cc: Namhyung Kim Cc: Wang Nan Fixes: c4191e55b874 ("perf trace: Show comm and tid for tracepoint events") Link: https://lkm

[PATCH 18/37] perf scripts python: call-graph-from-sql.py: Set a minimum window size

2018-10-25 Thread Arnaldo Carvalho de Melo
From: Adrian Hunter Prevent weirdly small window size. Committer testing: Seems to work, but even before this patch, on my system, it always started with: xwininfo: Window id: 0x1e2 "Call Graph: pt_example" Width: 800 Height: 600 Signed-off-by: Adrian Hunter Tested-by: Arnaldo Carv

[PATCH 06/37] tools lib subcmd: Introduce OPTION_ULONG

2018-10-25 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo For completeness, will be used in 'perf trace --max-events'. Cc: Adrian Hunter Cc: Andi Kleen Cc: David Ahern Cc: Jiri Olsa Cc: Josh Poimboeuf Cc: Kim Phillips Cc: Namhyung Kim Cc: Wang Nan Link: https://lkml.kernel.org/n/tip-glaj3pwespxfj2fdjs9a2...@git.ke

[PATCH 08/37] perf evsel: Introduce per event max_events property

2018-10-25 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo This simply adds the field to 'struct perf_evsel' and allows setting it via the event parser, to test it lets trace trace: First look at where in a function that receives an evsel we can put a probe to read how evsel->max_events was setup: # perf probe -x ~/bin/

[PATCH 23/37] perf scripts python: call-graph-from-sql.py: Remove use of setObjectName()

2018-10-25 Thread Arnaldo Carvalho de Melo
From: Adrian Hunter The object name is never used, so don't bother setting it. Signed-off-by: Adrian Hunter Cc: Andi Kleen Cc: Jiri Olsa Link: http://lkml.kernel.org/r/20181001062853.28285-9-adrian.hun...@intel.com Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/scripts/python/call-g

[PATCH 15/37] perf trace: Introduce per-event maximum number of events property

2018-10-25 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo Call it 'nr', as in this context it should be expressive enough, i.e.: # perf trace -e sched:*waking/nr=8,call-graph=fp/ 0.000 :0/0 sched:sched_waking:comm=rcu_sched pid=10 prio=120 target_cpu=001 try_to_wake_up ([kerne

[PATCH 16/37] perf scripts python: call-graph-from-sql.py: Use SPDX license identifier

2018-10-25 Thread Arnaldo Carvalho de Melo
From: Adrian Hunter Use SPDX license identifier in call-graph-from-sql.py. Signed-off-by: Adrian Hunter Cc: Andi Kleen Cc: Jiri Olsa Link: http://lkml.kernel.org/r/20181001062853.28285-2-adrian.hun...@intel.com Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/scripts/python/call-graph

[PATCH 22/37] perf scripts python: call-graph-from-sql.py: Add a class for global data

2018-10-25 Thread Arnaldo Carvalho de Melo
From: Adrian Hunter Keep global data in a single object that is easy to pass around as needed, without polluting the global namespace. Signed-off-by: Adrian Hunter Cc: Andi Kleen Cc: Jiri Olsa Link: http://lkml.kernel.org/r/20181001062853.28285-8-adrian.hun...@intel.com Signed-off-by: Arnaldo

[PATCH 14/37] perf script: Flush output stream after events in verbose mode

2018-10-25 Thread Arnaldo Carvalho de Melo
From: Milian Wolff When the perf script output is written to a terminal stream, the normal output of `perf script` would get buffered, but its debug output would be written directly. This made it quite hard to figure out where a given debug output is coming from. We can improve on this by flushi

[PATCH 20/37] perf scripts python: call-graph-from-sql.py: Make a "Main" function

2018-10-25 Thread Arnaldo Carvalho de Melo
From: Adrian Hunter Make a "Main" function so that the variables used do not pollute the global namespace. Signed-off-by: Adrian Hunter Cc: Andi Kleen Cc: Jiri Olsa Link: http://lkml.kernel.org/r/20181001062853.28285-6-adrian.hun...@intel.com Signed-off-by: Arnaldo Carvalho de Melo --- tool

[PATCH 21/37] perf scripts python: call-graph-from-sql.py: Separate the database details into a class

2018-10-25 Thread Arnaldo Carvalho de Melo
From: Adrian Hunter Separate the database details into a class that can provide different connections using the same connection information. That paves the way for sub-processes that require their own connection. Signed-off-by: Adrian Hunter Cc: Andi Kleen Cc: Jiri Olsa Link: http://lkml.ker

[PATCH 19/37] perf scripts python: call-graph-from-sql.py: Change icon

2018-10-25 Thread Arnaldo Carvalho de Melo
From: Adrian Hunter There are not many standard icons, but the computer icon looks slightly better than the information icon. Committer testing: Noticed the change on the icon on the gnome menu right next to the "Activities" menu, looks nicer indeed. Signed-off-by: Adrian Hunter Tested-by: Ar

[PATCH 37/37] perf script: Support total cycles count

2018-10-25 Thread Arnaldo Carvalho de Melo
From: Andi Kleen For 'perf script' brstackinsn also print a running cycles count. This makes it easier to calculate cycle deltas for code sections measured with LBRs. % perf record -b -a sleep 1 % perf script -F +brstackinsn ... 7f73ecc41083insn: 74 06 #

[PATCH 32/37] perf scripts python: exported-sql-viewer.py: Add All branches report

2018-10-25 Thread Arnaldo Carvalho de Melo
From: Adrian Hunter Add a report to display branches in a similar fashion to perf script. The main purpose of this report is to display disassembly, however, presently, the only supported disassembler is Intel XED, and additionally the object code must be present in perf build ID cache. To use I

[PATCH 26/37] perf scripts python: call-graph-from-sql.py: Refactor TreeItem class

2018-10-25 Thread Arnaldo Carvalho de Melo
From: Adrian Hunter class TreeItem represents items at all levels of the call-graph tree. However, not all the levels represent the same data i.e. the top-level is comms, the next level is threads, and subsequent levels are functions. Consequently it is simpler to have separate classes for differ

[PATCH 28/37] perf scripts python: exported-sql-viewer.py: Add support for multiple sub-windows

2018-10-25 Thread Arnaldo Carvalho de Melo
From: Adrian Hunter Use Qt MDI (multiple document interface) to support multiple sub-windows. Put the data model in a cache so that each sub-window can share the same data. This allows mutiple views of the call-graph at the same time and paves the way to add more reports. Committer testing: Sta

[PATCH 27/37] perf scripts python: call-graph-from-sql.py: Rename to exported-sql-viewer.py

2018-10-25 Thread Arnaldo Carvalho de Melo
From: Adrian Hunter Additional reports will be added to the script so rename to reflect the more general purpose. Signed-off-by: Adrian Hunter Cc: Andi Kleen Cc: Jiri Olsa Link: http://lkml.kernel.org/r/20181001062853.28285-13-adrian.hun...@intel.com Signed-off-by: Arnaldo Carvalho de Melo -

[PATCH 36/37] perf script: Implement --graph-function

2018-10-25 Thread Arnaldo Carvalho de Melo
From: Andi Kleen Add a ftrace style --graph-function argument to 'perf script' that allows to print itrace function calls only below a given function. This makes it easier to find the code of interest in a large trace. % perf record -e intel_pt//k -a sleep 1 % perf script --graph-function group_

[PATCH 35/37] tools script: Add --call-trace and --call-ret-trace

2018-10-25 Thread Arnaldo Carvalho de Melo
From: Andi Kleen Add short cut options to print PT call trace and call-ret-trace, for calls and call and returns. Roughly corresponds to ftrace function tracer and function graph tracer. Just makes these common use cases nicer to use. % perf record -a -e intel_pt// sleep 1 % perf script --call-

[PATCH 24/37] perf scripts python: call-graph-from-sql.py: Factor out CallGraphModel from TreeModel

2018-10-25 Thread Arnaldo Carvalho de Melo
From: Adrian Hunter Factor out CallGraphModel from TreeModel, which paves the way to reuse TreeModel in future reports. Signed-off-by: Adrian Hunter Cc: Andi Kleen Cc: Jiri Olsa Link: http://lkml.kernel.org/r/20181001062853.28285-10-adrian.hun...@intel.com Signed-off-by: Arnaldo Carvalho de M

[PATCH 25/37] perf scripts python: call-graph-from-sql.py: Add data helper functions

2018-10-25 Thread Arnaldo Carvalho de Melo
From: Adrian Hunter Add helper functions for a few common cases. Signed-off-by: Adrian Hunter Cc: Andi Kleen Cc: Jiri Olsa Link: http://lkml.kernel.org/r/20181001062853.28285-11-adrian.hun...@intel.com Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/scripts/python/call-graph-from-sql

[PATCH 30/37] perf scripts python: exported-sql-viewer.py: Add ability to shrink / enlarge font

2018-10-25 Thread Arnaldo Carvalho de Melo
From: Adrian Hunter Shrinking the font allows more information to display. Committer testing: Works, tested with the convenient Control+Shift+'+' and Control+'-' as well with the more cumbersome top menu "Edit" + "Enlarge/Shrink font" options. Signed-off-by: Adrian Hunter Tested-by: Arnaldo C

[PATCH 33/37] perf script: Add --insn-trace for instruction decoding

2018-10-25 Thread Arnaldo Carvalho de Melo
From: Andi Kleen Add a --insn-trace short hand option for decoding and disassembling instruction streams for intel_pt. This automatically pipes the output into the xed disassembler to generate disassembled instructions. This just makes this use model much nicer to use. Before % perf record -

[PATCH 31/37] perf scripts python: exported-sql-viewer.py: Add ability to display all the database tables

2018-10-25 Thread Arnaldo Carvalho de Melo
From: Adrian Hunter Displaying all the database tables can help make the database easier to understand. Committer testing: Opened all the tables, even the sqlite master table, which I selected everything and used control+C, lets see if it works... CREATE VIEW threads_view AS SELECT id,machin

[PATCH 34/37] perf script: Make itrace script default to all calls

2018-10-25 Thread Arnaldo Carvalho de Melo
From: Andi Kleen By default 'perf script' for itrace outputs sampled instructions or branches. In my experience this is confusing to users because it's hard to correlate with real program behavior. The sampling makes sense for tools like 'perf report' that actually sample to reduce the run time,

[PATCH 29/37] perf scripts python: exported-sql-viewer.py: Add ability to find symbols in the call-graph

2018-10-25 Thread Arnaldo Carvalho de Melo
From: Adrian Hunter Add a Find bar that appears at the bottom of the call-graph window. Committer testing: Using: python tools/perf/scripts/python/exported-sql-viewer.py pt_example branches calls Using the database built in the first "Committer Testing" section in this patch series I was a

Re: [PATCH v14 0/3]: perf: reduce data loss when profiling highly parallel CPU bound workloads

2018-10-25 Thread Arnaldo Carvalho de Melo
Em Thu, Oct 25, 2018 at 10:54:39AM +0200, Jiri Olsa escreveu: > On Thu, Oct 25, 2018 at 10:59:36AM +0300, Alexey Budankov wrote: > > Hi, > > > > On 15.10.2018 13:17, Jiri Olsa wrote: > > > On Mon, Oct 15, 2018 at 09:26:09AM +0300, Alexey Budankov wrote: > > >> > > >> Currently in record mode the t

[PATCH 17/37] perf scripts python: call-graph-from-sql.py: Provide better default column sizes

2018-10-25 Thread Arnaldo Carvalho de Melo
From: Adrian Hunter Set initial column sizes to improve initial display. Committer testing: Extended instructions on testing this, using the sqlite variant: Make sure you have the SQLite glue for python+Qt installed, on fedora 27 I used: # dnf install python-pyside Collect some PT samples,

[PATCH 2/6] ARM: dts: ls1021a: Add the status property disable PCIe

2018-10-25 Thread Xiaowei Bao
Add the status property disable the PCIe, the property will be enable by bootloader. Signed-off-by: Xiaowei Bao --- arch/arm/boot/dts/ls1021a.dtsi |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi index bdd6e

Re: KASAN: use-after-free Read in task_is_descendant

2018-10-25 Thread Oleg Nesterov
On 10/25, Tetsuo Handa wrote: > > Oleg Nesterov wrote: > > On 10/22, Tetsuo Handa wrote: > > > > And again, I do not know how/if yama ensures that child is > > > > rcu-protected, perhaps > > > > task_is_descendant() needs to check pid_alive(child) right after > > > > rcu_read_lock() ? > > > > > >

[PATCH 02/37] perf annotate: Add Sparc support

2018-10-25 Thread Arnaldo Carvalho de Melo
From: David Miller E.g.: $ perf annotate --stdio2 Samples: 7K of event 'cycles:ppp', 4000 Hz, Event count (approx.): 3086733887 __gettimeofday /lib32/libc-2.27.so [Percent: local period] Percent│ │ │ │Disassembly of section .text: │ │

Re: [PATCH] MAINTAINERS: add myself as co-maintainer of gpiolib

2018-10-25 Thread Linus Walleij
On Wed, Oct 24, 2018 at 5:39 PM Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > As discussed with Linus Walleij - I'm adding myself as > the co-maintainer. > > Cc: Benoît Cousson > Cc: Kevin Hilman > Cc: Michael Turquette > Signed-off-by: Bartosz Golaszewski Excellent, patch appl

Re: [PATCH] mmc: sdhci: Conver sdhci_allocate_bounce_buffer() to return void

2018-10-25 Thread Linus Walleij
On Wed, Oct 24, 2018 at 9:19 AM Chunyan Zhang wrote: > The function sdhci_allocate_bounce_buffer() always return zero at > present, so there's no need to have a return value, that will also make > error path easier. > > CC: Linus Walleij > Signed-off-by: Chunyan Zhang Good catch! Reviewed-by:

Re: Call to Action Re: [PATCH 0/7] Code of Conduct: Fix some wording, and add an interpretation document

2018-10-25 Thread Rainer Fiebig
Am Montag, 22. Oktober 2018, 08:20:11 schrieb NeilBrown: > On Sat, Oct 20 2018, Greg Kroah-Hartman wrote: > > Hi all, > > > > As everyone knows by now, we added a new Code of Conduct to the kernel > > tree a few weeks ago. > > I wanted to stay detached from all this, but as remaining (publicly) >

Re: [RFC][PATCH v3 01/10] fs: common implementation of file type

2018-10-25 Thread Jan Kara
On Tue 23-10-18 21:19:53, Phillip Potter wrote: > Many file systems use a copy&paste implementation > of dirent to on-disk file type conversions. > > Create a common implementation to be used by file systems > with some useful conversion helpers to reduce open coded > file type conversions in file

Re: [PATCH v4 2/8] mfd: stpmic1: add stpmic1 driver

2018-10-25 Thread Lee Jones
On Thu, 18 Oct 2018, Pascal PAILLET-LME wrote: > From: pascal paillet > > stpmic1 is a pmic from STMicroelectronics. The STPMIC1 integrates 10 > regulators , 3 switches, a watchdog and an input for a power on key. Same comments as for the DT binding patch. > Signed-off-by: pascal paillet > --

Re: Memory management issue in 4.18.15

2018-10-25 Thread Sasha Levin
On Mon, Oct 22, 2018 at 1:01 PM Michal Hocko wrote: > > On Mon 22-10-18 15:08:22, Roman Gushchin wrote: > [...] > > RE backporting: I'm slightly surprised that only one patch of the memcg > > reclaim fix series has been backported. Either all or none makes much more > > sense to me. > > Yeah, I th

Re: [PATCH 00/10] steal tasks to improve CPU utilization

2018-10-25 Thread Steven Sistare
On 10/25/2018 3:50 AM, Vincent Guittot wrote: > Hi Steve, > > On Mon, 22 Oct 2018 at 17:10, Steve Sistare wrote: >> >> When a CPU has no more CFS tasks to run, and idle_balance() fails to >> find a task, then attempt to steal a task from an overloaded CPU in the >> same LLC. Maintain and use a bi

Re: [PATCH 00/10] steal tasks to improve CPU utilization

2018-10-25 Thread Valentin Schneider
On 24/10/2018 20:27, Steven Sistare wrote: [...] > Hi Valentin, > > Asymmetric systems could maintain a separate bitmap for misfits; set a bit > when a CPU goes on CPU, clear it going off. When a fast CPU goes new idle, > it would first search the misfits mask, then search cfs_overload_cpus. >

Re: [PATCH 4/4] PCI/dwc: Add more than 4GiB range support

2018-10-25 Thread kbuild test robot
/commits/Z-q-Hou/PCI-dwc-Add-more-than-4GiB-range-support/20181025-173802 base: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next config: i386-randconfig-s1-201842 (attached as .config) compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026 reproduce: # save the attached .config to

Re: KASAN: use-after-free Read in task_is_descendant

2018-10-25 Thread Kees Cook
On Thu, Oct 25, 2018 at 12:13 PM, Oleg Nesterov wrote: > So again, suppose that "child" is already dead. Its task_struct can't be > freed, > but child->real_parent can point to the already freed memory. I can't find a path for "child" to be released. I see task_lock() always called on it before

Re: [PATCH] arm64/module: use mod->klp_info section header information

2018-10-25 Thread Jessica Yu
+++ Miroslav Benes [25/10/18 11:00 +0200]: On Thu, 25 Oct 2018, Petr Mladek wrote: On Tue 2018-10-23 19:55:54, Jessica Yu wrote: > The arm64 module loader keeps a pointer into info->sechdrs to keep track > of section header information for .plt section(s). A pointer to the > relevent section he

Re: dcache endless loop in d_invalidate

2018-10-25 Thread Martin Schwidefsky
On Tue, 16 Oct 2018 13:15:28 +0200 Martin Schwidefsky wrote: > In short, this if-statement in select_collect: > > if (dentry->d_flags & DCACHE_SHRINK_LIST) { > data->found++; > } > > with assumption that "somebody else" will do the shrinking seems broken. > > Do

Re: [PATCH v2 2/5] mfd: lochnagar: Add support for the Cirrus Logic Lochnagar

2018-10-25 Thread Lee Jones
On Thu, 25 Oct 2018, Richard Fitzgerald wrote: > On 25/10/18 09:26, Charles Keepax wrote: > > On Thu, Oct 25, 2018 at 08:44:59AM +0100, Lee Jones wrote: > > > On Mon, 08 Oct 2018, Charles Keepax wrote: > > > > From: Charles Keepax > > > > +static const struct reg_default lochnagar1_reg_defaults[]

Re: KASAN: use-after-free Read in task_is_descendant

2018-10-25 Thread Tetsuo Handa
On 2018/10/25 20:13, Oleg Nesterov wrote: > On 10/25, Tetsuo Handa wrote: >> >> Oleg Nesterov wrote: >>> On 10/22, Tetsuo Handa wrote: > And again, I do not know how/if yama ensures that child is rcu-protected, > perhaps > task_is_descendant() needs to check pid_alive(child) right afte

Re: [PATCH v5 3/3] clk: meson: add sub MMC clock controller driver

2018-10-25 Thread Jianxin Pan
Hi Jerome, On 2018/10/24 17:01, Jerome Brunet wrote: > On Thu, 2018-10-18 at 13:07 +0800, Jianxin Pan wrote: >> From: Yixun Lan >> >> The patch will add a MMC clock controller driver which used by MMC or NAND, >> It provide a mux and divider clock, and three phase clocks - core, tx, tx. >> [...]

Re: TSC to Mono-raw Drift

2018-10-25 Thread Miroslav Lichvar
On Wed, Oct 24, 2018 at 01:32:48PM -0400, Christopher Hall wrote: > On Wed, Oct 24, 2018 at 04:51:13PM +0200, Miroslav Lichvar wrote: > > The error is too large to be corrected by stepping on clock updates. > > For a typical TSC frequency we have multiplier in the range of few > > millions, so that

Re: [PATCH v5 2/3] clk: meson: add DT documentation for emmc clock controller

2018-10-25 Thread Jianxin Pan
On 2018/10/25 15:29, Yixun Lan wrote: > Hi Jerome, Jianxin: > > see my comments > > On 10:58 Wed 24 Oct , Jerome Brunet wrote: >> On Thu, 2018-10-18 at 13:07 +0800, Jianxin Pan wrote: >>> From: Yixun Lan >>> >>> Document the MMC sub clock controller driver, the potential consumer >>> of this

Re: KASAN: use-after-free Read in task_is_descendant

2018-10-25 Thread Oleg Nesterov
On 10/25, Kees Cook wrote: > > task_is_descendant() is called under rcu_read_lock() in both > ptracer_exception_found() and yama_ptrace_access_check() so I don't > understand how any of the tasks could get freed? This is walking > group_leader and real_parent -- are these not stable under rcu_lock(

Re: [PATCHv3] panic: avoid deadlocks in re-entrant console drivers

2018-10-25 Thread Sergey Senozhatsky
On (10/25/18 18:51), kbuild test robot wrote: > > [auto build test ERROR on linux-sof-driver/master] > [also build test ERROR on v4.19 next-20181019] > [if your patch is applied to the wrong git tree, please drop us a note to > help improve the system] > My bad, sorry! +#include This should

Re: [PATCH 1/2] mm/zsmalloc.c: check encoded object value overflow for PAE

2018-10-25 Thread Russell King - ARM Linux
On Wed, Oct 24, 2018 at 10:27:44PM -0300, Rafael David Tinoco wrote: > On 32-bit systems, zsmalloc uses HIGHMEM and, when PAE is enabled, the > physical frame number might be so big that zsmalloc obj encoding (to > location) will break IF architecture does not re-define > MAX_PHYSMEM_BITS, causing:

Re: [PATCH] dt-bindings: arm: Fix cpu capacity mismatch in example

2018-10-25 Thread Daniel Lezcano
On 25/10/2018 10:27, Viresh Kumar wrote: > The example text says the capacity value should be 446, while the > example have it set to 578 instead. Fix the mismatch. > > Signed-off-by: Viresh Kumar > --- > Documentation/devicetree/bindings/arm/cpu-capacity.txt | 2 +- > 1 file changed, 1 insertio

Re: KASAN: use-after-free Read in task_is_descendant

2018-10-25 Thread Oleg Nesterov
On 10/25, Kees Cook wrote: > > On Thu, Oct 25, 2018 at 12:13 PM, Oleg Nesterov wrote: > > So again, suppose that "child" is already dead. Its task_struct can't be > > freed, > > but child->real_parent can point to the already freed memory. > > I can't find a path for "child" to be released. I see

Re: KASAN: use-after-free Read in task_is_descendant

2018-10-25 Thread Oleg Nesterov
On 10/25, Tetsuo Handa wrote: > > On 2018/10/25 20:13, Oleg Nesterov wrote: > > > > So again, suppose that "child" is already dead. Its task_struct can't be > > freed, > > but child->real_parent can point to the already freed memory. > > Yes. > > But if child->real_parent is pointing to the alread

Re: [PATCH 00/10] steal tasks to improve CPU utilization

2018-10-25 Thread Steven Sistare
On 10/25/2018 7:31 AM, Valentin Schneider wrote: > > On 24/10/2018 20:27, Steven Sistare wrote: > [...] >> Hi Valentin, >> >> Asymmetric systems could maintain a separate bitmap for misfits; set a bit >> when a CPU goes on CPU, clear it going off. When a fast CPU goes new idle, >> it would first

Re: [PATCH v2] kernel/signal: Signal-based pre-coredump notification

2018-10-25 Thread Eric W. Biederman
Enke Chen writes: > Hi, Eric: > > Thanks for your comments. Please see my replies inline. > > On 10/24/18 6:29 AM, Eric W. Biederman wrote: >> Enke Chen writes: >> >>> For simplicity and consistency, this patch provides an implementation >>> for signal-based fault notification prior to the core

[PATCH v2 0/3] Add reset driver support for ZynqMP

2018-10-25 Thread Nava kishore Manne
This series of patches are created On top of the below repo. git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc.git (fetch) BRANCH: next/drivers Nava kishore Manne (3): firmware: xilinx: Add reset API's dt-bindings: reset: Add bindings for ZynqMP reset driver reset: reset-zynqmp: Add

[PATCH v2 2/3] dt-bindings: reset: Add bindings for ZynqMP reset driver

2018-10-25 Thread Nava kishore Manne
Add documentation to describe Xilinx ZynqMP reset driver bindings. Signed-off-by: Nava kishore Manne --- Changes for v2: -None. Changes for v1: -Created a Seperate(New) DT binding file as suggested by Rob. Changes for RFC-V3: -Cor

[PATCH v2 1/3] firmware: xilinx: Add reset API's

2018-10-25 Thread Nava kishore Manne
This Patch Adds reset API's to support release, assert and status functionalities by using firmware interface. Signed-off-by: Nava kishore Manne --- Changes for v2: -None. Changes for v1: -None. Changes for RFC-V3: -None. Changes for RFC-V2:

[PATCH v2 3/3] reset: reset-zynqmp: Adding support for Xilinx zynqmp reset controller.

2018-10-25 Thread Nava kishore Manne
Add a reset controller driver for Xilinx Zynq UltraScale+ MPSoC. The zynqmp reset-controller has the ability to reset lines connected to different blocks and peripheral in the Soc. Signed-off-by: Nava kishore Manne --- Changes for v2: -Fixed some minor coding issues as suggested

Re: [PATCH 1/2] mm/zsmalloc.c: check encoded object value overflow for PAE

2018-10-25 Thread Rafael David Tinoco
> MAX_PHYSMEM_BITS is a definition for sparsemem, and is only visible > when sparsemem is enabled. When sparsemem is disabled, asm/sparsemem.h > is not included (and should not be included) which means there is no > MAX_PHYSMEM_BITS definition. Missed that part :\, tks. > I don't think zsmalloc.

Re: [PATCH v4 2/8] mfd: stpmic1: add stpmic1 driver

2018-10-25 Thread Benjamin Gaignard
Le jeu. 25 oct. 2018 à 13:21, Lee Jones a écrit : > > On Thu, 18 Oct 2018, Pascal PAILLET-LME wrote: > > > From: pascal paillet > > > > stpmic1 is a pmic from STMicroelectronics. The STPMIC1 integrates 10 > > regulators , 3 switches, a watchdog and an input for a power on key. > > Same comments a

Re: [mm PATCH v3 4/6] mm: Move hot-plug specific memory init into separate functions and optimize

2018-10-25 Thread Michal Hocko
On Wed 24-10-18 10:35:09, Alexander Duyck wrote: > On Wed, 2018-10-24 at 17:27 +0200, Michal Hocko wrote: > > On Wed 24-10-18 08:08:41, Alexander Duyck wrote: > > > On Wed, 2018-10-24 at 14:36 +0200, Michal Hocko wrote: > > > > On Wed 17-10-18 08:26:20, Alexander Duyck wrote: > > > > [...] > > > >

Re: [PATCH 1/2] mm/zsmalloc.c: check encoded object value overflow for PAE

2018-10-25 Thread kbuild test robot
/0day-ci/linux/commits/Rafael-David-Tinoco/mm-zsmalloc-c-check-encoded-object-value-overflow-for-PAE/20181025-110258 base: https://github.com/thesofproject/linux master config: um-allyesconfig (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached

Re: [PATCH 00/10] steal tasks to improve CPU utilization

2018-10-25 Thread Vincent Guittot
On Thu, 25 Oct 2018 at 13:29, Steven Sistare wrote: > > On 10/25/2018 3:50 AM, Vincent Guittot wrote: > > Hi Steve, > > > > On Mon, 22 Oct 2018 at 17:10, Steve Sistare > > wrote: > >> > >> When a CPU has no more CFS tasks to run, and idle_balance() fails to > >> find a task, then attempt to stea

Re: [PATCH v2 2/5] mfd: lochnagar: Add support for the Cirrus Logic Lochnagar

2018-10-25 Thread Charles Keepax
On Thu, Oct 25, 2018 at 12:42:05PM +0100, Lee Jones wrote: > On Thu, 25 Oct 2018, Richard Fitzgerald wrote: > > On 25/10/18 09:26, Charles Keepax wrote: > > > On Thu, Oct 25, 2018 at 08:44:59AM +0100, Lee Jones wrote: > > > > On Mon, 08 Oct 2018, Charles Keepax wrote: > > > > > From: Charles Keepax

Re: [PATCH v5 3/3] clk: meson: add sub MMC clock controller driver

2018-10-25 Thread Jerome Brunet
On Thu, 2018-10-25 at 19:48 +0800, Jianxin Pan wrote: > Hi Jerome, > > On 2018/10/24 17:01, Jerome Brunet wrote: > > On Thu, 2018-10-18 at 13:07 +0800, Jianxin Pan wrote: > > > From: Yixun Lan > > > > > > The patch will add a MMC clock controller driver which used by MMC or > > > NAND, > > > It

Re: [PATCH] leds: gpio: set led_dat->gpiod pointer for OF defined GPIO leds

2018-10-25 Thread Linus Walleij
On Thu, Oct 18, 2018 at 2:14 AM Liviu Dudau wrote: > Commit 45d4c6de4e49 ("leds: gpio: Try to lookup gpiod from device") > removed the common code path that set the led_dat->gpiod pointer in > create_gpio_led(), but only added it back for the devices that have > a valid gpio_led_platform_data str

Re: [PATCH v4 1/8] dt-bindings: mfd: document stpmic1

2018-10-25 Thread Rob Herring
On Thu, Oct 25, 2018 at 4:44 AM Lee Jones wrote: > > Rob: please grep your name for some feedback. > > On Thu, 18 Oct 2018, Pascal PAILLET-LME wrote: > > > From: pascal paillet > > +Optional parent device properties: > > +- st,main-control-register: > > + -bit 1: Power cycling will be perfor

Re: [PATCH] mfd: tps6586x: Handle interrupts on suspend

2018-10-25 Thread Dmitry Osipenko
On 10/24/18 5:19 PM, Jon Hunter wrote: > > On 24/10/2018 13:44, Dmitry Osipenko wrote: >> On 10/24/18 1:49 PM, Jon Hunter wrote: >>> >>> On 22/10/2018 12:19, Dmitry Osipenko wrote: On 10/22/18 12:52 PM, Thierry Reding wrote: > On Fri, Oct 19, 2018 at 02:22:53PM +0100, Jon Hunter wrote: >>

Re: KASAN: use-after-free Read in task_is_descendant

2018-10-25 Thread Oleg Nesterov
On 10/25, Oleg Nesterov wrote: > > As I said below, please ignore ptracer_exception_found(), another caller for > now, > perhaps it needs some changes too. I even have a vague feeling that I have > already > blamed this function some time ago... Heh, yes, 3 years ago ;) https://lore.kernel.org/

Re: [PATCH] leds: gpio: set led_dat->gpiod pointer for OF defined GPIO leds

2018-10-25 Thread Pavel Machek
On Tue 2018-10-23 12:18:44, Liviu Dudau wrote: > On Thu, Oct 18, 2018 at 01:14:32AM +0100, Liviu Dudau wrote: > > Commit 45d4c6de4e49 ("leds: gpio: Try to lookup gpiod from device") > > removed the common code path that set the led_dat->gpiod pointer in > > create_gpio_led(), but only added it back

Re: [PATCH] ARM: dts: imx: Add dummy PHYs for HSIC-only USB controllers

2018-10-25 Thread Fabio Estevam
On Thu, Oct 18, 2018 at 5:00 AM Frieder Schrempf wrote: > > Some SOCs in the i.MX6 family have a USB host controller that is > only capable of the HSIC interface and has no on-board PHY. > > To be able to use these controllers, we need to add "usb-nop-xceiv" > dummy PHYs. > > Signed-off-by: Friede

Re: [PATCH v2 1/3] mfd: upboard: Add UP2 platform controller driver

2018-10-25 Thread Andy Shevchenko
On Thu, Oct 25, 2018 at 12:05:05PM +0100, Lee Jones wrote: > On Sat, 20 Oct 2018, Andy Shevchenko wrote: > > On Fri, Oct 19, 2018 at 8:26 PM Dan O'Donovan wrote: > > > + ret = upboard_init_gpio(dev); > > > + if (ret) { > > > + if (ret != -EPROBE_DEFER) > > > +

Re: KASAN: use-after-free Read in task_is_descendant

2018-10-25 Thread Tetsuo Handa
On 2018/10/25 21:17, Oleg Nesterov wrote: >>> And yes, task_is_descendant() can hit the dead child, if nothing else it can >>> be killed. This can explain the kasan report. >> >> The kasan is reporting that child->real_parent (or maybe >> child->real_parent->real_parent >> or child->real_parent->r

Re: [PATCH v2 2/5] mfd: lochnagar: Add support for the Cirrus Logic Lochnagar

2018-10-25 Thread Charles Keepax
On Thu, Oct 25, 2018 at 01:49:05PM +0100, Charles Keepax wrote: > On Thu, Oct 25, 2018 at 12:42:05PM +0100, Lee Jones wrote: > > On Thu, 25 Oct 2018, Richard Fitzgerald wrote: > > > On 25/10/18 09:26, Charles Keepax wrote: > > > > On Thu, Oct 25, 2018 at 08:44:59AM +0100, Lee Jones wrote: > > > > >

Re: [GIT PULL] MFD for v4.20

2018-10-25 Thread Linus Torvalds
On Tue, Oct 23, 2018 at 3:46 AM Lee Jones wrote: > > git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git mfd-next-4.20 Pulled, Linus

<    1   2   3   4   5   6   7   8   9   >