[PATCH] firewire: core-topology: mark expected switch fall-through

2018-10-12 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Addresses-Coverity-ID: 741234 ("Missing break in switch") Signed-off-by: Gustavo A. R. Silva --- drivers/firewire/core-topology.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drive

Re: [PATCH] x86: entry: flush the cache if syscall error

2018-10-12 Thread Jann Horn
On Fri, Oct 12, 2018 at 5:03 PM Alan Cox wrote: > > > My understanding is that the standard “breadcrumb” is that a cache line is > > fetched into L1D, and that the cacheline in question will go into L1D even > > if it was previously not cached at all. So flushing L1D will cause the > > timing f

Re: [GIT PULL] ARM: SoC fixes for 4.19

2018-10-12 Thread gregkh
On Fri, Oct 12, 2018 at 05:31:17PM +0200, Arnd Bergmann wrote: > The following changes since commit 17b57b1883c1285f3d0dc2266e8f79286a7bef38: > > Linux 4.19-rc6 (2018-09-30 07:15:35 -0700) > > are available in the Git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-s

Re: [PATCH 4.4 00/27] 4.4.161-stable review

2018-10-12 Thread Guenter Roeck
On Thu, Oct 11, 2018 at 05:34:47PM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.4.161 release. > There are 27 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know

Re: [PATCH 4.14 00/45] 4.14.76-stable review

2018-10-12 Thread Guenter Roeck
On Thu, Oct 11, 2018 at 05:39:27PM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.14.76 release. > There are 45 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know

Re: [PATCH V2 6/9] OPP: Add dev_pm_opp_{set|put}_genpd_device() helper

2018-10-12 Thread Viresh Kumar
On 12 October 2018 at 20:16, Ulf Hansson wrote: > On 12 October 2018 at 13:11, Viresh Kumar wrote: >> Multiple generic power domains for a consumer device are supported with >> the help of virtual devices, which are created for each consumer device >> - genpd pair. These are the device structures

Re: [PATCH 4.18 00/44] 4.18.14-stable review

2018-10-12 Thread Guenter Roeck
On Thu, Oct 11, 2018 at 05:39:38PM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.18.14 release. > There are 44 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know

Re: [PATCH] KEYS: trusted: fix -Wvarags warning

2018-10-12 Thread Denis Kenzior
Hi James, So instead of having unsigned char h3, can't we simply have bool h3 or unsigned int h3? Given the ambiguity in the standards, the safe thing that will work for all time and all potential compilers is a char * All right. You state this with certainty, but I'd still like you to ed

Re: [PATCH v3 1/7] dt-bindings: power: supply: axp20x: add AXP813 AC power DT binding

2018-10-12 Thread Rob Herring
On Mon, 8 Oct 2018 21:19:02 +0300, Oskari Lemmela wrote: > The AXP803/AXP813 AC power supply can limit input current and voltage. > > Signed-off-by: Oskari Lemmela > --- > .../devicetree/bindings/power/supply/axp20x_ac_power.txt | 3 +++ > 1 file changed, 3 insertions(+) > Reviewed-by:

Re: livelock with hrtimer cpu_base->lock

2018-10-12 Thread Will Deacon
On Fri, Oct 12, 2018 at 05:55:28AM -0700, Sodagudi Prasad wrote: > On 2018-10-10 09:49, Will Deacon wrote: > >On Tue, Oct 09, 2018 at 01:56:14PM -0700, Sodagudi Prasad wrote: > >>This is regarding - thread "try to fix contention between expire_timers > >>and > >>try_to_del_timer_sync". > >>https://

[GIT PULL] Couple more arm64 fixes for 4.19

2018-10-12 Thread Will Deacon
Hi Greg, Please pull these two arm64 fixes for 4.19. One of them fixes a nasty WARN() that has started triggering because we assumed that memory reservations from firmware would always correspond to regions of the physical address space that we have mapped as memory. Unfortunately, some existing d

Re: [PATCH RFC v1 7/8] drivers: qcom: cpu_pd: Handle cpu hotplug in the domain

2018-10-12 Thread Ulf Hansson
On 12 October 2018 at 17:04, Sudeep Holla wrote: > On Thu, Oct 11, 2018 at 03:06:09PM -0600, Lina Iyer wrote: >> On Thu, Oct 11 2018 at 11:37 -0600, Sudeep Holla wrote: > [...] > >> > >> > Is DDR managed by Linux ? I assumed it was handled by higher exception >> > levels. Can you give examples of

[PATCH] MAINTAINERS: remove reference to bogus vsock file

2018-10-12 Thread Stefan Hajnoczi
The file drivers/vhost/vsock.h never existed. Remove the bogus MAINTAINERS reference. Fixes: 433fc58e6bf2c8bd97e57153ed28e64fd78207b8 ("VSOCK: Introduce vhost_vsock.ko") Reported-by: Joe Perches Signed-off-by: Stefan Hajnoczi --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/

Re: [PATCH] KEYS: trusted: fix -Wvarags warning

2018-10-12 Thread James Bottomley
On Fri, 2018-10-12 at 10:44 -0500, Denis Kenzior wrote: > Hi James, > > > > So instead of having unsigned char h3, can't we simply have bool > > > h3 or unsigned int h3? > > > > Given the ambiguity in the standards, the safe thing that will work > > for all time and all potential compilers is a c

Re: Bad MAINTAINERS pattern in section 'VIRTIO AND VHOST VSOCK DRIVER'

2018-10-12 Thread Stefan Hajnoczi
On Fri, Sep 28, 2018 at 03:05:26PM -0700, Joe Perches wrote: > Please fix this defect appropriately. > > linux-next MAINTAINERS section: > > 15660 VIRTIO AND VHOST VSOCK DRIVER > 15661 M: Stefan Hajnoczi > 15662 L: k...@vger.kernel.org > 15663 L: vi

Re: [PATCH 03/11] x86/fpu: make __raw_xsave_addr() use feature number instead of mask

2018-10-12 Thread Dave Hansen
On 10/04/2018 07:05 AM, Sebastian Andrzej Siewior wrote: > Most users of __raw_xsave_addr() use a feature number, shift it to a > mask and then __raw_xsave_addr() shifts it back to the feature number. > > Make __raw_xsave_addr() use the feature number as argument. This generally looks like a nice

Re: [PATCH] KEYS: trusted: fix -Wvarags warning

2018-10-12 Thread Denis Kenzior
Hi James, From the links provided in the patch it seems that one cannot pass char/float/short to va_start(). Fair enough. So if we make h3 an unsigned int, the issue goes away, no? For the current version of clang, yes. However, if we're fixing this for good a char * pointer is the only g

Re: [RCF PATCH,v2,2/2] pwm: imx: Configure output to GPIO in disabled state

2018-10-12 Thread Thierry Reding
On Fri, Oct 12, 2018 at 03:04:48PM +, Vokáč Michal wrote: > On 12.10.2018 10:57, Uwe Kleine-König wrote: > > On Wed, Oct 10, 2018 at 09:33:26AM +, Vokáč Michal wrote: [...] > >> +static int imx_pwm_init_pinctrl_info(struct imx_chip *imx_chip, > >> + struct platform_device *pdev) >

Re: [PATCHv5 3/7] tty: Hold tty_ldisc_lock() during tty_reopen()

2018-10-12 Thread Dmitry Safonov
Hi Guilherme, Just to let you know - I've done with more urgent issues now, so I'll be back on this patch on Monday, installing qemu-system-hppa and debugging the root case. Thanks, Dmitry On Wed, 2018-10-03 at 07:46 -0300, Guilherme Piccoli wrote: > On Tue, Oct 2, 2018 at 6:33 PM Dmitry Safonov

Re: [RCF PATCH v2 2/2] pwm: imx: Configure output to GPIO in disabled state

2018-10-12 Thread Thierry Reding
On Wed, Oct 10, 2018 at 09:33:26AM +, Vokáč Michal wrote: > Normally the PWM output is held LOW when PWM is disabled. This can cause > problems when inverted PWM signal polarity is needed. With this behavior > the connected circuit is fed by 100% duty cycle instead of being shut-off. > > Allow

Re: [PATCH] KEYS: trusted: fix -Wvarags warning

2018-10-12 Thread James Bottomley
On Fri, 2018-10-12 at 10:53 -0500, Denis Kenzior wrote: > Hi James, > > > > From the links provided in the patch it seems that one cannot > > > pass char/float/short to va_start(). Fair enough. So if we make > > > h3 an unsigned int, the issue goes away, no? > > > > For the current version of

Re: [PATCH v2 3/5] clk: lochnagar: Add support for the Cirrus Logic Lochnagar

2018-10-12 Thread Stephen Boyd
Quoting Charles Keepax (2018-10-11 06:26:02) > On Thu, Oct 11, 2018 at 12:00:46AM -0700, Stephen Boyd wrote: > > Quoting Charles Keepax (2018-10-08 06:25:40) > > > > +struct lochnagar_regmap_clk { > > > + unsigned int cfg_reg; > > > + unsigned int ena_mask; > > > + unsigned int d

Re: [PATCH 0/4] Add clock support for Hi3670 SoC

2018-10-12 Thread Stephen Boyd
Quoting Manivannan Sadhasivam (2018-10-11 20:38:58) > On Thu, Sep 20, 2018 at 11:00:59PM -0700, Manivannan Sadhasivam wrote: > > This patchset adds clock support for Hi3670 SoC from HiSilicon utilizing > > the HiSi common clock code. While adding clock support, let's remove the > > fixed clock for

Re: [PATCH RFC v1 7/8] drivers: qcom: cpu_pd: Handle cpu hotplug in the domain

2018-10-12 Thread Lina Iyer
On Fri, Oct 12 2018 at 09:04 -0600, Sudeep Holla wrote: On Thu, Oct 11, 2018 at 03:06:09PM -0600, Lina Iyer wrote: On Thu, Oct 11 2018 at 11:37 -0600, Sudeep Holla wrote: [...] > > Is DDR managed by Linux ? I assumed it was handled by higher exception > levels. Can you give examples of resour

[PATCH 3/4] gsmi: Remove autoselected dependency on EFI and EFI_VARS

2018-10-12 Thread Ross Zwisler
From: Duncan Laurie Instead of selecting EFI and EFI_VARS automatically when GSMI is enabled let that portion of the driver be conditionally compiled if EFI and EFI_VARS are enabled. This allows the rest of the driver (specifically event log) to be used if EFI_VARS is not enabled. To test: 1) v

[PATCH 1/4] gsmi: Fix bug in append_to_eventlog sysfs handler

2018-10-12 Thread Ross Zwisler
From: Duncan Laurie The sysfs handler should return the number of bytes consumed, which in the case of a successful write is the entire buffer. Also fix a bug where param.data_len was being set to (count - (2 * sizeof(u32))) instead of just (count - sizeof(u32)). The latter is correct because w

[PATCH 0/4] gsmi: Google specific firmware patches

2018-10-12 Thread Ross Zwisler
This series contains some Google specific firmware patches that we've been carrying out of tree. I've updated the changelog for each so that it is suitable for upstream, and I've retested them to make sure I know what the patches are doing. Duncan Laurie (3): gsmi: Fix bug in append_to_eventlog

[PATCH 2/4] gsmi: Add coreboot to list of matching BIOS vendors

2018-10-12 Thread Ross Zwisler
From: Duncan Laurie In order to use this coreboot needs board support for: CONFIG_ELOG=y CONFIG_ELOG_GSMI=y And the kernel driver needs enabled: CONFIG_GOOGLE_GSMI=y To test, verify that clean shutdown event is added to the log: > mosys eventlog list | grep 'Clean Shutdown' 11 | 2012-06-25 09:

[PATCH 4/4] gsmi: Add GSMI commands to log S0ix info

2018-10-12 Thread Ross Zwisler
From: Furquan Shaikh Add new GSMI commands (GSMI_CMD_LOG_S0IX_SUSPEND = 0xa, GSMI_CMD_LOG_S0IX_RESUME = 0xb) that allow firmware to log any information during S0ix suspend/resume paths. Traditional ACPI suspend S3 involves BIOS both during the suspend and the resume paths. However, modern suspen

[PATCH] bcache: fix superblock being corrupted with non-4KB page size

2018-10-12 Thread Guoju Fang
In read_super(), after read super block by __bread(), a page is used to cache the data. But it will cause superblock corrupted when PAGE_SIZE is 8KB or larger, because bh->b_data doesn't always point to the beginning of the page. So use a bio_vec struct to point the superblock cached. Signed-off-

Re: [PATCH 3.18 000/120] 3.18.124-stable review

2018-10-12 Thread Greg Kroah-Hartman
On Fri, Oct 12, 2018 at 08:39:16AM -0700, Guenter Roeck wrote: > On Fri, Oct 12, 2018 at 08:15:06AM -0700, Guenter Roeck wrote: > > On Fri, Oct 12, 2018 at 04:21:10PM +0200, Greg Kroah-Hartman wrote: > > > On Fri, Oct 12, 2018 at 07:06:13AM -0700, Guenter Roeck wrote: > > > > On 10/12/2018 06:37 AM

Re: [PATCH 2/2] clk: add 74aup1g157gw 2-input multiplexer as clock driver

2018-10-12 Thread Stephen Boyd
Quoting Kuninori Morimoto (2018-10-11 17:37:30) > > > + .recalc_rate= clk74_recalc_rate, > > > + .get_parent = clk74_get_parent, > > > +}; > > > > Can this all be handled by the 'gpio-mux-clock' compatible/driver? I > > suppose it may need an update to add the rounding policy t

[PATCH net-next] net: ethernet: ti: cpsw: use for mcast entries only host port

2018-10-12 Thread Ivan Khoronzhuk
In dual-emac mode the cpsw driver sends directed packets, that means that packets go to the directed port, but an ALE lookup is performed to determine untagged egress only. It means that on tx side no need to add port bit for ALE mcast entry mask, and basically ALE entry for port identification is

Re: [PATCH] x86: entry: flush the cache if syscall error

2018-10-12 Thread Andy Lutomirski
On Fri, Oct 12, 2018 at 8:02 AM Alan Cox wrote: > > > My understanding is that the standard “breadcrumb” is that a cache line is > > fetched into L1D, and that the cacheline in question will go into L1D even > > if it was previously not cached at all. So flushing L1D will cause the > > timing f

Re: [PATCH 0/4] Add clock support for Hi3670 SoC

2018-10-12 Thread Manivannan Sadhasivam
On Fri, Oct 12, 2018 at 09:03:29AM -0700, Stephen Boyd wrote: > Quoting Manivannan Sadhasivam (2018-10-11 20:38:58) > > On Thu, Sep 20, 2018 at 11:00:59PM -0700, Manivannan Sadhasivam wrote: > > > This patchset adds clock support for Hi3670 SoC from HiSilicon utilizing > > > the HiSi common clock c

Re: [RCF PATCH,v2,2/2] pwm: imx: Configure output to GPIO in disabled state

2018-10-12 Thread Uwe Kleine-König
Hello, On Fri, Oct 12, 2018 at 03:04:48PM +, Vokáč Michal wrote: > On 12.10.2018 10:57, Uwe Kleine-König wrote: > > On Wed, Oct 10, 2018 at 09:33:26AM +, Vokáč Michal wrote: > >> Normally the PWM output is held LOW when PWM is disabled. This can cause > >> problems when inverted PWM signal

[PATCH] mm/thp: fix call to mmu_notifier in set_pmd_migration_entry()

2018-10-12 Thread jglisse
From: Jérôme Glisse Inside set_pmd_migration_entry() we are holding page table locks and thus we can not sleep so we can not call invalidate_range_start/end() So remove call to mmu_notifier_invalidate_range_start/end() and add call to mmu_notifier_invalidate_range(). Note that we are already cal

Re: [PATCH] gpio/regulator: Allow nonexclusive GPIO access

2018-10-12 Thread Mark Brown
On Thu, Oct 11, 2018 at 08:41:16PM +0200, Linus Walleij wrote: > On Thu, Oct 11, 2018 at 7:54 PM Mark Brown wrote: > > Other regulators that have GPIO control for their enables do their own > > requests (as does the core) so don't they all need to set the flag > > GPIOD_FLAGS_BIT_NONEXCLUSIVE whe

Re: [PATCH RFC v1 7/8] drivers: qcom: cpu_pd: Handle cpu hotplug in the domain

2018-10-12 Thread Lina Iyer
On Fri, Oct 12 2018 at 09:46 -0600, Ulf Hansson wrote: On 12 October 2018 at 17:04, Sudeep Holla wrote: On Thu, Oct 11, 2018 at 03:06:09PM -0600, Lina Iyer wrote: On Thu, Oct 11 2018 at 11:37 -0600, Sudeep Holla wrote: [...] > > Is DDR managed by Linux ? I assumed it was handled by higher e

Re: [PATCH v7] regulator: fixed: Convert to use GPIO descriptor only

2018-10-12 Thread Mark Brown
On Fri, Oct 12, 2018 at 04:58:38PM +0300, Andy Shevchenko wrote: > On Fri, Oct 12, 2018 at 1:45 PM Russell King - ARM Linux > > Given that DT describes the hardware, not the software implementation, > > it must not change just because we move from GPIO numbers to GPIO > > descriptors. > > The exi

Re: [PATCH] mm/thp: fix call to mmu_notifier in set_pmd_migration_entry()

2018-10-12 Thread Zi Yan
On 12 Oct 2018, at 12:09, jgli...@redhat.com wrote: > From: Jérôme Glisse > > Inside set_pmd_migration_entry() we are holding page table locks and > thus we can not sleep so we can not call invalidate_range_start/end() > > So remove call to mmu_notifier_invalidate_range_start/end() and add > call

Re: [PATCH v3 2/9] dt-bindings: ti-lmu: Remove LM3697

2018-10-12 Thread Rob Herring
On Thu, Oct 11, 2018 at 09:38:53PM +0200, Jacek Anaszewski wrote: > On 10/11/2018 08:34 PM, Dan Murphy wrote: > > Pavel > > > > On 10/11/2018 01:27 PM, Pavel Machek wrote: > >> On Thu 2018-10-11 11:51:16, Dan Murphy wrote: > >>> Remove support for the LM3697 LED device > >>> from the ti-lmu. The

Re: [RFC][PATCH] x86: ptrace: Add function argument access API

2018-10-12 Thread Steven Rostedt
Anyone have any issues with this patch? -- Steve On Thu, 11 Oct 2018 23:00:21 -0400 Steven Rostedt wrote: > [ > A while ago I posted an RFC patchset for dynamic function based > events. But Masami pointed out that this could be done with kprobes > with minimal changes. He posted a patc

Re: [PATCH v3 4/9] dt-bindings: leds: Add bindings for lm3697 driver

2018-10-12 Thread Rob Herring
On Thu, Oct 11, 2018 at 11:51:18AM -0500, Dan Murphy wrote: > Add the device tree bindings for the lm3697 > LED driver for backlighting and display. Bindings are for h/w, not drivers... > > Signed-off-by: Dan Murphy > --- > .../devicetree/bindings/leds/leds-lm3697.txt | 98 +++

Re: [PATCH v13 3/3]: perf record: extend trace writing to multi AIO

2018-10-12 Thread Alexey Budankov
Hi, On 12.10.2018 17:17, Jiri Olsa wrote: > On Thu, Oct 11, 2018 at 09:59:19PM +0300, Alexey Budankov wrote: > > SNIP > >> @@ -1490,6 +1514,13 @@ static int perf_record_config(const char *var, const >> char *value, void *cb) >> var = "call-graph.record-mode"; >> return

[PATCH V3] MAINTAINERS: intel_telemetry: Update maintainers info

2018-10-12 Thread David E. Box
Remove Souvik who has left this role. Add Rajneesh and David who work jointly on telemetry updates for new platforms. Signed-off-by: David E. Box Signed-off-by: Rajneesh Bhardwaj --- V3: Change signoff format MAINTAINERS | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --

Re: [RFC PATCH v2 1/4] dt: bindings: Add SD tap value properties details for 'xlnx,zynqmp-8.9a'

2018-10-12 Thread Rob Herring
On Thu, Sep 20, 2018 at 03:00:42PM +0530, Manish Narani wrote: > Add documentation for MIO bank required property and Tap Delays optional > properties in devicetree bindings. > > Signed-off-by: Manish Narani > --- > .../devicetree/bindings/mmc/arasan,sdhci.txt | 19 > ++

Re: [PATCH v1] KVM/x86/vPMU: Guest PMI Optimization

2018-10-12 Thread Andi Kleen
> 4. Results > - Without this optimization, the guest pmi handling time is > ~450 ns, and the max sampling rate is reduced to 250. > - With this optimization, the guest pmi handling time is ~9000 ns > (i.e. 1 / 500 of the non-optimization case), and the max sampling >

Re: [PATCH RFC v1 7/8] drivers: qcom: cpu_pd: Handle cpu hotplug in the domain

2018-10-12 Thread Sudeep Holla
On Fri, Oct 12, 2018 at 05:46:13PM +0200, Ulf Hansson wrote: [...] > > Apologize for sidetracking the discussion, just want to fold in a few > comments. > No need to apologize, you are just contributing to get better understanding of the system. > This is becoming a complicated story. May I sugg

Re: [PATCH v2] regulator/gpio: Allow nonexclusive GPIO access

2018-10-12 Thread Mark Brown
On Fri, Oct 12, 2018 at 04:26:12PM +0200, jacopo mondi wrote: > Sorry, I'm going slightly OT with this, but please read below. > On Fri, Oct 12, 2018 at 02:54:12PM +0200, Linus Walleij wrote: > > This allows nonexclusive (simultaneous) access to a single > > GPIO line for the fixed regulator enab

[PATCH v3 0/3] cpufreq: intel_pstate: Base frequency attribute

2018-10-12 Thread Srinivas Pandruvada
This series presents base frequency to cpufreq sysfs when intel_pstate is in use in HWP mode. Changes: v3: - Update documentation v2 - Removed guaranteed attribute addition to acpi_cppc sysfs - Using the cppc_acpi interface to get base frequency and present Srinivas Pandruvada (3): ACPI / CPPC:

[PATCH v3 2/3] cpufreq: intel_pstate: Add base_frequency attribute

2018-10-12 Thread Srinivas Pandruvada
Present base_frequency to user space via cpufreq sysfs when HWP is in use. This HWP base frequency is read from HWP Capabilities MSR, if platform doesn't have ACPI _CPC object. On most of the HWP platforms the _CPC object will point to the HWP Capabilities MSR using address space id as "Functional

Re: [PATCH V3] MAINTAINERS: intel_telemetry: Update maintainers info

2018-10-12 Thread Joe Perches
On Fri, 2018-10-12 at 09:28 -0700, David E. Box wrote: > Remove Souvik who has left this role. Add Rajneesh and David who work > jointly on telemetry updates for new platforms. > > Signed-off-by: David E. Box > Signed-off-by: Rajneesh Bhardwaj [] > diff --git a/MAINTAINERS b/MAINTAINERS [] > @@

[PATCH] MAINTAINERS: Replace Vince Bridgers as Altera TSE maintainer

2018-10-12 Thread thor . thayer
From: Thor Thayer Vince has moved to a different role. Replace him as Altera TSE maintainer. Signed-off-by: Thor Thayer --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 72429b928626..f02cf78f5394 100644 --- a/MAINTAINERS +++ b/

Re: [PATCH v2 3/5] clk: lochnagar: Add support for the Cirrus Logic Lochnagar

2018-10-12 Thread Mark Brown
On Thu, Oct 11, 2018 at 12:36:22PM -0700, Stephen Boyd wrote: > Quoting Mark Brown (2018-10-11 07:54:22) > > On Thu, Oct 11, 2018 at 12:00:46AM -0700, Stephen Boyd wrote: > > > Is this used for anything besides getting the regmap? Can you get the > > > pointer to the parent in probe and use that t

Re: [PATCH] mm/thp: fix call to mmu_notifier in set_pmd_migration_entry()

2018-10-12 Thread Michal Hocko
On Fri 12-10-18 12:09:53, jgli...@redhat.com wrote: > From: Jérôme Glisse > > Inside set_pmd_migration_entry() we are holding page table locks and > thus we can not sleep so we can not call invalidate_range_start/end() > > So remove call to mmu_notifier_invalidate_range_start/end() and add > cal

Re: [PATCH v3 1/1] scsi: ufs: make UFS Tx lane1 clock optional for QCOM platforms

2018-10-12 Thread Doug Anderson
Hi, On Thu, Oct 11, 2018 at 6:12 PM Can Guo wrote: > + if (err != -EPROBE_DEFER) > + dev_err(dev, "failed to get %s err %d", > + name, err); I wouldn't spin just for this, but if you spin for some other reason you could move the above "dev_err" o

Re: [PATCH] KEYS: trusted: fix -Wvarags warning

2018-10-12 Thread Nick Desaulniers
On Thu, Oct 11, 2018 at 6:50 PM Nathan Chancellor wrote: > > On Thu, Oct 11, 2018 at 01:31:26PM -0700, ndesaulni...@google.com wrote: > > by swapping h2 and h3. > > > > security/keys/trusted.c:146:17: warning: passing an object that > > undergoes default > > argument promotion to 'va_start'

Re: [PATCH v7] regulator: fixed: Convert to use GPIO descriptor only

2018-10-12 Thread Mark Brown
On Fri, Oct 12, 2018 at 11:43:13AM +, Marcel Ziswiler wrote: > On Fri, 2018-10-12 at 11:43 +0100, Russell King - ARM Linux wrote: > > The existing DT description is reasonable, and introducing ficticious > > regulators in DT to work around the implementation is not reasonable. > I don't think

Re: [PATCH] MAINTAINERS: Replace Vince Bridgers as Altera TSE maintainer

2018-10-12 Thread Greg KH
On Fri, Oct 12, 2018 at 11:50:52AM -0500, thor.tha...@linux.intel.com wrote: > From: Thor Thayer > > Vince has moved to a different role. Replace him as Altera > TSE maintainer. > > Signed-off-by: Thor Thayer Would be nice if Vince can ack this...

Re: [PATCHv2] mm/gup: Cache dev_pagemap while pinning pages

2018-10-12 Thread Dan Williams
On Fri, Oct 12, 2018 at 4:00 AM Kirill A. Shutemov wrote: [..] > > Does this have defined behavior? I would feel better with " = { 0 }" > > to be explicit. > > Well, it's not allowed by the standart, but GCC allows this. > You can see a warning with -pedantic. > > We use empty-list initializers a

Applied "regulator/gpio: Allow nonexclusive GPIO access" to the regulator tree

2018-10-12 Thread Mark Brown
The patch regulator/gpio: Allow nonexclusive GPIO access has been applied to the regulator tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) a

Re: [PATCH v2 01/11] dt-bindings: spi/spi-pxa2xx: add PXA2xx SSP SPI Controller

2018-10-12 Thread Mark Brown
On Thu, Oct 11, 2018 at 07:59:15PM +0200, Lubomir Rintel wrote: > On Thu, 2018-10-11 at 15:27 +0100, Mark Brown wrote: > > Please use subject lines matching the style for the subsystem. This > > makes it easier for people to identify relevant patches. > Thanks for the response. > I'm a little c

Applied "regulator: lochnagar: Add support for the Cirrus Logic Lochnagar" to the regulator tree

2018-10-12 Thread Mark Brown
The patch regulator: lochnagar: Add support for the Cirrus Logic Lochnagar has been applied to the regulator tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git All being well this means that it will be integrated into the linux-next tree (usually sometime in th

Re: [PATCH RFC v1 7/8] drivers: qcom: cpu_pd: Handle cpu hotplug in the domain

2018-10-12 Thread Sudeep Holla
On Fri, Oct 12, 2018 at 10:04:27AM -0600, Lina Iyer wrote: > On Fri, Oct 12 2018 at 09:04 -0600, Sudeep Holla wrote: [...] > > Why does CPU going down says that another (screen - supposedly shared) > > resource needs to be relinquished ? Shouldn't display decide that on it's > > own ? I have no i

Re: [PATCHv2] mm/gup: Cache dev_pagemap while pinning pages

2018-10-12 Thread Keith Busch
On Fri, Oct 12, 2018 at 09:58:18AM -0700, Dan Williams wrote: > On Fri, Oct 12, 2018 at 4:00 AM Kirill A. Shutemov > wrote: > [..] > > > Does this have defined behavior? I would feel better with " = { 0 }" > > > to be explicit. > > > > Well, it's not allowed by the standart, but GCC allows this.

Applied "spi: imx: use PIO mode if size is small" to the spi tree

2018-10-12 Thread Mark Brown
The patch spi: imx: use PIO mode if size is small has been applied to the spi tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus du

Applied "spi: imx: move wml setting to later than setup_transfer" to the spi tree

2018-10-12 Thread Mark Brown
The patch spi: imx: move wml setting to later than setup_transfer has been applied to the spi tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and

Re: [PATCH] KEYS: trusted: fix -Wvarags warning

2018-10-12 Thread Nick Desaulniers
On Fri, Oct 12, 2018 at 5:29 AM Denis Kenzior wrote: > > Hi Nick, > > > @@ -123,7 +123,7 @@ static int TSS_rawhmac(unsigned char *digest, const > > unsigned char *key, > >*/ > > static int TSS_authhmac(unsigned char *digest, const unsigned char *key, > > unsigned int k

Applied "spi: Make GPIO CSs honour the SPI_NO_CS flag" to the spi tree

2018-10-12 Thread Mark Brown
The patch spi: Make GPIO CSs honour the SPI_NO_CS flag has been applied to the spi tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Lin

Re: [PATCH] KEYS: trusted: fix -Wvarags warning

2018-10-12 Thread Nathan Chancellor
On Fri, Oct 12, 2018 at 09:55:55AM -0700, Nick Desaulniers wrote: > On Thu, Oct 11, 2018 at 6:50 PM Nathan Chancellor > wrote: > > > > On Thu, Oct 11, 2018 at 01:31:26PM -0700, ndesaulni...@google.com wrote: > > > by swapping h2 and h3. > > > > > > security/keys/trusted.c:146:17: warning: passing

Re: [PATCH v2 1/7] modules: Create rlimit for module space

2018-10-12 Thread Edgecombe, Rick P
On Fri, 2018-10-12 at 02:35 +0200, Jann Horn wrote: > On Fri, Oct 12, 2018 at 1:40 AM Rick Edgecombe > wrote: > > This introduces a new rlimit, RLIMIT_MODSPACE, which limits the amount of > > module space a user can use. The intention is to be able to limit module > > space > > allocations that ma

Re: [PATCH] mm/thp: fix call to mmu_notifier in set_pmd_migration_entry()

2018-10-12 Thread Jerome Glisse
On Fri, Oct 12, 2018 at 06:55:48PM +0200, Michal Hocko wrote: > On Fri 12-10-18 12:09:53, jgli...@redhat.com wrote: > > From: Jérôme Glisse > > > > Inside set_pmd_migration_entry() we are holding page table locks and > > thus we can not sleep so we can not call invalidate_range_start/end() > > >

Re: [PATCH 10/10] arm64: use the generic swiotlb_dma_ops

2018-10-12 Thread Catalin Marinas
On Fri, Oct 12, 2018 at 04:40:49PM +0200, Christoph Hellwig wrote: > On Fri, Oct 12, 2018 at 02:01:00PM +0100, Robin Murphy wrote: > > On 08/10/18 09:02, Christoph Hellwig wrote: > >> Now that the generic swiotlb code supports non-coherent DMA we can switch > >> to it for arm64. For that we need t

Re: [PATCH] KEYS: trusted: fix -Wvarags warning

2018-10-12 Thread Nick Desaulniers
On Fri, Oct 12, 2018 at 8:14 AM Denis Kenzior wrote: > > Hi James, > > >> So can't we simply use 'bool' or uint32 as the type for h3 instead > >> of re-ordering everything > > > > The problem is the standard is ambiguious. The only thing that's > > guaranteed to work for all time is a char *. If

Re: [PATCH 3.18 000/120] 3.18.124-stable review

2018-10-12 Thread Nathan Chancellor
On Thu, Oct 11, 2018 at 05:33:01PM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 3.18.124 release. > There are 120 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me kn

Re: [PATCH 4.4 00/27] 4.4.161-stable review

2018-10-12 Thread Nathan Chancellor
On Thu, Oct 11, 2018 at 05:34:47PM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.4.161 release. > There are 27 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know

Re: [PATCH 4.9 00/35] 4.9.133-stable review

2018-10-12 Thread Nathan Chancellor
On Thu, Oct 11, 2018 at 05:35:02PM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.9.133 release. > There are 35 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know

Re: [PATCH v3 1/3] x86: baytrail/cherrytrail: Rework and move P-Unit PMIC bus semaphore code

2018-10-12 Thread Alan Cox
> > It should be. > > You mean that the problem should be purely academic, IOW that registers > touched > by the P-Unit are never touched through ACPI Opregions / power-resources? As far as I am aware. Holding the lock over both is definitely better regardless > >> 2) To safely access the sha

Re: [PATCH v2] regulator/gpio: Allow nonexclusive GPIO access

2018-10-12 Thread jacopo mondi
Hi Mark, On Fri, Oct 12, 2018 at 06:44:24PM +0200, Mark Brown wrote: > On Fri, Oct 12, 2018 at 04:26:12PM +0200, jacopo mondi wrote: > > > Sorry, I'm going slightly OT with this, but please read below. > > > On Fri, Oct 12, 2018 at 02:54:12PM +0200, Linus Walleij wrote: > > > This allows nonexclus

Re: [PATCH] KEYS: trusted: fix -Wvarags warning

2018-10-12 Thread Nick Desaulniers
On Fri, Oct 12, 2018 at 9:01 AM James Bottomley wrote: > > On Fri, 2018-10-12 at 10:53 -0500, Denis Kenzior wrote: > > Hi James, > > > > > > From the links provided in the patch it seems that one cannot > > > > pass char/float/short to va_start(). Fair enough. So if we make > > > > h3 an unsig

Re: [PATCH v5 1/2] dt-bindings: iio: vadc: Update example to include unit address for node 'usb-id-nopull'

2018-10-12 Thread Matthias Kaehlcke
On Fri, Oct 05, 2018 at 03:47:43PM -0500, Rob Herring wrote: > On Wed, Oct 03, 2018 at 05:14:31PM -0700, Matthias Kaehlcke wrote: > > The node has a reg property, therefore its name should include a unit > > address. > > > > Also change the name from 'usb_id_nopull' to 'usb-id-nopull' to follow >

Re: [PATCH] KEYS: trusted: fix -Wvarags warning

2018-10-12 Thread Denis Kenzior
Hi Nick, Refer to https://trustedcomputinggroup.org/wp-content/uploads/TPM-Main-Part-3-Commands_v1.2_rev116_01032011.pdf for details. Can you cite the relevant section? Just pick any section that describes a TPM command. I randomly used Section 10.3 for TPM Unbind. See the 'Incoming op

Re: [PATCH v1] phy: qcom-qusb2: Fix HSTX_TRIM tuning with fused value for SDM845

2018-10-12 Thread Doug Anderson
Hi, On Thu, Oct 11, 2018 at 10:57 PM wrote: > Fused value is supposed to always override. If value is not fused for > some > parts (which I believe is case with some early samples), then driver > will > read it is '0' from nvmem and should use hstx-trim value passed from DT. OK cool. Just wante

Re: [PATCH] KEYS: trusted: fix -Wvarags warning

2018-10-12 Thread Nick Desaulniers
On Fri, Oct 12, 2018 at 10:05 AM Nick Desaulniers wrote: > > On Fri, Oct 12, 2018 at 8:14 AM Denis Kenzior wrote: > > > > Hi James, > > > > >> So can't we simply use 'bool' or uint32 as the type for h3 instead > > >> of re-ordering everything > > > > > > The problem is the standard is ambiguious.

Re: [PATCH RFC v1 7/8] drivers: qcom: cpu_pd: Handle cpu hotplug in the domain

2018-10-12 Thread Lina Iyer
On Fri, Oct 12 2018 at 11:01 -0600, Sudeep Holla wrote: On Fri, Oct 12, 2018 at 10:04:27AM -0600, Lina Iyer wrote: On Fri, Oct 12 2018 at 09:04 -0600, Sudeep Holla wrote: [...] Yes all these are fine but with multiple power-domains/cluster, it's hard to determine the first CPU. You may be abl

Re: [PATCH v2 1/7] modules: Create rlimit for module space

2018-10-12 Thread Jann Horn
On Fri, Oct 12, 2018 at 7:04 PM Edgecombe, Rick P wrote: > On Fri, 2018-10-12 at 02:35 +0200, Jann Horn wrote: > > On Fri, Oct 12, 2018 at 1:40 AM Rick Edgecombe > > wrote: > > > This introduces a new rlimit, RLIMIT_MODSPACE, which limits the amount of > > > module space a user can use. The inten

Re: [PATCH v2 2/2] LICENSES: Add ISC license text

2018-10-12 Thread Jonathan Corbet
On Wed, 10 Oct 2018 22:15:09 +0200 Hans de Goede wrote: > Add the full text of the ISC license to the kernel tree. It was copied > directly from: > >https://spdx.org/licenses/ISC.html > > With the mention of "ISC" in the warranty disclaimer replaced with > "THE AUTHOR" as done in the ISC li

Re: [PATCH v2 1/2] LICENSES: Add note to CDDL-1.0 license that it should not be used

2018-10-12 Thread Jonathan Corbet
On Wed, 10 Oct 2018 22:15:08 +0200 Hans de Goede wrote: > The only reason we have the CDDL-1.0 license text around is for some > dual-licensed files from virtualbox. New code should not use this license. > > Add a note about this and change the example tag to be dual-licensed. > > Signed-off-by

Re: [PATCH] mm/thp: fix call to mmu_notifier in set_pmd_migration_entry()

2018-10-12 Thread Andrea Arcangeli
Hello, On Fri, Oct 12, 2018 at 12:20:54PM -0400, Zi Yan wrote: > On 12 Oct 2018, at 12:09, jgli...@redhat.com wrote: > > > From: Jérôme Glisse > > > > Inside set_pmd_migration_entry() we are holding page table locks and > > thus we can not sleep so we can not call invalidate_range_start/end() >

Re: [PATCH RFC v1 7/8] drivers: qcom: cpu_pd: Handle cpu hotplug in the domain

2018-10-12 Thread Sudeep Holla
On Fri, Oct 12, 2018 at 11:19:10AM -0600, Lina Iyer wrote: > On Fri, Oct 12 2018 at 11:01 -0600, Sudeep Holla wrote: > > On Fri, Oct 12, 2018 at 10:04:27AM -0600, Lina Iyer wrote: > > > On Fri, Oct 12 2018 at 09:04 -0600, Sudeep Holla wrote: > > > > [...] > > > > Yes all these are fine but with mul

Re: [PATCH] KEYS: trusted: fix -Wvarags warning

2018-10-12 Thread Denis Kenzior
Hi Nick, So maybe I'm misunderstanding something, but the issue seems to be that unsigned char is promoted to 'unsigned char *' by Clang and probably unsigned int or int by gcc. No. This is extremely well defined behavior in C. In C, integral types are NEVER promoted to pointer to integer typ

Re: [PATCH v1] KVM/x86/vPMU: Guest PMI Optimization

2018-10-12 Thread Alexey Budankov
Hi, On 12.10.2018 19:30, Andi Kleen wrote: >> 4. Results >> - Without this optimization, the guest pmi handling time is >> ~450 ns, and the max sampling rate is reduced to 250. >> - With this optimization, the guest pmi handling time is ~9000 ns >> (i.e. 1 / 500 of the non-

[PATCHv3] mm/gup: Cache dev_pagemap while pinning pages

2018-10-12 Thread Keith Busch
Getting pages from ZONE_DEVICE memory needs to check the backing device's live-ness, which is tracked in the device's dev_pagemap metadata. This metadata is stored in a radix tree and looking it up adds measurable software overhead. This patch avoids repeating this relatively costly operation when

Re: [PATCH RFC v1 8/8] arm64: dtsi: sdm845: Add cpu power domain support

2018-10-12 Thread Sudeep Holla
On Thu, Oct 11, 2018 at 02:50:55AM +0530, Raju P.L.S.S.S.N wrote: > Add cpu power domain support > > Signed-off-by: Raju P.L.S.S.S.N > --- > arch/arm64/boot/dts/qcom/sdm845.dtsi | 13 + > 1 file changed, 13 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi > b/arc

Re: [PATCH] mm/thp: fix call to mmu_notifier in set_pmd_migration_entry()

2018-10-12 Thread Jerome Glisse
On Fri, Oct 12, 2018 at 01:24:22PM -0400, Andrea Arcangeli wrote: > Hello, > > On Fri, Oct 12, 2018 at 12:20:54PM -0400, Zi Yan wrote: > > On 12 Oct 2018, at 12:09, jgli...@redhat.com wrote: > > > > > From: Jérôme Glisse > > > > > > Inside set_pmd_migration_entry() we are holding page table lock

Re: [PATCH v6] clk: qcom: Add lpass clock controller driver for SDM845

2018-10-12 Thread Stephen Boyd
Quoting Taniya Das (2018-10-09 23:12:27) > > > On 10/10/2018 2:22 AM, Stephen Boyd wrote: > > Quoting Taniya Das (2018-10-09 10:26:38) > >> Hello Stephen, > >> > >> On 10/8/2018 8:14 AM, Stephen Boyd wrote: > >>> Quoting Taniya Das (2018-10-04 05:02:26) > Add support for the lpass clock cont

Re: [PATCH 6/6] arm64: dts: marvell: Add cpu clock node on Armada 7K/8K

2018-10-12 Thread Stephen Boyd
+Rob Quoting Gregory CLEMENT (2018-09-22 11:17:09) > diff --git a/arch/arm64/boot/dts/marvell/armada-ap806.dtsi > b/arch/arm64/boot/dts/marvell/armada-ap806.dtsi > index 4a65e4e830aa..27c840e91abe 100644 > --- a/arch/arm64/boot/dts/marvell/armada-ap806.dtsi > +++ b/arch/arm64/boot/dts/marvell/arm

RE: issues with suspend on Dell XPS 13 2-in-1

2018-10-12 Thread Mario.Limonciello
> -Original Message- > From: Dennis Gilmore > Sent: Friday, October 12, 2018 8:39 AM > To: Pandruvada, Srinivas > Cc: linux-kernel@vger.kernel.org; linux-a...@vger.kernel.org; Limonciello, > Mario > Subject: Re: issues with suspend on Dell XPS 13 2-in-1 > It appears I'm being added to t

Re: [PATCH v2 0/4] devres: provide and use devm_kstrdup_const()

2018-10-12 Thread Stephen Boyd
Quoting Bartosz Golaszewski (2018-09-20 05:59:54) > 2018-08-28 11:33 GMT+02:00 Bartosz Golaszewski : > > This series implements devm_kstrdup_const() together with some > > prerequisite changes and uses it in pmc-atom driver. > > > > v1 -> v2: > > - fixed the changelog in the patch implementing devm

<    1   2   3   4   5   6   >