Regression in next with filesystem context concept

2018-09-06 Thread Tony Lindgren
Hi, Looks like next-20180906 now has a regression where mounting root won't work with commit fd0002870b45 ("vfs: Implement a filesystem superblock creation/configuration context"). Here's what happens for me on MMC for example: Waiting for root device /dev/mmcblk0p2...

Re: [PATCH] lockdep: Have assert functions test for actual interrupts disabled

2018-09-06 Thread Peter Zijlstra
On Thu, Sep 06, 2018 at 10:17:01AM -0400, Steven Rostedt wrote: > I still think checking if IRQS are really disabled or not when lockdep > thinks it is (or not) is valuable and doesn't cause any other problems. Since check_flags() is a relatively cheap thing I would rather do something like so..

Re: [PATCH V2] input: egalax_ts: add system wakeup support

2018-09-06 Thread Fabio Estevam
On Thu, Sep 6, 2018 at 12:24 AM, Anson Huang wrote: > This patch adds wakeup function support for egalax touch > screen, if "wakeup-source" is added to device tree's egalax > touch screen node, the wakeup function will be enabled, and > egalax touch screen will be able to wakeup system from suspen

INFO: task hung in uprobe_start_dup_mmap

2018-09-06 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:f2b6e66e9885 Add linux-next specific files for 20180904 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=175217e140 kernel config: https://syzkaller.appspot.com/x/.config?x=15ad48400e39c1b3 dashb

Re: [PATCH] memory: ti-aemif: fix a potential NULL-pointer dereference

2018-09-06 Thread Santosh Shilimkar
Hi Arnd, Olof, On 9/6/2018 5:12 AM, Bartosz Golaszewski wrote: From: Bartosz Golaszewski Platform data pointer may be NULL. We check it everywhere but in one place. Fix it. Fixes: 8af70cd2ca50 ("memory: aemif: add support for board files") Reported-by: Dan Carpenter Signed-off-by: Bartosz Go

Re: [PATCH v2 0/6] x86/alternatives: text_poke() fixes

2018-09-06 Thread Nadav Amit
at 3:16 AM, Peter Zijlstra wrote: > On Thu, Sep 06, 2018 at 10:13:00AM +0200, Peter Zijlstra wrote: >> No, you got it the first time. There are in fact more fixmap abusers; >> see drivers/acpi/apei/ghes.c. Also, as long as set_fixmap() allows >> overwriting a _PAGE_PRESENT pte and has that dodgy

Re: [PATCH v2 1/2] mm: Move page struct poisoning to CONFIG_DEBUG_VM_PAGE_INIT_POISON

2018-09-06 Thread Michal Hocko
On Thu 06-09-18 08:41:52, Alexander Duyck wrote: > On Thu, Sep 6, 2018 at 8:13 AM Michal Hocko wrote: > > > > On Thu 06-09-18 07:59:03, Dave Hansen wrote: > > > On 09/05/2018 10:47 PM, Michal Hocko wrote: > > > > why do you have to keep DEBUG_VM enabled for workloads where the boot > > > > time ma

Re: [PATCH v2] firmware: arm_scmi: fix divide by zero when sustained_perf_level is zero

2018-09-06 Thread Olof Johansson
Hi, On Thu, Sep 06, 2018 at 04:10:39PM +0100, Sudeep Holla wrote: > Firmware can provide zero as values for sustained performance level and > corresponding sustained frequency in kHz in order to hide the actual > frequencies and provide only abstract values. It may endup with divide > by zero scen

Re: [PATCH] memory: ti-aemif: fix a potential NULL-pointer dereference

2018-09-06 Thread Olof Johansson
On Thu, Sep 06, 2018 at 09:58:54AM -0700, Santosh Shilimkar wrote: > Hi Arnd, Olof, > > On 9/6/2018 5:12 AM, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > > > Platform data pointer may be NULL. We check it everywhere but in one > > place. Fix it. > > > > Fixes: 8af70cd2ca50 ("mem

[PATCH] arm64: lib: use C string functions with KASAN enabled.

2018-09-06 Thread Andrey Ryabinin
ARM64 has asm implementations of memchr(), memcmp(), str[r]chr(), str[n]cmp(), str[n]len(). KASAN don't see memory accesses in asm code, thus it can potentially miss many bugs. Ifdef out __HAVE_ARCH_* defines of these functions when KASAN is enabled, so the generic implementations from lib/string.

[PATCH] lib/test_kasan: Add tests for several string/memory API functions

2018-09-06 Thread Andrey Ryabinin
Arch code may have asm implementation of string/memory API functions instead of using generic one from lib/string.c. KASAN don't see memory accesses in asm code, thus can miss many bugs. E.g. on ARM64 KASAN don't see bugs in memchr(), memcmp(), str[r]chr(), str[n]cmp(), str[n]len(). Add tests for

Re: [PATCH v2] arm64: kasan: add interceptors for strcmp/strncmp functions

2018-09-06 Thread Andrey Ryabinin
On 09/05/2018 10:44 AM, Kyeongdon Kim wrote: > > > On 2018-09-05 오전 1:24, Andrey Ryabinin wrote: >> >> >> On 09/04/2018 01:10 PM, Andrey Ryabinin wrote: >> > >> > >> > On 09/04/2018 09:59 AM, Kyeongdon Kim wrote: >> > >> +#undef strncmp >> +int strncmp(const char *cs, const char *ct, si

Re: [PATCH v2 1/2] mm: Move page struct poisoning to CONFIG_DEBUG_VM_PAGE_INIT_POISON

2018-09-06 Thread Dave Hansen
On 09/06/2018 09:12 AM, Pasha Tatashin wrote: > > I do not want to make this feature less tested. Poisoning memory allowed > us to catch corner case bugs like these: > > ab1e8d8960b68f54af42b6484b5950bd13a4054b > mm: don't allow deferred pages with NEED_PER_CPU_KM > > e181ae0c5db9544de9c53239eb2

Re: [PATCH] memory: ti-aemif: fix a potential NULL-pointer dereference

2018-09-06 Thread Santosh Shilimkar
On 9/6/2018 10:03 AM, Olof Johansson wrote: On Thu, Sep 06, 2018 at 09:58:54AM -0700, Santosh Shilimkar wrote: Hi Arnd, Olof, On 9/6/2018 5:12 AM, Bartosz Golaszewski wrote: From: Bartosz Golaszewski Platform data pointer may be NULL. We check it everywhere but in one place. Fix it. Fixes:

Re: [PATCH v2 1/2] mm: Move page struct poisoning to CONFIG_DEBUG_VM_PAGE_INIT_POISON

2018-09-06 Thread Michal Hocko
On Thu 06-09-18 09:09:46, Dave Hansen wrote: [...] > Has anyone ever seen a single in-the-wild report from this mechanism? Yes. See the list from Pavel. And I wouldn't push for it otherwise. There are some questionable asserts with an overhead which is not directly visible but it just adds up. Thi

Re: [PATCH v2] firmware: arm_scmi: fix divide by zero when sustained_perf_level is zero

2018-09-06 Thread Sudeep Holla
On 06/09/18 17:59, Olof Johansson wrote: > Hi, > > On Thu, Sep 06, 2018 at 04:10:39PM +0100, Sudeep Holla wrote: >> Firmware can provide zero as values for sustained performance level and >> corresponding sustained frequency in kHz in order to hide the actual >> frequencies and provide only abs

Re: [PATCH v2 0/6] x86/alternatives: text_poke() fixes

2018-09-06 Thread Peter Zijlstra
On Thu, Sep 06, 2018 at 05:01:25PM +, Nadav Amit wrote: > In addition, there might be a couple of issues with your fix: It boots on my box ;-) > 1. __set_pte_vaddr() is not used exclusive by set_fixmap(). This means > the warning might be wrong, but also means that these code patches (Xen’s >

Re: [PATCH] x86: use WRITE_ONCE() when setting PTEs

2018-09-06 Thread Dave Hansen
On 09/02/2018 11:14 AM, Nadav Amit wrote: > When page-table entries are set, the compiler might optimize their > assignment by using multiple instructions to set the PTE. This might > turn into a security hazard if the user somehow manages to use the > interim PTE. L1TF does not make our lives easi

Re: KASAN: use-after-free Read in sha512_mb_flusher

2018-09-06 Thread Tim Chen
On 08/20/2018 07:46 PM, Eric Biggers wrote: > On Wed, Aug 15, 2018 at 09:35:03AM -0700, syzbot wrote: >> Hello, >> >> syzbot found the following crash on: >> >> HEAD commit:5ed5da74de9e Add linux-next specific files for 20180813 >> git tree: linux-next >> console output: https://syzkaller

Re: [PATCH net-next 06/11] tuntap: split out XDP logic

2018-09-06 Thread Michael S. Tsirkin
On Thu, Sep 06, 2018 at 12:05:21PM +0800, Jason Wang wrote: > This patch split out XDP logic into a single function. This make it to > be reused by XDP batching path in the following patch. > > Signed-off-by: Jason Wang > --- > drivers/net/tun.c | 84 -

Re: [PATCH v4 14/16] sched/core: uclamp: request CAP_SYS_ADMIN by default

2018-09-06 Thread Patrick Bellasi
On 06-Sep 16:59, Juri Lelli wrote: > On 06/09/18 15:40, Patrick Bellasi wrote: > > On 04-Sep 15:47, Juri Lelli wrote: > > [...] > > > > Wondering if you want to fold the check below inside the > > > > > > if (user && !capable(CAP_SYS_NICE)) { > > >... > > > } > > > > > > block. It would a

Re: [PATCH v2 0/6] x86/alternatives: text_poke() fixes

2018-09-06 Thread Peter Zijlstra
On Thu, Sep 06, 2018 at 05:01:25PM +, Nadav Amit wrote: > I’ll give your patch a try once my server goes back online. I was (and still > am) worried that interrupts would be disabled when __set_pte_vaddr() is > called, which would make the fix more complicated. Thing is, we only need the TLB i

Re: [PATCH v2 1/2] mm: Move page struct poisoning to CONFIG_DEBUG_VM_PAGE_INIT_POISON

2018-09-06 Thread Pasha Tatashin
On 9/6/18 1:03 PM, Michal Hocko wrote: > On Thu 06-09-18 08:41:52, Alexander Duyck wrote: >> On Thu, Sep 6, 2018 at 8:13 AM Michal Hocko wrote: >>> >>> On Thu 06-09-18 07:59:03, Dave Hansen wrote: On 09/05/2018 10:47 PM, Michal Hocko wrote: > why do you have to keep DEBUG_VM enabled for

Re: [PATCH i2c-next v6] i2c: aspeed: Handle master/slave combined irq events properly

2018-09-06 Thread Brendan Higgins
On Thu, Aug 23, 2018 at 3:58 PM Jae Hyun Yoo wrote: > > In most of cases, interrupt bits are set one by one but there are > also a lot of other cases that Aspeed I2C IP sends multiple > interrupt bits with combining master and slave events using a > single interrupt call. It happens much more in m

Re: [PATCH] x86/fault: Decode page fault OOPSes better

2018-09-06 Thread Dave Hansen
On 08/31/2018 08:42 PM, Andy Lutomirski wrote: > One of Linus' favorite hobbies seems to be looking at OOPSes and > decoding the error code in his head. This is not one of my favorite > hobbies :) I just work around this by having a screenshot of 'enum x86_pf_error_code' as my desktop background.

Re: [PATCH i2c-next v6] i2c: aspeed: Handle master/slave combined irq events properly

2018-09-06 Thread Jae Hyun Yoo
On 9/6/2018 10:26 AM, Brendan Higgins wrote: On Thu, Aug 23, 2018 at 3:58 PM Jae Hyun Yoo wrote: In most of cases, interrupt bits are set one by one but there are also a lot of other cases that Aspeed I2C IP sends multiple interrupt bits with combining master and slave events using a single in

Re: [PATCH v13 11/13] platform/x86: Intel SGX driver

2018-09-06 Thread Miguel Ojeda
Hi Jarkko, On Thu, Sep 6, 2018 at 11:21 AM, Jarkko Sakkinen wrote: > There is another open. If I grep through the kernel tree I see SPDX > headers that are decorated both with C99- and C89-style comments. I > guess I ended up using C99-style because when I was instructed to add > SPDX headers in

Re: [PATCH v2] perf tools: use PTR_ERR_OR_ZERO inetead of return code

2018-09-06 Thread Arnaldo Carvalho de Melo
Em Thu, Sep 06, 2018 at 07:42:51PM +0800, Ding Xiang escreveu: > use PTR_ERR_OR_ZERO for bpf__setup_stdout return code > > v2: add macro PTR_ERR_OR_ZERO to err.h This really should be done in two patches, one introducing the PTR_ERR_OR_ZERO() macro, and then the use of it in bpf-loader.c. Thanks

Re: [PATCH v5 5/5] x86/kvm: Avoid dynamic allocation of pvclock data when SEV is active

2018-09-06 Thread Brijesh Singh
On 09/06/2018 08:50 AM, Sean Christopherson wrote: ... So are we going to be defining a decrypted section for every piece of machinery now? That's a bit too much in my book. Why can't you simply free everything in .data..decrypted on !SVE guests? That would prevent adding __decrypted to

Re: [PATCH] arm64: dts: qcom: sdm845-mtp: pm8998 and pmi8998 regulators

2018-09-06 Thread Doug Anderson
Bjorn, On Sat, Sep 1, 2018 at 3:19 PM, Bjorn Andersson wrote: > Add regulator definitions for pm8998 and pmi8998 regulators on the MTP. > > Signed-off-by: Bjorn Andersson > --- > arch/arm64/boot/dts/qcom/sdm845-mtp.dts | 216 > 1 file changed, 216 insertions(+) I'm cur

Re: [PATCH] efi_stub: update documentation on dtb= parameter

2018-09-06 Thread Grant Likely
> On 6 Sep 2018, at 16:51, Jonathan Corbet wrote: > > On Wed, 5 Sep 2018 20:07:50 +0100 > Grant Likely wrote: > >> The dtb= parameter is no longer the primary mechanism for providing a >> devicetree to the kernel. Now either firmware or the boot selector (ex. >> Grub) should provide the devi

Targeted Global B2B Companies emails list

2018-09-06 Thread christine . walker
Hi, I just wanted to check if you would be interested in a list of Managed Service Providers (MSPs) and Managed Security Service Providers (MSSPs)? We also have the data intelligence of: • Managed Service Providers (MSP’s) – 25,000 unique companies • Managed Security Service Prov

Re: [PATCH v2 0/6] x86/alternatives: text_poke() fixes

2018-09-06 Thread Nadav Amit
at 10:17 AM, Peter Zijlstra wrote: > On Thu, Sep 06, 2018 at 05:01:25PM +, Nadav Amit wrote: >> In addition, there might be a couple of issues with your fix: > > It boots on my box ;-) > >> 1. __set_pte_vaddr() is not used exclusive by set_fixmap(). This means >> the warning might be wrong,

[PATCH] dt-bindings: fpga: fix freeze controller compatible in region doc

2018-09-06 Thread Alan Tull
Documentation/devicetree/bindings/fpga/fpga-region.txt has an error regarding the freeze controller bridge, secifically: compatible = "altr,freeze-bridge"; The compatibility string should be "altr,freeze-bridge-controller" as set forth in altera-freeze-bridge.txt. Signed-off-by: Alan Tull Repo

[PATCH v3] ata: Disable AHCI ALPM feature for Ampere Computing eMAG SATA

2018-09-06 Thread Suman Tripathi
Due to hardware errata, Ampere Computing eMAG SATA can't support AHCI ALPM feature. This patch disables the AHCI ALPM feature for eMAG SATA. Signed-off-by: Suman Trpathi Signed-off-by: Rameshwar Prasad Sahu --- Changes for v3: * Fix the indentation and whitespace warnings. Changes for v2: *

Re: [RFC PATCH v2 3/3] dynamic_debug: Add support for dynamic register trace

2018-09-06 Thread Sai Prakash Ranjan
On 9/6/2018 3:35 PM, Will Deacon wrote: On Fri, Aug 24, 2018 at 08:15:27PM +0530, Sai Prakash Ranjan wrote: Introduce dynamic debug filtering mechanism to register tracing as dynamic_rtb() which will reduce a lot of overhead otherwise of tracing all the register reads/writes in all files. Now w

Re: [PATCH i2c-next v6] i2c: aspeed: Handle master/slave combined irq events properly

2018-09-06 Thread Wolfram Sang
> > Looks awesome! Thanks! > > > > Reviewed-by: Brendan Higgins > > > > Thanks a lot for your review Brendan! Please don't quote the whole message. Everyone else has to scroll down a lot to find the relevant information. Thanks! signature.asc Description: PGP signature

Re: [PATCH v2 1/2] mm: Move page struct poisoning to CONFIG_DEBUG_VM_PAGE_INIT_POISON

2018-09-06 Thread Michal Hocko
On Thu 06-09-18 10:07:51, Dave Hansen wrote: > On 09/06/2018 09:12 AM, Pasha Tatashin wrote: > > > > I do not want to make this feature less tested. Poisoning memory allowed > > us to catch corner case bugs like these: > > > > ab1e8d8960b68f54af42b6484b5950bd13a4054b > > mm: don't allow deferred

Re: [PATCH v2 0/6] x86/alternatives: text_poke() fixes

2018-09-06 Thread Andy Lutomirski
> On Sep 6, 2018, at 10:58 AM, Nadav Amit wrote: > > at 10:17 AM, Peter Zijlstra wrote: > >>> On Thu, Sep 06, 2018 at 05:01:25PM +, Nadav Amit wrote: >>> In addition, there might be a couple of issues with your fix: >> >> It boots on my box ;-) >> >>> 1. __set_pte_vaddr() is not used e

Re: Regression in next with filesystem context concept

2018-09-06 Thread Naresh Kamboju
On 6 September 2018 at 22:13, Tony Lindgren wrote: > Hi, > > Looks like next-20180906 now has a regression where mounting > root won't work with commit fd0002870b45 ("vfs: Implement a > filesystem superblock creation/configuration context"). I have noticed this pro

Smack: wrong-looking capable() check in smk_ptrace_rule_check()

2018-09-06 Thread Jann Horn
Hi! I noticed the following check in smk_ptrace_rule_check(): if (tracer_known->smk_known == tracee_known->smk_known) rc = 0; else if (smack_ptrace_rule == SMACK_PTRACE_DRACONIAN) rc = -EACCES; else if

Re: [PATCH] dt-bindings: fpga: fix freeze controller compatible in region doc

2018-09-06 Thread Moritz Fischer
Hi Alan, looks like it's just the examples, right? So not sure someone would be affected by that, yet? On Thu, Sep 06, 2018 at 01:01:52PM -0500, Alan Tull wrote: > Documentation/devicetree/bindings/fpga/fpga-region.txt has an error > regarding the freeze controller bridge, secifically: > > comp

Re: [PATCH v3 12/12] RISC-V: Support cpu hotplug.

2018-09-06 Thread Atish Patra
On 9/6/18 3:21 AM, Mark Rutland wrote: Hi, On Thu, Sep 06, 2018 at 01:05:35AM -0700, Atish Patra wrote: This patch enable support for cpu hotplug in RISC-V. In absence of generic cpu stop functions, WFI is used to put the cpu in low power state during offline. An IPI is sent to bring it out of

Re: [PATCH] dt-bindings: fpga: fix freeze controller compatible in region doc

2018-09-06 Thread Alan Tull
On Thu, Sep 6, 2018 at 1:24 PM Moritz Fischer wrote: > > Hi Alan, > > looks like it's just the examples, right? Yes, it's in the examples of use, not the actual freeze bridge bindings doc that I'm correcting. > So not sure someone > would be affected by that, yet? It's taken two years for anybo

Re: [PATCH v6 4/5] seccomp: add support for passing fds via USER_NOTIF

2018-09-06 Thread Tycho Andersen
On Thu, Sep 06, 2018 at 10:22:46AM -0600, Tycho Andersen wrote: > On Thu, Sep 06, 2018 at 06:15:18PM +0200, Jann Horn wrote: > > On Thu, Sep 6, 2018 at 5:29 PM Tycho Andersen wrote: > > > The idea here is that the userspace handler should be able to pass an fd > > > back to the trapped task, for e

Re: [PATCH v3 1/2] i2c: mediatek: Register i2c adapter driver earlier

2018-09-06 Thread Wolfram Sang
On Thu, Sep 06, 2018 at 09:15:28PM +0800, Jun Gao wrote: > From: Jun Gao > > In order not to block the initializations of some i2c devices. > Register i2c adapter driver at appropriate time. > > Signed-off-by: Jun Gao The reasons this patch was rejected in v2 still hold. signature.asc Descr

Re: [PATCH v2 0/6] x86/alternatives: text_poke() fixes

2018-09-06 Thread Peter Zijlstra
On Thu, Sep 06, 2018 at 11:09:23AM -0700, Andy Lutomirski wrote: > > On Sep 6, 2018, at 10:58 AM, Nadav Amit wrote: > > It depends what security you want. Some may consider even the short > > time-window in which the kernel code is writable from other cores as > > insufficient for security. > > >

Re: [PATCH v5 5/5] x86/kvm: Avoid dynamic allocation of pvclock data when SEV is active

2018-09-06 Thread Borislav Petkov
On Thu, Sep 06, 2018 at 08:54:52AM -0700, Sean Christopherson wrote: > My thought was that we could simply define a second array for the SEV > case to statically allocate for NR_CPUS since __decrypted has a big > chunk of memory that would be ununsed anyways[1]. And since the second > array is only

Re: [PATCH v3 2/2] i2c: mediatek: Use DMA safe buffers for i2c transactions

2018-09-06 Thread Wolfram Sang
On Thu, Sep 06, 2018 at 09:15:29PM +0800, Jun Gao wrote: > From: Jun Gao > > DMA mode will always be used in i2c transactions, try to allocate > a DMA safe buffer if the buf of struct i2c_msg used is not DMA safe. > > Signed-off-by: Jun Gao Applied to for-next, thanks! signature.asc Descrip

Re: [PATCH i2c-next v6] i2c: aspeed: Handle master/slave combined irq events properly

2018-09-06 Thread Jae Hyun Yoo
Please don't quote the whole message. Everyone else has to scroll down a lot to find the relevant information. Thanks! Will keep that in mind. Thanks Wolfram!

Re: [PATCH RFC LKMM 3/7] EXP tools/memory-model: Add more LKMM limitations

2018-09-06 Thread Paul E. McKenney
On Fri, Aug 31, 2018 at 11:43:42AM +0200, Andrea Parri wrote: > > > > + b. The "unless" RMW operations are not currently modeled: > > > > + atomic_long_add_unless(), atomic_add_unless(), > > > > + atomic_inc_unless_negative(), and > > > > + atomi

Re: [PATCH 2/3] arm64: dts: qcom: pm8998: Add adc node

2018-09-06 Thread Doug Anderson
Hi, On Mon, Aug 27, 2018 at 10:10 AM, Matthias Kaehlcke wrote: > On Fri, Aug 10, 2018 at 05:09:17PM -0700, Doug Anderson wrote: >> Hi, >> >> On Wed, Aug 8, 2018 at 12:13 PM, Matthias Kaehlcke wrote: >> > This adds the adc node to pm8998 based on the examples in the >> > bindings. It also fixes t

Re: [PATCH v2] cgroup: kselftests: add test_core to .gitignore

2018-09-06 Thread Shuah Khan
On 09/05/2018 11:47 PM, Lei Yang wrote: > Update .gitignore file. > > Signed-off-by: Lei Yang > --- > tools/testing/selftests/cgroup/.gitignore | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/testing/selftests/cgroup/.gitignore > b/tools/testing/selftests/cgroup/.gitignore > ind

[tip:irq/urgent] irqchip/gic-v3-its: Cap lpi_id_bits to reduce memory footprint

2018-09-06 Thread tip-bot for Jia He
Commit-ID: 4cb205c0c50f613e2de91f0eb19d5247ed003e89 Gitweb: https://git.kernel.org/tip/4cb205c0c50f613e2de91f0eb19d5247ed003e89 Author: Jia He AuthorDate: Tue, 28 Aug 2018 12:53:26 +0800 Committer: Thomas Gleixner CommitDate: Thu, 6 Sep 2018 20:31:59 +0200 irqchip/gic-v3-its: Cap lpi_i

Re: [PATCH v5 5/5] x86/kvm: Avoid dynamic allocation of pvclock data when SEV is active

2018-09-06 Thread Brijesh Singh
On 09/06/2018 09:18 AM, Sean Christopherson wrote: So are we going to be defining a decrypted section for every piece of machinery now? That's a bit too much in my book. Why can't you simply free everything in .data..decrypted on !SVE guests? That would prevent adding __decrypted to

Re: [PATCH v2 0/6] x86/alternatives: text_poke() fixes

2018-09-06 Thread Nadav Amit
at 11:31 AM, Peter Zijlstra wrote: > On Thu, Sep 06, 2018 at 11:09:23AM -0700, Andy Lutomirski wrote: >>> On Sep 6, 2018, at 10:58 AM, Nadav Amit wrote: >>> It depends what security you want. Some may consider even the short >>> time-window in which the kernel code is writable from other cores a

Re: [PATCH i2c-next v6] i2c: aspeed: Handle master/slave combined irq events properly

2018-09-06 Thread Wolfram Sang
On Thu, Aug 23, 2018 at 03:57:31PM -0700, Jae Hyun Yoo wrote: > In most of cases, interrupt bits are set one by one but there are > also a lot of other cases that Aspeed I2C IP sends multiple > interrupt bits with combining master and slave events using a > single interrupt call. It happens much mo

Re: [PATCH v5 5/5] x86/kvm: Avoid dynamic allocation of pvclock data when SEV is active

2018-09-06 Thread Brijesh Singh
On 09/06/2018 01:33 PM, Borislav Petkov wrote: On Thu, Sep 06, 2018 at 08:54:52AM -0700, Sean Christopherson wrote: My thought was that we could simply define a second array for the SEV case to statically allocate for NR_CPUS since __decrypted has a big chunk of memory that would be ununsed a

Re: [PATCH v5 5/5] x86/kvm: Avoid dynamic allocation of pvclock data when SEV is active

2018-09-06 Thread Sean Christopherson
On Thu, Sep 06, 2018 at 08:33:34PM +0200, Borislav Petkov wrote: > On Thu, Sep 06, 2018 at 08:54:52AM -0700, Sean Christopherson wrote: > > My thought was that we could simply define a second array for the SEV > > case to statically allocate for NR_CPUS since __decrypted has a big > > chunk of memo

Re: [PATCH v5 5/5] x86/kvm: Avoid dynamic allocation of pvclock data when SEV is active

2018-09-06 Thread Sean Christopherson
On Thu, Sep 06, 2018 at 01:37:50PM -0500, Brijesh Singh wrote: > > > On 09/06/2018 09:18 AM, Sean Christopherson wrote: > > > >>> > >>>So are we going to be defining a decrypted section for every piece of > >>>machinery now? > >>> > >>>That's a bit too much in my book. > >>> > >>>Why can't

Re: [PATCH v5 5/5] x86/kvm: Avoid dynamic allocation of pvclock data when SEV is active

2018-09-06 Thread Brijesh Singh
On 09/06/2018 09:07 AM, Sean Christopherson wrote: ... + +/* This should cover upto 512 VCPUS (first 64 are covered by hv_clock_boot[]). */ +#define HVC_DECRYPTED_ARRAY_SIZE \ + ((PAGE_SIZE * 7) / sizeof(struct pvclock_vsyscall_time_info)) I think we can define the size relative to

Re: [PATCH] i2c: xiic: Make the start and the byte count write atomic

2018-09-06 Thread Wolfram Sang
On Mon, Sep 03, 2018 at 03:11:11PM +0530, shubhrajyoti.da...@gmail.com wrote: > From: Shubhrajyoti Datta > > Disable interrupts while configuring the transfer and enable them back. > > We have below as the programming sequence > 1. start and slave address > 2. byte count and stop > > In some cu

Re: [PATCH v5 5/5] x86/kvm: Avoid dynamic allocation of pvclock data when SEV is active

2018-09-06 Thread Borislav Petkov
On Thu, Sep 06, 2018 at 11:45:03AM -0700, Sean Christopherson wrote: > Yep, though because the 4k chunk in __decrypted is @hv_clock_boot > that's used for cpus 0-127, __decrypted_XXX would effectively be: > >(((num_possible_cpus() * 32) / 4k) - 1) pages Ok, sounds like a nice compromise to m

Re: [PATCH] pci: fix pci.c kernel-doc parameter warning

2018-09-06 Thread Bjorn Helgaas
On Sun, Sep 02, 2018 at 07:32:50PM -0700, Randy Dunlap wrote: > From: Randy Dunlap > > Fix kernel-doc warning: > > ../drivers/pci/pci.c:218: warning: Excess function parameter 'p' description > in 'pci_dev_str_match_path' > > Signed-off-by: Randy Dunlap > Cc: Bjorn Helgaas > Cc: linux-...@vg

Re: [PATCH -next 0/2] fs/epoll: loosen irq safety when possible

2018-09-06 Thread Peter Zijlstra
On Fri, Jul 20, 2018 at 01:05:59PM -0700, Davidlohr Bueso wrote: > On Fri, 20 Jul 2018, Andrew Morton wrote: > >I'm surprised. Is spin_lock_irqsave() significantly more expensive > >than spin_lock_irq()? Relative to all the other stuff those functions > >are doing? If so, how come? Some archit

Re: [PATCH v2 0/6] x86/alternatives: text_poke() fixes

2018-09-06 Thread Peter Zijlstra
On Thu, Sep 06, 2018 at 06:38:30PM +, Nadav Amit wrote: > Note that patch 1/6 is still needed to fix false lockdep shoutouts due to a > recent patch. For some reason I do not appear to have 1/6 in my inbox. Let me dig through lkml.

Re: Widespread crashes in next-20180906

2018-09-06 Thread Matt Hart
t;> >> total: 134 pass: 133 fail: 1 >> >> Do you build arm64? Because KernelCI is seeing build failures in arm64 >> defconfig for next-20180906 >> Clearly it's a module build problem for sunxi but I'm not sure who to >> CC about this. >&g

Re: [PATCH V2 5/6] x86/intel_rdt: Use perf infrastructure for measurements

2018-09-06 Thread Reinette Chatre
Hi Peter, On 9/6/2018 7:15 AM, Peter Zijlstra wrote: > On Thu, Aug 16, 2018 at 01:16:08PM -0700, Reinette Chatre wrote: >> +l2_miss_event = perf_event_create_kernel_counter(&perf_miss_attr, >> + plr->cpu, >> +

Re: [PATCH v5 5/5] x86/kvm: Avoid dynamic allocation of pvclock data when SEV is active

2018-09-06 Thread Brijesh Singh
On 09/06/2018 01:47 PM, Sean Christopherson wrote: On Thu, Sep 06, 2018 at 01:37:50PM -0500, Brijesh Singh wrote: On 09/06/2018 09:18 AM, Sean Christopherson wrote: So are we going to be defining a decrypted section for every piece of machinery now? That's a bit too much in my book

Re: [PATCH] x86: use WRITE_ONCE() when setting PTEs

2018-09-06 Thread Peter Zijlstra
On Thu, Sep 06, 2018 at 10:21:38AM -0700, Dave Hansen wrote: > There's probably a massive number of things that would break if we > assumed sane 64-bit writes can be observed piecemeal. Do assume, it has been observed. WRITE_ONCE()/READ_ONCE() are _required_ if you cannot have load/store tearing.

Re: [PATCH RT 00/22] Linux 4.14.63-rt41-rc1

2018-09-06 Thread Sebastian Andrzej Siewior
On 2018-09-06 12:43:49 [-0400], Steven Rostedt wrote: > > Your tree (v4.14.63) has > > 80d20d35af1ed ("nohz: Fix local_timer_softirq_pending()") > > 0a0e0829f9901 ("nohz: Fix missing tick reprogram when interrupting an > > inline softirq") > > > > which means that the patch "n

Re: possible deadlock in ext4_evict_inode

2018-09-06 Thread Theodore Y. Ts'o
On Thu, Sep 06, 2018 at 09:41:04AM -0700, syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:b36fdc6853a3 Merge tag 'gpio-v4.19-2' of git://git.kernel... > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=1716bc9e40 > kernel

Re: [PATCH v2 1/6] Fix "x86/alternatives: Lockdep-enforce text_mutex in text_poke*()"

2018-09-06 Thread Peter Zijlstra
On Sun, Sep 02, 2018 at 10:32:19AM -0700, Nadav Amit wrote: > text_mutex is expected to be held before text_poke() is called, but we > cannot add a lockdep assertion since kgdb does not take it, and instead > *supposedly* ensures the lock is not taken and will not be acquired by > any other core wh

Re: possible deadlock in ext4_evict_inode

2018-09-06 Thread Dmitry Vyukov
On Thu, Sep 6, 2018 at 9:38 PM, Theodore Y. Ts'o wrote: > On Thu, Sep 06, 2018 at 09:41:04AM -0700, syzbot wrote: >> Hello, >> >> syzbot found the following crash on: >> >> HEAD commit:b36fdc6853a3 Merge tag 'gpio-v4.19-2' of git://git.kernel... >> git tree: upstream >> console output: h

Re: [PATCH v2 1/6] Fix "x86/alternatives: Lockdep-enforce text_mutex in text_poke*()"

2018-09-06 Thread Nadav Amit
at 12:40 PM, Peter Zijlstra wrote: > On Sun, Sep 02, 2018 at 10:32:19AM -0700, Nadav Amit wrote: >> text_mutex is expected to be held before text_poke() is called, but we >> cannot add a lockdep assertion since kgdb does not take it, and instead >> *supposedly* ensures the lock is not taken and w

Re: Widespread crashes in next-20180906

2018-09-06 Thread Theodore Y. Ts'o
uild arm64? Because KernelCI is seeing build failures in arm64 > defconfig for next-20180906 > Clearly it's a module build problem for sunxi but I'm not sure who to > CC about this. > > https://kernelci.org/build/next/branch/master/kernel/next-20180906/ > https://storage.ke

Re: [PATCH V2 5/6] x86/intel_rdt: Use perf infrastructure for measurements

2018-09-06 Thread Peter Zijlstra
On Thu, Sep 06, 2018 at 12:21:59PM -0700, Reinette Chatre wrote: > If you do have suggestions on how I can improve the implementation while > maintaining (or improving) the accuracy of the measurements I would > greatly appreciate it. You can reduce the code duplication by using __always_inline fu

Re: [PATCH v5 5/5] x86/kvm: Avoid dynamic allocation of pvclock data when SEV is active

2018-09-06 Thread Sean Christopherson
On Thu, Sep 06, 2018 at 02:24:32PM -0500, Brijesh Singh wrote: > > > On 09/06/2018 01:47 PM, Sean Christopherson wrote: > >On Thu, Sep 06, 2018 at 01:37:50PM -0500, Brijesh Singh wrote: > >> > >> > >>On 09/06/2018 09:18 AM, Sean Christopherson wrote: > >> > >> > > > >So are we going t

Re: [PATCH v5 5/5] x86/kvm: Avoid dynamic allocation of pvclock data when SEV is active

2018-09-06 Thread Brijesh Singh
On 09/06/2018 02:24 PM, Brijesh Singh wrote: ... Again we have to consider the bare metal scenario while doing this. The aux array you proposed will be added in decrypted section only when CONFIG_AMD_MEM_ENCRYPT=y.  If CONFIG_AMD_MEM_ENCRYPT=n then nothng gets put in .data.decrypted section

Re: [PATCH v2 1/6] Fix "x86/alternatives: Lockdep-enforce text_mutex in text_poke*()"

2018-09-06 Thread Peter Zijlstra
On Thu, Sep 06, 2018 at 07:42:14PM +, Nadav Amit wrote: > at 12:40 PM, Peter Zijlstra wrote: > > > On Sun, Sep 02, 2018 at 10:32:19AM -0700, Nadav Amit wrote: > >> text_mutex is expected to be held before text_poke() is called, but we > >> cannot add a lockdep assertion since kgdb does not ta

Re: [PATCH] x86: use WRITE_ONCE() when setting PTEs

2018-09-06 Thread Peter Zijlstra
On Sun, Sep 02, 2018 at 11:14:50AM -0700, Nadav Amit wrote: > When page-table entries are set, the compiler might optimize their > assignment by using multiple instructions to set the PTE. This might > turn into a security hazard if the user somehow manages to use the > interim PTE. L1TF does not m

Re: [PATCH v2 1/6] Fix "x86/alternatives: Lockdep-enforce text_mutex in text_poke*()"

2018-09-06 Thread Nadav Amit
at 12:53 PM, Peter Zijlstra wrote: > On Thu, Sep 06, 2018 at 07:42:14PM +, Nadav Amit wrote: >> at 12:40 PM, Peter Zijlstra wrote: >> >>> On Sun, Sep 02, 2018 at 10:32:19AM -0700, Nadav Amit wrote: text_mutex is expected to be held before text_poke() is called, but we cannot add a

Re: [PATCH v2 7/9] net: stmmac: dwmac-sun8i: fix OF child-node lookup

2018-09-06 Thread Corentin Labbe
On Mon, Aug 27, 2018 at 10:21:51AM +0200, Johan Hovold wrote: > Use the new of_get_compatible_child() helper to lookup the mdio-internal > child node instead of using of_find_compatible_node(), which searches > the entire tree from a given start node and thus can return an unrelated > (i.e. non-chi

Re: [PATCH V2 5/6] x86/intel_rdt: Use perf infrastructure for measurements

2018-09-06 Thread Reinette Chatre
Hi Peter, On 9/6/2018 12:44 PM, Peter Zijlstra wrote: > On Thu, Sep 06, 2018 at 12:21:59PM -0700, Reinette Chatre wrote: >> If you do have suggestions on how I can improve the implementation while >> maintaining (or improving) the accuracy of the measurements I would >> greatly appreciate it. > >

Re: [PATCH v3] ata: Disable AHCI ALPM feature for Ampere Computing eMAG SATA

2018-09-06 Thread Hans de Goede
Hi, On 06-09-18 20:05, Suman Tripathi wrote: Due to hardware errata, Ampere Computing eMAG SATA can't support AHCI ALPM feature. This patch disables the AHCI ALPM feature for eMAG SATA. Signed-off-by: Suman Trpathi Signed-off-by: Rameshwar Prasad Sahu Sorry, but the patch is still coming th

RE: [PATCH v3] ata: Disable AHCI ALPM feature for Ampere Computing eMAG SATA

2018-09-06 Thread Suman Tripathi
Hi Hans, With regards, Suman -Original Message- From: Hans de Goede Sent: Thursday, September 6, 2018 1:06 PM To: Suman Tripathi ; ax...@kernel.dk; t...@kernel.org; linux-...@vger.kernel.org; linux-arm-ker...@lists.infradead.org; linux-kernel@vger.kernel.org; j...@perches.com; a..

Re: [PATCH] arm64: dts: qcom: sdm845-mtp: pm8998 and pmi8998 regulators

2018-09-06 Thread Bjorn Andersson
On Thu 06 Sep 10:52 PDT 2018, Doug Anderson wrote: > Bjorn, > > On Sat, Sep 1, 2018 at 3:19 PM, Bjorn Andersson > wrote: > > Add regulator definitions for pm8998 and pmi8998 regulators on the MTP. > > > > Signed-off-by: Bjorn Andersson > > --- > > arch/arm64/boot/dts/qcom/sdm845-mtp.dts | 216

Re: [PATCH] x86: use WRITE_ONCE() when setting PTEs

2018-09-06 Thread Nadav Amit
at 12:57 PM, Peter Zijlstra wrote: > On Sun, Sep 02, 2018 at 11:14:50AM -0700, Nadav Amit wrote: >> When page-table entries are set, the compiler might optimize their >> assignment by using multiple instructions to set the PTE. This might >> turn into a security hazard if the user somehow manages

Re: [PATCH 1/2] mtd: nand: reorder nand manufacturer ids

2018-09-06 Thread Miquel Raynal
Hi Marcel, Marcel Ziswiler wrote on Thu, 6 Sep 2018 10:49:21 +0200: > From: Marcel Ziswiler > > Reorder NAND manufacturer ids for clarity. > > Signed-off-by: Marcel Ziswiler > > --- Both patches applied to nand/next with subject prefix s/nand:/rawnand:/ as well as upper-case: s/nand/NAND/

Re: [PATCH v10 2/2] leds: sc27xx: Add pattern_set/clear interfaces for LED controller

2018-09-06 Thread Jacek Anaszewski
Hi Baolin, Thank you for the patch. I really appreciate your effort. I see one more thing I forgot to mention in the previous review. Please take a look at my comment to pattern_set(). On 09/06/2018 04:37 AM, Baolin Wang wrote: > This patch implements the 'pattern_set'and 'pattern_clear' > inter

[PATCH] locking/rwsem: Make owner store task pointer of last owning reader

2018-09-06 Thread Waiman Long
Currently, when a reader acquires a lock, it only sets the RWSEM_READER_OWNED bit in the owner field. The other bits are simply not used. When debugging hanging cases involving rwsems and readers, the owner value does not provide much useful information at all. This patch modifies the current beha

Re: [PATCH] arm64: dts: qcom: sdm845-mtp: pm8998 and pmi8998 regulators

2018-09-06 Thread Doug Anderson
Hi, On Thu, Sep 6, 2018 at 1:12 PM, Bjorn Andersson wrote: >> * Seems to have a few rails named differently LDO22 is named >> "vreg_l22a_2p95" in your DTS but "vreg_l22a_2p85" in mine as one >> example. The schematics I have (from Dec 5, 2017) show it as 2p85. >> > > Looks like a typo on my part

Re: [PATCH v5 5/5] x86/kvm: Avoid dynamic allocation of pvclock data when SEV is active

2018-09-06 Thread Brijesh Singh
On 09/06/2018 02:47 PM, Sean Christopherson wrote: ... Yes, the auxiliary array will dumped into the regular .bss when CONFIG_AMD_MEM_ENCRYPT=n. Typically it will be few k, I am not sure if its worth complicating the code to save those extra memory. Most of the distro's have CONFIG_AMD_MEM_E

Re: [PATCH v2 1/6] Fix "x86/alternatives: Lockdep-enforce text_mutex in text_poke*()"

2018-09-06 Thread Peter Zijlstra
On Thu, Sep 06, 2018 at 07:58:40PM +, Nadav Amit wrote: > > With that CR3 trickery, we can rid ourselves of the text_mutex > > requirement, since concurrent text_poke is 'safe'. That would clean up > > the kgdb code quite a bit. > > I don’t know. I’m somewhat worried with multiple mechanisms p

Re: [PATCH] x86: use WRITE_ONCE() when setting PTEs

2018-09-06 Thread Peter Zijlstra
On Thu, Sep 06, 2018 at 01:12:14PM -0700, Nadav Amit wrote: > at 12:57 PM, Peter Zijlstra wrote: > > > On Sun, Sep 02, 2018 at 11:14:50AM -0700, Nadav Amit wrote: > >> When page-table entries are set, the compiler might optimize their > >> assignment by using multiple instructions to set the PTE.

Re: [PATCH] x86/mm/pat: Fix L1TF stable backport for CPA

2018-09-06 Thread Andi Kleen
> And what about populate_pud? > set_pud(pud, pud_mkhuge(pfn_pud(cpa->pfn, >canon_pgprot(pud_pgprot; > > start += PUD_SIZE; > cpa->pfn += PUD_SIZE; Yes you're right. That case needs to be fixed too. Are

Re: [PATCH V2 5/6] x86/intel_rdt: Use perf infrastructure for measurements

2018-09-06 Thread Peter Zijlstra
On Thu, Sep 06, 2018 at 01:05:05PM -0700, Reinette Chatre wrote: > When I separate the above into the two functions it just becomes either: >rdpmcl(l2_hit_pmcnum, l2_hits_after); >rdpmcl(l2_miss_pmcnum, l2_miss_after); > or: >rdpmcl(l3_hit

Re: [RFC PATCH 1/2] mm: move tlb_table_flush to tlb_flush_mmu_free

2018-09-06 Thread Rik van Riel
On Thu, 2018-08-23 at 18:47 +1000, Nicholas Piggin wrote: > There is no need to call this from tlb_flush_mmu_tlbonly, it > logically belongs with tlb_flush_mmu_free. This allows some > code consolidation with a subsequent fix. > > Signed-off-by: Nicholas Piggin Reviewed-by: Rik van Riel This p

Re: [PATCH v1] x86/intel_rdt: Switch to bitmap_zalloc()

2018-09-06 Thread Fenghua Yu
On Thu, Aug 30, 2018 at 02:50:39PM +0300, Andy Shevchenko wrote: > Switch to bitmap_zalloc() to show clearly what we are allocating. > Besides that it returns pointer of bitmap type instead of opaque void *. > > Signed-off-by: Andy Shevchenko > --- > arch/x86/kernel/cpu/intel_rdt.c | 10

Re: [PATCH] seccomp: remove unnecessary unlikely()

2018-09-06 Thread James Morris
On Wed, 5 Sep 2018, Igor Stoppa wrote: > WARN_ON() already contains an unlikely(), so it's not necessary to wrap it > into another. > > Signed-off-by: Igor Stoppa > Acked-by: Kees Cook > Cc: linux-security-mod...@vger.kernel.org > Cc: linux-kernel@vger.kernel.org Applied to git://git.kernel.or

<    1   2   3   4   5   6   7   8   9   10   >