[PATCH v2] PCI/AER: Do not clear AER bits if we don't own AER

2018-07-23 Thread Alexandru Gagniuc
When we don't own AER, we shouldn't touch the AER error bits. Clearing error bits willy-nilly might cause firmware to miss some errors. In theory, these bits get cleared by FFS, or via ACPI _HPX method. These mechanisms are not subject to the problem. This race is mostly of theoretical significanc

[PATCH v5] PCI: Check for PCIe downtraining conditions

2018-07-23 Thread Alexandru Gagniuc
PCIe downtraining happens when both the device and PCIe port are capable of a larger bus width or higher speed than negotiated. Downtraining might be indicative of other problems in the system, and identifying this from userspace is neither intuitive, nor straightforward. The easiest way to detect

Re: [PATCH] sched/numa: do not balance tasks onto isolated cpus

2018-07-23 Thread kbuild test robot
Hi Chen, Thank you for the patch! Yet something to improve: [auto build test ERROR on tip/sched/core] [also build test ERROR on v4.18-rc6 next-20180723] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

Re: [PATCH] sched/numa: do not balance tasks onto isolated cpus

2018-07-23 Thread kbuild test robot
Hi Chen, Thank you for the patch! Yet something to improve: [auto build test ERROR on tip/sched/core] [also build test ERROR on v4.18-rc6 next-20180723] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

Re: [PATCH v9 1/2] regulator: dt-bindings: add QCOM RPMh regulator bindings

2018-07-23 Thread Doug Anderson
Hi Mark, On Fri, Jul 13, 2018 at 6:50 PM, David Collins wrote: > Introduce bindings for RPMh regulator devices found on some > Qualcomm Technlogies, Inc. SoCs. These devices allow a given > processor within the SoC to make PMIC regulator requests which > are aggregated within the RPMh hardware b

Re: [PATCHv3 2/2] mtd: m25p80: restore the status of SPI flash when exiting

2018-07-23 Thread Boris Brezillon
Hi Brian, On Mon, 23 Jul 2018 11:13:50 -0700 Brian Norris wrote: > Hello, > > I noticed this got merged, but I wanted to put my 2 cents in here: I wish you had replied to this thread when it was posted (more than 6 months ago). Reverting the patch now implies making some people unhappy because

Re: Consolidating RCU-bh, RCU-preempt, and RCU-sched

2018-07-23 Thread Steven Rostedt
Sorry for the late reply, just came back from the Caribbean :-) :-) :-) On Fri, 13 Jul 2018 11:47:18 +0800 Lai Jiangshan wrote: > On Fri, Jul 13, 2018 at 8:02 AM, Paul E. McKenney > wrote: > > Hello! > > > > I now have a semi-reasonable prototype of changes consolidating the > > RCU-bh, RCU-p

Re: [PATCH 05/11] touchscreen: elants: Use octal permissions

2018-07-23 Thread Harshit Jain
I ran a treewide script and changed them all to octal and built a kernel which i am currently running on my machine, I have used DEVICE_ATTR_RO() for 0444's where possible if i dont find any regressions I will post a patch for review. I think i will be testing it at least for a week. On Tue, Jul 2

Re: [PATCH] mm/mempool: add missing parameter description

2018-07-23 Thread David Rientjes
On Mon, 23 Jul 2018, Mike Rapoport wrote: > The kernel-doc for mempool_init function is missing the description of the > pool parameter. Add it. > > Signed-off-by: Mike Rapoport Acked-by: David Rientjes My b.

Re: [PATCH] tpm: add support for partial reads

2018-07-23 Thread Jarkko Sakkinen
On Thu, Jul 19, 2018 at 08:52:32AM -0700, Tadeusz Struk wrote: > Currently to read a response from the TPM device an application needs > provide "big enough" buffer for the whole response and read it in one go. > The application doesn't know how big the response it beforehand so it > always needs t

Re: [PATCH] dd: Invoke one probe retry cycle after every initcall level

2018-07-23 Thread rishabhb
On 2018-07-23 04:17, Rafael J. Wysocki wrote: On Thu, Jul 19, 2018 at 11:24 PM, Rishabh Bhatnagar wrote: Drivers that are registered at an initcall level may have to wait until late_init before the probe deferral mechanism can retry their probe functions. It is possible that their dependencies

Re: Consolidating RCU-bh, RCU-preempt, and RCU-sched

2018-07-23 Thread Paul E. McKenney
On Mon, Jul 23, 2018 at 04:10:41PM -0400, Steven Rostedt wrote: > > Sorry for the late reply, just came back from the Caribbean :-) :-) :-) Welcome back, and I hope that the Caribbean trip was a good one! > On Fri, 13 Jul 2018 11:47:18 +0800 > Lai Jiangshan wrote: > > > On Fri, Jul 13, 2018 at

Re: [PATCH] mm: thp: remove use_zero_page sysfs knob

2018-07-23 Thread David Rientjes
On Sat, 21 Jul 2018, Matthew Wilcox wrote: > > The huge zero page can be reclaimed under memory pressure and, if it is, > > it is attempted to be allocted again with gfp flags that attempt memory > > compaction that can become expensive. If we are constantly under memory > > pressure, it gets

Re: [PATCH] mm: thp: remove use_zero_page sysfs knob

2018-07-23 Thread David Rientjes
On Fri, 20 Jul 2018, Yang Shi wrote: > I agree to keep it for a while to let that security bug cool down, however, if > there is no user anymore, it sounds pointless to still keep a dead knob. > It's not a dead knob. We use it, and for reasons other than CVE-2017-1000405. To mitigate the cost

Re: [patch v3 -mm 3/6] mm, memcg: add hierarchical usage oom policy

2018-07-23 Thread David Rientjes
On Mon, 16 Jul 2018, David Rientjes wrote: > > And "tree" is different. It actually changes how the selection algorithm > > works, > > and sub-tree settings do matter in this case. > > > > "Tree" is considering the entity as a single indivisible memory consumer, > it is compared with siblings

Re: bisected: 4.18-rc* regression: x86-32 troubles (with timers?)

2018-07-23 Thread Meelis Roos
> >> Now this seems more relevant: > >> > >> mroos@rx100s2:~/linux$ nice git bisect good > >> 24dea04767e6e5175f4750770281b0c17ac6a2fb is the first bad commit > >> commit 24dea04767e6e5175f4750770281b0c17ac6a2fb > >> Author: Daniel Borkmann > >> Date: Fri May 4 01:08:23 2018 +0200 > >> > >>

Re: kernel BUG at mm/shmem.c:LINE!

2018-07-23 Thread Matthew Wilcox
On Mon, Jul 23, 2018 at 12:14:41PM -0700, Hugh Dickins wrote: > On Mon, 23 Jul 2018, Matthew Wilcox wrote: > > On Sun, Jul 22, 2018 at 07:28:01PM -0700, Hugh Dickins wrote: > > > Whether or not that fixed syzbot's kernel BUG at mm/shmem.c:815! > > > I don't know, but I'm afraid it has not fixed lin

Re: Linux 4.18-rc6

2018-07-23 Thread Guenter Roeck
On Sun, Jul 22, 2018 at 02:23:39PM -0700, Linus Torvalds wrote: > So this was the week when the other shoe dropped ... The reason the > two previous rc releases were so nice and small was that David hadn't > sent me much networking fixes, and they came in this week. > Build results: tota

Re: [PATCH v3 1/2] dt-bindings: pfuze100: add optional disable switch-regulators binding

2018-07-23 Thread Fabio Estevam
On Mon, Jul 23, 2018 at 4:47 AM, Marco Felsch wrote: > This binding is used to keep the backward compatibility with the current > dtb's [1]. The binding informs the driver that the unused switch regulators > can be disabled. > If it is not specified, the driver doesn't disable the switch regulator

Re: [PATCH v3 2/2] regulator: pfuze100: add support to en-/disable switch regulators

2018-07-23 Thread Fabio Estevam
On Mon, Jul 23, 2018 at 4:47 AM, Marco Felsch wrote: > Add enable/disable support for switch regulators on pfuze100. > > Based on commit 5fe156f1cab4 ("regulator: pfuze100: add enable/disable for > switch") which is reverted due to boot regressions by commit 464a5686e6c9 > ("regulator: Revert "reg

[PATCH 01/15] staging:rtl8192u: Remove typedef of u32 to QOS_MODE - Style

2018-07-23 Thread John Whitmore
The typedef of QOS_MODE as a u32 is contrary to coding standard and fails the checkpatch tests for defining new types in code. Definitions of type QOS_MODE have simply been replaced with a u32 type. This is a coding style change which should not impact runtime execution. Signed-off-by: John Whitm

[PATCH 04/15] staging:rtl8192u: Removed unused structure BSS_QOS - Style

2018-07-23 Thread John Whitmore
The structure BSS_QOS is not used in code so has simply been removed. The change is a coding style change and should not impact runtime execution. Signed-off-by: John Whitmore --- .../staging/rtl8192u/ieee80211/rtl819x_Qos.h | 19 --- 1 file changed, 19 deletions(-) diff --git

[PATCH 00/15] Removal of usused definitions - Style

2018-07-23 Thread John Whitmore
Clean up of the file drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h A number of the definitions in the file are unused so were removed from the file. John Whitmore (15): staging:rtl8192u: Remove typedef of u32 to QOS_MODE - Style staging:rtl8192u: Remove unused enumerated type ACK_POLICY -

[PATCH 02/15] staging:rtl8192u: Remove unused enumerated type ACK_POLICY - Style

2018-07-23 Thread John Whitmore
The enumerated type ACK_POLICY is not used in code so it has been removed from the source code. This is a coding style change and should have no impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h | 9 - 1 file changed, 9 de

[PATCH 05/15] staging:rtl8192u: Remove unused structure STA_QOS - Style

2018-07-23 Thread John Whitmore
Remove structure STA_QOS as it is unused in code. This change is a coding style change so should not impact runtime code execution. Signed-off-by: John Whitmore --- .../staging/rtl8192u/ieee80211/rtl819x_Qos.h | 53 --- 1 file changed, 53 deletions(-) diff --git a/drivers/stagi

[PATCH 11/15] staging:rtl8192u: Remove unused structure WMM_TSPEC - Style

2018-07-23 Thread John Whitmore
Remove the structure WMM_TSPEC as it is unused. This change is a coding style change and should not impact runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h | 15 --- 1 file changed, 15 deletions(-) diff --git a/drivers/staging

[PATCH 09/15] staging:rtl8192u: Remove unused enumerated type QOS_ELE_SUBTYPE - Style

2018-07-23 Thread John Whitmore
The enumerated type QOS_ELE_SUBTYPE is unused in code so has been removed from code. This is a coding style change which should have not impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h | 11 --- 1 file changed, 11 deleti

[PATCH 13/15] staging:rtl8192u: Remove unused structure ACM - Style

2018-07-23 Thread John Whitmore
Remove the structure ACM as it is unused in code. This change is a coding style change and should have no impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/staging/

[PATCH 14/15] staging:rtl8192u: Remove unused AC_UAPSD definitions - Style

2018-07-23 Thread John Whitmore
Remove the definitions associated with AC_UAPSD. These definitions are not used in code so have simply been removed. This is a coding style change and should have no impact on runtime execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h | 15 --

[PATCH 15/15] staging:rtl8192u: Remove unused definition of sQoSCtlLng - Style

2018-07-23 Thread John Whitmore
Remove sQoSCtlLng. The constant sQoSCtlLng is never used in code so has been removed. This is a coding style change so should have no impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h | 6 -- 1 file changed, 6 deletions(-) di

[PATCH 06/15] staging:rtl8192u: Remove unused structure QOS_CTRL_FIELD - Style

2018-07-23 Thread John Whitmore
The structure QOS_CTRL_FIELD is unused in code so has simply been removed from source. This is a coding style change and should have no impact on runtime code execution. Signed-off-by: John Whitmore --- .../staging/rtl8192u/ieee80211/rtl819x_Qos.h | 50 --- 1 file changed, 50 de

[PATCH 12/15] staging:rtl8192u: Remove unused enumerated type ACM_METHOD - Style

2018-07-23 Thread John Whitmore
Remove the enumerated type ACM_METHOD as it is unused in code. This is a coding style change and should not impact runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h | 11 --- 1 file changed, 11 deletions(-) diff --git a/drivers/sta

[PATCH 08/15] staging:rtl8192u: Remove the unused AC_CODING definitions - Style

2018-07-23 Thread John Whitmore
The AC_CODING definitions are unused in code, so have simply been removed from source. This is a coding style change and should not impact runtime code execution. Signed-off-by: John Whitmore --- .../staging/rtl8192u/ieee80211/rtl819x_Qos.h | 20 --- 1 file changed, 20 deletions

[PATCH 10/15] staging:rtl8192u: Remove unused structure QOS_TSTREAM - Style

2018-07-23 Thread John Whitmore
The structure QOS_TSTREAM is unused in code so has simply been removed. This change is a coding style change and should have no impact on runtime code execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_Qos.h | 11 --- 1 file changed, 11 deletions(-) d

[PATCH 07/15] staging:rtl8192u: Remove unused union QOS_INFO_FIELD - Style

2018-07-23 Thread John Whitmore
The union QOS_INFO_FIELD is unused in code so has been removed from source. This change is a coding style change so should have no impact on runtime code execution. Signed-off-by: John Whitmore --- .../staging/rtl8192u/ieee80211/rtl819x_Qos.h | 86 --- 1 file changed, 86 deletio

[PATCH 03/15] staging:rtl8192u: Remove unused QOS definitions - Style

2018-07-23 Thread John Whitmore
Remove the unused QOS related types. Since definitions are not used simply remove from code. This change is a coding style change and should not impact runtime execution. Signed-off-by: John Whitmore --- .../staging/rtl8192u/ieee80211/rtl819x_Qos.h | 22 --- 1 file changed, 22

Re: [PATCH] tpm: add support for partial reads

2018-07-23 Thread Tadeusz Struk
On 07/23/2018 01:19 PM, Jarkko Sakkinen wrote: > In this case I do not have any major evidence of any major benefit *and* > the change breaks the ABI. As I said before - this does not break the ABI. As for the benefits - it help user space in how they implement the receive path. Application does n

Re: [PATCH v6] pidns: introduce syscall translate_pid

2018-07-23 Thread Michael Tirado
Hey, I'm not seeing much activity on this so here's my $0.02 > Unix socket automatically translates pid attached to SCM_CREDENTIALS. > This requires CAP_SYS_ADMIN for sending arbitrary pids and entering > into pid namespace, this expose process and could be insecure. Perhaps it would be a good i

Re: Linux 4.18-rc6

2018-07-23 Thread Linus Torvalds
Adding davem for the sparc issue, Martin for the s390 one. On Mon, Jul 23, 2018 at 1:46 PM Guenter Roeck wrote: > > The s390 gcc plugins related build error reported previously has not really > been fixed; after feedback from the s390 maintainers, suggesting that it > won't get fixed in 4.18, I d

Re: [PATCH 0/4] ia64: switch to NO_BOOTMEM

2018-07-23 Thread Luck, Tony
On Mon, Jul 23, 2018 at 08:56:54AM +0300, Mike Rapoport wrote: > Hi, > > These patches convert ia64 to use NO_BOOTMEM. > > The first two patches are cleanups, the third patches reduces usage of > 'struct bootmem_data' for easier transition and the forth patch actually > replaces bootmem with memb

Re: [PATCH v5] PCI: Check for PCIe downtraining conditions

2018-07-23 Thread Jakub Kicinski
On Mon, 23 Jul 2018 15:03:38 -0500, Alexandru Gagniuc wrote: > PCIe downtraining happens when both the device and PCIe port are > capable of a larger bus width or higher speed than negotiated. > Downtraining might be indicative of other problems in the system, and > identifying this from userspace

Re: linux-next: Tree for Jul 23

2018-07-23 Thread Stephen Rothwell
Hi Michael, On Tue, 24 Jul 2018 00:35:22 +1000 Michael Ellerman wrote: > > Would you mind adding my "topic/hvc" branch to linux-next. > > We (ppc) are notionally the maintainers for that code but it's used by > some other folks, so I'd like it to get some wider testing before I > commit it. > >

Re: Linux 4.18-rc6

2018-07-23 Thread David Miller
From: Linus Torvalds Date: Mon, 23 Jul 2018 13:56:15 -0700 > Hmm. I assume it's > > arch/sparc/include/asm/cacheflush_32.h > > that wants a forward-declaration of 'struct page', and doesn't include > any header files. > > The fix is presumably to move the > >#include > > in drivers

[PATCH v2] IB/mlx5: avoid excessive warning msgs when creating VFs on 2nd port

2018-07-23 Thread Qing Huang
When a CX5 device is configured in dual-port RoCE mode, after creating many VFs against port 1, creating the same number of VFs against port 2 will flood kernel/syslog with something like "mlx5_*:mlx5_ib_bind_slave_port:4266:(pid 5269): port 2 already affiliated." So basically, when traversing mlx

Re: [PATCH v2] IB/mlx5: avoid excessive warning msgs when creating VFs on 2nd port

2018-07-23 Thread Daniel Jurgens
On 7/23/2018 4:15 PM, Qing Huang wrote: > When a CX5 device is configured in dual-port RoCE mode, after creating > many VFs against port 1, creating the same number of VFs against port 2 > will flood kernel/syslog with something like > "mlx5_*:mlx5_ib_bind_slave_port:4266:(pid 5269): port 2 alre

Re: [PATCH] tpm: add support for partial reads

2018-07-23 Thread James Bottomley
On Mon, 2018-07-23 at 13:53 -0700, Tadeusz Struk wrote: > On 07/23/2018 01:19 PM, Jarkko Sakkinen wrote: > > In this case I do not have any major evidence of any major benefit > > *and* the change breaks the ABI. > > As I said before - this does not break the ABI. The current patch does, you even

Re: [PATCH v6] pidns: introduce syscall translate_pid

2018-07-23 Thread Nagarathnam Muthusamy
On 07/23/2018 01:55 PM, Michael Tirado wrote: Hey, I'm not seeing much activity on this so here's my $0.02 Unix socket automatically translates pid attached to SCM_CREDENTIALS. This requires CAP_SYS_ADMIN for sending arbitrary pids and entering into pid namespace, this expose process and cou

Re: [PATCH 0/10] psi: pressure stall information for CPU, memory, and IO v2

2018-07-23 Thread Balbir Singh
On Fri, Jul 13, 2018 at 3:27 AM Johannes Weiner wrote: > > PSI aggregates and reports the overall wallclock time in which the > tasks in a system (or cgroup) wait for contended hardware resources. > > This helps users understand the resource pressure their workloads are > under, which allows them

Re: [PATCH] hexagon: switch to NO_BOOTMEM

2018-07-23 Thread Richard Kuo
On Mon, Jul 16, 2018 at 10:43:18AM +0300, Mike Rapoport wrote: > This patch adds registration of the system memory with memblock, eliminates > bootmem initialization and converts early memory reservations from bootmem > to memblock. > > Signed-off-by: Mike Rapoport Sorry for the delay, and tha

Re: Linux 4.18-rc6

2018-07-23 Thread Guenter Roeck
On Mon, Jul 23, 2018 at 01:56:15PM -0700, Linus Torvalds wrote: > Adding davem for the sparc issue, Martin for the s390 one. > > On Mon, Jul 23, 2018 at 1:46 PM Guenter Roeck wrote: > > > > The s390 gcc plugins related build error reported previously has not really > > been fixed; after feedback

[PATCH RFC] debugobjects: Make stack check warning more informative

2018-07-23 Thread Joel Fernandes
From: "Joel Fernandes (Google)" Recently we debugged an issue where debugobject tracking was telling us of an annotation issue. Turns out the issue was due to the object in concern being on a different stack which was due to another issue. Discussing with tglx, he suggested printing the pointers

[RFC PATCH] checkpatch: Discourage use with --f/--file outside of drivers/staging ?

2018-07-23 Thread Joe Perches
Perhaps some patch like this could help reduce the number of ill-considered checkpatch submissions for files outside of drivers/staging/ Concept and message wordsmithing appreciated... --- scripts/checkpatch.pl | 4 1 file changed, 4 insertions(+) diff --git a/scripts/checkpatch.pl b/script

Re: [patch v3 -mm 3/6] mm, memcg: add hierarchical usage oom policy

2018-07-23 Thread Roman Gushchin
On Mon, Jul 23, 2018 at 01:33:19PM -0700, David Rientjes wrote: > On Mon, 16 Jul 2018, David Rientjes wrote: > > > > And "tree" is different. It actually changes how the selection algorithm > > > works, > > > and sub-tree settings do matter in this case. > > > > > > > "Tree" is considering the

Re: [PATCH] mm: thp: remove use_zero_page sysfs knob

2018-07-23 Thread David Rientjes
On Mon, 23 Jul 2018, David Rientjes wrote: > > > The huge zero page can be reclaimed under memory pressure and, if it is, > > > it is attempted to be allocted again with gfp flags that attempt memory > > > compaction that can become expensive. If we are constantly under memory > > > pressure,

Re: [PATCH] arch/h8300: fix kernel/dma.c build warning

2018-07-23 Thread Richard Kuo
On Sun, Jul 22, 2018 at 10:24:58AM -0700, Randy Dunlap wrote: > On 07/22/2018 02:25 AM, Geert Uytterhoeven wrote: > > CC hexagon > > > > hexagon != H8/300 != SuperH > > argh. Thanks. > > > On Sat, Jul 21, 2018 at 5:17 AM Randy Dunlap wrote: > >> > >> From: Randy Dunlap > >> > >> Fix build war

Re: [PATCH v3] PCI: Check for PCIe downtraining conditions

2018-07-23 Thread Tal Gilboa
On 7/23/2018 8:01 PM, Alex G. wrote: On 07/23/2018 12:21 AM, Tal Gilboa wrote: On 7/19/2018 6:49 PM, Alex G. wrote: On 07/18/2018 08:38 AM, Tal Gilboa wrote: On 7/16/2018 5:17 PM, Bjorn Helgaas wrote: [+cc maintainers of drivers that already use pcie_print_link_status() and GPU folks] [sni

Re: [PATCH 0/3] PTI for x86-32 Fixes and Updates

2018-07-23 Thread Pavel Machek
On Mon 2018-07-23 12:00:08, Linus Torvalds wrote: > On Mon, Jul 23, 2018 at 7:09 AM Pavel Machek wrote: > > > > Meanwhile... it looks like gcc is not slowed down significantly, but > > other stuff sees 30% .. 40% slowdowns... which is rather > > significant. > > That is more or less expected. >

Re: [PATCH] tpm: add support for partial reads

2018-07-23 Thread Tadeusz Struk
On 07/23/2018 02:13 PM, James Bottomley wrote: > The current patch does, you even provided a use case in your last email > (it's do command to get sizing followed by do command with correctly > sized buffer). The example I provided was: #1 send a command, #2 read the response header (10 bytes),

Re: [PATCH] IPoIB: use kvzalloc to allocate an array of bucket pointers

2018-07-23 Thread Jason Gunthorpe
On Mon, Jul 09, 2018 at 04:51:03PM +0300, Jan Dakinevich wrote: > This table by default takes 32KiB which is 3rd memory order. Meanwhile, > this memory is not aimed for DMA operation and could be safely allocated > by vmalloc. > > Signed-off-by: Jan Dakinevich > Reviewed-by: Håkon Bugge > --- >

[PATCH] android: binder: Include asm/cacheflush.h after linux/ include files

2018-07-23 Thread Guenter Roeck
If asm/cacheflush.h is included first, the following build warnings are seen with sparc32 builds. In file included from arch/sparc/include/asm/cacheflush.h:11:0, from drivers/android/binder.c:54: arch/sparc/include/asm/cacheflush_32.h:40:37: warning: 'struct page' declared inside p

Re: [PATCH] mtd: spi-nor: clear Extended Address Reg on switch to 3-byte addressing.

2018-07-23 Thread NeilBrown
On Mon, Jul 23 2018, Brian Norris wrote: > Hi, > > I'm a little late to this thread, but I recently noticed (and > complained about) commit: 59b356ffd0b0 ("mtd: m25p80: restore the > status of SPI flash when exiting"). > > On Mon, Apr 9, 2018 at 6:05 PM, NeilBrown wrote: >> On Mon, Apr 09 2018, M

[PATCH] android: binder_alloc: Include asm/cacheflush.h after linux/ include files

2018-07-23 Thread Guenter Roeck
If asm/cacheflush.h is included first, the following build warnings are seen with sparc32 builds. In file included from ./arch/sparc/include/asm/cacheflush.h:11:0, from drivers/android/binder_alloc.c:20: ./arch/sparc/include/asm/cacheflush_32.h:40:37: warning: 'struct page' declare

linux-next-20180723: battery status funny after bootup

2018-07-23 Thread Pavel Machek
pavel@amd:~$ cat /proc/acpi/battery/BAT0/state present: yes capacity state: ok charging state: charged present rate:0 mW remaining capacity: 0 mWh present voltage: 0 mV pavel@amd:~$ uname -a Linux amd 4.18.0-rc6-next-20180723+ #141 SMP

Re: [PATCH] tpm: add support for partial reads

2018-07-23 Thread Jason Gunthorpe
On Thu, Jul 19, 2018 at 08:52:32AM -0700, Tadeusz Struk wrote: > Currently to read a response from the TPM device an application needs > provide "big enough" buffer for the whole response and read it in one go. > The application doesn't know how big the response it beforehand so it > always needs t

Re: [PATCH] mm: thp: remove use_zero_page sysfs knob

2018-07-23 Thread Yang Shi
On 7/23/18 2:33 PM, David Rientjes wrote: On Mon, 23 Jul 2018, David Rientjes wrote: The huge zero page can be reclaimed under memory pressure and, if it is, it is attempted to be allocted again with gfp flags that attempt memory compaction that can become expensive. If we are constantly un

[PATCH v7 07/12] dt-bindings: mfd: Add a document for PECI client MFD

2018-07-23 Thread Jae Hyun Yoo
This commit adds a dt-bindings document for PECI client MFD. Signed-off-by: Jae Hyun Yoo Cc: Lee Jones Cc: Rob Herring Cc: Mark Rutland Cc: Andrew Jeffery Cc: James Feist Cc: Jason M Biils Cc: Joel Stanley Cc: Vernon Mauery --- .../bindings/mfd/intel-peci-client.txt| 34 +

Re: [PATCH 0/3] PTI for x86-32 Fixes and Updates

2018-07-23 Thread Andy Lutomirski
> On Jul 23, 2018, at 2:38 PM, Pavel Machek wrote: > >> On Mon 2018-07-23 12:00:08, Linus Torvalds wrote: >>> On Mon, Jul 23, 2018 at 7:09 AM Pavel Machek wrote: >>> >>> Meanwhile... it looks like gcc is not slowed down significantly, but >>> other stuff sees 30% .. 40% slowdowns... which is

Re: [PATCH v5] PCI: Check for PCIe downtraining conditions

2018-07-23 Thread Tal Gilboa
On 7/24/2018 12:01 AM, Jakub Kicinski wrote: On Mon, 23 Jul 2018 15:03:38 -0500, Alexandru Gagniuc wrote: PCIe downtraining happens when both the device and PCIe port are capable of a larger bus width or higher speed than negotiated. Downtraining might be indicative of other problems in the syst

Re: [PATCH] mm: thp: remove use_zero_page sysfs knob

2018-07-23 Thread Yang Shi
On 7/23/18 1:31 PM, David Rientjes wrote: On Fri, 20 Jul 2018, Yang Shi wrote: I agree to keep it for a while to let that security bug cool down, however, if there is no user anymore, it sounds pointless to still keep a dead knob. It's not a dead knob. We use it, and for reasons other tha

[PATCH v2 2/2] clk: qcom: Add qspi (Quad SPI) clocks for sdm845

2018-07-23 Thread Douglas Anderson
Add both the interface and core clock. Signed-off-by: Douglas Anderson --- Changes in v2: - Only 19.2, 100, 150, and 300 MHz now. - All clocks come from MAIN rather than EVEN. - Use parent map 0 instead of new parent map 9. drivers/clk/qcom/gcc-sdm845.c | 63 +++

[PATCH v2 0/2] clk: qcom: Quad SPI (qspi) clock support for sdm845

2018-07-23 Thread Douglas Anderson
This two-series patch adds the needed clock bits to use the Quad SPI (qspi) part on sdm845. It's expected that the bindings part of this patch could land in the clock tree with an immutable git hash and then be pulled into the Qualcomm tree so it could be used by dts files. >From the reply to m

[PATCH v2 1/2] clk: qcom: Add qspi (Quad SPI) clock defines for sdm845 to header

2018-07-23 Thread Douglas Anderson
These clocks will need to be defined in the clock driver and referenced in device tree files. Signed-off-by: Douglas Anderson --- Changes in v2: None include/dt-bindings/clock/qcom,gcc-sdm845.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/include/dt-bindings/clock/qcom,gcc-sdm845.h

Re: HID: intel_ish-hid: tx_buf memory leak on probe/remove

2018-07-23 Thread Srinivas Pandruvada
On Mon, 2018-07-23 at 20:56 +0300, Anton Vasilyev wrote: > ish_dev_init() allocates 512*176 bytes memory for tx_buf and stores > it at > &dev->wr_free_list_head.link list on ish_probe(). > But there is no deallocation of this memory in ish_remove() and in > ish_probe() > error path. > So current i

Re: [PATCH RFC] debugobjects: Make stack check warning more informative

2018-07-23 Thread Yang Shi
On 7/23/18 2:25 PM, Joel Fernandes wrote: From: "Joel Fernandes (Google)" Recently we debugged an issue where debugobject tracking was telling us of an annotation issue. Turns out the issue was due to the object in concern being on a different stack which was due to another issue. Discussin

Re: [PATCH 0/3] PTI for x86-32 Fixes and Updates

2018-07-23 Thread Pavel Machek
Hi! > > What I want is "if A can ptrace B, and B has pti disabled, A can have > > pti disabled as well". Now.. I see someone may want to have it > > per-thread, because for stuff like javascript JIT, thread may have > > rights to call ptrace, but is unable to call ptrace because JIT > > removed th

Re: [PATCH] tpm: add support for partial reads

2018-07-23 Thread Jason Gunthorpe
On Mon, Jul 23, 2018 at 02:38:08PM -0700, Tadeusz Struk wrote: > On 07/23/2018 02:13 PM, James Bottomley wrote: > > The current patch does, you even provided a use case in your last email > > (it's do command to get sizing followed by do command with correctly > > sized buffer). > > The example

Re: [PATCH] tpm: add support for partial reads

2018-07-23 Thread Tadeusz Struk
On 07/23/2018 02:56 PM, Jason Gunthorpe wrote: > The proposed patch doesn't clear the data_pending if the entire buffer > is not consumed, so of course it is ABI breaking, that really isn't OK. The data_pending will be cleared by the timeout handler if the user doesn't read the response fully befo

Re: [PATCH 1/5] mfd: rk808: Add RK817 and RK809 support

2018-07-23 Thread kbuild test robot
Hi Tony, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on ljones-mfd/for-mfd-next] [also build test WARNING on v4.18-rc6 next-20180723] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https

Re: [RFC v5 0/2] mm: zap pages with read mmap_sem in munmap for large mapping

2018-07-23 Thread Yang Shi
Hi folks, Any comment on this version? Thanks, Yang On 7/18/18 4:21 PM, Yang Shi wrote: Background: Recently, when we ran some vm scalability tests on machines with large memory, we ran into a couple of mmap_sem scalability issues when unmapping large memory space, please refer to https://

Re: [PATCH 0/3] PTI for x86-32 Fixes and Updates

2018-07-23 Thread Josh Poimboeuf
On Mon, Jul 23, 2018 at 11:38:30PM +0200, Pavel Machek wrote: > But for now I'd like at least "global" option of turning pti on/off > during runtime for benchmarking. Let me see... > > Something like this, or is it going to be way more complex? Does > anyone have patch by chance? RHEL/CentOS has

Re: [PATCHv3 2/2] mtd: m25p80: restore the status of SPI flash when exiting

2018-07-23 Thread Brian Norris
Hi Boris, On Mon, Jul 23, 2018 at 1:10 PM, Boris Brezillon wrote: > On Mon, 23 Jul 2018 11:13:50 -0700 > Brian Norris wrote: >> I noticed this got merged, but I wanted to put my 2 cents in here: > > I wish you had replied to this thread when it was posted (more than > 6 months ago). Reverting th

Re: [PATCH 0/3] PTI for x86-32 Fixes and Updates

2018-07-23 Thread Dave Hansen
On 07/23/2018 02:59 PM, Josh Poimboeuf wrote: > On Mon, Jul 23, 2018 at 11:38:30PM +0200, Pavel Machek wrote: >> But for now I'd like at least "global" option of turning pti on/off >> during runtime for benchmarking. Let me see... >> >> Something like this, or is it going to be way more complex? Do

Re: [PATCH] tpm: add support for partial reads

2018-07-23 Thread Jason Gunthorpe
On Mon, Jul 23, 2018 at 03:00:20PM -0700, Tadeusz Struk wrote: > On 07/23/2018 02:56 PM, Jason Gunthorpe wrote: > > The proposed patch doesn't clear the data_pending if the entire buffer > > is not consumed, so of course it is ABI breaking, that really isn't OK. > > The data_pending will be cleare

Re: [PATCH] drivers/pci/probe: Move variable bridge inside ifdef

2018-07-23 Thread Bjorn Helgaas
On Sat, Jul 21, 2018 at 11:45:56PM +0200, Anders Roxell wrote: > When CONFIG_PCI_QUIRKS isn't enabled we get the warning below: > drivers/pci/probe.c: In function ‘pci_bus_read_dev_vendor_id’: > drivers/pci/probe.c:2221:18: warning: unused variable ‘bridge’ > [-Wunused-variable] > struct pci_dev

Re: [PATCH 4.4 000/107] 4.4.144-stable review

2018-07-23 Thread Dan Rue
//git.linaro.org/lkft/arm64-stable-rc.git git branch: 4.4.144-rc1-hikey-20180723-241 git commit: 74ff347a1f4bd5b91588a4025bfd29ae7a28329d git describe: 4.4.144-rc1-hikey-20180723-241 Test details: https://qa-reports.linaro.org/lkft/linaro-hikey-stable-rc-4.4-oe/build/4.4.144-rc1-hikey-20180723-241 No

Re: [PATCH v5] PCI: Check for PCIe downtraining conditions

2018-07-23 Thread Jakub Kicinski
On Tue, 24 Jul 2018 00:52:22 +0300, Tal Gilboa wrote: > On 7/24/2018 12:01 AM, Jakub Kicinski wrote: > > On Mon, 23 Jul 2018 15:03:38 -0500, Alexandru Gagniuc wrote: > >> PCIe downtraining happens when both the device and PCIe port are > >> capable of a larger bus width or higher speed than negot

Re: [PATCH v4] iio: chemical: Add support for Bosch BME680 sensor

2018-07-23 Thread David Frey
On 7/22/2018 3:21 PM, Himanshu Jha wrote: On Sat, Jul 21, 2018 at 08:45:34PM +0300, Daniel Baluta wrote: On Sat, Jul 21, 2018 at 6:43 PM, Andy Shevchenko wrote: On Sat, Jul 21, 2018 at 6:36 PM, Himanshu Jha wrote: + /* Look up table 1 for the possible gas range values */ + u32 lookupTab

Re: [PATCH] mtd: spi-nor: clear Extended Address Reg on switch to 3-byte addressing.

2018-07-23 Thread Brian Norris
Hi Neil, On Mon, Jul 23, 2018 at 2:45 PM, NeilBrown wrote: > On Mon, Jul 23 2018, Brian Norris wrote: >> On Mon, Apr 9, 2018 at 6:05 PM, NeilBrown wrote: >>> On Mon, Apr 09 2018, Marek Vasut wrote: On 04/08/2018 11:56 PM, NeilBrown wrote: > were added to Linux. They appear to be design

[PATCH] Staging: octeon: Apply Licence and resolves warnings according to TODO list. There are also a few "checks" that probably should revised but i think most of them could be resolved by breaking d

2018-07-23 Thread Georgios Tsotsos
Signed-off-by: Georgios Tsotsos --- drivers/staging/octeon-usb/octeon-hcd.c | 55 ++--- drivers/staging/octeon-usb/octeon-hcd.h | 1 + 2 files changed, 31 insertions(+), 25 deletions(-) diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-us

Re: [PATCH v7 08/12] mfd: intel-peci-client: Add PECI client MFD driver

2018-07-23 Thread Randy Dunlap
On 07/23/2018 02:47 PM, Jae Hyun Yoo wrote: > This commit adds PECI client MFD driver. > > Signed-off-by: Jae Hyun Yoo > Cc: Lee Jones > Cc: Rob Herring > Cc: Andrew Jeffery > Cc: James Feist > Cc: Jason M Biils > Cc: Joel Stanley > Cc: Vernon Mauery > --- > drivers/mfd/Kconfig

Re: [PATCH] mtd: spi-nor: clear Extended Address Reg on switch to 3-byte addressing.

2018-07-23 Thread NeilBrown
On Mon, Jul 23 2018, Brian Norris wrote: > Hi Neil, > > On Mon, Jul 23, 2018 at 2:45 PM, NeilBrown wrote: >> On Mon, Jul 23 2018, Brian Norris wrote: >>> On Mon, Apr 9, 2018 at 6:05 PM, NeilBrown wrote: On Mon, Apr 09 2018, Marek Vasut wrote: > On 04/08/2018 11:56 PM, NeilBrown wrote: >

[PATCH 1/2] PCI: Export pcie_has_flr()

2018-07-23 Thread Alex Williamson
pcie_flr() suggests pcie_has_flr() to ensure that PCIe FLR support is present prior to calling. pcie_flr() is exported while pcie_has_flr() is not. Resolve this. Signed-off-by: Alex Williamson --- drivers/pci/pci.c |3 ++- include/linux/pci.h |1 + 2 files changed, 3 insertions(+), 1

[PATCH 0/2] PCI: NVMe reset quirk

2018-07-23 Thread Alex Williamson
As discussed in the 2nd patch, at least one NVMe controller sometimes doesn't like being reset while enabled and another will timeout during a subsequent re-enable if it happens too quickly after reset. Introduce a device specific reset quirk for all NVMe class devices so that we can try to get rel

[PATCH 2/2] PCI: NVMe device specific reset quirk

2018-07-23 Thread Alex Williamson
Take advantage of NVMe devices using a standard interface to quiesce the controller prior to reset, including device specific delays before and after that reset. This resolves several NVMe device assignment scenarios with two different vendors. The Intel DC P3700 controller has been shown to only

Re: [PATCH v2 09/10] coresight: perf: Remove set_buffer call back

2018-07-23 Thread Suzuki K Poulose
Mathieu, On 07/23/2018 07:22 PM, Mathieu Poirier wrote: On Fri, 20 Jul 2018 at 03:04, Suzuki K Poulose wrote: Mathieu, On 19/07/18 21:36, Mathieu Poirier wrote: On Tue, Jul 17, 2018 at 06:11:40PM +0100, Suzuki K Poulose wrote: In coresight perf mode, we need to prepare the sink before star

Re: [PATCH V4 2/7] mmc: sdhci: Change SDMA address register for v4 mode

2018-07-23 Thread kbuild test robot
Hi Chunyan, I love your patch! Perhaps something to improve: [auto build test WARNING on ulf.hansson-mmc/next] [also build test WARNING on v4.18-rc6 next-20180723] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com

Re: [PATCH V4 2/7] mmc: sdhci: Change SDMA address register for v4 mode

2018-07-23 Thread kbuild test robot
Hi Chunyan, I love your patch! Perhaps something to improve: [auto build test WARNING on ulf.hansson-mmc/next] [also build test WARNING on v4.18-rc6 next-20180723] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com

Re: [PATCH v10 1/7] dt-bindings: net: bluetooth: Add device tree bindings for QTI chip wcn3990

2018-07-23 Thread Matthias Kaehlcke
On Fri, Jul 20, 2018 at 07:02:37PM +0530, Balakrishna Godavarthi wrote: > This patch enables regulators for the Qualcomm Bluetooth wcn3990 > controller. > > Signed-off-by: Balakrishna Godavarthi > Reviewed-by: Rob Herring > --- > Changes in v10: > * added entry for regulator currents > > Ch

Re: [PATCH v1 09/10] Input: atmel_mxt_ts - tool type is ignored when slot is closed

2018-07-23 Thread Dmitry Torokhov
On Fri, Jul 20, 2018 at 10:51:21PM +0100, Nick Dyer wrote: > From: Nick Dyer > > input_mt_report_slot_state() ignores the tool when the slot is closed. > Remove the tool type from these function calls, which has caused a bit of > confusion. Hmm, maybe we could introduce MT_TOOL_NONE or MT_TOOL_I

Re: [PATCH v1 07/10] Input: atmel_mxt_ts - zero terminate config firmware file

2018-07-23 Thread Dmitry Torokhov
On Fri, Jul 20, 2018 at 10:51:19PM +0100, Nick Dyer wrote: > From: Nick Dyer > > We use sscanf to parse the configuration file, so it's necessary to zero > terminate the configuration otherwise a truncated file can cause the > parser to run off into uninitialised memory. > > Signed-off-by: Nick

<    3   4   5   6   7   8   9   10   >