On Fri, 20 Jul 2018 17:15:01 +0200
Miquel Raynal wrote:
> Two helpers have been added to the core to make ECC-related
> configuration between the detection phase and the final NAND scan. Use
> these hooks and convert the driver to just use nand_scan() instead of
> both nand_scan_ident() and nand_
On Fri, Jul 20, 2018 at 09:21:35PM +0100, John Whitmore wrote:
> Removed the typedef from structure RT_DOT11D_INFO. This change clears the
> checkpatch issue with declaring new types.
>
> Rename the structure from RT_DOT11D_INFO to rt_dot11d_info.
>
> Coding style changes which should not impact
On Mon, Jul 16, 2018 at 08:04:53PM +0100, John Whitmore wrote:
> Rename the struct TS_COMMON_INFO member variable TClasProc to
> t_clas_proc. This change clears the checkpatch issue with CamelCase variable
> names. There should be no impact on runtime execution.
>
> Signed-off-by: John Whitmore
>
On Thu, Jul 19, 2018 at 12:05:25AM -0400, Nicolas Pitre wrote:
>
> The nr argument is typically small: most often nr == 1. However this
> could be abused with a very large explicit scroll in a resized screen.
> Make the code scroll lines by performing an array rotation operation to
> avoid the nee
On Fri, 2018-07-20 at 12:44 +0200, Matthias Brugger wrote:
>
> On 20/07/18 10:19, Erin Lo wrote:
> > On Mon, 2018-07-16 at 11:28 +0200, Matthias Brugger wrote:
> >> Hi Erin,
> >>
> >> On 17/05/18 08:22, Erin Lo wrote:
> >>> MT8183 is a SoC based on 64bit ARMv8 architecture.
> >>> It contains 4 CA5
On 20 July 2018 at 17:43, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 4.9.114 release.
> There are 66 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses
My name is Lisa i saw your email today when i was searching for
someone i can trust and let know more about me and i became interested
in you, i will also like to know you the more, I believe we can move
from here! I am waiting for your mail. and I have vital information
you need to know. Please,
On 20 July 2018 at 17:43, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 4.4.143 release.
> There are 31 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses
On Wed, Jul 18, 2018 at 05:01:52AM +0200, Adam Borowski wrote:
> Hi!
> Here's a patchset with two entangled improvements:
>
> * it'd be good to get rid of blinking where possible. Even CGA (thus VGA)
> allows disabling it, rendering such characters with a bright background
> instead.
> * due
On Tue, Jul 17, 2018 at 05:14:53PM -0700, r...@google.com wrote:
> From: Roman Kiryanov
>
> To make further maintenance easier.
That sentance makes no sense :(
Please be specific as to what exactly you are doing here.
thanks,
greg k-h
On Tue, Jul 17, 2018 at 05:14:54PM -0700, r...@google.com wrote:
> From: Roman Kiryanov
>
> enums produce better compilation errors than defines.
Yes, if you name the enum. But you didn't do that here, so this patch
really does not do anything to cause any "protection" at all :(
Please fix thi
--
Hello
You have a message from the office of Mr. Fawaz KhE. Al Saleh Member of
the Board of Directors, Kuveyt Türk Participation Bank (Turkey)
REPLY for Further Details via : mrfawaz...@gmail.com.
Sincerely,
On Tue, Jul 17, 2018 at 05:14:55PM -0700, r...@google.com wrote:
> From: Roman Kiryanov
>
> The driver never mutates this variable - no benefits of
> keeping it mutable.
Then why not just make it a #define? No need to waste the memory of a
variable, right?
thanks,
greg k-h
On Tue, Jul 10, 2018 at 09:44:33AM +1000, Benjamin Herrenschmidt wrote:
> On Sat, 2018-07-07 at 18:48 +0200, Greg Kroah-Hartman wrote:
> > No, kobject_get() should never happen on a 0 refcount object. That
> > being said, the code does allow it, so if things are messed up, it will
> > happen. I t
On 20 July 2018 at 17:43, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 4.17.9 release.
> There are 101 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses
Fixes the following sparse warnings:
arch/x86/mm/tlb.c:38:6: warning: symbol 'clear_asid_other' was not declared.
Should it be static?
Signed-off-by: zhong jiang
---
arch/x86/mm/tlb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/mm/tlb.c b/arch/x86/mm/tlb.c
inde
On Sat, Jul 21, 2018 at 09:02:15AM +0200, Greg KH wrote:
> On Mon, Jul 16, 2018 at 08:04:53PM +0100, John Whitmore wrote:
> > Rename the struct TS_COMMON_INFO member variable TClasProc to
> > t_clas_proc. This change clears the checkpatch issue with CamelCase variable
> > names. There should be no
From: Levin Du
ROC-RK3399-PC is the first power efficient 4GB DDR4 single board
computer with USB 3.0 and Gigabit Ethernet in a form factor compatible
with the Raspberry Pi. It is based on the Rockchip RK3399 SoC, powered
by the Type-C port.
The devicetree currently supports peripherals of:
- E
Fixes the following sparse warnings:
arch/x86/kernel/pci-iommu_table.c:63:37: warning: Using plain integer as NULL
pointer
Signed-off-by: zhong jiang
---
arch/x86/kernel/pci-iommu_table.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kernel/pci-iommu_table.c
b/a
On 20 July 2018 at 17:43, Greg Kroah-Hartman wrote:
> This is the start of the stable review cycle for the 4.14.57 release.
> There are 92 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
> Responses
Hi,
OK, I'll handle this.
The reason why this error is that kprobe event tests probe ftrace itself for
test.
On Sat, 21 Jul 2018 10:41:13 +0800
kernel test robot wrote:
>
> FYI, we noticed the following commit (built with gcc-7):
>
> commit: ecadccb31b8f1516dd045cc64fc7bc7a2d72947f ("[PATCH
On Fri, Jul 20, 2018 at 12:31:07PM +, Marcel Ziswiler wrote:
> On Fri, 2018-07-20 at 13:16 +0100, Mark Brown wrote:
> > > ac97->sync_gpio = of_get_named_gpio(pdev->dev.of_node,
> > > "nvidia,codec-sync-
> > > gpio", 0);
> > > if (!gpio_is_valid(ac97->s
On Sat, 2018-07-21 at 10:56 +0100, Mark Brown wrote:
> On Fri, Jul 20, 2018 at 12:31:07PM +, Marcel Ziswiler wrote:
> > On Fri, 2018-07-20 at 13:16 +0100, Mark Brown wrote:
> > > > ac97->sync_gpio = of_get_named_gpio(pdev->dev.of_node,
> > > >
BUSINESS PARTNERSHIP.
Hello, my name is Alhaji Mustapha Amidu from Accra Ghana. I am
interested to invest $4.7 Million Dollars in your country and i will
need your assistance and co-operation to actualize it. If you are
capable to handle the money and invest it in a profitable business
that will be
As part of the work to support various other Ingenic JZ47xx SoC versions,
which don't feature the same number of DMA channels per core, we now
deduce the number of DMA channels available from the devicetree
compatible string.
Signed-off-by: Paul Cercueil
Tested-by: Mathieu Malaterre
---
drivers
The driver is now compatible with four SoCs: JZ4780, JZ4770, JZ4725B and
JZ4740.
Besides, it now expects the devicetree to supply a second memory
resource. This resource is mandatory on the newly supported SoCs.
For the JZ4780, new devicetree code must also provide it, although the
driver is still
The driver calls clk_get() with the clock name set to NULL, which means
that the driver could only work when probed from devicetree. From now
on, we explicitly require the driver to be probed from devicetree.
Signed-off-by: Paul Cercueil
Tested-by: Mathieu Malaterre
---
drivers/dma/dma-jz4780.c
Hi,
This is the version 3 of my jz4780-dma driver update patchset.
Apologies to the DMA people, the v2 of this patchset did not make it to
their mailing-list; see the bottom of this email for a description of
what happened in v2.
Changelog from v2 to v3:
- Modified the devicetree bindings to co
With the fast DMA bit set, the DMA will transfer twice as much data
per clock period to the AIC, so there is little point not to set it.
Signed-off-by: Paul Cercueil
Tested-by: Mathieu Malaterre
Reviewed-by: PrasannaKumar Muralidharan
---
drivers/dma/dma-jz4780.c | 5 +++--
1 file changed, 3 i
The register area of the JZ4780 DMA core can be split into different
sections for different purposes:
* one set of registers is used to perform actions at the DMA core level,
that will generally affect all channels;
* one set of registers per DMA channel, to perform actions at the DMA
channel lev
The JZ4740 SoC has a single DMA core starring six DMA channels.
Signed-off-by: Paul Cercueil
Tested-by: Mathieu Malaterre
Reviewed-by: PrasannaKumar Muralidharan
---
drivers/dma/dma-jz4780.c | 3 +++
1 file changed, 3 insertions(+)
v2: The documentation update is now in patch 01/17
v3: The
The JZ4770 SoC has two DMA cores, each one featuring six DMA channels.
The major change is that each channel's clock can be enabled or disabled
through register writes.
Signed-off-by: Paul Cercueil
Tested-by: Mathieu Malaterre
---
drivers/dma/dma-jz4780.c | 46 ++
From: Daniel Silsby
Simple cleanup, no changes to actual logic here.
Signed-off-by: Daniel Silsby
Tested-by: Mathieu Malaterre
---
drivers/dma/dma-jz4780.c | 15 +--
1 file changed, 5 insertions(+), 10 deletions(-)
v2: No change
v3: No change
diff --git a/drivers/dma/dma-jz47
Add the devicetree nodes for the DMA core of the JZ4740 SoC, disabled
by default, as currently there are no clients for the DMA driver
(until the MMC driver and/or others get a devicetree node).
Signed-off-by: Paul Cercueil
Tested-by: Mathieu Malaterre
---
arch/mips/boot/dts/ingenic/jz4740.dtsi
Add the two devicetree nodes for the two DMA cores of the JZ4770 SoC,
disabled by default, as currently there are no clients for the DMA
driver (until the MMC driver and/or others get a devicetree node).
Signed-off-by: Paul Cercueil
Tested-by: Mathieu Malaterre
---
arch/mips/boot/dts/ingenic/jz
From: Daniel Silsby
This is the standard method provided by dmaengine header.
Signed-off-by: Daniel Silsby
Tested-by: Mathieu Malaterre
---
drivers/dma/dma-jz4780.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
v2: No change
v3: No change
diff --git a/drivers/dma/dma-jz4
The driver now accepts two memory resources, the first one for the
channel-specific registers, the second one for the controller-specific
registers.
Note that older devicetrees, without this commit, will still work with
the jz4780-dma driver.
Signed-off-by: Paul Cercueil
Tested-by: Mathieu Malat
From: Daniel Silsby
Normally, we wouldn't set the channel transfer count register directly
when using descriptor-driven transfers. However, there is no harm in
doing so, and it allows jz4780_dma_desc_residue() to report the correct
residue of an ongoing transfer, no matter when it is called.
Sig
From: Daniel Silsby
Func jz4780_dma_desc_residue() expects the index to the next hw
descriptor as its last parameter. Caller func jz4780_dma_tx_status(),
however, applied modulus before passing it. When the current hw
descriptor was last in the list, the index passed became zero.
The resulting e
From: Daniel Silsby
The 'dtc' word in jz DMA descriptors contains two fields: The
lowest 24 bits are the transfer count, and upper 8 bits are the DOA
offset to next descriptor. The upper 8 bits are now correctly masked
off when computing residue in jz4780_dma_desc_residue(). Note that
reads of th
The JZ4725B has one DMA core starring six DMA channels.
As for the JZ4770, each DMA channel's clock can be enabled with
a register write, the difference here being that once started, it
is not possible to turn it off.
Signed-off-by: Paul Cercueil
Tested-by: Mathieu Malaterre
Reviewed-by: Prasann
The only information we use in the 8-word version of the hardware DMA
descriptor that is not present in the 4-word version is the transfer
type, aka. the ID of the source or recipient device.
Since the transfer type will never change for a DMA channel in use,
we can just set it once for all in the
If we make this driver depend on MACH_JZ4780, that means it can be
enabled only if we're building a kernel specially crafted for a
JZ4780-based board, while most GNU/Linux distributions will want one
generic MIPS kernel that works on multiple boards.
Signed-off-by: Paul Cercueil
---
drivers/dma/
On Saturday, 21 July 2018 12:56:15 MSK Mark Brown wrote:
> On Fri, Jul 20, 2018 at 12:31:07PM +, Marcel Ziswiler wrote:
> > On Fri, 2018-07-20 at 13:16 +0100, Mark Brown wrote:
> > > > ac97->sync_gpio = of_get_named_gpio(pdev->dev.of_node,
> > > >
> > > >
Re-sending due to email address typo.
SW2 and SW4 use a shared table to provide voltage to the cpu core and
devices on Tegra hardware.
Added this table to the cpcap regulator driver as the first step to
supporting this device on Tegra.
Signed-off-by: Peter Geis
---
drivers/regulator/cpcap-regu
On 2018/07/20 23:04, David Laight wrote:
> From: Tetsuo Handa
>> Sent: 20 July 2018 14:27
>>
>> On 2018/07/19 22:46, Peter Zijlstra wrote:
>>> On Thu, Jul 19, 2018 at 10:37:23PM +0900, Tetsuo Handa wrote:
This patch can be applied before proposing abovementioned changes.
Since there are m
wait_for_completion_timeout returns unsigned long not int so a variable of
proper type is introduced. Further the check for <= 0 is ambiguous and
should be == 0 here indicating timeout.
Signed-off-by: Nicholas Mc Guire
Fixes: 7b3ad5abf027 ("staging: Import the BCM2835 MMAL-based V4L2 camera
driv
On Sat, 2018-07-21 at 14:17 +0300, Dmitry Osipenko wrote:
> On Saturday, 21 July 2018 12:56:15 MSK Mark Brown wrote:
> > On Fri, Jul 20, 2018 at 12:31:07PM +, Marcel Ziswiler wrote:
> > > On Fri, 2018-07-20 at 13:16 +0100, Mark Brown wrote:
> > > > > ac97->sync_gpio = of_get_named_gpio(pd
Linus,
Please pull the latest core-urgent-for-linus git tree from:
git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git
core-urgent-for-linus
# HEAD: 092b31aa2048cf7561a39697974adcd147fbb27b x86/asm/memcpy_mcsafe: Fix
copy_to_user_mcsafe() exception handling
This is mostly the copy
On Saturday, 21 July 2018 14:55:21 MSK Marcel Ziswiler wrote:
> On Sat, 2018-07-21 at 14:17 +0300, Dmitry Osipenko wrote:
>
> > On Saturday, 21 July 2018 12:56:15 MSK Mark Brown wrote:
> >
> > > On Fri, Jul 20, 2018 at 12:31:07PM +, Marcel Ziswiler wrote:
> > >
> > > > On Fri, 2018-07-20 at
On Saturday, 21 July 2018 15:03:57 MSK Dmitry Osipenko wrote:
> On Saturday, 21 July 2018 14:55:21 MSK Marcel Ziswiler wrote:
> > On Sat, 2018-07-21 at 14:17 +0300, Dmitry Osipenko wrote:
> > > On Saturday, 21 July 2018 12:56:15 MSK Mark Brown wrote:
> > > > On Fri, Jul 20, 2018 at 12:31:07PM +
Removed a commented out case statement
Signed-off-by: Mark Railton
---
drivers/staging/pi433/rf69.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c
index 14826fb505dd..b2d69af6d3fe 100644
--- a/drivers/staging/pi433/rf69.c
+++ b/d
On Sat, Jul 21, 2018 at 08:53:21AM +0200, Greg KH wrote:
> On Thu, Jul 19, 2018 at 10:43:18PM +0100, Mark Railton wrote:
> > Fixed a coding style issue
> >
> > Signed-off-by: Mark Railton
> > ---
> > drivers/staging/pi433/rf69.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
>
Linus,
Please pull the latest sched-urgent-for-linus git tree from:
git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git
sched-urgent-for-linus
# HEAD: e117cb52bdb4d376b711bee34af6434c9e314b3b sched/deadline: Fix
switched_from_dl() warning
Two fixes: a stop-machine preemption fix a
This patch series disables the internal pull-up/down resistors
for IRQ lines which are pulled up externally. Without these patches the
associated IRQs never fire if the bootloader hasn't configured the pins
correctly.
Simon Shields (5):
ARM: dts: exynos: add max77693 pinctrl config for midas
A
This pin is externally pulled up, so we should disable the SoC's
pull down resistor in order for the interrupt to function properly.
Signed-off-by: Simon Shields
---
arch/arm/boot/dts/exynos4412-midas.dtsi | 7 +++
1 file changed, 7 insertions(+)
diff --git a/arch/arm/boot/dts/exynos4412-mi
This pins are externally pulled up, and so we should explicitly
configure them to disable the SoC-internal pull-downs. Previously
we relied on the bootloader doing this in order to allow the buttons
to function properly.
Signed-off-by: Simon Shields
---
arch/arm/boot/dts/exynos4412-midas.dtsi |
This pin is externally pulled up, so we need to disable the
SoC's internal pull-down.
Signed-off-by: Simon Shields
---
arch/arm/boot/dts/exynos4412-midas.dtsi | 7 +++
1 file changed, 7 insertions(+)
diff --git a/arch/arm/boot/dts/exynos4412-midas.dtsi
b/arch/arm/boot/dts/exynos4412-midas.
Linus,
Please pull the latest x86-pti-urgent-for-linus git tree from:
git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git
x86-pti-urgent-for-linus
# HEAD: 6f6060a5c9cc76fdbc22748264e6aa3779ec2427 x86/apm: Don't access
__preempt_count with zeroed fs
An APM fix, and a BTS hardware-t
Currently, we assume that the bootloader has correctly configured
the interrupt pin for max77693. This might not actually be the case -
so it's better to configure it explicitly.
Signed-off-by: Simon Shields
---
arch/arm/boot/dts/exynos4412-midas.dtsi | 7 +++
1 file changed, 7 insertions(+)
This pin is externally pulled up, so we need to disable the SoC's
internal pull down resistor to allow it to function properly.
Signed-off-by: Simon Shields
---
arch/arm/boot/dts/exynos4412-midas.dtsi | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/exy
Linus,
Please pull the latest x86-urgent-for-linus git tree from:
git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git
x86-urgent-for-linus
# HEAD: fbdb328c6bae0a7c78d75734a738b66b86dffc96 x86/MCE: Remove min
interval polling limitation
A single fix for a MCE-polling regression, wh
From: Todd Poynor
Various fixups arising from the chromium review of the gasket and apex
drivers.
Todd Poynor (14):
staging: gasket: fix check_and_invoke_callback log param
staging: gasket: remove duplicate call to retrieve device callback
staging: gasket: gasket_handle_ioctl fix ioctl exi
From: Todd Poynor
gasket_mmap use PAGE_MASK, instead of performing math on PAGE_SIZE, for
simplicity and clarity.
Reported-by: Guenter Roeck
Signed-off-by: Simon Que
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/gasket_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
dif
From: Todd Poynor
gasket_config_coherent_allocator() on error return the error to caller
without copying a possibly-update DMA address back to userspace.
Reported-by: Dmitry Torokhov
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/gasket_ioctl.c | 4 +++-
1 file changed, 3 insertions(+)
From: Todd Poynor
Debugging information is improperly logged at non-debug log level in a
number of places, and some logs regarding error conditions may be
generated too frequently, such that these could cause performance
problems and/or obscure other logs. Convert these to debug log level.
Sign
From: Todd Poynor
The message should be passed the callback function pointer, not
the pointer to the gasket device.
Signed-off-by: Zhongze Hu
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/gasket_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging
From: Todd Poynor
Convert from int to bool return type for gasket page table functions
that return values used as booleans.
Reported-by: Guenter Roeck
Signed-off-by: Simon Que
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/gasket_page_table.c | 58 +++---
drivers/stagi
From: Todd Poynor
The gasket and apex drivers are also to be used on ARM64 architectures.
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/gasket/Kconfig b/drivers/staging/gasket/Kconfig
index c836
From: Todd Poynor
Add __user annotation to ioctl pointer argument, for sparse checking.
Reported-by: Dmitry Torokhov
Signed-off-by: Zhongze Hu
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/apex_driver.c | 17 ++---
1 file changed, 10 insertions(+), 7 deletions(-)
diff --
From: Todd Poynor
It is not an error for a device to not have a reset callback registered.
Signed-off-by: Simon Que
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/gasket_core.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/gasket/gasket_core
From: Todd Poynor
Add __user annotation to gasket_core top-level ioctl handling pointer
arguments, for sparse checking.
Reported-by: Dmitry Torokhov
Signed-off-by: Zhongze Hu
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/gasket_core.c | 6 --
drivers/staging/gasket/gasket_core.h
From: Todd Poynor
Add __user annotation to gasket common ioctl pointer arguments for
sparse checking.
Reported-by: Dmitry Torokhov
Signed-off-by: Zhongze Hu
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/gasket_ioctl.c | 102 ++
1 file changed, 55 insertions(+)
From: Todd Poynor
Add __user annotation to gasket core common ioctl pointer arguments for
sparse checking.
Reported-by: Dmitry Torokhov
Signed-off-by: Zhongze Hu
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/gasket_ioctl.c | 8 +---
drivers/staging/gasket/gasket_ioctl.h | 4 +++-
From: Todd Poynor
Always allow root to open device for writing.
Drop special-casing of ioctl permissions for root vs. owner.
Convert to bool types as appropriate.
Reported-by: Dmitry Torokhov
Signed-off-by: Zhongze Hu
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/apex_driver.c | 1
From: Todd Poynor
Use consistent kernel-style multi-line comment syntax.
Reported-by: Guenter Roeck
Signed-off-by: Simon Que
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/gasket_core.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/gasket/gasket
From: Todd Poynor
Debugging information is improperly logged at non-debug log level in a
number of places, and some logs regarding error conditions may be
generated too frequently, such that these could cause performance
problems and/or obscure other logs. Convert these to debug log level.
Sign
From: Todd Poynor
Some error logs in page table handling code could only be hit in
cases of programming errors not expected in the current code base, and
aren't likely to be useful on their own. Remove these.
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/gasket_page_table.c | 23 +
From: Todd Poynor
Remove unneeded parentheses around subexpressions.
Reported-by: Guenter Roeck
Signed-off-by: Simon Que
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/gasket_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/gasket/gasket_core.
From: Todd Poynor
Debugging information is improperly logged at non-debug log level in a
number of places, and some logs regarding error conditions may be
generated too frequently, such that these could cause performance
problems and/or obscure other logs. Convert these to debug log level.
Sign
From: Todd Poynor
gasket_alloc_coherent_memory() extra parentheses in statement.
Reported-by: Guenter Roeck
Signed-off-by: Simon Que
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/gasket_page_table.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/g
From: Todd Poynor
Use kernel-style multi-line comment syntax.
Reported-by: Guenter Roeck
Signed-off-by: Simon Que
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/apex.h | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/gasket/apex.h b/drivers/st
From: Todd Poynor
Remove unneeded checks for NULL pointers in struct file pointers passed
from the VFS layer or the private_data that must have been properly set
at file open time.
Reported-by: Guenter Roeck
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/gasket_core.c | 15
From: Todd Poynor
Collapse together two checks and return immediately, avoid conditional
indentation for most of function code.
Reported-by: Guenter Roeck
Signed-off-by: Simon Que
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/apex_driver.c | 43 +---
1 file ch
From: Todd Poynor
class_create() never returns NULL, and this driver should never return
PTR_ERR(NULL) anyway.
Reported-by: Dmitry Torokhov
Signed-off-by: Zhongze Hu
Signed-off-by: Todd Poynor
Reviewed-by: Dmitry Torokhov
---
drivers/staging/gasket/gasket_core.c | 2 +-
1 file changed, 1 in
From: Todd Poynor
Else after return is unnecessary and may cause static code checkers to
complain.
Reported-by: Guenter Roeck
Signed-off-by: Simon Que
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/gasket_page_table.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --gi
From: Todd Poynor
Debugging information is improperly logged at non-debug log level in a
number of places, and some logs regarding error conditions may be
generated too frequently, such that these could cause performance
problems and/or obscure other logs. Convert these to debug log level.
Sign
From: Todd Poynor
Apex sysfs show function return -ENODEV if the attribute is not present,
rather than silently failing from the standpoint of the userspace
accessor.
Reported-by: Guenter Roeck
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/apex_driver.c | 4 ++--
1 file changed, 2 ins
From: Todd Poynor
When offset to be mapped matches both a BAR region and a coherent mapped
region return an error as intended, not the BAR index.
Signed-off-by: Simon Que
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/gasket_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
From: Todd Poynor
The pci_dev field of a struct gasket_dev can never be NULL, there's no
need to check for this in gasket_get_device().
Reported-by: Guenter Roeck
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/gasket_core.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff
From: Todd Poynor
Debugging information is improperly logged at non-debug log level in a
number of places, and some logs regarding error conditions may be
generated too frequently, such that these could cause performance
problems and/or obscure other logs. Convert these to debug log level.
Sign
From: Todd Poynor
Remove extraneous statement in gasket_config_coherent_allocator()
Reported-by: Dmitry Torokhov
Signed-off-by: Zhongze Hu
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/gasket_ioctl.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/stagi
From: Todd Poynor
Page alignment error log should print the offending value as an unsigned
long, not as a kernel pointer.
Reported-by: Guenter Roeck
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/gasket_core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/driv
From: Todd Poynor
Remove unnecessary variable, pass constant param instead.
Reported-by: Dmitry Torokhov
Signed-off-by: Zhongze Hu
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/gasket_core.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/staging/gaske
From: Todd Poynor
gasket_enable_dev code for enabling a gasket device with no physical PCI
device registered shouldn't be necessary.
Reported-by: Greg Kroah-Hartman
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/gasket_core.c | 12 +---
1 file changed, 1 insertion(+), 11 deleti
From: Todd Poynor
Pass the return value from the device ioctl permissions callback to the
tracepoint when the callback returns an error.
Reported-by: Dmitry Torokhov
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/gasket_ioctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
dif
From: Todd Poynor
gasket_handle_ioctl() calls gasket_get_ioctl_permissions_cb() twice;
simplify the code and avoid duplicated work by fetching the callback
pointer only once.
Reported-by: Dmitry Torokhov
Signed-off-by: Todd Poynor
---
drivers/staging/gasket/gasket_ioctl.c | 7 ---
1 file
On Sat, Jul 21, 2018 at 05:56:39AM -0700, Todd Poynor wrote:
> From: Todd Poynor
>
> Various fixups arising from the chromium review of the gasket and apex
> drivers.
Didn't I just apply this whole series? Why resend it?
confused,
greg k-h
wait_for_completion_timeout returns unsigned long not int so a variable of
proper type is introduced. Further the check for <= 0 is ambiguous and should
be == 0 here indicating timeout which is the only error case so no additional
check needed here.
Signed-off-by: Nicholas Mc Guire
Fixes: 7b3ad5a
On Sat, Jul 21, 2018 at 6:17 AM Greg Kroah-Hartman
wrote:
>
> On Sat, Jul 21, 2018 at 05:56:39AM -0700, Todd Poynor wrote:
> > From: Todd Poynor
> >
> > Various fixups arising from the chromium review of the gasket and apex
> > drivers.
>
> Didn't I just apply this whole series? Why resend it?
1 - 100 of 278 matches
Mail list logo
