[patch v3 -mm 6/6] mm, memcg: disregard mempolicies for cgroup-aware oom killer

2018-07-13 Thread David Rientjes
The cgroup-aware oom killer currently considers the set of allowed nodes for the allocation that triggers the oom killer and discounts usage from disallowed nodes when comparing cgroups. If a cgroup has both the cpuset and memory controllers enabled, it may be possible to restrict allocations to a

[patch v3 -mm 1/6] mm, memcg: introduce per-memcg oom policy tunable

2018-07-13 Thread David Rientjes
The cgroup aware oom killer is needlessly enforced for the entire system by a mount option. It's unnecessary to force the system into a single oom policy: either cgroup aware, or the traditional process aware. This patch introduces a memory.oom_policy tunable for all mem cgroups. It is currently

[patch v3 -mm 4/6] mm, memcg: evaluate root and leaf memcgs fairly on oom

2018-07-13 Thread David Rientjes
There are several downsides to the current implementation that compares the root mem cgroup with leaf mem cgroups for the cgroup-aware oom killer. For example, /proc/pid/oom_score_adj is accounted for processes attached to the root mem cgroup but not leaves. This leads to wild inconsistencies tha

[patch v3 -mm 5/6] mm, memcg: separate oom_group from selection criteria

2018-07-13 Thread David Rientjes
With the current implementation of the cgroup-aware oom killer, memory.oom_group defines two behaviors: - consider the footprint of the "group" consisting of the mem cgroup itself and all descendants for comparison with other cgroups, and - when selected as the victim mem cgroup, kill all pr

Re: [PATCH 03/39] x86/entry/32: Load task stack from x86_tss.sp1 in SYSENTER handler

2018-07-13 Thread Andy Lutomirski
On Fri, Jul 13, 2018 at 10:19 AM, Andy Lutomirski wrote: > On Fri, Jul 13, 2018 at 2:48 AM, Joerg Roedel wrote: >> On Thu, Jul 12, 2018 at 01:49:13PM -0700, Andy Lutomirski wrote: >>> > On Jul 11, 2018, at 4:29 AM, Joerg Roedel wrote: >>> >/* Offset from the sysenter stack to tss.sp0 */ >>>

Re: [PATCH 35/39] x86/ldt: Split out sanity check in map_ldt_struct()

2018-07-13 Thread Andy Lutomirski
On Wed, Jul 11, 2018 at 4:29 AM, Joerg Roedel wrote: > From: Joerg Roedel > > This splits out the mapping sanity check and the actual > mapping of the LDT to user-space from the map_ldt_struct() > function in a way so that it is re-usable for PAE paging. > Reviewed-by: Andy Lutomirski

Re: [PATCH 30/39] x86/mm/pti: Clone entry-text again in pti_finalize()

2018-07-13 Thread Andy Lutomirski
On Wed, Jul 11, 2018 at 4:29 AM, Joerg Roedel wrote: > From: Joerg Roedel > > The mapping for entry-text might have changed in the kernel > after it was cloned to the user page-table. Clone again > to update the user page-table to bring the mapping in sync > with the kernel again. Can't we just

Re: [PATCH 28/39] x86/mm/pti: Keep permissions when cloning kernel text in pti_clone_kernel_text()

2018-07-13 Thread Andy Lutomirski
On Wed, Jul 11, 2018 at 4:29 AM, Joerg Roedel wrote: > From: Joerg Roedel > > Mapping the kernel text area to user-space makes only sense > if it has the same permissions as in the kernel page-table. > If permissions are different this will cause a TLB reload > when using the kernel page-table, w

Re: [PATCH] checkpatch: Require commit text and warn on long commit text lines

2018-07-13 Thread pheragu
On 2018-07-13 14:46, Joe Perches wrote: On Fri, 2018-07-13 at 14:40 -0700, Prakruthi Deepak Heragu wrote: Commit text is almost always necessary to explain why a change is needed. This bit seems sensible, but perhaps it should just count the number of lines after the end of email headers and b

Re: [PATCH 10/39] x86/entry/32: Handle Entry from Kernel-Mode on Entry-Stack

2018-07-13 Thread Andy Lutomirski
On Wed, Jul 11, 2018 at 4:29 AM, Joerg Roedel wrote: > From: Joerg Roedel > > It can happen that we enter the kernel from kernel-mode and > on the entry-stack. The most common way this happens is when > we get an exception while loading the user-space segment > registers on the kernel-to-userspac

Re: [RFC PATCH 10/10] psi: aggregate ongoing stall events when somebody reads pressure

2018-07-13 Thread Suren Baghdasaryan
On Fri, Jul 13, 2018 at 3:49 PM, Johannes Weiner wrote: > On Fri, Jul 13, 2018 at 03:13:07PM -0700, Suren Baghdasaryan wrote: >> On Thu, Jul 12, 2018 at 10:29 AM, Johannes Weiner wrote: >> > might want to know about and react to stall states before they have >> > even concluded (e.g. a prolonged

[PATCH] IB/mlx5: avoid binding a new mpi unit to the same devices repeatedly

2018-07-13 Thread Qing Huang
When a CX5 device is configured in dual-port RoCE mode, after creating many VFs against port 1, creating the same number of VFs against port 2 will flood kernel/syslog with something like "mlx5_*:mlx5_ib_bind_slave_port:4266:(pid 5269): port 2 already affiliated." So basically, when traversing mlx

mmotm 2018-07-13-16-51 uploaded

2018-07-13 Thread akpm
The mm-of-the-moment snapshot 2018-07-13-16-51 has been uploaded to http://www.ozlabs.org/~akpm/mmotm/ mmotm-readme.txt says README for mm-of-the-moment: http://www.ozlabs.org/~akpm/mmotm/ This is a snapshot of my -mm patch queue. Uploaded at random hopefully more than once a week. You wi

Re: [PATCH] checkpatch: Require commit text and warn on long commit text lines

2018-07-13 Thread Joe Perches
On Fri, 2018-07-13 at 16:28 -0700, pher...@codeaurora.org wrote: > On 2018-07-13 14:46, Joe Perches wrote: > > On Fri, 2018-07-13 at 14:40 -0700, Prakruthi Deepak Heragu wrote: > > > Commit text is almost always necessary to explain why a change is > > > needed. > > > > This bit seems sensible, b

Re: [PATCH] get_maintainer.pl: Add optional .get_maintainer.MAINTAINERS override

2018-07-13 Thread Joe Perches
On Fri, 2018-07-13 at 14:51 -0400, Don Zickus wrote: > On Fri, Jul 06, 2018 at 03:14:28PM -0700, Joe Perches wrote: > > On Fri, 2018-07-06 at 15:09 -0700, Joe Perches wrote: > > > On Fri, 2018-07-06 at 17:58 -0400, Don Zickus wrote: > > > > We have an internal use case of multiple MAINTAINER files,

Re: [patch 0/7] x86/kvmclock: Remove memblock dependency and further cleanups

2018-07-13 Thread Pavel Tatashin
On 07/13/2018 06:51 PM, Thomas Gleixner wrote: > On Wed, 11 Jul 2018, Pavel Tatashin wrote: > >>> So this still will have some overhead when kvmclock is not in use, but >>> bringing it down to zero would be a massive trainwreck and even more >>> indirections. >> >> Hi Thomas, >> >> In my opinio

Re: [PATCH v2 4/4] clk: qcom: Add graphics clock controller driver for SDM845

2018-07-13 Thread kbuild test robot
Hi Amit, Thank you for the patch! Yet something to improve: [auto build test ERROR on agross/for-next] [also build test ERROR on v4.18-rc4 next-20180713] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

Re: mmotm 2018-07-13-16-51 uploaded (PSI)

2018-07-13 Thread Randy Dunlap
On 07/13/2018 04:51 PM, a...@linux-foundation.org wrote: > The mm-of-the-moment snapshot 2018-07-13-16-51 has been uploaded to > >http://www.ozlabs.org/~akpm/mmotm/ > > mmotm-readme.txt says > > README for mm-of-the-moment: > > http://www.ozlabs.org/~akpm/mmotm/ > > This is a snapshot of m

[PATCH v9 1/2] regulator: dt-bindings: add QCOM RPMh regulator bindings

2018-07-13 Thread David Collins
Introduce bindings for RPMh regulator devices found on some Qualcomm Technlogies, Inc. SoCs. These devices allow a given processor within the SoC to make PMIC regulator requests which are aggregated within the RPMh hardware block along with requests from other processors in the SoC to determine th

[PATCH v9 2/2] regulator: add QCOM RPMh regulator driver

2018-07-13 Thread David Collins
Add the QCOM RPMh regulator driver to manage PMIC regulators which are controlled via RPMh on some Qualcomm Technologies, Inc. SoCs. RPMh is a hardware block which contains several accelerators which are used to manage various hardware resources that are shared between the processors of the SoC.

[PATCH v9 0/2] regulator: add QCOM RPMh regulator driver

2018-07-13 Thread David Collins
This patch series adds a driver and device tree binding documentation for PMIC regulator control via Resource Power Manager-hardened (RPMh) on some Qualcomm Technologies, Inc. SoCs such as SDM845. RPMh is a hardware block which contains several accelerators which are used to manage various hardwar

Re: [PATCH v2] tools/memory-model: Add extra ordering for locks and remove it for ordinary release/acquire

2018-07-13 Thread Alan Stern
On Fri, 13 Jul 2018, Andrea Parri wrote: > On Fri, Jul 13, 2018 at 10:16:48AM -0700, Linus Torvalds wrote: > > On Fri, Jul 13, 2018 at 2:34 AM Will Deacon wrote: > > > > > > And, since we're stating preferences, I'll reiterate my preference > > > towards: > > > > > > * RCsc unlock/lock >

RE: [PATCH] gpio: mxc: add power management support

2018-07-13 Thread Anson Huang
Hi, Fabio Anson Huang Best Regards! > -Original Message- > From: Fabio Estevam [mailto:feste...@gmail.com] > Sent: Saturday, July 14, 2018 2:34 AM > To: Anson Huang > Cc: Linus Walleij ; open list:GPIO SUBSYSTEM > ; linux-kernel ; > dl-linux-imx > Subject: Re: [PATCH] gpio: mxc: add po

[PATCH V2] ARM: dts: imx6sl-evk: add missing GPIO iomux setting

2018-07-13 Thread Anson Huang
On i.MX6SL EVK board, the MX6SL_PAD_KEY_ROW5 pin is used as lcd 3v3 regulator control pin, need to make sure MX6SL_PAD_KEY_ROW5 is muxed as GPIO function for controlling lcd 3v3 regulator. Signed-off-by: Anson Huang --- change since V1: using a separate pin group for lcd regulator instead

Re: Kernel 4.17.4 lockup

2018-07-13 Thread Andy Lutomirski
I'm not at all convinced that this is the problem, but the series here will give a better diagnostic if the issue really is an IRQ stack overflow: https://git.kernel.org/pub/scm/linux/kernel/git/luto/linux.git/log/?h=x86/guard_pages (link currently broken. should work soon.)

RE: [RFC] x86, tsc: Add kcmdline args for skipping tsc calibration sequences

2018-07-13 Thread Brown, Len
We disabled CPUID-based TSC calibration on SKX in December for several reasons. If you still have it enabled, you need this patch: commit b511203093489eb1829cb4de86e8214752205ac6 x86/tsc: Fix erroneous TSC rate on Skylake Xeon If you are referring to another platform that has CPUID-TSC calibr

Re: [PATCH v4 1/2] leds: core: Introduce generic pattern interface

2018-07-13 Thread Baolin Wang
Hi Jacek, On 14 July 2018 at 04:07, Jacek Anaszewski wrote: > Hi Baolin, > > Thank you for the update. > > > On 07/13/2018 08:21 AM, Baolin Wang wrote: >> >> From: Bjorn Andersson >> >> Some LED controllers have support for autonomously controlling >> brightness over time, according to some prep

Re: mmotm 2018-07-13-16-51 uploaded (PSI)

2018-07-13 Thread Stephen Rothwell
Hi all, On Fri, 13 Jul 2018 18:41:40 -0700 Randy Dunlap wrote: > > On 07/13/2018 04:51 PM, a...@linux-foundation.org wrote: > > The mm-of-the-moment snapshot 2018-07-13-16-51 has been uploaded to > > > >http://www.ozlabs.org/~akpm/mmotm/ > > > > mmotm-readme.txt says > > > > README for mm-

Re: [PATCH v2] tools/memory-model: Add extra ordering for locks and remove it for ordinary release/acquire

2018-07-13 Thread Linus Torvalds
On Fri, Jul 13, 2018 at 6:51 PM Alan Stern wrote: > > The point being that the scenarios under discussion in this thread all > fall most definitely into the "Non-standard usage; you'd better know > exactly what you're doing" category. Well, yes and no. The thing is, people expected unlock+lock t

Re: [PATCH v2 4/4] clk: qcom: Add graphics clock controller driver for SDM845

2018-07-13 Thread kbuild test robot
Hi Amit, Thank you for the patch! Yet something to improve: [auto build test ERROR on agross/for-next] [also build test ERROR on v4.18-rc4 next-20180713] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

Re: [PATCH 1/6] swap: Add comments to lock_cluster_or_swap_info()

2018-07-13 Thread Huang, Ying
Dave Hansen writes: >> +/* >> + * At most times, fine grained cluster lock is sufficient to protect > > Can we call out those times, please? To protect si->swap_map[], if HDD, si->lock is used, otherwise cluster lock is used. "at most times" is ambiguous here, I will fix it. >> + * the operati

Re: [PATCH] mmc: mxcmmc: Fix missing parentheses and brace

2018-07-13 Thread Randy Dunlap
On 07/12/2018 12:59 PM, Kees Cook wrote: > Looks like the adjusted syntax wasn't fully build tested. This fixes > failures with powerpc builds: > > drivers/mmc/host/mxcmmc.c: In function ‘mxcmci_swap_buffers’: > drivers/mmc/host/mxcmmc.c:296:51: error: expected ‘)’ before ‘;’ token >void *buf

Re: [PATCH] kconfig: remove EXPERT from CHECKPOINT_RESTORE

2018-07-13 Thread Kees Cook
On Fri, Jul 13, 2018 at 1:55 PM, Andrew Morton wrote: > On Thu, 12 Jul 2018 11:33:33 -0500 ebied...@xmission.com (Eric W. Biederman) > wrote: >> What is the value of disabling this functionality ever? >> >> Is there any reason why we don't just delete CONFIG_CHECKPOINT_RESTORE >> entirely? > > Fo

Re: [PATCH 30/39] x86/mm/pti: Clone entry-text again in pti_finalize()

2018-07-13 Thread Joerg Roedel
On Fri, Jul 13, 2018 at 04:21:45PM -0700, Andy Lutomirski wrote: > On Wed, Jul 11, 2018 at 4:29 AM, Joerg Roedel wrote: > > From: Joerg Roedel > > > > The mapping for entry-text might have changed in the kernel > > after it was cloned to the user page-table. Clone again > > to update the user pag

Re: [PATCH 38/39] x86/mm/pti: Add Warning when booting on a PCID capable CPU

2018-07-13 Thread Joerg Roedel
On Fri, Jul 13, 2018 at 11:59:44AM -0700, Andy Lutomirski wrote: > On Wed, Jul 11, 2018 at 4:29 AM, Joerg Roedel wrote: > > From: Joerg Roedel > > > > Warn the user in case the performance can be significantly > > improved by switching to a 64-bit kernel. > > ... > > > +#ifdef CONFIG_X86_32 > >

Re: [PATCH 39/39] x86/entry/32: Add debug code to check entry/exit cr3

2018-07-13 Thread Joerg Roedel
On Fri, Jul 13, 2018 at 10:28:50AM -0700, Andy Lutomirski wrote: > On Wed, Jul 11, 2018 at 4:29 AM, Joerg Roedel wrote: > > From: Joerg Roedel > > > > Add a config option that enabled code to check that we enter > > and leave the kernel with the correct cr3. This is needed > > because we have no

Re: [PATCH 10/39] x86/entry/32: Handle Entry from Kernel-Mode on Entry-Stack

2018-07-13 Thread Joerg Roedel
On Fri, Jul 13, 2018 at 04:31:02PM -0700, Andy Lutomirski wrote: > What you're really doing is keeping it available for an extra flag. > Please update the comment as such. But see below. Thanks, will do. > > +.macro PARANOID_EXIT_TO_KERNEL_MODE > > + > > + /* > > +* Test if we ente

[PATCH 16/18] staging: gasket: gasket core error handling fixups

2018-07-13 Thread Todd Poynor
From: Todd Poynor Minor fixups to error codes and error handling in gasket core. No device reset callback registered is not an error condition. Signed-off-by: Simon Que Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 13 + 1 file changed, 5 insertions(+), 8

[PATCH 13/18] staging: gasket: gasket_enable_dev fixups

2018-07-13 Thread Todd Poynor
From: Todd Poynor Remove unnecessary variable. Bail out if no physical device. Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 19 ++- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/drivers/staging/gasket/gasket_core.c b/drivers/staging/g

[PATCH 18/18] staging: gasket: various cleanups

2018-07-13 Thread Todd Poynor
From: Todd Poynor Cleanups to error codes, code style, error conditions, etc. Reported-by: Guenter Roeck Signed-off-by: Simon Que Signed-off-by: Todd Poynor --- drivers/staging/gasket/apex.h | 7 ++- drivers/staging/gasket/apex_driver.c | 50 - drivers/sta

[PATCH 11/18] staging: gasket: always allow root open for write

2018-07-13 Thread Todd Poynor
From: Todd Poynor Always allow root to open device for writing. Drop special-casing of ioctl permissions for root vs. owner. Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/apex_driver.c | 9 +++-- drivers/staging/gasket/gas

[PATCH 07/18] staging: gasket: convert gasket_mmap_has_permissions to bool return

2018-07-13 Thread Todd Poynor
From: Todd Poynor gasket_mmap_has_permissions() should return a boolean value. Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/gasket/gasket_core.c b

[PATCH 09/18] staging: gasket: bail out of reset sequence on device callback error

2018-07-13 Thread Todd Poynor
From: Todd Poynor If device reset callback returns an error, error out at the gasket level. Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/driver

[PATCH 15/18] staging: gasket: remove unnecessary code in coherent allocator

2018-07-13 Thread Todd Poynor
From: Todd Poynor Remove extraneous statement in gasket_config_coherent_allocator() Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_ioctl.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/stagi

[PATCH 17/18] staging: gasket: don't release coherent mappings

2018-07-13 Thread Todd Poynor
From: Todd Poynor coherent address mappings aren't backed by a struct page, don't need to be released, and don't count as an active page in the page table bookkeeping. Signed-off-by: Simon Que Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_page_table.c | 2 +- 1 file changed, 1

[PATCH 12/18] staging: gasket: annotate ioctl arg with __user

2018-07-13 Thread Todd Poynor
From: Todd Poynor For sparse checking. Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/apex_driver.c | 12 ++--- drivers/staging/gasket/gasket_core.c | 6 ++- drivers/staging/gasket/gasket_core.h | 4 +- drivers/staging/gasket

[PATCH 00/18] staging: gasket: sundry fixes and fixups

2018-07-13 Thread Todd Poynor
From: Todd Poynor Various fixes mainly from the chromium review of the gasket and apex drivers. More to come. Various (18): staging: gasket: remove X86 Kconfig restriction MAINTAINERS: Add maintainer for drivers/staging/gasket staging: gasket: typo and whitespace cleanups staging: gaske

[PATCH 01/18] staging: gasket: remove X86 Kconfig restriction

2018-07-13 Thread Todd Poynor
From: Todd Poynor The gasket and apex drivers are to be used on other architectures besides X86. Signed-off-by: Todd Poynor --- drivers/staging/gasket/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gasket/Kconfig b/drivers/staging/gasket/Kconfig ind

[PATCH 06/18] staging: gasket: fix deadlock in pci driver unregister path

2018-07-13 Thread Todd Poynor
From: Todd Poynor g_mutex held across pci_unregister_driver() call, also held in gasket_pci_remove(), which deadlocks. Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 7 ++- 1 file changed, 2 insertions(+), 5 de

[PATCH 04/18] staging: gasket: device registration error and unregister fixups

2018-07-13 Thread Todd Poynor
From: Todd Poynor Remove device registration on class creation fail. Hold mutex around device removal updates for proper ordering of updates. Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletio

[PATCH 02/18] MAINTAINERS: Add maintainer for drivers/staging/gasket

2018-07-13 Thread Todd Poynor
From: Todd Poynor Todd Poynor will be a maintainer of the Gasket and Apex drivers. Signed-off-by: Todd Poynor --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 562ee1e1cfd6..8f44e7bed49e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -5968,6 +5

[PATCH 03/18] staging: gasket: typo and whitespace cleanups

2018-07-13 Thread Todd Poynor
From: Todd Poynor Trivial typo and whitespace fixes. Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/apex_driver.c | 2 +- drivers/staging/gasket/gasket_core.h | 2 +- drivers/staging/gasket/gasket_page_table.c | 2 +- 3 files changed, 3 insertions(

[PATCH 14/18] staging: gasket: fix class create bug handling

2018-07-13 Thread Todd Poynor
From: Todd Poynor class_create() never returns NULL, and this driver should never return PTR_ERR(NULL) anyway. Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) dif

[PATCH 10/18] staging: gasket: gasket_open use container_of()

2018-07-13 Thread Todd Poynor
From: Todd Poynor Use container_of(), drop unnecessary NULL check. Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/staging/gasket/gask

[PATCH 05/18] staging: gasket: sysfs mapping creation fixups

2018-07-13 Thread Todd Poynor
From: Todd Poynor Return EBUSY for attempt to create a mapping already in use. Remove stale pointers on error allocating attr array. Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_sysfs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff -

[PATCH 08/18] staging: gasket: gasket_wait_with_reschedule fixups

2018-07-13 Thread Todd Poynor
From: Todd Poynor Return -ETIMEDOUT on timeouts. Don't need 64-bit sized retry count. Use msleep(). Return immediately when condition hit. Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/apex_driver.c | 8 drivers/stag

Re: [PATCH] kconfig: remove EXPERT from CHECKPOINT_RESTORE

2018-07-13 Thread Josh Triplett
On Fri, Jul 13, 2018 at 09:44:15PM -0700, Kees Cook wrote: > On Fri, Jul 13, 2018 at 1:55 PM, Andrew Morton > wrote: > > On Thu, 12 Jul 2018 11:33:33 -0500 ebied...@xmission.com (Eric W. > > Biederman) wrote: > >> What is the value of disabling this functionality ever? > >> > >> Is there any reas

[PATCH 02/18 v2] MAINTAINERS: Add maintainer for drivers/staging/gasket

2018-07-13 Thread Todd Poynor
From: Todd Poynor Todd Poynor will be a maintainer of the Gasket and Apex drivers. Signed-off-by: Todd Poynor --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 562ee1e1cfd6..8f44e7bed49e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -5968,7 +5

[PATCH] lib/rhashtable: consider param->min_size when setting initial table size

2018-07-13 Thread Davidlohr Bueso
rhashtable_init() currently does not take into account the user-passed min_size parameter unless param->nelem_hint is set as well. As such, the default size (number of buckets) will always be HASH_DEFAULT_SIZE even if the smallest allowed size is larger than that. Remediate this by unconditionally

Re: [PATCH 10/39] x86/entry/32: Handle Entry from Kernel-Mode on Entry-Stack

2018-07-13 Thread Andy Lutomirski
> On Jul 13, 2018, at 10:21 PM, Joerg Roedel wrote: > >> On Fri, Jul 13, 2018 at 04:31:02PM -0700, Andy Lutomirski wrote: >> What you're really doing is keeping it available for an extra flag. >> Please update the comment as such. But see below. > > Thanks, will do. > >>> +.macro PARANOID_E

Re: [PATCH 02/18] MAINTAINERS: Add maintainer for drivers/staging/gasket

2018-07-13 Thread Greg Kroah-Hartman
On Fri, Jul 13, 2018 at 10:58:00PM -0700, Todd Poynor wrote: > From: Todd Poynor > > Todd Poynor will be a maintainer of the Gasket > and Apex drivers. > > Signed-off-by: Todd Poynor I need an ack, or signed-off-by by the current maintainers that this is ok. And 4 maintainers is a lot, are y

Re: [PATCH v4 1/2] leds: core: Introduce generic pattern interface

2018-07-13 Thread Pavel Machek
> @@ -446,4 +455,14 @@ static inline void > led_classdev_notify_brightness_hw_changed( > struct led_classdev *led_cdev, enum led_brightness brightness) { } > #endif > > +/** > + * struct led_pattern - brigheness value in a pattern "brightness".

Re: [PATCH 02/18 v2] MAINTAINERS: Add maintainer for drivers/staging/gasket

2018-07-13 Thread Greg Kroah-Hartman
On Fri, Jul 13, 2018 at 11:04:07PM -0700, Todd Poynor wrote: > From: Todd Poynor > > Todd Poynor will be a maintainer of the Gasket > and Apex drivers. > > Signed-off-by: Todd Poynor > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) What changed from v1? Always put that below the

Re: [PATCH 18/18] staging: gasket: various cleanups

2018-07-13 Thread Greg Kroah-Hartman
On Fri, Jul 13, 2018 at 10:58:16PM -0700, Todd Poynor wrote: > From: Todd Poynor > > Cleanups to error codes, code style, error conditions, etc. You you need to break this up into "one type of logical change per patch" here for this change, sorry. thanks, greg k-h

Re: [PATCH 03/18] staging: gasket: typo and whitespace cleanups

2018-07-13 Thread Greg Kroah-Hartman
On Fri, Jul 13, 2018 at 10:58:01PM -0700, Todd Poynor wrote: > From: Todd Poynor > > Trivial typo and whitespace fixes. typos are different from whitespace issues. Please break this up. Yeah, it's a pain, sorry, but that's a requirement for kernel patches. It's to make it easier on the reviewe

Re: [PATCH 05/18] staging: gasket: sysfs mapping creation fixups

2018-07-13 Thread Greg Kroah-Hartman
On Fri, Jul 13, 2018 at 10:58:03PM -0700, Todd Poynor wrote: > From: Todd Poynor > > Return EBUSY for attempt to create a mapping already in use. Why? > Remove stale pointers on error allocating attr array. This should be a different patch. thanks, greg k-h

Re: [PATCH 08/18] staging: gasket: gasket_wait_with_reschedule fixups

2018-07-13 Thread Greg Kroah-Hartman
On Fri, Jul 13, 2018 at 10:58:06PM -0700, Todd Poynor wrote: > From: Todd Poynor > > Return -ETIMEDOUT on timeouts. > > Don't need 64-bit sized retry count. > > Use msleep(). > > Return immediately when condition hit. Huge hint, when you have to list the different things you do in a patch, th

Re: [PATCH 12/18] staging: gasket: annotate ioctl arg with __user

2018-07-13 Thread Greg Kroah-Hartman
On Fri, Jul 13, 2018 at 10:58:10PM -0700, Todd Poynor wrote: > From: Todd Poynor > > For sparse checking. > > Reported-by: Dmitry Torokhov > Signed-off-by: Zhongze Hu > Signed-off-by: Todd Poynor > --- Are you sure this patch even applies? What tree did you make it against? I ask because t

Re: [PATCH 06/18] staging: gasket: fix deadlock in pci driver unregister path

2018-07-13 Thread Greg Kroah-Hartman
On Fri, Jul 13, 2018 at 10:58:04PM -0700, Todd Poynor wrote: > From: Todd Poynor > > g_mutex held across pci_unregister_driver() call, also held in > gasket_pci_remove(), which deadlocks. Which reminds me, why in the world do you all wrap pci register/unregister within your new subsystem? That'

Re: [PATCH 13/18] staging: gasket: gasket_enable_dev fixups

2018-07-13 Thread Greg Kroah-Hartman
On Fri, Jul 13, 2018 at 10:58:11PM -0700, Todd Poynor wrote: > From: Todd Poynor > > Remove unnecessary variable. > > Bail out if no physical device. > > Signed-off-by: Todd Poynor > --- > drivers/staging/gasket/gasket_core.c | 19 ++- > 1 file changed, 6 insertions(+), 13 del

<    1   2   3   4   5