Re: [PATCH] kvm: x86: mmu: Add cast to negated bitmasks in update_permission_bitmask()

2018-06-19 Thread Matthias Kaehlcke
On Tue, Jun 19, 2018 at 11:07:47AM -0700, Joe Perches wrote: > On Tue, 2018-06-19 at 19:35 +0200, Paolo Bonzini wrote: > > On 19/06/2018 19:23, Joe Perches wrote: > > > On Tue, 2018-06-19 at 10:08 -0700, Nick Desaulniers wrote: > > > > On Tue, Jun 19, 2018 at 8:19 AM Paolo Bonzini > > > > wrote:

Re: [PATCH] kvm: x86: mmu: Add cast to negated bitmasks in update_permission_bitmask()

2018-06-19 Thread Matthias Kaehlcke
On Tue, Jun 19, 2018 at 07:13:41PM +0200, Paolo Bonzini wrote: > On 19/06/2018 19:08, Nick Desaulniers wrote: > >> This one really makes the code uglier though, so I'm not really inclined > >> to applying the patch. > > Note that of the three variables (w, u, x), only u is used later on. > > What a

Re: [RFC PATCH v3 05/10] sched/topology: Reference the Energy Model of CPUs when available

2018-06-19 Thread Peter Zijlstra
On Tue, Jun 19, 2018 at 06:13:17PM +0100, Quentin Perret wrote: > I agree having one list per root_domain should be better. I'll change that > in v4. But I also think the idea of a global static_key is broken then. Static keys are global per definition, there is only a single copy of the code. Yo

[PATCH treewide] headers: separate mod_devicetable.h from platform_device.h

2018-06-19 Thread Randy Dunlap
From: Randy Dunlap At over 4000 #includes, is the 9th most #included header file in the Linux kernel. It does not need , so drop that header and explicitly add to source files that need it. 4146 #include After this patch, there are 225 files that use , for a reduction of around 3900 time

[PATCH v7 5/9] x86/microcode/AMD: Split status from data to skip in verify_and_add_patch()

2018-06-19 Thread Maciej S. Szmigiero
verify_and_add_patch() returned a single "int" value which encoded both this function error status and also a length of microcode container data to skip. Unfortunately, ranges of these two values collide: the length of data to skip can be any value between 1 and UINT_MAX, so, for example, error st

[PATCH v7 1/9] x86/microcode/AMD: Subtract SECTION_HDR_SIZE from file leftover length

2018-06-19 Thread Maciej S. Szmigiero
verify_patch_size() verifies whether the remaining size of the microcode container file is large enough to contain a patch of the indicated size. However, the section header length is not included in this indicated size but it is present in the leftover file length so it should be subtracted from

[PATCH v7 9/9] x86/microcode/AMD: Check the equivalence table size when scanning it

2018-06-19 Thread Maciej S. Szmigiero
Currently, the code scanning the CPU equivalence table read from a microcode container file assumes that it actually contains a terminating zero entry. Let's check also the size of this table to make sure that we don't read past it in case it actually doesn't. Signed-off-by: Maciej S. Szmigiero -

[PATCH v7 3/9] x86/microcode/AMD: Integrate verify_patch_size() into verify_patch()

2018-06-19 Thread Maciej S. Szmigiero
Integrating verify_patch_size() into verify_patch() allows us to check whether the indicated patch size makes sense for its indicated CPU family - for all CPU families known to the driver. If we spot a patch that is longer than expected for its family we'll carefully skip over only the expected le

Re: [PATCH v10 1/7] x86/tsc: remove tsc_disabled flag

2018-06-19 Thread Peter Zijlstra
On Tue, Jun 19, 2018 at 07:32:49PM +0200, Thomas Gleixner wrote: > On Fri, 15 Jun 2018, Pavel Tatashin wrote: > > > tsc_disabled is set when notsc is passed as kernel parameter. The reason we > > have notsc is to avoid timing problems on multi-socket systems. We already > > have a mechanism, howe

[PATCH v7 0/9] x86/microcode/AMD: Check microcode file sanity before loading it

2018-06-19 Thread Maciej S. Szmigiero
Currently, it is very easy to make the AMD microcode update driver crash or spin on a malformed microcode container file since it does very little consistency checking on data loaded from such file. This series introduces various checks, mostly on length-type fields, so all corrupted microcode con

[PATCH v7 2/9] x86/microcode/AMD: Add microcode container data checking functions

2018-06-19 Thread Maciej S. Szmigiero
Add verify_container(), verify_equivalence_table(), verify_patch_section() and verify_patch() functions to the AMD microcode update driver. These functions check whether a passed buffer contains the relevant structure, whether it isn't truncated and (for actual microcode patches) whether the size

[PATCH v7 7/9] x86/microcode/AMD: Add a reminder about PATCH_MAX_SIZE macro

2018-06-19 Thread Maciej S. Szmigiero
The PATCH_MAX_SIZE macro should contain the maximum of all family patch sizes. Since these sizes are defined in an other place than this macro, let's add a reminder to them so people will remember to verify PATCH_MAX_SIZE correctness when modifying a family patch size or adding a new family. Signe

[PATCH v7 6/9] x86/microcode/AMD: Check microcode container data in the late loader

2018-06-19 Thread Maciej S. Szmigiero
Convert the late loader in the AMD microcode update driver to use newly introduced microcode container data checking functions as it was previously done for the early loader. Signed-off-by: Maciej S. Szmigiero --- arch/x86/kernel/cpu/microcode/amd.c | 67 + 1 file cha

[PATCH v7 4/9] x86/microcode/AMD: Check microcode container data in the early loader

2018-06-19 Thread Maciej S. Szmigiero
Convert the early loader in the AMD microcode update driver to use the container data checking functions introduced by previous commits. We have to be careful to call these functions with 'early' parameter set, so they won't try to print errors as the early loader runs too early for printk()-style

Re: WARNING in input_alloc_absinfo

2018-06-19 Thread Dmitry Torokhov
On Thu, Jun 14, 2018 at 05:47:03AM -0700, syzbot wrote: > Hello, > > syzbot found the following crash on: > > HEAD commit:d2d741e5d189 kmsan: add initialization for shmem pages > git tree: https://github.com/google/kmsan.git/master > console output: https://syzkaller.appspot.com/x/log.t

[PATCH v7 8/9] x86/microcode/AMD: Convert CPU equivalence table variable into a struct

2018-06-19 Thread Maciej S. Szmigiero
Convert pointer to CPU equivalence table global static variable into a struct descriptor in preparation for tracking also the size of this table. Signed-off-by: Maciej S. Szmigiero --- arch/x86/kernel/cpu/microcode/amd.c | 24 +--- 1 file changed, 13 insertions(+), 11 deletio

Re: [RFC v7 1/1] mconf: global i-search in menu prompts

2018-06-19 Thread Dirk Gouders
Randy Dunlap writes: > Hi Dirk, > > On 06/17/2018 05:15 AM, Dirk Gouders wrote: >> >> At any time, at most one i-search is active and the navigation path to >> the current menu is displayed in the subtitle, the second line in the >> menu window. > > Nice. > > And the highlight of the current men

Re: [PATCH] kvm: x86: mmu: Add cast to negated bitmasks in update_permission_bitmask()

2018-06-19 Thread Joe Perches
On Tue, 2018-06-19 at 11:36 -0700, Matthias Kaehlcke wrote: > On Tue, Jun 19, 2018 at 11:07:47AM -0700, Joe Perches wrote: > > On Tue, 2018-06-19 at 19:35 +0200, Paolo Bonzini wrote: > > > On 19/06/2018 19:23, Joe Perches wrote: > > > > On Tue, 2018-06-19 at 10:08 -0700, Nick Desaulniers wrote: > >

Re: [PATCH v10 1/7] x86/tsc: remove tsc_disabled flag

2018-06-19 Thread Thomas Gleixner
On Tue, 19 Jun 2018, Peter Zijlstra wrote: > On Tue, Jun 19, 2018 at 07:32:49PM +0200, Thomas Gleixner wrote: > > On Fri, 15 Jun 2018, Pavel Tatashin wrote: > > > > > tsc_disabled is set when notsc is passed as kernel parameter. The reason > > > we > > > have notsc is to avoid timing problems on

Re: Possible regression in "slab, slub: skip unnecessary kasan_cache_shutdown()"

2018-06-19 Thread Shakeel Butt
On Tue, Jun 19, 2018 at 8:19 AM Jason A. Donenfeld wrote: > > On Tue, Jun 19, 2018 at 5:08 PM Shakeel Butt wrote: > > > > Are you using SLAB or SLUB? We stress kernel pretty heavily, but with > > > > SLAB, and I suspect Shakeel may also be using SLAB. So if you are > > > > using SLUB, there is si

Re: [PATCH] Use 'imply' with SEV Kconfig CRYPTO dependencies

2018-06-19 Thread Brijesh Singh
Hi Boris, On 06/19/2018 04:46 AM, Borislav Petkov wrote: On Thu, Jun 14, 2018 at 07:08:26AM -0500, Brijesh Singh wrote: I think depends should look like this: config KVM_AMD_SEV     def_bool y     bool "AMD Secure Encrypted Virtualization (SEV) support"     depends KVM_AMD && X86_64     d

[PATCH v2] kvm: x86: mmu: Add cast to negated bitmasks in update_permission_bitmask()

2018-06-19 Thread Matthias Kaehlcke
update_permission_bitmask() negates u8 bitmask values and assigns them to variables of type u8. Since the MSB is set in the bitmask values the compiler expands the negated values to int, which then is assigned to an u8 variable. Cast the negated value back to u8. This fixes several warnings like t

[PATCH 1/2] ARM: avoid badr macro for switching to Thumb-2 mode

2018-06-19 Thread Ard Biesheuvel
Switching to Thumb-2 mode can be done using a single 'sub' instruction so use that instead of the badr macro in various places in the code. This allows us to reimplement the macro in a way that does not allow it to be used in ARM code sequences when building a Thumb2 kernel. Signed-off-by: Ard Bie

[PATCH 2/2] ARM: assembler: prevent ADR from setting the Thumb bit twice

2018-06-19 Thread Ard Biesheuvel
To work around recent issues where ADR references to Thumb function symbols may or may not have the Thumb bit set already when they are resolved by GAS, reference the symbol indirectly via a local symbol typed as 'function', and emit the reference in a way that prevents the assembler from resolving

[PATCH 0/2] Make badr macro compatible with newer GAS versions

2018-06-19 Thread Ard Biesheuvel
Work around the mindless and backward incompatible change in GAS that prevents us from using a simple addition to set the Thumb bit in local symbol references taken using 'adr' instructions (#2) As a preparatory step, remove badr occurrences in ARM code sequences contained in Thumb2 kernels. Ard

Re: [RFC v7 1/1] mconf: global i-search in menu prompts

2018-06-19 Thread Randy Dunlap
On 06/19/2018 11:47 AM, Dirk Gouders wrote: > Randy Dunlap writes: > >> Hi Dirk, >> >> On 06/17/2018 05:15 AM, Dirk Gouders wrote: >>> >>> At any time, at most one i-search is active and the navigation path to >>> the current menu is displayed in the subtitle, the second line in the >>> menu wind

[PATCH 3/5] arm64: dts: ti: Add Support for AM654 SoC

2018-06-19 Thread Nishanth Menon
The AM654 SoC is a lead device of the K3 Multicore SoC architecture platform, targeted for broad market and industrial control with aim to meet the complex processing needs of modern embedded products. Some highlights of this SoC are: * Quad ARMv8 A53 cores split over two clusters * GICv3 complian

[PATCH 6/6] mailbox: ti-msgmgr: Add support for Secure Proxy

2018-06-19 Thread Nishanth Menon
Secure Proxy is another communication scheme in Texas Instrument's devices intended to provide an unique communication path from various processors in the System on Chip(SoC) to a central System Controller. Secure proxy is, in effect, an evolution of current generation Message Manager hardware blo

[PATCH 0/5] arm64: Initial support Texas Instrument's AM654 Platform

2018-06-19 Thread Nishanth Menon
Hi, This is an update from RFC posted earlier: https://marc.info/?l=linux-arm-kernel&m=152817866312732&w=2 The following series enables support for newest addition in TI's SoC portfolio - AM654 SoC. The series is based off v4.18-rc1, also available here: https://github.com/nmenon/linux-2.

Re: [PATCH v2 2/2] hwmon: npcm750: add NPCM7xx PWM and Fan driver

2018-06-19 Thread kbuild test robot
Hi Tomer, I love your patch! Perhaps something to improve: [auto build test WARNING on hwmon/hwmon-next] [also build test WARNING on v4.18-rc1 next-20180619] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci

[PATCH 1/2] Documentation: dt: keystone: ti-sci: Add optional host-id parameter

2018-06-19 Thread Nishanth Menon
Texas Instrument's System Control Interface (TISCI) permits the ability for OSs running in virtual machines to be able to independently communicate with the firmware without the need going through an hypervisor. The "host-id" in effect is the hardware representation of the host (example: VMs locke

[PATCH 4/5] soc: ti: Add Support for AM654 SoC config option

2018-06-19 Thread Nishanth Menon
Add option to build AM6 SoC specific components Signed-off-by: Benjamin Fair Signed-off-by: Nishanth Menon --- (new patch broken out from: https://patchwork.kernel.org/patch/10447719/) drivers/soc/ti/Kconfig | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/soc/ti/Kco

[PATCH 2/2] serial: 8250_omap: Add support for AM654 UART controller

2018-06-19 Thread Nishanth Menon
AM654 uses a UART controller that is compatible (partially) with existing 8250 UART, however, has a few differences with respect to DMA support and control paths. Introduce a base definition that allows us to build up the differences in follow on patches. Cc: Sekhar Nori Cc: Vignesh R Signed-off

[PATCH 1/2] dt-bindings: serial: 8250_omap: Add compatible for AM654 UART controller

2018-06-19 Thread Nishanth Menon
AM654 uses a UART controller that is only partially compatible with existing 8250 UART. UART DMA integration is substantially different and even a match against standard 8250 or omap4 would result in non-working UART once DMA is enabled by default. Introduce a specific compatible to help build up

[PATCH 2/2] firmware: ti_sci: Provide host-id as an optional dt parameter

2018-06-19 Thread Nishanth Menon
Texas Instrument's System Control Interface (TISCI) permits the ability for Operating Systems to running in virtual machines to be able to independently communicate with the firmware without the need going through an hypervisor. The "host-id" in effect is the hardware representation of the host (e

Re: [PATCH] Use 'imply' with SEV Kconfig CRYPTO dependencies

2018-06-19 Thread Borislav Petkov
On Tue, Jun 19, 2018 at 02:22:53PM -0500, Brijesh Singh wrote: > It would be nice to have a single depends. But the main issue is, PSP > support is provided through the ccp driver (aka CRYPTO_DEV_CCP_DD). And this sentence states also your dependency: KVM_AMD_SEV <- PSP driver <- CCP driver but

[PATCH 2/5] arm64: Add support for TI's K3 Multicore SoC architecture

2018-06-19 Thread Nishanth Menon
Add support for Texas Instrument's K3 Multicore SoC architecture processors. Signed-off-by: Nishanth Menon --- Changes since RFC: * None RFC: https://patchwork.kernel.org/patch/10447633/ arch/arm64/Kconfig.platforms | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm64/Kconfig

[PATCH 1/5] dt-bindings: arm: ti: Add bindings for AM654 SoC

2018-06-19 Thread Nishanth Menon
The AM654 SoC is a lead device of the K3 Multicore SoC architecture platform, targeted for broad market and industrial control with aim to meet the complex processing needs of modern embedded products. Some highlights of this SoC are: * Quad ARMv8 A53 cores split over two clusters * GICv3 complian

[PATCH 2/6] mailbox: ti-msgmgr: Allocate Rx channel resources only on request

2018-06-19 Thread Nishanth Menon
In a much bigger system SoCs, the number of Rx channels can be many and mostly unused based on the system of choice, and not all Rx channels need IRQs and allocating all memory at probe will be inefficient. Some SoCs could have total threads in the 100s and usage would be just 1 Rx thread. Thus, r

[PATCH 0/6] mailbox: ti-msgmgr: Add support for AM654 Secure Proxy

2018-06-19 Thread Nishanth Menon
Hi, The following series enables support for Secure Proxy in newest addition in TI's SoC portfolio - AM654 SoC (posted previously as RFC). The series is based on v4.18-rc1 and is available here: https://github.com/nmenon/linux-2.6-playground/commits/upstream/v4.18-rc1/k3-1-am6-sproxy There are a

[PATCH 4/6] mailbox: ti-msgmgr: Move the memory region name to descriptor

2018-06-19 Thread Nishanth Menon
For newer generation of the hardware, the naming of the region is decided at integration level and there could be additional regions as well. Hence move the region naming to be described from compatible descriptor. Signed-off-by: Nishanth Menon --- Changes since RFC: None RFC: https://patchwork.k

[PATCH 5/5] arm64: dts: ti: Add support for AM654 EVM base board

2018-06-19 Thread Nishanth Menon
The EValuation Module(EVM) platform for AM654 consists of a common Base board + one or more of daughter cards, which include: a) "Personality Modules", which can be specific to a profile, such as ICSSG enabled or Multi-media (including audio). b) SERDES modules, which may be 2 lane PCIe or two por

Re: [RFC v7 1/1] mconf: global i-search in menu prompts

2018-06-19 Thread Dirk Gouders
Randy Dunlap writes: > On 06/19/2018 11:47 AM, Dirk Gouders wrote: >> Randy Dunlap writes: >> >>> Hi Dirk, >>> >>> On 06/17/2018 05:15 AM, Dirk Gouders wrote: At any time, at most one i-search is active and the navigation path to the current menu is displayed in the subtitle, the

Re: [PATCH 3/3] fs, mm: account buffer_head to kmemcg

2018-06-19 Thread Shakeel Butt
On Tue, Jun 19, 2018 at 10:41 AM Roman Gushchin wrote: > > On Tue, Jun 19, 2018 at 12:27:41PM -0400, Johannes Weiner wrote: > > On Mon, Jun 18, 2018 at 10:13:27PM -0700, Shakeel Butt wrote: > > > The buffer_head can consume a significant amount of system memory and > > > is directly related to the

Re: [PATCH treewide] headers: separate mod_devicetable.h from platform_device.h

2018-06-19 Thread kbuild test robot
Hi Randy, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.18-rc1 next-20180619] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

[PATCH 1/6] mailbox: ti-msgmgr: Get rid of unused structure members

2018-06-19 Thread Nishanth Menon
Though q_proxies and q_slices do describe the hardware configuration, they are not necessary for operation given that the values are always default. Hence drop the same. Signed-off-by: Nishanth Menon --- Changes since RFC: None RFC: https://patchwork.kernel.org/patch/10447665/ drivers/mailbox/t

Re: [RFC PATCH v2] driver core: add a debugfs entry to show deferred devices

2018-06-19 Thread Andy Shevchenko
On Tue, Jun 19, 2018 at 9:33 PM, Javier Martinez Canillas wrote: > For debugging purposes it may be useful to know what are the devices whose > probe function was deferred. Add a debugfs entry showing that information. > > $ cat /sys/kernel/debug/deferred_devices > 4807.i2c:twl@48:bci >

[PATCH 3/6] mailbox: ti-msgmgr: Change message count mask to be descriptor based

2018-06-19 Thread Nishanth Menon
Change mask used to extract the message count to be descriptor based. This is to support changes for count location for various SoC solutions. Signed-off-by: Nishanth Menon --- Changes since RFC: None RFC: https://patchwork.kernel.org/patch/10447671/ drivers/mailbox/ti-msgmgr.c | 25 ++

[PATCH 5/6] dt-bindings: mailbox: Add support for secure proxy threads

2018-06-19 Thread Nishanth Menon
Secure Proxy is another communication scheme in Texas Instrument's devices intended to provide an unique communication path from various processors in the System on Chip(SoC) to a central System Controller. Secure proxy is, in effect, an evolution of current generation Message Manager hardware blo

[PATCH 0/2] firmware: ti_sci: Add host-id as an optional parameter

2018-06-19 Thread Nishanth Menon
Hi, Please find attached series to enable host-id as an optional dt property. Changes Since RFC: * Updated commit message based on feedback from Rob. The series is based on v4.18-rc1 and is available here: https://github.com/nmenon/linux-2.6-playground/commits/upstream/v4.18-rc1/k3-1-am6-tisci

Re: [RFC PATCH v2] driver core: add a debugfs entry to show deferred devices

2018-06-19 Thread Andy Shevchenko
On Tue, Jun 19, 2018 at 10:53 PM, Andy Shevchenko wrote: > On Tue, Jun 19, 2018 at 9:33 PM, Javier Martinez Canillas > wrote: >> For debugging purposes it may be useful to know what are the devices whose >> probe function was deferred. Add a debugfs entry showing that information. >> +static int

[PATCH 0/2] serial: 8250_omap: Add compatible for AM654 UART

2018-06-19 Thread Nishanth Menon
Hi, This series was previously send out as part of a larger AM654 UART support series, but was determined to create a bit of merge conflicts due to interdependence. Changes since RFC are indicated in corresponding patches in the series Instead this series is split out. The series itself is based

Re: [PATCH 3/3] fs, mm: account buffer_head to kmemcg

2018-06-19 Thread Roman Gushchin
On Tue, Jun 19, 2018 at 12:51:15PM -0700, Shakeel Butt wrote: > On Tue, Jun 19, 2018 at 10:41 AM Roman Gushchin wrote: > > > > On Tue, Jun 19, 2018 at 12:27:41PM -0400, Johannes Weiner wrote: > > > On Mon, Jun 18, 2018 at 10:13:27PM -0700, Shakeel Butt wrote: > > > > The buffer_head can consume a

Re: [PATCH] x86: Call fixup_exception() before notify_die() in math_error()

2018-06-19 Thread Siarhei Liakh
On Tue, 19 Jun 2018, Andy Lutomirski wrote:  > On Jun 19, 2018, at 9:15 AM, Siarhei Liakh > wrote: > > > On Mon, 18 Jun 2018, Andy Lutomirski wrote: > > > > > > On Thu, Jun 14, 2018 at 10:10 PM Siarhei Liakh > > > > wrote: > > > > > > > > > > fpu__drop() has an explicit fwait which under so

[PATCH 2/9] staging: rtl8192u: Correct indentation of switch statement - Coding Style

2018-06-19 Thread John Whitmore
Removed an extra indentation from the code of the various case options in a switch statement. Signed-off-by: John Whitmore --- .../rtl8192u/ieee80211/rtl819x_HTProc.c | 30 +-- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee8021

[PATCH 6/9] staging: rtl8192u: Remove braces from single statement blocks - Style

2018-06-19 Thread John Whitmore
Removed the unrequired braces from single statement blocks - Coding Style. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/dr

[PATCH 8/9] staging: rtl8192u: Correct if statement - Coding Style

2018-06-19 Thread John Whitmore
Corrected the coding style of if statement. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers/staging/rtl8192u/ieee80211/rtl81

[PATCH 9/9] staging: rtl8192u: Correction of spelling mistake in comment.

2018-06-19 Thread John Whitmore
Simple spelling correction. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c index 05

v1 Coding style changes

2018-06-19 Thread John Whitmore
Simple coding style changes to single file drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c

[PATCH 4/9] staging: rtl8192u: Removal of white space from end of lines - Coding Style

2018-06-19 Thread John Whitmore
Previous truncation of comment blocks to 80 character line length resulted in some white space at endof line. Signed-off-by: John Whitmore --- .../rtl8192u/ieee80211/rtl819x_HTProc.c | 26 +-- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/staging/r

[PATCH 5/9] staging: rtl8192u: Use %s and __func__ instead of hardcoded string - Style

2018-06-19 Thread John Whitmore
Changed a number of hard coded function names to use %s and __func__ Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/driver

[PATCH 7/9] staging: rtl8192u: Correciton of block comments - Coding Style

2018-06-19 Thread John Whitmore
Correcton of a few block comments to comply with Coding Style. Signed-off-by: John Whitmore --- .../staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers/sta

[PATCH 3/9] staging: rtl8192u: Truncate block comments to 80 character length - Style

2018-06-19 Thread John Whitmore
Where possible truncation of block comments to the 80 character length prefered by the coding style. Signed-off-by: John Whitmore --- .../rtl8192u/ieee80211/rtl819x_HTProc.c | 157 +++--- 1 file changed, 98 insertions(+), 59 deletions(-) diff --git a/drivers/staging/rtl8192u/i

[PATCH v2] PCI/AER: Fix aerdrv loading with "pcie_ports=native" parameter

2018-06-19 Thread Alexandru Gagniuc
According to the documentation, "pcie_ports=native", linux should use native AER and DPC services. While that is true for the _OSC method parsing, this is not the only place that is checked. Should the HEST table list PCIe ports as firmware-first, linux will not use native services. This happens b

[PATCH 1/9] staging: rtl8192u: change block comments to prefered style - Coding Style

2018-06-19 Thread John Whitmore
Some of the comment blocks are commening out code so have been left for the moment. Signed-off-by: John Whitmore --- .../rtl8192u/ieee80211/rtl819x_HTProc.c | 366 ++ 1 file changed, 195 insertions(+), 171 deletions(-) diff --git a/drivers/staging/rtl8192u/ieee80211/rtl81

Re: [PATCH v10 1/7] x86/tsc: remove tsc_disabled flag

2018-06-19 Thread Peter Zijlstra
On Tue, Jun 19, 2018 at 09:12:45PM +0200, Thomas Gleixner wrote: > On Tue, 19 Jun 2018, Peter Zijlstra wrote: > > It does not; there is TSC usage even if you boot with notsc on. See how > > it does not clear X86_FEATURE_TSC for instance. > > Well, kinda. There is some stuff in the apic calibration

Re: [PATCH 2/9] staging: rtl8192u: Correct indentation of switch statement - Coding Style

2018-06-19 Thread Andy Shevchenko
On Tue, Jun 19, 2018 at 10:55 PM, John Whitmore wrote: > Removed an extra indentation from the code of the various case options in a > switch statement. > + //no MCS rate > + for (i = 0; i <= 15; i++) > + pOperateMCS[i] = 0; This would be just me

Re: [PATCH 3/9] staging: rtl8192u: Truncate block comments to 80 character length - Style

2018-06-19 Thread Andy Shevchenko
On Tue, Jun 19, 2018 at 10:55 PM, John Whitmore wrote: > Where possible truncation of block comments to the 80 character length > prefered by the coding style. Is it somehow automated?! > /* > -* 8190 only, Realtek proprietary aggregation mode > -* Set MPDUDensity=2, 1:

Re: Possible regression in "slab, slub: skip unnecessary kasan_cache_shutdown()"

2018-06-19 Thread Jason A. Donenfeld
Hi Andrey, On Tue, Jun 19, 2018 at 7:33 PM Andrey Ryabinin wrote: > What's the status of CONFIG_SLUB_DEBUG in your config? > > AFAICS __kmem_cache_empty() is broken for CONFIG_SLUB_DEBUG=n. We use > slabs_node() there > which is always 0 for CONFIG_SLUB_DEBUG=n. > > The problem seems not limited

[PATCH v2 0/3] Resolve -Wattribute-alias warnings from SYSCALL_DEFINEx()

2018-06-19 Thread Paul Burton
This series introduces infrastructure allowing compiler diagnostics to be disabled or their severity modified for specific pieces of code, with suitable abstractions to prevent that code from becoming tied to a specific compiler. This infrastructure is then used to disable the -Wattribute-alias wa

Re: [PATCH 5/9] staging: rtl8192u: Use %s and __func__ instead of hardcoded string - Style

2018-06-19 Thread Andy Shevchenko
On Tue, Jun 19, 2018 at 10:56 PM, John Whitmore wrote: > Changed a number of hard coded function names to use %s and __func__ Oh. Looking at the code, much better fix would be... Move IEEE80211_DEBUG() to use netdev_dbg() [dev_dbg() or pr_dbg() as last resort) and actually drop it completely in

Re: Possible regression in "slab, slub: skip unnecessary kasan_cache_shutdown()"

2018-06-19 Thread Jason A. Donenfeld
Hi Shakeel, On Tue, Jun 19, 2018 at 9:21 PM Shakeel Butt wrote: > Jason, can you try the following patch? Your patch also fixed the problem, which was also fixed by enabling CONFIG_SLUB_DEBUG, per the other email. I haven't checked to see if your patch is simply a subset of what SLUB_DEBUG is do

Re: [PATCH 2/2] fs/lock: show locks taken by processes from another pidns

2018-06-19 Thread Andrey Vagin
On Thu, Jun 14, 2018 at 07:00:07AM -0400, Jeff Layton wrote: > On Fri, 2018-06-08 at 17:27 +0300, Konstantin Khorenko wrote: > > Currently if we face a lock taken by a process invisible in the current > > pidns we skip the lock completely, but this > > > > 1) makes the output not that nice > >

Re: [RFC PATCH v2] driver core: add a debugfs entry to show deferred devices

2018-06-19 Thread Greg Kroah-Hartman
On Tue, Jun 19, 2018 at 10:55:20PM +0300, Andy Shevchenko wrote: > On Tue, Jun 19, 2018 at 10:53 PM, Andy Shevchenko > wrote: > > On Tue, Jun 19, 2018 at 9:33 PM, Javier Martinez Canillas > > wrote: > >> For debugging purposes it may be useful to know what are the devices whose > >> probe functio

Re: [PATCH 0/2] Make badr macro compatible with newer GAS versions

2018-06-19 Thread Guenter Roeck
On Tue, Jun 19, 2018 at 09:26:31PM +0200, Ard Biesheuvel wrote: > Work around the mindless and backward incompatible change in GAS that > prevents us from using a simple addition to set the Thumb bit in local > symbol references taken using 'adr' instructions (#2) > > As a preparatory step, remove

Re: [PATCH] drm: fix fallouts from slow-work -> wq conversion

2018-06-19 Thread Dave Airlie
On 9 August 2010 at 20:20, Tejun Heo wrote: > >From 9a919c46dfa48a9c1f465174609b90253eb8ffc1 Mon Sep 17 00:00:00 2001 > From: Tejun Heo > Date: Mon, 9 Aug 2010 12:01:27 +0200 > > Commit 991ea75c (drm: use workqueue instead of slow-work), which made > drm to use wq instead of slow-work, didn't acc

Re: [patch] mm, oom: fix unnecessary killing of additional processes

2018-06-19 Thread David Rientjes
On Mon, 18 Jun 2018, Andrew Morton wrote: > > The oom reaper ensures forward progress by setting MMF_OOM_SKIP itself if > > it cannot reap an mm. This can happen for a variety of reasons, > > including: > > > > - the inability to grab mm->mmap_sem in a sufficient amount of time, > > > > - whe

Re: [PATCH 0/2] Make badr macro compatible with newer GAS versions

2018-06-19 Thread Ard Biesheuvel
On 19 June 2018 at 22:32, Guenter Roeck wrote: > On Tue, Jun 19, 2018 at 09:26:31PM +0200, Ard Biesheuvel wrote: >> Work around the mindless and backward incompatible change in GAS that >> prevents us from using a simple addition to set the Thumb bit in local >> symbol references taken using 'adr'

Re: [v2] cpufreq / CPPC: Add cpuinfo_cur_freq support for CPPC

2018-06-19 Thread Jayachandran C
Hi George, Few comments on your patch: On Fri, Jun 15, 2018 at 03:03:15AM -0700, George Cherian wrote: > Per Section 8.4.7.1.3 of ACPI 6.2, The platform provides performance > feedback via set of performance counters. To determine the actual > performance level delivered over time, OSPM may read

Re: [PATCH v10 3/7] x86/time: read_boot_clock64() implementation

2018-06-19 Thread Andy Shevchenko
On Tue, Jun 19, 2018 at 5:23 PM, Pavel Tatashin wrote: >> > > + *ts = (struct timespec64){0, 0}; >> >> I dunno if additional variable would be better for readability, like >> >> struct timespec64 null_ts = {0,0}; > > I don't mind adding ts_null, but I think, as-is ok here, Actually

Re: [PATCH 0/2] Make badr macro compatible with newer GAS versions

2018-06-19 Thread Guenter Roeck
On Tue, Jun 19, 2018 at 10:34:38PM +0200, Ard Biesheuvel wrote: > On 19 June 2018 at 22:32, Guenter Roeck wrote: > > On Tue, Jun 19, 2018 at 09:26:31PM +0200, Ard Biesheuvel wrote: > >> Work around the mindless and backward incompatible change in GAS that > >> prevents us from using a simple addit

Re: Query: Patches break with Microsoft exchange server.

2018-06-19 Thread Willy Tarreau
On Mon, Aug 09, 2010 at 11:02:44AM +0100, David Woodhouse wrote: > If my corporate overloads told me I had to use my Exchange "messaging" > account for external email communication, they would get a quite clear > 'no' in response. My response may also contain suggestions that they use > certain oth

Re: [PATCH] Use 'imply' with SEV Kconfig CRYPTO dependencies

2018-06-19 Thread Brijesh Singh
On 06/19/2018 02:43 PM, Borislav Petkov wrote: On Tue, Jun 19, 2018 at 02:22:53PM -0500, Brijesh Singh wrote: It would be nice to have a single depends. But the main issue is, PSP support is provided through the ccp driver (aka CRYPTO_DEV_CCP_DD). And this sentence states also your dependen

Re: [PATCH v2] regulator: arizona-ldo1: Use correct device to get enable GPIO

2018-06-19 Thread Andy Shevchenko
On Tue, Jun 19, 2018 at 6:10 PM, Charles Keepax wrote: > Currently the enable GPIO is being looked up on the regulator > device itself but that does not have its own DT node, this causes > the lookup to fail and the regulator not to get its GPIO. The DT > node is shared across the whole MFD and as

Re: [RFC PATCH v2] driver core: add a debugfs entry to show deferred devices

2018-06-19 Thread Javier Martinez Canillas
Hello Andy, Thanks a lot for your feedback. On 06/19/2018 09:55 PM, Andy Shevchenko wrote: > On Tue, Jun 19, 2018 at 10:53 PM, Andy Shevchenko > wrote: >> On Tue, Jun 19, 2018 at 9:33 PM, Javier Martinez Canillas >> wrote: >>> For debugging purposes it may be useful to know what are the devices

Flash Memory Summit

2018-06-19 Thread Grace Anna
Hi, I have noticed that your company is exhibiting in Flash Memory Summit on AUG 07 - 09 2018. Would you be interested in the complete (B2B) contact information with email addresses of: § Hardware and software designers § Storage specialists § Consumer electronics designers § Data cen

Re: [PATCH v10 1/7] x86/tsc: remove tsc_disabled flag

2018-06-19 Thread Thomas Gleixner
On Tue, 19 Jun 2018, Peter Zijlstra wrote: > On Tue, Jun 19, 2018 at 09:12:45PM +0200, Thomas Gleixner wrote: > > On Tue, 19 Jun 2018, Peter Zijlstra wrote: > > > It does not; there is TSC usage even if you boot with notsc on. See how > > > it does not clear X86_FEATURE_TSC for instance. > > > >

[PATCH] driver core: add a debugfs entry to show deferred devices

2018-06-19 Thread Javier Martinez Canillas
For debugging purposes it may be useful to know what are the devices whose probe function was deferred. Add a debugfs entry showing that information. $ cat /sys/kernel/debug/deferred_devices 4807.i2c:twl@48:bci musb-hdrc.0.auto omapdrm.0 Signed-off-by: Javier Martinez Canillas ---

Re: [PATCH v10 1/7] x86/tsc: remove tsc_disabled flag

2018-06-19 Thread Peter Zijlstra
On Tue, Jun 19, 2018 at 10:57:35PM +0200, Thomas Gleixner wrote: > I'm not arguing against removing it. I just refuse to accept changelogs > which suggest that there is no functional change. Fair enough..

Re: [PATCH] driver core: add a debugfs entry to show deferred devices

2018-06-19 Thread Andy Shevchenko
On Tue, Jun 19, 2018 at 11:59 PM, Javier Martinez Canillas wrote: > For debugging purposes it may be useful to know what are the devices whose > probe function was deferred. Add a debugfs entry showing that information. > > $ cat /sys/kernel/debug/deferred_devices > 4807.i2c:twl@48:bci >

[PATCH] thp: use mm_file_counter to determine update which rss counter

2018-06-19 Thread Yang Shi
Since commit eca56ff906bdd0239485e8b47154a6e73dd9a2f3 ("mm, shmem: add internal shmem resident memory accounting"), MM_SHMEMPAGES is added to separate the shmem accounting from regular files. So, all shmem pages should be accounted to MM_SHMEMPAGES instead of MM_FILEPAGES. And, normal 4K shmem pag

Re: [PATCH 2/2] jffs2: use unsigned 32-bit timstamps consistently

2018-06-19 Thread kbuild test robot
Hi Arnd, I love your patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v4.18-rc1 next-20180619] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

Re: [PATCH] kvm: x86: mmu: Add cast to negated bitmasks in update_permission_bitmask()

2018-06-19 Thread Matthias Kaehlcke
On Tue, Jun 19, 2018 at 12:11:27PM -0700, Joe Perches wrote: > On Tue, 2018-06-19 at 11:36 -0700, Matthias Kaehlcke wrote: > > On Tue, Jun 19, 2018 at 11:07:47AM -0700, Joe Perches wrote: > > > On Tue, 2018-06-19 at 19:35 +0200, Paolo Bonzini wrote: > > > > On 19/06/2018 19:23, Joe Perches wrote: >

Re: [RFC v2 PATCH 2/2] mm: mmap: zap pages with read mmap_sem for large mapping

2018-06-19 Thread Yang Shi
On 6/19/18 3:02 AM, Peter Zijlstra wrote: On Tue, Jun 19, 2018 at 07:34:16AM +0800, Yang Shi wrote: diff --git a/mm/mmap.c b/mm/mmap.c index fc41c05..e84f80c 100644 --- a/mm/mmap.c +++ b/mm/mmap.c @@ -2686,6 +2686,141 @@ int split_vma(struct mm_struct *mm, struct vm_area_struct *vma,

Re: [PATCH 1/3] pinctrl: msm: Really mask level interrupts to prevent latching

2018-06-19 Thread Stephen Boyd
Quoting Doug Anderson (2018-06-18 16:38:27) > Hi, > > On Mon, Jun 18, 2018 at 4:28 PM, Stephen Boyd wrote: > > Quoting Doug Anderson (2018-06-18 15:43:06) > >> > >> On Mon, Jun 18, 2018 at 1:52 PM, Stephen Boyd wrote: > >> > >> > +*/ > >> > + if (irqd_get_trigger_type(d) & IRQ_TYPE

Re: [PATCH v10 2/7] time: sync read_boot_clock64() with persistent clock

2018-06-19 Thread Thomas Gleixner
On Fri, 15 Jun 2018, Pavel Tatashin wrote: > read_boot_clock64() returns a boot start timestamp from epoch. Some arches > may need to access the persistent clock interface in order to calculate the > epoch offset. The resolution of the persistent clock, however, might be > low. Therefore, in orde

Re: [PATCH 2/3] pinctrl: msm: Mux out gpio function with gpio_request()

2018-06-19 Thread Stephen Boyd
Quoting Doug Anderson (2018-06-18 16:54:49) > Hi, > > On Mon, Jun 18, 2018 at 1:52 PM, Stephen Boyd wrote: > > We rely on devices to use pinmuxing configurations in DT to select the > > GPIO function (function 0) if they're going to use the gpio in GPIO > > mode. Let's simplify things for driver

[PATCH v5 3/6] clocksource/drivers: atmel-pit: make option silent

2018-06-19 Thread Alexandre Belloni
To conform with the other option, make the ATMEL_PIT option silent so it can be selected from the platform Tested-by: Alexander Dahl Signed-off-by: Alexandre Belloni --- drivers/clocksource/Kconfig | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/clocksource/Kconf

Re: [PATCH] clk: qcom: Add some missing gcc clks for msm8996

2018-06-19 Thread Stephen Boyd
Quoting Stephen Boyd (2018-05-15 11:05:44) > Quoting Bjorn Andersson (2018-04-17 17:09:26) > > @@ -3350,6 +3522,7 @@ static struct clk_regmap *gcc_msm8996_clocks[] = { > > [GCC_AGGRE0_CNOC_AHB_CLK] = &gcc_aggre0_cnoc_ahb_clk.clkr, > > [GCC_SMMU_AGGRE0_AXI_CLK] = &gcc_smmu_aggre0_axi

[PATCH v5 5/6] ARM: configs: at91: use new TCB timer driver

2018-06-19 Thread Alexandre Belloni
Unselecting ATMEL_TCLIB switches the TCB timer driver from tcb_clksrc to timer-atmel-tcb. Signed-off-by: Alexandre Belloni --- arch/arm/configs/at91_dt_defconfig | 1 - arch/arm/configs/sama5_defconfig | 1 - 2 files changed, 2 deletions(-) diff --git a/arch/arm/configs/at91_dt_defconfig b/a

<    1   2   3   4   5   6   7   8   9   >