Re: [PATCH] arm64: mm: mark tramp_pg_dir read-only

2018-06-19 Thread Ard Biesheuvel
On 19 June 2018 at 17:50, Will Deacon wrote: > On Tue, Jun 19, 2018 at 05:40:26PM +0200, Ard Biesheuvel wrote: >> On 19 June 2018 at 17:37, Will Deacon wrote: >> > On Tue, Jun 19, 2018 at 05:29:03PM +0200, Ard Biesheuvel wrote: >> >> On 19 June 2018 at 17:28, Will Deacon wrote: >> >> > On Tue, J

Re: [PATCH] arm64: mm: mark tramp_pg_dir read-only

2018-06-19 Thread Will Deacon
On Tue, Jun 19, 2018 at 05:51:46PM +0200, Ard Biesheuvel wrote: > On 19 June 2018 at 17:50, Will Deacon wrote: > > On Tue, Jun 19, 2018 at 05:40:26PM +0200, Ard Biesheuvel wrote: > >> On 19 June 2018 at 17:37, Will Deacon wrote: > >> > On Tue, Jun 19, 2018 at 05:29:03PM +0200, Ard Biesheuvel wrot

Re: [PATCH 1/2] rcu: Assign higher priority to RCU threads if its rcutorture

2018-06-19 Thread Paul E. McKenney
On Mon, Jun 18, 2018 at 11:34:21PM -0700, Joel Fernandes wrote: > On Mon, Jun 18, 2018 at 11:22:14PM -0700, Joel Fernandes wrote: > > From: "Joel Fernandes (Google)" > > > > rcutorture boost tests fail even with CONFIG_RCU_BOOST set because > > rcutorture's threads are equal priority to the defau

Re: [PATCH v11 09/13] x86, sgx: basic routines for enclave page cache

2018-06-19 Thread Sean Christopherson
On Tue, Jun 19, 2018 at 05:57:53PM +0300, Jarkko Sakkinen wrote: > On Fri, Jun 08, 2018 at 11:24:12AM -0700, Dave Hansen wrote: > > On 06/08/2018 10:09 AM, Jarkko Sakkinen wrote: > > > +static __init bool sgx_is_enabled(bool *lc_enabled) > > > { > > > unsigned long fc; > > > > > > @@ -41,12 +4

[PATCH 1/2] jffs2: use 64-bit intermediate timestamps

2018-06-19 Thread Arnd Bergmann
The VFS now uses timespec64 timestamps consistently, but jffs2 still converts them to 32-bit numbers on the storage medium. As the helper functions for the conversion (get_seconds() and timespec_to_timespec64()) are now deprecated, let's change them over to the more modern replacements. This keeps

[PATCH 2/2] jffs2: use unsigned 32-bit timstamps consistently

2018-06-19 Thread Arnd Bergmann
Most users of jffs2 are 32-bit systems that traditionally only support timestamps using a 32-bit signed time_t, in the range from years 1902 to 2038. On 64-bit systems, jffs2 however interpreted the same timestamps as unsigned values, reading back negative times (before 1970) as times between 2038

Re: [PATCH v3 3/8] mm, devm_memremap_pages: Fix shutdown handling

2018-06-19 Thread Logan Gunthorpe
On 19/06/18 12:04 AM, Dan Williams wrote: > Cc: > Fixes: e8d513483300 ("memremap: change devm_memremap_pages interface...") > Cc: Christoph Hellwig > Cc: "Jérôme Glisse" > Reported-by: Logan Gunthorpe > Signed-off-by: Dan Williams Looks good to me. Reviewed-by: Logan Gunthorpe

Re: [PATCH] arm64: mm: mark tramp_pg_dir read-only

2018-06-19 Thread Ard Biesheuvel
On 19 June 2018 at 17:55, Will Deacon wrote: > On Tue, Jun 19, 2018 at 05:51:46PM +0200, Ard Biesheuvel wrote: >> On 19 June 2018 at 17:50, Will Deacon wrote: >> > On Tue, Jun 19, 2018 at 05:40:26PM +0200, Ard Biesheuvel wrote: >> >> On 19 June 2018 at 17:37, Will Deacon wrote: >> >> > On Tue, J

[PATCH] clk: meson: remove obsolete register access

2018-06-19 Thread Jerome Brunet
The legacy method to access the hhi register space is not longer used. We can safely drop it now. Signed-off-by: Jerome Brunet --- drivers/clk/meson/axg.c | 37 ++--- drivers/clk/meson/gxbb.c | 36 ++-- 2 files changed, 4 insertion

[PATCH -tip v6 00/27] kprobes: Cleanup jprobe implementation

2018-06-19 Thread Masami Hiramatsu
Hello, This is the 6th version of the series for removing jprobe. Previous version is here: https://lkml.org/lkml/2018/6/4/681 In this version, I fixed x86 and powerpc kprobe_ftrace_handler to include post-handler emulation code according to Naveen's suggestion. This also simplifies [24/27] a b

[PATCH -tip v6 02/27] kprobes: Remove jprobe API implementation

2018-06-19 Thread Masami Hiramatsu
Remove jprobe API implementations and test cases for those APIs which is no more used. Signed-off-by: Masami Hiramatsu --- Changes in v4: - Cleanup lib/Kconfig.debug description too. Changes in v3: - Remove test cases. --- include/linux/kprobes.h |3 -- kernel/kprobes.c| 78 +

[PATCH -tip v6 03/27] kprobes/x86: Remove jprobe implementation

2018-06-19 Thread Masami Hiramatsu
Remove arch dependent setjump/longjump functions and unused fields in kprobe_ctlblk for jprobes from arch/x86. Signed-off-by: Masami Hiramatsu Cc: Thomas Gleixner Cc: Ingo Molnar Cc: "H. Peter Anvin" Cc: x...@kernel.org --- arch/x86/include/asm/kprobes.h |3 - arch/x86/kernel/kprobes/core

[PATCH -tip v6 05/27] ARM: kprobes: Remove jprobe arm implementation

2018-06-19 Thread Masami Hiramatsu
Remove arch dependent setjump/longjump functions and unused fields in kprobe_ctlblk for jprobes from arch/arm. Signed-off-by: Masami Hiramatsu Cc: Russell King Cc: linux-arm-ker...@lists.infradead.org --- arch/arm/include/asm/kprobes.h |2 - arch/arm/include/asm/probes.h |1 arch/arm/

[PATCH -tip v6 06/27] arm64: kprobes: Remove jprobe implementation

2018-06-19 Thread Masami Hiramatsu
Remove arch dependent setjump/longjump functions and unused fields in kprobe_ctlblk for jprobes from arch/arm64. Signed-off-by: Masami Hiramatsu Acked-by: Will Deacon Cc: Catalin Marinas Cc: linux-arm-ker...@lists.infradead.org --- arch/arm64/include/asm/kprobes.h |1 - arch/arm64/kernel

[PATCH -tip v6 08/27] ia64: kprobes: Remove jprobe implementation

2018-06-19 Thread Masami Hiramatsu
Remove arch dependent setjump/longjump functions and unused fields in kprobe_ctlblk for jprobes from arch/ia64. Note that since ia64 jprobes code a bit different from other arch, this keeps __IA64_BREAK_JPROBE for checking break_handler. It will be removed with break_handler() call afterwards. Si

[PATCH -tip v6 09/27] MIPS: kprobes: Remove jprobe implementation

2018-06-19 Thread Masami Hiramatsu
Remove arch dependent setjump/longjump functions and unused fields in kprobe_ctlblk for jprobes from arch/mips. Signed-off-by: Masami Hiramatsu Cc: Ralf Baechle Cc: James Hogan Cc: linux-m...@linux-mips.org --- arch/mips/include/asm/kprobes.h | 13 --- arch/mips/kernel/kprobes.c

[PATCH -tip v6 10/27] s390/kprobes: Remove jprobe implementation

2018-06-19 Thread Masami Hiramatsu
Remove arch dependent setjump/longjump functions and unused fields in kprobe_ctlblk for jprobes from arch/s390. Signed-off-by: Masami Hiramatsu Cc: Martin Schwidefsky Cc: Heiko Carstens Cc: linux-s...@vger.kernel.org --- arch/s390/include/asm/kprobes.h |2 - arch/s390/kernel/kprobes.c

Re: [PATCH v6 0/3] Directed kmem charging

2018-06-19 Thread Johannes Weiner
Hi Shakeel, this looks generally reasonable to me. However, patch 1 introduces API that isn't used until patch 2 and 3, which makes reviewing harder since you have to jump back and forth between emails. Please fold patch 1 and introduce API along with the users. On Mon, Jun 18, 2018 at 10:13:24P

[PATCH -tip v6 11/27] sh: kprobes: Remove jprobe implementation

2018-06-19 Thread Masami Hiramatsu
Remove arch dependent setjump/longjump functions and unused fields in kprobe_ctlblk for jprobes from arch/sh. Signed-off-by: Masami Hiramatsu Cc: Yoshinori Sato Cc: Rich Felker Cc: linux...@vger.kernel.org --- arch/sh/include/asm/kprobes.h |4 --- arch/sh/kernel/kprobes.c | 51 -

[PATCH -tip v6 12/27] sparc64: kprobes: Remove jprobe implementation

2018-06-19 Thread Masami Hiramatsu
Remove arch dependent setjump/longjump functions and unused fields in kprobe_ctlblk for jprobes from arch/sparc. Signed-off-by: Masami Hiramatsu Cc: "David S. Miller" Cc: sparcli...@vger.kernel.org --- arch/sparc/include/asm/kprobes.h |1 - arch/sparc/kernel/kprobes.c | 47 --

[PATCH -tip v6 13/27] kprobes: Don't check the ->break_handler() in generic kprobes code

2018-06-19 Thread Masami Hiramatsu
Don't check the ->break_handler() from the core kprobes code, because it was only used by jprobes which got removed. ( In followup patches we'll remove the remaining calls in low level arch handlers as well and remove the callback altogether. ) Signed-off-by: Masami Hiramatsu --- Documentatio

[PATCH -tip v6 14/27] kprobes/x86: Don't call ->break_handler() in x86 kprobes

2018-06-19 Thread Masami Hiramatsu
Don't call ->break_handler() and remove break_handler related code from x86 since that was only used by jprobe which got removed. Signed-off-by: Masami Hiramatsu Cc: Thomas Gleixner Cc: Ingo Molnar Cc: "H. Peter Anvin" Cc: x...@kernel.org Cc: linux-kernel@vger.kernel.org --- Changes in v6:

[PATCH -tip v6 16/27] ARM: kprobes: Don't call the ->break_handler() in arm kprobes code

2018-06-19 Thread Masami Hiramatsu
Don't call the ->break_handler() from the arm kprobes code, because it was only used by jprobes which got removed. Signed-off-by: Masami Hiramatsu Cc: Russell King Cc: linux-arm-ker...@lists.infradead.org --- arch/arm/probes/kprobes/core.c | 11 --- 1 file changed, 11 deletions(-) di

[PATCH -tip v6 17/27] arm64: kprobes: Don't call the ->break_handler() in arm64 kprobes code

2018-06-19 Thread Masami Hiramatsu
Don't call the ->break_handler() from the arm64 kprobes code, because it was only used by jprobes which got removed. Signed-off-by: Masami Hiramatsu Acked-by: Will Deacon Cc: Catalin Marinas Cc: linux-arm-ker...@lists.infradead.org --- arch/arm64/kernel/probes/kprobes.c |8 1 file

[PATCH v4 0/5] slimbus: Add QCOM SLIMBus NGD driver

2018-06-19 Thread Srinivas Kandagatla
This patchset adds support to basic version of Qualcomm NGD SLIMBus controller driver found SoCs from B family. This controller is light-weight SLIMBus controller driver responsible for communicating with slave HW directly over the bus using messaging interface, and communicating with master compo

[PATCH -tip v6 19/27] ia64: kprobes: Don't call the ->break_handler() in ia64 kprobes code

2018-06-19 Thread Masami Hiramatsu
Don't call the ->break_handler() from the ia64 kprobes code, because it was only used by jprobes which got removed. Signed-off-by: Masami Hiramatsu Cc: Tony Luck Cc: Fenghua Yu Cc: linux-i...@vger.kernel.org --- arch/ia64/include/uapi/asm/break.h |1 - arch/ia64/kernel/kprobes.c |

[PATCH v4 5/5] slimbus: ngd: Add qcom SLIMBus NGD driver

2018-06-19 Thread Srinivas Kandagatla
This patch adds suppor to Qualcomm SLIMBus Non-Generic Device (NGD) controller driver. This is light-weight SLIMBus controller driver responsible for communicating with slave HW directly over the bus using messaging interface, and communicating with master component residing on ADSP for bandwidth a

[PATCH -tip v6 20/27] MIPS: kprobes: Don't call the ->break_handler() in MIPS kprobes code

2018-06-19 Thread Masami Hiramatsu
Don't call the ->break_handler() from the MIPS kprobes code, because it was only used by jprobes which got removed. Signed-off-by: Masami Hiramatsu Cc: Ralf Baechle Cc: James Hogan Cc: linux-m...@linux-mips.org --- arch/mips/kernel/kprobes.c | 21 +++-- 1 file changed, 7 inse

[PATCH v4 1/5] slimbus: core: add of_slim_device_get() helper

2018-06-19 Thread Srinivas Kandagatla
On SLIMBus controllers like Qcom NGD(non ported device), controller can request logical address once the remote side is powered, having a helper function like this to explicitly enumerate the bus is helpful. Also codec drivers which are taking to interface device would need such a helper too. Sign

[PATCH v4 3/5] slimbus: messaging: add slim_alloc/free_txn_tid()

2018-06-19 Thread Srinivas Kandagatla
This patch adds slim_alloc_txn_tid() and slim_free_txn_tid() api to allow controllers like ngd to allocate tids for user specific commands. This also cleans up the existing code to use single place for tid allocations and free. This patch also make the tid allocation cyclic one, its very useful to

[PATCH v4 4/5] slimbus: ngd: dt-bindings: Add slim ngd dt bindings

2018-06-19 Thread Srinivas Kandagatla
This patch adds bindings for Qualcomm SLIMBus NGD controller. SLIMBus NGD controller is a light-weight driver responsible for communicating with SLIMBus slaves directly over the bus using messaging interface and communicating with master component residing on ADSP for bandwidth and data-channel man

[PATCH -tip v6 22/27] sh: kprobes: Don't call the ->break_handler() in SH kprobes code

2018-06-19 Thread Masami Hiramatsu
Don't call the ->break_handler() from the SH kprobes code, because it was only used by jprobes which got removed. Signed-off-by: Masami Hiramatsu Cc: Yoshinori Sato Cc: Rich Felker Cc: linux...@vger.kernel.org --- arch/sh/kernel/kprobes.c | 14 +- 1 file changed, 1 insertion(+),

[PATCH -tip v6 21/27] s390/kprobes: Don't call the ->break_handler() in s390 kprobes code

2018-06-19 Thread Masami Hiramatsu
Don't call the ->break_handler() from the s390 kprobes code, because it was only used by jprobes which got removed. Signed-off-by: Masami Hiramatsu Cc: Martin Schwidefsky Cc: Heiko Carstens Cc: linux-s...@vger.kernel.org --- arch/s390/kernel/kprobes.c | 20 1 file change

[PATCH v4 2/5] slimbus: core: rearrange slim_eaddr structure

2018-06-19 Thread Srinivas Kandagatla
Rearrange struct slim_eaddr so that the structure is packed correctly to be able to send in SLIMBus messages. Signed-off-by: Srinivas Kandagatla --- include/linux/slimbus.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/include/linux/slimbus.h b/include/linux/sl

[PATCH -tip v6 23/27] sparc64: kprobes: Don't call the ->break_handler() in sparc64 kprobes code

2018-06-19 Thread Masami Hiramatsu
Don't call the ->break_handler() from the sparc64 kprobes code, because it was only used by jprobes which got removed. Signed-off-by: Masami Hiramatsu Cc: "David S. Miller" Cc: sparcli...@vger.kernel.org --- arch/sparc/kernel/kprobes.c | 11 ++- 1 file changed, 2 insertions(+), 9 dele

[PATCH -tip v6 27/27] kprobes: Remove jprobe stub API

2018-06-19 Thread Masami Hiramatsu
Remove jprobe stub APIs from linux/kprobes.h since the jprobe implementation was completely gone. Signed-off-by: Masami Hiramatsu --- include/linux/kprobes.h | 50 --- 1 file changed, 50 deletions(-) diff --git a/include/linux/kprobes.h b/include/li

[PATCH -tip v6 26/27] Documentation: kprobes: Add how to change the execution path

2018-06-19 Thread Masami Hiramatsu
Add a section that explaining how to change the execution path with kprobes and warnings for some arch. Signed-off-by: Masami Hiramatsu Cc: Jonathan Corbet Cc: linux-...@vger.kernel.org --- Documentation/kprobes.txt | 20 1 file changed, 20 insertions(+) diff --git a/Doc

Re: [PATCH] proc: add missing '\0' back to /proc/$pid/cmdline

2018-06-19 Thread kbuild test robot
Hi Michal, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v4.18-rc1 next-20180619] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day

Re: An example of a much more impactful way of doing file system-specific fuzzing

2018-06-19 Thread Dmitry Vyukov
On Mon, Jun 18, 2018 at 7:15 AM, Theodore Y. Ts'o wrote: > I'd like to commend to you the style of bug reports which Wen Xu, > researcher at Georgia Tech has been using. (He's a Ph.D. student, > with an interesting in fuzzing, and he's been very responsive to my > suggestions about how to make hi

Re: [RFC PATCH v3 05/10] sched/topology: Reference the Energy Model of CPUs when available

2018-06-19 Thread Peter Zijlstra
On Tue, Jun 19, 2018 at 02:24:49PM +0100, Quentin Perret wrote: > On Tuesday 19 Jun 2018 at 14:26:32 (+0200), Peter Zijlstra wrote: > > I'm confused by this patch,... what does it do? Why is em_cpu_get() > > (after you fix it) not sufficient? > > Hmm, so maybe the confusing part is that this patc

Re: [PATCH 1/3] mm: memcg: remote memcg charging for kmem allocations

2018-06-19 Thread Johannes Weiner
On Mon, Jun 18, 2018 at 10:13:25PM -0700, Shakeel Butt wrote: > @@ -248,6 +248,30 @@ static inline void memalloc_noreclaim_restore(unsigned > int flags) > current->flags = (current->flags & ~PF_MEMALLOC) | flags; > } > > +#ifdef CONFIG_MEMCG > +static inline struct mem_cgroup *memalloc_me

Re: [alsa-devel] [PATCH] ASoC: qcom: add sdm845 sound card support

2018-06-19 Thread Vinod
Hi Rohit, On 19-06-18, 19:20, Rohit Kumar wrote: > On 6/19/2018 10:35 AM, Vinod wrote: > > On 18-06-18, 16:46, Rohit kumar wrote: > > > > > +struct sdm845_snd_data { > > > + struct snd_soc_card *card; > > > + struct regulator *vdd_supply; > > > + struct snd_soc_dai_link dai_link[]; > > > +}; > >

[PATCH] proc: add missing '\0' back to /proc/$pid/cmdline

2018-06-19 Thread Michal Kubecek
Recent rewrite introduced a regression, /proc/$pid/cmdline is missing the trailing null character: mike@lion:/tmp> cat /proc/self/cmdline | od -t c 000 c a t \0 / p r o c / s e l f / c 020 m d l i n e 026 This is because strnlen() is used to

[PATCH] Staging: comedi: fix operator '=' coding style issue

2018-06-19 Thread Vitor Fernandes Ferreira
Signed-off-by: Vitor Fernandes Ferreira --- drivers/staging/comedi/comedi_fops.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c index 1f3b1106f478..e18b61cdbdeb 100644 --- a/drivers/staging/comed

Re: [PATCH 3/3] fs, mm: account buffer_head to kmemcg

2018-06-19 Thread Johannes Weiner
On Mon, Jun 18, 2018 at 10:13:27PM -0700, Shakeel Butt wrote: > The buffer_head can consume a significant amount of system memory and > is directly related to the amount of page cache. In our production > environment we have observed that a lot of machines are spending a > significant amount of mem

[PATCH v2] proc: add missing '\0' back to /proc/$pid/cmdline

2018-06-19 Thread Michal Kubecek
Recent rewrite introduced a regression, /proc/$pid/cmdline is missing the trailing null character: mike@lion:/tmp> cat /proc/self/cmdline | od -t c 000 c a t \0 / p r o c / s e l f / c 020 m d l i n e 026 This is because strnlen() is used to

Re: [PATCH 1/2] arm64: avoid alloc memory on offline node

2018-06-19 Thread Lorenzo Pieralisi
On Tue, Jun 19, 2018 at 04:35:40PM +0100, Punit Agrawal wrote: > Michal Hocko writes: > > > On Tue 19-06-18 15:54:26, Punit Agrawal wrote: > > [...] > >> In terms of $SUBJECT, I wonder if it's worth taking the original patch > >> as a temporary fix (it'll also be easier to backport) while we work

Re: [PATCH V6 07/38] x86/intel_rdt: Initialize new resource group with sane defaults

2018-06-19 Thread Reinette Chatre
Hi Thomas, On 6/19/2018 5:31 AM, Thomas Gleixner wrote: > On Thu, 7 Jun 2018, Reinette Chatre wrote: >> +/** >> + * cbm_ensure_valid - Enforce validity on provided CBM >> + * @_val: Candidate CBM >> + * @r: RDT resource to which the CBM belongs >> + * >> + * The provided CBM represe

Re: An example of a much more impactful way of doing file system-specific fuzzing

2018-06-19 Thread Mark Rutland
Hi Dmitry, I hope the below doesn't sound like a criticism; I am a *huge* fan of syzkaller. On Tue, Jun 19, 2018 at 06:18:07PM +0200, 'Dmitry Vyukov' via syzkaller wrote: > On Mon, Jun 18, 2018 at 7:15 AM, Theodore Y. Ts'o wrote: > 3. You say "not actionable reports without reproducers", but you

Re: [PATCH] nvme-pci: not invoke nvme_remove_dead_ctrl when change state fails

2018-06-19 Thread Keith Busch
On Tue, Jun 19, 2018 at 04:30:50PM +0800, Jianchao Wang wrote: > There is race between nvme_remove and nvme_reset_work that can > lead to io hang. > > nvme_removenvme_reset_work > -> change state to DELETING >-> fail to change state to LIVE >

Re: [PATCH v2 1/2] platform/x86: asus-wmi: Call led hw_changed API on kbd brightness change

2018-06-19 Thread Daniel Drake
Hi, On Thu, Jun 14, 2018 at 1:58 AM, Chris Chiu wrote: > > On Wed, Jun 13, 2018 at 8:49 PM, Andy Shevchenko > wrote: > > On Mon, Jun 11, 2018 at 10:18 AM, Chris Chiu wrote: > >> Make asus-wmi notify on hotkey kbd brightness changes, listen for > >> brightness events and update the brightness di

Re: An example of a much more impactful way of doing file system-specific fuzzing

2018-06-19 Thread Dmitry Vyukov
On Tue, Jun 19, 2018 at 6:36 PM, Mark Rutland wrote: > Hi Dmitry, > > I hope the below doesn't sound like a criticism; I am a *huge* fan of > syzkaller. > > On Tue, Jun 19, 2018 at 06:18:07PM +0200, 'Dmitry Vyukov' via syzkaller wrote: >> On Mon, Jun 18, 2018 at 7:15 AM, Theodore Y. Ts'o wrote: >

Re: [PATCH v1 1/2] perf/core: Use sysctl to turn on/off dropping leaked kernel samples

2018-06-19 Thread Stephane Eranian
On Fri, Jun 15, 2018 at 12:15 AM Jin, Yao wrote: > > > > On 6/15/2018 1:59 PM, Stephane Eranian wrote: > > On Thu, Jun 14, 2018 at 7:10 PM Jin Yao wrote: > >> > >> When doing sampling, for example: > >> > >> perf record -e cycles:u ... > >> > >> On workloads that do a lot of kernel entry/exits we

Re: [PATCH V6 07/38] x86/intel_rdt: Initialize new resource group with sane defaults

2018-06-19 Thread Thomas Gleixner
On Tue, 19 Jun 2018, Reinette Chatre wrote: > On 6/19/2018 5:31 AM, Thomas Gleixner wrote: > > On Thu, 7 Jun 2018, Reinette Chatre wrote: > >> +static void cbm_ensure_valid(u32 *_val, struct rdt_resource *r) > >> +{ > >> + unsigned long *val = (unsigned long *)_val; > > > > I'm a bit worried abou

Re: [PATCH V5 00/38] Intel(R) Resource Director Technology Cache Pseudo-Locking enabling

2018-06-19 Thread Thomas Gleixner
On Tue, 29 May 2018, Reinette Chatre wrote: > > The last patch of this series depends on the series: > "[RFC PATCH 0/3] Interface for higher order contiguous allocations" > submitted at: > http://lkml.kernel.org/r/2018021056.9735-1-mike.krav...@oracle.com > A new version of this was submitted

[PATCH] ACPI / processor: Finish making acpi_processor_ppc_has_changed() void

2018-06-19 Thread Brian Norris
Commit bca5f557dcea ("ACPI / processor: Make acpi_processor_ppc_has_changed() void") changed one of the declarations of acpi_processor_ppc_has_changed() to return void, but the !CPU_FREQ version still return int. Let's return void to be consistent. Signed-off-by: Brian Norris --- include/acpi/pr

Re: [PATCH 1/2] clk: qcom: drop CLK_SET_RATE_GATE from sdc clocks

2018-06-19 Thread Michael Turquette
Quoting Jerome Brunet (2018-06-19 06:40:50) > the mmci driver (drivers/mmc/host/mmci.c) does the following sequence: > * clk_prepare_enable() > * clk_set_rate() > > on SDCx_clk which is a children of SDCx_src. SDCx_src has > CLK_SET_RATE_GATE so this sequence should not be allowed but this was not

Re: [PATCH 2/2] clk: fix CLK_SET_RATE_GATE with clock rate protection

2018-06-19 Thread Michael Turquette
Quoting Jerome Brunet (2018-06-19 06:40:51) > CLK_SET_RATE_GATE should prevent any operation which may result in a rate > change or glitch while the clock is prepared/enabled. > > IOW, the following sequence is not allowed anymore with CLK_SET_RATE_GATE: > * clk_get() > * clk_prepare_enable() > *

Re: [PATCH v2 1/2] platform/x86: asus-wmi: Call led hw_changed API on kbd brightness change

2018-06-19 Thread Andy Shevchenko
On Tue, Jun 19, 2018 at 7:46 PM, Daniel Drake wrote: >> > Can we avoid those ugly castings? > Now kbd_led_set can continue being a correctly typed function pointer > for led_classdev.brightness_set. And from the code you are adding here > you can call __kbd_led_set directly with signed integer

Re: [PATCH V6 07/38] x86/intel_rdt: Initialize new resource group with sane defaults

2018-06-19 Thread Reinette Chatre
Hi Thomas, On 6/19/2018 9:53 AM, Thomas Gleixner wrote: > On Tue, 19 Jun 2018, Reinette Chatre wrote: >> On 6/19/2018 5:31 AM, Thomas Gleixner wrote: >>> On Thu, 7 Jun 2018, Reinette Chatre wrote: +static void cbm_ensure_valid(u32 *_val, struct rdt_resource *r) +{ + unsigned long *

Re: [PATCH V5 00/38] Intel(R) Resource Director Technology Cache Pseudo-Locking enabling

2018-06-19 Thread Reinette Chatre
Hi Thomas, On 6/19/2018 9:57 AM, Thomas Gleixner wrote: > On Tue, 29 May 2018, Reinette Chatre wrote: >> >> The last patch of this series depends on the series: >> "[RFC PATCH 0/3] Interface for higher order contiguous allocations" >> submitted at: >> http://lkml.kernel.org/r/2018021056.9735-1

Re: [PATCH v4] clk: add duty cycle support

2018-06-19 Thread Michael Turquette
Quoting Jerome Brunet (2018-06-19 07:41:41) > Add the possibility to apply and query the clock signal duty cycle ratio. > > This is useful when the duty cycle of the clock signal depends on some > other parameters controlled by the clock framework. > > For example, the duty cycle of a divider may

Re: [PATCH] kvm: x86: mmu: Add cast to negated bitmasks in update_permission_bitmask()

2018-06-19 Thread Nick Desaulniers
On Tue, Jun 19, 2018 at 8:19 AM Paolo Bonzini wrote: > > On 15/06/2018 20:45, Nick Desaulniers wrote: > >> > >>> In any case I think it it preferable to fix the code over disabling > >>> the warning, unless the warning is bogus or there are just too many > >>> occurrences. > >> Maybe. > > Spurious

Re: [PATCH v4] staging: rts5208: add error handling into rtsx_probe

2018-06-19 Thread Andy Shevchenko
On Tue, Jun 19, 2018 at 6:25 PM, Anton Vasilyev wrote: > If rtsx_probe() fails to allocate dev->chip, then release_everything() > will crash on uninitialized dev->cmnd_ready complete Period is missed at the end. > > Patch adds error handling into rtsx_probe. an error > > Found by Linux Driver

Re: [RFC PATCH v3 05/10] sched/topology: Reference the Energy Model of CPUs when available

2018-06-19 Thread Quentin Perret
On Tuesday 19 Jun 2018 at 18:20:42 (+0200), Peter Zijlstra wrote: > Right, so I would not do that many things at once. Also be more explicit > about what data structure, and why. OK, I can probably split that patch in two smaller patches. One that introduces and enables the static_key (or somethin

Re: [PATCH] kvm: x86: mmu: Add cast to negated bitmasks in update_permission_bitmask()

2018-06-19 Thread Paolo Bonzini
On 19/06/2018 19:08, Nick Desaulniers wrote: >> This one really makes the code uglier though, so I'm not really inclined >> to applying the patch. > Note that of the three variables (w, u, x), only u is used later on. > What about declaring them as negated with the cast, that way there's > no cast

Re: [PATCH] net: nixge: Add __packed attribute to DMA descriptor struct

2018-06-19 Thread Florian Fainelli
On 06/19/2018 09:54 AM, Moritz Fischer wrote: > Add __packed attribute to DMA descriptor structure in order to > make sure that the DMA engine's alignemnt requirements are met. > > Fixes commit 492caffa8a1a ("net: ethernet: nixge: Add support for > National Instruments XGE netdev") > Signed-off-b

Re: [RFC PATCH] ARM: Use logical or instead of addition for badr address calculation

2018-06-19 Thread Guenter Roeck
On Tue, Jun 19, 2018 at 04:12:35PM +0100, Russell King - ARM Linux wrote: > > So, I'm going to continue sitting on the fence on this, and basically > take the attitude that it's better that people don't use the new > binutils until binutils people can provide us with an officially > sanctioned sol

Re: [PATCH v2] proc: add missing '\0' back to /proc/$pid/cmdline

2018-06-19 Thread Alexey Dobriyan
On Tue, Jun 19, 2018 at 06:28:40PM +0200, Michal Kubecek wrote: > Recent rewrite introduced a regression, /proc/$pid/cmdline is missing the > trailing null character: > > mike@lion:/tmp> cat /proc/self/cmdline | od -t c > 000 c a t \0 / p r o c / s e l f / c > 00

Re: [RFC v7 1/1] mconf: global i-search in menu prompts

2018-06-19 Thread Randy Dunlap
Hi Dirk, On 06/17/2018 05:15 AM, Dirk Gouders wrote: > > At any time, at most one i-search is active and the navigation path to > the current menu is displayed in the subtitle, the second line in the > menu window. Nice. And the highlight of the current menu item is also nice when TAB is used t

[PATCH v2] PCI: controller: dwc: Do not let PCIE_DW_PLAT_HOST default to yes

2018-06-19 Thread Geert Uytterhoeven
PCIE_DW_PLAT_HOST does not have any platform dependency, so it should not default to yes. Fixes: 1d906b22076e12cf ("PCI: dwc: Add support for EP mode") Signed-off-by: Geert Uytterhoeven --- v2: - Rebased on top of the big PCI controller move. --- drivers/pci/controller/dwc/Kconfig | 1 - 1 fil

[PATCH 4.4] nvme-pci: initialize queue memory before interrupts

2018-06-19 Thread Ben Hutchings
From: Keith Busch commit 161b8be2bd6abad250d4b3f674bdd5480f15beeb upstream. A spurious interrupt before the nvme driver has initialized the completion queue may inadvertently cause the driver to believe it has a completion to process. This may result in a NULL dereference since the nvmeq's tags

Re: [PATCH] kvm: x86: mmu: Add cast to negated bitmasks in update_permission_bitmask()

2018-06-19 Thread Joe Perches
On Tue, 2018-06-19 at 10:08 -0700, Nick Desaulniers wrote: > On Tue, Jun 19, 2018 at 8:19 AM Paolo Bonzini wrote: > > > > On 15/06/2018 20:45, Nick Desaulniers wrote: > > > > > > > > > In any case I think it it preferable to fix the code over disabling > > > > > the warning, unless the warning i

Re: [RFC PATCH] ARM: Use logical or instead of addition for badr address calculation

2018-06-19 Thread Guenter Roeck
On Tue, Jun 19, 2018 at 03:35:07PM +0200, Ard Biesheuvel wrote: > >> > >> + /* this needs to be a separate macro or \@ does not work correctly > >> */ > >> + .macro __badr, c, rd, sym > >> + .eqv.Lsym\@, \sym > >> + adr\c \rd, .Lsym\@ + 1 > > > > > > Wild shot, but th

Re: [RFC v7 0/1] mconf: global i-search in menu prompts

2018-06-19 Thread Randy Dunlap
On 06/17/2018 05:15 AM, Dirk Gouders wrote: > Hello, > > Most noticeable changes are that the exact starting position before > doing i-search is now remebered and i-search stays on the current item > if a character was added and the new string also matches this item. Nice. > Also, compiler warni

Re: Possible regression in "slab, slub: skip unnecessary kasan_cache_shutdown()"

2018-06-19 Thread Andrey Ryabinin
On 06/19/2018 05:51 AM, Jason A. Donenfeld wrote: > Hello Shakeel, > > It may be the case that f9e13c0a5a33d1eaec374d6d4dab53a4f72756a0 has > introduced a regression. I've bisected a failing test to this commit, > and after staring at the my code for a long time, I'm unable to find a > bug that

Re: [PATCH v10 1/7] x86/tsc: remove tsc_disabled flag

2018-06-19 Thread Thomas Gleixner
On Fri, 15 Jun 2018, Pavel Tatashin wrote: > tsc_disabled is set when notsc is passed as kernel parameter. The reason we > have notsc is to avoid timing problems on multi-socket systems. We already > have a mechanism, however, to detect and resolve these issues by invoking > tsc unstable path. Th

Re: [PATCH] kvm: x86: mmu: Add cast to negated bitmasks in update_permission_bitmask()

2018-06-19 Thread Paolo Bonzini
On 19/06/2018 19:23, Joe Perches wrote: > On Tue, 2018-06-19 at 10:08 -0700, Nick Desaulniers wrote: >> On Tue, Jun 19, 2018 at 8:19 AM Paolo Bonzini wrote: >>> >>> On 15/06/2018 20:45, Nick Desaulniers wrote: > >> In any case I think it it preferable to fix the code over disabling >>

Re: [PATCH 3/3] fs, mm: account buffer_head to kmemcg

2018-06-19 Thread Roman Gushchin
On Tue, Jun 19, 2018 at 12:27:41PM -0400, Johannes Weiner wrote: > On Mon, Jun 18, 2018 at 10:13:27PM -0700, Shakeel Butt wrote: > > The buffer_head can consume a significant amount of system memory and > > is directly related to the amount of page cache. In our production > > environment we have o

Re: [RFC v7 1/1] mconf: global i-search in menu prompts

2018-06-19 Thread Randy Dunlap
On 06/17/2018 05:15 AM, Dirk Gouders wrote: > Signed-off-by: Dirk Gouders > --- > scripts/kconfig/lxdialog/checklist.c | 2 +- > scripts/kconfig/lxdialog/dialog.h| 3 +- > scripts/kconfig/lxdialog/inputbox.c | 2 +- > scripts/kconfig/lxdialog/menubox.c | 181 +---

Re: [PATCH v3 12/12] mfd: cros_ec: Add throttler sub-device

2018-06-19 Thread Matthias Kaehlcke
On Mon, Jun 18, 2018 at 04:21:10PM -0700, Brian Norris wrote: > Hi, > > On Thu, Jun 14, 2018 at 12:47:12PM -0700, Matthias Kaehlcke wrote: > > Instantiate the CrOS EC throttler if it is enabled in the kernel > > configuration. > > > > Signed-off-by: Matthias Kaehlcke > > --- > > Changes in v3: >

Re: [PATCH v1 0/6] perf cs-etm: Fix tracing packet handling and minor refactoring

2018-06-19 Thread Mathieu Poirier
On Sun, 17 Jun 2018 at 23:10, Leo Yan wrote: > > Due the current code is missing to handle cs-etm start tracing packet > and CS_ETM_TRACE_ON packet, we fail to generate branch sample for them. > > This patch series is to fix cs-etm tracing packet handling: > > Patch 0001 is to add invalid address

Re: [PATCH 2/2] sched/fair: Advance global expiration when period timer is restarted

2018-06-19 Thread bsegall
Xunlei Pang writes: > On 6/19/18 2:58 AM, bseg...@google.com wrote: >> Xunlei Pang writes: >> >>> I noticed the group frequently got throttled even it consumed >>> low cpu usage, this caused some jitters on the response time >>> to some of our business containers enabling cpu quota. >>> >>> It'

Re: [PATCH v7 4/4] input/power: Add driver for BD71837/BD71847 PMIC power button

2018-06-19 Thread Dmitry Torokhov
Hi Matti, On Tue, Jun 19, 2018 at 01:57:09PM +0300, Matti Vaittinen wrote: > ROHM BD71837 PMIC power button driver providing power-key press > information to user-space. > > Signed-off-by: Matti Vaittinen > --- > drivers/input/misc/Kconfig | 10 + > drivers/input/misc/Makefile

Re: [PATCH v10 1/7] x86/tsc: remove tsc_disabled flag

2018-06-19 Thread Pavel Tatashin
> > tsc_disabled is set when notsc is passed as kernel parameter. The reason we > > have notsc is to avoid timing problems on multi-socket systems. We already > > have a mechanism, however, to detect and resolve these issues by invoking > > tsc unstable path. Thus, make notsc to behave the same as

Re: [PATCH v3 12/12] mfd: cros_ec: Add throttler sub-device

2018-06-19 Thread Matthias Kaehlcke
Hi Enric, On Tue, Jun 19, 2018 at 10:41:01AM +0200, Enric Balletbo Serra wrote: > Hi Matthias, > > I am also interested on the answer of Brian comments :). One small comment. > > Missatge de Brian Norris del dia dt., 19 de > juny 2018 a les 1:22: > > > > Hi, > > > > On Thu, Jun 14, 2018 at 12:4

RE: [PATCH] x86/hyper-v: use cheaper HVCALL_FLUSH_VIRTUAL_ADDRESS_{LIST,SPACE} hypercalls when possible

2018-06-19 Thread Michael Kelley (EOSG)
> -Original Message- > From: linux-kernel-ow...@vger.kernel.org > On Behalf > Of Vitaly Kuznetsov > Sent: Friday, June 15, 2018 9:30 AM > To: x...@kernel.org > Cc: de...@linuxdriverproject.org; linux-kernel@vger.kernel.org; KY Srinivasan > ; Haiyang Zhang ; Stephen > Hemminger > ; Thomas

Re: [PATCH] objtool: Add machine_real_restart() to the noreturn list

2018-06-19 Thread Matthias Kaehlcke
On Tue, Jun 19, 2018 at 10:47:50AM -0500, Josh Poimboeuf wrote: > machine_real_restart() is annotated as '__noreturn", so add it to the > objtool noreturn list. This fixes the following warning with clang and > CONFIG_CC_OPTIMIZE_FOR_SIZE=y: > > arch/x86/kernel/reboot.o: warning: objtool: > na

Re: [PATCH] kvm: x86: mmu: Add cast to negated bitmasks in update_permission_bitmask()

2018-06-19 Thread Joe Perches
On Tue, 2018-06-19 at 19:35 +0200, Paolo Bonzini wrote: > On 19/06/2018 19:23, Joe Perches wrote: > > On Tue, 2018-06-19 at 10:08 -0700, Nick Desaulniers wrote: > > > On Tue, Jun 19, 2018 at 8:19 AM Paolo Bonzini wrote: > > > > > > > > On 15/06/2018 20:45, Nick Desaulniers wrote: > > > > > > > >

Re: [RFC PATCH] ARM: Use logical or instead of addition for badr address calculation

2018-06-19 Thread Russell King - ARM Linux
On Tue, Jun 19, 2018 at 10:14:24AM -0700, Guenter Roeck wrote: > On Tue, Jun 19, 2018 at 04:12:35PM +0100, Russell King - ARM Linux wrote: > > > > So, I'm going to continue sitting on the fence on this, and basically > > take the attitude that it's better that people don't use the new > > binutils

Re: [PATCH 2/2] mm: set PG_dma_pinned on get_user_pages*()

2018-06-19 Thread John Hubbard
On 06/19/2018 03:41 AM, Jan Kara wrote: > On Tue 19-06-18 02:02:55, Matthew Wilcox wrote: >> On Tue, Jun 19, 2018 at 10:29:49AM +0200, Jan Kara wrote: >>> And for record, the problem with page cache pages is not only that >>> try_to_unmap() may unmap them. It is also that page_mkclean() can >>> wri

Re: uapi headers userspace build results

2018-06-19 Thread Randy Dunlap
On 06/18/2018 06:47 PM, Jayant Chowdhary wrote: > Hi Randy, > > On 06/12/2018 05:07 PM, Randy Dunlap wrote: >> On 06/12/2018 01:39 PM, Jayant Chowdhary wrote: >>> Hi Randy, >>> >>> On 06/11/2018 10:49 PM, Randy Dunlap wrote: Hi, Here is what I have so far. It begins with a makefile

Re: [RFC PATCH] ARM: Use logical or instead of addition for badr address calculation

2018-06-19 Thread Ard Biesheuvel
On 19 June 2018 at 19:24, Guenter Roeck wrote: > On Tue, Jun 19, 2018 at 03:35:07PM +0200, Ard Biesheuvel wrote: >> >> >> >> + /* this needs to be a separate macro or \@ does not work correctly >> >> */ >> >> + .macro __badr, c, rd, sym >> >> + .eqv.Lsym\@, \sym >> >> +

Re: [PATCH v1 0/6] perf cs-etm: Fix tracing packet handling and minor refactoring

2018-06-19 Thread Arnaldo Carvalho de Melo
Em Tue, Jun 19, 2018 at 11:46:02AM -0600, Mathieu Poirier escreveu: > On Sun, 17 Jun 2018 at 23:10, Leo Yan wrote: > > > > Due the current code is missing to handle cs-etm start tracing packet > > and CS_ETM_TRACE_ON packet, we fail to generate branch sample for them. > > > > This patch series is

Re: [RFC PATCH] ARM: Use logical or instead of addition for badr address calculation

2018-06-19 Thread Ard Biesheuvel
On 19 June 2018 at 20:17, Ard Biesheuvel wrote: > On 19 June 2018 at 19:24, Guenter Roeck wrote: >> On Tue, Jun 19, 2018 at 03:35:07PM +0200, Ard Biesheuvel wrote: >>> >> >>> >> + /* this needs to be a separate macro or \@ does not work >>> >> correctly >>> >> */ >>> >> + .macro __b

RE: [PATCH] x86/hyper-v: use cheaper HVCALL_FLUSH_VIRTUAL_ADDRESS_{LIST,SPACE} hypercalls when possible

2018-06-19 Thread KY Srinivasan
> -Original Message- > From: Michael Kelley (EOSG) > Sent: Tuesday, June 19, 2018 10:57 AM > To: Vitaly Kuznetsov ; x...@kernel.org > Cc: de...@linuxdriverproject.org; linux-kernel@vger.kernel.org; KY > Srinivasan ; Haiyang Zhang > ; Stephen Hemminger > ; Thomas Gleixner ; Ingo > Molnar

[RFC PATCH] driver core: add a debugfs entry to show deferred devices

2018-06-19 Thread Javier Martinez Canillas
For debugging purposes it may be useful to know what are the devices whose probe function was deferred. Add a debugfs entry showing that information. $ cat /sys/kernel/debug/deferred_devices 4807.i2c:twl@48:bci musb-hdrc.0.auto omapdrm.0 Signed-off-by: Javier Martinez Canillas ---

Re: [PATCH 3/3] perf stat: Remove duplicate event counting

2018-06-19 Thread Jiri Olsa
On Tue, Jun 19, 2018 at 12:17:06PM -0300, Arnaldo Carvalho de Melo wrote: > Em Fri, Jun 15, 2018 at 10:21:24AM +0200, Jiri Olsa escreveu: > > On Thu, Jun 14, 2018 at 01:48:45PM +0200, Thomas Richter wrote: > > > > SNIP > > > > > +static void perf_pmu_assign_str(char *name, const char *field, char

Re: [RFC PATCH] ARM: Use logical or instead of addition for badr address calculation

2018-06-19 Thread Ard Biesheuvel
On 19 June 2018 at 20:20, Ard Biesheuvel wrote: > On 19 June 2018 at 20:17, Ard Biesheuvel wrote: >> On 19 June 2018 at 19:24, Guenter Roeck wrote: >>> On Tue, Jun 19, 2018 at 03:35:07PM +0200, Ard Biesheuvel wrote: >> >> + /* this needs to be a separate macro or \@ does not work

[RFC PATCH v2] driver core: add a debugfs entry to show deferred devices

2018-06-19 Thread Javier Martinez Canillas
For debugging purposes it may be useful to know what are the devices whose probe function was deferred. Add a debugfs entry showing that information. $ cat /sys/kernel/debug/deferred_devices 4807.i2c:twl@48:bci musb-hdrc.0.auto omapdrm.0 Signed-off-by: Javier Martinez Canillas ---

<    1   2   3   4   5   6   7   8   9   >