Re: [PATCH v2 2/6] Documentation: DT: Add optional 'timeout-sec' property for sp805

2018-05-23 Thread Guenter Roeck
On Wed, May 23, 2018 at 01:32:03PM -0700, Ray Jui wrote: > Update the SP805 binding document to add optional 'timeout-sec' > devicetree property > > Signed-off-by: Ray Jui > Reviewed-by: Scott Branden > Reviewed-by: Guenter Roeck > --- > Documentation/devicetree/bindings/watchdog/arm,sp805.txt

Re: [PATCH] block drivers/block: Use octal not symbolic permissions

2018-05-23 Thread Joe Perches
On Wed, 2018-05-23 at 15:27 -0600, Jens Axboe wrote: > On 5/23/18 2:05 PM, Joe Perches wrote: > > Convert the S_ symbolic permissions to their octal equivalents as > > using octal and not symbolic permissions is preferred by many as more > > readable. > > > > see: https://lkml.org/lkml/2016/8/2/19

linux-next: manual merge of the printk tree with Linus' tree

2018-05-23 Thread Mark Brown
Hi Petr, Today's linux-next merge of the printk tree got a conflict in: lib/vsprintf.c between commit: 85f4f12d51397f164 ("vsprintf: Replace memory barrier with static_key for random_ptr_key update") from Linus' tree and commits: 558594f3c2a5cd65f ("lib/vsprintf: Move pointer_string()

Re: [PATCH v2] ath10k: transmit queued frames after waking queues

2018-05-23 Thread Niklas Cassel
On Wed, May 23, 2018 at 06:25:49PM +0200, Erik Stromdahl wrote: > > > On 05/22/2018 11:15 PM, Niklas Cassel wrote: > > > > > > > > Earlier we observed performance issues in calling push_pending from each > > > tx completion. IMHO this change may introduce the same problem again. > > > > I pre

Re: [PATCH v2] drm/nouveau/secboot: remove VLA usage

2018-05-23 Thread Kees Cook
On Thu, Apr 26, 2018 at 4:25 PM, Kees Cook wrote: > On Thu, Mar 15, 2018 at 7:05 PM, Ben Skeggs wrote: >> On 14 March 2018 at 21:08, Thierry Reding wrote: >>> On Tue, Mar 13, 2018 at 11:24:11AM -0500, Gustavo A. R. Silva wrote: In preparation to enabling -Wvla, remove VLA. In this particula

Re: [PATCH v3] gpio: Remove VLA from stmpe driver

2018-05-23 Thread Kees Cook
On Wed, Mar 28, 2018 at 10:59 AM, Laura Abbott wrote: > The new challenge is to remove VLAs from the kernel > (see https://lkml.org/lkml/2018/3/7/621) > > The number of GPIOs on the supported chips is fairly small > so stack allocate to a known upper bound and spit out a warning > if any new chips

Re: [PATCHv3 2/2] x86/vdso: Add build salt to the vDSO

2018-05-23 Thread Laura Abbott
On 05/22/2018 05:33 PM, Andy Lutomirski wrote: On Tue, May 22, 2018 at 5:19 PM Laura Abbott wrote: The vDSO is linked separately from the kernel and modules. Ensure it picks up the comment section, if available. Did you end up preferring this to just sticking the kernel version in a .commen

Re: [PATCH V2] PCI/portdrv: do not disable device on reboot/shutdown

2018-05-23 Thread Sinan Kaya
On 5/23/2018 5:32 PM, Bjorn Helgaas wrote: > > The crash seems to indicate that the hpsa device attempted a DMA after > we cleared the Root Port's PCI_COMMAND_MASTER, which means > hpsa_shutdown() didn't stop DMA from the device (it looks like *most* > shutdown methods don't disable device DMA, so

Re: [PATCH v2] ppp: remove the PPPIOCDETACH ioctl

2018-05-23 Thread Paul Mackerras
On Wed, May 23, 2018 at 02:37:38PM -0700, Eric Biggers wrote: > From: Eric Biggers > > The PPPIOCDETACH ioctl effectively tries to "close" the given ppp file > before f_count has reached 0, which is fundamentally a bad idea. It > does check 'f_count < 2', which excludes concurrent operations on

Re: linux-next: Tree for May 17

2018-05-23 Thread Mark Brown
On Tue, May 22, 2018 at 03:18:43PM +0100, Mark Brown wrote: > On Thu, May 17, 2018 at 05:06:56PM +1000, Stephen Rothwell wrote: > > > News: I will not be doing any linux-next releases between Friday 18 May > > and Friday 25 May inclusive. > > Just noticed this, I'm going to try to cover starting

Re: INFO: rcu detected stall in corrupted

2018-05-23 Thread Marcelo Ricardo Leitner
On Mon, May 21, 2018 at 11:13:46AM -0700, Eric Dumazet wrote: > > > On 05/21/2018 11:09 AM, David Miller wrote: > > From: syzbot > > Date: Mon, 21 May 2018 11:05:02 -0700 > > > >> find_match+0x244/0x13a0 net/ipv6/route.c:691 > >> find_rr_leaf net/ipv6/route.c:729 [inline] > >> rt6_select net

Re: [PATCH net-next v3] net: sched: don't disable bh when accessing action idr

2018-05-23 Thread Cong Wang
On Wed, May 23, 2018 at 1:52 AM, Vlad Buslov wrote: > Initial net_device implementation used ingress_lock spinlock to synchronize > ingress path of device. This lock was used in both process and bh context. > In some code paths action map lock was obtained while holding ingress_lock. > Commit e1e9

Re: [PATCH] bdi: Move cgroup bdi_writeback to a dedicated low concurrency workqueue

2018-05-23 Thread Tejun Heo
Hello, Rik. On Wed, May 23, 2018 at 06:03:15PM -0400, Rik van Riel wrote: > Dumb question. Does setting max_active to 1 mean > that every cgwb_release_workfn() ends up forcing > another RCU grace period on the whole system, while > today you might have a bunch of them waiting on the > same RCU gr

[REVIEW][PATCH 0/6] Wrapping up the vfs support for unprivileged mounts

2018-05-23 Thread Eric W. Biederman
Very slowly the work has been progressing to ensure the vfs has the necessary support for mounting filesystems without privilege. This patchset contains one more core piece of that work, ensuring a few more operations that would write back an inode and confuse an exisiting filesystem are denied.

[PATCH V4] mlx4_core: allocate ICM memory in page size chunks

2018-05-23 Thread Qing Huang
When a system is under memory presure (high usage with fragments), the original 256KB ICM chunk allocations will likely trigger kernel memory management to enter slow path doing memory compact/migration ops in order to complete high order memory allocations. When that happens, user processes calli

[PATCH] bdi: Increase the concurrecy level of cgwb_release_wq

2018-05-23 Thread Tejun Heo
cgwb_release_wq was added to isolate and limit the concurrency level of cgwb release work items. The max concurrency was set to 1 per CPU but we do want some level of concurrency as otherwise it ends up calling, through bdi_unregister(), synchronize_sched_expedited() back-to-back for each release

[REVIEW][PATCH 2/6] vfs: Allow userns root to call mknod on owned filesystems.

2018-05-23 Thread Eric W. Biederman
These filesystems already always set SB_I_NODEV so mknod will not be useful for gaining control of any devices no matter their permissions. This will allow overlayfs and applications to fakeroot to use device nodes to represent things on disk. Signed-off-by: "Eric W. Biederman" --- fs/namei.c |

[REVIEW][PATCH 1/6] vfs: Don't allow changing the link count of an inode with an invalid uid or gid

2018-05-23 Thread Eric W. Biederman
Changing the link count of an inode via unlink or link will cause a write back of that inode. If the uids or gids are invalid (aka not known to the kernel) writing the inode back may change the uid or gid in the filesystem. To prevent possible filesystem and to avoid the need for filesystem main

[REVIEW][PATCH 5/6] capabilities: Allow privileged user in s_user_ns to set security.* xattrs

2018-05-23 Thread Eric W. Biederman
A privileged user in s_user_ns will generally have the ability to manipulate the backing store and insert security.* xattrs into the filesystem directly. Therefore the kernel must be prepared to handle these xattrs from unprivileged mounts, and it makes little sense for commoncap to prevent writing

[REVIEW][PATCH 4/6] fs: Allow superblock owner to access do_remount_sb()

2018-05-23 Thread Eric W. Biederman
Superblock level remounts are currently restricted to global CAP_SYS_ADMIN, as is the path for changing the root mount to read only on umount. Loosen both of these permission checks to also allow CAP_SYS_ADMIN in any namespace which is privileged towards the userns which originally mounted the file

[REVIEW][PATCH 3/6] fs: Allow superblock owner to replace invalid owners of inodes

2018-05-23 Thread Eric W. Biederman
Allow users with CAP_SYS_CHOWN over the superblock of a filesystem to chown files when inode owner is invalid. Ordinarily the capable_wrt_inode_uidgid check is sufficient to allow access to files but when the underlying filesystem has uids or gids that don't map to the current user namespace it is

[REVIEW][PATCH 6/6] fs: Allow CAP_SYS_ADMIN in s_user_ns to freeze and thaw filesystems

2018-05-23 Thread Eric W. Biederman
From: Seth Forshee The user in control of a super block should be allowed to freeze and thaw it. Relax the restrictions on the FIFREEZE and FITHAW ioctls to require CAP_SYS_ADMIN in s_user_ns. Signed-off-by: Seth Forshee Signed-off-by: Eric W. Biederman --- fs/ioctl.c | 4 ++-- 1 file changed

Re: INFO: task hung in xlog_grant_head_check

2018-05-23 Thread Dave Chinner
On Wed, May 23, 2018 at 09:20:15AM -0700, Eric Biggers wrote: > Now, if you *really* don't want syzbot to report XFS bugs as you believe XFS > contains known unfixable bugs or for other reasons, you can formally ask > Dmitry > to remove CONFIG_XFS_FS from the syzbot config. We haven't said "we do

[REVIEW][PATCH v2 3/6] fs: Allow superblock owner to replace invalid owners of inodes

2018-05-23 Thread Eric W. Biederman
Allow users with CAP_SYS_CHOWN over the superblock of a filesystem to chown files when inode owner is invalid. Ordinarily the capable_wrt_inode_uidgid check is sufficient to allow access to files but when the underlying filesystem has uids or gids that don't map to the current user namespace it i

Bugs involving maliciously crafted file system

2018-05-23 Thread Theodore Y. Ts'o
On Wed, May 23, 2018 at 01:01:59PM -0500, Eric Sandeen wrote: > > What I'm personally hung up on are the bugs where the "exploit" involves > merely > mounting a crafted filesystem that in reality would never (until the heat > death > of the universe) corrupt itself into that state on its own; it

Re: [PATCH] usb: hub: Per-port setting to use old enumeration scheme

2018-05-23 Thread Nicolas Boichat
On Thu, May 24, 2018 at 12:39 AM, Greg Kroah-Hartman wrote: > On Wed, May 23, 2018 at 10:03:55AM -0400, Alan Stern wrote: >> On Wed, 23 May 2018, Nicolas Boichat wrote: >> >> > The "old" enumeration scheme is considerably faster (it takes >> > ~294ms instead of ~439ms to get the descriptor). >> >

Re: [PATCH v2 2/6] Documentation: DT: Add optional 'timeout-sec' property for sp805

2018-05-23 Thread Ray Jui
On 5/23/2018 3:29 PM, Guenter Roeck wrote: On Wed, May 23, 2018 at 01:32:03PM -0700, Ray Jui wrote: Update the SP805 binding document to add optional 'timeout-sec' devicetree property Signed-off-by: Ray Jui Reviewed-by: Scott Branden Reviewed-by: Guenter Roeck --- Documentation/devicetre

Re: [PATCH v5 20/28] fpga: dfl: add fpga bridge platform driver for FME

2018-05-23 Thread Wu Hao
On Wed, May 23, 2018 at 04:06:17PM -0500, Alan Tull wrote: > On Wed, May 23, 2018 at 10:28 AM, Wu Hao wrote: > > On Wed, May 23, 2018 at 10:15:00AM -0500, Alan Tull wrote: > >> On Tue, May 1, 2018 at 9:50 PM, Wu Hao wrote: > >> > >> Hi Hao, > >> > >> > This patch adds fpga bridge platform driver

Notes on locking for pagacache consistency (was: [PATCH 01/10] mm: pagecache add lock)

2018-05-23 Thread Kent Overstreet
On Fri, May 18, 2018 at 01:45:49PM -0400, Kent Overstreet wrote: > On Fri, May 18, 2018 at 08:53:30AM -0700, Christoph Hellwig wrote: > > On Fri, May 18, 2018 at 06:13:06AM -0700, Matthew Wilcox wrote: > > > > Historically, the only problematic case has been direct IO, and people > > > > have been

Re: [PATCHv3 2/2] x86/vdso: Add build salt to the vDSO

2018-05-23 Thread Linus Torvalds
On Wed, May 23, 2018 at 3:53 PM Laura Abbott wrote: > Actually I remember now why this is necessary: there is not a simple way > to encode a string into a linker file as it has to be spit out byte > by byte. I think you can use the "fill" thing to basically add any random data to a section. So

Re: [PATCHv3 2/2] x86/vdso: Add build salt to the vDSO

2018-05-23 Thread Andy Lutomirski
> On May 23, 2018, at 4:55 PM, Linus Torvalds > wrote: > >> On Wed, May 23, 2018 at 3:53 PM Laura Abbott wrote: >> >> Actually I remember now why this is necessary: there is not a simple way >> to encode a string into a linker file as it has to be spit out byte >> by byte. > > I think you c

Re: [PATCH v3] platform: chrome: Add Tablet Switch ACPI driver

2018-05-23 Thread Benson Leung
Hi Gwendal, On Mon, Jan 30, 2017 at 03:47:22PM -0800, Gwendal Grignou wrote: > Add a kernel driver for GOOG0006, an ACPI driver reporting an event when > the tablet switch status changes. > > On an ACPI based convertible chromebook check evtest display tablet mode > switch changes: > Available de

Re: [PATCH v6 5/6] ARM: dts: Renesas RZN1D-DB Board base file

2018-05-23 Thread kbuild test robot
Hi Michel, Thank you for the patch! Yet something to improve: [auto build test ERROR on next-20180517] [also build test ERROR on v4.17-rc6] [cannot apply to robh/for-next renesas-drivers/clk-renesas renesas/devel v4.17-rc6 v4.17-rc5 v4.17-rc4] [if your patch is applied to the wrong git tree, ple

Re: [PATCH 0/5] mm: rework hmm to use devm_memremap_pages

2018-05-23 Thread Jerome Glisse
On Mon, May 21, 2018 at 03:35:14PM -0700, Dan Williams wrote: > Hi Andrew, please consider this series for 4.18. > > For maintainability, as ZONE_DEVICE continues to attract new users, > it is useful to keep all users consolidated on devm_memremap_pages() as > the interface for create "device page

Re: [PATCHv3 2/2] x86/vdso: Add build salt to the vDSO

2018-05-23 Thread Masahiro Yamada
2018-05-24 7:53 GMT+09:00 Laura Abbott : > On 05/22/2018 05:33 PM, Andy Lutomirski wrote: >> >> On Tue, May 22, 2018 at 5:19 PM Laura Abbott wrote: >> >> >>> The vDSO is linked separately from the kernel and modules. Ensure it >>> picks >>> up the comment section, if available. >> >> >> Did you en

[PATCH v3 0/6] Enhance support for the SP805 WDT

2018-05-23 Thread Ray Jui
This patch series enhances the support for the SP805 watchdog timer. First of all, 'timeout-sec' devicetree property is added. In addition, support is also added to allow the driver to reset the watchdog if it has been detected that watchdot has been started in the bootloader. In this case, the dri

[PATCH v3 4/6] watchdog: sp805: set WDOG_HW_RUNNING when appropriate

2018-05-23 Thread Ray Jui
If the watchdog hardware is already enabled during the boot process, when the Linux watchdog driver loads, it should reset the watchdog and tell the watchdog framework. As a result, ping can be generated from the watchdog framework, until the userspace watchdog daemon takes over control Signed-off

[PATCH v3 2/6] Documentation: DT: Add optional 'timeout-sec' property for sp805

2018-05-23 Thread Ray Jui
Update the SP805 binding document to add optional 'timeout-sec' devicetree property Signed-off-by: Ray Jui --- Documentation/devicetree/bindings/watchdog/arm,sp805.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/watchdog/arm,sp805.txt b/Documentation/

[PATCH v3 6/6] arm64: defconfig: add CONFIG_ARM_SP805_WATCHDOG

2018-05-23 Thread Ray Jui
Enable the SP805 watchdog timer Signed-off-by: Ray Jui --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig index ecf6137..3fe5eb5 100644 --- a/arch/arm64/configs/defconfig +++ b/arch/arm64/configs/defcon

[PATCH v3 3/6] watchdog: sp805: add 'timeout-sec' DT property support

2018-05-23 Thread Ray Jui
Add support for optional devicetree property 'timeout-sec'. 'timeout-sec' is used in the driver if specified in devicetree. Otherwise, fall back to driver default, i.e., 60 seconds Signed-off-by: Ray Jui Reviewed-by: Scott Branden Reviewed-by: Guenter Roeck --- drivers/watchdog/sp805_wdt.c | 9

[PATCH v3 5/6] arm64: dt: set initial SR watchdog timeout to 60 seconds

2018-05-23 Thread Ray Jui
Set initial Stingray watchdog timeout to 60 seconds By the time when the userspace watchdog daemon is ready and taking control over, the watchdog timeout will then be reset to what's configured in the daemon Signed-off-by: Ray Jui Reviewed-by: Vladimir Olovyannikov Reviewed-by: Scott Branden -

[PATCH v3 1/6] Documentation: DT: Consolidate SP805 binding docs

2018-05-23 Thread Ray Jui
Consolidate two SP805 binding documents "arm,sp805.txt" and "sp805-wdt.txt" into "arm,sp805.txt" that matches the naming of the desired compatible string to be used Signed-off-by: Ray Jui --- .../devicetree/bindings/watchdog/arm,sp805.txt | 27 ++- .../devicetree/bindings/wat

Re: [PATCH v6 6/6] clk: renesas: Renesas RZ/N1 clock driver

2018-05-23 Thread kbuild test robot
Hi Michel, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on next-20180517] [also build test WARNING on v4.17-rc6] [cannot apply to robh/for-next renesas-drivers/clk-renesas renesas/devel v4.17-rc6 v4.17-rc5 v4.17-rc4] [if your patch is applied to the wrong git t

Re: [REGRESSION] v4.17-rc4: xgalaga fails to start in fullscreen (default) mode

2018-05-23 Thread Vito Caputo
On Wed, May 23, 2018 at 03:27:34PM -0700, Vito Caputo wrote: > On Wed, May 23, 2018 at 02:27:48PM -0700, Vito Caputo wrote: > > On Wed, May 23, 2018 at 11:41:25PM +0300, Ville Syrjälä wrote: > > > On Wed, May 23, 2018 at 01:15:05PM -0700, Vito Caputo wrote: > > > > On Wed, May 23, 2018 at 10:12:22P

[PATCH v8 2/2] drivers: soc: Add LLCC driver

2018-05-23 Thread Rishabh Bhatnagar
LLCC (Last Level Cache Controller) provides additional cache memory in the system. LLCC is partitioned into multiple slices and each slice gets its own priority, size, ID and other config parameters. LLCC driver programs these parameters for each slice. Clients that are assigned to use LLCC need to

[PATCH v8 1/2] dt-bindings: Documentation for qcom, llcc

2018-05-23 Thread Rishabh Bhatnagar
Documentation for last level cache controller device tree bindings, client bindings usage examples. Signed-off-by: Channagoud Kadabi Signed-off-by: Rishabh Bhatnagar Reviewed-by: Evan Green Reviewed-by: Rob Herring --- .../devicetree/bindings/arm/msm/qcom,llcc.txt | 26 ++

[PATCH v8 0/2] SDM845 System Cache Driver

2018-05-23 Thread Rishabh Bhatnagar
This series implements system cache or LLCC(Last Level Cache Controller) driver for SDM845 SOC. The purpose of the driver is to partition the system cache and program the settings such as priortiy, lines to probe while doing a look up in the system cache, low power related settings etc. The partiti

Re: [PATCH v2] drm/nouveau/secboot: remove VLA usage

2018-05-23 Thread Ben Skeggs
On Thu, May 24, 2018 at 8:48 AM, Kees Cook wrote: > On Thu, Apr 26, 2018 at 4:25 PM, Kees Cook wrote: >> On Thu, Mar 15, 2018 at 7:05 PM, Ben Skeggs wrote: >>> On 14 March 2018 at 21:08, Thierry Reding wrote: On Tue, Mar 13, 2018 at 11:24:11AM -0500, Gustavo A. R. Silva wrote: > In pre

Re: [PATCH v2] drm/nouveau/secboot: remove VLA usage

2018-05-23 Thread Kees Cook
On Wed, May 23, 2018 at 5:36 PM, Ben Skeggs wrote: > On Thu, May 24, 2018 at 8:48 AM, Kees Cook wrote: >> On Thu, Apr 26, 2018 at 4:25 PM, Kees Cook wrote: >>> On Thu, Mar 15, 2018 at 7:05 PM, Ben Skeggs wrote: On 14 March 2018 at 21:08, Thierry Reding wrote: > On Tue, Mar 13, 2018 at

Re: Bugs involving maliciously crafted file system

2018-05-23 Thread Dave Chinner
On Wed, May 23, 2018 at 07:41:15PM -0400, Theodore Y. Ts'o wrote: > On Wed, May 23, 2018 at 01:01:59PM -0500, Eric Sandeen wrote: > > > > What I'm personally hung up on are the bugs where the "exploit" involves > > merely > > mounting a crafted filesystem that in reality would never (until the he

Re: [PATCH 1/4] rcu: Speed up calling of RCU tasks callbacks

2018-05-23 Thread Joel Fernandes
On Wed, May 23, 2018 at 01:04:58PM -0700, Paul E. McKenney wrote: > On Wed, May 23, 2018 at 03:13:37PM -0400, Steven Rostedt wrote: > > On Wed, 23 May 2018 10:03:03 -0700 > > "Paul E. McKenney" wrote: > > > > > > > > diff --git a/kernel/rcu/update.c b/kernel/rcu/update.c > > > > > > index 5783bdf

[PATCH] arm64: dt: Update sp805 compatible string

2018-05-23 Thread Ray Jui
The two sp805 binding documents 'arm,sp805.txt' and 'sp805-wdt.txt' are consolidated into 1 ('arm,sp805.txt'), with the compatible string consolidated to "arm,sp805", which are already used in all ARM32 dts and most ARM64 dts files Update the following dtsi to use the consolidated compatible strin

Re: [PATCH 3/4] rcu: Use better variable names in funnel locking loop

2018-05-23 Thread Joel Fernandes
On Wed, May 23, 2018 at 12:23:49PM -0700, Paul E. McKenney wrote: > On Wed, May 23, 2018 at 09:06:17AM -0700, Paul E. McKenney wrote: > > On Tue, May 22, 2018 at 11:38:14PM -0700, Joel Fernandes wrote: > > > From: "Joel Fernandes (Google)" > > > > > > The funnel locking loop in rcu_start_this_gp

Re: [PATCH v5 3/3] dt-bindings: phy-qcom-qmp: Add UFS phy compatible string for sdm845

2018-05-23 Thread cang
On 2018-05-24 00:13, Rob Herring wrote: On Wed, May 23, 2018 at 11:47:12AM +0800, Can Guo wrote: Update the compatible string for UFS QMP PHY on SDM845. Signed-off-by: Can Guo --- Documentation/devicetree/bindings/phy/qcom-qmp-phy.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)

Re: [PATCH] cpufreq: schedutil: Avoid missing updates for one-CPU policies

2018-05-23 Thread Joel Fernandes
On Wed, May 23, 2018 at 11:47:45AM +0200, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > Commit 152db033d775 (schedutil: Allow cpufreq requests to be made > even when kthread kicked) made changes to prevent utilization updates > from being discarded during processing a previous request, b

Proposal

2018-05-23 Thread Miss Zeliha Omer Faruk
Hello Greetings to you please i have a business proposal for you contact me for more detailes asap thanks. Best Regards, Miss.Zeliha ömer faruk Esentepe Mahallesi Büyükdere Caddesi Kristal Kule Binasi No:215 Sisli - Istanbul, Turkey

Re: Bugs involving maliciously crafted file system

2018-05-23 Thread Theodore Y. Ts'o
On Thu, May 24, 2018 at 10:49:31AM +1000, Dave Chinner wrote: > > We've learnt this lesson the hard way over and over again: don't > parse untrusted input in privileged contexts. How many times do we > have to make the same mistakes before people start to learn from > them? Good question. For ho

[PATCH -V2 -mm 0/4] mm, huge page: Copy target sub-page last when copy huge page

2018-05-23 Thread Huang, Ying
From: Huang Ying Huge page helps to reduce TLB miss rate, but it has higher cache footprint, sometimes this may cause some issue. For example, when copying huge page on x86_64 platform, the cache footprint is 4M. But on a Xeon E5 v3 2699 CPU, there are 18 cores, 36 threads, and only 45M LLC (la

[PATCH -V2 -mm 4/4] mm, hugetlbfs: Pass fault address to cow handler

2018-05-23 Thread Huang, Ying
From: Huang Ying This is to take better advantage of the general huge page copying optimization. Where, the target subpage will be copied last to avoid the cache lines of target subpage to be evicted when copying other subpages. This works better if the address of the target subpage is availabl

[PATCH -V2 -mm 1/4] mm, clear_huge_page: Move order algorithm into a separate function

2018-05-23 Thread Huang, Ying
From: Huang Ying In commit c79b57e462b5d ("mm: hugetlb: clear target sub-page last when clearing huge page"), to keep the cache lines of the target subpage hot, the order to clear the subpages in the huge page in clear_huge_page() is changed to clearing the subpage which is furthest from the targ

[PATCH -V2 -mm 3/4] mm, hugetlbfs: Rename address to haddr in hugetlb_cow()

2018-05-23 Thread Huang, Ying
From: Huang Ying To take better advantage of general huge page copying optimization, the target subpage address will be passed to hugetlb_cow(), then copy_user_huge_page(). So we will use both target subpage address and huge page size aligned address in hugetlb_cow(). To distinguish between the

[PATCH -V2 -mm 2/4] mm, huge page: Copy target sub-page last when copy huge page

2018-05-23 Thread Huang, Ying
From: Huang Ying Huge page helps to reduce TLB miss rate, but it has higher cache footprint, sometimes this may cause some issue. For example, when copying huge page on x86_64 platform, the cache footprint is 4M. But on a Xeon E5 v3 2699 CPU, there are 18 cores, 36 threads, and only 45M LLC (la

Re: [PATCH 07/14] powerpc: Add support for restartable sequences

2018-05-23 Thread Michael Ellerman
Mathieu Desnoyers writes: > - On May 23, 2018, at 4:14 PM, Mathieu Desnoyers > mathieu.desnoy...@efficios.com wrote: ... >> >> Hi Boqun, >> >> I tried your patch in a ppc64 le environment, and it does not survive boot >> with CONFIG_DEBUG_RSEQ=y. init gets killed right away. Sorry this co

[PATCH v7 1/8] softirq: reorder trace_softirqs_on to prevent lockdep splat

2018-05-23 Thread Joel Fernandes
From: "Joel Fernandes (Google)" I'm able to reproduce a lockdep splat with config options: CONFIG_PROVE_LOCKING=y, CONFIG_DEBUG_LOCK_ALLOC=y and CONFIG_PREEMPTIRQ_EVENTS=y $ echo 1 > /d/tracing/events/preemptirq/preempt_enable/enable [ 26.112609] DEBUG_LOCKS_WARN_ON(current->softirqs_enabled)

[PATCH v7 0/8] Centralize and unify usage of preempt/irq tracepoints

2018-05-23 Thread Joel Fernandes
From: "Joel Fernandes (Google)" This is the next revision of preempt/irq tracepoint centralization and unified usage across the kernel. The preempt/irq tracepoints exist but not everything in the kernel is using it. This makes things not work simultaneously (for ex, only either lockdep or irqsoff

[PATCH v7 3/8] srcu: Add notrace variant of srcu_dereference

2018-05-23 Thread Joel Fernandes
From: "Joel Fernandes (Google)" In the last patch in this series, we are making lockdep register hooks onto the irq_{disable,enable} tracepoints. These tracepoints use the _rcuidle tracepoint variant. In this series we switch the _rcuidle tracepoint callers to use SRCU instead of sched-RCU. Inord

[PATCH v7 4/8] trace/irqsoff: Split reset into separate functions

2018-05-23 Thread Joel Fernandes
From: "Joel Fernandes (Google)" Split reset functions into seperate functions in preparation of future patches that need to do tracer specific reset. Signed-off-by: Joel Fernandes (Google) --- kernel/trace/trace_irqsoff.c | 22 +++--- 1 file changed, 19 insertions(+), 3 deletio

[PATCH v7 2/8] srcu: Add notrace variants of srcu_read_{lock,unlock}

2018-05-23 Thread Joel Fernandes
From: Paul McKenney This is needed for a future tracepoint patch that uses srcu, and to make sure it doesn't call into lockdep. tracepoint code already calls notrace variants for rcu_read_lock_sched so this patch does the same for srcu which will be used in a later patch. Keeps it consistent wit

[PATCH v7 8/8] kselftests: Add tests for the preemptoff and irqsoff tracers

2018-05-23 Thread Joel Fernandes
From: "Joel Fernandes (Google)" Here we add unit tests for the preemptoff and irqsoff tracer by using a kernel module introduced previously to trigger atomic sections in the kernel. Signed-off-by: Joel Fernandes (Google) --- tools/testing/selftests/ftrace/config | 3 + .../test.d/pree

[PATCH v7 7/8] lib: Add module to simulate atomic sections for testing preemptoff tracers

2018-05-23 Thread Joel Fernandes
From: "Joel Fernandes (Google)" In this patch we introduce a test module for simulating a long atomic section in the kernel which the preemptoff or irqsoff tracers can detect. This module is to be used only for test purposes and is default disabled. Following is the expected output (only briefly

[PATCH v7 5/8] tracepoint: Make rcuidle tracepoint callers use SRCU

2018-05-23 Thread Joel Fernandes
From: "Joel Fernandes (Google)" In recent tests with IRQ on/off tracepoints, a large performance overhead ~10% is noticed when running hackbench. This is root caused to calls to rcu_irq_enter_irqson and rcu_irq_exit_irqson from the tracepoint code. Following a long discussion on the list [1] abou

[PATCH v7 6/8] tracing: Centralize preemptirq tracepoints and unify their usage

2018-05-23 Thread Joel Fernandes
From: "Joel Fernandes (Google)" This patch detaches the preemptirq tracepoints from the tracers and keeps it separate. Advantages: * Lockdep and irqsoff event can now run in parallel since they no longer have their own calls. * This unifies the usecase of adding hooks to an irqsoff and irqson e

Re: [PATCH v2 2/4] drm/mediatek: Add support for mediatek SOC MT2712

2018-05-23 Thread CK Hu
Hi, Stu: On Wed, 2018-05-23 at 17:28 +0800, Stu Hsieh wrote: > On Wed, 2018-05-23 at 13:23 +0800, CK Hu wrote: > > Hi, Stu: > > > > I've some inline comment. > > > > On Wed, 2018-05-23 at 10:25 +0800, Stu Hsieh wrote: > > > This patch add support for the Mediatek MT2712 DISP subsystem. > > > The

[PATCH V3] nvme-rdma: stop queue first before free it in config admin queue

2018-05-23 Thread Jianchao Wang
When any of cases after nvme_rdma_start_queue in nvme_rdma_configure_admin_queue fails, the ctrl->queues[0] will be freed but the NVME_RDMA_Q_LIVE is still set. If nvme_rdma_stop_queue is invoked, we will incur use-after-free which will cause memory corruption. BUG: KASAN: use-after-free in rdma_di

Re: [PATCH v3 net-next 0/2] bpfilter

2018-05-23 Thread Jakub Kicinski
Minor glitch with Ubuntu 18.04: $ gcc --version gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0 In file included from /usr/include/fcntl.h:290:0, from ../net/bpfilter/main.c:7: In function ‘open’, inlined from ‘main’ at ../net/bpfilter/main.c:58:13: /usr/include/x86_64-linux-gnu/bits/fcnt

Re: [PATCH 1/4] rcu: Speed up calling of RCU tasks callbacks

2018-05-23 Thread Steven Rostedt
On Wed, 23 May 2018 17:51:19 -0700 Joel Fernandes wrote: > Shouldn't this assignment be done outside the loop? I believe the variable > will be initialized on each iteration. > > A program like this doesn't terminate: > > #include > > int main() { > for (;;) { > int i = 10;

Re: [PATCHv3 2/2] x86/vdso: Add build salt to the vDSO

2018-05-23 Thread Laura Abbott
On 05/23/2018 05:06 PM, Linus Torvalds wrote: On Wed, May 23, 2018, 17:01 Andy Lutomirski mailto:l...@amacapital.net>> wrote: I don’t know whether I’m missing something obvious, but can’t this be in C? Yes, but I thought Laura wanted to limit it to linker file tricks (this thread has g

Re: [PATCH v1] dma: imx-sdma: add virt-dma support

2018-05-23 Thread Robin Gong
Okay, I'll try to split it. On 三, 2018-05-23 at 19:04 +0530, Vinod wrote: > On 23-05-18, 12:56, s.ha...@pengutronix.de wrote: > > > > > Well, it's somewhat related to virtual dma support, but that's not > > my > > point. My point is that this patch is quite big and thus hard to > > review. > > If

Re: [PATCH] kdump: add default crashkernel reserve kernel config options

2018-05-23 Thread Dave Young
Hi Eric, On 05/23/18 at 10:53am, Eric W. Biederman wrote: > Dave Young writes: > > > [snip] > > > >> > > >> > +config CRASHKERNEL_DEFAULT_THRESHOLD_MB > >> > +int "System memory size threshold for kdump memory default > >> > reserving" > >> > +depends on CRASH_CORE > >> > +

Re: [PATCHv3 2/2] x86/vdso: Add build salt to the vDSO

2018-05-23 Thread Masahiro Yamada
2018-05-24 9:11 GMT+09:00 Masahiro Yamada : > 2018-05-24 7:53 GMT+09:00 Laura Abbott : >> On 05/22/2018 05:33 PM, Andy Lutomirski wrote: >>> >>> On Tue, May 22, 2018 at 5:19 PM Laura Abbott wrote: >>> >>> The vDSO is linked separately from the kernel and modules. Ensure it picks up

[RFC/RFT] [PATCH v2 4/6] cpufreq: intel_pstate: HWP boost performance on IO wakeup

2018-05-23 Thread Srinivas Pandruvada
This change uses SCHED_CPUFREQ_IOWAIT flag to boost HWP performance. Since SCHED_CPUFREQ_IOWAIT flag is set frequently, we don't start boosting steps unless we see two consecutive flags in two ticks. This avoids boosting due to IO because of regular system activities. To avoid synchronization issu

[RFC/RFT] [PATCH v2 5/6] cpufreq: intel_pstate: New sysfs entry to control HWP boost

2018-05-23 Thread Srinivas Pandruvada
A new attribute is added to intel_pstate sysfs to enable/disable HWP dynamic performance boost. Signed-off-by: Srinivas Pandruvada --- drivers/cpufreq/intel_pstate.c | 30 ++ 1 file changed, 30 insertions(+) diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufr

[RFC/RFT] [PATCH v2 2/6] cpufreq: intel_pstate: Add HWP boost utility functions

2018-05-23 Thread Srinivas Pandruvada
Added two utility functions to HWP boost up gradually and boost down to the default cached HWP request values. Boost up: Boost up updates HWP request minimum value in steps. This minimum value can reach upto at HWP request maximum values depends on how frequently, the IOWAIT flag is set. At max, b

[RFC/RFT] [PATCH v2 3/6] cpufreq: intel_pstate: Add update_util_hook for HWP

2018-05-23 Thread Srinivas Pandruvada
When HWP dynamic boost is active then set the HWP specific update util hook. Signed-off-by: Srinivas Pandruvada --- drivers/cpufreq/intel_pstate.c | 21 + 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pst

[RFC/RFT] [PATCH v2 0/6] Intel_pstate: HWP Dynamic performance boost

2018-05-23 Thread Srinivas Pandruvada
v2 This is a much simpler version than the previous one and only consider IO boost, using the existing mechanism. There is no change in this series beyond intel_pstate driver. Once PeterZ finishes his work on frequency invariant, I will revisit thread migration optimization in HWP mode. Other cha

[RFC/RFT] [PATCH v2 6/6] cpufreq: intel_pstate: enable boost for SKX

2018-05-23 Thread Srinivas Pandruvada
Enable HWP boost on Skylake server platform. Signed-off-by: Srinivas Pandruvada --- drivers/cpufreq/intel_pstate.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/cpufreq/intel_pstate.c b/drivers/cpufreq/intel_pstate.c index b2613c9775d5..6f8214a40764 100644 --- a/drivers/cp

Re: [PATCH] kdump: add default crashkernel reserve kernel config options

2018-05-23 Thread Dave Young
Hi Petr, On 05/23/18 at 10:22pm, Petr Tesarik wrote: > On Wed, 23 May 2018 10:53:55 -0500 > ebied...@xmission.com (Eric W. Biederman) wrote: > > > Dave Young writes: > > > > > [snip] > > > > > >> > > > >> > +config CRASHKERNEL_DEFAULT_THRESHOLD_MB > > >> > + int "System memory size thr

[RFC/RFT] [PATCH v2 1/6] cpufreq: intel_pstate: Cache last HWP capability/request value

2018-05-23 Thread Srinivas Pandruvada
Store the HWP request value last set using MSR_HWP_REQUEST. This will allow us to save cycles used for reading last HWP request value for dynamic update of MSR_HWP_REQUEST. Also store HWP capability MSR value in local memory, to avoid reading MSR later for calculating limits for dynamic update of M

Re: BUG: scsi/qla2xxx: BUG_ON(blk_queued_rq(req) is triggered in blk_finish_request

2018-05-23 Thread jianchao.wang
Would anyone please take a look at this ? Thanks in advance Jianchao On 05/23/2018 11:55 AM, jianchao.wang wrote: > > > Hi all > > Our customer met a panic triggered by BUG_ON in blk_finish_request. >>From the dmesg log, the BUG_ON was triggered after command abort occurred >>many times. > Th

Re: [PATCH 10/13] atomics/powerpc: define atomic64_fetch_add_unless()

2018-05-23 Thread Michael Ellerman
Hi Mark, Mark Rutland writes: > As a step towards unifying the atomic/atomic64/atomic_long APIs, this > patch converts the arch/powerpc implementation of atomic64_add_unless() > into an implementation of atomic64_fetch_add_unless(). > > A wrapper in will build atomic_add_unless() atop of > this,

Re: [PATCH v3 net-next 0/2] bpfilter

2018-05-23 Thread Jakub Kicinski
On Wed, 23 May 2018 18:33:52 -0700, Jakub Kicinski wrote: > Minor glitch with Ubuntu 18.04: > > $ gcc --version > gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0 > > In file included from /usr/include/fcntl.h:290:0, > from ../net/bpfilter/main.c:7: > In function ‘open’, > inlined from ‘ma

Re: [PATCH 01/12] perf/breakpoint: Split attribute parse and commit

2018-05-23 Thread Michael Ellerman
Frederic Weisbecker writes: > diff --git a/kernel/events/hw_breakpoint.c b/kernel/events/hw_breakpoint.c > index 6e28d28..51320c2 100644 > --- a/kernel/events/hw_breakpoint.c > +++ b/kernel/events/hw_breakpoint.c > @@ -424,19 +443,22 @@ static int validate_hw_breakpoint(struct perf_event *bp) >

Re: [PATCHv3 2/2] x86/vdso: Add build salt to the vDSO

2018-05-23 Thread Masahiro Yamada
2018-05-23 9:19 GMT+09:00 Laura Abbott : > > The vDSO is linked separately from the kernel and modules. Ensure it picks > up the comment section, if available. > > Signed-off-by: Laura Abbott > --- > v3: Invoke the generated linker script. The ".." nightmare is pretty > ugly but I didn't see an ea

Re: [PATCH v2 2/5] gpio: syscon: Add gpio-syscon for rockchip

2018-05-23 Thread Levin Du
Hi all, I'd like to quote reply of Robin Murphy at  http://lists.infradead.org/pipermail/linux-rockchip/2018-May/020619.html I would suggest s/pin number/bit number in the associated GRF register/ here. At least in this RK3328 case there's only one pin, which isn't numbered, and if you naively

Re: [PATCH 04/12] powerpc: Implement hw_breakpoint_arch_parse()

2018-05-23 Thread Michael Ellerman
Frederic Weisbecker writes: > diff --git a/arch/powerpc/kernel/hw_breakpoint.c > b/arch/powerpc/kernel/hw_breakpoint.c > index 348cac9..fba6527 100644 > --- a/arch/powerpc/kernel/hw_breakpoint.c > +++ b/arch/powerpc/kernel/hw_breakpoint.c > @@ -139,30 +139,31 @@ int arch_bp_generic_fields(int ty

Re: [PATCH v3 net-next 0/2] bpfilter

2018-05-23 Thread Alexei Starovoitov
On 5/23/18 6:50 PM, Jakub Kicinski wrote: On Wed, 23 May 2018 18:33:52 -0700, Jakub Kicinski wrote: Minor glitch with Ubuntu 18.04: $ gcc --version gcc (Ubuntu 7.3.0-16ubuntu3) 7.3.0 In file included from /usr/include/fcntl.h:290:0, from ../net/bpfilter/main.c:7: In function ‘

Re: [PATCH] printk: inject caller information into the body of message

2018-05-23 Thread Sergey Senozhatsky
On (05/18/18 14:15), Petr Mladek wrote: > > Dunno... > > For instance, can we store context tracking info as a extended record > > data? We have that dict/dict_len thing. So may we can store tracking > > info there? Extended records will appear on the serial console /* if > > console supports exten

Re: [PATCHv3 2/2] x86/vdso: Add build salt to the vDSO

2018-05-23 Thread Laura Abbott
On 05/23/2018 06:43 PM, Masahiro Yamada wrote: 2018-05-24 9:11 GMT+09:00 Masahiro Yamada : 2018-05-24 7:53 GMT+09:00 Laura Abbott : On 05/22/2018 05:33 PM, Andy Lutomirski wrote: On Tue, May 22, 2018 at 5:19 PM Laura Abbott wrote: The vDSO is linked separately from the kernel and modules.

Re: [PATCH] printk: inject caller information into the body of message

2018-05-23 Thread Sergey Senozhatsky
On (05/18/18 15:08), Dmitry Vyukov wrote: [..] > >> What consoles do support it? > >> We are interested at least in qemu console, GCE console and Android > >> phone consoles. But it would be pity if this can't be used on various > >> development boards too. > > > > Only the netconsole is able to sh

net/ipv4/netfilter/nft_chain_nat_ipv4.c:39: undefined reference to `nft_do_chain'

2018-05-23 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: bee797529d7c1ea4e2803fda067d20edbc00bc3d commit: 02c7b25e5f54321b9063e18d4f52cce07f8e081d netfilter: nf_tables: build-in filter chain type date: 8 weeks ago config: x86_64-randconfig-s0-05240812 (attached

<    5   6   7   8   9   10   11   >