Re: [PATCH v3 1/4] rcu: Add comment documenting how rcu_seq_snap works

2018-05-20 Thread Randy Dunlap
On 05/20/2018 09:42 PM, Joel Fernandes wrote: > rcu_seq_snap may be tricky to decipher. Lets document how it works with > an example to make it easier. > > Signed-off-by: Joel Fernandes (Google) > --- > kernel/rcu/rcu.h | 33 - > 1 file changed, 32 insertions(+),

Re: [PATCH v2 5/5] kconfig: refactor ncurses package checks for building nconf

2018-05-20 Thread Randy Dunlap
On 05/20/2018 09:48 PM, Masahiro Yamada wrote: > 2018-05-21 8:41 GMT+09:00 Randy Dunlap : >> On 05/20/2018 01:16 AM, Masahiro Yamada wrote: >>> Building nconf requires ncurses, but its presence is not checked. >>> Check and configure necessary packages by a shell script like the >>> other GUI front

Re: [PATCH v2] gpu: drm: udl: Adding new typedef vm_fault_t

2018-05-20 Thread Souptick Joarder
On Thu, May 10, 2018 at 7:18 PM, Souptick Joarder wrote: > On Wed, Apr 25, 2018 at 10:29 AM, Souptick Joarder > wrote: >> Use new return type vm_fault_t for fault and huge_fault >> handler. For now, this is just documenting that the >> function returns a VM_FAULT value rather than an errno. >> O

Re: [PATCH v2 5/5] kconfig: refactor ncurses package checks for building nconf

2018-05-20 Thread Masahiro Yamada
2018-05-21 13:51 GMT+09:00 Randy Dunlap : > On 05/20/2018 09:48 PM, Masahiro Yamada wrote: >> 2018-05-21 8:41 GMT+09:00 Randy Dunlap : >>> On 05/20/2018 01:16 AM, Masahiro Yamada wrote: Building nconf requires ncurses, but its presence is not checked. Check and configure necessary package

Re: [PATCH] cpufreq: Add Kryo CPU scaling driver

2018-05-20 Thread Viresh Kumar
More comments after Russell's reply. On 19-05-18, 14:35, Ilia Lin wrote: > +static int __init qcom_cpufreq_kryo_driver_init(void) > +{ > + struct device *cpu_dev_silver, *cpu_dev_gold; > + struct opp_table *opp_silver, *opp_gold; > + enum _msm8996_version msm8996_version; > + struc

Re: [PATCH v2] schedutil: Allow cpufreq requests to be made even when kthread kicked

2018-05-20 Thread Viresh Kumar
On 18-05-18, 11:55, Joel Fernandes (Google.) wrote: > From: "Joel Fernandes (Google)" > > Currently there is a chance of a schedutil cpufreq update request to be > dropped if there is a pending update request. This pending request can > be delayed if there is a scheduling delay of the irq_work an

Re: [PATCH v4 07/31] kconfig: add built-in function support

2018-05-20 Thread Masahiro Yamada
Sam, 2018-05-20 23:50 GMT+09:00 Sam Ravnborg : > On Thu, May 17, 2018 at 03:16:46PM +0900, Masahiro Yamada wrote: >> This commit adds a new concept 'function' to do more text processing >> in Kconfig. >> >> A function call looks like this: >> >> $(function,arg1,arg2,arg3,...) >> >> This commit a

Re: [PATCH v4 05/31] kconfig: remove string expansion for mainmenu after yyparse()

2018-05-20 Thread Masahiro Yamada
2018-05-20 23:39 GMT+09:00 Sam Ravnborg : >> @@ -544,10 +530,10 @@ void conf_parse(const char *name) >> if (!modules_sym) >> modules_sym = sym_find( "n" ); >> >> - tmp = rootmenu.prompt->text; >> - rootmenu.prompt->text = _(rootmenu.prompt->text); >> - rootmenu.prom

Re: [Xen-devel] [RFC 1/3] xen/balloon: Allow allocating DMA buffers

2018-05-20 Thread Oleksandr Andrushchenko
On 05/19/2018 01:04 AM, Boris Ostrovsky wrote: On 05/17/2018 04:26 AM, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko A commit message would be useful. Sure, v1 will have it Signed-off-by: Oleksandr Andrushchenko for (i = 0; i < nr_pages; i++) { - pag

Re: [PATCH v2 03/11] cpufreq: tegra20: Clean up included headers

2018-05-20 Thread Viresh Kumar
On 18-05-18, 23:06, Dmitry Osipenko wrote: > Remove unused/unneeded headers and sort them in the alphabet order. > > Signed-off-by: Dmitry Osipenko > Acked-by: Thierry Reding > --- > drivers/cpufreq/tegra20-cpufreq.c | 12 > 1 file changed, 4 insertions(+), 8 deletions(-) > > diff

Re: [Xen-devel][RFC 2/3] xen/grant-table: Extend API to work with DMA buffers

2018-05-20 Thread Oleksandr Andrushchenko
On 05/19/2018 01:19 AM, Boris Ostrovsky wrote: On 05/17/2018 04:26 AM, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko Signed-off-by: Oleksandr Andrushchenko --- drivers/xen/grant-table.c | 49 +++ include/xen/grant_table.h | 7 ++ 2 f

Re: [PATCH v2 07/11] cpufreq: tegra20: Remove unnecessary parentheses

2018-05-20 Thread Viresh Kumar
On 18-05-18, 23:06, Dmitry Osipenko wrote: > Remove unnecessary parentheses as suggested by the checkpatch script. > > Signed-off-by: Dmitry Osipenko > --- > drivers/cpufreq/tegra20-cpufreq.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cpufreq/tegra20-cpufre

[PATCH RESEND] platform/chrome: cros_ec_lpc: Add support for newer Google devices using custom coreboot firmware or stock SeaBIOS.

2018-05-20 Thread Vittorio Gambaletta (VittGam)
Custom coreboot firmware does not contain "Google_*" as BIOS version string; also, booting through stock SeaBIOS will present an empty BIOS version string to Linux. So the generic match at the top would not work. A previous patch added the "GOOGLE" match for DMI system vendor, but newer machines s

Re: [PATCH v3 1/4] rcu: Add comment documenting how rcu_seq_snap works

2018-05-20 Thread Joel Fernandes
On Sun, May 20, 2018 at 09:50:25PM -0700, Randy Dunlap wrote: > On 05/20/2018 09:42 PM, Joel Fernandes wrote: > > rcu_seq_snap may be tricky to decipher. Lets document how it works with > > an example to make it easier. > > > > Signed-off-by: Joel Fernandes (Google) > > --- > > kernel/rcu/rcu.h

RE: [PATCH] kernfs: fix dentry unexpected skip

2018-05-20 Thread Hatayama, Daisuke
> -Original Message- > From: linux-kernel-ow...@vger.kernel.org > [mailto:linux-kernel-ow...@vger.kernel.org] On Behalf Of Hatayama, Daisuke > Sent: Saturday, May 19, 2018 12:43 AM > To: 'gre...@linuxfoundation.org' > Cc: Okajima, Toshiyuki/岡嶋 寿行 ; > linux-kernel@vger.kernel.org; 'ebied.

Re: [PATCH v2 0/2] Add support for QCOM cpufreq FW driver

2018-05-20 Thread Viresh Kumar
On 19-05-18, 23:04, Taniya Das wrote: > [v2] >* Address comments given in v0 series. That's not how you do it. You need to explain every change in enough detail here so that the reviewers don't need to go to their previous emails to see what changed. > [v1] > * Fixed compilation reporte

Re: WARNING in ext4_set_page_dirty

2018-05-20 Thread syzbot
syzbot has found a reproducer for the following crash on: HEAD commit:771c577c23ba Linux 4.17-rc6 git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=108c9f3780 kernel config: https://syzkaller.appspot.com/x/.config?x=982e2df1b9e60b02 dashboard link: https:

[next-20180517][ppc] watchdog: CPU 88 self-detected hard LOCKUP @ update_cfs_group+0x30/0x150

2018-05-20 Thread Abdul Haleem
Greeting's Offlate we are seeing hard hard lockup trace messages on our powerpc bare-metal machine for both linux-next and mainline kernel Machine Type: Power 8 Bare-metal (minsky) kernel: 4.17.0-rc5-next-20180517 gcc: 4.8.5 config: attached test: the exact scenario which is triggering these trac

Re: [PATCH v4 07/31] kconfig: add built-in function support

2018-05-20 Thread Sam Ravnborg
Hi Masahiro > >> + char *(*func)(int argc, char *argv[], int old_argc, char > >> *old_argv[]); > >> +}; > > If a typedef was provided for the function then ... > > > Yes, I can do this, > but I may rather consider to simplify the code. Simplify is better. > > Will the following be equal:

Re: [PATCH] Revert "mm/cma: manage the memory of the CMA area by using the ZONE_MOVABLE"

2018-05-20 Thread Joonsoo Kim
On Sat, May 19, 2018 at 05:46:32PM +0300, Ville Syrjälä wrote: > On Fri, May 18, 2018 at 01:01:04PM +0900, Joonsoo Kim wrote: > > On Thu, May 17, 2018 at 10:53:32AM -0700, Laura Abbott wrote: > > > On 05/17/2018 10:08 AM, Michal Hocko wrote: > > > >On Thu 17-05-18 18:49:47, Michal Hocko wrote: > >

Re: [PATCH v3 1/4] rcu: Add comment documenting how rcu_seq_snap works

2018-05-20 Thread Randy Dunlap
On 05/20/2018 10:48 PM, Joel Fernandes wrote: > --8<-- > > From 1c1f8ce04bca656a3c07e555048545d4a59e44cf Mon Sep 17 00:00:00 2001 > From: Joel Fernandes > Date: Sun, 20 May 2018 19:37:18 -0700 > Subject: [PATCH v3.5] rcu: Add comment documenting how rcu_seq_snap works > > rcu_se

Re: [PATCH v2 5/5] kconfig: refactor ncurses package checks for building nconf

2018-05-20 Thread Randy Dunlap
On 05/20/2018 09:58 PM, Masahiro Yamada wrote: > 2018-05-21 13:51 GMT+09:00 Randy Dunlap : >> On 05/20/2018 09:48 PM, Masahiro Yamada wrote: >>> 2018-05-21 8:41 GMT+09:00 Randy Dunlap : On 05/20/2018 01:16 AM, Masahiro Yamada wrote: > Building nconf requires ncurses, but its presence is no

Re: [PATCH v4 07/31] kconfig: add built-in function support

2018-05-20 Thread Masahiro Yamada
Hi Sam, 2018-05-21 15:16 GMT+09:00 Sam Ravnborg : > Hi Masahiro > >> >> + char *(*func)(int argc, char *argv[], int old_argc, char >> >> *old_argv[]); >> >> +}; >> > If a typedef was provided for the function then ... >> >> >> Yes, I can do this, >> but I may rather consider to simplify the

Re: [PATCH 5/6] mtd: rawnand: ams-delta: use GPIO lookup table

2018-05-20 Thread Andy Shevchenko
On Sun, May 20, 2018 at 8:25 PM, Miquel Raynal wrote: > On Sun, 20 May 2018 19:17:04 +0300, Andy Shevchenko > wrote: > Do we actually have the possibility to rename this gpio? I guess no > since it would break DT backward compatibility. No we don't. > Otherwise it would have > been more descri

Re: [PATCH v2] isdn: eicon: fix a missing-check bug

2018-05-20 Thread Wenwen Wang
On Sun, May 20, 2018 at 5:37 PM, David Miller wrote: > From: Wenwen Wang > Date: Fri, 18 May 2018 16:33:47 -0500 > >> In divasmain.c, the function divas_write() firstly invokes the function >> diva_xdi_open_adapter() to open the adapter that matches with the adapter >> number provided by the user

Re: [next-20180517][ppc] watchdog: CPU 88 self-detected hard LOCKUP @ update_cfs_group+0x30/0x150

2018-05-20 Thread Nicholas Piggin
Ah, it's POWER8. I'm betting we have a bug with nohz timer offloading somewhere. I *think* we may have seen similar on P9 as well, but that may be related to problems with stop states. Can you reproduce it easily? I'm thinking maybe adding some tracepoints that track decrementer settings and int

[PATCH v3] isdn: eicon: fix a missing-check bug

2018-05-20 Thread Wenwen Wang
In divasmain.c, the function divas_write() firstly invokes the function diva_xdi_open_adapter() to open the adapter that matches with the adapter number provided by the user, and then invokes the function diva_xdi_write() to perform the write operation using the matched adapter. The two functions d

<    1   2   3   4