Re: [PATCH v9 15/24] mm: Introduce __vm_normal_page()

2018-04-04 Thread Laurent Dufour
On 03/04/2018 21:39, Jerome Glisse wrote: > On Tue, Mar 13, 2018 at 06:59:45PM +0100, Laurent Dufour wrote: >> When dealing with the speculative fault path we should use the VMA's field >> cached value stored in the vm_fault structure. >> >> Currently vm_normal_page() is using the pointer to the

Re: [GIT PULL] Kernel lockdown for secure boot

2018-04-04 Thread Matthew Garrett
On Tue, Apr 3, 2018 at 11:56 PM Peter Dolding wrote: > On Wed, Apr 4, 2018 at 11:13 AM, Matthew Garrett wrote: > > There are four cases: > > > > Verified Boot off, lockdown off: Status quo in distro and mainline kernels > > Verified Boot off, lockdown on: Perception of security improvement that'

Re: [RFC][PATCH] tracing, printk: Force no hashing when trace_printk() is used

2018-04-04 Thread Kees Cook
On Wed, Apr 4, 2018 at 12:49 AM, Peter Zijlstra wrote: > On Tue, Apr 03, 2018 at 05:06:12PM -0400, Steven Rostedt wrote: >> If you are concerned about attack surface, I could make it a bit more >> difficult to tweak by malicious software. What about the patch below? >> It would be much more diffic

[PATCH] lib: fix stall in __bitmap_parselist()

2018-04-04 Thread Yury Norov
syzbot is catching stalls at __bitmap_parselist() [1]. The trigger is unsigned long v = 0; bitmap_parselist("7:,", &v, BITS_PER_LONG); which results in hitting infinite loop at while (a <= b) { off = min(b - a + 1, used_size); bitmap_set(maskp, a, off);

Re: [PATCH] sched/rt: Fix rq->clock_update_flags < RQCF_ACT_SKIP warning

2018-04-04 Thread Davidlohr Bueso
On Mon, 02 Apr 2018, Davidlohr Bueso wrote: The case for the rt task throttling (which this workload also hits) can be ignored in that the skip_update call is actually bogus and quite the contrary (the request bits are removed/reverted). While at it, how about this trivial patch? 8<

Re: [PATCH v2] tools: fix cross-compile var clobbering

2018-04-04 Thread Martin Kelly
On 04/04/2018 06:20 AM, Jiri Slaby wrote: On 01/07/2018, 10:40 PM, Martin Kelly wrote: From: Martin Kelly ... --- a/tools/power/acpi/Makefile.config +++ b/tools/power/acpi/Makefile.config @@ -56,9 +56,6 @@ INSTALL_SCRIPT = ${INSTALL_PROGRAM} # to compile vs uClibc, that can be done here as

[PATCH] tools: restore READ_ONCE() C++ compatibility

2018-04-04 Thread Mark Rutland
Our userspace defines READ_ONCE() in a way that clang doesn't like, as we have an anonymous union in which neither field is initialized. WRITE_ONCE() is fine since it initializes the __val field. For READ_ONCE() we can keep clang and GCC happy with a dummy initialization of the __c field, so let'

Re: An actual suggestion (Re: [GIT PULL] Kernel lockdown for secure boot)

2018-04-04 Thread Andy Lutomirski
On Wed, Apr 4, 2018 at 9:17 AM, David Howells wrote: > Andy Lutomirski wrote: > >> Since this thread has devolved horribly, I'm going to propose a solution. >> >> 1. Split the "lockdown" state into three levels: (please don't >> bikeshed about the names right now.) >> >> LOCKDOWN_NONE: normal be

Re: v4.16+ seeing many unaligned access in dequeue_task_fair() on IA64

2018-04-04 Thread Luck, Tony
On Wed, Apr 04, 2018 at 09:25:13AM +0200, Peter Zijlstra wrote: > Right, I remember being careful with that. Which again brings me to the > RANDSTRUCT thing, which will mess that up. No RANDSTRUCT config options set for my build. > Does the below cure things? It makes absolutely no difference for

Re: [PATCH] sched/rt: Fix rq->clock_update_flags < RQCF_ACT_SKIP warning

2018-04-04 Thread Peter Zijlstra
On Wed, Apr 04, 2018 at 09:15:39AM -0700, Davidlohr Bueso wrote: > On Mon, 02 Apr 2018, Davidlohr Bueso wrote: > > > The case for the rt task throttling (which this workload also hits) can be > > ignored in > > that the skip_update call is actually bogus and quite the contrary (the > > request b

Re: [GIT PULL] Kernel lockdown for secure boot

2018-04-04 Thread Andy Lutomirski
On Wed, Apr 4, 2018 at 9:22 AM, Matthew Garrett wrote: > On Wed, Apr 4, 2018 at 6:52 AM Theodore Y. Ts'o wrote: > >> On Wed, Apr 04, 2018 at 02:33:37PM +0100, David Howells wrote: >> > Theodore Y. Ts'o wrote: >> > >> > > Whoa. Why doesn't lockdown prevent kexec? Put another away, why >> > > is

Re: [GIT PULL] Kernel lockdown for secure boot

2018-04-04 Thread Matthew Garrett
On Wed, Apr 4, 2018 at 9:39 AM Andy Lutomirski wrote: > On Wed, Apr 4, 2018 at 9:22 AM, Matthew Garrett wrote: > > If you don't have secure boot then an attacker with root can modify your > > bootloader or kernel, and on next boot lockdown can be silently disabled. > This has been rebutted over

Re: [PATCH] w1: gpio: fix problem with platfom data in w1-gpio

2018-04-04 Thread Paweł Dembicki
2018-03-29 12:01 GMT+02:00 Greg Kroah-Hartman : > On Thu, Mar 29, 2018 at 11:47:25AM +0200, Paweł Dembicki wrote: >> 2018-03-17 12:55 GMT+01:00 Greg Kroah-Hartman : >> >> > Where is this patch supposed to go? Is this a stable backport patch, or >> > something to go into Linus's tree? >> >> I teste

[GIT PULL] RISC-V changes for 4.17

2018-04-04 Thread Palmer Dabbelt
The following changes since commit 0adb32858b0bddf4ada5f364a84ed60b196dbcda: Linux 4.16 (2018-04-01 14:20:27 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/palmer/riscv-linux.git tags/riscv-for-linus-4.17-mw0 for you to fetch changes up to f6a1

Re: [GIT PULL] Kernel lockdown for secure boot

2018-04-04 Thread Justin Forbes
On Wed, Apr 4, 2018 at 11:39 AM, Andy Lutomirski wrote: > On Wed, Apr 4, 2018 at 9:22 AM, Matthew Garrett wrote: >> On Wed, Apr 4, 2018 at 6:52 AM Theodore Y. Ts'o wrote: >> >>> On Wed, Apr 04, 2018 at 02:33:37PM +0100, David Howells wrote: >>> > Theodore Y. Ts'o wrote: >>> > >>> > > Whoa. Why

Re: [PATCH 2/4] nvmet-rdma: Use new SGL alloc/free helper for requests

2018-04-04 Thread Logan Gunthorpe
On 4/4/2018 6:43 AM, Sagi Grimberg wrote: IIRC, this might result in nvmet-rdma executing data-transfer even for failed requests in some error cases. I'm not sure this is the only case, but have you tested what happens in error cases? That's why I set transfer_len to zero when we exit this func

Re: [RFC][PATCH] tracing, printk: Force no hashing when trace_printk() is used

2018-04-04 Thread Steven Rostedt
On Wed, 4 Apr 2018 09:27:10 -0700 Kees Cook wrote: > On Wed, Apr 4, 2018 at 12:49 AM, Peter Zijlstra wrote: > > On Tue, Apr 03, 2018 at 05:06:12PM -0400, Steven Rostedt wrote: > >> If you are concerned about attack surface, I could make it a bit more > >> difficult to tweak by malicious softwa

Re: v4.16+ seeing many unaligned access in dequeue_task_fair() on IA64

2018-04-04 Thread Peter Zijlstra
On Wed, Apr 04, 2018 at 09:38:56AM -0700, Luck, Tony wrote: > On Wed, Apr 04, 2018 at 09:25:13AM +0200, Peter Zijlstra wrote: > > Right, I remember being careful with that. Which again brings me to the > > RANDSTRUCT thing, which will mess that up. > > No RANDSTRUCT config options set for my build

Re: INFO: rcu detected stall in bitmap_parselist

2018-04-04 Thread Yury Norov
On Thu, Apr 05, 2018 at 12:58:46AM +0900, Tetsuo Handa wrote: > Yury Norov wrote: > > Hi Tetsuo, > > > > Thanks for the patch. > > > > On Wed, Apr 04, 2018 at 09:21:43PM +0900, Tetsuo Handa wrote: > > > Yury, are you OK with this patch? > > > > > > > > > >From 7f21827cdfe9780b4949b22bcd19efa721

Re: [GIT PULL] x86/build changes for v4.17

2018-04-04 Thread Nick Desaulniers
(re-sending as plain text) On Wed, Apr 4, 2018 at 2:38 AM Greg KH wrote: > There are known-bugs with building a kernel with clang right now (I > pointed one out a few days ago about NULL checks being deleted from the > clang output for no good reason, which really is scary for obvious > reasons).

Re: [RFC PATCH 3/4] acpi: apei: Do not panic() in NMI because of GHES messages

2018-04-04 Thread James Morse
Hi Alex, On 04/04/18 16:33, Alex G. wrote: > On 04/04/2018 02:18 AM, James Morse wrote: >> On 03/04/18 18:08, Alexandru Gagniuc wrote: >>> BIOSes like to send NMIs for a number of silly reasons often deemed >>> to be "fatal". For example pin bounce during a PCIE hotplug/unplug >>> might cause the

Re: [PATCH] netdevsim: remove incorrect __net_initdata annotations

2018-04-04 Thread David Miller
From: Arnd Bergmann Date: Wed, 4 Apr 2018 18:03:41 +0200 > On Wed, Apr 4, 2018 at 5:52 PM, David Miller wrote: >> From: Arnd Bergmann >> Date: Wed, 4 Apr 2018 14:12:39 +0200 >> >>> The __net_initdata section cannot currently be used for structures that >>> get cleaned up in an exitcall using u

Re: [v3,4/4] watchdog: add Gateworks System Controller support

2018-04-04 Thread Tim Harvey
On Mon, Apr 2, 2018 at 9:32 AM, Andrew Lunn wrote: >> The 'use case' we have been using this in for a couple years is that >> users who want to use this watchdog will enable it externally (we have >> a command in the bootloader) and if enabled the kernel driver (that >> I'm proposing here which we

Re: [PATCH 1/3] mm: memcontrol: Use cgroup_rstat for event accounting

2018-04-04 Thread Tejun Heo
Hello, On Wed, Apr 04, 2018 at 04:34:47PM +0200, Michal Hocko wrote: > > > The lazy updates are neat, but I'm a little concerned at the memory > > > footprint. On a 64-cpu machine for example, this adds close to 9000 > > > words to struct mem_cgroup. And we really only need the accuracy for > > >

Re: [GIT PULL] x86/build changes for v4.17

2018-04-04 Thread Greg KH
On Wed, Apr 04, 2018 at 04:53:52PM +, Nick Desaulniers wrote: > (re-sending as plain text) > > On Wed, Apr 4, 2018 at 2:38 AM Greg KH wrote: > > There are known-bugs with building a kernel with clang right now (I > > pointed one out a few days ago about NULL checks being deleted from the > >

[PATCH] KVM: vmx: unify adjacent #ifdefs

2018-04-04 Thread Paolo Bonzini
vmx_save_host_state has multiple ifdefs for CONFIG_X86_64 that have no other code between them. Simplify by reducing them to a single conditional. Signed-off-by: Paolo Bonzini --- arch/x86/kvm/vmx.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/arch/x86/kvm/vmx.

Re: [PATCH] x86: kvm: hide the unused 'cpu' variable

2018-04-04 Thread Paolo Bonzini
On 04/04/2018 13:51, David Hildenbrand wrote: > On 04.04.2018 12:44, Arnd Bergmann wrote: >> The local variable was newly introduced but is only accessed in one >> place on x86_64, but not on 32-bit: >> >> arch/x86/kvm/vmx.c: In function 'vmx_save_host_state': >> arch/x86/kvm/vmx.c:2175:6: error: u

Re: [PATCH 2/3] adp5061: Add support for battery charging enable

2018-04-04 Thread kbuild test robot
Hi Stefan, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.16 next-20180404] [cannot apply to battery/master] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https

Re: [PATCH] HID: input: fix battery level reporting on BT mice

2018-04-04 Thread Dmitry Torokhov
On Wed, Apr 4, 2018 at 1:51 AM, Martin van Es wrote: > > On Wednesday, April 4, 2018 10:33:16 AM CEST Jiri Kosina wrote: > > Can I add your Tested-by: while applying the commit? > > That's ok. Martin is also the reporter of the issue, I did not put down his name because I wasn't sure if he wanted

Re: [RFC] mm: memory.low heirarchical behavior

2018-04-04 Thread Johannes Weiner
On Wed, Mar 21, 2018 at 07:08:06PM +, Roman Gushchin wrote: > > On Tue, Mar 20, 2018 at 10:33:53PM +, Roman Gushchin wrote: > > > This patch aims to address an issue in current memory.low semantics, > > > which makes it hard to use it in a hierarchy, where some leaf memory > > > cgroups are

Re: [GIT PULL] libata changes for v4.17-rc1

2018-04-04 Thread Tejun Heo
On Tue, Apr 03, 2018 at 05:59:04PM -0700, Linus Torvalds wrote: > People hotplug ATA _controllers_? :-O > > As opposed to just the disks a'la eSATA? Heh, yeah, it's surprising. IIUC, it's people trying pcie hotplug (I don't know whether they try physically) on SAS controllers on fancy machines

Re: [PATCH v5 2/2] KVM: X86: Add Force Emulation Prefix for "emulate the next instruction"

2018-04-04 Thread Paolo Bonzini
On 04/04/2018 15:35, Wanpeng Li wrote: > 2018-04-04 19:59 GMT+08:00 David Hildenbrand : >> >>> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c >>> index 1eb495e..a55ecef 100644 >>> --- a/arch/x86/kvm/x86.c >>> +++ b/arch/x86/kvm/x86.c >>> @@ -146,6 +146,9 @@ bool __read_mostly enable_vmware_ba

Re: [PATCH] kvm: Add emulation for movups/movupd

2018-04-04 Thread Konrad Rzeszutek Wilk
On Wed, Apr 04, 2018 at 05:53:04PM +0200, Paolo Bonzini wrote: > On 01/04/2018 17:54, Stefan Fritsch wrote: > > This is very similar to the aligned versions movaps/movapd. ..snip.. > Applied, thanks. Should there be a corresponding test-case? > > Paolo

Re: [PATCH] kvm: x86 : fix a compile warning

2018-04-04 Thread Paolo Bonzini
On 02/04/2018 03:15, Peng Hao wrote: > fix a "warning: no previous prototype". > > Signed-off-by: Peng Hao > --- > arch/x86/kvm/x86.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > index 18b5ca7..6621319 100644 > --- a/arch/x86

Re: [PATCH] ARM: omap2: fix am43xx build without L2X0

2018-04-04 Thread Tony Lindgren
* Arnd Bergmann [180404 10:27]: > When CONFIG_CACHE_L2X0 is disabled, the am43xx specific suspend > implemnentation fails to link: > > arch/arm/mach-omap2/sleep43xx.o: In function `get_l2cache_base': > (.text+0x180): undefined reference to `omap4_get_l2cache_base' > > This adds an #ifdef protect

Re: [PATCH v5 1/2] KVM: X86: Introduce handle_ud()

2018-04-04 Thread Paolo Bonzini
On 04/04/2018 13:54, David Hildenbrand wrote: >> +{ >> +enum emulation_result er; >> + >> +er = emulate_instruction(vcpu, EMULTYPE_TRAP_UD); >> +if (er == EMULATE_USER_EXIT) >> +return 0; >> +if (er != EMULATE_DONE) >> +kvm_queue_exception(vcpu, UD_VECTOR); >

Re: [PATCH v2] tracing, printk: Force no hashing when trace_printk() is used

2018-04-04 Thread Steven Rostedt
On Wed, 4 Apr 2018 11:34:55 +0900 Sergey Senozhatsky wrote: > On (04/03/18 18:03), Steven Rostedt wrote: > > > > > he'd want you to change all the trace_printk()s to %px with > > > justifications, though. > > > > What trace_printk()s do you want to change? They are throw away > > functions.

Re: [GIT PULL] x86/build changes for v4.17

2018-04-04 Thread Linus Torvalds
On Wed, Apr 4, 2018 at 9:49 AM, Nick Desaulniers wrote: > > It's definitely something curious that I'll need to sit down and investigate > more. If there are other known instances, it would be good to let me know. Note that we explicitly use "-fno-delete-null-pointer-checks" because we do *not*

Re: [PATCH] tools: restore READ_ONCE() C++ compatibility

2018-04-04 Thread Sandipan Das
Hi Mark, On 04/04/2018 10:04 PM, Mark Rutland wrote: > > Zhijian, Sandipan, does this patch work for you? > Yes it does. Thanks for the fix. - Sandipan

Re: [PATCH] lockdep: Do not record irq state in debug_check_no_locks_freed()

2018-04-04 Thread Steven Rostedt
On Wed, 4 Apr 2018 18:23:05 +0200 Peter Zijlstra wrote: > > Makes sense, could you convert all of them just to make sure there > aren't any left? There's a few others. I'll send another patch. -- Steve

Re: [PATCH 2/2] efi: Add embedded peripheral firmware support

2018-04-04 Thread Peter Jones
On Tue, Apr 03, 2018 at 06:58:48PM +, Luis R. Rodriguez wrote: > On Tue, Apr 03, 2018 at 08:07:11PM +0200, Lukas Wunner wrote: > > On Tue, Apr 03, 2018 at 10:33:25AM +0200, Hans de Goede wrote: > > > I asked Peter Jones for suggestions how to extract this during boot and > > > he suggested seei

Re: [PATCH] tools: restore READ_ONCE() C++ compatibility

2018-04-04 Thread Mark Rutland
On Wed, Apr 04, 2018 at 10:43:16PM +0530, Sandipan Das wrote: > Hi Mark, > > On 04/04/2018 10:04 PM, Mark Rutland wrote: > > > > Zhijian, Sandipan, does this patch work for you? > > > > Yes it does. Thanks for the fix. Great! Can I take that as a Tested-by? Thanks, Mark.

Re: [PATCH] tools: restore READ_ONCE() C++ compatibility

2018-04-04 Thread Sandipan Das
On 04/04/2018 10:48 PM, Mark Rutland wrote: > On Wed, Apr 04, 2018 at 10:43:16PM +0530, Sandipan Das wrote: >> Hi Mark, >> >> On 04/04/2018 10:04 PM, Mark Rutland wrote: >>> >>> Zhijian, Sandipan, does this patch work for you? >>> >> >> Yes it does. Thanks for the fix. > > Great! Can I take that

[PATCH v7 0/9] Add Actions Semi S900 pinctrl and gpio support

2018-04-04 Thread Manivannan Sadhasivam
This patchset adds pinctrl and gpio support for Actions Semi S900 SoC. Pinctrl and gpio subsystems share the common set of register range but implemented as individual drivers for making it less complex. Pinmux functions are only accessible for pin groups while pinconf parameters are available for

[PATCH v7 1/9] arm64: dts: actions: Add pinctrl node for S900

2018-04-04 Thread Manivannan Sadhasivam
Add pinctrl nodes for Actions Semi S900 SoC Signed-off-by: Manivannan Sadhasivam Reviewed-by: Linus Walleij --- arch/arm64/boot/dts/actions/s900.dtsi | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/arm64/boot/dts/actions/s900.dtsi b/arch/arm64/boot/dts/actions/s900.dtsi index fe

[PATCH v7 2/9] arm64: actions: Enable PINCTRL in platforms Kconfig

2018-04-04 Thread Manivannan Sadhasivam
Select PINCTRL for Actions Semi SoCs Signed-off-by: Manivannan Sadhasivam Reviewed-by: Linus Walleij --- arch/arm64/Kconfig.platforms | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms index fbedbd8f619a..bae1289bdc3f 100644 --- a/arc

[PATCH v7 4/9] dt-bindings: gpio: Add gpio nodes for Actions S900 SoC

2018-04-04 Thread Manivannan Sadhasivam
Add gpio nodes for Actions Semi S900 SoC. Signed-off-by: Manivannan Sadhasivam --- .../devicetree/bindings/gpio/actions,owl-gpio.txt | 87 ++ 1 file changed, 87 insertions(+) create mode 100644 Documentation/devicetree/bindings/gpio/actions,owl-gpio.txt diff --git a/Docume

[PATCH v7 3/9] pinctrl: actions: Add Actions S900 pinctrl driver

2018-04-04 Thread Manivannan Sadhasivam
Add pinctrl driver for Actions Semi S900 SoC. The driver supports pinctrl, pinmux and pinconf functionalities through a range of registers common to both gpio driver and pinctrl driver. Pinmux functionality is available only for the pin groups while the pinconf functionality is available for both

Re: [PATCH v4] x86,sched: allow topologies where NUMA nodes share an LLC

2018-04-04 Thread Tim Chen
On 04/03/2018 02:12 PM, Alison Schofield wrote: > + > + /* > + * topology_sane() considers LLCs that span NUMA nodes to be > + * insane and will display a warning message. Bypass the call > + * to topology_sane() for snc_cpu's to avoid that warning. > + */ > + > + if (!

[PATCH v7 8/9] MAINTAINERS: Add reviewer for ACTIONS platforms

2018-04-04 Thread Manivannan Sadhasivam
Since I'll be working on improving support for ACTIONS platforms, adding myself as the reviewer. Signed-off-by: Manivannan Sadhasivam --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9a7f76eadae9..640dabc4c311 100644 --- a/MAINTAINERS +++ b/MAIN

[PATCH v7 6/9] arm64: dts: actions: Add gpio line names to Bubblegum-96 board

2018-04-04 Thread Manivannan Sadhasivam
Add gpio line names to Actions Semi S900 based Bubblegum-96 board. Signed-off-by: Manivannan Sadhasivam Reviewed-by: Linus Walleij --- arch/arm64/boot/dts/actions/s900-bubblegum-96.dts | 195 ++ 1 file changed, 195 insertions(+) diff --git a/arch/arm64/boot/dts/actions/s900

[PATCH v7 9/9] MAINTAINERS: Add Actions Semi S900 pinctrl and gpio entries

2018-04-04 Thread Manivannan Sadhasivam
Add S900 pinctrl and gpio entries under ARCH_ACTIONS Signed-off-by: Manivannan Sadhasivam --- MAINTAINERS | 4 1 file changed, 4 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 640dabc4c311..d63793ee545e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1125,10 +1125,14 @@ F:

[PATCH v7 7/9] gpio: Add gpio driver for Actions OWL S900 SoC

2018-04-04 Thread Manivannan Sadhasivam
Add gpio driver for Actions Semi OWL family S900 SoC. Set of registers controlling the gpio shares the same register range with pinctrl block. GPIO registers are organized as 6 banks and each bank controls the maximum of 32 gpios. Signed-off-by: Manivannan Sadhasivam Reviewed-by: Andy Shevchenko

[PATCH v7 5/9] arm64: dts: actions: Add S900 gpio nodes

2018-04-04 Thread Manivannan Sadhasivam
Add gpio nodes for Actions Semi S900 SoC. Signed-off-by: Manivannan Sadhasivam --- arch/arm64/boot/dts/actions/s900.dtsi | 51 +++ 1 file changed, 51 insertions(+) diff --git a/arch/arm64/boot/dts/actions/s900.dtsi b/arch/arm64/boot/dts/actions/s900.dtsi index 0

Re: [PATCH] kvm: Add emulation for movups/movupd

2018-04-04 Thread Paolo Bonzini
On 04/04/2018 19:10, Konrad Rzeszutek Wilk wrote: > On Wed, Apr 04, 2018 at 05:53:04PM +0200, Paolo Bonzini wrote: >> On 01/04/2018 17:54, Stefan Fritsch wrote: >>> This is very similar to the aligned versions movaps/movapd. > ..snip.. >> Applied, thanks. > Should there be a corresponding test-case

Re: [PATCH v3 2/2] drivers: soc: Add LLCC driver

2018-04-04 Thread rishabhb
Hi Stanimir, We incorporated all your comments except the following: 1. Removing the driver that maintains the SCT (system cache table) per chipset. As responded earlier the data is expected to change from chipset to chipset and would clutter the main driver if we choose using compatible string. W

Re: [PATCH 1/3] adp5061: New driver for ADP5061 I2C battery charger

2018-04-04 Thread Randy Dunlap
Hi, one small typo below: On 04/04/2018 01:17 AM, Stefan Popa wrote: > diff --git a/drivers/power/supply/Kconfig b/drivers/power/supply/Kconfig > index 428b426..761cc52 100644 > --- a/drivers/power/supply/Kconfig > +++ b/drivers/power/supply/Kconfig > @@ -75,6 +75,17 @@ config BATTERY_88PM860X >

Re: [PATCH] kvm: Add emulation for movups/movupd

2018-04-04 Thread Stefan Fritsch
On Wednesday, 4 April 2018 19:24:20 CEST Paolo Bonzini wrote: > On 04/04/2018 19:10, Konrad Rzeszutek Wilk wrote: > > Should there be a corresponding test-case? > > Good point! Stefan, could you write one? Is there infrastructure for such tests? If yes, can you give me a pointer to it? Cheers,

Re: [PATCH v4] x86,sched: allow topologies where NUMA nodes share an LLC

2018-04-04 Thread Alison Schofield
On Wed, Apr 04, 2018 at 10:24:49AM -0700, Tim Chen wrote: > On 04/03/2018 02:12 PM, Alison Schofield wrote: > > > + > > + /* > > +* topology_sane() considers LLCs that span NUMA nodes to be > > +* insane and will display a warning message. Bypass the call > > +* to topology_sane() fo

Re: [RFC] drm/atomic+msm: add helper to implement legacy dirtyfb

2018-04-04 Thread Noralf Trønnes
Den 04.04.2018 00.42, skrev Rob Clark: Add an atomic helper to implement dirtyfb support. This is needed to support DSI command-mode panels with x11 userspace (ie. when we can't rely on pageflips to trigger a flush to the panel). To signal to the driver that the async atomic update needs to s

Re: [PATCH v5 1/2] KVM: X86: Introduce handle_ud()

2018-04-04 Thread David Hildenbrand
On 04.04.2018 19:12, Paolo Bonzini wrote: > On 04/04/2018 13:54, David Hildenbrand wrote: >>> +{ >>> + enum emulation_result er; >>> + >>> + er = emulate_instruction(vcpu, EMULTYPE_TRAP_UD); >>> + if (er == EMULATE_USER_EXIT) >>> + return 0; >>> + if (er != EMULATE_DONE) >>> +

Re: [PATCH] [RFC][WIP] namespace.c: Allow some unprivileged proc mounts when not fully visible

2018-04-04 Thread Alexey Dobriyan
> Instead, it introduces new options in proc to disable some proc entries (TBD). No, no, no, no. Blacklists are bad, mmkay. The reason is that quite dangerous new /proc entries get added (think /proc/kpageflags) and suddenly they are enabled inside container. > The granularity does not need to

Re: Signal handling in a page fault handler

2018-04-04 Thread Daniel Vetter
On Wed, Apr 4, 2018 at 6:24 PM, Matthew Wilcox wrote: > On Wed, Apr 04, 2018 at 05:15:46PM +0200, Daniel Vetter wrote: >> On Wed, Apr 4, 2018 at 4:39 PM, Matthew Wilcox wrote: >> > I actually have plans to allow mutex_lock_{interruptible,killable} to >> > return -EWOULDBLOCK if a flag is set. So

Re: [PATCH v2 2/2] io: prevent compiler reordering on the default readX() implementation

2018-04-04 Thread Sinan Kaya
On 4/4/2018 11:55 AM, Arnd Bergmann wrote: > Yes, exactly, plus the same for write and in/out of course. I was looking at this... inb() and outb() seem to be calling writeb(). It gets the wmb/barrier automatically when we fix writeb(). Did I miss something? -- Sinan Kaya Qualcomm Datacenter T

Re: [PATCH] [RFC][WIP] namespace.c: Allow some unprivileged proc mounts when not fully visible

2018-04-04 Thread Alexey Dobriyan
> The only option I have seen proposed that might qualify as something > general purpose and simple is a new filesystem that is just the process > directories of proc. While "mount -t pid" and "mount -t sysctl" are decades overdue, I don't think they cover everything. IIRC some gcc versions read

[GIT] Networking

2018-04-04 Thread David Miller
This fixes some fallout from the net-next merge the other day, plus some non-merge-window-related bug fixes: 1) Fix sparse warnings in bcmgenet,systemport, b53, and mt7530, from Florian Fainelli. 2) pptp does a bogus dst_release() on a route we have a single refcount on, and attached to a

Re: [RFC] drm/atomic+msm: add helper to implement legacy dirtyfb

2018-04-04 Thread Daniel Vetter
On Wed, Apr 4, 2018 at 7:41 PM, Noralf Trønnes wrote: > > > Den 04.04.2018 00.42, skrev Rob Clark: >> >> Add an atomic helper to implement dirtyfb support. This is needed to >> support DSI command-mode panels with x11 userspace (ie. when we can't >> rely on pageflips to trigger a flush to the pan

Re: ARM compile failure in Re: linux-next: Tree for Apr 4

2018-04-04 Thread Tony Lindgren
inline 'memcmp': function not inlinable > ... > pavel@duo:/data/l/linux-next-n900$ git branch -l > * (detached from next-20180403) > > I'm using > > eval ` eldk-switch.sh -r 5.4 armv7a` > > for cross-compilation. Hmm I'm not seeing build issues with next-20180404, did this somehow already get sorted out? Regards, Tony

[RFC PATCH] perf tools powerpc: Fix callchain ip filtering

2018-04-04 Thread Sandipan Das
For powerpc64, if a probe is added for a function without specifying a line number, the corresponding trap instruction is placed at offset 0 (for big endian) or 8 (for little endian) from the start address of the function. This address is in the function prologue and the trap instruction preceeds t

[PATCH 1/3] perf tools: Fix perf builds with clang support

2018-04-04 Thread Sandipan Das
For libclang, some distro packages provide static libraries (.a) while some provide shared libraries (.so). Currently, perf code can only be linked with static libraries. This makes perf build possible for both cases. Fixes: d58ac0bf8d1e ("perf build: Add clang and llvm compile and linking suppor

[PATCH 2/3] perf clang: Add support for recent clang versions

2018-04-04 Thread Sandipan Das
The clang API calls used by perf have changed in recent releases and builds succeed with libclang-3.9 only. This introduces compatibility with libclang-4.0 and above. Without this patch, we will see the following compilation errors with libclang-4.0+: util/c++/clang.cpp: In function ‘clang::Comp

[PATCH 3/3] perf tests clang: Fix function name for clang IR test

2018-04-04 Thread Sandipan Das
As stated in tests/llvm-src-base.c, the name of the bpf function should be "bpf_func__SyS_epoll_pwait" but this clang test fails as it tries to lookup "bpf_func__SyS_epoll_wait". Before applying patch: 55: builtin clang support : 55.1: builtin clang compile C sourc

[PATCH v2] lockdep: Do not record irq state within lockdep code

2018-04-04 Thread Steven Rostedt
From: Steven Rostedt (VMware) While debugging where things were going wrong with mapping enabling/disabling interrupts with the lockdep state and actual real enabling and disabling interrupts, I had to silent the irq disabling/enabling in debug_check_no_locks_freed() because it was always showing

Re: [PATCH 09/11] x86/pti: enable global pages for shared areas

2018-04-04 Thread Thomas Gleixner
On Wed, 4 Apr 2018, Nadav Amit wrote: > Dave Hansen wrote: > > On 04/03/2018 09:45 PM, Nadav Amit wrote: > >> Dave Hansen wrote: > >>> void cea_set_pte(void *cea_vaddr, phys_addr_t pa, pgprot_t flags) > >>> { > >>> unsigned long va = (unsigned long) cea_vaddr; > >>> + pte_t pte = pfn_pte(pa >>

Re: RFC: Using regmap in ARM64 for EL3 register access

2018-04-04 Thread Thor Thayer
Hi Sudeep, On 04/04/2018 05:47 AM, Sudeep Holla wrote: On 30/03/18 00:00, Thor Thayer wrote: Hi, I'm working on an ARM64 architecture that needs to manipulate some protected registers that are only accessible in EL3. Linux is running at EL1 which doesn't have the proper permissions for these

Re: ARM compile failure in Re: linux-next: Tree for Apr 4

2018-04-04 Thread Pavel Machek
t; > lib/string.c:855:15: error: inlining failed in call to > > always_inline 'memcmp': function not inlinable > > ... > > pavel@duo:/data/l/linux-next-n900$ git branch -l > > * (detached from next-20180403) > > > > I'm using > > >

Re: [PATCH] iommu/vt-d: fix usage of force parameter in intel_ir_reconfigure_irte()

2018-04-04 Thread Jag Raman
On 3/6/2018 5:39 PM, Jagannathan Raman wrote: It was noticed that the IRTE configured for guest OS kernel was over-written while the guest was running. As a result, vt-d Posted Interrupts configured for the guest are not being delivered directly, and instead bounces off the host. Every interrup

regression: twl4030 audio/clock stopped working in v4.16

2018-04-04 Thread H. Nikolaus Schaller
Hi Peter, I just noticed a problem in v4.16 kernels with twl4030 audio and vibra driver no longer working. Tracing it back shows that it already did appear in v4.16-rc1 and wasn't fixed up to v4.16.0. Kernel v4.15.9 (the latest one where I have a binary) works. The symptoms are: [1.557342]

Re: [PATCHv4 08/10] backlight: add TI LMU backlight driver

2018-04-04 Thread Dan Murphy
Sebastian -Milo Kim email is not valid On 03/30/2018 12:24 PM, Sebastian Reichel wrote: > This adds backlight support for the following TI LMU > chips: LM3532, LM3631, LM3632, LM3633, LM3695 and LM3697. > > Signed-off-by: Milo Kim > [add LED subsystem support for keyboard backlight and rework D

Re: [PATCHv3] gpio: Remove VLA from gpiolib

2018-04-04 Thread Laura Abbott
On 03/30/2018 07:33 AM, Andy Shevchenko wrote: On Wed, Mar 28, 2018 at 9:18 PM, Laura Abbott wrote: The new challenge is to remove VLAs from the kernel (see https://lkml.org/lkml/2018/3/7/621) to eventually turn on -Wvla. Using a kmalloc array is the easy way to fix this but kmalloc is still m

Re: [PATCH v2] drm/i915: Keep AUX block running when disabling DPMS for MST

2018-04-04 Thread Lyude Paul
On Wed, 2018-04-04 at 18:34 +0300, Ville Syrjälä wrote: > On Mon, Apr 02, 2018 at 05:26:16PM -0400, Lyude Paul wrote: > > While enabling/disabling DPMS before link training with MST hubs is > > perfectly valid; unfortunately disabling DPMS results in some devices > > disabling their AUX CH block as

Re: linux-next: manual merge of the pci tree with the asm-generic tree

2018-04-04 Thread Bjorn Helgaas
On Mon, Apr 2, 2018 at 9:15 PM Stephen Rothwell wrote: > Hi all, > Today's linux-next merge of the pci tree got a conflict in: > arch/cris/arch-v32/drivers/pci/bios.c > between commits: > c690eddc2f3b ("CRIS: Drop support for the CRIS port") > fd8773f9f544 ("arch: remove frv port"

Re: [Intel-gfx] [PATCH v2] drm/i915: Keep AUX block running when disabling DPMS for MST

2018-04-04 Thread Manasi Navare
On Wed, Apr 04, 2018 at 06:34:29PM +0300, Ville Syrjälä wrote: > On Mon, Apr 02, 2018 at 05:26:16PM -0400, Lyude Paul wrote: > > While enabling/disabling DPMS before link training with MST hubs is > > perfectly valid; unfortunately disabling DPMS results in some devices > > disabling their AUX CH b

Re: [PATCH v4] x86,sched: allow topologies where NUMA nodes share an LLC

2018-04-04 Thread Tim Chen
On 04/04/2018 10:38 AM, Alison Schofield wrote: > On Wed, Apr 04, 2018 at 10:24:49AM -0700, Tim Chen wrote: >> On 04/03/2018 02:12 PM, Alison Schofield wrote: >> >>> + >>> + /* >>> +* topology_sane() considers LLCs that span NUMA nodes to be >>> +* insane and will display a warning messag

Re: [PATCH] [RFC][WIP] namespace.c: Allow some unprivileged proc mounts when not fully visible

2018-04-04 Thread Serge E. Hallyn
Quoting Eric W. Biederman (ebied...@xmission.com): > It looks like a cruft free cousin of proc that is just processes would > be applicable to your usecase. Just to check - is that something you're working on? -serge

Re: [GIT PULL] Kernel lockdown for secure boot

2018-04-04 Thread Peter Jones
On Tue, Apr 03, 2018 at 02:51:23PM -0700, Andy Lutomirski wrote: > On Tue, Apr 3, 2018 at 12:29 PM, Matthew Garrett wrote: > > On Tue, Apr 3, 2018 at 9:46 AM Andy Lutomirski wrote: > >> On Tue, Apr 3, 2018 at 9:29 AM, Matthew Garrett wrote: > >> > A kernel that allows users arbitrary access to r

Re: ARM compile failure in Re: linux-next: Tree for Apr 4

2018-04-04 Thread Pavel Machek
ere > > lib/string.c:855:15: error: inlining failed in call to > > always_inline 'memcmp': function not inlinable > > ... > > pavel@duo:/data/l/linux-next-n900$ git branch -l > > * (detached from next-20180403) > > > > I'm usin

Re: [Intel-gfx] [PATCH v2] drm/i915: Keep AUX block running when disabling DPMS for MST

2018-04-04 Thread Lyude Paul
On Wed, 2018-04-04 at 11:44 -0700, Manasi Navare wrote: > On Wed, Apr 04, 2018 at 06:34:29PM +0300, Ville Syrjälä wrote: > > On Mon, Apr 02, 2018 at 05:26:16PM -0400, Lyude Paul wrote: > > > While enabling/disabling DPMS before link training with MST hubs is > > > perfectly valid; unfortunately dis

[RFC][PATCH] tracing: Hide global trace clock from lockdep

2018-04-04 Thread Steven Rostedt
From: Steven Rostedt (VMware) Function tracing can trace in NMIs and such. If the TSC is determined to be unstable, the tracing clock will switch to the global clock on boot up, unless "trace_clock" is specified on the kernel command line. The global clock disables interrupts to access sched_clo

Re: [RFC] drm/atomic+msm: add helper to implement legacy dirtyfb

2018-04-04 Thread Noralf Trønnes
Den 04.04.2018 19.56, skrev Daniel Vetter: On Wed, Apr 4, 2018 at 7:41 PM, Noralf Trønnes wrote: Den 04.04.2018 00.42, skrev Rob Clark: Add an atomic helper to implement dirtyfb support. This is needed to support DSI command-mode panels with x11 userspace (ie. when we can't rely on pageflip

Re: [PATCH v2] drm/i915: Keep AUX block running when disabling DPMS for MST

2018-04-04 Thread Ville Syrjälä
On Wed, Apr 04, 2018 at 02:37:41PM -0400, Lyude Paul wrote: > On Wed, 2018-04-04 at 18:34 +0300, Ville Syrjälä wrote: > > On Mon, Apr 02, 2018 at 05:26:16PM -0400, Lyude Paul wrote: > > > While enabling/disabling DPMS before link training with MST hubs is > > > perfectly valid; unfortunately disabl

[PATCH v2 0/2] Base enablement of IOMMU debugfs support

2018-04-04 Thread Gary R Hook
These patches create a top-level function to create a debugfs directory for the IOMMU, under which drivers may create and populate-specific directories for their device internals. Patch 1: general IOMMU enablement Patch 2: basic AMD enablement to demonstrate linkage with patch 1 Introduce a new K

[PATCH v2 1/2] iommu - Enable debugfs exposure of the IOMMU

2018-04-04 Thread Gary R Hook
Provide base enablement for using debugfs to expose internal data of an IOMMU driver. When called, create the /sys/kernel/debug/iommu directory. Emit a strong warning at boot time to indicate that this feature is enabled. This patch adds a top-level function that will create the (above) directory

[PATCH v2 2/2] iommu/amd: Add basic debugfs infrastructure for AMD IOMMU

2018-04-04 Thread Gary R Hook
Implement a skeleton framework for debugfs support in the AMD IOMMU. Signed-off-by: Gary R Hook --- drivers/iommu/Makefile|1 + drivers/iommu/amd_iommu_debugfs.c | 45 + drivers/iommu/amd_iommu_init.c|7 -- drivers/iommu/amd_iomm

[PATCH] prctl: Deprecate non PR_SET_MM_MAP operations

2018-04-04 Thread Cyrill Gorcunov
An ability to manipulate mm_struct fields was introduced in sake of CRIU in first place. Later we provide more suitable and safe operation PR_SET_MM_MAP where all fields to be modifed are passed in one structure which allows us to make more detailed verification. Still old interface remains presen

Re: [RFC PATCH 2/2] ACPI/IORT: use swiotlb_dma_ops when smmu probe failed

2018-04-04 Thread Robin Murphy
On 04/04/18 17:01, Lorenzo Pieralisi wrote: [+cc Robin] On Thu, Mar 29, 2018 at 03:01:00AM -0700, Wang Dongsheng wrote: If SMMU probe failed, master should use swiotlb as dma ops. SMMU may probe failed with specified environment, so there are not any iommu resources in iommu_device_list. The m

Re: [PATCH v2] drm/i915: Keep AUX block running when disabling DPMS for MST

2018-04-04 Thread Lyude Paul
On Wed, 2018-04-04 at 21:53 +0300, Ville Syrjälä wrote: > On Wed, Apr 04, 2018 at 02:37:41PM -0400, Lyude Paul wrote: > > On Wed, 2018-04-04 at 18:34 +0300, Ville Syrjälä wrote: > > > On Mon, Apr 02, 2018 at 05:26:16PM -0400, Lyude Paul wrote: > > > > While enabling/disabling DPMS before link train

Re: [PATCH 1/6] x86/intel_rdt/mba_sc: Add documentation for MBA software controller

2018-04-04 Thread Shivappa Vikas
On Wed, 4 Apr 2018, Thomas Gleixner wrote: > On Tue, 3 Apr 2018, Shivappa Vikas wrote: > > On Tue, 3 Apr 2018, Thomas Gleixner wrote: > > > On Thu, 29 Mar 2018, Vikas Shivappa wrote: > > > The L2 external bandwidth is higher than the L3 external bandwidth. > > > > > > Is there any information

Re: [PATCH v2] drm/i915: Keep AUX block running when disabling DPMS for MST

2018-04-04 Thread Lyude Paul
On Wed, 2018-04-04 at 21:53 +0300, Ville Syrjälä wrote: > On Wed, Apr 04, 2018 at 02:37:41PM -0400, Lyude Paul wrote: > > On Wed, 2018-04-04 at 18:34 +0300, Ville Syrjälä wrote: > > > On Mon, Apr 02, 2018 at 05:26:16PM -0400, Lyude Paul wrote: > > > > While enabling/disabling DPMS before link train

[PATCH v2 2/5] gpio: pca953x: add register definitions for pcal6524 and fix address calculation

2018-04-04 Thread H. Nikolaus Schaller
PCAL chips ("L" seems to stand for "latched") have additional registers starting at address 0x40 to control the latches, interrupt mask, pull-up and pull down etc. The constants are so far defined in a way that they fit for the pcal9555a when shifted by the number of banks, i.e. multiplied by 2.

<    1   2   3   4   5   6   7   8   9   10   >