Re: [PATCH 4/4] nvmet-fc: Use new SGL alloc/free helper for requests

On 29/03/18 10:52 AM, James Smart wrote: > overall - I'm a little concerned about the replacement. > > I know the code depends on the null/zero checks in > nvmet_fc_free_tgt_pgs() as there are paths that can call them twice.  > Your replacement in that routine is fine, but you've fully removed

Re: [PATCH 2/6] fpga: manager: don't use drvdata in common fpga code

On Thu, Mar 29, 2018 at 08:36:54AM -0700, Moritz Fischer wrote: > From: Alan Tull > > Change fpga_mgr_register to not set or use drvdata. > > Change the register/unregister function parameters to take the mgr > struct: > * int fpga_mgr_register(struct fpga_manager *mgr); > * void fpga_mgr_unregi

Re: [PATCH 3/6] fpga: bridge: don't use drvdata in common fpga code

On Thu, Mar 29, 2018 at 08:36:55AM -0700, Moritz Fischer wrote: > From: Alan Tull > > Change fpga_bridge_register to not set drvdata. > > Change the register/unregister functions parameters to take the > bridge struct: > * int fpga_bridge_register(struct fpga_bridge *bridge); > * void fpga_bridg

Re: [PATCH v2 0/2] gfs2: Stop using rhashtable_walk_peek

On Thu, Mar 29, 2018 at 06:52:34PM +0200, Andreas Gruenbacher wrote: > > Should rhashtable_walk_peek be kept around even if there are no more > users? I have my doubts. Absolutely. All netlink dumps using rhashtable_walk_next are buggy and need to switch over to rhashtable_walk_peek. As otherwis

Re: [PATCH 4/6] fpga: region: change fpga_region_register to have one param

On Thu, Mar 29, 2018 at 08:36:56AM -0700, Moritz Fischer wrote: > From: Alan Tull > > Change fpga_region_register to only take one parameter: > > int fpga_region_register(struct fpga_region *region) > > The parent dev is added to struct fpga_region. > > This make it similar to fpga_bridge_re

[PATCH] selftests/ftrace: fix spelling mistake: "tiggers" -> "triggers"

From: Colin Ian King Trivial fix to spelling mistake in message text Signed-off-by: Colin Ian King --- tools/testing/selftests/ftrace/test.d/trigger/trigger-multihist.tc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/ftrace/test.d/trigger/trigger-mu

Re: [linux-sunxi] [PATCH v9 0/2] Initial Allwinner V3s CSI Support

On 03/28/2018 06:02 PM, Yong wrote: AFAIK, there is no document about MIPI CSI-2. You can take a look at the source code in BSP: https://github.com/friendlyarm/h3_lichee/tree/master/linux-3.4/drivers/media/video/sunxi-vfe/mipi_csi And try to port it to mainline. Yep, I see there's lots of mag

Re: [PATCH v4 2/7] phy: qcom-qmp: Enable pipe_clk before PHY initialization

Hi Manu, On Thu, Mar 29, 2018 at 4:06 AM Manu Gautam wrote: > QMP PHY for USB/PCIE requires pipe_clk for locking of > retime buffers at the pipe interface. Driver checks for > PHY_STATUS without enabling pipe_clk due to which > phy_init() fails with initialization timeout. > Though pipe_clk is o

Re: [PATCH v2 08/11] block: sed-opal: ioctl for writing to shadow mbr

Hi, On Wed, Mar 21, 2018 at 02:43:21AM +0100, Jonas Rabenstein wrote: > On Tue, Mar 20, 2018 at 04:09:08PM -0600, Scott Bauer wrote: > > On Tue, Mar 20, 2018 at 10:36:04AM +0100, Jonas Rabenstein wrote: > > > On Mon, Mar 19, 2018 at 08:52:24PM +0100, Christoph Hellwig wrote: > > > > On Mon, Mar 19,

Re: [PATCH] selftests/ftrace: fix spelling mistake: "tiggers" -> "triggers"

On Thu, 29 Mar 2018 18:24:31 +0100 Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in message text > > Signed-off-by: Colin Ian King > --- > tools/testing/selftests/ftrace/test.d/trigger/trigger-multihist.tc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH] of_net: Implement of_get_nvmem_mac_address helper

On 25-03-18 10:17, Mike Looijmans wrote: On 24-03-18 19:53, Andrew Lunn wrote: A quick survey for the of_get_mac_address users learns that most of them do a memcpy (or similar) right after it, so for these drivers the "of_get_nvmem_mac_address" style signature that performs the memcpy (or bette

Re: [PATCH v2 04/21] kconfig: reference environments directly and remove 'option env=' syntax

On Thu, Mar 29, 2018 at 4:56 AM, Ulf Magnusson wrote: > On Thu, Mar 29, 2018 at 4:19 AM, Ulf Magnusson wrote: >> I've been kinda busy lately, so that's why I disappeared. >> >> I'll try to go over this patchset in more detail over the weekend. >> >> On Tue, Mar 27, 2018 at 7:29 AM, Masahiro Yamad

Re: [PATCH 4/4] nvmet-fc: Use new SGL alloc/free helper for requests

On 3/29/2018 10:02 AM, Logan Gunthorpe wrote: Per the bug in the previous patch, I don't think that was ever a valid assumption. It doesn't have anything to do with the sgl_alloc change either. The dma_map interface is allowed to merge SGLs and that's why it can return fewer nents than it was pas

Re: Problem with commit 31e77c93e432 "sched/fair: Update blocked load when newly idle"

Am 29.03.2018 um 09:41 schrieb Vincent Guittot: > On 28 March 2018 at 16:01, Vincent Guittot wrote: >> Hi, >> >> On 28 March 2018 at 12:37, Dietmar Eggemann wrote: >>> Hi, >>> >>> On 03/24/2018 01:47 PM, Heiner Kallweit wrote: Am 24.03.2018 um 07:46 schrieb Vincent Guittot: > >

Re: [PATCH 8/8] fs/aio: Use rcu_work instead of explicit rcu and work item

Hello, On Thu, Mar 29, 2018 at 06:49:25PM +0200, Oleg Nesterov wrote: > Still no use-case... But yes, I forgot this is needed for correctness. > > OK, thanks for your patience. But fyi now I hate this interface even more, > exactly because I was technically wrong in this discussion ;) Yeah, we m

Re: [PATCH v2 08/11] block: sed-opal: ioctl for writing to shadow mbr

On Thu, Mar 29, 2018 at 07:30:02PM +0200, Jonas Rabenstein wrote: > Hi, > On Wed, Mar 21, 2018 at 02:43:21AM +0100, Jonas Rabenstein wrote: > > On Tue, Mar 20, 2018 at 04:09:08PM -0600, Scott Bauer wrote: > > > On Tue, Mar 20, 2018 at 10:36:04AM +0100, Jonas Rabenstein wrote: > > > > On Mon, Mar 19

Re: [RFC PATCH v3 1/3] ima: extend clone() with IMA namespace support

On Mar 28, 8:44am, Stefan Berger wrote: } Subject: Re: [RFC PATCH v3 1/3] ima: extend clone() with IMA namespace sup Good morning, I hope the week is going well for everyone. > On 03/28/2018 08:14 AM, Dr. Greg Wettstein wrote: > > On Wed, Mar 28, 2018 at 07:10:12AM -0400, Stefan Berger wrote: >

Re: [PATCH] selftests/ftrace: fix spelling mistake: "tiggers" -> "triggers"

On 29/03/18 18:31, Steven Rostedt wrote: > On Thu, 29 Mar 2018 18:24:31 +0100 > Colin King wrote: > >> From: Colin Ian King >> >> Trivial fix to spelling mistake in message text >> >> Signed-off-by: Colin Ian King >> --- >> tools/testing/selftests/ftrace/test.d/trigger/trigger-multihist.tc | 2

Re: [PATCH] selftests/ftrace: fix spelling mistake: "tiggers" -> "triggers"

On 03/29/2018 11:47 AM, Colin Ian King wrote: > On 29/03/18 18:31, Steven Rostedt wrote: >> On Thu, 29 Mar 2018 18:24:31 +0100 >> Colin King wrote: >> >>> From: Colin Ian King >>> >>> Trivial fix to spelling mistake in message text >>> >>> Signed-off-by: Colin Ian King >>> --- >>> tools/testing

Re: [PATCH v3 2/2] drivers: soc: Add LLCC driver

On 2018-03-29 01:08, Stanimir Varbanov wrote: Hi, On 03/27/2018 09:52 PM, Rishabh Bhatnagar wrote: LLCC (Last Level Cache Controller) provides additional cache memory in the system. LLCC is partitioned into muliple slices and each slice getting its own priority, size, ID and other config parame

Re: [PATCH v6 0/3] Bluetooth: hci_qca: Add serdev support

Hi, On 28/03/2018 11:51, Thierry Escande wrote: Hi, This patchset enables the Qualcomm BT controller QCA6174 node in the device tree of the db820c board. This allows the bluetooth chipset to be probed and registered against the hci layer by using the serdev framework. This patchset also contai

linux-next 20180327 - "SELinux: (dev dm-3, type ext4) getxattr errno 34"

Seeing this error trying to mount ext4 disks. next-20180320 was OK. SELinux: (dev dm-3, type ext4) getxattr errno 34 and for /var, it refused to mount entirely (which brought the boot process to a screeching halt). git log shows commits in the past few days against both selinux and ext4, but not

[RFCv2 PATCH 1/3] kbuild: Introduce build-salt generated header

The build id generated from --build-id can be generated in several different ways, with the default being the sha1 on the output of the linked file. For distributions, it can be useful to make sure this ID is unique, even if the actual file contents don't change. The easiest way to do this is to in

[RFCv2 PATCH 3/3] x86/vdso: Add build salt to the vDSO

The vDSO is linked separately from the kernel and modules. Ensure it picks up the comment section, if available. Signed-off-by: Laura Abbott --- v2: Updated name --- arch/x86/entry/vdso/vdso-layout.lds.S | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/x86/entry/vdso/vdso-layout.lds.S

[RFCv2 PATCH 2/3] kbuild: Link with generated build-salt header

Now that we have a header with appropriate data, link it into the kernel and modules. If BUILD_ID_SALT isn't set, the script should be empty. Signed-off-by: Laura Abbott --- v2: Changed names to be consistent --- Makefile | 4 +++- scripts/.gitignore | 1 + scripts/Makefile

[PATCH 4.15 17/47] net sched actions: return explicit error when tunnel_key mode is not specified

4.15-stable review patch. If anyone has any objections, please let me know. -- From: Roman Mashak [ Upstream commit 51d4740f88affd85d49c04e3c9cd129c0e33bcb9 ] If set/unset mode of the tunnel_key action is not provided, ->init() still returns 0, and the caller proceeds with bo

[PATCH 4.15 04/47] tcp: purge write queue upon aborting the connection

4.15-stable review patch. If anyone has any objections, please let me know. -- From: Soheil Hassas Yeganeh [ Upstream commit e05836ac07c77dd90377f8c8140bce2a44af5fe7 ] When the connection is aborted, there is no point in keeping the packets on the write queue until the connec

[PATCH 4.15 03/47] qed: Fix MPA unalign flow in case header is split across two packets.

4.15-stable review patch. If anyone has any objections, please let me know. -- From: Michal Kalderon [ Upstream commit 933e8c91b9f5a2f504f6da1f069c410449b9f4b9 ] There is a corner case in the MPA unalign flow where a FPDU header is split over two tcp segments. The length of t

[PATCH 4.15 08/47] devlink: Remove redundant free on error path

4.15-stable review patch. If anyone has any objections, please let me know. -- From: Arkadi Sharshevsky [ Upstream commit 7fe4d6dcbcb43fe0282d4213fc52be178bb30e91 ] The current code performs unneeded free. Remove the redundant skb freeing during the error path. Fixes: 1555d2

[PATCH 4.15 20/47] test_rhashtable: add test case for rhltable with duplicate objects

4.15-stable review patch. If anyone has any objections, please let me know. -- From: Paul Blakey [ Upstream commit 499ac3b60f657dae82055fc81c7b01e6242ac9bc ] Tries to insert duplicates in the middle of bucket's chain: bucket 1: [[val 21 (tid=1)]] -> [[ val 1 (tid=2), val 1

[PATCH 4.15 22/47] sch_netem: fix skb leak in netem_enqueue()

4.15-stable review patch. If anyone has any objections, please let me know. -- From: Alexey Kodanev [ Upstream commit 35d889d10b649fda66121891ec05eca88150059d ] When we exceed current packets limit and we have more than one segment in the list returned by skb_gso_segment(), n

[PATCH 4.15 28/47] s390/qeth: lock read device while queueing next buffer

4.15-stable review patch. If anyone has any objections, please let me know. -- From: Julian Wiedmann [ Upstream commit 17bf8c9b3d499d5168537c98b61eb7a1fcbca6c2 ] For calling ccw_device_start(), issue_next_read() needs to hold the device's ccwlock. This is satisfied for the IR

[PATCH 4.15 37/47] l2tp: do not accept arbitrary sockets

4.15-stable review patch. If anyone has any objections, please let me know. -- From: Eric Dumazet [ Upstream commit 17cfe79a65f98abe535261856c5aef14f306dff7 ] syzkaller found an issue caused by lack of sufficient checks in l2tp_tunnel_create() RAW sockets can not be consider

[PATCH 4.15 34/47] dpaa_eth: remove duplicate increment of the tx_errors counter

4.15-stable review patch. If anyone has any objections, please let me know. -- From: Camelia Groza [ Upstream commit 82d141cd19d088ee41feafde4a6f86eeb40d93c5 ] The tx_errors counter is incremented by the dpaa_xmit caller. Signed-off-by: Camelia Groza Signed-off-by: Madalin

[PATCH 4.15 42/47] netlink: avoid a double skb free in genlmsg_mcast()

4.15-stable review patch. If anyone has any objections, please let me know. -- From: Nicolas Dichtel [ Upstream commit 02a2385f37a7c6594c9d89b64c4a1451276f08eb ] nlmsg_multicast() consumes always the skb, thus the original skb must be freed only when this function is called w

[PATCH 4.15 41/47] net/iucv: Free memory obtained by kzalloc

4.15-stable review patch. If anyone has any objections, please let me know. -- From: Arvind Yadav [ Upstream commit fa6a91e9b907231d2e38ea5ed89c537b3525df3d ] Free memory by calling put_device(), if afiucv_iucv_init is not successful. Signed-off-by: Arvind Yadav Reviewed-by

[PATCH 4.15 11/47] ipv6: old_dport should be a __be16 in __ip6_datagram_connect()

4.15-stable review patch. If anyone has any objections, please let me know. -- From: Stefano Brivio [ Upstream commit 5f2fb802eee1df0810b47ea251942fe3fd36589a ] Fixes: 2f987a76a977 ("net: ipv6: keep sk status consistent after datagram connect failure") Signed-off-by: Stefano

[PATCH 4.15 12/47] ipv6: sr: fix NULL pointer dereference when setting encap source address

4.15-stable review patch. If anyone has any objections, please let me know. -- From: David Lebrun [ Upstream commit 8936ef7604c11b5d701580d779e0f5684abc7b68 ] When using seg6 in encap mode, we call ipv6_dev_get_saddr() to set the source address of the outer IPv6 header, in ca

[PATCH 4.15 14/47] mlxsw: spectrum_buffers: Set a minimum quota for CPU port traffic

4.15-stable review patch. If anyone has any objections, please let me know. -- From: Ido Schimmel [ Upstream commit bcdd5de80a2275f7879dc278bfc747f1caf94442 ] In commit 9ffcc3725f09 ("mlxsw: spectrum: Allow packets to be trapped from any PG") I fixed a problem where packets c

[PATCH 4.15 45/47] qede: Fix qedr link update

4.15-stable review patch. If anyone has any objections, please let me know. -- From: Michal Kalderon [ Upstream commit 4609adc27175839408359822523de7247d56c87f ] Link updates were not reported to qedr correctly. Leading to cases where a link could be down, but qedr would see

[PATCH 4.14 11/43] ipv6: sr: fix scheduling in RCU when creating seg6 lwtunnel state

4.14-stable review patch. If anyone has any objections, please let me know. -- From: David Lebrun [ Upstream commit 191f86ca8ef27f7a492fd1c03620498c6e94f0ac ] The seg6_build_state() function is called with RCU read lock held, so we cannot use GFP_KERNEL. This patch uses GFP_A

[PATCH 4.14 14/43] net sched actions: return explicit error when tunnel_key mode is not specified

4.14-stable review patch. If anyone has any objections, please let me know. -- From: Roman Mashak [ Upstream commit 51d4740f88affd85d49c04e3c9cd129c0e33bcb9 ] If set/unset mode of the tunnel_key action is not provided, ->init() still returns 0, and the caller proceeds with bo

[PATCH 4.14 17/43] kcm: lock lower socket in kcm_attach

4.14-stable review patch. If anyone has any objections, please let me know. -- From: Tom Herbert [ Upstream commit 2cc683e88c0c993ac3721d9b702cb0630abe2879 ] Need to lock lower socket in order to provide mutual exclusion with kcm_unattach. v2: Add Reported-by for syzbot Fix

[PATCH 4.14 13/43] net: phy: Tell caller result of phy_change()

4.14-stable review patch. If anyone has any objections, please let me know. -- From: Brad Mouring [ Upstream commit a2c054a896b8ac794ddcfc7c92e2dc7ec4ed4ed5 ] In 664fcf123a30e (net: phy: Threaded interrupts allow some simplification) the phy_interrupt system was changed to us

[PATCH 4.14 03/43] qed: Fix non TCP packets should be dropped on iWARP ll2 connection

4.14-stable review patch. If anyone has any objections, please let me know. -- From: Michal Kalderon [ Upstream commit 16da09047d3fb991dc48af41f6d255fd578e8ca2 ] FW workaround. The iWARP LL2 connection did not expect TCP packets to arrive on it's connection. The fix drops any

[PATCH 4.14 19/43] ieee802154: 6lowpan: fix possible NULL deref in lowpan_device_event()

4.14-stable review patch. If anyone has any objections, please let me know. -- From: Eric Dumazet [ Upstream commit ca0edb131bdf1e6beaeb2b8289fd6b374b74147d ] A tun device type can trivially be set to arbitrary value using TUNSETLINK ioctl(). Therefore, lowpan_device_event()

[PATCH 4.14 00/43] 4.14.32-stable review

This is the start of the stable review cycle for the 4.14.32 release. There are 43 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Sat Mar 31 17:57:12 UTC 2018. Anything receiv

[PATCH 4.14 08/43] net: ipv6: keep sk status consistent after datagram connect failure

4.14-stable review patch. If anyone has any objections, please let me know. -- From: Paolo Abeni [ Upstream commit 2f987a76a97773beafbc615b9c4d8fe79129a7f4 ] On unsuccesful ip6_datagram_connect(), if the failure is caused by ip6_datagram_dst_update(), the sk peer information

[PATCH 4.14 30/43] net: Only honor ifindex in IP_PKTINFO if non-0

4.14-stable review patch. If anyone has any objections, please let me know. -- From: David Ahern [ Upstream commit 2cbb4ea7de167b02ffa63e9cdfdb07a7e7094615 ] Only allow ifindex from IP_PKTINFO to override SO_BINDTODEVICE settings if the index is actually set in the message.

[PATCH 4.14 06/43] devlink: Remove redundant free on error path

4.14-stable review patch. If anyone has any objections, please let me know. -- From: Arkadi Sharshevsky [ Upstream commit 7fe4d6dcbcb43fe0282d4213fc52be178bb30e91 ] The current code performs unneeded free. Remove the redundant skb freeing during the error path. Fixes: 1555d2

[PATCH 4.14 04/43] sysfs: symlink: export sysfs_create_link_nowarn()

4.14-stable review patch. If anyone has any objections, please let me know. -- From: Grygorii Strashko [ Upstream commit 2399ac42e762ab25c58420e25359b2921afdc55f ] The sysfs_create_link_nowarn() is going to be used in phylib framework in subsequent patch which can be built as

[PATCH 4.14 34/43] team: Fix double free in error path

4.14-stable review patch. If anyone has any objections, please let me know. -- From: Arkadi Sharshevsky [ Upstream commit cbcc607e18422555db569b593608aec26111cb0b ] The __send_and_alloc_skb() receives a skb ptr as a parameter but in case it fails the skb is not valid: - Send

[PATCH 4.14 36/43] dpaa_eth: fix error in dpaa_remove()

4.14-stable review patch. If anyone has any objections, please let me know. -- From: Madalin Bucur [ Upstream commit 88075256ee817041d68c2387f29065b5cb2b342a ] The recent changes that make the driver probing compatible with DSA were not propagated in the dpa_remove() function

[PATCH 4.14 32/43] qede: Fix qedr link update

4.14-stable review patch. If anyone has any objections, please let me know. -- From: Michal Kalderon [ Upstream commit 4609adc27175839408359822523de7247d56c87f ] Link updates were not reported to qedr correctly. Leading to cases where a link could be down, but qedr would see

Re: omap4-droid4: voice call support was Re: [PATCHv5,5/5] ARM: dts: omap4-droid4: add soundcard

On Thu 2018-03-29 09:34:50, Tony Lindgren wrote: > * Pavel Machek [180329 16:09]: > > > Then using the n_gsm ts 27.010 uart mux, I dial: > > > > > > ./ngsm-rw 1 "AT+CFUN=1" # connect to network > > > U0001+CFUN:OK > > > ./ngsm-rw 2 "AT+CMUT=0" # unmute speaker over ch2, do thi

[PATCH 4.14 22/43] dccp: check sk for closed state in dccp_sendmsg()

4.14-stable review patch. If anyone has any objections, please let me know. -- From: Alexey Kodanev [ Upstream commit 67f93df79aeefc3add4e4b31a752600f834236e2 ] dccp_disconnect() sets 'dp->dccps_hc_tx_ccid' tx handler to NULL, therefore if DCCP socket is disconnected and dccp

[PATCH 4.14 23/43] ipv6: fix access to non-linear packet in ndisc_fill_redirect_hdr_option()

4.14-stable review patch. If anyone has any objections, please let me know. -- From: Lorenzo Bianconi [ Upstream commit 9f62c15f28b0d1d746734666d88a79f08ba1e43e ] Fix the following slab-out-of-bounds kasan report in ndisc_fill_redirect_hdr_option when the incoming ipv6 packet

[PATCH 4.14 25/43] net: ethernet: arc: Fix a potential memory leak if an optional regulator is deferred

4.14-stable review patch. If anyone has any objections, please let me know. -- From: Christophe JAILLET [ Upstream commit 00777fac28ba3e126b9e63e789a613e8bd2cab25 ] If the optional regulator is deferred, we must release some resources. They will be re-allocated when the probe

[PATCH 4.14 27/43] net: fec: Fix unbalanced PM runtime calls

4.14-stable review patch. If anyone has any objections, please let me know. -- From: Florian Fainelli [ Upstream commit a069215cf5985f3aa1bba550264907d6bd05c5f7 ] When unbinding/removing the driver, we will run into the following warnings: [ 259.655198] fec 400d1000.etherne

[PATCH 4.9 11/28] ipv6: fix access to non-linear packet in ndisc_fill_redirect_hdr_option()

4.9-stable review patch. If anyone has any objections, please let me know. -- From: Lorenzo Bianconi [ Upstream commit 9f62c15f28b0d1d746734666d88a79f08ba1e43e ] Fix the following slab-out-of-bounds kasan report in ndisc_fill_redirect_hdr_option when the incoming ipv6 packet

[PATCH 4.9 19/28] skbuff: Fix not waking applications when errors are enqueued

4.9-stable review patch. If anyone has any objections, please let me know. -- From: Vinicius Costa Gomes [ Upstream commit 6e5d58fdc9bedd0255a8781b258f10bbdc63e975 ] When errors are enqueued to the error queue via sock_queue_err_skb() function, it is possible that the waiting

[PATCH 4.9 02/28] genirq: Track whether the trigger type has been set

4.9-stable review patch. If anyone has any objections, please let me know. -- From: Marc Zyngier commit 4f8413a3a799c958f7a10a6310a451e6b8aef5ad upstream. When requesting a shared interrupt, we assume that the firmware support code (DT or ACPI) has called irqd_set_trigger_type

[PATCH 4.9 12/28] l2tp: do not accept arbitrary sockets

4.9-stable review patch. If anyone has any objections, please let me know. -- From: Eric Dumazet [ Upstream commit 17cfe79a65f98abe535261856c5aef14f306dff7 ] syzkaller found an issue caused by lack of sufficient checks in l2tp_tunnel_create() RAW sockets can not be considere

[PATCH 4.9 24/28] s390/qeth: lock read device while queueing next buffer

4.9-stable review patch. If anyone has any objections, please let me know. -- From: Julian Wiedmann [ Upstream commit 17bf8c9b3d499d5168537c98b61eb7a1fcbca6c2 ] For calling ccw_device_start(), issue_next_read() needs to hold the device's ccwlock. This is satisfied for the IRQ

[PATCH 4.9 03/28] net sched actions: return explicit error when tunnel_key mode is not specified

4.9-stable review patch. If anyone has any objections, please let me know. -- From: Roman Mashak [ Upstream commit 51d4740f88affd85d49c04e3c9cd129c0e33bcb9 ] If set/unset mode of the tunnel_key action is not provided, ->init() still returns 0, and the caller proceeds with bog

[PATCH 4.9 21/28] soc/fsl/qbman: fix issue in qman_delete_cgr_safe()

4.9-stable review patch. If anyone has any objections, please let me know. -- From: Madalin Bucur [ Upstream commit 96f413f47677366e0ae03797409bfcc4151dbf9e ] The wait_for_completion() call in qman_delete_cgr_safe() was triggering a scheduling while atomic bug, replacing the

[PATCH 4.9 05/28] rhashtable: Fix rhlist duplicates insertion

4.9-stable review patch. If anyone has any objections, please let me know. -- From: Paul Blakey [ Upstream commit d3dcf8eb615537526bd42ff27a081d46d337816e ] When inserting duplicate objects (those with the same key), current rhlist implementation messes up the chain pointers

[PATCH 4.4 10/20] netlink: avoid a double skb free in genlmsg_mcast()

4.4-stable review patch. If anyone has any objections, please let me know. -- From: Nicolas Dichtel [ Upstream commit 02a2385f37a7c6594c9d89b64c4a1451276f08eb ] nlmsg_multicast() consumes always the skb, thus the original skb must be freed only when this function is called wi

[PATCH 4.9 06/28] sch_netem: fix skb leak in netem_enqueue()

4.9-stable review patch. If anyone has any objections, please let me know. -- From: Alexey Kodanev [ Upstream commit 35d889d10b649fda66121891ec05eca88150059d ] When we exceed current packets limit and we have more than one segment in the list returned by skb_gso_segment(), ne

[PATCH 4.4 06/20] l2tp: do not accept arbitrary sockets

4.4-stable review patch. If anyone has any objections, please let me know. -- From: Eric Dumazet [ Upstream commit 17cfe79a65f98abe535261856c5aef14f306dff7 ] syzkaller found an issue caused by lack of sufficient checks in l2tp_tunnel_create() RAW sockets can not be considere

[PATCH 4.4 04/20] dccp: check sk for closed state in dccp_sendmsg()

4.4-stable review patch. If anyone has any objections, please let me know. -- From: Alexey Kodanev [ Upstream commit 67f93df79aeefc3add4e4b31a752600f834236e2 ] dccp_disconnect() sets 'dp->dccps_hc_tx_ccid' tx handler to NULL, therefore if DCCP socket is disconnected and dccp_

Re: [PATCH 07/30] aio: add delayed cancel support

On Thu, Mar 29, 2018 at 03:25:06PM +0100, Al Viro wrote: > OK. Let's leave that alone for now. Re deferred cancels - AFAICS, we *must* > remove the sucker from ctx->active_reqs before dropping ->ctx_lock. > > As it is, you are creating a io_cancel()/io_cancel() race leading to double > fput().

[PATCH 4.4 20/20] net: systemport: Rewrite __bcm_sysport_tx_reclaim()

4.4-stable review patch. If anyone has any objections, please let me know. -- From: Florian Fainelli [ Upstream commit 484d802d0f2f29c335563fcac2a8facf174a1bbc ] There is no need for complex checking between the last consumed index and current consumed index, a simple subtrac

[PATCH 4.4 02/20] genirq: Track whether the trigger type has been set

4.4-stable review patch. If anyone has any objections, please let me know. -- From: Marc Zyngier commit 4f8413a3a799c958f7a10a6310a451e6b8aef5ad upstream. When requesting a shared interrupt, we assume that the firmware support code (DT or ACPI) has called irqd_set_trigger_type

[PATCH 4.4 18/20] ieee802154: 6lowpan: fix possible NULL deref in lowpan_device_event()

4.4-stable review patch. If anyone has any objections, please let me know. -- From: Eric Dumazet [ Upstream commit ca0edb131bdf1e6beaeb2b8289fd6b374b74147d ] A tun device type can trivially be set to arbitrary value using TUNSETLINK ioctl(). Therefore, lowpan_device_event()

[PATCH 4.4 13/20] team: Fix double free in error path

4.4-stable review patch. If anyone has any objections, please let me know. -- From: Arkadi Sharshevsky [ Upstream commit cbcc607e18422555db569b593608aec26111cb0b ] The __send_and_alloc_skb() receives a skb ptr as a parameter but in case it fails the skb is not valid: - Send f

[PATCH 4.4 19/20] net: fec: Fix unbalanced PM runtime calls

4.4-stable review patch. If anyone has any objections, please let me know. -- From: Florian Fainelli [ Upstream commit a069215cf5985f3aa1bba550264907d6bd05c5f7 ] When unbinding/removing the driver, we will run into the following warnings: [ 259.655198] fec 400d1000.ethernet

Re: [PATCH v7 05/14] ext4, dax: introduce ext4_dax_aops

On Thu, Mar 29, 2018 at 05:40:35PM +0200, Jan Kara wrote: > So ext4_direct_IO() for IS_DAX() files will just bail out. So could you > just provide ext4_dax_direct_IO() which will bail out and use it here? With > a similar comment as in xfs_vm_direct_IO() that open still needs this > method set... T

Re: [PATCH 10/10] softirq: Remove __ARCH_SET_SOFTIRQ_PENDING

On Thu, Mar 29, 2018 at 04:53:43PM +0200, Martin Schwidefsky wrote: > The lowcore optimization for softirq_pending field is not really needed, > just nice to have. But if there is a strong reason to make a common > definition for it we can certainly do that. A slightly related question; would it m

[PATCH 4.4 16/20] s390/qeth: lock read device while queueing next buffer

4.4-stable review patch. If anyone has any objections, please let me know. -- From: Julian Wiedmann [ Upstream commit 17bf8c9b3d499d5168537c98b61eb7a1fcbca6c2 ] For calling ccw_device_start(), issue_next_read() needs to hold the device's ccwlock. This is satisfied for the IRQ

[PATCH 4.4 17/20] s390/qeth: on channel error, reject further cmd requests

4.4-stable review patch. If anyone has any objections, please let me know. -- From: Julian Wiedmann [ Upstream commit a6c3d93963e4b333c764fde69802c3ea9eaa9d5c ] When the IRQ handler determines that one of the cmd IO channels has failed and schedules recovery, block any furthe

[PATCH 4.4 14/20] s390/qeth: free netdevice when removing a card

4.4-stable review patch. If anyone has any objections, please let me know. -- From: Julian Wiedmann [ Upstream commit 6be687395b3124f002a653c1a50b3260222b3cd7 ] On removal, a qeth card's netdevice is currently not properly freed because the call chain looks as follows: qeth_

[PATCH 4.4 09/20] net/iucv: Free memory obtained by kzalloc

4.4-stable review patch. If anyone has any objections, please let me know. -- From: Arvind Yadav [ Upstream commit fa6a91e9b907231d2e38ea5ed89c537b3525df3d ] Free memory by calling put_device(), if afiucv_iucv_init is not successful. Signed-off-by: Arvind Yadav Reviewed-by:

Re: [PATCH] media: i2c: tvp5150: fix color burst lock instability on some hardware

On Thu, Mar 29, 2018 at 12:02:40PM -0300, Mauro Carvalho Chehab wrote: > Em Thu, 29 Mar 2018 19:04:35 +0430 > Nasser escreveu: > > > On Tue, Mar 27, 2018 at 02:59:21AM +0430, Nasser wrote: > > Hi Mauro, > > > > Thank you for taking time to review my patch. > > > > May be I should rephrase the c

[PATCH 4.4 15/20] s390/qeth: when thread completes, wake up all waiters

4.4-stable review patch. If anyone has any objections, please let me know. -- From: Julian Wiedmann [ Upstream commit 1063e432bb45be209427ed3f1ca3908e4aa3c7d7 ] qeth_wait_for_threads() is potentially called by multiple users, make sure to notify all of them after qeth_clear_t

[PATCH 4.4 00/20] 4.4.126-stable review

This is the start of the stable review cycle for the 4.4.126 release. There are 20 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Sat Mar 31 17:57:30 UTC 2018. Anything receiv

Re: [RFC PATCH for 4.17 02/21] rseq: Introduce restartable sequences system call (v12)

On Thu, 29 Mar 2018 14:02:33 -0400 (EDT) Mathieu Desnoyers wrote: > Currently, anyone using ptrace on a process has pretty much given up all > hopes of performance. Processes will use rseq to gain performance, not the > opposite, so this deterioration will be unwelcome. The ptrace path has nothi

[PATCH 4.4 07/20] net: ethernet: arc: Fix a potential memory leak if an optional regulator is deferred

4.4-stable review patch. If anyone has any objections, please let me know. -- From: Christophe JAILLET [ Upstream commit 00777fac28ba3e126b9e63e789a613e8bd2cab25 ] If the optional regulator is deferred, we must release some resources. They will be re-allocated when the probe

[PATCH 4.4 05/20] ipv6: fix access to non-linear packet in ndisc_fill_redirect_hdr_option()

4.4-stable review patch. If anyone has any objections, please let me know. -- From: Lorenzo Bianconi [ Upstream commit 9f62c15f28b0d1d746734666d88a79f08ba1e43e ] Fix the following slab-out-of-bounds kasan report in ndisc_fill_redirect_hdr_option when the incoming ipv6 packet

Re: [PATCH] xfs: always free inline data before resetting inode fork during ifree

On Thu, Mar 29, 2018 at 10:05:35AM +1100, Dave Chinner wrote: > On Wed, Mar 28, 2018 at 07:30:06PM +, Sasha Levin wrote: > > > > This is actually something I want maintainers to dictate. What sort of > > testing would make the XFS folks happy here? Right now I'm doing > > "./check 'xfs/*'" wit

Re: [RFC][PATCH] ipc: Remove IPCMNI

Hello Mathew, On 03/29/2018 12:56 PM, Matthew Wilcox wrote: On Thu, Mar 29, 2018 at 10:47:45AM +0200, Manfred Spraul wrote: This can be implemented trivially with the current code using idr_alloc_cyclic. Is there a performance impact? Right now, the idr tree is only large if there are lots of

[PATCH 4.4 03/20] net: Fix hlist corruptions in inet_evict_bucket()

4.4-stable review patch. If anyone has any objections, please let me know. -- From: Kirill Tkhai [ Upstream commit a560002437d3646dafccecb1bf32d1685112ddda ] inet_evict_bucket() iterates global list, and several tasks may call it in parallel. All of them hash the same fq->lis

[PATCH 4.4 12/20] skbuff: Fix not waking applications when errors are enqueued

4.4-stable review patch. If anyone has any objections, please let me know. -- From: Vinicius Costa Gomes [ Upstream commit 6e5d58fdc9bedd0255a8781b258f10bbdc63e975 ] When errors are enqueued to the error queue via sock_queue_err_skb() function, it is possible that the waiting

[PATCH 4.4 11/20] net: Only honor ifindex in IP_PKTINFO if non-0

4.4-stable review patch. If anyone has any objections, please let me know. -- From: David Ahern [ Upstream commit 2cbb4ea7de167b02ffa63e9cdfdb07a7e7094615 ] Only allow ifindex from IP_PKTINFO to override SO_BINDTODEVICE settings if the index is actually set in the message. S

[PATCH 4.9 08/28] net: use skb_to_full_sk() in skb_update_prio()

4.9-stable review patch. If anyone has any objections, please let me know. -- From: Eric Dumazet [ Upstream commit 4dcb31d4649df36297296b819437709f5407059c ] Andrei Vagin reported a KASAN: slab-out-of-bounds error in skb_update_prio() Since SYNACK might be attached to a requ

[PATCH 4.4 01/20] scsi: sg: dont return bogus Sg_requests

4.4-stable review patch. If anyone has any objections, please let me know. -- From: Johannes Thumshirn commit 48ae8484e9fc324b4968d33c585e54bc98e44d61 upstream. If the list search in sg_get_rq_mark() fails to find a valid request, we return a bogus element. This then can later

[PATCH 4.9 09/28] net: Fix hlist corruptions in inet_evict_bucket()

4.9-stable review patch. If anyone has any objections, please let me know. -- From: Kirill Tkhai [ Upstream commit a560002437d3646dafccecb1bf32d1685112ddda ] inet_evict_bucket() iterates global list, and several tasks may call it in parallel. All of them hash the same fq->lis

[PATCH 4.9 00/28] 4.9.92-stable review

This is the start of the stable review cycle for the 4.9.92 release. There are 28 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made by Sat Mar 31 17:57:18 UTC 2018. Anything receive

[PATCH 4.9 07/28] ieee802154: 6lowpan: fix possible NULL deref in lowpan_device_event()

4.9-stable review patch. If anyone has any objections, please let me know. -- From: Eric Dumazet [ Upstream commit ca0edb131bdf1e6beaeb2b8289fd6b374b74147d ] A tun device type can trivially be set to arbitrary value using TUNSETLINK ioctl(). Therefore, lowpan_device_event()

Re: [PATCH v5 1/9] sysctl: Add flags to support min/max range clamping

On Mon, Mar 19, 2018 at 11:39:19AM -0400, Waiman Long wrote: > On 03/16/2018 09:10 PM, Luis R. Rodriguez wrote: > > On Fri, Mar 16, 2018 at 02:13:42PM -0400, Waiman Long wrote: > >> When the CTL_FLAGS_CLAMP_RANGE flag is set in the ctl_table > >> entry, any update from the userspace will be clamped

<    2   3   4   5   6   7   8   9   10   11   >