Re: Simplifying our RCU models

2018-03-06 Thread Paul E. McKenney
On Tue, Mar 06, 2018 at 10:00:50AM +0100, Ingo Molnar wrote: > > * Ingo Molnar wrote: > > >I.e. the new RCU namespace would be something like: > > > > call_rcu => rcu_call_rcu > > typo: rcu_call(). > > > synchronize_rcu => rcu_wait_ > > typo: rc

Re: [PATCH v2 6/8] [PATCH 6/8] Documentation: hwmon: Add a document for PECI hwmon client driver

2018-03-06 Thread Jae Hyun Yoo
Hi Randy, On 3/6/2018 12:28 PM, Randy Dunlap wrote: Hi, On 02/21/2018 08:16 AM, Jae Hyun Yoo wrote: +temp_labelProvides DDR DIMM temperature if this label indicates + 'DIMM #'. +temp_inputProvides current temperature of the DDR DIMM. + +Note: +

Re: [PATCH] mm: might_sleep warning

2018-03-06 Thread Pavel Tatashin
> > > > spin_lock(&deferred_zone_grow_lock); > > > > - static_branch_disable(&deferred_pages); > > > > + deferred_zone_grow = false; > > > > spin_unlock(&deferred_zone_grow_lock); > > > > + static_branch_disable(&deferred_pages); > > > > > > > > /* There will be num_no

Re: [RFC PATCH 0/4 v2] Define killable version for access_remote_vm() and use it in fs/proc

2018-03-06 Thread Yang Shi
On 3/6/18 12:45 PM, Andrew Morton wrote: On Tue, 27 Feb 2018 08:25:47 +0800 Yang Shi wrote: Background: When running vm-scalability with large memory (> 300GB), the below hung task issue happens occasionally. INFO: task ps:14018 blocked for more than 120 seconds. Tainted: G

Re: [PATCH] parisc: time: stop validating rtc_time in .read_time

2018-03-06 Thread Helge Deller
On 21.02.2018 22:40, Alexandre Belloni wrote: > The RTC core is always calling rtc_valid_tm after the read_time callback. > It is not necessary to call it just before returning from the callback. > > Signed-off-by: Alexandre Belloni Acked-by: Helge Deller Thanks! Helge > --- > arch/parisc/k

Re: [PATCH] mm: might_sleep warning

2018-03-06 Thread Andrew Morton
On Tue, 6 Mar 2018 16:04:06 -0500 Pavel Tatashin wrote: > > > > > spin_lock(&deferred_zone_grow_lock); > > > > > - static_branch_disable(&deferred_pages); > > > > > + deferred_zone_grow = false; > > > > > spin_unlock(&deferred_zone_grow_lock); > > > > > + static_branch_di

Re: [PATCH 4.4 03/34] mtd: nand: gpmi: Fix failure when a erased page has a bitflip at BBM

2018-03-06 Thread Ben Hutchings
On Fri, 2018-03-02 at 09:50 +0100, Greg Kroah-Hartman wrote: > 4.4-stable review patch.  If anyone has any objections, please let me know. > > -- > > From: Sascha Hauer > > > [ Upstream commit fdf2e821052958a114618a95ab18a300d0b080cb ] > > When erased subpages are read then th

Re: [PATCH 03/11] Staging: iio: accel: Remove unnecessary comments

2018-03-06 Thread Shreeya Patel
On Mon, 2018-03-05 at 13:19 +0530, Himanshu Jha wrote: > Remove unnecessary comments since the definitions are pretty clear > with their macro names. > > Signed-off-by: Himanshu Jha > --- >  drivers/staging/iio/accel/adis16201.c | 82 +-- > >  1 file changed, 10 in

Re: [PATCH 0/29] arm meltdown fix backporting review for lts 4.9

2018-03-06 Thread Mark Brown
On Tue, Mar 06, 2018 at 09:25:25AM -0800, Greg KH wrote: > On Tue, Mar 06, 2018 at 02:26:34PM +, Mark Brown wrote: > > I'm not far enough into the details to comment on the specifics here; > > there's other people in the CCs who are. Let's let people look at the > > code and see if they think

Re: dm-bufio: avoid false-positive Wmaybe-uninitialized warning

2018-03-06 Thread Arnd Bergmann
On Thu, Feb 22, 2018 at 5:04 PM, Mike Snitzer wrote: > On Thu, Feb 22 2018 at 10:56am -0500, > Arnd Bergmann wrote: > > Mikulas already sent a fix for this: > https://patchwork.kernel.org/patch/10211631/ > > But I like yours a bit better, though I'll likely move the declaration > of 'noio_flag'

Re: Regulator regression in next-20180305

2018-03-06 Thread Mark Brown
On Tue, Mar 06, 2018 at 05:06:48PM -0300, Fabio Estevam wrote: > On Tue, Mar 6, 2018 at 4:12 PM, Mark Brown wrote: > > Yeah, that's what I expected. What we really need to figure out I think > > is what exactly is taking the lock that we end up colliding with, I > > don't seem to be able to repr

Re: [RFC PATCH 0/4 v2] Define killable version for access_remote_vm() and use it in fs/proc

2018-03-06 Thread Andrew Morton
On Tue, 6 Mar 2018 13:17:37 -0800 Yang Shi wrote: > > > It just mitigates the hung task warning, can't resolve the mmap_sem > scalability issue. Furthermore, waiting on pure uninterruptible state > for reading /proc sounds unnecessary. It doesn't wait for I/O completion. OK. > > > > Where t

Re: [PATCH v3 03/10] drivers: qcom: rpmh-rsc: log RPMH requests in FTRACE

2018-03-06 Thread Steven Rostedt
On Tue, 6 Mar 2018 13:38:06 +0800 kbuild test robot wrote: > >> drivers/soc/qcom/./trace-rpmh.h:29:3: error: implicit declaration of > >> function '__assign_string'; did you mean '__assign_str'? > >> [-Werror=implicit-function-declaration] Yes, you meant __assign_str(). I may have said __ass

[PATCH v2] scsi: sd: Keep disk read-only when re-reading partition

2018-03-06 Thread Jeremy Cline
If the read-only flag is true on a SCSI disk, re-reading the partition table sets the flag back to false. To observe this bug, you can run: 1. blockdev --setro /dev/sda 2. blockdev --rereadpt /dev/sda 3. blockdev --getro /dev/sda This commit reads the disk's old state and combines it with the de

Re: [PATCH] mm: might_sleep warning

2018-03-06 Thread Pavel Tatashin
That's why page_alloc_init_late() needs spin_lock_irq(). If a CPU is holding deferred_zone_grow_lock with enabled interrupts and an interrupt comes in on that CPU and the CPU runs deferred_grow_zone() in its interrupt handler, we deadlock. lockdep knows about this bug and should have reported it

Re: [PATCH v3 03/10] drivers: qcom: rpmh-rsc: log RPMH requests in FTRACE

2018-03-06 Thread Lina Iyer
On Tue, Mar 06 2018 at 14:47 -0700, Steven Rostedt wrote: On Tue, 6 Mar 2018 13:38:06 +0800 kbuild test robot wrote: >> drivers/soc/qcom/./trace-rpmh.h:29:3: error: implicit declaration of function '__assign_string'; did you mean '__assign_str'? [-Werror=implicit-function-declaration] Yes,

Re: [PATCH 1/3 RESEND] tpm: add longer timeouts for creation commands.

2018-03-06 Thread Jason Gunthorpe
On Tue, Mar 06, 2018 at 01:36:36PM -0500, Mimi Zohar wrote: > On Tue, 2018-03-06 at 08:32 -0800, James Bottomley wrote: > > On Tue, 2018-03-06 at 08:06 +, Winkler, Tomas wrote: > > > > > > > > > > > > On Mon, Mar 05, 2018 at 01:09:09PM +, Winkler, Tomas wrote: > > > > > > > > > > Why you

[PATCH] ARM: dts: i.MX25: define SSI FIFO depth

2018-03-06 Thread Martin Kaiser
According to the i.MX25 reference manuals, each SSI has four FIFOs. All of those FIFOs can store up to 15 entries. The fsl_ssi driver's internal default for the FIFO depth in 8. Set our non-default FIFO depth explicitly in the Device Tree. Signed-off-by: Martin Kaiser --- arch/arm/boot/dts/imx2

[PATCH] clk: imx25: set correct parents for ssi ipg clocks

2018-03-06 Thread Martin Kaiser
The ssi1_ipg clock depends on ssi1_ipg_per. Set ssi1_ipg_per as parent clock of ssi1_ipg. Without this link, the fsl_ssi driver does not activate the ssi1_ipg clock correctly and ssi1 is unable to transfer audio data. Fix the parent clock of ssi2 as well, it shows the same behaviour. Signed-off-b

Re: [PATCH] ftrace: nuke clear_ftrace_function

2018-03-06 Thread Steven Rostedt
On Tue, 6 Mar 2018 19:30:28 +0800 Yisheng Xie wrote: > hi Steven and all, > Ping, for month passed, do you have any comment about this patch? Sorry you got me in the midst of traveling and other issues. This patch looks fine, I'll queue it up. I'm currently working on some code so I wont be pus

Re: [PATCH] ARM: dts: i.MX25: define SSI FIFO depth

2018-03-06 Thread Fabio Estevam
On Tue, Mar 6, 2018 at 6:58 PM, Martin Kaiser wrote: > According to the i.MX25 reference manuals, each SSI has four FIFOs. All > of those FIFOs can store up to 15 entries. > > The fsl_ssi driver's internal default for the FIFO depth in 8. Set our > non-default FIFO depth explicitly in the Device T

Re: [PATCH 2/2] trace_uprobe: Simplify probes_seq_show()

2018-03-06 Thread Kees Cook
On Tue, Mar 6, 2018 at 12:12 AM, Ravi Bangoria wrote: > > > On 02/08/2018 09:13 AM, Ravi Bangoria wrote: >> >> On 02/08/2018 08:59 AM, Kees Cook wrote: >>> On Tue, Feb 6, 2018 at 8:34 PM, Ravi Bangoria >>> wrote: Simplify probes_seq_show() function. We are using %lx to display the offse

Re: [PATCH v3 03/10] drivers: qcom: rpmh-rsc: log RPMH requests in FTRACE

2018-03-06 Thread Lina Iyer
On Tue, Mar 06 2018 at 14:56 -0700, Lina Iyer wrote: On Tue, Mar 06 2018 at 14:47 -0700, Steven Rostedt wrote: On Tue, 6 Mar 2018 13:38:06 +0800 kbuild test robot wrote: drivers/soc/qcom/./trace-rpmh.h:29:3: error: implicit declaration of function '__assign_string'; did you mean '__assign_st

Re: [PATCH v4 1/2] drivers: qcom: add command DB driver

2018-03-06 Thread Stephen Boyd
Quoting Lina Iyer (2018-03-06 08:21:40) > On Mon, Mar 05 2018 at 11:42 -0700, Stephen Boyd wrote: > >Quoting Lina Iyer (2018-02-26 09:58:01) > > >> +} > >> +EXPORT_SYMBOL(cmd_db_ready); > >> + > >> +static u64 cmd_db_get_u64_id(const char *id) > >> +{ > >> + u64 rsc_id = 0; > >> + u8 *

Re: [PATCH v4 1/2] drivers: qcom: add command DB driver

2018-03-06 Thread Stephen Boyd
Quoting Lina Iyer (2018-03-06 08:56:19) > On Tue, Mar 06 2018 at 09:21 -0700, Lina Iyer wrote: > >On Mon, Mar 05 2018 at 11:42 -0700, Stephen Boyd wrote: > >>Quoting Lina Iyer (2018-02-26 09:58:01) > >>>+size_t cmd_db_read_aux_data_len(const char *id) > >>>+{ > >>>+ int ret; > >>>+ stru

Re: Regulator regression in next-20180305

2018-03-06 Thread Fabio Estevam
On Tue, Mar 6, 2018 at 6:33 PM, Mark Brown wrote: > No, unfortunately, apart from the generic kernel ones (like lockdep). > I'll try to have a poke at adding some tomorrow, though I'm also > considering just dropping the series for now. Ok, lockdep is already enabled by default in the defconfig

Re: [PATCH] usb,signal,security: only pass the cred, not the secid, to kill_pid_info_as_cred and security_task_kill

2018-03-06 Thread James Morris
On Tue, 6 Mar 2018, Casey Schaufler wrote: > On 3/6/2018 11:01 AM, Paul Moore wrote: > > On Fri, Sep 8, 2017 at 6:09 PM, James Morris wrote: > >> On Fri, 8 Sep 2017, Paul Moore wrote: > >>> Looks fine to me from a SELinux perspective. If Casey and John are > >>> happy with this I can volunteer t

Re: [PATCH v3 07/10] drivers: qcom: rpmh: cache sleep/wake state requests

2018-03-06 Thread Lina Iyer
On Mon, Mar 05 2018 at 13:45 -0700, Evan Green wrote: Hi Lina, On Fri, Mar 2, 2018 at 8:43 AM, Lina Iyer wrote: Active state requests are sent immediately to the mailbox controller, while sleep and wake state requests are cached in this driver to avoid taxing the mailbox controller repeatedly.

Re: [RESEND PATCH v3] crypto: add zBeWalgo compression for zram

2018-03-06 Thread Eric Biggers
Hi Benjamin, On Tue, Mar 06, 2018 at 09:23:08PM +0100, Benjamin Warnke wrote: > Currently ZRAM uses compression-algorithms from the crypto-api. ZRAM > compresses each page individually. As a result the compression algorithm is > forced to use a very small sliding window. None of the available comp

Re: [PATCH v7 13/13] arm64: topology: divorce MC scheduling domain from core_siblings

2018-03-06 Thread Jeremy Linton
Hi, On 03/06/2018 10:07 AM, Morten Rasmussen wrote: On Tue, Feb 27, 2018 at 02:18:47PM -0600, Jeremy Linton wrote: Hi, First, thanks for taking a look at this. On 03/01/2018 09:52 AM, Morten Rasmussen wrote: Hi Jeremy, On Wed, Feb 28, 2018 at 04:06:19PM -0600, Jeremy Linton wrote: Now tha

Re: [PATCH] clk: imx25: set correct parents for ssi ipg clocks

2018-03-06 Thread Fabio Estevam
Hi Martin, On Tue, Mar 6, 2018 at 7:02 PM, Martin Kaiser wrote: > The ssi1_ipg clock depends on ssi1_ipg_per. Set ssi1_ipg_per as parent > clock of ssi1_ipg. Without this link, the fsl_ssi driver does not > activate the ssi1_ipg clock correctly and ssi1 is unable to transfer > audio data. > > Fix

Re: [PATCH 03/11] Staging: iio: accel: Remove unnecessary comments

2018-03-06 Thread Himanshu Jha
Hi Shreeya, > I was just going through your patch for giving myself  > a habit of reading patches. Great! > I see here that there are many comments which are necessary > have also been removed. > Jonathan told that some of the names do not explain > much about the how registers are related to th

Re: [PATCH bpf-next v8 00/11] Landlock LSM: Toward unprivileged sandboxing

2018-03-06 Thread Mickaël Salaün
On 28/02/2018 00:09, Andy Lutomirski wrote: > On Tue, Feb 27, 2018 at 10:03 PM, Mickaël Salaün wrote: >> >> On 27/02/2018 05:36, Andy Lutomirski wrote: >>> On Tue, Feb 27, 2018 at 12:41 AM, Mickaël Salaün wrote: Hi, > ## Why use the seccomp(2) syscall? Landlock us

Re: [PATCH bpf-next v8 08/11] landlock: Add ptrace restrictions

2018-03-06 Thread Mickaël Salaün
On 28/02/2018 01:09, Andy Lutomirski wrote: > On Wed, Feb 28, 2018 at 12:00 AM, Mickaël Salaün wrote: >> >> On 28/02/2018 00:23, Andy Lutomirski wrote: >>> On Tue, Feb 27, 2018 at 11:02 PM, Andy Lutomirski wrote: On Tue, Feb 27, 2018 at 10:14 PM, Mickaël Salaün wrote: > I thi

Re: [PATCH v3 02/10] dt-bindings: introduce RPMH RSC bindings for Qualcomm SoCs

2018-03-06 Thread Stephen Boyd
Quoting Lina Iyer (2018-03-02 08:43:09) > Add device binding documentation for Qualcomm Technology Inc's RPMH RSC > driver. The hardware block is used for communicating resource state s/driver/hardware/ > requests for shared resources. > > Cc: devicet...@vger.kernel.org > Signed-off-by: Lina Iye

Re: + mm-relax-ptrace-mode-in-process_vm_readv2.patch added to -mm tree

2018-03-06 Thread Kees Cook
On Tue, Mar 6, 2018 at 10:03 AM, Alexey Dobriyan wrote: > On Tue, Mar 06, 2018 at 08:42:19PM +0300, Alexey Dobriyan wrote: >> On Mon, Mar 05, 2018 at 05:02:08PM -0800, Kees Cook wrote: >> > On Mon, Mar 5, 2018 at 4:07 PM, wrote: >> >> > > It is more natural to check for read-from-memory permissi

Re: [PATCH 1/1] mm: make start_isolate_page_range() fail if already isolated

2018-03-06 Thread Andrew Morton
On Mon, 5 Mar 2018 16:57:40 -0800 Mike Kravetz wrote: > >>> > >>> I could not immediately come up with a good idea here. The zone lock > >>> would be the obvious choice, but I don't think we want to hold it while > >>> examining each of the page blocks. Perhaps a new lock or semaphore > >>> ass

Re: [PATCH bpf-next v8 00/11] Landlock LSM: Toward unprivileged sandboxing

2018-03-06 Thread Andy Lutomirski
On Tue, Mar 6, 2018 at 10:25 PM, Mickaël Salaün wrote: > > > On 28/02/2018 00:09, Andy Lutomirski wrote: >> On Tue, Feb 27, 2018 at 10:03 PM, Mickaël Salaün wrote: >>> >>> On 27/02/2018 05:36, Andy Lutomirski wrote: On Tue, Feb 27, 2018 at 12:41 AM, Mickaël Salaün wrote: > Hi, > >>

Re: [PATCH v3 03/10] drivers: qcom: rpmh-rsc: log RPMH requests in FTRACE

2018-03-06 Thread Steven Rostedt
On Tue, 6 Mar 2018 15:05:42 -0700 Lina Iyer wrote: > Duh. FTRACE seems to have been disabled. Will fix and update. Don't feel bad. You're not alone, I've done that too ;-) -- Steve

[PATCH v2] mm: might_sleep warning

2018-03-06 Thread Pavel Tatashin
Robot reported this issue: https://lkml.org/lkml/2018/2/27/851 That is introduced by: mm: initialize pages on demand during boot The problem is caused by changing static branch value within spin lock. Spin lock disables preemption, and changing static branch value takes mutex lock in its path, an

[PATCH] iommu/vt-d: fix usage of force parameter in intel_ir_reconfigure_irte()

2018-03-06 Thread Jagannathan Raman
It was noticed that the IRTE configured for guest OS kernel was over-written while the guest was running. As a result, vt-d Posted Interrupts configured for the guest are not being delivered directly, and instead bounces off the host. Every interrupt delivery takes a VM Exit. It was noticed that t

Re: [PATCH bpf-next v8 00/11] Landlock LSM: Toward unprivileged sandboxing

2018-03-06 Thread Tycho Andersen
On Tue, Mar 06, 2018 at 10:33:17PM +, Andy Lutomirski wrote: > >> Suppose I'm writing a container manager. I want to run "mount" in the > >> container, but I don't want to allow moun() in general and I want to > >> emulate certain mount() actions. I can write a filter that catches > >> mount

Re: [PATCH v12 02/11] mm, swap: Add infrastructure for saving page metadata on swap

2018-03-06 Thread Andrew Morton
On Wed, 21 Feb 2018 10:15:44 -0700 Khalid Aziz wrote: > If a processor supports special metadata for a page, for example ADI > version tags on SPARC M7, this metadata must be saved when the page is > swapped out. The same metadata must be restored when the page is swapped > back in. This patch ad

Re: [PATCH v12 09/11] mm: Allow arch code to override copy_highpage()

2018-03-06 Thread Andrew Morton
On Wed, 21 Feb 2018 10:15:51 -0700 Khalid Aziz wrote: > Some architectures can support metadata for memory pages and when a > page is copied, its metadata must also be copied. Sparc processors > from M7 onwards support metadata for memory pages. This metadata > provides tag based protection for a

Re: [PATCH v12 07/11] mm: Add address parameter to arch_validate_prot()

2018-03-06 Thread Andrew Morton
On Wed, 21 Feb 2018 10:15:49 -0700 Khalid Aziz wrote: > A protection flag may not be valid across entire address space and > hence arch_validate_prot() might need the address a protection bit is > being set on to ensure it is a valid protection flag. For example, sparc > processors support memory

Re: [PATCH v12 08/11] mm: Clear arch specific VM flags on protection change

2018-03-06 Thread Andrew Morton
On Wed, 21 Feb 2018 10:15:50 -0700 Khalid Aziz wrote: > When protection bits are changed on a VMA, some of the architecture > specific flags should be cleared as well. An examples of this are the > PKEY flags on x86. This patch expands the current code that clears > PKEY flags for x86, to support

Re: Warning from swake_up_all in 4.14.15-rt13 non-RT

2018-03-06 Thread Corey Minyard
On 03/06/2018 11:46 AM, Sebastian Andrzej Siewior wrote: On 2018-03-05 09:08:11 [-0600], Corey Minyard wrote: Starting with the change 8a64547a07980f9d25e962a78c2e10ee82bdb742 fs/dcache: use swait_queue instead of waitqueue … The following change is the obvious reason: --- a/kernel/sched/swa

Re: [PATCH] dump_stack: convert generic dump_stack into a weak symbol

2018-03-06 Thread Stephen Rothwell
Hi all, On Tue, 6 Mar 2018 13:43:26 +0100 Petr Mladek wrote: > > Greentime Hu, > > the for-4.17 branch in printk.git is based on Linus' tree. Therefore > I had to remove the hunk against arch/nds32/kernel/traps.c because > this file is only in linux-next. > > I think that it might be easier if

[PATCH 1/2] lkdtm: Relocate code to subdirectory

2018-03-06 Thread Kees Cook
The LKDTM modules keep expanding, and it's getting weird to have each file get a prefix. Instead, move to a subdirectory for cleaner handling. Signed-off-by: Kees Cook --- MAINTAINERS | 2 +- drivers/misc/Makefile | 20 +-

[PATCH 0/2] lkdtm: Relocate code to subdirectory

2018-03-06 Thread Kees Cook
Hi Greg, Please take these two patches for LKDTM. The first is a mass renaming to move under a new "lkdtm" subdirectory in drivers/misc. The second just adds a missed SPDX line to one of the LKDTM source files. Thanks! -Kees

[PATCH 2/2] lkdtm: Add missing SPDX-License-Identifier line

2018-03-06 Thread Kees Cook
The refcount.c file missed the mass-addition of the SPDX lines. Signed-off-by: Kees Cook --- drivers/misc/lkdtm/refcount.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/misc/lkdtm/refcount.c b/drivers/misc/lkdtm/refcount.c index 2b99d448e7fd..0a146b32da13 100644 --- a/drivers/misc/

Re: [PATCH v3 02/10] include: Move compat_timespec/ timeval to compat_time.h

2018-03-06 Thread Deepa Dinamani
On Tue, Mar 6, 2018 at 4:48 AM, Christian Borntraeger wrote: > > > On 03/06/2018 01:46 PM, Arnd Bergmann wrote: >> On Mon, Mar 5, 2018 at 10:30 AM, Christian Borntraeger >> wrote: >>> On 01/16/2018 03:18 AM, Deepa Dinamani wrote: All the current architecture specific defines for these a

Re: [PATCH bpf-next v8 00/11] Landlock LSM: Toward unprivileged sandboxing

2018-03-06 Thread Mickaël Salaün
On 06/03/2018 23:46, Tycho Andersen wrote: > On Tue, Mar 06, 2018 at 10:33:17PM +, Andy Lutomirski wrote: Suppose I'm writing a container manager. I want to run "mount" in the container, but I don't want to allow moun() in general and I want to emulate certain mount() actions.

[PATCH] Add an option to dm-verity to validate hashes at most once

2018-03-06 Thread Patrik Torstensson
Add an option to dm-verity to validate hashes at most once to allow platforms that is CPU/memory contraint to be protected by dm-verity against offline attacks. The option introduces a bitset that is used to check if a block has been validated before or not. A block can be validated more than once

Re: [PATCH v4] pstore: add lz4hc and 842 compression support

2018-03-06 Thread Kees Cook
On Mon, Feb 12, 2018 at 10:40 PM, Geliang Tang wrote: > Currently, pstore has supported three compression algorithms: zlib, > lzo and lz4. This patch added two more compression algorithms: lz4hc > and 842. > > Signed-off-by: Geliang Tang Thanks for the updates, I've applied this. I'll send a fol

Re: [PATCH] ubi: Reject MLC NAND

2018-03-06 Thread Pavel Machek
On Sat 2018-03-03 11:45:54, Richard Weinberger wrote: > While UBI and UBIFS seem to work at first sight with MLC NAND, you will > most likely lose all your data upon a power-cut or due to read/write > disturb. > In order to protect users from bad surprises, refuse to attach to MLC > NAND. > > Cc:

[PATCH -next] pstore: Avoid size casts for 842 compression

2018-03-06 Thread Kees Cook
Instead of casting, make sure we don't end up with giant values and just perform regular assignments with unsigned int instead of re-cast size_t. Signed-off-by: Kees Cook --- fs/pstore/platform.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/fs/pstore/pl

Re: C tricks for efficient stack zeroing

2018-03-06 Thread Pavel Machek
Hi! > do_something(u8 *output, const u8 *input) > thing1(...) > thing2(...) > thinga(...) > thingb(...) >thingi(...) > thingc(...) > thing3(...) > thing4(...) > thinga(...) > thingc(...) > > Each one of these functions have a few

Re: [PATCH V2 5/7] thermal/drivers/cpu_cooling: Add idle cooling device documentation

2018-03-06 Thread Pavel Machek
Hi! > --- /dev/null > +++ b/Documentation/thermal/cpu-idle-cooling.txt > @@ -0,0 +1,165 @@ > + > +Situation: > +-- > + Can we have some real header here? Also if this is .rst, maybe it should be marked so? > +Under certain circumstances, the SoC reaches a temperature exceeding > +the all

Re: [PATCH 1/2] infiniband: qplib_fp: fix pointer cast

2018-03-06 Thread Arnd Bergmann
On Wed, Feb 28, 2018 at 10:15 PM, Jason Gunthorpe wrote: > On Tue, Feb 20, 2018 at 09:56:26PM +0100, Arnd Bergmann wrote: >> Building for a 32-bit target results in a couple of warnings from casting >> between >> a 32-bit pointer and a 64-bit integer: >> >> drivers/infiniband/hw/bnxt_re/qplib_fp.

Re: mainline build: 15 warnings 0 failures (mainline/v4.16-rc2-64-gaf3e79d)

2018-03-06 Thread Arnd Bergmann
On Wed, Feb 21, 2018 at 3:42 PM, Kishon Vijay Abraham I wrote: > > > On Wednesday 21 February 2018 06:12 PM, Arnd Bergmann wrote: >> On Tue, Feb 20, 2018 at 7:34 PM, Olof's autobuilder wrote: >>> Here are the build results from automated periodic testing. >>> >>> The tree being built was mainline

[PATCH] docs: clarify security-bugs disclosure policy

2018-03-06 Thread Dave Hansen
From: Dave Hansen I think we need to soften the language a bit. It might scare folks off, especially the: We prefer to fully disclose the bug as soon as possible. which is not really the case. As Greg mentioned in private mail, we really do not prefer to disclose things until *after

Re: [PATCH] infiniband: remove redundant assignment to pointer 'rdi'

2018-03-06 Thread Jason Gunthorpe
On Thu, Mar 01, 2018 at 04:23:54PM +, Colin Ian King wrote: > From: Colin Ian King > > The pointer rdi is being initialized with a value that is never read > and re-assigned immediately after, hence the initialization is redundant > and can be removed. > > Cleans up clang warning: > drivers/

Re: [PATCH v2] infiniband: hw: Drop unnecessary continue

2018-03-06 Thread Jason Gunthorpe
On Sat, Mar 03, 2018 at 09:54:57PM +0530, Arushi wrote: > Continue at the bottom of a loop are removed. > Issue found using drop_continue.cocci Coccinelle script. > > Signed-off-by: Arushi Singhal > Changes in v2: > - Braces is dropped from if with single statement. > > drivers/infiniband/hw/qi

Re: [PATCH] RDMA/bnxt_re/qplib_sp: Use true and false for boolean values

2018-03-06 Thread Jason Gunthorpe
On Mon, Mar 05, 2018 at 05:36:47PM -0600, Gustavo A. R. Silva wrote: > Assign true or false to boolean variables instead of an integer value. > > This issue was detected with the help of Coccinelle. > > Signed-off-by: Gustavo A. R. Silva > Acked-by: Selvin Xavier > --- > drivers/infiniband/hw/

[PATCH v4 1/2] timers: Don't wake ktimersoftd on every tick

2018-03-06 Thread Haris Okanovic
We recently upgraded from 4.1 to 4.6 and noticed a minor latency regression caused by an additional thread wakeup (ktimersoftd) in interrupt context on every tick. The wakeups are from run_local_timers() raising TIMER_SOFTIRQ. Both TIMER and SCHED softirq coalesced into one ksoftirqd wakeup prior t

[PATCH v4 2/2] timers: Don't search for expired timers while TIMER_SOFTIRQ is scheduled

2018-03-06 Thread Haris Okanovic
This change avoid needlessly searching for more timers in run_local_timers() (hard interrupt context) when they can't fire. For example, when ktimersoftd/run_timer_softirq() is scheduled but preempted due to cpu contention. When it runs, run_timer_softirq() will discover newly expired timers up to

Re: [PATCH net-next] modules: allow modprobe load regular elf binaries

2018-03-06 Thread Chris Mason
On 6 Mar 2018, at 11:12, Linus Torvalds wrote: On Mon, Mar 5, 2018 at 5:34 PM, Alexei Starovoitov wrote: As the first step in development of bpfilter project [1] the request_module() code is extended to allow user mode helpers to be invoked. Idea is that user mode helpers are built as part of

Re: [PATCH][RESEND] block: sed-opal: fix u64 short atom length

2018-03-06 Thread Derrick, Jonathan
Hi Jonas, On Thu, 2018-03-01 at 14:27 +0100, Jonas Rabenstein wrote: > The length must be given as bytes and not as 4 bit tuples. > > Signed-off-by: Jonas Rabenstein n.de> > --- > block/sed-opal.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/block/sed-opal.c b/block

Re: [PATCH 1/2] infiniband: qplib_fp: fix pointer cast

2018-03-06 Thread Jason Gunthorpe
On Wed, Mar 07, 2018 at 12:25:14AM +0100, Arnd Bergmann wrote: > On Wed, Feb 28, 2018 at 10:15 PM, Jason Gunthorpe wrote: > > On Tue, Feb 20, 2018 at 09:56:26PM +0100, Arnd Bergmann wrote: > >> Building for a 32-bit target results in a couple of warnings from casting > >> between > >> a 32-bit po

Re: [PATCH] MAINTAINERS: Add linux/of_*.h headers to appropriate subsystems

2018-03-06 Thread Bjorn Helgaas
On Tue, Mar 6, 2018 at 7:13 AM, Rob Herring wrote: > The DeviceTree support code for specific subsystems are maintained by > the respective subsystem maintainers. However, only the DT > maintainers are listed for most of the linux/of_*.h headers. Fix this > and add the headers to the appropriate s

Re: [PATCH] x86/tsc: Always Running Timer (ART) nanoseconds clocksource

2018-03-06 Thread Rajvi Jingar
Hi Thomas, Thank you for your review comments. Please find my answers inline. On Thu, 2018-03-01 at 12:40 +0100, Thomas Gleixner wrote: > On Wed, 28 Feb 2018, Rajvi Jingar wrote: > > Subject: x86/tsc: Always Running Timer (ART) nanoseconds clocksource > > Please don't use clocksource here. That

[PATCH v2] x86/tsc: Convert ART in nanoseconds to TSC.

2018-03-06 Thread Rajvi Jingar
Device drivers use get_device_system_crosststamp() to produce precise system/device cross-timestamps. The PHC clock and ALSA interfaces, for example, make the cross-timestamps available to user applications. On Intel platforms, get_device_system_crosststamp() requires a TSC value derived from ART (

Re: Regression in IPMI on 4.15.6

2018-03-06 Thread Laura Abbott
On 03/06/2018 09:19 AM, Corey Minyard wrote: On 03/06/2018 11:17 AM, Laura Abbott wrote: On 03/05/2018 11:39 AM, Corey Minyard wrote: On 03/05/2018 01:31 PM, Corey Minyard wrote: On 03/05/2018 01:07 PM, Laura Abbott wrote: On 03/02/2018 05:46 AM, Corey Minyard wrote: On 02/28/2018 01:07 PM,

[PATCH v4.15.7 1/1] x86/vdso: handle clock_gettime(CLOCK_MONOTONIC_RAW, &ts) in VDSO

2018-03-06 Thread Jason Vas Dias
Handling clock_gettime( CLOCK_MONOTONIC_RAW, ×pec) by calling vdso_fallback_gettime(), ie. syscall, is too slow - latencies of 300-700ns are common on Haswell (06:3C) CPUs . This patch against the 4.15.7 stable branch makes the VDSO handle clock_gettime(CLOCK_GETTIME_RAW, &ts) by issuing rdt

Re: [patch] mm, compaction: drain pcps for zone when kcompactd fails

2018-03-06 Thread David Rientjes
On Thu, 1 Mar 2018, David Rientjes wrote: > On Thu, 1 Mar 2018, Andrew Morton wrote: > > > On Thu, 1 Mar 2018 03:42:04 -0800 (PST) David Rientjes > > wrote: > > > > > It's possible for buddy pages to become stranded on pcps that, if drained, > > > could be merged with other buddy pages on the

[PATCH] objtool: Fix 32-bit build

2018-03-06 Thread Josh Poimboeuf
Fix the objtool build when cross-compiling a 64-bit kernel on a 32-bit host. This also simplifies read_retpoline_hints() a bit and makes its implementation similar to most of the other annotation reading functions. Reported-by: Sven Joachim Fixes: b5bc2231b8ad ("objtool: Add retpoline validation

Re: [PATCH][RESEND] block: sed-opal: fix response string extraction

2018-03-06 Thread Derrick, Jonathan
This looks correct. Adding my Ack unless Scott has objections Acked-by: Jonathan Derrick On Thu, 2018-03-01 at 14:26 +0100, Jonas Rabenstein wrote: > Tokens are prefixed by a variable length of bytes. If a bytestring is > not stored in an tiny or short atom, we have to skip more than one > byte

Re: [PATCH v2 1/1] HID: Logitech K290: Add driver for the Logitech K290 USB keyboard

2018-03-06 Thread Florent Flament
Hi Benjamin, Nestor, On Tue, 2018-03-06 at 00:31 +0100, Florent Flament wrote: > On Mon, 2018-03-05 at 18:26 +0100, Benjamin Tissoires wrote: > > Hi Florent, > > Hi Benjamin, > > > > > On Mon, Mar 5, 2018 at 10:31 AM, Nestor Lopez Casado > > wrote: > > > Hello Florent, > > > > > > In my view,

Re: [PATCH] docs: clarify security-bugs disclosure policy

2018-03-06 Thread Kees Cook
On Tue, Mar 6, 2018 at 3:31 PM, Dave Hansen wrote: > > From: Dave Hansen > > I think we need to soften the language a bit. It might scare folks > off, especially the: > > We prefer to fully disclose the bug as soon as possible. > > which is not really the case. As Greg mentioned in pri

PLEASE REPLY SOONEST.

2018-03-06 Thread fax
I have a business Proposal that will be of benefit to the both of us.Kindly contact me on mrmichealwu...@yahoo.com.hk should this be of interest to you.

Re: [PATCH] xfs: Correctly invert xfs_buftarg LRU isolation logic

2018-03-06 Thread Darrick J. Wong
On Tue, Mar 06, 2018 at 11:26:38AM +0100, Vratislav Bendel wrote: > Due to an inverted logic mistake in xfs_buftarg_isolate() > the xfs_buffers with zero b_lru_ref will take another trip > around LRU, while isolating buffers with non-zero b_lru_ref. > > Additionally those isolated buffers end up r

Re: [PATCH v4 0/3] KVM: Introduce dedicated vCPUs hint KVM_HINTS_DEDICATED

2018-03-06 Thread Wanpeng Li
2018-03-06 22:39 GMT+08:00 Eduardo Valentin : > Folks, > > On Tue, Feb 13, 2018 at 09:05:39AM +0800, Wanpeng Li wrote: >> This patchset introduces dedicated vCPUs(vCPU pinning, and there is no >> vCPU over-commitment) hint KVM_HINTS_DEDICATED, it has two users now: >> >> 1) Waiman Long mentioned th

Re: [PATCH] pci-iov: Add support for unmanaged SR-IOV

2018-03-06 Thread Alexander Duyck
On Tue, Mar 6, 2018 at 12:19 PM, Don Dutile wrote: > On 03/05/2018 04:41 PM, Alexander Duyck wrote: >> >> On Mon, Mar 5, 2018 at 12:57 PM, Don Dutile wrote: >>> >>> On 03/01/2018 03:22 PM, Alex Williamson wrote: On Wed, 28 Feb 2018 16:36:38 -0800 Alexander Duyck wrote: >

[PATCH v2 0/3] staging:iio:meter: Checkpatch cleanup for meter

2018-03-06 Thread Rodrigo Siqueira
This patchset fixes errors and checks found by checkpatch.pl in the staging/iio/meter. These series fixes: * Removes the use of 4 digit octal by replaces IIO_DEV_ATTR_CH_OFF by IIO_DEVICE_ATTR; * Removes unnecessary macro; * Aligns open parenthesis; Changes v2: - Aligns one extra open par

[PATCH v2 3/3] staging:iio:meter: Aligns open parenthesis

2018-03-06 Thread Rodrigo Siqueira
This patch fixes the checkpatch.pl checks: staging/iio/meter/ade7854-spi.c:19: CHECK: Alignment should match open parenthesis staging/iio/meter/ade7854-spi.c:44: CHECK: Alignment should match open parenthesis staging/iio/meter/ade7854-spi.c:70: CHECK: Alignment should match open parenthesis stagin

[PATCH v2 1/3] staging:iio:meter: Replaces IIO_DEV_ATTR_CH_OFF by IIO_DEVICE_ATTR

2018-03-06 Thread Rodrigo Siqueira
The macro IIO_DEV_ATTR_CH_OFF is a wrapper for IIO_DEVICE_ATTR, with a tiny change in the name definition. This extra macro does not improve the readability and also creates some checkpatch errors. This patch fixes the checkpatch.pl errors: staging/iio/meter/ade7753.c:391: ERROR: Use 4 digit octa

[PATCH v2 2/3] staging:iio:meter: Remove unused macro IIO_DEV_ATTR_CH_OFF

2018-03-06 Thread Rodrigo Siqueira
This patch removes the macro IIO_DEV_ATTR_CH_OFF. The macro IIO_DEV_ATTR_CH_OFF is not required, due to the replace of it by the direct use of IIO_DEVICE_ATTR in files staging/iio/meter/ade7759.c and staging/iio/meter/ade7753.c. Signed-off-by: Rodrigo Siqueira --- drivers/staging/iio/meter/meter

RE: [PATCH v5 2/4] drivers: firmware: xilinx: Add ZynqMP firmware driver

2018-03-06 Thread Jolly Shah
Hi Sudeep, Thanks for the review, > -Original Message- > From: Sudeep Holla [mailto:sudeep.ho...@arm.com] > Sent: Thursday, March 01, 2018 6:28 AM > To: Jolly Shah ; michal.si...@xilinx.com > Cc: ard.biesheu...@linaro.org; mi...@kernel.org; > gre...@linuxfoundation.org; m...@codeblueprint

Re: [RFC PATCH 0/4 v2] Define killable version for access_remote_vm() and use it in fs/proc

2018-03-06 Thread Yang Shi
On 3/6/18 1:41 PM, Andrew Morton wrote: On Tue, 6 Mar 2018 13:17:37 -0800 Yang Shi wrote: It just mitigates the hung task warning, can't resolve the mmap_sem scalability issue. Furthermore, waiting on pure uninterruptible state for reading /proc sounds unnecessary. It doesn't wait for I/O c

[PATCH -next] pstore: Select compression at runtime

2018-03-06 Thread Kees Cook
To allow for easier build test coverage and run-time testing, this allows multiple compression algorithms to be built into pstore. Still only one is supported to operate at a time (which can be selected at build time or at boot time, similar to how LSMs are selected). Signed-off-by: Kees Cook ---

Re: [PATCH] libnvdimm: remove redundant __func__ in dev_dbg

2018-03-06 Thread Ross Zwisler
On Tue, Mar 06, 2018 at 08:59:11AM -0800, Dan Williams wrote: > On Mon, Mar 5, 2018 at 7:54 PM, Ross Zwisler > wrote: > > On Mon, Mar 05, 2018 at 05:09:21PM -0800, Dan Williams wrote: > >> Dynamic debug can be instructed to add the function name to the debug > >> output using the +f switch, so the

Re: [PATCH net-next] modules: allow modprobe load regular elf binaries

2018-03-06 Thread Alexei Starovoitov
combining multiple answers... On 3/6/18 3:05 AM, Greg KH wrote: Any chance you can add a field to your "umh module" type such that a normal 'modinfo' program will be able to notice it is different easily? ok. handling of modinfo turned out to be straightforward. kmod tooling worked fine with

Re: [PATCH] ftrace: nuke clear_ftrace_function

2018-03-06 Thread Yisheng Xie
Hi Steven, On 2018/3/7 6:02, Steven Rostedt wrote: > On Tue, 6 Mar 2018 19:30:28 +0800 > Yisheng Xie wrote: > >> hi Steven and all, >> Ping, for month passed, do you have any comment about this patch? > > Sorry you got me in the midst of traveling and other issues. > > This patch looks fine, I

Re: [PATCH bpf-next v8 00/11] Landlock LSM: Toward unprivileged sandboxing

2018-03-06 Thread Andy Lutomirski
On Tue, Mar 6, 2018 at 11:06 PM, Mickaël Salaün wrote: > > On 06/03/2018 23:46, Tycho Andersen wrote: >> On Tue, Mar 06, 2018 at 10:33:17PM +, Andy Lutomirski wrote: > Suppose I'm writing a container manager. I want to run "mount" in the > container, but I don't want to allow moun() i

Re: dm-bufio: avoid false-positive Wmaybe-uninitialized warning

2018-03-06 Thread Mike Snitzer
On Tue, Mar 06 2018 at 4:33pm -0500, Arnd Bergmann wrote: > On Thu, Feb 22, 2018 at 5:04 PM, Mike Snitzer wrote: > > On Thu, Feb 22 2018 at 10:56am -0500, > > Arnd Bergmann wrote: > > > > > Mikulas already sent a fix for this: > > https://patchwork.kernel.org/patch/10211631/ > > > > But I lik

[PATCH] staging: most: Remove unnecessary usage of BUG_ON().

2018-03-06 Thread Quytelda Kahja
There is no need for the calls to BUG_ON() in this driver, which are used to check if mbo or mbo->context are NULL; mbo is never NULL, and if mbo->context is NULL it would have already been dereferenced and oopsed before reaching the BUG_ON(). Signed-off-by: Quytelda Kahja --- drivers/staging/mo

Re: ftrace: Proposal for an Alternative RecordMcount framework

2018-03-06 Thread Alan Kao
On Thu, Mar 01, 2018 at 10:05:07AM +0800, Alan Kao wrote: > On Wed, Feb 28, 2018 at 05:12:52AM +0800, Steven Rostedt wrote: > > On Tue, 27 Feb 2018 18:04:26 +0800 > > Alan Kao wrote: > > > > > 1. During the final linking stages, do "objdump vmlinux.o | grep ..." [2] > > > > Note, doing it at th

Re: [PATCH v2 2/2] dt-bindings: input: Add binding for RAVE SP input driver

2018-03-06 Thread Andrey Smirnov
On Tue, Mar 6, 2018 at 6:17 AM, Fabio Estevam wrote: > Hi Andrey, > > On Thu, Mar 1, 2018 at 1:55 PM, Andrey Smirnov > wrote: > l >> +++ b/Documentation/devicetree/bindings/input/zii,rave-sp-pwrbutton.txt >> @@ -0,0 +1,24 @@ >> +Zodiac Inflight Innovations RAVE Supervisory Processor Power Button

Re: Regression in IPMI on 4.15.6

2018-03-06 Thread Corey Minyard
On 03/06/2018 05:54 PM, Laura Abbott wrote: On 03/06/2018 09:19 AM, Corey Minyard wrote: On 03/06/2018 11:17 AM, Laura Abbott wrote: On 03/05/2018 11:39 AM, Corey Minyard wrote: On 03/05/2018 01:31 PM, Corey Minyard wrote: On 03/05/2018 01:07 PM, Laura Abbott wrote: On 03/02/2018 05:46 AM, C

<    3   4   5   6   7   8   9   >