Re: [RFC tip/locking/lockdep v5 05/17] lockdep: Extend __bfs() to work with multiple kinds of dependencies

2018-02-22 Thread Peter Zijlstra
On Fri, Feb 23, 2018 at 12:34:26AM +0800, Boqun Feng wrote: > OK, so I have some 'proof' in patch #16. I could move that proof in the > commit log or merge that patch with this one? Hehe, I'm not yet that far with reading patches.. I'll get to it, eventually ;-)

Re: [PATCH v4] arm64: Add support for new control bits CTR_EL0.DIC and CTR_EL0.IDC

2018-02-22 Thread Mark Rutland
On Thu, Feb 22, 2018 at 04:28:03PM +, Robin Murphy wrote: > [Apologies to keep elbowing in, and if I'm being thick here...] > > On 22/02/18 15:22, Mark Rutland wrote: > > On Thu, Feb 22, 2018 at 08:51:30AM -0600, Shanker Donthineni wrote: > > > +#define CTR_B31_SHIFT31 > > > > Sin

Re: Regression: Dell XPS 13 9360 keyboard no longer works

2018-02-22 Thread Darren Hart
On Thu, Feb 22, 2018 at 04:28:57PM +, mario.limoncie...@dell.com wrote: > > -Original Message- > > From: platform-driver-x86-ow...@vger.kernel.org [mailto:platform-driver-x86- > > ow...@vger.kernel.org] On Behalf Of Darren Hart > > Sent: Thursday, February 22, 2018 10:19 AM > > To: Limo

Re: Removing architectures without upstream gcc support

2018-02-22 Thread Arnd Bergmann
On Thu, Feb 22, 2018 at 5:28 PM, James Hogan wrote: > Hi Arnd, > > On Thu, Feb 22, 2018 at 04:45:06PM +0100, Arnd Bergmann wrote: >> * Meta was ImgTec's own architecture and they upstreamed the kernel >> port just before they acquired MIPS. Apparently Meta was abandoned >> shortly afterwards a

Re: [PATCH] drivers/virt: vm_gen_counter: initial driver implementation

2018-02-22 Thread Greg KH
On Thu, Feb 22, 2018 at 06:20:38PM +0200, Or Idgar wrote: > From: Or Idgar > > This patch is a driver which expose the Virtual Machine Generation ID > via sysfs. The ID is a UUID value used to differentiate between virtual > machines. > > The VM-Generation ID is a feature defined by Microsoft (p

Re: uprobes/perf: KASAN: use-after-free in uprobe_perf_close

2018-02-22 Thread Oleg Nesterov
On 02/22, Prashant Bhole wrote: > > Hi, > I encountered following BUG caught by KASAN with recent kernels when trying > out [BCC project] bcc/testing/python/test_usdt2.py > Tried with v4.12, it was reproducible. > > --- KASAN log --- > BUG: KASAN: use-after-free in uprobe_perf_close+0x118/0x1a0 > R

Re: [PATCH] arm64: dts: Remove leading 0x and 0s from bindings notation

2018-02-22 Thread Arnd Bergmann
On Thu, Dec 14, 2017 at 5:53 PM, Mathieu Malaterre wrote: > Improve the DTS files by removing all the leading "0x" and zeros to fix the > following dtc warnings: > > Warning (unit_address_format): Node /XXX unit name should not have leading > "0x" > > and > > Warning (unit_address_format): Node /

Re: [PATCH 01/13] metag: Remove arch/metag/

2018-02-22 Thread James Hogan
On Thu, Feb 22, 2018 at 04:19:31PM +, Graham Whaley wrote: > >> > > >> > So lets call it a day and drop the Meta architecture port from the > >> > kernel. RIP Meta. > > Oh, and James, I meant to ask/note - I guess that just leaves parisc > using STACK_GROWSUP... shame we could not ditch that a

Re: [PATCH 16/25] arm: zx: dts: Remove leading 0x and 0s from bindings notation

2018-02-22 Thread Arnd Bergmann
On Tue, Dec 26, 2017 at 9:03 AM, Shawn Guo wrote: > On Fri, Dec 15, 2017 at 01:46:48PM +0100, Mathieu Malaterre wrote: >> Improve the DTS files by removing all the leading "0x" and zeros to fix the >> following dtc warnings: >> >> Warning (unit_address_format): Node /XXX unit name should not have

Re: [PATCH] ipv6 sit: work around bogus gcc-8 -Wrestrict warning

2018-02-22 Thread Eric Dumazet
On Thu, 2018-02-22 at 16:55 +0100, Arnd Bergmann wrote: ... > > This code is old, so Cc stable to make sure that we don't get the warning > for older kernels built with new gcc. > > Cc: sta...@vger.kernel.org This part makes little sense to me for two reasons. 1) David Miller handles stable

Re: [GIT PULL] ARM: at91: SoC fixes for 4.16

2018-02-22 Thread Arnd Bergmann
On Thu, Feb 22, 2018 at 5:29 PM, Alexandre Belloni wrote: > Hi, > > A single patch changing my email address. I think it is worth having it > in MAINTAINERS sooner rather than later. > > The following changes since commit 7928b2cbe55b2a410a0f5c1f154610059c57b1b2: > > Linux 4.16-rc1 (2018-02-11 1

Re: Regression: Dell XPS 13 9360 keyboard no longer works

2018-02-22 Thread Jeremy Cline
On 02/22/2018 11:17 AM, mario.limoncie...@dell.com wrote: >> -Original Message- >> From: platform-driver-x86-ow...@vger.kernel.org [mailto:platform-driver-x86- >> ow...@vger.kernel.org] On Behalf Of Jeremy Cline >> Sent: Thursday, February 22, 2018 10:17 AM >> To: Limonciello, Mario ; notm.

Re: [PATCH 1/3] ARM: clps711x: mark clps711x_compat as const

2018-02-22 Thread Arnd Bergmann
On Tue, Feb 20, 2018 at 5:24 PM, Arnd Bergmann wrote: > The array of string pointers is put in __initconst, and the strings themselves > are marke 'const' but the the pointers are not, which caused a warning when > built with LTO: > > arch/arm/mach-clps711x/board-dt.c:72:20: error: 'clps711x_compa

Re: [PATCH 3/3] ARM: davinci: mark spi_board_info arrays as const

2018-02-22 Thread Arnd Bergmann
On Tue, Feb 20, 2018 at 5:24 PM, Arnd Bergmann wrote: > Building with LTO revealed that three spi_board_info arrays are marked > __initconst, but not const: > > arch/arm/mach-davinci/board-dm365-evm.c: In function 'dm365_evm_init': > arch/arm/mach-davinci/board-dm365-evm.c:729:30: error: 'dm365_ev

Re: [PATCH v2 3/3] fs: fsnotify: account fsnotify metadata to kmemcg

2018-02-22 Thread Yang Shi
On Thu, Feb 22, 2018 at 6:48 AM, Jan Kara wrote: > On Thu 22-02-18 14:49:44, Michal Hocko wrote: >> On Tue 20-02-18 19:01:01, Shakeel Butt wrote: >> > A lot of memory can be consumed by the events generated for the huge or >> > unlimited queues if there is either no or slow listener. This can caus

Re: [PATCH v4] reset: add support for non-DT systems

2018-02-22 Thread David Lechner
On 02/22/2018 05:34 AM, Philipp Zabel wrote: On Tue, 2018-02-20 at 10:40 -0600, David Lechner wrote: [...] In your case the platform code that adds the lookup may be identical to the code that registers the struct reset_controller_dev, but that doesn't have to be the case. I'm not sure how that

Re: [PATCH] PCMCIA / PM: Avoid noirq suspend aborts during suspend-to-idle

2018-02-22 Thread Dominik Brodowski
On Wed, Feb 21, 2018 at 01:24:16PM +0100, Rafael J. Wysocki wrote: > Avoid that by using a new socket state flag, SOCKET_IN_RESUME, > to indicate that socket_early_resume() has already run for the > socket in which case socket_suspend() will do minimum handling > and return 0. That looks to be *to

Re: [PATCH] drivers/virt: vm_gen_counter: initial driver implementation

2018-02-22 Thread Gal Hammer
Hi, On Thu, Feb 22, 2018 at 6:36 PM, Greg KH wrote: > On Thu, Feb 22, 2018 at 06:20:38PM +0200, Or Idgar wrote: >> From: Or Idgar >> >> This patch is a driver which expose the Virtual Machine Generation ID >> via sysfs. The ID is a UUID value used to differentiate between virtual >> machines. >>

Re: [PATCH] ARM: orion: fix orion_ge00_switch_board_info initialization

2018-02-22 Thread Arnd Bergmann
On Thu, Feb 22, 2018 at 2:30 PM, Andrew Lunn wrote: > On Wed, Feb 21, 2018 at 01:18:49PM +0100, Arnd Bergmann wrote: >> A section type mismatch warning shows up when building with LTO, >> since orion_ge00_mvmdio_bus_name was put in __initconst but not marked >> const itself: >> >> include/linux/of

Re: [PATCH v4] arm64: Add support for new control bits CTR_EL0.DIC and CTR_EL0.IDC

2018-02-22 Thread Robin Murphy
On 22/02/18 16:33, Mark Rutland wrote: On Thu, Feb 22, 2018 at 04:28:03PM +, Robin Murphy wrote: [Apologies to keep elbowing in, and if I'm being thick here...] On 22/02/18 15:22, Mark Rutland wrote: On Thu, Feb 22, 2018 at 08:51:30AM -0600, Shanker Donthineni wrote: +#define CTR_B31_SHIF

Re: [QUESTION] srcu: Remove the SCAN2 state

2018-02-22 Thread Paul E. McKenney
On Thu, Feb 22, 2018 at 02:05:18PM +0900, Byungchul Park wrote: > On 2/22/2018 11:11 AM, Paul E. McKenney wrote: > >On Thu, Feb 22, 2018 at 08:57:27AM +0900, Byungchul Park wrote: > >>Hello, > >> > >>I'm sorry for bothering you, and I seem to be obviously missing > >>something, but I'm really wonde

Re: [PATCH] ipv6 sit: work around bogus gcc-8 -Wrestrict warning

2018-02-22 Thread Arnd Bergmann
On Thu, Feb 22, 2018 at 5:40 PM, Eric Dumazet wrote: > On Thu, 2018-02-22 at 16:55 +0100, Arnd Bergmann wrote: > > ... >> >> This code is old, so Cc stable to make sure that we don't get the warning >> for older kernels built with new gcc. >> >> Cc: sta...@vger.kernel.org > > > This part makes lit

Re: [PATCH v2 07/10] drivers: qcom: rpmh: cache sleep/wake state requests

2018-02-22 Thread Lina Iyer
On Wed, Feb 21 2018 at 22:07 +, Evan Green wrote: Hi Lina, On Thu, Feb 15, 2018 at 9:35 AM, Lina Iyer wrote: [...] +static struct cache_req *cache_rpm_request(struct rpmh_client *rc, + enum rpmh_state state, +

Re: [PATCH] srcu: remove never used variable

2018-02-22 Thread Paul E. McKenney
On Thu, Feb 22, 2018 at 06:52:37AM +, zhouzho...@gmail.com wrote: > From: Zhouyi Zhou > > In function srcu_gp_end, the variable idxnext is never used after assign, > remove it and its assign statement. > > Signed-off-by: Zhouyi Zhou Good catch, but Byungchul Park beat you to it. Please se

Re: [PATCH 1/2] stackleak: Update for arm64

2018-02-22 Thread Will Deacon
Hi Laura, On Tue, Feb 20, 2018 at 05:13:02PM -0800, Laura Abbott wrote: > > arm64 has another layer of indirection in the RTL. > Account for this in the plugin. > > Signed-off-by: Laura Abbott > --- > scripts/gcc-plugins/stackleak_plugin.c | 5 + > 1 file changed, 5 insertions(+) > > diff

Re: [PATCH v3 2/5] m68k: rename UL() to TO_UL()

2018-02-22 Thread Masahiro Yamada
Hi Geert 2018-02-22 22:20 GMT+09:00 Geert Uytterhoeven : > Hi Yamada-san, > > On Thu, Feb 22, 2018 at 1:15 PM, Masahiro Yamada > wrote: >> ARM, ARM64 and UniCore32 define UL(x) like follows: >> #define UL(x) _AC(x, UL) >> >> While, M68K defines it differently: >> #define UL(x) ((unsigned long

Re: [PATCH 1/4] drm/simple_kms_helper: Add {enable|disable}_vblank callback support

2018-02-22 Thread Daniel Vetter
On Mon, Feb 19, 2018 at 11:11:23AM +0200, Oleksandr Andrushchenko wrote: > ping > On 02/12/2018 10:52 AM, Oleksandr Andrushchenko wrote: > > From: Oleksandr Andrushchenko > > > > If simple_kms_helper based driver needs to work with vblanks, > > then it has to provide drm_driver.{enable|disable}_v

[PATCH v5 0/4] Utilization estimation (util_est) for FAIR tasks

2018-02-22 Thread Patrick Bellasi
Hi, here is an update of [1], based on today's tip/sched/core [2], which targets two main things: 1) Add the required/missing {READ,WRITE}_ONCE compiler barriers AFAIU, we wanted those barriers for lock-less synchronization between: - enqueue/dequeue calls: which are serialized by the RQ lo

[PATCH v5 1/4] sched/fair: add util_est on top of PELT

2018-02-22 Thread Patrick Bellasi
The util_avg signal computed by PELT is too variable for some use-cases. For example, a big task waking up after a long sleep period will have its utilization almost completely decayed. This introduces some latency before schedutil will be able to pick the best frequency to run a task. The same is

[PATCH v5 4/4] sched/fair: update util_est only on util_avg updates

2018-02-22 Thread Patrick Bellasi
The estimated utilization of a task is currently updated every time the task is dequeued. However, to keep overheads under control, PELT signals are effectively updated at maximum once every 1ms. Thus, for really short running tasks, it can happen that their util_avg value has not been updates sin

[PATCH v5 3/4] sched/cpufreq_schedutil: use util_est for OPP selection

2018-02-22 Thread Patrick Bellasi
When schedutil looks at the CPU utilization, the current PELT value for that CPU is returned straight away. In certain scenarios this can have undesired side effects and delays on frequency selection. For example, since the task utilization is decayed at wakeup time, a long sleeping big task newly

[PATCH v5 2/4] sched/fair: use util_est in LB and WU paths

2018-02-22 Thread Patrick Bellasi
When the scheduler looks at the CPU utilization, the current PELT value for a CPU is returned straight away. In certain scenarios this can have undesired side effects on task placement. For example, since the task utilization is decayed at wakeup time, when a long sleeping big task is enqueued it

Re: uprobes/perf: KASAN: use-after-free in uprobe_perf_close

2018-02-22 Thread Peter Zijlstra
On Thu, Feb 22, 2018 at 05:37:15PM +0100, Oleg Nesterov wrote: > On 02/22, Prashant Bhole wrote: > > After debugging, found that uprobe_perf_close() is called after task has > > been terminated and uprobe_perf_close() tries to access task_struct of the > > terminated process. > > Oh. You can't im

RE: Regression: Dell XPS 13 9360 keyboard no longer works

2018-02-22 Thread Mario.Limonciello
> -Original Message- > From: platform-driver-x86-ow...@vger.kernel.org [mailto:platform-driver-x86- > ow...@vger.kernel.org] On Behalf Of Jeremy Cline > Sent: Thursday, February 22, 2018 10:42 AM > To: Limonciello, Mario ; notm...@gmail.com > Cc: pali.ro...@gmail.com; andriy.shevche...@linu

Re: [PATCH v2 09/10] drivers: qcom: rpmh: add support for batch RPMH request

2018-02-22 Thread Lina Iyer
On Wed, Feb 21 2018 at 23:25 +, Evan Green wrote: Hello Lina, On Thu, Feb 15, 2018 at 9:35 AM, Lina Iyer wrote: Platform drivers need make a lot of resource state requests at the same time, say, at the start or end of an usecase. It can be quite inefficient to send each request separately.

Re: [PATCH v2 0/3] new driver for Valve Steam Controller

2018-02-22 Thread Benjamin Tissoires
On Thu, Feb 22, 2018 at 5:31 PM, Rodrigo Rivas Costa wrote: > On Thu, Feb 22, 2018 at 10:10:40AM +0100, Benjamin Tissoires wrote: >> On Thu, Feb 22, 2018 at 1:13 AM, Pierre-Loup A. Griffais >> wrote: >> > >> > >> > On 02/21/2018 12:21 PM, Rodrigo Rivas Costa wrote: >> >> >> >> On Tue, Feb 20, 201

Re: [PATCH 1/3] KVM: x86: use native MSR ops for SPEC_CTRL

2018-02-22 Thread Konrad Rzeszutek Wilk
On Wed, Feb 21, 2018 at 10:41:35PM +0100, Paolo Bonzini wrote: > Having a paravirt indirect call in the IBRS restore path is not a > good idea, since we are trying to protect from speculative execution > of bogus indirect branch targets. It is also slower, so use > native_wrmsrl on the vmentry pat

Re: [PATCH v7 0/5] Add Intel IOMMU debugfs support

2018-02-22 Thread Jacob Pan
On Thu, 22 Feb 2018 08:48:37 +0100 Yves-Alexis Perez wrote: > On Tue, 2018-02-20 at 14:25 -0800, Jacob Pan wrote: > > I didn't know about chipsec but reading the code seems to rely on an > > out-of-tree kernel module. I don't think it matches what we need > > here. > > Yes good indeed, I had f

Re: [PATCH NAND v5] mtd: nand: Replace printk() with appropriate pr_*() macro

2018-02-22 Thread Andy Shevchenko
On Thu, Feb 22, 2018 at 6:31 PM, Shreeya Patel wrote: > Using pr_() is more concise than > printk(KERN_). > Replace printks having a log level with the appropriate > pr_*() macros. > Define pr_fmt() and remove other additional macros from > the replaced printks. It makes sense to fix indentation,

Re: uprobes/perf: KASAN: use-after-free in uprobe_perf_close

2018-02-22 Thread Peter Zijlstra
On Thu, Feb 22, 2018 at 06:04:27PM +0100, Peter Zijlstra wrote: > On Thu, Feb 22, 2018 at 05:37:15PM +0100, Oleg Nesterov wrote: > > This all makes me think that we should change (fix) kernel/events/core.c... > > That's going to be mighty dodgy though, holding a reference on the task > will avoid

Re: [PATCH] efivarfs: Limit the rate for non-root to read files

2018-02-22 Thread Eric W. Biederman
"Luck, Tony" writes: >> - add a per-user mutex, and do the usleep inside of it, so that >> anybody who tries to do a thousand threads will just be serialized by >> the mutex. >> >> Note that the mutex needs to be per-user, because otherwise it will be >> a DoS for the other users. > > I can try

Re: [PATCH 1/2] pci: endpoint: Free func_name after last usage

2018-02-22 Thread Andy Shevchenko
On Thu, Feb 22, 2018 at 6:21 PM, Rolf Evers-Fischer wrote: > On Wed, 21 Feb 2018, Andy Shevchenko wrote: >> This is a slow path and your change makes code slightly less readable >> b/c of patterns used in the kernel. >> > I see. It is probably not a good idea to free the > memory in the middle of

Re: Removing architectures without upstream gcc support

2018-02-22 Thread Max Filippov
On Thu, Feb 22, 2018 at 8:02 AM, Christoph Hellwig wrote: > I'd love to see dead architecture ports dropped if they really are > more or less abandoned. In addition to your missing gcc port ones > above (minus openrisc) it seems like frv and m32r certainly qualify, > and xtensa seems to be going

[PATCH v2] efivarfs: Limit the rate for non-root to read files

2018-02-22 Thread Luck, Tony
Each read from a file in efivarfs results in two calls to EFI (one to get the file size, another to get the actual data). On X86 these EFI calls result in broadcast system management interrupts (SMI) which affect performance of the whole system. A malicious user can loop performing reads from efiv

Re: [PATCH 1/4] drm/simple_kms_helper: Add {enable|disable}_vblank callback support

2018-02-22 Thread Oleksandr Andrushchenko
On 02/22/2018 06:59 PM, Daniel Vetter wrote: On Mon, Feb 19, 2018 at 11:11:23AM +0200, Oleksandr Andrushchenko wrote: ping On 02/12/2018 10:52 AM, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko If simple_kms_helper based driver needs to work with vblanks, then it has to provide

Re: [PATCH v1] drm/simple_kms_helper: Fix NULL pointer dereference with no active CRTC

2018-02-22 Thread Oleksandr Andrushchenko
On 02/22/2018 06:11 PM, Daniel Vetter wrote: On Thu, Feb 22, 2018 at 08:12:48AM +0200, Oleksandr Andrushchenko wrote: On 02/22/2018 08:09 AM, Oleksandr Andrushchenko wrote: From: Oleksandr Andrushchenko It is possible that drm_simple_kms_plane_atomic_check called with no CRTC set, e.g. when u

Re: [PATCH v2 1/8] [PATCH 1/8] drivers/peci: Add support for PECI bus driver core

2018-02-22 Thread Jae Hyun Yoo
On 2/21/2018 10:54 PM, Greg KH wrote: On Wed, Feb 21, 2018 at 12:42:30PM -0800, Jae Hyun Yoo wrote: On 2/21/2018 9:58 AM, Greg KH wrote: On Wed, Feb 21, 2018 at 08:15:59AM -0800, Jae Hyun Yoo wrote: This commit adds driver implementation for PECI bus into linux driver framework. Signed-off-by

Re: [BUG] ARCv2: MCIP: GFRC: mcip cmd/readback concurrency

2018-02-22 Thread Vineet Gupta
On 02/22/2018 06:26 AM, Eugeniy Paltsev wrote: To read any data from ARconnect we have special interface which includes two AUX registers: MCIP_CMD and MCIP_READBACK. We write command to MCIP_CMD and read data from MCIP_READBACK after that. We have only one instance of this registers per cluster

[PATCH] xen/pvcalls: fix null pointer dereference on map->sock

2018-02-22 Thread Colin King
From: Colin Ian King Currently if map is null then a potential null pointer deference occurs when calling sock_release on map->sock. I believe the actual intention was to call sock_release on sock instead. Fix this. Fixes: 5db4d286a8ef ("xen/pvcalls: implement connect command") Signed-off-by: C

Re: [PATCH v7 6/6] drm/msm: iommu: Replace runtime calls with runtime suppliers

2018-02-22 Thread Vivek Gautam
Hi, On Thu, Feb 22, 2018 at 7:42 PM, Tomasz Figa wrote: > On Thu, Feb 22, 2018 at 10:45 PM, Robin Murphy wrote: >> [sorry, I had intended to reply sooner but clearly forgot] >> >> >> On 16/02/18 00:13, Tomasz Figa wrote: >>> >>> On Fri, Feb 16, 2018 at 2:14 AM, Robin Murphy >>> wrote:

Re: [PATCH v1 2/2] PCI: Allow user to request power management of conventional and hotplug bridges

2018-02-22 Thread Rafael J. Wysocki
On Thu, Feb 22, 2018 at 2:31 PM, Rafael J. Wysocki wrote: > On 2/22/2018 2:18 PM, Lukas Wunner wrote: >> >> On Tue, Feb 20, 2018 at 12:15:54PM -0600, Bjorn Helgaas wrote: >>> >>> Basically I was hoping to partially rectify what I think was a mistake >>> on my part when we merged this. 9d26d3a8f1b

Re: [RFC PATCH] drivers/peci: peci_match_id() can be static

2018-02-22 Thread Jae Hyun Yoo
On 2/21/2018 11:01 PM, kbuild test robot wrote: Fixes: 99f5d2b99ecd ("drivers/peci: Add support for PECI bus driver core") Signed-off-by: Fengguang Wu --- peci-core.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/peci/peci-core.c b/drivers/peci/peci-core.

Re: [RFC PATCH] riscv/locking: Strengthen spin_lock() and spin_unlock()

2018-02-22 Thread Daniel Lustig
On 2/22/2018 6:12 AM, Andrea Parri wrote: > On Thu, Feb 22, 2018 at 02:40:04PM +0100, Peter Zijlstra wrote: >> On Thu, Feb 22, 2018 at 01:19:50PM +0100, Andrea Parri wrote: >> >>> C unlock-lock-read-ordering >>> >>> {} >>> /* s initially owned by P1 */ >>> >>> P0(int *x, int *y) >>> { >>> WRITE

Re: [PATCH v3 06/10] pwm: add PWM modes

2018-02-22 Thread Andy Shevchenko
On Thu, Feb 22, 2018 at 2:01 PM, Claudiu Beznea wrote: > Add PWM normal and complementary modes. > +- PWM_DTMODE_COMPLEMENTARY: PWM complementary working mode (for PWM > +channels two outputs); if not specified, the default for PWM channel will > +be used What DT stands for? -- With Best Regar

Re: [PATCH 2/3] Kconfig: improve handling for all{rand,yes,no,}.config fragments

2018-02-22 Thread Masahiro Yamada
2018-02-22 1:57 GMT+09:00 Arnd Bergmann : > On Tue, Feb 20, 2018 at 6:04 PM, Masahiro Yamada > wrote: >> 2018-02-20 18:59 GMT+09:00 Arnd Bergmann : >>> On Tue, Feb 20, 2018 at 10:26 AM, Masahiro Yamada >>> wrote: 2018-02-17 6:41 GMT+09:00 Arnd Bergmann : >>> > @@ -621,14 +622,24 @@ int m

Re: [RFC tip/locking/lockdep v5 07/17] lockdep: Adjust check_redundant() for recursive read change

2018-02-22 Thread Peter Zijlstra
On Thu, Feb 22, 2018 at 03:08:54PM +0800, Boqun Feng wrote: > As we have four kinds of dependencies now, check_redundant() should only > report redundant if we have a dependency path which is equal or > _stronger_ than the current dependency. For example if in > check_prev_add() we have: > >

Re: [PATCH] doc: process: Add "Root-caused-by" and "Suggested-by"

2018-02-22 Thread Randy Dunlap
On 02/21/2018 10:03 PM, Kees Cook wrote: > On Wed, Feb 21, 2018 at 8:43 PM, Randy Dunlap wrote: >> On 02/21/2018 04:37 PM, Kees Cook wrote: >>> As recently pointed out by Linus, "Root-caused-by" is a good tag to include >>> since it can indicate significantly more work than "just" a Reported-by. >

Re: samples/seccomp/ broken when cross compiling s390, ppc allyesconfig

2018-02-22 Thread Kees Cook
On Thu, Feb 22, 2018 at 5:07 AM, Michal Hocko wrote: > On Wed 14-02-18 09:14:47, Kees Cook wrote: > [...] >> I can send it through my seccomp tree via James Morris. > > Could you please do it? Hi! Yes, sorry, this fell through the cracks. Now applied. -Kees -- Kees Cook Pixel Security

Re: [PATCH] PCMCIA / PM: Avoid noirq suspend aborts during suspend-to-idle

2018-02-22 Thread Rafael J. Wysocki
On Thu, Feb 22, 2018 at 5:45 PM, Dominik Brodowski wrote: > On Wed, Feb 21, 2018 at 01:24:16PM +0100, Rafael J. Wysocki wrote: >> Avoid that by using a new socket state flag, SOCKET_IN_RESUME, >> to indicate that socket_early_resume() has already run for the >> socket in which case socket_suspend(

Re: [PATCH 1/1] x86: Fix Intel Edison module stuck reboot

2018-02-22 Thread Andy Shevchenko
On Thu, Feb 22, 2018 at 11:27 AM, Sebastian Panceac wrote: > > When powering Intel Edison module with 3.3V, the "reboot" command makes the > module stuck. > If the module is powered at a greater voltage, like 4.4V(as the Edison Mini > Breakout board does), reboot works OK. > This patch fixes the

Re: kernel BUG at mm/khugepaged.c:533 on 4.15.3

2018-02-22 Thread Laura Abbott
On 02/21/2018 01:14 AM, Kirill A. Shutemov wrote: On Mon, Feb 19, 2018 at 10:51:01AM -0800, Laura Abbott wrote: Hi, Fedora got a bug report of a BUG with 4.15.3: (https://bugzilla.redhat.com/show_bug.cgi?id=1546709) Is it new to v4.15 kernel? I don't see any recent change that could cause it.

Re: [PATCH] dt-bindings: fpga: Consolidate bridge properties

2018-02-22 Thread Moritz Fischer
On Thu, Feb 22, 2018 at 08:12:19AM +0100, Michal Simek wrote: > On 21.2.2018 18:33, Moritz Fischer wrote: > > Consolidate bridge properties in a single file, instead of duplicating > > the same optional property over and over again. > > > > Signed-off-by: Moritz Fischer > > Cc: Alan Tull > > Cc:

Re: [PATCH v2] efivarfs: Limit the rate for non-root to read files

2018-02-22 Thread Linus Torvalds
On Thu, Feb 22, 2018 at 9:15 AM, Luck, Tony wrote: > > In efivarfs if the limit is exceeded when reading, we take an > interruptible nap for 50ms and check the rate limit again. Ok, turning that 'if' into a 'while' makes the sleeping work even in the presence of lots of threads, and that all look

[PATCH] usbip: vudc: fix null pointer dereference on udc->lock

2018-02-22 Thread Colin King
From: Colin Ian King Currently the driver attempts to spin lock on udc->lock before a NULL pointer check is performed on udc, hence there is a potential null pointer dereference on udc->lock. Fix this by moving the null check on udc before the lock occurs. Fixes: ea6873a45a22 ("usbip: vudc: Add

Re: [PATCH NAND v5] mtd: nand: Replace printk() with appropriate pr_*() macro

2018-02-22 Thread Boris Brezillon
On Thu, 22 Feb 2018 19:08:29 +0200 Andy Shevchenko wrote: > On Thu, Feb 22, 2018 at 6:31 PM, Shreeya Patel > wrote: > > Using pr_() is more concise than > > printk(KERN_). > > Replace printks having a log level with the appropriate > > pr_*() macros. > > Define pr_fmt() and remove other addition

Re: [PATCH] doc: process: Add "Root-caused-by" and "Suggested-by"

2018-02-22 Thread Jonathan Corbet
On Wed, 21 Feb 2018 16:37:50 -0800 Kees Cook wrote: > As recently pointed out by Linus, "Root-caused-by" is a good tag to include > since it can indicate significantly more work than "just" a Reported-by. > This adds it and "Suggested-by" (which was also missing) to the documented > list of tags.

Re: uprobes/perf: KASAN: use-after-free in uprobe_perf_close

2018-02-22 Thread Oleg Nesterov
On 02/22, Peter Zijlstra wrote: > > On Thu, Feb 22, 2018 at 06:04:27PM +0100, Peter Zijlstra wrote: > > On Thu, Feb 22, 2018 at 05:37:15PM +0100, Oleg Nesterov wrote: > > > > This all makes me think that we should change (fix) > > > kernel/events/core.c... > > > > That's going to be mighty dodgy t

[PATCH v3] kconfig.h: Include compiler types to avoid missed struct attributes

2018-02-22 Thread Kees Cook
The header files for some structures could get included in such a way that struct attributes (specifically __randomize_layout from path.h) would be parsed as variable names instead of attributes. This could lead to some instances of a structure being unrandomized, causing nasty GPFs, etc. This pat

Re: [RFC tip/locking/lockdep v5 08/17] lockdep: Fix recursive read lock related safe->unsafe detection

2018-02-22 Thread Peter Zijlstra
On Thu, Feb 22, 2018 at 03:08:55PM +0800, Boqun Feng wrote: > There are four cases for recursive read lock realted deadlocks: > > (--(X..Y)--> means a strong dependency path starts with a --(X*)--> > dependency and ends with a --(*Y)-- dependency.) > > 1.An irq-safe lock L1 has a dependency -

Re: [PATCH v3 06/10] pwm: add PWM modes

2018-02-22 Thread Claudiu Beznea
On 22.02.2018 19:28, Andy Shevchenko wrote: > On Thu, Feb 22, 2018 at 2:01 PM, Claudiu Beznea > wrote: >> Add PWM normal and complementary modes. > >> +- PWM_DTMODE_COMPLEMENTARY: PWM complementary working mode (for PWM >> +channels two outputs); if not specified, the default for PWM channel wi

[PATCH RFC] driver core: Reprobe consumer if it was unbound by dropped device_link

2018-02-22 Thread Jyri Sarha
Put consumer device to deferred probe list if it is unbound due to a dropped link to a supplier. When a device link supplier is unbound (either manually or because one of its own suppliers was unbound), its consumers are unbound as well. Currently if the supplier binds again after this the consume

Re: [RFC tip/locking/lockdep v5 08/17] lockdep: Fix recursive read lock related safe->unsafe detection

2018-02-22 Thread Peter Zijlstra
On Thu, Feb 22, 2018 at 03:08:55PM +0800, Boqun Feng wrote: > There are four cases for recursive read lock realted deadlocks: > > (--(X..Y)--> means a strong dependency path starts with a --(X*)--> > dependency and ends with a --(*Y)-- dependency.) > > 1.An irq-safe lock L1 has a dependency -

Re: [PATCH net v3 2/2] tuntap: correctly add the missing xdp flush

2018-02-22 Thread Jesper Dangaard Brouer
On Thu, 22 Feb 2018 17:36:46 +0800 Jason Wang wrote: > Commit 762c330d670e ("tuntap: add missing xdp flush") tries to fix the > devmap stall caused by missed xdp flush by counting the pending xdp > redirected packets and flush when it exceeds NAPI_POLL_WEIGHT or > MSG_MORE is clear. This may lead

Re: [PATCH v2 0/3] new driver for Valve Steam Controller

2018-02-22 Thread Rodrigo Rivas Costa
On Thu, Feb 22, 2018 at 06:06:30PM +0100, Benjamin Tissoires wrote: > On Thu, Feb 22, 2018 at 5:31 PM, Rodrigo Rivas Costa > wrote: > > On Thu, Feb 22, 2018 at 10:10:40AM +0100, Benjamin Tissoires wrote: > >> On Thu, Feb 22, 2018 at 1:13 AM, Pierre-Loup A. Griffais > >> wrote: > >> > > >> > > >>

Re: uprobes/perf: KASAN: use-after-free in uprobe_perf_close

2018-02-22 Thread Oleg Nesterov
On 02/22, Peter Zijlstra wrote: > > On Thu, Feb 22, 2018 at 05:37:15PM +0100, Oleg Nesterov wrote: > > On 02/22, Prashant Bhole wrote: > > > > After debugging, found that uprobe_perf_close() is called after task has > > > been terminated and uprobe_perf_close() tries to access task_struct of the >

[RFC PATCH 1/2] serial: 8250_dw: add IO space support

2018-02-22 Thread John Garry
The current 8250_dw driver only supports MEM iotype. It is desired to have a platform device-based 8250 UART driver for ACPI FW with IO port iotype, so update the driver to support this. Note: a solution needs to be found for autconfig using MEM accessors only. Signed-off-by: John Garry --- dri

[RFC PATCH 2/2] serial: 8250_dw: support polling mode

2018-02-22 Thread John Garry
It would be useful to make this driver support some 8250-compatible devices which have no interrupt line. For these, we allow for no interrupt, and will fallback on polling mode. Note: the 8250 dt bindings state that "interrupts" is a required property: "interrupts : should contain uart interrupt

[PATCH] MIPS: ath25: check for kzalloc allocation failure

2018-02-22 Thread Colin King
From: Colin Ian King Currently there is no null check on a failed allocation of board_data, and hence a null pointer dereference will occurr. Fix this by checking for the out of memory null pointer. Fixes: a7473717483e ("MIPS: ath25: add board configuration detection") Signed-off-by: Colin Ian

[RFC PATCH 0/2] serial: 8250_dw: IO space + polling mode support

2018-02-22 Thread John Garry
There is a requirement for supporting an 8250-compatible UART with the following profile/features: - platform device - polling mode (i.e. no interrupt support) - ACPI FW - IO port iotype - 16550-compatible For OF, we have 8250_of.c, and for PNP device we have 8250_pnp.c drivers. However there does

Re: [v2 1/3] x86/microcode/intel: Check microcode revision before updating sibling threads

2018-02-22 Thread Henrique de Moraes Holschuh
On Thu, 22 Feb 2018, Van De Ven, Arjan wrote: > > > In the past the only guidance was to not load microcode at the same time > > > to > > the > > > thread siblings of a core. We now have new guidance that the sibling must > > > be > > > spinning and not doing other things that can introduce insta

[RFC PATCH V2] virtio_pci: Add SR-IOV support

2018-02-22 Thread Mark Rustad
Hardware-realized virtio-pci devices can implement SR-IOV, so this patch enables its use. The device in question is an upcoming Intel NIC that implements both a virtio-net PF and virtio-net VFs. These are hardware realizations of what has been up to now been a software interface. The device in que

Re: [PATCH V15 06/22] mmc: block: Add blk-mq support

2018-02-22 Thread Dmitry Osipenko
On 22.02.2018 10:42, Adrian Hunter wrote: > On 21/02/18 22:50, Dmitry Osipenko wrote: >> On 29.11.2017 16:41, Adrian Hunter wrote: >>> Define and use a blk-mq queue. Discards and flushes are processed >>> synchronously, but reads and writes asynchronously. In order to support >>> slow DMA unmapping

Re: [PATCH v2] efivarfs: Limit the rate for non-root to read files

2018-02-22 Thread Luck, Tony
On Thu, Feb 22, 2018 at 09:39:10AM -0800, Linus Torvalds wrote: > I'm certainly ok with this. I'm assuming this has been tested I read some files using "dd bs=1" as root and non-root. Root still goes fast, non-root is limited. Both see the same data. I can ^C the non-root version and the dd quits

[PATCH] cpufreq: scpi: drop redundant arm_big_little config dependency

2018-02-22 Thread Sudeep Holla
Commit 343a8d17fa8d (cpufreq: scpi: remove arm_big_little dependency) removed the SCPI cpufreq dependency on arm_big_little cpufreq driver. However the Kconfig entry still depends on ARM_BIG_LITTLE_CPUFREQ which is clearly wrong. This patch removes that unnecessary Kconfig dependency. Fixes: 343a

Re: [PATCH 1/4] i2c: xlp9xx: return ENXIO on slave address NACK

2018-02-22 Thread dann frazier
On Tue, Jan 30, 2018 at 7:28 AM, George Cherian wrote: > Gentle Ping on this series. I've been using these on a few Cavium Sabre boards, which previously had an unusable system interface (/dev/ipmi) due to timeouts or just enumerations failures. So, fwiw: Tested-by: dann frazier -dann > On 0

Re: Removing architectures without upstream gcc support

2018-02-22 Thread Christoph Hellwig
On Thu, Feb 22, 2018 at 09:14:11AM -0800, Max Filippov wrote: > On Thu, Feb 22, 2018 at 8:02 AM, Christoph Hellwig wrote: > > I'd love to see dead architecture ports dropped if they really are > > more or less abandoned. In addition to your missing gcc port ones > > above (minus openrisc) it seem

Re: [PATCH v3] kconfig.h: Include compiler types to avoid missed struct attributes

2018-02-22 Thread Linus Torvalds
On Thu, Feb 22, 2018 at 9:41 AM, Kees Cook wrote: > > Updated to include Tested-by. Linus, this looks ready to go. Ok, applied. I'm a bit worried that this ends up bypassing our automatic dependency generation. Lookie here (in a fully built tree): find . -name '*.o.cmd' | xargs gre

[PATCH] pinctrl: bc2835: Add brcm,level property

2018-02-22 Thread Matheus Castello
Property to set initial value of pin output buffer. Signed-off-by: Matheus Castello --- .../bindings/pinctrl/brcm,bcm2835-gpio.txt | 5 +- drivers/pinctrl/bcm/pinctrl-bcm2835.c | 90 +- 2 files changed, 75 insertions(+), 20 deletions(-) diff --git a/Doc

Re: [PATCH v2] efivarfs: Limit the rate for non-root to read files

2018-02-22 Thread Linus Torvalds
On Thu, Feb 22, 2018 at 9:54 AM, Luck, Tony wrote: > With the new "while/nap" change there would still be one message > per second, but the number of callbacks suppressed should be 1 > (unless the user has many threads doing reads). > > Maybe it is good to know that an application is doing somethi

Re: [PATCH v2] efivarfs: Limit the rate for non-root to read files

2018-02-22 Thread Ard Biesheuvel
On 22 February 2018 at 18:07, Linus Torvalds wrote: > On Thu, Feb 22, 2018 at 9:54 AM, Luck, Tony wrote: >> With the new "while/nap" change there would still be one message >> per second, but the number of callbacks suppressed should be 1 >> (unless the user has many threads doing reads). >> >> M

[PATCH] MIPS: OCTEON: irq: check for null return on kzalloc allocation

2018-02-22 Thread Colin King
From: Colin Ian King The allocation of host_data is not null checked, leading to a null pointer dereference if the allocation fails. Fix this by adding a null check and return with -ENOMEM. Fixes: 64b139f97c01 ("MIPS: OCTEON: irq: add CIB and other fixes") Signed-off-by: Colin Ian King --- arc

Re: [PATCH] MIPS: OCTEON: irq: check for null return on kzalloc allocation

2018-02-22 Thread David Daney
On 02/22/2018 10:08 AM, Colin King wrote: From: Colin Ian King The allocation of host_data is not null checked, leading to a null pointer dereference if the allocation fails. Fix this by adding a null check and return with -ENOMEM. Fixes: 64b139f97c01 ("MIPS: OCTEON: irq: add CIB and other fix

Re: [PATCH fixes v3] pinctrl: Really force states during suspend/resume

2018-02-22 Thread Marc Zyngier
Hi Linus, On 22/02/18 15:30, Linus Walleij wrote: > On Mon, Feb 19, 2018 at 8:23 PM, Marc Zyngier wrote: >>> Am Montag, 19. Februar 2018, 19:03:27 CET schrieb Florian Fainelli: > Can you indicate which DTS file is used for your Chromebook model? Sorry about the breakage. >>> >>> that

Re: [RFC PATCH] riscv/locking: Strengthen spin_lock() and spin_unlock()

2018-02-22 Thread Paul E. McKenney
On Thu, Feb 22, 2018 at 09:27:09AM -0800, Daniel Lustig wrote: > On 2/22/2018 6:12 AM, Andrea Parri wrote: > > On Thu, Feb 22, 2018 at 02:40:04PM +0100, Peter Zijlstra wrote: > >> On Thu, Feb 22, 2018 at 01:19:50PM +0100, Andrea Parri wrote: > >> > >>> C unlock-lock-read-ordering > >>> > >>> {} > >

Re: [PATCH v6 2/5] fuse: Fail all requests with invalid uids or gids

2018-02-22 Thread Eric W. Biederman
Miklos Szeredi writes: > On Wed, Feb 21, 2018 at 9:29 PM, Eric W. Biederman > wrote: >> Upon a cursory examinination the uid and gid of a fuse request are >> necessary for correct operation. Failing a fuse request where those >> values are not reliable seems a straight forward and reliable mean

Re: [PATCH 1/2] pci: endpoint: Free func_name after last usage

2018-02-22 Thread Lorenzo Pieralisi
On Wed, Feb 21, 2018 at 01:47:06PM +0100, Rolf Evers-Fischer wrote: > From: Rolf Evers-Fischer > > This commit decreases the number of jump labels and ensures > that the next commit doesn't increase the number of occurrences > of 'kfree(func_name)'. > > Change-Id: I0d1b6fd652395b85f82b11c43bf9b7

Re: [RFC PATCH] riscv/locking: Strengthen spin_lock() and spin_unlock()

2018-02-22 Thread Peter Zijlstra
On Thu, Feb 22, 2018 at 09:27:09AM -0800, Daniel Lustig wrote: > On 2/22/2018 6:12 AM, Andrea Parri wrote: > > On Thu, Feb 22, 2018 at 02:40:04PM +0100, Peter Zijlstra wrote: > >> On Thu, Feb 22, 2018 at 01:19:50PM +0100, Andrea Parri wrote: > >> > >>> C unlock-lock-read-ordering > >>> > >>> {} > >

Re: [RFC PATCH V2] virtio_pci: Add SR-IOV support

2018-02-22 Thread Christoph Hellwig
Can we move this into common code as a a generic_sriov_configure helper? Nothing is really virtio specific, and it seems like some other drivers could also use it, e.g. ena or nvme.

Re: [RFC PATCH] riscv/locking: Strengthen spin_lock() and spin_unlock()

2018-02-22 Thread Peter Zijlstra
On Thu, Feb 22, 2018 at 10:13:17AM -0800, Paul E. McKenney wrote: > So we have something that is not all that rare in the Linux kernel > community, namely two conflicting more-or-less concurrent changes. > This clearly needs to be resolved, either by us not strengthening the > Linux-kernel memory m

Re: [PATCH v2] usb: host: ehci-platform: add support for optional external vbus supply

2018-02-22 Thread Alan Stern
On Thu, 22 Feb 2018, Amelie DELAUNAY wrote: > > --- a/Documentation/devicetree/bindings/usb/usb-ehci.txt > > +++ b/Documentation/devicetree/bindings/usb/usb-ehci.txt > > @@ -19,6 +19,7 @@ Optional properties: > > - phys : phandle + phy specifier pair > > - phy-names : "

<    1   2   3   4   5   6   7   8   9   10   >