Re: [PATCH v2 2/5] irqchip/gic-v3-its: add ability to save/restore ITS state

2018-01-26 Thread dbasehore .
On Fri, Jan 26, 2018 at 12:59 PM, Brian Norris wrote: > One trivial comment: > > On Thu, Jan 25, 2018 at 11:38:32PM -0800, Derek Basehore wrote: >> Some platforms power off GIC logic in suspend, so we need to >> save/restore state. The distributor and redistributor registers need >> to be handled

Re: [PATCH V4 0/3] Use mm_struct and switch_mm() instead of manually

2018-01-26 Thread Matt Fleming
On Thu, 18 Jan, at 01:01:04PM, Sai Praneeth Prakhya wrote: > From: Sai Praneeth > > Presently, in x86, to invoke any efi function like > efi_set_virtual_address_map() or any efi_runtime_service() the code path > typically involves read_cr3() (save previous pgd), write_cr3() > (write efi_pgd) and

Re: [PATCH] of: use hash based search in of_find_node_by_phandle

2018-01-26 Thread Frank Rowand
On 01/26/18 00:22, Chintan Pandya wrote: > > > On 1/26/2018 1:24 AM, Frank Rowand wrote: >> On 01/25/18 02:14, Chintan Pandya wrote: >>> of_find_node_by_phandle() takes a lot of time finding >>> right node when your intended device is too right-side >>> in the fdt. Reason is, we search each devic

Re: [PATCH] of: use hash based search in of_find_node_by_phandle

2018-01-26 Thread Frank Rowand
On 01/26/18 13:27, Frank Rowand wrote: > On 01/26/18 00:22, Chintan Pandya wrote: >> >> >> On 1/26/2018 1:24 AM, Frank Rowand wrote: >>> On 01/25/18 02:14, Chintan Pandya wrote: of_find_node_by_phandle() takes a lot of time finding right node when your intended device is too right-side >>

[PATCH 1/4] PCI: Add SPDX GPL-2.0 when no license was specified

2018-01-26 Thread Bjorn Helgaas
From: Bjorn Helgaas b24413180f56 ("License cleanup: add SPDX GPL-2.0 license identifier to files with no license") added SPDX GPL-2.0 to several PCI files that previously contained no license information. Add SPDX GPL-2.0 to all other PCI files that did not contain any license information and he

[PATCH 3/4] PCI: Add SPDX GPL-2.0 to replace COPYING boilerplate

2018-01-26 Thread Bjorn Helgaas
From: Bjorn Helgaas Add SPDX GPL-2.0 to all PCI files that referred to the kernel default "COPYING" file, which specifies GPL version 2. Remove the boilerplate language referring to the GPL and "COPYING", relying on the assertion in b24413180f56 ("License cleanup: add SPDX GPL-2.0 license identi

[PATCH 2/4] PCI: Add SPDX GPL-2.0 to replace GPL v2 boilerplate

2018-01-26 Thread Bjorn Helgaas
From: Bjorn Helgaas Add SPDX GPL-2.0 to all PCI files that specified the GPL version 2 license. Remove the boilerplate GPL version 2 language, relying on the assertion in b24413180f56 ("License cleanup: add SPDX GPL-2.0 license identifier to files with no license") that the SPDX identifier may b

[PATCH 0/4] PCI: Add SPDX tags

2018-01-26 Thread Bjorn Helgaas
b24413180f56 ("License cleanup: add SPDX GPL-2.0 license identifier to files with no license") added SPDX GPL-2.0 tags to several PCI files. These patches add SPDX tags to almost all remaining PCI files. For ease of reviewing they're split into several cases (GPL v2, GPL v2+, etc.) One file (dri

[PATCH 4/4] PCI: Add SPDX GPL-2.0+ to replace GPL v2 or later boilerplate

2018-01-26 Thread Bjorn Helgaas
From: Bjorn Helgaas Add SPDX GPL-2.0+ to all PCI files that specified the GPL and allowed either GPL version 2 or any later version. Remove the boilerplate GPL version 2 or later language, relying on the assertion in b24413180f56 ("License cleanup: add SPDX GPL-2.0 license identifier to files wi

Re: [PATCH] of: use hash based search in of_find_node_by_phandle

2018-01-26 Thread Frank Rowand
On 01/26/18 13:29, Frank Rowand wrote: > On 01/26/18 13:27, Frank Rowand wrote: >> On 01/26/18 00:22, Chintan Pandya wrote: >>> >>> >>> On 1/26/2018 1:24 AM, Frank Rowand wrote: On 01/25/18 02:14, Chintan Pandya wrote: > of_find_node_by_phandle() takes a lot of time finding > right nod

Re: [PATCH v5 7/7] x86/speculation: Add basic IBPB (Indirect Branch Prediction Barrier) support

2018-01-26 Thread Tim Chen
On 01/25/2018 08:14 AM, David Woodhouse wrote: > > diff --git a/arch/x86/include/asm/nospec-branch.h > b/arch/x86/include/asm/nospec-branch.h > index 4ad4108..34e384c 100644 > --- a/arch/x86/include/asm/nospec-branch.h > +++ b/arch/x86/include/asm/nospec-branch.h > @@ -218,5 +218,18 @@ static i

Re: [PATCH v2] of: use hash based search in of_find_node_by_phandle

2018-01-26 Thread Rob Herring
On Fri, Jan 26, 2018 at 09:34:59AM -0600, Rob Herring wrote: > On Fri, Jan 26, 2018 at 9:14 AM, Chintan Pandya > wrote: > > > >> I'm probably missing something obvious, but: Aren't phandles in practice > >> small consecutive integers assigned by dtc? If so, why not just have a > >> smallish stati

Re: [RFC 1/2] arm: cacheflush syscall: process only pages that are in the memory

2018-01-26 Thread Russell King - ARM Linux
On Fri, Jan 26, 2018 at 02:30:47PM +0100, Marek Szyprowski wrote: > Hi Russell, > > On 2018-01-26 12:32, Russell King - ARM Linux wrote: > >On Fri, Jan 26, 2018 at 12:14:40PM +0100, Marek Szyprowski wrote: > >>glibc in calls cacheflush syscall on the whole textrels section of the > >>relocated bin

INVESTMENT

2018-01-26 Thread Ibrahim Ali
INVESTMENT You may be surprised to receive my letter, however,I have decided to contact you for confidential, Urgent and rewarding joint business. My name is Ibrahim Ali was a Personal Assistant to the Late Libyan President, Muammar Gaddafi, who was Killed in 20 October 2011 and my aim of writing t

Re: [PATCH v24 1/2] mm: support reporting free page blocks

2018-01-26 Thread Michael S. Tsirkin
On Fri, Jan 26, 2018 at 05:00:09PM +0200, Michael S. Tsirkin wrote: > On Fri, Jan 26, 2018 at 11:29:15AM +0800, Wei Wang wrote: > > On 01/25/2018 09:41 PM, Michael S. Tsirkin wrote: > > > On Wed, Jan 24, 2018 at 06:42:41PM +0800, Wei Wang wrote: > > > > This patch adds support to walk through the f

Re: [RFC PATCH 6/8] v4l2: document the request API interface

2018-01-26 Thread Nicolas Dufresne
Le vendredi 26 janvier 2018 à 12:40 -0800, Randy Dunlap a écrit : > > +Request API > > +=== > > + > > +The Request API has been designed to allow V4L2 to deal with > > requirements of > > +modern IPs (stateless codecs, MIPI cameras, ...) and APIs (Android > > Codec v2). > > Hi, > Just a qu

[PATCH] orangefs: reverse sense of revalidate is-inode-stale test

2018-01-26 Thread Martin Brandenburg
It was wrong. Signed-off-by: Martin Brandenburg --- fs/orangefs/dcache.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/fs/orangefs/dcache.c b/fs/orangefs/dcache.c index ae782df5c063..c7aa5c923477 100644 --- a/fs/orangefs/dcache.c +++ b/fs/orangefs/dcache.

Re: [PATCH] x86/cpufeatures: Cleanup AMD speculation feature bits

2018-01-26 Thread Borislav Petkov
On Fri, Jan 26, 2018 at 03:06:20PM -0600, Tom Lendacky wrote: > So I like the idea of AMD_IBRS/AMD_IBPB/AMD_STIBP and then use the magic > quotes as appropriate. We could probably use the magic quotes on > AMD_STIBP and set X86_FEATURE_STIBP when we see X86_FEATURE_AMD_STIBP. Like this? We set t

Re: [PATCH] x86/cpufeatures: Cleanup AMD speculation feature bits

2018-01-26 Thread David Woodhouse
On Fri, 2018-01-26 at 22:52 +0100, Borislav Petkov wrote: > On Fri, Jan 26, 2018 at 03:06:20PM -0600, Tom Lendacky wrote: > > > > So I like the idea of AMD_IBRS/AMD_IBPB/AMD_STIBP and then use the magic > > quotes as appropriate.  We could probably use the magic quotes on > > AMD_STIBP and set X86

Re: [PATCH] fork: Allow stack to be wiped on fork

2018-01-26 Thread Jiri Kosina
On Tue, 16 Jan 2018, Kees Cook wrote: > diff --git a/include/linux/thread_info.h b/include/linux/thread_info.h > index 34f053a150a9..091f53fe31cc 100644 > --- a/include/linux/thread_info.h > +++ b/include/linux/thread_info.h > @@ -43,7 +43,9 @@ enum { > #define THREAD_ALIGN THREAD_SIZE > #endif

Re: [PATCH] hrtimer: Reset hrtimer cpu base proper on CPU hotplug

2018-01-26 Thread Paul E. McKenney
On Fri, Jan 26, 2018 at 02:54:32PM +0100, Thomas Gleixner wrote: > The hrtimer interrupt code contains a hang detection and mitigation > mechanism, which prevents that a long delayed hrtimer interrupt causes a > continous retriggering of interrupts which prevent the system from making > progress. I

[PATCH] ir-hix5hd2: fix error handling of clk_prepare_enable()

2018-01-26 Thread Alexey Khoroshilov
Return code of clk_prepare_enable() is ignored in many places. The patch adds error handling for all of them. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/media/rc/ir-hix5hd2.c | 35 --- 1 file chang

Re: [PATCH] x86/cpufeatures: Cleanup AMD speculation feature bits

2018-01-26 Thread Borislav Petkov
On Fri, Jan 26, 2018 at 09:59:44PM +, David Woodhouse wrote: > If we wanted to do this kind of thing, we'd do it the other way round. > Turn the *Intel* feature into both 'IBRS' and 'IBPB' CPU-visible > features, and have those defined in the AMD word. You lost me here: have those defined in t

Re: [PATCH 1/2] arm64: dts: sdm845: Add minimal dts/dtsi files for sdm845 SoC and MTP

2018-01-26 Thread Stephen Boyd
On 01/25, Rajendra Nayak wrote: > create mode 100644 arch/arm64/boot/dts/qcom/sdm845-mtp.dts > create mode 100644 arch/arm64/boot/dts/qcom/sdm845-mtp.dtsi Do we really need two files? Maybe collapse the two? > create mode 100644 arch/arm64/boot/dts/qcom/sdm845.dtsi > diff --git a/arch/arm64/bo

Re: [PATCH 2/2] arm64: dts: sdm845: Add serial console support

2018-01-26 Thread Stephen Boyd
On 01/25, Rajendra Nayak wrote: > diff --git a/arch/arm64/boot/dts/qcom/sdm845-pins.dtsi > b/arch/arm64/boot/dts/qcom/sdm845-pins.dtsi > new file mode 100644 > index ..b97f99e6f4b4 > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/sdm845-pins.dtsi > @@ -0,0 +1,32 @@ > +// SPDX-License-I

Re: [patch -mm v2 2/3] mm, memcg: replace cgroup aware oom killer mount option with tunable

2018-01-26 Thread David Rientjes
On Thu, 25 Jan 2018, Andrew Morton wrote: > > Now that each mem cgroup on the system has a memory.oom_policy tunable to > > specify oom kill selection behavior, remove the needless "groupoom" mount > > option that requires (1) the entire system to be forced, perhaps > > unnecessarily, perhaps unex

Re: [PATCH RFC 07/16] prcu: Implement call_prcu() API

2018-01-26 Thread Paul E. McKenney
On Fri, Jan 26, 2018 at 08:44:50AM +, Lihao Liang wrote: > On Thu, Jan 25, 2018 at 6:20 AM, Paul E. McKenney > wrote: > > On Tue, Jan 23, 2018 at 03:59:32PM +0800, liangli...@huawei.com wrote: > >> From: Lihao Liang > >> > >> This is PRCU's counterpart of RCU's call_rcu() API. > >> > >> Revie

[PATCH] regulator: of: Add a missing 'of_node_put()' in an error handling path of 'of_regulator_match()'

2018-01-26 Thread Christophe JAILLET
If an unlikely failure in 'of_get_regulator_init_data()' occurs, we must release the reference on the current 'child' node before returning. Signed-off-by: Christophe JAILLET --- drivers/regulator/of_regulator.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/regulator/of_regulator.c

[PATCH v3] mtd: nand: vf610: fix error handling in vf610_nfc_probe()

2018-01-26 Thread Alexey Khoroshilov
vf610_nfc_probe() misses error handling of mtd_device_register() and contains unneeded of_node_put() on error path. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- v2: Add nand_cleanup() to undone nand_scan_tail() as Boris Brezillon noted. v3:

Re: [PATCH] fork: Allow stack to be wiped on fork

2018-01-26 Thread Jiri Kosina
On Fri, 26 Jan 2018, Jiri Kosina wrote: > > diff --git a/include/linux/thread_info.h b/include/linux/thread_info.h > > index 34f053a150a9..091f53fe31cc 100644 > > --- a/include/linux/thread_info.h > > +++ b/include/linux/thread_info.h > > @@ -43,7 +43,9 @@ enum { > > #define THREAD_ALIGN TH

Re: [patch -mm 3/4] mm, memcg: replace memory.oom_group with policy tunable

2018-01-26 Thread David Rientjes
On Fri, 26 Jan 2018, Michal Hocko wrote: > > Could you elaborate on why specifying the oom policy for the entire > > hierarchy as part of the root mem cgroup and also for individual subtrees > > is incomplete? It allows admins to specify and delegate policy decisions > > to subtrees owners as

Re: selftests/x86/fsgsbase_64 test problem

2018-01-26 Thread Andy Lutomirski
On Fri, Jan 26, 2018 at 11:46 AM, Andy Lutomirski wrote: > On Fri, Jan 26, 2018 at 10:59 AM, Andy Lutomirski wrote: >> On Fri, Jan 26, 2018 at 8:22 AM, Andy Lutomirski wrote: >>> On Fri, Jan 26, 2018 at 7:36 AM, Dan Rue wrote: We've noticed that fsgsbase_64 can fail intermittently wit

[GIT PULL] RISC-V: We have a new mailing list and git repo!

2018-01-26 Thread Palmer Dabbelt
The following changes since commit 0c5b9b5d9adbad4b60491f9ba0d2af38904bb4b9: Linux 4.15-rc9 (2018-01-21 13:51:26 -0800) are available in the git repository at: ssh://g...@gitolite.kernel.org/pub/scm/linux/kernel/git/palmer/riscv-linux.git tags/riscv-for-linus-4.15-maintainers gpg: Signatur

Re: [patch -mm v2 2/3] mm, memcg: replace cgroup aware oom killer mount option with tunable

2018-01-26 Thread Andrew Morton
On Fri, 26 Jan 2018 14:20:24 -0800 (PST) David Rientjes wrote: > On Thu, 25 Jan 2018, Andrew Morton wrote: > > > > Now that each mem cgroup on the system has a memory.oom_policy tunable to > > > specify oom kill selection behavior, remove the needless "groupoom" mount > > > option that requires

Re: selftests/x86/fsgsbase_64 test problem

2018-01-26 Thread Andy Lutomirski
On Fri, Jan 26, 2018 at 2:38 PM, Andy Lutomirski wrote: > On Fri, Jan 26, 2018 at 11:46 AM, Andy Lutomirski wrote: >> On Fri, Jan 26, 2018 at 10:59 AM, Andy Lutomirski wrote: >>> On Fri, Jan 26, 2018 at 8:22 AM, Andy Lutomirski wrote: On Fri, Jan 26, 2018 at 7:36 AM, Dan Rue wrote: >

[PATCH] kernfs: account kernfs_node_cache as reclaimable

2018-01-26 Thread Cong Wang
Similar to commit df206988e03e ("fs: fuse: account fuse_inode slab memory as reclaimable"), these kernfs nodes are currently included in the unreclaimable slab counts - SUnreclaim in /proc/meminfo. And they are reclaimable too and can be freed by kernfs_evict_inode() via /proc/sys/vm/drop_caches ea

[PATCH 1/3] KVM: nVMX: Eliminate vmcs02 pool

2018-01-26 Thread Paolo Bonzini
From: Jim Mattson The potential performance advantages of a vmcs02 pool have never been realized. To simplify the code, eliminate the pool. Instead, a single vmcs02 is allocated per VCPU when the VCPU enters VMX operation. Signed-off-by: Jim Mattson Signed-off-by: Mark Kanda Reviewed-by: Ameya

[PATCH 0/3] Per-VCPU MSR bitmaps patches - topic branch for x86/pti

2018-01-26 Thread Paolo Bonzini
David and others, the following changes since commit ba804bb4b72e57374b5f567b783aa0298fba0ce6: Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net (2018-01-26 09:03:16 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/kvm.git msr-bitmaps for yo

[PATCH 3/3] KVM: VMX: make MSR bitmaps per-VCPU

2018-01-26 Thread Paolo Bonzini
Place the MSR bitmap in struct loaded_vmcs, and update it in place every time the x2apic or APICv state can change. This is rare and the loop can handle 64 MSRs per iteration, in a similar fashion as nested_vmx_prepare_msr_bitmap. This prepares for choosing, on a per-VM basis, whether to intercep

[PATCH 2/3] KVM: VMX: introduce alloc_loaded_vmcs

2018-01-26 Thread Paolo Bonzini
Group together the calls to alloc_vmcs and loaded_vmcs_init. Soon we'll also allocate an MSR bitmap there. Signed-off-by: Paolo Bonzini --- arch/x86/kvm/vmx.c | 36 ++-- 1 file changed, 22 insertions(+), 14 deletions(-) diff --git a/arch/x86/kvm/vmx.c b/arch/x86

Re: [patch -mm v2 2/3] mm, memcg: replace cgroup aware oom killer mount option with tunable

2018-01-26 Thread David Rientjes
On Fri, 26 Jan 2018, Andrew Morton wrote: > > -ECONFUSED. We want to have a mount option that has the sole purpose of > > doing echo cgroup > /mnt/cgroup/memory.oom_policy? > > Approximately. Let me put it another way: can we modify your patchset > so that the mount option remains, and continu

Re: selftests/x86/fsgsbase_64 test problem

2018-01-26 Thread H. Peter Anvin
On 01/26/18 11:46, Andy Lutomirski wrote: > > Under QEMU TCG, gs stays equal to 1. On native or KVM, on Skylake, it > changes to 0. > > On KVM or native, I do not observe do_debug getting called with %gs == > 1. On TCG, I do. I don't think that's precisely the problem that's > causing the test

Re: selftests/x86/fsgsbase_64 test problem

2018-01-26 Thread Borislav Petkov
On Fri, Jan 26, 2018 at 02:38:28PM -0800, Andy Lutomirski wrote: > Borislav, any chance you could run the attached program on an AMD > machine to see what it does? [boris@pd: /tmp> ./gs1 PID = 3420 ax = 0, cx = 0, dx = 0 This is on 4.15-rc7-ish + tip/master from 2 wks ago. -- Regards/Gruss,

[PATCH v3] Remove silentoldconfig from help and docs; fix kconfig/conf's help

2018-01-26 Thread Marc Herbert
As explained by Michal Marek at https://lkml.org/lkml/2011/8/31/189 silentoldconfig has become a misnomer. It has become an internal interface so remove it from "make help" and Documentation/ to stop confusing people using it as seen for instance at https://chromium-review.googlesource.com/835632 D

Re: [PATCH] Remove silentoldconfig from "make help"; fix kconfig/conf's help

2018-01-26 Thread Marc Herbert
Masahiro, On 17/01/2018 20:31, Masahiro Yamada wrote: > Sorry for my late reply. I think we're even now :-) >> I'd like to keep that sentence because it's there to explain the legacy and >> confusing "--silentoldconfig" name which unfortunately still sticks out in >> the *current* conf.c inter

Re: [PATCH net-next v1] samples/bpf: Partially fixes the bpf.o build

2018-01-26 Thread Daniel Borkmann
On 01/26/2018 09:30 AM, Mickaël Salaün wrote: > On 26/01/2018 03:16, Alexei Starovoitov wrote: >> On Fri, Jan 26, 2018 at 01:39:30AM +0100, Mickaël Salaün wrote: >>> Do not build lib/bpf/bpf.o with this Makefile but use the one from the >>> library directory. This avoid making a buggy bpf.o file (

Re: [PATCH v2] of: use hash based search in of_find_node_by_phandle

2018-01-26 Thread kbuild test robot
Hi Chintan, Thank you for the patch! Yet something to improve: [auto build test ERROR on robh/for-next] [also build test ERROR on v4.15-rc9 next-20180126] [cannot apply to glikely/devicetree/next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system

Re: [GIT PULL] RISC-V: We have a new mailing list and git repo!

2018-01-26 Thread Linus Torvalds
On Fri, Jan 26, 2018 at 2:39 PM, Palmer Dabbelt wrote: > > I can understand if it's too late to get this into 4.15, but given that > it's not a code change I was hoping it'd still be OK. No problem. Something like this is a no-brainer. Pulled, Linus

Re: [patches] Re: [GIT PULL] RISC-V: We have a new mailing list and git repo!

2018-01-26 Thread Palmer Dabbelt
On Fri, 26 Jan 2018 15:13:19 PST (-0800), Linus Torvalds wrote: On Fri, Jan 26, 2018 at 2:39 PM, Palmer Dabbelt wrote: I can understand if it's too late to get this into 4.15, but given that it's not a code change I was hoping it'd still be OK. No problem. Something like this is a no-brainer

Re: [PATCH] x86/cpufeatures: Cleanup AMD speculation feature bits

2018-01-26 Thread Tom Lendacky
On 1/26/2018 4:10 PM, Borislav Petkov wrote: > On Fri, Jan 26, 2018 at 09:59:44PM +, David Woodhouse wrote: >> If we wanted to do this kind of thing, we'd do it the other way round. >> Turn the *Intel* feature into both 'IBRS' and 'IBPB' CPU-visible >> features, and have those defined in the AM

Re: BUG: unable to handle kernel NULL pointer dereference in irq_bypass_register_consumer

2018-01-26 Thread Eric Biggers
On Sun, Dec 17, 2017 at 06:37:02PM +0800, Wanpeng Li wrote: > 2017-12-17 17:56 GMT+08:00 syzbot > : > > Hello, > > > > syzkaller hit the following crash on > > 41d8c16909ebda40f7b4982a7f5e2ad102705ade > > git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/master > > compiler: gcc (GC

Re: [PATCH v2] of: use hash based search in of_find_node_by_phandle

2018-01-26 Thread kbuild test robot
Hi Chintan, Thank you for the patch! Yet something to improve: [auto build test ERROR on robh/for-next] [also build test ERROR on v4.15-rc9 next-20180126] [cannot apply to glikely/devicetree/next] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system

Re: Re: KASAN: use-after-free Write in irq_bypass_register_consumer

2018-01-26 Thread Eric Biggers
On Sat, Dec 16, 2017 at 04:37:02PM +0800, Lan, Tianyu wrote: > The root cause is that kvm_irqfd_assign() and kvm_irqfd_deassign() can't > be run in parallel. Some data structure(e.g, irqfd->consumer) will be > crashed because irqfd may be freed in deassign path before they are used > in assign path

Re: [patch v11 - re-ordered 03/12] FIXME platform/mellanox: Remove redundant dev_err messages on device_create

2018-01-26 Thread Darren Hart
On Fri, Jan 26, 2018 at 04:59:32PM +, Vadim Pasternak wrote: > > > > -Original Message- > > From: Darren Hart [mailto:dvh...@infradead.org] > > Sent: Thursday, January 25, 2018 11:47 PM > > To: Vadim Pasternak > > Cc: andy.shevche...@gmail.com; gre...@linuxfoundation.org; linux- > >

Re: general protection fault in proc_flush_task

2018-01-26 Thread Eric Biggers
On Wed, Nov 29, 2017 at 10:23:00PM -0800, syzbot wrote: > Hello, > > syzkaller hit the following crash on > 0c86a6bd85ff0629cd2c5141027fc1c8bb6cde9c > git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console ou

Re: BUG: unable to handle kernel NULL pointer dereference in proc_flush_task

2018-01-26 Thread Eric Biggers
On Tue, Dec 19, 2017 at 11:49:02PM -0800, syzbot wrote: > Hello, > > syzkaller hit the following crash on > 6084b576dca2e898f5c101baef151f7bfdbb606d > git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console o

[PATCH 0/5] Add debugfs info for the AMD IOMMU

2018-01-26 Thread Gary R Hook
The following series creates a debugfs directory for AMD IOMMUs, constructs a framework for additional entries, an online README, and a method for dumping device table entries. Data is reported in a default concise mode, but a verbose mode is enabled via a filesystem entry. This is the first of th

[PATCH 1/5] iommu/amd - Add debugfs support

2018-01-26 Thread Gary R Hook
Create the basic debugfs functions. Expose a count of IOMMU device table entries that appear to be in use. Signed-off-by: Gary R Hook --- drivers/iommu/Kconfig |9 +++ drivers/iommu/Makefile|2 - drivers/iommu/amd_iommu_debugfs.c | 112 +++

[PATCH 5/5] iommu/amd - Add a debugfs entry to specify a IOMMU device table entry

2018-01-26 Thread Gary R Hook
Initially (at boot) the device table values dumped are all of the active devices. Add a devid debugfs file to allow the user to select a single device table entry to dump (active or not). Let any devid value greater than the maximum allowable PCI ID (0x) restore the behavior to that effective

[PATCH 2/5] iommu/amd - Add a 'verbose' switch for IOMMU debugfs

2018-01-26 Thread Gary R Hook
Enable more descriptive debugfs output via a 'verbose' variable. Signed-off-by: Gary R Hook --- drivers/iommu/amd_iommu_debugfs.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/iommu/amd_iommu_debugfs.c b/drivers/iommu/amd_iommu_debugfs.c index 18f7

[PATCH 3/5] iommu/amd - Add a README variable for the IOMMU debugfs

2018-01-26 Thread Gary R Hook
Provide help text via a filesystem entry Signed-off-by: Gary R Hook --- drivers/iommu/amd_iommu_debugfs.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/drivers/iommu/amd_iommu_debugfs.c b/drivers/iommu/amd_iommu_debugfs.c index c449f3a7452c..5066d3976912

[PATCH 4/5] iommu/amd - Expose the active IOMMU device table entries

2018-01-26 Thread Gary R Hook
Add a debugfs entry to dump the active device table entries from the IOMMU's table. 'Active' is determined by non-default values in the first and second long words of the DTE. Aside from IOMMU devices, this output should list every device reported by lspci. Use arrays to store DTE bit field defini

Re: [PATCH v2] clk: qcom: Add Global Clock controller (GCC) driver for SDM845

2018-01-26 Thread Stephen Boyd
On 01/22, Amit Nischal wrote: > Add support for the global clock controller found on SDM845 > based devices. This should allow most non-multimedia device > drivers to probe and control their clocks. > > Signed-off-by: Taniya Das Is Taniya the author? Should be a From: line then. > Signed-off-by

[PATCH] ssb: Reenable PCI host on !MIPS

2018-01-26 Thread Krzysztof Mazur
The commit 58eae1416b804d900014d84feadda7195007cc30 ("ssb: Disable PCI host for PCI_DRIVERS_GENERIC") disabled CONFIG_SSB_PCIHOST and CONFIG_SSB_B43_PCI_BRIDGE, which are required for SSB-based b43 PCI cards, on everything except MIPS with PCI_DRIVERS_LEGACY, including x86 (only MIPS defines that c

Re: [PATCH 1/5] iommu/amd - Add debugfs support

2018-01-26 Thread Borislav Petkov
On Fri, Jan 26, 2018 at 05:52:15PM -0600, Gary R Hook wrote: > Create the basic debugfs functions. Expose a count of IOMMU device > table entries that appear to be in use. > > Signed-off-by: Gary R Hook > --- > drivers/iommu/Kconfig |9 +++ > drivers/iommu/Makefile|

[PATCH] ARM: dts: imx25-pinfunc: Always set SION for SD CMD

2018-01-26 Thread Benoît Thébaudeau
The eSDHC does not work properly if the SION bit is not set for the bidirectional CMD signal, whatever the eSDHC instance and the selected pad. Therefore, setting SION is mandatory for all eSDHC CMD ports. Do this for MX25_PAD_*__SD*_CMD in imx25-pinfunc.h in order to enforce this behavior for all

Re: [PATCH 20/21] Kbuild, lto: Add Link Time Optimization support

2018-01-26 Thread Arnd Bergmann
On Mon, Nov 27, 2017 at 10:34 PM, Andi Kleen wrote: > From: Andi Kleen > - Add a new LDFINAL variable that controls the final link > for vmlinux or module. In this case we call gcc-ld instead > of ld, to run the LTO step. When I tried this out on allmodconfig (following the lwn article), I ran i

Re: [patch -mm v2 2/3] mm, memcg: replace cgroup aware oom killer mount option with tunable

2018-01-26 Thread Andrew Morton
On Fri, 26 Jan 2018 14:52:59 -0800 (PST) David Rientjes wrote: > On Fri, 26 Jan 2018, Andrew Morton wrote: > > > > -ECONFUSED. We want to have a mount option that has the sole purpose of > > > doing echo cgroup > /mnt/cgroup/memory.oom_policy? > > > > Approximately. Let me put it another wa

Re: [PATCH] ARM: dts: imx25-pinfunc: Always set SION for SD CMD

2018-01-26 Thread Fabio Estevam
On Fri, Jan 26, 2018 at 10:07 PM, Benoît Thébaudeau wrote: > The eSDHC does not work properly if the SION bit is not set for the > bidirectional CMD signal, whatever the eSDHC instance and the selected > pad. Therefore, setting SION is mandatory for all eSDHC CMD ports. Do > this for MX25_PAD_*__S

Re: [PATCH] clk: aspeed: Handle inverse polarity of USB port 1 clock gate

2018-01-26 Thread Stephen Boyd
On 01/12, Benjamin Herrenschmidt wrote: > The USB port 1 clock gate control has an inversed polarity > from all the other clock gates in the chip. This makes the > aspeed_clk_{enable,disable} functions honor the flag > CLK_GATE_SET_TO_DISABLE and set that flag appropriately > so it's set for all cl

Re: [PATCH v3 7/9] clk: ingenic: Add JZ47xx TCU clocks driver

2018-01-26 Thread Stephen Boyd
On 01/10, Paul Cercueil wrote: > The TCU (Timer Counter Unit) of the Ingenic JZ47xx SoCs features 8 > channels, each one having its own clock, that can be started and > stopped, reparented, and reclocked. > > This driver only modifies the bits of the registers of the TCU that are > related to cloc

Re: [PATCH] staging: lustre: lnet/selftest: fix compile error on UP build

2018-01-26 Thread Dilger, Andreas
On Jan 22, 2018, at 23:27, NeilBrown wrote: > > When compiled without CONFIG_SMP, we get a compile error > as ->ctb_parts is not defined. > > There is already a function, cfs_cpt_cpumask(), which will get the > cpumask we need, and which handles the UP case by returning a NULL pointer. > So use

Re: [RESEND PATCH v2 0/5] Enable CAAM on i.MX7s fix TrustZone issues

2018-01-26 Thread Fabio Estevam
Hi Bryan, On Fri, Jan 26, 2018 at 5:04 PM, Bryan O'Donoghue wrote: > Bryan O'Donoghue (1): > crypto: caam: Fix endless loop when RNG is already initialized > > Rui Miguel Silva (4): > crypto: caam: Fix null dereference at error path > crypto: caam: do not use mem and emi_slow clock for imx

[PATCH] Revert "kernel/relay.c: fix potential memory leak"

2018-01-26 Thread Eric Biggers
From: Eric Biggers This reverts commit ba62bafe942b159a6109cbec780d36496e06b6c5. This commit introduced a double free bug, because 'chan' is already freed by the line: kref_put(&chan->kref, relay_destroy_channel); This bug was found by syzkaller, using the BLKTRACESETUP ioctl. Fixes: ba62

Re: [PATCH 20/21] Kbuild, lto: Add Link Time Optimization support

2018-01-26 Thread Andi Kleen
On Sat, Jan 27, 2018 at 01:15:49AM +0100, Arnd Bergmann wrote: > On Mon, Nov 27, 2017 at 10:34 PM, Andi Kleen wrote: > > From: Andi Kleen > > - Add a new LDFINAL variable that controls the final link > > for vmlinux or module. In this case we call gcc-ld instead > > of ld, to run the LTO step. >

[PATCH] kbuild: clang: Disable -Wunused-const-variable warnings

2018-01-26 Thread Prasad Sodagudi
Disable -Wunused-const-variable warnings instead of disabling -Wunused-variable warnings, So that in both clang and GCC -Wunused-const-variable gets disabled. Currently with clang -Wunused-variable warnings are disabled and with gcc -Wunused-variable warnings are enabled, with this setting all unu

Re: [PATCH 2/5] rpmsg: smd: Create device for all channels

2018-01-26 Thread Jeremy McNicoll
On Tue, Dec 12, 2017 at 03:58:54PM -0800, Bjorn Andersson wrote: > Rather than selectively creating devices only for the channels that the > remote have moved to "opening" state let's create devices for all > channels found. The driver model will match drivers to the ones we care > about and attemp

Re: [PATCH bpf-next v7 2/5] libbpf: add function to setup XDP

2018-01-26 Thread Daniel Borkmann
On 01/25/2018 01:05 AM, Eric Leblond wrote: > Most of the code is taken from set_link_xdp_fd() in bpf_load.c and > slightly modified to be library compliant. > > Signed-off-by: Eric Leblond > Acked-by: Alexei Starovoitov > --- > tools/lib/bpf/bpf.c| 127 > ++

Re: general protection fault in __lock_acquire (2)

2018-01-26 Thread Eric Biggers
On Thu, Nov 02, 2017 at 03:55:00AM -0700, syzbot wrote: > Hello, > > syzkaller hit the following crash on > fa8785e862ef644f742558f1a8c91eca6f3f0004 > git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console o

Re: [PATCH bpf-next v7 3/5] libbpf: add error reporting in XDP

2018-01-26 Thread Daniel Borkmann
On 01/25/2018 01:05 AM, Eric Leblond wrote: > Parse netlink ext attribute to get the error message returned by > the card. Code is partially take from libnl. > > We add netlink.h to the uapi include of tools. And we need to > avoid include of userspace netlink header to have a successful > build o

Re: general protection fault in lockdep_invariant_state (2)

2018-01-26 Thread Eric Biggers
On Wed, Nov 08, 2017 at 12:16:00AM -0800, syzbot wrote: > Hello, > > syzkaller hit the following crash on > 5a3517e009e979f21977d362212b7729c5165d92 > git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console o

Re: [PATCH 1/5] rpmsg: smd: Perform handshake during open

2018-01-26 Thread Jeremy McNicoll
On Tue, Dec 12, 2017 at 03:58:53PM -0800, Bjorn Andersson wrote: > Validate the the remote side is opening the channel that we've found by > performing a handshake when opening the channel. > > Signed-off-by: Bjorn Andersson > --- > drivers/rpmsg/qcom_smd.c | 30 ++ >

Re: [PATCH 0/5] Qualcomm SMD updates

2018-01-26 Thread Jeremy McNicoll
On Tue, Dec 12, 2017 at 03:58:52PM -0800, Bjorn Andersson wrote: > A series of fixes for a few issues reported or seen with SMD. > > The first two fixes changes the trigger for creating devices for channels > found, which should cause the rpm-smd driver to probe on 8909 and 8994 > devices. > ..

Re: KASAN: stack-out-of-bounds Read in write_mmio

2018-01-26 Thread Eric Biggers
On Mon, Dec 11, 2017 at 07:00:03PM +0800, Wanpeng Li wrote: > 2017-12-09 19:39 GMT+08:00 Tianyu Lan : > > 2017-12-09 17:15 GMT+08:00 syzbot > > : > >> syzkaller has found reproducer for the following crash on > >> ad4dac17f9d563b9e34aab78a34293b10993e9b5 > >> git://git.kernel.org/pub/scm/linux/kern

Re: [Linaro-mm-sig] [PATCH v3] staging: android: ion: Zero CMA allocated memory

2018-01-26 Thread Chen Feng
On 2018/1/27 1:48, Liam Mark wrote: > Since commit 204f672255c2 ("staging: android: ion: Use CMA APIs directly") > the CMA API is now used directly and therefore the allocated memory is no > longer automatically zeroed. > > Explicitly zero CMA allocated memory to ensure that no data is exposed t

Re: [RFC PATCH] vsprintf: add flag ZEROPAD handling before crng is ready

2018-01-26 Thread Yang, Shunyong
Hi, Rasmus and Andy,   Thanks for your feedback. I add some information below. On Fri, 2018-01-26 at 10:43 +0100, Rasmus Villemoes wrote: > On 26 January 2018 at 10:17, Andy Shevchenko > wrote: > > > > +Rasmus > Thanks. > > > > > On Fri, 2018-01-26 at 15:39 +0800, Yang Shunyong wrote: > > > >

Re: [PATCH v2 3/4] openrisc: Use the new MULTI_IRQ_HANDLER

2018-01-26 Thread Stafford Horne
On Wed, Jan 24, 2018 at 11:46:19PM -0800, Christoph Hellwig wrote: > On Wed, Jan 24, 2018 at 07:07:55PM -0800, Palmer Dabbelt wrote: > > It appears that openrisc copied arm64's MULTI_IRQ_HANDLER code (which > > came from arm). I wanted to make this generic so I could use it in the > > RISC-V port.

[RFC] apparent bogosity in unregister_ftrace_function_probe_func()

2018-01-26 Thread Al Viro
It contains something very odd: func_g.type = filter_parse_regex(glob, strlen(glob), &func_g.search, ¬); func_g.len = strlen(func_g.search); func_g.search = glob; /* we do not support

[PATCH v2] mm: Correct comments regarding do_fault_around()

2018-01-26 Thread William Kucharski

[PATCH v2] mm: Correct comments regarding do_fault_around()

2018-01-26 Thread William Kucharski
mm: Correct comments regarding do_fault_around() There are multiple comments surrounding do_fault_around that memtion fault_around_pages() and fault_around_mask(), two routines that do not exist. These comments should be reworded to reference fault_around_bytes, the value which is used to determi

Re: [PATCH v11 2/6] mailbox: qcom: Create APCS child device for clock controller

2018-01-26 Thread Jassi Brar
On Thu, Jan 4, 2018 at 10:26 PM, Georgi Djakov wrote: > Hi Jassi, > > On 12/29/2017 08:14 AM, Jassi Brar wrote: >> Hi Bjorn, >> >> On Sun, Dec 24, 2017 at 10:36 AM, Bjorn Andersson >> wrote: >>> On Fri 22 Dec 20:57 PST 2017, Jassi Brar wrote: >>> On Tue, Dec 5, 2017 at 9:16 PM, Georgi Djakov

Re: [PATCH-next] misc: mic: Use PTR_ERR_OR_ZERO

2018-01-26 Thread Ashutosh Dixit
On Tue, Jan 23 2018 at 02:55:19 PM, Al Viro wrote: > On Tue, Jan 23, 2018 at 03:10:09PM -0500, Christopher Díaz Riveros wrote: >> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR >> >> This issue was detected by using the Coccinelle software. > > ... and that's a wonderful demonstration

Re: [PATCH] print kdump kernel loaded status in stack dump

2018-01-26 Thread Dave Young
On 01/26/18 at 01:17pm, Petr Mladek wrote: > On Fri 2018-01-26 15:37:24, Dave Young wrote: > > On 01/19/18 at 12:47pm, Dave Young wrote: > > > On 01/18/18 at 01:57pm, Steven Rostedt wrote: > > > > On Thu, 18 Jan 2018 10:02:17 -0800 > > > > Andi Kleen wrote: > > > > > > > > > Dave Young writes: >

[PATCH] Documentation/cdrom: update cdrom-standard.tex for kernel changes

2018-01-26 Thread Randy Dunlap
e me short descriptions that I can use there? Thanks. Documentation/cdrom/cdrom-standard.tex | 29 +++ 1 file changed, 20 insertions(+), 9 deletions(-) --- linux-next-20180126.orig/Documentation/cdrom/cdrom-standard.tex +++ linux-next-20180126/Documentation/cdrom/cdrom

Re: [PATCH] atm: firestream: Replace GFP_ATOMIC with GFP_KERNEL in fs_send

2018-01-26 Thread Jia-Ju Bai
On 2018/1/27 1:08, Al Viro wrote: On Fri, Jan 26, 2018 at 11:07:39AM -0500, David Miller wrote: This is found by a static analysis tool named DCNS written by myself. The trouble is, places like net/atm/raw.c:65: vcc->send = atm_send_aal0; net/atm/raw.c:74: vcc->send = vcc->dev->op

[PATCH V2] print kdump kernel loaded status in stack dump

2018-01-26 Thread Dave Young
It is useful to print kdump kernel loaded status in dump_stack() especially when panic happens so that we can differenciate kdump kernel early hang and a normal panic in a bug report. Signed-off-by: Dave Young --- [v1 -> v2] merge the status in other line as Andi Kleen suggested kernel/printk/

Re: [PATCH] block: paride: on26: Replace mdelay with msleep in on26_test_port

2018-01-26 Thread Jia-Ju Bai
On 2018/1/27 1:31, Al Viro wrote: On Fri, Jan 26, 2018 at 11:42:25PM +0800, Jia-Ju Bai wrote: After checking all possible call chains to on26_test_port() here, my tool finds that this function is never called in atomic context, namely never in an interrupt handler or holding a spinlock. And on

Re: [PATCH v2 1/2] x86/retpoline: Simplify vmexit_fill_RSB()

2018-01-26 Thread Konrad Rzeszutek Wilk
> + * Google experimented with loop-unrolling and this turned out to be > + * the optimal version — two calls, each with their own speculation > + * trap should their return address end up getting used, in a loop. > + */ > +.macro BOINK_RSB nr:req sp:req BOINK? Really?

Re: [PATCH v2.1] x86/retpoline: Fill return stack buffer on vmexit

2018-01-26 Thread Konrad Rzeszutek Wilk
> Looks good to me. > > Another IRC discussion was that Boris may eventually add a feature to > the alternatives code to automatically insert such a jump if there are a > lot of nops. I vaguely recall that NOPs are skipped by the CPU so that it shouldn't matter as compared to say jumping over the

Re: [PATCH] ssb: Reenable PCI host on !MIPS

2018-01-26 Thread Kalle Valo
Krzysztof Mazur writes: > The commit 58eae1416b804d900014d84feadda7195007cc30 > ("ssb: Disable PCI host for PCI_DRIVERS_GENERIC") disabled > CONFIG_SSB_PCIHOST and CONFIG_SSB_B43_PCI_BRIDGE, which are > required for SSB-based b43 PCI cards, on everything except MIPS > with PCI_DRIVERS_LEGACY, inc

<    2   3   4   5   6   7   8   >