Re: [PATCH 11/19] staging: lustre: remove back_to_sleep()

2018-01-17 Thread James Simmons
> When 'back_to_sleep()' is passed as the 'timeout' function, > the effect is to wait indefinitely for the event, polling > once after the timeout. > If LWI_ON_SIGNAL_NOOP is given, then after the timeout > we allow fatal signals to interrupt the wait. > > Make this more obvious in both places "b

[GIT PULL] scheduler fix

2018-01-17 Thread Ingo Molnar
Linus, Please pull the latest sched-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git sched-urgent-for-linus # HEAD: c96f5471ce7d2aefd0dda560cc23f08ab00bc65d delayacct: Account blkio completion on the correct task A delayacct statistics correctnes

Re: [PATCH 13/19] staging: lustre: use wait_event_idle_timeout in ptlrpcd()

2018-01-17 Thread James Simmons
> We can replace l_wait_event() with > wait_event_idle_timeout() here providing we call the > timeout function when wait_event_idle_timeout() returns zero. > > As ptlrpc_expired_set() returns 1, the l_wait_event() aborts of the > first timeout. Reviewed-by: James Simmons > Signed-off-by: Neil

Re: [PATCH] x86/acpi: check rsdp address received via bootparams to be valid

2018-01-17 Thread Ingo Molnar
* Juergen Gross wrote: > On 16/01/18 17:35, Ingo Molnar wrote: > > > > * Juergen Gross wrote: > > > >> On 16/01/18 16:46, Ingo Molnar wrote: > >>> > >>> * Juergen Gross wrote: > >>> > There seem to exist several grub2 versions trashing > boot_params.hdr.acpi_rsdp_addr. > > >>>

Re: [PATCH 14/19] staging: lustre: improve waiting in sptlrpc_req_refresh_ctx

2018-01-17 Thread James Simmons
> Replace l_wait_event with wait_event_idle_timeout() and call the > handler function explicitly. This makes it more clear > what is happening. Reviewed-by: James Simmons > Signed-off-by: NeilBrown > --- > drivers/staging/lustre/lustre/ptlrpc/sec.c | 34 > >

Re: [PATCH 16/19] staging: lustre: use explicit poll loop in ptlrpc_unregister_reply

2018-01-17 Thread James Simmons
> replace l_wait_event() with wait_event_idle_timeout() and explicit > loop. This approach is easier to understand. Reviewed-by: James Simmons > Signed-off-by: NeilBrown > --- > drivers/staging/lustre/lustre/ptlrpc/client.c | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletio

[PATCH v3 10/12] iommu/rockchip: Fix error handling in init

2018-01-17 Thread Jeffy Chen
It's hard to undo bus_set_iommu() in the error path, so move it to the end of rk_iommu_probe(). Signed-off-by: Jeffy Chen Reviewed-by: Tomasz Figa --- Changes in v3: None Changes in v2: Move bus_set_iommu() to rk_iommu_probe(). drivers/iommu/rockchip-iommu.c | 15 ++- 1 file chang

[PATCH 1/6] arm64: zynqmp: Use zynqmp specific compatible string for macb

2018-01-17 Thread Michal Simek
The patch "devicetree: Add compatible string for Zynq Ultrascale+ MPSoC" (commit <988d6f07fc0a29e392035ba56e3bcfaf7b397d95>) introduced specific compatible string for ZynqMP which should be used first. Signed-off-by: Michal Simek --- arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 8 1 file c

Re: [PATCH 17/19] staging: lustre: remove l_wait_event from ptlrpc_set_wait

2018-01-17 Thread James Simmons
> This is the last remaining use of l_wait_event(). > It is the only use of LWI_TIMEOUT_INTR_ALL() which > has a meaning that timeouts can be interrupted. > Only interrupts by "fatal" signals are allowed, so > introduce l_wait_event_abortable_timeout() to > support this. Reviewed-by: James Simmon

Re: [PATCH][devlink-next] devlink: make functions a couple of new functions static

2018-01-17 Thread Jiri Pirko
Wed, Jan 17, 2018 at 12:23:03PM CET, colin.k...@canonical.com wrote: >From: Colin Ian King > >The functions devlink_resource_find and devlink_resource_validate_children >are local to the source and do not need to be in global scope, so make >them static. > >Cleans up sparse warnings: >symbol 'devl

Re: [PATCH 18/19] staging: lustre: replace l_wait_event_exclusive_head() with wait_event_idle_exclusive

2018-01-17 Thread James Simmons
> This l_wait_event_exclusive_head() will wait indefinitely > if the timeout is zero. If it does wait with a timeout > and times out, the timeout for next time is set to zero. > > The can be mapped to a call to either > wait_event_idle_exclusive() > or > wait_event_idle_exclusive_timeout() > d

Re: [PATCH 15/19] staging: lustre: use explicit poll loop in ptlrpc_service_unlink_rqbd

2018-01-17 Thread James Simmons
> Rather an using l_wait_event(), use wait_event_idle_timeout() > with an explicit loop so it is easier to see what is happening. Reviewed-by: James Simmons > Signed-off-by: NeilBrown > --- > drivers/staging/lustre/lustre/ptlrpc/service.c | 15 --- > 1 file changed, 8 insertion

Re: [PATCH 19/19] staging: lustre: remove l_wait_event() and related code

2018-01-17 Thread James Simmons
> These macros are no longer used, so they can > be removed. Reviewed-by: James Simmons > Signed-off-by: NeilBrown > --- > drivers/staging/lustre/lustre/include/lustre_lib.h | 249 > > 1 file changed, 249 deletions(-) > > diff --git a/drivers/staging/lustre/lustre/inc

Re: [PATCH v2 0/4] Remove checkpatch warnings

2018-01-17 Thread Shreeya Patel
On Wed, 2018-01-17 at 14:58 +0100, Greg KH wrote: > On Wed, Jan 17, 2018 at 12:24:50AM +0530, Shreeya Patel wrote: > > > > This patchset removes some warnings generated by checkpatch > > for cleanup of the rtl8723bs driver. Also some additional > > cleanups are introduced in the *[1/4] and *[3/4]

Re: [PATCH 07/11] signal/arm64: Document conflicts with SI_USER and SIGFPE, SIGTRAP, SIGBUS

2018-01-17 Thread Dave Martin
On Wed, Jan 17, 2018 at 12:37:52PM +, Russell King - ARM Linux wrote: > On Wed, Jan 17, 2018 at 12:15:05PM +, Dave Martin wrote: > > On Wed, Jan 17, 2018 at 11:57:09AM +, Russell King - ARM Linux wrote: [...] > > > VFP used to use force_sig_info(), but it seems to be really the wrong

Re: [PATCH 3/3] pinctrl: sx150x: add a static gpio/pinctrl pin range mapping

2018-01-17 Thread Peter Rosin
On 2018-01-17 16:05, Andrew Jeffery wrote: > On Wed, 2018-01-17 at 14:34 +0100, Peter Rosin wrote: >> Without such a range, gpiolib fails with -EPROBE_DEFER, pending the >> addition of the range. So, without a range, gpiolib will keep >> deferring indefinitely. >> >> Fixes: e10f72bf4b3e ("gpio: gpi

[PATCH v3 03/12] iommu/rockchip: Request irqs in rk_iommu_probe()

2018-01-17 Thread Jeffy Chen
Move request_irq to the end of rk_iommu_probe(). Suggested-by: Robin Murphy Signed-off-by: Jeffy Chen --- Changes in v3: Loop platform_get_irq() as Robin suggested. Changes in v2: None drivers/iommu/rockchip-iommu.c | 38 +- 1 file changed, 9 insertions(+)

Re: [PATCH 01/19] sched/wait: add wait_event_idle() functions.

2018-01-17 Thread James Simmons
> The new TASK_IDLE state (TASK_UNINTERRUPTIBLE | __TASK_NOLOAD) > is not much used. One way to make it easier to use is to > add wait_event*() family functions that make use of it. > This patch adds: > wait_event_idle() > wait_event_idle_timeout() > wait_event_idle_exclusive() > wait_eve

[PATCH 6/8] Expand various INIT_* macros and remove

2018-01-17 Thread David Howells
Expand various INIT_* macros into the single places they're used in init/init_task.c and remove them. Signed-off-by: David Howells Tested-by: Tony Luck Tested-by: Will Deacon (arm64) Tested-by: Palmer Dabbelt Acked-by: Thomas Gleixner --- include/linux/ftrace.h| 12 - include/linu

[PATCH v3 02/12] iommu/rockchip: Fix error handling in probe

2018-01-17 Thread Jeffy Chen
Add missing iommu_device_sysfs_remove in error path. Signed-off-by: Jeffy Chen Reviewed-by: Tomasz Figa --- Changes in v3: None Changes in v2: None drivers/iommu/rockchip-iommu.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/iommu/rockchip-iommu.c b/drivers/

[PATCH v3 01/12] iommu/rockchip: Prohibiat unbind and remove

2018-01-17 Thread Jeffy Chen
Removal the IOMMUs cannot be done reliably. This is similar to exynos iommu driver. Signed-off-by: Jeffy Chen --- Changes in v3: Also remove remove() and module_exit() as Tomasz suggested. Changes in v2: None drivers/iommu/rockchip-iommu.c | 21 + 1 file changed, 1 insert

[PATCH 1/8] cris: Make THREAD_SIZE available to vmlinux.lds

2018-01-17 Thread David Howells
Make THREAD_SIZE available to vmlinux.lds on cris by moving it to asm/thread_info.h and including that from the linker script. This allows init_stack to be allocated in the linker script in a subsequent patch. Reported-by: Guenter Roeck Signed-off-by: David Howells Tested-by: Guenter Roeck cc:

Re: [PATCH] [RESEND] aoe: use ktime_t instead of timeval

2018-01-17 Thread Jens Axboe
On 1/17/18 8:30 AM, Arnd Bergmann wrote: > From: Tina Ruchandani > > 'struct frame' uses two variables to store the sent timestamp - 'struct > timeval' and jiffies. jiffies is used to avoid discrepancies caused by > updates to system time. 'struct timeval' is deprecated because it uses > 32-bit r

[GIT PULL] x86 fixes

2018-01-17 Thread Ingo Molnar
Linus, Please pull the latest x86-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86-urgent-for-linus # HEAD: 45d55e7bac4028af93f5fa324e69958a0b868e96 x86/apic/vector: Fix off by one in error path Misc fixes: - A rather involved set of memory

Re: [patch -mm 3/4] mm, memcg: replace memory.oom_group with policy tunable

2018-01-17 Thread Tejun Heo
Hello, David. On Tue, Jan 16, 2018 at 06:15:08PM -0800, David Rientjes wrote: > The behavior of killing an entire indivisible memory consumer, enabled > by memory.oom_group, is an oom policy itself. It specifies that all I thought we discussed this before but maybe I'm misremembering. There are

[GIT pull] x86/pti - The final bits and fixes

2018-01-17 Thread Thomas Gleixner
Linus, please pull the latest x86-pti-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86-pti-for-linus This last update contains: - An objtool fix to prevent a segfault with the gold linker by changing the invocation order. That's not just for gold,

[PATCH] ipmi: use dynamic memory for DMI driver override

2018-01-17 Thread John Garry
Currently a crash can be seen if we reach the "err" label in dmi_add_platform_ipmi(), calling platform_device_put(), like here: [7.270584] (null): ipmi:dmi: Unable to add resources: -16 [7.330229] [ cut here ] [7.334889] kernel BUG at mm/slub.c:3894! [7.3389

Re: [PATCH RT 07/13] Revert "fs: jbd2: pull your plug when waiting for space"

2018-01-17 Thread Sebastian Andrzej Siewior
On 2018-01-17 10:14:11 [-0500], Steven Rostedt wrote: > 3.18.91-rt98-rc1 stable review patch. > If anyone has any objections, please let me know. > > -- > > From: Sebastian Andrzej Siewior > > This reverts commit "fs: jbd2: pull your plug when waiting for space". > This was a du

Re: [PATCH] drm: i915: remove timeval users

2018-01-17 Thread Arnd Bergmann
On Mon, Nov 6, 2017 at 1:29 PM, Chris Wilson wrote: > Quoting Arnd Bergmann (2017-11-03 19:53:52) >> struct timeval is deprecated because it cannot represent times >> past 2038. In this driver, the only use of this structure is >> to capture debug information. This is easily changed to ktime_t, >>

Re: [PATCH] print kdump kernel loaded status in stack dump

2018-01-17 Thread Steven Rostedt
On Wed, 17 Jan 2018 14:42:17 +0100 Petr Mladek wrote: > > kexec_crash_loaded is enough, we only care if kdump kernel being > > loaded or not, nothing else, no matter how long it has been loaded. > > In Fedora/RHEL a kdump service takes care of loading the kernel but > > it runs after networking i

[PATCH] [RESEND] drm: i915: remove timeval users

2018-01-17 Thread Arnd Bergmann
struct timeval is deprecated because it cannot represent times past 2038. In this driver, the only use of this structure is to capture debug information. This is easily changed to ktime_t, which we then format as needed when printing it later. Reviewed-by: Chris Wilson Signed-off-by: Arnd Bergman

[PATCH] ASoC: use seq_file to dump the contents of dai_list, platoform_list and codec_list

2018-01-17 Thread Peng Donglin
Now the debugfs files dais/codecs/platforms have a size limit PAGE_SIZE and the user can not see the whole contents of dai_list/platform_list/codec_list when they are larger than this limit. This patch uses seq_file instead to make sure dais/platforms/codecs show the full contents of dai_list/plat

Re: [PATCH 07/11] signal/arm64: Document conflicts with SI_USER and SIGFPE, SIGTRAP, SIGBUS

2018-01-17 Thread Russell King - ARM Linux
On Wed, Jan 17, 2018 at 03:37:31PM +, Dave Martin wrote: > On Wed, Jan 17, 2018 at 12:37:52PM +, Russell King - ARM Linux wrote: > > On Wed, Jan 17, 2018 at 12:15:05PM +, Dave Martin wrote: > > > On Wed, Jan 17, 2018 at 11:57:09AM +, Russell King - ARM Linux wrote: > > [...] > > >

Re: [PATCH 0/6] arm64: zynqmp: Various dts cleanups

2018-01-17 Thread Michal Simek
Hi, On 17.1.2018 16:29, Michal Simek wrote: > this patchset is adding minor dt pieces for ep108. > Also adding SPDX headers, fixing minor coding style issue and extending > gem compatible string for all boards. > The next patchset will add much more zynqmp based board. > > Thanks, > Michal > >

Re: [PATCH -next] ipmi/powernv: Fix error return code in ipmi_powernv_probe()

2018-01-17 Thread Corey Minyard
On 01/17/2018 05:25 AM, Wei Yongjun wrote: Fix to return a negative error code from the request_irq() error handling case instead of 0, as done elsewhere in this function. I think you are right here.  However, you had a bunch of people on the email that probably didn't need to be there, and did

Re: [PATCH v2 0/2] ata: ahci_brcm: Recover from failures to identify devices

2018-01-17 Thread Tejun Heo
On Thu, Jan 11, 2018 at 05:31:06PM -0800, Florian Fainelli wrote: > Hi Tejun, Kishon, > > This patch series implement a recovery mechanism to work around a HW bug > on Broadcom AHCI SATA controller subject to noise triggering a failure to > identify hard drives. Applied 1-2 to libata/for-4.16. T

[PATCH 1/3] devicetree: bindings: scsi: hisi_sas: add LED feature for v2 hw

2018-01-17 Thread John Garry
From: Xiaofei Tan Add directly attached disk LED feature for v2 hw. Signed-off-by: Xiaofei Tan Signed-off-by: John Garry --- Documentation/devicetree/bindings/scsi/hisilicon-sas.txt | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/scsi/

[PATCH 0/3] hisi_sas: v2 hw LED support

2018-01-17 Thread John Garry
This patchset includes SGPIO support for driving LEDs for boards including a SoC (like hip07) with v2 hw. The SGPIO interface is realised with a CPLD on the D05 board which inludes hip07. Also included in the patchset is a small bug fix for device removal. Xiang Chen (1): scsi: hisi_sas: fix a

[PATCH 3/3] scsi: hisi_sas: fix a bug in hisi_sas_dev_gone()

2018-01-17 Thread John Garry
From: Xiang Chen When device gone, NULL pointer can be accessed in free_device callback if during SAS controller reset as we clear structure sas_dev prior. Actually we can only set dev_type as SAS_PHY_UNUSED and not clear structure sas_dev as all the members of structure sas_dev will be re-initi

[PATCH 2/3] scsi: hisi_sas: directly attached disk LED feature for v2 hw

2018-01-17 Thread John Garry
From: Xiaofei Tan This patch implements LED feature of directly attached disk for v2 hw. As libsas has provided an interface lldd_write_gpio() for this feature, we just need realise the interface following SPGIO API. We use an CPLD to finish the hardware part of this feature, and the base addres

Re: [PATCH 0/4] dmaengine: qcom: bam_dma: fixes for remotely controlled bam

2018-01-17 Thread Vinod Koul
On Wed, Jan 17, 2018 at 10:55:34AM +, Srinivas Kandagatla wrote: > > > On 17/01/18 10:18, Vinod Koul wrote: > >On Tue, Jan 16, 2018 at 07:02:32PM +, srinivas.kandaga...@linaro.org > >wrote: > >>From: Srinivas Kandagatla > >> > >>Hi Andy, > >> > >>I did hit few issues while trying out SL

RE: [PATCH 3/8] staging: fsl-mc: Add SPDX license identifiers

2018-01-17 Thread Bogdan Purcareata
> -Original Message- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Tuesday, January 16, 2018 5:13 PM > To: Bogdan Purcareata > Cc: Laurentiu Tudor ; Ruxandra Ioana Ciocoi Radulescu > ; de...@driverdev.osuosl.org; r...@kernel.org; > stuyo...@gmail.com; a...@arndb.de; marc.zyng

Re: [PATCH arm/aspeed/ast2500 v1] ipmi: add an Aspeed KCS IPMI BMC driver

2018-01-17 Thread Corey Minyard
On 01/17/2018 08:31 AM, Wang, Haiyue wrote: On 2018-01-17 06:12, Corey Minyard wrote: On 01/16/2018 02:59 PM, Corey Minyard wrote: On 01/16/2018 05:43 AM, Haiyue Wang wrote: The KCS (Keyboard Controller Style) interface is used to perform in-band IPMI communication between a server host and

Re: [patch -mm 3/4] mm, memcg: replace memory.oom_group with policy tunable

2018-01-17 Thread Michal Hocko
On Wed 17-01-18 07:41:55, Tejun Heo wrote: > Hello, David. > > On Tue, Jan 16, 2018 at 06:15:08PM -0800, David Rientjes wrote: > > The behavior of killing an entire indivisible memory consumer, enabled > > by memory.oom_group, is an oom policy itself. It specifies that all > > I thought we discu

Re: [PATCH v2 0/4] Remove checkpatch warnings

2018-01-17 Thread Greg KH
On Wed, Jan 17, 2018 at 09:06:50PM +0530, Shreeya Patel wrote: > On Wed, 2018-01-17 at 14:58 +0100, Greg KH wrote: > > On Wed, Jan 17, 2018 at 12:24:50AM +0530, Shreeya Patel wrote: > > > > > > This patchset removes some warnings generated by checkpatch > > > for cleanup of the rtl8723bs driver. A

Re: [GIT PULL] isolation: 1Hz residual tick offloading v3

2018-01-17 Thread Mike Galbraith
On Wed, 2018-01-17 at 08:51 -0600, Christopher Lameter wrote: > On Tue, 16 Jan 2018, Mike Galbraith wrote: > > > > I tried to remove isolcpus or at least change the way it works so that its > > > effects are reversible (ie: affine the init task instead of isolating > > > domains) > > > but that g

Re: [PATCH 03/32] fs: introduce new ->get_poll_head and ->poll_mask methods

2018-01-17 Thread Christoph Hellwig
On Thu, Jan 11, 2018 at 05:47:50PM +, Al Viro wrote: > What I mean is that it would be nice to have do_select() and friends aware of > that. > You are hiding the whole thing behind vfs_poll(); sure, we can't really > exploit > that while we have the mix of converted and unconverted instances,

Re: [PATCH] staging: lustre: lnet: avoid uninitialized return value

2018-01-17 Thread James Simmons
> gcc warns that the latest workqueue change leads to returning an > uninitialized variable: > > drivers/staging/lustre/lnet/selftest/module.c: In function > 'lnet_selftest_init': > drivers/staging/lustre/lnet/selftest/module.c:98:10: error: 'rc' may be used > uninitialized in this function [-W

Re: [RFC PATCH 1/2] pinctrl: add consumer variant for gpio request

2018-01-17 Thread Andy Shevchenko
On Wed, Jan 17, 2018 at 4:54 PM, Ludovic Desroches wrote: > On Tue, Jan 16, 2018 at 04:33:29PM +0200, Andy Shevchenko wrote: >> First of all, the main architectural issue with current pin control >> design is so called "states". It's quite artificial entity which is >> not represented by hardware

Re: Suspend/resume with FTRACE enabled doesn’t work anymore

2018-01-17 Thread Steven Rostedt
On Wed, 17 Jan 2018 15:20:42 +0100 Paul Menzel wrote: > Dear Linux folks and Dell XPS 13 9360 users, > > > Testing Linux 4.15-rc8 on a Lenovo T60 (32 bit) and Dell XPS 13 9360 (64 > bit) suspend to and resume from ACPI S3 doesn’t work anymore. > `./sleepgraph.py -config config/suspend-callgra

Re: [PATCH 07/11] signal/arm64: Document conflicts with SI_USER and SIGFPE, SIGTRAP, SIGBUS

2018-01-17 Thread Dave Martin
On Wed, Jan 17, 2018 at 03:49:59PM +, Russell King - ARM Linux wrote: > On Wed, Jan 17, 2018 at 03:37:31PM +, Dave Martin wrote: > > On Wed, Jan 17, 2018 at 12:37:52PM +, Russell King - ARM Linux wrote: [...] > > > I'd be more inclined to agree with you if VFP exceptions were synchron

[PATCH 06/32] perf evsel: Check if callchain is enabled before setting it up

2018-01-17 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo The construct: if (callchain_param) perf_evsel__config_callchain(evsel, opts, &callchain_param); happens in several places, so make perf_evsel__config_callchain() work just like free(NULL), do nothing if param->enabled is not set. Cc: Adri

[PATCH 09/32] tools lib traceevent: Show value of flags that have not been parsed

2018-01-17 Thread Arnaldo Carvalho de Melo
From: "Steven Rostedt (VMware)" If the value contains bits that are not defined by print_flags() helper, then show the remaining bits. This aligns with the functionality of the kernel. Signed-off-by: Steven Rostedt Acked-by: Namhyung Kim Cc: Andrew Morton Link: http://lkml.kernel.org/r/e60c88

[PATCH 12/32] tools lib traceevent: Handle new pointer processing of bprint strings

2018-01-17 Thread Arnaldo Carvalho de Melo
From: "Steven Rostedt (VMware)" The Linux kernel printf() has some extended use cases that dereference the pointer. This is dangerouse for tracing because the pointer that is dereferenced can change or even be unmapped. It also causes issues when the trace data is extracted, because user space do

[PATCH 17/32] tools lib traceevent: Fix get_field_str() for dynamic strings

2018-01-17 Thread Arnaldo Carvalho de Melo
From: "Steven Rostedt (VMware)" If a field is a dynamic string, get_field_str() returned just the offset/size value and not the string. Have it parse the offset/size correctly to return the actual string. Otherwise filtering fails when trying to filter fields that are dynamic strings. Reported-b

[PATCH 18/32] perf tools: Add ARM Statistical Profiling Extensions (SPE) support

2018-01-17 Thread Arnaldo Carvalho de Melo
From: Kim Phillips 'perf record' and 'perf report --dump-raw-trace' supported in this release. Example usage: # perf record -e arm_spe/ts_enable=1,pa_enable=1/ dd if=/dev/zero of=/dev/null count=1 # perf report --dump-raw-trace Note that the perf.data file is portable, so the report can

[PATCH 25/32] perf script: Improve error msg when no first/last sample time found

2018-01-17 Thread Arnaldo Carvalho de Melo
From: Jin Yao The following message will be returned to user when executing 'perf script --time' if perf data file doesn't contain the first/last sample time. "HINT: no first/last sample time found in perf data. Please use latest perf binary to execute 'perf record' (if '--buildid-all' is enab

[PATCH 24/32] perf report: Improve error msg when no first/last sample time found

2018-01-17 Thread Arnaldo Carvalho de Melo
From: Jin Yao The following message will be returned to user when executing 'perf report --time' if perf data file doesn't contain the first/last sample time. "HINT: no first/last sample time found in perf data. Please use latest perf binary to execute 'perf record' (if '--buildid-all' is enab

[PATCH 27/32] perf util: Support no index time percent slice

2018-01-17 Thread Arnaldo Carvalho de Melo
From: Jin Yao Previously, the time percent slice needs an index to specify which one the user wants. It may be easier to use if the index can be omitted. So with this patch, for example, perf report --stdio --time 10%/1 should be equivalent to perf report --stdio --time 10% Signed-off-by: Jin

[PATCH 30/32] perf report: Remove the time slices number limitation

2018-01-17 Thread Arnaldo Carvalho de Melo
From: Jin Yao Previously it was only allowed to use at most 10 time slices in 'perf report --time'. This patch removes this limitation. For example, following command line is OK (12 time slices) perf report --stdio --time 1%/1,1%/2,1%/3,1%/4,1%/5,1%/6,1%/7,1%/8,1%/9,1%/10,1%/11,1%/12 Signed-o

[PATCH 31/32] perf script: Remove the time slices number limitation

2018-01-17 Thread Arnaldo Carvalho de Melo
From: Jin Yao Previously it was only allowed to use at most 10 time slices in 'perf script --time'. This patch removes this limitation. For example, following command line is OK (12 time slices) perf script --time 1%/1,1%/2,1%/3,1%/4,1%/5,1%/6,1%/7,1%/8,1%/9,1%/10,1%/11,1%/12 Signed-off-by: J

[PATCH 32/32] perf record: Fix failed memory allocation for get_cpuid_str

2018-01-17 Thread Arnaldo Carvalho de Melo
From: Thomas Richter In x86 architecture dependend part function get_cpuid_str() mallocs a 128 byte buffer, but does not check if the memory allocation succeeded or not. When the memory allocation fails, function __get_cpuid() is called with first parameter being a NULL pointer. However this fu

[PATCH 29/32] perf util: Allocate time slices buffer according to number of comma

2018-01-17 Thread Arnaldo Carvalho de Melo
From: Jin Yao Previously we use a magic number 10 to limit the number of time slices. It's not very good. This patch creates a new function perf_time__range_alloc() to allocate time slices buffer. The number of buffer entries is determined by the number of comma in string but at least it will al

[PATCH 28/32] perf report: Add an indication of what time slices are used

2018-01-17 Thread Arnaldo Carvalho de Melo
From: Jin Yao Add a time slices indication to the perf report header. For example, # perf report --stdio --time 10% # Total Lost Samples: 0 # # Samples: 9K of event 'cycles:ppp' (time slices: 10%) # Event count (approx.): 8951288803 Signed-off-by: Jin Yao Suggested--by: Arnaldo Car

Re: [PATCH] selinux:Significant reduce of preempt_disable holds

2018-01-17 Thread Stephen Smalley
On Wed, 2018-01-17 at 15:55 +0100, peter.enderb...@sony.com wrote: > From: Peter Enderborg > > Holding the preempt_disable is very bad for low latency tasks > as audio and therefore we need to break out the rule-set dependent > part from this disable. By using a rwsem instead of rwlock we > have

[PATCH 26/32] perf util: Improve error checking for time percent input

2018-01-17 Thread Arnaldo Carvalho de Melo
From: Jin Yao The command line like 'perf report --stdio --time 1abc%/1' could be accepted by perf. It looks not very good. This patch uses strtod() to replace original atof() and check the entire string. Now for the same command line, it would return error message "Invalid time string". root@s

[PATCH 23/32] perf callchains: Ask for PERF_RECORD_MMAP for data mmaps for DWARF unwinding

2018-01-17 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo When we use a global DWARF setting as in: perf record --call-graph dwarf According to 5c0cf22477ea ("perf record: Store data mmaps for dwarf unwind") we need to set up some extra perf_event_attr bits. But when we instead do a per event dwarf setting:

[PATCH 22/32] perf trace: Allow overriding global --max-stack per event

2018-01-17 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo The per-event max-stack setting wasn't overriding the global --max-stack setting: # perf trace --no-syscalls --max-stack 4 -e probe_libc:inet_pton/call-graph=dwarf,max-stack=2/ ping -6 -c 1 ::1 PING ::1(::1) 56 data bytes 64 bytes from ::1: icmp_seq=1 ttl=64

RE: [PATCH] Documentation: rapidio: move sysfs interface to ABI

2018-01-17 Thread Bounine, Alexandre
For users convenience and due to limited use of RapidIO I would prefer to keep all subsystem documentation in one place. Also, having text file in free format gives us ability to easily add explanations and examples which we cannot have in ABI documentation format. If converting this file into

[PATCH 20/32] perf unwind: Do not look just at the global callchain_param.record_mode

2018-01-17 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo When setting up DWARF callchains on specific events, without using 'record' or 'trace' --call-graph, but instead doing it like: perf trace -e cycles/call-graph=dwarf/ The unwind__prepare_access() call in thread__insert_map() when we process PERF_RECORD_MMA

Re: [PATCH 3/8] staging: fsl-mc: Add SPDX license identifiers

2018-01-17 Thread Greg KH
On Wed, Jan 17, 2018 at 03:56:19PM +, Bogdan Purcareata wrote: > > -Original Message- > > From: Greg KH [mailto:gre...@linuxfoundation.org] > > Sent: Tuesday, January 16, 2018 5:13 PM > > To: Bogdan Purcareata > > Cc: Laurentiu Tudor ; Ruxandra Ioana Ciocoi > > Radulescu > > ; de...@d

Re: [PATCH 08/30] kexec_file: Restrict at runtime if the kernel is locked down

2018-01-17 Thread David Howells
Jiri Bohac wrote: > > Having said that, I do see your point, I think. We should still let through > > validly signed images, even if signatures aren't mandatory in lockdown mode. > > yes, to be clear, the problem I'm trying to fix is: > - without CONFIG_KEXEC_VERIFY_SIG kexec in a locked down k

[PATCH 21/32] perf trace: Setup DWARF callchains for non-syscall events when --max-stack is used

2018-01-17 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo If we use: perf trace --max-stack=4 then the syscall events will use DWARF callchains, when available (libunwind enabled in the build) and the printing will stop at 4 levels. When we introduced support for tracepoint events this ended up not applying for

[PATCH 19/32] perf callchain: Fix attr.sample_max_stack setting

2018-01-17 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo When setting the "dwarf" unwinder for a specific event and not specifying the max-stack, the attr.sample_max_stack ended up using an uninitialized callchain_param.max_stack, fix it by using designated initializers for that callchain_param variable, zeroing all non e

[PATCH 14/32] tools lib traceevent: Use asprintf when possible

2018-01-17 Thread Arnaldo Carvalho de Melo
From: Federico Vaga It makes the code clearer and less error prone. clearer: - less code - the code is now using the same format to create strings dynamically less error prone: - no magic number +2 +9 +5 to compute the size - no copy&paste of the strings to compute the size and to concatenate

[PATCH 13/32] tools lib traceevent: Show contents (in hex) of data of unrecognized type records

2018-01-17 Thread Arnaldo Carvalho de Melo
From: "Steven Rostedt (VMware)" When a record has an unrecognized type, an error message is reported, but it would also be helpful to see the contents of that record. At least show what it is in hex, instead of just showing a blank line. Signed-off-by: Steven Rostedt Acked-by: Namhyung Kim Cc:

Re: linux-next: manual merge of the block tree with the dma-mapping tree

2018-01-17 Thread Christoph Hellwig
On Wed, Jan 17, 2018 at 01:38:17PM +1100, Stephen Rothwell wrote: > from the dma-mapping tree and commit: > > e80a0af4759a ("lib/scatterlist: Introduce sgl_alloc() and sgl_free()") > > from the block tree. > > I fixed it up (see below) and can carry the fix as necessary. This > is now fixed as

[PATCH 16/32] tools lib traceevent: Fix missing break in FALSE case of pevent_filter_clear_trivial()

2018-01-17 Thread Arnaldo Carvalho de Melo
From: Taeung Song Currently the FILTER_TRIVIAL_FALSE case has a missing break statement, if the trivial type is FALSE, it will also run into the TRUE case, and always be skipped as the TRUE statement will continue the loop on the inverse condition of the FALSE statement. Reported-by: Namhyung Ki

Re: Suspend/resume with FTRACE enabled doesn’t work anymore

2018-01-17 Thread Steven Rostedt
On Wed, 17 Jan 2018 11:10:31 -0500 Steven Rostedt wrote: > It's been fixed, and the the patch is in Linus's tree already: > > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=a0e3a18f4baf8e3754ac1e56f0ade924d0c0c721 Although I just noticed that the revert, also

[PATCH 15/32] tools lib traceevent: Add UL suffix to MISSING_EVENTS

2018-01-17 Thread Arnaldo Carvalho de Melo
From: Michael Sartain Add UL suffix to MISSING_EVENTS since ints shouldn't be left shifted by 31. Signed-off-by: Michael Sartain Acked-by: Namhyung Kim Cc: Andrew Morton Link: http://lkml.kernel.org/r/20171016165542.13038-4-mikes...@fastmail.com Link: http://lkml.kernel.org/r/20180112004822.8

[PATCH 10/32] tools lib traceevent: Print value of unknown symbolic fields

2018-01-17 Thread Arnaldo Carvalho de Melo
From: Jan Kiszka Aligns trace-cmd with the behavior of the kernel. Signed-off-by: Jan Kiszka Acked-by: Namhyung Kim Cc: Andrew Morton Link: http://lkml.kernel.org/r/e60c889f-55e7-4ee8-0e50-151e435ff...@siemens.com Link: http://lkml.kernel.org/r/20180112004822.118332...@goodmis.org Signed-off-

[PATCH 11/32] tools lib traceevent: Simplify pointer print logic and fix %pF

2018-01-17 Thread Arnaldo Carvalho de Melo
From: "Steven Rostedt (VMware)" When processing %pX in pretty_print(), simplify the logic slightly by incrementing the ptr to the format string if isalnum(ptr[1]) is true. This follows the logic a bit more closely to what is in the kernel. Also, this fixes a small bug where %pF was not giving th

[PATCH 07/32] perf trace: Fix setting of --call-graph/--max-stack for non-syscall events

2018-01-17 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo The raw_syscalls:sys_{enter,exit} were first supported in 'perf trace', together with minor and major page faults, then we supported --call-graph, then --max-stack, but when the other tracepoints got supported, and bpf, etc, I forgot to make those global call-graph

[PATCH 08/32] tools lib traceevent: Fix bad force_token escape sequence

2018-01-17 Thread Arnaldo Carvalho de Melo
From: Michael Sartain Older kernels have a bug that creates invalid symbols. event-parse.c handles them by replacing them with a "%s" token. But the fix included an extra backslash, and "\%s" was added incorrectly. Signed-off-by: Michael Sartain Acked-by: Namhyung Kim Cc: Andrew Morton Link:

[PATCH 05/32] perf tools: Fix copyfile_offset update of output offset

2018-01-17 Thread Arnaldo Carvalho de Melo
From: Jiri Olsa We need to increase output offset in each iteration, not decrease it as we currently do. I guess we were lucky to finish in most cases in first iteration, so the bug never showed. However it shows a lot when working with big (~4GB) size data. Signed-off-by: Jiri Olsa Cc: Alexan

[PATCH 03/32] perf script python: Add script to profile and resolve physical mem type

2018-01-17 Thread Arnaldo Carvalho de Melo
From: Kan Liang There could be different types of memory in the system. E.g normal System Memory, Persistent Memory. To understand how the workload maps to those memories, it's important to know the I/O statistics of them. Perf can collect physical addresses, but those are raw data. It still ne

[PATCH 0/4] spi: a3700: Add improvements and full-duplex transfers

2018-01-17 Thread Maxime Chevallier
This patchset adds some improvements on the existing Armada 3700 SPI driver, the biggest being adding support for full-duplex transfers. The first patch fixes an undocumented (to my knowledge, I might have missed something) behaviour where some of the content of the last write transfer is shifted

[PATCH 2/4] spi: a3700: Set frequency limits at startup

2018-01-17 Thread Maxime Chevallier
Armada 3700 SPI controller has an internal clock divider which can divide the parent clock frequency by up to 30. This patch sets the limits in the spi_controller fields so that we can detect when a non-supported frequency is requested by a device for a transfer. Signed-off-by: Maxime Chevallier

[PATCH 3/4] spi: a3700: Allow to enable or disable FIFO mode

2018-01-17 Thread Maxime Chevallier
The armada 3700 SPI controller allows to make transfers without using the 32 bytes RFIFO and WFIFO. This commit enable switching between FIFO and non-FIFO mode, which is necessary to implement full-duplex transfers. Signed-off-by: Maxime Chevallier --- drivers/spi/spi-armada-3700.c | 9 ++--

[PATCH 4/4] spi: a3700: Add full-duplex support

2018-01-17 Thread Maxime Chevallier
The armada 3700 SPI controller has support for full-duplex transfers, but it can only be done without using the hardware FIFOs. A full duplex transfer is done by shifting 4 bytes at a time, or even one byte at a time for transfers less than 4 bytes long. While this method is perfectly suitable fo

[PATCH 1/4] spi: a3700: Clear DATA_OUT when performing a read

2018-01-17 Thread Maxime Chevallier
When performing a read using FIFO mode, the spi controller shifts out the last 2 bytes that were written in a previous transfer on MOSI. This undocumented behaviour can cause devices to misinterpret the transfer, so we explicitly clear the WFIFO before each read. This behaviour was noticed on Esp

Re: [GIT PULL 00/32] perf/core improvements and fixes

2018-01-17 Thread Ingo Molnar
;perf-core-for-mingo-4.16-20180110' of > git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core > (2018-01-11 06:53:06 +0100) > > are available in the Git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git > tags/perf-

Re: [PATCH] Kbuild: suppress packed-not-aligned warning for default setting only

2018-01-17 Thread Masahiro Yamada
2018-01-11 18:22 GMT+09:00 Xiongfeng Wang : > From: Xiongfeng Wang > > gcc-8 reports many -Wpacked-not-aligned warnings. The below are some > examples. > > ./include/linux/ceph/msgr.h:67:1: warning: alignment 1 of 'struct > ceph_entity_addr' is less than 8 [-Wpacked-not-aligned] > } __attribute__

[PATCH 04/32] perf trace: No need to set PERF_SAMPLE_IDENTIFIER explicitely

2018-01-17 Thread Arnaldo Carvalho de Melo
From: Arnaldo Carvalho de Melo Since 75562573bab3 ("perf tools: Add support for PERF_SAMPLE_IDENTIFIER") we don't need explicitely set PERF_SAMPLE_IDENTIFIER, as perf_evlist__config() will do this for us, i.e. when there are more than one evsel in an evlist, it will check if some evsel has a samp

[PATCH 02/32] perf evlist: Remove trailing semicolon

2018-01-17 Thread Arnaldo Carvalho de Melo
From: Luis de Bethencourt The trailing semicolon is an empty statement that does no operation. Removing it since it doesn't do anything. Signed-off-by: Luis de Bethencourt Cc: Alexander Shishkin Cc: Jiri Olsa Cc: Joe Perches Cc: Namhyung Kim Cc: Peter Zijlstra Link: http://lkml.kernel.org/

[PATCH 01/32] perf evsel: Fix incorrect handling of type _TERM_DRV_CFG

2018-01-17 Thread Arnaldo Carvalho de Melo
From: Mathieu Poirier Commit ("d0565132605f perf evsel: Enable type checking for perf_evsel_config_term types") assumes PERF_EVSEL__CONFIG_TERM_DRV_CFG isn't used and as such adds a BUG_ON(). Since the enumeration type is used in macro ADD_CONFIG_TERM() the change break CoreSight trace acquisiti

[GIT PULL 00/32] perf/core improvements and fixes

2018-01-17 Thread Arnaldo Carvalho de Melo
linux into perf/core (2018-01-11 06:53:06 +0100) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo-4.16-20180117 for you to fetch changes up to 81fccd6ca507d3b2012eaf1edeb9b1dbf4bd22db: perf record: Fix fai

[patch v1 1/1] platform/x86: mlx-platform: Allow compilation for 32 bit arch

2018-01-17 Thread Vadim Pasternak
It makes mlx-platform available for 32 bit architecture. Signed-off-by: Vadim Pasternak --- drivers/platform/x86/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig index 8a07df5..b9b40e3 100644 --- a/drivers/platform/x86/Kconfig

[patch v9 0/4] drivers/platform: Replace module x86/mlxcpld-hotplug with mellanox/mlxreg-hotplug

2018-01-17 Thread Vadim Pasternak
The patchset: - replaces modules include/linux/platform_data/mlxcpld-hotplug.h and drivers/platform/x86/mlxcpld-hotplug.c with the modules include/linux/platform_data/mlxreg.h and drivers/platform/mellanox/mlxreg-hotplug.c; relevant Makefile and Kconfig are updated; - modifies Mellano

[patch v9 2/4] platform/mellanox: mlxreg-hotplug: Allow driver for ARM architecture

2018-01-17 Thread Vadim Pasternak
It allows driver to run on x86 and ARM architecture based systems. Signed-off-by: Vadim Pasternak --- v9->v8 Comments pointed out by Darren: - Leave in this patch only the code related to ARM architecture. Move other code to a separate patch, since it is not related to subject. --- driv

<    1   2   3   4   5   6   7   8   9   10   >