Re: [PATCH 5/6] staging: pi433: Rename enum dataMode in rf69_enum.h

2017-12-04 Thread Dan Carpenter
On Mon, Dec 04, 2017 at 09:31:06PM +0200, Marcus Wolf wrote: > > > Then it might be, that DATAMODUL_MODE_PACKET might need an other value. > > > > That's future code so we can delete that sentence for now. > > With the rule above, you are absolutely right. But we now spend time, to > remove an cu

Re: [PATCH 4/6] staging: pi433: Rename enum optionOnOff in rf69_enum.h

2017-12-04 Thread Marcus Wolf
Am 04.12.2017 um 21:42 schrieb Simon Sandström: On Mon, Dec 04, 2017 at 09:22:06PM +0200, Marcus Wolf wrote: Am 04.12.2017 um 21:15 schrieb Dan Carpenter: That's a bad name, because it doesn't just enable it also disables. Please split them. regards, dan carpenter Same applies to all

[tip:irq/urgent] irqdesc: Use bool return type instead of int

2017-12-04 Thread tip-bot for Will Deacon
Commit-ID: 4ce413d1840b25b101be3c0559161db8891f3360 Gitweb: https://git.kernel.org/tip/4ce413d1840b25b101be3c0559161db8891f3360 Author: Will Deacon AuthorDate: Fri, 1 Dec 2017 15:29:39 + Committer: Thomas Gleixner CommitDate: Mon, 4 Dec 2017 20:51:12 +0100 irqdesc: Use bool return

Re: [PATCH 2/2] of: dynamic: add overlay-allowed DT property

2017-12-04 Thread Rob Herring
On Mon, Dec 4, 2017 at 1:13 PM, Alan Tull wrote: > Allow DT nodes to be marked as valid targets for DT > overlays by the added "overlay-allowed" property. Why do you need a property for this? I'm not all that keen on putting this policy into the DT. It can change over time in the kernel. For exam

Re: [PATCH 4/6] staging: pi433: Rename enum optionOnOff in rf69_enum.h

2017-12-04 Thread Simon Sandström
On Mon, Dec 04, 2017 at 09:59:02PM +0200, Marcus Wolf wrote: > > Hi Simon, hi Dan, > > if you both are of the same opinion, for me, it's fine, if we go with two > functions. > > But I don't get the advantage, if we split approx. 10 functions, to get rid > of enum optionOnOff. > > Keep in mind,

Re: [PATCH 0/5] blkcg: Limit maximum number of aio requests available for cgroup

2017-12-04 Thread Tejun Heo
Hello, Kirill. On Mon, Dec 04, 2017 at 07:12:51PM +0300, Kirill Tkhai wrote: > this patch set introduces accounting aio_nr and aio_max_nr per blkio cgroup. > It may be used to limit number of aio requests, which are available for > a cgroup, and could be useful for containers. Can you please expl

Re: [PATCH v4 2/2] arm64: Add software workaround for Falkor erratum 1041

2017-12-04 Thread Shanker Donthineni
Hi Will, On 12/03/2017 07:35 AM, Shanker Donthineni wrote: > Hi Will, thanks for your review comments. > > On 12/01/2017 05:24 AM, Will Deacon wrote: >> On Mon, Nov 27, 2017 at 05:18:00PM -0600, Shanker Donthineni wrote: >>> The ARM architecture defines the memory locations that are permitted >>>

Re: [PATCH 2/3, V2] kernel: Move groups_sort to the caller of set_groups.

2017-12-04 Thread NeilBrown
On Mon, Dec 04 2017, Thiago Rafael Becker wrote: > On Mon, 4 Dec 2017, NeilBrown wrote: > >> I think you need to add groups_sort() in a few more places. >> Almost anywhere that calls groups_alloc() should be considered. >> net/sunrpc/svcauth_unix.c, net/sunrpc/auth_gss/svcauth_gss.c, >> fs/nfsd/au

RE: [PATCH v2 00/15] NTB: Add full multi-port API support to the test drivers

2017-12-04 Thread Allen Hubbe
From: Serge Semin > The multi-port NTB API was introduced in kernel 4.13 as well as the > first driver for the true multi-port devices of IDT PCIe-switches > series. But the test drivers still were left almost unchanged. Yes, > they didn't fail being used with new NTB API, but they only worked > wi

Re: [PATCH 2/2] of: dynamic: add overlay-allowed DT property

2017-12-04 Thread Alan Tull
On Mon, Dec 4, 2017 at 2:04 PM, Rob Herring wrote: > On Mon, Dec 4, 2017 at 1:13 PM, Alan Tull wrote: >> Allow DT nodes to be marked as valid targets for DT >> overlays by the added "overlay-allowed" property. > > Why do you need a property for this? I'm not all that keen on putting > this policy

Re: [PATCH 3.18 00/12] 3.18.86-stable review

2017-12-04 Thread Shuah Khan
On 12/04/2017 08:59 AM, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 3.18.86 release. > There are 12 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Responses s

Re: [PATCH 4.4 00/27] 4.4.104-stable review

2017-12-04 Thread Shuah Khan
On 12/04/2017 08:59 AM, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.4.104 release. > There are 27 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Responses s

Re: [PATCH] ima: log message to module appraisal error

2017-12-04 Thread Bruno E. O. Meneguele
On 04-12, Bruno E. O. Meneguele wrote: > Simple but useful message log to the user in case of module appraise is > forced and fails due to the lack of file descriptor, that might be > caused by kmod calls to compressed modules. > > Signed-off-by: Bruno E. O. Meneguele > --- Oh sorry, I sent thro

Re: [PATCH v2] soc: qcom: smp2p: Access APCS as mailbox client

2017-12-04 Thread Bjorn Andersson
On Fri 01 Dec 14:25 PST 2017, Rob Herring wrote: > On Wed, Nov 29, 2017 at 04:00:40PM -0800, Bjorn Andersson wrote: > > Attempt to acquire the APCS IPC through the mailbox framework and fall > > back to the old syscon based approach, to allow us to move away from > > using the syscon. > > > > Sig

Re: [PATCH] ahci: qoriq: refine port register configuration

2017-12-04 Thread Tejun Heo
On Mon, Dec 04, 2017 at 05:01:20PM +0800, andy.t...@nxp.com wrote: > From: Yuantian Tang > > These PP2C and PP3C registers control the configuration of the PHY > control OOB timing for the COMINIT/COMWAKE parameters respectively > for sata port. Overwrite default values with calculated ones to ge

Re: [PATCH 5/6] staging: pi433: Rename enum dataMode in rf69_enum.h

2017-12-04 Thread Marcus Wolf
Am 04.12.2017 um 21:56 schrieb Dan Carpenter: On Mon, Dec 04, 2017 at 09:31:06PM +0200, Marcus Wolf wrote: Then it might be, that DATAMODUL_MODE_PACKET might need an other value. That's future code so we can delete that sentence for now. With the rule above, you are absolutely right. But w

Re: [PATCH] cgroup/cpuset: fix circular locking dependency

2017-12-04 Thread Tejun Heo
Hello, On Mon, Dec 04, 2017 at 10:44:49AM +0530, Prateek Sood wrote: > Any feedback/suggestion for this patch? Sorry about the delay. I'm a bit worried because it feels like we're chasing a squirrel. I'll think through the recent changes and this one and get back to you. Thanks. -- tejun

[tip:x86/urgent] x86/boot/compressed/64: Print error if 5-level paging is not supported

2017-12-04 Thread tip-bot for Kirill A. Shutemov
Commit-ID: eabf2a604e0555b8f86a2c6c05c3a27496facf6d Gitweb: https://git.kernel.org/tip/eabf2a604e0555b8f86a2c6c05c3a27496facf6d Author: Kirill A. Shutemov AuthorDate: Mon, 4 Dec 2017 15:40:56 +0300 Committer: Thomas Gleixner CommitDate: Mon, 4 Dec 2017 21:14:34 +0100 x86/boot/compresse

[tip:x86/urgent] x86/boot/compressed/64: Detect and handle 5-level paging at boot-time

2017-12-04 Thread tip-bot for Kirill A. Shutemov
Commit-ID: 10c9a5346f7200f5150608742075470612f9eadb Gitweb: https://git.kernel.org/tip/10c9a5346f7200f5150608742075470612f9eadb Author: Kirill A. Shutemov AuthorDate: Mon, 4 Dec 2017 15:40:55 +0300 Committer: Thomas Gleixner CommitDate: Mon, 4 Dec 2017 21:14:34 +0100 x86/boot/compresse

[PATCH v2] ima: log message to module appraisal error

2017-12-04 Thread Bruno E. O. Meneguele
Simple but useful message log to the user in case of module appraise is forced and fails due to the lack of file descriptor, that might be caused by kmod calls to compressed modules. Signed-off-by: Bruno E. O. Meneguele --- security/integrity/ima/ima_main.c | 6 +- 1 file changed, 5 insertio

Re: BPF: bug without effect in BPF_RSH case of adjust_scalar_min_max_vals()

2017-12-04 Thread Edward Cree
On 04/12/17 17:03, Jann Horn wrote: > As far as I can tell, commit b03c9f9fdc37 ("bpf/verifier: track signed > and unsigned min/max values") introduced the following effectless bug > in the BPF_RSH case of adjust_scalar_min_max_vals() (unless that's > intentional): > > `dst_reg->smax_value` is only

Re: [PATCH v6 1/2] media: ov7740: Document device tree bindings

2017-12-04 Thread Rob Herring
On Mon, Dec 04, 2017 at 02:58:57PM +0800, Wenyou Yang wrote: > Add the device tree binding documentation for the ov7740 sensor driver. > > Signed-off-by: Wenyou Yang > --- > > Changes in v6: None > Changes in v5: None > Changes in v4: None > Changes in v3: > - Explicitly document the "remote-en

Re: [patch 23/60] x86/entry/64: Make cpu_entry_area.tss read-only

2017-12-04 Thread Borislav Petkov
On Mon, Dec 04, 2017 at 03:07:29PM +0100, Thomas Gleixner wrote: > From: Andy Lutomirski > > The TSS is a fairly juicy target for exploits, and, now that the TSS > is in the cpu_entry_area, it's no longer protected by kASLR. Make it > read-only on x86_64. > > On x86_32, it can't be RO because i

linux-next: remove the tile tree?

2017-12-04 Thread Stephen Rothwell
Hi Chris, Given commit 8ee5ad1d4c0b ("arch/tile: mark as orphaned") in Linus' tree, should I remove the tile tree from linux-next? -- Cheers, Stephen Rothwell

Re: [PATCH 4.9 00/38] 4.9.67-stable review

2017-12-04 Thread Shuah Khan
On 12/04/2017 08:59 AM, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.9.67 release. > There are 38 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Responses sh

Re: [PATCH v3 02/21] fpga: mgr: add region_id to fpga_image_info

2017-12-04 Thread Alan Tull
On Wed, Nov 29, 2017 at 12:11 AM, Moritz Fischer wrote: > Hi Hao, > > On Mon, Nov 27, 2017 at 02:42:09PM +0800, Wu Hao wrote: >> This patch adds region_id to fpga_image_info data structure, it >> allows driver to pass region id information to fpga-mgr via >> fpga_image_info for fpga reconfiguratio

Re: BPF: bug without effect in BPF_RSH case of adjust_scalar_min_max_vals()

2017-12-04 Thread Jann Horn
On Mon, Dec 4, 2017 at 6:03 PM, Jann Horn wrote: > As far as I can tell, commit b03c9f9fdc37 ("bpf/verifier: track signed > and unsigned min/max values") introduced the following effectless bug > in the BPF_RSH case of adjust_scalar_min_max_vals() (unless that's > intentional): [...] > ===

linux-next: Signed-off-by missing for commit in the befs tree

2017-12-04 Thread Stephen Rothwell
Hi Luis, Commit 88e3f65c2c20 ("fs: befs: btree: Fixed some coding standard issues") is missing a Signed-off-by from its author. -- Cheers, Stephen Rothwell

Re: [PATCH v3 1/3] dt-bindings: hwrng: Add Samsung Exynos 5250+ True RNG bindings

2017-12-04 Thread Rob Herring
On Mon, Dec 04, 2017 at 01:53:49PM +0100, Łukasz Stelmach wrote: > Add binding documentation for the True Random Number Generator > found on Samsung Exynos 5250+ SoCs. > > Signed-off-by: Łukasz Stelmach > --- > .../devicetree/bindings/rng/samsung,exynos5250-trng.txt | 17 > + >

Re: [PATCH 4.14 00/95] 4.14.4-stable review

2017-12-04 Thread Shuah Khan
On 12/04/2017 08:59 AM, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.14.4 release. > There are 95 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Responses sh

Re: [PATCH V7 2/2] dt-bindings: Add qcom spmi_pmic clock divider bindings

2017-12-04 Thread Rob Herring
On Tue, Nov 21, 2017 at 02:41:05PM +0530, Tirupathi Reddy wrote: > This patch adds device tree bindings for Qualcomm SPMI PMIC > clock divider module. > > Signed-off-by: Tirupathi Reddy > --- > .../bindings/clock/qcom,spmi-pmic-div.txt | 59 > ++ Didn't Stephen say

Re: [PATCHv3 1/5] x86/boot/compressed/64: Detect and handle 5-level paging at boot-time

2017-12-04 Thread Thomas Gleixner
On Mon, 4 Dec 2017, Kirill A. Shutemov wrote: > This patch prepare decompression code to boot-time switching between 4- > and 5-level paging. This is the very wrong reason for tagging this commit stable. > > Signed-off-by: Kirill A. Shutemov > Cc: [4.14+] Adding cc stable requires a Fixes

Re: [patch 02/60] x86/unwinder/orc: Dont bail on stack overflow

2017-12-04 Thread Andy Lutomirski
Fixlet lost here > On Dec 4, 2017, at 6:07 AM, Thomas Gleixner wrote: > > regs->sp Should be state->sp

Re: [PATCH] drm: amd: dc: don't use FP math when Kcov is enabled

2017-12-04 Thread Harry Wentland
On 2017-12-04 08:08 AM, Arnd Bergmann wrote: > Building the DCN 1.0 Raven display driver with CONFIG_KCOV_INSTRUMENT_ALL=y > and CONFIG_KCOV_ENABLE_COMPARISONS=y results in warnings about many functions > that do a comparison of floating-point variables: > > drivers/gpu/drm/amd/display/dc/calcs/dc

Re: [PATCH 2/2] ahci: mtk: Change driver name to ahci-mtk

2017-12-04 Thread Tejun Heo
On Fri, Dec 01, 2017 at 11:47:22AM +0100, Matthias Brugger wrote: > The driver name "ahci" is already used by the ahci platform driver. > This leads to the following error: > Error: Driver 'ahci' is already registered, aborting... > > Change the name to ahci-mtk to fix this. > > Signed-off-by: Ma

Re: [PATCH v3 1/4] uinput: Add ioctl for using monotonic/ boot times

2017-12-04 Thread Deepa Dinamani
On Mon, Dec 4, 2017 at 6:21 AM, Arnd Bergmann wrote: > On Mon, Dec 4, 2017 at 1:55 AM, Deepa Dinamani wrote: >> struct timeval which is part of struct input_event to >> maintain the event times is not y2038 safe. >> >> Real time timestamps are also not ideal for input_event >> as this time can go

Re: [PATCH v3 4/4] input: serio: Replace timeval by timespec64

2017-12-04 Thread Deepa Dinamani
On Mon, Dec 4, 2017 at 5:44 AM, Arnd Bergmann wrote: > On Mon, Dec 4, 2017 at 1:55 AM, Deepa Dinamani wrote: >> struct timeval is not y2038 safe. >> All references to timeval will be deleted from the >> kernel to make it y2038 safe. >> Replace its uses by y2038 safe struct timespec64. >> >> The t

[PATCH V2] staging: pi433: rf69.c: Replace macros READ_REG and WRITE_REG with inline functions rf69_set_bit, rf69_reset_bit and rf69_read_modify_write

2017-12-04 Thread Marcus Wolf
To increase the readability of the register accesses, the abstraction of the helpers was increased from simple read and write to set bit, clear bit and read modify write bit. Annotation: This patch contains a lot of long lines and camel case var names. These long lines and camel case vars weren't

Re: [PATCH v3 3/4] input: Deprecate real timestamps beyond year 2106

2017-12-04 Thread Deepa Dinamani
On Mon, Dec 4, 2017 at 6:29 AM, Arnd Bergmann wrote: > On Mon, Dec 4, 2017 at 1:55 AM, Deepa Dinamani wrote: >> struct timeval is not y2038 safe. >> All usage of timeval in the kernel will be replaced by >> y2038 safe structures. >> The change is also necessary as glibc is introducing support >>

[PATCH v2] Staging: pi433: fix brace coding style issues in pi433_if.c

2017-12-04 Thread Tomas Marek
This patch fix several brace on next line, braces not necessary, space around =/<, and space before/after open/close parenthesis coding style errors find by checkpatch in pi433_if.c. In addition, the interrupt routine DIO0_irq_handler logic is updated: - use 'switch' statement instead of 'if/else

Re: [PATCH v3 0/4] Make input drivers y2038 safe

2017-12-04 Thread Deepa Dinamani
On Mon, Dec 4, 2017 at 6:30 AM, Arnd Bergmann wrote: > On Mon, Dec 4, 2017 at 1:55 AM, Deepa Dinamani wrote: >> The series is aimed at making input events y2038 safe. >> It extends the lifetime of the realtime timestamps in the >> events to year 2106. >> The series is also a necessary update as g

[PATCH 00/10] ASoC: fsl_ssi: Clean up - coding style level

2017-12-04 Thread Nicolin Chen
==Background== The fsl_ssi driver was designed for PPC originally and then it has been updated to support different modes for i.MX Series, including SDMA, I2S Master mode, AC97 and older i.MXs with FIQ, by different contributors for different use cases in different coding styles. Additionally, in

[PATCH 01/10] ASoC: fsl_ssi: Remove unused struct device

2017-12-04 Thread Nicolin Chen
struct device is defined in system level header files any way. As long as fsl_ssi.h is included after those header files, it should be safe to remove this line. Signed-off-by: Nicolin Chen --- sound/soc/fsl/fsl_ssi.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/sound/soc/fsl/fsl_ssi.h b/

[PATCH 10/10] ASoC: fsl_ssi: Replace fsl_ssi_rxtx_reg_val with fsl_ssi_regvals

2017-12-04 Thread Nicolin Chen
The name fsl_ssi_rxtx_reg_val is too long to read comfortably. So this patch shortens it by using an array (fsl_ssi_regvals, renamed from fsl_ssi_reg_val). To do that, it also introduces two macros (TX and RX) to replace the wrapper structure. This will also help for further cleanups. Meanwhile, i

[PATCH 08/10] ASoC: fsl_ssi: Rename cpu_dai parameter to dai

2017-12-04 Thread Nicolin Chen
Shortens the variable name to save space, useful for dev_err outputs. Signed-off-by: Nicolin Chen --- sound/soc/fsl/fsl_ssi.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c index e1c985b..10

[PATCH 07/10] ASoC: fsl_ssi: Refine printk outputs

2017-12-04 Thread Nicolin Chen
This patches unifies the error message in the "failed to " format. It also reduces the length of one line and adds spaces to an operator. Signed-off-by: Nicolin Chen --- sound/soc/fsl/fsl_ssi.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/sound/soc/fs

[PATCH 09/10] ASoC: fsl_ssi: Rename scr_val to scr

2017-12-04 Thread Nicolin Chen
Simplify the variable name. This reduces one over-80-character line. Signed-off-by: Nicolin Chen --- sound/soc/fsl/fsl_ssi.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c index 10f6b63..55f6a1f 100644 --- a/soun

[PATCH 05/10] ASoC: fsl_ssi: Rename registers and fields macros

2017-12-04 Thread Nicolin Chen
This patch renames CCSR_SSI_xxx to REG_SSI_xxx and SSI_xxx_yyy style. It also slightly reduces the length of them to save some space. Signed-off-by: Nicolin Chen --- sound/soc/fsl/fsl_ssi.c | 374 +-- sound/soc/fsl/fsl_ssi.h | 376 +

[PATCH 06/10] ASoC: fsl_ssi: Refine indentations and wrappings

2017-12-04 Thread Nicolin Chen
This patch just simply unifies the coding style. Signed-off-by: Nicolin Chen --- sound/soc/fsl/fsl_ssi.c | 225 ++-- sound/soc/fsl/fsl_ssi.h | 2 +- sound/soc/fsl/fsl_ssi_dbg.c | 3 +- 3 files changed, 113 insertions(+), 117 deletions(-) diff

[PATCH 04/10] ASoC: fsl_ssi: Refine all comments

2017-12-04 Thread Nicolin Chen
This patch refines the comments by: 1) Removing all out-of-date comments 2) Removing all not-so-useful comments 3) Unifying the styles of all comments 4) Simplifying over-descriptive comments 5) Adding comments to improve code readablity 6) Moving all register related comments to fsl_ssi.h 7) Addin

[PATCH 02/10] ASoC: fsl_ssi: Rename fsl_ssi_private to fsl_ssi

2017-12-04 Thread Nicolin Chen
Shorten the private data structure to save some wrapped lines. Signed-off-by: Nicolin Chen --- sound/soc/fsl/fsl_ssi.c | 456 +++- 1 file changed, 220 insertions(+), 236 deletions(-) diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c index

[PATCH 03/10] ASoC: fsl_ssi: Cache pdev->dev pointer

2017-12-04 Thread Nicolin Chen
There should be no trouble to understand dev = pdev->dev. This can save some space to have more print info or save some wrapped lines. Signed-off-by: Nicolin Chen --- sound/soc/fsl/fsl_ssi.c | 64 - 1 file changed, 31 insertions(+), 33 deletions(-)

Re: [PATCH v3 03/21] fpga: mgr: add status for fpga-manager

2017-12-04 Thread Alan Tull
On Mon, Nov 27, 2017 at 12:42 AM, Wu Hao wrote: Hi Hao, mgr->status isn't used anywhere except in status_show. So we don't need to add status to the fpga_manager struct. Also don't need the inline function to update it. Just read the status in status_show, if that ops exists. If mops->status

[PATCH] HID: elecom: rewrite report fixup for EX-G and future mice

2017-12-04 Thread Tomasz Kramkowski
This patch rewrites the mouse report fixup used for the DEFT and HUGE ELECOM trackballs in order to make it generic enough to fix other ELECOM mice with similar issues. This patch also uses this new report fixup function to fix the ELECOM EX-G trackball which has 6 physical buttons and a similar is

Re: [PATCH v13 3/5] mfd: Add driver for RAVE Supervisory Processor

2017-12-04 Thread Andrey Smirnov
On Mon, Dec 4, 2017 at 8:11 AM, Andrey Smirnov wrote: > Add a driver for RAVE Supervisory Processor, an MCU implementing > various bits of housekeeping functionality (watchdoging, backlight > control, LED control, etc) on RAVE family of products by Zodiac > Inflight Innovations. > > This driver im

Re: [PATCH RFC] stat.2: Document that stat can fail with EINTR

2017-12-04 Thread Michael Kerrisk (man-pages)
Hello Keno On 12/03/2017 04:15 AM, Keno Fischer wrote: > Resending as plain text (apologies for those receiving it twice, and > those that got > an HTML copy, I'm used to my mail client switching that over > automatically, which > for some reason didn't happen here). > > > This is exactly the di

Re: [PATCH] leaking_addresses: add support for 32-bit kernel addresses

2017-12-04 Thread Tobin C. Harding
On Mon, Dec 04, 2017 at 03:50:41PM +0530, kaiwan.billimo...@gmail.com wrote: > On Mon, 2017-12-04 at 19:21 +1100, Tobin C. Harding wrote: > > On Mon, Dec 04, 2017 at 10:51:53AM +0530, Kaiwan N Billimoria wrote: > > > > --- > > > diff --git a/scripts/leaking_addresses.pl b/scripts/leaking_addresses.

Re: maxcpus confusion

2017-12-04 Thread Heiko Carstens
On Fri, Dec 01, 2017 at 12:58:47PM -0800, Randy Dunlap wrote: > Hi, > > I used "maxcpus=1" on a recent x86 boot (4.15-rc1) and got 4 CPUs (all of > them AFAICT). When I use "nr_cpus=1", I do get a hard limit of one CPU. > > > A few boot log excerpts: > > [0.00] smpboot: Allowing 8 CPUs

Re: [PATCH RFC] stat.2: Document that stat can fail with EINTR

2017-12-04 Thread Keno Fischer
Hi Michael, I was hoping to get a clear statement one way or another from the kernel maintainers as to whether an EINTR from stat() is supposed to be allowed kernel behavior (hence the RFC in the subject). If it's not, then I don't think it should be documented, even if there is buggy filesystems

Re: [PATCH] workqueue/hotplug: simplify workqueue_offline_cpu()

2017-12-04 Thread Tejun Heo
On Fri, Dec 01, 2017 at 10:20:36PM +0800, Lai Jiangshan wrote: > Since the refactor for the cpu/hotplug is done, > workqueue_offline_cpu() is ensured to be run on the > local cpu which is going off. > > Signed-off-by: Lai Jiangshan Applied to wq/for-4.16 w/ minor desc update. Thanks. -- tejun

Re: KASAN: slab-out-of-bounds Read in strcmp

2017-12-04 Thread Paul Moore
On Mon, Dec 4, 2017 at 11:29 AM, Dmitry Vyukov wrote: > On Mon, Dec 4, 2017 at 2:59 PM, Paul Moore wrote: > Hi Paul, > > We are just rolling in the process. Feedback is much appreciated! > > The idea is that we need to know the title as it will appear in Linus > tree and in other tested trees. It

Re: [PATCH] workqueue/hotplug: remove the workaround in rebind_workers()

2017-12-04 Thread Tejun Heo
On Fri, Dec 01, 2017 at 10:23:07PM +0800, Lai Jiangshan wrote: > Sine the cpu/hotplug refactor is done, the hotplug > callbacks are called properly. So the workaround is > useless. > > Signed-off-by: Lai Jiangshan Applied to wq/for-4.16 w/ desc updates. Thanks. -- tejun

Re: [PATCH 4.14 00/95] 4.14.4-stable review

2017-12-04 Thread Tom Gall
> On Dec 4, 2017, at 9:59 AM, Greg Kroah-Hartman > wrote: > > This is the start of the stable review cycle for the 4.14.4 release. > There are 95 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. >

Re: [PATCHv3 1/5] x86/boot/compressed/64: Detect and handle 5-level paging at boot-time

2017-12-04 Thread Kirill A. Shutemov
On Mon, Dec 04, 2017 at 09:29:45PM +0100, Thomas Gleixner wrote: > On Mon, 4 Dec 2017, Kirill A. Shutemov wrote: > > > This patch prepare decompression code to boot-time switching between 4- > > and 5-level paging. > > This is the very wrong reason for tagging this commit stable. > > > > > Sign

Re: [PATCH 1/3] eeprom: at25: Add DT support for EEPROMs with odd address bits

2017-12-04 Thread Rob Herring
On Mon, Dec 04, 2017 at 10:17:47AM +0100, Geert Uytterhoeven wrote: > On Thu, Nov 30, 2017 at 2:29 PM, Geert Uytterhoeven > wrote: > > Certain EEPROMS have a size that is larger than the number of address > > bytes would allow, and store the MSB of the address in bit 3 of the > > instruction byte.

[PATCH] checkpatch: warn for use of %px

2017-12-04 Thread Tobin C. Harding
Usage of the new %px specifier potentially leaks sensitive inforamtion. Printing kernel addresses exposes the kernel layout in memory, this is potentially exploitable. We have tools in the kernel to help us do the right thing. We can have checkpatch warn developers of potential dangers of using %px

Re: [PATCH v3 1/4] uinput: Add ioctl for using monotonic/ boot times

2017-12-04 Thread Arnd Bergmann
On Mon, Dec 4, 2017 at 9:36 PM, Deepa Dinamani wrote: > On Mon, Dec 4, 2017 at 6:21 AM, Arnd Bergmann wrote: >> On Mon, Dec 4, 2017 at 1:55 AM, Deepa Dinamani >> wrote: >>> struct timeval which is part of struct input_event to >>> maintain the event times is not y2038 safe. >>> >>> Real time ti

[PATCH 1/5] dt: bindings: lp8860: Update DT label binding

2017-12-04 Thread Dan Murphy
Update the lp8860 label binding to the LED standard as documented in Documentation/devicetree/bindings/leds/common.txt Signed-off-by: Dan Murphy cc: devicet...@vger.kernel.org --- Documentation/devicetree/bindings/leds/leds-lp8860.txt | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-)

[PATCH 2/5] leds: lp8860: Update the dt parsing for LED labeling

2017-12-04 Thread Dan Murphy
Update the DT parsing for the label node so that the label is retrieved from the device child as opposed to being part of the parent. This will align this driver with the LED binding documentation Documentation/devicetree/bindings/leds/common.txt Signed-off-by: Dan Murphy --- drivers/leds/leds

[PATCH 4/5] leds: lp8860: Add DT parsing to retrieve the trigger node

2017-12-04 Thread Dan Murphy
Add the ability to parse the DT and set the default trigger mode for the LED. Signed-off-by: Dan Murphy --- drivers/leds/leds-lp8860.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/leds/leds-lp8860.c b/drivers/leds/leds-lp8860.c index 13d6210cba85..4fed603ee728 100644 --- a/dri

[PATCH 5/5] leds: lp8860: Various fixes to align with LED framework

2017-12-04 Thread Dan Murphy
Update the driver to conform with the LED framework. Use devm_led_classdev_register Destroy mutex on exit Remove dependency on CONFIG_OF in the driver and move to the Kconfig Update the MODULE_LICENSE to GPL v2 Remove setting of MAX brightness as the LED framework does this. Signed-off-by: Dan Mur

[PATCH 3/5] dt: bindings: lp8860: Add trigger binding to the lp8860

2017-12-04 Thread Dan Murphy
Add a default trigger optional node to the child node. This will allow the driver to set the trigger for a backlight. Signed-off-by: Dan Murphy cc: devicet...@vger.kernel.org --- Documentation/devicetree/bindings/leds/leds-lp8860.txt | 13 - 1 file changed, 8 insertions(+), 5 deletio

Re: [PATCH] eeprom: at24: Change nvmem stride to 1

2017-12-04 Thread David Lechner
On 12/04/2017 11:44 AM, Bartosz Golaszewski wrote: I can't find any documentation on what the stride config option does in nvmem, but looking at the code it's only used for alignment checks in nvmem core, so this patch should be ok. Still: I'm wondering if it shouldn't depend on the size of the e

Re: [PATCH 0/3] eeprom: at25: Add DT support for 25lc040

2017-12-04 Thread Rob Herring
On Thu, Nov 30, 2017 at 02:29:43PM +0100, Geert Uytterhoeven wrote: > Hi all, > > Some "atmel,at25" compatible SPI EEPROMs (e.g. Microchip 25lc040) use an > odd number of address bits. This patch series adds support for > instantiating such devices from DT. > > Do EEPROMs using 17 or 25 ad

[PATCH 0/5] Numerous fixes for LP8860

2017-12-04 Thread Dan Murphy
All After creating a new LED driver for the LM3692x device I went back to the LP8860 driver that I authored and found some updates that need to be applied. First the way the LP8860 retrieved the label from the DT was incorrect as the label should have been from a child node as opposed to the pare

[PATCH] doc: update 'unique identifiers'

2017-12-04 Thread Tobin C. Harding
Advice about what to use as a unique identifier is no longer valid since patch series was merged to hash pointers printed with %p. We can use this as a unique identifier now. Signed-off-by: Tobin C. Harding --- Documentation/security/self-protection.rst | 4 ++-- 1 file changed, 2 insertions(+),

[patch V4 08/11] LICENSES: Add the MIT license

2017-12-04 Thread Thomas Gleixner
Add the full text of the MIT license to the kernel tree. It was copied directly from: https://spdx.org/licenses/MIT.html#licenseText Add the required tags for reference and tooling. Signed-off-by: Thomas Gleixner Reviewed-by: Philippe Ombredanne Reviewed-by: Kate Stewart Reviewed-by: Greg

[patch V4 06/11] LICENSES: Add the BSD 3-clause "New" or "Revised" License

2017-12-04 Thread Thomas Gleixner
Add the full text of the BSD 3-clause "New" or "Revised" License to the kernel tree. It was copied directly from: https://spdx.org/licenses/BSD-3-Clause.html#licenseText Add the required tags for reference and tooling. Signed-off-by: Thomas Gleixner Reviewed-by: Philippe Ombredanne Reviewed

[patch V4 11/11] LICENSES: Add MPL-1.1 license

2017-12-04 Thread Thomas Gleixner
Add the full text of the Mozilla Public License 1.1 to the kernel tree. It was copied directly from: https://spdx.org/licenses/MPL-1.1.html#licenseText Signed-off-by: Thomas Gleixner Reviewed-by: Philippe Ombredanne Reviewed-by: Kate Stewart Reviewed-by: Greg Kroah-Hartman --- LICEN

[patch V4 10/11] LICENSES: Add the GPL 1.0 license

2017-12-04 Thread Thomas Gleixner
Add the full text of the GPL 1.0 license to the kernel tree. It was copied directly from: https://spdx.org/licenses/GPL-1.0.html#licenseText Signed-off-by: Thomas Gleixner Reviewed-by: Philippe Ombredanne Reviewed-by: Kate Stewart Reviewed-by: Greg Kroah-Hartman --- LICENSES/other/G

Re: [PATCH v6 0/9] i2c: document DMA handling and add helpers for it

2017-12-04 Thread Wolfram Sang
On Sat, Nov 04, 2017 at 09:20:00PM +0100, Wolfram Sang wrote: > So, after revisiting old mail threads, taking part in a similar discussion on > the USB list, and implementing a not-convincing solution before, here is what > I > cooked up to document and ease DMA handling for I2C within Linux. Plea

[patch V4 09/11] LICENSES: Add Linux syscall note exception

2017-12-04 Thread Thomas Gleixner
Copied from the Linux kernel COPYING file. Add the required tags for reference and tooling. Signed-off-by: Thomas Gleixner Reviewed-by: Philippe Ombredanne Reviewed-by: Kate Stewart Reviewed-by: Greg Kroah-Hartman --- LICENSES/exceptions/Linux-syscall-note | 25 +

[patch V4 07/11] LICENSES: Add the BSD-3-clause "Clear" license

2017-12-04 Thread Thomas Gleixner
Add the full text of the BSD 3-clause "Clear" License to the kernel tree. It was copied directly from: https://spdx.org/licenses/BSD-3-Clause-Clear.html Add the required tags for reference and tooling. Signed-off-by: Thomas Gleixner Reviewed-by: Philippe Ombredanne Reviewed-by: Kate Stewart

[patch V4 01/11] Documentation: Add license-rules.rst to describe how to properly identify file licenses

2017-12-04 Thread Thomas Gleixner
Add a file to the Documentation directory to describe how file licenses should be described in all kernel files, using the SPDX identifier, as well as where all licenses should be in the kernel source tree for people to refer to (LICENSES/). Thanks to Kate and Greg for review and editing and Jonas

[patch V4 00/11] LICENSES: Add documentation and initial License files

2017-12-04 Thread Thomas Gleixner
This is the 4th version of the licensing rules documentation. Changes since v3: - Addressed the review comments - Replaced the GPL-2.0 license text with the one from the kernel COPYING file and added the nice explanation from Philippe to the changelog. - Picked up Reviewed-by tags Thanks

[patch V4 05/11] LICENSES: Add the BSD 2-clause "Simplified" license

2017-12-04 Thread Thomas Gleixner
Add the full text of the BSD 2-clause "Simplified" license to the kernel tree. It was copied directly from: https://spdx.org/licenses/BSD-2-Clause.html#licenseText Add the required tags for reference and tooling. Signed-off-by: Thomas Gleixner Reviewed-by: Philippe Ombredanne Reviewed-by:

[patch V4 04/11] LICENSES: Add the LGPL-2.1 license

2017-12-04 Thread Thomas Gleixner
Add the full text of the LGPL 2.1 license to the kernel tree. It was copied directly from: https://spdx.org/licenses/LGPL-2.1.html#licenseText Add the required tags for reference and tooling. Signed-off-by: Thomas Gleixner Reviewed-by: Philippe Ombredanne Reviewed-by: Kate Stewart Reviewe

[patch V4 03/11] LICENSES: Add the LGPL 2.0 license

2017-12-04 Thread Thomas Gleixner
Add the full text of the LGPL 2.0 license to the kernel tree. It was copied directly from: https://spdx.org/licenses/LGPL-2.0.html#licenseText Add the required tags for reference and tooling. Signed-off-by: Thomas Gleixner Reviewed-by: Philippe Ombredanne Reviewed-by: Kate Stewart Reviewe

[patch V4 02/11] LICENSES: Add the GPL 2.0 license

2017-12-04 Thread Thomas Gleixner
Add the full text of the GPL 2.0 license to the LICENSES directory. It was copied directly from the COPYING file in the kernel source tree as it differs from the public available version of the license in various places including the FSF. Philippe did some research on the GPL2.0 history: There

Re: [PATCH 0/5] blkcg: Limit maximum number of aio requests available for cgroup

2017-12-04 Thread Kirill Tkhai
Hi, Benjamin, On 04.12.2017 19:52, Benjamin LaHaise wrote: > Hi Kirill, > > On Mon, Dec 04, 2017 at 07:12:51PM +0300, Kirill Tkhai wrote: >> Hi, >> >> this patch set introduces accounting aio_nr and aio_max_nr per blkio cgroup. >> It may be used to limit number of aio requests, which are availabl

Re: [PATCH v8 10/13] dt-bindings: Add qcom slimbus controller bindings

2017-12-04 Thread Rob Herring
On Thu, Nov 30, 2017 at 05:41:57PM +, srinivas.kandaga...@linaro.org wrote: > From: Sagar Dharia > > This patch add device tree bindings for Qualcomm slimbus controller. > > Signed-off-by: Sagar Dharia > Signed-off-by: Srinivas Kandagatla > --- > .../devicetree/bindings/slimbus/slim-qcom-

Re: [PATCH] doc: update 'unique identifiers'

2017-12-04 Thread Kees Cook
On Mon, Dec 4, 2017 at 1:22 PM, Tobin C. Harding wrote: > Advice about what to use as a unique identifier is no longer valid since > patch series was merged to hash pointers printed with %p. We can use > this as a unique identifier now. > > Signed-off-by: Tobin C. Harding I don't agree: %p shoul

Re: [patch 02/60] x86/unwinder/orc: Dont bail on stack overflow

2017-12-04 Thread Thomas Gleixner
On Mon, 4 Dec 2017, Andy Lutomirski wrote: > Fixlet lost here > > > On Dec 4, 2017, at 6:07 AM, Thomas Gleixner wrote: > > > > regs->sp > > Should be state->sp Fixed. Thanks, tglx

Re: [PATCH v2 1/5] fpga: region: don't use drvdata in common fpga code

2017-12-04 Thread Moritz Fischer
On Wed, Nov 15, 2017 at 02:51:48PM -0600, Alan Tull wrote: > Part of patchset that changes the following fpga_*_register > functions to not set drvdata: > * fpga_region_register. > * fpga_mgr_register > * fpga_bridge_register > > The rationale is that setting drvdata is fine for DT based devices >

Re: [PATCH 0/5] blkcg: Limit maximum number of aio requests available for cgroup

2017-12-04 Thread Jeff Moyer
Kirill Tkhai writes: > Hi, Benjamin, > > On 04.12.2017 19:52, Benjamin LaHaise wrote: >> Hi Kirill, >> >> On Mon, Dec 04, 2017 at 07:12:51PM +0300, Kirill Tkhai wrote: >>> Hi, >>> >>> this patch set introduces accounting aio_nr and aio_max_nr per blkio cgroup. >>> It may be used to limit number

Writing "+pids" to cgroup.subtree_control flie yields EINVAL

2017-12-04 Thread Michael Kerrisk (man-pages)
Hello Tejun, I was trying to do some simple testing ot the CPU controller that is merged into 4.15, and ran immediately into some confusion. In the root cgroup on a freshly booted 4.150-rc1, I try the following: # pwd /sys/fs/cgroup/unified # echo '+cpu' > cgroup.subtree_control sh: echo: write

Re: [PATCH RFC 2/2] arm64: allwinner: a64: Add Brava Keller initial support

2017-12-04 Thread Rob Herring
On Thu, Nov 30, 2017 at 10:36:55PM +0100, Philippe Ombredanne wrote: > Jagan, > > On Thu, Nov 30, 2017 at 7:42 PM, Jagan Teki wrote: > [] > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-brava-keller.dts > > b/arch/arm64/boot/dts/allwinner/sun50i-a64-brava-keller.dts > > new file mode 1

Re: [PATCH v3 15/16] iommu: introduce page response function

2017-12-04 Thread Jacob Pan
On Fri, 24 Nov 2017 12:03:50 + Jean-Philippe Brucker wrote: > On 17/11/17 18:55, Jacob Pan wrote: > > When nested translation is turned on and guest owns the > > first level page tables, device page request can be forwared > > to the guest for handling faults. As the page response returns > >

Re: [PATCH RFC 1/2] dt-bindings: Add vendor prefix for Brava Home

2017-12-04 Thread Rob Herring
On Fri, Dec 01, 2017 at 12:12:13AM +0530, Jagan Teki wrote: > Added 'brava' as a vendor prefix for Brava Home, Inc. > which is consumer electronics and IoT company. > > Signed-off-by: Jagan Teki > --- > Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + > 1 file changed, 1 insertion(+)

Re: [PATCH v4 0/2] livepatch: Introduce signal and force sysfs attributes

2017-12-04 Thread Jiri Kosina
On Wed, 15 Nov 2017, Miroslav Benes wrote: > Currently, livepatch gradually migrate the system from an unpatched to a > patched state (or vice versa). Each task drops its TIF_PATCH_PENDING > itself when crossing the kernel/user space boundary or it is cleared > using the stack checking approach. I

<    1   2   3   4   5   6   7   8   9   10   >