[PATCH 00/23] [v4] KAISER: unmap most of the kernel from userspace page tables

2017-11-22 Thread Dave Hansen
Thanks, everyone for all the reviews thus far. I hope I managed to address all the feedback given so far, except for the TODOs of course. This is a pretty minor update compared to v1->v2. These patches are all on this tip branch: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.

[PATCH 02/23] x86, kaiser: prepare assembly for entry/exit CR3 switching

2017-11-22 Thread Dave Hansen
From: Dave Hansen This is largely code from Andy Lutomirski. I fixed a few bugs in it, and added a few SWITCH_TO_* spots. KAISER needs to switch to a different CR3 value when it enters the kernel and switch back when it exits. This essentially needs to be done before leaving assembly code. T

[PATCH 15/23] x86, mm: put mmu-to-h/w ASID translation in one place

2017-11-22 Thread Dave Hansen
From: Dave Hansen There are effectively two ASID types: 1. The one stored in the mmu_context that goes from 0->5 2. The one programmed into the hardware that goes from 1->6 This consolidates the locations where converting beween the two (by doing +1) to a single place which gives us a nice plac

[PATCH 21/23] x86, kaiser: un-poison PGDs at runtime

2017-11-22 Thread Dave Hansen
From: Dave Hansen With KAISER Kernel PGDs that map userspace are "poisoned" with the NX bit. This ensures that if a kernel->user CR3 switch is missed, userspace crashes instead of running in an unhardened state. This code will be needed in a moment when KAISER is turned on and off at runtime.

[PATCH 23/23] x86, kaiser: add Kconfig

2017-11-22 Thread Dave Hansen
From: Dave Hansen PARAVIRT generally requires that the kernel not manage its own page tables. It also means that the hypervisor and kernel must agree wholeheartedly about what format the page tables are in and what they contain. KAISER, unfortunately, changes the rules and they can not be used

[PATCH 22/23] x86, kaiser: allow KAISER to be enabled/disabled at runtime

2017-11-22 Thread Dave Hansen
From: Dave Hansen The KAISER CR3 switches are expensive for many reasons. Not all systems benefit from the protection provided by KAISER. Some of them can not pay the high performance cost. This patch adds a debugfs file. To disable KAISER, you do: echo 0 > /sys/kernel/debug/x86/kai

[PATCH 11/23] x86, kaiser: map entry stack variables

2017-11-22 Thread Dave Hansen
From: Dave Hansen There are times where the kernel is entered but there is not a safe stack, like at SYSCALL entry. To obtain a safe stack, the per-cpu variables 'rsp_scratch' and 'cpu_current_top_of_stack' are used to save the old %rsp value and to find where the kernel stack should start. Yo

[PATCH 19/23] x86, kaiser: add debugfs file to turn KAISER on/off at runtime

2017-11-22 Thread Dave Hansen
From: Dave Hansen This will be used in a few patches. Right now, it's not wired up to do anything useful. Signed-off-by: Dave Hansen Cc: Moritz Lipp Cc: Daniel Gruss Cc: Michael Schwarz Cc: Richard Fellner Cc: Andy Lutomirski Cc: Linus Torvalds Cc: Kees Cook Cc: Hugh Dickins Cc: x...@

Re: [PATCH 3/3] autofs - fix AT_NO_AUTOMOUNT not being honored

2017-11-22 Thread Ian Kent
On 22/11/17 12:28, Ian Kent wrote: > On 21/11/17 09:53, NeilBrown wrote: >> On Wed, May 10 2017, Ian Kent wrote: >> >>> The fstatat(2) and statx() calls can pass the flag AT_NO_AUTOMOUNT >>> which is meant to clear the LOOKUP_AUTOMOUNT flag and prevent triggering >>> of an automount by the call. Bu

[PATCH 17/23] x86, kaiser: use PCID feature to make user and kernel switches faster

2017-11-22 Thread Dave Hansen
From: Dave Hansen Short summary: Use x86 PCID feature to avoid flushing the TLB at all interrupts and syscalls. Speed them up. Makes context switches and TLB flushing slower. Background: KAISER keeps two copies of the page tables. Switches between the copies are performed by writing to the

[PATCH 20/23] x86, kaiser: add a function to check for KAISER being enabled

2017-11-22 Thread Dave Hansen
From: Dave Hansen Currently, all of the checks for KAISER are compile-time checks. Runtime checks are needed for turning it on/off at runtime. Add a function to do that. Signed-off-by: Dave Hansen Cc: Moritz Lipp Cc: Daniel Gruss Cc: Michael Schwarz Cc: Richard Fellner Cc: Andy Lutomirsk

[PATCH 13/23] x86, mm: Move CR3 construction functions

2017-11-22 Thread Dave Hansen
From: Dave Hansen For flushing the TLB, the ASID which has been programmed into the hardware must be known. That differs from what is in 'cpu_tlbstate'. Add functions to transform the 'cpu_tlbstate' values into to the one programmed into the hardware (CR3). It's not easy to include mmu_contex

[PATCH 14/23] x86, mm: remove hard-coded ASID limit checks

2017-11-22 Thread Dave Hansen
From: Dave Hansen First, it's nice to remove the magic numbers. Second, KAISER is going to consume half of the available ASID space. The space is currently unused, but add a comment to spell out this new restriction. Signed-off-by: Dave Hansen Cc: Moritz Lipp Cc: Daniel Gruss Cc: Michael S

[PATCH 16/23] x86, pcid, kaiser: allow flushing for future ASID switches

2017-11-22 Thread Dave Hansen
From: Dave Hansen If changing the page tables in such a way that an invalidation of all contexts (aka. PCIDs / ASIDs) is required, they can be actively invalidated by: 1. INVPCID for each PCID (works for single pages too). 2. Load CR3 with each PCID without the NOFLUSH bit set 3. Load CR3 wi

[PATCH 18/23] x86, kaiser: disable native VSYSCALL

2017-11-22 Thread Dave Hansen
From: Dave Hansen The KAISER code attempts to "poison" the user portion of the kernel page tables. It detects entries that it wants that it wants to poison in two ways: * Looking for addresses >= PAGE_OFFSET * Looking for entries without _PAGE_USER set But, to allow the _PAGE_USER check to w

[PATCH 12/23] x86, kaiser: map virtually-addressed performance monitoring buffers

2017-11-22 Thread Dave Hansen
From: Hugh Dickins [Dave] Add explicit _PAGE_GLOBAL [Dave] remove KAISER #ifdefs by moving kmalloc() to plain page allocator [Dave] reword the commit message a bit to be consistent with other patches The BTS and PEBS buffers both have their virtual addresses programmed into the hardware. This m

[PATCH 07/23] x86, kaiser: make sure static PGDs are 8k in size

2017-11-22 Thread Dave Hansen
From: Dave Hansen A few PGDs come out of the kernel binary instead of being allocated dynamically. Before this patch, they are all 8k-aligned, but they must also be 8k in *size*. The original KAISER patch did not do this. It probably just lucked out that it did not trample over data after the

[PATCH 08/23] x86, kaiser: map cpu entry area

2017-11-22 Thread Dave Hansen
From: Dave Hansen There is now a special 'struct cpu_entry' area that contains all of the data needed to enter the kernel. It's mapped in the fixmap area and contains: * The GDT (hardware segment descriptor) * The TSS (thread information structure that points the hardware to the various s

[PATCH 10/23] x86, kaiser: map espfix structures

2017-11-22 Thread Dave Hansen
From: Dave Hansen There is some rather arcane code to help when an IRET returns to 16-bit segments. It is referred to as the "espfix" code. This consists of a few per-cpu variables: espfix_stack: tells us where the stack is allocated (the bottom) espfix_wa

[PATCH 09/23] x86, kaiser: map dynamically-allocated LDTs

2017-11-22 Thread Dave Hansen
From: Dave Hansen Normally, a process has a NULL mm->context.ldt. But, there is a syscall for a process to set a new one. If a process does that, the LDT be mapped into the user page tables, just like the default copy. The original KAISER patch missed this case. Signed-off-by: Dave Hansen C

[PATCH 06/23] x86, kaiser: allow NX poison to be set in p4d/pgd

2017-11-22 Thread Dave Hansen
From: Dave Hansen The user portion of the kernel page tables use the NX bit to poison them for userspace. But, that trips the p4d/pgd_bad() checks. Make sure it does not do that. Signed-off-by: Dave Hansen Cc: Moritz Lipp Cc: Daniel Gruss Cc: Michael Schwarz Cc: Richard Fellner Cc: Andy

[Patch v8 05/16] CIFS: SMBD: Upper layer destroys SMB Direct session on shutdown or umount

2017-11-22 Thread Long Li
From: Long Li When upper layer wants to umount, make it call shutdown on transport when SMB Direct is used. Signed-off-by: Long Li --- fs/cifs/connect.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c index fc46066..d8bfa89 100644 -

[Patch v8 02/16] CIFS: SMBD: Implement function to reconnect to a SMB Direct transport

2017-11-22 Thread Long Li
From: Long Li Add function to implement a reconnect to SMB Direct. This involves tearing down the current connection and establishing/negotiating a new connection. Signed-off-by: Long Li --- fs/cifs/smbdirect.c | 36 fs/cifs/smbdirect.h | 4 2 files c

[Patch v8 03/16] CIFS: SMBD: Upper layer reconnects to SMB Direct session

2017-11-22 Thread Long Li
From: Long Li Do a reconnect on SMB Direct when it is used as the connection. Reconnect can happen for many reasons and it's mostly the decision of SMB2 upper layer. Signed-off-by: Long Li --- fs/cifs/connect.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/fs/cifs/con

[Patch v8 08/16] CIFS: SMBD: Upper layer receives data via RDMA receive

2017-11-22 Thread Long Li
From: Long Li With SMB Direct connected, use it for receiving data via RDMA receive. Signed-off-by: Long Li --- fs/cifs/connect.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c index d8bfa89..1677401 100644 --- a/fs/cifs/connect.

[Patch v8 09/16] CIFS: SMBD: Implement function to send data via RDMA send

2017-11-22 Thread Long Li
From: Long Li The transport doesn't maintain send buffers or send queue for transferring payload via RDMA send. There is no data copy in the transport on send. Signed-off-by: Long Li --- fs/cifs/smbdirect.c | 246 fs/cifs/smbdirect.h | 5 +

[Patch v8 12/16] CIFS: SMBD: Upper layer performs SMB write via RDMA read through memory registration

2017-11-22 Thread Long Li
From: Long Li When sending I/O, if size is larger than rdma_readwrite_threshold we prepare to send SMB write packet for a RDMA read via memory registration. The actual I/O is done by remote peer through local RDMA hardware. Modify the relevant fields in the packet accordingly, and append a smbd_b

[Patch v8 11/16] CIFS: SMBD: Implement RDMA memory registration

2017-11-22 Thread Long Li
From: Long Li Memory registration is used for transferring payload via RDMA read or write. After I/O is done, memory registrations are recovered and reused. This process can be time consuming and is done in a work queue. Signed-off-by: Long Li --- fs/cifs/smbdirect.c | 421

[Patch v8 16/16] CIFS: SMBD: Disable signing on SMB direct transport

2017-11-22 Thread Long Li
From: Long Li Currently the CIFS SMB Direct implementation (experimental) doesn't properly support signing. Disable it when SMB Direct is in use for transport. Signing will be enabled in future after it is implemented. Signed-off-by: Long Li --- fs/cifs/connect.c | 8 fs/cifs/smb2pdu

[Patch v8 04/16] CIFS: SMBD: Implement function to destroy a SMB Direct connection

2017-11-22 Thread Long Li
From: Long Li Add function to tear down a SMB Direct connection. This is used by upper layer to free all SMB Direct connection and transport resources. Signed-off-by: Long Li --- fs/cifs/smbdirect.c | 16 fs/cifs/smbdirect.h | 3 +++ 2 files changed, 19 insertions(+) diff --

[Patch v8 06/16] CIFS: SMBD: Set SMB Direct maximum read or write size for I/O

2017-11-22 Thread Long Li
From: Long Li When connecting over SMB Direct, the transport negotiates its maximum I/O sizes with the server and determines how to choose to do RDMA send/recv vs read/write. Expose these maximum I/O sizes to upper layer so we will get the correct sized payloads. Signed-off-by: Long Li --- fs/

[PATCH] bcache: Fix bdev leak during backing device registering

2017-11-22 Thread 彭良彦
If the backing device hasn't been detached due to exceptional stop like power outage, the BDEV_STATE in super block can't be reset, it will fail to register this backing device in next time, but the opened bdev will be hold, this makes the backing device unaccessable because of FMODE_EXCL until reb

[Patch v8 15/16] CIFS: SMBD: Add SMB Direct debug counters

2017-11-22 Thread Long Li
From: Long Li For debugging and troubleshooting, export SMBDirect debug counters to /proc/fs/cifs/DebugData. Signed-off-by: Long Li --- fs/cifs/cifs_debug.c | 66 1 file changed, 66 insertions(+) diff --git a/fs/cifs/cifs_debug.c b/fs/cifs/

[Patch v8 10/16] CIFS: SMBD: Upper layer sends data via RDMA send

2017-11-22 Thread Long Li
From: Long Li With SMB Direct connected, use it for sending data via RDMA send. Signed-off-by: Long Li --- fs/cifs/transport.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/fs/cifs/transport.c b/fs/cifs/transport.c index e678307..4001842 100644 --- a/fs/cifs/trans

[Patch v8 14/16] CIFS: SMBD: Upper layer performs SMB read via RDMA write through memory registration

2017-11-22 Thread Long Li
From: Long Li If I/O size is larger than rdma_readwrite_threshold, use RDMA write for SMB read by specifying channel SMB2_CHANNEL_RDMA_V1 or SMB2_CHANNEL_RDMA_V1_INVALIDATE in the SMB packet, depending on SMB dialect used. Append a smbd_buffer_descriptor_v1 to the end of the SMB packet and fill i

[Patch v8 01/16] CIFS: SMBD: Upper layer connects to SMBDirect session

2017-11-22 Thread Long Li
From: Long Li When "rdma" is specified in the mount option, make CIFS connect to SMB Direct. Signed-off-by: Long Li --- fs/cifs/connect.c | 22 +++--- 1 file changed, 19 insertions(+), 3 deletions(-) diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c index 64be6f9..fafaecb 100

[Patch v8 13/16] CIFS: SMBD: Read correct returned data length for RDMA write (SMB read) I/O

2017-11-22 Thread Long Li
From: Long Li This patch is for preparing upper layer doing SMB read via RDMA write. When RDMA write is used for SMB read, the returned data length is in DataRemaining in the response packet. Reading it properly by adding a parameter to specifiy where the returned data length is. Add the defiti

[Patch v8 07/16] CIFS: SMBD: Implement function to receive data via RDMA receive

2017-11-22 Thread Long Li
From: Long Li On the receive path, the transport maintains receive buffers and a reassembly queue for transferring payload via RDMA recv. There is data copy in the transport on recv when it copies the payload to upper layer. The transport recognizes the RFC1002 header length use in the SMB upper

[PATCH 03/23] x86, kaiser: introduce user-mapped per-cpu areas

2017-11-22 Thread Dave Hansen
From: Dave Hansen These patches are based on work from a team at Graz University of Technology posted here: https://github.com/IAIK/KAISER The KAISER approach keeps two copies of the page tables: one for running in the kernel and one for running userspace. But, there are a few structures that

[PATCH 05/23] x86, kaiser: unmap kernel from userspace page tables (core patch)

2017-11-22 Thread Dave Hansen
From: Dave Hansen These patches are based on work from a team at Graz University of Technology: https://github.com/IAIK/KAISER . This work would not have been possible without their work as a starting point. KAISER is a countermeasure against side channel attacks against kernel virtual memory.

[Patch v8 00/16] CIFS: Implement SMB Direct protocol

2017-11-22 Thread Long Li
From: Long Li Starting with SMB2 dialect 3.0, Microsoft introduced SMB Direct transport protocol for transferring upper layer (SMB2) payload over RDMA via Infiniband, RoCE or iWARP. The prococol is published in [MS-SMBD] (https://msdn.microsoft.com/en-us/library/hh536346.aspx). Change log: v2: I

[PATCH 04/23] x86, kaiser: mark per-cpu data structures required for entry/exit

2017-11-22 Thread Dave Hansen
From: Dave Hansen These patches are based on work from a team at Graz University of Technology posted here: https://github.com/IAIK/KAISER The KAISER approach keeps two copies of the page tables: one for running in the kernel and one for running userspace. But, there are a few structures that

[PATCH 01/23] x86, kaiser: disable global pages by default with KAISER

2017-11-22 Thread Dave Hansen
From: Dave Hansen Global pages stay in the TLB across context switches. Since all contexts share the same kernel mapping, these mappings are marked as global pages so kernel entries in the TLB are not flushed out on a context switch. But, even having these entries in the TLB opens up something

Re: [PATCH 3/3] autofs - fix AT_NO_AUTOMOUNT not being honored

2017-11-22 Thread NeilBrown
On Wed, Nov 22 2017, Ian Kent wrote: > On 21/11/17 09:53, NeilBrown wrote: >> On Wed, May 10 2017, Ian Kent wrote: >> >>> The fstatat(2) and statx() calls can pass the flag AT_NO_AUTOMOUNT >>> which is meant to clear the LOOKUP_AUTOMOUNT flag and prevent triggering >>> of an automount by the call

Re: [PATCH AUTOSEL for 4.14 45/51] locking/refcounts, x86/asm: Use unique .text section for refcount exceptions

2017-11-22 Thread alexander . levin
On Wed, Nov 22, 2017 at 03:19:10PM -0800, Kees Cook wrote: >Hi, > >On Wed, Nov 22, 2017 at 2:25 PM, wrote: >> From: Kees Cook >> >> [ Upstream commit 564c9cc84e2adf8a6671c1937f0a9fe3da2a4b0e ] > >Thanks! I was going to recommend this too. Please also add: > >commit 39208aa7ecb7 ("locking/refcoun

Re: [PATCH v2 1/3] media: V3s: Add support for Allwinner CSI.

2017-11-22 Thread Yong
Hi, On Wed, 22 Nov 2017 10:45:26 +0100 Maxime Ripard wrote: > Hi, > > On Wed, Nov 22, 2017 at 09:33:06AM +0800, Yong wrote: > > > On Thu, Jul 27, 2017 at 01:01:35PM +0800, Yong Deng wrote: > > > > Allwinner V3s SoC have two CSI module. CSI0 is used for MIPI interface > > > > and CSI1 is used fo

Regression in TTM driver w/Linus' master

2017-11-22 Thread Laura Abbott
Hi, Fedora QA testing reported a panic when booting up VMs using qmeu vga drivers (https://paste.fedoraproject.org/paste/498yRWTCJv2LKIrmj4EliQ) [ 30.108507] [ cut here ] [ 30.108920] kernel BUG at ./include/linux/gfp.h:408! [ 30.109356] invalid opcode: [#1] S

Re: [PATCH] hwmon: (pmbus/lm25066) Swap low/high current coefficients for LM5066(i)

2017-11-22 Thread Guenter Roeck
Hi Rob, On 11/22/2017 03:39 PM, Rob Lippert wrote: On Wed, Nov 22, 2017 at 3:28 PM, Guenter Roeck wrote: On Wed, Nov 22, 2017 at 02:07:28PM -0800, Robert Lippert wrote: The _L low-current mode coefficient values should reference the datasheet rows with CL=VDD but it seems were mistakenly pul

Re: [PATCH v7 0/4] Add the ability to do BPF directed error injection

2017-11-22 Thread Alexei Starovoitov
On Wed, Nov 22, 2017 at 04:23:29PM -0500, Josef Bacik wrote: > This is hopefully the final version, I've addressed the comment by Igno and > added his Acks. > > v6->v7: > - moved the opt-in macro to bpf.h out of kprobes.h. Thanks Josef! All patches look great to me. We'll probably take them all i

RE: Re: [PATCH 1/4] rk3399_dmc: Fix line continuation format

2017-11-22 Thread MyungJoo Ham
> On Wed, 2017-11-22 at 14:13 +0900, Chanwoo Choi wrote: > > On 2017년 11월 17일 00:27, Joe Perches wrote: > > > Line continuations with excess spacing causes unexpected output. > > > > > > Signed-off-by: Joe Perches > > > --- > > > drivers/devfreq/rk3399_dmc.c | 4 ++-- > > > 1 file changed, 2 ins

Re: Regression in TTM driver w/Linus' master

2017-11-22 Thread Adam Williamson
On Wed, 2017-11-22 at 17:17 -0800, Laura Abbott wrote: > Hi, > > Fedora QA testing reported a panic when booting up VMs > using qmeu vga drivers > (https://paste.fedoraproject.org/paste/498yRWTCJv2LKIrmj4EliQ) > > [ 30.108507] [ cut here ] > [ 30.108920] kernel BUG at

[PATCH] staging: rtl8188eu: Fix private WEXT IOCTL calls

2017-11-22 Thread ishraq . i . ashraf
From: Ishraq Ibne Ashraf Commit 8bfb36766064 ("wireless: wext: remove ndo_do_ioctl fallback") breaks private WEXT IOCTL calls of this driver as these are not invoked through ndo_do_ioctl interface anymore. As a result hostapd stops working with this driver. In this patch this problem is solved b

Re: [PATCH] au0828: fix use-after-free at USB probing

2017-11-22 Thread Gustavo A. R. Silva
Hi Andrey, I have successfully installed and tested syzkaller with QEMU. Can you please tell me how to reproduce this bug or share with me the full crash report? Also, can you point me out to the PoC file? Much appreciated Thank you! -- Gustavo A. R. Silva Quoting Andrey Konovalov : On

Re: [PATCH 00/62] XArray November 2017 Edition

2017-11-22 Thread Dave Chinner
On Wed, Nov 22, 2017 at 01:06:37PM -0800, Matthew Wilcox wrote: > From: Matthew Wilcox > > I've lost count of the number of times I've posted the XArray before, > so time for a new numbering scheme. Here're two earlier versions, > https://lkml.org/lkml/2017/3/17/724 > https://lwn.net/Articles/71

Re: [PATCH 3/3] autofs - fix AT_NO_AUTOMOUNT not being honored

2017-11-22 Thread Ian Kent
On 23/11/17 08:47, NeilBrown wrote: > On Wed, Nov 22 2017, Ian Kent wrote: > >> On 21/11/17 09:53, NeilBrown wrote: >>> On Wed, May 10 2017, Ian Kent wrote: >>> The fstatat(2) and statx() calls can pass the flag AT_NO_AUTOMOUNT which is meant to clear the LOOKUP_AUTOMOUNT flag and preven

Re: [PATCH 1/4] rk3399_dmc: Fix line continuation format

2017-11-22 Thread Chanwoo Choi
On 2017년 11월 23일 10:21, MyungJoo Ham wrote: >> On Wed, 2017-11-22 at 14:13 +0900, Chanwoo Choi wrote: >>> On 2017년 11월 17일 00:27, Joe Perches wrote: Line continuations with excess spacing causes unexpected output. Signed-off-by: Joe Perches --- drivers/devfreq/rk3399_dmc.

Re: 492b95e597 ("rcuperf: Set more user-friendly defaults"): WARNING: CPU: 0 PID: 1 at arch/x86/kernel/smp.c:128 native_smp_send_reschedule

2017-11-22 Thread Fengguang Wu
Hi Paul, On Wed, Nov 22, 2017 at 08:37:32PM +0800, Fengguang Wu wrote: Hi Paul, On Tue, Oct 24, 2017 at 06:25:13AM -0700, Paul E. McKenney wrote: On Tue, Oct 24, 2017 at 04:49:52AM +0200, Fengguang Wu wrote: Greetings, 0day kernel testing robot got the below dmesg and the first bad commit is

Re: [PATCH 01/11] Initialize the mapping of KASan shadow memory

2017-11-22 Thread Liuwenliang (Abbott Liu)
On Nov 23, 2017 20:30 Marc Zyngier [mailto:marc.zyng...@arm.com] wrote: >Please define both PAR accessors. Yes, I know the 32bit version is not >used yet, but it doesn't hurt to make it visible. Thanks for your review. I'm going to change it in the new version. Here is the code I tested on vexp

Re: Regression in TTM driver w/Linus' master

2017-11-22 Thread Dave Airlie
On 23 November 2017 at 11:17, Laura Abbott wrote: > Hi, > > Fedora QA testing reported a panic when booting up VMs > using qmeu vga drivers > (https://paste.fedoraproject.org/paste/498yRWTCJv2LKIrmj4EliQ) > > [ 30.108507] [ cut here ] > [ 30.108920] kernel BUG at ./incl

linux-next: build warning after merge of the akpm-current tree

2017-11-22 Thread Stephen Rothwell
Hi Andrew, After merging the akpm-current tree, today's linux-next build (arm multi_v7_defconfig) produced this warning: fs/super.c: In function 'sget_userns': fs/super.c:521:2: warning: ignoring return value of 'register_shrinker', declared with attribute warn_unused_result [-Wunused-result]

Re: [PATCH 1/4] rk3399_dmc: Fix line continuation format

2017-11-22 Thread Joe Perches
On Thu, 2017-11-23 at 10:45 +0900, Chanwoo Choi wrote: > On 2017년 11월 23일 10:21, MyungJoo Ham wrote: > > > On Wed, 2017-11-22 at 14:13 +0900, Chanwoo Choi wrote: > > > > On 2017년 11월 17일 00:27, Joe Perches wrote: > > > > > Line continuations with excess spacing causes unexpected output. > > > > >

[lkp-robot] [fw_cfg] d5daa79dd1: BUG:unable_to_handle_kernel

2017-11-22 Thread kernel test robot
FYI, we noticed the following commit (built with gcc-5): commit: d5daa79dd1c013fb9dbec70c7e371eed1feb09db ("fw_cfg: do DMA read operation") https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git master in testcase: boot on test machine: qemu-system-x86_64 -enable-kvm -cpu Nehalem -sm

Re: [PATCH] checkpatch: Add a warning for log messages that don't end in a line feed

2017-11-22 Thread Joe Perches
On Wed, 2017-11-22 at 13:55 -0700, Logan Gunthorpe wrote: > Check for lines with a log function using a $logLineFeedFunctions > expression which is similar to the existing $logFunctions expression > except we don't include MODULE and seq_ functions. > > Once an appropriate log function is found, m

Re: [PATCH 1/4] rk3399_dmc: Fix line continuation format

2017-11-22 Thread Chanwoo Choi
On 2017년 11월 23일 11:07, Joe Perches wrote: > On Thu, 2017-11-23 at 10:45 +0900, Chanwoo Choi wrote: >> On 2017년 11월 23일 10:21, MyungJoo Ham wrote: On Wed, 2017-11-22 at 14:13 +0900, Chanwoo Choi wrote: > On 2017년 11월 17일 00:27, Joe Perches wrote: >> Line continuations with excess spaci

Re: [PATCH 1/4] rk3399_dmc: Fix line continuation format

2017-11-22 Thread Joe Perches
On Thu, 2017-11-23 at 11:12 +0900, Chanwoo Choi wrote: > On 2017년 11월 23일 11:07, Joe Perches wrote: > > On Thu, 2017-11-23 at 10:45 +0900, Chanwoo Choi wrote: > > > On 2017년 11월 23일 10:21, MyungJoo Ham wrote: > > > > > On Wed, 2017-11-22 at 14:13 +0900, Chanwoo Choi wrote: > > > > > > On 2017년 11월

Re: [PATCH 3/3] autofs - fix AT_NO_AUTOMOUNT not being honored

2017-11-22 Thread NeilBrown
On Thu, Nov 23 2017, Ian Kent wrote: > > Hey Neil, I'm looking at this again because RH QE have complained about > a regression test failing with a kernel that has this change. > > Maybe I'm just dumb but I though a "find " > would, well, just look at the contents below but an > strace shows tha

Re: [PATCH 1/4] rk3399_dmc: Fix line continuation format

2017-11-22 Thread Chanwoo Choi
On 2017년 11월 23일 11:18, Joe Perches wrote: > On Thu, 2017-11-23 at 11:12 +0900, Chanwoo Choi wrote: >> On 2017년 11월 23일 11:07, Joe Perches wrote: >>> On Thu, 2017-11-23 at 10:45 +0900, Chanwoo Choi wrote: On 2017년 11월 23일 10:21, MyungJoo Ham wrote: >> On Wed, 2017-11-22 at 14:13 +0900, Cha

Re: [PATCH 3/3] autofs - fix AT_NO_AUTOMOUNT not being honored

2017-11-22 Thread Ian Kent
On 23/11/17 09:43, Ian Kent wrote: > On 23/11/17 08:47, NeilBrown wrote: >> On Wed, Nov 22 2017, Ian Kent wrote: >> >>> On 21/11/17 09:53, NeilBrown wrote: On Wed, May 10 2017, Ian Kent wrote: > The fstatat(2) and statx() calls can pass the flag AT_NO_AUTOMOUNT > which is meant to

Re: [PATCH 1/4] rk3399_dmc: Fix line continuation format

2017-11-22 Thread Joe Perches
On Thu, 2017-11-23 at 11:23 +0900, Chanwoo Choi wrote: > On 2017년 11월 23일 11:18, Joe Perches wrote: > > never break user-visible strings such as > > printk messages, because that breaks the ability to grep for them > > So, I suggested "Or, we better to modify the error message within 80 char.". R

Re: [PATCH V5 10/12] clk: sprd: add clocks support for SC9860

2017-11-22 Thread kbuild test robot
Hi Chunyan, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on clk/clk-next] [also build test WARNING on v4.14 next-20171122] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci

Re: [PATCH 1/4] rk3399_dmc: Fix line continuation format

2017-11-22 Thread Chanwoo Choi
On 2017년 11월 23일 11:29, Joe Perches wrote: > On Thu, 2017-11-23 at 11:23 +0900, Chanwoo Choi wrote: >> On 2017년 11월 23일 11:18, Joe Perches wrote: >>> never break user-visible strings such as >>> printk messages, because that breaks the ability to grep for them >> >> So, I suggested "Or, we better t

Re: [PATCH 1/4] rk3399_dmc: Fix line continuation format

2017-11-22 Thread Joe Perches
On Thu, 2017-11-23 at 11:35 +0900, Chanwoo Choi wrote: > On 2017년 11월 23일 11:29, Joe Perches wrote: > > On Thu, 2017-11-23 at 11:23 +0900, Chanwoo Choi wrote: > > > On 2017년 11월 23일 11:18, Joe Perches wrote: > > > > never break user-visible strings such as > > > > printk messages, because that brea

linux-next: Tree for Nov 23

2017-11-22 Thread Stephen Rothwell
Hi all, Please do not add any v4.16 material to your linux-next included trees until v4.15-rc1 has been released. Changes since 20171122: Non-merge commits (relative to Linus' tree): 847 874 files changed, 20738 insertions(+), 7941 dele

Re: [PATCH 00/62] XArray November 2017 Edition

2017-11-22 Thread Matthew Wilcox
On Thu, Nov 23, 2017 at 12:25:01PM +1100, Dave Chinner wrote: > On Wed, Nov 22, 2017 at 01:06:37PM -0800, Matthew Wilcox wrote: > > From: Matthew Wilcox > > > > I've lost count of the number of times I've posted the XArray before, > > so time for a new numbering scheme. Here're two earlier versi

Re: [PATCH 3/3] autofs - fix AT_NO_AUTOMOUNT not being honored

2017-11-22 Thread Ian Kent
On 23/11/17 10:21, NeilBrown wrote: > On Thu, Nov 23 2017, Ian Kent wrote: > >> >> Hey Neil, I'm looking at this again because RH QE have complained about >> a regression test failing with a kernel that has this change. >> >> Maybe I'm just dumb but I though a "find " >> would, well, just look at

Re: kernel CI: printk loglevels in kernel boot logs?

2017-11-22 Thread Sergey Senozhatsky
On (11/22/17 20:52), Fengguang Wu wrote: [..] > > well, I think that that "consoles_format=syslog" command line parameter > > will be enabled only by those who actually want to have it - Fengguang's > > build robot and kernelCI (+ may be more setups). so I'd probably assume > > there are low risks

[PATCH V2] selftest/vm: Add test case for mmap across 128TB boundary.

2017-11-22 Thread Aneesh Kumar K.V
From: "Kirill A. Shutemov" This patch add a self-test that covers a few corner cases of the interface. Signed-off-by: Kirill A. Shutemov Signed-off-by: Aneesh Kumar K.V --- Changes from V1: * Add the test to run_vmtests script tools/testing/selftests/vm/Makefile | 1 + tools/testi

Re: [PATCH 3/3] autofs - fix AT_NO_AUTOMOUNT not being honored

2017-11-22 Thread NeilBrown
On Thu, Nov 23 2017, Ian Kent wrote: > On 23/11/17 08:47, NeilBrown wrote: >> On Wed, Nov 22 2017, Ian Kent wrote: >> >>> On 21/11/17 09:53, NeilBrown wrote: On Wed, May 10 2017, Ian Kent wrote: > The fstatat(2) and statx() calls can pass the flag AT_NO_AUTOMOUNT > which is mean

Re: [PATCH 3/3] autofs - fix AT_NO_AUTOMOUNT not being honored

2017-11-22 Thread Ian Kent
On 23/11/17 10:46, Ian Kent wrote: > On 23/11/17 10:21, NeilBrown wrote: >> On Thu, Nov 23 2017, Ian Kent wrote: >> >>> >>> Hey Neil, I'm looking at this again because RH QE have complained about >>> a regression test failing with a kernel that has this change. >>> >>> Maybe I'm just dumb but I tho

[PATCH 2/2] i2c: fix piix4 aux port number

2017-11-22 Thread Andrew Cooks
Let the aux port use port number one (not zero), to match the AMD documentation and enable mapping ACPI _ADR to port number. This fixes ACPI-based enumeration of I2C slave peripherals that are defined for the aux SMBus port. Signed-off-by: Andrew Cooks --- drivers/i2c/busses/i2c-piix4.c | 2 +-

[PATCH 1/2] i2c: add ACPI support for i2c-piix4

2017-11-22 Thread Andrew Cooks
This enables the i2c-piix4 SMBus controller driver to enumerate I2C slave devices using ACPI. It builds on the related I2C mux device work in commit 8eb5c87a92c0 ("i2c: add ACPI support for I2C mux ports") Signed-off-by: Andrew Cooks --- drivers/i2c/busses/i2c-piix4.c | 6 ++ 1 file changed,

Re: kernel CI: printk loglevels in kernel boot logs?

2017-11-22 Thread Fengguang Wu
On Thu, Nov 23, 2017 at 11:59:57AM +0900, Sergey Senozhatsky wrote: On (11/22/17 20:52), Fengguang Wu wrote: [..] > well, I think that that "consoles_format=syslog" command line parameter > will be enabled only by those who actually want to have it - Fengguang's > build robot and kernelCI (+ may

Re: [PATCH 11/23] x86, kaiser: map entry stack variables

2017-11-22 Thread Andy Lutomirski
On Wed, Nov 22, 2017 at 4:34 PM, Dave Hansen wrote: > > From: Dave Hansen > > There are times where the kernel is entered but there is not a > safe stack, like at SYSCALL entry. To obtain a safe stack, the > per-cpu variables 'rsp_scratch' and 'cpu_current_top_of_stack' > are used to save the ol

[PATCH] davinci: vpif_capture: add NULL check on devm_kzalloc return value

2017-11-22 Thread Gustavo A. R. Silva
Check return value from call to devm_kzalloc() in order to prevent a NULL pointer dereference. This issue was detected with the help of Coccinelle. Fixes: 4a5f8ae50b66 ("[media] davinci: vpif_capture: get subdevs from DT when available") Signed-off-by: Gustavo A. R. Silva --- drivers/media/pla

We really want to confirm whether you are terminal sick.

2017-11-22 Thread CENTRAL BANK OF NIGERIA
-- Dear Sir/Madam, We are hereby to confirmed whether it is true that you are terminal sick and you empower two gentlemen to came to our office to stand and claim your contract/inheritance funds due to your health condition, as they stand as Next-Of-Kin to you. Further more they provide bank

Re: [PATCH 3/3] autofs - fix AT_NO_AUTOMOUNT not being honored

2017-11-22 Thread Ian Kent
On 23/11/17 11:04, NeilBrown wrote: > On Thu, Nov 23 2017, Ian Kent wrote: > >> On 23/11/17 08:47, NeilBrown wrote: >>> On Wed, Nov 22 2017, Ian Kent wrote: >>> On 21/11/17 09:53, NeilBrown wrote: > On Wed, May 10 2017, Ian Kent wrote: > >> The fstatat(2) and statx() calls can pas

Re: [PATCH V2] selftest/vm: Add test case for mmap across 128TB boundary.

2017-11-22 Thread Anshuman Khandual
On 11/23/2017 08:33 AM, Aneesh Kumar K.V wrote: > From: "Kirill A. Shutemov" > > This patch add a self-test that covers a few corner cases of the interface. > > Signed-off-by: Kirill A. Shutemov > Signed-off-by: Aneesh Kumar K.V > --- > > Changes from V1: > * Add the test to run_vmtests scrip

[PATCH] mfd: sm501: Add NULL check on devm_kzalloc return value

2017-11-22 Thread Gustavo A. R. Silva
Check return value from call to devm_kzalloc() in order to prevent a NULL pointer dereference. This issue was detected with the help of Coccinelle. Fixes: b2e6392f ("i2c: gpio: Convert to use descriptors") Signed-off-by: Gustavo A. R. Silva --- drivers/mfd/sm501.c | 3 +++ 1 file changed, 3

Re: [PATCH 1/4] cpufreq: Clean up cpufreq_parse_governor()

2017-11-22 Thread Viresh Kumar
On 23-11-17, 01:23, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > Drop an unnecessary local variable from cpufreq_parse_governor() > and rearrange the code in there to make it easier to follow. > > Signed-off-by: Rafael J. Wysocki > --- > drivers/cpufreq/cpufreq.c | 32 +

Re: [PATCH 2/4] cpufreq: Pass policy pointer to cpufreq_parse_governor()

2017-11-22 Thread Viresh Kumar
On 23-11-17, 01:24, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > Pass policy pointer to cpufreq_parse_governor() instead of passing > pointers to two members of it so as to make the code slightly more > straightforward. > > Signed-off-by: Rafael J. Wysocki > --- > drivers/cpufreq/cpu

Re: [PATCH v3 03/16] phy: qcom-qmp: Power-on PHY before initialization

2017-11-22 Thread Manu Gautam
Hi, On 11/22/2017 11:33 PM, Stephen Boyd wrote: > On 11/21/2017 01:23 AM, Manu Gautam wrote: >> PHY must be powered on before turning ON clocks and >> attempting to initialize it. Driver is exposing >> separate init and power_on routines for this. >> Apparently USB dwc3 core driver performs power-

Re: [PATCH 3/4] cpufreq: Fix governor module removal race

2017-11-22 Thread Viresh Kumar
On 23-11-17, 01:29, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > It is possible to remove a cpufreq governor module after > cpufreq_parse_governor() has returned success in > store_scaling_governor() and before cpufreq_set_policy() > acquires a reference to it, because the governor list

Re: [PATCH 4/4] cpufreq: Drop pointless return statement

2017-11-22 Thread Viresh Kumar
On 23-11-17, 01:30, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > Drop a pointless return statement from cpufreq_unregister_governor(). > > Signed-off-by: Rafael J. Wysocki > --- > drivers/cpufreq/cpufreq.c |1 - > 1 file changed, 1 deletion(-) > > Index: linux-pm/drivers/cpufreq

Re: [PATCH v3 10/16] phy: qcom-qmp: Move register offsets to header file

2017-11-22 Thread Manu Gautam
Hi, On 11/22/2017 10:56 PM, Stephen Boyd wrote: > On 11/21/2017 01:23 AM, Manu Gautam wrote: >> New revision (v3) of QMP PHY uses different offsets >> for almost all of the registers. Hence, move these >> definitions to header file so that updated offsets >> can be added for QMP v3. >> >> Signed-

Re: [PATCH 05/23] x86, kaiser: unmap kernel from userspace page tables (core patch)

2017-11-22 Thread Andy Lutomirski
On Wed, Nov 22, 2017 at 4:34 PM, Dave Hansen wrote: > > These actions when dealing with a user address *and* the > PGD has _PAGE_USER set. That way, in-kernel users of low addresses > typically used by userspace are not accidentally poisoned. This seems sane. > +/* > + * Take a PGD location (pg

[git pull] drm for v4.15 (fixes/cleanups/one small feature)

2017-11-22 Thread Dave Airlie
Hi Linus, This is just some bits and pieces for the second half of the merge window, 1. Remove the MSM dt-bindings file Rob managed to push in the previous pull. 2. Add a property/edid quirk to denote HMD devices, I had these hanging around for a few weeks and Keith had done some work on them, th

Re: [PATCH net] net: thunderx: Fix TCP/UDP checksum offload for IPv6 pkts

2017-11-22 Thread Sunil Kovvuri
On Wed, Nov 22, 2017 at 9:27 PM, Eric Dumazet wrote: > On Wed, 2017-11-22 at 15:37 +0300, Aleksey Makarov wrote: >> From: Sunil Goutham >> >> This fixes a previous patch which missed some changes >> and due to which L3 checksum offload was getting enabled >> for IPv6 pkts. And HW is dropping thes

Re: [PATCH 4/6] mmc: tmio: move mmc_host_ops to struct tmio_mmc_host from static data

2017-11-22 Thread Masahiro Yamada
2017-11-21 5:48 GMT+09:00 Wolfram Sang : > >> + struct mmc_host_ops mmc_host_ops; > > Just came to think of it: maybe a shorter name? > > host->ops > > is still nicely readable, I'd think... > I just thought it should be clear which ops, but nobody would be confused with "dma_ops". OK, I

Re: [PATCH v3] kbuild: Set KBUILD_CFLAGS before incl. arch Makefile

2017-11-22 Thread Masahiro Yamada
Hi. 2017-11-18 13:09 GMT+09:00 Masahiro Yamada : > 2017-11-16 5:42 GMT+09:00 Nick Desaulniers : >> From: Chris Fries >> >> Set the clang KBUILD_CFLAGS up before including arch/ Makefiles, >> so that ld-options (etc.) can work correctly. >> >> This fixes errors with clang such as ld-options trying

Re: [PATCH 3/5] media: i2c: Add TDA1997x HDMI receiver driver

2017-11-22 Thread Tim Harvey
On Mon, Nov 20, 2017 at 7:39 AM, Hans Verkuil wrote: > Hi Tim, > > Some more review comments: > > On 11/09/2017 07:45 PM, Tim Harvey wrote: >> Add support for the TDA1997x HDMI receivers. >> + */ >> +struct color_matrix_coefs { >> + const char *name; >> + /* Input offsets */ >> + s16

<    5   6   7   8   9   10   11   >