Re: [PATCH 3/6 v3] mmc: sdhci-acpi: Handle return value of platform_get_irq

2017-11-22 Thread Adrian Hunter
On 19/11/17 06:52, Arvind Yadav wrote: > platform_get_irq() can fail here and we must check its return value. > > Signed-off-by: Arvind Yadav Acked-by: Adrian Hunter > --- > changes in v2 : > Add failure case '<= 0' instead of '< 0'. IRQ0 is not valid. > changes in v3 : >

Re: [PATCH v1 3/9] perf util: Reconstruct rblist for supporting per-thread shadow stats

2017-11-22 Thread Jin, Yao
On 11/22/2017 4:32 PM, Jiri Olsa wrote: On Wed, Nov 22, 2017 at 02:57:12PM +0800, Jin, Yao wrote: On 11/22/2017 2:31 PM, Ravi Bangoria wrote: On 11/20/2017 08:13 PM, Jin Yao wrote: @@ -76,6 +97,17 @@ static struct rb_node *saved_value_new(struct rblist *rblist __maybe_unused,   retur

[PATCH] sched/tracing: Fix task state recording/printout

2017-11-22 Thread Thomas Gleixner
The recent conversion of the task state recording to use task_state_index() broke the sched_switch tracepoint task state output. task_state_index() returns surprisingly an index (0-7) which is then printed with __print_flags() applying bitmasks. Not really working and resulting in weird states lik

Re: [PATCH v1 4/9] perf util: Update and print per-thread shadow stats

2017-11-22 Thread Jin, Yao
On 11/22/2017 4:37 PM, Jiri Olsa wrote: On Wed, Nov 22, 2017 at 11:10:37AM +0800, Jin, Yao wrote: On 11/21/2017 11:18 PM, Jiri Olsa wrote: On Mon, Nov 20, 2017 at 10:43:39PM +0800, Jin Yao wrote: SNIP if (num == 0) diff --git a/tools/perf/util/stat.c b/tools/perf/util/stat.c inde

Re: [PATCH v2 03/18] x86/dumpstack: Add get_stack_info() support for the SYSENTER stack

2017-11-22 Thread Borislav Petkov
On Tue, Nov 21, 2017 at 08:43:58PM -0800, Andy Lutomirski wrote: > get_stack_info() doesn't currently know about the SYSENTER stack, so > unwinding will fail if we entered the kernel on the SYSENTER stack > and haven't fully switched off. Teach get_stack_info() about the > SYSENTER stack. > > Wit

Re: [PATCH] mm: migrate: fix an incorrect call of prep_transhuge_page()

2017-11-22 Thread Zi Yan
On 22 Nov 2017, at 5:14, Michal Hocko wrote: > On Wed 22-11-17 10:35:10, Michal Hocko wrote: > [...] >> Moreover I am not really sure this is really working properly. Just look >> at the split_huge_page. It moves all the tail pages to the LRU list >> while migrate_pages has a list of pages to migr

Re: [migration_cpu_stop] WARNING: CPU: 0 PID: 11 at kernel/sched/core.c:1187 set_task_cpu+0x257/0x6b6

2017-11-22 Thread Fengguang Wu
Hi Paul, On Tue, Nov 21, 2017 at 08:13:35AM -0800, Paul E. McKenney wrote: On Tue, Nov 21, 2017 at 09:51:01PM +0800, Fengguang Wu wrote: On Tue, Nov 21, 2017 at 02:34:03PM +0100, Peter Zijlstra wrote: >On Tue, Nov 21, 2017 at 08:04:20PM +0800, Fengguang Wu wrote: >>Hello, >> >>FYI this happens

[PATCH] mm/hugetlb: Fix NULL-pointer dereference on 5-level paging machine

2017-11-22 Thread Kirill A. Shutemov
I've made mistake during converting hugetlb code to 5-level paging: in huge_pte_alloc() we have to use p4d_alloc(), not p4d_offset(). Otherwise it leads to crash -- NULL-pointer dereference in pud_alloc() if p4d table is not yet allocated. It only can happen in 5-level paging mode. In 4-level pagi

Re: [PATCH 23/30] [media] atomisp: deprecate pci_get_bus_and_slot()

2017-11-22 Thread Alan Cox
On Wed, 2017-11-22 at 00:31 -0500, Sinan Kaya wrote: > pci_get_bus_and_slot() is restrictive such that it assumes domain=0 > as > where a PCI device is present. This restricts the device drivers to > be > reused for other domain numbers. The ISP v2 will always been in domain 0. Alan

Re: [tegra186]: emmc resume failing after booting from snapshot image

2017-11-22 Thread Pintu Kumar
On Wed, Nov 22, 2017 at 4:10 PM, Jon Hunter wrote: > Hi Pintu, > > I think that the appropriate place to ask about this issue is on the TX2 > forum [0]. Someone should be able to help you there. > Hello Jon, Yes I raised my query there almost 1 week back here. https://devtalk.nvidia.com/default/t

Re: [PATCH] mm: migrate: fix an incorrect call of prep_transhuge_page()

2017-11-22 Thread Zi Yan
On 22 Nov 2017, at 7:13, Zi Yan wrote: > On 22 Nov 2017, at 5:14, Michal Hocko wrote: > >> On Wed 22-11-17 10:35:10, Michal Hocko wrote: >> [...] >>> Moreover I am not really sure this is really working properly. Just look >>> at the split_huge_page. It moves all the tail pages to the LRU list >>>

[PATCH RT] Revert "memcontrol: Prevent scheduling while atomic in cgroup code"

2017-11-22 Thread Steven Rostedt
From: "Steven Rostedt (VMware)" The commit "memcontrol: Prevent scheduling while atomic in cgroup code" fixed this issue: refill_stock() get_cpu_var() drain_stock() res_counter_uncharge() res_counter_uncharge_until() spin

Re: [RFC PATCH for 4.15 v12 00/22] Restartable sequences and CPU op vector

2017-11-22 Thread Mathieu Desnoyers
- On Nov 21, 2017, at 5:59 PM, Thomas Gleixner t...@linutronix.de wrote: > On Tue, 21 Nov 2017, Mathieu Desnoyers wrote: >> - On Nov 21, 2017, at 12:21 PM, Andi Kleen a...@firstfloor.org wrote: >> >> > On Tue, Nov 21, 2017 at 09:18:38AM -0500, Mathieu Desnoyers wrote: >> >> Hi, >> >> >>

Re: [PATCH] mm/hugetlb: Fix NULL-pointer dereference on 5-level paging machine

2017-11-22 Thread Vlastimil Babka
On 11/22/2017 01:19 PM, Kirill A. Shutemov wrote: > I've made mistake during converting hugetlb code to 5-level paging: > in huge_pte_alloc() we have to use p4d_alloc(), not p4d_offset(). > Otherwise it leads to crash -- NULL-pointer dereference in pud_alloc() > if p4d table is not yet allocated. >

Re: 492b95e597 ("rcuperf: Set more user-friendly defaults"): WARNING: CPU: 0 PID: 1 at arch/x86/kernel/smp.c:128 native_smp_send_reschedule

2017-11-22 Thread Fengguang Wu
Hi Paul, On Tue, Oct 24, 2017 at 06:25:13AM -0700, Paul E. McKenney wrote: On Tue, Oct 24, 2017 at 04:49:52AM +0200, Fengguang Wu wrote: Greetings, 0day kernel testing robot got the below dmesg and the first bad commit is https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git mast

Re: kernel CI: printk loglevels in kernel boot logs?

2017-11-22 Thread Sergey Senozhatsky
On (11/22/17 12:34), Petr Mladek wrote: [..] > > > > This is espeically useful when ingesting kernel logs into advanced > > > > search/analytics frameworks (I'm playing with and ELK stack: Elastic > > > > Search, Logstash, Kibana). [..] > To make it clear. I understand that "show_loglevel" command

Re: [PATCHv3 2/2] x86/selftests: Add test for mapping placement for 5-level paging

2017-11-22 Thread Kirill A. Shutemov
On Wed, Nov 22, 2017 at 05:06:27PM +0530, Aneesh Kumar K.V wrote: > "Kirill A. Shutemov" writes: > > > On Wed, Nov 22, 2017 at 11:11:36AM +0530, Aneesh Kumar K.V wrote: > >> "Kirill A. Shutemov" writes: > >> > >> > With 5-level paging, we have 56-bit virtual address space available for > >> > u

RE: [RFC PATCH v6 2/3] ACPI / EC: Add event detection support for noirq stages

2017-11-22 Thread Zhang, Rui
> -Original Message- > From: linux-acpi-ow...@vger.kernel.org [mailto:linux-acpi- > ow...@vger.kernel.org] On Behalf Of Lv Zheng > Sent: Friday, September 29, 2017 10:50 AM > To: Wysocki, Rafael J ; Rafael J . Wysocki > ; Brown, Len > Cc: Zheng, Lv ; Lv Zheng ; linux- > ker...@vger.kerne

[PATCH] arm64: pgd: Mark pgd_cache as __ro_after_init

2017-11-22 Thread Jinbum Park
pgd_cache is setup once while init stage and never changed after that, so it is good candidate for __ro_after_init Signed-off-by: Jinbum Park --- arch/arm64/mm/pgd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/mm/pgd.c b/arch/arm64/mm/pgd.c index 371c5f0..051e7

Re: [PATCH] mm/hugetlb: Fix NULL-pointer dereference on 5-level paging machine

2017-11-22 Thread Michal Hocko
On Wed 22-11-17 15:19:21, Kirill A. Shutemov wrote: > I've made mistake during converting hugetlb code to 5-level paging: > in huge_pte_alloc() we have to use p4d_alloc(), not p4d_offset(). > Otherwise it leads to crash -- NULL-pointer dereference in pud_alloc() > if p4d table is not yet allocated.

Re: Failed IRQ assignment for INT0002 on Braswell

2017-11-22 Thread Oleksandr Natalenko
Hi, Hans. On středa 22. listopadu 2017 11:48:50 CET Hans de Goede wrote: > /* snip */ > This should be fixed by: > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/ke > rnel/irq?id=382bd4de61827dbaaf5fb4fb7b1f4be4a86505e7 > > Which is in 4.13, but the trigger-type does

Re: Xen PV seems to be broken on Linus' tree

2017-11-22 Thread Juergen Gross
On 22/11/17 05:46, Andy Lutomirski wrote: > On Tue, Nov 21, 2017 at 8:11 PM, Andy Lutomirski wrote: >> On Tue, Nov 21, 2017 at 7:33 PM, Andy Lutomirski wrote: >>> I'm doing: >>> >>> /usr/bin/qemu-system-x86_64 -machine accel=kvm:tcg -cpu host -net none >>> -nographic -kernel xen-4.8.2 -initrd './

RE: [RFC PATCH v6 1/3] ACPI / EC: Fix possible driver order issue by moving EC event handling earlier

2017-11-22 Thread Zhang, Rui
> -Original Message- > From: linux-acpi-ow...@vger.kernel.org [mailto:linux-acpi- > ow...@vger.kernel.org] On Behalf Of Lv Zheng > Sent: Friday, September 29, 2017 10:50 AM > To: Wysocki, Rafael J ; Rafael J . Wysocki > ; Brown, Len > Cc: Zheng, Lv ; Lv Zheng ; linux- > ker...@vger.kerne

Re: kernel CI: printk loglevels in kernel boot logs?

2017-11-22 Thread Fengguang Wu
On Wed, Nov 22, 2017 at 09:38:21PM +0900, Sergey Senozhatsky wrote: On (11/22/17 12:34), Petr Mladek wrote: [..] > > > This is espeically useful when ingesting kernel logs into advanced > > > search/analytics frameworks (I'm playing with and ELK stack: Elastic > > > Search, Logstash, Kibana). [

[PATCH net] net: thunderx: Fix TCP/UDP checksum offload for IPv6 pkts

2017-11-22 Thread Aleksey Makarov
From: Sunil Goutham This fixes a previous patch which missed some changes and due to which L3 checksum offload was getting enabled for IPv6 pkts. And HW is dropping these pkts as it assumes the pkt is IPv4 when IP csum offload is set in the SQ descriptor. Fixes: 494fd005 ("net: thunderx: Ena

Re: [PATCH 21/30] xen: deprecate pci_get_bus_and_slot()

2017-11-22 Thread Juergen Gross
On 22/11/17 06:31, Sinan Kaya wrote: > pci_get_bus_and_slot() is restrictive such that it assumes domain=0 as > where a PCI device is present. This restricts the device drivers to be > reused for other domain numbers. > > Use pci_get_domain_bus_and_slot() with a domain number of 0 where we can't >

[PATCH v4] checkpatch: allow long lines containing URL

2017-11-22 Thread Andreas Brauchli
Allow lines with URL to exceed the 80 char limit for improved interaction in adaption to ongoing but undocumented practice. $ git grep -E '://\S{77}.*' -- '*.[ch]' As per RFC3986 [1], the URL format allows for alphanum, +, - and . characters in the scheme before the separator :// as long as it st

Re: [PATCH v3] checkpatch: allow URL >80 chars

2017-11-22 Thread Andreas Brauchli
On Die, 2017-11-21 at 17:05 -0800, Joe Perches wrote: > On Tue, 2017-11-21 at 22:50 +0100, Andreas Brauchli wrote: > > Allow URL to exceed the 80 char limit for improved interaction in > > adaption to ongoing but undocumented practice. > > > > $ git grep -E '://\S{77}.*' -- '*.[ch]' > > > > The p

Linux Kernel has additional MACSEC support

2017-11-22 Thread Keyur Patel
Hi,   Is there any development going on related to macsec in Linux Kernel except the current support driver from Sabrina?   Can any body help me to understand Linux TC framework?   Regards, Keyur Patel

Re: [PATCH 01/11] Initialize the mapping of KASan shadow memory

2017-11-22 Thread Liuwenliang (Abbott Liu)
On Nov 22, 2017 20:30 Mark Rutland [mailto:mark.rutl...@arm.com] wrote: >On Tue, Nov 21, 2017 at 07:59:01AM +, Liuwenliang (Abbott Liu) wrote: >> On Nov 17, 2017 21:49 Marc Zyngier [mailto:marc.zyng...@arm.com] wrote: >> >On Sat, 18 Nov 2017 10:40:08 + >> >"Liuwenliang (Abbott Liu)" w

Re: [PATCH] mm: migrate: fix an incorrect call of prep_transhuge_page()

2017-11-22 Thread Michal Hocko
On Wed 22-11-17 07:29:38, Zi Yan wrote: > On 22 Nov 2017, at 7:13, Zi Yan wrote: > > > On 22 Nov 2017, at 5:14, Michal Hocko wrote: > > > >> On Wed 22-11-17 10:35:10, Michal Hocko wrote: > >> [...] > >>> Moreover I am not really sure this is really working properly. Just look > >>> at the split_hu

Re: [PATCH 01/11] Initialize the mapping of KASan shadow memory

2017-11-22 Thread Marc Zyngier
On 22/11/17 12:56, Liuwenliang (Abbott Liu) wrote: > On Nov 22, 2017 20:30 Mark Rutland [mailto:mark.rutl...@arm.com] wrote: >> On Tue, Nov 21, 2017 at 07:59:01AM +, Liuwenliang (Abbott Liu) wrote: >>> On Nov 17, 2017 21:49 Marc Zyngier [mailto:marc.zyng...@arm.com] wrote: On Sat, 18

Re: [RFC PATCH 0/2] mm: introduce MAP_FIXED_SAFE

2017-11-22 Thread Michal Hocko
On Tue 21-11-17 17:48:31, John Hubbard wrote: [...] > Hi Michal, > > Yes, it really is useful for user space. I'll use CUDA as an example, but I > think anything that enforces a uniform virtual addressing scheme across CPUs > and devices, probably has to do something eerily similar. CUDA does thi

[PATCH 0/1] Trivial: Add parentheses to parameters in macros

2017-11-22 Thread Igor Stoppa
Some parameters are used in macros without being surrounded by parentheses. Igor Stoppa (1): Add paretheses to macro parameters. For trivial include/linux/kernel.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) -- 2.9.3

Re: No check of the size passed to unmap_single in swiotlb

2017-11-22 Thread Robin Murphy
On 22/11/17 03:23, Eric Yang wrote: -Original Message- From: Konrad Rzeszutek Wilk [mailto:konrad.w...@oracle.com] Sent: Tuesday, November 21, 2017 12:27 AM To: Eric Yang ; io...@lists.linux-foundation.org Cc: linux-kernel@vger.kernel.org; Greg Kroah-Hartman ; Andrew Morton ; Andrey Ry

[PATCH 1/1] Add paretheses to macro parameters. For trivial

2017-11-22 Thread Igor Stoppa
kernel.h: Some macros are not wrapping their parameters with parentheses. Signed-off-by: Igor Stoppa Cc: Tetsuo Handa Cc: Guenter Roeck Cc: Javi Merino --- include/linux/kernel.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/include/linux/kernel.h b/include/linux

Re: [RFC PATCH 0/2] mm: introduce MAP_FIXED_SAFE

2017-11-22 Thread Vlastimil Babka
On 11/22/2017 02:12 PM, Michal Hocko wrote: > I will be probably stubborn and go with a shorter name I have currently. > I am not very fond-of-very-long-names. The short synonym for the last word is "German" SCNR :P

Re: [PATCH v3 2/2] Protected O_CREAT open in sticky directories

2017-11-22 Thread Matthew Wilcox
On Wed, Nov 22, 2017 at 09:01:46AM +0100, Salvatore Mesoraca wrote: > +An O_CREAT open missing the O_EXCL flag in a sticky directory is, > +often, a bug or a synthom of the fact that the program is not > +using appropriate procedures to access sticky directories. > +This protection allow to detect

Re: [patch V4 01/11] Documentation: Add license-rules.rst to describe how to properly identify file licenses

2017-11-22 Thread Christoph Hellwig
On Wed, Nov 22, 2017 at 09:51:17AM -0200, Mauro Carvalho Chehab wrote: > Also, one may forget that headers use /**/ and end by doing the wrong > thing, as a common practice is to just cut-and-paste the same copyright > header on both C and H files at development time. Yes. > Make headers_install

Re: [BUG] 4.14 regression: Xorg hangs on exit

2017-11-22 Thread Tetsuo Handa
On 2017/11/22 13:11, Bob Tracy wrote: > On Tue, Nov 21, 2017 at 11:12:35AM -0600, Bob Tracy wrote: >> Apologies for the lack of detail, but the subject pretty much says it >> all. Xorg works fine with 4.13, but hangs on exit with 4.14. >> >> Logging in remotely and applying the "kill -9" sledgeham

Re: [patch V4 01/11] Documentation: Add license-rules.rst to describe how to properly identify file licenses

2017-11-22 Thread Mauro Carvalho Chehab
Em Wed, 22 Nov 2017 14:23:29 +0100 Christoph Hellwig escreveu: > On Wed, Nov 22, 2017 at 09:51:17AM -0200, Mauro Carvalho Chehab wrote: > > Also, one may forget that headers use /**/ and end by doing the wrong > > thing, as a common practice is to just cut-and-paste the same copyright > > header

Re: [PATCH] mm: migrate: fix an incorrect call of prep_transhuge_page()

2017-11-22 Thread Michal Hocko
On Wed 22-11-17 09:54:16, Michal Hocko wrote: > On Mon 20-11-17 21:18:55, Zi Yan wrote: [...] > > diff --git a/include/linux/migrate.h b/include/linux/migrate.h > > index 895ec0c4942e..a2246cf670ba 100644 > > --- a/include/linux/migrate.h > > +++ b/include/linux/migrate.h > > @@ -54,7 +54,7 @@ stat

Re: [PATCH] media: coda: fix comparision of decoded frames' indexes

2017-11-22 Thread Philipp Zabel
Hi Martin, On Fri, 2017-11-17 at 15:30 +0100, Martin Kepplinger wrote: > At this point the driver looks the currently decoded frame's index > and compares is to VPU-specific state values. Directly before this > if and else statements the indexes are read (index for decoded and > for displayed fram

Re: [patch V4 01/11] Documentation: Add license-rules.rst to describe how to properly identify file licenses

2017-11-22 Thread Greg Kroah-Hartman
On Wed, Nov 22, 2017 at 09:51:17AM -0200, Mauro Carvalho Chehab wrote: > Em Wed, 22 Nov 2017 12:12:04 +0100 (CET) > Thomas Gleixner escreveu: > > > On Fri, 17 Nov 2017, Christoph Hellwig wrote: > > > On Fri, Nov 17, 2017 at 07:11:41PM +0100, Thomas Gleixner wrote: > > > > Introcude a MODULE_LIC

Re: [RFC 00/19] KVM: s390/crypto/vfio: guest dedicated crypto adapters

2017-11-22 Thread Cornelia Huck
On Tue, 21 Nov 2017 11:08:01 -0500 Tony Krowiak wrote: > I am not quite sure what you are asking, but I'll attempt to answer > what I think you're asking. A new type of mediated matrix device > will be introduced to configure a virtual matrix for a guest that > provides the interfaces to map a v

Re: WARNING: can't dereference registers at ffffc90004dfff60 for ip error_entry+0x7d/0xd0 (Re: [PATCH v2 00/18] Entry stack switching)

2017-11-22 Thread Josh Poimboeuf
On Wed, Nov 22, 2017 at 08:39:07AM +0100, Ingo Molnar wrote: > > * Andy Lutomirski wrote: > > > This sets up stack switching, including for SYSCALL. I think it's > > in decent shape. > > > > Known issues: > > - I think we're going to want a way to turn the stack switching on and > >off ei

Re: [PATCH 23/30] [media] atomisp: deprecate pci_get_bus_and_slot()

2017-11-22 Thread Sinan Kaya
Hi Alex, On 11/22/2017 7:20 AM, Alan Cox wrote: > On Wed, 2017-11-22 at 00:31 -0500, Sinan Kaya wrote: >> pci_get_bus_and_slot() is restrictive such that it assumes domain=0 >> as >> where a PCI device is present. This restricts the device drivers to >> be >> reused for other domain numbers. > >

Re: [PATCH 2/2] ARM: dts: TS-7970: add basic device tree

2017-11-22 Thread kbuild test robot
: https://github.com/0day-ci/linux/commits/Sebastien-Bourdelin/of-documentation-add-bindings-documentation-for-TS-7970/20171122-195011 base: https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git for-next config: arm-at91_dt_defconfig (attached as .config) compiler: arm-linux-gnueabi

Re: [PATCH 23/30] [media] atomisp: deprecate pci_get_bus_and_slot()

2017-11-22 Thread Sinan Kaya
On 11/22/2017 9:05 AM, Sinan Kaya wrote: > Hi Alex, I tried to mean Alan. Sorry about that. Apparently, I didn't have enough coffee this morning. I shouldn't touch the code for a few hours. -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qua

Re: [BUG] 4.4.x-rt - memcg: refill_stock() use get_cpu_light() has data corruption issue

2017-11-22 Thread Mike Galbraith
On Wed, 2017-11-22 at 06:59 -0500, Steven Rostedt wrote: > > You see. No more spin lock to gripe about. No boom in your scenario. And patches--, perfect. -Mike

Re: kernel CI: printk loglevels in kernel boot logs?

2017-11-22 Thread Fengguang Wu
On Wed, Nov 22, 2017 at 12:34:48PM +0100, Petr Mladek wrote: On Wed 2017-11-22 11:27:02, Fengguang Wu wrote: [CC LKML for possible printk improvements] On Wed, Nov 22, 2017 at 09:56:10AM +0800, Fengguang Wu wrote: > Hi Kevin, > > On Tue, Nov 21, 2017 at 12:27:48PM -0800, Kevin Hilman wrote: > >

Re: [PATCH] scsi: ufs: ufshcd: fix potential NULL pointer dereference in ufshcd_config_vreg

2017-11-22 Thread Gustavo A. R. Silva
On 11/21/2017 10:01 PM, Martin K. Petersen wrote: Gustavo A., _vreg_ is being dereferenced before it is null checked, hence there is a potential null pointer dereference. Fix this by moving the pointer dereference after _vreg_ has been null checked. Applied to 4.15/scsi-fixes, thank you!

Re: [PATCH] c8sectpfe: fix potential NULL pointer dereference in c8sectpfe_timer_interrupt

2017-11-22 Thread Gustavo A. R. Silva
On 11/21/2017 02:22 AM, Patrice CHOTARD wrote: Hi Gustavo On 11/20/2017 03:00 PM, Gustavo A. R. Silva wrote: _channel_ is being dereferenced before it is null checked, hence there is a potential null pointer dereference. Fix this by moving the pointer dereference after _channel_ has been null

Re: [PATCH v2 3/4] drm/tinydrm: export mipi_dbi_buf_copy and mipi_dbi_spi_cmd_max_speed

2017-11-22 Thread Noralf Trønnes
Den 19.11.2017 21.12, skrev David Lechner: This exports the mipi_dbi_buf_copy() and mipi_dbi_spi_cmd_max_speed() functions so that they can be shared with other drivers. Signed-off-by: David Lechner --- Reviewed-by: Noralf Trønnes v2 changes: * new patch in v2 drivers/gpu/drm/tinydrm/m

Re: [PATCH v2 4/4] drm/tinydrm: add driver for ILI9225 panels

2017-11-22 Thread Noralf Trønnes
Den 19.11.2017 21.12, skrev David Lechner: This adds a new driver for display panels based on the Ilitek ILI9225 controller. This was developed for a no-name panel with a red PCB that is commonly marketed for Arduino. See . Signed-off-by: David Lechner

Re: Linux & FAT32 label

2017-11-22 Thread Andrius Štikonas
2017 m. lapkričio 22 d., trečiadienis 11:03:52 GMT rašėte: > On Wed, Nov 22, 2017 at 09:52:03AM +0100, Pali Rohár wrote: > > I can prepare patches for blkid (util-linux), but I do not like idea to > > have different algorithm how is read label in fatlabel and blkid. Both > > tools are used by diffe

[PATCH] iio: accel: remove redundant pointer pdata

2017-11-22 Thread Colin King
From: Colin Ian King Pointer pdata is being assigned but it is never being used, hence it is redundant and can be removed. Cleans up clang warning: drivers/iio/accel/st_accel_core.c:952:3: warning: Value stored to 'pdata' is never read Signed-off-by: Colin Ian King --- drivers/iio/accel/st_ac

[PATCH] mm, compaction: direct freepage allocation for async direct compaction

2017-11-22 Thread Johannes Weiner
From: Vlastimil Babka The goal of direct compaction is to quickly make a high-order page available for the pending allocation. The free page scanner can add significant latency when searching for migration targets, although to succeed the compaction, the only important limit on the target free pa

[PATCH v3 1/3] sched/pelt: Move pelt related code in a dedicated file

2017-11-22 Thread Vincent Guittot
We want to track rt_rq's utilization as a part of the estimation of the whole rq's utilization. This is necessary because rt tasks can steal utilization to cfs tasks and make them lighter than they are. As we want to use the same load tracking mecanism for both and prevent useless dependency betwee

[PATCH 0/3 v3] sched/rt: track rt rq utilization

2017-11-22 Thread Vincent Guittot
When both cfs and rt tasks compete to run on a CPU, we can see some frequency drops with schedutil governor. In such case, the cfs_rq's utilization doesn't reflect anymore the utilization of cfs tasks but only the remaining part that is not used by rt tasks. We should monitor the stolen utilization

Re: Autoselect patches for stable (Was: Re: [PATCH AUTOSEL for 4.9 36/56] drm/i915: Fix the level 0 max_wm hack on VLV/CHV)

2017-11-22 Thread alexander . levin
On Tue, Nov 21, 2017 at 05:55:29PM +, Emil Velikov wrote: >On 21 November 2017 at 15:07, wrote: >> On Mon, Nov 20, 2017 at 11:21:52AM +, Emil Velikov wrote: >>> - Document the autoselect process >>>Information about about What, Why, and [ideally] How - analogous to >>>the normal stable no

[PATCH v3 2/3] sched/rt: add rt_rq utilization tracking

2017-11-22 Thread Vincent Guittot
schedutil governor relies on cfs_rq's util_avg to choose the OPP when cfs tasks are running. When the CPU is overloaded by cfs and rt tasks, cfs tasks are preempted by rt tasks and in this case util_avg reflects the remaining capacity that is used by cfs task but not what cfs want to use. In such c

[PATCH 3/3] cpufreq/schedutil: add rt utilization tracking

2017-11-22 Thread Vincent Guittot
add both cfs and rt utilization when selecting an OPP as rt can preempt and steal cfs's running time Signed-off-by: Vincent Guittot --- kernel/sched/cpufreq_schedutil.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/sched/cpufreq_schedutil.c b/kernel/sched/cpufreq_sch

Re: [hrtimer_active ^W ata_port_wait_eh] INFO: trying to register non-static key.

2017-11-22 Thread Thomas Gleixner
On Tue, 21 Nov 2017, Fengguang Wu wrote: > Hello, > > FYI this happens in mainline kernel 4.14.0-12872-g020aae3. > It looks like a new regression after 4.14. > > It occurs in 126 out of 945 boots. > > [ 33.016892] INFO: trying to register non-static key. > [ 33.017745] the code is fine but

[PATCH] USB: gadget: legacy: remove redundant zero assignment to variable 'value'

2017-11-22 Thread Colin King
From: Colin Ian King The variable value is being assigned to zero but that value is never being read. Either value is being reassigned in the following if condition, or it is never read and the function returns. In both cases the assignment is redundant and can be removed. Cleans up clang warnin

Re: [PATCH 30/30] PCI: remove pci_get_bus_and_slot() function

2017-11-22 Thread Timur Tabi
On 11/22/17 1:51 AM, Greg KH wrote: Ick, no, why? What is wrong with removing this function as is? Don't mark something as __depreciated if there are no in-kernel users, just delete it and move on. If you have out-of-tree drivers, then yes, they can make a wrapper for this function like this i

Re: [PATCH V14 07/24] mmc: block: Use data timeout in card_busy_detect()

2017-11-22 Thread Ulf Hansson
On 22 November 2017 at 08:40, Adrian Hunter wrote: > On 21/11/17 17:39, Ulf Hansson wrote: >> On 21 November 2017 at 14:42, Adrian Hunter wrote: >>> card_busy_detect() has a 10 minute timeout. However the correct timeout is >>> the data timeout. Change card_busy_detect() to use the data timeout.

Re: [PATCH] mm: migrate: fix an incorrect call of prep_transhuge_page()

2017-11-22 Thread Zi Yan
Michal Hocko wrote: > On Wed 22-11-17 09:54:16, Michal Hocko wrote: >> On Mon 20-11-17 21:18:55, Zi Yan wrote: > [...] >>> diff --git a/include/linux/migrate.h b/include/linux/migrate.h >>> index 895ec0c4942e..a2246cf670ba 100644 >>> --- a/include/linux/migrate.h >>> +++ b/include/linux/migrate.h

Re: 4.14: WARNING: CPU: 4 PID: 2895 at block/blk-mq.c:1144 with virtio-blk (also 4.12 stable)

2017-11-22 Thread Jens Axboe
On 11/22/2017 12:28 AM, Christoph Hellwig wrote: > Jens, please don't just revert the commit in your for-linus tree. > > On its own this will totally mess up the interrupt assignments. Give > me a bit of time to sort this out properly. I wasn't going to push it until I heard otherwise. I'll just

Re: [PATCH 30/30] PCI: remove pci_get_bus_and_slot() function

2017-11-22 Thread Greg KH
On Wed, Nov 22, 2017 at 08:42:35AM -0600, Timur Tabi wrote: > On 11/22/17 1:51 AM, Greg KH wrote: > > Ick, no, why? What is wrong with removing this function as is? Don't > > mark something as __depreciated if there are no in-kernel users, just > > delete it and move on. > > > > If you have out-

Re: [PATCH] mm, compaction: direct freepage allocation for async direct compaction

2017-11-22 Thread Vlastimil Babka
On 11/22/2017 03:33 PM, Johannes Weiner wrote: > From: Vlastimil Babka > > The goal of direct compaction is to quickly make a high-order page available > for the pending allocation. The free page scanner can add significant latency > when searching for migration targets, although to succeed the c

Re: [PATCH] mm: migrate: fix an incorrect call of prep_transhuge_page()

2017-11-22 Thread Michal Hocko
On Wed 22-11-17 09:43:46, Zi Yan wrote: > > > Michal Hocko wrote: > > On Wed 22-11-17 09:54:16, Michal Hocko wrote: > >> On Mon 20-11-17 21:18:55, Zi Yan wrote: > > [...] > >>> diff --git a/include/linux/migrate.h b/include/linux/migrate.h > >>> index 895ec0c4942e..a2246cf670ba 100644 > >>> --- a

Re: [PATCH 3.18 00/12] 3.18.84-stable review

2017-11-22 Thread Greg Kroah-Hartman
On Wed, Nov 22, 2017 at 06:03:00AM -0800, kernelci.org bot wrote: > stable-rc/linux-3.18.y boot: 44 boots: 2 failed, 42 passed > (v3.18.83-12-g09d9c198f334) > > Full Boot Summary: > https://kernelci.org/boot/all/job/stable-rc/branch/linux-3.18.y/kernel/v3.18.83-12-g09d9c198f334/ > Full Build Sum

Re: [PATCH] PCI: designware-ep: Fix ->get_msi() to check MSI_EN bit

2017-11-22 Thread Lorenzo Pieralisi
On Wed, Nov 22, 2017 at 05:24:21PM +0530, Kishon Vijay Abraham I wrote: > Hi Lorenzo, > > On Wednesday 22 November 2017 05:07 PM, Lorenzo Pieralisi wrote: > > On Wed, Nov 22, 2017 at 02:34:27PM +0530, Kishon Vijay Abraham I wrote: > >> ->get_msi() now checks MSI_EN bit in the MSI CAPABILITY regist

Re: [PATCH 3.2 00/61] 3.2.96-rc1 review

2017-11-22 Thread Guenter Roeck
On 11/21/2017 06:11 PM, Ben Hutchings wrote: This is the start of the stable review cycle for the 3.2.96 release. There are 61 patches in this series, which will be posted as responses to this one. If anyone has any issues with these being applied, please let me know. Responses should be made b

Re: [PATCH 3.16 000/133] 3.16.51-rc1 review

2017-11-22 Thread Guenter Roeck
On 11/21/2017 05:58 PM, Ben Hutchings wrote: This is the start of the stable review cycle for the 3.16.51 release. There are 133 patches in this series, which will be posted as responses to this one. If anyone has any issues with these being applied, please let me know. Responses should be made

Re: VMs freezing when host is running 4.14

2017-11-22 Thread 王金浦
+cc kvm 2017-11-22 10:39 GMT+01:00 Marc Haber : > On Tue, Nov 21, 2017 at 05:18:21PM +0100, Marc Haber wrote: >> On the affected host, VMs freeze at a rate about two or three per day. >> They just stop dead in their tracks, console and serial console become >> unresponsive, ping stops, they don't

[PATCH 2/3] ASoC: stm32: sai: simplify sync modes management

2017-11-22 Thread Olivier Moysan
Use function of_find_device_by_node() to retrieve SAI synchro provider device and private data. This allows to remove registration of probed SAI in a linked list. Signed-off-by: Olivier Moysan --- sound/soc/stm/stm32_sai.c | 105 ++ 1 file changed, 22

[PATCH 1/3] ASoC: stm32: fix sync property description in SAI bindings

2017-11-22 Thread Olivier Moysan
SAI sync property must be described in SAI subnodes section, as it is a property of child node. This patch fixes commit 14f0e5f8d97e632695d92f41f2e91d10d8005d47 "ASoC: stm32: Add synchronization to SAI bindings". Signed-off-by: Olivier Moysan --- Documentation/devicetree/bindings/sound/st,stm32-

[PATCH 0/3] ASoC: stm32: sai: fixes related to synchro feature

2017-11-22 Thread Olivier Moysan
Fix sai binding and simplify code related to synchro feature. This change allows to remove stm32_sai_remove() function and use devm_of_platform_populate(). Olivier Moysan (3): ASoC: stm32: fix sync property description in SAI bindings ASoC: stm32: sai: simplify sync modes management ASoC: st

[PATCH 3/3] ASoC: stm32: sai: use devm_of_platform_populate()

2017-11-22 Thread Olivier Moysan
Use devm_of_platform_populate() instead of of_platform_depopulate() to simplify driver code. Signed-off-by: Benjamin Gaignard Signed-off-by: Olivier Moysan --- sound/soc/stm/stm32_sai.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/sound/soc/stm/stm32_sai.c b/s

Re: [11/30] hwmon: (coretemp) deprecate pci_get_bus_and_slot()

2017-11-22 Thread Guenter Roeck
On Wed, Nov 22, 2017 at 12:30:56AM -0500, Sinan Kaya wrote: > pci_get_bus_and_slot() is restrictive such that it assumes domain=0 as > where a PCI device is present. This restricts the device drivers to be > reused for other domain numbers. > > Use pci_get_domain_bus_and_slot() with a domain numbe

Re: [PATCH] mm: migrate: fix an incorrect call of prep_transhuge_page()

2017-11-22 Thread Zi Yan
Michal Hocko wrote: > On Wed 22-11-17 09:43:46, Zi Yan wrote: >> >> Michal Hocko wrote: >>> On Wed 22-11-17 09:54:16, Michal Hocko wrote: On Mon 20-11-17 21:18:55, Zi Yan wrote: >>> [...] > diff --git a/include/linux/migrate.h b/include/linux/migrate.h > index 895ec0c4942e..a2246cf67

Re: [v3, 02/12] Documentation: ABI: Add occ-hwmon driver sysfs documentation

2017-11-22 Thread Guenter Roeck
On Mon, Nov 20, 2017 at 05:53:31PM -0600, eaja...@linux.vnet.ibm.com wrote: > From: "Edward A. James" > > Detail the sysfs attributes provided by the occ-hwmon driver. > This describes my problem with this driver: All the sysfs attributes described here are not really hardware monitoring relate

Re: [PATCH update for 4.15 1/3] selftests: lib.mk: Introduce OVERRIDE_TARGETS

2017-11-22 Thread Shuah Khan
On 11/21/2017 03:19 PM, Mathieu Desnoyers wrote: > Introduce OVERRIDE_TARGETS to allow tests to express dependencies on > header files and .so, which require to override the selftests lib.mk > targets. > > Signed-off-by: Mathieu Desnoyers > CC: Russell King > CC: Catalin Marinas > CC: Will Deac

[PATCH] ARM: dma-mapping:Fix ifnullfree.cocci warnings

2017-11-22 Thread Vasyl Gomonovych
NULL check before some freeing functions is not needed. arch/arm/common/dmabounce.c:573:2-18: WARNING: NULL check before freeing functions like kfree arch/arm/common/dmabounce.c:575:2-18: WARNING: NULL check before freeing functions like kfree Generated by: scripts/coccinelle/free/ifnullfree.coc

Re: [PATCH 30/30] PCI: remove pci_get_bus_and_slot() function

2017-11-22 Thread Sinan Kaya
On 11/22/2017 9:49 AM, Greg KH wrote: >>> If you have out-of-tree drivers, then yes, they can make a wrapper for >>> this function like this if they really feel the need, or they can get >>> their code merged:) >> Sorry, I guess I should have been clearer. My suggestion was to fix some of >> the d

Re: WARNING: can't dereference registers at ffffc90004dfff60 for ip error_entry+0x7d/0xd0 (Re: [PATCH v2 00/18] Entry stack switching)

2017-11-22 Thread Andy Lutomirski
On Wed, Nov 22, 2017 at 5:55 AM, Josh Poimboeuf wrote: > On Wed, Nov 22, 2017 at 08:39:07AM +0100, Ingo Molnar wrote: >> >> * Andy Lutomirski wrote: >> >> > This sets up stack switching, including for SYSCALL. I think it's >> > in decent shape. >> > >> > Known issues: >> > - I think we're going

[PATCH] ARM: dma-mapping: Use vma_pages helper

2017-11-22 Thread Vasyl Gomonovych
Use vma_pages function on vma object instead of explicit computation. arch/arm/mm/dma-mapping.c:849:36-42: WARNING: Consider using vma_pages helper on vma Generated by: scripts/coccinelle/api/vma_pages.cocci Signed-off-by: Vasyl Gomonovych --- arch/arm/mm/dma-mapping.c | 2 +- 1 file changed, 1

Re: [PATCH update for 4.15 2/3] cpu_opv: selftests: Implement selftests (v4)

2017-11-22 Thread Shuah Khan
On 11/21/2017 03:19 PM, Mathieu Desnoyers wrote: > Implement cpu_opv selftests. It needs to express dependencies on > header files and .so, which require to override the selftests > lib.mk targets. Use OVERRIDE_TARGETS define for this. > > Signed-off-by: Mathieu Desnoyers > CC: Russell King > CC

Re: [v3, 09/12] hwmon (occ): Add sensor attributes and register hwmon device

2017-11-22 Thread Guenter Roeck
On Mon, Nov 20, 2017 at 05:53:38PM -0600, eaja...@linux.vnet.ibm.com wrote: > From: "Edward A. James" > > Setup the sensor attributes for every OCC sensor found by the first poll > response. Register the attributes with hwmon. Add hwmon documentation > for the driver. > > Signed-off-by: Edward A

[PATCH] dma-buf: Fix ifnullfree.cocci warnings

2017-11-22 Thread Vasyl Gomonovych
NULL check before some freeing functions is not needed. drivers/dma-buf/dma-buf.c:1183:2-26: WARNING: NULL check before freeing debugfs_remove_recursive Generated by: scripts/coccinelle/free/ifnullfree.cocci Signed-off-by: Vasyl Gomonovych --- drivers/dma-buf/dma-buf.c | 3 +-- 1 file changed,

Re: [PATCH v2 06/18] x86/kasan/64: Teach KASAN about the cpu_entry_area

2017-11-22 Thread Andy Lutomirski
On Wed, Nov 22, 2017 at 1:05 AM, Andrey Ryabinin wrote: > > > On 11/22/2017 07:44 AM, Andy Lutomirski wrote: >> The cpu_entry_area will contain stacks. Make sure that KASAN has >> appropriate shadow mappings for them. >> >> Cc: Andrey Ryabinin >> Cc: Alexander Potapenko >> Cc: Dmitry Vyukov >>

Re: [v3,10/12] hwmon (occ): Add non-hwmon attributes

2017-11-22 Thread Guenter Roeck
On Mon, Nov 20, 2017 at 05:53:39PM -0600, eaja...@linux.vnet.ibm.com wrote: > From: "Edward A. James" > > Create device attributes for additional OCC properties that do not > belong as hwmon sensors. These provide additional information as to the > state of the processor and system. > ... and th

Re: Xen PV seems to be broken on Linus' tree

2017-11-22 Thread Andy Lutomirski
On Wed, Nov 22, 2017 at 4:50 AM, Juergen Gross wrote: > On 22/11/17 05:46, Andy Lutomirski wrote: >> On Tue, Nov 21, 2017 at 8:11 PM, Andy Lutomirski wrote: >>> On Tue, Nov 21, 2017 at 7:33 PM, Andy Lutomirski wrote: I'm doing: /usr/bin/qemu-system-x86_64 -machine accel=kvm:tcg -c

Re: [PATCH update for 4.15 3/3] rseq: selftests: Provide self-tests (v4)

2017-11-22 Thread Shuah Khan
On 11/21/2017 03:19 PM, Mathieu Desnoyers wrote: > Implements two basic tests of RSEQ functionality, and one more > exhaustive parameterizable test. > > The first, "basic_test" only asserts that RSEQ works moderately > correctly. E.g. that the CPUID pointer works. > > "basic_percpu_ops_test" is a

[PATCH] drm/rockchip: dma-mapping: Use vma_pages helper

2017-11-22 Thread Vasyl Gomonovych
Use vma_pages function on vma object instead of explicit computation. ./drivers/gpu/drm/rockchip/rockchip_drm_gem.c:223:34-40: WARNING: Consider using vma_pages helper on vma Generated by: scripts/coccinelle/api/vma_pages.cocci Signed-off-by: Vasyl Gomonovych --- drivers/gpu/drm/rockchip/rockch

Re: [RFC PATCH for 4.15 v12 00/22] Restartable sequences and CPU op vector

2017-11-22 Thread Thomas Gleixner
On Wed, 22 Nov 2017, Mathieu Desnoyers wrote: > - On Nov 21, 2017, at 5:59 PM, Thomas Gleixner t...@linutronix.de wrote: > >> Using vDSO as an example of how things should be done is just wrong: the > >> vDSO interaction with debugger instruction single-stepping is broken, > >> as I detailed in

[PATCH] misc: mic: Use memdup_user() as a cleanup

2017-11-22 Thread Vasyl Gomonovych
Fix coccicheck warning which recommends to use memdup_user(): drivers/misc/mic/vop/vop_vringh.c:940:14-21: WARNING opportunity for memdup_user drivers/misc/mic/vop/vop_vringh.c:998:8-15: WARNING opportunity for memdup_user Generated by: scripts/coccinelle/memdup_user/memdup_user.cocci Signed-off

Re: [PATCH] ARM: dma-mapping: Use vma_pages helper

2017-11-22 Thread Vladimir Murzin
On 22/11/17 15:20, Vasyl Gomonovych wrote: > Use vma_pages function on vma object instead of explicit computation. > arch/arm/mm/dma-mapping.c:849:36-42: WARNING: Consider using vma_pages helper > on vma > Generated by: scripts/coccinelle/api/vma_pages.cocci > > Signed-off-by: Vasyl Gomonovych >

<    1   2   3   4   5   6   7   8   9   10   >