3.2.96-rc1 review patch. If anyone has any objections, please let me know.
--
From: Ben Hutchings
Commit ef810e7c3d2a ("mac80211: accept key reinstall without changing
anything") moved the initialisation of key->sdata later in
ieee80211_key_link(). In the upstream commit fdf7c
3.2.96-rc1 review patch. If anyone has any objections, please let me know.
--
From: Chad Dupuis
commit 7a8ab9c840b5dff9bb70328338a86444ed1c2415 upstream.
Signed-off-by: Chad Dupuis
Signed-off-by: Saurav Kashyap
Signed-off-by: James Bottomley
[bwh: Backported to 3.2: adjust
3.2.96-rc1 review patch. If anyone has any objections, please let me know.
--
From: Amir Goldstein
commit 47c7d0b19502583120c3f396c7559e7a77288a68 upstream.
When calling into _xfs_log_force{,_lsn}() with a pointer
to log_flushed variable, log_flushed will be set to 1 if:
1. xl
3.2.96-rc1 review patch. If anyone has any objections, please let me know.
--
From: Joe Carnuccio
commit 71dfe9e776878d9583d004edade55edc2bdac5eb upstream.
Correct the erroneous return codes introduced by the following patch:
"Return sysfs error codes appropriate to conditions
3.2.96-rc1 review patch. If anyone has any objections, please let me know.
--
From: Mike Marciniszyn
commit 5b0ef650bd0f820e922fcc42f1985d4621ae19cf upstream.
Section 9.7.7.2.5 of the 1.3 IBTA spec clearly says that receive
credits should never apply to RDMA write.
qib and hf
3.2.96-rc1 review patch. If anyone has any objections, please let me know.
--
From: Edwin Török
commit 55acdd926f6b21a5cdba23da98a48aedf19ac9c3 upstream.
Can be reproduced when running dlm_controld (tested on 4.4.x, 4.12.4):
# seq 1 100 | xargs -P0 -n1 dlm_tool join
# seq 1
3.2.96-rc1 review patch. If anyone has any objections, please let me know.
--
From: Guenter Roeck
commit 7e09f7d5c790278ab98e5f2c22307ebe8ad6e8ba upstream.
The size of uvc_control_mapping is user controlled leading to a
potential heap overflow in the uvc driver. This adds a ch
3.2.96-rc1 review patch. If anyone has any objections, please let me know.
--
From: "Steven Rostedt (VMware)"
commit 46320a6acc4fb58f04bcf78c4c942cc43b20f986 upstream.
In the second iteration of trace_selftest_ops(), the error goto label is
wrong in the case where trace_selfte
3.2.96-rc1 review patch. If anyone has any objections, please let me know.
--
From: Kai-Heng Feng
commit de3af5bf259d7a0bfaac70441c8568ab5998d80c upstream.
Corsair Strafe RGB keyboard has trouble to initialize:
[ 1.679455] usb 3-6: new full-speed USB device number 4 using xhc
3.2.96-rc1 review patch. If anyone has any objections, please let me know.
--
From: Sean Young
commit 89d8a2cc51d1f29ea24a0b44dde13253141190a0 upstream.
This driver cannot send pulse, it only accepts driver-dependent codes.
Signed-off-by: Sean Young
Signed-off-by: Mauro Carv
3.2.96-rc1 review patch. If anyone has any objections, please let me know.
--
From: Paul Mackerras
commit 93b2d3cf3733b4060d3623161551f51ea1ab5499 upstream.
The instruction code for xxlor that commit 0016a4cf5582 ("powerpc:
Emulate most Book I instructions in emulate_step()",
3.2.96-rc1 review patch. If anyone has any objections, please let me know.
--
From: Dmitry Fleytman
commit a1279ef74eeeb5f627f091c71d80dd7ac766c99d upstream.
Commit e0429362ab15
("usb: Add device quirk for Logitech HD Pro Webcams C920 and C930e")
introduced quirk to workaround
-- Forwarded message --
From: 丁飞
Date: Wed, Nov 22, 2017 at 12:58 AM
Subject: Why qemu with kvm enabled can boot kernel even if identity
page map is not set correctly?
To: k...@vger.kernel.org
Hi, KVM developers. Firstly, sorry if it's the wrong place to ask such
a question!
In
3.2.96-rc1 review patch. If anyone has any objections, please let me know.
--
From: Christophe JAILLET
commit 0f9b011d3321ca1079c7a46c18cb1956fbdb7bcb upstream.
The .release function of driver_ktype is 'driver_release()'.
This function frees the container_of this kobject.
So,
3.2.96-rc1 review patch. If anyone has any objections, please let me know.
--
From: Arvind Yadav
commit 58fd55e838276a0c13d1dc7c387f90f25063cbf3 upstream.
It seems that the return value of usb_ifnum_to_if() can be NULL and
needs to be checked.
Signed-off-by: Arvind Yadav
Tes
3.2.96-rc1 review patch. If anyone has any objections, please let me know.
--
From: SeongJae Park
commit f113e64121ba9f4791332248b315d9f57ee33a6b upstream.
Comment for pagetypeinfo_showblockcount() is mistakenly duplicated from
pagetypeinfo_show_free()'s comment. This commit
3.2.96-rc1 review patch. If anyone has any objections, please let me know.
--
From: Colin Ian King
commit 801e3659bf2c87c31b7024087d61e89e172b5651 upstream.
The calculation of the left volume looks suspect, the value of
0x1f - ((val << 8) & 0x1f) is always 0x1f. The debug prio
3.2.96-rc1 review patch. If anyone has any objections, please let me know.
--
From: Dan Carpenter
commit e6f77540c067b48dee10f1e33678415bfcc89017 upstream.
The value of "size" comes from the user. When we add "start + size" it
could lead to an integer overflow bug.
It means
3.2.96-rc1 review patch. If anyone has any objections, please let me know.
--
From: Bart Van Assche
commit 4ddd56b003f251091a67c15ae3fe4a5c5c5e390a upstream.
Calling blk_start_queue() from interrupt context with the queue
lock held and without disabling IRQs, as the skd driver
3.2.96-rc1 review patch. If anyone has any objections, please let me know.
--
From: "Guillermo A. Amaral"
commit 540602a43ae5fa94064f8fae100f5ca75d4c002b upstream.
This adds VID/PID combinations for MadCatz, PDP and PowerA (new).
Removed Pelican 'TSZ' Wired Xbox 360 Controlle
3.2.96-rc1 review patch. If anyone has any objections, please let me know.
--
From: Johan Hovold
commit 6c3b047fa2d2286d5e438bcb470c7b1a49f415f6 upstream.
Make sure to check that we actually have an Interface Association
Descriptor before dereferencing it during probe to avoid
3.2.96-rc1 review patch. If anyone has any objections, please let me know.
--
From: Brian King
commit 1ae948fa4f00f3a2823e7cb19a3049ef27dd6947 upstream.
This fixes a potential race condition observed on Power systems.
Several places throughout the aacraid driver call aac_fib_
3.2.96-rc1 review patch. If anyone has any objections, please let me know.
--
From: Thomas Gleixner
commit 12ac1d0f6c3e95732d144ffa65c8b20fbd9aa462 upstream.
for_each_active_irq() iterates the sparse irq allocation bitmap. The caller
must hold sparse_irq_lock. Several code pat
2017-11-20 22:29 GMT+08:00 Will Deacon :
> Hi Greentime,
>
> On Wed, Nov 08, 2017 at 01:54:59PM +0800, Greentime Hu wrote:
>> From: Greentime Hu
>>
>> Signed-off-by: Vincent Chen
>> Signed-off-by: Greentime Hu
>> ---
>> arch/nds32/include/asm/futex.h| 116
>> arch/
3.2.96-rc1 review patch. If anyone has any objections, please let me know.
--
From: Theodore Ts'o
commit 2ba3e6e8afc9b6188b471f27cf2b5e3cf34e7af2 upstream.
It is OK for s_first_meta_bg to be equal to the number of block group
descriptor blocks. (It rarely happens, but it shou
3.2.96-rc1 review patch. If anyone has any objections, please let me know.
--
From: Jonas Gorski
commit 1b495faec231980b6c719994b24044ccc04ae06c upstream.
Make the behaviour of clk_get_rate consistent with common clk's
clk_get_rate by accepting NULL clocks as parameter. Some d
3.2.96-rc1 review patch. If anyone has any objections, please let me know.
--
From: Kai-Heng Feng
commit 697c5d8a36768b36729533fb44622b35d56d6ad0 upstream.
Similar to other Gigabyte laptops, the touchpad on P57 requires a
keyboard reset to detect Elantech touchpad correctly.
3.2.96-rc1 review patch. If anyone has any objections, please let me know.
--
From: Cameron Gutman
commit c01b5e7464f0cf20936d7467c7528163c4e2782d upstream.
The order of endpoints is well defined on official Xbox pads, but
we have found at least one 3rd-party pad that doesn't
3.2.96-rc1 review patch. If anyone has any objections, please let me know.
--
From: Jan H. Schönherr
commit 49a8afca386ee1775519a4aa80f8e121bd227dd4 upstream.
Signed-off-by: Jan H. Schönherr
Fixes: f6511935f424 ("KVM: SVM: Add checks for IO instructions")
Reviewed-by: David H
3.2.96-rc1 review patch. If anyone has any objections, please let me know.
--
From: Steffen Maier
commit fdb7cee3b9e3c561502e58137a837341f10cbf8b upstream.
At the default trace level, we only trace unsuccessful events including
FSF responses.
zfcp_dbf_hba_fsf_response() only
3.2.96-rc1 review patch. If anyone has any objections, please let me know.
--
From: Wanpeng Li
commit 9a6e7c39810e4a8bc7fc95056cefb40583fe07ef upstream.
qemu-system-x86-8600 [004] d..1 7205.687530: kvm_entry: vcpu 2
qemu-system-x86-8600 [004] 7205.687532: kvm_exit: re
3.2.96-rc1 review patch. If anyone has any objections, please let me know.
--
From: Cameron Gutman
commit 122d6a347329818419b032c5a1776e6b3866d9b9 upstream.
We should only see devices with interrupt endpoints. Ignore any other
endpoints that we find, so we don't send try to se
3.2.96-rc1 review patch. If anyone has any objections, please let me know.
--
From: "Xiangliang.Yu"
commit 9afae2719273fa1d406829bf3498f82dbdba71c7 upstream.
When fail to get needed page for pool, need to put allocated pages
into pool. But current code has a miscalculation of
3.2.96-rc1 review patch. If anyone has any objections, please let me know.
--
From: Eryu Guan
commit 3a4b77cd47bb837b8557595ec7425f281f2ca1fe upstream.
Ralf Spenneberg reported that he hit a kernel crash when mounting a
modified ext4 image. And it turns out that kernel crashed
3.2.96-rc1 review patch. If anyone has any objections, please let me know.
--
From: Ted Mielczarek
commit 1a48ff81b3912be5fadae3fafde6c2f632246a4c upstream.
Xbox One controllers require an initialization message to start sending
data, so xpad_init_output becomes a required fun
3.2.96-rc1 review patch. If anyone has any objections, please let me know.
--
From: Steffen Maier
commit 12c3e5754c8022a4f2fd1e9f00d19e99ee0d3cc1 upstream.
If the FCP_RSP UI has optional parts (FCP_SNS_INFO or FCP_RSP_INFO) and
thus does not fit into the fsp_rsp field built in
3.2.96-rc1 review patch. If anyone has any objections, please let me know.
--
From: Steffen Maier
commit 975171b4461be296a35e83ebd748946b81cf0635 upstream.
v4.9 commit aceeffbb59bb ("zfcp: trace full payload of all SAN records
(req,resp,iels)") fixed trace data loss of 2.6.38
3.2.96-rc1 review patch. If anyone has any objections, please let me know.
--
From: Johan Hovold
commit 299d7572e46f98534033a9e65973f13ad1ce9047 upstream.
Make sure to reset the USB-console port pointer when console setup fails
in order to avoid having the struct usb_serial be
3.2.96-rc1 review patch. If anyone has any objections, please let me know.
--
From: Andrey Korolyov
commit 591b6bb605785c12a21e8b07a08a277065b655a5 upstream.
Several legacy devices such as Geode-based Cisco ASA appliances
and DB800 development board do possess CS5536 IDE contr
3.2.96-rc1 review patch. If anyone has any objections, please let me know.
--
From: Steffen Maier
commit 1a5d999ebfc7bfe28deb48931bb57faa8e4102b6 upstream.
For problem determination we need to see that we were in scsi_eh
as well as whether and why we were successful or not.
T
Hi, Aleksa Sarai:
Sorry for the late replay.
> what happens if you have processes in the same pidns that have
different mount namespaces?
We support this. The coredump file will be saved in the same mount
namespace with the processes. This is implemented by patch
> Just my $0.02.
Thanks.
Be
3.2.96-rc1 review patch. If anyone has any objections, please let me know.
--
From: Noa Osherovich
commit 5236333592244557a19694a51337df6ac018f0a7 upstream.
RoCE Annex (A16.9.10/11) declares that during attach (detach) QP to a
multicast group, if the QP is associated with a Ro
3.2.96-rc1 review patch. If anyone has any objections, please let me know.
--
From: Rui Teng
commit 23493c121912a39f0262e0dbeb236e1d39efa4d5 upstream.
The offset of hugepage block will not be 16G, if the expected
page is more than one. Calculate the totol size instead of the
h
This is the start of the stable review cycle for the 3.2.96 release.
There are 61 patches in this series, which will be posted as responses
to this one. If anyone has any issues with these being applied, please
let me know.
Responses should be made by Fri Nov 24 20:00:00 UTC 2017.
Anything receiv
3.2.96-rc1 review patch. If anyone has any objections, please let me know.
--
From: Finn Thain
commit 7640d91d285893a5cf1e62b2cd00f0884c401d93 upstream.
When in MESSAGE IN phase, the ESP device does not automatically
acknowledge each byte that is transferred by PIO. The mac_es
3.2.96-rc1 review patch. If anyone has any objections, please let me know.
--
From: Dmitry Torokhov
commit a50829479f58416a013a4ccca791336af3c584c7 upstream.
parse_hid_report_descriptor() has a while (i < length) loop, which
only guarantees that there's at least 1 byte in the
3.2.96-rc1 review patch. If anyone has any objections, please let me know.
--
From: Steffen Maier
commit 9fe5d2b2fd30aa8c7827ec62cbbe6d30df4fe3e3 upstream.
Without this fix we get SCSI trace records on task management functions
which cannot be correlated to HBA trace records b
3.2.96-rc1 review patch. If anyone has any objections, please let me know.
--
From: "Eric W. Biederman"
commit d08477aa975e97f1dc64c0ae59cebf98520456ce upstream.
We have a weird and problematic intersection of features that when
they all come together result in ambiguous sigin
FYI, we noticed the following commit (built with gcc-5):
commit: a04f08a1593be12b76cce3e5dbd5da98b77ce250 ("x86/mm/tlb: Make CR4-based
TLB flushes more robust")
https://git.kernel.org/cgit/linux/kernel/git/tip/tip.git WIP.x86/mm
in testcase: boot
on test machine: qemu-system-x86_64 -enable-kvm
FYI, we noticed the following commit (built with gcc-6):
commit: 5f3cb7eb7ce2d895658c6251fbaa4b59d93d941d ("x86/entry/64: Create a
percpu SYSCALL entry trampoline")
https://git.kernel.org/cgit/linux/kernel/git/luto/linux.git x86/entry_stack
in testcase: boot
on test machine: qemu-system-x86_64
On 11/21/2017 11:18 PM, Jiri Olsa wrote:
On Mon, Nov 20, 2017 at 10:43:39PM +0800, Jin Yao wrote:
SNIP
if (num == 0)
diff --git a/tools/perf/util/stat.c b/tools/perf/util/stat.c
index 151e9ef..50bb16d 100644
--- a/tools/perf/util/stat.c
+++ b/tools/perf/util/stat.c
@@ -278,9 +278,16
On 11/21/2017 11:18 PM, Jiri Olsa wrote:
On Mon, Nov 20, 2017 at 10:43:37PM +0800, Jin Yao wrote:
SNIP
+ STAT_SMI_NUM,
+ STAT_APERF,
+ STAT_MAX
+};
+
+struct runtime_stat {
+ struct rblist value_list;
+};
+
struct perf_stat_config {
enum aggr_mode aggr_mode
On Tue, 2017-11-21 at 22:59 +, Colin King wrote:
> From: Colin Ian King
>
> Trivial fix to spelling mistake in dev_err error message
>
> Signed-off-by: Colin Ian King
> ---
> drivers/ntb/hw/mscc/ntb_hw_switchtec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/dr
2017-11-13 19:42 GMT+08:00 Arnd Bergmann :
> On Mon, Nov 13, 2017 at 3:51 AM, Vincent Chen wrote:
On Wed, Nov 8, 2017 at 6:55 AM, Greentime Hu wrote:
From: Greentime Hu
>
>>
+#define __ARCH_WANT_SYS_CLONE
>>>
>>>This seems ok, though it would be nice to have the reverse logic and h
From: Miles Chen
Coverity found that the commit 3aaabbf1c39e ("lib/dma-debug.c:
fix incorrect pfn calculation") uses incorrect API to check
if a given address is a linear address.
The condition should be: (as discussed in Christoph's review)
if (!is_vmalloc_addr(virt) && !virt_addr_valid(virt))
n
> -Original Message-
> From: Konrad Rzeszutek Wilk [mailto:konrad.w...@oracle.com]
> Sent: Tuesday, November 21, 2017 12:27 AM
> To: Eric Yang ; io...@lists.linux-foundation.org
> Cc: linux-kernel@vger.kernel.org; Greg Kroah-Hartman
> ; Andrew Morton ;
> Andrey Ryabinin ; David Miller
> ;
Dear RT experts,
I have a x86 server mainly used as qemu-kvm hypervisor that is installed with
linux-RT kernel, the linux kernel and RT patch set are respectively get from:
Linux kernel: https://www.kernel.org/pub/linux/kernel/v4.x/linux-4.4.97.tar.xz
RT patch set:
https://www.kernel.org/pub/lin
This patchset includes following function points:
1: Let usermodehelper function possible to set pid namespace
done by: [PATCH_v4.1 1/3] Make call_usermodehelper_exec possible
to set namespaces
2: Let pipe_type core_pattern write dump into container's rootfs
done by: [PATCH_v4.1 2/3] Limit
Currently when we set core_pattern to a pipe, the pipe program is
forked by kthread running with root's permission, and write dumpfile
into host's filesystem.
Same thing happened for container, the dumper and dumpfile are also
in host(not in container).
It have following program:
1: Not consistent
Current call_usermodehelper_work() can not set namespaces for
the executed program.
This patch add above function for call_usermodehelper_work().
The init_intermediate is introduced for init works which should
be done before fork(). So that we get a method to set namespaces
for children. The clean
Currently, each container shared one copy of coredump setting
with the host system, if host system changed the setting, each
running containers will be affected.
Same story happened when container changed core_pattern, both
host and other container will be affected.
For container based on namespac
[CC LKML for possible printk improvements]
On Wed, Nov 22, 2017 at 09:56:10AM +0800, Fengguang Wu wrote:
Hi Kevin,
On Tue, Nov 21, 2017 at 12:27:48PM -0800, Kevin Hilman wrote:
Hi Fenguang,
In automated testing, for ease of parsing kernel boot logs (especially
separating warnings and errors f
On Tue, Nov 21, 2017 at 10:55:23PM +0100, Jason A. Donenfeld wrote:
> Hi Josh,
>
> We're working on some highly optimized assembly crypto primitive
> implementations for WireGuard. The last 24 hours have been spent
> trying to make objtool happy with a variety of tricks, some more
> unfortunate th
I'm doing:
/usr/bin/qemu-system-x86_64 -machine accel=kvm:tcg -cpu host -net none
-nographic -kernel xen-4.8.2 -initrd './arch/x86/boot/bzImage' -m 2G
-smp 2 -append console=com1
With Linus' commit c8a0739b185d11d6e2ca7ad9f5835841d1cfc765 and the
attached config.
It dies with a bunch of sensible
On Wed, 2017-11-22 at 01:58 +, Ben Hutchings wrote:
> 3.16.51-rc1 review patch. If anyone has any objections, please let me know.
[]
> --- a/drivers/md/bcache/writeback.h
> +++ b/drivers/md/bcache/writeback.h
> @@ -14,6 +14,25 @@ static inline uint64_t bcache_dev_sector
> return ret;
>
On 11/21/2017 11:18 PM, Jiri Olsa wrote:
On Mon, Nov 20, 2017 at 10:43:43PM +0800, Jin Yao wrote:
SNIP
- if ((stat_config.aggr_mode == AGGR_THREAD) &&
!target__has_task(&target)) {
- fprintf(stderr, "The --per-thread option is only available "
- "wh
On Tue, Nov 21, 2017 at 2:09 PM, Dave Hansen
wrote:
> On 11/20/2017 12:12 PM, Thomas Gleixner wrote:
>>> + */
>>> +native_get_shadow_pgd(pgdp)->pgd = pgd.pgd;
>>> +/*
>>> + * For the copy of the pgd that the kernel
>>>
On Tue, Nov 21, 2017 at 10:57 AM, Dave Hansen wrote:
> On 11/20/2017 09:07 AM, Andy Lutomirski wrote:
>> --- a/arch/x86/entry/entry_64.S
>> +++ b/arch/x86/entry/entry_64.S
>> @@ -560,6 +560,14 @@ END(irq_entries_start)
>> .macro interrupt func
>> cld
>> ALLOC_PT_GPREGS_ON_STACK
>
On Wed, 22 Nov 2017 03:18:45 +
Haiyang HY1 Tan wrote:
> Dear RT experts,
>
> I have a x86 server mainly used as qemu-kvm hypervisor that is installed with
> linux-RT kernel, the linux kernel and RT patch set are respectively get from:
> Linux kernel: https://www.kernel.org/pub/linux/kernel/
ping again...
On 2017/11/17 9:09, Yunlong Song wrote:
This can help to find potential bugs on some corner case.
Signed-off-by: Yunlong Song
---
fs/f2fs/gc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
index 5d5bba4..c89128b 100644
--- a/fs/f2fs/gc.c
+++ b
ping again...
On 2017/11/17 8:54, Yunlong Song wrote:
f2fs_balance_fs only actives once in the commit_inmem_pages, but there
are more than one page to commit, so all the other pages will miss the
check. This will lead to out-of-free problem when commit a very large
file. However, we cannot do f2
Hi Shawn,
On Wed, Sep 27, 2017 at 02:35:27PM -0700, Shawn Nematbakhsh wrote:
> For host commands that take a long time to process, cros ec can return
> early by signaling a EC_RES_IN_PROGRESS result. The host must then poll
> status with EC_CMD_GET_COMMS_STATUS until completion of the command.
>
On Tue, Nov 21 2017, Mikulas Patocka wrote:
> On Tue, 21 Nov 2017, Mike Snitzer wrote:
>
>> On Tue, Nov 21 2017 at 4:23pm -0500,
>> Mikulas Patocka wrote:
>>
>> > This is not correct:
>> >
>> >2206 static void dm_wq_work(struct work_struct *work)
>> >2207 {
>> >2208 struct
Gustavo A.,
> _vreg_ is being dereferenced before it is null checked, hence there is a
> potential null pointer dereference.
>
> Fix this by moving the pointer dereference after _vreg_ has been null
> checked.
Applied to 4.15/scsi-fixes, thank you!
--
Martin K. Petersen Oracle Linux Engin
The names of the idle states in the output of cpupower monitor command are
truncated to 4 characters. Hence, On POWER9, since the states are named
"stop0, stop1, stop2, stop4, stop11", this output is ambiguous
root:~# cpupower monitor
|Idle_Stats
PKG |CORE|CPU | snoo | stop | stop
On Tue, Nov 21, 2017 at 11:12:35AM -0600, Bob Tracy wrote:
> Apologies for the lack of detail, but the subject pretty much says it
> all. Xorg works fine with 4.13, but hangs on exit with 4.14.
>
> Logging in remotely and applying the "kill -9" sledgehammer has no
> effect. System logs don't sho
On Tue, Nov 21, 2017 at 7:33 PM, Andy Lutomirski wrote:
> I'm doing:
>
> /usr/bin/qemu-system-x86_64 -machine accel=kvm:tcg -cpu host -net none
> -nographic -kernel xen-4.8.2 -initrd './arch/x86/boot/bzImage' -m 2G
> -smp 2 -append console=com1
>
> With Linus' commit c8a0739b185d11d6e2ca7ad9f58358
Hi, all
I sent the patch series of Sony CXD2880 DVB-T2/T tuner + demodulator driver
version 4 on 13th/Oct.
I'd like to get better understanding of current review status for our codes.
Are there any comments, advices and review results for them?
Regards,
Takiguchi
On Tuesday 21 November 2017 08:38 PM, Deucher, Alexander wrote:
-Original Message-
From: Agrawal, Akshu
Sent: Tuesday, November 21, 2017 1:15 AM
To: Deucher, Alexander; 'Guenter Roeck'; Liam Girdwood; Mukunda,
Vijendar
Cc: Mark Brown; Jaroslav Kysela; Takashi Iwai; alsa-de...@alsa-proje
On 21/11/17 09:53, NeilBrown wrote:
> On Wed, May 10 2017, Ian Kent wrote:
>
>> The fstatat(2) and statx() calls can pass the flag AT_NO_AUTOMOUNT
>> which is meant to clear the LOOKUP_AUTOMOUNT flag and prevent triggering
>> of an automount by the call. But this flag is unconditionally cleared
>>
On Tue, Nov 21 2017 at 11:00pm -0500,
NeilBrown wrote:
> On Tue, Nov 21 2017, Mikulas Patocka wrote:
>
> > On Tue, 21 Nov 2017, Mike Snitzer wrote:
> >
> >> On Tue, Nov 21 2017 at 4:23pm -0500,
> >> Mikulas Patocka wrote:
> >>
> >> > This is not correct:
> >> >
> >> >2206 static void dm_
This sets up stack switching, including for SYSCALL. I think it's
in decent shape.
Known issues:
- I think we're going to want a way to turn the stack switching on and
off either at boot time or at runtime. It should be fairly straightforward
to make it work.
- I think the ORC unwinder
Currently, the GDT is an ad-hoc array of pages, one per CPU, in the
fixmap. Generalize it to be an array of a new struct cpu_entry_area
so that we can cleanly add new things to it.
Signed-off-by: Andy Lutomirski
---
arch/x86/include/asm/desc.h | 9 +
arch/x86/include/asm/fixmap.h | 3
This will simplify future changes that want scratch variables early in
the SYSENTER handler -- they'll be able to spill registers to the
stack. It also lets us get rid of a SWAPGS_UNSAFE_STACK user.
This does not depend on CONFIG_IA32_EMULATION because we'll want the
stack space even without IA32
The IST stacks are needed when an IST exception occurs and are
accessed before any kernel code at all runs. Move them into
cpu_entry_area.
Signed-off-by: Andy Lutomirski
---
arch/x86/include/asm/fixmap.h | 10 ++
arch/x86/kernel/cpu/common.c | 40 +--
Handling SYSCALL is tricky: the SYSCALL handler is entered with every
single register (except FLAGS), including RSP, live. It somehow needs
to set RSP to point to a valid stack, which means it needs to save the
user RSP somewhere and find its own stack pointer. The canonical way
to do this is wit
In case something goes wrong with unwind (not unlikely in case of
overflow), print the offending IP where we detected the overflow.
Signed-off-by: Andy Lutomirski
---
arch/x86/kernel/irq_64.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/x86/kernel/irq_64.c b/arch/
Historically, IDT entries from usermode have always gone directly
to the running task's kernel stack. Rearrange it so that we enter on
a percpu trampoline stack and then manually switch to the task's stack.
This touches a couple of extra cachelines, but it gives us a chance
to run some code before
That race has been fixed and code cleaned up for a while now.
Signed-off-by: Andy Lutomirski
---
arch/x86/kernel/irq.c | 12
1 file changed, 12 deletions(-)
diff --git a/arch/x86/kernel/irq.c b/arch/x86/kernel/irq.c
index 49cfd9fe7589..68e1867cca80 100644
--- a/arch/x86/kernel/irq.
By itself, this is useless. It gives us the ability to run some final
code before exit that cannnot run on the kernel stack. This could
include a CR3 switch a la KAISER or some kernel stack erasing, for
example. (Or even weird things like *changing* which kernel stack
gets used as an ASLR-streng
On 64-bit kernels, we used to assume that TSS.sp0 was the current
top of stack. With the addition of an entry trampoline, this will
no longer be the case. Store the current top of stack in TSS.sp1,
which is otherwise unused but shares the same cacheline.
Signed-off-by: Andy Lutomirski
---
arch
When we start using an entry trampoline, a #GP from userspace will
be delivered on the entry stack, not on the task stack. Fix the
espfix64 #DF fixup to set up #GP according to TSS.SP0, rather than
assuming that pt_regs + 1 == SP0. This won't change anything
without an entry stack, but it will ma
We currently have CPU 0's GDT at the top of the GDT range and
higher-numbered CPUs at lower addreses. This happens because the
fixmap is upside down (index 0 is the top of the fixmap).
Flip it so that GDTs are in ascending order by virtual address.
This will simplify a future patch that will gene
This has a secondary purpose: it puts the entry stack into a region
with a well-controlled layout. A subsequent patch will take
advantage of this to streamline the SYSCALL entry code to be able to
find it more easily.
Signed-off-by: Andy Lutomirski
---
arch/x86/entry/entry_32.S | 6 --
On Tue, Nov 21, 2017 at 8:11 PM, Andy Lutomirski wrote:
> On Tue, Nov 21, 2017 at 7:33 PM, Andy Lutomirski wrote:
>> I'm doing:
>>
>> /usr/bin/qemu-system-x86_64 -machine accel=kvm:tcg -cpu host -net none
>> -nographic -kernel xen-4.8.2 -initrd './arch/x86/boot/bzImage' -m 2G
>> -smp 2 -append co
I want SYSENTER_stack to have reliable overflow detection, which
means that it needs to be at the bottom of a page, not the top.
Move it to the beginning of struct tss_struct and page-align it.
Also add an assertion to make sure that the fixed hardware TSS
doesn't cross a page boundary.
Signed-of
I'm going to move SYSENTER_stack to the beginning of cpu_tss to help
detect overflow. Before this can happen, I need to fix several code
paths that hardcode assumptions about the old layout.
Reviewed-by: Thomas Gleixner
Signed-off-by: Andy Lutomirski
---
arch/x86/include/asm/desc.h | 2 +
The cpu_entry_area will contain stacks. Make sure that KASAN has
appropriate shadow mappings for them.
Cc: Andrey Ryabinin
Cc: Alexander Potapenko
Cc: Dmitry Vyukov
Cc: kasan-...@googlegroups.com
Signed-off-by: Andy Lutomirski
---
arch/x86/mm/kasan_init_64.c | 9 -
1 file changed, 8
We currently special-case stack overflow on the task stack. We're
going to start putting special stacks in the fixmap with a custom
layout, so they'll have guard pages, too. Teach the unwinder to be
able to unwind an overflow of any of the stacks.
Signed-off-by: Andy Lutomirski
---
arch/x86/ke
get_stack_info() doesn't currently know about the SYSENTER stack, so
unwinding will fail if we entered the kernel on the SYSENTER stack
and haven't fully switched off. Teach get_stack_info() about the
SYSENTER stack.
With future patches applied that run part of the entry code on the
SYSENTER stac
701 - 800 of 995 matches
Mail list logo
