[PATCH 0/2] kvm: vmx: CPUs without virtual NMIs

2017-11-06 Thread Paolo Bonzini
It turns out that Core 2 Duo machines only had virtual NMIs in some SKUs. Patch 1 adds back emulation of the NMI window, patch 2 allows testing it on modern processors as well. One eventinj.flat test (NMI after iret) fails as expected. Paolo Paolo Bonzini (2): kvm: vmx: Reinstate virtual NMI s

[PATCH 2/2] kvm: vmx: Allow disabling virtual NMI support

2017-11-06 Thread Paolo Bonzini
To simplify testing of these rarely used code paths, add a module parameter that turns it on. One eventinj.flat test (NMI after iret) fails when loading kvm_intel with vnmi=0. Signed-off-by: Paolo Bonzini --- arch/x86/kvm/vmx.c | 31 +-- 1 file changed, 21 insertions

Re: kernel panic: n_tty: init_tty

2017-11-06 Thread Greg KH
On Sun, Nov 05, 2017 at 02:04:39PM -0800, Eric Biggers wrote: > On Sun, Nov 05, 2017 at 11:34:34AM +0100, Greg KH wrote: > > On Sun, Nov 05, 2017 at 01:05:02AM -0800, syzbot wrote: > > > Hello, > > > > > > syzkaller hit the following crash on > > > b5ac3beb5a9f0ef0ea64cd85faf94c0dc4de0e42 > > > gi

Re: [RFT][PATCH v2 1/2] PM / domains: Rework governor code to be more consistent

2017-11-06 Thread Rafael J. Wysocki
On Mon, Nov 6, 2017 at 1:10 PM, Ulf Hansson wrote: > On 3 November 2017 at 12:47, Rafael J. Wysocki wrote: >> From: Rafael J. Wysocki >> >> The genpd governor currently uses negative PM QoS values to indicate >> the "no suspend" condition and 0 as "no restriction", but it doesn't >> use them con

Re: [PATCH net-next 4/5] net: dsa: lan9303: Remove unnecessary parentheses

2017-11-06 Thread Egil Hjelmeland
On 03. nov. 2017 15:54, Vivien Didelot wrote: Hi Egil, Egil Hjelmeland writes: If you send a v2, you may want to address the other parenthesis alignment issues found when running ./scripts/checkpatch -f on the lan9303* files. There is just one remaining alignment issue. Removing that would

Re: kernel panic: n_tty: init_tty

2017-11-06 Thread Greg KH
On Mon, Nov 06, 2017 at 01:14:00PM +0100, Dmitry Vyukov wrote: > On Sun, Nov 5, 2017 at 11:04 PM, Eric Biggers wrote: > > On Sun, Nov 05, 2017 at 11:34:34AM +0100, Greg KH wrote: > >> On Sun, Nov 05, 2017 at 01:05:02AM -0800, syzbot wrote: > >> > Hello, > >> > > >> > syzkaller hit the following cr

Re: [PATCH v2] usb:xhci fix panic in xhci_free_virt_devices_depth_first

2017-11-06 Thread Chen Yu
On 2017/11/6 19:32, Greg KH wrote: >> A simple process is as below: >> xhci_plat_probe() >>| >> usb_add_hcd() xhci_plat_remove() >> || >> find some device

Re: [PATCH 0/4] platform/x86: intel-vbtn: Add support for several more switches/buttons

2017-11-06 Thread Bastien Nocera
On Sun, 2017-11-05 at 14:31 +0200, Andy Shevchenko wrote: > On Fri, Nov 3, 2017 at 9:03 PM, Stefan Brüns > wrote: > > Currently, intel-vbtn only supports the most relevant buttons, > > although > > there are several more events, mostly in use by convertibles. > > > > This series adds support for

Re: [RFT][PATCH v2 1/2] PM / domains: Rework governor code to be more consistent

2017-11-06 Thread Ulf Hansson
[...] >>> static int dev_update_qos_constraint(struct device *dev, void *data) >>> { >>> s64 *constraint_ns_p = data; >>> - s32 constraint_ns = -1; >>> - >>> - if (dev->power.subsys_data && dev->power.subsys_data->domain_data) >>> - constraint_ns = >>> dev_gpd_

[PATCH] ACPI / PM: Blacklist the Low Power S0 Idle _DSM for Dell XPS13 9360

2017-11-06 Thread Rafael J. Wysocki
From: Rafael J. Wysocki At least one Dell XPS13 9360 is reported to have serious issues with the Low Power S0 Idle _DSM interface and since this machine model generally can do ACPI S3 just fine, add a blacklist entry to disable that interface for Dell XPS13 9360. Fixes: 8110dd281e15 (ACPI / slee

Re: general protection fault in sctp_stream_free

2017-11-06 Thread Neil Horman
On Sun, Nov 05, 2017 at 01:35:02AM -0700, syzbot wrote: > Hello, > > syzkaller hit the following crash on > 2a171788ba7bb61995e98e8163204fc7880f63b2 > git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console ou

Re: [RFT][PATCH v2 1/2] PM / domains: Rework governor code to be more consistent

2017-11-06 Thread Rafael J. Wysocki
On Mon, Nov 6, 2017 at 1:44 PM, Ulf Hansson wrote: > [...] > static int dev_update_qos_constraint(struct device *dev, void *data) { s64 *constraint_ns_p = data; - s32 constraint_ns = -1; - - if (dev->power.subsys_data && dev->power.subsys_data->d

Re: [PATCH v2] writeback: remove the unused function parameter

2017-11-06 Thread Jan Kara
On Fri 03-11-17 01:04:45, Wang Long wrote: > The parameter `struct bdi_writeback *wb` is not been used in the function > body. so we just remove it. > > Signed-off-by: Wang Long Looks good. You can add: Reviewed-by: Jan Kara Honz

Re: [PATCH 0/4] platform/x86: intel-vbtn: Add support for several more switches/buttons

2017-11-06 Thread Bastien Nocera
On Sun, 2017-11-05 at 14:31 +0200, Andy Shevchenko wrote: > On Fri, Nov 3, 2017 at 9:03 PM, Stefan Brüns > wrote: > > Currently, intel-vbtn only supports the most relevant buttons, > > although > > there are several more events, mostly in use by convertibles. > > > > This series adds support for

Re: Guaranteed allocation of huge pages (1G) using movablecore=N doesn't seem to work at all

2017-11-06 Thread Michal Hocko
On Sat 04-11-17 11:55:14, Maxim Levitsky wrote: > Hi! > > My system has 64G of ram and I want to create 32 1G huge pages to use > in KVM virtualization, > on demand, only when VM is running. > > So I booted the kernel with > 'hugepagesz=1G hugepages=0 default_hugepagesz=1G movablecore=40G' Why d

Re: linux-next: manual merge of the tip tree with the pm tree

2017-11-06 Thread Rafael J. Wysocki
On Monday, November 6, 2017 3:10:40 AM CET Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the tip tree got a conflict in: > > drivers/idle/intel_idle.c > > between commit: > > 0563bb7ba67e ("intel_idle: replace conditionals with > static_cpu_has(X86_FEATURE_ARAT)") > >

Re: [PATCH 0001/0001] format idle IP output func+offset/length

2017-11-06 Thread Josh Poimboeuf
On Mon, Nov 06, 2017 at 06:52:03PM +0800, Liu, Changcheng wrote: > kaslr feature is enabled in kernel. > Remove kernel text address when dumping idle IP info > > Signed-off-by: Liu Changcheng > Signed-off-by: Jerry Liu > > diff --git a/lib/nmi_backtrace.c b/lib/nmi_backtrace.c > index 0bc0a35..

Re: [PATCH] KVM: VMX: replace move_msr_up with swap macro

2017-11-06 Thread Gustavo A. R. Silva
Hi Paolo, Quoting Paolo Bonzini : - Original Message - From: "Gustavo A. R. Silva" To: "Paolo Bonzini" , "Radim Krčmář" , "Thomas Gleixner" , "Ingo Molnar" , "H. Peter Anvin" , x...@kernel.org Cc: k...@vger.kernel.org, linux-kernel@vger.kernel.org, "Gustavo A. R. Silva" Sent:

[PATCH 1/2] ARM: OMAP2+: CM: make some pointers and function arguments as const

2017-11-06 Thread Bhumika Goyal
Make the pointer cm_ll_data of type cm_ll_data as const as it does not modify the fields of the structure it points too. After this change, make the argument of cm_register function as const as it is used to initialise cm_ll_data or used inside an if condition. Make the pointer argument of cm_unreg

[PATCH 0/2] ARM: OMAP2+: CM: make some structures, function arguments and pointers as const

2017-11-06 Thread Bhumika Goyal
Make some pointers and function arguments as const. After this change, make the structures of type cm_ll_data as const. Bhumika Goyal (2): ARM: OMAP2+: CM: make some pointers and function arguments as const ARM: OMAP2+: CM: make cm_ll_data structures as const arch/arm/mach-omap2/cm.h

Re: possible deadlock in generic_file_write_iter

2017-11-06 Thread Jan Kara
On Mon 06-11-17 09:32:35, Dmitry Vyukov wrote: > On Mon, Nov 6, 2017 at 6:29 AM, Al Viro wrote: > > On Sun, Nov 05, 2017 at 02:25:00AM -0800, syzbot wrote: > > > >> loop0/2986 is trying to acquire lock: > >> (&sb->s_type->i_mutex_key#9){}, at: [] inode_lock > >> include/linux/fs.h:712 [inline

[PATCH 2/2] ARM: OMAP2+: CM: make cm_ll_data structures as const

2017-11-06 Thread Bhumika Goyal
Make these const as they are only getting passed to the functions cm_register and cm_unregister having the arguments as const. Signed-off-by: Bhumika Goyal --- arch/arm/mach-omap2/cm2xxx.c | 2 +- arch/arm/mach-omap2/cm33xx.c | 2 +- arch/arm/mach-omap2/cm3xxx.c | 2 +- arch/arm/mach

Re: [PATCH] thunderbolt: tb: fix use after free in tb_activate_pcie_devices

2017-11-06 Thread Gustavo A. R. Silva
Quoting Mika Westerberg : On Sat, Nov 04, 2017 at 11:52:54PM -0500, Gustavo A. R. Silva wrote: Add a ̣̣continue statement in order to avoid using a previously free'd pointer tunnel in list_add. Addresses-Coverity-ID: 1415336 Fixes: 9d3cce0b6136 ("thunderbolt: Introduce thunderbolt bus and c

Re: [PATCH 0/5] TTY/JSM coding style fixes

2017-11-06 Thread Guilherme G. Piccoli
On 11/05/2017 03:06 AM, Gimcuan Hui wrote: > This patch set fixes several warnings and errors reported > by checkpatch.pl. > > Gimcuan Hui (5): > tty: serial: jsm: change the type of local variable > tty: serial: jsm: add blank line after declarations > tty: serial: jsm: delete space between

[PATCH] video: fbdev: intelfb: remove redundant variables

2017-11-06 Thread Colin King
From: Colin Ian King Variables err_max, err_target and f_best are being assigned values but these are never read, hence they are redundant variables and can be removed. Cleans up clang warnings: drivers/video/fbdev/intelfb/intelfbhw.c:946:2: warning: Value stored to 'err_max' is never read drive

[PATCH 1/2] objtool: Add a comment for the unreachable annotation macros

2017-11-06 Thread Josh Poimboeuf
Add a comment for the unreachable annotation macros to explain their purpose and the '__COUNTER__' label hack. Suggested-by: Linus Torvalds Signed-off-by: Josh Poimboeuf --- include/linux/compiler.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/linux/compiler.h b/include/linu

[PATCH 2/2] objtool: Make unreachable annotation inline asms explicitly volatile

2017-11-06 Thread Josh Poimboeuf
Add 'volatile' to the unreachable annotation macro inline asm statements. They're already implicitly volatile because they don't have output constraints, but it's clearer and more robust to make them explicitly volatile. Suggested-by: Linus Torvalds Signed-off-by: Josh Poimboeuf --- include/li

Re: [PATCH] netfilter: ip6_tables: remove redundant assignment to e

2017-11-06 Thread Pablo Neira Ayuso
On Tue, Oct 17, 2017 at 01:02:00PM +0100, Colin King wrote: > From: Colin Ian King > > The assignment to variable e is redundant since the same assignment > occurs just a few lines later, hence it can be removed. Cleans up > clang warning: warning: Value stored to 'e' is never read Seems like n

[PATCH v2 0/2] objtool: sync cleanups

2017-11-06 Thread Josh Poimboeuf
Here are some cleanups to improve future warnings about copied files getting out of sync. Josh Poimboeuf (2): objtool: Move synced files to their original relative locations objtool: Move sync check to a script tools/objtool/.gitignore | 2 +- tools/objtool/Makefil

[PATCH v2 2/2] objtool: Move sync check to a script

2017-11-06 Thread Josh Poimboeuf
Replace the nasty diff checks in the objtool Makefile with a clean bash script, and make the warnings more specific. Heavily inspired by tools/perf/check-headers.sh. Suggested-by: Ingo Molnar Signed-off-by: Josh Poimboeuf --- tools/objtool/Makefile | 16 +--- tools/objtool/syn

Re: [PATCH v6 00/12] gpio: Tight IRQ chip integration

2017-11-06 Thread Linus Walleij
On Sat, Nov 4, 2017 at 12:50 AM, Grygorii Strashko wrote: > On 11/03/2017 05:50 PM, Linus Walleij wrote: >> I guess I will consider queueing them already for v4.15 if >> Torvalds churns out another -rc on sunday, I do not >> doubt that you will finish it as we have discussed with banks and >> all

[PATCH v2 1/2] objtool: Move synced files to their original relative locations

2017-11-06 Thread Josh Poimboeuf
This will enable more straightforward comparisons, and it also makes the files 100% identical. Suggested-by: Ingo Molnar Signed-off-by: Josh Poimboeuf --- tools/objtool/.gitignore | 2 +- tools/objtool/Makefile | 22 --

Re: [RFC PATCH 5/7] power: supply: Add type for USB PD PPS chargers

2017-11-06 Thread Sebastian Reichel
Hi, On Wed, Nov 01, 2017 at 05:03:13PM +, Adam Thomson wrote: > This adds a type to represent USB PPS chargers as defined in the > USB Power Delivery Specification Revision 3.0 V1.1 > > Signed-off-by: Adam Thomson Reviewed-by: Sebastian Reichel -- Sebastian > drivers/power/supply/power_

usb/media/uvc: slab-out-of-bounds in uvc_probe

2017-11-06 Thread Andrey Konovalov
Hi! I've got the following report while fuzzing the kernel with syzkaller. On commit 39dae59d66acd86d1de24294bd2f343fd5e7a625 (4.14-rc8). It seems that type == UVC_ITT_CAMERA | 0x8000, that's why the (type == UVC_ITT_CAMERA) check fails and (UVC_ENTITY_TYPE(term) == UVC_ITT_CAMERA) passes, so le

usb/media/tm6000: use-after-free in tm6000_read_write_usb

2017-11-06 Thread Andrey Konovalov
Hi! I've got the following report while fuzzing the kernel with syzkaller. On commit 39dae59d66acd86d1de24294bd2f343fd5e7a625 (4.14-rc8). usb 1-1: USB disconnect, device number 11 tm6000: disconnecting tm6000 #0 xc2028 0-0061: destroying instance =

Re: [PATCH v3] dmaengine: rcar-dmac: use TCRB instead of TCR for residue

2017-11-06 Thread Geert Uytterhoeven
Hi Morimoto-san, On Mon, Nov 6, 2017 at 2:24 AM, Kuninori Morimoto wrote: >> Large serial console input (copy and pasting long lines) works, as that uses >> DMA. Small serial console input (typing) doesn't work. >> >> Apparently for the serial port, TCR contains the value we need (< 0x20), >> whi

usb/net/qmi_wwan: divide error in qmi_wwan_probe/usbnet_probe

2017-11-06 Thread Andrey Konovalov
Hi! I've got the following report while fuzzing the kernel with syzkaller. On commit 39dae59d66acd86d1de24294bd2f343fd5e7a625 (4.14-rc8). qmi_wwan 1-1:0.4: cdc-wdm0: USB WDM device divide error: [#1] PREEMPT SMP KASAN Modules linked in: CPU: 0 PID: 24 Comm: kworker/0:1 Not tainted 4.14.0-rc

usb/media/technisat: slab-out-of-bounds in technisat_usb2_rc_query

2017-11-06 Thread Andrey Konovalov
Hi! I've got the following report while fuzzing the kernel with syzkaller. On commit 39dae59d66acd86d1de24294bd2f343fd5e7a625 (4.14-rc8). It seems that there's no check of the received buffer length in technisat_usb2_get_ir(). == B

[PATCH] [net-next?] of: add of_property_read_variable_* dummy helpers

2017-11-06 Thread Arnd Bergmann
Commit a67e9472da42 ("of: Add array read functions with min/max size limits") added a new interface for reading variable-length arrays from DT properties. One user was added in dsa recently and this causes a build error because that code can be built with CONFIG_OF disabled: net/dsa/dsa2.c: In fun

[PATCH] ASoC: intel: initialize return value properly

2017-11-06 Thread Arnd Bergmann
When CONFIG_SND_SOC_HDAC_HDMI is disabled, we can run into an uninitialized variable: sound/soc/intel/skylake/skl.c: In function 'skl_resume': sound/soc/intel/skylake/skl.c:326:6: error: 'ret' may be used uninitialized in this function [-Werror=maybe-uninitialized] I have run into this on today'

Re: possible deadlock in generic_file_write_iter

2017-11-06 Thread Al Viro
On Mon, Nov 06, 2017 at 02:15:44PM +0100, Jan Kara wrote: > > Should we annotate these inodes with different lock types? Or use > > nesting annotations? > > Well, you'd need to have a completely separate set of locking classes for > each filesystem to avoid false positives like these. And that wo

[PATCH] clocksource/drivers/timer-of: mark timer_of_exit as __init

2017-11-06 Thread Arnd Bergmann
The newly added function triggers a harmless Kbuild warning because of a missing annotation: WARNING: vmlinux.o(.text+0x448098): Section mismatch in reference from the function timer_of_exit() to the function .init.text:timer_clk_exit() The function timer_of_exit() references the function __init

[PATCH] [fixup timers-conversion] ARM: footbridge: add missing semicolon

2017-11-06 Thread Arnd Bergmann
The timer_setup() conversion included a small typo that breaks the build: arch/arm/mach-footbridge/dc21285.c: In function 'dc21285_enable_error': arch/arm/mach-footbridge/dc21285.c:145:2: error: expected ';' before 'else' else if (timer == &perr_timer) Fixes: b7bea32f0cc4 ("ARM: footbridge: Con

[PATCH] mpt3sas: fix dma_addr_t casts

2017-11-06 Thread Arnd Bergmann
The newly added base_make_prp_nvme function triggers a build warning on some 32-bit configurations: drivers/scsi/mpt3sas/mpt3sas_base.c: In function 'base_make_prp_nvme': drivers/scsi/mpt3sas/mpt3sas_base.c:1664:13: error: cast from pointer to integer of different size [-Werror=pointer-to-int-cas

Re: possible deadlock in generic_file_write_iter

2017-11-06 Thread Dmitry Vyukov
On Mon, Nov 6, 2017 at 2:33 PM, Al Viro wrote: > On Mon, Nov 06, 2017 at 02:15:44PM +0100, Jan Kara wrote: > >> > Should we annotate these inodes with different lock types? Or use >> > nesting annotations? >> >> Well, you'd need to have a completely separate set of locking classes for >> each file

[PATCH] remoteproc: qcom: use %pap format string for phys_addr_t

2017-11-06 Thread Arnd Bergmann
We cannot cast a phys_addr_t variable to a pointer on 32-bit architectures with CONFIG_PHYS_ADDR_T_64BIT set: In file included from include/linux/kernel.h:14:0, from include/linux/clk.h:16, from drivers/remoteproc/qcom_q6v5_pil.c:18: drivers/remoteproc/qcom_q6v5_p

[PATCH] sysctl: add register_sysctl() dummy helper

2017-11-06 Thread Arnd Bergmann
The register_sysctl() function has been around for five years with commit fea478d4101a ("sysctl: Add register_sysctl for normal sysctl users") but now that arm64 started using it, I ran into a compile error: arch/arm64/kernel/armv8_deprecated.c: In function 'register_insn_emulation_sysctl': arch/

[PATCH] refcount_t: documentation for memory ordering differences

2017-11-06 Thread Elena Reshetova
Some functions from refcount_t API provide different memory ordering guarantees that their atomic counterparts. This adds a document outlining the differences and showing examples. Signed-off-by: Elena Reshetova --- Documentation/refcount-vs-atomic.txt | 234 +++

Re: [PATCH] tty: fix tty_ldisc_receive_buf() documentation

2017-11-06 Thread Sebastian Reichel
Hi, On Fri, Nov 03, 2017 at 03:18:05PM +0100, Johan Hovold wrote: > The tty_ldisc_receive_buf() helper returns the number of bytes > processed so drop the bogus "not" from the kernel doc comment. > > Fixes: 8d082cd300ab ("tty: Unify receive_buf() code paths") > Signed-off-by: Johan Hovold > ---

[PATCH] mm: do not rely on preempt_count in print_vma_addr (was: Re: [PATCH] mm: use in_atomic() in print_vma_addr())

2017-11-06 Thread Michal Hocko
On Mon 06-11-17 13:12:22, Michal Hocko wrote: > On Mon 06-11-17 13:00:25, Peter Zijlstra wrote: > > On Mon, Nov 06, 2017 at 11:43:54AM +0100, Michal Hocko wrote: > > > > Yes the comment is very much accurate. > > > > > > Which suggests that print_vma_addr might be problematic, right? > > > Shouldn

Re: [PATCH 13/14] netfilter/ipvs: Use %pS printk format for direct addresses

2017-11-06 Thread Pablo Neira Ayuso
On Mon, Oct 09, 2017 at 07:52:24AM +0200, Simon Horman wrote: > On Wed, Sep 06, 2017 at 10:28:00PM +0200, Helge Deller wrote: > > The debug and error printk functions in ipvs uses wrongly the %pF instead of > > the %pS printk format specifier for printing symbols for the address > > returned > > b

Re: [RFT][PATCH v2 0/2] PM / QoS: Device resume latency framework fix

2017-11-06 Thread Geert Uytterhoeven
Hi Rafael, On Fri, Nov 3, 2017 at 12:42 PM, Rafael J. Wysocki wrote: > On Thursday, November 2, 2017 12:00:27 AM CET Rafael J. Wysocki wrote: >> This series is a replacement for commit 0cc2b4e5a020 (PM / QoS: Fix device >> resume latency PM QoS) that had to be reverted due to problems introduced

Re: [PATCH] netfilter: ebtables: clean up initialization of buf

2017-11-06 Thread Pablo Neira Ayuso
On Mon, Oct 16, 2017 at 11:24:02AM +0100, Colin King wrote: > From: Colin Ian King > > buf is initialized to buf_start and then set on the next statement > to buf_start + offsets[i]. Clean this up to just initialize buf > to buf_start + offsets[i] to clean up the clang build warning: > "Value st

Re: [RFC PATCH] scripts: checkpatch.pl: remove obsolete in_atomic rule

2017-11-06 Thread Michal Hocko
On Sat 04-11-17 03:08:06, Yang Shi wrote: > checkpatch.pl still reports the below in_atomic warning: > > WARNING: use of in_atomic() is incorrect outside core kernel code > + if (in_atomic()) > > But, in_atomic() has been used outside kernel dir for a long time, and > even drivers. So, remo

Re: [PATCH v2] usb:xhci fix panic in xhci_free_virt_devices_depth_first

2017-11-06 Thread Mathias Nyman
On 06.11.2017 14:36, Chen Yu wrote: On 2017/11/6 19:32, Greg KH wrote: A simple process is as below: xhci_plat_probe() | usb_add_hcd() xhci_plat_remove() ||

[PATCH 1/3] rtlwifi: fix uninitialized rtlhal->last_suspend_sec time

2017-11-06 Thread Arnd Bergmann
We set rtlhal->last_suspend_sec to an uninitialized stack variable, but unfortunately gcc never warned about this, I only found it while working on another patch. I opened a gcc bug for this. Presumably the value of rtlhal->last_suspend_sec is not all that important, but it does get used, so we pr

[PATCH 2/3] rtlwifi: use ktime_get_real_seconds() for suspend time

2017-11-06 Thread Arnd Bergmann
do_gettimeofday() is deprecated and slower than necessary for the purpose of reading the seconds. This changes rtl_op_suspend/resume to use ktime_get_real_seconds() instead, which is simpler and avoids confusion about whether it is y2038-safe or not. Signed-off-by: Arnd Bergmann --- drivers/net/

[PATCH] [media] Don't do DMA on stack for firmware upload in the AS102 driver

2017-11-06 Thread Michele Baldessari
Firmware load on AS102 is using the stack which is not allowed any longer. We currently fail with: kernel: transfer buffer not dma capable kernel: [ cut here ] kernel: WARNING: CPU: 0 PID: 598 at drivers/usb/core/hcd.c:1595 usb_hcd_map_urb_for_dma+0x41d/0x620 kernel: Modul

Re: [PATCH] tty: fix tty_ldisc_receive_buf() documentation

2017-11-06 Thread Johan Hovold
On Mon, Nov 06, 2017 at 02:39:44PM +0100, Sebastian Reichel wrote: > Hi, > > On Fri, Nov 03, 2017 at 03:18:05PM +0100, Johan Hovold wrote: > > The tty_ldisc_receive_buf() helper returns the number of bytes > > processed so drop the bogus "not" from the kernel doc comment. > > > > Fixes: 8d082cd30

[PATCH 3/3] rtlwifi: drop unused ppsc->last_wakeup_time

2017-11-06 Thread Arnd Bergmann
The calculation of ppsc->last_wakeup_time is not y2038-safe, but the variable is not used at all, so we can simply drop it. Signed-off-by: Arnd Bergmann --- drivers/net/wireless/realtek/rtlwifi/rtl8821ae/hw.c | 5 - drivers/net/wireless/realtek/rtlwifi/wifi.h | 2 -- 2 files changed,

[PATCH] drm/rockchip: add CONFIG_OF dependency for lvds

2017-11-06 Thread Arnd Bergmann
Build-testing on randconfig kernels revealed a dependency in the newly added lvds sub-driver: drivers/gpu/drm/rockchip/rockchip_lvds.c: In function 'rockchip_lvds_bind': drivers/gpu/drm/rockchip/rockchip_lvds.c:380:24: error: 'struct drm_bridge' has no member named 'of_node' remote = lvds->bri

Re: [PATCH v2] usb:xhci fix panic in xhci_free_virt_devices_depth_first

2017-11-06 Thread Guenter Roeck
On Mon, Nov 6, 2017 at 6:00 AM, Mathias Nyman wrote: > On 06.11.2017 14:36, Chen Yu wrote: >> >> >> >> On 2017/11/6 19:32, Greg KH wrote: A simple process is as below: xhci_plat_probe() | usb_add_hcd() xhci_plat_remove()

Re: [nohz_full/apic] multiple timer interrupts a second

2017-11-06 Thread Luiz Capitulino
On Sat, 04 Nov 2017 10:14:52 +0100 Nicolai Stange wrote: > Hi Luiz, > > [John Stultz added to CC] > > On Fri, Nov 03 2017, Luiz Capitulino wrote: > > > [CC'ing lkml this time] > > > > I've observed that smp_apic_timer_interrupt() is sometimes called > > two or more times a second on a nohz_ful

[PATCH] s390/dasd: avoid calling do_gettimeofday()

2017-11-06 Thread Arnd Bergmann
do_gettimeofday() is deprecated because it's not y2038-safe on 32-bit architectures. Since it is basically a wrapper around ktime_get_real_ts64(), we can just call that function directly instead. Signed-off-by: Arnd Bergmann --- drivers/s390/block/dasd_eer.c | 16 1 file changed

[PATCH] bnxt: fix bnxt_hwrm_fw_set_time for y2038

2017-11-06 Thread Arnd Bergmann
On 32-bit architectures, rtc_time_to_tm() returns incorrect results in 2038 or later, and do_gettimeofday() is broken for the same reason. This changes the code to use ktime_get_real_seconds() and time64_to_tm() instead, both of them are 2038-safe, and we can also get rid of the CONFIG_RTC_LIB dep

[PATCH] rt2x00: use monotonic timestamps for frame dump

2017-11-06 Thread Arnd Bergmann
rt2x00 uses the deprecated do_gettimeofday() function to get a timestamp for its debugfs "dump" file interface. The timestamp is using an unsigned 32-bit value, so we could make it work until 2106 by using ktime_get_real_ts64(), but it seems better to use monotonic times, as we normally want for t

Re: [PATCH 3/3] Documentation: add Actions S900 clock bindings

2017-11-06 Thread Manivannan Sadhasivam
On Wed, Nov 01, 2017 at 07:04:48PM -0500, Rob Herring wrote: > On Wed, Nov 01, 2017 at 01:24:23AM +0530, Manivannan Sadhasivam wrote: > > This patch adds clock bindings for Actions Semi S900 SoC. > > "dt-bindings: clock: " for the subject. > > This patch should come before the dts and driver chan

Re: [PATCH 1/1] ice1712: tiny patch defining i2c eeprom addr to header file

2017-11-06 Thread Takashi Iwai
On Sun, 05 Nov 2017 21:11:01 +0100, Konstantinos Tsimpoukas wrote: > > Signed-off-by: Konstantinos Tsimpoukas Applied, thanks. Takashi

Re: usb/net/qmi_wwan: divide error in qmi_wwan_probe/usbnet_probe

2017-11-06 Thread Bjørn Mork
Andrey Konovalov writes: > Hi! > > I've got the following report while fuzzing the kernel with syzkaller. Thanks. It would have helped a lot of you said *what* you were fuzzing, though But based on where the bug is, I assume it is USB descriptors? > On commit 39dae59d66acd86d1de24294bd2f3

[PATCH] media: av7110: avoid 2038 overflow in debug print

2017-11-06 Thread Arnd Bergmann
Using the deprecated do_gettimeofday() in print_time() will overflow in 2038 on 32-bit architectures. It'sbetter to use a structure that is safe everywhere. While we're at it, fix the missing leading zeroes on the sub-second portion. Signed-off-by: Arnd Bergmann --- drivers/media/pci/ttpci/av711

[PATCH] media: rc: Replace timeval with ktime_t in imon.c

2017-11-06 Thread Arnd Bergmann
From: Chunyan Zhang This patch changes the 32-bit time type (timeval) to the 64-bit one (ktime_t), since 32-bit time types will break in the year 2038. I use ktime_t instead of all uses of timeval in imon.c This patch also changes do_gettimeofday() to ktime_get() accordingly, since ktime_get re

Re: [PATCH 2/3] clk: owl: add clock driver for Actions S900 SoC

2017-11-06 Thread Manivannan Sadhasivam
On Wed, Nov 01, 2017 at 07:02:46PM -0500, Rob Herring wrote: > On Wed, Nov 01, 2017 at 01:24:22AM +0530, Manivannan Sadhasivam wrote: > > This patch adds clock driver for Actions Semi OWL > > series S900 SoC. > > > > Signed-off-by: Manivannan Sadhasivam > > --- > > MAINTAINERS

Re: [PATCH 1/3] f2fs: avoid using __GFP_NOFAIL

2017-11-06 Thread Michal Hocko
On Sun 05-11-17 21:53:28, Chao Yu wrote: > From: Chao Yu > > We will keep __add_ino_entry success all the time, for ENOMEM failure > case, we have already handled it with an opened loop code, so we don't > have to use redundant __GFP_NOFAIL in radix_tree_preload, remove it. Why do you think an o

Re: [PATCH v3] display: panel: Add Mitsubishi aa070mc01 display support (800x480)

2017-11-06 Thread Rob Herring
On Fri, Oct 20, 2017 at 5:18 PM, Lukasz Majewski wrote: > This commit adds support for Mitsubishi aa070mc01 TFT panel working > with 8 bit ISP mode (pin 19 "mode" HIGH for 20 pin TFT connector). > > Signed-off-by: Lukasz Majewski > --- > Changes for v2: > - Place the code sorted alphabetically >

[PATCH v1] platform/x86: pmc_atom: Fix parent clocks

2017-11-06 Thread Andy Shevchenko
PLL or XTAL is a choice of parents. They are not dependent to each other (direct citation): The source of the frequencies can be XTAL or PLL, depending on the configuration. Any of the two available frequencies can be selected for each of the platform clocks. According to

Re: [PATCH] mm: do not rely on preempt_count in print_vma_addr

2017-11-06 Thread Vlastimil Babka
On 11/06/2017 02:40 PM, Michal Hocko wrote: > On Mon 06-11-17 13:12:22, Michal Hocko wrote: >> On Mon 06-11-17 13:00:25, Peter Zijlstra wrote: >>> On Mon, Nov 06, 2017 at 11:43:54AM +0100, Michal Hocko wrote: > Yes the comment is very much accurate. Which suggests that print_vma_addr

Re: [PATCH v4] i2c: aspeed: Deassert reset in probe

2017-11-06 Thread Rob Herring
On Sun, Nov 5, 2017 at 6:49 AM, Wolfram Sang wrote: > On Wed, Nov 01, 2017 at 10:53:30AM +1030, Joel Stanley wrote: >> In order to use i2c from a cold boot, the i2c peripheral must be taken >> out of reset. We request a shared reset controller each time a bus >> driver is loaded, as the reset is s

Re: [PATCH v2] staging: fsl-mc: move bus driver out of staging

2017-11-06 Thread Laurentiu Tudor
On 11/03/2017 05:17 PM, Greg KH wrote: > On Thu, Aug 31, 2017 at 06:04:30PM +0200, Greg KH wrote: >> On Mon, Aug 28, 2017 at 01:54:05PM +0300, laurentiu.tu...@nxp.com wrote: >>> From: Stuart Yoder >>> >>> Move the source files out of staging into their final locations: >>>-include files in d

[PATCH net-next] net: dsa: lan9303: Drop port range check

2017-11-06 Thread Egil Hjelmeland
Now that ds->num_ports is 3, there is no need to check range of "port" parameter. Signed-off-by: Egil Hjelmeland --- drivers/net/dsa/lan9303-core.c | 27 --- 1 file changed, 4 insertions(+), 23 deletions(-) diff --git a/drivers/net/dsa/lan9303-core.c b/drivers/net/dsa/la

Re: [PATCH 1/3] rtlwifi: fix uninitialized rtlhal->last_suspend_sec time

2017-11-06 Thread Larry Finger
On 11/06/2017 07:55 AM, Arnd Bergmann wrote: We set rtlhal->last_suspend_sec to an uninitialized stack variable, but unfortunately gcc never warned about this, I only found it while working on another patch. I opened a gcc bug for this. Presumably the value of rtlhal->last_suspend_sec is not all

[PATCH] usb: dvb-usb-v2: dvb_usb_core: remove redundant code in dvb_usb_fe_sleep

2017-11-06 Thread Gustavo A. R. Silva
Check on return value and goto instruction is redundant as the code that follows is the goto label err. Addresses-Coverity-ID: 1268783 Signed-off-by: Gustavo A. R. Silva --- drivers/media/usb/dvb-usb-v2/dvb_usb_core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/

Re: [PATCH] btrfs/volumes: Improve unlocking of a mutex in __btrfs_balance()

2017-11-06 Thread David Sterba
On Mon, Nov 06, 2017 at 09:04:37AM +0100, SF Markus Elfring wrote: > > * Adjust jump targets so that a call of the function "mutex_unlock" > can be better reused for error cases at the end of this function. > > * Replace three calls by goto statements. > > This issue was detected by using the

Re: [PATCH] ipvs: Fix inappropriate output of procfs

2017-11-06 Thread Pablo Neira Ayuso
On Sun, Oct 15, 2017 at 05:11:28PM +0300, Julian Anastasov wrote: > On Sun, 15 Oct 2017, KUWAZAWA Takuya wrote: > > > Information about ipvs in different network namespace can be seen via > > procfs. > > > > How to reproduce: > > > > # ip netns add ns01 > > # ip netns add ns02 > > # ip ne

RE: [v11,1/4] drivers: jtag: Add JTAG core driver

2017-11-06 Thread Oleksandr Shamray
Hi, Thanks for review> > -Original Message- > From: Chip Bilbrey [mailto:c...@bilbrey.org] > Sent: Monday, November 6, 2017 12:33 AM > To: Oleksandr Shamray > Cc: gre...@linuxfoundation.org; a...@arndb.de; linux- > ker...@vger.kernel.org; linux-arm-ker...@lists.infradead.org; > devicet..

[PATCH] scsi: Remove null check before kfree

2017-11-06 Thread Himanshu Jha
Kfree on NULL pointer is a no-op and therefore checking is redundant. Done using Coccinelle. Semantic patch used : @@ expression E; @@ - if (E != NULL) { kfree(E); } + kfree(E); @@ expression E; @@ - if (E != NULL) { kfree(E); E = NULL; } + kfree(E); + E = NULL; Signed-off-by: Himanshu Jha ---

Re: [PATCH] mm: do not rely on preempt_count in print_vma_addr

2017-11-06 Thread Michal Hocko
On Mon 06-11-17 15:19:46, Vlastimil Babka wrote: > On 11/06/2017 02:40 PM, Michal Hocko wrote: > > On Mon 06-11-17 13:12:22, Michal Hocko wrote: > >> On Mon 06-11-17 13:00:25, Peter Zijlstra wrote: > >>> On Mon, Nov 06, 2017 at 11:43:54AM +0100, Michal Hocko wrote: > > Yes the comment is very m

Re: [PATCH] display: panel: Add Tianma tm070rvhg71 display support (800x480)

2017-11-06 Thread Rob Herring
On Fri, Oct 27, 2017 at 3:18 AM, Lukasz Majewski wrote: > Hi Rob, > >> On Sat, Oct 21, 2017 at 12:10:03AM +0200, Lukasz Majewski wrote: >> > Signed-off-by: Lukasz Majewski >> > --- >> > .../bindings/display/panel/tianma,tm070rvhg71.txt | 7 ++ >> > drivers/gpu/drm/panel/panel-simple.c

Re: WARNING in task_participate_group_stop

2017-11-06 Thread Oleg Nesterov
On 11/06, Jamie Iles wrote: > > I'm unable to reproduce the warning in qemu with SMP (on a 32 CPU VM). Neither me. Perhaps because I tried this test-case on the minimal system with /bin/sh running as init process. > Instead I get the following instant traceback which is different to what > you r

Re: [PATCH] [net-next?] of: add of_property_read_variable_* dummy helpers

2017-11-06 Thread Rob Herring
On Mon, Nov 6, 2017 at 7:26 AM, Arnd Bergmann wrote: > Commit a67e9472da42 ("of: Add array read functions with min/max size > limits") added a new interface for reading variable-length arrays from > DT properties. One user was added in dsa recently and this causes a > build error because that code

Re: [PATCH 3.18 00/27] 3.18.80-stable review

2017-11-06 Thread Guenter Roeck
On 11/06/2017 03:27 AM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 3.18.80 release. There are 27 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be m

[PATCH] IB/ocrdma_hw: remove unnecessary code in ocrdma_mbx_dealloc_lkey

2017-11-06 Thread Gustavo A. R. Silva
Check on return value and goto label mbx_err are unnecessary. Addresses-Coverity-ID: 1268780 Signed-off-by: Gustavo A. R. Silva --- drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c b/drivers/

Re: [PATCH] ieee802154: mrf24j40: fix incorrect mask in mrf24j40_stop

2017-11-06 Thread Alan Ott
On 11/06/2017 06:13 AM, Stefan Schmidt wrote: Hello Alan. On 10/31/2017 07:31 AM, Gustavo A. R. Silva wrote: It seems that this is a copy/paste error and the proper bit masking is: BIT_TXNIE | BIT_RXIE This issue was detected with the help of Coccinelle. Reported-by: Julia Lawall Signed-off-

Re: [PATCH v6 00/12] gpio: Tight IRQ chip integration

2017-11-06 Thread Thierry Reding
On Mon, Nov 06, 2017 at 02:22:22PM +0100, Linus Walleij wrote: > On Sat, Nov 4, 2017 at 12:50 AM, Grygorii Strashko > wrote: > > On 11/03/2017 05:50 PM, Linus Walleij wrote: > > >> I guess I will consider queueing them already for v4.15 if > >> Torvalds churns out another -rc on sunday, I do not

Re: [Part2 PATCH v7 34/38] KVM: SVM: Add support for SEV LAUNCH_SECRET command

2017-11-06 Thread Borislav Petkov
On Wed, Nov 01, 2017 at 04:17:19PM -0500, Brijesh Singh wrote: > The command is used for injecting a secret into the guest memory region. > > Cc: Thomas Gleixner > Cc: Ingo Molnar > Cc: "H. Peter Anvin" > Cc: Paolo Bonzini > Cc: "Radim Krčmář" > Cc: Joerg Roedel > Cc: Borislav Petkov > Cc:

Re: [RFT][PATCH v2 1/2] PM / domains: Rework governor code to be more consistent

2017-11-06 Thread Ulf Hansson
[...] >>> >>> So I guess I'll simply evaluate dev_pm_qos_read_value(dev) if >>> subsys_data or subsys_data->domain_data is not there. >> >> Yes. >> >> However, if it returns -1, what value should you pick? 0? > > Without the second patch, -1 will just mean "no suspend", so the > parent cannot be s

Re: [PATCH 1/3] nvme: do not check for ns on rw path

2017-11-06 Thread Keith Busch
On Mon, Nov 06, 2017 at 10:13:24AM +0100, Christoph Hellwig wrote: > On Sat, Nov 04, 2017 at 09:38:45AM -0600, Keith Busch wrote: > > That's not quite right. For non-PI metadata formats, we use the > > 'nop_profile', which gets the metadata buffer allocated so we can safely > > use a metadata forma

Re: Regression still in next for drop migrate type checks

2017-11-06 Thread Tony Lindgren
e in hands. The fix has been posted [1] and Andrew has picked it > up few days ago. Could you try to apply that patch? It will show up in > linux-next as soon as Andrew releases mmotm. Yes thanks I can confirm that next-20171106 works for me. So as far as I'm concerned, we're good to go. Regards, Tony > [1] http://lkml.kernel.org/r/20171019122118.y6cndierwl2vn...@dhcp22.suse.cz

[PATCH v2 0/9] memfd: add sealing to hugetlb-backed memory

2017-11-06 Thread Marc-André Lureau
Hi, Recently, Mike Kravetz added hugetlbfs support to memfd. However, he didn't add sealing support. One of the reasons to use memfd is to have shared memory sealing when doing IPC or sharing memory with another process with some extra safety. qemu uses shared memory & hugetables with vhost-user (

[PATCH v2 7/9] memfd-test: add 'memfd-hugetlb:' prefix when testing hugetlbfs

2017-11-06 Thread Marc-André Lureau
Suggested-by: Mike Kravetz Signed-off-by: Marc-André Lureau --- tools/testing/selftests/memfd/memfd_test.c | 26 -- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git a/tools/testing/selftests/memfd/memfd_test.c b/tools/testing/selftests/memfd/memfd_test.c ind

[PATCH v2 4/9] hugetlbfs: implement memfd sealing

2017-11-06 Thread Marc-André Lureau
Implements memfd sealing, similar to shmem: - WRITE: deny fallocate(PUNCH_HOLE). mmap() write is denied in memfd_add_seals(). write() doesn't exist for hugetlbfs. - SHRINK: added similar check as shmem_setattr() - GROW: added similar check as shmem_setattr() & shmem_fallocate() Except write() op

<    1   2   3   4   5   6   7   8   9   10   >