Re: [RFC PATCH v8 1/7] dt-bindings: PCI: Add definition of PCIe WAKE# irq and PCI irq

2017-10-26 Thread Brian Norris
Hi Jeffy, On Fri, Oct 27, 2017 at 11:06:34AM +0800, Jeffy Chen wrote: > On 10/27/2017 10:33 AM, Brian Norris wrote: > >In fact, I'm pretty sure this series fails to actually look in the host > >bridge for the "wakeup" interrupt at all! Did you actually test this? > actually it could... > > static

Re: [PATCH] x86: Remove unnecessary return from void function

2017-10-26 Thread Juergen Gross
On 23/06/17 18:23, Anton Vasilyev wrote: > The patch removes unnecessary return from void function. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Anton Vasilyev Reviewed-by: Juergen Gross Juergen

[PATCH v3 0/2] refactor code and mark expected switch fall-throughs

2017-10-26 Thread Gustavo A. R. Silva
The aim of this patchset is firstly to refactor code in nr_route.c in order to make it easier to read and maintain and, secondly, to mark some expected switch fall-throughs in preparation to enabling -Wimplicit-fallthrough. I have to mention that I did not implement any unit test. If someone has

[PATCH v3 1/2] net: netrom: nr_route: refactor code in nr_add_node

2017-10-26 Thread Gustavo A. R. Silva
Code refactoring in order to make the code easier to read and maintain. Signed-off-by: Gustavo A. R. Silva --- Changes in v2: Make use of the swap macro and remove inline keyword. Changes in v3: Update subject. net/netrom/nr_route.c | 59 ++- 1

[PATCH v3 2/2] net: netrom: nr_route: mark expected switch fall-throughs

2017-10-26 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva --- Changes in v2: None. Changes in v3: Update subject. net/netrom/nr_route.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/netrom/nr_r

[PATCH -mm -V2] mm, swap: Fix false error message in __swp_swapcount()

2017-10-26 Thread Huang, Ying
From: Huang Ying When a page fault occurs for a swap entry, the physical swap readahead (not the VMA base swap readahead) may readahead several swap entries after the fault swap entry. The readahead algorithm calculates some of the swap entries to readahead via increasing the offset of the fault

[PATCH] drivers/net: 8390: Convert timers to use timer_setup()

2017-10-26 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: net...@vger.kernel.org Signed-off-by: Kees Cook --- drivers/net/ethernet/8390/axnet_cs.c | 10 +---

[PATCH] drivers/net: amd: Convert timers to use timer_setup()

2017-10-26 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: Tom Lendacky Cc: "David S. Miller" Cc: Allen Pais Cc: net...@vger.kernel.org Signed-off-by: Kees Cook

[PATCH] drivers/net: appletalk/cops: Convert timers to use timer_setup()

2017-10-26 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: Allen Pais Cc: "David S. Miller" Cc: David Howells Cc: net...@vger.kernel.org Signed-off-by: Kees Coo

[PATCH] drivers/net: chelsio/cxgb*: Convert timers to use timer_setup()

2017-10-26 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: Santosh Raspatur Cc: Ganesh Goudar Cc: Casey Leedom Cc: net...@vger.kernel.org Signed-off-by: Kees Co

[PATCH] drivers/net: fealnx: Convert timers to use timer_setup()

2017-10-26 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: "David S. Miller" Cc: "yuval.sh...@oracle.com" Cc: Allen Pais Cc: Stephen Hemminger Cc: Philippe Rey

[PATCH] drivers/net: smsc: Convert timers to use timer_setup()

2017-10-26 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: "David S. Miller" Cc: "yuval.sh...@oracle.com" Cc: Eric Dumazet Cc: Philippe Reynes Cc: Allen Pais

Re: [RFC PATCH v8 7/7] PCI / PM: Add support for the PCIe WAKE# signal for OF

2017-10-26 Thread Brian Norris
Hi Jeffy, On Thu, Oct 26, 2017 at 09:28:40PM +0800, Jeffy Chen wrote: > Add pci-of.c to handle the PCIe WAKE# interrupt. > > Also use the dedicated wakeirq infrastructure to simplify it. > > Signed-off-by: Jeffy Chen > --- > > Changes in v8: > Add pci-of.c and use platform_pm_ops to handle the

[PATCH] netfilter: ipvs: Convert timers to use timer_setup()

2017-10-26 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: Wensong Zhang Cc: Simon Horman Cc: Julian Anastasov Cc: Pablo Neira Ayuso Cc: Jozsef Kadlecsik Cc:

[PATCH] drivers/net: mellanox: Convert timers to use timer_setup()

2017-10-26 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: Saeed Mahameed Cc: Matan Barak Cc: Leon Romanovsky Cc: net...@vger.kernel.org Cc: linux-r...@vger.ker

[PATCH] drivers/net: packetengines: Convert timers to use timer_setup()

2017-10-26 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: "David S. Miller" Cc: Allen Pais Cc: yuan linyu Cc: Philippe Reynes Cc: net...@vger.kernel.org Signe

[PATCH] drivers/net: natsemi: Convert timers to use timer_setup()

2017-10-26 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: "David S. Miller" Cc: Allen Pais Cc: Eric Dumazet Cc: Philippe Reynes Cc: Wei Yongjun Cc: net...@vg

Re: [PATCH v2] kprobes: avoid the kprobe being re-registered

2017-10-26 Thread Masami Hiramatsu
On Fri, 27 Oct 2017 09:56:40 +0800 Zhou Chengming wrote: > Changes from v1: > - We should put the modifies of the kprobe after the re-reg check. > - And then the address_safe check. > - When check_kprobe_address_safe() return fail, the *probed_mod > should be set to NULL, and no module refcount

[PATCH] drivers/net: korina: Convert timers to use timer_setup()

2017-10-26 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: "David S. Miller" Cc: Roman Yeryomin Cc: Florian Fainelli Cc: net...@vger.kernel.org Signed-off-by: K

Re: [RFC PATCH v8 1/7] dt-bindings: PCI: Add definition of PCIe WAKE# irq and PCI irq

2017-10-26 Thread jeffy
Hi Brian, On 10/27/2017 01:40 PM, Brian Norris wrote: Another odd thing about this series is that the interrupt doesn't actually show up in /proc/interrupts, /sys/kernel/debug/gpio, or similar, seemingly because the wakeirq is requested/released every time we suspend/resume. So it's really not t

[PATCH] drivers/net: dlink: Convert timers to use timer_setup()

2017-10-26 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: Denis Kirjanov Cc: net...@vger.kernel.org Signed-off-by: Kees Cook --- drivers/net/ethernet/dlink/sun

Re: KASAN: use-after-free Read in get_work_pool

2017-10-26 Thread Dmitry Vyukov
On Thu, Oct 26, 2017 at 7:58 PM, Tejun Heo wrote: > Hello, > > On Thu, Oct 26, 2017 at 09:35:44AM -0700, syzbot wrote: >> BUG: KASAN: use-after-free in __read_once_size >> include/linux/compiler.h:276 [inline] >> BUG: KASAN: use-after-free in atomic64_read >> arch/x86/include/asm/atomic64_64.h:21

Re: WARNING in refcount_sub_and_test

2017-10-26 Thread Dmitry Vyukov
On Fri, Oct 27, 2017 at 4:30 AM, ChunYu Wang wrote: > Maybe I have just made some mistakes on understanding the reproduction > methods, will try it again. This is reproducible with the C program. If bot posts it, it was able to reproduce the bug with the compiled C program. If it was not able to

Re: WARNING in refcount_sub_and_test

2017-10-26 Thread Dmitry Vyukov
On Thu, Oct 26, 2017 at 6:56 PM, Xin Long wrote: > Hi all, > > I am failed to reproduce it on target kernel with the reproducer file > or replaying the target syzkaller description log file, do I made > something wrong or there exists more subjects then the line in > repro.

Re: [PATCH 01/12] Input: ad7897 - use managed devm_device_add_group

2017-10-26 Thread Andi Shyti
Hi Dmitry, > > Commit 57b8ff070f98 ("driver core: add devm_device_add_group() > > and friends") has added the the managed version for creating > > sysfs group files. > > > > Use devm_device_add_group instead of sysfs_create_group and > > remove the relative sysfs_remove_group and goto label. > >

[PATCH] selftests/ftrace: Do not use arch dependent do_IRQ as a target function

2017-10-26 Thread Masami Hiramatsu
Instead using arch-dependent do_IRQ, use do_softirq as a target function. Applying do_IRQ to set_ftrace_filter always fail on arm/arm64 and any other architectures which don't define do_IRQ. So, instead of using that, use do_softirq which is defined in kernel/softirq.c. Signed-off-by: Masami Hira

[PATCH v2 2/3] mailbox: Add support for Hi3660 mailbox

2017-10-26 Thread Kaihua Zhong
Hi3660 mailbox controller is used to send message within multiple processors, MCU, HIFI, etc. It supports 32 mailbox channels and every channel can only be used for single transferring direction. Once the channel is enabled, it needs to specify the destination interrupt and acknowledge interrupt,

Re: [PATCH v2] kprobes: avoid the kprobe being re-registered

2017-10-26 Thread zhouchengming
On 2017/10/27 13:57, Masami Hiramatsu wrote: On Fri, 27 Oct 2017 09:56:40 +0800 Zhou Chengming wrote: Changes from v1: - We should put the modifies of the kprobe after the re-reg check. - And then the address_safe check. - When check_kprobe_address_safe() return fail, the *probed_mod should

[PATCH v2 3/3] dts: arm64: Add mailbox binding for hi3660

2017-10-26 Thread Kaihua Zhong
Add DT binding for mailbox driver. Cc: John Stultz Cc: Guodong Xu Cc: Haojian Zhuang Cc: Niranjan Yadla Cc: Raj Pawate Signed-off-by: Leo Yan Signed-off-by: Ruyi Wang Signed-off-by: Kaihua Zhong --- arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 8 1 file changed, 8 insertions(+) d

[PATCH v2 1/3] dt-bindings: mailbox: Introduce Hi3660 controller binding

2017-10-26 Thread Kaihua Zhong
From: Leo Yan Introduce a binding for the Hi3660 mailbox controller, the mailbox is used within application processor (AP), communication processor (CP), HIFI and MCU, etc. Cc: John Stultz Cc: Guodong Xu Cc: Haojian Zhuang Cc: Niranjan Yadla Cc: Raj Pawate Signed-off-by: Leo Yan --- .../b

[PATCH v2 0/3] mailbox: Add support for Hi3660 mailbox

2017-10-26 Thread Kaihua Zhong
From: Leo Yan Hi3660 mailbox controller is used to send message within multiple processors, MCU, HIFI, etc. This patch series is to implement an initial version for Hi3660 mailbox driver with "automatic acknowledge" mode. The patch set have been verified with Hi3660 stub clock driver, so we can

RE: [PATCH 1/3] [S390] vmur: convert urdev.ref_count from atomic_t to refcount_t

2017-10-26 Thread Reshetova, Elena
> On Fri, 20 Oct 2017 10:47:48 +0300 > Elena Reshetova wrote: > > > atomic_t variables are currently used to implement reference > > counters with the following properties: > > - counter is initialized to 1 using atomic_set() > > - a resource is freed upon counter reaching zero > > - once cou

Re: [PATCH] pci: Add a acs_disable option for pci kernel parameter

2017-10-26 Thread Christoph Hellwig
On Thu, Oct 26, 2017 at 08:37:49PM -0600, sba...@raithlin.com wrote: > From: Stephen Bates > > On some servers the BIOS sets up ACS on any valid pci_dev in the > system. The kernel has no way of backing this out since the kernel > only turns ACS capabilities on. > > This patch adds a new boot op

Re: [PATCH] f2fs: fix out-of-free problem caused by atomic write

2017-10-26 Thread Christoph Hellwig
On Thu, Oct 26, 2017 at 04:30:19PM +0200, Jaegeuk Kim wrote: > On 10/26, Yunlong Song wrote: > > f2fs_balance_fs only actives once in the commit_inmem_pages, but there > > are more than one page to commit, so all the other pages will miss the > > check. This will lead to out-of-free problem when co

[PATCH net-next] qed: Set error code for allocation failures

2017-10-26 Thread Dan Carpenter
There are several places where we accidentally return success when kcalloc() fails. Fixes: fcb39f6c10b2 ("qed: Add mpa buffer descriptors for storing and processing mpa fpdus") Signed-off-by: Dan Carpenter diff --git a/drivers/net/ethernet/qlogic/qed/qed_iwarp.c b/drivers/net/ethernet/qlogic/q

Re: [PATCH] drm/bridge/synopsys: dsi: add optional pixel clock

2017-10-26 Thread Andrzej Hajda
On 26.10.2017 18:09, Philippe Cornu wrote: > The pixel clock is optional. When available, it offers a better > preciseness for timing computations. > > Signed-off-by: Philippe Cornu > --- > drivers/gpu/drm/bridge/synopsys/dw-mipi-dsi.c | 24 ++-- > 1 file changed, 18 insertion

Re: [PATCH v3 00/13] dax: fix dma vs truncate and remove 'page-less' support

2017-10-26 Thread Christoph Hellwig
On Thu, Oct 26, 2017 at 12:58:50PM +0200, Jan Kara wrote: > But are we guaranteed page refs are short term? E.g. if someone creates > v4l2 videobuf in MAP_SHARED mapping of a file on DAX filesystem, page refs > can be rather long-term similarly as in RDMA case. Also freeing of blocks > on page refe

Re: [PATCH v3 00/13] dax: fix dma vs truncate and remove 'page-less' support

2017-10-26 Thread Dave Chinner
On Thu, Oct 26, 2017 at 11:51:04PM +, Williams, Dan J wrote: > On Thu, 2017-10-26 at 12:58 +0200, Jan Kara wrote: > > On Fri 20-10-17 11:31:48, Christoph Hellwig wrote: > > > On Fri, Oct 20, 2017 at 09:47:50AM +0200, Christoph Hellwig wrote: > > > > I'd like to brainstorm how we can do somethin

RE: [PATCH] refcount: provide same memory ordering guarantees as in atomic_t

2017-10-26 Thread Reshetova, Elena
> On Mon, Oct 23, 2017 at 02:09:44PM +0300, Elena Reshetova wrote: > > Currently arch. independent implementation of refcount_t in > > lib/refcount.c provides weak memory ordering guarantees > > compare to its analog atomic_t implementations. > > While it should not be a problem for most of the act

Re: [PATCHv2 2/2] Add /proc/PID/{smaps, numa_maps} support for DAX

2017-10-26 Thread kbuild test robot
Hi Fan, Thank you for the patch! Yet we hit a small issue. [auto build test WARNING on linus/master] [also build test WARNING on v4.14-rc6 next-20171018] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/c

[PATCH 1/2] KVM: X86: Fix operand size during instruction decoding

2017-10-26 Thread Wanpeng Li
From: Wanpeng Li Pedro reported: During tests that we conducted on KVM, we noticed that executing a "PUSH %ES" instruction under KVM produces different results on both memory and the SP register depending on whether EPT support is enabled. With EPT the SP is reduced by 4 bytes (and the wr

[PATCH 2/2] KVM: nVMX: Validate the IA32_BNDCFGS on nested VM-entry

2017-10-26 Thread Wanpeng Li
From: Wanpeng Li According to the SDM, if the "load IA32_BNDCFGS" VM-entry controls is 1, the following checks are performed on the field for the IA32_BNDCFGS MSR: - Bits reserved in the IA32_BNDCFGS MSR must be 0. - The linear address in bits 63:12 must be canonical. Cc: Paolo Bonzini Cc: Ra

<    3   4   5   6   7   8