Re: [PATCH v2 0/5] GPIO driver for Maxim MAX3191x

2017-10-13 Thread Linus Walleij
On Thu, Oct 12, 2017 at 12:40 PM, Lukas Wunner wrote: > - Patch [1/5]: Change the argument order of assign_bit() to reflect > traditional "dst = src" in C. (Peter Zijlstra) > > - Patch [2/5]: Update documentation. (Linus Walleij) > Drop const qualifier from struct gpio_desc ** in all function

[GIT PULL 55/58] lightnvm: pblk: cleanup unused and static functions

2017-10-13 Thread Matias Bjørling
From: Javier González Cleanup up unused and static functions across the whole codebase. Signed-off-by: Javier González Signed-off-by: Matias Bjørling --- drivers/lightnvm/pblk-core.c | 133 --- drivers/lightnvm/pblk-gc.c | 40 ++--- drivers/l

[GIT PULL 44/58] lightnvm: pblk: fix releases of kmem cache in error path

2017-10-13 Thread Matias Bjørling
From: Rakesh Pandit If pblk_core_init fails lets destroy all global caches. Signed-off-by: Rakesh Pandit Signed-off-by: Matias Bjørling --- drivers/lightnvm/pblk-init.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/drivers/lightnvm/pblk-init.c b/driver

Re: [PATCH] ath9k: debug: Simplify error checking

2017-10-13 Thread Kalle Valo
Christos Gkekas writes: > Variable val is unsigned so checking whether it is less than zero is > redundant. > > Signed-off-by: Christos Gkekas > --- > drivers/net/wireless/ath/ath9k/debug.c | 5 + > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath

[GIT PULL 54/58] lightnvm: pblk: remove spinlock when freeing line metadata

2017-10-13 Thread Matias Bjørling
From: Hans Holmberg Lockdep complains about being in atomic context while freeing line metadata - and rightly so as we take a spinlock and end up calling vfree that might sleep(in pblk_mfree). There is no need for holding the line manager free_lock while freeing line metadata as the pipeline as

[GIT PULL 53/58] lightnvm: pblk: correct valid lba count calculation

2017-10-13 Thread Matias Bjørling
From: Hans Holmberg During garbage collect, lbas being written can end up being invalidated. Make sure that this is reflected in the valid lba count. Signed-off-by: Hans Holmberg Signed-off-by: Matias Bjørling --- drivers/lightnvm/pblk-map.c | 7 --- 1 file changed, 4 insertions(+), 3 del

Re: [RFC PATCH v9 for 4.15 01/14] Restartable sequences system call

2017-10-13 Thread Florian Weimer
On 10/13/2017 01:03 AM, Mathieu Desnoyers wrote: Expose a new system call allowing each thread to register one userspace memory area to be used as an ABI between kernel and user-space for two purposes: user-space restartable sequences and quick access to read the current CPU number value from use

[GIT PULL 43/58] lightnvm: pblk: reduce arguments in __pblk_rb_update_l2p

2017-10-13 Thread Matias Bjørling
From: Rakesh Pandit We already pass the structure pointer so no need to pass the member. Signed-off-by: Rakesh Pandit Signed-off-by: Matias Bjørling --- drivers/lightnvm/pblk-rb.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/lightnvm/pblk-rb.c b/driv

[GIT PULL 52/58] lightnvm: pblk: gc all lines in the pipeline before exit

2017-10-13 Thread Matias Bjørling
From: Hans Holmberg Finish garbage collect of the lines that are in the gc pipeline before exiting. Ensure that all lines already in in the pipeline goes through, from read to write. Do this by keeping track of how many lines are in the pipeline and waiting for that number to reach zero before e

[GIT PULL 38/58] lightnvm: pblk: ensure right bad block calculation

2017-10-13 Thread Matias Bjørling
From: Javier González Make sure that the variable controlling block threshold for allocating extra metadata sectors in case of a line with bad blocks does not get a negative value. Otherwise, the line will be marked as corrupted and wasted. Signed-off-by: Javier González Signed-off-by: Matias B

[GIT PULL 51/58] lightnvm: pblk: add l2p crc debug printouts

2017-10-13 Thread Matias Bjørling
From: Hans Holmberg Print the CRC of the logical-to-physical mapping during exit and after recovering the L2P table to facilitate detection of meta data corruption/recovery issues. The CRC printed after recovery should match the CRC printed during the previous exit - if it doesn't this indicates

Re: [PATCH 1/2] hwmon: (jc42) optionally try to disable the SMBUS timeout

2017-10-13 Thread Guenter Roeck
On 10/13/2017 02:27 AM, Peter Rosin wrote: With a nxp,se97 chip on an atmel sama5d31 board, the I2C adapter driver is not always capable of avoiding the 25-35 ms timeout as specified by the SMBUS protocol. This may cause silent corruption of the last bit of any transfer, e.g. a one is read instea

[GIT PULL 50/58] lightnvm: pblk: shut down gc gracefully during exit

2017-10-13 Thread Matias Bjørling
From: Hans Holmberg Shut down the GC workqueues and tasks in the right order. Signed-off-by: Hans Holmberg Signed-off-by: Matias Bjørling --- drivers/lightnvm/pblk-gc.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/drivers/lightnvm/pblk-gc.c b/drive

[GIT PULL 49/58] lightnvm: pblk: consider bad sectors in emeta during recovery

2017-10-13 Thread Matias Bjørling
From: Hans Holmberg When recovering lines we need to consider that bad blocks in a line affect the emeta area size. Previously it was assumed that the emeta area would grow by the number of sectors per page * number of bad blocks in the line. This assumption is not correct - the number of "extr

[PATCH] mmc: sdhci-cadence: use bitfield access macros for cleanup

2017-10-13 Thread Masahiro Yamada
Accessing register fields generally need mask and shift part. Defining them separately, like SDHCI_CDNS_HRS06_TUNE_{SHIFT,MASK}, is tedious. Register fields can be always defined by GENMASK (or, BIT if it it a single bit). They are nicely handled by FIELD_* macros. Signed-off-by: Masahiro Yamada

[GIT PULL 48/58] lightnvm: pblk: start gc if needed during init

2017-10-13 Thread Matias Bjørling
From: Hans Holmberg Start GC if needed, directly after init, as we might need to garbage collect in order to make room for user writes. Create a helper function that allows to kick GC without exposing the internals of the GC/rate-limiter interaction. Signed-off-by: Hans Holmberg Signed-off-by:

[GIT PULL 39/58] lightnvm: pblk: fix changing GC group list for a line

2017-10-13 Thread Matias Bjørling
From: Rakesh Pandit pblk_line_gc_list seems to had a bug since the introduction of pblk in getting GC list for a line. In b20ba1bc7 while redesigning the GC algorithm, the naming for the GC thresholds was altered, but the values for high_thrs and mid_thrs were not. The result is that when moving

[GIT PULL 47/58] lightnvm: pblk: free full lines during recovery

2017-10-13 Thread Matias Bjørling
From: Hans Holmberg When rebuilding the L2P table, any full lines (lines without any valid sectors) will be identified. If these lines are not freed, we risk not being able to allocate the first data line. This patch refactors the part of GC that frees empty lines into a separate function and ad

[GIT PULL 45/58] lightnvm: pblk: prevent gc kicks when gc is not operational

2017-10-13 Thread Matias Bjørling
From: Hans Holmberg GC can be kicked after it has been shut down when closing the last line during exit, resulting in accesses to freed structures. Make sure that GC is not triggered while it is not operational. Also make sure that GC won't be re-activated during exit when running on another pro

[GIT PULL 46/58] lightnvm: pblk: recover partially written lines correctly

2017-10-13 Thread Matias Bjørling
From: Hans Holmberg When recovering partially written lines, the valid sector count must be decreased by the number of padded sectors in the line. Update line recovery to take all ADDR_EMPTY(padded) sectors into account. Signed-off-by: Hans Holmberg Signed-off-by: Matias Bjørling --- drivers

[GIT PULL 42/58] lightnvm: remove stale extern and unused exported symbols

2017-10-13 Thread Matias Bjørling
From: Rakesh Pandit Not all exported symbols are being used outside core and there were some stale entries in lightnvm.h Signed-off-by: Rakesh Pandit Signed-off-by: Matias Bjørling --- drivers/lightnvm/core.c | 129 +++ include/linux/lightnvm.h |

[GIT PULL 40/58] lightnvm: pblk: remove useless line

2017-10-13 Thread Matias Bjørling
From: Rakesh Pandit Signed-off-by: Rakesh Pandit Signed-off-by: Matias Bjørling --- drivers/lightnvm/pblk-core.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/lightnvm/pblk-core.c b/drivers/lightnvm/pblk-core.c index e38e918..43866ad 100644 --- a/drivers/lightnvm/pblk-core.c +++ b

Re: [PATCH 4.13 0/2] 4.13.7-stable review

2017-10-13 Thread Greg Kroah-Hartman
On Fri, Oct 13, 2017 at 05:41:02AM -0700, Guenter Roeck wrote: > On 10/12/2017 02:26 PM, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.13.7 release. > > There are 2 patches in this series, all will be posted as a response > > to this one. If anyone has any is

[GIT PULL 33/58] lightnvm: pblk: check lba sanity on read path

2017-10-13 Thread Matias Bjørling
From: Javier González As part of pblk's recovery scheme, we store the lba mapped to each physical sector on the device's out-of-bound (OOB) area. On the read path, we can use this information to validate that the data being delivered to the upper layers corresponds to the lba being requested. Th

[GIT PULL 41/58] lightnvm: remove unused argument from nvm_set_tgt_bb_tbl

2017-10-13 Thread Matias Bjørling
From: Rakesh Pandit vblk isn't being used anyway and if we ever have a usecase we can introduce this again. This makes the logic easier and removes unnecessary checks. Signed-off-by: Rakesh Pandit Signed-off-by: Matias Bjørling --- drivers/lightnvm/core.c | 27 +++ i

[GIT PULL 34/58] lightnvm: pblk: guarantee line integrity on reads

2017-10-13 Thread Matias Bjørling
From: Javier González When a line is recycled during garbage collection, reads can still be issued to the line. If the line is freed in the middle of this process, data corruption might occur. This patch guarantees that lines are not freed in the middle of reads that target them (lines). Specifi

Re: [PATCH] reduce the time of finding symbols for module

2017-10-13 Thread Ruslan Bilovol
Hi Li, On Wed, Mar 29, 2017 at 4:50 AM, Li Bin wrote: > Hi, [snip] > > Yeah, from 2014, we started to work on livepatch support on aarch64, and > in May 2015, we pushed the solution to the livepatch community[1] and gcc > community (mfentry feature on aarch64)[2]. And then, there were an another

[GIT PULL 37/58] lightnvm: pblk: enable 1 LUN configuration

2017-10-13 Thread Matias Bjørling
From: Javier González Metadata I/Os are scheduled to minimize their impact on user data I/Os. When there are enough LUNs instantiated (i.e., enough bandwidth), it is easy to interleave metadata and data one after the other so that metadata I/Os are the ones being blocked and not vice-versa. We d

[GIT PULL 35/58] lightnvm: pblk: remove redundant check on read path

2017-10-13 Thread Matias Bjørling
From: Javier González A partial read I/O in pblk is an I/O where some sectors reside in the write buffer in main memory and some are persisted on the device. Such an I/O must at least contain 2 lbas, therefore checking for the case where a single lba is mapped is not necessary. Signed-off-by: Ja

RE: [PATCH 02/10] perf tool: fix: Don't discard prev in backward mode

2017-10-13 Thread Liang, Kan
> Em Tue, Oct 10, 2017 at 10:20:15AM -0700, kan.li...@intel.com escreveu: > > From: Kan Liang > > > > Perf record can switch output. The new output should only store the > > data after switching. However, in overwrite backward mode, the new > > output still have the data from old output. > > > > A

[PATCH] clk: uniphier: fix clock data for PXs3

2017-10-13 Thread Masahiro Yamada
Fix reg offsets of USB clocks. Fixes: 736de651a836 ("clk: uniphier: add PXs3 clock data") Signed-off-by: Masahiro Yamada --- drivers/clk/uniphier/clk-uniphier-sys.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/clk/uniphier/clk-uniphier-sys.c b/drivers/clk/u

[GIT PULL 36/58] lightnvm: pblk: remove I/O dependency on write path

2017-10-13 Thread Matias Bjørling
From: Javier González pblk schedules user I/O, metadata I/O and erases on the write path in order to minimize collisions at the media level. Until now, there has been a dependency between user and metadata I/Os that could lead to a deadlock as both take the per-LUN semaphore to schedule submissio

[GIT PULL 32/58] lightnvm: pblk: use rqd->end_io for completion

2017-10-13 Thread Matias Bjørling
From: Javier González For consistency with the rest of pblk, use rqd->end_io to point to the function taking care of ending the request on the completion path. Signed-off-by: Javier González Signed-off-by: Matias Bjørling --- drivers/lightnvm/pblk-core.c | 7 --- drivers/lightnvm/pblk-rea

[GIT PULL 31/58] lightnvm: pblk: refactor rqd alloc/free

2017-10-13 Thread Matias Bjørling
From: Javier González Refactor the rqd allocation and free functions so that all I/O types can use these helper functions. Signed-off-by: Javier González Signed-off-by: Matias Bjørling --- drivers/lightnvm/pblk-core.c | 40 ++-- drivers/lightnvm/pblk-re

[GIT PULL 30/58] lightnvm: pblk: improve naming for internal req.

2017-10-13 Thread Matias Bjørling
From: Javier González Each request type sent to the LightNVM subsystem requires different metadata. Until now, we have tailored this metadata based on write, read and erase commands. However, pblk uses different metadata for internal writes that do not hit the write buffer. Instead of abusing the

[GIT PULL 27/58] lightnvm: pblk: put bio on bio completion

2017-10-13 Thread Matias Bjørling
From: Javier González Simplify put bio by doing it on bio end_io instead of manually putting it on the completion path. Signed-off-by: Javier González Signed-off-by: Matias Bjørling --- drivers/lightnvm/pblk-core.c | 10 +++--- drivers/lightnvm/pblk-read.c | 1 - drivers/lightnvm

[GIT PULL 28/58] lightnvm: pblk: simplify path on REQ_PREFLUSH

2017-10-13 Thread Matias Bjørling
From: Javier González On REQ_PREFLUSH, directly tag the I/O context flags to signal a flush in the write to cache path, instead of finding the correct entry context and imposing a memory barrier. This simplifies the code and might potentially prevent race conditions when adding functionality to t

[GIT PULL 29/58] lightnvm: pblk: allocate bio size more accurately

2017-10-13 Thread Matias Bjørling
From: Javier González Wait until we know the exact number of ppas to be sent to the device, before allocating the bio. Signed-off-by: Javier González Signed-off-by: Matias Bjørling --- drivers/lightnvm/pblk-rb.c| 5 +++-- drivers/lightnvm/pblk-write.c | 20 ++-- drivers/l

[GIT PULL 25/58] lightnvm: pblk: simplify data validity check on GC

2017-10-13 Thread Matias Bjørling
From: Javier González When a line is selected for recycling by the garbage collector (GC), the line state changes and the invalid bitmap is frozen, preventing invalidations from happening. Throughout the GC, the L2P map is checked to verify that not data being recycled has been updated. The last

[GIT PULL 16/58] lightnvm: pblk: avoid deadlock on low LUN config

2017-10-13 Thread Matias Bjørling
From: Javier González On low LUN configurations, make sure not to send bios that are bigger than the buffer size. Fixes: a4bd217b4326 ("lightnvm: physical block device (pblk) target") Signed-off-by: Javier González Signed-off-by: Matias Bjørling --- drivers/lightnvm/pblk-init.c | 2 +- driver

[GIT PULL 24/58] lightnvm: pblk: refactor read lba sanity check

2017-10-13 Thread Matias Bjørling
From: Javier González Refactor lba sanity check on read path to avoid code duplication. Signed-off-by: Javier González Signed-off-by: Matias Bjørling --- drivers/lightnvm/pblk-read.c | 29 ++--- 1 file changed, 10 insertions(+), 19 deletions(-) diff --git a/drivers/li

[GIT PULL 22/58] lightnvm: pblk: use constant for GC max inflight

2017-10-13 Thread Matias Bjørling
From: Javier González Use a constant to set the maximum number of inflight GC requests allowed. Signed-off-by: Javier González Signed-off-by: Matias Bjørling --- drivers/lightnvm/pblk-gc.c | 4 ++-- drivers/lightnvm/pblk.h| 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --gi

[GIT PULL 15/58] lightnvm: pblk: fix write I/O sync stat

2017-10-13 Thread Matias Bjørling
From: Javier González Fix stat counter to collect the right number of I/Os being synced on the completion path. Fixes: 0880a9aa2d91f ("lightnvm: pblk: delete redundant buffer pointer") Signed-off-by: Javier González Signed-off-by: Matias Bjørling --- drivers/lightnvm/pblk-write.c | 2 +- 1 fi

[GIT PULL 20/58] lightnvm: pblk: do not use a mempool for line bitmaps

2017-10-13 Thread Matias Bjørling
From: Javier González pblk holds two sector bitmaps: one to keep track of the mapped sectors while the line is active and another one to keep track of the invalid sectors. The latter is kept during the whole live of the line, until it is recycled. Since we cannot guarantee forward progress for th

[GIT PULL 14/58] lightnvm: pblk: free padded entries in write buffer

2017-10-13 Thread Matias Bjørling
From: Javier González When a REQ_FLUSH reaches pblk, the bio cannot be directly completed. Instead, data on the write buffer is flushed and the bio is completed on the completion pah. This might require some sectors to be padded in order to guarantee a successful write. This patch fixes a memory

[GIT PULL 21/58] lightnvm: pblk: remove checks on mempool alloc.

2017-10-13 Thread Matias Bjørling
From: Javier González As part of the mempool audit on pblk, remove unnecessary mempool allocation checks on mempools. Reported-by: Jens Axboe Signed-off-by: Javier González Signed-off-by: Matias Bjørling --- drivers/lightnvm/pblk-core.c | 4 drivers/lightnvm/pblk-read.c | 8 --

[GIT PULL 19/58] lightnvm: pblk: decouple read/erase mempools

2017-10-13 Thread Matias Bjørling
From: Javier González Since read and erase paths offer different guarantees for inflight I/Os, separate the mempools to set the right min_nr for each on creation. Reported-by: Jens Axboe Signed-off-by: Javier González Signed-off-by: Matias Bjørling --- drivers/lightnvm/pblk-core.c | 8 -

[GIT PULL 18/58] lightnvm: pblk: simplify work_queue mempool

2017-10-13 Thread Matias Bjørling
From: Javier González In pblk, we have a mempool to allocate a generic structure that we pass along workqueues. This is heavily used in the GC path in order to have enough inflight reads and fully utilize the GC bandwidth. However, the current GC path copies data to the host memory and puts it b

[GIT PULL 13/58] lightnvm: pblk: use right flag for GC allocation

2017-10-13 Thread Matias Bjørling
From: Javier González The data buffer for the GC path allocates virtual memory through vmalloc. When this change was introduced, a flag signaling kmalloc'ed memory was wrongly introduced. Use the right flag when creating a bio from this buffer. Fixes: de54e703a422 ("lightnvm: pblk: use vmalloc f

[GIT PULL 17/58] lightnvm: pblk: fix min size for page mempool

2017-10-13 Thread Matias Bjørling
From: Javier González pblk uses an internal page mempool for allocating pages on internal bios. The main two users of this memory pool are partial reads (reads with some sectors in cache and some on media) and padded writes, which need to add dummy pages to an existing bio already containing vali

[GIT PULL 12/58] lightnvm: pblk: initialize debug stat counter

2017-10-13 Thread Matias Bjørling
From: Javier González Initialize the stat counter for garbage collected reads. Fixes: a4bd217b43268 ("lightnvm: physical block device (pblk) target") Signed-off-by: Javier González Signed-off-by: Matias Bjørling --- drivers/lightnvm/pblk-init.c | 1 + 1 file changed, 1 insertion(+) diff --gi

[GIT PULL 08/58] lightnvm: pblk: fix message if L2P MAP is in device

2017-10-13 Thread Matias Bjørling
From: Rakesh Pandit This usually happens if we are developing with qemu and ll2pmode has default value. Improve description. Signed-off-by: Rakesh Pandit Reviewed-by: Javier González Signed-off-by: Matias Bjørling --- drivers/lightnvm/pblk-init.c | 2 +- 1 file changed, 1 insertion(+), 1 del

[GIT PULL 01/58] lightnvm: prevent target type module removal when in use

2017-10-13 Thread Matias Bjørling
From: Rakesh Pandit If target type module e.g. pblk here is unloaded (rmmod) while module is in use (after creating target) system crashes. We fix this by using module API refcnt. Signed-off-by: Rakesh Pandit Signed-off-by: Matias Bjørling --- drivers/lightnvm/core.c | 4 drivers/l

[GIT PULL 11/58] lightnvm: pblk: reuse pblk_gc_should_kick

2017-10-13 Thread Matias Bjørling
From: Rakesh Pandit This is a trivial change which reuses pblk_gc_should_kick instead of repeating it again in pblk_rl_free_lines_inc. Signed-off-by: Rakesh Pandit Made it apply to the common case. Reviewed-by: Javier González Signed-off-by: Matias Bjørling --- drivers/lightnvm/pblk-core.c |

[GIT PULL 10/58] lightnvm: pblk: print incompatible line version correctly

2017-10-13 Thread Matias Bjørling
From: Rakesh Pandit Correct it by converting little endian to cpu endian and also define a macro for line version so that maintenance is easy. Signed-off-by: Rakesh Pandit Reviewed-by: Javier González Signed-off-by: Matias Bjørling --- drivers/lightnvm/pblk-core.c | 2 +- drivers/lightnv

[GIT PULL 09/58] lightnvm: pblk: improve error message if down_timeout fails

2017-10-13 Thread Matias Bjørling
From: Rakesh Pandit The two pr_err messages are useless as they don't differentiate error code. Signed-off-by: Rakesh Pandit Reviewed-by: Javier González Signed-off-by: Matias Bjørling --- drivers/lightnvm/pblk-core.c | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff

Re: [PATCH] tracing: hide unused functions

2017-10-13 Thread Arnd Bergmann
On Fri, Oct 13, 2017 at 2:01 PM, Arnd Bergmann wrote: > After trace_selftest_startup_sched_switch is removed, trace_test_buffer() > is now only used inside of CONFIG_FUNCTION_TRACER, leading to this > warning: > > kernel/trace/trace_selftest.c:62:12: error: 'trace_test_buffer' defined but > not u

[GIT PULL 06/58] lightnvm: include NVM Express driver if OCSSD is selected for build

2017-10-13 Thread Matias Bjørling
From: Rakesh Pandit Because NVM needs BLK_DEV_NVME, select it automatically if we mark NVM in config file before building kernel. Also append PCI to depends as select doesn't automatically add dependencies. Signed-off-by: Rakesh Pandit Signed-off-by: Matias Bjørling --- drivers/lightnvm/Kcon

[GIT PULL 04/58] lightnvm: remove already calculated nr_chnls

2017-10-13 Thread Matias Bjørling
From: Rakesh Pandit Remove repeated calculation for number of channels while creating a target device. Signed-off-by: Rakesh Pandit Reviewed-by: Javier González Signed-off-by: Matias Bjørling --- drivers/lightnvm/core.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/lightnvm/core

[GIT PULL 05/58] lightnvm: pblk: fix error path in pblk_lines_alloc_metadata

2017-10-13 Thread Matias Bjørling
From: Rakesh Pandit Use appropriate memory free calls based on allocation type used and also fix number of times free is called if kmalloc fails. Signed-off-by: Rakesh Pandit Reviewed-by: Javier González Signed-off-by: Matias Bjørling --- drivers/lightnvm/pblk-init.c | 5 - 1 file change

[GIT PULL 03/58] lightnvm: protect target type list with correct locks

2017-10-13 Thread Matias Bjørling
From: Rakesh Pandit nvm_tgt_types list was protected by wrong lock for NVM_INFO ioctl call and can race with addition or removal of target types. Also unregistering target type was not protected correctly. Fixes: 5cd907853 ("lightnvm: remove nested lock conflict with mm") Signed-off-by: Rakesh

Re: [PATCH] powerpc/powernv: Enable reset_devices parameter to issue a PHB reset

2017-10-13 Thread Guilherme G. Piccoli
On 10/13/2017 05:37 AM, Michael Ellerman wrote: > > I really dislike this. > > You're basically saying the kernel can't work out how to get a device > working, so let's leave it up to the user. Oh, it was never my intention to say such blasphemy :) It meant to be just a debug option to help the

[PATCH] radix-tree: replace with

2017-10-13 Thread Masahiro Yamada
This header contains references to spinlock_t and lockdep_is_held(), both of which are defined in Signed-off-by: Masahiro Yamada --- include/linux/radix-tree.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/radix-tree.h b/include/linux/radix-tree.h index 567e

[GIT PULL 02/58] lightnvm: prevent bd removal if busy

2017-10-13 Thread Matias Bjørling
From: Rakesh Pandit When a virtual block device is formatted and mounted after creating with "nvme lnvm create... -t pblk", a removal from "nvm lnvm remove" would result in this: 446416.309757] bdi-block not registered [446416.309773] [ cut here ] [446416.309780] WARNING:

[PATCH] powerpc/eeh: make eeh_ops structures _ro_after_init

2017-10-13 Thread Bhumika Goyal
These structures are passed to the eeh_ops_register function during the initialization phase. There they get stored in a structure variable which only makes function calls through function pointers. There is no other usage of these eeh_ops structures and their fields are never modified after init p

Re: [PATCH v8 0/4] Add support for ThunderX2 pmu events using json files

2017-10-13 Thread Arnaldo Carvalho de Melo
Em Fri, Oct 13, 2017 at 10:11:42AM +0100, Will Deacon escreveu: > On Thu, Oct 12, 2017 at 10:54:50PM +0530, Ganapatrao Kulkarni wrote: > > On Thu, Oct 12, 2017 at 8:54 PM, Will Deacon wrote: > > > On Thu, Oct 12, 2017 at 07:41:12PM +0530, Ganapatrao Kulkarni wrote: > > >> Extending json/jevent fra

Re: [PATCH 2/3] early_printk: Add force_early_printk kernel parameter

2017-10-13 Thread Petr Mladek
On Thu 2017-10-12 13:39:49, Peter Zijlstra wrote: > On Thu, Oct 12, 2017 at 12:24:19PM +0200, Petr Mladek wrote: > > On Thu 2017-09-28 14:18:25, Peter Zijlstra wrote: > > > > +#ifdef CONFIG_EARLY_PRINTK > > > +struct console *early_console; > > > + > > > +static bool __read_mostly force_early_prin

Re: [PATCH 02/10] perf tool: fix: Don't discard prev in backward mode

2017-10-13 Thread Arnaldo Carvalho de Melo
Em Fri, Oct 13, 2017 at 12:55:34PM +, Liang, Kan escreveu: > > Em Tue, Oct 10, 2017 at 10:20:15AM -0700, kan.li...@intel.com escreveu: > > > From: Kan Liang > > > > > > Perf record can switch output. The new output should only store the > > > data after switching. However, in overwrite backwar

Re: [PATCH v2] ALSA: hda/ca0132 - use ARRAY_SIZE

2017-10-13 Thread Takashi Iwai
On Fri, 13 Oct 2017 04:36:31 +0200, Jérémy Lefaure wrote: > > Using the ARRAY_SIZE macro improves the readability of the code. > > Found with Coccinelle with the following semantic patch: > @r depends on (org || report)@ > type T; > T[] E; > position p; > @@ > ( > (sizeof(E)@p /sizeof(*E)) > | >

Re: [PATCH] PM / QoS: Drop PM_QOS_FLAG_REMOTE_WAKEUP

2017-10-13 Thread Rafael J. Wysocki
On Friday, October 13, 2017 8:32:18 AM CEST Ulf Hansson wrote: > On 13 October 2017 at 02:35, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > > > The PM QoS flag PM_QOS_FLAG_REMOTE_WAKEUP is not used consistently > > and the vast majority of code simply assumes that remote wakeup > > sho

RE: [PATCH 02/10] perf tool: fix: Don't discard prev in backward mode

2017-10-13 Thread Liang, Kan
> Em Fri, Oct 13, 2017 at 12:55:34PM +, Liang, Kan escreveu: > > > Em Tue, Oct 10, 2017 at 10:20:15AM -0700, kan.li...@intel.com escreveu: > > > > From: Kan Liang > > > > > > > > Perf record can switch output. The new output should only store > > > > the data after switching. However, in overw

Re: [PATCH] PM / core: Fix kerneldoc comments of three functions

2017-10-13 Thread Rafael J. Wysocki
On Friday, October 13, 2017 8:48:30 AM CEST Ulf Hansson wrote: > On 13 October 2017 at 02:33, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > > > Fix kerneldoc comments of __device_suspend_noirq(), > > __device_suspend_late() and __device_suspend() where the function > > names in kerneld

Re: [PATCH] ALSA: hda - silence uninitialized variable warning in activate_amp_in()

2017-10-13 Thread Takashi Iwai
On Fri, 13 Oct 2017 12:57:10 +0200, Dan Carpenter wrote: > > If snd_hda_get_conn_list() fails then "conn" isn't initialized. > > Signed-off-by: Dan Carpenter Applied, thanks. Takashi

Re: [PATCH v2 03/10] KVM: arm/arm64: vgic-its: Improve error reporting on device table save

2017-10-13 Thread Christoffer Dall
On Wed, Sep 27, 2017 at 03:28:33PM +0200, Eric Auger wrote: > At the moment the device table save() returns -EINVAL if > vgic_its_check_id() fails to return the gpa of the entry > associated to the device/collection id. Let vgic_its_check_id() > return an int instead of a bool and return a more pre

Re: [PATCH] reduce the time of finding symbols for module

2017-10-13 Thread Torsten Duwe
On Fri, Oct 13, 2017 at 03:54:46PM +0300, Ruslan Bilovol wrote: > Hi Li, > > On Wed, Mar 29, 2017 at 4:50 AM, Li Bin wrote: > > Hi, > [snip] > > > > Yeah, from 2014, we started to work on livepatch support on aarch64, and > > in May 2015, we pushed the solution to the livepatch community[1] and g

Re: NMI watchdog dump does not print on hard lockup

2017-10-13 Thread Steven Rostedt
On Fri, 13 Oct 2017 13:14:44 +0200 Petr Mladek wrote: > In general, we could either improve detection of situations when > the entire system is locked. It would be a reason to risk calling > consoles even in NMI. > > Or we could accept that the "default" printk is not good for all > situations a

Re: [PATCH 2/3] early_printk: Add force_early_printk kernel parameter

2017-10-13 Thread Peter Zijlstra
On Fri, Oct 13, 2017 at 03:06:09PM +0200, Petr Mladek wrote: > Or we should call early_printk() from printk() also when > PRINTK is disabled. This. > > Do you mean if someone were to toggle force_early_printk at runtime? > > Or that someone unregisters the early console. That's broken anyway,

[PATCH] virtio_balloon: fix deadlock on OOM

2017-10-13 Thread Michael S. Tsirkin
fill_balloon doing memory allocations under balloon_lock can cause a deadlock when leak_balloon is called from virtballoon_oom_notify and tries to take same lock. To fix, split page allocation and enqueue and do allocations outside the lock. Here's a detailed analysis of the deadlock by Tetsuo Ha

Re: [PATCH v3 1/2] acpi: apei: remove the unused dead-code for SEA notification type

2017-10-13 Thread Borislav Petkov
On Thu, Sep 28, 2017 at 08:41:37PM +0800, Dongjiu Geng wrote: > In current code logic, the two functions ghes_sea_add() and > ghes_sea_remove() are only called when CONFIG_ACPI_APEI_SEA > is defined. If not, it will return errors in the ghes_probe() > and not continue. If the probe is failed, the g

Re: [PATCH] tracing: hide unused functions

2017-10-13 Thread Steven Rostedt
On Fri, 13 Oct 2017 15:02:34 +0200 Arnd Bergmann wrote: > On Fri, Oct 13, 2017 at 2:01 PM, Arnd Bergmann wrote: > > After trace_selftest_startup_sched_switch is removed, trace_test_buffer() > > is now only used inside of CONFIG_FUNCTION_TRACER, leading to this > > warning: > > > > kernel/trace/t

Re: [PATCH] xfs: move two more RT specific functions into CONFIG_XFS_RT

2017-10-13 Thread Brian Foster
On Fri, Oct 13, 2017 at 02:05:40PM +0200, Arnd Bergmann wrote: > The last cleanup introduced two harmless warnings: > > fs/xfs/xfs_fsmap.c:480:1: warning: '__xfs_getfsmap_rtdev' defined but not used > fs/xfs/xfs_fsmap.c:372:1: warning: 'xfs_getfsmap_rtdev_rtbitmap_helper' > defined but not used >

Re: [PATCH v2 04/10] KVM: arm/arm64: vgic-its: Check GITS_BASER Valid bit before saving tables

2017-10-13 Thread Christoffer Dall
On Wed, Sep 27, 2017 at 03:28:34PM +0200, Eric Auger wrote: > At the moment we don't properly check the GITS_BASER.Valid > bit before saving the collection and device tables. > > On Collection table save() we use the gpa field whereas the Valid bit 'Collection table save()' looks weird. Just use

[GIT PULL] DeviceTree fixes for 4.14, round 2

2017-10-13 Thread Rob Herring
Hi Linus, Please pull a couple more DT fixes for 4.14. Rob The following changes since commit 8a5776a5f49812d29fe4b2d0a2d71675c3facf3f: Linux 4.14-rc4 (2017-10-08 20:53:29 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git tags/devi

Re: [RESEND PATCH 2/2] arm64: dts: rockchip: Enable edp disaplay on kevin

2017-10-13 Thread Heiko Stuebner
Hi Jeffy, Am Freitag, 13. Oktober 2017, 18:41:38 CEST schrieb Jeffy Chen: > Add edp panel and enable related nodes on kevin. > > Signed-off-by: Jeffy Chen does this actually work with mainline kernel sources? Sean Paul did look at making the edp work on Chromebooks recently, but it seemed ther

[PATCH v2] f2fs: update dirty status for CURSEG as well

2017-10-13 Thread Yunlong Song
Without this patch, it will cause all the free segments using up in some corner case. For example, there are 100 segments, and 20 of them are reserved for ovp. If 79 segments are full of data, segment 80 becomes CURSEG segment, write 512 blocks and then delete 511 blocks. Since it is CURSEG segment

Re: [PATCH 1/2] dt-bindings: mfd: Add Spreadtrum SC27xx PMIC documentation

2017-10-13 Thread Baolin Wang
On 13 October 2017 at 17:55, Lee Jones wrote: > On Fri, 13 Oct 2017, Baolin Wang wrote: >> On 13 October 2017 at 17:07, Lee Jones wrote: >> > On Wed, 11 Oct 2017, Baolin Wang wrote: >> > >> >> This patch adds the binding documentation for Spreadtrum SC27xx series >> >> PMIC device. >> >> >> >> Si

Re: [PATCH v5 09/16] perf report: compare symbol name for inlined frames when matching

2017-10-13 Thread Arnaldo Carvalho de Melo
Em Mon, Oct 09, 2017 at 10:33:03PM +0200, Milian Wolff escreveu: > +++ b/tools/perf/util/callchain.c > @@ -670,11 +670,11 @@ static enum match_result match_chain(struct > callchain_cursor_node *node, >struct callchain_list *cnode) > { > struct symbol *sym

Re: Sluggish AT91 I2C driver causes SMBus timeouts

2017-10-13 Thread Alan Cox
On Thu, 12 Oct 2017 13:35:17 +0200 Peter Rosin wrote: > Hi! > > I have encountered an "interesting" bug. It silently corrupts data > and is generally nasty... > > On an I2C bus, driven by the at91 driver and DMA (an Atmel > sama5d31 chip), I have an 256 byte eeprom (NXP SE97BTP). I'm using > Li

Re: [PATCH 2/3] early_printk: Add force_early_printk kernel parameter

2017-10-13 Thread Steven Rostedt
On Fri, 13 Oct 2017 15:06:09 +0200 Petr Mladek wrote: > > > > Can we even have !PRINTK && EARLY_PRINTK? If so it seems to me continued > > usage of early_printk() is what makes most sense. > > Yes, !PRINTK && EARLY_PRINTK is possible at the moment. It makes some > sense because EARLY_PRINTK ne

Re: [PATCH v5 1/3] PCI: rockchip: Add support for pcie wake irq

2017-10-13 Thread Rafael J. Wysocki
[+cc Tony] On Friday, October 13, 2017 5:04:41 AM CEST Bjorn Helgaas wrote: > [+cc Rafael, linux-pm] > > On Mon, Sep 11, 2017 at 11:10:27PM +0800, Jeffy Chen wrote: > > Add support for PCIE_WAKE pin in rockchip pcie driver. > > > > Signed-off-by: Jeffy Chen > > --- > > > > Changes in v5: > > R

Re: [v11 3/6] mm, oom: cgroup-aware OOM killer

2017-10-13 Thread Roman Gushchin
On Thu, Oct 12, 2017 at 02:50:38PM -0700, David Rientjes wrote: > On Wed, 11 Oct 2017, Roman Gushchin wrote: > > Think about it in a different way: we currently compare per-process usage > and userspace has /proc/pid/oom_score_adj to adjust that usage depending > on priorities of that process an

[PATCH v2] f2fs: add bug_on when f2fs_gc even fails to get one victim

2017-10-13 Thread Yunlong Song
This can help us to debug on some corner case. Signed-off-by: Yunlong Song Signed-off-by: Chao Yu --- fs/f2fs/gc.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c index 197ebf4..2b03202 100644 --- a/fs/f2fs/gc.c +++ b/fs/f2fs/gc.c @@ -986,6 +

Re: [PATCH v2 07/10] KVM: arm/arm64: vgic-its: new helper functions to free the caches

2017-10-13 Thread Christoffer Dall
On Wed, Sep 27, 2017 at 03:28:37PM +0200, Eric Auger wrote: > From: wanghaibin > > We create 2 new functions that frees the device and two free > collection lists. this is currently called by vgic_its_destroy() These are > and we will add other

[PATCH] PM / core: Fix kerneldoc comments of four functions

2017-10-13 Thread Rafael J. Wysocki
From: Rafael J. Wysocki Fix the kerneldoc comments of __device_suspend_noirq(), __device_suspend_late() and __device_suspend() where the function names in kerneldoc don't match the actual names of the functions. Also fix the device_resume_noirq() kerneldoc comment which mentions "early resume" i

[PATCH v2] PM / QoS: Drop PM_QOS_FLAG_REMOTE_WAKEUP

2017-10-13 Thread Rafael J. Wysocki
From: Rafael J. Wysocki The PM QoS flag PM_QOS_FLAG_REMOTE_WAKEUP is not used consistently and the vast majority of code simply assumes that remote wakeup should be enabled for devices in runtime suspend if they can generate wakeup signals, so drop it. Signed-off-by: Rafael J. Wysocki Acked-by:

Re: [RFC PATCH v9 for 4.15 01/14] Restartable sequences system call

2017-10-13 Thread Mathieu Desnoyers
- On Oct 13, 2017, at 8:50 AM, Florian Weimer fwei...@redhat.com wrote: > On 10/13/2017 01:03 AM, Mathieu Desnoyers wrote: >> Expose a new system call allowing each thread to register one userspace >> memory area to be used as an ABI between kernel and user-space for two >> purposes: user-spac

Re: [PATCH v16 5/5] virtio-balloon: VIRTIO_BALLOON_F_CTRL_VQ

2017-10-13 Thread Michael S. Tsirkin
On Thu, Oct 12, 2017 at 11:54:56AM +0800, Wei Wang wrote: > > But I think flushing is very fragile. You will easily run into races > > if one of the actors gets out of sync and keeps adding data. > > I think adding an ID in the free vq stream is a more robust > > approach. > > > > Adding ID to th

Re: [PATCH v5 11/16] perf report: properly handle branch count in match_chain

2017-10-13 Thread Arnaldo Carvalho de Melo
Em Mon, Oct 09, 2017 at 10:33:05PM +0200, Milian Wolff escreveu: > Some of the code paths I introduced before returned too early > without running the code to handle a node's branch count. > By refactoring match_chain to only have one exit point, this > can be remedied. Fixing up this one now. >

Re: [PATCH 0/3] arm64: cpuinfo: make /proc/cpuinfo more human-readable

2017-10-13 Thread Timur Tabi
On Wed, Sep 27, 2017 at 5:34 AM, Mark Rutland wrote: > Hi Al, > > On Tue, Sep 26, 2017 at 04:23:21PM -0600, Al Stone wrote: >> As ARMv8 servers get deployed, I keep getting the same set of questions >> from end-users of those systems: what do all the hex numbers mean in >> /proc/cpuinfo and could

[PATCH] KVM: X86: fix a bad_page bug_on path

2017-10-13 Thread Peng Hao
When poweroff L1 Guest with L2 guset on L1, it exists a path to trigger a bad_page bug_on. !page_count(pfn_to_page(pfn)) Warning in mmu_spte_clear_track_bits will appear before,then it may set A/D bit for the freed page and trigger a bad_page bug_on. Signed-off-by: Peng Hao --- arch/x86/kvm/mmu.

<    1   2   3   4   5   6   7   8   9   10   >