Re: [PATCH v2] ACPI / LPIT: Add Low Power Idle Table (LPIT) support

2017-10-05 Thread Andy Shevchenko
On Thu, Oct 5, 2017 at 9:16 PM, Srinivas Pandruvada wrote: > Added functionality to read LPIT table, which provides: > > - Sysfs interface to read residency counters via > /sys/devices/system/cpu/cpuidle/low_power_idle_cpu_residency_us > /sys/devices/system/cpu/cpuidle/low_power_idle_system_reside

Re: [PATCH v5 1/7] media: add glossary.rst with a glossary of terms used at V4L2 spec

2017-10-05 Thread Mauro Carvalho Chehab
Em Thu, 5 Oct 2017 11:21:07 +0300 Sakari Ailus escreveu: > Hi Mauro, > > My apologies for the late reply. > > On Tue, Aug 29, 2017 at 10:07:50AM -0300, Mauro Carvalho Chehab wrote: > > Em Tue, 29 Aug 2017 10:47:48 +0300 > > Sakari Ailus escreveu: > > > > > Hi Mauro, > > > > > > Thanks for

Re: [PATCH] i2c: piix4: Fix SMBus port selection for AMD Family 17h chips

2017-10-05 Thread Rudolf Marek
Hi Guys, Even in "AMD Family 15h Models 60h-6Fh Processors" [1] are ports3 and ports4 marked as "Reserved". Maybe we should limit "KERN" to 2 ports? Thanks Rudolf [1] http://support.amd.com/TechDocs/50742_15h_Models_60h-6Fh_BKDG.pdf

Re: [PATCH V2] PCI: AER: fix deadlock in do_recovery

2017-10-05 Thread Bjorn Helgaas
On Thu, Oct 05, 2017 at 11:05:12PM +0800, Wei Yang wrote: > On Wed, Oct 4, 2017 at 5:15 AM, Bjorn Helgaas wrote: > > [+cc Alex, Gavin, Wei] > > > > On Fri, Sep 29, 2017 at 10:49:38PM -0700, Govindarajulu Varadarajan wrote: > >> CPU0 CPU1 > >> --

[PATCH v7 2/6] vfs: Remove unnecessary list_for_each_entry_safe() variants

2017-10-05 Thread Waiman Long
From: Jan Kara evict_inodes() and invalidate_inodes() use list_for_each_entry_safe() to iterate sb->s_inodes list. However, since we use i_lru list entry for our local temporary list of inodes to destroy, the inode is guaranteed to stay in sb->s_inodes list while we hold sb->s_inode_list_lock. So

[PATCH v7 3/6] vfs: Use dlock list for superblock's inode list

2017-10-05 Thread Waiman Long
When many threads are trying to add or delete inode to or from a superblock's s_inodes list, spinlock contention on the list can become a performance bottleneck. This patch changes the s_inodes field to become a dlock list which is a distributed set of lists with per-list spinlocks. As a result,

[PATCH v7 6/6] lib/dlock-list: Add an IRQ-safe mode to be used in interrupt handler

2017-10-05 Thread Waiman Long
To enable the use of dlock-list in an interrupt handler, a new irqsafe mode can now be specified at dlock-list allocation time as an additional argument to alloc_dlock_list_heads(). With that mode specified, the spin_lock_irqsave/spin_unlock_irqrestore pair will be used instead of the regular lock

[PATCH v7 5/6] lib/dlock-list: Enable faster lookup with hashing

2017-10-05 Thread Waiman Long
Insertion and deletion is relatively cheap and mostly contention free for dlock-list. Lookup, on the other hand, can be rather costly because all the lists in a dlock-list will have to be iterated. Currently dlock-list insertion is based on the cpu that the task is running on. So a given object ca

[PATCH v7 4/6] lib/dlock-list: Make sibling CPUs share the same linked list

2017-10-05 Thread Waiman Long
The dlock list needs one list for each of the CPUs available. However, for sibling CPUs, they are sharing the L2 and probably L1 caches too. As a result, there is not much to gain in term of avoiding cacheline contention while increasing the cacheline footprint of the L1/L2 caches as separate lists

[PATCH v7 1/6] lib/dlock-list: Distributed and lock-protected lists

2017-10-05 Thread Waiman Long
Linked list is used everywhere in the Linux kernel. However, if many threads are trying to add or delete entries into the same linked list, it can create a performance bottleneck. This patch introduces a new list APIs that provide a set of distributed lists (one per CPU), each of which is protecte

[PATCH v7 0/6] vfs: Use dlock list for SB's s_inodes list

2017-10-05 Thread Waiman Long
v6->v7: - Fix outdated email address. - Add a comment to patch 4 to explain allocation issue & fix a compilation problem with cpumask. - Replace patch 6 with another one that adds an irqsafe mode argument in alloc_dlock_list_heads() instead of adding new APIs. v5->v6: - Rebased the patc

Re: [PATCH] powerpc: Drop lockdep_assert_cpus_held call from arch_update_cpu_topology

2017-10-05 Thread Thomas Gleixner
Thiago, On Thu, 5 Oct 2017, Thiago Jung Bauermann wrote: > Thomas Gleixner writes: > It doesn't look like powerpc uses arch_update_cpu_topology differently > than other arches. Are you saying that all callers of the function > should be holding cpu_hotplug_lock? No. I didn't check as I was lazy

Re: [PATCH v4 12/14] platform/x86: wmi: create character devices when requested by drivers

2017-10-05 Thread Greg KH
On Thu, Oct 05, 2017 at 10:39:25AM -0700, Darren Hart wrote: > > It does, thanks. And as we now understand it (I'm guessing it had to be > > semi-understood in the older wmi drivers already), validating it > > properly seems to be the key for creating an interface that we "know" to > > be safe. >

Re: [PATCH] block/laptop_mode: Convert timers to use timer_setup()

2017-10-05 Thread Kees Cook
On Thu, Oct 5, 2017 at 11:26 AM, Jens Axboe wrote: > Honestly, I think the change should have waited for 4.15 in that case. > Why the rush? It wasn't ready for the merge window. My understanding from my discussion with tglx was that if the API change waiting for 4.15, then the conversions would h

Re: [PATCH 1/2] IB/hfi1: Use preempt_{dis,en}able_nort()

2017-10-05 Thread Arnaldo Carvalho de Melo
Em Thu, Oct 05, 2017 at 01:29:00PM -0500, Julia Cartwright escreveu: > On Thu, Oct 05, 2017 at 01:53:05PM -0300, Arnaldo Carvalho de Melo wrote: > > So __this_cpu_inc() checks preemption but this_cpu_inc() doesn't and > > thus we're ok here? Or am I getting lost in this maze of defines? :-) > I t

Re: [PATCH] block/laptop_mode: Convert timers to use timer_setup()

2017-10-05 Thread Jens Axboe
On 10/05/2017 12:49 PM, Kees Cook wrote: > On Thu, Oct 5, 2017 at 11:26 AM, Jens Axboe wrote: >> Honestly, I think the change should have waited for 4.15 in that case. >> Why the rush? It wasn't ready for the merge window. > > My understanding from my discussion with tglx was that if the API > ch

Re: [PATCH] powerpc: Default to enabling STRICT_KERNEL_RWX

2017-10-05 Thread christophe leroy
Le 05/10/2017 à 19:30, Kees Cook a écrit : On Thu, Oct 5, 2017 at 12:49 AM, Christophe LEROY wrote: Le 05/10/2017 à 05:45, Kees Cook a écrit : When available, CONFIG_KERNEL_RWX should be default-enabled. On PPC32, this option implies deactivating BATs and/or LTLB mapping of the linear

Re: [PATCH] powerpc: Default to enabling STRICT_KERNEL_RWX

2017-10-05 Thread Kees Cook
On Thu, Oct 5, 2017 at 11:57 AM, christophe leroy wrote: > > > Le 05/10/2017 à 19:30, Kees Cook a écrit : >> >> On Thu, Oct 5, 2017 at 12:49 AM, Christophe LEROY >> wrote: >>> >>> >>> >>> Le 05/10/2017 à 05:45, Kees Cook a écrit : When available, CONFIG_KERNEL_RWX should be default

RE: [PATCH v4 12/14] platform/x86: wmi: create character devices when requested by drivers

2017-10-05 Thread Mario.Limonciello
> -Original Message- > From: Greg KH [mailto:g...@kroah.com] > Sent: Thursday, October 5, 2017 1:47 PM > To: Darren Hart > Cc: Pali Rohár ; Limonciello, Mario > ; andy.shevche...@gmail.com; linux- > ker...@vger.kernel.org; platform-driver-...@vger.kernel.org; l...@kernel.org; > quasi...@go

[PATCH v2] powerpc: Default to enabling STRICT_KERNEL_RWX

2017-10-05 Thread Kees Cook
When available, CONFIG_KERNEL_RWX should be default-enabled for PPC64. On PPC32, there is a performance trade-off. Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Michael Ellerman Cc: Christophe LEROY Cc: Balbir Singh Cc: linuxppc-...@lists.ozlabs.org Signed-off-by: Kees Cook --- v2: - dep

Re: [PATCH] powerpc/perf/hv-24x7: Delete an error message for a failed memory allocation in create_events_from_catalog()

2017-10-05 Thread Thiago Jung Bauermann
Thanks, Markus. SF Markus Elfring writes: > From: Markus Elfring > Date: Thu, 5 Oct 2017 18:02:05 +0200 > > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > arch/pow

Re: [linux-next][Oops] CPU toggle resulted in kernel crash

2017-10-05 Thread Kees Cook
On Thu, Oct 5, 2017 at 10:21 AM, Abdul Haleem wrote: > Hi, > > CPU off on in a loop for single cpu results in kernel panic for > 4.14.0-rc2-next-20170929 > > Machine: Power 8 PowerVM LPAR > Kernel: 4.14.0-rc2-next-20170929 > gcc: 5.1.1 > config : attached > > Steps to recreate: > -

Re: [PATCH] mwifiex: Use put_unaligned_le32

2017-10-05 Thread Himanshu Jha
On Thu, Oct 05, 2017 at 11:02:50AM -0700, Brian Norris wrote: > On Thu, Oct 05, 2017 at 08:52:33PM +0530, Himanshu Jha wrote: > > There are various instances where a function used in file say for eg > > int func_align (void* a) > > is used and it is defined in align.h > > But many files don't *dire

Re: [PATCH v4 12/14] platform/x86: wmi: create character devices when requested by drivers

2017-10-05 Thread Greg KH
On Thu, Oct 05, 2017 at 07:03:24PM +, mario.limoncie...@dell.com wrote: > > -Original Message- > > From: Greg KH [mailto:g...@kroah.com] > > Sent: Thursday, October 5, 2017 1:47 PM > > To: Darren Hart > > Cc: Pali Rohár ; Limonciello, Mario > > ; andy.shevche...@gmail.com; linux- > > k

Re: [PATCH 1/2] IB/hfi1: Use preempt_{dis,en}able_nort()

2017-10-05 Thread Steven Rostedt
On Thu, 5 Oct 2017 15:53:30 -0300 Arnaldo Carvalho de Melo wrote: > Em Thu, Oct 05, 2017 at 01:29:00PM -0500, Julia Cartwright escreveu: > > On Thu, Oct 05, 2017 at 01:53:05PM -0300, Arnaldo Carvalho de Melo wrote: > > > So __this_cpu_inc() checks preemption but this_cpu_inc() doesn't and > > >

Re: [PATCH] coccinelle: api: detect duplicate chip data arrays

2017-10-05 Thread Julia Lawall
On Fri, 6 Oct 2017, Masahiro Yamada wrote: > 2017-10-01 21:42 GMT+09:00 Julia Lawall : > > This semantic patch detects duplicate arrays declared using BQ27XXX_DATA > > within a single structure. It is currently specific to the file > > drivers/power/supply/bq27xxx_battery.c. > > > > Signed-off-

Re: [PATCH] coccinelle: api: detect duplicate chip data arrays

2017-10-05 Thread Joe Perches
On Thu, 2017-10-05 at 21:13 +0200, Julia Lawall wrote: > > On Fri, 6 Oct 2017, Masahiro Yamada wrote: > > > 2017-10-01 21:42 GMT+09:00 Julia Lawall : > > > This semantic patch detects duplicate arrays declared using BQ27XXX_DATA > > > within a single structure. It is currently specific to the fi

Re: [PATCH] isdn/gigaset: Convert timers to use timer_setup()

2017-10-05 Thread Kees Cook
On Thu, Oct 5, 2017 at 12:58 AM, Paul Bolle wrote: > Hi Kees, > > On Wed, 2017-10-04 at 17:52 -0700, Kees Cook wrote: >> Also uses kzmalloc to replace open-coded field assignments to NULL and zero. > > If I'm allowed to whine (chances that I'm allowed to do that are not so great > as Dave tends to

Re: [PATCH] coccinelle: api: detect duplicate chip data arrays

2017-10-05 Thread Julia Lawall
On Thu, 5 Oct 2017, Joe Perches wrote: > On Thu, 2017-10-05 at 21:13 +0200, Julia Lawall wrote: > > > > On Fri, 6 Oct 2017, Masahiro Yamada wrote: > > > > > 2017-10-01 21:42 GMT+09:00 Julia Lawall : > > > > This semantic patch detects duplicate arrays declared using BQ27XXX_DATA > > > > within a

Re: [PATCH] coccinelle: api: detect duplicate chip data arrays

2017-10-05 Thread Liam Breck
Hi, sorry for slow reply... Can we patch something to make this script run by default on bq7_battery_i2c build? If so let's do that. Also maybe the name of the script should include "bq27xxx_data"? Few more comments below... On Sun, Oct 1, 2017 at 5:42 AM, Julia Lawall wrote: > This semant

Re: [RFC PATCH 1/2] arm64: mm: Use READ_ONCE/WRITE_ONCE when accessing page tables

2017-10-05 Thread Paul E. McKenney
On Thu, Oct 05, 2017 at 05:31:54PM +0100, Will Deacon wrote: > Hi Paul, > > On Tue, Oct 03, 2017 at 12:11:10PM -0700, Paul E. McKenney wrote: > > On Fri, Sep 29, 2017 at 05:33:49PM +0100, Will Deacon wrote: > > > On Fri, Sep 29, 2017 at 09:29:39AM -0700, Paul E. McKenney wrote: > > > > On Fri, Sep

Re: [PATCH] block/laptop_mode: Convert timers to use timer_setup()

2017-10-05 Thread Thomas Gleixner
On Thu, 5 Oct 2017, Jens Axboe wrote: > On 10/05/2017 11:49 AM, Kees Cook wrote: > > Yes, totally true. tglx and I ended up meeting face-to-face at the > > Kernel Recipes conference and we solved some outstanding design issues > > with the conversion. The timing meant the new API went into -rc3, >

[PREVIEW] Add x86 zstd kernel compression

2017-10-05 Thread Nick Terrell
On 10/5/17, 1:18 AM, "René Rebe" wrote: > > Hi Nick, > > On Oct 5, 2017, at 1:29, Nick Terrell wrote: > >> On 10/4/17, 3:01 AM, "linux-kernel-ow...@vger.kernel.org on behalf of René >> Rebe" >> wrote: >>> Hi, >>> >>> I noticed zstd compression was recently added for btrfs and squashfs. >>> Are

Re: [PATCH] coccinelle: api: detect duplicate chip data arrays

2017-10-05 Thread Liam Breck
Hi Joe, On Thu, Oct 5, 2017 at 12:15 PM, Joe Perches wrote: > On Thu, 2017-10-05 at 21:13 +0200, Julia Lawall wrote: >> >> On Fri, 6 Oct 2017, Masahiro Yamada wrote: >> >> > 2017-10-01 21:42 GMT+09:00 Julia Lawall : >> > > This semantic patch detects duplicate arrays declared using BQ27XXX_DATA >

Re: [PATCH] coccinelle: api: detect duplicate chip data arrays

2017-10-05 Thread Julia Lawall
On Thu, 5 Oct 2017, Liam Breck wrote: > Hi, sorry for slow reply... > > Can we patch something to make this script run by default on > bq7_battery_i2c build? If so let's do that. I don't think anything is set up for that. But any changes to the file should be checked by the 0-day bot. > A

Re: [PATCH] coccinelle: api: detect duplicate chip data arrays

2017-10-05 Thread Julia Lawall
On Thu, 5 Oct 2017, Liam Breck wrote: > Hi Joe, > > On Thu, Oct 5, 2017 at 12:15 PM, Joe Perches wrote: > > On Thu, 2017-10-05 at 21:13 +0200, Julia Lawall wrote: > >> > >> On Fri, 6 Oct 2017, Masahiro Yamada wrote: > >> > >> > 2017-10-01 21:42 GMT+09:00 Julia Lawall : > >> > > This semantic pa

Re: [PATCH] usb: isp1301-omap: Convert timers to use timer_setup()

2017-10-05 Thread Tony Lindgren
* Kees Cook [171004 17:57]: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Felipe Balbi > Cc: Greg Kroah-Hartman > Cc: linux-...@vger.kern

[PATCH] isdn/gigaset: Use kzalloc instead of open-coded field zeroing

2017-10-05 Thread Kees Cook
This replaces a kmalloc followed by a bunch of per-field zeroing with a single kzalloc call, reducing the lines of code. Cc: Paul Bolle Cc: Karsten Keil Cc: "David S. Miller" Cc: Johan Hovold Cc: gigaset307x-com...@lists.sourceforge.net Cc: net...@vger.kernel.org Signed-off-by: Kees Cook ---

Re: [PATCH] coccinelle: api: detect duplicate chip data arrays

2017-10-05 Thread Joe Perches
On Thu, 2017-10-05 at 21:19 +0200, Julia Lawall wrote: > On Thu, 5 Oct 2017, Joe Perches wrote: > > On Thu, 2017-10-05 at 21:13 +0200, Julia Lawall wrote: > > > On Fri, 6 Oct 2017, Masahiro Yamada wrote: > > > > 2017-10-01 21:42 GMT+09:00 Julia Lawall : > > > > > This semantic patch detects duplica

[PATCH 0/2] PowerPC-Cell platform: Adjustments for four function implementations

2017-10-05 Thread SF Markus Elfring
From: Markus Elfring Date: Thu, 5 Oct 2017 21:25:43 +0200 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation in three functions Improve a size determination in three functions arch/powe

[PATCH v2] isdn/gigaset: Convert timers to use timer_setup()

2017-10-05 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: Paul Bolle Cc: Karsten Keil Cc: "David S. Miller" Cc: Johan Hovold Cc: gigaset307x-com...@lists.sour

Re: [RFC PATCH 1/2] arm64: mm: Use READ_ONCE/WRITE_ONCE when accessing page tables

2017-10-05 Thread Andrea Parri
Hi Will, none of my comments below represent objections to this patch, but let me remark: On Thu, Oct 05, 2017 at 05:31:54PM +0100, Will Deacon wrote: > Hi Paul, > > On Tue, Oct 03, 2017 at 12:11:10PM -0700, Paul E. McKenney wrote: > > On Fri, Sep 29, 2017 at 05:33:49PM +0100, Will Deacon wrote

Re: [PATCH] net: qcom/emac: make function emac_isr static

2017-10-05 Thread Timur Tabi
On 10/05/2017 04:10 AM, Colin King wrote: From: Colin Ian King The function emac_isr is local to the source and does not need to be in global scope, so make it static. Cleans up sparse warnings: symbol 'emac_isr' was not declared. Should it be static? Signed-off-by: Colin Ian King ACK -- Qu

Re: [PATCH v4 12/14] platform/x86: wmi: create character devices when requested by drivers

2017-10-05 Thread Pali Rohár
Hi Greg! I would answer some of your question... On Thursday 05 October 2017 21:09:48 Greg KH wrote: > On Thu, Oct 05, 2017 at 07:03:24PM +, mario.limoncie...@dell.com wrote: > > On Windows it's a driver-less solution. Vendors don't do anything other > > than provide the MOF (which describes

RE: [PATCH v4 12/14] platform/x86: wmi: create character devices when requested by drivers

2017-10-05 Thread Mario.Limonciello
> -Original Message- > From: Greg KH [mailto:g...@kroah.com] > Sent: Thursday, October 5, 2017 2:10 PM > To: Limonciello, Mario > Cc: dvh...@infradead.org; pali.ro...@gmail.com; andy.shevche...@gmail.com; > linux-kernel@vger.kernel.org; platform-driver-...@vger.kernel.org; > l...@kernel.or

Re: [PATCH] coccinelle: api: detect duplicate chip data arrays

2017-10-05 Thread Liam Breck
Hi Julia, On Thu, Oct 5, 2017 at 12:25 PM, Julia Lawall wrote: > > > On Thu, 5 Oct 2017, Liam Breck wrote: > >> Hi, sorry for slow reply... >> >> Can we patch something to make this script run by default on >> bq7_battery_i2c build? If so let's do that. > > I don't think anything is set up fo

RE: [PATCH v4 12/14] platform/x86: wmi: create character devices when requested by drivers

2017-10-05 Thread Mario.Limonciello
> -Original Message- > From: Pali Rohár [mailto:pali.ro...@gmail.com] > Sent: Thursday, October 5, 2017 2:33 PM > To: Greg KH > Cc: Limonciello, Mario ; dvh...@infradead.org; > andy.shevche...@gmail.com; linux-kernel@vger.kernel.org; platform-driver- > x...@vger.kernel.org; l...@kernel.org

Re: [PATCH] coccinelle: api: detect duplicate chip data arrays

2017-10-05 Thread Julia Lawall
On Thu, 5 Oct 2017, Joe Perches wrote: > On Thu, 2017-10-05 at 21:19 +0200, Julia Lawall wrote: > > On Thu, 5 Oct 2017, Joe Perches wrote: > > > On Thu, 2017-10-05 at 21:13 +0200, Julia Lawall wrote: > > > > On Fri, 6 Oct 2017, Masahiro Yamada wrote: > > > > > 2017-10-01 21:42 GMT+09:00 Julia La

Re: [PATCH] coccinelle: api: detect duplicate chip data arrays

2017-10-05 Thread Julia Lawall
On Thu, 5 Oct 2017, Liam Breck wrote: > Hi Julia, > > On Thu, Oct 5, 2017 at 12:25 PM, Julia Lawall wrote: > > > > > > On Thu, 5 Oct 2017, Liam Breck wrote: > > > >> Hi, sorry for slow reply... > >> > >> Can we patch something to make this script run by default on > >> bq7_battery_i2c build

[PATCH 1/2] powerpc/platforms/cell: Delete an error message for a failed memory allocation in three functions

2017-10-05 Thread SF Markus Elfring
From: Markus Elfring Date: Thu, 5 Oct 2017 21:04:30 +0200 Omit extra messages for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- arch/powerpc/platforms/cell/axon_msi.c | 5 + arch/powerpc/platfo

Re: [PATCH] block/laptop_mode: Convert timers to use timer_setup()

2017-10-05 Thread Jens Axboe
On 10/05/2017 01:23 PM, Thomas Gleixner wrote: > On Thu, 5 Oct 2017, Jens Axboe wrote: >> On 10/05/2017 11:49 AM, Kees Cook wrote: >>> Yes, totally true. tglx and I ended up meeting face-to-face at the >>> Kernel Recipes conference and we solved some outstanding design issues >>> with the conversio

[PATCH 2/2] powerpc/platforms/cell: Improve a size determination in three functions

2017-10-05 Thread SF Markus Elfring
From: Markus Elfring Date: Thu, 5 Oct 2017 21:12:41 +0200 Replace the specification of data structures by pointer dereferences as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. This issue was detect

Re: [PATCH] coccinelle: api: detect duplicate chip data arrays

2017-10-05 Thread Julia Lawall
On Thu, 5 Oct 2017, Liam Breck wrote: > Hi Julia, > > On Thu, Oct 5, 2017 at 12:25 PM, Julia Lawall wrote: > > > > > > On Thu, 5 Oct 2017, Liam Breck wrote: > > > >> Hi, sorry for slow reply... > >> > >> Can we patch something to make this script run by default on > >> bq7_battery_i2c build

[PATCH 4/6] of: move kobj_to_device_node() into dynamic.c

2017-10-05 Thread Rob Herring
The only user of kobj_to_device_node() is in dynamic.c, so move it there. This avoids having to make it conditional once kobject is configurable. Cc: Nicolas Pitre Cc: Frank Rowand Signed-off-by: Rob Herring --- drivers/of/dynamic.c| 5 + drivers/of/of_private.h | 6 -- 2 files cha

[PATCH 6/6] of: make kobject and bin_attribute support configurable

2017-10-05 Thread Rob Herring
Having device_nodes be kobjects is only needed if sysfs or OF_DYNAMIC is enabled. Otherwise, having a kobject in struct device_node is unnecessary bloat in minimal kernel configurations. Likewise, bin_attribute is only needed in struct property when sysfs is enabled, so we can make it configurable

[PATCH 5/6] of: wrap accesses to device_node kobject

2017-10-05 Thread Rob Herring
In preparation to make kobject element in struct device_node optional, provide and use a macro to return the kobject pointer. The only user outside the DT core is the driver core. Cc: Greg Kroah-Hartman Cc: Nicolas Pitre Cc: Frank Rowand Signed-off-by: Rob Herring --- drivers/base/core.c | 2

[PATCH 2/6] of: remove struct property.unique_id for FDT

2017-10-05 Thread Rob Herring
Only Sparc uses unique_id, so remove it for FDT builds and shrink struct property a bit making the unflattened DT less of a memory hog. Cc: Nicolas Pitre Cc: Frank Rowand Signed-off-by: Rob Herring --- include/linux/of.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/linux/of.h

[PATCH] net/ipv6: remove unused err variable on icmpv6_push_pending_frames

2017-10-05 Thread Tim Hansen
int err is unused by icmpv6_push_pending_frames(), this patch returns removes the variable and returns the function with 0. git bisect shows this variable has been around since linux has been in git in commit 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2. This was found by running make coccicheck

Re: [PATCH v3] sched/deadline: make it configurable

2017-10-05 Thread Mathieu Poirier
On 3 October 2017 at 20:36, Nicolas Pitre wrote: > On most small systems, the deadline scheduler class is a luxury that > rarely gets used if at all. It is preferable to have the ability to > configure it out to reduce the kernel size in that case. > > Before: > > $ size -t kernel/sched/built-in.o

[PATCH 1/6] of: fix missing kobject init for !SYSFS && OF_DYNAMIC config

2017-10-05 Thread Rob Herring
The ref counting is broken for OF_DYNAMIC when sysfs is disabled because the kobject initialization is skipped. Only the properties add/remove/update should be skipped for !SYSFS config. Cc: Nicolas Pitre Cc: Frank Rowand Signed-off-by: Rob Herring --- drivers/of/base.c | 3 --- 1 file changed

[PATCH 3/6] of: make struct property _flags field configurable

2017-10-05 Thread Rob Herring
Only Sparc and CONFIG_OF_DYNAMIC use the struct property._flags field, so make it conditional shrinking struct property a bit. Cc: Nicolas Pitre Cc: Frank Rowand Signed-off-by: Rob Herring --- include/linux/of.h | 4 1 file changed, 4 insertions(+) diff --git a/include/linux/of.h b/inclu

[PATCH 0/6] Shrinking DT memory usage

2017-10-05 Thread Rob Herring
On kernels with a minimal config and a RAM target in the 100s of KB, DT is quite a hog of runtime memory usage. How much is dependent on how many nodes and properties in the DT which have a corresponding struct device_node and struct property in the kernel. Just skipping disabled nodes saves a lo

Re: [PATCH] coccinelle: api: detect duplicate chip data arrays

2017-10-05 Thread Liam Breck
Hi Joe, On Thu, Oct 5, 2017 at 12:30 PM, Joe Perches wrote: > On Thu, 2017-10-05 at 21:19 +0200, Julia Lawall wrote: >> On Thu, 5 Oct 2017, Joe Perches wrote: >> > On Thu, 2017-10-05 at 21:13 +0200, Julia Lawall wrote: >> > > On Fri, 6 Oct 2017, Masahiro Yamada wrote: >> > > > 2017-10-01 21:42 GM

RE: [PATCH v4 11/14] platform/x86: dell-smbios-wmi: Add new WMI dispatcher driver

2017-10-05 Thread Mario.Limonciello
> -Original Message- > From: Darren Hart [mailto:dvh...@infradead.org] > Sent: Thursday, October 5, 2017 12:58 PM > To: Limonciello, Mario > Cc: andy.shevche...@gmail.com; linux-kernel@vger.kernel.org; platform- > driver-...@vger.kernel.org; l...@kernel.org; quasi...@google.com; > pali.ro.

Re: [PATCH] md: raid10: remove VLAIS

2017-10-05 Thread Guenter Roeck
On Thu, Oct 5, 2017 at 11:28 AM, Matthias Kaehlcke wrote: > The raid10 driver can't be built with clang since it uses a variable > length array in a structure (VLAIS): > > drivers/md/raid10.c:4583:17: error: fields must have a constant size: > 'variable length array in structure' extension will

Re: [PATCH] block/laptop_mode: Convert timers to use timer_setup()

2017-10-05 Thread Jens Axboe
On 10/05/2017 01:41 PM, Jens Axboe wrote: > On 10/05/2017 01:23 PM, Thomas Gleixner wrote: >> On Thu, 5 Oct 2017, Jens Axboe wrote: >>> On 10/05/2017 11:49 AM, Kees Cook wrote: Yes, totally true. tglx and I ended up meeting face-to-face at the Kernel Recipes conference and we solved some

[RT-SUMMIT] Prague Oct. 21st

2017-10-05 Thread Thomas Gleixner
Folks, this is a reminder for the upcoming RT-Summit event in Prague on October 21st at the Czech Technical University. The schedule and logistics information are available from: https://wiki.linuxfoundation.org/realtime/events/rt-summit2017/start If you have questions or need assistance plea

Re: [PATCH 1/2] scripts/dtc: add fdt_overlay.c and fdt_addresses.c to sync script

2017-10-05 Thread Tom Rini
On Thu, Oct 05, 2017 at 10:09:39AM -0500, Rob Herring wrote: > On Thu, Oct 5, 2017 at 9:39 AM, Tom Rini wrote: > > On Tue, Oct 03, 2017 at 05:23:28PM -0500, Rob Herring wrote: > >> On Tue, Oct 3, 2017 at 5:04 PM, Tom Rini wrote: > >> > On Tue, Oct 03, 2017 at 01:31:17PM -0500, Rob Herring wrote:

Re: [PATCH] coccinelle: api: detect duplicate chip data arrays

2017-10-05 Thread Joe Perches
On Thu, 2017-10-05 at 21:40 +0200, Julia Lawall wrote: > On Thu, 5 Oct 2017, Joe Perches wrote: > > btw: spatch 1.7 doesn't seem to have a tag in git > > > > From the script: > > > > // Requires: 1.0.7 > > > > Assuming this is correct, then this doesn't even run today > > except maybe on you

Re: [PATCH] coccinelle: api: detect duplicate chip data arrays

2017-10-05 Thread Joe Perches
On Thu, 2017-10-05 at 12:46 -0700, Liam Breck wrote: > Hi Joe, > > On Thu, Oct 5, 2017 at 12:30 PM, Joe Perches wrote: > > On Thu, 2017-10-05 at 21:19 +0200, Julia Lawall wrote: > > > On Thu, 5 Oct 2017, Joe Perches wrote: > > > > On Thu, 2017-10-05 at 21:13 +0200, Julia Lawall wrote: > > > > > O

Re: [PATCH] coccinelle: api: detect duplicate chip data arrays

2017-10-05 Thread Julia Lawall
On Thu, 5 Oct 2017, Joe Perches wrote: > On Thu, 2017-10-05 at 21:40 +0200, Julia Lawall wrote: > > On Thu, 5 Oct 2017, Joe Perches wrote: > > > btw: spatch 1.7 doesn't seem to have a tag in git > > > > > > From the script: > > > > > > // Requires: 1.0.7 > > > > > > Assuming this is correct,

Re: [PATCH 1/3] arm/xen: don't inclide rwlock.h directly.1~B

2017-10-05 Thread Stefano Stabellini
On Thu, 5 Oct 2017, Sebastian Andrzej Siewior wrote: > rwlock.h should not be included directly. Instead linux/splinlock.h > should be included. One thing it does is to break the RT build. > > Cc: Stefano Stabellini > Cc: xen-de...@lists.xenproject.org > Cc: linux-arm-ker...@lists.infradead.org >

Re: [PATCH] coccinelle: api: detect duplicate chip data arrays

2017-10-05 Thread Julia Lawall
On Thu, 5 Oct 2017, Joe Perches wrote: > On Thu, 2017-10-05 at 12:46 -0700, Liam Breck wrote: > > Hi Joe, > > > > On Thu, Oct 5, 2017 at 12:30 PM, Joe Perches wrote: > > > On Thu, 2017-10-05 at 21:19 +0200, Julia Lawall wrote: > > > > On Thu, 5 Oct 2017, Joe Perches wrote: > > > > > On Thu, 201

Re: [PATCH 1/2] powerpc/platforms/cell: Delete an error message for a failed memory allocation in three functions

2017-10-05 Thread Michal Suchánek
Hello, On Thu, 5 Oct 2017 21:36:26 +0200 SF Markus Elfring wrote: > From: Markus Elfring > Date: Thu, 5 Oct 2017 21:04:30 +0200 > > Omit extra messages for a memory allocation failure in these > functions. this is bogus. All these functions return -1 on any error. Until they reflect the error

Re: [PATCH] kbuild: drop unused symverfile in Makefile.modpost

2017-10-05 Thread Masahiro Yamada
2017-09-25 21:25 GMT+09:00 Cao jin : > Since commit 040fcc819, symverfile has been replaced with kernelsymfile > and modulesymfile. > > Signed-off-by: Cao jin > --- > scripts/Makefile.modpost | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/scripts/Makefile.modpost b/scripts/Makefile.modpo

Re: [PATCH] kbuild: Fix optimization level choice default

2017-10-05 Thread Masahiro Yamada
2017-10-04 16:27 GMT+09:00 Arnd Bergmann : > On Wed, Oct 4, 2017 at 1:53 AM, Ulf Magnusson wrote: >> The choice containing the CC_OPTIMIZE_FOR_PERFORMANCE symbol >> accidentally added a "CONFIG_" prefix when trying to make it the >> default, selecting an undefined symbol as the default. >> >> The

RE: [PATCH v4 4/5] cramfs: add mmap support

2017-10-05 Thread Chris Brandt
On Wednesday, October 04, 2017, Nicolas Pitre wrote: > On Wed, 4 Oct 2017, Christoph Hellwig wrote: > > > As said in my last mail: look at the VM_MIXEDMAP flag and how it is > > used by DAX, and you'll get out of the vma splitting business in the > > fault path. > > Alright, it appears to work. >

Re: [PATCH 1/2] powerpc/platforms/cell: Delete an error message for a failed memory allocation in three functions

2017-10-05 Thread Julia Lawall
On Thu, 5 Oct 2017, Michal Suchánek wrote: > Hello, > > On Thu, 5 Oct 2017 21:36:26 +0200 > SF Markus Elfring wrote: > > > From: Markus Elfring > > Date: Thu, 5 Oct 2017 21:04:30 +0200 > > > > Omit extra messages for a memory allocation failure in these > > functions. > > this is bogus. All th

Re: [RFC PATCH 1/2] arm64: mm: Use READ_ONCE/WRITE_ONCE when accessing page tables

2017-10-05 Thread Paul E. McKenney
On Thu, Oct 05, 2017 at 09:31:48PM +0200, Andrea Parri wrote: > Hi Will, > > none of my comments below represent objections to this patch, but > let me remark: > > > On Thu, Oct 05, 2017 at 05:31:54PM +0100, Will Deacon wrote: > > Hi Paul, > > > > On Tue, Oct 03, 2017 at 12:11:10PM -0700, Paul

[tip:timers/core] timer: Fix two mistakes in callback conversions

2017-10-05 Thread tip-bot for Kees Cook
Commit-ID: 6ac35264513e43634f127a92057f04a4b3c5cdbb Gitweb: https://git.kernel.org/tip/6ac35264513e43634f127a92057f04a4b3c5cdbb Author: Kees Cook AuthorDate: Thu, 5 Oct 2017 10:10:35 -0700 Committer: Thomas Gleixner CommitDate: Thu, 5 Oct 2017 22:04:48 +0200 timer: Fix two mistakes in

Re: Extreme time jitter with suspend/resume cycles

2017-10-05 Thread Gabriel Beddingfield
Hi John, On Wed, Oct 4, 2017 at 5:16 PM, John Stultz wrote: >> Please let me know what you think -- and what the right approach for >> solving this would be. > > So I suspect the best solution for you here is: provide some > infrastructure so clocksources that set CLOCK_SOURCE_SUSPEND_NONSTOP > w

Re: [PATCH] kbuild: clang: remove crufty HOSTCFLAGS

2017-10-05 Thread Masahiro Yamada
Hi Nick. 2017-10-01 8:14 GMT+09:00 Nick Desaulniers : > On Thu, Sep 28, 2017 at 07:52:35PM +0900, Masahiro Yamada wrote: >> 2017-09-26 11:28 GMT+09:00 Nick Desaulniers : >> > HOSTCFLAGS := -Wall -Wmissing-prototypes -Wstrict-prototypes -O2 \ >> > + $(call hostcc-option,-fno-delete

Re: [PATCH] kbuild: revert $(realpath ...) to $(shell cd ... && /bin/pwd)

2017-10-05 Thread Masahiro Yamada
2017-10-02 20:27 GMT+09:00 Julien Grall : > Hello, > > On 02/10/17 09:07, Masahiro Yamada wrote: >> >> I thought commit 8e9b46679923 ("kbuild: use $(abspath ...) instead of >> $(shell cd ... && /bin/pwd)") was a safe conversion, but it changed >> the behavior. >> >> $(abspath ...) / $(realpath ...)

Re: [PATCH 1/2] kbuild: link-vmlinux.sh: simplify .version increment

2017-10-05 Thread Masahiro Yamada
2017-09-22 14:31 GMT+09:00 Masahiro Yamada : > Since commit 1f2bfbd00e46 ("kbuild: link of vmlinux moved to a > script"), it is easy to increment .version without using a temporary > file .old_version. > > I do not see anybody who creates .tmp_version any more. Probably > it is a left-over of comm

Re: [PATCH 2/2] kbuild: mkcompile_h: do not create .version

2017-10-05 Thread Masahiro Yamada
2017-09-22 14:31 GMT+09:00 Masahiro Yamada : > This script need not to create .version; it will be created by > scripts/link-vmlinux.sh later. Clean-up the code slightly. > > Signed-off-by: Masahiro Yamada Applied to linux-kbuild/kbuild. -- Best Regards Masahiro Yamada

Re: [PATCH] ARM: shmobile: rcar-gen2: fix non-SMP build

2017-10-05 Thread Arnd Bergmann
On Thu, Oct 5, 2017 at 2:25 PM, Geert Uytterhoeven wrote: > On Thu, Oct 5, 2017 at 2:09 PM, Arnd Bergmann wrote: >> arch/arm/mach-shmobile/headsmp-apmu.S | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/arch/arm/mach-shmobile/headsmp-apmu.S >> b/arch/arm/mach-shmobile/headsmp-apmu.

Re: [PATCH 1/2] powerpc/platforms/cell: Delete an error message for a failed memory allocation in three functions

2017-10-05 Thread Michal Suchánek
On Thu, 5 Oct 2017 22:06:11 +0200 (CEST) Julia Lawall wrote: > On Thu, 5 Oct 2017, Michal Suchánek wrote: > > > Hello, > > > > On Thu, 5 Oct 2017 21:36:26 +0200 > > SF Markus Elfring wrote: > > > > > From: Markus Elfring > > > Date: Thu, 5 Oct 2017 21:04:30 +0200 > > > > > > Omit extra messa

Re: [PATCH] clk: export clk_bulk_prepare

2017-10-05 Thread Arnd Bergmann
On Thu, Oct 5, 2017 at 7:22 PM, Stephen Boyd wrote: > On 10/05, Arnd Bergmann wrote: >> The ARM allmodconfig build fails in linux-next, since one > > Which version of linux-next? I merged a patch for this already > and pushed it out a day or two ago. I used the latest linux-next, which unfortunat

Re: [PATCH v1 3/5] dt-bindings: Add DT bindings for NVIDIA Tegra AHB DMA controller

2017-10-05 Thread Rob Herring
On Tue, Sep 26, 2017 at 02:22:04AM +0300, Dmitry Osipenko wrote: > Document DT bindings for NVIDIA Tegra AHB DMA controller that presents > on Tegra20/30 SoC's. > > Signed-off-by: Dmitry Osipenko > --- > .../bindings/dma/nvidia,tegra20-ahbdma.txt | 23 > ++ > 1 file

Re: [PATCH 11/13] x86/paravirt: Add paravirt alternatives infrastructure

2017-10-05 Thread Boris Ostrovsky
> #ifdef CONFIG_PARAVIRT > +/* > + * Paravirt alternatives are applied much earlier than normal alternatives. > + * They are only applied when running on a hypervisor. They replace some > + * native instructions with calls to pv ops. > + */ > +void __init apply_pv_alternatives(void) > +{ > +

24e700e291 ("Merge branch 'x86-apic-for-linus' of .."): WARNING: kernel stack regs at 979f9f70 in kworker/u4:1:648 has bad 'bp' value (null)

2017-10-05 Thread kernel test robot
Greetings, 0day kernel testing robot got the below dmesg and the first bad commit is https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master commit 24e700e291d52bd200212487e2b654c0aa3f07a2 Merge: f57091767add2 c6ef89421e236 Author: Linus Torvalds AuthorDate: Mon Sep 4 17:4

[PATCH] [SUBMITTED 20171005] spi: spreadtrum adi: add hwspinlock dependency

2017-10-05 Thread Arnd Bergmann
With CONFIG_HWSPINLOCK=m, the new driver fails to link as a built-in driver: drivers/spi/spi-sprd-adi.o: In function `sprd_adi_remove': spi-sprd-adi.c:(.text+0x18): undefined reference to `hwspin_lock_free' drivers/spi/spi-sprd-adi.o: In function `sprd_adi_probe': spi-sprd-adi.c:(.text+0xfc): unde

Re: [PATCH] spi: spreadtrum adi: add hwspinlock dependency

2017-10-05 Thread Arnd Bergmann
On Thu, Oct 5, 2017 at 2:22 PM, Mark Brown wrote: > On Thu, Oct 05, 2017 at 02:11:17PM +0200, Arnd Bergmann wrote: > >> This adds a hard Kconfig dependency on HWSPINLOCK, which is the >> simplest solution since we don't care about building for the case >> without HWSPINLOCK. > > Given that there a

Re: [PATCH v2] ACPI / LPIT: Add Low Power Idle Table (LPIT) support

2017-10-05 Thread Srinivas Pandruvada
On Thu, 2017-10-05 at 21:39 +0300, Andy Shevchenko wrote: > On Thu, Oct 5, 2017 at 9:16 PM, Srinivas Pandruvada > wrote: > > > > Added functionality to read LPIT table, which provides: > > > > - Sysfs interface to read residency counters via > > /sys/devices/system/cpu/cpuidle/low_power_idle_cpu

Re: [PATCH v4] Input: add support for the Samsung S6SY761 touchscreen

2017-10-05 Thread Rob Herring
On Tue, Sep 26, 2017 at 03:31:35PM +0900, Andi Shyti wrote: > The S6SY761 touchscreen is a capicitive multi-touch controller > for mobile use. It's connected with i2c at the address 0x48. > > This commit provides a basic version of the driver which can > handle only initialization, touch events an

[PATCH 0/2] Power Mac: Adjustments for five function implementations

2017-10-05 Thread SF Markus Elfring
From: Markus Elfring Date: Thu, 5 Oct 2017 22:48:22 +0200 Two update suggestions were taken into account from static source code analysis. Markus Elfring (2): Delete an error message for a failed memory allocation in kw_i2c_host_init() Improve a size determination in five functions arch/po

Re: [PATCH v2 01/10] pinctrl: move gpio-axp209 to pinctrl

2017-10-05 Thread Rob Herring
On Tue, Sep 26, 2017 at 02:17:11PM +0200, Quentin Schulz wrote: > To prepare the driver for the upcoming pinctrl features, move the GPIO > driver AXP209 from GPIO to pinctrl subsystem. > > Signed-off-by: Quentin Schulz > --- > Documentation/devicetree/bindings/gpio/gpio-axp209.txt | 30 +-

Re: [PATCH] Add Tecon Microprocessor Technologies, LLC vendor prefix

2017-10-05 Thread Rob Herring
On Tue, Sep 26, 2017 at 05:49:37PM +0300, dun...@tecon.ru wrote: > From: Dmitry Dunaev > > Signed-off-by: Dmitry Dunaev > --- > Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + > 1 file changed, 1 insertion(+) Applied.

Re: [PATCH v4 12/14] platform/x86: wmi: create character devices when requested by drivers

2017-10-05 Thread Darren Hart
On Thu, Oct 05, 2017 at 07:03:24PM +, mario.limoncie...@dell.com wrote: > > > > And how _exactly_ is this interface exposed in Windows? Is it ad-hoc > > with custom kernel drivers written by each vendor? Or does the OS > > provide a "sane" interface for it? > > On Windows it's a driver-less

[PATCH 1/2] powermac: Delete an error message for a failed memory allocation in kw_i2c_host_init()

2017-10-05 Thread SF Markus Elfring
From: Markus Elfring Date: Thu, 5 Oct 2017 22:30:29 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- arch/powerpc/platforms/powermac/low_i2c.c | 5 + 1 file changed, 1

<    2   3   4   5   6   7   8   9   10   >