Re: [PATCH V5 7/7] blk-mq-sched: don't dequeue request until all in ->dispatch are flushed

2017-10-03 Thread Christoph Hellwig
This looks good in general: Reviewed-by: Christoph Hellwig Minor nitpicks below: > const bool has_sched_dispatch = e && e->type->ops.mq.dispatch_request; This is now only tested once, so you can remove the local variable for it. > + /* > + * We may clear DISPATC

Re: [PATCH v2] arm64: dts: foundation-v8: Enable PSCI mode

2017-10-03 Thread Daniel Thompson
On 02/10/17 18:26, Sudeep Holla wrote: Sorry for late response, I thought I had sent this mail out long back but was sitting in my draft :( No worries. I've been at Linaro connect this last week anyway. On 20/09/17 12:17, Daniel Thompson wrote: On 20/09/17 10:42, Sudeep Holla wrote: On 1

Re: [PATCH V5 4/8] block: move actual bio merge code into __elv_merge

2017-10-03 Thread Christoph Hellwig
On Sat, Sep 30, 2017 at 07:26:51PM +0800, Ming Lei wrote: > So that we can reuse __elv_merge() to merge bio > into requests from sw queue in the following patches. > > No functional change. There are very few callers of elv_merge, just update the function with the new parameters instead of introd

Re: [PATCH V5 3/8] block: introduce rqhash helpers

2017-10-03 Thread Christoph Hellwig
Can yu get rid of the elv_rqhash in favour of these new ones instead of having that tinty indirection? Also the new helper should have some prefix - either keep elv_ or add blk_.

Re: [PATCH V5 5/8] block: add check on elevator for supporting bio merge via hashtable from blk-mq sw queue

2017-10-03 Thread Christoph Hellwig
On Sat, Sep 30, 2017 at 07:26:52PM +0800, Ming Lei wrote: > blk_mq_sched_try_merge() will be reused in following patches > to support bio merge to blk-mq sw queue, so add checkes to > related functions which are called from blk_mq_sched_try_merge(). The changes themselves look ok, but don't make s

Re: Build regressions/improvements in v4.14-rc3

2017-10-03 Thread Michael Ellerman
Geert Uytterhoeven writes: > Hi Thomas, > > On Mon, Oct 2, 2017 at 4:11 PM, Thomas Meyer wrote: >> On Mon, Oct 02, 2017 at 11:49:33AM +0200, Geert Uytterhoeven wrote: >>> Below is the list of build error/warning regressions/improvements in >>> v4.14-rc3[1] compared to v4.13[2]. >> >> a question

Re: [PATCH v3 12/12] ARM: dtsi: axp81x: set pinmux for GPIO0/1 when used as LDOs

2017-10-03 Thread Russell King - ARM Linux
On Tue, Oct 03, 2017 at 10:06:29AM +0800, Chen-Yu Tsai wrote: > On Tue, Oct 3, 2017 at 4:42 AM, Maxime Ripard > wrote: > > On Mon, Oct 02, 2017 at 12:08:54PM +, Quentin Schulz wrote: > >> On AXP813/818, GPIO0 and GPIO1 can be used as LDO as (respectively) > >> ldo_io0 and ldo_io1. > >> > >> Le

Re: [PATCH V5 6/8] block: introduce .last_merge and .hash to blk_mq_ctx

2017-10-03 Thread Christoph Hellwig
> +enum elv_merge elv_merge_ctx(struct request_queue *q, struct request **req, > + struct bio *bio, struct blk_mq_ctx *ctx) > +{ > + WARN_ON_ONCE(!q->mq_ops); > + return __elv_merge(q, req, bio, ctx->hash, ctx->last_merge); > +} This function only has a single caller, just open

Re: [PATCH V5 7/8] blk-mq-sched: refactor blk_mq_sched_try_merge()

2017-10-03 Thread Christoph Hellwig
> +bool blk_mq_sched_try_merge(struct request_queue *q, struct bio *bio, > + struct request **merged_request) > +{ > + struct request *rq; > + enum elv_merge type = elv_merge(q, &rq, bio); > + > + return __blk_mq_try_merge(q, bio, merged_request, rq, type); > +} > EXPORT_SY

[PATCH 0/1] virt: Add vboxguest driver for Virtual Box Guest integration

2017-10-03 Thread Hans de Goede
Hi All, Here is my first non RFC submission of my cleaned up version of the VirtualBox vboxguest driver. VirtualBox upstream has declared the ioctl API for the /dev/vboxguest device as being stable now, so once this passes review this is ready for merging. I'm only submitting the vboxguest drive

Re: [PATCH V5 8/8] blk-mq: improve bio merge from blk-mq sw queue

2017-10-03 Thread Christoph Hellwig
This looks generally good to me, but I really worry about the impact on very high iops devices. Did you try this e.g. for random reads from unallocated blocks on an enterprise NVMe SSD?

Re: [PATCH v3 4/8] platform/x86: wmi: create character devices when requested by drivers

2017-10-03 Thread Greg KH
On Wed, Sep 27, 2017 at 11:02:16PM -0500, Mario Limonciello wrote: > For WMI operations that are only Set or Query read or write sysfs > attributes created by WMI vendor drivers make sense. > > For other WMI operations that are run on Method, there needs to be a > way to guarantee to userspace tha

Re: [PATCH v3 4/8] platform/x86: wmi: create character devices when requested by drivers

2017-10-03 Thread Greg KH
On Wed, Sep 27, 2017 at 11:02:16PM -0500, Mario Limonciello wrote: > For WMI operations that are only Set or Query read or write sysfs > attributes created by WMI vendor drivers make sense. > > For other WMI operations that are run on Method, there needs to be a > way to guarantee to userspace tha

Re: [PATCH v3] mm, sysctl: make NUMA stats configurable

2017-10-03 Thread Michal Hocko
On Thu 28-09-17 14:11:41, Kemi Wang wrote: > This is the second step which introduces a tunable interface that allow > numa stats configurable for optimizing zone_statistics(), as suggested by > Dave Hansen and Ying Huang. > > ===

Re: [PATCH] MAINTAINERS: Add dri-devel as a mailing list for anything fbdev

2017-10-03 Thread Daniel Vetter
On Mon, Oct 02, 2017 at 10:29:26AM +0200, Daniel Vetter wrote: > On Fri, Sep 08, 2017 at 11:39:44AM -0400, Sean Paul wrote: > > On Fri, Sep 8, 2017 at 11:35 AM, Daniel Vetter > > wrote: > > > fbdev is in maintenance only, except that it's still used by drm > > > through the drm fbdev emulation, t

Re: [PATCH v2 5/5] drm/bridge/synopsys: dsi :remove is_panel_bridge

2017-10-03 Thread Emil Velikov
On 2 October 2017 at 10:34, Benjamin Gaignard wrote: > When using drm_of_panel_bridge_remove() we can simplify the > code and remove is_panel_bridge from dw_mipi_dsi structure. > As the previous patches remove the struct drm_bridge pointer, it might be worth mentioning why that cannot be done here

[PATCH] ARM: cache-l2x0-pmu: Delete an error message for a failed memory allocation in l2x0_pmu_init()

2017-10-03 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 3 Oct 2017 11:16:56 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- arch/arm/mm/cache-l2x0-pmu.c | 4 +--- 1 file changed, 1 insertion(+),

Re: [PATCH v3 5/8] platform/x86: dell-wmi-smbios: introduce character device for userspace

2017-10-03 Thread Greg KH
On Wed, Sep 27, 2017 at 11:02:17PM -0500, Mario Limonciello wrote: > +static int dell_wmi_smbios_open(struct inode *inode, struct file *file) > +{ > + return nonseekable_open(inode, file); > +} > + > +static int dell_wmi_smbios_release(struct inode *inode, struct file *file) > +{ > + return

Re: [PATCH v3 12/12] ARM: dtsi: axp81x: set pinmux for GPIO0/1 when used as LDOs

2017-10-03 Thread Linus Walleij
On Mon, Oct 2, 2017 at 2:08 PM, Quentin Schulz wrote: > On AXP813/818, GPIO0 and GPIO1 can be used as LDO as (respectively) > ldo_io0 and ldo_io1. (...) > + gpio0_ldo: gpio0_ldo { > + pins = "GPIO0"; > + function = "ldo"; > +

Re: Build regressions/improvements in v4.14-rc3

2017-10-03 Thread Thomas Meyer
On Tue, Oct 03, 2017 at 08:18:14PM +1100, Michael Ellerman wrote: > Geert Uytterhoeven writes: > > > Hi Thomas, > > > > On Mon, Oct 2, 2017 at 4:11 PM, Thomas Meyer wrote: > >> On Mon, Oct 02, 2017 at 11:49:33AM +0200, Geert Uytterhoeven wrote: > >>> Below is the list of build error/warning regr

[PATCH v10 0/4] Add Rockchip RGA V4l2 support

2017-10-03 Thread Jacob Chen
This patch series add a v4l2 m2m drvier for rockchip RGA direct rendering based 2d graphics acceleration module. change in V10: - move to rockchip/rga - changes according to comments - some style changes change in V9: - remove protduff things - test with the latest v4l2-compliance change in V8:

Re: [PATCH] HID: i2c-hid: Allow ACPI systems to specify "post-power-on-delay-ms"

2017-10-03 Thread Andy Shevchenko
+ Cc: Jarkko, he spent a lot of nice hours to debug i2c HID touchscreen devices on x86 ACPI enabled platforms, so, he might have a better idea or some comments. On Mon, 2017-10-02 at 14:32 -0700, Rajat Jain wrote: > The property "post-power-on-delay-ms"" allows a platform to specify > the delay ne

[PATCH v10 4/4] dt-bindings: Document the Rockchip RGA bindings

2017-10-03 Thread Jacob Chen
Add DT bindings documentation for Rockchip RGA Signed-off-by: Jacob Chen Signed-off-by: Yakir Yang Acked-by: Rob Herring --- .../devicetree/bindings/media/rockchip-rga.txt | 33 ++ 1 file changed, 33 insertions(+) create mode 100644 Documentation/devicetree/bindings/me

Re: [PATCH -v2 13/18] sched/fair: Propagate an effective runnable_load_avg

2017-10-03 Thread Dietmar Eggemann
On 03/10/17 09:50, Peter Zijlstra wrote: > On Mon, Oct 02, 2017 at 06:46:32PM +0100, Dietmar Eggemann wrote: > >>> +/* >>> + * Recomputes the group entity based on the current state of its group >>> + * runqueue. >>> + */ >>> +static void update_cfs_group(struct sched_entity *se) >> >> update_cfs_

[PATCH v10 3/4] arm64: dts: rockchip: add RGA device node for RK3399

2017-10-03 Thread Jacob Chen
This patch add the RGA dt config of RK3399 SoC. Signed-off-by: Jacob Chen Signed-off-by: Yakir Yang --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi

Re: usb/serial/visor: slab-out-of-bounds in palm_os_3_probe

2017-10-03 Thread Johan Hovold
On Fri, Sep 29, 2017 at 10:37:55AM +0200, Greg Kroah-Hartman wrote: > On Thu, Sep 28, 2017 at 07:57:46PM +0200, Andrey Konovalov wrote: > > Hi! > > > > I've got the following report while fuzzing the kernel with syzkaller. > > > > On commit dc972a67cc54585bd83ad811c4e9b6ab3dcd427e (4.14-rc2+). >

[PATCH v10 1/4] rockchip/rga: v4l2 m2m support

2017-10-03 Thread Jacob Chen
Rockchip RGA is a separate 2D raster graphic acceleration unit. It accelerates 2D graphics operations, such as point/line drawing, image scaling, rotation, BitBLT, alpha blending and image blur/sharpness The driver supports various operations from the rendering pipeline. - copy - fast solid colo

[PATCH v10 2/4] ARM: dts: rockchip: add RGA device node for RK3288

2017-10-03 Thread Jacob Chen
This patch add the RGA dt config of rk3288 SoC. Signed-off-by: Jacob Chen Signed-off-by: Yakir Yang --- arch/arm/boot/dts/rk3288.dtsi | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi index a0a0b08bff74..8c6dfc0abc42 1

Re: ce07a9415f ("locking/lockdep: Make check_prev_add() able to .."): BUG: unable to handle kernel NULL pointer dereference at 00000020

2017-10-03 Thread Ingo Molnar
Any progress with fixing this crash? I'll have to revert this commit otherwise. Thanks, Ingo * kernel test robot wrote: > Greetings, > > 0day kernel testing robot got the below dmesg and the first bad commit is > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git

Re: [BUGFIX PATCH] kprobes/x86: Remove IRQ disabling from jprobe handlers

2017-10-03 Thread Ingo Molnar
* Masami Hiramatsu wrote: > Jprobe actually doesn't need to disable IRQs while calling > handlers, because Documentation/kprobes.txt says: > > - > Probe handlers are run with preemption disabled. Depending on the > architecture and optimization state, handlers may also run with > interr

Re: [PATCH] MAINTAINERS: Add dri-devel as a mailing list for anything fbdev

2017-10-03 Thread Bartlomiej Zolnierkiewicz
On Tuesday, October 03, 2017 11:24:39 AM Daniel Vetter wrote: > On Mon, Oct 02, 2017 at 10:29:26AM +0200, Daniel Vetter wrote: > > On Fri, Sep 08, 2017 at 11:39:44AM -0400, Sean Paul wrote: > > > On Fri, Sep 8, 2017 at 11:35 AM, Daniel Vetter > > > wrote: > > > > fbdev is in maintenance only, exc

Re: i2c-omap.c vs. qemu: too much work in one irq (and broken boot)

2017-10-03 Thread Pavel Machek
Hi! > > > I'm trying to get qemu emulation of Nokia N900 to work, but > > > unfortunately i2c-omap.c breaks boot in the emulator (real hardware > > > works ok). > > > > I started bisection. v4.6 works, v4.7 is broken. (It still may be > > config difference or something). > > > > This looked susp

Re: [PATCH v2] drivers/ide/pci: Fix legacy IRQ assignment

2017-10-03 Thread Bartlomiej Zolnierkiewicz
On Monday, October 02, 2017 11:52:47 AM Lorenzo Pieralisi wrote: > Through struct pci_host_bridge->{map/swizzle}_irq() hooks is now > possible to define IRQ mapping functions on a per PCI host bridge basis. > > Actual IRQ allocation is carried out by the pci_assign_irq() function in > pci_device_p

Re: [PATCH] phy: rockchip-typec: Check for errors from tcphy_phy_init()

2017-10-03 Thread Kishon Vijay Abraham I
On Saturday 30 September 2017 04:08 PM, Guenter Roeck wrote: > On Fri, Sep 29, 2017 at 4:58 PM, Douglas Anderson > wrote: >> The function tcphy_phy_init() could return an error but the callers >> weren't checking the return value. They should. In at least one case >> while testing I saw the m

Re: [PATCH] KVM: VMX: check match table

2017-10-03 Thread Paolo Bonzini
On 01/10/2017 01:22, Nick Desaulniers wrote: > On Wed, Sep 27, 2017 at 02:36:03PM +0200, Paolo Bonzini wrote: >> On 26/09/2017 19:12, Josh Triplett wrote: >>> Does this make any other checks redundant and removable? >> >> It would make sense to place it in cpu_has_kvm_support instead > > cpu_has_k

Re: [PATCH] Add new uio device for PCI with dynamic memory allocation

2017-10-03 Thread Dan Carpenter
Looks good. A couple minor comments below. On Mon, Oct 02, 2017 at 03:02:09PM +, Stahl, Manuel wrote: > +static int open(struct uio_info *info, struct inode *inode) > +{ > + struct uio_pci_dmem_dev *priv = to_uio_pci_dmem_dev(info); > + struct uio_mem *uiomem; > + int ret = 0; > +

[PATCH] ASoC: codecs: msm8916-wcd-analog: fix module autoload

2017-10-03 Thread Nicolas Dechesne
If the driver is built as a module, autoload won't work because the module alias information is not filled. So user-space can't match the registered device with the corresponding module. Export the module alias information using the MODULE_DEVICE_TABLE() macro. Before this patch: $ modinfo snd_s

[PATCH] md-cluster: make function cluster_check_sync_size static

2017-10-03 Thread Colin King
From: Colin Ian King The function cluster_check_sync_size is local to the source and does not need to be in global scope, so make it static. Cleans up sparse warning: symbol 'cluster_check_sync_size' was not declared. Should it be static? Signed-off-by: Colin Ian King --- drivers/md/md-cluste

Re: [PATCH v2 2/7] drm/rockchip: dw_hdmi: add device type

2017-10-03 Thread Neil Armstrong
On 30/09/2017 03:43, Algea Cao wrote: > To determine type of SOC, we add a parameter dev_type. > > Signed-off-by: Algea Cao > --- > drivers/gpu/drm/rockchip/dw_hdmi-rockchip.c | 5 + > include/drm/bridge/dw_hdmi.h| 10 ++ > 2 files changed, 15 insertions(+) > > diff

[PATCH] mmc: dw_mmc-k3: make array hs_timing_cfg static

2017-10-03 Thread Colin King
From: Colin Ian King The array hs_timing_cfg is local to the source and does not need to be in global scope, so make it static. Cleans up sparse warning: symbol 'hs_timing_cfg' was not declared. Should it be static? Signed-off-by: Colin Ian King --- drivers/mmc/host/dw_mmc-k3.c | 2 +- 1 file

Re: [RESEND x2][PATCH 0/3] dwc2 fixes for edge cases on hikey

2017-10-03 Thread Minas Harutyunyan
On 9/30/2017 9:13 PM, John Youn wrote: > On 09/20/2017 12:57 PM, John Stultz wrote: >> So here are a few dwc2 fixes that I've been using with HiKey. >> I'm not totally sure these are all ideal, but they avoid edge case >> issues that we have been running into with switching between >> gadget mode a

Re: [RESEND x2][PATCH 2/3] usb: dwc2: Error out of dwc2_hsotg_ep_disable() if we're in host mode

2017-10-03 Thread Minas Harutyunyan
On 9/20/2017 11:57 PM, John Stultz wrote: > We've found that while in host mode, using Android, if one runs > the command: > stop adbd > > The existing usb devices being utilized in host mode are disconnected. > This is most visible with usb networking devices. > > This seems to be due to adbd cl

Re: [patch V2 22/29] lockup_detector: Make watchdog_nmi_reconfigure() two stage

2017-10-03 Thread Nicholas Piggin
On Tue, 3 Oct 2017 09:04:03 +0200 (CEST) Thomas Gleixner wrote: > On Tue, 3 Oct 2017, Thomas Gleixner wrote: > > On Tue, 3 Oct 2017, Michael Ellerman wrote: > > > Hi Thomas, > > > Unfortunately this is hitting the WARN_ON in start_wd_cpu() on powerpc > > > because we're calling it multiple time

Re: [RESEND x2][PATCH 3/3] usb: dwc2: Fix UDC state tracking

2017-10-03 Thread Minas Harutyunyan
On 9/20/2017 11:57 PM, John Stultz wrote: > It has been noticed that the dwc2 udc state reporting doesn't > seem to work (at least on HiKey boards). Where after the initial > setup, the sysfs /sys/class/udc/f72c.usb/state file would > report "configured" no matter the state of the OTG port. > >

Re: [PATCH] virt: Add vboxguest driver for Virtual Box Guest integration

2017-10-03 Thread Christoph Hellwig
Looks like you forgot to CC previous revierers. > +#define CHECK_IOCTL_IN(req) \ > +do { \ > + if ((req)->Hdr.cbIn != (sizeof((req)->Hdr) + sizeof((req)->u.In)) || \ > + (

Re: [kernel-hardening] [PATCH 0/3] Makefile: Introduce CONFIG_CC_STACKPROTECTOR_AUTO

2017-10-03 Thread Mark Rutland
Hi Kees, On Mon, Oct 02, 2017 at 12:20:04PM -0700, Kees Cook wrote: > As described in the final patch: > > Nearly all modern compilers support a stack-protector option, and nearly > all modern distributions enable the kernel stack-protector, so enabling > this by default in kernel builds would ma

[PATCH] mmc: sdhci-of-at91: make function sdhci_at91_set_uhs_signaling static

2017-10-03 Thread Colin King
From: Colin Ian King The function sdhci_at91_set_uhs_signaling is local to the source and does not need to be in global scope, so make it static. Cleans up sparse warning: symbol 'sdhci_at91_set_uhs_signaling' was not declared. Should it be static? Signed-off-by: Colin Ian King --- drivers/m

[PATCH 0/9] recovery robustness improvements

2017-10-03 Thread Hans Holmberg
From: Hans Holmberg This patchset improves the robustness of recovery - fixing a bunch of issues that occurs when removing and re-creating a pblk instance. It also adds a couple of debug-only prints to facilitate detection of L2P table corruptions. The patches apply on top of: https://github.com

[PATCH 9/9] lightnvm: pblk: correct valid lba count calculation

2017-10-03 Thread Hans Holmberg
From: Hans Holmberg During garbage collect, lbas being written can end up being invalidated. Make sure that this is reflected in the valid lba count. Signed-off-by: Hans Holmberg --- drivers/lightnvm/pblk-map.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/

[PATCH 4/9] lightnvm: pblk: start gc if needed during init

2017-10-03 Thread Hans Holmberg
From: Hans Holmberg Start GC, if needed, directly after init, as we might need to garbage collect to make room for user writes. Signed-off-by: Hans Holmberg --- drivers/lightnvm/pblk-init.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/lightnvm/pblk-init.c b/drivers/lightnvm/

[PATCH 8/9] lightnvm: pblk: gc all lines in the pipeline before exit

2017-10-03 Thread Hans Holmberg
From: Hans Holmberg Finish garbage collect of the lines that are in the gc pipeline before exiting. Ensure that all lines already in in the pipeline goes through, from read to write. Do this by keeping track of how many lines are in the pipeline and waiting for that number to reach zero before e

[PATCH 7/9] lightnvm: pblk: add l2p crc debug printouts

2017-10-03 Thread Hans Holmberg
From: Hans Holmberg Print the CRC of the logical-to-physical mapping during exit and after recovering the L2P table to facilitate detection of meta data corruption/recovery issues. The CRC printed after recovery should match the CRC printed during the previous exit - if it doesn't this indicates

RE: [PATCH 5/6] staging: fsl-dpaa2/ethsw: Add README

2017-10-03 Thread Razvan Stefanescu
> -Original Message- > From: linux-arm-kernel [mailto:linux-arm-kernel-boun...@lists.infradead.org] > On Behalf Of Andrew Lunn > Sent: Tuesday, September 19, 2017 3:18 PM > To: Razvan Stefanescu > Cc: de...@driverdev.osuosl.org; Ruxandra Ioana Radulescu > ; a...@arndb.de; gre...@linuxfound

[PATCH 3/9] lightnvm: pblk: free full lines during recovery

2017-10-03 Thread Hans Holmberg
From: Hans Holmberg When rebuilding the L2P table, any full lines(lines without any valid sectors) will be identified. If these lines are not freed, we risk not being able to allocate the first data line. This patch refactors the part of GC that frees empty lines into a separate function and add

[PATCH 6/9] lightnvm: pblk: shut down gc gracefully during exit

2017-10-03 Thread Hans Holmberg
From: Hans Holmberg Shut down the GC workqueues and tasks in the right order. Signed-off-by: Hans Holmberg --- drivers/lightnvm/pblk-gc.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/drivers/lightnvm/pblk-gc.c b/drivers/lightnvm/pblk-gc.c index 3740

[PATCH 5/9] lightnvm: pblk: consider bad sectors in emeta during recovery

2017-10-03 Thread Hans Holmberg
From: Hans Holmberg When recovering lines we need to consider that bad blocks in a line affects the emeta area size. Previously it was assumed that the emeta area would grow by the number of sectors per page * number of bad blocks in the line. This assumtion not correct - the number of "extra"

Re: [PATCH] ARM: cache-l2x0-pmu: Delete an error message for a failed memory allocation in l2x0_pmu_init()

2017-10-03 Thread Mark Rutland
On Tue, Oct 03, 2017 at 11:23:23AM +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 3 Oct 2017 11:16:56 +0200 > > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus El

[PATCH 2/9] lightnvm: pblk: recover partially written lines correctly

2017-10-03 Thread Hans Holmberg
From: Hans Holmberg When recovering partially written lines, the valid sector count must be decreased by the number of padded sectors in the line. Update line recovery to take all ADDR_EMPTY(padded) sectors into account. Signed-off-by: Hans Holmberg --- drivers/lightnvm/pblk-recovery.c | 8 ++

[PATCH 1/9] lightnvm: pblk: prevent gc kicks when gc is not operational

2017-10-03 Thread Hans Holmberg
From: Hans Holmberg GC can be kicked after it has been shut down when closing the last line during exit, resulting in accesses to freed structures. Make sure that GC is not triggered while it is not operational. Also make sure that GC won't be re-activated during exit when running on another pro

Re: [PATCH v2] arm64: dts: foundation-v8: Enable PSCI mode

2017-10-03 Thread Ard Biesheuvel
On 3 October 2017 at 10:12, Daniel Thompson wrote: > On 02/10/17 18:26, Sudeep Holla wrote: >> >> Sorry for late response, I thought I had sent this mail out long back >> but was sitting in my draft :( > > > No worries. I've been at Linaro connect this last week anyway. > > >> On 20/09/17 12:17, D

perf script : wrong symoff in callchain

2017-10-03 Thread Matthieu CASTET
Hi, while using perf on x86_64, I saw strange output for symoff. $ perf record -g -- sleep 1 $ perf script -F comm,tid,pid,time,ip,sym,dso,symoff [...] sleep 11656/11656 1045318.546436: 7fff9542e5b5 __d_lookup_rcu+0x80006ae02035 ([kernel.kallsyms]) 7fff9541e132 lookup_fa

[PATCH] ide: add missing hwif->portdev freeing on hwif_init() failure

2017-10-03 Thread Bartlomiej Zolnierkiewicz
Recent pci_assing_irq() changes uncovered a problem with missing freeing of ide_port class instance on hwif_init() failure in ide_host_register(): ide0: disabled, no IRQ ide0: failed to initialize IDE interface ide0: disabling port cmd64x :00:02.0: IDE controller (0x1095:0x0646 rev 0x07) CMD6

Re: [PATCH 1/9] lightnvm: pblk: prevent gc kicks when gc is not operational

2017-10-03 Thread Javier González
> On 3 Oct 2017, at 12.05, Hans Holmberg wrote: > > From: Hans Holmberg > > GC can be kicked after it has been shut down when closing the last > line during exit, resulting in accesses to freed structures. > > Make sure that GC is not triggered while it is not operational. > Also make sure tha

Re: [PATCH 2/9] lightnvm: pblk: recover partially written lines correctly

2017-10-03 Thread Javier González
> On 3 Oct 2017, at 12.05, Hans Holmberg wrote: > > From: Hans Holmberg > > When recovering partially written lines, the valid sector > count must be decreased by the number of padded sectors > in the line. > > Update line recovery to take all ADDR_EMPTY(padded) sectors > into account. > > Si

Re: [4.14-rc1 x86] WARNING: kernel stack regs at f60bbb12 in swapper:1 has bad 'bp' value 0ba00000

2017-10-03 Thread Tetsuo Handa
Tetsuo Handa wrote: > Tetsuo Handa wrote: > > Tetsuo Handa wrote: > > > I'm seeing below error between > > > 4898b99c261efe32 ("Merge tag 'acpi-4.13-rc7' of > > > git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm") (git > > > bisect good (presumably)) > > > e6f3faa734a00c60 ("locking/

Re: [PATCH v1 3/5] dt-bindings: Add DT bindings for NVIDIA Tegra AHB DMA controller

2017-10-03 Thread Jon Hunter
On 03/10/17 00:02, Dmitry Osipenko wrote: > On 02.10.2017 20:05, Stephen Warren wrote: >> On 09/29/2017 09:11 PM, Dmitry Osipenko wrote: >>> On 29.09.2017 22:30, Stephen Warren wrote: On 09/27/2017 02:34 AM, Jon Hunter wrote: > > On 27/09/17 02:57, Dmitry Osipenko wrote: >> On 26

Re: [PATCH 3/9] lightnvm: pblk: free full lines during recovery

2017-10-03 Thread Javier González
> On 3 Oct 2017, at 12.05, Hans Holmberg wrote: > > From: Hans Holmberg > > When rebuilding the L2P table, any full lines(lines without any > valid sectors) will be identified. If these lines are not freed, > we risk not being able to allocate the first data line. > > This patch refactors the

Re: [PATCH 4/9] lightnvm: pblk: start gc if needed during init

2017-10-03 Thread Javier González
> On 3 Oct 2017, at 12.05, Hans Holmberg wrote: > > From: Hans Holmberg > > Start GC, if needed, directly after init, as we might > need to garbage collect to make room for user writes. > > Signed-off-by: Hans Holmberg > --- > drivers/lightnvm/pblk-init.c | 4 > 1 file changed, 4 insertio

Re: [4.14-rc1 x86] WARNING: kernel stack regs at f60bbb12 in swapper:1 has bad 'bp' value 0ba00000

2017-10-03 Thread Borislav Petkov
On Tue, Oct 03, 2017 at 07:29:36PM +0900, Tetsuo Handa wrote: > Tetsuo Handa wrote: > > Tetsuo Handa wrote: > > > Tetsuo Handa wrote: > > > > I'm seeing below error between > > > > 4898b99c261efe32 ("Merge tag 'acpi-4.13-rc7' of > > > > git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm

Re: [PATCH 6/9] lightnvm: pblk: shut down gc gracefully during exit

2017-10-03 Thread Javier González
> On 3 Oct 2017, at 12.05, Hans Holmberg wrote: > > From: Hans Holmberg > > Shut down the GC workqueues and tasks in the right order. > > Signed-off-by: Hans Holmberg > --- > drivers/lightnvm/pblk-gc.c | 20 > 1 file changed, 12 insertions(+), 8 deletions(-) > > diff --gi

Re: [PATCH 5/9] lightnvm: pblk: consider bad sectors in emeta during recovery

2017-10-03 Thread Javier González
> On 3 Oct 2017, at 12.05, Hans Holmberg wrote: > > From: Hans Holmberg > > When recovering lines we need to consider that bad blocks in a line > affects the emeta area size. > > Previously it was assumed that the emeta area would grow by the > number of sectors per page * number of bad blocks

[PATCH] net: dsa: lan9303: make functions lan9303_mdio_phy_{read|write} static

2017-10-03 Thread Colin King
From: Colin Ian King The functions lan9303_mdio_phy_write and lan9303_mdio_phy_read are local to the source and do not need to be in global scope, so make them static. Cleans up sparse warnings: symbol 'lan9303_mdio_phy_write' was not declared. Should it be static? symbol 'lan9303_mdio_phy_read'

Re: [PATCH 7/9] lightnvm: pblk: add l2p crc debug printouts

2017-10-03 Thread Javier González
> On 3 Oct 2017, at 12.05, Hans Holmberg wrote: > > From: Hans Holmberg > > Print the CRC of the logical-to-physical mapping during exit and > after recovering the L2P table to facilitate detection of meta > data corruption/recovery issues. > > The CRC printed after recovery should match the C

Re: [PATCH 8/9] lightnvm: pblk: gc all lines in the pipeline before exit

2017-10-03 Thread Javier González
> On 3 Oct 2017, at 12.05, Hans Holmberg wrote: > > From: Hans Holmberg > > Finish garbage collect of the lines that are in the gc pipeline > before exiting. Ensure that all lines already in in the pipeline > goes through, from read to write. > > Do this by keeping track of how many lines are

Re: perf script : wrong symoff in callchain

2017-10-03 Thread Adrian Hunter
On 03/10/17 13:19, Matthieu CASTET wrote: > Hi, > > while using perf on x86_64, I saw strange output for symoff. > > $ perf record -g -- sleep 1 > $ perf script -F comm,tid,pid,time,ip,sym,dso,symoff > > [...] > sleep 11656/11656 1045318.546436: > 7fff9542e5b5 __d_lookup_rcu+0x80006

Re: [PATCH 9/9] lightnvm: pblk: correct valid lba count calculation

2017-10-03 Thread Javier González
> On 3 Oct 2017, at 12.05, Hans Holmberg wrote: > > From: Hans Holmberg > > During garbage collect, lbas being written can end up > being invalidated. Make sure that this is reflected in > the valid lba count. > > Signed-off-by: Hans Holmberg > --- > drivers/lightnvm/pblk-map.c | 7 --- >

[PATCH v2 0/4] staging: ccree: logging related coding style fixes

2017-10-03 Thread Gilad Ben-Yossef
The following patch set cleans up some code and builds upon this to replace ccree custom logging macros with the generic device dev_* facilities, handles the resulting fallout and further simplifies handling of memory and allocation OOM error handling code path exposed by checkpatch following the c

Re: [PATCH v2 4/4] Make all print functions receive the fp argument, and opens a dump file in process_event.

2017-10-03 Thread Jiri Olsa
On Tue, Sep 26, 2017 at 02:53:17PM +0800, yuzhoujian wrote: SNIP > - perf_event__fprintf(event, stdout); > + fp = tool->per_event_dump ? per_event_dump_file : stdout; > + fprint_sample_start(sample, thread, evsel, fp); > + perf_event__fprintf(event, fp); > thread__put(thread

[PATCH v2 1/4] staging: ccree: remove sysfs if of deleted code

2017-10-03 Thread Gilad Ben-Yossef
The ccree cycle count mechanism was removed in commit 7f821f0c6ffa ("staging: ccree: remove cycle count debug support") but the sysfs interface lingered on. Remove it now. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_sysfs.c | 266 -- 1 file c

[PATCH 09/11] xtensa: make dma_cache_sync a no-op

2017-10-03 Thread Christoph Hellwig
xtensa does not implement DMA_ATTR_NON_CONSISTENT allocations, so it doesn't make any sense to do any work in dma_cache_sync given that it must be a no-op when dma_alloc_attrs returns coherent memory. Signed-off-by: Christoph Hellwig --- arch/xtensa/include/asm/dma-mapping.h | 6 -- arch/xt

[PATCH 10/11] sh: make dma_cache_sync a no-op

2017-10-03 Thread Christoph Hellwig
sh does not implement DMA_ATTR_NON_CONSISTENT allocations, so it doesn't make any sense to do any work in dma_cache_sync given that it must be a no-op when dma_alloc_attrs returns coherent memory. On the other hand sh uses dma_cache_sync internally in the dma_ops implementation and for the maple b

[PATCH 06/11] mn10300: make dma_cache_sync a no-op

2017-10-03 Thread Christoph Hellwig
mn10300 does not implement DMA_ATTR_NON_CONSISTENT allocations, so it doesn't make any sense to do any work in dma_cache_sync given that it must be a no-op when dma_alloc_attrs returns coherent memory. Signed-off-by: Christoph Hellwig --- arch/mn10300/include/asm/dma-mapping.h | 4 1 file c

[PATCH 07/11] powerpc: make dma_cache_sync a no-op

2017-10-03 Thread Christoph Hellwig
powerpc does not implement DMA_ATTR_NON_CONSISTENT allocations, so it doesn't make any sense to do any work in dma_cache_sync given that it must be a no-op when dma_alloc_attrs returns coherent memory. Signed-off-by: Christoph Hellwig --- arch/powerpc/include/asm/dma-mapping.h | 2 -- 1 file cha

[PATCH 11/11] dma-mapping: turn dma_cache_sync into a dma_map_ops method

2017-10-03 Thread Christoph Hellwig
After we removed all the dead wood it turns out only two architectures actually implement dma_cache_sync as a real op: mips and parisc. Add a cache_sync method to struct dma_map_ops and implement it for the mips defualt DMA ops, and the parisc pa11 ops. Note that arm, arc and openrisc support DMA

[PATCH v2 2/4] staging: ccree: simplify access to struct device

2017-10-03 Thread Gilad Ben-Yossef
Introduce a function to retrieve struct device from private data structure in preparation to replacing custom logging macros with proper dev_dbg and friends which require struct device. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_aead.c| 11 --- drivers/staging/ccre

Re: [PATCH v2 4/4] Make all print functions receive the fp argument, and opens a dump file in process_event.

2017-10-03 Thread Jiri Olsa
On Tue, Sep 26, 2017 at 02:53:17PM +0800, yuzhoujian wrote: SNIP > - fprint_sample_start(sample, thread, evsel, stdout); > + /* the dump file name is NAME>-script-dump-.txt */ > + evname = perf_evsel__name(evsel); > + if (script->tool.per_event_dump) { > + if (asprint

Re: [PATCH 2/4] staging: ccree: simplify access to struct device

2017-10-03 Thread Gilad Ben-Yossef
On Mon, Oct 2, 2017 at 1:00 PM, Joe Perches wrote: > On Mon, 2017-10-02 at 10:03 +0100, Gilad Ben-Yossef wrote: >> Introduce a DEV macro to retrieve struct device from private >> data structure in preparation to replacing custom logging >> macros with proper dev_dbg and friends which require struc

[PATCH 08/11] unicore32: make dma_cache_sync a no-op

2017-10-03 Thread Christoph Hellwig
unicore32 does not implement DMA_ATTR_NON_CONSISTENT allocations, so it doesn't make any sense to do any work in dma_cache_sync given that it must be a no-op when dma_alloc_attrs returns coherent memory. Signed-off-by: Christoph Hellwig --- arch/unicore32/include/asm/cacheflush.h | 9 -

Re: [PATCH v2 4/4] Make all print functions receive the fp argument, and opens a dump file in process_event.

2017-10-03 Thread Jiri Olsa
On Tue, Sep 26, 2017 at 02:53:17PM +0800, yuzhoujian wrote: SNIP > + fprintf(fp, "%16" PRIx64, sample->phys_addr); > + fprintf(fp, "\n"); > + if (script->tool.per_event_dump) > + fclose(fp); > } > > static struct scripting_ops *scripting_ops; > @@ -1574,6 +158

[PATCH 01/11] floppy: consolidate the dummy fd_cacheflush definition

2017-10-03 Thread Christoph Hellwig
Only mips defines this helper, so remove all the other arch definitions. Signed-off-by: Christoph Hellwig --- arch/alpha/include/asm/floppy.h| 2 -- arch/powerpc/include/asm/floppy.h | 2 -- arch/sparc/include/asm/floppy_32.h | 1 - arch/sparc/include/asm/floppy_64.h | 1 - drivers/block/fl

[PATCH 05/11] microblaze: make dma_cache_sync a no-op

2017-10-03 Thread Christoph Hellwig
microblaze does not implement DMA_ATTR_NON_CONSISTENT allocations, so it doesn't make any sense to do any work in dma_cache_sync given that it must be a no-op when dma_alloc_attrs returns coherent memory. This also allows moving __dma_sync out of the microblaze asm/dma-mapping.h and thus greatly r

[PATCH 04/11] ia64: make dma_cache_sync a no-op

2017-10-03 Thread Christoph Hellwig
ia64 does not implement DMA_ATTR_NON_CONSISTENT allocations, so it doesn't make any sense to do any work in dma_cache_sync given that it must be a no-op when dma_alloc_attrs returns coherent memory. Signed-off-by: Christoph Hellwig --- arch/ia64/include/asm/dma-mapping.h | 5 - 1 file change

[PATCH 02/11] x86: make dma_cache_sync a no-op

2017-10-03 Thread Christoph Hellwig
x86 does not implement DMA_ATTR_NON_CONSISTENT allocations, so it doesn't make any sense to do any work in dma_cache_sync given that it must be a no-op when dma_alloc_attrs returns coherent memory. Signed-off-by: Christoph Hellwig Reviewed-by: Thomas Gleixner --- arch/x86/include/asm/dma-mappin

[PATCH] net: dsa: mt7530: make functions mt7530_phy_write static

2017-10-03 Thread Colin King
From: Colin Ian King The function mt7530_phy_write is local to the source and does not need to be in global scope, so make it static. Cleans up sparse warnings: symbol 'mt7530_phy_write' was not declared. Should it be static? Signed-off-by: Colin Ian King --- drivers/net/dsa/mt7530.c | 3 ++-

refactor dma_cache_sync V2

2017-10-03 Thread Christoph Hellwig
The dma_cache_sync routines is used to flush caches for memory returned by dma_alloc_attrs with the DMA_ATTR_NON_CONSISTENT flag (or previously from dma_alloc_noncoherent), but the requirements for it seems to be frequently misunderstood. dma_cache_sync is documented to be a no-op for allocations

[PATCH 03/11] frv: make dma_cache_sync a no-op

2017-10-03 Thread Christoph Hellwig
frv does not implement DMA_ATTR_NON_CONSISTENT allocations, so it doesn't make any sense to do any work in dma_cache_sync given that it must be a no-op when dma_alloc_attrs returns coherent memory. Signed-off-by: Christoph Hellwig --- arch/frv/include/asm/dma-mapping.h | 1 - 1 file changed, 1 d

[PATCH v2 3/4] staging: ccree: move to generic device log infra

2017-10-03 Thread Gilad Ben-Yossef
Move over from using macro wrappers around to printk to dev_err, dev_dbg and friends and clean up resulting fallout. Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_aead.c| 226 ++ drivers/staging/ccree/ssi_buffer_mgr.c | 394 +++

[PATCH v2 4/4] staging: ccree: simplify OOM handling

2017-10-03 Thread Gilad Ben-Yossef
Simplify handling of memory allocation failures and remove redundant log messages Signed-off-by: Gilad Ben-Yossef --- drivers/staging/ccree/ssi_cipher.c | 11 -- drivers/staging/ccree/ssi_driver.c | 1 - drivers/staging/ccree/ssi_hash.c | 42 +---

Re: [v9 2/5] mm: implement mem_cgroup_scan_tasks() for the root memory cgroup

2017-10-03 Thread Michal Hocko
On Wed 27-09-17 14:09:33, Roman Gushchin wrote: > Implement mem_cgroup_scan_tasks() functionality for the root > memory cgroup to use this function for looking for a OOM victim > task in the root memory cgroup by the cgroup-ware OOM killer. > > The root memory cgroup should be treated as a leaf cg

Re: [PATCH] x86/CPU/AMD, mm: Extend with mem_encrypt=sme option

2017-10-03 Thread Paolo Bonzini
On 02/10/2017 17:07, Brijesh Singh wrote: > > > Yep, that will work just fine. There are couple of ways we can limit > hypervisor from creating the SEV guest 1) clear the X86_FEATURE_SEV bit > when mem_encrypt=sme is passed or 2) parse the mem_encrypt=xxx in > kvm-amd.ko > and fail the KVM_SEV_IN

<    1   2   3   4   5   6   7   8   9   10   >