On Fri 2017-09-29 18:45:19, tristram...@microchip.com wrote:
> > > > > > Similar code will be needed by other drivers, right?
> > > > >
> > > > > Although KSZ8795 and KSZ8895 may use the same code, the other
> > > > > chips will have different code.
> > > >
> > > > Ok, please make sure code is shar
Remove unnecessary comments which are there
to explain why call to memset is in comments. Both of the
comments are not needed as they are not very useful.
Signed-off-by: Shreeya Patel
---
Changes in v2:
-Remove some more unnecessary comments and make the
commit message more appropriate.
C
This looks very convoluted, mostly because the existing code is
doing weird things. For one thing what is sq_dma_addr currently
is not a DMA adddress - we either need the resource address
for the ioremap, but we don't need to stash that away, and second
the one programmed into the controller shoul
On Sun, 2017-10-01 at 09:42 +1100, Tobin C. Harding wrote:
> On Sat, Sep 30, 2017 at 07:41:11PM +0530, Shreeya Patel wrote:
> >
> > Remove unnecessary comments which are there
> > to explain why call to memset is in comments. Both of the
> > comments are not needed as they are not very useful.
> >
Can you please start with an explanation of the problem in text and
cut down the cycle of involved functions to those actually relevant?
That'll make reviewing the patch a bit easier..
> 2 files changed, 48 insertions(+), 2 deletions(-)
> diff --git a/drivers/pci/pcie/aer/aerdrv.h b/drivers/pci
While this looks okay-ish to me I really don't want people confused
with three variants of add_disk, we really need to consolidate
our helpers there a bit..
On Wed, Sep 27, 2017 at 11:23:52AM +0100, Robin Murphy wrote:
> > I found that debug_dma_alloc_coherent() and debug_dma_free_coherent()
> > assume that dma_alloc_coherent() always returns a linear address.
> > However it's possible that dma_alloc_coherent() returns a non-linear
> > address. In this
On Wed, Sep 27, 2017 at 10:15:10AM -0600, Ross Zwisler wrote:
> Well, I don't know if platforms that support HMAT + PMEM are widely available,
> but we have all the details in the ACPI spec, so we could begin to code it up
> and things will "just work" when platforms arrive.
Then again currently a
On Tue, Sep 26, 2017 at 11:11:55AM -0700, Dan Williams wrote:
> I think we'll always need an explicit override available, but yes we
> need to think about what the override looks like in the context of a
> kernel that is able to automatically pick the right I/O policy
> relative to the media type.
Looks fine,
Reviewed-by: Christoph Hellwig
On Wed, Sep 27, 2017 at 07:32:20PM -0400, Nicolas Pitre wrote:
> To distinguish between both access types, the cramfs_physmem filesystem
> type must be specified when using a memory accessible cramfs image, and
> the physaddr argument must provide the actual filesystem image's physical
> memory loc
up_read(&mm->mmap_sem) in the fault path is a still a complete
no-go,
NAK
On Sat, Sep 30, 2017 at 4:29 AM, Darren Hart wrote:
> On Wed, Sep 27, 2017 at 11:02:15PM -0500, Mario Limonciello wrote:
>> The Dell WMI descriptor check is used as an indication that WMI
>> calls are safe to run both when used with the notification
>> ASL/GUID pair as well as the SMBIOS calling A
On Sat, Sep 30, 2017 at 5:10 AM, Darren Hart wrote:
> On Wed, Sep 27, 2017 at 11:02:18PM -0500, Mario Limonciello wrote:
>> Currently userspace tools can access system tokens via the dcdbas
>> kernel module and a SMI call that will cause the platform to execute
>> SMM code.
>>
>> With a goal in mi
On Wed, Sep 27, 2017 at 10:13:51AM -0700, Dan Williams wrote:
> As far as I can see "Offset can be greater than PAGE_SIZE" is the only
> safe assumption for core code.
It seems completely bogus to me, but if it is the current assumption
we'll have to document it. But this brings me back to that
o
Hi!
> > There is some interest. I'd like to have working bluetooth, and people
> from postmarketos
> > would probably like something, too. Unfortunately my experience is same as
> yours -- current
> > mainline does not work well on N900.
>
> I might try debugging that at some point, but I do
> - task_active_pid_ns(current)->last_pid);
> + task_active_pid_ns(current)->idr.idr_next-1);
I think we want a well documented helper for this pattern instead
of poking into the internals.
Also is last - 1 always the correct answer? Even with idr_alloc_cyclic
we could wr
Linus,
please pull the latest core-urgent-for-linus git tree from:
git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git
core-urgent-for-linus
Two small fixes for objtool:
- Support frame pointer setup via 'lea (%rsp), %rbp' which was not yet
supported and caused build warnings
-
On Mon, Sep 18, 2017 at 7:00 PM, Lyude Paul wrote:
> Reviewed-by: Lyude Paul
>
> On Fri, 2017-09-15 at 15:20 +0200, Benjamin Berg wrote:
>> Many thinkpad laptops and convertibles provide the GMMS method to
>> resolve how far the laptop has been opened and whether it has been
>> converted into tab
Linus,
please pull the latest irq-urgent-for-linus git tree from:
git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git
irq-urgent-for-linus
This pull request provides the following fixes:
- Add a missing NULL pointer check in free_irq()
- Fix a memory leak/memory corruption in the
Hi!
I inserted u-SD card, only to realize that it is not detected as it
should be. And dmesg indeed reveals:
[10994.299846] mmc0: new high speed SDHC card at address 0003
[10994.302196] kworker/2:1: page allocation failure: order:4,
mode:0x16040c0(GFP_KERNEL|__GFP_COMP|__GFP_NOTRACK), nodemask=(n
Linus,
please pull the latest locking-urgent-for-linus git tree from:
git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git
locking-urgent-for-linus
Two fixes for locking:
- Plug a hole the pi_stat->owner serialization which was changed recently
and failed to fixup two usage sites
Linus,
please pull the latest perf-urgent-for-linus git tree from:
git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git
perf-urgent-for-linus
This update contains the following:
- Prevent a division by zero in the perf aux buffer handling.
- Sync kernel headers with perf tool header
Linus,
please pull the latest sched-urgent-for-linus git tree from:
git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git
sched-urgent-for-linus
The scheduler pull request comes with the following updates:
- Prevent a divide by zero issue by validating the input value of
sysctl_sc
Linus,
please pull the latest smp-urgent-for-linus git tree from:
git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git
smp-urgent-for-linus
This update addresses the fallout of the new lockdep mechanism which covers
completions in the CPU hotplug code. The lockdep splats are false
posit
Linus,
please pull the latest timers-urgent-for-linus git tree from:
git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git
timers-urgent-for-linus
This adds a new timer wheel function which is required for the conversion
of the timer callback function from the 'unsigned long data' argumen
Added device tree binding documentation for Nuvoton NPCM7xx timer.
Signed-off-by: Tomer Maimon
---
.../bindings/timer/nuvoton,npcm7xx-timer.txt | 25 ++
1 file changed, 25 insertions(+)
create mode 100644
Documentation/devicetree/bindings/timer/nuvoton,npcm7xx-timer.t
Add Nuvoton BMC NPCM7xx timer driver.
Signed-off-by: Tomer Maimon
---
drivers/clocksource/Kconfig | 9 ++
drivers/clocksource/Makefile| 1 +
drivers/clocksource/npcm7xx_timer.c | 205
3 files changed, 215 insertions(+)
create mode 100644
This patch set adds clocksource support for the Nuvoton NPCM7xx Baseboard
Management Controller (BMC).
The clocksource Enable 24-bit TIMER0 and TIMER1 counters in the NPCM7xx BMC,
while TIMER0 serves as clockevent and TIMER1 serves as clocksource.
clocksource patch set depand on approval of basic
On Fri, 29 Sep 2017 21:09:20 -0400
Brian Masney wrote:
> The driver explicitly creates the in_illuminance0_integration_time sysfs
> attribute outside the IIO core. This attribute is available in the IIO
> core so this patches migrates the attribute to be created by
> the iio_chan_spec.
>
> Signe
On Fri, 29 Sep 2017 21:09:19 -0400
Brian Masney wrote:
> The length of the 'tsl2x7x_settings' variable within the tsl2X7X_chip
> structure makes some of the line lengths greater than 80 characters for
> upcoming patches. This patch shortens the name of the 'tsl2x7x_settings'
> variable in this st
On Fri, 29 Sep 2017 21:09:21 -0400
Brian Masney wrote:
> The sysfs attributes in_intensity0_thresh_period and
> in_proximity0_thresh_period are currently directly created by the driver.
> This patch migrates the creation of these sysfs attributes from the driver
> to using the IIO core via iio_ev
Linus,
please pull the latest x86-urgent-for-linus git tree from:
git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git
x86-urgent-for-linus
This update contins the following fixes and improvements
- Avoid dereferencing an unprotected VMA pointer in the fault signal
generation cod
When I was supporting Rpi Camera Module on the ASUS Tinker board,
I found this driver have some issues with rockchip's mipi-csi driver.
It didn't place clock lane in LP-11 state before performing
D-PHY initialisation.
>From our experience, on some OV sensors,
LP-11 state is not achieved while BIT(
ref docuemnt:
ov5647-datasheet-v1.00-2009
Signed-off-by: Jacob Chen
---
drivers/media/i2c/ov5647.c | 42 ++
1 file changed, 26 insertions(+), 16 deletions(-)
diff --git a/drivers/media/i2c/ov5647.c b/drivers/media/i2c/ov5647.c
index 247302d01f53..34179d
Hi!
> I inserted u-SD card, only to realize that it is not detected as it
> should be. And dmesg indeed reveals:
Tetsuo asked me to report this to linux-mm.
But 2^4 is 16 pages, IIRC that can't be expected to work reliably, and
thus this sounds like MMC bug, not mm bug.
> [10994.299846] mmc0: n
On Sun, Sep 24, 2017 at 5:59 PM, Devid Antonio Floni
wrote:
> The ov5648 5-megapixel camera sensor from OmniVision supports up to 2592x1944
> resolution and MIPI CSI-2 interface. Output format is raw sRGB/Bayer with
> 10 bits per colour (SGRBG10_1X10).
>
> This patch is a port of ov5648 driver aft
Linus,
please consider to pull the latest core-watchdog-for-linus git tree from:
git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git
core-watchdog-for-linus
The watchdog (hard/softlockup detector) code is pretty much broken in its
current state. The patch series addresses this by remov
On Sun, Oct 1, 2017 at 2:45 PM, Christoph Hellwig wrote:
>> - task_active_pid_ns(current)->last_pid);
>> + task_active_pid_ns(current)->idr.idr_next-1);
>
> I think we want a well documented helper for this pattern instead
> of poking into the internals.
idr_get_cursor() ge
On 07/29/2017 04:02 PM, Felix Janda wrote:
> libc-compat.h aims to prevent symbol collisions between uapi and libc
> headers for each supported libc. This requires continuous coordination
> between them.
>
> The goal of this commit is to improve the situation for libcs (such as
> musl) which are n
The driver doesn't have a struct of_device_id table but supported devices
are registered via Device Trees. This is working on the assumption that a
I2C device registered via OF will always match a legacy I2C device ID and
that the MODALIAS reported will always be of the form i2c:.
But this could c
Pavel Machek wrote:
> Hi!
>
> > I inserted u-SD card, only to realize that it is not detected as it
> > should be. And dmesg indeed reveals:
>
> Tetsuo asked me to report this to linux-mm.
>
> But 2^4 is 16 pages, IIRC that can't be expected to work reliably, and
> thus this sounds like MMC bug,
On Sun, Oct 01, 2017 at 11:14:46AM +0100, Jonathan Cameron wrote:
> On Fri, 29 Sep 2017 21:09:21 -0400
> Brian Masney wrote:
>
> > The sysfs attributes in_intensity0_thresh_period and
> > in_proximity0_thresh_period are currently directly created by the driver.
> > This patch migrates the creatio
On Wed, 27 Sep 2017 18:22:58 +0200
Thierry Escande wrote:
> From: Gwendal Grignou
>
> Add driver to support older EC firmware that only support deprecated
> ec command. Rely on ACPI memory map register to access sensor
> information.
> Present same interface as the regular cros_ec sensor stack:
On Fri, 29 Sep 2017 16:52:26 +0200
Bartosz Golaszewski wrote:
> 2017-09-29 15:15 GMT+02:00 Lars-Peter Clausen :
> > On 09/28/2017 12:56 PM, Bartosz Golaszewski wrote:
> >> Switch to using the recently added interrupt simulator for dummy irqs.
> >>
> >> Signed-off-by: Bartosz Golaszewski
> >
On Sat, 2017-09-30 at 18:56 -0700, Linus Torvalds wrote:
> On Sep 30, 2017 18:33, "Eric W. Biederman" wrote:.
>
>
> That would require a task_work or another kind of work callback so that
> the writes of the xattr are not synchronous with the vfs callback
> correct?
>
>
> No, why?
>
> You sho
On Dienstag, 19. September 2017 14:27:11 CEST Jiri Olsa wrote:
> On Wed, Sep 06, 2017 at 03:54:51PM +0200, Milian Wolff wrote:
>
> SNIP
>
> > -struct inline_node *dso__parse_addr_inlines(struct dso *dso, u64 addr);
> > +// parse inlined frames for the given address
> > +struct inline_node *dso__p
On Dienstag, 19. September 2017 14:27:27 CEST Jiri Olsa wrote:
> On Wed, Sep 06, 2017 at 03:54:51PM +0200, Milian Wolff wrote:
> > The inlined frames use a fake symbol that is maintained by
> > inline_node which in turn is maintained by the dso->inlines tree.
> > This tree is always sorted by name.
Hi, the regression tracker here. What's the status of this issue? Was
the problem fixed? It seems nothing happened for more than 10 days -- or
did the discussion move somewhere else? Ciao, Thorsten
On 20.09.2017 02:30, Chuck Ebbert wrote:
> On Tue, 19 Sep 2017 16:51:06 +0100
> Marc Zyngier wrote:
Hi! Find below my first regression report for Linux 4.14. It lists 4
regressions I'm currently aware of (two of the reports are my own). I
skimmed LKML, bugzilla.kernel.org, but those were all I found that
looked worthy. And nobody pointed me to any regressions directly. Sigh.
Either we are doing r
On Sun, 2017-10-01 at 14:46 +0200, Thorsten Leemhuis wrote:
> Hi, the regression tracker here. What's the status of this issue? Was
> the problem fixed? It seems nothing happened for more than 10 days -- or
> did the discussion move somewhere else? Ciao, Thorsten
The commit was reverted last week
On Sun, Oct 1, 2017 at 12:31 PM, Andy Shevchenko
wrote:
> On Mon, Sep 18, 2017 at 7:00 PM, Lyude Paul wrote:
>> Reviewed-by: Lyude Paul
>>
>> On Fri, 2017-09-15 at 15:20 +0200, Benjamin Berg wrote:
>>> Many thinkpad laptops and convertibles provide the GMMS method to
>>> resolve how far the lapt
On Sat, Sep 30, 2017 at 01:53:02PM +0200, Borislav Petkov wrote:
> On Sat, Sep 30, 2017 at 01:29:03PM +0200, Adam Borowski wrote:
> > On Sat, Sep 30, 2017 at 01:11:37PM +0200, Borislav Petkov wrote:
> > > On Sat, Sep 30, 2017 at 04:05:16AM +0200, Adam Borowski wrote:
> Boot into -rc2+ and do as ro
This semantic patch detects duplicate arrays declared using BQ27XXX_DATA
within a single structure. It is currently specific to the file
drivers/power/supply/bq27xxx_battery.c.
Signed-off-by: Julia Lawall
---
scripts/coccinelle/api/battery.cocci | 161 +++
1 fi
Am 01.10.2017 um 08:01 schrieb Evgeniy Polyakov:
> Hi Jan, Greg
>
> Have you resolved issues with the patch (touch bit export and driver itself)?
> This driver lives outside the kernel quite for a while, do you need any help
> to resolve this?
>
I hope so. I've set up 4.14-rc1, changed my patche
On 01.10.2017 15:06, Yanko Kaneti wrote:
> On Sun, 2017-10-01 at 14:46 +0200, Thorsten Leemhuis wrote:
>> Hi, the regression tracker here. What's the status of this issue? Was
>> the problem fixed? It seems nothing happened for more than 10 days -- or
>> did the discussion move somewhere else? Ciao
For 4.15.
These are last set of cleanups, error path fixes most likely and also
some memory leak. Also removes stale symbols from lightnvm.h. In
addition remove exported symbols which are no where used (except
locally in core).
Everything is based on top of:
https://github.com/OpenChannelSSD/li
Signed-off-by: Rakesh Pandit
---
drivers/lightnvm/pblk-core.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/lightnvm/pblk-core.c b/drivers/lightnvm/pblk-core.c
index 1f8aa94..4ffd1d6 100644
--- a/drivers/lightnvm/pblk-core.c
+++ b/drivers/lightnvm/pblk-core.c
@@ -1053,7 +1053,6 @@ st
On Sat, Sep 30, 2017 at 07:26:57PM +, mario.limoncie...@dell.com wrote:
> I think what's Darren's most interested in is the that conceptually this is
> an approach you can agree with.
>
> "A WMI vendor driver binds to the WMI bus and requests the WMI bus to create
> a character device. The WM
We already pass the structure pointer so no need to pass the member.
Signed-off-by: Rakesh Pandit
---
drivers/lightnvm/pblk-rb.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/lightnvm/pblk-rb.c b/drivers/lightnvm/pblk-rb.c
index 05e6b2e..920ffac 100644
vblk isn't being used anyway and if we ever have a usecase we can
introduce this again. This makes the logic easier and removes
unnecessary checks.
Signed-off-by: Rakesh Pandit
---
drivers/lightnvm/core.c | 29 -
include/linux/lightnvm.h | 2 +-
2 files changed, 13
Not all exported symbols are being used outside core and there were
some stable entries in lightnvm.h
Signed-off-by: Rakesh Pandit
---
drivers/lightnvm/core.c | 129 +++
include/linux/lightnvm.h | 7 ---
2 files changed, 64 insertions(+), 72 deletio
While separating read and erase mempools in 22da65a1b pblk_g_rq_cache
was used two times to set aside memory both for erase and read
requests. Because same kmem cache is used repeatedly a single call to
kmem_cache_destroy wouldn't deallocate everything. Repeatedly doing
loading and unloading of p
Hello,
where i can found the patch in git.kernel.org ?
Best regards
Damian
Am Samstag, den 30.09.2017, 12:05 +0800 schrieb Wei Wang:
> This patch series enhances the existing virtio-balloon with the
> following
> new features:
> 1) fast ballooning: transfer ballooned pages between the guest and
If pblk_core_init fails lets destroy all global caches.
Signed-off-by: Rakesh Pandit
---
drivers/lightnvm/pblk-init.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/lightnvm/pblk-init.c b/drivers/lightnvm/pblk-init.c
index 519e5cf..9f39800 100644
--- a/drivers
On Sun, Oct 01, 2017 at 04:25:18PM +0300, Rakesh Pandit wrote:
> Not all exported symbols are being used outside core and there were
> some stable entries in lightnvm.h
>
If you can replace 'stable' with 'stale' both in subject or body while
picking up that would be great.
Regards,
On Mon, Sep 11, 2017 at 02:16:48PM -0500, Alan Tull wrote:
> Add new device tree bindings document for max1619 device
> including a new compatible string.
>
> Signed-off-by: Alan Tull
> Cc: Jean Delvare
> Cc: Guenter Roeck
> Cc: Rob Herring
> Cc: Mark Rutland
> Acked-by: Rob Herring
Applied
On Mon, Sep 11, 2017 at 02:16:49PM -0500, Alan Tull wrote:
> Add new device tree binding for max1619.
>
> Signed-off-by: Alan Tull
> Cc: Jean Delvare
> Cc: Guenter Roeck
> Cc: Rob Herring
> Cc: Mark Rutland
Applied to hwmon-next.
Thanks,
Guenter
> ---
> drivers/hwmon/max1619.c | 10 ++
On Fri, Sep 22, 2017 at 03:36:20PM +0100, Colin Ian King wrote:
> From: Colin Ian King
>
> Don't populate const array watchdog_minors on the stack, instead make it
> static. Makes the object code smaller by over 350 bytes:
>
> Before:
>text data bss dec hex filename
>
On Dienstag, 19. September 2017 14:27:19 CEST Jiri Olsa wrote:
> On Wed, Sep 06, 2017 at 03:54:51PM +0200, Milian Wolff wrote:
>
> SNIP
>
> > +void inlines__tree_insert(struct rb_root *tree, struct inline_node
> > *inlines) +{
> > + struct rb_node **p = &tree->rb_node;
> > + struct rb_node *p
Hello,
where i can found the patch in git.kernel.org ?
Am Samstag, den 30.09.2017, 12:05 +0800 schrieb Wei Wang:
> This patch series enhances the existing virtio-balloon with the
> following
> new features:
> 1) fast ballooning: transfer ballooned pages between the guest and
> host in
> chunks u
On Thu, Sep 28, 2017 at 02:11:43PM +0100, Sudeep Holla wrote:
> It's useful to know the maximum types of sensor supported by hwmon
> framework. It can be used to allocate some data structures when sorting
> the monitors based on their type.
>
> This will be used by scmi hwmon support.
>
> Cc: Gue
> -Original Message-
> From: Greg KH [mailto:gre...@linuxfoundation.org]
> Sent: Sunday, October 1, 2017 8:24 AM
> To: Limonciello, Mario
> Cc: dvh...@infradead.org; andy.shevche...@gmail.com; linux-
> ker...@vger.kernel.org; platform-driver-...@vger.kernel.org; l...@kernel.org;
> quasi...
On Thu, Sep 28, 2017 at 02:11:44PM +0100, Sudeep Holla wrote:
> Create a driver to add support for SoC sensors exported by the System
> Control Processor (SCP) via the System Control and Management Interface
> (SCMI). The supported sensor types is one of voltage, temperature,
> current, and power.
On Sat, Sep 23, 2017 at 08:44:15AM +0200, Christophe Jaillet wrote:
> Commit 2ca492e22cb7 has moved the call to 'kfifo_alloc()' from after the
> main 'if' statement to before it.
> But it has not updated the error handling paths accordingly.
>
> Fix all that:
>- if 'kfifo_alloc()' fails we can
On Thu, Sep 21, 2017 at 10:17:09AM -0700, hotran wrote:
> This patch supports xgene-hwmon v2 which uses the non-cachable memory
> as the PCC shared memory.
>
> Signed-off-by: Hoan Tran
Applied to hwmon-next.
Thanks,
Guenter
> ---
> drivers/hwmon/xgene-hwmon.c | 1 +
> 1 file changed, 1 insert
This series of patches completely reworks the way inline frames are handled.
Instead of querying for the inline nodes on-demand in the individual tools,
we now create proper callchain nodes for inlined frames. The advantages this
approach brings are numerous:
- less duplicated code in the individu
This also removes the symbol name from the srcline column,
more on this below.
This ensures we use the correct srcline, which could originate
from a potentially inlined function. The hist entries used to
query for the srcline based purely on the IP, which leads to
wrong results for inlined entries
Now that we have caches in place to speed up the process of finding
inlined frames and srcline information repeatedly, we can enable
this useful option by default.
Cc: Arnaldo Carvalho de Melo
Cc: David Ahern
Cc: Namhyung Kim
Cc: Peter Zijlstra
Cc: Yao Jin
Cc: Ingo Molnar
Suggested-by: Ingo
When no inlined frames could be found for a given address,
we did not store this information anywhere. That means we
potentially do the costly inliner lookup repeatedly for
cases where we know it can never succeed.
This patch makes dso__parse_addr_inlines always return a
valid inline_node. It will
On one hand this ensures that the memory is properly freed when
the DSO gets freed. On the other hand this significantly speeds up
the processing of the callchain nodes when lots of srclines are
requested. For one of my data files e.g.:
Before:
Performance counter stats for 'perf report -s srcli
Some of the code paths I introduced before returned too early
without running the code to handle a node's branch count.
By refactoring match_chain to only have one exit point, this
can be remedied.
Cc: Arnaldo Carvalho de Melo
Cc: David Ahern
Cc: Namhyung Kim
Cc: Peter Zijlstra
Cc: Yao Jin
Si
On Thu, Sep 21, 2017 at 10:17:10AM -0700, hotran wrote:
> As the PCC shared memory could be in IO region which doesn't
> support caching, this patch simply uses ioremap() for IO region.
>
> Signed-off-by: Hoan Tran
Applied to hwmon-next.
Thanks,
Guenter
> ---
> drivers/hwmon/xgene-hwmon.c | 1
The fake symbols we create for inlined frames will represent
different functions but can use the symbol start address. This leads
to issues when different inline branches all lead to the same
function.
Before:
~
$ perf report -s sym -i perf.inlining.data --inline --stdio -g function
...
The original patch that introduced inline frame output in the
various browsers used this suffix already. The new centralized
approach that uses fake symbols for inlined frames was missing
this approach so far.
Instead of changing the symbol name itself, we only print the
suffix where needed. This
Instead of showing the (repeated) DSO name of the non-inlined
frame, we now show the "(inlined)" suffix instead.
Before:
214f7 __hypot_finite (/usr/lib/libm-2.25.so)
ace3 hypot (/usr/lib/libm-2.25.so)
a4a std::__complex_abs
(/home/milian
Similar to the callstack frame matching, we also have to compare
the symbol name when sorting hist entries. The reason is twofold:
On one hand, multiple inlined functions will use the same symbol
start/end values of the parent, non-inlined symbol. As such, all
of these symbols often end up missing
When a callchain entry has no srcline available, we ended up
comparing the instruction pointer. I consider this to be not
too useful. Rather, I think we should group the entries by
function name, which this patch adds. For people who want to
split the data on the IP boundary, using `-g address` is
This is a preparation for the creation of real callchain entries
for inlined frames. The rest of the perf code uses the srcline
string. As such, using that also for the srcline API allows us
to simplify some of the upcoming code. Most notably, it will
allow us to cache the srcline for a given inlin
The inline_node structs are maintained by the new dso->inlines
tree. This in turn keeps ownership of the fake symbols and
srcline string representing an inline frame.
This tree is always sorted by name. All other entries of the symbol
beside the function name are unused for inline frames. The adva
This is a requirement to create real callchain entries for inlined
frames.
Since the list of inlines usually contains the target symbol too,
i.e. the location where the frames get inlined to, we alias that
symbol and reuse it as-is is. This ensures that other dependent
functionality keeps working,
The follow-up commits will make inline frames first-class citizens
in the callchain, thereby obsoleting all of this special code.
Cc: Arnaldo Carvalho de Melo
Cc: David Ahern
Cc: Namhyung Kim
Cc: Peter Zijlstra
Cc: Yao Jin
Signed-off-by: Milian Wolff
---
tools/perf/ui/browsers/hists.c | 18
On Tue, Sep 5, 2017 at 8:37 AM,
wrote:
> From: Kuppuswamy Sathyanarayanan
>
> This patch cleans up unnecessary free/alloc calls in ipc_plat_probe(),
> ipc_pci_probe() and ipc_plat_get_res() functions by using devm_*
> calls.
>
> This patch also adds proper error handling for failure cases in
> ip
This is mostly a preparation to enable the creation of
full callchain nodes for inline frames. Such frames will
reference the IP of the non-inlined frame, but hold the
symbol and srcline for an inlined location. As such, we
won't be able to query the srcline on-demand based on the
IP alone. Instead
On Tue, Sep 5, 2017 at 8:37 AM,
wrote:
> From: Kuppuswamy Sathyanarayanan
>
> Currently, we have lot of repetitive code in dependent device resource
> allocation and device creation handling code. This logic can be improved if
> we use MFD framework for dependent device creation. This patch adds
On Tue, Sep 5, 2017 at 8:37 AM,
wrote:
> From: Kuppuswamy Sathyanarayanan
>
> Hi All,
>
> Currently intel_pmc_ipc.c, intel_punit_ipc.c, intel_scu_ipc.c drivers
> implements the same IPC features.
> This code duplication could be avoided if we implement the IPC driver as a
> generic library and
On Tue, Sep 5, 2017 at 8:37 AM,
wrote:
> From: Kuppuswamy Sathyanarayanan
>
> Currently, update_no_reboot_bit() function implemented in this driver
> uses mutex_lock to protect its register updates. But this function is
> called with in atomic context in iTCO_wdt_start() and iTCO_wdt_stop()
> fun
Hi,
On Sun, Oct 01, 2017 at 11:01:33AM +0200, Pavel Machek wrote:
> Hi!
>
> > > There is some interest. I'd like to have working bluetooth, and people
> > from postmarketos
> > > would probably like something, too. Unfortunately my experience is same
> > as yours -- current
> > > mainline do
On Tue, Sep 5, 2017 at 8:37 AM,
wrote:
> From: Kuppuswamy Sathyanarayanan
>
> Currently intel_scu_ipc.c, intel_pmc_ipc.c and intel_punit_ipc.c
> redundantly implements the same IPC features and has lot of code
> duplication between them. This driver addresses this issue by grouping
> the common I
Hi,
On Sat, Sep 23, 2017 at 09:08:38PM +0200, Pavel Machek wrote:
>
> Kilo should be "k" not "K", fix it it comments and messages.
>
> Signed-off-by: Pavel Machek
Thanks, queued.
-- Sebastian
> index 88e48b3..41a09f5 100644
> --- a/drivers/hsi/controllers/omap_ssi_core.c
> +++ b/drivers/hsi/
1 - 100 of 255 matches
Mail list logo
